Fix: snapshot command mishandles missing arguments
[lttng-tools.git] / src / bin / lttng / commands / snapshot.c
1 /*
2 * Copyright (C) 2013 - David Goulet <dgoulet@efficios.com>
3 *
4 * This program is free software; you can redistribute it and/or modify it
5 * under the terms of the GNU General Public License, version 2 only, as
6 * published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but WITHOUT
9 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
11 * more details.
12 *
13 * You should have received a copy of the GNU General Public License along with
14 * this program; if not, write to the Free Software Foundation, Inc., 51
15 * Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
16 */
17
18 #define _LGPL_SOURCE
19 #include <assert.h>
20 #include <inttypes.h>
21 #include <popt.h>
22 #include <stdio.h>
23 #include <stdlib.h>
24 #include <string.h>
25 #include <sys/stat.h>
26 #include <sys/types.h>
27 #include <unistd.h>
28 #include <assert.h>
29
30 #include <common/utils.h>
31 #include <common/mi-lttng.h>
32 #include <lttng/snapshot.h>
33
34 #include "../command.h"
35
36 static const char *opt_session_name;
37 static const char *opt_output_name;
38 static const char *opt_data_url;
39 static const char *opt_ctrl_url;
40 static const char *current_session_name;
41 static uint64_t opt_max_size;
42
43 /* Stub for the cmd struct actions. */
44 static int cmd_add_output(int argc, const char **argv);
45 static int cmd_del_output(int argc, const char **argv);
46 static int cmd_list_output(int argc, const char **argv);
47 static int cmd_record(int argc, const char **argv);
48
49 static const char *indent4 = " ";
50
51 #ifdef LTTNG_EMBED_HELP
52 static const char help_msg[] =
53 #include <lttng-snapshot.1.h>
54 ;
55 #endif
56
57 enum {
58 OPT_HELP = 1,
59 OPT_LIST_OPTIONS,
60 OPT_MAX_SIZE,
61 OPT_LIST_COMMANDS,
62 };
63
64 static struct mi_writer *writer;
65
66 static struct poptOption snapshot_opts[] = {
67 /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
68 {"help", 'h', POPT_ARG_NONE, 0, OPT_HELP, 0, 0},
69 {"session", 's', POPT_ARG_STRING, &opt_session_name, 0, 0, 0},
70 {"ctrl-url", 'C', POPT_ARG_STRING, &opt_ctrl_url, 0, 0, 0},
71 {"data-url", 'D', POPT_ARG_STRING, &opt_data_url, 0, 0, 0},
72 {"name", 'n', POPT_ARG_STRING, &opt_output_name, 0, 0, 0},
73 {"max-size", 'm', POPT_ARG_STRING, 0, OPT_MAX_SIZE, 0, 0},
74 {"list-options", 0, POPT_ARG_NONE, NULL, OPT_LIST_OPTIONS, NULL, NULL},
75 {"list-commands", 0, POPT_ARG_NONE, NULL, OPT_LIST_COMMANDS},
76 {0, 0, 0, 0, 0, 0, 0}
77 };
78
79 static struct cmd_struct actions[] = {
80 { "add-output", cmd_add_output },
81 { "del-output", cmd_del_output },
82 { "list-output", cmd_list_output },
83 { "record", cmd_record },
84 { NULL, NULL } /* Array closure */
85 };
86
87 /*
88 * Count and return the number of arguments in argv.
89 */
90 static int count_arguments(const char **argv)
91 {
92 int i = 0;
93
94 assert(argv);
95
96 while (argv[i] != NULL) {
97 i++;
98 }
99
100 return i;
101 }
102
103 /*
104 * Create a snapshot output object from arguments using the given URL.
105 *
106 * Return a newly allocated object or NULL on error.
107 */
108 static struct lttng_snapshot_output *create_output_from_args(const char *url)
109 {
110 int ret = 0;
111 struct lttng_snapshot_output *output = NULL;
112
113 output = lttng_snapshot_output_create();
114 if (!output) {
115 goto error_create;
116 }
117
118 if (url) {
119 ret = lttng_snapshot_output_set_ctrl_url(url, output);
120 if (ret < 0) {
121 goto error;
122 }
123 } else if (opt_ctrl_url) {
124 ret = lttng_snapshot_output_set_ctrl_url(opt_ctrl_url, output);
125 if (ret < 0) {
126 goto error;
127 }
128 }
129
130 if (opt_data_url) {
131 ret = lttng_snapshot_output_set_data_url(opt_data_url, output);
132 if (ret < 0) {
133 goto error;
134 }
135 }
136
137 if (opt_max_size) {
138 ret = lttng_snapshot_output_set_size(opt_max_size, output);
139 if (ret < 0) {
140 goto error;
141 }
142 }
143
144 if (opt_output_name) {
145 ret = lttng_snapshot_output_set_name(opt_output_name, output);
146 if (ret < 0) {
147 goto error;
148 }
149 }
150
151 return output;
152
153 error:
154 lttng_snapshot_output_destroy(output);
155 error_create:
156 return NULL;
157 }
158
159 static int list_output(void)
160 {
161 int ret, output_seen = 0;
162 struct lttng_snapshot_output *s_iter;
163 struct lttng_snapshot_output_list *list;
164
165 ret = lttng_snapshot_list_output(current_session_name, &list);
166 if (ret < 0) {
167 goto error;
168 }
169
170 MSG("Snapshot output list for session %s", current_session_name);
171
172 if (lttng_opt_mi) {
173 ret = mi_lttng_snapshot_output_session_name(writer,
174 current_session_name);
175 if (ret) {
176 ret = CMD_ERROR;
177 goto end;
178 }
179 }
180
181 while ((s_iter = lttng_snapshot_output_list_get_next(list)) != NULL) {
182 MSG("%s[%" PRIu32 "] %s: %s (max-size: %" PRId64 ")", indent4,
183 lttng_snapshot_output_get_id(s_iter),
184 lttng_snapshot_output_get_name(s_iter),
185 lttng_snapshot_output_get_ctrl_url(s_iter),
186 lttng_snapshot_output_get_maxsize(s_iter));
187 output_seen = 1;
188 if (lttng_opt_mi) {
189 ret = mi_lttng_snapshot_list_output(writer, s_iter);
190 if (ret) {
191 ret = CMD_ERROR;
192 goto end;
193 }
194 }
195 }
196
197 if (lttng_opt_mi) {
198 /* Close snapshot snapshots element */
199 ret = mi_lttng_writer_close_element(writer);
200 if (ret) {
201 ret = CMD_ERROR;
202 goto end;
203 }
204
205 /* Close snapshot session element */
206 ret = mi_lttng_writer_close_element(writer);
207 if (ret) {
208 ret = CMD_ERROR;
209 }
210 }
211 end:
212 lttng_snapshot_output_list_destroy(list);
213
214 if (!output_seen) {
215 MSG("%sNone", indent4);
216 }
217
218 error:
219 return ret;
220 }
221
222 /*
223 * Delete output by ID.
224 */
225 static int del_output(uint32_t id, const char *name)
226 {
227 int ret;
228 struct lttng_snapshot_output *output = NULL;
229
230 output = lttng_snapshot_output_create();
231 if (!output) {
232 ret = CMD_FATAL;
233 goto error;
234 }
235
236 if (name) {
237 ret = lttng_snapshot_output_set_name(name, output);
238 } else if (id != UINT32_MAX) {
239 ret = lttng_snapshot_output_set_id(id, output);
240 } else {
241 ret = CMD_ERROR;
242 goto error;
243 }
244 if (ret < 0) {
245 ret = CMD_FATAL;
246 goto error;
247 }
248
249 ret = lttng_snapshot_del_output(current_session_name, output);
250 if (ret < 0) {
251 goto error;
252 }
253
254 if (id != UINT32_MAX) {
255 MSG("Snapshot output id %" PRIu32 " successfully deleted for session %s",
256 id, current_session_name);
257 } else {
258 MSG("Snapshot output %s successfully deleted for session %s",
259 name, current_session_name);
260 }
261
262 if (lttng_opt_mi) {
263 ret = mi_lttng_snapshot_del_output(writer, id, name,
264 current_session_name);
265 if (ret) {
266 ret = CMD_ERROR;
267 }
268 }
269
270 error:
271 lttng_snapshot_output_destroy(output);
272 return ret;
273 }
274
275 /*
276 * Add output from the user URL.
277 */
278 static int add_output(const char *url)
279 {
280 int ret;
281 struct lttng_snapshot_output *output = NULL;
282 char name[NAME_MAX];
283 const char *n_ptr;
284
285 if (!url && (!opt_data_url || !opt_ctrl_url)) {
286 ret = CMD_ERROR;
287 goto error;
288 }
289
290 output = create_output_from_args(url);
291 if (!output) {
292 ret = CMD_FATAL;
293 goto error;
294 }
295
296 /* This call, if successful, populates the id of the output object. */
297 ret = lttng_snapshot_add_output(current_session_name, output);
298 if (ret < 0) {
299 goto error;
300 }
301
302 n_ptr = lttng_snapshot_output_get_name(output);
303 if (*n_ptr == '\0') {
304 int pret;
305 pret = snprintf(name, sizeof(name), DEFAULT_SNAPSHOT_NAME "-%" PRIu32,
306 lttng_snapshot_output_get_id(output));
307 if (pret < 0) {
308 PERROR("snprintf add output name");
309 }
310 n_ptr = name;
311 }
312
313 MSG("Snapshot output successfully added for session %s",
314 current_session_name);
315 MSG(" [%" PRIu32 "] %s: %s (max-size: %" PRId64 ")",
316 lttng_snapshot_output_get_id(output), n_ptr,
317 lttng_snapshot_output_get_ctrl_url(output),
318 lttng_snapshot_output_get_maxsize(output));
319 if (lttng_opt_mi) {
320 ret = mi_lttng_snapshot_add_output(writer, current_session_name,
321 n_ptr, output);
322 if (ret) {
323 ret = CMD_ERROR;
324 }
325 }
326 error:
327 lttng_snapshot_output_destroy(output);
328 return ret;
329 }
330
331 static int cmd_add_output(int argc, const char **argv)
332 {
333 int ret;
334
335 if (argc < 2 && (!opt_data_url || !opt_ctrl_url)) {
336 ret = CMD_ERROR;
337 goto end;
338 }
339
340 ret = add_output(argv[1]);
341
342 end:
343 return ret;
344 }
345
346 static int cmd_del_output(int argc, const char **argv)
347 {
348 int ret;
349 char *name;
350 long id;
351
352 if (argc < 2) {
353 ret = CMD_ERROR;
354 goto end;
355 }
356
357 errno = 0;
358 id = strtol(argv[1], &name, 10);
359 if (id == 0 && (errno == 0 || errno == EINVAL)) {
360 ret = del_output(UINT32_MAX, name);
361 } else if (errno == 0 && *name == '\0') {
362 ret = del_output(id, NULL);
363 } else {
364 ERR("Argument %s not recognized", argv[1]);
365 ret = -1;
366 goto end;
367 }
368
369 end:
370 return ret;
371 }
372
373 static int cmd_list_output(int argc, const char **argv)
374 {
375 int ret;
376
377 ret = list_output();
378
379 return ret;
380 }
381
382 /*
383 * Do a snapshot record with the URL if one is given.
384 */
385 static int record(const char *url)
386 {
387 int ret;
388 struct lttng_snapshot_output *output = NULL;
389
390 output = create_output_from_args(url);
391 if (!output) {
392 ret = CMD_FATAL;
393 goto error;
394 }
395
396 ret = lttng_snapshot_record(current_session_name, output, 0);
397 if (ret < 0) {
398 if (ret == -LTTNG_ERR_MAX_SIZE_INVALID) {
399 ERR("Invalid snapshot size. Cannot fit at least one packet per stream.");
400 }
401 goto error;
402 }
403
404 MSG("Snapshot recorded successfully for session %s", current_session_name);
405
406 if (url) {
407 MSG("Snapshot written at: %s", url);
408 } else if (opt_ctrl_url) {
409 MSG("Snapshot written to ctrl: %s, data: %s", opt_ctrl_url,
410 opt_data_url);
411 }
412
413 if (lttng_opt_mi) {
414 ret = mi_lttng_snapshot_record(writer, current_session_name, url,
415 opt_ctrl_url, opt_data_url);
416 if (ret) {
417 ret = CMD_ERROR;
418 }
419 }
420
421 error:
422 lttng_snapshot_output_destroy(output);
423 return ret;
424 }
425
426 static int cmd_record(int argc, const char **argv)
427 {
428 int ret;
429
430 if (argc == 2) {
431 ret = record(argv[1]);
432 } else {
433 ret = record(NULL);
434 }
435
436 return ret;
437 }
438
439 static enum cmd_error_code handle_command(const char **argv)
440 {
441 int mi_ret, i = 0, argc;
442 enum cmd_error_code cmd_ret;
443 struct cmd_struct *cmd;
444
445 if (!argv) {
446 ERR("No action specified for snapshot command.");
447 cmd_ret = CMD_ERROR;
448 goto end;
449 }
450
451 if ((!opt_ctrl_url && opt_data_url) ||
452 (opt_ctrl_url && !opt_data_url)) {
453 ERR("URLs must be specified for both data and control");
454 cmd_ret = CMD_ERROR;
455 goto end;
456 }
457
458 argc = count_arguments(argv);
459 /* popt should have passed NULL if no arguments are present. */
460 assert(argc > 0);
461
462 cmd = &actions[i];
463 while (cmd->func != NULL) {
464 /* Find command */
465 if (strcmp(argv[0], cmd->name) == 0) {
466 int result;
467
468 if (lttng_opt_mi) {
469 /* Action element */
470 mi_ret = mi_lttng_writer_open_element(writer,
471 mi_lttng_element_command_action);
472 if (mi_ret) {
473 cmd_ret = CMD_ERROR;
474 goto end;
475 }
476
477 /* Name of the action */
478 mi_ret = mi_lttng_writer_write_element_string(writer,
479 config_element_name, argv[0]);
480 if (mi_ret) {
481 cmd_ret = CMD_ERROR;
482 goto end;
483 }
484
485 /* Open output element */
486 mi_ret = mi_lttng_writer_open_element(writer,
487 mi_lttng_element_command_output);
488 if (mi_ret) {
489 cmd_ret = CMD_ERROR;
490 goto end;
491 }
492 }
493
494 result = cmd->func(argc, argv);
495 if (result) {
496 switch (-result) {
497 case LTTNG_ERR_SNAPSHOT_NODATA:
498 WARN("%s", lttng_strerror(result));
499
500 /* A warning is fine since the user has no control on
501 * whether or not applications (or the kernel) have
502 * produced any event between the start of the tracing
503 * session and the recording of the snapshot. MI wise
504 * the command is not a success since nothing was
505 * recorded.
506 */
507 cmd_ret = CMD_SUCCESS;
508 break;
509 default:
510 ERR("%s", lttng_strerror(result));
511 cmd_ret = CMD_ERROR;
512 break;
513 }
514 } else {
515 cmd_ret = CMD_SUCCESS;
516 }
517
518
519 if (lttng_opt_mi) {
520 /* Close output and action element */
521 mi_ret = mi_lttng_close_multi_element(writer, 2);
522 if (mi_ret) {
523 cmd_ret = CMD_ERROR;
524 goto end;
525 }
526 }
527 goto end;
528 }
529 i++;
530 cmd = &actions[i];
531 }
532
533 cmd_ret = CMD_UNDEFINED;
534
535 end:
536 return cmd_ret;
537 }
538 /*
539 * The 'snapshot <cmd> <options>' first level command
540 */
541 int cmd_snapshot(int argc, const char **argv)
542 {
543 int opt;
544 int mi_ret;
545 enum cmd_error_code cmd_ret = CMD_SUCCESS;
546 char *session_name = NULL;
547 static poptContext pc;
548
549 pc = poptGetContext(NULL, argc, argv, snapshot_opts, 0);
550 poptReadDefaultConfig(pc, 0);
551
552 /* Mi check */
553 if (lttng_opt_mi) {
554 writer = mi_lttng_writer_create(fileno(stdout), lttng_opt_mi);
555 if (!writer) {
556 cmd_ret = CMD_ERROR;
557 goto end;
558 }
559
560 /* Open command element */
561 mi_ret = mi_lttng_writer_command_open(writer,
562 mi_lttng_element_command_snapshot);
563 if (mi_ret) {
564 cmd_ret = CMD_ERROR;
565 goto end;
566 }
567
568 /* Open output element */
569 mi_ret = mi_lttng_writer_open_element(writer,
570 mi_lttng_element_command_output);
571 if (mi_ret) {
572 cmd_ret = CMD_ERROR;
573 goto end;
574 }
575 }
576
577 while ((opt = poptGetNextOpt(pc)) != -1) {
578 switch (opt) {
579 case OPT_HELP:
580 {
581 int ret;
582
583 /* SHOW_HELP assigns to ret. */
584 SHOW_HELP();
585 cmd_ret = ret;
586 goto end;
587 }
588 case OPT_LIST_OPTIONS:
589 list_cmd_options(stdout, snapshot_opts);
590 goto end;
591 case OPT_LIST_COMMANDS:
592 list_commands(actions, stdout);
593 goto end;
594 case OPT_MAX_SIZE:
595 {
596 uint64_t val;
597 const char *opt = poptGetOptArg(pc);
598
599 if (utils_parse_size_suffix((char *) opt, &val) < 0) {
600 ERR("Unable to handle max-size value %s", opt);
601 cmd_ret = CMD_ERROR;
602 goto end;
603 }
604
605 opt_max_size = val;
606
607 break;
608 }
609 default:
610 cmd_ret = CMD_UNDEFINED;
611 goto end;
612 }
613 }
614
615 if (!opt_session_name) {
616 session_name = get_session_name();
617 if (session_name == NULL) {
618 cmd_ret = CMD_ERROR;
619 goto end;
620 }
621 current_session_name = session_name;
622 } else {
623 current_session_name = opt_session_name;
624 }
625
626 cmd_ret = handle_command(poptGetArgs(pc));
627
628 if (lttng_opt_mi) {
629 /* Close output element */
630 mi_ret = mi_lttng_writer_close_element(writer);
631 if (mi_ret) {
632 cmd_ret = CMD_ERROR;
633 goto end;
634 }
635
636 /* Success ? */
637 mi_ret = mi_lttng_writer_write_element_bool(writer,
638 mi_lttng_element_command_success,
639 cmd_ret == CMD_SUCCESS);
640 if (mi_ret) {
641 cmd_ret = CMD_ERROR;
642 goto end;
643 }
644
645 /* Command element close */
646 mi_ret = mi_lttng_writer_command_close(writer);
647 if (mi_ret) {
648 cmd_ret = CMD_ERROR;
649 goto end;
650 }
651 }
652
653 end:
654 /* Mi clean-up */
655 if (writer && mi_lttng_writer_destroy(writer)) {
656 cmd_ret = CMD_ERROR;
657 }
658
659 if (!opt_session_name) {
660 free(session_name);
661 }
662
663 poptFreeContext(pc);
664 return cmd_ret;
665 }
This page took 0.043104 seconds and 5 git commands to generate.