lttng: fix: out-of-bounds copy of original 'view' command arguments
[lttng-tools.git] / src / bin / lttng / commands / view.c
1 /*
2 * Copyright (C) 2011 - David Goulet <dgoulet@efficios.com>
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License, version 2 only,
6 * as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU General Public License for more details.
12 *
13 * You should have received a copy of the GNU General Public License along
14 * with this program; if not, write to the Free Software Foundation, Inc.,
15 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
16 */
17
18 #define _LGPL_SOURCE
19 #include <popt.h>
20 #include <stdio.h>
21 #include <stdlib.h>
22 #include <string.h>
23 #include <sys/stat.h>
24 #include <sys/types.h>
25 #include <unistd.h>
26
27 #include "../command.h"
28
29 static char *opt_session_name;
30 static char *opt_viewer;
31 static char *opt_trace_path;
32 static const char *babeltrace_bin = CONFIG_BABELTRACE_BIN;
33 //static const char *lttv_gui_bin = CONFIG_LTTV_GUI_BIN;
34
35 #ifdef LTTNG_EMBED_HELP
36 static const char help_msg[] =
37 #include <lttng-view.1.h>
38 ;
39 #endif
40
41 enum {
42 OPT_HELP = 1,
43 OPT_LIST_OPTIONS,
44 };
45
46 static struct poptOption long_options[] = {
47 /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
48 {"help", 'h', POPT_ARG_NONE, 0, OPT_HELP, 0, 0},
49 {"list-options", 0, POPT_ARG_NONE, NULL, OPT_LIST_OPTIONS, NULL, NULL},
50 {"viewer", 'e', POPT_ARG_STRING, &opt_viewer, 0, 0, 0},
51 {"trace-path", 't', POPT_ARG_STRING, &opt_trace_path, 0, 0, 0},
52 {0, 0, 0, 0, 0, 0, 0}
53 };
54
55 /*
56 * This is needed for each viewer since we are using execvp().
57 */
58 static const char *babeltrace_opts[] = { "babeltrace" };
59 //static const char *lttv_gui_opts[] = { "lttv-gui", "-t", };
60
61 /*
62 * Type is also use as the index in the viewers array. So please, make sure
63 * your enum value is in the right order in the array below.
64 */
65 enum viewer_type {
66 VIEWER_BABELTRACE = 0,
67 VIEWER_LTTV_GUI = 1,
68 VIEWER_USER_DEFINED = 2,
69 };
70
71 /*
72 * NOTE: "lttv" is a shell command and it's not working for exec() family
73 * functions so we might think of removing this wrapper or using bash.
74 */
75 static struct viewers {
76 const char *exec_name;
77 enum viewer_type type;
78 } viewers[] = {
79 { "babeltrace", VIEWER_BABELTRACE },
80 { "lttv-gui", VIEWER_LTTV_GUI },
81 { NULL, VIEWER_USER_DEFINED },
82 };
83
84 /* Is the session we are trying to view is in live mode. */
85 static int session_live_mode;
86
87 static struct viewers *parse_options(void)
88 {
89 if (opt_viewer == NULL) {
90 /* Default is babeltrace */
91 return &(viewers[VIEWER_BABELTRACE]);
92 }
93
94 /*
95 * This means that if -e, --viewers is used, we just override everything
96 * with it. For supported viewers like lttv, we could simply detect if "-t"
97 * is passed and if not, add the trace directory to it.
98 */
99 return &(viewers[VIEWER_USER_DEFINED]);
100 }
101
102 /*
103 * Alloc an array of string pointer from a simple string having all options
104 * seperated by spaces. Also adds the trace path to the arguments.
105 *
106 * The returning pointer is ready to be passed to execvp().
107 */
108 static char **alloc_argv_from_user_opts(char *opts, const char *trace_path)
109 {
110 int i = 0, ignore_space = 0;
111 unsigned int num_opts = 1;
112 char **argv, *token = opts;
113
114 /* Count number of arguments. */
115 do {
116 if (*token == ' ') {
117 /* Use to ignore consecutive spaces */
118 if (!ignore_space) {
119 num_opts++;
120 }
121 ignore_space = 1;
122 } else {
123 ignore_space = 0;
124 }
125 token++;
126 } while (*token != '\0');
127
128 /* Add two here for the NULL terminating element and trace path */
129 argv = zmalloc(sizeof(char *) * (num_opts + 2));
130 if (argv == NULL) {
131 goto error;
132 }
133
134 token = strtok(opts, " ");
135 while (token != NULL) {
136 argv[i] = strdup(token);
137 if (argv[i] == NULL) {
138 goto error;
139 }
140 token = strtok(NULL, " ");
141 i++;
142 }
143
144 argv[num_opts] = (char *) trace_path;
145 argv[num_opts + 1] = NULL;
146
147 return argv;
148
149 error:
150 if (argv) {
151 for (i = 0; i < num_opts + 2; i++) {
152 free(argv[i]);
153 }
154 free(argv);
155 }
156
157 return NULL;
158 }
159
160 /*
161 * Alloc an array of string pointer from an array of strings. It also adds
162 * the trace path to the argv.
163 *
164 * The returning pointer is ready to be passed to execvp().
165 */
166 static char **alloc_argv_from_local_opts(const char **opts, size_t opts_len,
167 const char *trace_path)
168 {
169 char **argv;
170 size_t size, mem_len;
171
172
173 /* Add one for the NULL terminating element. */
174 mem_len = opts_len + 1;
175 if (session_live_mode) {
176 /* Add 3 option for the live mode being "-i lttng-live URL". */
177 mem_len += 3;
178 } else {
179 /* Add option for the trace path. */
180 mem_len += 1;
181 }
182
183 size = sizeof(char *) * mem_len;
184
185 /* Add two here for the trace_path and the NULL terminating element. */
186 argv = zmalloc(size);
187 if (argv == NULL) {
188 goto error;
189 }
190
191 memcpy(argv, opts, opts_len);
192
193 if (session_live_mode) {
194 argv[opts_len] = "-i";
195 argv[opts_len + 1] = "lttng-live";
196 argv[opts_len + 2] = (char *) trace_path;
197 argv[opts_len + 3] = NULL;
198 } else {
199 argv[opts_len] = (char *) trace_path;
200 argv[opts_len + 1] = NULL;
201 }
202
203 error:
204 return argv;
205 }
206
207 /*
208 * Spawn viewer with the trace directory path.
209 */
210 static int spawn_viewer(const char *trace_path)
211 {
212 int ret = 0;
213 struct stat status;
214 const char *viewer_bin = NULL;
215 struct viewers *viewer;
216 char **argv = NULL;
217
218 /* Check for --viewer options */
219 viewer = parse_options();
220 if (viewer == NULL) {
221 ret = CMD_ERROR;
222 goto error;
223 }
224
225 switch (viewer->type) {
226 case VIEWER_BABELTRACE:
227 if (stat(babeltrace_bin, &status) == 0) {
228 viewer_bin = babeltrace_bin;
229 } else {
230 viewer_bin = viewer->exec_name;
231 }
232 argv = alloc_argv_from_local_opts(babeltrace_opts,
233 ARRAY_SIZE(babeltrace_opts), trace_path);
234 break;
235 case VIEWER_USER_DEFINED:
236 argv = alloc_argv_from_user_opts(opt_viewer, trace_path);
237 if (argv) {
238 viewer_bin = argv[0];
239 }
240 break;
241 default:
242 viewer_bin = viewers[VIEWER_BABELTRACE].exec_name;
243 argv = alloc_argv_from_local_opts(babeltrace_opts,
244 ARRAY_SIZE(babeltrace_opts), trace_path);
245 break;
246 }
247
248 if (argv == NULL || !viewer_bin) {
249 ret = CMD_FATAL;
250 goto error;
251 }
252
253 DBG("Using %s viewer", viewer_bin);
254
255 ret = execvp(viewer_bin, argv);
256 if (ret) {
257 if (errno == ENOENT) {
258 ERR("%s not found on the system", viewer_bin);
259 } else {
260 PERROR("exec: %s", viewer_bin);
261 }
262 ret = CMD_FATAL;
263 goto error;
264 }
265
266 error:
267 free(argv);
268 return ret;
269 }
270
271 /*
272 * Build the live path we need for the lttng live view.
273 */
274 static char *build_live_path(char *session_name)
275 {
276 int ret;
277 char *path = NULL;
278 char hostname[HOST_NAME_MAX];
279
280 ret = gethostname(hostname, sizeof(hostname));
281 if (ret < 0) {
282 PERROR("gethostname");
283 goto error;
284 }
285
286 ret = asprintf(&path, "net://localhost/host/%s/%s", hostname,
287 session_name);
288 if (ret < 0) {
289 PERROR("asprintf live path");
290 goto error;
291 }
292
293 error:
294 return path;
295 }
296
297 /*
298 * Exec viewer if found and use session name path.
299 */
300 static int view_trace(void)
301 {
302 int ret;
303 char *session_name, *trace_path = NULL;
304 struct lttng_session *sessions = NULL;
305 bool free_trace_path = false;
306
307 /*
308 * Safety net. If lttng is suid at some point for *any* useless reasons,
309 * this prevent any bad execution of binaries.
310 */
311 if (getuid() != 0) {
312 if (getuid() != geteuid()) {
313 ERR("UID does not match effective UID.");
314 ret = CMD_ERROR;
315 goto error;
316 } else if (getgid() != getegid()) {
317 ERR("GID does not match effective GID.");
318 ret = CMD_ERROR;
319 goto error;
320 }
321 }
322
323 /* User define trace path override the session name */
324 if (opt_trace_path) {
325 session_name = NULL;
326 } else if(opt_session_name == NULL) {
327 session_name = get_session_name();
328 if (session_name == NULL) {
329 ret = CMD_ERROR;
330 goto error;
331 }
332 } else {
333 session_name = opt_session_name;
334 }
335
336 DBG("Viewing trace for session %s", session_name);
337
338 if (session_name) {
339 int i, count, found = 0;
340
341 /* Getting all sessions */
342 count = lttng_list_sessions(&sessions);
343 if (count < 0) {
344 ERR("Unable to list sessions. Session name %s not found.",
345 session_name);
346 MSG("Is there a session daemon running?");
347 ret = CMD_ERROR;
348 goto free_error;
349 }
350
351 /* Find our session listed by the session daemon */
352 for (i = 0; i < count; i++) {
353 if (strncmp(sessions[i].name, session_name, NAME_MAX) == 0) {
354 found = 1;
355 break;
356 }
357 }
358
359 if (!found) {
360 MSG("Session name %s not found", session_name);
361 ret = CMD_ERROR;
362 goto free_sessions;
363 }
364
365 session_live_mode = sessions[i].live_timer_interval;
366
367 DBG("Session live mode set to %d", session_live_mode);
368
369 if (sessions[i].enabled && !session_live_mode) {
370 WARN("Session %s is running. Please stop it before reading it.",
371 session_name);
372 ret = CMD_ERROR;
373 goto free_sessions;
374 }
375
376 /* If the timer interval is set we are in live mode. */
377 if (session_live_mode) {
378 trace_path = build_live_path(session_name);
379 if (!trace_path) {
380 ret = CMD_ERROR;
381 goto free_sessions;
382 }
383 free_trace_path = true;
384 } else {
385 /* Get file system session path. */
386 trace_path = sessions[i].path;
387 }
388 } else {
389 trace_path = opt_trace_path;
390 }
391
392 MSG("Trace directory: %s\n", trace_path);
393
394 ret = spawn_viewer(trace_path);
395 if (ret < 0) {
396 /* Don't set ret so lttng can interpret the sessiond error. */
397 goto free_sessions;
398 }
399
400 free_sessions:
401 if (session_live_mode && free_trace_path) {
402 free(trace_path);
403 }
404 free(sessions);
405 free_error:
406 if (opt_session_name == NULL) {
407 free(session_name);
408 }
409 error:
410 return ret;
411 }
412
413 /*
414 * The 'view <options>' first level command
415 */
416 int cmd_view(int argc, const char **argv)
417 {
418 int opt, ret = CMD_SUCCESS;
419 static poptContext pc;
420 const char *leftover = NULL;
421
422 pc = poptGetContext(NULL, argc, argv, long_options, 0);
423 poptReadDefaultConfig(pc, 0);
424
425 if (lttng_opt_mi) {
426 WARN("mi does not apply to view command");
427 }
428
429 while ((opt = poptGetNextOpt(pc)) != -1) {
430 switch (opt) {
431 case OPT_HELP:
432 SHOW_HELP();
433 goto end;
434 case OPT_LIST_OPTIONS:
435 list_cmd_options(stdout, long_options);
436 goto end;
437 default:
438 ret = CMD_UNDEFINED;
439 goto end;
440 }
441 }
442
443 opt_session_name = (char*) poptGetArg(pc);
444
445 leftover = poptGetArg(pc);
446 if (leftover) {
447 ERR("Unknown argument: %s", leftover);
448 ret = CMD_ERROR;
449 goto end;
450 }
451
452 ret = view_trace();
453
454 end:
455 poptFreeContext(pc);
456 return ret;
457 }
This page took 0.04078 seconds and 6 git commands to generate.