projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: Missing rcu_read_lock in cmd_snapshot_list_outputs()
[lttng-tools.git]
/
src
/
bin
/
lttng-sessiond
/
cmd.c
diff --git
a/src/bin/lttng-sessiond/cmd.c
b/src/bin/lttng-sessiond/cmd.c
index 2c6f6f4a7bcb443d4a7e6638e489bd04d395e8bc..0b97ed61a1ec54fc928b1e5a69890ede4002a162 100644
(file)
--- a/
src/bin/lttng-sessiond/cmd.c
+++ b/
src/bin/lttng-sessiond/cmd.c
@@
-2796,7
+2796,7
@@
ssize_t cmd_snapshot_list_outputs(struct ltt_session *session,
struct lttng_snapshot_output **outputs)
{
int ret, idx = 0;
struct lttng_snapshot_output **outputs)
{
int ret, idx = 0;
- struct lttng_snapshot_output *list;
+ struct lttng_snapshot_output *list
= NULL
;
struct lttng_ht_iter iter;
struct snapshot_output *output;
struct lttng_ht_iter iter;
struct snapshot_output *output;
@@
-2810,7
+2810,7
@@
ssize_t cmd_snapshot_list_outputs(struct ltt_session *session,
* set in no output mode.
*/
if (session->output_traces) {
* set in no output mode.
*/
if (session->output_traces) {
- ret = LTTNG_ERR_EPERM;
+ ret =
-
LTTNG_ERR_EPERM;
goto error;
}
goto error;
}
@@
-2821,11
+2821,12
@@
ssize_t cmd_snapshot_list_outputs(struct ltt_session *session,
list = zmalloc(session->snapshot.nb_output * sizeof(*list));
if (!list) {
list = zmalloc(session->snapshot.nb_output * sizeof(*list));
if (!list) {
- ret = LTTNG_ERR_NOMEM;
+ ret =
-
LTTNG_ERR_NOMEM;
goto error;
}
/* Copy list from session to the new list object. */
goto error;
}
/* Copy list from session to the new list object. */
+ rcu_read_lock();
cds_lfht_for_each_entry(session->snapshot.output_ht->ht, &iter.iter,
output, node.node) {
assert(output->consumer);
cds_lfht_for_each_entry(session->snapshot.output_ht->ht, &iter.iter,
output, node.node) {
assert(output->consumer);
@@
-2840,28
+2841,28
@@
ssize_t cmd_snapshot_list_outputs(struct ltt_session *session,
ret = uri_to_str_url(&output->consumer->dst.net.control,
list[idx].ctrl_url, sizeof(list[idx].ctrl_url));
if (ret < 0) {
ret = uri_to_str_url(&output->consumer->dst.net.control,
list[idx].ctrl_url, sizeof(list[idx].ctrl_url));
if (ret < 0) {
- ret = LTTNG_ERR_NOMEM;
- goto
free_
error;
+ ret =
-
LTTNG_ERR_NOMEM;
+ goto error;
}
/* Data URI. */
ret = uri_to_str_url(&output->consumer->dst.net.data,
list[idx].data_url, sizeof(list[idx].data_url));
if (ret < 0) {
}
/* Data URI. */
ret = uri_to_str_url(&output->consumer->dst.net.data,
list[idx].data_url, sizeof(list[idx].data_url));
if (ret < 0) {
- ret = LTTNG_ERR_NOMEM;
- goto
free_
error;
+ ret =
-
LTTNG_ERR_NOMEM;
+ goto error;
}
}
idx++;
}
*outputs = list;
}
}
idx++;
}
*outputs = list;
- return session->snapshot.nb_output;
-
-free_error:
- free(list);
+ list = NULL;
+ ret = session->snapshot.nb_output;
error:
error:
- return -ret;
+ free(list);
+ rcu_read_unlock();
+ return ret;
}
/*
}
/*
This page took
0.026805 seconds
and
5
git commands to generate.