sessiond: prepare client replies through an lttng_payload
[lttng-tools.git] / src / bin / lttng-sessiond / cmd.c
index 68b6aa2536d7d8bf6bc9350e0b0763f7b458da36..200396df67688be647e3d56f74dbb2d47d9cc08d 100644 (file)
@@ -6,6 +6,10 @@
  *
  */
 
+#include "bin/lttng-sessiond/tracker.h"
+#include "common/sessiond-comm/payload.h"
+#include "lttng/lttng-error.h"
+#include "lttng/tracker.h"
 #define _LGPL_SOURCE
 #include <assert.h>
 #include <inttypes.h>
@@ -23,6 +27,8 @@
 #include <common/kernel-ctl/kernel-ctl.h>
 #include <common/dynamic-buffer.h>
 #include <common/buffer-view.h>
+#include <common/sessiond-comm/payload.h>
+#include <common/sessiond-comm/payload-view.h>
 #include <common/trace-chunk.h>
 #include <lttng/location-internal.h>
 #include <lttng/trigger/trigger-internal.h>
@@ -813,8 +819,7 @@ end:
        return nb_event;
 
 error:
-       /* Negate the error code to differentiate the size from an error */
-       return -ret;
+       return ret;
 }
 
 /*
@@ -1431,112 +1436,6 @@ error:
        return ret;
 }
 
-/*
- * Command LTTNG_TRACK_ID processed by the client thread.
- *
- * Called with session lock held.
- */
-int cmd_track_id(struct ltt_session *session,
-               enum lttng_tracker_type tracker_type,
-               enum lttng_domain_type domain,
-               const struct lttng_tracker_id *id)
-{
-       int ret;
-
-       rcu_read_lock();
-
-       switch (domain) {
-       case LTTNG_DOMAIN_KERNEL:
-       {
-               struct ltt_kernel_session *ksess;
-
-               ksess = session->kernel_session;
-
-               ret = kernel_track_id(tracker_type, ksess, id);
-               if (ret != LTTNG_OK) {
-                       goto error;
-               }
-
-               kernel_wait_quiescent();
-               break;
-       }
-       case LTTNG_DOMAIN_UST:
-       {
-               struct ltt_ust_session *usess;
-
-               usess = session->ust_session;
-
-               ret = trace_ust_track_id(tracker_type, usess, id);
-               if (ret != LTTNG_OK) {
-                       goto error;
-               }
-               break;
-       }
-       default:
-               ret = LTTNG_ERR_UNKNOWN_DOMAIN;
-               goto error;
-       }
-
-       ret = LTTNG_OK;
-
-error:
-       rcu_read_unlock();
-       return ret;
-}
-
-/*
- * Command LTTNG_UNTRACK_ID processed by the client thread.
- *
- * Called with session lock held.
- */
-int cmd_untrack_id(struct ltt_session *session,
-               enum lttng_tracker_type tracker_type,
-               enum lttng_domain_type domain,
-               const struct lttng_tracker_id *id)
-{
-       int ret;
-
-       rcu_read_lock();
-
-       switch (domain) {
-       case LTTNG_DOMAIN_KERNEL:
-       {
-               struct ltt_kernel_session *ksess;
-
-               ksess = session->kernel_session;
-
-               ret = kernel_untrack_id(tracker_type, ksess, id);
-               if (ret != LTTNG_OK) {
-                       goto error;
-               }
-
-               kernel_wait_quiescent();
-               break;
-       }
-       case LTTNG_DOMAIN_UST:
-       {
-               struct ltt_ust_session *usess;
-
-               usess = session->ust_session;
-
-               ret = trace_ust_untrack_id(tracker_type, usess, id);
-               if (ret != LTTNG_OK) {
-                       goto error;
-               }
-               break;
-       }
-       default:
-               ret = LTTNG_ERR_UNKNOWN_DOMAIN;
-               goto error;
-       }
-
-       ret = LTTNG_OK;
-
-error:
-       rcu_read_unlock();
-       return ret;
-}
-
 /*
  * Command LTTNG_ENABLE_CHANNEL processed by the client thread.
  *
@@ -1708,6 +1607,211 @@ end:
        return ret;
 }
 
+enum lttng_error_code cmd_process_attr_tracker_get_tracking_policy(
+               struct ltt_session *session,
+               enum lttng_domain_type domain,
+               enum lttng_process_attr process_attr,
+               enum lttng_tracking_policy *policy)
+{
+       enum lttng_error_code ret_code = LTTNG_OK;
+       const struct process_attr_tracker *tracker;
+
+       switch (domain) {
+       case LTTNG_DOMAIN_KERNEL:
+               if (!session->kernel_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               tracker = kernel_get_process_attr_tracker(
+                               session->kernel_session, process_attr);
+               break;
+       case LTTNG_DOMAIN_UST:
+               if (!session->ust_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               tracker = trace_ust_get_process_attr_tracker(
+                               session->ust_session, process_attr);
+               break;
+       default:
+               ret_code = LTTNG_ERR_UNSUPPORTED_DOMAIN;
+               goto end;
+       }
+       if (tracker) {
+               *policy = process_attr_tracker_get_tracking_policy(tracker);
+       } else {
+               ret_code = LTTNG_ERR_INVALID;
+       }
+end:
+       return ret_code;
+}
+
+enum lttng_error_code cmd_process_attr_tracker_set_tracking_policy(
+               struct ltt_session *session,
+               enum lttng_domain_type domain,
+               enum lttng_process_attr process_attr,
+               enum lttng_tracking_policy policy)
+{
+       enum lttng_error_code ret_code = LTTNG_OK;
+
+       switch (policy) {
+       case LTTNG_TRACKING_POLICY_INCLUDE_SET:
+       case LTTNG_TRACKING_POLICY_EXCLUDE_ALL:
+       case LTTNG_TRACKING_POLICY_INCLUDE_ALL:
+               break;
+       default:
+               ret_code = LTTNG_ERR_INVALID;
+               goto end;
+       }
+
+       switch (domain) {
+       case LTTNG_DOMAIN_KERNEL:
+               if (!session->kernel_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               ret_code = kernel_process_attr_tracker_set_tracking_policy(
+                               session->kernel_session, process_attr, policy);
+               break;
+       case LTTNG_DOMAIN_UST:
+               if (!session->ust_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               ret_code = trace_ust_process_attr_tracker_set_tracking_policy(
+                               session->ust_session, process_attr, policy);
+               break;
+       default:
+               ret_code = LTTNG_ERR_UNSUPPORTED_DOMAIN;
+               break;
+       }
+end:
+       return ret_code;
+}
+
+enum lttng_error_code cmd_process_attr_tracker_inclusion_set_add_value(
+               struct ltt_session *session,
+               enum lttng_domain_type domain,
+               enum lttng_process_attr process_attr,
+               const struct process_attr_value *value)
+{
+       enum lttng_error_code ret_code = LTTNG_OK;
+
+       switch (domain) {
+       case LTTNG_DOMAIN_KERNEL:
+               if (!session->kernel_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               ret_code = kernel_process_attr_tracker_inclusion_set_add_value(
+                               session->kernel_session, process_attr, value);
+               break;
+       case LTTNG_DOMAIN_UST:
+               if (!session->ust_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               ret_code = trace_ust_process_attr_tracker_inclusion_set_add_value(
+                               session->ust_session, process_attr, value);
+               break;
+       default:
+               ret_code = LTTNG_ERR_UNSUPPORTED_DOMAIN;
+               break;
+       }
+end:
+       return ret_code;
+}
+
+enum lttng_error_code cmd_process_attr_tracker_inclusion_set_remove_value(
+               struct ltt_session *session,
+               enum lttng_domain_type domain,
+               enum lttng_process_attr process_attr,
+               const struct process_attr_value *value)
+{
+       enum lttng_error_code ret_code = LTTNG_OK;
+
+       switch (domain) {
+       case LTTNG_DOMAIN_KERNEL:
+               if (!session->kernel_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               ret_code = kernel_process_attr_tracker_inclusion_set_remove_value(
+                               session->kernel_session, process_attr, value);
+               break;
+       case LTTNG_DOMAIN_UST:
+               if (!session->ust_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               ret_code = trace_ust_process_attr_tracker_inclusion_set_remove_value(
+                               session->ust_session, process_attr, value);
+               break;
+       default:
+               ret_code = LTTNG_ERR_UNSUPPORTED_DOMAIN;
+               break;
+       }
+end:
+       return ret_code;
+}
+
+enum lttng_error_code cmd_process_attr_tracker_get_inclusion_set(
+               struct ltt_session *session,
+               enum lttng_domain_type domain,
+               enum lttng_process_attr process_attr,
+               struct lttng_process_attr_values **values)
+{
+       enum lttng_error_code ret_code = LTTNG_OK;
+       const struct process_attr_tracker *tracker;
+       enum process_attr_tracker_status status;
+
+       switch (domain) {
+       case LTTNG_DOMAIN_KERNEL:
+               if (!session->kernel_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               tracker = kernel_get_process_attr_tracker(
+                               session->kernel_session, process_attr);
+               break;
+       case LTTNG_DOMAIN_UST:
+               if (!session->ust_session) {
+                       ret_code = LTTNG_ERR_INVALID;
+                       goto end;
+               }
+               tracker = trace_ust_get_process_attr_tracker(
+                               session->ust_session, process_attr);
+               break;
+       default:
+               ret_code = LTTNG_ERR_UNSUPPORTED_DOMAIN;
+               goto end;
+       }
+
+       if (!tracker) {
+               ret_code = LTTNG_ERR_INVALID;
+               goto end;
+       }
+
+       status = process_attr_tracker_get_inclusion_set(tracker, values);
+       switch (status) {
+       case PROCESS_ATTR_TRACKER_STATUS_OK:
+               ret_code = LTTNG_OK;
+               break;
+       case PROCESS_ATTR_TRACKER_STATUS_INVALID_TRACKING_POLICY:
+               ret_code = LTTNG_ERR_PROCESS_ATTR_TRACKER_INVALID_TRACKING_POLICY;
+               break;
+       case PROCESS_ATTR_TRACKER_STATUS_ERROR:
+               ret_code = LTTNG_ERR_NOMEM;
+               break;
+       default:
+               ret_code = LTTNG_ERR_UNK;
+               break;
+       }
+
+end:
+       return ret_code;
+}
+
 /*
  * Command LTTNG_DISABLE_EVENT processed by the client thread.
  */
@@ -2566,56 +2670,6 @@ ssize_t cmd_list_syscalls(struct lttng_event **events)
        return syscall_table_list(events);
 }
 
-/*
- * Command LTTNG_LIST_TRACKER_IDS processed by the client thread.
- *
- * Called with session lock held.
- */
-int cmd_list_tracker_ids(enum lttng_tracker_type tracker_type,
-               struct ltt_session *session,
-               enum lttng_domain_type domain,
-               struct lttng_tracker_ids **ids)
-{
-       int ret = LTTNG_OK;
-
-       switch (domain) {
-       case LTTNG_DOMAIN_KERNEL:
-       {
-               struct ltt_kernel_session *ksess;
-
-               ksess = session->kernel_session;
-               ret = kernel_list_tracker_ids(tracker_type, ksess, ids);
-               if (ret != LTTNG_OK) {
-                       ret = -LTTNG_ERR_KERN_LIST_FAIL;
-                       goto error;
-               }
-               break;
-       }
-       case LTTNG_DOMAIN_UST:
-       {
-               struct ltt_ust_session *usess;
-
-               usess = session->ust_session;
-               ret = trace_ust_list_tracker_ids(tracker_type, usess, ids);
-               if (ret != LTTNG_OK) {
-                       ret = -LTTNG_ERR_UST_LIST_FAIL;
-                       goto error;
-               }
-               break;
-       }
-       case LTTNG_DOMAIN_LOG4J:
-       case LTTNG_DOMAIN_JUL:
-       case LTTNG_DOMAIN_PYTHON:
-       default:
-               ret = -LTTNG_ERR_UND;
-               goto error;
-       }
-
-error:
-       /* Return negative value to differentiate return code */
-       return ret;
-}
-
 /*
  * Command LTTNG_START_TRACE processed by the client thread.
  *
@@ -2739,6 +2793,16 @@ int cmd_start_trace(struct ltt_session *session)
                }
        }
 
+       /*
+        * Open a packet in every stream of the session to ensure that viewers
+        * can correctly identify the boundaries of the periods during which
+        * tracing was active for this session.
+        */
+       ret = session_open_packets(session);
+       if (ret != LTTNG_OK) {
+               goto error;
+       }
+
        /*
         * Clear the flag that indicates that a rotation was done while the
         * session was stopped.
@@ -3122,19 +3186,19 @@ enum lttng_error_code cmd_create_session(struct command_ctx *cmd_ctx, int sock,
        enum lttng_error_code ret_code;
 
        lttng_dynamic_buffer_init(&payload);
-       if (cmd_ctx->lsm->u.create_session.home_dir_size >=
+       if (cmd_ctx->lsm.u.create_session.home_dir_size >=
                        LTTNG_PATH_MAX) {
                ret_code = LTTNG_ERR_INVALID;
                goto error;
        }
-       if (cmd_ctx->lsm->u.create_session.session_descriptor_size >
+       if (cmd_ctx->lsm.u.create_session.session_descriptor_size >
                        LTTNG_SESSION_DESCRIPTOR_MAX_LEN) {
                ret_code = LTTNG_ERR_INVALID;
                goto error;
        }
 
-       payload_size = cmd_ctx->lsm->u.create_session.home_dir_size +
-                       cmd_ctx->lsm->u.create_session.session_descriptor_size;
+       payload_size = cmd_ctx->lsm.u.create_session.home_dir_size +
+                       cmd_ctx->lsm.u.create_session.session_descriptor_size;
        ret = lttng_dynamic_buffer_set_size(&payload, payload_size);
        if (ret) {
                ret_code = LTTNG_ERR_NOMEM;
@@ -3151,11 +3215,11 @@ enum lttng_error_code cmd_create_session(struct command_ctx *cmd_ctx, int sock,
        home_dir_view = lttng_buffer_view_from_dynamic_buffer(
                        &payload,
                        0,
-                       cmd_ctx->lsm->u.create_session.home_dir_size);
+                       cmd_ctx->lsm.u.create_session.home_dir_size);
        session_descriptor_view = lttng_buffer_view_from_dynamic_buffer(
                        &payload,
-                       cmd_ctx->lsm->u.create_session.home_dir_size,
-                       cmd_ctx->lsm->u.create_session.session_descriptor_size);
+                       cmd_ctx->lsm.u.create_session.home_dir_size,
+                       cmd_ctx->lsm.u.create_session.session_descriptor_size);
 
        ret = lttng_session_descriptor_create_from_buffer(
                        &session_descriptor_view, &session_descriptor);
@@ -3350,9 +3414,17 @@ int cmd_destroy_session(struct ltt_session *session,
                 */
                ret = cmd_rotate_session(session, NULL, true,
                        LTTNG_TRACE_CHUNK_COMMAND_TYPE_NO_OPERATION);
-               if (ret != LTTNG_OK) {
+               /*
+                * Rotation operations may not be supported by the kernel
+                * tracer. Hence, do not consider this implicit rotation as
+                * a session destruction error. The library has already stopped
+                * the session and waited for pending data; there is nothing
+                * left to do but complete the destruction of the session.
+                */
+               if (ret != LTTNG_OK &&
+                               ret != -LTTNG_ERR_ROTATION_NOT_AVAILABLE_KERNEL) {
                        ERR("Failed to perform a quiet rotation as part of the destruction of session \"%s\": %s",
-                                       session->name, lttng_strerror(-ret));
+                           session->name, lttng_strerror(ret));
                        destruction_last_error = -ret;
                }
        }
@@ -4290,19 +4362,19 @@ int cmd_register_trigger(struct command_ctx *cmd_ctx, int sock,
        size_t trigger_len;
        ssize_t sock_recv_len;
        struct lttng_trigger *trigger = NULL;
-       struct lttng_buffer_view view;
-       struct lttng_dynamic_buffer trigger_buffer;
+       struct lttng_payload trigger_payload;
 
-       lttng_dynamic_buffer_init(&trigger_buffer);
-       trigger_len = (size_t) cmd_ctx->lsm->u.trigger.length;
-       ret = lttng_dynamic_buffer_set_size(&trigger_buffer, trigger_len);
+       lttng_payload_init(&trigger_payload);
+       trigger_len = (size_t) cmd_ctx->lsm.u.trigger.length;
+       ret = lttng_dynamic_buffer_set_size(
+                       &trigger_payload.buffer, trigger_len);
        if (ret) {
                ret = LTTNG_ERR_NOMEM;
                goto end;
        }
 
-       sock_recv_len = lttcomm_recv_unix_sock(sock, trigger_buffer.data,
-                       trigger_len);
+       sock_recv_len = lttcomm_recv_unix_sock(
+                       sock, trigger_payload.buffer.data, trigger_len);
        if (sock_recv_len < 0 || sock_recv_len != trigger_len) {
                ERR("Failed to receive \"register trigger\" command payload");
                /* TODO: should this be a new error enum ? */
@@ -4310,12 +4382,17 @@ int cmd_register_trigger(struct command_ctx *cmd_ctx, int sock,
                goto end;
        }
 
-       view = lttng_buffer_view_from_dynamic_buffer(&trigger_buffer, 0, -1);
-       if (lttng_trigger_create_from_buffer(&view, &trigger) !=
-                       trigger_len) {
-               ERR("Invalid trigger payload received in \"register trigger\" command");
-               ret = LTTNG_ERR_INVALID_TRIGGER;
-               goto end;
+       {
+               struct lttng_payload_view view =
+                               lttng_payload_view_from_payload(
+                                               &trigger_payload, 0, -1);
+
+               if (lttng_trigger_create_from_payload(&view, &trigger) !=
+                               trigger_len) {
+                       ERR("Invalid trigger payload received in \"register trigger\" command");
+                       ret = LTTNG_ERR_INVALID_TRIGGER;
+                       goto end;
+               }
        }
 
        ret = notification_thread_command_register_trigger(notification_thread,
@@ -4324,7 +4401,7 @@ int cmd_register_trigger(struct command_ctx *cmd_ctx, int sock,
        trigger = NULL;
 end:
        lttng_trigger_destroy(trigger);
-       lttng_dynamic_buffer_reset(&trigger_buffer);
+       lttng_payload_reset(&trigger_payload);
        return ret;
 }
 
@@ -4335,19 +4412,19 @@ int cmd_unregister_trigger(struct command_ctx *cmd_ctx, int sock,
        size_t trigger_len;
        ssize_t sock_recv_len;
        struct lttng_trigger *trigger = NULL;
-       struct lttng_buffer_view view;
-       struct lttng_dynamic_buffer trigger_buffer;
+       struct lttng_payload trigger_payload;
 
-       lttng_dynamic_buffer_init(&trigger_buffer);
-       trigger_len = (size_t) cmd_ctx->lsm->u.trigger.length;
-       ret = lttng_dynamic_buffer_set_size(&trigger_buffer, trigger_len);
+       lttng_payload_init(&trigger_payload);
+       trigger_len = (size_t) cmd_ctx->lsm.u.trigger.length;
+       ret = lttng_dynamic_buffer_set_size(
+                       &trigger_payload.buffer, trigger_len);
        if (ret) {
                ret = LTTNG_ERR_NOMEM;
                goto end;
        }
 
-       sock_recv_len = lttcomm_recv_unix_sock(sock, trigger_buffer.data,
-                       trigger_len);
+       sock_recv_len = lttcomm_recv_unix_sock(
+                       sock, trigger_payload.buffer.data, trigger_len);
        if (sock_recv_len < 0 || sock_recv_len != trigger_len) {
                ERR("Failed to receive \"unregister trigger\" command payload");
                /* TODO: should this be a new error enum ? */
@@ -4355,19 +4432,24 @@ int cmd_unregister_trigger(struct command_ctx *cmd_ctx, int sock,
                goto end;
        }
 
-       view = lttng_buffer_view_from_dynamic_buffer(&trigger_buffer, 0, -1);
-       if (lttng_trigger_create_from_buffer(&view, &trigger) !=
-                       trigger_len) {
-               ERR("Invalid trigger payload received in \"unregister trigger\" command");
-               ret = LTTNG_ERR_INVALID_TRIGGER;
-               goto end;
+       {
+               struct lttng_payload_view view =
+                               lttng_payload_view_from_payload(
+                                               &trigger_payload, 0, -1);
+
+               if (lttng_trigger_create_from_payload(&view, &trigger) !=
+                               trigger_len) {
+                       ERR("Invalid trigger payload received in \"unregister trigger\" command");
+                       ret = LTTNG_ERR_INVALID_TRIGGER;
+                       goto end;
+               }
        }
 
        ret = notification_thread_command_unregister_trigger(notification_thread,
                        trigger);
 end:
        lttng_trigger_destroy(trigger);
-       lttng_dynamic_buffer_reset(&trigger_buffer);
+       lttng_payload_reset(&trigger_payload);
        return ret;
 }
 
@@ -4574,7 +4656,7 @@ int64_t get_session_nb_packets_per_stream(const struct ltt_session *session,
                }
                cur_nb_packets++;
        }
-       if (!cur_nb_packets) {
+       if (!cur_nb_packets && size_left != max_size) {
                /* Not enough room to grab one packet of each stream, error. */
                return -1;
        }
@@ -4687,7 +4769,7 @@ enum lttng_error_code snapshot_record(struct ltt_session *session,
                        snapshot_output->max_size);
        if (nb_packets_per_stream < 0) {
                ret_code = LTTNG_ERR_MAX_SIZE_INVALID;
-               goto error;
+               goto error_close_trace_chunk;
        }
 
        if (session->kernel_session) {
@@ -4695,7 +4777,7 @@ enum lttng_error_code snapshot_record(struct ltt_session *session,
                                snapshot_kernel_consumer_output, session,
                                wait, nb_packets_per_stream);
                if (ret_code != LTTNG_OK) {
-                       goto error;
+                       goto error_close_trace_chunk;
                }
        }
 
@@ -4704,10 +4786,11 @@ enum lttng_error_code snapshot_record(struct ltt_session *session,
                                snapshot_ust_consumer_output, session,
                                wait, nb_packets_per_stream);
                if (ret_code != LTTNG_OK) {
-                       goto error;
+                       goto error_close_trace_chunk;
                }
        }
 
+error_close_trace_chunk:
        if (session_set_trace_chunk(session, NULL, &snapshot_trace_chunk)) {
                ERR("Failed to release the current trace chunk of session \"%s\"",
                                session->name);
This page took 0.030809 seconds and 5 git commands to generate.