projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
lttng-sessiond: Set group permissions explicitly
[lttng-tools.git]
/
src
/
bin
/
lttng-sessiond
/
main.c
diff --git
a/src/bin/lttng-sessiond/main.c
b/src/bin/lttng-sessiond/main.c
index 6ae374483a428019721591fc012924044eb93758..283868970f74e9eb2317e9a7e883c99d3b55f8bf 100644
(file)
--- a/
src/bin/lttng-sessiond/main.c
+++ b/
src/bin/lttng-sessiond/main.c
@@
-3913,7
+3913,7
@@
static int check_existing_daemon(void)
* Set the tracing group gid onto the client socket.
*
* Race window between mkdir and chown is OK because we are going from more
* Set the tracing group gid onto the client socket.
*
* Race window between mkdir and chown is OK because we are going from more
- * permissive (root.root) to les permissive (root.tracing).
+ * permissive (root.root) to les
s
permissive (root.tracing).
*/
static int set_permissions(char *rundir)
{
*/
static int set_permissions(char *rundir)
{
@@
-3934,6
+3934,13
@@
static int set_permissions(char *rundir)
perror("chown");
}
perror("chown");
}
+ /* Ensure tracing group can search the run dir */
+ ret = chmod(rundir, S_IRWXU | S_IXGRP);
+ if (ret < 0) {
+ ERR("Unable to set permissions on %s", rundir);
+ perror("chmod");
+ }
+
/* lttng client socket path */
ret = chown(client_unix_sock_path, 0, gid);
if (ret < 0) {
/* lttng client socket path */
ret = chown(client_unix_sock_path, 0, gid);
if (ret < 0) {
@@
-3993,7
+4000,7
@@
static int create_lttng_rundir(const char *rundir)
DBG3("Creating LTTng run directory: %s", rundir);
DBG3("Creating LTTng run directory: %s", rundir);
- ret = mkdir(rundir, S_IRWXU
| S_IRWXG
);
+ ret = mkdir(rundir, S_IRWXU);
if (ret < 0) {
if (errno != EEXIST) {
ERR("Unable to create %s", rundir);
if (ret < 0) {
if (errno != EEXIST) {
ERR("Unable to create %s", rundir);
@@
-4035,7
+4042,7
@@
static int set_consumer_sockets(struct consumer_data *consumer_data,
DBG2("Creating consumer directory: %s", path);
DBG2("Creating consumer directory: %s", path);
- ret = mkdir(path, S_IRWXU
| S_IRWXG
);
+ ret = mkdir(path, S_IRWXU);
if (ret < 0) {
if (errno != EEXIST) {
ERR("Failed to create %s", path);
if (ret < 0) {
if (errno != EEXIST) {
ERR("Failed to create %s", path);
This page took
0.025601 seconds
and
5
git commands to generate.