SoW-2019-0002: Dynamic Snapshot
[lttng-tools.git] / src / bin / lttng / commands / create.c
index c43ce59b906c7a5f43db8e5fed1f709262951ac6..379ca0a660908c1e3454fafd3d193b83e029e081 100644 (file)
@@ -1,21 +1,12 @@
 /*
- * Copyright (C) 2011 - David Goulet <david.goulet@polymtl.ca>
+ * Copyright (C) 2011 David Goulet <david.goulet@polymtl.ca>
+ * Copyright (C) 2019 Jérémie Galarneau <jeremie.galarneau@efficios.com>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License, version 2 only,
- * as published by the Free Software Foundation.
+ * SPDX-License-Identifier: GPL-2.0-only
  *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#define _GNU_SOURCE
+#define _LGPL_SOURCE
 #include <assert.h>
 #include <ctype.h>
 #include <popt.h>
 #include <string.h>
 #include <sys/stat.h>
 #include <sys/types.h>
-#include <time.h>
+#include <common/compat/time.h>
 #include <unistd.h>
+#include <signal.h>
+#include <sys/wait.h>
+
+#include <common/mi-lttng.h>
 
 #include "../command.h"
 #include "../utils.h"
 #include <common/uri.h>
 #include <common/utils.h>
 #include <lttng/snapshot.h>
+#include <lttng/session-descriptor.h>
 
 static char *opt_output_path;
 static char *opt_session_name;
 static char *opt_url;
 static char *opt_ctrl_url;
 static char *opt_data_url;
+static char *opt_shm_path;
 static int opt_no_consumer;
 static int opt_no_output;
 static int opt_snapshot;
-static unsigned int opt_live_timer;
-static int opt_disable_consumer;
+static uint32_t opt_live_timer;
+
+#ifdef LTTNG_EMBED_HELP
+static const char help_msg[] =
+#include <lttng-create.1.h>
+;
+#endif
 
 enum {
        OPT_HELP = 1,
@@ -53,6 +55,14 @@ enum {
        OPT_LIVE_TIMER,
 };
 
+enum output_type {
+       OUTPUT_NONE,
+       OUTPUT_LOCAL,
+       OUTPUT_NETWORK,
+       OUTPUT_UNSPECIFIED,
+};
+
+static struct mi_writer *writer;
 static struct poptOption long_options[] = {
        /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
        {"help", 'h', POPT_ARG_NONE, NULL, OPT_HELP, NULL, NULL},
@@ -63,171 +73,204 @@ static struct poptOption long_options[] = {
        {"data-url",       'D', POPT_ARG_STRING, &opt_data_url, 0, 0, 0},
        {"no-output",       0, POPT_ARG_VAL, &opt_no_output, 1, 0, 0},
        {"no-consumer",     0, POPT_ARG_VAL, &opt_no_consumer, 1, 0, 0},
-       {"disable-consumer", 0, POPT_ARG_VAL, &opt_disable_consumer, 1, 0, 0},
        {"snapshot",        0, POPT_ARG_VAL, &opt_snapshot, 1, 0, 0},
        {"live",            0, POPT_ARG_INT | POPT_ARGFLAG_OPTIONAL, 0, OPT_LIVE_TIMER, 0, 0},
+       {"shm-path",        0, POPT_ARG_STRING, &opt_shm_path, 0, 0, 0},
        {0, 0, 0, 0, 0, 0, 0}
 };
 
 /*
- * Please have a look at src/lib/lttng-ctl/lttng-ctl.c for more information on
- * why this declaration exists and used ONLY in for this command.
+ * Retrieve the created session and mi output it based on provided argument
+ * This is currently a summary of what was pretty printed and is subject to
+ * enhancements.
  */
-extern int _lttng_create_session_ext(const char *name, const char *url,
-               const char *datetime, int live_timer);
-
-/*
- * usage
- */
-static void usage(FILE *ofp)
+static int mi_created_session(const char *session_name)
 {
-       fprintf(ofp, "usage: lttng create [NAME] [OPTIONS] \n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "Without a given NAME, the default is 'auto-<yyyymmdd>-<hhmmss>'\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "Options:\n");
-       fprintf(ofp, "  -h, --help           Show this help\n");
-       fprintf(ofp, "      --list-options   Simple listing of options\n");
-       fprintf(ofp, "  -o, --output PATH    Specify output path for traces\n");
-       fprintf(ofp, "      --no-output      Traces will not be outputted\n");
-       fprintf(ofp, "      --snapshot       Set the session in snapshot mode.\n");
-       fprintf(ofp, "                       Created in no-output mode and uses the URL,\n");
-       fprintf(ofp, "                       if one, as the default snapshot output.\n");
-       fprintf(ofp, "                       Every channel will be set in overwrite mode\n");
-       fprintf(ofp, "                       and with mmap output (splice not supported).\n");
-       fprintf(ofp, "      --live [USEC]    Set the session in live-reading mode.\n");
-       fprintf(ofp, "                       The delay parameter in micro-seconds is the\n");
-       fprintf(ofp, "                       maximum time the user can wait for the data\n");
-       fprintf(ofp, "                       to be flushed. Can be set with a network\n");
-       fprintf(ofp, "                       URL (-U or -C/-D) and must have a relayd listening.\n");
-       fprintf(ofp, "                       By default, %u is used for the timer and the\n",
-                                                                                       DEFAULT_LTTNG_LIVE_TIMER);
-       fprintf(ofp, "                       network URL is set to net://127.0.0.1.\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "Extended Options:\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "Using these options, each API call can be controlled individually.\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "  -U, --set-url=URL    Set URL destination of the trace data.\n");
-       fprintf(ofp, "                       It is persistent for the session lifetime.\n");
-       fprintf(ofp, "                       This will set both data and control URL.\n");
-       fprintf(ofp, "                       You can change it with the enable-consumer cmd\n");
-       fprintf(ofp, "  -C, --ctrl-url=URL   Set control path URL. (Must use -D also)\n");
-       fprintf(ofp, "  -D, --data-url=URL   Set data path URL. (Must use -C also)\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "Please refer to the man page (lttng(1)) for more information on network\n");
-       fprintf(ofp, "streaming mechanisms and explanation of the control and data port\n");
-       fprintf(ofp, "You must have a running remote lttng-relayd for network streaming\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "URL format is has followed:\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "  proto://[HOST|IP][:PORT1[:PORT2]][/TRACE_PATH]\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "  Supported protocols are (proto):\n");
-       fprintf(ofp, "  > file://...\n");
-       fprintf(ofp, "    Local filesystem full path.\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "  > net[6]://...\n");
-       fprintf(ofp, "    This will use the default network transport layer which is\n");
-       fprintf(ofp, "    TCP for both control (PORT1) and data port (PORT2).\n");
-       fprintf(ofp, "    The default ports are respectively 5342 and 5343.\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "  > tcp[6]://...\n");
-       fprintf(ofp, "    Can only be used with -C and -D together\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "NOTE: IPv6 address MUST be enclosed in brackets '[]' (rfc2732)\n");
-       fprintf(ofp, "\n");
-       fprintf(ofp, "Examples:\n");
-       fprintf(ofp, "    # lttng create -U net://192.168.1.42\n");
-       fprintf(ofp, "    Uses TCP and default ports for the given destination.\n");
-       fprintf(ofp, "    # lttng create -U net6://[fe80::f66d:4ff:fe53:d220]\n");
-       fprintf(ofp, "    Uses TCP, default ports and IPv6.\n");
-       fprintf(ofp, "    # lttng create s1 -U net://myhost.com:3229\n");
-       fprintf(ofp, "    Set the consumer to the remote HOST on port 3229 for control.\n");
-       fprintf(ofp, "\n");
-}
-
-/*
- * For a session name, set the consumer URLs.
- */
-static int set_consumer_url(const char *session_name, const char *ctrl_url,
-               const char *data_url)
-{
-       int ret;
-       struct lttng_handle *handle;
-       struct lttng_domain dom;
+       int ret, i, count, found;
+       struct lttng_session *sessions;
 
+       /* session_name should not be null */
        assert(session_name);
+       assert(writer);
 
-       /*
-        * Set handle with the session name and the domain set to 0. This means to
-        * the session daemon that the next action applies on the tracing session
-        * rather then the domain specific session.
-        */
-       memset(&dom, 0, sizeof(dom));
-
-       handle = lttng_create_handle(session_name, &dom);
-       if (handle == NULL) {
-               ret = CMD_FATAL;
+       count = lttng_list_sessions(&sessions);
+       if (count < 0) {
+               ret = count;
+               ERR("%s", lttng_strerror(ret));
                goto error;
        }
 
-       ret = lttng_set_consumer_url(handle, ctrl_url, data_url);
-       if (ret < 0) {
-               goto error;
+       if (count == 0) {
+               ERR("Error session creation failed: session %s not found", session_name);
+               ret = -LTTNG_ERR_SESS_NOT_FOUND;
+               goto end;
        }
 
-       if (ctrl_url) {
-               MSG("Control URL %s set for session %s", ctrl_url, session_name);
+       found = 0;
+       for (i = 0; i < count; i++) {
+               if (strncmp(sessions[i].name, session_name, NAME_MAX) == 0) {
+                       found = 1;
+                       ret = mi_lttng_session(writer, &sessions[i], 0);
+                       if (ret) {
+                               goto error;
+                       }
+                       break;
+               }
        }
 
-       if (data_url) {
-               MSG("Data URL %s set for session %s", data_url, session_name);
+       if (!found) {
+               ret = -LTTNG_ERR_SESS_NOT_FOUND;
+       } else {
+               ret = CMD_SUCCESS;
        }
 
 error:
-       lttng_destroy_handle(handle);
+       free(sessions);
+end:
        return ret;
 }
 
-static int add_snapshot_output(const char *session_name, const char *ctrl_url,
-               const char *data_url)
+static
+struct lttng_session_descriptor *create_session_descriptor(void)
 {
        int ret;
-       struct lttng_snapshot_output *output = NULL;
-
-       assert(session_name);
+       ssize_t uri_count;
+       enum output_type output_type;
+       struct lttng_uri *uris = NULL;
+       struct lttng_session_descriptor *descriptor = NULL;
+       const char *uri_str1 = NULL, *uri_str2 = NULL;
+       char local_output_path[LTTNG_PATH_MAX] = {};
+
+       if (opt_no_output) {
+               output_type = OUTPUT_NONE;
+       } else if (opt_output_path) {
+               char *expanded_output_path;
+
+               output_type = OUTPUT_LOCAL;
+               expanded_output_path = utils_expand_path(opt_output_path);
+               if (!expanded_output_path) {
+                       ERR("Failed to expand output path.");
+                       goto end;
+               }
+               ret = lttng_strncpy(local_output_path, expanded_output_path,
+                               sizeof(local_output_path));
+               free(expanded_output_path);
+               if (ret) {
+                       ERR("Output path exceeds the maximal supported length (%zu bytes)",
+                                       sizeof(local_output_path));
+                       goto end;
+               }
+       } else if (opt_url || opt_ctrl_url) {
+               uri_str1 = opt_ctrl_url ? opt_ctrl_url : opt_url;
+               uri_str2 = opt_data_url;
 
-       output = lttng_snapshot_output_create();
-       if (!output) {
-               ret = CMD_FATAL;
-               goto error_create;
-       }
+               uri_count = uri_parse_str_urls(uri_str1, uri_str2, &uris);
+               if (uri_count != 1 && uri_count != 2) {
+                       ERR("Unrecognized URL format.");
+                       goto end;
+               }
 
-       if (ctrl_url) {
-               ret = lttng_snapshot_output_set_ctrl_url(ctrl_url, output);
-               if (ret < 0) {
-                       goto error;
+               switch (uri_count) {
+               case 1:
+                       output_type = OUTPUT_LOCAL;
+                       if (uris[0].dtype != LTTNG_DST_PATH) {
+                               ERR("Unrecognized URL format.");
+                               goto end;
+                       }
+                       ret = lttng_strncpy(local_output_path, uris[0].dst.path,
+                                       sizeof(local_output_path));
+                       if (ret) {
+                               ERR("Output path exceeds the maximal supported length (%zu bytes)",
+                                               sizeof(local_output_path));
+                       }
+                       break;
+               case 2:
+                       output_type = OUTPUT_NETWORK;
+                       break;
+               default:
+                       /* Already checked. */
+                       abort();
                }
+       } else {
+               output_type = OUTPUT_UNSPECIFIED;
        }
 
-       if (data_url) {
-               ret = lttng_snapshot_output_set_data_url(data_url, output);
-               if (ret < 0) {
-                       goto error;
+       if (opt_snapshot) {
+               /* Snapshot session. */
+               switch (output_type) {
+               case OUTPUT_UNSPECIFIED:
+               case OUTPUT_LOCAL:
+                       descriptor = lttng_session_descriptor_snapshot_local_create(
+                                       opt_session_name,
+                                       output_type == OUTPUT_LOCAL ?
+                                               local_output_path : NULL);
+                       break;
+               case OUTPUT_NONE:
+                       descriptor = lttng_session_descriptor_snapshot_create(
+                                       opt_session_name);
+                       break;
+               case OUTPUT_NETWORK:
+                       descriptor = lttng_session_descriptor_snapshot_network_create(
+                                       opt_session_name, uri_str1, uri_str2);
+                       break;
+               default:
+                       abort();
+               }
+       } else if (opt_live_timer) {
+               /* Live session. */
+               if (output_type != OUTPUT_UNSPECIFIED &&
+                               output_type != OUTPUT_NETWORK) {
+                       ERR("Unsupported output type specified for live session.");
+                       goto end;
+               }
+               descriptor = lttng_session_descriptor_live_network_create(
+                               opt_session_name, uri_str1, uri_str2,
+                               opt_live_timer);
+       } else {
+               /* Regular session. */
+               switch (output_type) {
+               case OUTPUT_UNSPECIFIED:
+               case OUTPUT_LOCAL:
+                       descriptor = lttng_session_descriptor_local_create(
+                                       opt_session_name,
+                                       output_type == OUTPUT_LOCAL ?
+                                               local_output_path : NULL);
+                       break;
+               case OUTPUT_NONE:
+                       descriptor = lttng_session_descriptor_create(
+                                       opt_session_name);
+                       break;
+               case OUTPUT_NETWORK:
+                       descriptor = lttng_session_descriptor_network_create(
+                                       opt_session_name, uri_str1, uri_str2);
+                       break;
+               default:
+                       abort();
                }
        }
-
-       /* This call, if successful, populates the id of the output object. */
-       ret = lttng_snapshot_add_output(session_name, output);
-       if (ret < 0) {
-               goto error;
+       if (!descriptor) {
+               ERR("Failed to initialize session creation command.");
+       } else {
+               /*
+                * Auto-launch the relay daemon when a live session
+                * is created using default URLs.
+                */
+               if (!opt_url && !opt_ctrl_url && !opt_data_url &&
+                               opt_live_timer && !check_relayd()) {
+                       int ret;
+                       const char *pathname = opt_relayd_path ? :
+                                       INSTALL_BIN_PATH "/lttng-relayd";
+
+                       ret = spawn_relayd(pathname, 0);
+                       if (ret < 0) {
+                               lttng_session_descriptor_destroy(descriptor);
+                               descriptor = NULL;
+                       }
+               }
        }
-
-error:
-       lttng_snapshot_output_destroy(output);
-error_create:
-       return ret;
+end:
+       free(uris);
+       return descriptor;
 }
 
 /*
@@ -238,33 +281,21 @@ error_create:
  */
 static int create_session(void)
 {
-       int ret;
-       char *session_name = NULL, *traces_path = NULL, *alloc_path = NULL;
-       char *alloc_url = NULL, *url = NULL, datetime[16];
-       char session_name_date[NAME_MAX + 17], *print_str_url = NULL;
-       time_t rawtime;
-       struct tm *timeinfo;
-
-       /* Get date and time for automatic session name/path */
-       time(&rawtime);
-       timeinfo = localtime(&rawtime);
-       strftime(datetime, sizeof(datetime), "%Y%m%d-%H%M%S", timeinfo);
-
-       /* Auto session name creation */
-       if (opt_session_name == NULL) {
-               ret = snprintf(session_name_date, sizeof(session_name_date),
-                               DEFAULT_SESSION_NAME "-%s", datetime);
-               if (ret < 0) {
-                       PERROR("snprintf session name");
-                       goto error;
-               }
-               session_name = session_name_date;
-               DBG("Auto session name set to %s", session_name_date);
-       } else {
+       int ret, i;
+       char shm_path[LTTNG_PATH_MAX] = {};
+       struct lttng_session_descriptor *session_descriptor = NULL;
+       enum lttng_session_descriptor_status descriptor_status;
+       enum lttng_error_code ret_code;
+       struct lttng_session *sessions = NULL;
+       const struct lttng_session *created_session = NULL;
+       const char *created_session_name;
+
+       /* Validate options. */
+       if (opt_session_name) {
                if (strlen(opt_session_name) > NAME_MAX) {
                        ERR("Session name too long. Length must be lower or equal to %d",
                                        NAME_MAX);
-                       ret = LTTNG_ERR_SESSION_FAIL;
+                       ret = CMD_ERROR;
                        goto error;
                }
                /*
@@ -282,178 +313,334 @@ static int create_session(void)
                        ret = CMD_ERROR;
                        goto error;
                }
-               session_name = opt_session_name;
-               ret = snprintf(session_name_date, sizeof(session_name_date),
-                               "%s-%s", session_name, datetime);
-               if (ret < 0) {
-                       PERROR("snprintf session name");
-                       goto error;
-               }
+       }
+
+       if (opt_snapshot && opt_live_timer) {
+               ERR("Snapshot and live modes are mutually exclusive.");
+               ret = CMD_ERROR;
+               goto error;
        }
 
        if ((!opt_ctrl_url && opt_data_url) || (opt_ctrl_url && !opt_data_url)) {
-               ERR("You need both control and data URL.");
+               ERR("Both control and data URLs must be specified.");
                ret = CMD_ERROR;
                goto error;
        }
 
-       if (opt_output_path != NULL) {
-               traces_path = utils_expand_path(opt_output_path);
-               if (traces_path == NULL) {
-                       ret = CMD_ERROR;
-                       goto error;
-               }
+       session_descriptor = create_session_descriptor();
+       if (!session_descriptor) {
+               ret = CMD_ERROR;
+               goto error;
+       }
+       ret_code = lttng_create_session_ext(session_descriptor);
+       if (ret_code != LTTNG_OK) {
+               ERR("%s", lttng_strerror(-ret_code));
+               ret = CMD_ERROR;
+               goto error;
+       }
 
-               /* Create URL string from the local filesytem path */
-               ret = asprintf(&alloc_url, "file://%s", traces_path);
-               if (ret < 0) {
-                       PERROR("asprintf url path");
-                       ret = CMD_FATAL;
-                       goto error;
+       descriptor_status = lttng_session_descriptor_get_session_name(
+               session_descriptor, &created_session_name);
+       if (descriptor_status != LTTNG_SESSION_DESCRIPTOR_STATUS_OK) {
+               ERR("Failed to obtain created session name");
+               ret = CMD_ERROR;
+               goto error;
+       }
+
+       ret = lttng_list_sessions(&sessions);
+       if (ret < 0) {
+               ERR("Failed to fetch properties of created session: %s",
+                               lttng_strerror(ret));
+               ret = CMD_ERROR;
+               goto error;
+       }
+       for (i = 0; i < ret; i++) {
+               if (!strcmp(created_session_name, sessions[i].name)) {
+                       created_session = &sessions[i];
+                       break;
                }
-               /* URL to use in the lttng_create_session() call */
-               url = alloc_url;
-               print_str_url = traces_path;
-       } else if (opt_url) { /* Handling URL (-U opt) */
-               url = opt_url;
-               print_str_url = url;
-       } else if (opt_data_url && opt_ctrl_url) {
+       }
+       if (!created_session) {
+               ERR("Failed to fetch properties of created session");
+               ret = CMD_ERROR;
+               goto error;
+       }
+
+       if (opt_shm_path) {
+               char datetime_suffix[17] = {};
+
                /*
-                * With both control and data, we'll be setting the consumer URL after
-                * session creation thus use no URL.
+                * An auto-generated session name already includes the creation
+                * timestamp.
                 */
-               url = NULL;
-       } else if (!opt_no_output) {
-               /* Auto output path */
-               alloc_path = utils_get_home_dir();
-               if (alloc_path == NULL) {
-                       ERR("HOME path not found.\n \
-                                       Please specify an output path using -o, --output PATH");
-                       ret = CMD_FATAL;
-                       goto error;
+               if (opt_session_name) {
+                       uint64_t creation_time;
+                       struct tm *timeinfo;
+                       time_t creation_time_t;
+                       size_t strftime_ret;
+
+                       ret_code = lttng_session_get_creation_time(
+                                       created_session,
+                                       &creation_time);
+                       if (ret_code != LTTNG_OK) {
+                               ERR("%s", lttng_strerror(-ret_code));
+                               ret = CMD_ERROR;
+                               goto error;
+                       }
+                       creation_time_t = (time_t) creation_time;
+                       timeinfo = localtime(&creation_time_t);
+                       if (!timeinfo) {
+                               PERROR("Failed to interpret session creation time");
+                               ret = CMD_ERROR;
+                               goto error;
+                       }
+                       strftime_ret = strftime(datetime_suffix,
+                                       sizeof(datetime_suffix),
+                                       "-%Y%m%d-%H%M%S", timeinfo);
+                       if (strftime_ret == 0) {
+                               ERR("Failed to format session creation time.");
+                               ret = CMD_ERROR;
+                               goto error;
+                       }
                }
-               alloc_path = strdup(alloc_path);
 
-               ret = asprintf(&alloc_url,
-                               "file://%s/" DEFAULT_TRACE_DIR_NAME "/%s",
-                               alloc_path, session_name_date);
+               ret = snprintf(shm_path, sizeof(shm_path),
+                               "%s/%s%s", opt_shm_path, created_session_name,
+                               datetime_suffix);
+               if (ret < 0 || ret >= sizeof(shm_path)) {
+                       ERR("Failed to format the shared memory path.");
+                       ret = CMD_ERROR;
+                       goto error;
+               }
+               ret = lttng_set_session_shm_path(created_session_name,
+                               shm_path);
                if (ret < 0) {
-                       PERROR("asprintf trace dir name");
-                       ret = CMD_FATAL;
+                       lttng_destroy_session(created_session_name);
+                       ret = CMD_ERROR;
                        goto error;
                }
+       }
 
-               url = alloc_url;
-               print_str_url = alloc_url + strlen("file://");
+       if (opt_snapshot) {
+               MSG("Snapshot session %s created.", created_session_name);
+       } else if (opt_live_timer) {
+               MSG("Live session %s created.", created_session_name);
        } else {
-               /* No output means --no-output or --snapshot mode. */
-               url = NULL;
+               MSG("Session %s created.", created_session_name);
        }
 
-       /* Use default live URL if NO url is/are found. */
-       if ((opt_live_timer && !opt_url) && (opt_live_timer && !opt_data_url)) {
-               ret = asprintf(&alloc_url, "net://127.0.0.1");
+       if (*created_session->path && !opt_snapshot) {
+               MSG("Traces will be output to %s", created_session->path);
+
+               if (opt_live_timer) {
+                       MSG("Live timer interval set to %u %s", opt_live_timer,
+                                       USEC_UNIT);
+               }
+       } else if (opt_snapshot) {
+               struct lttng_snapshot_output_list *list;
+               struct lttng_snapshot_output *iter;
+               char snapshot_url[LTTNG_PATH_MAX] = {};
+
+               ret = lttng_snapshot_list_output(created_session_name, &list);
                if (ret < 0) {
-                       PERROR("asprintf default live URL");
-                       ret = CMD_FATAL;
+                       ERR("Failed to list snapshot outputs.");
+                       ret = CMD_ERROR;
                        goto error;
                }
-               url = alloc_url;
-               print_str_url = url;
-       }
-
-       if (opt_snapshot && opt_live_timer) {
-               ERR("Snapshot and live modes are mutually exclusive.");
-               ret = CMD_ERROR;
-               goto error;
-       }
 
-       if (opt_snapshot) {
-               /* No output by default. */
-               const char *snapshot_url = NULL;
+               while ((iter = lttng_snapshot_output_list_get_next(list))) {
+                       const char *url = NULL;
 
-               if (opt_url) {
-                       snapshot_url = url;
-               } else if (!opt_data_url && !opt_ctrl_url) {
-                       /* This is the session path that we need to use as output. */
-                       snapshot_url = url;
+                       url = lttng_snapshot_output_get_ctrl_url(
+                                       iter);
+                       ret = lttng_strncpy(snapshot_url, url,
+                                       sizeof(snapshot_url));
+                       if (ret) {
+                               snapshot_url[0] = '\0';
+                               ERR("Failed to retrieve snapshot output destination");
+                       }
+                       break;
                }
-               ret = lttng_create_session_snapshot(session_name, snapshot_url);
-       } else if (opt_live_timer) {
-               const char *pathname;
+               lttng_snapshot_output_list_destroy(list);
 
-               if (opt_relayd_path) {
-                       pathname = opt_relayd_path;
-               } else {
-                       pathname = INSTALL_BIN_PATH "/lttng-relayd";
+               if (*snapshot_url) {
+                       MSG("Default snapshot output set to %s",
+                                       snapshot_url);
                }
-               if (!opt_url && !opt_data_url && !check_relayd() &&
-                               spawn_relayd(pathname, 0) < 0) {
+               MSG("Every channel enabled for this session will be set to mmap output and default to overwrite mode.");
+       }
+       if (opt_shm_path) {
+               MSG("Shared memory path set to %s", shm_path);
+       }
+
+       /* Mi output */
+       if (lttng_opt_mi) {
+               ret = mi_created_session(created_session_name);
+               if (ret) {
+                       ret = CMD_ERROR;
                        goto error;
                }
-               ret = lttng_create_session_live(session_name, url, opt_live_timer);
-       } else {
-               ret = _lttng_create_session_ext(session_name, url, datetime, -1);
        }
+
+       /* Init lttng session config */
+       ret = config_init(created_session_name);
        if (ret < 0) {
-               /* Don't set ret so lttng can interpret the sessiond error. */
-               switch (-ret) {
-               case LTTNG_ERR_EXIST_SESS:
-                       WARN("Session %s already exists", session_name);
-                       break;
-               default:
-                       break;
-               }
+               ret = CMD_ERROR;
                goto error;
        }
 
-       if (opt_ctrl_url && opt_data_url) {
-               if (opt_snapshot) {
-                       ret = add_snapshot_output(session_name, opt_ctrl_url,
-                                       opt_data_url);
+       ret = CMD_SUCCESS;
+error:
+       lttng_session_descriptor_destroy(session_descriptor);
+       free(sessions);
+       return ret;
+}
+
+/*
+ *  spawn_sessiond
+ *
+ *  Spawn a session daemon by forking and execv.
+ */
+static int spawn_sessiond(const char *pathname)
+{
+       int ret = 0;
+       pid_t pid;
+
+       MSG("Spawning a session daemon");
+       pid = fork();
+       if (pid == 0) {
+               /*
+                * Spawn session daemon in daemon mode.
+                */
+               execlp(pathname, "lttng-sessiond",
+                               "--daemonize", NULL);
+               /* execlp only returns if error happened */
+               if (errno == ENOENT) {
+                       ERR("No session daemon found. Use --sessiond-path.");
                } else {
-                       /* Setting up control URI (-C or/and -D opt) */
-                       ret = set_consumer_url(session_name, opt_ctrl_url, opt_data_url);
+                       PERROR("execlp");
                }
-               if (ret < 0) {
-                       /* Destroy created session because the URL are not valid. */
-                       lttng_destroy_session(session_name);
-                       goto error;
+               kill(getppid(), SIGTERM);       /* wake parent */
+               exit(EXIT_FAILURE);
+       } else if (pid > 0) {
+               /*
+                * In daemon mode (--daemonize), sessiond only exits when
+                * it's ready to accept commands.
+                */
+               for (;;) {
+                       int status;
+                       pid_t wait_pid_ret = waitpid(pid, &status, 0);
+
+                       if (wait_pid_ret < 0) {
+                               if (errno == EINTR) {
+                                       continue;
+                               }
+                               PERROR("waitpid");
+                               ret = -errno;
+                               goto end;
+                       }
+
+                       if (WIFSIGNALED(status)) {
+                               ERR("Session daemon was killed by signal %d",
+                                               WTERMSIG(status));
+                               ret = -1;
+                               goto end;
+                       } else if (WIFEXITED(status)) {
+                               DBG("Session daemon terminated normally (exit status: %d)",
+                                               WEXITSTATUS(status));
+
+                               if (WEXITSTATUS(status) != 0) {
+                                       ERR("Session daemon terminated with an error (exit status: %d)",
+                                                       WEXITSTATUS(status));
+                                       ret = -1;
+                                       goto end;
+                               }
+                               break;
+                       }
                }
+
+               goto end;
+       } else {
+               PERROR("fork");
+               ret = -1;
+               goto end;
        }
 
-       MSG("Session %s created.", session_name);
-       if (print_str_url && !opt_snapshot) {
-               MSG("Traces will be written in %s", print_str_url);
+end:
+       return ret;
+}
 
-               if (opt_live_timer) {
-                       MSG("Live timer set to %u usec", opt_live_timer);
-               }
-       } else if (opt_snapshot) {
-               if (print_str_url) {
-                       MSG("Default snapshot output set to: %s", print_str_url);
-               }
-               MSG("Snapshot mode set. Every channel enabled for that session will "
-                               "be set in overwrite mode and mmap output.");
+/*
+ *  launch_sessiond
+ *
+ *  Check if the session daemon is available using
+ *  the liblttngctl API for the check. If not, try to
+ *  spawn a daemon.
+ */
+static int launch_sessiond(void)
+{
+       int ret;
+       const char *pathname = NULL;
+
+       ret = lttng_session_daemon_alive();
+       if (ret) {
+               /* Sessiond is alive, not an error */
+               ret = 0;
+               goto end;
        }
 
-       /* Init lttng session config */
-       ret = config_init(session_name);
-       if (ret < 0) {
-               ret = CMD_ERROR;
-               goto error;
+       /* Try command line option path */
+       pathname = opt_sessiond_path;
+
+       /* Try LTTNG_SESSIOND_PATH env variable */
+       if (pathname == NULL) {
+               pathname = getenv(DEFAULT_SESSIOND_PATH_ENV);
        }
 
-       ret = CMD_SUCCESS;
+       /* Try with configured path */
+       if (pathname == NULL) {
+               if (CONFIG_SESSIOND_BIN[0] != '\0') {
+                       pathname = CONFIG_SESSIOND_BIN;
+               }
+       }
 
-error:
-       free(alloc_url);
-       free(traces_path);
-       free(alloc_path);
+       /* Try the default path */
+       if (pathname == NULL) {
+               pathname = INSTALL_BIN_PATH "/lttng-sessiond";
+       }
+
+       DBG("Session daemon binary path: %s", pathname);
 
+       /* Check existence and permissions */
+       ret = access(pathname, F_OK | X_OK);
        if (ret < 0) {
-               ERR("%s", lttng_strerror(ret));
+               ERR("No such file or access denied: %s", pathname);
+               goto end;
        }
+
+       ret = spawn_sessiond(pathname);
+end:
+       if (ret) {
+               ERR("Problem occurred while launching session daemon (%s)",
+                               pathname);
+       }
+       return ret;
+}
+
+static
+int validate_url_option_combination(void)
+{
+       int ret = 0;
+       int used_count = 0;
+
+       used_count += !!opt_url;
+       used_count += !!opt_output_path;
+       used_count += (opt_data_url || opt_ctrl_url);
+       if (used_count > 1) {
+               ERR("Only one of the --set-url, --ctrl-url/data-url, or --output options may be used at once.");
+               ret = -1;
+       }
+
        return ret;
 }
 
@@ -464,8 +651,9 @@ error:
  */
 int cmd_create(int argc, const char **argv)
 {
-       int opt, ret = CMD_SUCCESS;
+       int opt, ret = CMD_SUCCESS, command_ret = CMD_SUCCESS, success = 1;
        char *opt_arg = NULL;
+       const char *leftover = NULL;
        static poptContext pc;
 
        pc = poptGetContext(NULL, argc, argv, long_options, 0);
@@ -474,14 +662,14 @@ int cmd_create(int argc, const char **argv)
        while ((opt = poptGetNextOpt(pc)) != -1) {
                switch (opt) {
                case OPT_HELP:
-                       usage(stdout);
+                       SHOW_HELP();
                        goto end;
                case OPT_LIST_OPTIONS:
                        list_cmd_options(stdout, long_options);
                        goto end;
                case OPT_LIVE_TIMER:
                {
-                       unsigned long v;
+                       uint64_t v;
 
                        errno = 0;
                        opt_arg = poptGetOptArg(pc);
@@ -493,52 +681,127 @@ int cmd_create(int argc, const char **argv)
                                break;
                        }
 
-                       v = strtoul(opt_arg, NULL, 0);
-                       if (errno != 0 || !isdigit(opt_arg[0])) {
-                               ERR("Wrong value in --live parameter: %s", opt_arg);
+                       if (utils_parse_time_suffix(opt_arg, &v) < 0) {
+                               ERR("Wrong value for --live parameter: %s", opt_arg);
                                ret = CMD_ERROR;
                                goto end;
                        }
+
                        if (v != (uint32_t) v) {
                                ERR("32-bit overflow in --live parameter: %s", opt_arg);
                                ret = CMD_ERROR;
                                goto end;
                        }
+
+                       if (v == 0) {
+                               ERR("Live timer interval must be greater than zero");
+                               ret = CMD_ERROR;
+                               goto end;
+                       }
+
                        opt_live_timer = (uint32_t) v;
                        DBG("Session live timer interval set to %d", opt_live_timer);
                        break;
                }
                default:
-                       usage(stderr);
                        ret = CMD_UNDEFINED;
                        goto end;
                }
        }
 
-       /* TODO: mi support */
-       if (lttng_opt_mi) {
-               ret = -LTTNG_ERR_MI_NOT_IMPLEMENTED;
-               ERR("mi option not supported");
-               goto end;
-       }
-
        if (opt_no_consumer) {
                MSG("The option --no-consumer is obsolete. Use --no-output now.");
                ret = CMD_WARNING;
                goto end;
        }
 
-       if (opt_disable_consumer) {
-               MSG("The option --disable-consumer is obsolete.");
-               ret = CMD_WARNING;
+       ret = validate_url_option_combination();
+       if (ret) {
+               ret = CMD_ERROR;
                goto end;
        }
 
+       /* Spawn a session daemon if needed */
+       if (!opt_no_sessiond) {
+               ret = launch_sessiond();
+               if (ret) {
+                       ret = CMD_ERROR;
+                       goto end;
+               }
+       }
+
+       /* MI initialization */
+       if (lttng_opt_mi) {
+               writer = mi_lttng_writer_create(fileno(stdout), lttng_opt_mi);
+               if (!writer) {
+                       ret = -LTTNG_ERR_NOMEM;
+                       goto end;
+               }
+
+               /* Open command element */
+               ret = mi_lttng_writer_command_open(writer,
+                               mi_lttng_element_command_create);
+               if (ret) {
+                       ret = CMD_ERROR;
+                       goto end;
+               }
+
+               /* Open output element */
+               ret = mi_lttng_writer_open_element(writer,
+                               mi_lttng_element_command_output);
+               if (ret) {
+                       ret = CMD_ERROR;
+                       goto end;
+               }
+       }
        opt_session_name = (char*) poptGetArg(pc);
 
-       ret = create_session();
+       leftover = poptGetArg(pc);
+       if (leftover) {
+               ERR("Unknown argument: %s", leftover);
+               ret = CMD_ERROR;
+               goto end;
+       }
+
+       command_ret = create_session();
+       if (command_ret) {
+               success = 0;
+       }
+
+       if (lttng_opt_mi) {
+               /* Close  output element */
+               ret = mi_lttng_writer_close_element(writer);
+               if (ret) {
+                       ret = CMD_ERROR;
+                       goto end;
+               }
+
+               /* Success ? */
+               ret = mi_lttng_writer_write_element_bool(writer,
+                               mi_lttng_element_command_success, success);
+               if (ret) {
+                       ret = CMD_ERROR;
+                       goto end;
+               }
+
+               /* Command element close */
+               ret = mi_lttng_writer_command_close(writer);
+               if (ret) {
+                       ret = CMD_ERROR;
+                       goto end;
+               }
+       }
 
 end:
+       /* Mi clean-up */
+       if (writer && mi_lttng_writer_destroy(writer)) {
+               /* Preserve original error code */
+               ret = ret ? ret : -LTTNG_ERR_MI_IO_FAIL;
+       }
+
+       /* Overwrite ret if an error occurred in create_session() */
+       ret = command_ret ? command_ret : ret;
+
        poptFreeContext(pc);
        return ret;
 }
This page took 0.03835 seconds and 5 git commands to generate.