Fix return value and mem leak for all commands

[lttng-tools.git] / src / bin / lttng / commands / start.c

diff --git a/src/bin/lttng/commands/start.c b/src/bin/lttng/commands/start.c
index b2a4980055f4c480a1798b5c599e872a81c1ac93..1db0a31c5b49a48efea44cdbd841d0801849c9f4 100644 (file)
--- a/src/bin/lttng/commands/start.c
+++ b/src/bin/lttng/commands/start.c
@@ -100,7 +100,7 @@ error:
  */
 int cmd_start(int argc, const char **argv)
 {
-       int opt, ret;
+       int opt, ret = CMD_SUCCESS;
        static poptContext pc;
 
        pc = poptGetContext(NULL, argc, argv, long_options, 0);
@@ -109,12 +109,10 @@ int cmd_start(int argc, const char **argv)
        while ((opt = poptGetNextOpt(pc)) != -1) {
                switch (opt) {
                case OPT_HELP:
-                       usage(stderr);
-                       ret = CMD_SUCCESS;
+                       usage(stdout);
                        goto end;
                case OPT_LIST_OPTIONS:
                        list_cmd_options(stdout, long_options);
-                       ret = CMD_SUCCESS;
                        goto end;
                default:
                        usage(stderr);
@@ -128,5 +126,6 @@ int cmd_start(int argc, const char **argv)
        ret = start_tracing();
 
 end:
+       poptFreeContext(pc);
        return ret;
 }