consumerd: cleanup: use buffer view interface for mmap read subbuf
[lttng-tools.git] / src / common / kernel-consumer / kernel-consumer.c
index 9bed7b55b8114357382f983ecd4ff2ebb63aaa31..54314ec75a2c4d7758fd3c3ac2cd4d8492dee893 100644 (file)
@@ -1,22 +1,14 @@
 /*
- * Copyright (C) 2011 Julien Desfossez <julien.desfossez@polymtl.ca>
- *                      Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
- * Copyright (C) 2017 Jérémie Galarneau <jeremie.galarneau@efficios.com>
+ * Copyright (C) 2011 Julien Desfossez <julien.desfossez@polymtl.ca>
+ * Copyright (C) 2011 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
+ * Copyright (C) 2017 Jérémie Galarneau <jeremie.galarneau@efficios.com>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License, version 2 only,
- * as published by the Free Software Foundation.
+ * SPDX-License-Identifier: GPL-2.0-only
  *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "common/buffer-view.h"
+#include <stdint.h>
 #define _LGPL_SOURCE
 #include <assert.h>
 #include <poll.h>
@@ -43,6 +35,7 @@
 #include <common/consumer/consumer-stream.h>
 #include <common/index/index.h>
 #include <common/consumer/consumer-timer.h>
+#include <common/optional.h>
 
 #include "kernel-consumer.h"
 
@@ -122,15 +115,36 @@ int lttng_kconsumer_get_consumed_snapshot(struct lttng_consumer_stream *stream,
        return ret;
 }
 
+static
+int get_current_subbuf_addr(struct lttng_consumer_stream *stream,
+               const char **addr)
+{
+       int ret;
+       unsigned long mmap_offset;
+       const char *mmap_base = stream->mmap_base;
+
+       ret = kernctl_get_mmap_read_offset(stream->wait_fd, &mmap_offset);
+       if (ret < 0) {
+               PERROR("Failed to get mmap read offset");
+               goto error;
+       }
+
+       *addr = mmap_base + mmap_offset;
+error:
+       return ret;
+}
+
 /*
  * Take a snapshot of all the stream of a channel
  * RCU read-side lock must be held across this function to ensure existence of
- * channel.
+ * channel. The channel lock must be held by the caller.
  *
  * Returns 0 on success, < 0 on error
  */
-int lttng_kconsumer_snapshot_channel(struct lttng_consumer_channel *channel,
-               uint64_t key, char *path, uint64_t relayd_id, uint64_t nb_packets_per_stream,
+static int lttng_kconsumer_snapshot_channel(
+               struct lttng_consumer_channel *channel,
+               uint64_t key, char *path, uint64_t relayd_id,
+               uint64_t nb_packets_per_stream,
                struct lttng_consumer_local_data *ctx)
 {
        int ret;
@@ -142,7 +156,8 @@ int lttng_kconsumer_snapshot_channel(struct lttng_consumer_channel *channel,
 
        /* Splice is not supported yet for channel snapshot. */
        if (channel->output != CONSUMER_CHANNEL_MMAP) {
-               ERR("Unsupported output %d", channel->output);
+               ERR("Unsupported output type for channel \"%s\": mmap output is required to record a snapshot",
+                               channel->name);
                ret = -1;
                goto end;
        }
@@ -157,6 +172,19 @@ int lttng_kconsumer_snapshot_channel(struct lttng_consumer_channel *channel,
                 */
                pthread_mutex_lock(&stream->lock);
 
+               assert(channel->trace_chunk);
+               if (!lttng_trace_chunk_get(channel->trace_chunk)) {
+                       /*
+                        * Can't happen barring an internal error as the channel
+                        * holds a reference to the trace chunk.
+                        */
+                       ERR("Failed to acquire reference to channel's trace chunk");
+                       ret = -1;
+                       goto end_unlock;
+               }
+               assert(!stream->trace_chunk);
+               stream->trace_chunk = channel->trace_chunk;
+
                /*
                 * Assign the received relayd ID so we can use it for streaming. The streams
                 * are not visible to anyone so this is OK to change it.
@@ -170,20 +198,13 @@ int lttng_kconsumer_snapshot_channel(struct lttng_consumer_channel *channel,
                                goto end_unlock;
                        }
                } else {
-                       ret = utils_create_stream_file(path, stream->name,
-                                       stream->chan->tracefile_size,
-                                       stream->tracefile_count_current,
-                                       stream->uid, stream->gid, NULL);
+                       ret = consumer_stream_create_output_files(stream,
+                                       false);
                        if (ret < 0) {
-                               ERR("utils_create_stream_file");
                                goto end_unlock;
                        }
-
-                       stream->out_fd = ret;
-                       stream->tracefile_size_current = 0;
-
-                       DBG("Kernel consumer snapshot stream %s/%s (%" PRIu64 ")",
-                                       path, stream->name, stream->key);
+                       DBG("Kernel consumer snapshot stream (%" PRIu64 ")",
+                                       stream->key);
                }
 
                ret = kernctl_buffer_flush_empty(stream->wait_fd);
@@ -221,25 +242,17 @@ int lttng_kconsumer_snapshot_channel(struct lttng_consumer_channel *channel,
                        goto end_unlock;
                }
 
-               if (stream->max_sb_size == 0) {
-                       ret = kernctl_get_max_subbuf_size(stream->wait_fd,
-                                       &stream->max_sb_size);
-                       if (ret < 0) {
-                               ERR("Getting kernel max_sb_size");
-                               goto end_unlock;
-                       }
-               }
-
                consumed_pos = consumer_get_consume_start_pos(consumed_pos,
                                produced_pos, nb_packets_per_stream,
                                stream->max_sb_size);
 
-               while (consumed_pos < produced_pos) {
+               while ((long) (consumed_pos - produced_pos) < 0) {
                        ssize_t read_len;
                        unsigned long len, padded_len;
+                       const char *subbuf_addr;
+                       struct lttng_buffer_view subbuf_view;
 
                        health_code_update();
-
                        DBG("Kernel consumer taking snapshot at pos %lu", consumed_pos);
 
                        ret = kernctl_get_subbuf(stream->wait_fd, &consumed_pos);
@@ -266,7 +279,15 @@ int lttng_kconsumer_snapshot_channel(struct lttng_consumer_channel *channel,
                                goto error_put_subbuf;
                        }
 
-                       read_len = lttng_consumer_on_read_subbuffer_mmap(ctx, stream, len,
+                       ret = get_current_subbuf_addr(stream, &subbuf_addr);
+                       if (ret) {
+                               goto error_put_subbuf;
+                       }
+
+                       subbuf_view = lttng_buffer_view_init(
+                                       subbuf_addr, 0, padded_len);
+                       read_len = lttng_consumer_on_read_subbuffer_mmap(ctx,
+                                       stream, &subbuf_view,
                                        padded_len - len, NULL);
                        /*
                         * We write the padded len in local tracefiles but the data len
@@ -306,6 +327,8 @@ int lttng_kconsumer_snapshot_channel(struct lttng_consumer_channel *channel,
                        close_relayd_stream(stream);
                        stream->net_seq_idx = (uint64_t) -1ULL;
                }
+               lttng_trace_chunk_put(stream->trace_chunk);
+               stream->trace_chunk = NULL;
                pthread_mutex_unlock(&stream->lock);
        }
 
@@ -328,11 +351,12 @@ end:
 /*
  * Read the whole metadata available for a snapshot.
  * RCU read-side lock must be held across this function to ensure existence of
- * metadata_channel.
+ * metadata_channel. The channel lock must be held by the caller.
  *
  * Returns 0 on success, < 0 on error
  */
-static int lttng_kconsumer_snapshot_metadata(struct lttng_consumer_channel *metadata_channel,
+static int lttng_kconsumer_snapshot_metadata(
+               struct lttng_consumer_channel *metadata_channel,
                uint64_t key, char *path, uint64_t relayd_id,
                struct lttng_consumer_local_data *ctx)
 {
@@ -349,7 +373,10 @@ static int lttng_kconsumer_snapshot_metadata(struct lttng_consumer_channel *meta
 
        metadata_stream = metadata_channel->metadata_stream;
        assert(metadata_stream);
+
        pthread_mutex_lock(&metadata_stream->lock);
+       assert(metadata_channel->trace_chunk);
+       assert(metadata_stream->trace_chunk);
 
        /* Flag once that we have a valid relayd for the stream. */
        if (relayd_id != (uint64_t) -1ULL) {
@@ -362,20 +389,17 @@ static int lttng_kconsumer_snapshot_metadata(struct lttng_consumer_channel *meta
                        goto error_snapshot;
                }
        } else {
-               ret = utils_create_stream_file(path, metadata_stream->name,
-                               metadata_stream->chan->tracefile_size,
-                               metadata_stream->tracefile_count_current,
-                               metadata_stream->uid, metadata_stream->gid, NULL);
+               ret = consumer_stream_create_output_files(metadata_stream,
+                               false);
                if (ret < 0) {
                        goto error_snapshot;
                }
-               metadata_stream->out_fd = ret;
        }
 
        do {
                health_code_update();
 
-               ret_read = lttng_kconsumer_read_subbuffer(metadata_stream, ctx, NULL);
+               ret_read = lttng_kconsumer_read_subbuffer(metadata_stream, ctx);
                if (ret_read < 0) {
                        if (ret_read != -EAGAIN) {
                                ERR("Kernel snapshot reading metadata subbuffer (ret: %zd)",
@@ -402,6 +426,8 @@ static int lttng_kconsumer_snapshot_metadata(struct lttng_consumer_channel *meta
                                 */
                        }
                        metadata_stream->out_fd = -1;
+                       lttng_trace_chunk_put(metadata_stream->trace_chunk);
+                       metadata_stream->trace_chunk = NULL;
                }
        }
 
@@ -462,6 +488,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
        {
                struct lttng_consumer_channel *new_channel;
                int ret_recv;
+               const uint64_t chunk_id = msg.u.channel.chunk_id.value;
 
                health_code_update();
 
@@ -476,8 +503,11 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
 
                DBG("consumer_add_channel %" PRIu64, msg.u.channel.channel_key);
                new_channel = consumer_allocate_channel(msg.u.channel.channel_key,
-                               msg.u.channel.session_id, msg.u.channel.pathname,
-                               msg.u.channel.name, msg.u.channel.uid, msg.u.channel.gid,
+                               msg.u.channel.session_id,
+                               msg.u.channel.chunk_id.is_set ?
+                                               &chunk_id : NULL,
+                               msg.u.channel.pathname,
+                               msg.u.channel.name,
                                msg.u.channel.relayd_id, msg.u.channel.output,
                                msg.u.channel.tracefile_size,
                                msg.u.channel.tracefile_count, 0,
@@ -581,14 +611,14 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                ret = consumer_send_status_msg(sock, ret_code);
                if (ret < 0) {
                        /* Somehow, the session daemon is not responding anymore. */
-                       goto error_fatal;
+                       goto error_add_stream_fatal;
                }
 
                health_code_update();
 
                if (ret_code != LTTCOMM_CONSUMERD_SUCCESS) {
                        /* Channel was not found. */
-                       goto end_nosignal;
+                       goto error_add_stream_nosignal;
                }
 
                /* Blocking call */
@@ -596,7 +626,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                ret = lttng_consumer_poll_socket(consumer_sockpoll);
                health_poll_exit();
                if (ret) {
-                       goto error_fatal;
+                       goto error_add_stream_fatal;
                }
 
                health_code_update();
@@ -605,8 +635,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                ret = lttcomm_recv_fds_unix_sock(sock, &fd, 1);
                if (ret != sizeof(fd)) {
                        lttng_consumer_send_error(ctx, LTTCOMM_CONSUMERD_ERROR_RECV_FD);
-                       rcu_read_unlock();
-                       return ret;
+                       goto end;
                }
 
                health_code_update();
@@ -619,24 +648,22 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                ret = consumer_send_status_msg(sock, ret_code);
                if (ret < 0) {
                        /* Somehow, the session daemon is not responding anymore. */
-                       goto end_nosignal;
+                       goto error_add_stream_nosignal;
                }
 
                health_code_update();
 
+               pthread_mutex_lock(&channel->lock);
                new_stream = consumer_allocate_stream(channel->key,
                                fd,
-                               LTTNG_CONSUMER_ACTIVE_STREAM,
                                channel->name,
-                               channel->uid,
-                               channel->gid,
                                channel->relayd_id,
                                channel->session_id,
+                               channel->trace_chunk,
                                msg.u.stream.cpu,
                                &alloc_ret,
                                channel->type,
-                               channel->monitor,
-                               msg.u.stream.trace_archive_id);
+                               channel->monitor);
                if (new_stream == NULL) {
                        switch (alloc_ret) {
                        case -ENOMEM:
@@ -645,11 +672,20 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                                lttng_consumer_send_error(ctx, LTTCOMM_CONSUMERD_OUTFD_ERROR);
                                break;
                        }
-                       goto end_nosignal;
+                       pthread_mutex_unlock(&channel->lock);
+                       goto error_add_stream_nosignal;
                }
 
                new_stream->chan = channel;
                new_stream->wait_fd = fd;
+               ret = kernctl_get_max_subbuf_size(new_stream->wait_fd,
+                               &new_stream->max_sb_size);
+               if (ret < 0) {
+                       pthread_mutex_unlock(&channel->lock);
+                       ERR("Failed to get kernel maximal subbuffer size");
+                       goto error_add_stream_nosignal;
+               }
+
                consumer_stream_update_channel_attributes(new_stream,
                                channel);
                switch (channel->output) {
@@ -657,7 +693,8 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                        new_stream->output = LTTNG_EVENT_SPLICE;
                        ret = utils_create_pipe(new_stream->splice_pipe);
                        if (ret < 0) {
-                               goto end_nosignal;
+                               pthread_mutex_unlock(&channel->lock);
+                               goto error_add_stream_nosignal;
                        }
                        break;
                case CONSUMER_CHANNEL_MMAP:
@@ -665,7 +702,8 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                        break;
                default:
                        ERR("Stream output unknown %d", channel->output);
-                       goto end_nosignal;
+                       pthread_mutex_unlock(&channel->lock);
+                       goto error_add_stream_nosignal;
                }
 
                /*
@@ -690,14 +728,16 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
 
                health_code_update();
 
+               pthread_mutex_lock(&new_stream->lock);
                if (ctx->on_recv_stream) {
                        ret = ctx->on_recv_stream(new_stream);
                        if (ret < 0) {
+                               pthread_mutex_unlock(&new_stream->lock);
+                               pthread_mutex_unlock(&channel->lock);
                                consumer_stream_free(new_stream);
-                               goto end_nosignal;
+                               goto error_add_stream_nosignal;
                        }
                }
-
                health_code_update();
 
                if (new_stream->metadata_flag) {
@@ -710,7 +750,9 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                                        "relayd id %" PRIu64, new_stream->name,
                                        new_stream->net_seq_idx);
                        cds_list_add(&new_stream->send_node, &channel->streams.head);
-                       break;
+                       pthread_mutex_unlock(&new_stream->lock);
+                       pthread_mutex_unlock(&channel->lock);
+                       goto end_add_stream;
                }
 
                /* Send stream to relayd if the stream has an ID. */
@@ -718,8 +760,10 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                        ret = consumer_send_relayd_stream(new_stream,
                                        new_stream->chan->pathname);
                        if (ret < 0) {
+                               pthread_mutex_unlock(&new_stream->lock);
+                               pthread_mutex_unlock(&channel->lock);
                                consumer_stream_free(new_stream);
-                               goto end_nosignal;
+                               goto error_add_stream_nosignal;
                        }
 
                        /*
@@ -731,10 +775,14 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                                ret = consumer_send_relayd_streams_sent(
                                                new_stream->net_seq_idx);
                                if (ret < 0) {
-                                       goto end_nosignal;
+                                       pthread_mutex_unlock(&new_stream->lock);
+                                       pthread_mutex_unlock(&channel->lock);
+                                       goto error_add_stream_nosignal;
                                }
                        }
                }
+               pthread_mutex_unlock(&new_stream->lock);
+               pthread_mutex_unlock(&channel->lock);
 
                /* Get the right pipe where the stream will be sent. */
                if (new_stream->metadata_flag) {
@@ -760,12 +808,17 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                        } else {
                                consumer_del_stream_for_data(new_stream);
                        }
-                       goto end_nosignal;
+                       goto error_add_stream_nosignal;
                }
 
                DBG("Kernel consumer ADD_STREAM %s (fd: %d) %s with relayd id %" PRIu64,
                                new_stream->name, fd, new_stream->chan->pathname, new_stream->relayd_stream_id);
+end_add_stream:
                break;
+error_add_stream_nosignal:
+               goto end_nosignal;
+error_add_stream_fatal:
+               goto error_fatal;
        }
        case LTTNG_CONSUMER_STREAMS_SENT:
        {
@@ -794,7 +847,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                ret = consumer_send_status_msg(sock, ret_code);
                if (ret < 0 || ret_code != LTTCOMM_CONSUMERD_SUCCESS) {
                        /* Somehow, the session daemon is not responding anymore. */
-                       goto end_nosignal;
+                       goto error_streams_sent_nosignal;
                }
 
                health_code_update();
@@ -804,7 +857,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                 * streams in this channel.
                 */
                if (!channel->monitor) {
-                       break;
+                       goto end_error_streams_sent;
                }
 
                health_code_update();
@@ -813,11 +866,14 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                        ret = consumer_send_relayd_streams_sent(
                                        msg.u.sent_streams.net_seq_idx);
                        if (ret < 0) {
-                               goto end_nosignal;
+                               goto error_streams_sent_nosignal;
                        }
                        channel->streams_sent_to_relayd = true;
                }
+end_error_streams_sent:
                break;
+error_streams_sent_nosignal:
+               goto end_nosignal;
        }
        case LTTNG_CONSUMER_UPDATE_STREAM:
        {
@@ -896,6 +952,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                        ERR("Channel %" PRIu64 " not found", key);
                        ret_code = LTTCOMM_CONSUMERD_CHAN_NOT_FOUND;
                } else {
+                       pthread_mutex_lock(&channel->lock);
                        if (msg.u.snapshot_channel.metadata == 1) {
                                ret = lttng_kconsumer_snapshot_metadata(channel, key,
                                                msg.u.snapshot_channel.pathname,
@@ -915,6 +972,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                                        ret_code = LTTCOMM_CONSUMERD_SNAPSHOT_FAILED;
                                }
                        }
+                       pthread_mutex_unlock(&channel->lock);
                }
                health_code_update();
 
@@ -941,14 +999,14 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                ret = consumer_send_status_msg(sock, ret_code);
                if (ret < 0) {
                        /* Somehow, the session daemon is not responding anymore. */
-                       goto end_nosignal;
+                       goto end_destroy_channel;
                }
 
                health_code_update();
 
                /* Stop right now if no channel was found. */
                if (!channel) {
-                       goto end_nosignal;
+                       goto end_destroy_channel;
                }
 
                /*
@@ -964,7 +1022,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                assert(!uatomic_sub_return(&channel->refcount, 1));
 
                consumer_del_channel(channel);
-
+end_destroy_channel:
                goto end_nosignal;
        }
        case LTTNG_CONSUMER_DISCARDED_EVENTS:
@@ -1094,10 +1152,8 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                         * Sample the rotate position of all the streams in this channel.
                         */
                        ret = lttng_consumer_rotate_channel(channel, key,
-                                       msg.u.rotate_channel.pathname,
                                        msg.u.rotate_channel.relayd_id,
                                        msg.u.rotate_channel.metadata,
-                                       msg.u.rotate_channel.new_chunk_id,
                                        ctx);
                        if (ret < 0) {
                                ERR("Rotate channel failed");
@@ -1109,7 +1165,7 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                ret = consumer_send_status_msg(sock, ret_code);
                if (ret < 0) {
                        /* Somehow, the session daemon is not responding anymore. */
-                       goto end_nosignal;
+                       goto error_rotate_channel;
                }
                if (channel) {
                        /* Rotate the streams that are ready right now. */
@@ -1119,162 +1175,185 @@ int lttng_kconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
                                ERR("Rotate ready streams failed");
                        }
                }
-
                break;
+error_rotate_channel:
+               goto end_nosignal;
        }
-       case LTTNG_CONSUMER_ROTATE_RENAME:
+       case LTTNG_CONSUMER_CLEAR_CHANNEL:
        {
-               DBG("Consumer rename session %" PRIu64 " after rotation, old path = \"%s\", new path = \"%s\"",
-                               msg.u.rotate_rename.session_id,
-                               msg.u.rotate_rename.old_path,
-                               msg.u.rotate_rename.new_path);
-               ret = lttng_consumer_rotate_rename(msg.u.rotate_rename.old_path,
-                               msg.u.rotate_rename.new_path,
-                               msg.u.rotate_rename.uid,
-                               msg.u.rotate_rename.gid,
-                               msg.u.rotate_rename.relayd_id);
-               if (ret < 0) {
-                       ERR("Rotate rename failed");
-                       ret_code = LTTCOMM_CONSUMERD_ROTATE_RENAME_FAILED;
-               }
+               struct lttng_consumer_channel *channel;
+               uint64_t key = msg.u.clear_channel.key;
 
-               health_code_update();
+               channel = consumer_find_channel(key);
+               if (!channel) {
+                       DBG("Channel %" PRIu64 " not found", key);
+                       ret_code = LTTCOMM_CONSUMERD_CHAN_NOT_FOUND;
+               } else {
+                       ret = lttng_consumer_clear_channel(channel);
+                       if (ret) {
+                               ERR("Clear channel failed");
+                               ret_code = ret;
+                       }
 
+                       health_code_update();
+               }
                ret = consumer_send_status_msg(sock, ret_code);
                if (ret < 0) {
                        /* Somehow, the session daemon is not responding anymore. */
                        goto end_nosignal;
                }
+
                break;
        }
-       case LTTNG_CONSUMER_CHECK_ROTATION_PENDING_LOCAL:
+       case LTTNG_CONSUMER_INIT:
        {
-               int pending;
-               uint32_t pending_reply;
-
-               DBG("Perform local check of pending rotation for session id %" PRIu64,
-                               msg.u.check_rotation_pending_local.session_id);
-               pending = lttng_consumer_check_rotation_pending_local(
-                               msg.u.check_rotation_pending_local.session_id,
-                               msg.u.check_rotation_pending_local.chunk_id);
-               if (pending < 0) {
-                       ERR("Local rotation pending check failed with code %i", pending);
-                       ret_code = LTTCOMM_CONSUMERD_ROTATION_PENDING_LOCAL_FAILED;
-               } else {
-                       pending_reply = !!pending;
-               }
-
+               ret_code = lttng_consumer_init_command(ctx,
+                               msg.u.init.sessiond_uuid);
                health_code_update();
-
                ret = consumer_send_status_msg(sock, ret_code);
                if (ret < 0) {
                        /* Somehow, the session daemon is not responding anymore. */
                        goto end_nosignal;
                }
-
-               if (pending < 0) {
-                       /*
-                        * An error occurred while running the command;
-                        * don't send the 'pending' flag as the sessiond
-                        * will not read it.
-                        */
-                       break;
-               }
-
-               /* Send back returned value to session daemon */
-               ret = lttcomm_send_unix_sock(sock, &pending_reply,
-                               sizeof(pending_reply));
-               if (ret < 0) {
-                       PERROR("Failed to send rotation pending return code");
-                       goto error_fatal;
-               }
                break;
        }
-       case LTTNG_CONSUMER_CHECK_ROTATION_PENDING_RELAY:
+       case LTTNG_CONSUMER_CREATE_TRACE_CHUNK:
        {
-               int pending;
-               uint32_t pending_reply;
-
-               DBG("Perform relayd check of pending rotation for session id %" PRIu64,
-                               msg.u.check_rotation_pending_relay.session_id);
-               pending = lttng_consumer_check_rotation_pending_relay(
-                               msg.u.check_rotation_pending_relay.session_id,
-                               msg.u.check_rotation_pending_relay.relayd_id,
-                               msg.u.check_rotation_pending_relay.chunk_id);
-               if (pending < 0) {
-                       ERR("Relayd rotation pending check failed with code %i", pending);
-                       ret_code = LTTCOMM_CONSUMERD_ROTATION_PENDING_RELAY_FAILED;
-               } else {
-                       pending_reply = !!pending;
-               }
+               const struct lttng_credentials credentials = {
+                       .uid = msg.u.create_trace_chunk.credentials.value.uid,
+                       .gid = msg.u.create_trace_chunk.credentials.value.gid,
+               };
+               const bool is_local_trace =
+                               !msg.u.create_trace_chunk.relayd_id.is_set;
+               const uint64_t relayd_id =
+                               msg.u.create_trace_chunk.relayd_id.value;
+               const char *chunk_override_name =
+                               *msg.u.create_trace_chunk.override_name ?
+                                       msg.u.create_trace_chunk.override_name :
+                                       NULL;
+               struct lttng_directory_handle *chunk_directory_handle = NULL;
 
-               health_code_update();
+               /*
+                * The session daemon will only provide a chunk directory file
+                * descriptor for local traces.
+                */
+               if (is_local_trace) {
+                       int chunk_dirfd;
 
-               ret = consumer_send_status_msg(sock, ret_code);
-               if (ret < 0) {
-                       /* Somehow, the session daemon is not responding anymore. */
-                       goto end_nosignal;
-               }
+                       /* Acnowledge the reception of the command. */
+                       ret = consumer_send_status_msg(sock,
+                                       LTTCOMM_CONSUMERD_SUCCESS);
+                       if (ret < 0) {
+                               /* Somehow, the session daemon is not responding anymore. */
+                               goto end_nosignal;
+                       }
 
-               if (pending < 0) {
-                       /*
-                        * An error occurred while running the command;
-                        * don't send the 'pending' flag as the sessiond
-                        * will not read it.
-                        */
-                       break;
-               }
+                       ret = lttcomm_recv_fds_unix_sock(sock, &chunk_dirfd, 1);
+                       if (ret != sizeof(chunk_dirfd)) {
+                               ERR("Failed to receive trace chunk directory file descriptor");
+                               goto error_fatal;
+                       }
 
-               /* Send back returned value to session daemon */
-               ret = lttcomm_send_unix_sock(sock, &pending_reply,
-                               sizeof(pending_reply));
-               if (ret < 0) {
-                       PERROR("Failed to send rotation pending return code");
-                       goto error_fatal;
+                       DBG("Received trace chunk directory fd (%d)",
+                                       chunk_dirfd);
+                       chunk_directory_handle = lttng_directory_handle_create_from_dirfd(
+                                       chunk_dirfd);
+                       if (!chunk_directory_handle) {
+                               ERR("Failed to initialize chunk directory handle from directory file descriptor");
+                               if (close(chunk_dirfd)) {
+                                       PERROR("Failed to close chunk directory file descriptor");
+                               }
+                               goto error_fatal;
+                       }
                }
-               break;
+
+               ret_code = lttng_consumer_create_trace_chunk(
+                               !is_local_trace ? &relayd_id : NULL,
+                               msg.u.create_trace_chunk.session_id,
+                               msg.u.create_trace_chunk.chunk_id,
+                               (time_t) msg.u.create_trace_chunk
+                                               .creation_timestamp,
+                               chunk_override_name,
+                               msg.u.create_trace_chunk.credentials.is_set ?
+                                               &credentials :
+                                               NULL,
+                               chunk_directory_handle);
+               lttng_directory_handle_put(chunk_directory_handle);
+               goto end_msg_sessiond;
        }
-       case LTTNG_CONSUMER_MKDIR:
+       case LTTNG_CONSUMER_CLOSE_TRACE_CHUNK:
        {
-               DBG("Consumer mkdir %s in session %" PRIu64,
-                               msg.u.mkdir.path,
-                               msg.u.mkdir.session_id);
-               ret = lttng_consumer_mkdir(msg.u.mkdir.path,
-                               msg.u.mkdir.uid,
-                               msg.u.mkdir.gid,
-                               msg.u.mkdir.relayd_id);
-               if (ret < 0) {
-                       ERR("consumer mkdir failed");
-                       ret_code = LTTCOMM_CONSUMERD_MKDIR_FAILED;
+               enum lttng_trace_chunk_command_type close_command =
+                               msg.u.close_trace_chunk.close_command.value;
+               const uint64_t relayd_id =
+                               msg.u.close_trace_chunk.relayd_id.value;
+               struct lttcomm_consumer_close_trace_chunk_reply reply;
+               char path[LTTNG_PATH_MAX];
+
+               ret_code = lttng_consumer_close_trace_chunk(
+                               msg.u.close_trace_chunk.relayd_id.is_set ?
+                                               &relayd_id :
+                                               NULL,
+                               msg.u.close_trace_chunk.session_id,
+                               msg.u.close_trace_chunk.chunk_id,
+                               (time_t) msg.u.close_trace_chunk.close_timestamp,
+                               msg.u.close_trace_chunk.close_command.is_set ?
+                                               &close_command :
+                                               NULL, path);
+               reply.ret_code = ret_code;
+               reply.path_length = strlen(path) + 1;
+               ret = lttcomm_send_unix_sock(sock, &reply, sizeof(reply));
+               if (ret != sizeof(reply)) {
+                       goto error_fatal;
                }
-
-               health_code_update();
-
-               ret = consumer_send_status_msg(sock, ret_code);
-               if (ret < 0) {
-                       /* Somehow, the session daemon is not responding anymore. */
-                       goto end_nosignal;
+               ret = lttcomm_send_unix_sock(sock, path, reply.path_length);
+               if (ret != reply.path_length) {
+                       goto error_fatal;
                }
-               break;
+               goto end_nosignal;
+       }
+       case LTTNG_CONSUMER_TRACE_CHUNK_EXISTS:
+       {
+               const uint64_t relayd_id =
+                               msg.u.trace_chunk_exists.relayd_id.value;
+
+               ret_code = lttng_consumer_trace_chunk_exists(
+                               msg.u.trace_chunk_exists.relayd_id.is_set ?
+                                               &relayd_id : NULL,
+                               msg.u.trace_chunk_exists.session_id,
+                               msg.u.trace_chunk_exists.chunk_id);
+               goto end_msg_sessiond;
        }
        default:
                goto end_nosignal;
        }
 
 end_nosignal:
-       rcu_read_unlock();
-
        /*
         * Return 1 to indicate success since the 0 value can be a socket
         * shutdown during the recv() or send() call.
         */
-       health_code_update();
-       return 1;
-
+       ret = 1;
+       goto end;
 error_fatal:
-       rcu_read_unlock();
        /* This will issue a consumer stop. */
-       return -1;
+       ret = -1;
+       goto end;
+end_msg_sessiond:
+       /*
+        * The returned value here is not useful since either way we'll return 1 to
+        * the caller because the session daemon socket management is done
+        * elsewhere. Returning a negative code or 0 will shutdown the consumer.
+        */
+       ret = consumer_send_status_msg(sock, ret_code);
+       if (ret < 0) {
+               goto error_fatal;
+       }
+       ret = 1;
+end:
+       health_code_update();
+       rcu_read_unlock();
+       return ret;
 }
 
 /*
@@ -1285,66 +1364,62 @@ error_fatal:
 static int get_index_values(struct ctf_packet_index *index, int infd)
 {
        int ret;
+       uint64_t packet_size, content_size, timestamp_begin, timestamp_end,
+                       events_discarded, stream_id, stream_instance_id,
+                       packet_seq_num;
 
-       ret = kernctl_get_timestamp_begin(infd, &index->timestamp_begin);
+       ret = kernctl_get_timestamp_begin(infd, &timestamp_begin);
        if (ret < 0) {
                PERROR("kernctl_get_timestamp_begin");
                goto error;
        }
-       index->timestamp_begin = htobe64(index->timestamp_begin);
 
-       ret = kernctl_get_timestamp_end(infd, &index->timestamp_end);
+       ret = kernctl_get_timestamp_end(infd, &timestamp_end);
        if (ret < 0) {
                PERROR("kernctl_get_timestamp_end");
                goto error;
        }
-       index->timestamp_end = htobe64(index->timestamp_end);
 
-       ret = kernctl_get_events_discarded(infd, &index->events_discarded);
+       ret = kernctl_get_events_discarded(infd, &events_discarded);
        if (ret < 0) {
                PERROR("kernctl_get_events_discarded");
                goto error;
        }
-       index->events_discarded = htobe64(index->events_discarded);
 
-       ret = kernctl_get_content_size(infd, &index->content_size);
+       ret = kernctl_get_content_size(infd, &content_size);
        if (ret < 0) {
                PERROR("kernctl_get_content_size");
                goto error;
        }
-       index->content_size = htobe64(index->content_size);
 
-       ret = kernctl_get_packet_size(infd, &index->packet_size);
+       ret = kernctl_get_packet_size(infd, &packet_size);
        if (ret < 0) {
                PERROR("kernctl_get_packet_size");
                goto error;
        }
-       index->packet_size = htobe64(index->packet_size);
 
-       ret = kernctl_get_stream_id(infd, &index->stream_id);
+       ret = kernctl_get_stream_id(infd, &stream_id);
        if (ret < 0) {
                PERROR("kernctl_get_stream_id");
                goto error;
        }
-       index->stream_id = htobe64(index->stream_id);
 
-       ret = kernctl_get_instance_id(infd, &index->stream_instance_id);
+       ret = kernctl_get_instance_id(infd, &stream_instance_id);
        if (ret < 0) {
                if (ret == -ENOTTY) {
                        /* Command not implemented by lttng-modules. */
-                       index->stream_instance_id = -1ULL;
+                       stream_instance_id = -1ULL;
                } else {
                        PERROR("kernctl_get_instance_id");
                        goto error;
                }
        }
-       index->stream_instance_id = htobe64(index->stream_instance_id);
 
-       ret = kernctl_get_sequence_number(infd, &index->packet_seq_num);
+       ret = kernctl_get_sequence_number(infd, &packet_seq_num);
        if (ret < 0) {
                if (ret == -ENOTTY) {
                        /* Command not implemented by lttng-modules. */
-                       index->packet_seq_num = -1ULL;
+                       packet_seq_num = -1ULL;
                        ret = 0;
                } else {
                        PERROR("kernctl_get_sequence_number");
@@ -1353,6 +1428,18 @@ static int get_index_values(struct ctf_packet_index *index, int infd)
        }
        index->packet_seq_num = htobe64(index->packet_seq_num);
 
+       *index = (typeof(*index)) {
+               .offset = index->offset,
+               .packet_size = htobe64(packet_size),
+               .content_size = htobe64(content_size),
+               .timestamp_begin = htobe64(timestamp_begin),
+               .timestamp_end = htobe64(timestamp_end),
+               .events_discarded = htobe64(events_discarded),
+               .stream_id = htobe64(stream_id),
+               .stream_instance_id = htobe64(stream_instance_id),
+               .packet_seq_num = htobe64(packet_seq_num),
+       };
+
 error:
        return ret;
 }
@@ -1404,6 +1491,7 @@ int update_stream_stats(struct lttng_consumer_stream *stream)
                if (ret == -ENOTTY) {
                        /* Command not implemented by lttng-modules. */
                        seq = -1ULL;
+                       stream->sequence_number_unavailable = true;
                } else {
                        PERROR("kernctl_get_sequence_number");
                        goto end;
@@ -1494,15 +1582,16 @@ end:
 
 /*
  * Consume data on a file descriptor and write it on a trace file.
+ * The stream and channel locks must be held by the caller.
  */
 ssize_t lttng_kconsumer_read_subbuffer(struct lttng_consumer_stream *stream,
-               struct lttng_consumer_local_data *ctx, bool *rotated)
+               struct lttng_consumer_local_data *ctx)
 {
        unsigned long len, subbuf_size, padding;
        int err, write_index = 1, rotation_ret;
        ssize_t ret = 0;
        int infd = stream->wait_fd;
-       struct ctf_packet_index index;
+       struct ctf_packet_index index = {};
 
        DBG("In read_subbuffer (infd : %d)", infd);
 
@@ -1512,7 +1601,7 @@ ssize_t lttng_kconsumer_read_subbuffer(struct lttng_consumer_stream *stream,
         */
        if (stream->rotate_ready) {
                DBG("Rotate stream before extracting data");
-               rotation_ret = lttng_consumer_rotate_stream(ctx, stream, rotated);
+               rotation_ret = lttng_consumer_rotate_stream(ctx, stream);
                if (rotation_ret < 0) {
                        ERR("Stream rotation error");
                        ret = -1;
@@ -1632,6 +1721,10 @@ ssize_t lttng_kconsumer_read_subbuffer(struct lttng_consumer_stream *stream,
                }
                break;
        case CONSUMER_CHANNEL_MMAP:
+       {
+               const char *subbuf_addr;
+               struct lttng_buffer_view subbuf_view;
+
                /* Get subbuffer size without padding */
                err = kernctl_get_subbuf_size(infd, &subbuf_size);
                if (err != 0) {
@@ -1651,18 +1744,25 @@ ssize_t lttng_kconsumer_read_subbuffer(struct lttng_consumer_stream *stream,
                        goto error;
                }
 
+               ret = get_current_subbuf_addr(stream, &subbuf_addr);
+               if (ret) {
+                       goto error_put_subbuf;
+               }
+
                /* Make sure the tracer is not gone mad on us! */
                assert(len >= subbuf_size);
 
                padding = len - subbuf_size;
 
+               subbuf_view = lttng_buffer_view_init(subbuf_addr, 0, len);
+
                /* write the subbuffer to the tracefile */
-               ret = lttng_consumer_on_read_subbuffer_mmap(ctx, stream, subbuf_size,
-                               padding, &index);
+               ret = lttng_consumer_on_read_subbuffer_mmap(
+                               ctx, stream, &subbuf_view, padding, &index);
                /*
-                * The mmap operation should write subbuf_size amount of data when
-                * network streaming or the full padding (len) size when we are _not_
-                * streaming.
+                * The mmap operation should write subbuf_size amount of data
+                * when network streaming or the full padding (len) size when we
+                * are _not_ streaming.
                 */
                if ((ret != subbuf_size && stream->net_seq_idx != (uint64_t) -1ULL) ||
                                (ret != len && stream->net_seq_idx == (uint64_t) -1ULL)) {
@@ -1677,11 +1777,12 @@ ssize_t lttng_kconsumer_read_subbuffer(struct lttng_consumer_stream *stream,
                        write_index = 0;
                }
                break;
+       }
        default:
                ERR("Unknown output method");
                ret = -EPERM;
        }
-
+error_put_subbuf:
        err = kernctl_put_next_subbuf(infd);
        if (err != 0) {
                if (err == -EFAULT) {
@@ -1736,7 +1837,7 @@ rotate:
         */
        rotation_ret = lttng_consumer_stream_is_rotate_ready(stream);
        if (rotation_ret == 1) {
-               rotation_ret = lttng_consumer_rotate_stream(ctx, stream, rotated);
+               rotation_ret = lttng_consumer_rotate_stream(ctx, stream);
                if (rotation_ret < 0) {
                        ERR("Stream rotation error");
                        ret = -1;
@@ -1759,33 +1860,15 @@ int lttng_kconsumer_on_recv_stream(struct lttng_consumer_stream *stream)
        assert(stream);
 
        /*
-        * Don't create anything if this is set for streaming or should not be
-        * monitored.
+        * Don't create anything if this is set for streaming or if there is
+        * no current trace chunk on the parent channel.
         */
-       if (stream->net_seq_idx == (uint64_t) -1ULL && stream->chan->monitor) {
-               ret = utils_create_stream_file(stream->chan->pathname, stream->name,
-                               stream->chan->tracefile_size, stream->tracefile_count_current,
-                               stream->uid, stream->gid, NULL);
-               if (ret < 0) {
+       if (stream->net_seq_idx == (uint64_t) -1ULL && stream->chan->monitor &&
+                       stream->chan->trace_chunk) {
+               ret = consumer_stream_create_output_files(stream, true);
+               if (ret) {
                        goto error;
                }
-               stream->out_fd = ret;
-               stream->tracefile_size_current = 0;
-
-               if (!stream->metadata_flag) {
-                       struct lttng_index_file *index_file;
-
-                       index_file = lttng_index_file_create(stream->chan->pathname,
-                                       stream->name, stream->uid, stream->gid,
-                                       stream->chan->tracefile_size,
-                                       stream->tracefile_count_current,
-                                       CTF_INDEX_MAJOR, CTF_INDEX_MINOR);
-                       if (!index_file) {
-                               goto error;
-                       }
-                       assert(!stream->index_file);
-                       stream->index_file = index_file;
-               }
        }
 
        if (stream->output == LTTNG_EVENT_MMAP) {
This page took 0.038104 seconds and 5 git commands to generate.