X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=blobdiff_plain;f=include%2Flttng%2Ftracker.h;h=2f1fbd8f4341295f25c22e299bc2594db029f872;hp=a66a2cfce4dea3701fd0cb53fe25329bdd12eb78;hb=refs%2Fheads%2Fsow-2019-0002-rev1;hpb=a7a533cd65d544e8beebabcca5fe906e27af4707

diff --git a/include/lttng/tracker.h b/include/lttng/tracker.h
index a66a2cfce..2f1fbd8f4 100644
--- a/include/lttng/tracker.h
+++ b/include/lttng/tracker.h
@@ -1,25 +1,15 @@
 /*
- * Copyright (C) 2019 - Jonathan Rajotte-Julien <jonathan.rajotte-julien@efficios.com>
+ * Copyright (C) 2019 Jonathan Rajotte-Julien <jonathan.rajotte-julien@efficios.com>
  *
- * This library is free software; you can redistribute it and/or modify it
- * under the terms of the GNU Lesser General Public License, version 2.1 only,
- * as published by the Free Software Foundation.
+ * SPDX-License-Identifier: LGPL-2.1-only
  *
- * This library is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
- * for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this library; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
 #ifndef LTTNG_TRACKER_H
 #define LTTNG_TRACKER_H
 
 #include <lttng/constant.h>
-#include <common/macros.h>
+#include <lttng/session.h>
 
 #ifdef __cplusplus
 extern "C" {
@@ -49,8 +39,14 @@ enum lttng_tracker_id_status {
 	LTTNG_TRACKER_ID_STATUS_UNSET = 1,
 };
 
-struct lttng_handle;
+/*
+ * A tracker id.
+ */
 struct lttng_tracker_id;
+
+/*
+ * A collection of tracker id.
+ */
 struct lttng_tracker_ids;
 
 /*
@@ -101,18 +97,18 @@ extern enum lttng_tracker_id_status lttng_tracker_id_set_all(
 		struct lttng_tracker_id *id);
 
 /*
- * Destroys (frees) a tracker id.
+ * Destroy a tracker id.
  */
 extern void lttng_tracker_id_destroy(struct lttng_tracker_id *id);
 
 /*
- * Returns the type of the tracker id.
+ * Get the type of a tracker id.
  */
 extern enum lttng_tracker_id_type lttng_tracker_id_get_type(
 		const struct lttng_tracker_id *id);
 
 /*
- * Returns the value of the tracker id.
+ * Get the value of a tracker id.
  *
  * Returns LTTNG_TRACKER_ID_OK on success,
  * LTTNG_TRACKER_ID_STATUS_INVALID when the tracker is not of type
@@ -123,7 +119,7 @@ extern enum lttng_tracker_id_status lttng_tracker_id_get_value(
 		const struct lttng_tracker_id *id, int *value);
 
 /*
- * Returns the string representation of the tracker id.
+ * Get the string representation of the tracker id.
  *
  * Returns LTTNG_TRACKER_ID_OK on success,
  * LTTNG_TRACKER_ID_STATUS_INVALID when the tracker is not of type
@@ -157,13 +153,10 @@ extern int lttng_untrack_id(struct lttng_handle *handle,
 		const struct lttng_tracker_id *id);
 
 /*
- * List IDs in the tracker.
+ * List IDs of a tracker.
  *
- * tracker_type is the type of tracker.
- * ids is set to an allocated lttng_tracker_ids representing IDs
- * currently tracked.
- * On success, caller is responsible for freeing ids
- * using lttng_tracker_ids_destroy.
+ * On success, ids is allocated.
+ * The ids collection must be freed by the caller with lttng_destroy_ids().
  *
  * Returns 0 on success, else a negative LTTng error code.
  */
@@ -223,8 +216,12 @@ extern const struct lttng_tracker_id *lttng_tracker_ids_get_at_index(
 
 /*
  * Get the number of tracker id in a tracker id list.
+ *
+ * Return LTTNG_TRACKER_ID_STATUS on sucess,
+ * LTTNG_TRACKER_ID_STATUS_INVALID when passed invalid parameters.
  */
-extern int lttng_tracker_ids_get_count(const struct lttng_tracker_ids *ids);
+extern enum lttng_tracker_id_status lttng_tracker_ids_get_count(
+		const struct lttng_tracker_ids *ids, unsigned int *count);
 
 /*
  * Destroy a tracker id list.