X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=blobdiff_plain;f=ltt-sessiond%2Ftrace.c;h=8b123a79df08073a0c69146b1679a468d24c8c7a;hp=b6138f8f5837ea61b9e9e2fc31d7a2242e81c97e;hb=8e12081b0ef475c304c629257bf4dbee2a826886;hpb=e75cda3acbabc7570777d6e708f43231e7bc4cac diff --git a/ltt-sessiond/trace.c b/ltt-sessiond/trace.c index b6138f8f5..8b123a79d 100644 --- a/ltt-sessiond/trace.c +++ b/ltt-sessiond/trace.c @@ -21,15 +21,13 @@ #include #include #include -#include -#include "lttngerr.h" +#include + #include "trace.h" /* - * get_kernel_channel_by_name - * - * Find the channel name for the given kernel session. + * Find the channel name for the given kernel session. */ struct ltt_kernel_channel *get_kernel_channel_by_name( char *name, struct ltt_kernel_session *session) @@ -53,9 +51,7 @@ error: } /* - * get_kernel_event_by_name - * - * Find the event name for the given channel. + * Find the event name for the given channel. */ struct ltt_kernel_event *get_kernel_event_by_name( char *name, struct ltt_kernel_channel *channel) @@ -80,11 +76,9 @@ error: } /* - * trace_create_kernel_session + * Allocate and initialize a kernel session data structure. * - * Allocate and initialize a kernel session data structure. - * - * Return pointer to structure or NULL. + * Return pointer to structure or NULL. */ struct ltt_kernel_session *trace_create_kernel_session(void) { @@ -103,6 +97,7 @@ struct ltt_kernel_session *trace_create_kernel_session(void) lks->channel_count = 0; lks->stream_count_global = 0; lks->metadata = NULL; + lks->consumer_fd = 0; CDS_INIT_LIST_HEAD(&lks->channel_list.head); return lks; @@ -112,11 +107,9 @@ error: } /* - * trace_create_kernel_channel - * - * Allocate and initialize a kernel channel data structure. + * Allocate and initialize a kernel channel data structure. * - * Return pointer to structure or NULL. + * Return pointer to structure or NULL. */ struct ltt_kernel_channel *trace_create_kernel_channel(struct lttng_channel *chan, char *path) { @@ -138,6 +131,7 @@ struct ltt_kernel_channel *trace_create_kernel_channel(struct lttng_channel *cha lkc->fd = 0; lkc->stream_count = 0; + lkc->event_count = 0; lkc->enabled = 1; lkc->ctx = NULL; /* Init linked list */ @@ -157,11 +151,9 @@ error: } /* - * trace_create_kernel_event + * Allocate and initialize a kernel event. Set name and event type. * - * Allocate and initialize a kernel event. Set name and event type. - * - * Return pointer to structure or NULL. + * Return pointer to structure or NULL. */ struct ltt_kernel_event *trace_create_kernel_event(struct lttng_event *ev) { @@ -182,11 +174,22 @@ struct ltt_kernel_event *trace_create_kernel_event(struct lttng_event *ev) attr->u.kprobe.offset = ev->attr.probe.offset; strncpy(attr->u.kprobe.symbol_name, ev->attr.probe.symbol_name, LTTNG_SYM_NAME_LEN); + attr->u.kprobe.symbol_name[LTTNG_SYM_NAME_LEN - 1] = '\0'; break; case LTTNG_EVENT_FUNCTION: + attr->instrumentation = LTTNG_KERNEL_KRETPROBE; + attr->u.kretprobe.addr = ev->attr.probe.addr; + attr->u.kretprobe.offset = ev->attr.probe.offset; + attr->u.kretprobe.offset = ev->attr.probe.offset; + strncpy(attr->u.kretprobe.symbol_name, + ev->attr.probe.symbol_name, LTTNG_SYM_NAME_LEN); + attr->u.kretprobe.symbol_name[LTTNG_SYM_NAME_LEN - 1] = '\0'; + break; + case LTTNG_EVENT_FUNCTION_ENTRY: attr->instrumentation = LTTNG_KERNEL_FUNCTION; strncpy(attr->u.ftrace.symbol_name, ev->attr.ftrace.symbol_name, LTTNG_SYM_NAME_LEN); + attr->u.ftrace.symbol_name[LTTNG_SYM_NAME_LEN - 1] = '\0'; break; case LTTNG_EVENT_TRACEPOINT: attr->instrumentation = LTTNG_KERNEL_TRACEPOINT; @@ -198,6 +201,7 @@ struct ltt_kernel_event *trace_create_kernel_event(struct lttng_event *ev) /* Copy event name */ strncpy(attr->name, ev->name, LTTNG_SYM_NAME_LEN); + attr->name[LTTNG_SYM_NAME_LEN - 1] = '\0'; /* Setting up a kernel event */ lke->fd = 0; @@ -212,11 +216,9 @@ error: } /* - * trace_create_kernel_metadata + * Allocate and initialize a kernel metadata. * - * Allocate and initialize a kernel metadata. - * - * Return pointer to structure or NULL. + * Return pointer to structure or NULL. */ struct ltt_kernel_metadata *trace_create_kernel_metadata(char *path) { @@ -233,8 +235,8 @@ struct ltt_kernel_metadata *trace_create_kernel_metadata(char *path) /* Set default attributes */ chan->attr.overwrite = DEFAULT_CHANNEL_OVERWRITE; - chan->attr.subbuf_size = DEFAULT_CHANNEL_SUBBUF_SIZE; - chan->attr.num_subbuf = DEFAULT_CHANNEL_SUBBUF_NUM; + chan->attr.subbuf_size = DEFAULT_METADATA_SUBBUF_SIZE; + chan->attr.num_subbuf = DEFAULT_METADATA_SUBBUF_NUM; chan->attr.switch_timer_interval = DEFAULT_CHANNEL_SWITCH_TIMER; chan->attr.read_timer_interval = DEFAULT_CHANNEL_READ_TIMER; chan->attr.output = DEFAULT_KERNEL_CHANNEL_OUTPUT; @@ -256,12 +258,10 @@ error: } /* - * trace_create_kernel_stream - * - * Allocate and initialize a kernel stream. The stream is set to ACTIVE_FD by - * default. + * Allocate and initialize a kernel stream. The stream is set to ACTIVE_FD by + * default. * - * Return pointer to structure or NULL. + * Return pointer to structure or NULL. */ struct ltt_kernel_stream *trace_create_kernel_stream(void) { @@ -284,6 +284,9 @@ error: return NULL; } +/* + * Cleanup kernel stream structure. + */ void trace_destroy_kernel_stream(struct ltt_kernel_stream *stream) { DBG("[trace] Closing stream fd %d", stream->fd); @@ -296,6 +299,9 @@ void trace_destroy_kernel_stream(struct ltt_kernel_stream *stream) free(stream); } +/* + * Cleanup kernel event structure. + */ void trace_destroy_kernel_event(struct ltt_kernel_event *event) { DBG("[trace] Closing event fd %d", event->fd); @@ -309,10 +315,13 @@ void trace_destroy_kernel_event(struct ltt_kernel_event *event) free(event); } +/* + * Cleanup kernel channel structure. + */ void trace_destroy_kernel_channel(struct ltt_kernel_channel *channel) { - struct ltt_kernel_stream *stream; - struct ltt_kernel_event *event; + struct ltt_kernel_stream *stream, *stmp; + struct ltt_kernel_event *event, *etmp; DBG("[trace] Closing channel fd %d", channel->fd); /* Close kernel fd */ @@ -322,12 +331,12 @@ void trace_destroy_kernel_channel(struct ltt_kernel_channel *channel) free(channel->channel); /* For each stream in the channel list */ - cds_list_for_each_entry(stream, &channel->stream_list.head, list) { + cds_list_for_each_entry_safe(stream, stmp, &channel->stream_list.head, list) { trace_destroy_kernel_stream(stream); } /* For each event in the channel list */ - cds_list_for_each_entry(event, &channel->events_list.head, list) { + cds_list_for_each_entry_safe(event, etmp, &channel->events_list.head, list) { trace_destroy_kernel_event(event); } @@ -336,6 +345,9 @@ void trace_destroy_kernel_channel(struct ltt_kernel_channel *channel) free(channel); } +/* + * Cleanup kernel metadata structure. + */ void trace_destroy_kernel_metadata(struct ltt_kernel_metadata *metadata) { DBG("[trace] Closing metadata fd %d", metadata->fd); @@ -347,9 +359,12 @@ void trace_destroy_kernel_metadata(struct ltt_kernel_metadata *metadata) free(metadata); } +/* + * Cleanup kernel session structure + */ void trace_destroy_kernel_session(struct ltt_kernel_session *session) { - struct ltt_kernel_channel *channel; + struct ltt_kernel_channel *channel, *ctmp; DBG("[trace] Closing session fd %d", session->fd); /* Close kernel fds */ @@ -363,7 +378,7 @@ void trace_destroy_kernel_session(struct ltt_kernel_session *session) trace_destroy_kernel_metadata(session->metadata); } - cds_list_for_each_entry(channel, &session->channel_list.head, list) { + cds_list_for_each_entry_safe(channel, ctmp, &session->channel_list.head, list) { trace_destroy_kernel_channel(channel); }