X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=blobdiff_plain;f=lttng%2Fconf.c;h=adc8874866c7a3e7cb739107f9eca75b4ed7ac87;hp=ac1c172964ca263029e0906e02c12e2fa1182bd7;hb=58a97671d5fa65f93126798ded9e5306e3555186;hpb=3087ef18ecb79a3fcef9c8bb8a3e9dc1ea228ff0 diff --git a/lttng/conf.c b/lttng/conf.c index ac1c17296..adc887486 100644 --- a/lttng/conf.c +++ b/lttng/conf.c @@ -29,11 +29,11 @@ #include "lttngerr.h" /* - * get_config_file_path + * config_get_file_path * * Return the path with '/CONFIG_FILENAME' added to it. */ -static char *get_config_file_path(char *path) +char *config_get_file_path(char *path) { int ret; char *file_path; @@ -56,7 +56,7 @@ static FILE *open_config(char *path, const char *mode) FILE *fp = NULL; char *file_path; - file_path = get_config_file_path(path); + file_path = config_get_file_path(path); if (file_path == NULL) { goto error; } @@ -97,32 +97,6 @@ error: return ret; } -/* - * create_config_dir - * - * Create the empty config dir. - */ -static int create_config_dir(char *path) -{ - int ret; - - /* Create session directory .lttng */ - ret = mkdir(path, S_IRWXU | S_IRGRP | S_IXGRP); - if (ret < 0) { - if (errno != EEXIST) { - perror("mkdir config"); - ERR("Couldn't init config directory at %s", path); - ret = -errno; - goto error; - } else { - ret = 0; - } - } - -error: - return ret; -} - /* * write_config * @@ -148,12 +122,11 @@ error: /* * config_get_default_path * - * Return the HOME directory path. The output is dup so the user MUST - * free(3) the returned string. + * Return the HOME directory path. Caller MUST NOT free(3) the return pointer. */ char *config_get_default_path(void) { - return strdup(getenv("HOME")); + return getenv("HOME"); } /* @@ -166,7 +139,10 @@ void config_destroy(char *path) int ret; char *config_path; - config_path = get_config_file_path(path); + config_path = config_get_file_path(path); + if (config_path == NULL) { + return; + } ret = remove(config_path); if (ret < 0) { @@ -241,38 +217,19 @@ error: return ret; } -/* - * config_generate_dir_path - * - * Return allocated path string to path/CONFIG_DIRNAME. - */ -char *config_generate_dir_path(char *path) -{ - int ret; - char *new_path; - - ret = asprintf(&new_path, "%s/%s", path, CONFIG_DIRNAME); - if (ret < 0) { - perror("config path problem"); - goto error; - } - -error: - return new_path; -} - /* * config_init * * Init configuration directory and file. */ -int config_init(char *path) +int config_init(char *session_name) { int ret; + char *path; - /* Create config directory (.lttng) */ - ret = create_config_dir(path); - if (ret < 0) { + path = config_get_default_path(); + if (path == NULL) { + ret = -1; goto error; } @@ -282,6 +239,11 @@ int config_init(char *path) goto error; } + ret = config_add_session_name(path, session_name); + if (ret < 0) { + goto error; + } + DBG("Init config session in %s", path); error: