X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fsession.c;h=e445363ea03d214d90a4f4ded762ad9593d818b1;hp=d30f4ab197ec63b863433070cca01fb1f378ba12;hb=a4b92340642035d1eafeb1eead0ad01f64d2007d;hpb=e74ecf5ad921a3edccacad4d79deb484cd19b1d5 diff --git a/src/bin/lttng-sessiond/session.c b/src/bin/lttng-sessiond/session.c index d30f4ab19..e445363ea 100644 --- a/src/bin/lttng-sessiond/session.c +++ b/src/bin/lttng-sessiond/session.c @@ -45,7 +45,7 @@ static struct ltt_session_list ltt_session_list = { .head = CDS_LIST_HEAD_INIT(ltt_session_list.head), .lock = PTHREAD_MUTEX_INITIALIZER, - .count = 0, + .next_uuid = 0, }; /* @@ -57,15 +57,13 @@ static struct ltt_session_list ltt_session_list = { static unsigned int add_session_list(struct ltt_session *ls) { cds_list_add(&ls->list, <t_session_list.head); - return ++ltt_session_list.count; + return ltt_session_list.next_uuid++; } /* * Delete a ltt_session structure to the global list. * * The caller MUST acquire the session list lock before. - * The session list count CANNOT be decremented, as it is used as unique - * identifier for the session in UST app hash table lookups. */ static void del_session_list(struct ltt_session *ls) { @@ -190,10 +188,11 @@ int session_create(char *name, char *path, uid_t uid, gid_t gid) ret = LTTCOMM_FATAL; goto error_asprintf; } + new_session->start_consumer = 1; } else { - ERR("No session path given"); - ret = LTTCOMM_FATAL; - goto error; + /* No path indicates that there is no use for a consumer. */ + new_session->start_consumer = 0; + new_session->path[0] = '\0'; } /* Init kernel session */ @@ -206,7 +205,7 @@ int session_create(char *name, char *path, uid_t uid, gid_t gid) new_session->uid = uid; new_session->gid = gid; - /* Mkdir if we have a valid path length */ + /* Mkdir if we have a valid path and length */ if (strlen(new_session->path) > 0) { ret = run_as_mkdir_recursive(new_session->path, S_IRWXU | S_IRWXG, new_session->uid, new_session->gid); @@ -224,9 +223,13 @@ int session_create(char *name, char *path, uid_t uid, gid_t gid) new_session->id = add_session_list(new_session); session_unlock_list(); - DBG("Tracing session %s created in %s with ID %u by UID %d GID %d", - name, path, new_session->id, - new_session->uid, new_session->gid); + /* + * Consumer is let to NULL since the create_session_uri command will set it + * up and, if valid, assign it to the session. + */ + + DBG("Tracing session %s created in %s with ID %u by UID %d GID %d", name, + path, new_session->id, new_session->uid, new_session->gid); return LTTCOMM_OK;