X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fconf.c;h=4bcf49e336c18dd79c67d0b4091f608f7d382f89;hp=b6632fcb144c052fa0ef4a9652843a074abd64c7;hb=6c1c0768320135c6936c371b09731851b508c023;hpb=487b253b3ec9f187b4c1b425b246e8e74e5ac309 diff --git a/src/bin/lttng/conf.c b/src/bin/lttng/conf.c index b6632fcb1..4bcf49e33 100644 --- a/src/bin/lttng/conf.c +++ b/src/bin/lttng/conf.c @@ -16,6 +16,7 @@ */ #define _GNU_SOURCE +#define _LGPL_SOURCE #include #include #include @@ -25,6 +26,7 @@ #include #include +#include #include "conf.h" @@ -122,14 +124,6 @@ end: return ret; } -/* - * Returns the HOME directory path. Caller MUST NOT free(3) the return pointer. - */ -char *config_get_default_path(void) -{ - return getenv("HOME"); -} - /* * Destroys directory config and file config. */ @@ -161,7 +155,7 @@ end: */ void config_destroy_default(void) { - char *path = config_get_default_path(); + char *path = utils_get_home_dir(); if (path == NULL) { return; } @@ -193,6 +187,9 @@ char *config_read_session_name(char *path) int ret; FILE *fp; char var[NAME_MAX], *session_name; +#if (NAME_MAX == 255) +#define NAME_MAX_SCANF_IS_A_BROKEN_API "254" +#endif session_name = malloc(NAME_MAX); if (session_name == NULL) { @@ -209,7 +206,9 @@ char *config_read_session_name(char *path) } while (!feof(fp)) { - if ((ret = fscanf(fp, "%[^'=']=%s\n", var, session_name)) != 2) { + if ((ret = fscanf(fp, "%" NAME_MAX_SCANF_IS_A_BROKEN_API + "[^'=']=%" NAME_MAX_SCANF_IS_A_BROKEN_API "s\n", + var, session_name)) != 2) { if (ret == -1) { ERR("Missing session=NAME in config file."); goto error_close; @@ -277,7 +276,7 @@ int config_init(char *session_name) int ret; char *path; - path = config_get_default_path(); + path = utils_get_home_dir(); if (path == NULL) { ret = -1; goto error;