X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fconf.c;h=f96be3a8175a248e8c1e6187e8e5fc5e96c8b270;hp=7e6c833449857890fa7c8e8a092eaf97d439a750;hb=1dac0189ed7311146ff2cfc6605bac81213ee90b;hpb=5d5baaa365798454df0fa41879399dd88a8413c1 diff --git a/src/bin/lttng/conf.c b/src/bin/lttng/conf.c index 7e6c83344..f96be3a81 100644 --- a/src/bin/lttng/conf.c +++ b/src/bin/lttng/conf.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include @@ -177,14 +178,10 @@ int config_exists(const char *path) return S_ISREG(info.st_mode) || S_ISDIR(info.st_mode); } -/* - * Returns the session name from the config file. - * The caller is responsible for freeing the returned string. - * On error, NULL is returned. - */ -char *config_read_session_name(char *path) +static +int _config_read_session_name(char *path, char **name) { - int ret; + int ret = 0; FILE *fp; char var[NAME_MAX], *session_name; #if (NAME_MAX == 255) @@ -193,15 +190,14 @@ char *config_read_session_name(char *path) session_name = zmalloc(NAME_MAX); if (session_name == NULL) { + ret = -ENOMEM; ERR("Out of memory"); goto error; } fp = open_config(path, "r"); if (fp == NULL) { - ERR("Can't find valid lttng config %s/.lttngrc", path); - MSG("Did you create a session? (lttng create )"); - free(session_name); + ret = -ENOENT; goto error; } @@ -222,22 +218,54 @@ char *config_read_session_name(char *path) } error_close: - free(session_name); - ret = fclose(fp); - if (ret < 0) { + if (fclose(fp) < 0) { PERROR("close config read session name"); } - error: - return NULL; - + free(session_name); + return ret; found: - ret = fclose(fp); - if (ret < 0) { + *name = session_name; + if (fclose(fp) < 0) { PERROR("close config read session name found"); } - return session_name; + return ret; +} + +/* + * Returns the session name from the config file. + * + * The caller is responsible for freeing the returned string. + * On error, NULL is returned. + */ +char *config_read_session_name(char *path) +{ + int ret; + char *name = NULL; + + ret = _config_read_session_name(path, &name); + if (ret == -ENOENT) { + const char *home_dir = utils_get_home_dir(); + + ERR("Can't find valid lttng config %s/.lttngrc", home_dir); + MSG("Did you create a session? (lttng create )"); + } + + return name; +} + +/* + * Returns the session name from the config file. (no warnings/errors emitted) + * + * The caller is responsible for freeing the returned string. + * On error, NULL is returned. + */ +char *config_read_session_name_quiet(char *path) +{ + char *name = NULL; + (void) _config_read_session_name(path, &name); + return name; } /*