X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fcommon%2Freadwrite.c;h=42a048fdabd2d3abaf0e32d561f9cb901930baff;hp=0098f759b2d57dc156088126d457a86226517e65;hb=a3eae3c98f047a8e795a01471adf8f4f7563947b;hpb=aeb162609d6ef1f16ec0e818d3750eb6dfff8b30

diff --git a/src/common/readwrite.c b/src/common/readwrite.c
index 0098f759b..42a048fda 100644
--- a/src/common/readwrite.c
+++ b/src/common/readwrite.c
@@ -15,8 +15,10 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#define _LGPL_SOURCE
 #include <assert.h>
 #include <errno.h>
+#include <limits.h>
 #include <unistd.h>
 
 #include "readwrite.h"
@@ -29,14 +31,22 @@
  * error occured.
  * The error can be checked by querying errno.
  */
+LTTNG_HIDDEN
 ssize_t lttng_read(int fd, void *buf, size_t count)
 {
 	size_t i = 0;
 	ssize_t ret;
 
-	assert(fd >= 0);
 	assert(buf);
 
+	/*
+	 * Deny a read count that can be bigger then the returned value max size.
+	 * This makes the function to never return an overflow value.
+	 */
+	if (count > SSIZE_MAX) {
+		return -EINVAL;
+	}
+
 	do {
 		ret = read(fd, buf + i, count - i);
 		if (ret < 0) {
@@ -59,14 +69,22 @@ error:
 	}
 }
 
+LTTNG_HIDDEN
 ssize_t lttng_write(int fd, const void *buf, size_t count)
 {
 	size_t i = 0;
 	ssize_t ret;
 
-	assert(fd >= 0);
 	assert(buf);
 
+	/*
+	 * Deny a write count that can be bigger then the returned value max size.
+	 * This makes the function to never return an overflow value.
+	 */
+	if (count > SSIZE_MAX) {
+		return -EINVAL;
+	}
+
 	do {
 		ret = write(fd, buf + i, count - i);
 		if (ret < 0) {