Fix: Parenthesize previous statement when adding conditions to a filter
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 28 Aug 2014 16:53:43 +0000 (12:53 -0400)
committerDavid Goulet <dgoulet@efficios.com>
Wed, 3 Sep 2014 18:52:00 +0000 (14:52 -0400)
commitfb0edb23588244609bc2e7552e8c3a07af13f540
treec75a225f855452819415d031fb41757d6633675a
parent3b4a6e401ee2df275299aa0460f0ae5b693f8aba
Fix: Parenthesize previous statement when adding conditions to a filter

Not parenthesizing the clauses in a filter string causes JUL events to be
traced even though they are not enabled when an enable-event command is
issued with a filter and the --loglevel-only option.

For instance,

lttng enable-event -j "my_event" --loglevel-only JUL_CONFIG -f "int_loglevel > 0 || int_loglevel < 0"

results in the following filter being applied:

int_loglevel > 0 || int_loglevel < 0 && logger_name == "my_event" && int_loglevel == 700

The resulting expression will always evaluate to true, regardless of the logger
name.

This fix parenthesizes each clause to ensure they are all independently
evaluated and not unintuitively affected by operator precedence.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
src/lib/lttng-ctl/lttng-ctl.c
This page took 0.026271 seconds and 5 git commands to generate.