Fix: run_command_wait() handle partial write

Use lttng_write() to handle partial writes (writing less than the
requested amount of bytes) as well as ret = -1, errno = EINTR.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/bin/lttng-sessiond/notification-thread-commands.c b/src/bin/lttng-sessiond/notification-thread-commands.c
index 11275ffc0e89f22c1f7cae596e2b8dbb30d880de..129cf4ee2def83df575cf6d170d327dc6544dc5a 100644 (file)
--- a/src/bin/lttng-sessiond/notification-thread-commands.c
+++ b/src/bin/lttng-sessiond/notification-thread-commands.c
@@ -44,9 +44,9 @@ int run_command_wait(struct notification_thread_handle *handle,
        cds_list_add_tail(&cmd->cmd_list_node,
                        &handle->cmd_queue.list);
        /* Wake-up thread. */
        cds_list_add_tail(&cmd->cmd_list_node,
                        &handle->cmd_queue.list);
        /* Wake-up thread. */

-       ret = write(lttng_pipe_get_writefd(handle->cmd_queue.event_pipe),
+       ret = lttng_write(lttng_pipe_get_writefd(handle->cmd_queue.event_pipe),

                        &notification_counter, sizeof(notification_counter));
                        &notification_counter, sizeof(notification_counter));

-       if (ret < 0) {
+       if (ret != sizeof(notification_counter)) {

                PERROR("write to notification thread's queue event fd");
                /*
                 * Remove the command from the list so the notification
                PERROR("write to notification thread's queue event fd");
                /*
                 * Remove the command from the list so the notification