Clean-up: consumerd: remove unreachable code

1412204 Logically dead code

The indicated dead code may have performed some action; that action
will never occur.

In consumer_clear_unmonitored_channel: Code can never be reached
because of a logical contradiction (CWE-561)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I116ba5127bf30d3cee1e5f002d7360bc4bc22098

diff --git a/src/common/consumer/consumer.c b/src/common/consumer/consumer.c
index b649d198aaad9c49ed139eb7d2520ce1c28f5373..c6eb71d57807354e729a9f220b02e18d07aaf6ab 100644 (file)
--- a/src/common/consumer/consumer.c
+++ b/src/common/consumer/consumer.c
@@ -4272,11 +4272,6 @@ error_unlock:
        pthread_mutex_unlock(&stream->lock);
        pthread_mutex_unlock(&channel->lock);
        rcu_read_unlock();
-       if (ret) {
-               goto error;
-       }
-       ret = LTTCOMM_CONSUMERD_SUCCESS;
-error:
        return ret;
 }