Tests: possible NULL dereference in rotation notification test
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Fri, 24 Aug 2018 18:09:52 +0000 (14:09 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Fri, 24 Aug 2018 18:09:52 +0000 (14:09 -0400)
Reported-by: Coverity Scan (1395166 Dereference after null check)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
tests/regression/tools/notification/rotation.c

index c9f5de4974375bff948f52d55460fca6dcb2e92f..fb516f31f7c4efeb0fa1954f5fceade8365dac12 100644 (file)
@@ -322,10 +322,11 @@ int test_notification(
 
        location_status = lttng_trace_archive_location_local_get_absolute_path(
                        location, &chunk_path);
-       ok(location_status == LTTNG_TRACE_ARCHIVE_LOCATION_STATUS_OK,
+       ok(location_status == LTTNG_TRACE_ARCHIVE_LOCATION_STATUS_OK && chunk_path,
                        "Retrieved path from location returned by the session rotation completed notification");
        diag("Chunk available at %s", chunk_path ? chunk_path : "NULL");
-       ok(!strncmp(session->output_path, chunk_path, strlen(session->output_path)),
+
+       ok(chunk_path && !strncmp(session->output_path, chunk_path, strlen(session->output_path)),
                        "Returned path from location starts with the output path");
 
 end:
This page took 0.028008 seconds and 5 git commands to generate.