Fix: uninitialized variable may be used in local rotation check

** CID 1395985:  Uninitialized variables  (UNINIT)

'ret' may be left uninitialized if no consumer daemons are
iterated-upon to perform a local rotation pending check.

In practice this wont' happen as that would mean that the
ltt_session has no user space nor kernel session action, thus
no rotation would be launched.

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/bin/lttng-sessiond/rotation-thread.c b/src/bin/lttng-sessiond/rotation-thread.c
index 2dfd9735741b7f12111a5af45e6dee346bf631dd..3747ebae7fe337713c1758ad08fe2b8c1c775f10 100644 (file)
--- a/src/bin/lttng-sessiond/rotation-thread.c
+++ b/src/bin/lttng-sessiond/rotation-thread.c
@@ -394,7 +394,7 @@ int check_session_rotation_pending_local_on_consumer(
 static
 int check_session_rotation_pending_local(struct ltt_session *session)
 {
 static
 int check_session_rotation_pending_local(struct ltt_session *session)
 {

-       int ret;
+       int ret = 0;

        struct consumer_socket *socket;
        struct cds_lfht_iter iter;
        bool rotation_completed = true;
        struct consumer_socket *socket;
        struct cds_lfht_iter iter;
        bool rotation_completed = true;