Comment why we cannot rmdir the lttng and relayd rundir

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

diff --git a/src/bin/lttng-relayd/health-relayd.c b/src/bin/lttng-relayd/health-relayd.c
index 61e50367cb0eb1bfeadeb1e549468d180145afa0..6b4a742f8e5fa95066e29b3e922ff13bd449eb31 100644 (file)
--- a/src/bin/lttng-relayd/health-relayd.c
+++ b/src/bin/lttng-relayd/health-relayd.c
@@ -385,6 +385,11 @@ error:
                }
        }
 
+       /*
+        * We do NOT rmdir rundir nor the relayd path because there are
+        * other processes using them.
+        */
+
        lttng_poll_clean(&events);
 
        rcu_unregister_thread();

diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
index a790844a1a484e3745305f91999ca98da8d390e3..54b47567dea05cbc2acf0e7796a499134d2cb987 100644 (file)
--- a/src/bin/lttng-sessiond/main.c
+++ b/src/bin/lttng-sessiond/main.c
@@ -499,6 +499,12 @@ static void cleanup(void)
        DBG("Removing directory %s", path);
        (void) rmdir(path);
 
+       /*
+        * We do NOT rmdir rundir because there are other processes
+        * using it, for instance lttng-relayd, which can start in
+        * parallel with this teardown.
+        */
+
        free(rundir);
 
        DBG("Cleaning up all sessions");