Fix: unreported error on rotate timer stop failure
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 20 Aug 2018 18:51:45 +0000 (14:51 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 20 Aug 2018 18:51:45 +0000 (14:51 -0400)
A missing 'goto end' causes errors occuring when stopping
the sessiond's rotate timer to be ignored as the switch-case's
case breaks and the 'ret' value is set to LTTNG_OK.

Reported-by: Coverity Scan (1395074 Unused value)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/bin/lttng-sessiond/cmd.c

index ba7dd3d4dd9452b92328547f7f09e24a7e389cf1..6262750866db73d16f193ebe00e7c34475a1e3c7 100644 (file)
@@ -4903,6 +4903,7 @@ int cmd_rotation_set_schedule(struct ltt_session *session,
                        if (ret) {
                                ERR("Failed to disable session rotation timer in ROTATION_SET_SCHEDULE command");
                                ret = LTTNG_ERR_UNK;
+                               goto end;
                        }
                }
                break;
This page took 0.028226 seconds and 5 git commands to generate.