From: Jérémie Galarneau Date: Mon, 15 May 2017 14:37:18 +0000 (-0400) Subject: Fix: status_loc argument of waitpid() is used on error X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=commitdiff_plain;h=1640c24c73ed9c061d8d148dfa18cfc5fd3b080b Fix: status_loc argument of waitpid() is used on error waitpid() may leave stat_loc uninitialized on error (depending on errno's value, see WAIT(3)). Signed-off-by: Jérémie Galarneau --- diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index b856e126f..d9355b019 100644 --- a/src/bin/lttng-sessiond/main.c +++ b/src/bin/lttng-sessiond/main.c @@ -600,8 +600,7 @@ static void wait_consumer(struct consumer_data *consumer_data) ret = waitpid(consumer_data->pid, &status, 0); if (ret == -1) { PERROR("consumerd waitpid pid: %d", consumer_data->pid) - } - if (!WIFEXITED(status)) { + } else if (!WIFEXITED(status)) { ERR("consumerd termination with error: %d", WEXITSTATUS(ret)); }