From: Jonathan Rajotte Date: Fri, 18 May 2018 21:45:57 +0000 (-0400) Subject: Fix: cmd line options overwrite env variable config options X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=commitdiff_plain;h=2788b49461149181a831ef23eb160921593e15fb Fix: cmd line options overwrite env variable config options The doc is clear about the order of precedence regarding configuration. The command line options always override any config file or configuration by environment variables. Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau --- diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index 3d2cad936..e032e037c 100644 --- a/src/bin/lttng-sessiond/main.c +++ b/src/bin/lttng-sessiond/main.c @@ -5830,6 +5830,12 @@ int main(int argc, char **argv) goto exit_set_signal_handler; } + /* + * Init config from environment variables. + * Command line option override env configuration per-doc. Do env first. + */ + sessiond_config_apply_env_config(&config); + /* * Parse arguments and load the daemon configuration file. * @@ -5844,9 +5850,6 @@ int main(int argc, char **argv) goto exit_options; } - /* Init config from environment variables. */ - sessiond_config_apply_env_config(&config); - /* * Resolve all paths received as arguments, configuration option, or * through environment variable as absolute paths. This is necessary