From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Thu, 18 Jul 2019 20:11:59 +0000 (-0400)
Subject: relayd: remove unnecessary allocation in session path formatting
X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=commitdiff_plain;h=b729f6f9f053b2314204b48e7d350738ae548c5d

relayd: remove unnecessary allocation in session path formatting

`alloc_path` merely contains the contents of `default_path`.
The allocation of `alloc_path` can be removed and `default_path`
used in its place.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-relayd/utils.c b/src/bin/lttng-relayd/utils.c
index 837c828d2..7ae0879e5 100644
--- a/src/bin/lttng-relayd/utils.c
+++ b/src/bin/lttng-relayd/utils.c
@@ -33,7 +33,6 @@ static char *create_output_path_auto(const char *path_name)
 {
 	int ret;
 	char *traces_path = NULL;
-	char *alloc_path = NULL;
 	char *default_path;
 
 	default_path = utils_get_home_dir();
@@ -42,19 +41,13 @@ static char *create_output_path_auto(const char *path_name)
 				Please specify an output path using -o, --output PATH");
 		goto exit;
 	}
-	alloc_path = strdup(default_path);
-	if (alloc_path == NULL) {
-		PERROR("Path allocation");
-		goto exit;
-	}
 	ret = asprintf(&traces_path, "%s/" DEFAULT_TRACE_DIR_NAME
-			"/%s", alloc_path, path_name);
+			"/%s", default_path, path_name);
 	if (ret < 0) {
 		PERROR("asprintf trace dir name");
 		goto exit;
 	}
 exit:
-	free(alloc_path);
 	return traces_path;
 }