From: Francis Deslauriers Date: Tue, 7 Jan 2020 23:09:46 +0000 (-0500) Subject: track-untrack.c: error out on unknown CLI options X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=commitdiff_plain;h=c47a705beb4d03d1a7498802047f6410814dced3;hp=c47a705beb4d03d1a7498802047f6410814dced3 track-untrack.c: error out on unknown CLI options Issue ===== At the moment, it's possible to have unknown options in the `track` and `untrack` commands. They are silently ignored. For example, the following command line is accepted without problem: lttng untrack HELLO -k --all --pid This was witnessed in the `test_event_tracker` tests. The `lttng_track()` and `lttng_untrack() functions in `tests/utils/util.sh` are currently passing the `$1` bash variable of the function to the `track` and `untrack` througth their "$@" variable. The commands should not silently accept those unknown options. Fix === 1. After looping on all the known options, check if there is any leftover options and error out if it's the case. 2. Fix the `utils.sh` functions to that they don't pass the `$1` variable to the commands. Signed-off-by: Francis Deslauriers Change-Id: I822ba09c8ce1ffa8366c586e760a9257e8078e43 Signed-off-by: Jérémie Galarneau ---