From: Jonathan Rajotte Date: Wed, 4 Sep 2019 22:29:58 +0000 (-0400) Subject: Fix: chunk state is not set when relayd does not support trace chunks X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=commitdiff_plain;h=caa15afd11d8545ea2cae5650947386fbc07af64 Fix: chunk state is not set when relayd does not support trace chunks Being explicit here enforces that for a lttng-relayd that does not support chunks, the queried chunk will never exist. This caused a lttng destroy command to hang during backward compatibility testing with older lttng-relayd. Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau --- diff --git a/src/common/relayd/relayd.c b/src/common/relayd/relayd.c index 49997015e..a9c2bb2c3 100644 --- a/src/common/relayd/relayd.c +++ b/src/common/relayd/relayd.c @@ -1480,6 +1480,8 @@ int relayd_trace_chunk_exists(struct lttcomm_relayd_sock *sock, if (!relayd_supports_chunks(sock)) { DBG("Refusing to check for trace chunk existence: relayd does not support chunks"); + /* The chunk will never exist */ + *chunk_exists = false; goto end; }