From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Sat, 6 May 2017 18:54:33 +0000 (-0400)
Subject: Silence bogus Coverity warning of uninitialized value
X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=commitdiff_plain;h=d184b96cb8d5bd26fcef718acc447eb55f10ed08

Silence bogus Coverity warning of uninitialized value

Coverity complains that struct lttng_condition_comm's payload
field is not initialized. "payload" is a flexible array
member which should be ignored. Normally, a such a member
_could_ result in additional padding added at the end of the
structure. In this case, the structure is declared as packed.

Nonetheless, using a designated initializer gets rid of the
ambiguity and silences Coverity.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/condition.c b/src/common/condition.c
index 0b184422a..ceab81eab 100644
--- a/src/common/condition.c
+++ b/src/common/condition.c
@@ -66,14 +66,15 @@ ssize_t lttng_condition_serialize(const struct lttng_condition *condition,
 		char *buf)
 {
 	ssize_t ret, condition_size;
-	struct lttng_condition_comm condition_comm;
+	struct lttng_condition_comm condition_comm = {
+		.condition_type = (int8_t) condition->type
+	};
 
 	if (!condition) {
 		ret = -1;
 		goto end;
 	}
 
-	condition_comm.condition_type = (int8_t) condition->type;
 	ret = sizeof(struct lttng_condition_comm);
 	if (buf) {
 		memcpy(buf, &condition_comm, ret);