From: Jérémie Galarneau Date: Thu, 14 Apr 2016 19:35:33 +0000 (-0400) Subject: Add comment describing ioctl number duplication X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=commitdiff_plain;h=d2b102df1d8edd7b6ff9ef3083308da5190e50af Add comment describing ioctl number duplication Signed-off-by: Jérémie Galarneau --- diff --git a/src/common/kernel-ctl/kernel-ioctl.h b/src/common/kernel-ctl/kernel-ioctl.h index 15308ac40..68056dcf1 100644 --- a/src/common/kernel-ctl/kernel-ioctl.h +++ b/src/common/kernel-ctl/kernel-ioctl.h @@ -127,6 +127,11 @@ _IOR(0xF6, 0x58, int32_t) #define LTTNG_KERNEL_SESSION_UNTRACK_PID \ _IOR(0xF6, 0x59, int32_t) +/* + * ioctl 0x58 and 0x59 are duplicated here. It works, since _IOR vs _IO + * are generating two different ioctl numbers, but this was not done on + * purpose. We should generally try to avoid those duplications. + */ #define LTTNG_KERNEL_SESSION_LIST_TRACKER_PIDS _IO(0xF6, 0x58) #define LTTNG_KERNEL_SESSION_METADATA_REGEN _IO(0xF6, 0x59)