From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Thu, 30 Nov 2017 22:45:30 +0000 (+0100)
Subject: Fix: unknown consumer type considered a libc error
X-Git-Url: http://git.efficios.com/?p=lttng-tools.git;a=commitdiff_plain;h=db58870b8a78ae1a466949318f1a7c9ef1ba3b3e

Fix: unknown consumer type considered a libc error

The PERROR() macro uses the errno variable to print an error
message. However, the consumer type being invalid is an internal
error. The value of errno, at that point, is unrelated to the
error.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
index 9f0bcdc41..3c2d2a756 100644
--- a/src/bin/lttng-sessiond/main.c
+++ b/src/bin/lttng-sessiond/main.c
@@ -2623,7 +2623,7 @@ static pid_t spawn_consumerd(struct consumer_data *consumer_data)
 			break;
 		}
 		default:
-			PERROR("unknown consumer type");
+			ERR("unknown consumer type");
 			exit(EXIT_FAILURE);
 		}
 		if (errno != 0) {