lttng-tools.git
8 years agoFix: rework utils_parse_size_suffix
Simon Marchi [Thu, 10 Apr 2014 15:30:19 +0000 (11:30 -0400)] 
Fix: rework utils_parse_size_suffix

Ok, so there are a lot of problems with this function (sorry :|). Taking
the regex road is probably to complicated for nothing, so here is a
version without regexes.

I added many test cases as suggested by Sandeep Chaudhary and Daniel
Thibault. I tested on both Intel 32 and 64 bits.

Fixes #633

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: XML declaration must be at beginning of XSD file
Christian Babeux [Thu, 10 Apr 2014 21:16:39 +0000 (17:16 -0400)] 
Fix: XML declaration must be at beginning of XSD file

Move down license information to fix the parser error :
XML declaration allowed only at the start of the document

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd MIT license header to session.xsd
Jérémie Galarneau [Mon, 7 Apr 2014 15:47:37 +0000 (11:47 -0400)] 
Add MIT license header to session.xsd

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoInsert V4L2 instrumentation module on session start
Wade Farnsworth [Fri, 28 Mar 2014 20:09:59 +0000 (13:09 -0700)] 
Insert V4L2 instrumentation module on session start

Requires V4L2 instrumentation patch for lttng-modules.

Signed-off-by: Wade Farnsworth <wade_farnsworth@mentor.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoUpdate ChangeLog with 2.4.1 release
David Goulet [Wed, 9 Apr 2014 18:20:54 +0000 (14:20 -0400)] 
Update ChangeLog with 2.4.1 release

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: don't delete stream from connection recv list
David Goulet [Thu, 3 Apr 2014 17:14:00 +0000 (13:14 -0400)] 
Fix: don't delete stream from connection recv list

We don't need to delete them from the list during a connection destroy
because it's only a reference to the stream that might be valid or not
during the connection destroy. There is no need at all to access the
stream's pointer at that point.

Commit cd2ef1ef1d54ced9e4d0d03b865bb7fc6a905f80 did not fixed the full
issue so this should fix the use after free race for good.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: misc spelling errors
Michael Jeanson [Fri, 4 Apr 2014 14:23:36 +0000 (10:23 -0400)] 
Fix: misc spelling errors

Signed-off-by: Michael Jeanson <mjeanson@ubuntu.com>
8 years agoFix: don't quiet the consumer if opt_quiet is not set
David Goulet [Wed, 2 Apr 2014 19:07:21 +0000 (15:07 -0400)] 
Fix: don't quiet the consumer if opt_quiet is not set

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: use after free of a relayd stream
David Goulet [Wed, 2 Apr 2014 14:31:34 +0000 (10:31 -0400)] 
Fix: use after free of a relayd stream

A race could occur with a stream destruction and a control connection
being destroyed emptying its recv_list. A freed stream could still be in
the list thus having a use after free during the connection destroy.

That was triggering undefined behavior from infinite looping to
segmentation faults.

We've observed this issue on high load stress test. A relayd received
all the stream but NOT the streams sent command which empty the list.
This can happen if a start tracing never occured or failed on the
application side thus the close stream command is sent to the relayd
freeing the stream before it is removed from that list.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: don't print stream name in error message
David Goulet [Tue, 1 Apr 2014 15:36:13 +0000 (11:36 -0400)] 
Fix: don't print stream name in error message

The stream received, in per UID, is actually a temporary stream object
that only contains the UST object data which is the relevant part for
UST to use.

Thus on error the name was random data thus print the valid handle
descriptor instead of invalid data.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: take session list lock when listing tp
David Goulet [Fri, 28 Mar 2014 13:58:03 +0000 (09:58 -0400)] 
Fix: take session list lock when listing tp

This is important since the list tracepoints command access the
application socket to ask the application for its TPs. The session list
lock protects the ordering of message for those sockets.

This was triggering out of order message between the session daemon and
an application thus triggering undefined behavior.

Fixes #774

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add consumer wake up pipe to avoid race
David Goulet [Wed, 19 Mar 2014 18:34:27 +0000 (14:34 -0400)] 
Fix: add consumer wake up pipe to avoid race

UST application will notify the wait_fd pipe for every subbuffer that it
writes and ready to be consumed. However, on *high* load systems, this
1:1 property can fail if the pipe gets filled up. For performance
reason, UST will ignore this error and continue since it can't wait for
the pipe to clear up.

This triggers a race condition where we have *one* wake up on the UST
pipe for potentially multiple subbuffers. A data pending command will
wait forever on streams that still has data but the data thread could'nt
consumed them because of this 1:n possible race. Using the stop command
without waiting would mean a memory/fd leak of the stream.

Thus, we add a consumer wake up pipe here that notifies the data thread
if there is still data to be read after a successful read subbuffer
call. With this, we end up handling the residual buffers if any since
the data thread is always notified when there is still data to be read.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: don't spawn relayd if URL is provided
David Goulet [Fri, 28 Mar 2014 17:19:47 +0000 (13:19 -0400)] 
Fix: don't spawn relayd if URL is provided

In the lttng command line tool, relayd should only be spawned for the
default use case which is no URL provided.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: update test to use correct lttng load option
David Goulet [Wed, 26 Mar 2014 15:31:36 +0000 (11:31 -0400)] 
Fix: update test to use correct lttng load option

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: allow loading session file with -i option
David Goulet [Wed, 26 Mar 2014 15:31:23 +0000 (11:31 -0400)] 
Fix: allow loading session file with -i option

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: bad errno handling in load session from path
David Goulet [Wed, 26 Mar 2014 15:26:15 +0000 (11:26 -0400)] 
Fix: bad errno handling in load session from path

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoUpdate load help message
David Goulet [Wed, 26 Mar 2014 15:19:15 +0000 (11:19 -0400)] 
Update load help message

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoPrint message on a successful load command
David Goulet [Wed, 26 Mar 2014 15:01:25 +0000 (11:01 -0400)] 
Print message on a successful load command

Fixes #754

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoRemove -s option from lttng load command
David Goulet [Wed, 26 Mar 2014 14:50:41 +0000 (10:50 -0400)] 
Remove -s option from lttng load command

This is to help usability and also provide the same usage as lttng save
command that does not require this option.

Fixes #755

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoUpdate ChangeLog and configure to 2.4.0 stable
David Goulet [Wed, 26 Mar 2014 14:22:29 +0000 (10:22 -0400)] 
Update ChangeLog and configure to 2.4.0 stable

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoRename kernel and ust trace variable for clarity
David Goulet [Tue, 25 Mar 2014 17:19:57 +0000 (13:19 -0400)] 
Rename kernel and ust trace variable for clarity

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoRename variable in session.h for clarity
David Goulet [Tue, 25 Mar 2014 16:14:01 +0000 (12:14 -0400)] 
Rename variable in session.h for clarity

The "started" var. is changed to the flag "has_been_started" indicating
if at least ONE start command has been seen.

The "enabled" var. is changed to the flag "active" and the semantic is
the same.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: don't ask data pending if session was not started
David Goulet [Tue, 25 Mar 2014 15:34:47 +0000 (11:34 -0400)] 
Fix: don't ask data pending if session was not started

Fixes #770

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing test file in EXTRA dist
David Goulet [Mon, 24 Mar 2014 20:07:51 +0000 (16:07 -0400)] 
Fix: missing test file in EXTRA dist

Fixes #753

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoTests: add tests for the save and load feature
David Goulet [Wed, 19 Mar 2014 20:19:04 +0000 (16:19 -0400)] 
Tests: add tests for the save and load feature

This commit integrates the tests to the fast make check.

Fixes #757

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: set full path in .gitignore
David Goulet [Mon, 24 Mar 2014 19:55:59 +0000 (15:55 -0400)] 
Fix: set full path in .gitignore

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: use NULL url for load live session
David Goulet [Mon, 24 Mar 2014 19:52:31 +0000 (15:52 -0400)] 
Fix: use NULL url for load live session

For a live session, the control and data URI are mandatory thus pass
NULL to the create session so we can set them afterwards by a set
consumer URL call.

net:// can't be used for control and data so this fixes the uri to url
string by printing "tcp://" instead of net:// which is more accurate and
the good way to actually print the URL to the user.

Fixes #767

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: allow empty URL for live session creation
David Goulet [Mon, 24 Mar 2014 18:23:00 +0000 (14:23 -0400)] 
Fix: allow empty URL for live session creation

This is actually very important so -C/-D can be used with lttng create
--live command and also the load command can set the control and data
URL independently.

This also adds a small test to make sure -C/-D works in live mode.

Fixes #769

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing valid return code when adding an URI to consumer
David Goulet [Mon, 24 Mar 2014 18:22:34 +0000 (14:22 -0400)] 
Fix: missing valid return code when adding an URI to consumer

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: clarify sessiond ust app queue cmd comment
David Goulet [Thu, 20 Mar 2014 19:06:30 +0000 (15:06 -0400)] 
Fix: clarify sessiond ust app queue cmd comment

Reported-by: Daniel Thibault <Daniel.Thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: use uri API to parse url for save command
David Goulet [Wed, 19 Mar 2014 20:19:49 +0000 (16:19 -0400)] 
Fix: use uri API to parse url for save command

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Succesful session load might still report an error
Jérémie Galarneau [Wed, 19 Mar 2014 15:29:18 +0000 (11:29 -0400)] 
Fix: Succesful session load might still report an error

This ensures that the load command reports a successful load when
the session is found in the user's home session configuration
directory and not in the system-wide session configuration directory.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Pass session name to config_load_session when no path is provided
Jérémie Galarneau [Wed, 19 Mar 2014 15:28:52 +0000 (11:28 -0400)] 
Fix: Pass session name to config_load_session when no path is provided

Fixes #756

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Remove overly restrictive asserts in create_session()
Jérémie Galarneau [Wed, 19 Mar 2014 15:25:26 +0000 (11:25 -0400)] 
Fix: Remove overly restrictive asserts in create_session()

The current assertions only allow sessions containing all three
domain types to be created. The pointers are already checked at
ln 1242.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: syntax error in lttng.1
Michael Jeanson [Sat, 15 Mar 2014 17:55:11 +0000 (13:55 -0400)] 
Fix: syntax error in lttng.1

Signed-off-by: Michael Jeanson <mjeanson@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: rename config internal header to abi
David Goulet [Mon, 17 Mar 2014 15:33:10 +0000 (11:33 -0400)] 
Fix: rename config internal header to abi

Allow config ABI to be visible to the internal code.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add error/msg output to save command
David Goulet [Wed, 12 Mar 2014 21:08:32 +0000 (17:08 -0400)] 
Fix: add error/msg output to save command

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add missing string msg for save/load error code
David Goulet [Wed, 12 Mar 2014 20:50:48 +0000 (16:50 -0400)] 
Fix: add missing string msg for save/load error code

Also, the LTTNG_ERR_LOAD_SESSION_NOT_FOUND has been removed and replaced
by LTTNG_ERR_LOAD_SESSION_NOENT.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: return error if not in overwrite mode and file exists
David Goulet [Wed, 12 Mar 2014 20:41:43 +0000 (16:41 -0400)] 
Fix: return error if not in overwrite mode and file exists

For the save command, if the file is found and we are not in overwrite
mode, send back an new error indicating the client that the file already
exists.

Fixes #762

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing memset 0 and NULL byte in string
David Goulet [Wed, 12 Mar 2014 20:31:32 +0000 (16:31 -0400)] 
Fix: missing memset 0 and NULL byte in string

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: check relayd fd leak in lttng cmdline
David Goulet [Wed, 12 Mar 2014 18:47:39 +0000 (14:47 -0400)] 
Fix: check relayd fd leak in lttng cmdline

Fixes coverity issue 1188185.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: time of check time of use scenario
David Goulet [Wed, 12 Mar 2014 18:43:45 +0000 (14:43 -0400)] 
Fix: time of check time of use scenario

Fixes coverity issue 1191753.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing varargs cleanup on error
David Goulet [Wed, 12 Mar 2014 18:08:28 +0000 (14:08 -0400)] 
Fix: missing varargs cleanup on error

Fixes coverity issue 1191751.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: wrong number of elements in array for loop
David Goulet [Wed, 12 Mar 2014 18:07:12 +0000 (14:07 -0400)] 
Fix: wrong number of elements in array for loop

Fixes coverity issue 1191759.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: possible unlink on uninitialized buffer path
David Goulet [Wed, 12 Mar 2014 17:55:44 +0000 (13:55 -0400)] 
Fix: possible unlink on uninitialized buffer path

Fixes coverity issue 1191752.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: possible load config domain overwrite
David Goulet [Wed, 12 Mar 2014 17:48:53 +0000 (13:48 -0400)] 
Fix: possible load config domain overwrite

The uniqueness of the domain CAN NOT be enforced with the XML xsd schema
so if the same domains are seen, return an error.

Fixes coverity issue 1191755.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: memory leak
David Goulet [Wed, 12 Mar 2014 17:40:49 +0000 (13:40 -0400)] 
Fix: memory leak

Fixes coverity issue 1191756.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: save session usage of string size
David Goulet [Wed, 12 Mar 2014 17:29:44 +0000 (13:29 -0400)] 
Fix: save session usage of string size

Kind of fixes coverity issue 1191758 since there was a bad check but the
reported issue does not makes sense since there is in fact a validation
before writing the string making the "len" variable never able to reach
4096 (PATH_MAX).

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: remove unused tp in high-throughput test
Zifei Tong [Wed, 12 Mar 2014 09:44:10 +0000 (17:44 +0800)] 
Fix: remove unused tp in high-throughput test

Signed-off-by: Zifei Tong <zifeitong@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoUse autoconf AM_MAINTAINER_MODE.
Lars Persson [Wed, 12 Mar 2014 09:22:40 +0000 (10:22 +0100)] 
Use autoconf AM_MAINTAINER_MODE.

Give distribution maintainers the option to skip rebuilding autoconf and
automake generated files. The default behaviour is still to have the
rebuild rules enabled.

Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: handle signed return value for snprintf
David Goulet [Mon, 10 Mar 2014 20:18:42 +0000 (16:18 -0400)] 
Fix: handle signed return value for snprintf

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: clang 'constant-out-of-range-compare' warning
Zifei Tong [Tue, 4 Mar 2014 13:27:38 +0000 (21:27 +0800)] 
Fix: clang 'constant-out-of-range-compare' warning

This patch fixes two 'autological-constant-out-of-range-compare' clang
warnings caused by comparing enum type variables with -1.

It's possible that compilers optimize these two comparisons away.

Signed-off-by: Zifei Tong <zifeitong@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Fail configuration if libxml2 is not found
Jérémie Galarneau [Mon, 10 Feb 2014 20:31:46 +0000 (15:31 -0500)] 
Fix: Fail configuration if libxml2 is not found

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
8 years agoAdd load command to the lttng client
Jérémie Galarneau [Mon, 10 Feb 2014 16:47:14 +0000 (11:47 -0500)] 
Add load command to the lttng client

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd session configuration load capability to libconfig
Jérémie Galarneau [Mon, 10 Feb 2014 16:44:55 +0000 (11:44 -0500)] 
Add session configuration load capability to libconfig

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd a save command based on the save API to the lttng client
Jérémie Galarneau [Wed, 22 Jan 2014 17:04:49 +0000 (12:04 -0500)] 
Add a save command based on the save API to the lttng client

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd session configuration save feature to session daemon
Jérémie Galarneau [Wed, 22 Jan 2014 19:36:01 +0000 (14:36 -0500)] 
Add session configuration save feature to session daemon

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd a save API to lttng-ctl
Jérémie Galarneau [Wed, 22 Jan 2014 16:57:19 +0000 (11:57 -0500)] 
Add a save API to lttng-ctl

This adds multiple function calls to the lttng-ctl API with save.h and
save-internal.h files.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd session configuration XSD
Jérémie Galarneau [Wed, 22 Jan 2014 16:46:06 +0000 (11:46 -0500)] 
Add session configuration XSD

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd a config_writer API based on libxml2
Jérémie Galarneau [Tue, 21 Jan 2014 19:24:54 +0000 (14:24 -0500)] 
Add a config_writer API based on libxml2

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoAdd a dependency to libxml2
Jérémie Galarneau [Tue, 21 Jan 2014 18:44:56 +0000 (13:44 -0500)] 
Add a dependency to libxml2

libxml2 2.7.6 is the oldest supported version.
This is the version distributed as part of RHEL 6.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoSend filter expression string to session daemon
Jérémie Galarneau [Tue, 21 Jan 2014 17:24:24 +0000 (12:24 -0500)] 
Send filter expression string to session daemon

Send the filter expression string along with the filter's bytecode to
the session daemon. The session daemon now stores the filter expression.
This makes it possible to list the filter's expression when listing
events.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: tcp4 and net4 protocol support in uri_parse
Jérémie Galarneau [Tue, 28 Jan 2014 20:01:25 +0000 (15:01 -0500)] 
Fix: tcp4 and net4 protocol support in uri_parse

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agosession_find_by_name does not need a non-const name param
Jérémie Galarneau [Wed, 22 Jan 2014 16:50:10 +0000 (11:50 -0500)] 
session_find_by_name does not need a non-const name param

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Unchecked session pointer when destroying a connection in relayd
Jérémie Galarneau [Tue, 4 Mar 2014 18:45:17 +0000 (13:45 -0500)] 
Fix: Unchecked session pointer when destroying a connection in relayd

An unknown command currently crashes the relay daemon since
destroy_connection calls destroy_session without checking whether or not
a session is associated with the connection.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: improve lttng with live by spawning relayd
David Goulet [Fri, 28 Feb 2014 17:31:46 +0000 (12:31 -0500)] 
Fix: improve lttng with live by spawning relayd

The create --live, will try to spawn a default relayd if no URL is
given.

The lttng view now supports the live tracing mode thus lttng view is
usable with a live session.

Fixes #738

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: relayd should listen for viewers on localhost only by default
Mathieu Desnoyers [Fri, 28 Feb 2014 13:33:49 +0000 (08:33 -0500)] 
Fix: relayd should listen for viewers on localhost only by default

Having relayd listening by default on 0.0.0.0 (all interfaces) with a
protocol without authentication is an information leak waiting to
happen.

Users should explicitely specify if they want to listen on all
interfaces, using e.g. -L tcp://0.0.0.0:5344 (see lttng-relayd(8)
manpage for details). They should only do so if they use a firewall, or
are within a secured network.

Fixes #746

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: handle loglevel range ALL in list command
David Goulet [Thu, 27 Feb 2014 20:04:53 +0000 (15:04 -0500)] 
Fix: handle loglevel range ALL in list command

Print the ":" if we get the ALL range and not TYPE UNKNOWN.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoTests: add JUL test for multiple loglevel
David Goulet [Thu, 27 Feb 2014 19:48:07 +0000 (14:48 -0500)] 
Tests: add JUL test for multiple loglevel

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: index JUL event by name *and* loglevel
David Goulet [Thu, 27 Feb 2014 19:00:13 +0000 (14:00 -0500)] 
Fix: index JUL event by name *and* loglevel

This is to support multiple loglevels for a JUL event.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: JUL to enable user and root tracepoints
David Goulet [Thu, 27 Feb 2014 15:03:14 +0000 (10:03 -0500)] 
Fix: JUL to enable user and root tracepoints

This is needed to support the LTTng JUL agent to connect to both user
and root session daemon, we have to enable different tracepoint for the
two cases in order to avoid duplicating the trace payload in both the
user and root trace output.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoRevert "Fix: format + PACKAGE_URL for dynamic printing"
David Goulet [Thu, 27 Feb 2014 14:56:51 +0000 (09:56 -0500)] 
Revert "Fix: format + PACKAGE_URL for dynamic printing"

This changes the lttng version output considered as a stable ABI in RC
cycle. This will apply to 2.5.

This reverts commit 9afbd878f072d5e0577811acf1d3340f65cf2e26.

8 years agoFix: handle the registration done command for JUL
David Goulet [Wed, 26 Feb 2014 21:13:34 +0000 (16:13 -0500)] 
Fix: handle the registration done command for JUL

Lockstep with lttng-ust.

Part of the fix for issue #692

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoTest fix: use temp file sync. of test app
David Goulet [Wed, 26 Feb 2014 20:13:46 +0000 (15:13 -0500)] 
Test fix: use temp file sync. of test app

Fixes #736

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: keep metadata channel attr in UST session
David Goulet [Wed, 26 Feb 2014 20:07:12 +0000 (15:07 -0500)] 
Fix: keep metadata channel attr in UST session

This is so that if we have NO application we can use the metadata
channel attributes once one appears.

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoTests fix: Missing waitpid in fork test
Jérémie Galarneau [Wed, 26 Feb 2014 15:56:57 +0000 (10:56 -0500)] 
Tests fix: Missing waitpid in fork test

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add loglevel type to lttng list <name>
David Goulet [Wed, 26 Feb 2014 18:22:32 +0000 (13:22 -0500)] 
Fix: add loglevel type to lttng list <name>

For range loglevel, the <= is used and for single ==. For instance:

ev_log_range (loglevel <= TRACE_WARNING (4)) (type: tracepoint)
ev_log_single (loglevel == TRACE_NOTICE (5)) (type: tracepoint)

Fixes #628

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: minor rephrasing of the lttng.1 man page
David Goulet [Wed, 26 Feb 2014 17:04:57 +0000 (12:04 -0500)] 
Fix: minor rephrasing of the lttng.1 man page

Fixes #730

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: Warn user if JUL port is already being used
David Goulet [Wed, 26 Feb 2014 16:45:45 +0000 (11:45 -0500)] 
Fix: Warn user if JUL port is already being used

Fixes #740

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add some sane default values to --live opt
David Goulet [Wed, 26 Feb 2014 16:29:57 +0000 (11:29 -0500)] 
Fix: add some sane default values to --live opt

The lttng create --live now takes optional arguments meaning if no USEC
or/and -U are found, some defaults value are used.

Fixes #738

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: possible NULL deref. in sessiond error path
Stefan Seefeld [Wed, 26 Feb 2014 03:44:30 +0000 (22:44 -0500)] 
Fix: possible NULL deref. in sessiond error path

Fxies #735

Signed-off-by: Stefan Seefeld <stefan@codesourcery.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: format + PACKAGE_URL for dynamic printing
Jonathan Rajotte [Tue, 25 Feb 2014 18:04:17 +0000 (13:04 -0500)] 
Fix: format + PACKAGE_URL for dynamic printing

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: flag that kernel streams FDs has been sent
David Goulet [Tue, 25 Feb 2014 20:24:53 +0000 (15:24 -0500)] 
Fix: flag that kernel streams FDs has been sent

Flag the session *after* every stream was successfully sent.

Fixes #731

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: forbid session name creation if contains /
David Goulet [Tue, 25 Feb 2014 19:45:08 +0000 (14:45 -0500)] 
Fix: forbid session name creation if contains /

This adds a validation function for session name which for now denies
any session name containing '/'.

This is in response of bug #721 that actually uses a path as a session
name such as "test/../session1" which would then be concatenated to the
session path adding a relative path to it making this a serious security
issue.

Because of this issue, this is backported from master up to stable-2.3.

Fixes #721

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: don't start session if no channel
David Goulet [Tue, 25 Feb 2014 19:22:19 +0000 (14:22 -0500)] 
Fix: don't start session if no channel

This adds a new error code that indicates that the session contains NO
channel.

Fixes #715

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add missing relayd option to man page
David Goulet [Tue, 25 Feb 2014 19:02:32 +0000 (14:02 -0500)] 
Fix: add missing relayd option to man page

Fixes #706

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: report error if consumer can't be spawned
David Goulet [Tue, 25 Feb 2014 18:55:12 +0000 (13:55 -0500)] 
Fix: report error if consumer can't be spawned

On error of the UST consumer execl(), we now exit the forked process
like the kernel does.

Furthermore, fix an error handling value when timing out when waiting
for the consumer to bootstrap thus returning an error to the client and
not continuing with the command thinking that the consumer was actually
spawned.

So, the expected behavior is to wait for the pthread condition and if a
timeout is seen, the client is informed thus making the client command
hang for the default timeout value of 30 seconds.

Fixes #702

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: lttng list -u <name> should only list UST
David Goulet [Tue, 25 Feb 2014 17:42:04 +0000 (12:42 -0500)] 
Fix: lttng list -u <name> should only list UST

Fixes #654

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: kernel channel destroy on consumer if sent
David Goulet [Tue, 25 Feb 2014 17:21:32 +0000 (12:21 -0500)] 
Fix: kernel channel destroy on consumer if sent

An enable-channel immediately followed by a destroy session triggered an
assert on the consumer followed by the shutdown of the consumer thread
for the kernel.

This fix make sure we don't ask the consumer to destroy a channel if not
previously sent to it and handle not found channel on destroy.

Fixes #643

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoUpdate changelog with stable 2.3 and 2.4 branch
David Goulet [Tue, 25 Feb 2014 17:01:59 +0000 (12:01 -0500)] 
Update changelog with stable 2.3 and 2.4 branch

Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: only create UST metadata on start trace
David Goulet [Tue, 25 Feb 2014 16:03:35 +0000 (11:03 -0500)] 
Fix: only create UST metadata on start trace

Fixes #739

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoRevert "Fix: wrong condition on startup for low-activity streams"
David Goulet [Mon, 24 Feb 2014 19:35:05 +0000 (14:35 -0500)] 
Revert "Fix: wrong condition on startup for low-activity streams"

This reverts commit d3aac146d0800fe9820d51e5b9fa52e7543c1237.

Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: missing big endian conversion for one index field
Julien Desfossez [Mon, 24 Feb 2014 18:34:00 +0000 (13:34 -0500)] 
Fix: missing big endian conversion for one index field

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: wrong condition on startup for low-activity streams
Julien Desfossez [Mon, 24 Feb 2014 18:02:19 +0000 (13:02 -0500)] 
Fix: wrong condition on startup for low-activity streams

If we only received and sent one index, we should not be in the retry
condition.
The rstream->total_index_received == vstream->last_sent_index is checked
before.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: perror on index directory creation error
Julien Desfossez [Mon, 24 Feb 2014 18:02:18 +0000 (13:02 -0500)] 
Fix: perror on index directory creation error

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoComments fix: lttngerr.h -> error.h (./Changelog:754)
Jonathan Rajotte [Mon, 24 Feb 2014 00:50:52 +0000 (19:50 -0500)] 
Comments fix: lttngerr.h -> error.h (./Changelog:754)

Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: consumerd errors on exit
Mathieu Desnoyers [Fri, 21 Feb 2014 15:14:46 +0000 (10:14 -0500)] 
Fix: consumerd errors on exit

- The LTTNG_CONSUMER_STOP command is not used by sessiond anymore, so
  deprecate it,
- Ensure that the normal teardown (with signal handler) does not trigger
  a health error in consumer daemon by distinguishing between errors and
  "should exit" with different lttng_consumer_poll_socket() return values.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: scanf unbounded input
Mathieu Desnoyers [Fri, 21 Feb 2014 03:53:04 +0000 (22:53 -0500)] 
Fix: scanf unbounded input

Awaiting a proper cleanup (introducing nscanf), do what we can to
validate the scanf input using its utterly broken API.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: miscellaneous memory handling fixes
Mathieu Desnoyers [Thu, 20 Feb 2014 15:23:46 +0000 (10:23 -0500)] 
Fix: miscellaneous memory handling fixes

Issues found with Valgrind:

- Uninitialized memory sent through sendmsg,
- Uninitialized realloc memory,
- Erroneous pointer arithmetic in jul_list_events(),
- Memory leaks in kernel_consumer_add_channel(),
  kernel_consumer_add_metadata(),
- Memory leak (snapshot_destroy missing hash table cleanup),
- Uninitialized poll/epoll memory on realloc.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
8 years agoFix: add missing VALGRIND ifdef checks and documentation
Mathieu Desnoyers [Thu, 20 Feb 2014 15:23:45 +0000 (10:23 -0500)] 
Fix: add missing VALGRIND ifdef checks and documentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.071536 seconds and 5 git commands to generate.