From 03e79f33de8b65a18a5929d55e937db565365fdc Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 31 Mar 2021 15:06:34 -0400 Subject: [PATCH] Fix: sessiond: fix -Wshadow error in save.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit I think this actually fixes a bug. Because of the second ret variable, the return value from init_ust_event_from_agent_event or save_ust_event would not be forwarded correctly, in case of error. Signed-off-by: Simon Marchi Signed-off-by: Jérémie Galarneau Change-Id: Ieb61d9b267ab90e18cc349d86754d9b89b5703f1 --- src/bin/lttng-sessiond/save.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/bin/lttng-sessiond/save.c b/src/bin/lttng-sessiond/save.c index c5ea4c873..43b0ed864 100644 --- a/src/bin/lttng-sessiond/save.c +++ b/src/bin/lttng-sessiond/save.c @@ -1234,7 +1234,6 @@ int save_agent_events(struct config_writer *writer, rcu_read_lock(); cds_lfht_for_each_entry(agent->events->ht, &iter.iter, node, node) { - int ret; struct agent_event *agent_event; struct ltt_ust_event fake_event; -- 2.34.1