From 1ebc45cd4c1b34fbaacb8b8403fbb5d3fab33d3f Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Fri, 24 Aug 2018 16:32:12 -0400 Subject: [PATCH] Fix: event copy constructor frees original event on error MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérémie Galarneau --- src/lib/lttng-ctl/event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/lttng-ctl/event.c b/src/lib/lttng-ctl/event.c index 44e4864c0..5785345cd 100644 --- a/src/lib/lttng-ctl/event.c +++ b/src/lib/lttng-ctl/event.c @@ -60,7 +60,7 @@ struct lttng_event *lttng_event_copy(const struct lttng_event *event) struct lttng_event_extended *new_event_extended; new_event = zmalloc(sizeof(*event)); - if (!event) { + if (!new_event) { PERROR("Error allocating event structure"); goto end; } @@ -82,7 +82,7 @@ struct lttng_event *lttng_event_copy(const struct lttng_event *event) end: return new_event; error: - free(event); + free(new_event); goto end; } -- 2.34.1