From 29fefef89ab4dd5ad6be0ace2c30c0887749f925 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Fri, 13 Jul 2012 23:33:09 -0400 Subject: [PATCH] Filter: cast double directly to s64 When we know that the child is a double we can cast it directly without letting the specializer do it. Signed-off-by: Mathieu Desnoyers --- src/lib/lttng-ctl/filter-visitor-generate-bytecode.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/lib/lttng-ctl/filter-visitor-generate-bytecode.c b/src/lib/lttng-ctl/filter-visitor-generate-bytecode.c index 7ee35fded..a9e741cd2 100644 --- a/src/lib/lttng-ctl/filter-visitor-generate-bytecode.c +++ b/src/lib/lttng-ctl/filter-visitor-generate-bytecode.c @@ -397,7 +397,11 @@ int visit_node_logical(struct filter_parser_ctx *ctx, struct ir_op *node) || node->u.binary.left->data_type == IR_DATA_FLOAT) { struct cast_op cast_insn; - cast_insn.op = FILTER_OP_CAST_TO_S64; + if (node->u.binary.left->data_type == IR_DATA_FIELD_REF) { + cast_insn.op = FILTER_OP_CAST_TO_S64; + } else { + cast_insn.op = FILTER_OP_CAST_DOUBLE_TO_S64; + } cast_insn.reg = REG_R0; ret = bytecode_push(&ctx->bytecode, &cast_insn, 1, sizeof(cast_insn)); @@ -431,7 +435,11 @@ int visit_node_logical(struct filter_parser_ctx *ctx, struct ir_op *node) || node->u.binary.right->data_type == IR_DATA_FLOAT) { struct cast_op cast_insn; - cast_insn.op = FILTER_OP_CAST_TO_S64; + if (node->u.binary.right->data_type == IR_DATA_FIELD_REF) { + cast_insn.op = FILTER_OP_CAST_TO_S64; + } else { + cast_insn.op = FILTER_OP_CAST_DOUBLE_TO_S64; + } cast_insn.reg = REG_R0; ret = bytecode_push(&ctx->bytecode, &cast_insn, 1, sizeof(cast_insn)); -- 2.34.1