From 4287ce26d07de052721a2c1f9a3e3270cd867450 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Thu, 25 Mar 2021 15:18:13 -0400 Subject: [PATCH] compiler warning cleanup: is_signed_type: compare -1 to 1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Comparing -1 to 0 triggers compiler warnings (gcc -Wtype-limits and -Wbool-compare) and Coverity warning "Macro compares unsigned to 0". Comparing -1 to 1 instead takes care of silencing those warnings while keeping the same behavior. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau Change-Id: Id4aebce6eed214f0ccba2c0289fb3b034808cb64 --- src/common/macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/macros.h b/src/common/macros.h index cce09a6cb..70de2875e 100644 --- a/src/common/macros.h +++ b/src/common/macros.h @@ -77,7 +77,7 @@ void *zmalloc(size_t len) #define LTTNG_PACKED __attribute__((__packed__)) #endif -#define is_signed(type) (((type) (-1)) < 0) +#define is_signed(type) (((type) -1) < (type) 1) /* * Align value to the next multiple of align. Returns val if it already is a -- 2.34.1