From 5d9ad61212d307697bb661bafcf16356fea915ac Mon Sep 17 00:00:00 2001 From: Christian Babeux Date: Thu, 15 Aug 2013 13:03:36 -0400 Subject: [PATCH] Fix: Snapshot should be taken asap in core handler script Taking a snapshot should be the first thing the core handler does. An enormous core file write to disk could potentially discard a lot of tracing data if done before the snapshot. Signed-off-by: Christian Babeux Signed-off-by: David Goulet --- extras/core-handler/handler.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/extras/core-handler/handler.sh b/extras/core-handler/handler.sh index 781728223..c2d24027b 100755 --- a/extras/core-handler/handler.sh +++ b/extras/core-handler/handler.sh @@ -29,6 +29,12 @@ SESSION_NAME="coredump-handler" # Sessiond binary name. SESSIOND_BIN_NAME="lttng-sessiond" +# TODO: Checking for a sessiond lockfile would be more appropriate. +if $PGREP_BIN -u root "${SESSIOND_BIN_NAME}" > /dev/null 2>&1 +then + $LTTNG_BIN snapshot record -s ${SESSION_NAME} > /dev/null 2>&1 +fi + # Core file settings. CORE_PATH="/tmp/lttng/core" CORE_PREFIX="core" @@ -54,9 +60,3 @@ $CAT_BIN - > "${CORE_PATH}/${CORE_PREFIX}.$p" # Optional, chain core dump handler with original systemd script. #$CAT_BIN - | /usr/lib/systemd/systemd-coredump $p $u $g $s $t $e - -# TODO: Checking for a sessiond lockfile would be more appropriate. -if $PGREP_BIN -u root "${SESSIOND_BIN_NAME}" > /dev/null 2>&1 -then - $LTTNG_BIN snapshot record -s ${SESSION_NAME} > /dev/null 2>&1 -fi -- 2.34.1