From 7e0a437914bdad867b9cdfa61d7cba163dfc4c8b Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Fri, 7 Sep 2018 15:18:38 -0400 Subject: [PATCH] Fix: skip closed session on viewer listing MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There is no value in listing a closed session. A viewer cannot hook itself to a closed session in live mode and the session is about to be removed from the sessions hash table. Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau --- src/bin/lttng-relayd/live.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/bin/lttng-relayd/live.c b/src/bin/lttng-relayd/live.c index bc0e4529a..0fd41f1a8 100644 --- a/src/bin/lttng-relayd/live.c +++ b/src/bin/lttng-relayd/live.c @@ -835,6 +835,11 @@ int viewer_list_sessions(struct relay_connection *conn) health_code_update(); + if (session->connection_closed) { + /* Skip closed session */ + continue; + } + if (count >= buf_count) { struct lttng_viewer_session *newbuf; uint32_t new_buf_count = buf_count << 1; -- 2.34.1