From b4bc01f7074ec9eb2a5784b72c804604e62bbe51 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Mon, 25 Sep 2017 16:22:57 -0400 Subject: [PATCH] Filter: document ust app ctx limitation MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- src/bin/lttng-sessiond/event.c | 3 +++ src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/src/bin/lttng-sessiond/event.c b/src/bin/lttng-sessiond/event.c index b7b80d366..ecb368fd5 100644 --- a/src/bin/lttng-sessiond/event.c +++ b/src/bin/lttng-sessiond/event.c @@ -422,6 +422,9 @@ error: /* * Check if this event's filter requires the activation of application contexts * and enable them in the agent. + * TODO: bytecode iterator does not support non-legacy application + * contexts yet. Not an issue for now, since they are not generated by + * the lttng-ctl library. */ static int add_filter_app_ctx(struct lttng_filter_bytecode *bytecode, const char *filter_expression, struct agent *agt) diff --git a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c index 1ab98138e..74ec1a715 100644 --- a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c +++ b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c @@ -319,6 +319,10 @@ int visit_node_load_expression(struct filter_parser_ctx *ctx, return -EINVAL; } + /* + * TODO: if we remove legacy load for application contexts, we + * need to update session bytecode parser as well. + */ ret = visit_node_load_expression_legacy(ctx, exp, op); if (ret < 0) { return ret; -- 2.34.1