From f3ce6946ed9508129491909fd56b61026bc0f054 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Mon, 20 Aug 2018 14:51:45 -0400 Subject: [PATCH] Fix: unreported error on rotate timer stop failure MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit A missing 'goto end' causes errors occuring when stopping the sessiond's rotate timer to be ignored as the switch-case's case breaks and the 'ret' value is set to LTTNG_OK. Reported-by: Coverity Scan (1395074 Unused value) Signed-off-by: Jérémie Galarneau --- src/bin/lttng-sessiond/cmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c index ba7dd3d4d..626275086 100644 --- a/src/bin/lttng-sessiond/cmd.c +++ b/src/bin/lttng-sessiond/cmd.c @@ -4903,6 +4903,7 @@ int cmd_rotation_set_schedule(struct ltt_session *session, if (ret) { ERR("Failed to disable session rotation timer in ROTATION_SET_SCHEDULE command"); ret = LTTNG_ERR_UNK; + goto end; } } break; -- 2.34.1