From f3dd7ce78597e2d8b002fcc9536aa6016d1b039f Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Wed, 26 Nov 2014 16:20:21 -0500 Subject: [PATCH] Fix: Unreachable error logging in set_option() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit *** CID 1256136: Logically dead code (DEADCODE) Signed-off-by: Jérémie Galarneau --- src/bin/lttng-sessiond/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index 4bfbb9ef4..a970012c7 100644 --- a/src/bin/lttng-sessiond/main.c +++ b/src/bin/lttng-sessiond/main.c @@ -4464,6 +4464,7 @@ static int set_option(int opt, const char *arg, const char *optname) ret = -1; } +end: if (ret == -EINVAL) { const char *opt_name = "unknown"; int i; @@ -4479,7 +4480,7 @@ static int set_option(int opt, const char *arg, const char *optname) WARN("Invalid argument provided for option \"%s\", using default value.", opt_name); } -end: + return ret; } -- 2.34.1