From f5112e978f61eb82bf487cfa9efa2de359d37661 Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?=
 <jeremie.galarneau@efficios.com>
Date: Fri, 31 Jan 2020 18:22:22 -0500
Subject: [PATCH 1/1] Clean-up: mi: remove logically dead code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

1412199 Logically dead code

The indicated dead code may have performed some action; that action
will never occur.

In mi_lttng_id_target: Code can never be reached because of a logical
contradiction (CWE-561)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I8279cd1e6ab5bc86bd4ea4ca8ac721ad1e31e02b
---
 src/common/mi-lttng.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/common/mi-lttng.c b/src/common/mi-lttng.c
index bd5049efe..f9f1e225a 100644
--- a/src/common/mi-lttng.c
+++ b/src/common/mi-lttng.c
@@ -1743,9 +1743,6 @@ int mi_lttng_id_target(struct mi_writer *writer,
 		ret = -LTTNG_ERR_INVALID;
 		goto end;
 	}
-	if (ret) {
-		goto end;
-	}
 
 	if (!is_open) {
 		ret = mi_lttng_writer_close_element(writer);
-- 
2.34.1