From f666ae706d924ec91ca8212c402fd514ca572e88 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Mon, 15 Jul 2013 21:47:21 -0400 Subject: [PATCH] document lttng_ustconsumer_request_metadata locking constraints Reviewed-by: Julien Desfossez Signed-off-by: Mathieu Desnoyers --- src/common/ust-consumer/ust-consumer.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/common/ust-consumer/ust-consumer.c b/src/common/ust-consumer/ust-consumer.c index e933f9227..ae933abc0 100644 --- a/src/common/ust-consumer/ust-consumer.c +++ b/src/common/ust-consumer/ust-consumer.c @@ -1804,6 +1804,12 @@ void lttng_ustconsumer_close_stream_wakeup(struct lttng_consumer_stream *stream) } } +/* + * Please refer to consumer-timer.c before adding any lock within this + * function or any of its callees. Timers have a very strict locking + * semantic with respect to teardown. Failure to respect this semantic + * introduces deadlocks. + */ int lttng_ustconsumer_request_metadata(struct lttng_consumer_local_data *ctx, struct lttng_consumer_channel *channel) { -- 2.34.1