From fa1289fc106deb2f88249e1ebdcf87d9b493b2a6 Mon Sep 17 00:00:00 2001 From: Francis Deslauriers Date: Wed, 15 Jan 2020 20:52:39 -0500 Subject: [PATCH] Fix: Tests: missing stream redirect causes test failure MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The following commit enforced the use of options (instead of arguments) in the `gen-ust-events` test application: commit 6c4a91d639747f260ab46decebc50998ef063712 Author: Mathieu Desnoyers Date: Mon Aug 26 14:22:06 2019 -0400 tests: gen-ust-events: use options instead of arguments This makes tests exit (and abort since commit 56d4838) when arguments are passed to the test application. It currently fails with the following error: ./gen-ust-events -i 32 -w 21 \ --sync-after-first-event /tmp/allo.hi \ --sync-before-last-event /tmp/allo.bye /dev/null Error: takes long options only. zsh: abort (core dumped) ./gen-ust-events -i 32 -w 21 --sync-after-first-event /tmp/allo.hi The `/dev/null` at the end of the command line is not associated with an option so it triggers the sanity check. The `/dev/null` most probably meant to redirect STDOUT to `/dev/null`. This commit adds the missing `>` so to overcome the sanity check problem. Signed-off-by: Francis Deslauriers Change-Id: I3e4d4066079055a542438a63ef4df5c5c4c080cf Signed-off-by: Jérémie Galarneau --- tests/destructive/metadata-regeneration | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/destructive/metadata-regeneration b/tests/destructive/metadata-regeneration index de0d3dec0..db4976302 100755 --- a/tests/destructive/metadata-regeneration +++ b/tests/destructive/metadata-regeneration @@ -129,7 +129,7 @@ function test_ust_local () $TESTAPP_BIN -i $NR_ITER -w $NR_USEC_WAIT \ --sync-after-first-event ${file_sync_after_first} \ - --sync-before-last-event ${file_sync_before_last} /dev/null 2>&1 & + --sync-before-last-event ${file_sync_before_last} > /dev/null 2>&1 & start_lttng_tracing_ok $SESSION_NAME @@ -167,7 +167,7 @@ function test_ust_streaming () $TESTAPP_BIN -i $NR_ITER -w $NR_USEC_WAIT \ --sync-after-first-event ${file_sync_after_first} \ - --sync-before-last-event ${file_sync_before_last} /dev/null 2>&1 & + --sync-before-last-event ${file_sync_before_last} > /dev/null 2>&1 & start_lttng_tracing_ok $SESSION_NAME -- 2.34.1