Don't write outside the requested range

[test-ssd.git] / test-ssd-write.c

diff --git a/test-ssd-write.c b/test-ssd-write.c
index 49a4238f28fec84a44c78e08c07854954e874070..ea852481e6b94f776cf8df1b983fac7293249311 100644 (file)
--- a/test-ssd-write.c
+++ b/test-ssd-write.c
@@ -8,19 +8,27 @@
  * Compile with:
  * gcc -O2 -Wall -o test-ssd-write test-ssd-write.c
  *
- * Hard disks known to stop responding with this program (requires a
+ * Hard disk setups known to stop responding with this program (requires a
  * warm machine reboot to get the drive to respond, as soft reset is not
  * enough):
  *
- * Vendor         Model          Firmware   Controller     # drives tested
- * Intel (Lenovo) SSDSC2BW180A3L LE1i       SandForce 2281 1
- * Intel (Lenovo) SSDSC2BW180A3L LF1i       SandForce 2281 2
+ * Vendor         Model          Firmware   Controller     # drives tested         HW                 BIOS
+ * Intel (Lenovo) SSDSC2BW180A3L LE1i       SandForce 2281 1 (3.5 Debian kernel)   Lenovo x230        G2ET90WW (2.50) 2012-20-12
+ * Intel (Lenovo) SSDSC2BW180A3L LF1i       SandForce 2281 2 (3.2 Debian kernel)   Lenovo x230        G2ET90WW (2.50) 2012-20-12
+ * Intel (Lenovo) SSDSC2BW180A3L LF1i       SandForce 2281 1 (3.7.9 Arch kernel)   Lenovo x230        G2ET86WW (2.06) 2012-11-13
+ * Intel (Lenovo) SSDSC2BW180A3L LF1i       SandForce 2281 1 (3.2 Debian kernel)   Lenovo x200
  *
- * We ensured that the problem is not coming from other parts by running
- * this test on other SSD drives, which don't show this problem:
+ * In order to narrow down the problem, we ran this test on a number of
+ * other hardware configurations which don't show this problem:
  * 
- * Vendor         Model          Firmware   Controller     # drives tested
+ * Vendor         Model          Firmware   Controller     # drives tested         HW                 BIOS
  * Intel          SSDSA2M160G2GC 2CV102HD   Intel          1
+ * Intel          SSDSA2CW300G310 ???????   Intel          1 (over USB on 3.8 kernel)
+ * Intel          SSDSA2CT040G3  4PC10302   Intel          1 (3.2 kernel)
+ * Intel          SSDSA2CT040G3  4PC10362   Intel          1 (3.2 kernel)
+ * Intel          SSDSC2CT120A3K5 ???????   SandForce 2281 1 (on HP SmartArray P212 with 3.2 kernel)
+ * OCZ            OCZ-VERTEX3        2.25   SF-2281        1 (3.7.9 Arch kernel)
+ * OCZ            OCZSSD2-2VTXE180G  1.37   SF-1200        1 (3.7.6 Arch kernel)
  *
  * Under Linux (Debian, Ubuntu, various kernels), after about 5 minutes,
  * we get this result:
@@ -138,13 +146,18 @@ static int rand_write(int fd, size_t len)
        uint64_t valcount;
        int ret;
 
+       if (len < BUFLEN) {
+               fprintf(stderr, "Error: File size needs to be at least %u\n", BUFLEN);
+               exit(EXIT_FAILURE);
+       }
+
        memset(buf, 0, BUFLEN);
 
        for (;;) {
                if (len > UINT32_MAX) {
-                       offset = (((size_t) rand() << 32) + (size_t) rand()) % len;
+                       offset = (((size_t) rand() << 32) + (size_t) rand()) % (len - BUFLEN);
                } else {
-                       offset = rand() % len;
+                       offset = rand() % (len - BUFLEN);
                }
 
                if ((offset >= validate_offset &&