drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()
[deliverable/linux.git] / drivers / gpu / drm / arm / malidp_drv.c
CommitLineData
ad49f860
LD
1/*
2 * (C) COPYRIGHT 2016 ARM Limited. All rights reserved.
3 * Author: Liviu Dudau <Liviu.Dudau@arm.com>
4 *
5 * This program is free software and is provided to you under the terms of the
6 * GNU General Public License version 2 as published by the Free Software
7 * Foundation, and any use by you of this program is subject to the terms
8 * of such GNU licence.
9 *
10 * ARM Mali DP500/DP550/DP650 KMS/DRM driver
11 */
12
13#include <linux/module.h>
14#include <linux/clk.h>
15#include <linux/component.h>
16#include <linux/of_device.h>
17#include <linux/of_graph.h>
18#include <linux/of_reserved_mem.h>
19
20#include <drm/drmP.h>
21#include <drm/drm_atomic.h>
22#include <drm/drm_atomic_helper.h>
23#include <drm/drm_crtc.h>
24#include <drm/drm_crtc_helper.h>
25#include <drm/drm_fb_helper.h>
26#include <drm/drm_fb_cma_helper.h>
27#include <drm/drm_gem_cma_helper.h>
28#include <drm/drm_of.h>
29
30#include "malidp_drv.h"
31#include "malidp_regs.h"
32#include "malidp_hw.h"
33
34#define MALIDP_CONF_VALID_TIMEOUT 250
35
36/*
37 * set the "config valid" bit and wait until the hardware acts on it
38 */
39static int malidp_set_and_wait_config_valid(struct drm_device *drm)
40{
41 struct malidp_drm *malidp = drm->dev_private;
42 struct malidp_hw_device *hwdev = malidp->dev;
43 int ret;
44
45 hwdev->set_config_valid(hwdev);
46 /* don't wait for config_valid flag if we are in config mode */
47 if (hwdev->in_config_mode(hwdev))
48 return 0;
49
50 ret = wait_event_interruptible_timeout(malidp->wq,
51 atomic_read(&malidp->config_valid) == 1,
52 msecs_to_jiffies(MALIDP_CONF_VALID_TIMEOUT));
53
54 return (ret > 0) ? 0 : -ETIMEDOUT;
55}
56
57static void malidp_output_poll_changed(struct drm_device *drm)
58{
59 struct malidp_drm *malidp = drm->dev_private;
60
61 drm_fbdev_cma_hotplug_event(malidp->fbdev);
62}
63
64static void malidp_atomic_commit_hw_done(struct drm_atomic_state *state)
65{
66 struct drm_pending_vblank_event *event;
67 struct drm_device *drm = state->dev;
68 struct malidp_drm *malidp = drm->dev_private;
69 int ret = malidp_set_and_wait_config_valid(drm);
70
71 if (ret)
72 DRM_DEBUG_DRIVER("timed out waiting for updated configuration\n");
73
74 event = malidp->crtc.state->event;
75 if (event) {
76 malidp->crtc.state->event = NULL;
77
78 spin_lock_irq(&drm->event_lock);
79 if (drm_crtc_vblank_get(&malidp->crtc) == 0)
80 drm_crtc_arm_vblank_event(&malidp->crtc, event);
81 else
82 drm_crtc_send_vblank_event(&malidp->crtc, event);
83 spin_unlock_irq(&drm->event_lock);
84 }
85 drm_atomic_helper_commit_hw_done(state);
86}
87
88static void malidp_atomic_commit_tail(struct drm_atomic_state *state)
89{
90 struct drm_device *drm = state->dev;
91
92 drm_atomic_helper_commit_modeset_disables(drm, state);
93 drm_atomic_helper_commit_modeset_enables(drm, state);
94 drm_atomic_helper_commit_planes(drm, state, true);
95
96 malidp_atomic_commit_hw_done(state);
97
98 drm_atomic_helper_wait_for_vblanks(drm, state);
99
100 drm_atomic_helper_cleanup_planes(drm, state);
101}
102
103static struct drm_mode_config_helper_funcs malidp_mode_config_helpers = {
104 .atomic_commit_tail = malidp_atomic_commit_tail,
105};
106
107static const struct drm_mode_config_funcs malidp_mode_config_funcs = {
108 .fb_create = drm_fb_cma_create,
109 .output_poll_changed = malidp_output_poll_changed,
110 .atomic_check = drm_atomic_helper_check,
111 .atomic_commit = drm_atomic_helper_commit,
112};
113
114static int malidp_enable_vblank(struct drm_device *drm, unsigned int crtc)
115{
116 struct malidp_drm *malidp = drm->dev_private;
117 struct malidp_hw_device *hwdev = malidp->dev;
118
119 malidp_hw_enable_irq(hwdev, MALIDP_DE_BLOCK,
120 hwdev->map.de_irq_map.vsync_irq);
121 return 0;
122}
123
124static void malidp_disable_vblank(struct drm_device *drm, unsigned int pipe)
125{
126 struct malidp_drm *malidp = drm->dev_private;
127 struct malidp_hw_device *hwdev = malidp->dev;
128
129 malidp_hw_disable_irq(hwdev, MALIDP_DE_BLOCK,
130 hwdev->map.de_irq_map.vsync_irq);
131}
132
133static int malidp_init(struct drm_device *drm)
134{
135 int ret;
136 struct malidp_drm *malidp = drm->dev_private;
137 struct malidp_hw_device *hwdev = malidp->dev;
138
139 drm_mode_config_init(drm);
140
141 drm->mode_config.min_width = hwdev->min_line_size;
142 drm->mode_config.min_height = hwdev->min_line_size;
143 drm->mode_config.max_width = hwdev->max_line_size;
144 drm->mode_config.max_height = hwdev->max_line_size;
145 drm->mode_config.funcs = &malidp_mode_config_funcs;
146 drm->mode_config.helper_private = &malidp_mode_config_helpers;
147
148 ret = malidp_crtc_init(drm);
149 if (ret) {
150 drm_mode_config_cleanup(drm);
151 return ret;
152 }
153
154 return 0;
155}
156
157static int malidp_irq_init(struct platform_device *pdev)
158{
159 int irq_de, irq_se, ret = 0;
160 struct drm_device *drm = dev_get_drvdata(&pdev->dev);
161
162 /* fetch the interrupts from DT */
163 irq_de = platform_get_irq_byname(pdev, "DE");
164 if (irq_de < 0) {
165 DRM_ERROR("no 'DE' IRQ specified!\n");
166 return irq_de;
167 }
168 irq_se = platform_get_irq_byname(pdev, "SE");
169 if (irq_se < 0) {
170 DRM_ERROR("no 'SE' IRQ specified!\n");
171 return irq_se;
172 }
173
174 ret = malidp_de_irq_init(drm, irq_de);
175 if (ret)
176 return ret;
177
178 ret = malidp_se_irq_init(drm, irq_se);
179 if (ret) {
180 malidp_de_irq_fini(drm);
181 return ret;
182 }
183
184 return 0;
185}
186
187static void malidp_lastclose(struct drm_device *drm)
188{
189 struct malidp_drm *malidp = drm->dev_private;
190
191 drm_fbdev_cma_restore_mode(malidp->fbdev);
192}
193
194static const struct file_operations fops = {
195 .owner = THIS_MODULE,
196 .open = drm_open,
197 .release = drm_release,
198 .unlocked_ioctl = drm_ioctl,
199#ifdef CONFIG_COMPAT
200 .compat_ioctl = drm_compat_ioctl,
201#endif
202 .poll = drm_poll,
203 .read = drm_read,
204 .llseek = noop_llseek,
205 .mmap = drm_gem_cma_mmap,
206};
207
208static struct drm_driver malidp_driver = {
209 .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC |
210 DRIVER_PRIME,
211 .lastclose = malidp_lastclose,
212 .get_vblank_counter = drm_vblank_no_hw_counter,
213 .enable_vblank = malidp_enable_vblank,
214 .disable_vblank = malidp_disable_vblank,
215 .gem_free_object_unlocked = drm_gem_cma_free_object,
216 .gem_vm_ops = &drm_gem_cma_vm_ops,
217 .dumb_create = drm_gem_cma_dumb_create,
218 .dumb_map_offset = drm_gem_cma_dumb_map_offset,
219 .dumb_destroy = drm_gem_dumb_destroy,
220 .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
221 .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
222 .gem_prime_export = drm_gem_prime_export,
223 .gem_prime_import = drm_gem_prime_import,
224 .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
225 .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
226 .gem_prime_vmap = drm_gem_cma_prime_vmap,
227 .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
228 .gem_prime_mmap = drm_gem_cma_prime_mmap,
229 .fops = &fops,
230 .name = "mali-dp",
231 .desc = "ARM Mali Display Processor driver",
232 .date = "20160106",
233 .major = 1,
234 .minor = 0,
235};
236
237static const struct of_device_id malidp_drm_of_match[] = {
238 {
239 .compatible = "arm,mali-dp500",
240 .data = &malidp_device[MALIDP_500]
241 },
242 {
243 .compatible = "arm,mali-dp550",
244 .data = &malidp_device[MALIDP_550]
245 },
246 {
247 .compatible = "arm,mali-dp650",
248 .data = &malidp_device[MALIDP_650]
249 },
250 {},
251};
252MODULE_DEVICE_TABLE(of, malidp_drm_of_match);
253
254#define MAX_OUTPUT_CHANNELS 3
255
256static int malidp_bind(struct device *dev)
257{
258 struct resource *res;
259 struct drm_device *drm;
3c31760e 260 struct device_node *ep;
ad49f860
LD
261 struct malidp_drm *malidp;
262 struct malidp_hw_device *hwdev;
263 struct platform_device *pdev = to_platform_device(dev);
264 /* number of lines for the R, G and B output */
265 u8 output_width[MAX_OUTPUT_CHANNELS];
266 int ret = 0, i;
267 u32 version, out_depth = 0;
268
269 malidp = devm_kzalloc(dev, sizeof(*malidp), GFP_KERNEL);
270 if (!malidp)
271 return -ENOMEM;
272
273 hwdev = devm_kzalloc(dev, sizeof(*hwdev), GFP_KERNEL);
274 if (!hwdev)
275 return -ENOMEM;
276
277 /*
278 * copy the associated data from malidp_drm_of_match to avoid
279 * having to keep a reference to the OF node after binding
280 */
281 memcpy(hwdev, of_device_get_match_data(dev), sizeof(*hwdev));
282 malidp->dev = hwdev;
283
284 INIT_LIST_HEAD(&malidp->event_list);
285
286 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
287 hwdev->regs = devm_ioremap_resource(dev, res);
1a9d71f8 288 if (IS_ERR(hwdev->regs))
ad49f860 289 return PTR_ERR(hwdev->regs);
ad49f860
LD
290
291 hwdev->pclk = devm_clk_get(dev, "pclk");
292 if (IS_ERR(hwdev->pclk))
293 return PTR_ERR(hwdev->pclk);
294
295 hwdev->aclk = devm_clk_get(dev, "aclk");
296 if (IS_ERR(hwdev->aclk))
297 return PTR_ERR(hwdev->aclk);
298
299 hwdev->mclk = devm_clk_get(dev, "mclk");
300 if (IS_ERR(hwdev->mclk))
301 return PTR_ERR(hwdev->mclk);
302
303 hwdev->pxlclk = devm_clk_get(dev, "pxlclk");
304 if (IS_ERR(hwdev->pxlclk))
305 return PTR_ERR(hwdev->pxlclk);
306
307 /* Get the optional framebuffer memory resource */
308 ret = of_reserved_mem_device_init(dev);
309 if (ret && ret != -ENODEV)
310 return ret;
311
312 drm = drm_dev_alloc(&malidp_driver, dev);
313 if (!drm) {
314 ret = -ENOMEM;
315 goto alloc_fail;
316 }
317
318 /* Enable APB clock in order to get access to the registers */
319 clk_prepare_enable(hwdev->pclk);
320 /*
321 * Enable AXI clock and main clock so that prefetch can start once
322 * the registers are set
323 */
324 clk_prepare_enable(hwdev->aclk);
325 clk_prepare_enable(hwdev->mclk);
326
327 ret = hwdev->query_hw(hwdev);
328 if (ret) {
329 DRM_ERROR("Invalid HW configuration\n");
330 goto query_hw_fail;
331 }
332
333 version = malidp_hw_read(hwdev, hwdev->map.dc_base + MALIDP_DE_CORE_ID);
334 DRM_INFO("found ARM Mali-DP%3x version r%dp%d\n", version >> 16,
335 (version >> 12) & 0xf, (version >> 8) & 0xf);
336
337 /* set the number of lines used for output of RGB data */
338 ret = of_property_read_u8_array(dev->of_node,
339 "arm,malidp-output-port-lines",
340 output_width, MAX_OUTPUT_CHANNELS);
341 if (ret)
342 goto query_hw_fail;
343
344 for (i = 0; i < MAX_OUTPUT_CHANNELS; i++)
345 out_depth = (out_depth << 8) | (output_width[i] & 0xf);
346 malidp_hw_write(hwdev, out_depth, hwdev->map.out_depth_base);
347
348 drm->dev_private = malidp;
349 dev_set_drvdata(dev, drm);
350 atomic_set(&malidp->config_valid, 0);
351 init_waitqueue_head(&malidp->wq);
352
353 ret = malidp_init(drm);
354 if (ret < 0)
355 goto init_fail;
356
357 ret = drm_dev_register(drm, 0);
358 if (ret)
359 goto register_fail;
360
361 /* Set the CRTC's port so that the encoder component can find it */
3c31760e
BS
362 ep = of_graph_get_next_endpoint(dev->of_node, NULL);
363 if (!ep)
364 goto port_fail;
365 malidp->crtc.port = of_get_next_parent(ep);
ad49f860
LD
366
367 ret = component_bind_all(dev, drm);
ad49f860
LD
368 if (ret) {
369 DRM_ERROR("Failed to bind all components\n");
370 goto bind_fail;
371 }
372
373 ret = malidp_irq_init(pdev);
374 if (ret < 0)
375 goto irq_init_fail;
376
377 ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
378 if (ret < 0) {
379 DRM_ERROR("failed to initialise vblank\n");
380 goto vblank_fail;
381 }
382
383 drm_mode_config_reset(drm);
384
385 malidp->fbdev = drm_fbdev_cma_init(drm, 32, drm->mode_config.num_crtc,
386 drm->mode_config.num_connector);
387
388 if (IS_ERR(malidp->fbdev)) {
389 ret = PTR_ERR(malidp->fbdev);
390 malidp->fbdev = NULL;
391 goto fbdev_fail;
392 }
393
394 drm_kms_helper_poll_init(drm);
395 return 0;
396
397fbdev_fail:
398 drm_vblank_cleanup(drm);
399vblank_fail:
400 malidp_se_irq_fini(drm);
401 malidp_de_irq_fini(drm);
402irq_init_fail:
403 component_unbind_all(dev, drm);
404bind_fail:
3c31760e
BS
405 of_node_put(malidp->crtc.port);
406 malidp->crtc.port = NULL;
407port_fail:
ad49f860
LD
408 drm_dev_unregister(drm);
409register_fail:
410 malidp_de_planes_destroy(drm);
411 drm_mode_config_cleanup(drm);
412init_fail:
413 drm->dev_private = NULL;
414 dev_set_drvdata(dev, NULL);
415query_hw_fail:
416 clk_disable_unprepare(hwdev->mclk);
417 clk_disable_unprepare(hwdev->aclk);
418 clk_disable_unprepare(hwdev->pclk);
419 drm_dev_unref(drm);
420alloc_fail:
421 of_reserved_mem_device_release(dev);
422
423 return ret;
424}
425
426static void malidp_unbind(struct device *dev)
427{
428 struct drm_device *drm = dev_get_drvdata(dev);
429 struct malidp_drm *malidp = drm->dev_private;
430 struct malidp_hw_device *hwdev = malidp->dev;
431
432 if (malidp->fbdev) {
433 drm_fbdev_cma_fini(malidp->fbdev);
434 malidp->fbdev = NULL;
435 }
436 drm_kms_helper_poll_fini(drm);
437 malidp_se_irq_fini(drm);
438 malidp_de_irq_fini(drm);
439 drm_vblank_cleanup(drm);
440 component_unbind_all(dev, drm);
3c31760e
BS
441 of_node_put(malidp->crtc.port);
442 malidp->crtc.port = NULL;
ad49f860
LD
443 drm_dev_unregister(drm);
444 malidp_de_planes_destroy(drm);
445 drm_mode_config_cleanup(drm);
446 drm->dev_private = NULL;
447 dev_set_drvdata(dev, NULL);
448 clk_disable_unprepare(hwdev->mclk);
449 clk_disable_unprepare(hwdev->aclk);
450 clk_disable_unprepare(hwdev->pclk);
451 drm_dev_unref(drm);
452 of_reserved_mem_device_release(dev);
453}
454
455static const struct component_master_ops malidp_master_ops = {
456 .bind = malidp_bind,
457 .unbind = malidp_unbind,
458};
459
460static int malidp_compare_dev(struct device *dev, void *data)
461{
462 struct device_node *np = data;
463
464 return dev->of_node == np;
465}
466
467static int malidp_platform_probe(struct platform_device *pdev)
468{
469 struct device_node *port, *ep;
470 struct component_match *match = NULL;
471
472 if (!pdev->dev.of_node)
473 return -ENODEV;
474
475 /* there is only one output port inside each device, find it */
476 ep = of_graph_get_next_endpoint(pdev->dev.of_node, NULL);
477 if (!ep)
478 return -ENODEV;
479
480 if (!of_device_is_available(ep)) {
481 of_node_put(ep);
482 return -ENODEV;
483 }
484
485 /* add the remote encoder port as component */
486 port = of_graph_get_remote_port_parent(ep);
487 of_node_put(ep);
488 if (!port || !of_device_is_available(port)) {
489 of_node_put(port);
490 return -EAGAIN;
491 }
492
493 component_match_add(&pdev->dev, &match, malidp_compare_dev, port);
494 return component_master_add_with_match(&pdev->dev, &malidp_master_ops,
495 match);
496}
497
498static int malidp_platform_remove(struct platform_device *pdev)
499{
500 component_master_del(&pdev->dev, &malidp_master_ops);
501 return 0;
502}
503
504static struct platform_driver malidp_platform_driver = {
505 .probe = malidp_platform_probe,
506 .remove = malidp_platform_remove,
507 .driver = {
508 .name = "mali-dp",
509 .of_match_table = malidp_drm_of_match,
510 },
511};
512
513module_platform_driver(malidp_platform_driver);
514
515MODULE_AUTHOR("Liviu Dudau <Liviu.Dudau@arm.com>");
516MODULE_DESCRIPTION("ARM Mali DP DRM driver");
517MODULE_LICENSE("GPL v2");
This page took 0.048743 seconds and 5 git commands to generate.