Commit | Line | Data |
---|---|---|
351e3db2 BV |
1 | /* |
2 | * Copyright © 2013 Intel Corporation | |
3 | * | |
4 | * Permission is hereby granted, free of charge, to any person obtaining a | |
5 | * copy of this software and associated documentation files (the "Software"), | |
6 | * to deal in the Software without restriction, including without limitation | |
7 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, | |
8 | * and/or sell copies of the Software, and to permit persons to whom the | |
9 | * Software is furnished to do so, subject to the following conditions: | |
10 | * | |
11 | * The above copyright notice and this permission notice (including the next | |
12 | * paragraph) shall be included in all copies or substantial portions of the | |
13 | * Software. | |
14 | * | |
15 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | |
16 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | |
17 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | |
18 | * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | |
19 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | |
20 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS | |
21 | * IN THE SOFTWARE. | |
22 | * | |
23 | * Authors: | |
24 | * Brad Volkin <bradley.d.volkin@intel.com> | |
25 | * | |
26 | */ | |
27 | ||
28 | #include "i915_drv.h" | |
29 | ||
30 | /** | |
122b2505 | 31 | * DOC: batch buffer command parser |
351e3db2 BV |
32 | * |
33 | * Motivation: | |
34 | * Certain OpenGL features (e.g. transform feedback, performance monitoring) | |
35 | * require userspace code to submit batches containing commands such as | |
36 | * MI_LOAD_REGISTER_IMM to access various registers. Unfortunately, some | |
37 | * generations of the hardware will noop these commands in "unsecure" batches | |
38 | * (which includes all userspace batches submitted via i915) even though the | |
39 | * commands may be safe and represent the intended programming model of the | |
40 | * device. | |
41 | * | |
42 | * The software command parser is similar in operation to the command parsing | |
43 | * done in hardware for unsecure batches. However, the software parser allows | |
44 | * some operations that would be noop'd by hardware, if the parser determines | |
45 | * the operation is safe, and submits the batch as "secure" to prevent hardware | |
46 | * parsing. | |
47 | * | |
48 | * Threats: | |
49 | * At a high level, the hardware (and software) checks attempt to prevent | |
50 | * granting userspace undue privileges. There are three categories of privilege. | |
51 | * | |
52 | * First, commands which are explicitly defined as privileged or which should | |
53 | * only be used by the kernel driver. The parser generally rejects such | |
54 | * commands, though it may allow some from the drm master process. | |
55 | * | |
56 | * Second, commands which access registers. To support correct/enhanced | |
57 | * userspace functionality, particularly certain OpenGL extensions, the parser | |
58 | * provides a whitelist of registers which userspace may safely access (for both | |
59 | * normal and drm master processes). | |
60 | * | |
61 | * Third, commands which access privileged memory (i.e. GGTT, HWS page, etc). | |
62 | * The parser always rejects such commands. | |
63 | * | |
64 | * The majority of the problematic commands fall in the MI_* range, with only a | |
65 | * few specific commands on each ring (e.g. PIPE_CONTROL and MI_FLUSH_DW). | |
66 | * | |
67 | * Implementation: | |
68 | * Each ring maintains tables of commands and registers which the parser uses in | |
69 | * scanning batch buffers submitted to that ring. | |
70 | * | |
71 | * Since the set of commands that the parser must check for is significantly | |
72 | * smaller than the number of commands supported, the parser tables contain only | |
73 | * those commands required by the parser. This generally works because command | |
74 | * opcode ranges have standard command length encodings. So for commands that | |
75 | * the parser does not need to check, it can easily skip them. This is | |
76 | * implementated via a per-ring length decoding vfunc. | |
77 | * | |
78 | * Unfortunately, there are a number of commands that do not follow the standard | |
79 | * length encoding for their opcode range, primarily amongst the MI_* commands. | |
80 | * To handle this, the parser provides a way to define explicit "skip" entries | |
81 | * in the per-ring command tables. | |
82 | * | |
83 | * Other command table entries map fairly directly to high level categories | |
84 | * mentioned above: rejected, master-only, register whitelist. The parser | |
85 | * implements a number of checks, including the privileged memory checks, via a | |
86 | * general bitmasking mechanism. | |
87 | */ | |
88 | ||
3a6fa984 BV |
89 | #define STD_MI_OPCODE_MASK 0xFF800000 |
90 | #define STD_3D_OPCODE_MASK 0xFFFF0000 | |
91 | #define STD_2D_OPCODE_MASK 0xFFC00000 | |
92 | #define STD_MFX_OPCODE_MASK 0xFFFF0000 | |
93 | ||
94 | #define CMD(op, opm, f, lm, fl, ...) \ | |
95 | { \ | |
96 | .flags = (fl) | ((f) ? CMD_DESC_FIXED : 0), \ | |
97 | .cmd = { (op), (opm) }, \ | |
98 | .length = { (lm) }, \ | |
99 | __VA_ARGS__ \ | |
100 | } | |
101 | ||
102 | /* Convenience macros to compress the tables */ | |
103 | #define SMI STD_MI_OPCODE_MASK | |
104 | #define S3D STD_3D_OPCODE_MASK | |
105 | #define S2D STD_2D_OPCODE_MASK | |
106 | #define SMFX STD_MFX_OPCODE_MASK | |
107 | #define F true | |
108 | #define S CMD_DESC_SKIP | |
109 | #define R CMD_DESC_REJECT | |
110 | #define W CMD_DESC_REGISTER | |
111 | #define B CMD_DESC_BITMASK | |
112 | #define M CMD_DESC_MASTER | |
113 | ||
114 | /* Command Mask Fixed Len Action | |
115 | ---------------------------------------------------------- */ | |
116 | static const struct drm_i915_cmd_descriptor common_cmds[] = { | |
117 | CMD( MI_NOOP, SMI, F, 1, S ), | |
b18b396b | 118 | CMD( MI_USER_INTERRUPT, SMI, F, 1, R ), |
17c1eb15 | 119 | CMD( MI_WAIT_FOR_EVENT, SMI, F, 1, M ), |
3a6fa984 BV |
120 | CMD( MI_ARB_CHECK, SMI, F, 1, S ), |
121 | CMD( MI_REPORT_HEAD, SMI, F, 1, S ), | |
122 | CMD( MI_SUSPEND_FLUSH, SMI, F, 1, S ), | |
9c640d1d BV |
123 | CMD( MI_SEMAPHORE_MBOX, SMI, !F, 0xFF, R ), |
124 | CMD( MI_STORE_DWORD_INDEX, SMI, !F, 0xFF, R ), | |
f0a346bd BV |
125 | CMD( MI_LOAD_REGISTER_IMM(1), SMI, !F, 0xFF, W, |
126 | .reg = { .offset = 1, .mask = 0x007FFFFC } ), | |
d4d48035 BV |
127 | CMD( MI_STORE_REGISTER_MEM(1), SMI, !F, 0xFF, W | B, |
128 | .reg = { .offset = 1, .mask = 0x007FFFFC }, | |
129 | .bits = {{ | |
130 | .offset = 0, | |
131 | .mask = MI_GLOBAL_GTT, | |
132 | .expected = 0, | |
133 | }}, ), | |
134 | CMD( MI_LOAD_REGISTER_MEM, SMI, !F, 0xFF, W | B, | |
135 | .reg = { .offset = 1, .mask = 0x007FFFFC }, | |
136 | .bits = {{ | |
137 | .offset = 0, | |
138 | .mask = MI_GLOBAL_GTT, | |
139 | .expected = 0, | |
140 | }}, ), | |
3a6fa984 BV |
141 | CMD( MI_BATCH_BUFFER_START, SMI, !F, 0xFF, S ), |
142 | }; | |
143 | ||
144 | static const struct drm_i915_cmd_descriptor render_cmds[] = { | |
145 | CMD( MI_FLUSH, SMI, F, 1, S ), | |
9c640d1d | 146 | CMD( MI_ARB_ON_OFF, SMI, F, 1, R ), |
3a6fa984 BV |
147 | CMD( MI_PREDICATE, SMI, F, 1, S ), |
148 | CMD( MI_TOPOLOGY_FILTER, SMI, F, 1, S ), | |
9c640d1d BV |
149 | CMD( MI_DISPLAY_FLIP, SMI, !F, 0xFF, R ), |
150 | CMD( MI_SET_CONTEXT, SMI, !F, 0xFF, R ), | |
3a6fa984 | 151 | CMD( MI_URB_CLEAR, SMI, !F, 0xFF, S ), |
d4d48035 BV |
152 | CMD( MI_STORE_DWORD_IMM, SMI, !F, 0x3F, B, |
153 | .bits = {{ | |
154 | .offset = 0, | |
155 | .mask = MI_GLOBAL_GTT, | |
156 | .expected = 0, | |
157 | }}, ), | |
9c640d1d | 158 | CMD( MI_UPDATE_GTT, SMI, !F, 0xFF, R ), |
d4d48035 BV |
159 | CMD( MI_CLFLUSH, SMI, !F, 0x3FF, B, |
160 | .bits = {{ | |
161 | .offset = 0, | |
162 | .mask = MI_GLOBAL_GTT, | |
163 | .expected = 0, | |
164 | }}, ), | |
165 | CMD( MI_REPORT_PERF_COUNT, SMI, !F, 0x3F, B, | |
166 | .bits = {{ | |
167 | .offset = 1, | |
168 | .mask = MI_REPORT_PERF_COUNT_GGTT, | |
169 | .expected = 0, | |
170 | }}, ), | |
171 | CMD( MI_CONDITIONAL_BATCH_BUFFER_END, SMI, !F, 0xFF, B, | |
172 | .bits = {{ | |
173 | .offset = 0, | |
174 | .mask = MI_GLOBAL_GTT, | |
175 | .expected = 0, | |
176 | }}, ), | |
3a6fa984 BV |
177 | CMD( GFX_OP_3DSTATE_VF_STATISTICS, S3D, F, 1, S ), |
178 | CMD( PIPELINE_SELECT, S3D, F, 1, S ), | |
f0a346bd BV |
179 | CMD( MEDIA_VFE_STATE, S3D, !F, 0xFFFF, B, |
180 | .bits = {{ | |
181 | .offset = 2, | |
182 | .mask = MEDIA_VFE_STATE_MMIO_ACCESS_MASK, | |
183 | .expected = 0, | |
184 | }}, ), | |
3a6fa984 BV |
185 | CMD( GPGPU_OBJECT, S3D, !F, 0xFF, S ), |
186 | CMD( GPGPU_WALKER, S3D, !F, 0xFF, S ), | |
187 | CMD( GFX_OP_3DSTATE_SO_DECL_LIST, S3D, !F, 0x1FF, S ), | |
f0a346bd BV |
188 | CMD( GFX_OP_PIPE_CONTROL(5), S3D, !F, 0xFF, B, |
189 | .bits = {{ | |
190 | .offset = 1, | |
b18b396b | 191 | .mask = (PIPE_CONTROL_MMIO_WRITE | PIPE_CONTROL_NOTIFY), |
f0a346bd | 192 | .expected = 0, |
d4d48035 BV |
193 | }, |
194 | { | |
195 | .offset = 1, | |
114d4f70 BV |
196 | .mask = (PIPE_CONTROL_GLOBAL_GTT_IVB | |
197 | PIPE_CONTROL_STORE_DATA_INDEX), | |
d4d48035 BV |
198 | .expected = 0, |
199 | .condition_offset = 1, | |
200 | .condition_mask = PIPE_CONTROL_POST_SYNC_OP_MASK, | |
f0a346bd | 201 | }}, ), |
3a6fa984 BV |
202 | }; |
203 | ||
204 | static const struct drm_i915_cmd_descriptor hsw_render_cmds[] = { | |
205 | CMD( MI_SET_PREDICATE, SMI, F, 1, S ), | |
206 | CMD( MI_RS_CONTROL, SMI, F, 1, S ), | |
207 | CMD( MI_URB_ATOMIC_ALLOC, SMI, F, 1, S ), | |
208 | CMD( MI_RS_CONTEXT, SMI, F, 1, S ), | |
17c1eb15 | 209 | CMD( MI_LOAD_SCAN_LINES_INCL, SMI, !F, 0x3F, M ), |
9c640d1d BV |
210 | CMD( MI_LOAD_SCAN_LINES_EXCL, SMI, !F, 0x3F, R ), |
211 | CMD( MI_LOAD_REGISTER_REG, SMI, !F, 0xFF, R ), | |
3a6fa984 BV |
212 | CMD( MI_RS_STORE_DATA_IMM, SMI, !F, 0xFF, S ), |
213 | CMD( MI_LOAD_URB_MEM, SMI, !F, 0xFF, S ), | |
214 | CMD( MI_STORE_URB_MEM, SMI, !F, 0xFF, S ), | |
215 | CMD( GFX_OP_3DSTATE_DX9_CONSTANTF_VS, S3D, !F, 0x7FF, S ), | |
216 | CMD( GFX_OP_3DSTATE_DX9_CONSTANTF_PS, S3D, !F, 0x7FF, S ), | |
217 | ||
218 | CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_VS, S3D, !F, 0x1FF, S ), | |
219 | CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_GS, S3D, !F, 0x1FF, S ), | |
220 | CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_HS, S3D, !F, 0x1FF, S ), | |
221 | CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_DS, S3D, !F, 0x1FF, S ), | |
222 | CMD( GFX_OP_3DSTATE_BINDING_TABLE_EDIT_PS, S3D, !F, 0x1FF, S ), | |
223 | }; | |
224 | ||
225 | static const struct drm_i915_cmd_descriptor video_cmds[] = { | |
9c640d1d | 226 | CMD( MI_ARB_ON_OFF, SMI, F, 1, R ), |
d4d48035 BV |
227 | CMD( MI_STORE_DWORD_IMM, SMI, !F, 0xFF, B, |
228 | .bits = {{ | |
229 | .offset = 0, | |
230 | .mask = MI_GLOBAL_GTT, | |
231 | .expected = 0, | |
232 | }}, ), | |
9c640d1d | 233 | CMD( MI_UPDATE_GTT, SMI, !F, 0x3F, R ), |
b18b396b BV |
234 | CMD( MI_FLUSH_DW, SMI, !F, 0x3F, B, |
235 | .bits = {{ | |
236 | .offset = 0, | |
237 | .mask = MI_FLUSH_DW_NOTIFY, | |
238 | .expected = 0, | |
d4d48035 BV |
239 | }, |
240 | { | |
241 | .offset = 1, | |
242 | .mask = MI_FLUSH_DW_USE_GTT, | |
243 | .expected = 0, | |
244 | .condition_offset = 0, | |
245 | .condition_mask = MI_FLUSH_DW_OP_MASK, | |
114d4f70 BV |
246 | }, |
247 | { | |
248 | .offset = 0, | |
249 | .mask = MI_FLUSH_DW_STORE_INDEX, | |
250 | .expected = 0, | |
251 | .condition_offset = 0, | |
252 | .condition_mask = MI_FLUSH_DW_OP_MASK, | |
d4d48035 BV |
253 | }}, ), |
254 | CMD( MI_CONDITIONAL_BATCH_BUFFER_END, SMI, !F, 0xFF, B, | |
255 | .bits = {{ | |
256 | .offset = 0, | |
257 | .mask = MI_GLOBAL_GTT, | |
258 | .expected = 0, | |
b18b396b | 259 | }}, ), |
3a6fa984 BV |
260 | /* |
261 | * MFX_WAIT doesn't fit the way we handle length for most commands. | |
262 | * It has a length field but it uses a non-standard length bias. | |
263 | * It is always 1 dword though, so just treat it as fixed length. | |
264 | */ | |
265 | CMD( MFX_WAIT, SMFX, F, 1, S ), | |
266 | }; | |
267 | ||
268 | static const struct drm_i915_cmd_descriptor vecs_cmds[] = { | |
9c640d1d | 269 | CMD( MI_ARB_ON_OFF, SMI, F, 1, R ), |
d4d48035 BV |
270 | CMD( MI_STORE_DWORD_IMM, SMI, !F, 0xFF, B, |
271 | .bits = {{ | |
272 | .offset = 0, | |
273 | .mask = MI_GLOBAL_GTT, | |
274 | .expected = 0, | |
275 | }}, ), | |
9c640d1d | 276 | CMD( MI_UPDATE_GTT, SMI, !F, 0x3F, R ), |
b18b396b BV |
277 | CMD( MI_FLUSH_DW, SMI, !F, 0x3F, B, |
278 | .bits = {{ | |
279 | .offset = 0, | |
280 | .mask = MI_FLUSH_DW_NOTIFY, | |
281 | .expected = 0, | |
d4d48035 BV |
282 | }, |
283 | { | |
284 | .offset = 1, | |
285 | .mask = MI_FLUSH_DW_USE_GTT, | |
286 | .expected = 0, | |
287 | .condition_offset = 0, | |
288 | .condition_mask = MI_FLUSH_DW_OP_MASK, | |
114d4f70 BV |
289 | }, |
290 | { | |
291 | .offset = 0, | |
292 | .mask = MI_FLUSH_DW_STORE_INDEX, | |
293 | .expected = 0, | |
294 | .condition_offset = 0, | |
295 | .condition_mask = MI_FLUSH_DW_OP_MASK, | |
d4d48035 BV |
296 | }}, ), |
297 | CMD( MI_CONDITIONAL_BATCH_BUFFER_END, SMI, !F, 0xFF, B, | |
298 | .bits = {{ | |
299 | .offset = 0, | |
300 | .mask = MI_GLOBAL_GTT, | |
301 | .expected = 0, | |
b18b396b | 302 | }}, ), |
3a6fa984 BV |
303 | }; |
304 | ||
305 | static const struct drm_i915_cmd_descriptor blt_cmds[] = { | |
9c640d1d | 306 | CMD( MI_DISPLAY_FLIP, SMI, !F, 0xFF, R ), |
d4d48035 BV |
307 | CMD( MI_STORE_DWORD_IMM, SMI, !F, 0x3FF, B, |
308 | .bits = {{ | |
309 | .offset = 0, | |
310 | .mask = MI_GLOBAL_GTT, | |
311 | .expected = 0, | |
312 | }}, ), | |
9c640d1d | 313 | CMD( MI_UPDATE_GTT, SMI, !F, 0x3F, R ), |
b18b396b BV |
314 | CMD( MI_FLUSH_DW, SMI, !F, 0x3F, B, |
315 | .bits = {{ | |
316 | .offset = 0, | |
317 | .mask = MI_FLUSH_DW_NOTIFY, | |
318 | .expected = 0, | |
d4d48035 BV |
319 | }, |
320 | { | |
321 | .offset = 1, | |
322 | .mask = MI_FLUSH_DW_USE_GTT, | |
323 | .expected = 0, | |
324 | .condition_offset = 0, | |
325 | .condition_mask = MI_FLUSH_DW_OP_MASK, | |
114d4f70 BV |
326 | }, |
327 | { | |
328 | .offset = 0, | |
329 | .mask = MI_FLUSH_DW_STORE_INDEX, | |
330 | .expected = 0, | |
331 | .condition_offset = 0, | |
332 | .condition_mask = MI_FLUSH_DW_OP_MASK, | |
b18b396b | 333 | }}, ), |
3a6fa984 BV |
334 | CMD( COLOR_BLT, S2D, !F, 0x3F, S ), |
335 | CMD( SRC_COPY_BLT, S2D, !F, 0x3F, S ), | |
336 | }; | |
337 | ||
9c640d1d | 338 | static const struct drm_i915_cmd_descriptor hsw_blt_cmds[] = { |
17c1eb15 | 339 | CMD( MI_LOAD_SCAN_LINES_INCL, SMI, !F, 0x3F, M ), |
9c640d1d BV |
340 | CMD( MI_LOAD_SCAN_LINES_EXCL, SMI, !F, 0x3F, R ), |
341 | }; | |
342 | ||
3a6fa984 BV |
343 | #undef CMD |
344 | #undef SMI | |
345 | #undef S3D | |
346 | #undef S2D | |
347 | #undef SMFX | |
348 | #undef F | |
349 | #undef S | |
350 | #undef R | |
351 | #undef W | |
352 | #undef B | |
353 | #undef M | |
354 | ||
355 | static const struct drm_i915_cmd_table gen7_render_cmds[] = { | |
356 | { common_cmds, ARRAY_SIZE(common_cmds) }, | |
357 | { render_cmds, ARRAY_SIZE(render_cmds) }, | |
358 | }; | |
359 | ||
360 | static const struct drm_i915_cmd_table hsw_render_ring_cmds[] = { | |
361 | { common_cmds, ARRAY_SIZE(common_cmds) }, | |
362 | { render_cmds, ARRAY_SIZE(render_cmds) }, | |
363 | { hsw_render_cmds, ARRAY_SIZE(hsw_render_cmds) }, | |
364 | }; | |
365 | ||
366 | static const struct drm_i915_cmd_table gen7_video_cmds[] = { | |
367 | { common_cmds, ARRAY_SIZE(common_cmds) }, | |
368 | { video_cmds, ARRAY_SIZE(video_cmds) }, | |
369 | }; | |
370 | ||
371 | static const struct drm_i915_cmd_table hsw_vebox_cmds[] = { | |
372 | { common_cmds, ARRAY_SIZE(common_cmds) }, | |
373 | { vecs_cmds, ARRAY_SIZE(vecs_cmds) }, | |
374 | }; | |
375 | ||
376 | static const struct drm_i915_cmd_table gen7_blt_cmds[] = { | |
377 | { common_cmds, ARRAY_SIZE(common_cmds) }, | |
378 | { blt_cmds, ARRAY_SIZE(blt_cmds) }, | |
379 | }; | |
380 | ||
9c640d1d BV |
381 | static const struct drm_i915_cmd_table hsw_blt_ring_cmds[] = { |
382 | { common_cmds, ARRAY_SIZE(common_cmds) }, | |
383 | { blt_cmds, ARRAY_SIZE(blt_cmds) }, | |
384 | { hsw_blt_cmds, ARRAY_SIZE(hsw_blt_cmds) }, | |
385 | }; | |
386 | ||
5947de9b BV |
387 | /* |
388 | * Register whitelists, sorted by increasing register offset. | |
389 | * | |
390 | * Some registers that userspace accesses are 64 bits. The register | |
391 | * access commands only allow 32-bit accesses. Hence, we have to include | |
392 | * entries for both halves of the 64-bit registers. | |
393 | */ | |
394 | ||
395 | /* Convenience macro for adding 64-bit registers */ | |
396 | #define REG64(addr) (addr), (addr + sizeof(u32)) | |
397 | ||
398 | static const u32 gen7_render_regs[] = { | |
399 | REG64(HS_INVOCATION_COUNT), | |
400 | REG64(DS_INVOCATION_COUNT), | |
401 | REG64(IA_VERTICES_COUNT), | |
402 | REG64(IA_PRIMITIVES_COUNT), | |
403 | REG64(VS_INVOCATION_COUNT), | |
404 | REG64(GS_INVOCATION_COUNT), | |
405 | REG64(GS_PRIMITIVES_COUNT), | |
406 | REG64(CL_INVOCATION_COUNT), | |
407 | REG64(CL_PRIMITIVES_COUNT), | |
408 | REG64(PS_INVOCATION_COUNT), | |
409 | REG64(PS_DEPTH_COUNT), | |
6e66ea13 | 410 | OACONTROL, /* Only allowed for LRI and SRM. See below. */ |
113a0476 BV |
411 | GEN7_3DPRIM_END_OFFSET, |
412 | GEN7_3DPRIM_START_VERTEX, | |
413 | GEN7_3DPRIM_VERTEX_COUNT, | |
414 | GEN7_3DPRIM_INSTANCE_COUNT, | |
415 | GEN7_3DPRIM_START_INSTANCE, | |
416 | GEN7_3DPRIM_BASE_VERTEX, | |
5947de9b BV |
417 | REG64(GEN7_SO_NUM_PRIMS_WRITTEN(0)), |
418 | REG64(GEN7_SO_NUM_PRIMS_WRITTEN(1)), | |
419 | REG64(GEN7_SO_NUM_PRIMS_WRITTEN(2)), | |
420 | REG64(GEN7_SO_NUM_PRIMS_WRITTEN(3)), | |
113a0476 BV |
421 | REG64(GEN7_SO_PRIM_STORAGE_NEEDED(0)), |
422 | REG64(GEN7_SO_PRIM_STORAGE_NEEDED(1)), | |
423 | REG64(GEN7_SO_PRIM_STORAGE_NEEDED(2)), | |
424 | REG64(GEN7_SO_PRIM_STORAGE_NEEDED(3)), | |
5947de9b BV |
425 | GEN7_SO_WRITE_OFFSET(0), |
426 | GEN7_SO_WRITE_OFFSET(1), | |
427 | GEN7_SO_WRITE_OFFSET(2), | |
428 | GEN7_SO_WRITE_OFFSET(3), | |
429 | }; | |
430 | ||
431 | static const u32 gen7_blt_regs[] = { | |
432 | BCS_SWCTRL, | |
433 | }; | |
434 | ||
220375aa BV |
435 | static const u32 ivb_master_regs[] = { |
436 | FORCEWAKE_MT, | |
437 | DERRMR, | |
438 | GEN7_PIPE_DE_LOAD_SL(PIPE_A), | |
439 | GEN7_PIPE_DE_LOAD_SL(PIPE_B), | |
440 | GEN7_PIPE_DE_LOAD_SL(PIPE_C), | |
441 | }; | |
442 | ||
443 | static const u32 hsw_master_regs[] = { | |
444 | FORCEWAKE_MT, | |
445 | DERRMR, | |
446 | }; | |
447 | ||
5947de9b BV |
448 | #undef REG64 |
449 | ||
351e3db2 BV |
450 | static u32 gen7_render_get_cmd_length_mask(u32 cmd_header) |
451 | { | |
452 | u32 client = (cmd_header & INSTR_CLIENT_MASK) >> INSTR_CLIENT_SHIFT; | |
453 | u32 subclient = | |
454 | (cmd_header & INSTR_SUBCLIENT_MASK) >> INSTR_SUBCLIENT_SHIFT; | |
455 | ||
456 | if (client == INSTR_MI_CLIENT) | |
457 | return 0x3F; | |
458 | else if (client == INSTR_RC_CLIENT) { | |
459 | if (subclient == INSTR_MEDIA_SUBCLIENT) | |
460 | return 0xFFFF; | |
461 | else | |
462 | return 0xFF; | |
463 | } | |
464 | ||
465 | DRM_DEBUG_DRIVER("CMD: Abnormal rcs cmd length! 0x%08X\n", cmd_header); | |
466 | return 0; | |
467 | } | |
468 | ||
469 | static u32 gen7_bsd_get_cmd_length_mask(u32 cmd_header) | |
470 | { | |
471 | u32 client = (cmd_header & INSTR_CLIENT_MASK) >> INSTR_CLIENT_SHIFT; | |
472 | u32 subclient = | |
473 | (cmd_header & INSTR_SUBCLIENT_MASK) >> INSTR_SUBCLIENT_SHIFT; | |
474 | ||
475 | if (client == INSTR_MI_CLIENT) | |
476 | return 0x3F; | |
477 | else if (client == INSTR_RC_CLIENT) { | |
478 | if (subclient == INSTR_MEDIA_SUBCLIENT) | |
479 | return 0xFFF; | |
480 | else | |
481 | return 0xFF; | |
482 | } | |
483 | ||
484 | DRM_DEBUG_DRIVER("CMD: Abnormal bsd cmd length! 0x%08X\n", cmd_header); | |
485 | return 0; | |
486 | } | |
487 | ||
488 | static u32 gen7_blt_get_cmd_length_mask(u32 cmd_header) | |
489 | { | |
490 | u32 client = (cmd_header & INSTR_CLIENT_MASK) >> INSTR_CLIENT_SHIFT; | |
491 | ||
492 | if (client == INSTR_MI_CLIENT) | |
493 | return 0x3F; | |
494 | else if (client == INSTR_BC_CLIENT) | |
495 | return 0xFF; | |
496 | ||
497 | DRM_DEBUG_DRIVER("CMD: Abnormal blt cmd length! 0x%08X\n", cmd_header); | |
498 | return 0; | |
499 | } | |
500 | ||
300233ee | 501 | static bool validate_cmds_sorted(struct intel_ring_buffer *ring) |
351e3db2 BV |
502 | { |
503 | int i; | |
300233ee | 504 | bool ret = true; |
351e3db2 BV |
505 | |
506 | if (!ring->cmd_tables || ring->cmd_table_count == 0) | |
300233ee | 507 | return true; |
351e3db2 BV |
508 | |
509 | for (i = 0; i < ring->cmd_table_count; i++) { | |
510 | const struct drm_i915_cmd_table *table = &ring->cmd_tables[i]; | |
511 | u32 previous = 0; | |
512 | int j; | |
513 | ||
514 | for (j = 0; j < table->count; j++) { | |
515 | const struct drm_i915_cmd_descriptor *desc = | |
516 | &table->table[i]; | |
517 | u32 curr = desc->cmd.value & desc->cmd.mask; | |
518 | ||
300233ee | 519 | if (curr < previous) { |
351e3db2 BV |
520 | DRM_ERROR("CMD: table not sorted ring=%d table=%d entry=%d cmd=0x%08X prev=0x%08X\n", |
521 | ring->id, i, j, curr, previous); | |
300233ee BV |
522 | ret = false; |
523 | } | |
351e3db2 BV |
524 | |
525 | previous = curr; | |
526 | } | |
527 | } | |
300233ee BV |
528 | |
529 | return ret; | |
351e3db2 BV |
530 | } |
531 | ||
300233ee | 532 | static bool check_sorted(int ring_id, const u32 *reg_table, int reg_count) |
351e3db2 BV |
533 | { |
534 | int i; | |
535 | u32 previous = 0; | |
300233ee | 536 | bool ret = true; |
351e3db2 BV |
537 | |
538 | for (i = 0; i < reg_count; i++) { | |
539 | u32 curr = reg_table[i]; | |
540 | ||
300233ee | 541 | if (curr < previous) { |
351e3db2 BV |
542 | DRM_ERROR("CMD: table not sorted ring=%d entry=%d reg=0x%08X prev=0x%08X\n", |
543 | ring_id, i, curr, previous); | |
300233ee BV |
544 | ret = false; |
545 | } | |
351e3db2 BV |
546 | |
547 | previous = curr; | |
548 | } | |
300233ee BV |
549 | |
550 | return ret; | |
351e3db2 BV |
551 | } |
552 | ||
300233ee | 553 | static bool validate_regs_sorted(struct intel_ring_buffer *ring) |
351e3db2 | 554 | { |
300233ee BV |
555 | return check_sorted(ring->id, ring->reg_table, ring->reg_count) && |
556 | check_sorted(ring->id, ring->master_reg_table, | |
557 | ring->master_reg_count); | |
351e3db2 BV |
558 | } |
559 | ||
560 | /** | |
561 | * i915_cmd_parser_init_ring() - set cmd parser related fields for a ringbuffer | |
562 | * @ring: the ringbuffer to initialize | |
563 | * | |
564 | * Optionally initializes fields related to batch buffer command parsing in the | |
565 | * struct intel_ring_buffer based on whether the platform requires software | |
566 | * command parsing. | |
567 | */ | |
568 | void i915_cmd_parser_init_ring(struct intel_ring_buffer *ring) | |
569 | { | |
570 | if (!IS_GEN7(ring->dev)) | |
571 | return; | |
572 | ||
573 | switch (ring->id) { | |
574 | case RCS: | |
3a6fa984 BV |
575 | if (IS_HASWELL(ring->dev)) { |
576 | ring->cmd_tables = hsw_render_ring_cmds; | |
577 | ring->cmd_table_count = | |
578 | ARRAY_SIZE(hsw_render_ring_cmds); | |
579 | } else { | |
580 | ring->cmd_tables = gen7_render_cmds; | |
581 | ring->cmd_table_count = ARRAY_SIZE(gen7_render_cmds); | |
582 | } | |
583 | ||
5947de9b BV |
584 | ring->reg_table = gen7_render_regs; |
585 | ring->reg_count = ARRAY_SIZE(gen7_render_regs); | |
586 | ||
220375aa BV |
587 | if (IS_HASWELL(ring->dev)) { |
588 | ring->master_reg_table = hsw_master_regs; | |
589 | ring->master_reg_count = ARRAY_SIZE(hsw_master_regs); | |
590 | } else { | |
591 | ring->master_reg_table = ivb_master_regs; | |
592 | ring->master_reg_count = ARRAY_SIZE(ivb_master_regs); | |
593 | } | |
594 | ||
351e3db2 BV |
595 | ring->get_cmd_length_mask = gen7_render_get_cmd_length_mask; |
596 | break; | |
597 | case VCS: | |
3a6fa984 BV |
598 | ring->cmd_tables = gen7_video_cmds; |
599 | ring->cmd_table_count = ARRAY_SIZE(gen7_video_cmds); | |
351e3db2 BV |
600 | ring->get_cmd_length_mask = gen7_bsd_get_cmd_length_mask; |
601 | break; | |
602 | case BCS: | |
9c640d1d BV |
603 | if (IS_HASWELL(ring->dev)) { |
604 | ring->cmd_tables = hsw_blt_ring_cmds; | |
605 | ring->cmd_table_count = ARRAY_SIZE(hsw_blt_ring_cmds); | |
606 | } else { | |
607 | ring->cmd_tables = gen7_blt_cmds; | |
608 | ring->cmd_table_count = ARRAY_SIZE(gen7_blt_cmds); | |
609 | } | |
610 | ||
5947de9b BV |
611 | ring->reg_table = gen7_blt_regs; |
612 | ring->reg_count = ARRAY_SIZE(gen7_blt_regs); | |
613 | ||
220375aa BV |
614 | if (IS_HASWELL(ring->dev)) { |
615 | ring->master_reg_table = hsw_master_regs; | |
616 | ring->master_reg_count = ARRAY_SIZE(hsw_master_regs); | |
617 | } else { | |
618 | ring->master_reg_table = ivb_master_regs; | |
619 | ring->master_reg_count = ARRAY_SIZE(ivb_master_regs); | |
620 | } | |
621 | ||
351e3db2 BV |
622 | ring->get_cmd_length_mask = gen7_blt_get_cmd_length_mask; |
623 | break; | |
624 | case VECS: | |
3a6fa984 BV |
625 | ring->cmd_tables = hsw_vebox_cmds; |
626 | ring->cmd_table_count = ARRAY_SIZE(hsw_vebox_cmds); | |
351e3db2 BV |
627 | /* VECS can use the same length_mask function as VCS */ |
628 | ring->get_cmd_length_mask = gen7_bsd_get_cmd_length_mask; | |
629 | break; | |
630 | default: | |
631 | DRM_ERROR("CMD: cmd_parser_init with unknown ring: %d\n", | |
632 | ring->id); | |
633 | BUG(); | |
634 | } | |
635 | ||
300233ee BV |
636 | BUG_ON(!validate_cmds_sorted(ring)); |
637 | BUG_ON(!validate_regs_sorted(ring)); | |
351e3db2 BV |
638 | } |
639 | ||
640 | static const struct drm_i915_cmd_descriptor* | |
641 | find_cmd_in_table(const struct drm_i915_cmd_table *table, | |
642 | u32 cmd_header) | |
643 | { | |
644 | int i; | |
645 | ||
646 | for (i = 0; i < table->count; i++) { | |
647 | const struct drm_i915_cmd_descriptor *desc = &table->table[i]; | |
648 | u32 masked_cmd = desc->cmd.mask & cmd_header; | |
649 | u32 masked_value = desc->cmd.value & desc->cmd.mask; | |
650 | ||
651 | if (masked_cmd == masked_value) | |
652 | return desc; | |
653 | } | |
654 | ||
655 | return NULL; | |
656 | } | |
657 | ||
658 | /* | |
659 | * Returns a pointer to a descriptor for the command specified by cmd_header. | |
660 | * | |
661 | * The caller must supply space for a default descriptor via the default_desc | |
662 | * parameter. If no descriptor for the specified command exists in the ring's | |
663 | * command parser tables, this function fills in default_desc based on the | |
664 | * ring's default length encoding and returns default_desc. | |
665 | */ | |
666 | static const struct drm_i915_cmd_descriptor* | |
667 | find_cmd(struct intel_ring_buffer *ring, | |
668 | u32 cmd_header, | |
669 | struct drm_i915_cmd_descriptor *default_desc) | |
670 | { | |
671 | u32 mask; | |
672 | int i; | |
673 | ||
674 | for (i = 0; i < ring->cmd_table_count; i++) { | |
675 | const struct drm_i915_cmd_descriptor *desc; | |
676 | ||
677 | desc = find_cmd_in_table(&ring->cmd_tables[i], cmd_header); | |
678 | if (desc) | |
679 | return desc; | |
680 | } | |
681 | ||
682 | mask = ring->get_cmd_length_mask(cmd_header); | |
683 | if (!mask) | |
684 | return NULL; | |
685 | ||
686 | BUG_ON(!default_desc); | |
687 | default_desc->flags = CMD_DESC_SKIP; | |
688 | default_desc->length.mask = mask; | |
689 | ||
690 | return default_desc; | |
691 | } | |
692 | ||
693 | static bool valid_reg(const u32 *table, int count, u32 addr) | |
694 | { | |
695 | if (table && count != 0) { | |
696 | int i; | |
697 | ||
698 | for (i = 0; i < count; i++) { | |
699 | if (table[i] == addr) | |
700 | return true; | |
701 | } | |
702 | } | |
703 | ||
704 | return false; | |
705 | } | |
706 | ||
707 | static u32 *vmap_batch(struct drm_i915_gem_object *obj) | |
708 | { | |
709 | int i; | |
710 | void *addr = NULL; | |
711 | struct sg_page_iter sg_iter; | |
712 | struct page **pages; | |
713 | ||
714 | pages = drm_malloc_ab(obj->base.size >> PAGE_SHIFT, sizeof(*pages)); | |
715 | if (pages == NULL) { | |
716 | DRM_DEBUG_DRIVER("Failed to get space for pages\n"); | |
717 | goto finish; | |
718 | } | |
719 | ||
720 | i = 0; | |
721 | for_each_sg_page(obj->pages->sgl, &sg_iter, obj->pages->nents, 0) { | |
722 | pages[i] = sg_page_iter_page(&sg_iter); | |
723 | i++; | |
724 | } | |
725 | ||
726 | addr = vmap(pages, i, 0, PAGE_KERNEL); | |
727 | if (addr == NULL) { | |
728 | DRM_DEBUG_DRIVER("Failed to vmap pages\n"); | |
729 | goto finish; | |
730 | } | |
731 | ||
732 | finish: | |
733 | if (pages) | |
734 | drm_free_large(pages); | |
735 | return (u32*)addr; | |
736 | } | |
737 | ||
738 | /** | |
739 | * i915_needs_cmd_parser() - should a given ring use software command parsing? | |
740 | * @ring: the ring in question | |
741 | * | |
742 | * Only certain platforms require software batch buffer command parsing, and | |
743 | * only when enabled via module paramter. | |
744 | * | |
745 | * Return: true if the ring requires software command parsing | |
746 | */ | |
747 | bool i915_needs_cmd_parser(struct intel_ring_buffer *ring) | |
748 | { | |
77fec556 | 749 | struct drm_i915_private *dev_priv = ring->dev->dev_private; |
d4d48035 | 750 | |
351e3db2 BV |
751 | /* No command tables indicates a platform without parsing */ |
752 | if (!ring->cmd_tables) | |
753 | return false; | |
754 | ||
d4d48035 BV |
755 | /* |
756 | * XXX: VLV is Gen7 and therefore has cmd_tables, but has PPGTT | |
757 | * disabled. That will cause all of the parser's PPGTT checks to | |
758 | * fail. For now, disable parsing when PPGTT is off. | |
759 | */ | |
760 | if (!dev_priv->mm.aliasing_ppgtt) | |
761 | return false; | |
762 | ||
351e3db2 BV |
763 | return (i915.enable_cmd_parser == 1); |
764 | } | |
765 | ||
b651000b BV |
766 | static bool check_cmd(const struct intel_ring_buffer *ring, |
767 | const struct drm_i915_cmd_descriptor *desc, | |
768 | const u32 *cmd, | |
6e66ea13 BV |
769 | const bool is_master, |
770 | bool *oacontrol_set) | |
b651000b BV |
771 | { |
772 | if (desc->flags & CMD_DESC_REJECT) { | |
773 | DRM_DEBUG_DRIVER("CMD: Rejected command: 0x%08X\n", *cmd); | |
774 | return false; | |
775 | } | |
776 | ||
777 | if ((desc->flags & CMD_DESC_MASTER) && !is_master) { | |
778 | DRM_DEBUG_DRIVER("CMD: Rejected master-only command: 0x%08X\n", | |
779 | *cmd); | |
780 | return false; | |
781 | } | |
782 | ||
783 | if (desc->flags & CMD_DESC_REGISTER) { | |
784 | u32 reg_addr = cmd[desc->reg.offset] & desc->reg.mask; | |
785 | ||
6e66ea13 BV |
786 | /* |
787 | * OACONTROL requires some special handling for writes. We | |
788 | * want to make sure that any batch which enables OA also | |
789 | * disables it before the end of the batch. The goal is to | |
790 | * prevent one process from snooping on the perf data from | |
791 | * another process. To do that, we need to check the value | |
792 | * that will be written to the register. Hence, limit | |
793 | * OACONTROL writes to only MI_LOAD_REGISTER_IMM commands. | |
794 | */ | |
795 | if (reg_addr == OACONTROL) { | |
796 | if (desc->cmd.value == MI_LOAD_REGISTER_MEM) | |
797 | return false; | |
798 | ||
799 | if (desc->cmd.value == MI_LOAD_REGISTER_IMM(1)) | |
800 | *oacontrol_set = (cmd[2] != 0); | |
801 | } | |
802 | ||
b651000b BV |
803 | if (!valid_reg(ring->reg_table, |
804 | ring->reg_count, reg_addr)) { | |
805 | if (!is_master || | |
806 | !valid_reg(ring->master_reg_table, | |
807 | ring->master_reg_count, | |
808 | reg_addr)) { | |
809 | DRM_DEBUG_DRIVER("CMD: Rejected register 0x%08X in command: 0x%08X (ring=%d)\n", | |
810 | reg_addr, | |
811 | *cmd, | |
812 | ring->id); | |
813 | return false; | |
814 | } | |
815 | } | |
816 | } | |
817 | ||
818 | if (desc->flags & CMD_DESC_BITMASK) { | |
819 | int i; | |
820 | ||
821 | for (i = 0; i < MAX_CMD_DESC_BITMASKS; i++) { | |
822 | u32 dword; | |
823 | ||
824 | if (desc->bits[i].mask == 0) | |
825 | break; | |
826 | ||
827 | if (desc->bits[i].condition_mask != 0) { | |
828 | u32 offset = | |
829 | desc->bits[i].condition_offset; | |
830 | u32 condition = cmd[offset] & | |
831 | desc->bits[i].condition_mask; | |
832 | ||
833 | if (condition == 0) | |
834 | continue; | |
835 | } | |
836 | ||
837 | dword = cmd[desc->bits[i].offset] & | |
838 | desc->bits[i].mask; | |
839 | ||
840 | if (dword != desc->bits[i].expected) { | |
841 | DRM_DEBUG_DRIVER("CMD: Rejected command 0x%08X for bitmask 0x%08X (exp=0x%08X act=0x%08X) (ring=%d)\n", | |
842 | *cmd, | |
843 | desc->bits[i].mask, | |
844 | desc->bits[i].expected, | |
845 | dword, ring->id); | |
846 | return false; | |
847 | } | |
848 | } | |
849 | } | |
850 | ||
851 | return true; | |
852 | } | |
853 | ||
351e3db2 BV |
854 | #define LENGTH_BIAS 2 |
855 | ||
856 | /** | |
857 | * i915_parse_cmds() - parse a submitted batch buffer for privilege violations | |
858 | * @ring: the ring on which the batch is to execute | |
859 | * @batch_obj: the batch buffer in question | |
860 | * @batch_start_offset: byte offset in the batch at which execution starts | |
861 | * @is_master: is the submitting process the drm master? | |
862 | * | |
863 | * Parses the specified batch buffer looking for privilege violations as | |
864 | * described in the overview. | |
865 | * | |
866 | * Return: non-zero if the parser finds violations or otherwise fails | |
867 | */ | |
868 | int i915_parse_cmds(struct intel_ring_buffer *ring, | |
869 | struct drm_i915_gem_object *batch_obj, | |
870 | u32 batch_start_offset, | |
871 | bool is_master) | |
872 | { | |
873 | int ret = 0; | |
874 | u32 *cmd, *batch_base, *batch_end; | |
875 | struct drm_i915_cmd_descriptor default_desc = { 0 }; | |
876 | int needs_clflush = 0; | |
6e66ea13 | 877 | bool oacontrol_set = false; /* OACONTROL tracking. See check_cmd() */ |
351e3db2 BV |
878 | |
879 | ret = i915_gem_obj_prepare_shmem_read(batch_obj, &needs_clflush); | |
880 | if (ret) { | |
881 | DRM_DEBUG_DRIVER("CMD: failed to prep read\n"); | |
882 | return ret; | |
883 | } | |
884 | ||
885 | batch_base = vmap_batch(batch_obj); | |
886 | if (!batch_base) { | |
887 | DRM_DEBUG_DRIVER("CMD: Failed to vmap batch\n"); | |
888 | i915_gem_object_unpin_pages(batch_obj); | |
889 | return -ENOMEM; | |
890 | } | |
891 | ||
892 | if (needs_clflush) | |
893 | drm_clflush_virt_range((char *)batch_base, batch_obj->base.size); | |
894 | ||
895 | cmd = batch_base + (batch_start_offset / sizeof(*cmd)); | |
896 | batch_end = cmd + (batch_obj->base.size / sizeof(*batch_end)); | |
897 | ||
898 | while (cmd < batch_end) { | |
899 | const struct drm_i915_cmd_descriptor *desc; | |
900 | u32 length; | |
901 | ||
902 | if (*cmd == MI_BATCH_BUFFER_END) | |
903 | break; | |
904 | ||
905 | desc = find_cmd(ring, *cmd, &default_desc); | |
906 | if (!desc) { | |
907 | DRM_DEBUG_DRIVER("CMD: Unrecognized command: 0x%08X\n", | |
908 | *cmd); | |
909 | ret = -EINVAL; | |
910 | break; | |
911 | } | |
912 | ||
913 | if (desc->flags & CMD_DESC_FIXED) | |
914 | length = desc->length.fixed; | |
915 | else | |
916 | length = ((*cmd & desc->length.mask) + LENGTH_BIAS); | |
917 | ||
918 | if ((batch_end - cmd) < length) { | |
86a25121 | 919 | DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", |
351e3db2 BV |
920 | *cmd, |
921 | length, | |
60f2b4af | 922 | (unsigned long)(batch_end - cmd)); |
351e3db2 BV |
923 | ret = -EINVAL; |
924 | break; | |
925 | } | |
926 | ||
6e66ea13 | 927 | if (!check_cmd(ring, desc, cmd, is_master, &oacontrol_set)) { |
351e3db2 BV |
928 | ret = -EINVAL; |
929 | break; | |
930 | } | |
931 | ||
351e3db2 BV |
932 | cmd += length; |
933 | } | |
934 | ||
6e66ea13 BV |
935 | if (oacontrol_set) { |
936 | DRM_DEBUG_DRIVER("CMD: batch set OACONTROL but did not clear it\n"); | |
937 | ret = -EINVAL; | |
938 | } | |
939 | ||
351e3db2 BV |
940 | if (cmd >= batch_end) { |
941 | DRM_DEBUG_DRIVER("CMD: Got to the end of the buffer w/o a BBE cmd!\n"); | |
942 | ret = -EINVAL; | |
943 | } | |
944 | ||
945 | vunmap(batch_base); | |
946 | ||
947 | i915_gem_object_unpin_pages(batch_obj); | |
948 | ||
949 | return ret; | |
950 | } | |
d728c8ef BV |
951 | |
952 | /** | |
953 | * i915_cmd_parser_get_version() - get the cmd parser version number | |
954 | * | |
955 | * The cmd parser maintains a simple increasing integer version number suitable | |
956 | * for passing to userspace clients to determine what operations are permitted. | |
957 | * | |
958 | * Return: the current version number of the cmd parser | |
959 | */ | |
960 | int i915_cmd_parser_get_version(void) | |
961 | { | |
962 | /* | |
963 | * Command parser version history | |
964 | * | |
965 | * 1. Initial version. Checks batches and reports violations, but leaves | |
966 | * hardware parsing enabled (so does not allow new use cases). | |
967 | */ | |
968 | return 1; | |
969 | } |