Commit | Line | Data |
---|---|---|
79e53945 JB |
1 | /* |
2 | * Copyright 2006 Dave Airlie <airlied@linux.ie> | |
3 | * Copyright © 2006-2007 Intel Corporation | |
4 | * | |
5 | * Permission is hereby granted, free of charge, to any person obtaining a | |
6 | * copy of this software and associated documentation files (the "Software"), | |
7 | * to deal in the Software without restriction, including without limitation | |
8 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, | |
9 | * and/or sell copies of the Software, and to permit persons to whom the | |
10 | * Software is furnished to do so, subject to the following conditions: | |
11 | * | |
12 | * The above copyright notice and this permission notice (including the next | |
13 | * paragraph) shall be included in all copies or substantial portions of the | |
14 | * Software. | |
15 | * | |
16 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | |
17 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | |
18 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | |
19 | * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | |
20 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | |
21 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | |
22 | * DEALINGS IN THE SOFTWARE. | |
23 | * | |
24 | * Authors: | |
25 | * Eric Anholt <eric@anholt.net> | |
26 | */ | |
27 | #include <linux/i2c.h> | |
5a0e3ad6 | 28 | #include <linux/slab.h> |
79e53945 JB |
29 | #include "drmP.h" |
30 | #include "drm.h" | |
31 | #include "drm_crtc.h" | |
32 | #include "intel_drv.h" | |
33 | #include "i915_drm.h" | |
34 | #include "i915_drv.h" | |
35 | #include "dvo.h" | |
36 | ||
37 | #define SIL164_ADDR 0x38 | |
38 | #define CH7xxx_ADDR 0x76 | |
39 | #define TFP410_ADDR 0x38 | |
40 | ||
ea5b213a | 41 | static const struct intel_dvo_device intel_dvo_devices[] = { |
79e53945 JB |
42 | { |
43 | .type = INTEL_DVO_CHIP_TMDS, | |
44 | .name = "sil164", | |
45 | .dvo_reg = DVOC, | |
46 | .slave_addr = SIL164_ADDR, | |
47 | .dev_ops = &sil164_ops, | |
48 | }, | |
49 | { | |
50 | .type = INTEL_DVO_CHIP_TMDS, | |
51 | .name = "ch7xxx", | |
52 | .dvo_reg = DVOC, | |
53 | .slave_addr = CH7xxx_ADDR, | |
54 | .dev_ops = &ch7xxx_ops, | |
55 | }, | |
56 | { | |
57 | .type = INTEL_DVO_CHIP_LVDS, | |
58 | .name = "ivch", | |
59 | .dvo_reg = DVOA, | |
60 | .slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */ | |
61 | .dev_ops = &ivch_ops, | |
62 | }, | |
63 | { | |
64 | .type = INTEL_DVO_CHIP_TMDS, | |
65 | .name = "tfp410", | |
66 | .dvo_reg = DVOC, | |
67 | .slave_addr = TFP410_ADDR, | |
68 | .dev_ops = &tfp410_ops, | |
69 | }, | |
70 | { | |
71 | .type = INTEL_DVO_CHIP_LVDS, | |
72 | .name = "ch7017", | |
73 | .dvo_reg = DVOC, | |
74 | .slave_addr = 0x75, | |
75 | .gpio = GPIOE, | |
76 | .dev_ops = &ch7017_ops, | |
77 | } | |
78 | }; | |
79 | ||
ea5b213a CW |
80 | struct intel_dvo { |
81 | struct intel_encoder base; | |
82 | ||
83 | struct intel_dvo_device dev; | |
84 | ||
85 | struct drm_display_mode *panel_fixed_mode; | |
86 | bool panel_wants_dither; | |
87 | }; | |
88 | ||
89 | static struct intel_dvo *enc_to_intel_dvo(struct drm_encoder *encoder) | |
90 | { | |
91 | return container_of(enc_to_intel_encoder(encoder), struct intel_dvo, base); | |
92 | } | |
93 | ||
79e53945 JB |
94 | static void intel_dvo_dpms(struct drm_encoder *encoder, int mode) |
95 | { | |
96 | struct drm_i915_private *dev_priv = encoder->dev->dev_private; | |
ea5b213a CW |
97 | struct intel_dvo *intel_dvo = enc_to_intel_dvo(encoder); |
98 | u32 dvo_reg = intel_dvo->dev.dvo_reg; | |
79e53945 JB |
99 | u32 temp = I915_READ(dvo_reg); |
100 | ||
101 | if (mode == DRM_MODE_DPMS_ON) { | |
102 | I915_WRITE(dvo_reg, temp | DVO_ENABLE); | |
103 | I915_READ(dvo_reg); | |
ea5b213a | 104 | intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, mode); |
79e53945 | 105 | } else { |
ea5b213a | 106 | intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, mode); |
79e53945 JB |
107 | I915_WRITE(dvo_reg, temp & ~DVO_ENABLE); |
108 | I915_READ(dvo_reg); | |
109 | } | |
110 | } | |
111 | ||
79e53945 JB |
112 | static int intel_dvo_mode_valid(struct drm_connector *connector, |
113 | struct drm_display_mode *mode) | |
114 | { | |
599be16c | 115 | struct drm_encoder *encoder = intel_attached_encoder(connector); |
ea5b213a | 116 | struct intel_dvo *intel_dvo = enc_to_intel_dvo(encoder); |
79e53945 JB |
117 | |
118 | if (mode->flags & DRM_MODE_FLAG_DBLSCAN) | |
119 | return MODE_NO_DBLESCAN; | |
120 | ||
121 | /* XXX: Validate clock range */ | |
122 | ||
ea5b213a CW |
123 | if (intel_dvo->panel_fixed_mode) { |
124 | if (mode->hdisplay > intel_dvo->panel_fixed_mode->hdisplay) | |
79e53945 | 125 | return MODE_PANEL; |
ea5b213a | 126 | if (mode->vdisplay > intel_dvo->panel_fixed_mode->vdisplay) |
79e53945 JB |
127 | return MODE_PANEL; |
128 | } | |
129 | ||
ea5b213a | 130 | return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode); |
79e53945 JB |
131 | } |
132 | ||
133 | static bool intel_dvo_mode_fixup(struct drm_encoder *encoder, | |
134 | struct drm_display_mode *mode, | |
135 | struct drm_display_mode *adjusted_mode) | |
136 | { | |
ea5b213a | 137 | struct intel_dvo *intel_dvo = enc_to_intel_dvo(encoder); |
79e53945 JB |
138 | |
139 | /* If we have timings from the BIOS for the panel, put them in | |
140 | * to the adjusted mode. The CRTC will be set up for this mode, | |
141 | * with the panel scaling set up to source from the H/VDisplay | |
142 | * of the original mode. | |
143 | */ | |
ea5b213a CW |
144 | if (intel_dvo->panel_fixed_mode != NULL) { |
145 | #define C(x) adjusted_mode->x = intel_dvo->panel_fixed_mode->x | |
79e53945 JB |
146 | C(hdisplay); |
147 | C(hsync_start); | |
148 | C(hsync_end); | |
149 | C(htotal); | |
150 | C(vdisplay); | |
151 | C(vsync_start); | |
152 | C(vsync_end); | |
153 | C(vtotal); | |
154 | C(clock); | |
155 | drm_mode_set_crtcinfo(adjusted_mode, CRTC_INTERLACE_HALVE_V); | |
156 | #undef C | |
157 | } | |
158 | ||
ea5b213a CW |
159 | if (intel_dvo->dev.dev_ops->mode_fixup) |
160 | return intel_dvo->dev.dev_ops->mode_fixup(&intel_dvo->dev, mode, adjusted_mode); | |
79e53945 JB |
161 | |
162 | return true; | |
163 | } | |
164 | ||
165 | static void intel_dvo_mode_set(struct drm_encoder *encoder, | |
166 | struct drm_display_mode *mode, | |
167 | struct drm_display_mode *adjusted_mode) | |
168 | { | |
169 | struct drm_device *dev = encoder->dev; | |
170 | struct drm_i915_private *dev_priv = dev->dev_private; | |
171 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc); | |
ea5b213a | 172 | struct intel_dvo *intel_dvo = enc_to_intel_dvo(encoder); |
79e53945 JB |
173 | int pipe = intel_crtc->pipe; |
174 | u32 dvo_val; | |
ea5b213a | 175 | u32 dvo_reg = intel_dvo->dev.dvo_reg, dvo_srcdim_reg; |
79e53945 JB |
176 | int dpll_reg = (pipe == 0) ? DPLL_A : DPLL_B; |
177 | ||
178 | switch (dvo_reg) { | |
179 | case DVOA: | |
180 | default: | |
181 | dvo_srcdim_reg = DVOA_SRCDIM; | |
182 | break; | |
183 | case DVOB: | |
184 | dvo_srcdim_reg = DVOB_SRCDIM; | |
185 | break; | |
186 | case DVOC: | |
187 | dvo_srcdim_reg = DVOC_SRCDIM; | |
188 | break; | |
189 | } | |
190 | ||
ea5b213a | 191 | intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev, mode, adjusted_mode); |
79e53945 JB |
192 | |
193 | /* Save the data order, since I don't know what it should be set to. */ | |
194 | dvo_val = I915_READ(dvo_reg) & | |
195 | (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG); | |
196 | dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE | | |
197 | DVO_BLANK_ACTIVE_HIGH; | |
198 | ||
199 | if (pipe == 1) | |
200 | dvo_val |= DVO_PIPE_B_SELECT; | |
201 | dvo_val |= DVO_PIPE_STALL; | |
202 | if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) | |
203 | dvo_val |= DVO_HSYNC_ACTIVE_HIGH; | |
204 | if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC) | |
205 | dvo_val |= DVO_VSYNC_ACTIVE_HIGH; | |
206 | ||
207 | I915_WRITE(dpll_reg, I915_READ(dpll_reg) | DPLL_DVO_HIGH_SPEED); | |
208 | ||
209 | /*I915_WRITE(DVOB_SRCDIM, | |
210 | (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) | | |
211 | (adjusted_mode->VDisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/ | |
212 | I915_WRITE(dvo_srcdim_reg, | |
213 | (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) | | |
214 | (adjusted_mode->vdisplay << DVO_SRCDIM_VERTICAL_SHIFT)); | |
215 | /*I915_WRITE(DVOB, dvo_val);*/ | |
216 | I915_WRITE(dvo_reg, dvo_val); | |
217 | } | |
218 | ||
219 | /** | |
220 | * Detect the output connection on our DVO device. | |
221 | * | |
222 | * Unimplemented. | |
223 | */ | |
7b334fcb CW |
224 | static enum drm_connector_status |
225 | intel_dvo_detect(struct drm_connector *connector, | |
226 | bool nondestructive) | |
79e53945 | 227 | { |
599be16c | 228 | struct drm_encoder *encoder = intel_attached_encoder(connector); |
ea5b213a | 229 | struct intel_dvo *intel_dvo = enc_to_intel_dvo(encoder); |
79e53945 | 230 | |
ea5b213a | 231 | return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev); |
79e53945 JB |
232 | } |
233 | ||
234 | static int intel_dvo_get_modes(struct drm_connector *connector) | |
235 | { | |
599be16c | 236 | struct drm_encoder *encoder = intel_attached_encoder(connector); |
ea5b213a | 237 | struct intel_dvo *intel_dvo = enc_to_intel_dvo(encoder); |
79e53945 JB |
238 | |
239 | /* We should probably have an i2c driver get_modes function for those | |
240 | * devices which will have a fixed set of modes determined by the chip | |
241 | * (TV-out, for example), but for now with just TMDS and LVDS, | |
242 | * that's not the case. | |
243 | */ | |
ea5b213a | 244 | intel_ddc_get_modes(connector, intel_dvo->base.ddc_bus); |
79e53945 JB |
245 | if (!list_empty(&connector->probed_modes)) |
246 | return 1; | |
247 | ||
ea5b213a | 248 | if (intel_dvo->panel_fixed_mode != NULL) { |
79e53945 | 249 | struct drm_display_mode *mode; |
ea5b213a | 250 | mode = drm_mode_duplicate(connector->dev, intel_dvo->panel_fixed_mode); |
79e53945 JB |
251 | if (mode) { |
252 | drm_mode_probed_add(connector, mode); | |
253 | return 1; | |
254 | } | |
255 | } | |
ea5b213a | 256 | |
79e53945 JB |
257 | return 0; |
258 | } | |
259 | ||
ea5b213a | 260 | static void intel_dvo_destroy(struct drm_connector *connector) |
79e53945 | 261 | { |
79e53945 JB |
262 | drm_sysfs_connector_remove(connector); |
263 | drm_connector_cleanup(connector); | |
599be16c | 264 | kfree(connector); |
79e53945 | 265 | } |
79e53945 JB |
266 | |
267 | static const struct drm_encoder_helper_funcs intel_dvo_helper_funcs = { | |
268 | .dpms = intel_dvo_dpms, | |
269 | .mode_fixup = intel_dvo_mode_fixup, | |
270 | .prepare = intel_encoder_prepare, | |
271 | .mode_set = intel_dvo_mode_set, | |
272 | .commit = intel_encoder_commit, | |
273 | }; | |
274 | ||
275 | static const struct drm_connector_funcs intel_dvo_connector_funcs = { | |
c9fb15f6 | 276 | .dpms = drm_helper_connector_dpms, |
79e53945 JB |
277 | .detect = intel_dvo_detect, |
278 | .destroy = intel_dvo_destroy, | |
279 | .fill_modes = drm_helper_probe_single_connector_modes, | |
280 | }; | |
281 | ||
282 | static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = { | |
283 | .mode_valid = intel_dvo_mode_valid, | |
284 | .get_modes = intel_dvo_get_modes, | |
599be16c | 285 | .best_encoder = intel_attached_encoder, |
79e53945 JB |
286 | }; |
287 | ||
b358d0a6 | 288 | static void intel_dvo_enc_destroy(struct drm_encoder *encoder) |
79e53945 | 289 | { |
ea5b213a CW |
290 | struct intel_dvo *intel_dvo = enc_to_intel_dvo(encoder); |
291 | ||
292 | if (intel_dvo->dev.dev_ops->destroy) | |
293 | intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev); | |
294 | ||
295 | kfree(intel_dvo->panel_fixed_mode); | |
296 | ||
297 | intel_encoder_destroy(encoder); | |
79e53945 JB |
298 | } |
299 | ||
300 | static const struct drm_encoder_funcs intel_dvo_enc_funcs = { | |
301 | .destroy = intel_dvo_enc_destroy, | |
302 | }; | |
303 | ||
79e53945 JB |
304 | /** |
305 | * Attempts to get a fixed panel timing for LVDS (currently only the i830). | |
306 | * | |
307 | * Other chips with DVO LVDS will need to extend this to deal with the LVDS | |
308 | * chip being on DVOB/C and having multiple pipes. | |
309 | */ | |
310 | static struct drm_display_mode * | |
ea5b213a | 311 | intel_dvo_get_current_mode(struct drm_connector *connector) |
79e53945 JB |
312 | { |
313 | struct drm_device *dev = connector->dev; | |
314 | struct drm_i915_private *dev_priv = dev->dev_private; | |
599be16c | 315 | struct drm_encoder *encoder = intel_attached_encoder(connector); |
ea5b213a CW |
316 | struct intel_dvo *intel_dvo = enc_to_intel_dvo(encoder); |
317 | uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg); | |
79e53945 JB |
318 | struct drm_display_mode *mode = NULL; |
319 | ||
320 | /* If the DVO port is active, that'll be the LVDS, so we can pull out | |
321 | * its timings to get how the BIOS set up the panel. | |
322 | */ | |
323 | if (dvo_val & DVO_ENABLE) { | |
324 | struct drm_crtc *crtc; | |
325 | int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0; | |
326 | ||
327 | crtc = intel_get_crtc_from_pipe(dev, pipe); | |
328 | if (crtc) { | |
329 | mode = intel_crtc_mode_get(dev, crtc); | |
79e53945 JB |
330 | if (mode) { |
331 | mode->type |= DRM_MODE_TYPE_PREFERRED; | |
332 | if (dvo_val & DVO_HSYNC_ACTIVE_HIGH) | |
333 | mode->flags |= DRM_MODE_FLAG_PHSYNC; | |
334 | if (dvo_val & DVO_VSYNC_ACTIVE_HIGH) | |
335 | mode->flags |= DRM_MODE_FLAG_PVSYNC; | |
336 | } | |
337 | } | |
338 | } | |
ea5b213a | 339 | |
79e53945 JB |
340 | return mode; |
341 | } | |
342 | ||
343 | void intel_dvo_init(struct drm_device *dev) | |
344 | { | |
21d40d37 | 345 | struct intel_encoder *intel_encoder; |
ea5b213a | 346 | struct intel_dvo *intel_dvo; |
599be16c | 347 | struct intel_connector *intel_connector; |
f9c10a9b | 348 | struct i2c_adapter *i2cbus = NULL; |
79e53945 JB |
349 | int ret = 0; |
350 | int i; | |
79e53945 | 351 | int encoder_type = DRM_MODE_ENCODER_NONE; |
ea5b213a CW |
352 | |
353 | intel_dvo = kzalloc(sizeof(struct intel_dvo), GFP_KERNEL); | |
354 | if (!intel_dvo) | |
79e53945 JB |
355 | return; |
356 | ||
599be16c ZW |
357 | intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL); |
358 | if (!intel_connector) { | |
ea5b213a | 359 | kfree(intel_dvo); |
599be16c ZW |
360 | return; |
361 | } | |
362 | ||
ea5b213a CW |
363 | intel_encoder = &intel_dvo->base; |
364 | ||
79e53945 | 365 | /* Set up the DDC bus */ |
21d40d37 EA |
366 | intel_encoder->ddc_bus = intel_i2c_create(dev, GPIOD, "DVODDC_D"); |
367 | if (!intel_encoder->ddc_bus) | |
79e53945 JB |
368 | goto free_intel; |
369 | ||
370 | /* Now, try to find a controller */ | |
371 | for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) { | |
599be16c | 372 | struct drm_connector *connector = &intel_connector->base; |
ea5b213a | 373 | const struct intel_dvo_device *dvo = &intel_dvo_devices[i]; |
79e53945 JB |
374 | int gpio; |
375 | ||
79e53945 JB |
376 | /* Allow the I2C driver info to specify the GPIO to be used in |
377 | * special cases, but otherwise default to what's defined | |
378 | * in the spec. | |
379 | */ | |
380 | if (dvo->gpio != 0) | |
381 | gpio = dvo->gpio; | |
382 | else if (dvo->type == INTEL_DVO_CHIP_LVDS) | |
383 | gpio = GPIOB; | |
384 | else | |
385 | gpio = GPIOE; | |
386 | ||
387 | /* Set up the I2C bus necessary for the chip we're probing. | |
388 | * It appears that everything is on GPIOE except for panels | |
389 | * on i830 laptops, which are on GPIOB (DVOA). | |
390 | */ | |
f9c10a9b KP |
391 | if (i2cbus != NULL) |
392 | intel_i2c_destroy(i2cbus); | |
393 | if (!(i2cbus = intel_i2c_create(dev, gpio, | |
394 | gpio == GPIOB ? "DVOI2C_B" : "DVOI2C_E"))) { | |
395 | continue; | |
79e53945 JB |
396 | } |
397 | ||
ea5b213a CW |
398 | intel_dvo->dev = *dvo; |
399 | ret = dvo->dev_ops->init(&intel_dvo->dev, i2cbus); | |
79e53945 JB |
400 | if (!ret) |
401 | continue; | |
402 | ||
21d40d37 EA |
403 | intel_encoder->type = INTEL_OUTPUT_DVO; |
404 | intel_encoder->crtc_mask = (1 << 0) | (1 << 1); | |
79e53945 JB |
405 | switch (dvo->type) { |
406 | case INTEL_DVO_CHIP_TMDS: | |
21d40d37 | 407 | intel_encoder->clone_mask = |
f8aed700 ML |
408 | (1 << INTEL_DVO_TMDS_CLONE_BIT) | |
409 | (1 << INTEL_ANALOG_CLONE_BIT); | |
79e53945 JB |
410 | drm_connector_init(dev, connector, |
411 | &intel_dvo_connector_funcs, | |
412 | DRM_MODE_CONNECTOR_DVII); | |
413 | encoder_type = DRM_MODE_ENCODER_TMDS; | |
414 | break; | |
415 | case INTEL_DVO_CHIP_LVDS: | |
21d40d37 | 416 | intel_encoder->clone_mask = |
f8aed700 | 417 | (1 << INTEL_DVO_LVDS_CLONE_BIT); |
79e53945 JB |
418 | drm_connector_init(dev, connector, |
419 | &intel_dvo_connector_funcs, | |
420 | DRM_MODE_CONNECTOR_LVDS); | |
421 | encoder_type = DRM_MODE_ENCODER_LVDS; | |
422 | break; | |
423 | } | |
424 | ||
425 | drm_connector_helper_add(connector, | |
426 | &intel_dvo_connector_helper_funcs); | |
427 | connector->display_info.subpixel_order = SubPixelHorizontalRGB; | |
428 | connector->interlace_allowed = false; | |
429 | connector->doublescan_allowed = false; | |
430 | ||
21d40d37 | 431 | drm_encoder_init(dev, &intel_encoder->enc, |
79e53945 | 432 | &intel_dvo_enc_funcs, encoder_type); |
21d40d37 | 433 | drm_encoder_helper_add(&intel_encoder->enc, |
79e53945 JB |
434 | &intel_dvo_helper_funcs); |
435 | ||
599be16c | 436 | drm_mode_connector_attach_encoder(&intel_connector->base, |
21d40d37 | 437 | &intel_encoder->enc); |
79e53945 JB |
438 | if (dvo->type == INTEL_DVO_CHIP_LVDS) { |
439 | /* For our LVDS chipsets, we should hopefully be able | |
440 | * to dig the fixed panel mode out of the BIOS data. | |
441 | * However, it's in a different format from the BIOS | |
442 | * data on chipsets with integrated LVDS (stored in AIM | |
443 | * headers, likely), so for now, just get the current | |
444 | * mode being output through DVO. | |
445 | */ | |
ea5b213a | 446 | intel_dvo->panel_fixed_mode = |
79e53945 | 447 | intel_dvo_get_current_mode(connector); |
ea5b213a | 448 | intel_dvo->panel_wants_dither = true; |
79e53945 JB |
449 | } |
450 | ||
451 | drm_sysfs_connector_add(connector); | |
452 | return; | |
453 | } | |
454 | ||
21d40d37 | 455 | intel_i2c_destroy(intel_encoder->ddc_bus); |
79e53945 JB |
456 | /* Didn't find a chip, so tear down. */ |
457 | if (i2cbus != NULL) | |
458 | intel_i2c_destroy(i2cbus); | |
459 | free_intel: | |
ea5b213a | 460 | kfree(intel_dvo); |
599be16c | 461 | kfree(intel_connector); |
79e53945 | 462 | } |