projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
LOAD in linker map file
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
7a289707
RO		 12019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2
3 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4 prstatus.pr_lwp.pr_info instead of making it up.
5
f2aec7f6
CB		 62019-09-11 Christian Biesinger <cbiesinger@google.com>
7
8 * auto-load.c (auto_load_expand_dir_vars): Update.
9 * defs.h (gdb_datadir): Change to std::string.
10 (python_libdir): Likewise.
11 (relocate_gdb_directory): Change return type to std::string.
12 * guile/guile.c (gdbscm_data_directory): Update.
13 (initialize_scheme_side): Update.
14 * jit.c (jit_reader_dir): Change to std::string.
15 (jit_reader_load_command): Update.
16 * main.c (gdb_datadir): Change to std::string.
17 (python_libdir): Likewise.
18 (set_gdb_data_directory): Update.
19 (relocate_path): Change to return std::string.
20 (relocate_gdb_directory): Change to return std::string.
21 (relocate_gdbinit_path_maybe_in_datadir): Update.
22 (captured_main_1): Update.
23 * python/python.c (do_start_initialization): Update.
24 * top.c (show_gdb_datadir): Update.
25 * xml-syscall.c (xml_init_syscalls_info): Update.
26 (init_syscalls_info): Update.
27
9224a013
CB		 282019-09-11 Christian Biesinger <cbiesinger@google.com>
29
30 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
31 out of get_init_files.
32 (get_init_files): Update.
33
f48cd836
CB		 342019-09-11 Christian Biesinger <cbiesinger@google.com>
35
36 * main.c (get_init_files): Change to use std::string.
37 (captured_main_1): Update.
38 (print_gdb_help): Update.
39
9cab7ecd
AT		 402019-09-11 Ali Tamur <tamur@google.com>
41
42 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
43 implementation.
44
67547d89
CB		 452019-09-11 Christian Biesinger <cbiesinger@google.com>
46
47 * dbxread.c (read_dbx_symtab): Update.
48 * dwarf2read.c (load_partial_dies): Update.
49 * mdebugread.c (parse_partial_symbols): Update.
50 (handle_psymbol_enumerators): Update.
51 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
52 * psymtab.c (add_psymbol_to_bcache): Likewise.
53 (add_psymbol_to_list): Likewise.
54 * symtab.c (symbol_set_names): Likewise.
55 * symtab.h (symbol_set_names): Likewise.
56 * xcoffread.c (scan_xcoff_symtab): Update.
57
64b2d4a0
TT		 582019-09-11 Tom Tromey <tom@tromey.com>
59
60 * symfile-mem.c (symbol_file_add_from_memory): Use
61 bfd_set_filename.
62 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
63 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
64
3b00ef10
TT		 652019-09-10 Tom Tromey <tromey@adacore.com>
66
67 * dwarf-index-write.c (write_psymbols): Extend error message.
68 (debug_names::insert): Add Ada code.
69 (debug_names::write_psymbols): Remove Ada check.
70 (debug_names) <m_string_obstack>: New member.
71 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
72 (gdb_index_symbol_name_matcher::matches): Remove.
73 (mapped_index_base::find_name_components_bounds): Add "lang"
74 parameter.
75 (mapped_index_base::build_name_components): Also split names
76 according to Ada syntax.
77 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
78 type of "match_callback".
79 (check_match, check_find_bounds_finds)
80 (dw2_expand_symtabs_matching): Update.
81 (dw2_debug_names_iterator): Add new constructor.
82 (dw2_debug_names_map_matching_symbols): New function.
83 (dw2_debug_names_expand_symtabs_matching): Update.
84 (dwarf2_debug_names_functions): Use
85 dw2_debug_names_map_matching_symbols.
86
aa391654
TT		 872019-09-10 Tom Tromey <tromey@adacore.com>
88
89 * dwarf2read.c (dw2_get_file_names_reader): Add the
90 CU's file name to the results.
91
b054970d
TT		 922019-09-10 Tom Tromey <tromey@adacore.com>
93
94 * ada-lang.c (add_nonlocal_symbols): Combine calls to
95 map_matching_symbols. Update.
96 * dwarf2read.c (dw2_map_matching_symbols): Update.
97 * psymtab.c (match_partial_symbol): Change type; update.
98 (psym_map_matching_symbols): Likewise.
99 * symfile-debug.c (debug_qf_map_matching_symbols): Change
100 type; update.
101 * symfile.h (struct quick_symbol_functions)
102 <map_matching_symbols>: Change "name" to be a lookup_name_info.
103 Remove "match".
104
6a3dbf1b
TT		 1052019-09-10 Tom Tromey <tromey@adacore.com>
106
107 * psymtab.c (map_block): Remove.
108 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
109 * symtab.c (iterate_over_symbols_terminated): New function.
110 * symtab.c (iterate_over_symbols_terminated): Declare.
111
6969f124
TT		 1122019-09-10 Tom Tromey <tromey@adacore.com>
113
114 * ada-lang.c (ada_iterate_over_symbols): Return bool.
115 * language.h (struct language_defn) <la_iterate_over_symbols>:
116 Return bool.
117 * symtab.c (iterate_over_symbols): Return bool.
118 * symtab.h (iterate_over_symbols): Return bool.
119
199b4314
TT		 1202019-09-10 Tom Tromey <tromey@adacore.com>
121
122 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
123 (add_nonlocal_symbols): Update.
124 * dwarf2read.c (dw2_map_matching_symbols): Change type.
125 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
126 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
127 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
128 Change type of "callback". Remove "data".
129
a084a2a6
AT		 130
1312019-09-09 Ali Tamur <tamur@google.com>
132
133 * dwarf2read.c (comp_unit_head): Update comment.
134 (dwarf2_dwo_name): New function declaration.
135 (dwarf_unit_type_name): New function declaration.
136 (read_comp_unit_head): Add support for new compilation units,
137 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
138 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
139 (currently named as "signature") in their header. Also clarify error
140 messages.
141 (lookup_dwo_id): New function. Returns the dwo id of the given
142 compile unit.
143 (lookup_dwo_unit): Use the new lookup_dwo_id function.
144 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
145 functions.
146 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
147 (dwarf2_dwo_name): Get the dwo name if present.
148 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
149 purposes.
150
25a2915e
TT		 1512019-09-09 Tom Tromey <tom@tromey.com>
152
153 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
154
e4df0874
PW		 1552019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
156
157 * python/python.c (do_start_initialization): Make progname_copy static,
158 to avoid a leak report.
159
8634b462
TT		 1602019-09-08 Tom Tromey <tom@tromey.com>
161
162 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
163
c7f839cb
SM		 1642019-09-07 Simon Marchi <simon.marchi@efficios.com>
165
166 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
167 Change type to gdb::optional<block_enum>.
168 (dw2_symtab_iter_init): Change block_index parameter type
169 to gdb::optional<block_enum>.
170 (dw2_lookup_symbol): Change block_index parameter
171 type to block_enum.c
172 (dw2_debug_names_lookup_symbol): Likewise.
173 * psymtab.c (psym_lookup_symbol): Likewise.
174 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
175 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
176 Likewise.
177
ead0e69a
CB		 1782019-09-06 Christian Biesinger <cbiesinger@google.com>
179
180 * defs.h (relocate_gdb_directory): Change int to bool in
181 signature and rename flag to relocatable.
182 * main.c (relocate_path): Likewise.
183 (relocate_gdb_directory): Likewise.
184
b16c44de
AM		 1852019-09-06 Alan Modra <amodra@gmail.com>
186
187 * coffread.c (coff_symfile_read): Constify filename variable.
188 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
189 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
190 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
191 * solib.c (reload_shared_libraries_1): Likewise.
192 * symfile.c (reread_symbols): Likewise.
193 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
194 * solib-darwin.c (darwin_bfd_open): Likewise.
195 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
196
06ff036e
AB		 1972019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
198
199 * psymtab.c (print_partial_symbols): Handle missing domain_enum
200 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
201
4e962e74
TT		 2022019-09-03 Tom Tromey <tromey@adacore.com>
203
204 * ada-valprint.c (ada_val_print_num): Don't recurse for range
205 types.
206 (has_negatives): Unbias a range type bound.
207 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
208 * gdbtypes.c (operator==): Handle new field.
209 (create_range_type): Add "bias" parameter.
210 (create_static_range_type, resolve_dynamic_range): Update.
211 * gdbtypes.h (struct range_bounds) <bias>: New member.
212 (create_range_type): Add bias parameter.
213 * printcmd.c (print_scalar_formatted): Unbias range types.
214 * value.c (unpack_long): Unbias range types.
215 (pack_long): Bias range types.
216
d90b8f26
AH		 2172019-09-02 Alan Hayward <alan.hayward@arm.com>
218
219 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
220 probe arguments.
221
fe01123e
AH		 2222019-09-02 Alan Hayward <alan.hayward@arm.com>
223
224 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
225 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
226 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
227 (compile_probe_arg): Likewise.
228 * probe.h (get_argument_count): Likewise.
229 * solib-svr4.c (solib_event_probe_action): Likewise.
230 * stap-probe.c (stap_probe::get_argument_count): Likewise.
231
e661ef01
AH		 2322019-09-02 Alan Hayward <alan.hayward@arm.com>
233
234 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
235 code to here...
236 (svr4_create_solib_event_breakpoints): ...from here.
237
47a536d9
SDJ		 2382019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
239
240 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
241 suffix from warning message.
242
d6a00eba
TT		 2432019-08-30 Tom Tromey <tom@tromey.com>
244
245 * tui/tui-winsource.h (struct tui_source_window_base)
246 <refresh_all>: Don't declare.
247 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
248 Remove.
249 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
250 tui_show_locator_content.
251 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
252 declare.
253 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
254 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
255 declare.
256
55b2657b
TT		 2572019-08-30 Tom Tromey <tom@tromey.com>
258
259 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
260
12a8555a
TT		 2612019-08-30 Tom Tromey <tom@tromey.com>
262
263 * tui/tui-stack.c (_initialize_tui_stack): Move later.
264 Remove unnecessary forward declarations.
265
900ac242
TT		 2662019-08-30 Tom Tromey <tom@tromey.com>
267
268 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
269 rerender.
270 (tui_update_locator_fullname, tui_show_frame_info): Don't call
271 tui_show_locator_content.
272
99ab33fb
TT		 2732019-08-30 Tom Tromey <tom@tromey.com>
274
275 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
276 (tui_locator_window::rerender): Rewrite using body of previous
277 tui_show_locator_content.
278
e594a5d1
TT		 2792019-08-30 Tom Tromey <tom@tromey.com>
280
281 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
282 set_locator_fullname>: New methods.
283 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
284 Rename from tui_set_locator_fullname.
285 (tui_locator_window::set_locator_info): Rename from
286 tui_set_locator_info. Return bool.
287 (tui_update_locator_fullname, tui_show_frame_info): Update.
288
715bb467
TT		 2892019-08-30 Tom Tromey <tom@tromey.com>
290
291 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
292
772f3f03
TT		 2932019-08-30 Tom Tromey <tom@tromey.com>
294
295 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
296 call touchwin.
297
108e13ab
TT		 2982019-08-30 Tom Tromey <tom@tromey.com>
299
300 * tui/tui-wingeneral.c (box_win): Assume win_info and
301 win_info->handle cannot be NULL.
302
cdaa6eb4
TT		 3032019-08-30 Tom Tromey <tom@tromey.com>
304
305 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
306 refresh_window>: Declare.
307 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
308 resize.
309 (tui_data_item_window::rerender): Rename from
310 tui_display_register.
311 (tui_data_item_window::refresh_window): New method.
312 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
313 no-op.
314
89df7f90
TT		 3152019-08-30 Tom Tromey <tom@tromey.com>
316
317 * tui/tui-regs.h (struct tui_data_window) <regs_content,
318 regs_column_count, current_group>: Move later. Now private.
319 <get_current_group>: New method.
320 * tui/tui-regs.c (tui_reg_command): Update.
321 * tui/tui-layout.c (tui_set_layout): Update.
322
1bf2866a
TT		 3232019-08-30 Tom Tromey <tom@tromey.com>
324
325 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
326 (tui_data_window::rerender): Don't call
327 check_and_display_highlight_if_needed.
328 (tui_data_window::refresh_all): Remove call to
329 erase_data_content.
330
0670413d
TT		 3312019-08-30 Tom Tromey <tom@tromey.com>
332
333 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
334 (tui_data_window::display_registers_from)
335 (tui_data_window::display_reg_element_at_line)
336 (tui_data_window::display_registers_from_line): Remove checks of
337 "empty".
338
18bb55c7
TT		 3392019-08-30 Tom Tromey <tom@tromey.com>
340
341 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
342 Don't declare.
343 * tui/tui-regs.c (tui_data_window::show_registers): Call
344 rerender.
345 (tui_data_window::rerender): Rename from display_all_data.
346 (tui_data_window::rerender): Remove old implementation.
347
1f6d2f10
TT		 3482019-08-30 Tom Tromey <tom@tromey.com>
349
350 * tui/tui-regs.c (tui_data_window::display_all_data): Change
351 text.
352 * tui/tui-data.h (NO_DATA_STRING): Remove define.
353
16d01f9c
BW		 3542019-08-29 Bernhard Wodok <barto@gmx.net>
355 Sergio Durigan Junior <sergiodj@redhat.com>
356
357 PR win32/24284
358 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
359
d8f27c60
AB		 3602019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
361
362 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
363 when searching for types.
364
1f20c35e
AB		 3652019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
366
367 * f-lang.c (f_language_defn): Use f_print_typedef.
368 * f-lang.h (f_print_typedef): Declare.
369 * f-typeprint.c (f_print_typedef): Define.
370
550105b7
CB		 3712019-08-27 Christian Biesinger <cbiesinger@google.com>
372
373 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
374
4acfdd20
AB		 3752019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
376
377 * cli/cli-utils.c (info_print_options_defs): Delete.
378 (make_info_print_options_def_group): Delete.
379 (extract_info_print_options): Delete.
380 (info_print_command_completer): Delete.
381 (info_print_args_help): Add extra parameter, and optionally
382 include text about -n flag.
383 * cli/cli-utils.h (struct info_print_options): Delete.
384 (extract_info_print_options): Delete declaration.
385 (info_print_command_completer): Delete declaration.
386 (info_print_args_help): Add extra parameter, extend header
387 comment.
388 * python/python.c (gdbpy_rbreak): Pass additional parameter to
389 search_symbols.
390 * stack.c (struct info_print_options): New type.
391 (info_print_options_defs): New file scoped variable.
392 (make_info_print_options_def_group): New static function.
393 (info_print_command_completer): New static function.
394 (info_locals_command): Update to use new local functions.
395 (info_args_command): Likewise.
396 (_initialize_stack): Add extra parameter to calls to
397 info_print_args_help.
398 * symtab.c (search_symbols): Add extra parameter, use this to
399 possibly excluse non-debug symbols.
400 (symtab_symbol_info): Add extra parameter, which is passed on to
401 search_symbols.
402 (struct info_print_options): New type.
403 (info_print_options_defs): New file scoped variable.
404 (make_info_print_options_def_group): New static function.
405 (info_print_command_completer): New static function.
406 (info_variables_command): Update to use local functions, and pass
407 extra parameter through to symtab_symbol_info.
408 (info_functions_command): Likewise.
409 (info_types_command): Pass additional argument through to
410 symtab_symbol_info.
411 (rbreak_command): Pass extra argument to search_symbols.
412 (_initialize_symtab): Add extra arguments for calls to
413 info_print_args_help, and update help text for 'info variables',
414 'whereis', and 'info functions' commands.
415 * symtab.h (search_symbols): Add extra argument to declaration.
416 * NEWS: Mention new flags.
417
9aa55206
CB		 4182019-08-26 Christian Biesinger <cbiesinger@google.com>
419
420 * symtab.c (lookup_static_symbol): Call the new function (and move
421 it down to be next to lookup_global_symbol).
422 (struct global_sym_lookup_data): Add block_enum member and rename to...
423 (struct global_or_static_sym_lookup_data): ...this.
424 (lookup_symbol_global_iterator_cb): Pass block_index instead of
425 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
426 (lookup_symbol_global_or_static_iterator_cb): ...this.
427 (lookup_global_or_static_symbol): New function.
428 (lookup_global_symbol): Call new function.
429
5c31b358
TV		 4302019-08-26 Tom de Vries <tdevries@suse.de>
431
432 PR c++/24852
433 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
434 when pc_probe.prob == NULL.
435
23c13d42
SM		 4362019-08-25 Simon Marchi <simon.marchi@efficios.com>
437
438 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
439 variable symbol_linkage to symbol_linkage_.
440
beadd3e8
SM		 4412019-08-25 Simon Marchi <simon.marchi@efficios.com>
442
443 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
444 represent whether the symbol is static, dynamic, or we don't
445 know.
446
e3ec872f
YS		 4472019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
448
449 * gdb/rx-tdep.c (rx_register_names): New.
450 (rx_register_name): Delete.
451 (rx_psw_type): Delete.
452 (rx_fpsw_type): Delete.
453 (rx_register_type): Delete.
454 (rx_gdbarch_init): Convert target-descriptions.
455 (_initialize_rx_tdep): Add initialize_tdesc_rx.
456 * gdb/features/Makefile: Add rx.xml.
457 * gdb/features/rx.xml: New.
458 * gdb/features/rx.c: Generated.
459 * gdb/NEWS: Mention target description support.
460
d0509ba4
CB		 4612019-08-22 Christian Biesinger <cbiesinger@google.com>
462
463 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
464 *slot_ptr.
465
2d41fa11
SDJ		 4662019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
467
468 * configure.ac: Don't check for 'dlfcn.h' (moved to
469 gdbsupport/common.m4).
470 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
471 'gdbsupport/'.
472 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
473 * compile/compile-c-support.c: Include
474 'gdbsupport/gdb-dlfcn.h'.
475 * gdbsupport/common.m4: Check for 'dlfcn.h'.
476 * gdb-dlfcn.c: Move to...
477 * gdbsupport/gdb-dlfcn.c: ... here.
478 * gdb-dlfcn.h: Move to...
479 * gdbsupport/gdb-dlfcn.h: ... here.
480
de8af808
SL		 4812019-08-23 Sandra Loosemore <sandra@codesourcery.com>
482
483 * nios2-tdep.c (struct reg_value): Improve comments. Make
484 the offset field signed.
485
27204489
CB		 4862019-08-22 Christian Biesinger <cbiesinger@google.com>
487
488 * python/lib/gdb/__init__.py (_execute_file): New function.
489 * python/python.c (python_run_simple_file): Call gdb._execute_file
490 on Windows.
491
43771869
AB		 4922019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
493
494 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
495 all uses as this was never set to anything but a zero value.
496
26c957f1
PA		 4972019-08-21 Bogdan Harjoc <harjoc@gmail.com>
498
499 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
500
c07aae6e
CB		 5012019-08-21 Christian Biesinger <cbiesinger@google.com>
502
503 * tui/tui-data.h (tui_gen_win_info): Add an =default
504 move constructor, required by some GCC versions.
505
3960cb7a
JF		 5062019-08-21 Jinke Fan <fanjinke51@yeah.net>
507
508 * go32-nat.c (go32_sysinfo): Add hygon_p.
509
04c72a68
TT		 5102019-08-20 Tom Tromey <tom@tromey.com>
511
512 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
513 line_from_reg_element_no, first_reg_element_no_inline,
514 display_all_data, delete_data_content_windows,
515 erase_data_content>: Now private.
516
072272ce
TT		 5172019-08-20 Tom Tromey <tom@tromey.com>
518
519 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
520 (tui_unhighlight_win, tui_highlight_win)
521 (tui_win_info::make_window): Update.
522 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
523
973961bd
TT		 5242019-08-20 Tom Tromey <tom@tromey.com>
525
526 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
527 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
528 (MAX_PID_WIDTH): Move to tui-stack.c.
529 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
530 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
531 (MAX_PID_WIDTH): Move from tui-data.h.
532
ab0e1f1a
TT		 5332019-08-20 Tom Tromey <tom@tromey.com>
534
535 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
536 * tui/tui-wingeneral.c (box_win): Change type of win_info.
537 (box_win): Update.
538 (tui_gen_win_info::make_window): Rename from tui_make_window.
539 (tui_win_info::make_window): New method.
540 (tui_gen_win_info::make_visible): Update.
541 * tui/tui-source.c (tui_source_window::set_contents): Update.
542 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
543 (tui_data_window::display_registers_from): Update.
544 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
545 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
546 Declare.
547 <can_box>: Remove.
548 <title>: Remove.
549 (struct tui_win_info) <make_window>: Declare.
550 <can_box>: Now virtual.
551 <title>: New member.
552 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
553 * tui/tui-command.c (tui_cmd_window::resize): Update.
554
100c2bf3
TT		 5552019-08-20 Tom Tromey <tom@tromey.com>
556
557 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
558 * tui/tui-regs.c (tui_data_window::show_registers): Update.
559 (tui_data_window::check_register_values): Update.
560
fa4dc567
TT		 5612019-08-20 Tom Tromey <tom@tromey.com>
562
563 * tui/tui-regs.h (struct tui_data_window): Use
564 DISABLE_COPY_AND_ASSIGN.
565 <regs_content>: Change type, removing unique_ptr.
566 <tui_data_window>: Add move constructor.
567 * tui/tui-regs.c (tui_data_window::show_registers)
568 (tui_data_window::show_register_group)
569 (tui_data_window::display_registers_from)
570 (tui_data_window::display_registers_from)
571 (tui_data_window::first_data_item_displayed)
572 (tui_data_window::delete_data_content_windows)
573 (tui_data_window::rerender, tui_data_window::refresh_window)
574 (tui_data_window::check_register_values): Update.
575
ca02d7c8
TT		 5762019-08-20 Tom Tromey <tom@tromey.com>
577
578 * tui/tui-regs.h (struct tui_data_window) <show_registers,
579 show_register_group>: Declare.
580 (tui_show_register_group): Don't declare.
581 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
582 tui_show_registers.
583 (tui_data_window::show_register_group): Rename from
584 tui_show_register_group.
585 (tui_data_window::check_register_values, tui_reg_command):
586 Update.
587 * tui/tui-layout.c (tui_set_layout): Update.
588
63356bfd
TT		 5892019-08-20 Tom Tromey <tom@tromey.com>
590
591 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
592 Declare.
593 (tui_check_register_values): Don't declare.
594 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
595 from tui_check_register_values.
596 * tui/tui-hooks.c (tui_register_changed): Update.
597
42cc14a7
TT		 5982019-08-20 Tom Tromey <tom@tromey.com>
599
600 * tui/tui-regs.c (tui_reg_layout): Move later.
601 (tui_show_registers): Don't enable TUI mode or change layout.
602
b9ad3686
TT		 6032019-08-20 Tom Tromey <tom@tromey.com>
604
605 * tui/tui-regs.h (struct tui_data_item_window)
606 <~tui_data_item_window>: Remove.
607 <content>: Now a unique_xmalloc_ptr.
608 * tui/tui-regs.c (tui_register_format): Return a
609 unique_xmalloc_ptr.
610 (tui_get_register): Update.
611 (~tui_data_item_window): Remove.
612 (tui_data_window::display_registers_from, tui_display_register):
613 Update.
614 * tui/tui-io.h (tui_expand_tabs): Update.
615 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
616 Remove "col" parameter.
617
8e114aab
TT		 6182019-08-20 Tom Tromey <tom@tromey.com>
619
620 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
621 field.
622 * tui/tui-regs.c (~tui_data_item_window): Update.
623
1a4f81dd
TT		 6242019-08-20 Tom Tromey <tom@tromey.com>
625
626 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
627 earlier.
628
0f8d8876
TT		 6292019-08-20 Tom Tromey <tom@tromey.com>
630
631 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
632
605dc2c2
TT		 6332019-08-20 Tom Tromey <tom@tromey.com>
634
635 * tui/tui-source.h (struct tui_source_window): Update.
636 * tui/tui-regs.c (tui_show_registers): Update.
637 * tui/tui-disasm.h (struct tui_disasm_window): Update.
638 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
639 (NO_REGS_STRING): Remove defines.
640
aedbe3bb
CM		 6412019-08-20 Conrad Meyer <cem@FreeBSD.org>
642
643 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
644 unnecessary thread walk if remote doesn't support the packet.
645
7ce8f214
TT		 6462019-08-19 Tom Tromey <tromey@adacore.com>
647
648 * python/py-value.c (value_has_field): Fix indentation.
649
f21c2bd7
TT		 6502019-08-19 Tom Tromey <tromey@adacore.com>
651
652 * printcmd.c (do_one_display, info_display_command): Update.
653 * block.h (contained_in): Return bool. Add allow_nested
654 parameter.
655 * block.c (contained_in): Return bool. Add allow_nested
656 parameter.
657
d806ea2d
TT		 6582019-08-19 Tom Tromey <tom@tromey.com>
659
660 * configure: Rebuild.
661 * configure.ac: Disallow the combination of -static-libstdc++ and
662 source highlight.
663 * source-cache.c (get_language_name): Handle rust.
664 (source_cache::get_source_lines): Ignore highlighting exceptions.
665
398fdd60
TT		 6662019-08-16 Tom Tromey <tom@tromey.com>
667
668 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
669 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
670 (struct tui_source_window_base) <make_visible, refresh_window,
671 resize>: Remove methods.
672 <execution_info>: Remove field.
673 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
674 (tui_show_source_line, tui_source_window_base)
675 (~tui_source_window_base): Update.
676 (tui_source_window_base::resize)
677 (tui_source_window_base::make_visible)
678 (tui_source_window_base::refresh_window): Remove.
679 (tui_source_window_base::update_exec_info): Update.
680 * tui/tui-source.c (tui_source_window::set_contents): Update.
681 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
682
e699d331
TT		 6832019-08-16 Tom Tromey <tom@tromey.com>
684
685 * tui/tui-hooks.c (tui_remove_hooks): Don't set
686 deprecated_query_hook.
687
bb01dbfc
TT		 6882019-08-16 Tom Tromey <tom@tromey.com>
689
690 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
691 (tui_update_source_windows_with_line): Update.
692 * tui/tui-source.h (struct tui_source_window)
693 <show_symtab_source>: Declare.
694 (tui_show_symtab_source): Don't declare.
695 * tui/tui-source.c (tui_show_symtab_source): Rename from
696 tui_show_symtab_source.
697
81c82c4b
TT		 6982019-08-16 Tom Tromey <tom@tromey.com>
699
700 * tui/tui-winsource.h (struct tui_source_window_base)
701 <set_contents>: Declare.
702 * tui/tui-winsource.c
703 (tui_source_window_base::update_source_window_as_is): Update.
704 * tui/tui-source.h (struct tui_source_window) <set_contents>:
705 Declare.
706 (tui_set_source_content): Don't declare.
707 * tui/tui-source.c (tui_source_window::set_contents): Rename from
708 tui_set_source_content.
709 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
710 Declare.
711 (tui_set_disassem_content): Don't declare.
712 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
713 tui_set_disassem_content.
714
2ddaf614
TT		 7152019-08-16 Tom Tromey <tom@tromey.com>
716
717 * tui/tui-winsource.h (struct tui_source_window_base)
718 <update_breakpoint_info>: Declare.
719 (tui_update_breakpoint_info): Don't declare.
720 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
721 (tui_update_all_breakpoint_info): Update.
722 (tui_source_window_base::update_breakpoint_info): Rename from
723 tui_update_breakpoint_info.
724 (tui_source_window_base::update_exec_info): Update.
725
017f9828
TT		 7262019-08-16 Tom Tromey <tom@tromey.com>
727
728 * tui/tui-winsource.h (struct tui_source_window_base)
729 <update_source_window>: Declare.
730 (tui_update_source_window): Don't declare.
731 * tui/tui-winsource.c
732 (tui_source_window_base::update_source_window): Rename from
733 tui_update_source_window.
734 (tui_source_window_base::rerender): Update.
735 * tui/tui-source.c (tui_source_window::maybe_update): Update.
736 * tui/tui-disasm.c (tui_show_disassem)
737 (tui_show_disassem_and_update_source)
738 (tui_disasm_window::maybe_update): Update.
739
ed8358e9
TT		 7402019-08-16 Tom Tromey <tom@tromey.com>
741
742 * tui/tui-winsource.h (struct tui_source_window_base)
743 <update_source_window_as_is>: Declare.
744 (tui_update_source_window_as_is): Don't declare.
745 * tui/tui-winsource.c (tui_update_source_window): Update
746 (tui_source_window_base::update_source_window_as_is): Rename from
747 tui_update_source_window_as_is.
748 (tui_source_window_base::refill): Update.
749 * tui/tui-source.c (tui_show_symtab_source): Update.
750 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
751 Update.
752
20149b6b
TT		 7532019-08-16 Tom Tromey <tom@tromey.com>
754
755 * tui/tui-winsource.h (tui_update_source_window)
756 (tui_update_source_window_as_is): Remove "noerror" parameter.
757 * tui/tui-winsource.c (tui_update_source_window)
758 (tui_update_source_window_as_is): Remove "noerror" parameter.
759 (tui_update_source_windows_with_addr)
760 (tui_update_source_windows_with_line)
761 (tui_source_window_base::rerender)
762 (tui_source_window_base::refill): Update.
763 * tui/tui-source.h (tui_set_source_content)
764 (tui_show_symtab_source): Remove "noerror" parameter.
765 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
766 parameter.
767 (tui_show_symtab_source): Likewise.
768 (tui_source_window::maybe_update): Update.
769 * tui/tui-disasm.c (tui_show_disassem)
770 (tui_show_disassem_and_update_source)
771 (tui_disasm_window::do_scroll_vertical)
772 (tui_disasm_window::maybe_update): Update.
773
2d83e710
TT		 7742019-08-16 Tom Tromey <tom@tromey.com>
775
776 * tui/tui.c (tui_is_window_visible): Update.
777 * tui/tui-wingeneral.c (tui_make_window)
778 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
779 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
780 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
781 (tui_set_win_height_command, parse_scrolling_args): Update.
782 * tui/tui-source.c (tui_source_window::style_changed): Update.
783 * tui/tui-regs.c (tui_show_registers)
784 (tui_data_window::first_data_item_displayed)
785 (tui_data_window::delete_data_content_windows)
786 (tui_check_register_values, tui_reg_command): Update.
787 * tui/tui-disasm.c (tui_show_disassem): Update.
788 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
789 method.
790 <is_visible>: Remove field.
791 * tui/tui-data.c (tui_next_win, tui_prev_win)
792 (tui_delete_invisible_windows): Update.
793
d4ab829a
TT		 7942019-08-16 Tom Tromey <tom@tromey.com>
795
796 * tui/tui-winsource.h (struct tui_source_window_base)
797 <m_has_locator>: Remove.
798 * tui/tui-layout.c (show_source_disasm_command, show_data)
799 (show_source_or_disasm_and_command): Update.
800
aa7ca1bb
AH		 8012019-08-16 Alan Hayward <alan.hayward@arm.com>
802
803 * NEWS (Other MI changes): New subsection.
804 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
805 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
806 * arch-utils.c (default_get_pc_address_flags): New function.
807 * arch-utils.h (default_get_pc_address_flags): New declaration.
808 * gdbarch.sh: Add get_pc_address_flags.
809 * gdbarch.c: Regenerate.
810 * gdbarch.h: Likewise.
811 * stack.c (print_pc): New function.
812 (print_frame_info) (print_frame): Call print_pc.
813
6eac171f
TV		 8142019-08-16 Tom de Vries <tdevries@suse.de>
815
816 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
817 print_objfile_section_info.
818
3df505f6
TT		 8192019-08-15 Tom Tromey <tom@tromey.com>
820
821 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
822 calling update_cmdwin_start_line.
823 * tui/tui-winsource.h (struct tui_source_window_base)
824 <do_make_visible_with_new_height, set_new_height>: Don't declare.
825 <rerender>: Declare.
826 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
827 Call rerender.
828 (tui_source_window_base::set_new_height): Remove.
829 (tui_source_window_base::rerender): Rename from
830 do_make_visible_with_new_height.
831 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
832 resize method.
833 (tui_win_info::make_invisible_and_set_new_height)
834 (tui_win_info::make_visible_with_new_height): Remove.
835 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
836 Declare.
837 * tui/tui-stack.c (tui_locator_window::rerender): New method.
838 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
839 do_make_visible_with_new_height>: Don't declare.
840 <rerender>: Declare.
841 * tui/tui-regs.c (tui_data_window::rerender): Rename from
842 set_new_height.
843 (tui_data_window::do_make_visible_with_new_height): Remove.
844 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
845 call tui_show_locator_content.
846 (tui_gen_win_info::resize): Call rerender.
847 (show_source_or_disasm_and_command): Don't call
848 tui_show_locator_content.
849 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
850 method.
851 (struct tui_win_info) <rerender>: Declare.
852 <set_new_height, make_invisible_and_set_new_height,
853 make_visible_with_new_height>: Don't declare.
854 * tui/tui-data.c (tui_win_list::rerender): New method.
855 * tui/tui-command.h (struct tui_cmd_window)
856 <do_make_visible_with_new_height>: Don't declare.
857 * tui/tui-command.c
858 (tui_cmd_window::do_make_visible_with_new_height): Remove.
859
272560b5
TT		 8602019-08-15 Tom Tromey <tromey@adacore.com>
861
862 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
863 * ada-lang.c (ada_enum_name): Likewise.
864
08235187
CB		 8652019-08-15 Christian Biesinger <cbiesinger@google.com>
866
867 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
868 leading underscore.
869 (GdbOutputErrorFile): Likewise.
870 (global scope): Adjust constructor calls to GdbOutput{,Error}File
871 accordingly.
872 (execute_unwinders): Rename to have a leading underscore.
873 (auto_load_packages): Likewise.
874 (global scope): Adjust call to auto_load_packages accordingly.
875 (GdbSetPythonDirectory): Likewise.
876 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
877 instead of execute_unwinders.
878
db502012
TT		 8792019-08-15 Tom Tromey <tom@tromey.com>
880
881 * tui/tui-layout.c (show_layout, show_source_disasm_command)
882 (show_data): Don't change window visibility.
883 (tui_gen_win_info::resize): Remove special case for command
884 window. Use wresize, when available.
885 (show_source_or_disasm_and_command): Don't change window
886 visibility.
887 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
888 <make_visible>: New method.
889 * tui/tui-command.c (tui_cmd_window::resize): New method.
890
3891b65e
TT		 8912019-08-15 Tom Tromey <tom@tromey.com>
892
893 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
894 (struct tui_source_windows): New.
895 * tui/tui-winsource.c (tui_display_main): Update.
896 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
897 (new_height_ok, parse_scrolling_args): Update.
898 * tui/tui-layout.c (show_layout, show_data): Update.
899 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
900 (tui_add_to_source_windows): Don't declare.
901 * tui/tui-data.c (source_windows, tui_source_windows)
902 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
903
ee556432
TT		 9042019-08-15 Tom Tromey <tom@tromey.com>
905
906 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
907 Rename from reset.
908 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
909 * tui/tui-layout.c (show_source_disasm_command, show_data):
910 Update.
911 (tui_gen_win_info::resize): Rename.
912 (show_source_or_disasm_and_command): Update.
913 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
914 reset.
915
46f438e3
TT		 9162019-08-15 Tom Tromey <tom@tromey.com>
917
918 * tui/tui-stack.c (tui_initialize_static_data): Remove.
919 * tui/tui-interp.c (tui_interp::init): Don't call
920 tui_initialize_static_data.
921 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
922
f4ce562c
TT		 9232019-08-15 Tom Tromey <tom@tromey.com>
924
925 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
926 examine tui_win_list.
927
c398c3d0
TT		 9282019-08-15 Tom Tromey <tom@tromey.com>
929
930 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
931 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
932 tui_clear_source_content.
933 (tui_clear_source_content): Remove.
934 (tui_source_window_base::do_erase_source_content): Hoist call to
935 content.clear().
936 * tui/tui-stack.c (tui_show_frame_info): Don't call
937 tui_clear_source_content.
938
e25d2004
TT		 9392019-08-15 Tom Tromey <tom@tromey.com>
940
941 * tui/tui-winsource.h (struct tui_source_window_base)
942 <do_erase_source_content>: New method.
943 <erase_source_content>: New method.
944 (tui_erase_source_content): Don't declare.
945 * tui/tui-winsource.c (tui_clear_source_content): Update.
946 (tui_source_window_base::do_erase_source_content): Rename from
947 tui_erase_source_content.
948 (tui_source_window_base::show_source_content): Update.
949 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
950 * tui/tui-source.h (struct tui_source_window)
951 <erase_source_content>: New method.
952 * tui/tui-disasm.h (struct tui_disasm_window)
953 <erase_source_content>: New method.
954
002f15c2
TT		 9552019-08-15 Tom Tromey <tom@tromey.com>
956
957 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
958 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
959 constructor.
960 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
961 * tui/tui-source.c (tui_set_source_content): Update.
962 * tui/tui-disasm.c (tui_set_disassem_content): Update.
963
c9033fe8
TT		 9642019-08-15 Tom Tromey <tom@tromey.com>
965
966 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
967 * tui/tui-winsource.c (tui_line_is_displayed): Move to
968 tui-source.c.
969 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
970 Declare.
971 * tui/tui-source.c (tui_source_window::line_is_displayed): New
972 method.
973 (tui_source_window::maybe_update): Update.
974
088f37dd
TT		 9752019-08-15 Tom Tromey <tom@tromey.com>
976
977 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
978 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
979 tui-disasm.c.
980 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
981 Declare.
982 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
983 method.
984 (tui_disasm_window::maybe_update): Update.
985
a54700c6
TT		 9862019-08-15 Tom Tromey <tom@tromey.com>
987
988 * tui/tui-winsource.h (struct tui_source_window_base)
989 <maybe_update>: Declare.
990 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
991 method.
992 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
993 Declare.
994 * tui/tui-source.c (tui_source_window::maybe_update): New method.
995 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
996 Declare.
997 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
998
e2a678a5
TT		 9992019-08-15 Tom Tromey <tom@tromey.com>
1000
1001 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1002
f2dda477
TT		 10032019-08-15 Tom Tromey <tom@tromey.com>
1004
1005 * tui/tui-wingeneral.c: Include tui-stack.h.
1006 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1007 (struct tui_locator_window): Move from tui-data.h.
1008 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1009 (tui_initialize_static_data): Move from tui-data.c.
1010 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1011 (struct tui_locator_window): Move to tui-stack.c.
1012 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1013 (tui_initialize_static_data): Move to tui-stack.c.
1014
ed4a1084
TT		 10152019-08-15 Tom Tromey <tom@tromey.com>
1016
1017 * tui/tui-layout.c (show_source_disasm_command)
1018 (show_source_or_disasm_and_command): Use make_visible method, not
1019 tui_make_window.
1020 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1021 Remove.
1022
65962b20
TT		 10232019-08-15 Tom Tromey <tom@tromey.com>
1024
1025 * tui/tui-wingeneral.h (tui_make_window): Update.
1026 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1027 parameter.
1028 (tui_gen_win_info::make_visible): Update.
1029 * tui/tui-regs.c (tui_data_window::display_registers_from):
1030 Update.
1031 * tui/tui-layout.c (show_source_disasm_command)
1032 (show_source_or_disasm_and_command): Update.
1033 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1034 (enum tui_box): Remove.
1035 (struct tui_win_info) <can_box>: New method.
1036 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1037 method.
1038
2208ee91
TV		 10392019-08-15 Tom de Vries <tdevries@suse.de>
1040
1041 * linux-nat-trad.c: Include gdbarch.h.
1042
75faf5c4
AH		 10432019-08-14 Alan Hayward <alan.hayward@arm.com>
1044
1045 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1046 register sizes.
1047
b1c896b3
TT		 10482019-08-14 Tom Tromey <tromey@adacore.com>
1049
1050 * darwin-nat.c: Include gdbarch.h.
1051 * darwin-nat-info.c: Include gdbarch.h.
1052
6405cd73
TT		 10532019-08-13 Tom Tromey <tom@tromey.com>
1054
1055 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1056 Remove.
1057 * tui/tui-data.c (tui_initialize_static_data): Update.
1058
5216580d
TT		 10592019-08-13 Tom Tromey <tom@tromey.com>
1060
1061 * tui/tui-winsource.h (struct tui_exec_info_window)
1062 <~tui_exec_info_window, maybe_allocate_content, get_content,
1063 m_content>: Remove.
1064 (struct tui_source_window_base) <set_exec_info_content,
1065 show_exec_info_content>: Don't declare.
1066 * tui/tui-winsource.c
1067 (tui_exec_info_window::maybe_allocate_content): Remove.
1068 (tui_source_window_base::update_exec_info): Rename from
1069 set_exec_info_content.
1070 (tui_source_window_base::show_exec_info_content)
1071 (tui_source_window_base::update_exec_info): Remove.
1072
93858ad3
TT		 10732019-08-13 Tom Tromey <tom@tromey.com>
1074
1075 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1076 declare.
1077 * tui/tui-winsource.c (tui_update_source_window_as_is)
1078 (tui_update_source_windows_with_addr, tui_erase_source_content):
1079 Update.
1080 (tui_clear_exec_info_content): Remove.
1081
e321e7ce
TT		 10822019-08-13 Tom Tromey <tom@tromey.com>
1083
1084 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1085 declare.
1086 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1087 call tui_erase_exec_info_content.
1088 (tui_clear_exec_info_content): Rename from
1089 tui_erase_exec_info_content.
1090 (tui_clear_exec_info_content): Delete.
1091
8270ac62
TT		 10922019-08-13 Tom Tromey <tom@tromey.com>
1093
1094 * tui/tui-winsource.h (struct tui_source_window_base)
1095 <show_exec_info_content>: Declare.
1096 (tui_show_exec_info_content): Don't declare.
1097 * tui/tui-winsource.c
1098 (tui_source_window_base::show_exec_info_content): Rename from
1099 tui_show_exec_info_content.
1100 (tui_source_window_base::update_exec_info): Update.
1101
7b56485d
TT		 11022019-08-13 Tom Tromey <tom@tromey.com>
1103
1104 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1105 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1106 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1107 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1108 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1109 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1110 ... here.
1111
7ba913dc
TT		 11122019-08-13 Tom Tromey <tom@tromey.com>
1113
1114 * tui/tui-winsource.h (struct tui_source_window_base)
1115 <update_exec_info>: Declare.
1116 (tui_update_exec_info): Don't declare.
1117 * tui/tui-winsource.c (tui_update_source_window_as_is)
1118 (tui_source_window_base::refresh_all)
1119 (tui_update_all_breakpoint_info): Update.
1120 (tui_source_window_base::update_exec_info): Rename from
1121 tui_update_exec_info.
1122 * tui/tui-stack.c (tui_show_frame_info): Update.
1123
37a4a131
TT		 11242019-08-13 Tom Tromey <tom@tromey.com>
1125
1126 * tui/tui-winsource.h (struct tui_source_window_base)
1127 <set_exec_info_content>: Declare.
1128 (tui_set_exec_info_content): Don't declare.
1129 * tui/tui-winsource.c
1130 (tui_source_window_base::set_exec_info_content): Rename from
1131 tui_set_exec_info_content.
1132 (tui_update_exec_info): Update.
1133
0bd27e07
TT		 11342019-08-13 Tom Tromey <tom@tromey.com>
1135
1136 * tui/tui-winsource.h (struct tui_source_window_base)
1137 <show_source_content>: Declare.
1138 (tui_show_source_content): Don't declare.
1139 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1140 (tui_source_window_base::show_source_content): Rename from
1141 tui_show_source_content.
1142 (tui_source_window_base::refresh_all): Update.
1143 * tui/tui-layout.c (show_source_disasm_command)
1144 (show_source_or_disasm_and_command): Update.
1145
b4ef5aeb
TT		 11462019-08-13 Tom Tromey <tom@tromey.com>
1147
1148 * tui/tui-winsource.c (tui_erase_source_content)
1149 (tui_show_source_content, tui_source_window_base::refresh_all):
1150 Update.
1151 * tui/tui-wingeneral.h
1152 (tui_check_and_display_highlight_if_needed): Don't declare.
1153 * tui/tui-wingeneral.c
1154 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1155 check_and_display_highlight_if_needed.
1156 * tui/tui-win.c (tui_rehighlight_all)
1157 (tui_win_info::make_visible_with_new_height): Update.
1158 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1159 (tui_data_window::erase_data_content)
1160 (tui_data_window::display_all_data): Update.
1161 * tui/tui-data.h (struct tui_win_info)
1162 <check_and_display_highlight_if_needed>: Declare.
1163
fede5273
TT		 11642019-08-13 Tom Tromey <tom@tromey.com>
1165
1166 * tui/tui-win.c (tui_resize_all): Call
1167 tui_delete_invisible_windows.
1168 * tui/tui-layout.c (show_layout): Call
1169 tui_delete_invisible_windows.
1170 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1171 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1172
22c3f490
TT		 11732019-08-13 Tom Tromey <tom@tromey.com>
1174
1175 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1176 tui_add_win_to_layout.
1177
16cb7910
TT		 11782019-08-13 Tom Tromey <tom@tromey.com>
1179
1180 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1181 * tui/tui-layout.c (tui_default_win_height): Now static.
1182
cc0c3ffb
TT		 11832019-08-13 Tom Tromey <tom@tromey.com>
1184
1185 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1186 single switch.
1187 (show_source_disasm_command, show_source_or_disasm_and_command):
1188 Don't check current layout.
1189
3f3ffe54
TT		 11902019-08-13 Tom Tromey <tom@tromey.com>
1191
1192 * tui/tui-wingeneral.c (make_all_visible): Remove.
1193 (tui_make_all_invisible): Simplify.
1194 * tui/tui-layout.c (tui_make_all_invisible): Move from
1195 tui-wingeneral.c; simplify.
1196 (show_layout): Hoist call to tui_make_all_invisible.
1197 (show_data): Don't call tui_make_all_invisible.
1198
69258091
TT		 11992019-08-13 Tom Tromey <tom@tromey.com>
1200
1201 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1202 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1203
62cf57fe
TT		 12042019-08-13 Tom Tromey <tom@tromey.com>
1205
1206 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1207 tui-data.c.
1208 (show_source_disasm_command, show_data)
1209 (show_source_or_disasm_and_command): Don't use
1210 tui_set_current_layout_to.
1211 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1212 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1213 tui-layout.c.
1214 (tui_set_current_layout_to): Remove.
1215
2afade5d
TT		 12162019-08-13 Tom Tromey <tom@tromey.com>
1217
1218 * tui/tui-layout.c (tui_set_layout): Update.
1219 * tui/tui-data.h (struct tui_layout_def): Remove.
1220 (tui_layout_def): Don't declare.
1221 * tui/tui-data.c (layout_def): Remove.
1222 (tui_layout_def): Remove.
1223
a3504e96
TT		 12242019-08-13 Tom Tromey <tom@tromey.com>
1225
1226 * tui/tui-winsource.h (struct tui_source_window_base)
1227 <clear_detail>: No longer "override".
1228 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1229 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1230 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1231 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1232 Remove.
1233 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1234
29c92911
TT		 12352019-08-13 Tom Tromey <tromey@adacore.com>
1236
1237 * tracepoint.c: Don't include readline.h or history.h.
1238
86c6b807
TT		 12392019-08-12 Tom Tromey <tom@tromey.com>
1240
1241 * configure: Rebuild.
1242 * configure.ac: Check for readline 7.
1243 * NEWS: Mention readline 7 requirement.
1244 * README: Update.
1245
5db2718c
TT		 12462019-08-12 Tom Tromey <tom@tromey.com>
1247
1248 * mingw-hdep.c (gdb_select): Remove readline hack.
1249
dac36daf
PFC		 12502019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1251
1252 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1253 when the function fails.
1254
1022c627
AA		 12552019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1256
1257 * s390-tdep.c (s390_type_align): New function.
1258 (s390_gdbarch_init): Set it as type_align gdbarch method.
1259
eba4caf2
TV		 12602019-08-09 Tom de Vries <tdevries@suse.de>
1261
1262 PR gdb/24591
1263 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1264 pc_low with relocation offset.
1265
123cd851
TT		 12662019-08-07 Tom Tromey <tromey@adacore.com>
1267
1268 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1269 (print_frame_args): Update.
1270 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1271 Update.
1272 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1273 * frame.h (struct frame_arg): Add initializers.
1274 <error>: Now a unique_xmalloc_ptr.
1275
3d31bc39
AH		 12762019-08-07 Alan Hayward <alan.hayward@arm.com>
1277
1278 * NEWS: Expand the Pointer Authentication entry.
1279 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1280 (aarch64_frame_unmask_lr): ... to this.
1281 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1282 Call aarch64_frame_unmask_lr.
1283 * frame.c (struct frame_info): Add "masked" variable.
1284 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1285 (fprint_frame): Check for masked pc.
1286 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1287 declarations.
1288 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1289 * stack.c (print_frame): Check for masked pc.
1290
0cf9feb9
TT		 12912019-08-06 Tom Tromey <tom@tromey.com>
1292
1293 * stabsread.c (patch_block_stabs, read_one_struct_field)
1294 (read_enum_type): Use obstack_strndup.
1295 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1296 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1297 * dwarf2read.c (guess_full_die_structure_name)
1298 (anonymous_struct_prefix): Use obstack_strndup.
1299 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1300 * c-exp.y (yylex): Use obstack_strndup.
1301 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1302 (write_var_or_type): Use obstack_strndup.
1303
efba19b0
TT		 13042019-08-06 Tom Tromey <tom@tromey.com>
1305
1306 * symfile.c (reread_symbols): Use obstack_strdup.
1307 * stabsread.c (read_type): Use obstack_strdup.
1308 * gdb_obstack.h (obstack_strdup): New overload.
1309 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1310 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1311 (dwarf2_canonicalize_name): Use obstack_strdup.
1312 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1313 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1314 Use obstack_strdup.
1315
f25102f7
TT		 13162019-08-06 Tom Tromey <tom@tromey.com>
1317
1318 * gdb_obstack.h (obstack_strdup): Define.
1319 * gdb_obstack.c (obstack_strdup): Don't define.
1320
021887d8
TT		 13212019-08-06 Tom Tromey <tom@tromey.com>
1322
1323 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1324 obstack_strdup.
1325 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1326 obstack_strdup.
1327 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1328 * stabsread.c (common_block_start): Use obstack_strdup.
1329 * objfiles.c (set_objfile_main_name, objfile): Use
1330 obstack_strdup.
1331 * namespace.c (add_using_directive): Use obstack_strdup.
1332 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1333 * jit.c (finalize_symtab): Use obstack_strdup.
1334 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1335 (guess_partial_die_structure_name, partial_die_info::fixup)
1336 (dwarf2_name): Use obstack_strdup.
1337 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1338 obstack_strdup.
1339 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1340 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1341 obstack_strdup.
1342 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1343
d2834edc
PW		 13442019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1345
1346 * unittests/help-doc-selftests.c: New file.
1347 * Makefile.in: Add the new file.
1348
590042fc
PW		 13492019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1350
1351 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1352 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1353 the full first line, except when FOR_VALUE_PREFIX. In this case,
1354 the trailing '.' is not output, and the first character is uppercased.
1355 (print_help_for_command): Update call to print_doc_line.
1356 (print_doc_of_command): Likewise.
1357 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1358 * cli/cli-option.c (append_indented_doc): Do not append newline.
1359 (build_help_option): Append newline after first appended_indented_doc
1360 only if a second call is done.
1361 (build_help): Append 2 new lines before each option, except the first
1362 one.
1363 * compile/compile.c (_initialize_compile): Add new lines after
1364 %OPTIONS%, when not at the end of the help.
1365 Change help doc or code
1366 producing the help doc to respect the invariants.
1367 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1368 Also removed the new line after 'Options:', as all other commands
1369 do not put an empty line between 'Options:' and the first option.
1370 * printcmd.c (_initialize_printcmd): Likewise.
1371 * stack.c (_initialize_stack): Likewise.
1372 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1373 incorrectly telling COMMAND is optional.
1374 * ada-lang.c (_initialize_ada_language): Change help doc or code
1375 producing the help doc to respect the invariants.
1376 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1377 * breakpoint.c (_initialize_breakpoint): Likewise.
1378 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1379 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1380 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1381 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1382 _initialize_cli_style): Likewise.
1383 * corelow.c (core_target_info): Likewise.
1384 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1385 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1386 * filesystem.c (_initialize_filesystem): Likewise.
1387 * frame.c (_initialize_frame): Likewise.
1388 * gnu-nat.c (add_task_commands): Likewise.
1389 * infcall.c (_initialize_infcall): Likewise.
1390 * infcmd.c (_initialize_infcmd): Likewise.
1391 * interps.c (_initialize_interpreter): Likewise.
1392 * language.c (_initialize_language): Likewise.
1393 * linux-fork.c (_initialize_linux_fork): Likewise.
1394 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1395 * maint.c (_initialize_maint_cmds): Likewise.
1396 * memattr.c (_initialize_mem): Likewise.
1397 * printcmd.c (_initialize_printcmd): Likewise.
1398 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1399 _RegEx): Likewise.
1400 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1401 * record-btrace.c (_initialize_record_btrace): Likewise.
1402 * record-full.c (_initialize_record_full): Likewise.
1403 * record.c (_initialize_record): Likewise.
1404 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1405 * regcache.c (_initialize_regcache): Likewise.
1406 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1407 _initialize_remote): Likewise.
1408 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1409 * serial.c (_initialize_serial): Likewise.
1410 * skip.c (_initialize_step_skip): Likewise.
1411 * source.c (_initialize_source): Likewise.
1412 * stack.c (_initialize_stack): Likewise.
1413 * symfile.c (_initialize_symfile): Likewise.
1414 * symtab.c (_initialize_symtab): Likewise.
1415 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1416 * top.c (init_main): Likewise.
1417 * tracefile-tfile.c (tfile_target_info): Likewise.
1418 * tracepoint.c (_initialize_tracepoint): Likewise.
1419 * tui/tui-win.c (_initialize_tui_win): Likewise.
1420 * utils.c (add_internal_problem_command): Likewise.
1421 * valprint.c (value_print_option_defs): Likewise.
1422
404f2902
FCE		 14232019-08-06 Frank Ch. Eigler <fche@redhat.com>
1424
1425 PR build/24886
1426 * configure.ac: Drop enable-libmcheck support.
1427 * configure, config.in: Rebuild.
1428 * libmcheck.m4: Remove.
1429 * acinclude.m4: Don't include it.
1430 * Makefile.in: Don't distribute it.
1431 * top.c (print_gdb_configuration): Don't mention it.
1432
046bebe1
TT		 14332019-08-06 Tom Tromey <tom@tromey.com>
1434
1435 * utils.c (set_output_style): Sometimes pass stream to
1436 emit_style_escape.
1437 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1438 * record-btrace.c (btrace_insn_history): Update.
1439 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1440 method.
1441 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1442 Update initializers.
1443 <m_uiout>: New field.
1444 <m_di>: Move lower.
1445 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1446 Remove "uiout" parameter.
1447 (dump_insns): Update.
1448 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1449 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1450
ddbcedf5
CB		 14512019-08-06 Christian Biesinger <cbiesinger@google.com>
1452
1453 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1454 (error_in_psymtab_expansion): Likewise.
1455 (lookup_symbol_via_quick_fns): Likewise.
1456 (basic_lookup_transparent_type_quick): Likewise.
1457 (basic_lookup_transparent_type_1): Likewise.
1458
b08b16c8
TT		 14592019-08-06 Tom Tromey <tromey@adacore.com>
1460
1461 * source.c (last_source_error): Now bool.
1462 (print_source_lines_base): Make "noprint" bool. Only open
1463 source file when last_source_visited changes.
1464
cb44333d
TT		 14652019-08-06 Tom Tromey <tromey@adacore.com>
1466
1467 * annotate.c (annotate_source_line): Use g_source_cache.
1468 * source-cache.c (source_cache::get_plain_source_lines): Change
1469 parameters. Populate m_offset_cache.
1470 (source_cache::ensure): New method.
1471 (source_cache::get_line_charpos): New method.
1472 (extract_lines): Move lower. Change parameters.
1473 (source_cache::get_source_lines): Move lower.
1474 * source-cache.h (class source_cache): Update comment.
1475 <get_line_charpos>: New method.
1476 <get_source_lines>: Update comment.
1477 <clear>: Clear m_offset_cache.
1478 <get_plain_source_lines>: Change parameters.
1479 <ensure>: New method
1480 <m_offset_cache>: New member.
1481 * source.c (forget_cached_source_info_for_objfile): Update.
1482 (info_source_command): Use g_source_cache.
1483 (find_source_lines, open_source_file_with_line_charpos): Remove.
1484 (print_source_lines_base, search_command_helper): Use g_source_cache.
1485 * source.h (open_source_file_with_line_charpos): Don't declare.
1486 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1487 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1488 Use g_source_cache.
1489
872dceaa
TT		 14902019-08-06 Tom Tromey <tromey@adacore.com>
1491
1492 * source-cache.c (source_cache::get_plain_source_lines):
1493 Remove "first_line" and "last_line" parameters.
1494 (source_cache::get_source_lines): Cache plain text.
1495 * source-cache.h (class source_cache)
1496 <get_plain_source_lines>: Update.
1497
269249d9
TT		 14982019-08-06 Tom Tromey <tromey@adacore.com>
1499
1500 * source-cache.c (extract_lines): No longer a method.
1501 Changed type of parameter. Include final newline.
1502 (selftests::extract_lines_test): New function.
1503 (_initialize_source_cache): Likewise.
1504 * source-cache.h (class source_cache)
1505 <extract_lines>: Don't declare.
1506
c0e8dcd8
TT		 15072019-08-06 Tom Tromey <tromey@adacore.com>
1508
1509 * breakpoint.c (init_breakpoint_sal): Update.
1510 (breakpoint): Update.
1511 * breakpoint.h (struct breakpoint) <filter>: Now a
1512 unique_xmalloc_ptr.
1513
0b27c27d
CB		 15142019-08-05 Christian Biesinger <cbiesinger@google.com>
1515
1516 * NEWS: Mention dictionary access on blocks.
1517 * python/py-block.c (blpy_getitem): New function.
1518 (block_object_as_mapping): New struct.
1519 (block_object_type): Use new struct for tp_as_mapping field.
1520
4ee94178
CB		 15212019-08-05 Christian Biesinger <cbiesinger@google.com>
1522
1523 * objfiles.h (objfile): Add a comment describing partial symbols.
1524
8abfcabc
TT		 15252019-08-05 Tom Tromey <tromey@adacore.com>
1526
1527 * compile/compile.c (_initialize_compile): Use _(), not N_().
1528 * thread.c (_initialize_thread): Use _(), not N_().
1529 * stack.c (_initialize_stack): Use _(), not N_().
1530 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1531
2b79f376
SM		 15322019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1533
1534 * dwarf2read.c (struct dw2_symtab_iterator):
1535 <want_specific_block>: Remove.
1536 <block_index>: Change type to gdb::optional.
1537 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1538 change type of BLOCK_INDEX parameter to gdb::optional.
1539 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1540 (dw2_lookup_symbol): Don't pass argument for
1541 WANT_SPECIFIC_BLOCK.
1542 (dw2_expand_symtabs_for_function): Don't pass argument for
1543 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1544 (class dw2_debug_names_iterator)
1545 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1546 parameter, change BLOCK_INDEX type to gdb::optional.
1547 <m_want_specific_block>: Remove.
1548 <m_block_index>: Change type to gdb::optional.
1549 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1550 gdb::optional. Re-write in function of gdb::optional.
1551 (dw2_debug_names_lookup_symbol): Don't pass argument for
1552 WANT_SPECIFIC_BLOCK.
1553 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1554 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1555 BLOCK_INDEX.
1556
ae60f04e
PW		 15572019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1558
1559 * NEWS: Mention changes to "info sources" command.
1560
28cd9371
PW		 15612019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1562
1563 * symtab.c (filename_partial_match_opts): New struct type.
1564 (struct output_source_filename_data): New members
1565 regexp, c_regexp, partial_match.
1566 (output_source_filename): Use new members to decide to print file.
1567 (info_sources_option_defs): New variable.
1568 (make_info_sources_options_def_group, print_info_sources_header,
1569 info_sources_command_completer):
1570 New functions.
1571 (info_sources_command): Read new optional arguments.
1572 (_initialize_symtab): Update info sources help.
1573
ca683e3a
AO		 15742019-08-02 Alexandre Oliva <oliva@adacore.com>
1575
1576 * ada-lang.c (exception_support_info_v0): Renamed from...
1577 (default_exception_support_info): ... this. Create new
1578 definition for v1.
1579 (ada_has_this_exception_support): Look up catch_handlers_sym.
1580 (ada_exception_support_info_sniffer): Try v0 after default.
1581
f1264162
TT		 15822019-08-01 Tom Tromey <tromey@adacore.com>
1583
1584 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1585 gdbarch.h.
1586
0a7b2485
CB		 15872019-08-01 Christian Biesinger <cbiesinger@google.com>
1588
1589 * s12z-tdep.c: Fix include path for s12z-opc.h.
1590
c6bdbeb7
AH		 15912019-08-01 Alan Hayward <alan.hayward@arm.com>
1592
1593 * NEWS: Require GNU make 3.82.
1594
a2bd7b82
TT		 15952019-07-16 Tom Tromey <tom@tromey.com>
1596
1597 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1598 declare.
1599
aa3b6533
TT		 16002019-07-30 Tom Tromey <tromey@adacore.com>
1601
1602 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1603
a1530dc7
KB		 16042019-07-30 Kevin Buettner <kevinb@redhat.com>
1605
1606 * printcmd.c (print_address_symbolic): Print negative offsets.
1607 (build_address_symbolic): Force signed arithmetic when computing
1608 offset.
1609
2906593f
CB		 16102019-07-30 Christian Biesinger <cbiesinger@google.com>
1611
1612 PR/24474: Add a function to lookup static variables.
1613 * NEWS: Mention this new function.
1614 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1615 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1616 * python/python.c (python_GdbMethods): Add new function.
1617
c620ed88
CB		 16182019-07-29 Christian Biesinger <cbiesinger@google.com>
1619
1620 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1621 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1622 (objfpy_lookup_static_symbol): New function.
1623 (objfile_object_methods): Add new functions.
1624
bc4268a5
PW		 16252019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1626
1627 * NEWS: Mention 'set|show print frame-info'. Mention new
1628 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1629 backtrace argument. Mention that python frame filtering code
1630 is now consistent with what 'backtrace' command prints.
1631
4b5e8d19
PW		 16322019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1633
1634 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1635 comments.
1636 (print_frame_info_auto, print_frame_info_source_line,
1637 print_frame_info_location, print_frame_info_source_and_location,
1638 print_frame_info_location_and_address, print_frame_info_short_location):
1639 New declarations.
1640 (struct frame_print_options): New member print_frame_info.
1641 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1642 * stack.h (get_user_print_what_frame_info): New declaration.
1643 (frame_show_address): New declaration.
1644 * stack.c (print_frame_arguments_choices): New value 'presence'.
1645 (print_frame_info_auto, print_frame_info_source_line,
1646 print_frame_info_location, print_frame_info_source_and_location,
1647 print_frame_info_location_and_address, print_frame_info_short_location,
1648 print_frame_info_choices, print_frame_info_print_what): New definitions.
1649 (print_frame_args): Only print dots for args if print frame-arguments
1650 is 'presence'.
1651 (frame_print_option_defs): New element for "frame-info".
1652 (get_user_print_what_frame_info): New function.
1653 (frame_show_address): Make non static. Move comment to stack.h.
1654 (print_frame_info_to_print_what): New function.
1655 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1656 to decide what to print.
1657 (backtrace_command_1): Handle the new print_frame_arguments_presence
1658 value.
1659 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1660 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1661 (py_print_frame): In non-mi mode, use LOCATION as default for
1662 print_what, similarly to frame information printed directly by
1663 backtrace command. Handle frame-info user option in non MI mode.
1664
6bdfee81
KB		 16652019-07-27 Kevin Buettner <kevinb@redhat.com>
1666
1667 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1668 Add case for debugging 32-bit target on 64-bit host. Revise
1669 comment.
1670
98a617f8
KB		 16712019-07-27 Kevin Buettner <kevinb@redhat.com>
1672
1673 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1674 instead of find_function_entry_range_from_pc.
1675
567238c9
KB		 16762019-07-27 Kevin Buettner <kevinb@redhat.com>
1677
1678 * stack.c (find_frame_funname): Remove code which preferred
1679 minsym over symtab sym in "certain pathological cases".
1680
2dc80cf8
KB		 1681 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1682 parameter. Change type of "do_demangle" to bool.
1683 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1684 Pass suitable "prefer_sym_over_minsym" flag to
1685 build_address_symbolic(). Don't output "+" for negative offsets.
1686 * printcmd.c (print_address_symbolic): Update invocation of
1687 build_address_symbolic to include a "prefer_sym_over_minsym"
1688 flag.
1689 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1690 Restrict cases in which use of minimal symbol is preferred to that
1691 of a found symbol. Update comments.
1692
1aff7173
KB		 1693 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1694 for entry pc when entry pc is out of range for that FDE.
1695
89b085ac
BC		 16962019-07-26 Brian Callahan <bcallah@openbsd.org>
1697
1698 PR gdb/24839:
1699 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1700 type.
1701
f32feb4a
CB		 17022019-07-25 Christian Biesinger <cbiesinger@google.com>
1703
1704 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1705 this function's Python signature.
1706
1707
17082019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 1709
1710 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1711 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1712 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1713 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1714 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1715
1716
c54e4253
YS		 17172019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1718
1719 * h8300-tdep.c (h8300_register_name_common): New.
1720 h8300_register_name): Use h8300_register_name_common.
1721 (h8300s_register_name): Likewise.
1722 (h8300sx_register_name): Likewise.
1723 (h8300h_register_nam): New.
1724 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1725
1726
40eadf04
SP		 17272019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1728
1729 * arm-tdep.c (arm_skip_cmse_entry): New function.
1730 (arm_is_sgstubs_section): New function.
1731 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1732
bfa2a36d
TT		 17332019-07-22 Tom Tromey <tom@tromey.com>
1734
1735 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1736 Don't self-assign.
1737
a8e9d247
AB		 17382019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1739
1740 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1741 type_print.
1742
eb86c5e2
AB		 17432019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1744
1745 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1746 so that GDB doesn't match any msymbols when searching in the
1747 TYPES_DOMAIN.
1748 (print_symbol_info): Print using typedef_print or type_print based
1749 on the type of the symbol. Add updated FIXME comment moved from...
1750 (_initialize_symtab): ... move and update FIXME comment to above.
1751
a8eab7c6
AB		 17522019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1753
1754 * NEWS: Mention adding -q option to "info types".
1755 * symtab.c (struct info_types_options): New struct.
1756 (info_types_options_defs): New variable.
1757 (make_info_types_options_def_group): New function.
1758 (info_types_command): Use gdb::option framework to parse options.
1759 (info_types_command_completer): New function.
1760 (_initialize_symtab): Extend the help text on "info types" and
1761 register command completer.
1762
b4603c34
CB		 17632019-07-21 Christian Biesinger <cbiesinger@google.com>
1764
1765 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1766 (lookup_symbol_in_objfile): Change int to block_enum and add a
1767 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1768
c8cdc1e0
CB		 17692019-07-20 Christian Biesinger <cbiesinger@google.com>
1770
1771 * MAINTAINERS (Write After Approval): Add self.
1772
01e175fe
AB		 17732019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1774
1775 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1776 instruction to the dummy code region.
1777
56f79b63
TT		 17782019-07-19 Tom Tromey <tromey@adacore.com>
1779
1780 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1781 (ARGSUSED, PARAMS, __func__): Remove rules.
1782
4c5aa8e0
AH		 17832019-07-19 Alan Hayward <alan.hayward@arm.com>
1784
1785 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1786 * features/arm/arm-with-iwmmxt.c: Remove.
1787 * features/arm/arm-with-iwmmxt.xml: Remove.
1788 * features/arm/arm-with-m-fpa-layout.c: Remove.
1789 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1790 * features/arm/arm-with-m-vfp-d16.c: Remove.
1791 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1792 * features/arm/arm-with-m.c: Remove.
1793 * features/arm/arm-with-m.xml: Remove.
1794 * features/arm/arm-with-neon.c: Remove.
1795 * features/arm/arm-with-neon.xml: Remove.
1796 * features/arm/arm-with-vfpv2.c: Remove.
1797 * features/arm/arm-with-vfpv2.xml: Remove.
1798 * features/arm/arm-with-vfpv3.c: Remove.
1799 * features/arm/arm-with-vfpv3.xml: Remove.
1800
f42b2617
AH		 18012019-07-19 Alan Hayward <alan.hayward@arm.com>
1802
1803 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1804
f29ec966
AH		 18052019-07-19 Alan Hayward <alan.hayward@arm.com>
1806
1807 * arch/aarch32.c (aarch32_create_target_description): Create
1808 target descriptions using features.
1809 * arch/arm.c (arm_create_target_description)
1810 (arm_create_mprofile_target_description): Likewise.
1811 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1812
d105cce5
AH		 18132019-07-19 Alan Hayward <alan.hayward@arm.com>
1814
1815 * Makefile.in: Add new files.
1816 * aarch32-tdep.c: New file.
1817 * aarch32-tdep.h: New file.
1818 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1819 Call aarch32_read_description.
1820 * arch/aarch32.c: New file.
1821 * arch/aarch32.h: New file.
1822 * arch/arm.c (arm_create_target_description)
1823 (arm_create_mprofile_target_description): New function.
1824 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1825 (arm_create_target_description)
1826 (arm_create_mprofile_target_description): New declaration.
1827 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1828 read_description functions.
1829 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1830 Likewise.
1831 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1832 * arm-tdep.c (tdesc_arm_list): New variable.
1833 (arm_register_g_packet_guesses): Call create description functions.
1834 (arm_read_description) (arm_read_mprofile_description): New
1835 function.
1836 * arm-tdep.h (arm_read_description)
1837 (arm_read_mprofile_description): Add declaration.
1838 * configure.tgt: Add new files.
1839
afe09f0b
GL		 18402019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1841
1842 * top.c (new_ui_command): Open specified terminal just once.
1843
cd215b2e
TT		 18442019-07-18 Tom Tromey <tromey@adacore.com>
1845
1846 * symtab.c (main_name): Constify return type.
1847 * symfile.c (set_initial_language): Update.
1848 * symtab.h (main_name): Constify return type.
1849
d8f68fcb
TT		 18502019-07-17 Tom Tromey <tom@tromey.com>
1851
1852 * tui/tui-winsource.c (tui_update_source_window)
1853 (tui_update_source_window_as_is)
1854 (tui_update_source_windows_with_line): Remove return.
1855 * tui/tui-disasm.c (tui_show_disassem)
1856 (tui_show_disassem_and_update_source): Remove return.
1857 * tui/tui.c (tui_reset): Remove return.
1858 * tui/tui-wingeneral.c
1859 (tui_check_and_display_highlight_if_needed): Remove return.
1860
ca5af91e
TT		 18612019-07-17 Tom Tromey <tom@tromey.com>
1862
1863 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1864
5104fe36
TT		 18652019-07-17 Tom Tromey <tom@tromey.com>
1866
1867 * tui/tui-winsource.h (struct tui_exec_info_window)
1868 (struct tui_source_window_base): Move from tui-data.h.
1869 * tui/tui-winsource.c: Move many method definitions from
1870 elsewhere. Remove "structuring" comments.
1871 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1872 (tui_source_window_base::refresh_window): Move to
1873 tui-winsource.c.
1874 * tui/tui-win.c (tui_source_window_base::refresh_all)
1875 (tui_source_window_base::update_tab_width)
1876 (tui_source_window_base::set_new_height)
1877 (tui_source_window_base::do_make_visible_with_new_height): Move to
1878 tui-winsource.c.
1879 * tui/tui-source.h: Update.
1880 * tui/tui-source.c (tui_source_window_base::reset): Move to
1881 tui-winsource.c.
1882 * tui/tui-disasm.h: Update.
1883 * tui/tui-data.h (struct tui_exec_info_window): Move to
1884 tui-winsource.h.
1885 (struct tui_source_window_base): Likewise.
1886 * tui/tui-data.c (tui_source_window_base::clear_detail)
1887 (tui_source_window_base, ~tui_source_window_base): Move to
1888 tui-winsource.c.
1889
daa15dde
TT		 18902019-07-17 Tom Tromey <tom@tromey.com>
1891
1892 * tui/tui-win.c (tui_resize_all)
1893 (tui_source_window_base::update_tab_width)
1894 (tui_adjust_win_heights): Update.
1895 (tui_win_info::make_invisible_and_set_new_height): Rename from
1896 make_invisible_and_set_new_height.
1897 * tui/tui-data.h (struct tui_win_info)
1898 <make_invisible_and_set_new_height>: New method.
1899
bfad4537
TT		 19002019-07-17 Tom Tromey <tom@tromey.com>
1901
1902 * tui/tui.c: Update.
1903 * tui/tui-source.h (struct tui_source_window): Move from
1904 tui-data.h.
1905 * tui/tui-layout.c: Update.
1906 * tui/tui-disasm.c: Update.
1907 * tui/tui-data.h (struct tui_source_window): Move to
1908 tui-source.h.
1909
88f7e873
TT		 19102019-07-17 Tom Tromey <tom@tromey.com>
1911
1912 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1913 tui-data.h.
1914 * tui/tui-data.h (struct tui_disasm_window): Move to
1915 tui-disasm.h.
1916
96bd6233
TT		 19172019-07-17 Tom Tromey <tom@tromey.com>
1918
1919 * tui/tui-regs.h (struct tui_data_item_window): Move from
1920 tui-data.h.
1921 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1922 * tui/tui-data.h (struct tui_data_item_window): Move to
1923 tui-regs.h.
1924 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1925
ce38393b
TT		 19262019-07-17 Tom Tromey <tom@tromey.com>
1927
1928 * tui/tui.c: Update.
1929 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1930 (tui_cmd_window::max_height): Move to tui-command.c.
1931 * tui/tui-layout.c: Update.
1932 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1933 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1934 tui-command.c.
1935 * tui/tui-command.h (struct tui_cmd_window): Move from
1936 tui-data.h.
1937 * tui/tui-command.c: Remove "structuring" comments.
1938 (tui_cmd_window::clear_detail)
1939 (tui_cmd_window::do_make_visible_with_new_height)
1940 (tui_cmd_window::max_height): Move from elsewhere.
1941
2d8b51cb
TT		 19422019-07-17 Tom Tromey <tom@tromey.com>
1943
1944 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1945 Now static.
1946 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1947 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1948
18ab23af
TT		 19492019-07-17 Tom Tromey <tom@tromey.com>
1950
1951 * tui/tui.c: Update.
1952 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1953 tui-regs.c.
1954 * tui/tui-windata.h: Remove file.
1955 * tui/tui-windata.c: Remove file.
1956 * tui/tui-win.c (tui_data_window::set_new_height)
1957 (tui_data_window::do_make_visible_with_new_height): Move to
1958 tui-regs.c.
1959 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1960 * tui/tui-regs.c: Remove "structuring" comments.
1961 (tui_data_window::first_data_item_displayed)
1962 (tui_data_window::delete_data_content_windows)
1963 (tui_data_window::erase_data_content)
1964 (tui_data_window::display_all_data)
1965 (tui_data_window::refresh_all)
1966 (tui_data_window::do_scroll_vertical)
1967 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1968 (tui_data_window::do_make_visible_with_new_height)
1969 (tui_data_window::refresh_window): Move from elsewhere.
1970 (_initialize_tui_regs): Move to end of file.
1971 * tui/tui-layout.c: Update.
1972 * tui/tui-hooks.c: Update.
1973 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1974 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1975 tui-regs.c.
1976 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1977
88b7e7cc
TT		 19782019-07-17 Tom Tromey <tom@tromey.com>
1979
1980 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1981 seen.
1982
0fcd3711
TT		 19832019-07-17 Tom Tromey <tom@tromey.com>
1984
1985 * tui/tui-win.c (tui_source_window_base::set_new_height)
1986 (tui_source_window_base::do_make_visible_with_new_height): Use
1987 m_has_locator field directly.
1988 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1989 method.
1990 (struct tui_source_window_base) <has_locator>: Likewise.
1991
4a38112d
TT		 19922019-07-17 Tom Tromey <tom@tromey.com>
1993
1994 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1995 Don't declare.
1996 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1997 Remove.
1998 * tui/tui-win.c (tui_source_window_base::set_new_height)
1999 (tui_source_window_base::set_new_height)
2000 (make_invisible_and_set_new_height)
2001 (tui_source_window_base::do_make_visible_with_new_height)
2002 (tui_source_window_base::do_make_visible_with_new_height):
2003 Update.
2004 * tui/tui-layout.c (show_source_disasm_command, show_data)
2005 (show_source_or_disasm_and_command): Update.
2006 * tui/tui-layout.c (show_layout): Update.
2007
09129226
TT		 20082019-07-17 Tom Tromey <tom@tromey.com>
2009
2010 * tui/tui-layout.c (make_data_window): Remove.
2011 (show_data): Unify creation and re-initialization cases.
2012
4a8a5e84
TT		 20132019-07-17 Tom Tromey <tom@tromey.com>
2014
2015 * tui/tui-layout.c (make_source_window, make_disasm_window):
2016 Remove.
2017 (show_data): Unify creation and re-initialization cases.
2018
76d2be8e
TT		 20192019-07-17 Tom Tromey <tom@tromey.com>
2020
2021 * tui/tui-layout.c (make_command_window): Remove.
2022 (show_source_disasm_command, show_source_or_disasm_and_command):
2023 Unify creation and re-initialization cases.
2024
890b8bde
TT		 20252019-07-17 Tom Tromey <tom@tromey.com>
2026
2027 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2028 creation and re-initialization cases.
2029
2cdfa113
TT		 20302019-07-17 Tom Tromey <tom@tromey.com>
2031
2032 * tui/tui-regs.c (tui_get_register): Return void.
2033
8e3cfd09
TT		 20342019-07-17 Tom Tromey <tom@tromey.com>
2035
2036 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2037 Simplify.
2038
f4e04977
TT		 20392019-07-17 Tom Tromey <tom@tromey.com>
2040
2041 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2042 resetting.
2043
0379b883
TT		 20442019-07-17 Tom Tromey <tom@tromey.com>
2045
2046 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2047 * tui/tui-regs.c (tui_reg_layout): New function.
2048 (tui_show_registers, tui_reg_command): Use it.
2049 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2050 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2051 parameters.
2052 (tui_layout_command): Remove.
2053
b7fbad91
TT		 20542019-07-17 Tom Tromey <tom@tromey.com>
2055
2056 * tui/tui-layout.h (tui/tui-layout): Return void.
2057 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2058
4e1e56b9
TT		 20592019-07-17 Tom Tromey <tom@tromey.com>
2060
2061 * tui/tui-layout.c (show_source_disasm_command, show_data):
2062 Update.
2063 (reset_locator): Remove.
2064 (show_source_or_disasm_and_command): Update.
2065
1e0c09ba
TT		 20662019-07-17 Tom Tromey <tom@tromey.com>
2067
2068 * tui/tui-source.c (tui_source_window_base::reset): Remove
2069 win_type parameter.
2070 * tui/tui-layout.c (make_command_window, make_source_window)
2071 (make_disasm_window, make_data_window)
2072 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2073 (reset_locator, show_source_or_disasm_and_command): Update.
2074 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2075 win_type parameter.
2076 (struct tui_source_window_base) <reset>: Likewise.
2077
1bf605de
TT		 20782019-07-17 Tom Tromey <tom@tromey.com>
2079
2080 * tui/tui-layout.c (show_source_disasm_command): Use
2081 reset_locator.
2082 (reset_locator): New function.
2083 (init_and_make_win): Remove.
2084 (show_source_or_disasm_and_command): Use reset_locator.
2085
098f9ed4
TT		 20862019-07-17 Tom Tromey <tom@tromey.com>
2087
2088 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2089 condition.
2090 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2091 Remove condition.
2092 * tui/tui-source.c (tui_source_window_base::reset): New method.
2093 * tui/tui-layout.c (make_command_window): Don't call
2094 init_and_make_win.
2095 (make_source_window, make_disasm_window): Don't call
2096 make_source_or_disasm_window.
2097 (make_data_window): Don't call init_and_make_win. Change calling
2098 convention.
2099 (show_source_disasm_command, show_data): Simplify.
2100 (make_source_or_disasm_window): Remove.
2101 (show_source_or_disasm_and_command): Simplify.
2102 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2103 (struct tui_source_window_base) <reset>: Likewise.
2104 <execution_info>: Remove initializer.
2105 * tui/tui-data.c (tui_source_window_base): Initialize
2106 execution_info.
2107
80110957
TT		 21082019-07-17 Tom Tromey <tom@tromey.com>
2109
2110 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2111 variable.
2112
cf82af05
TT		 21132019-07-17 Tom Tromey <tom@tromey.com>
2114
2115 * tui/tui.c (tui_rl_other_window): Update.
2116 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2117 superclass method first. Always iterate over regs_content.
2118 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2119 method.
2120 * tui/tui-win.c (tui_set_focus_command): Update.
2121
01aeb396
TT		 21222019-07-17 Tom Tromey <tom@tromey.com>
2123
2124 * tui/tui-win.c (tui_set_focus_command): Rename from
2125 tui_set_focus. Call tui_enable.
2126 (tui_set_focus_command): Remove.
2127
fd6c75ee
TT		 21282019-07-17 Tom Tromey <tom@tromey.com>
2129
2130 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2131 refresh_window.
2132 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2133 touchwin.
2134 (tui_data_window::refresh_window): Call refresh_window on data
2135 items. Always call superclass refresh_window.
2136 (tui_win_info::refresh): Remove.
2137 (tui_source_window_base::refresh_window): Update.
2138 (tui_refresh_all): Update.
2139 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2140 refresh_window.
2141 (show_source_or_disasm_and_command): Likewise.
2142 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2143 (struct tui_source_window_base) <refresh>: Likewise.
2144
f6cc34a9
TT		 21452019-07-17 Tom Tromey <tom@tromey.com>
2146
2147 * tui/tui-winsource.c (tui_clear_source_content)
2148 (tui_show_source_content): Update.
2149 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2150 whether content is empty.
2151 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2152 Remove.
2153
f31ec9af
TT		 21542019-07-17 Tom Tromey <tom@tromey.com>
2155
2156 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2157 window's contents.
2158 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2159 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2160
d1b6f1e5
TT		 21612019-07-17 Tom Tromey <tom@tromey.com>
2162
2163 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2164 (struct tui_data_item_window): Update.
2165
d9743a13
TT		 21662019-07-17 Tom Tromey <tom@tromey.com>
2167
2168 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2169 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2170 defines.
2171
caf0bc4e
TT		 21722019-07-17 Tom Tromey <tom@tromey.com>
2173
2174 * tui/tui-winsource.h (tui_erase_source_content)
2175 (tui_clear_source_content): Remove "display_prompt" parameter.
2176 * tui/tui-winsource.c (tui_update_source_window_as_is)
2177 (tui_update_source_windows_with_addr): Update.
2178 (tui_clear_source_content): Remove "display_prompt" parameter.
2179 (tui_erase_source_content): Likewise. Simplify.
2180 (tui_show_source_content): Update.
2181 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2182 * tui/tui-stack.c (tui_show_frame_info): Update.
2183 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2184 Remove defines.
2185
9d391078
TT		 21862019-07-17 Tom Tromey <tom@tromey.com>
2187
2188 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2189 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2190 parameter.
2191 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2192 parameter.
2193
a38da35d
TT		 21942019-07-17 Tom Tromey <tom@tromey.com>
2195
2196 * tui/tui-winsource.c (tui_clear_source_content)
2197 (tui_show_source_content, tui_show_exec_info_content)
2198 (tui_clear_exec_info_content): Update.
2199 * tui/tui-stack.c (tui_show_locator_content): Update.
2200 (tui_show_frame_info): Update.
2201 * tui/tui-source.h (tui_source_window): Don't declare.
2202 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2203 from tui_source_is_displayed.
2204 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2205 Remove field.
2206 (struct tui_source_window_base) <content_in_use>: New field. Now
2207 bool.
2208 (struct tui_source_window) <showing_source_p>: New method.
2209 (TUI_SRC_WIN): Change cast.
2210 * tui/tui-data.c (tui_initialize_static_data): Update.
2211
c2cd8994
TT		 22122019-07-17 Tom Tromey <tom@tromey.com>
2213
2214 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2215 location_matches_p.
2216 * tui/tui-source.c (tui_source_window::location_matches_p): New
2217 method.
2218 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2219 method.
2220 * tui/tui-data.h (struct tui_source_window_base)
2221 <location_matches_p>: New method.
2222 (struct tui_source_window, struct tui_disasm_window)
2223 <location_matches_p>: Likewise.
2224
4dde7b34
TT		 22252019-07-17 Tom Tromey <tom@tromey.com>
2226
2227 * tui/tui-win.c (tui_set_win_height_command): Rename from
2228 tui_set_win_height.
2229 (tui_set_win_height_command): Remove.
2230
b73dd877
TT		 22312019-07-17 Tom Tromey <tom@tromey.com>
2232
2233 * tui/tui-source.c (tui_source_window): New constructor. Add
2234 observer.
2235 (~tui_source_window): New destructor.
2236 (tui_source_window::style_changed): New method.
2237 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2238 (tui_attach_detach_observers): Update.
2239 * tui/tui-data.h (struct tui_source_window): Make constructor not
2240 inline. Add destructor.
2241 (struct tui_source_window) <style_changed>: New method.
2242 <m_observable>: New member.
2243
ae2b5380
TT		 22442019-07-17 Tom Tromey <tom@tromey.com>
2245
2246 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2247 * tui/tui-win.c (tui_resize_all): Fix typo.
2248
1ce3e844
TT		 22492019-07-17 Tom Tromey <tom@tromey.com>
2250
2251 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2252 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2253 (tui_refresh_all): Remove "list" parameter. Use foreach.
2254 * tui/tui-win.c (window_name_completer): Use foreach.
2255 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2256 (update_tab_width): Likewise.
2257 * tui/tui-layout.c (show_layout): Update.
2258 * tui/tui-data.h (class tui_window_iterator): New.
2259 (struct all_tui_windows): New.
2260 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2261
fe3eaf1c
TT		 22622019-07-17 Tom Tromey <tom@tromey.com>
2263
2264 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2265 parameter. Don't reference globals.
2266 (tui_reg_command): Update.
2267
368c1354
TT		 22682019-07-17 Tom Tromey <tom@tromey.com>
2269
2270 * tui/tui-regs.c (tui_show_registers): Simplify.
2271
e80cd204
TT		 22722019-07-17 Tom Tromey <tom@tromey.com>
2273
2274 * tui/tui-regs.c (tui_show_registers): Update.
2275 (tui_show_register_group): Add win_info parameter.
2276
aca2dd16
TT		 22772019-07-17 Tom Tromey <tom@tromey.com>
2278
2279 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2280 Rename from tui_display_reg_element_at_line.
2281 (tui_data_window::display_registers_from_line): Update.
2282 * tui/tui-data.h (struct tui_data_window)
2283 <display_reg_element_at_line>: New method.
2284
517e9505
TT		 22852019-07-17 Tom Tromey <tom@tromey.com>
2286
2287 * tui/tui-regs.h (tui_display_registers_from)
2288 (tui_display_registers_from_line): Don't declare.
2289 * tui/tui-windata.c (tui_data_window::display_all_data)
2290 (tui_data_window::refresh_all)
2291 (tui_data_window::do_scroll_vertical): Update.
2292 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2293 from tui_display_registers_from.
2294 (tui_display_reg_element_at_line): Update.
2295 (tui_data_window::display_registers_from_line): Rename from
2296 tui_display_registers_from_line.
2297 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2298 display_registers_from_line>: New methods.
2299
f76d8b19
TT		 23002019-07-17 Tom Tromey <tom@tromey.com>
2301
2302 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2303 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2304 from tui_erase_data_content.
2305 (tui_data_window::display_all_data)
2306 (tui_data_window::refresh_all)
2307 (tui_data_window::do_scroll_vertical): Update.
2308 * tui/tui-regs.c (tui_show_registers): Update.
2309 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2310 New method.
2311
b4094625
TT		 23122019-07-17 Tom Tromey <tom@tromey.com>
2313
2314 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2315 declare.
2316 * tui/tui-windata.c
2317 (tui_data_window::delete_data_content_windows): Rename from
2318 tui_delete_data_content_windows.
2319 (tui_data_window::display_all_data)
2320 (tui_data_window::do_scroll_vertical): Update.
2321 * tui/tui-data.h (struct tui_data_window)
2322 <delete_data_content_windows>: New method.
2323
c223a729
TT		 23242019-07-17 Tom Tromey <tom@tromey.com>
2325
2326 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2327 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2328
50daf268
TT		 23292019-07-17 Tom Tromey <tom@tromey.com>
2330
2331 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2332 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2333 from tui_display_all_data.
2334 * tui/tui-win.c
2335 (tui_data_window::do_make_visible_with_new_height): Update.
2336 * tui/tui-regs.c (tui_show_registers): Update.
2337 * tui/tui-layout.c (tui_set_layout): Update.
2338 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2339 method.
2340
df5f8cab
TT		 23412019-07-17 Tom Tromey <tom@tromey.com>
2342
2343 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2344 * tui/tui-windata.c (tui_display_data_from): Remove.
2345 (tui_data_window::refresh_all): Update.
2346
80cb6c27
TT		 23472019-07-17 Tom Tromey <tom@tromey.com>
2348
2349 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2350 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2351 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2352 tui_display_registers_from_line.
2353 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2354 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2355 "force_display" parameter.
2356
baff0c28
TT		 23572019-07-17 Tom Tromey <tom@tromey.com>
2358
2359 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2360 declare.
2361 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2362 Rename from tui_first_reg_element_no_inline.
2363 (tui_display_reg_element_at_line)
2364 (tui_display_registers_from_line): Update.
2365 * tui/tui-data.h (struct tui_data_window)
2366 <first_reg_element_no_inline>: New method.
2367
3b23c5f2
TT		 23682019-07-17 Tom Tromey <tom@tromey.com>
2369
2370 * tui/tui-windata.c (tui_display_data_from)
2371 (tui_data_window::do_scroll_vertical): Update.
2372 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2373 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2374 Rename from tui_line_from_reg_element_no.
2375 (tui_display_registers_from_line): Update.
2376 * tui/tui-data.h (struct tui_data_window)
2377 <line_from_reg_element_no>: New method.
2378
0b5ec218
TT		 23792019-07-17 Tom Tromey <tom@tromey.com>
2380
2381 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2382 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2383 tui_last_regs_line_no.
2384 (tui_display_reg_element_at_line)
2385 (tui_display_registers_from_line): Update.
2386 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2387 method.
2388
0807ab7b
TT		 23892019-07-17 Tom Tromey <tom@tromey.com>
2390
2391 PR tui/24722:
2392 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2393 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2394 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2395 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2396 (tui_update_breakpoint_info): Likewise.
2397 * tui/tui-hooks.c (tui_event_create_breakpoint)
2398 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2399 Update.
2400
9ad7fdef
TT		 24012019-07-17 Tom Tromey <tom@tromey.com>
2402
2403 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2404
5813316f
TT		 24052019-07-17 Tom Tromey <tom@tromey.com>
2406
2407 * tui/tui-winsource.c (tui_update_source_window_as_is)
2408 (tui_update_source_windows_with_addr): Update.
2409 * tui/tui-source.h (tui_set_source_content)
2410 (tui_show_symtab_source): Add "win_info" parameter.
2411 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2412 parameter.
2413 (tui_show_symtab_source): Likewise.
2414
00e264e7
TT		 24152019-07-17 Tom Tromey <tom@tromey.com>
2416
2417 * tui/tui-wingeneral.c
2418 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2419
06210ce4
TT		 24202019-07-17 Tom Tromey <tom@tromey.com>
2421
2422 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2423 (struct tui_cmd_window) <can_scroll>: New method.
2424 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2425 method.
2426
381befee
TT		 24272019-07-17 Tom Tromey <tromey@adacore.com>
2428
2429 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2430 do_field_signed>: Rename. Change type of "value".
2431 * ui-out.c (ui_out::field_signed): Rename from field_int.
2432 Change type of "value".
2433 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2434 type of "value".
2435 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2436 do_field_int. Change type of "value".
2437 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2438 do_field_int. Change type of "value".
2439 * tracepoint.c (trace_status_mi, tfind_1)
2440 (print_one_static_tracepoint_marker): Update.
2441 * thread.c (print_thread_info_1, print_selected_thread_frame):
2442 Update.
2443 * stack.c (print_frame, print_frame_info): Update.
2444 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2445 Update.
2446 * source.c (print_source_lines_base): Update.
2447 * skip.c (info_skip_command): Update.
2448 * record-btrace.c (btrace_ui_out_decode_error)
2449 (btrace_call_history_src_line): Update.
2450 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2451 Update.
2452 * progspace.c (print_program_space): Update.
2453 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2454 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2455 do_field_int. Change type of "value".
2456 * mi/mi-out.c (mi_ui_out::do_table_begin)
2457 (mi_ui_out::do_table_header): Update.
2458 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2459 type of "value".
2460 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2461 (mi_cmd_data_list_changed_registers, output_register)
2462 (mi_cmd_data_read_memory, mi_load_progress)
2463 (mi_cmd_trace_frame_collected): Update.
2464 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2465 Update.
2466 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2467 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2468 (mi_cmd_var_list_children, varobj_update_one): Update.
2469 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2470 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2471 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2472 * inferior.c (print_inferior): Update.
2473 * gdb_bfd.c (print_one_bfd): Update.
2474 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2475 Update.
2476 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2477 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2478 do_field_int. Change type of "value".
2479 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2480 do_field_int. Change type of "value".
2481 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2482 (print_one_breakpoint_location, print_it_catch_fork)
2483 (print_one_catch_fork, print_it_catch_vfork)
2484 (print_one_catch_vfork, print_it_catch_solib)
2485 (print_it_catch_exec, print_it_ranged_breakpoint)
2486 (print_mention_watchpoint, print_mention_masked_watchpoint)
2487 (bkpt_print_it, update_static_tracepoint): Update.
2488 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2489 * break-catch-syscall.c (print_it_catch_syscall): Update.
2490 * ada-tasks.c (print_ada_task_info): Update.
2491 * ada-lang.c (print_it_exception, print_mention_exception):
2492 Update.
2493
6b78c3f8
AB		 24942019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2495
2496 PR breakpoints/24541
2497 * gdbarch.c: Regenerate.
2498 * gdbarch.h: Regenerate.
2499 * gdbarch.sh: Adjust return type and parameter types for
2500 'stap_adjust_register'.
2501 (i386_stap_adjust_register): Adjust signature and return new
2502 register name.
2503 * stap-probe.c (stap_parse_register_operand): Adjust use of
2504 'gdbarch_stap_adjust_register'.
2505
d72a9b85
TT		 25062019-07-17 Tom Tromey <tromey@adacore.com>
2507
2508 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2509 declare VEC.
2510 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2511 std::vector.
2512 (struct s390_process_info): Add initializers.
2513 (s390_add_process): Use new.
2514 (s390_linux_nat_target::low_forget_process): Use delete.
2515 (s390_linux_nat_target::low_new_fork)
2516 (s390_linux_nat_target::stopped_by_watchpoint)
2517 (s390_linux_nat_target::low_prepare_to_resume)
2518 (s390_linux_nat_target::insert_watchpoint)
2519 (s390_linux_nat_target::insert_hw_breakpoint)
2520 (s390_linux_nat_target::remove_watchpoint)
2521 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2522
206e6c58
JB		 25232019-07-16 John Baldwin <jhb@FreeBSD.org>
2524
2525 * aarch64-fbsd-nat.c: Include regcache.h.
2526 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2527 argument.
2528 (aarch64_fbsd_nat_target::fetch_registers)
2529 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2530 variable.
2531 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2532
cbde90f2
JB		 25332019-07-16 John Baldwin <jhb@FreeBSD.org>
2534
2535 * fbsd-nat.c: Include gdbarch.h.
2536
07128006
TT		 25372019-07-15 Tom Tromey <tromey@adacore.com>
2538
2539 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2540
1f77b012
TT		 25412019-07-15 Tom Tromey <tromey@adacore.com>
2542
2543 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2544 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2545 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2546 * cli-out.c (cli_ui_out::do_field_int): New method.
2547 * ui-out.c (ui_out::field_unsigned): New method.
2548 * symfile.c (generic_load): Use field_unsigned.
2549 (print_transfer_performance): Likewise.
2550 * record-btrace.c (ui_out_field_uint): Remove.
2551 (btrace_call_history_insn_range, btrace_call_history): Use
2552 field_unsigned.
2553 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2554 field_unsigned.
2555 * ui-out.h (class ui_out) <field_unsigned>: New method.
2556 <do_field_unsigned>: Likewise.
2557
33eca680
TT		 25582019-07-15 Tom Tromey <tromey@adacore.com>
2559
2560 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2561 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2562 * target.c (flash_erase_command): Use field_string.
2563 * infrun.c (print_signal_received_reason): Use field_string.
2564 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2565 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2566 field_string.
2567 * ada-tasks.c (print_ada_task_info): Use field_string.
2568
ca8d69be
TT		 25692019-07-15 Tom Tromey <tromey@adacore.com>
2570
2571 * target.c (flash_erase_command): Use field_core_addr.
2572 * symfile.c (generic_load): Use field_core_addr.
2573 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2574 Use field_core_addr.
2575 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2576 field_core_addr.
2577
0d4e84ed
AB		 25782019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2579
2580 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2581 value if its desired type is smaller than a CORE_ADDR and signed.
2582
9a49df9d
AB		 25832019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2584
2585 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2586 of changes to field names, and use new is_reference field to
2587 decide if a property is a reference or not.
2588 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2589 field.
2590 (struct dwarf2_property_baton): Update header comment, rename
2591 'referenced_type' to 'property_type' and update comments.
2592 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2593 default property type, store in property baton, update to take
2594 accound of renamed field.
2595 (read_func_scope): Update call to attr_to_dynamic_prop.
2596 (read_array_type): Likewise.
2597 (dwarf2_per_cu_addr_sized_int_type): New function.
2598 (read_subrange_index_type): Move type finding code to
2599 dwarf2_per_cu_addr_sized_int_type.
2600 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2601 (dwarf2_per_cu_addr_type): New function.
2602 (set_die_type): Update calls to attr_to_dynamic_prop.
2603
b86352cf
AB		 26042019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2605
2606 * dwarf2read.c (read_subrange_index_type): New function.
2607 (read_subrange_type): Move code into new function and call it.
2608 * gdbtypes.c (create_range_type): Add some asserts.
2609
603490bf
AB		 26102019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2611
2612 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2613 update return statements.
2614 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2615 declaration, and update comment to match.
2616 * gdbtypes.c (resolve_dynamic_array): Update call to
2617 dwarf2_evaluate_property to match new return type.
2618
592f9d27
AB		 26192019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2620
2621 * valarith.c (value_subscripted_rvalue): Change lowerbound
2622 parameter type from int to LONGEST.
2623 * value.h (value_subscripted_rvalue): Likewise in declaration.
2624
60cfcb20
AB		 26252019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2626
2627 * cli/cli-utils.c (info_print_command_completer): New function.
2628 * cli/cli-utils.h: Add 'completer.h' include, and forward
2629 declaration for 'struct cmd_list_element'.
2630 (info_print_command_completer): Declare.
2631 * stack.c (_initialize_stack): Add completer for 'info locals' and
2632 'info args'.
2633 * symtab.c (_initialize_symtab): Add completer for 'info
2634 variables' and 'info functions'.
2635 * NEWS: Mention completion for additional info commands.
2636
b16507e0
AB		 26372019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2638
2639 * cli/cli-utils.c (extract_info_print_args): Delete.
2640 (extract_arg_maybe_quoted): Delete.
2641 (info_print_options_defs): New variable.
2642 (make_info_print_options_def_group): New function.
2643 (extract_info_print_options): Define new function.
2644 * cli/cli-utils.h (extract_info_print_args): Delete.
2645 (struct info_print_options): New structure.
2646 (extract_info_print_options): Declare new function.
2647 * stack.c (info_locals_command): Update to use new
2648 extract_info_print_options, also add a header comment.
2649 (info_args_command): Likewise.
2650 * symtab.c (info_variables_command): Likewise.
2651 (info_functions_command): Likewise.
2652
021d8588
AB		 26532019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2654
2655 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2656 to extract string arguments.
2657 * common/common-utils.c (extract_string_maybe_quoted): New function.
2658 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2659
b777eb6d
TT		 26602019-07-11 Tom Tromey <tromey@adacore.com>
2661
2662 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2663 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2664 * top.h (gdbinit): Don't declare.
2665 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2666 into...
2667 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2668 * top.c (gdb_init): Don't call init_cli_cmds.
2669 (gdbinit): Remove.
2670 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2671
72ee03ff
TT		 26722019-07-11 Tom Tromey <tromey@adacore.com>
2673
2674 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2675 after it has been moved.
2676
00db9531
SM		 26772019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2678
2679 * valops.c (value_must_coerce_to_target): Change return type to
2680 bool.
2681 * value.h (value_must_coerce_to_target): Likewise.
2682
f2478a7e
SM		 26832019-07-10 Simon Marchi <simon.marchi@efficios.com>
2684
2685 * breakpoint.c (is_hardware_watchpoint): Remove
2686 forward-declaration.
2687 (is_masked_watchpoint): Change return type to bool.
2688 (is_tracepoint): Likewise.
2689 (is_breakpoint): Likewise.
2690 (is_hardware_watchpoint): Likewise.
2691 (is_watchpoint): Likewise.
2692 (is_no_memory_software_watchpoint): Likewise.
2693 (is_catchpoint): Likewise.
2694 (breakpoint_1): Make FILTER parameter's return type bool.
2695 is_masked_watchpoint): Change return type to bool.
2696 (save_breakpoints): Make FILTER parameter's return type bool.
2697 * breakpoint.h (is_breakpoint): Change return type to bool.
2698 (is_watchpoint): Likewise.
2699 (is_catchpoint): Likewise.
2700 (is_tracepoint): Likewise.
2701
0d12e84c
TT		 27022019-07-10 Tom Tromey <tom@tromey.com>
2703
2704 * defs.h: Don't include gdbarch.h.
2705 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2706 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2707 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2708 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2709 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2710 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2711 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2712 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2713 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2714 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2715 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2716 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2717 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2718 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2719 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2720 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2721 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2722 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2723 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2724 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2725 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2726 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2727 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2728 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2729 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2730 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2731 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2732
f06f1252
TT		 27332019-07-10 Tom Tromey <tromey@adacore.com>
2734
2735 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2736 * breakpoint.c (init_ada_exception_breakpoint): Register as
2737 bp_catchpoint.
2738 (print_one_breakpoint_location, print_one_breakpoint): Use
2739 is_ada_exception_catchpoint.
2740 * ada-lang.c (class ada_catchpoint_location): Pass
2741 bp_loc_software_breakpoint to bp_location constructor.
2742 (is_ada_exception_catchpoint): New function.
2743
7a5d944b
TT		 27442019-07-10 Tom Tromey <tromey@adacore.com>
2745
2746 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2747 VEC.
2748 (struct arm_exidx_entry): New method operator<.
2749 (struct arm_exidx_data) <section_maps>: Change type.
2750 (arm_exidx_data_free): Remove.
2751 (arm_exidx_data_key): Change type. Move lower.
2752 (arm_exidx_new_objfile): Update.
2753 (arm_compare_exidx_entries): Remove.
2754 (arm_find_exidx_entry, _initialize_arm_tdep)
2755
48c66e1d
TT		 27562019-07-10 Tom Tromey <tromey@adacore.com>
2757
2758 * solib-spu.c (ocl_program_data_key): Change type.
2759 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2760 Update.
2761
a269fbf1
TT		 27622019-07-10 Tom Tromey <tromey@adacore.com>
2763
2764 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2765 (struct solib_aix_inferior_data) <library_list>: Change type.
2766 (solib_aix_inferior_data_handle): Change type.
2767 (get_solib_aix_inferior_data): Update.
2768 (solib_aix_free_library_list): Remove.
2769 (library_list_start_library): Update.
2770 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2771 return type.
2772 (solib_aix_get_library_list)
2773 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2774 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2775
c294730c
TT		 27762019-07-10 Tom Tromey <tromey@adacore.com>
2777
2778 * solib-dsbt.c (struct dsbt_info): Add initializers.
2779 (solib_dsbt_pspace_data): Change type.
2780 (dsbt_pspace_data_cleanup): Remove.
2781 (get_dsbt_info, _initialize_dsbt_solib): Update.
2782
9d52077d
TT		 27832019-07-10 Tom Tromey <tromey@adacore.com>
2784
2785 * spu-tdep.c (spu_overlay_data): Change type.
2786 (spu_get_overlay_table, spu_overlay_new_objfile)
2787 (_initialize_spu_tdep): Update.
2788
22a20dca
TT		 27892019-07-10 Tom Tromey <tromey@adacore.com>
2790
2791 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2792 destructor.
2793 (dbx_objfile_data_key): Change type and declare later.
2794 (DBX_SYMFILE_INFO): Rewrite.
2795 * dbxread.c (dbx_objfile_data_key): Change type.
2796 (dbx_symfile_init): Update.
2797 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2798 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2799 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2800
cb60f420
TT		 28012019-07-10 Tom Tromey <tromey@adacore.com>
2802
2803 * jit.c (jit_program_space_key): Change type. Move lower.
2804 (get_jit_program_space_data): Update.
2805 (jit_program_space_data_cleanup): Remove.
2806 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2807 Update.
2808 (struct jit_program_space_data): Add initializers.
2809
51df2ae3
TT		 28102019-07-10 Tom Tromey <tromey@adacore.com>
2811
2812 * solib-darwin.c (struct darwin_info): Add initializers.
2813 (solib_darwin_pspace_data): Change type.
2814 (darwin_pspace_data_cleanup): Remove.
2815 (get_darwin_info, _initialize_darwin_solib): Update.
2816
18101a35
TT		 28172019-07-10 Tom Tromey <tromey@adacore.com>
2818
2819 * remote-sim.c (struct sim_inferior_data): Add initializers,
2820 constructor, and destructor.
2821 (sim_inferior_data_key): Change type. Move lower.
2822 (check_for_duplicate_sim_descriptor): Update.
2823 (get_sim_inferior_data): Use new. Update.
2824 (~sim_inferior_data_cleanup): Rename from
2825 sim_inferior_data_cleanup. Simplify.
2826 (gdbsim_close_inferior, simulator_command)
2827 (sim_command_completer, _initialize_remote_sim): Update.
2828 (next_pid, INITIAL_PID): Move earlier.
2829
05b08ac1
TT		 28302019-07-10 Tom Tromey <tromey@adacore.com>
2831
2832 * python/python-internal.h (create_thread_object): Return
2833 gdbpy_ref.
2834 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2835 * python/py-inferior.c (struct threadlist_entry): Add
2836 constructor.
2837 <thread_obj>: Now a gdbpy_ref.
2838 (thread_to_thread_object): Update.
2839 (add_thread_object): Use new.
2840 (delete_thread_object): Use delete.
2841 (infpy_threads): Update.
2842 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2843 GIL.
2844
32372d80
TT		 28452019-07-10 Tom Tromey <tromey@adacore.com>
2846
2847 * valops.c (value_cast): Specialize error message for Ada.
2848
5c458ae8
SM		 28492019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2850
2851 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2852
4c462cb0
SM		 28532019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2854
2855 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2856 bpstat_should_step): Return bool, adjust comments.
2857 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2858 bpstat_should_step): Likewise.
2859
89abbcc2
AH		 28602019-07-10 Alan Hayward <alan.hayward@arm.com>
2861
2862 * features/Makefile: Use feature target descriptions for Arm.
2863 * features/arm/arm-core.c: Generate new file.
2864 * features/arm/arm-fpa.c: Likewise.
2865 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2866 * features/arm/arm-m-profile.c: Likewise.
2867 * features/arm/arm-vfpv2.c: Likewise.
2868 * features/arm/arm-vfpv3.c: Likewise.
2869 * features/arm/xscale-iwmmxt.c: Likewise.
2870 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2871
166a82be
AH		 28722019-07-10 Alan Hayward <alan.hayward@arm.com>
2873
2874 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2875 ptrace earlier.
2876
9fb4c7e9
AH		 28772019-07-10 Alan Hayward <alan.hayward@arm.com>
2878
2879 * features/aarch64-pauth.c: Regenerate.
2880
e2d0f980
SM		 28812019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2882
2883 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2884 bool.
2885 (bpstat_what): Use false instead of 0.
2886
a38118e5
PA		 28872019-07-09 Pedro Alves <palves@redhat.com>
2888
2889 * break-catch-throw.c (is_exception_catchpoint): New.
2890 * breakpoint.c (print_one_breakpoint_location): New parameter
2891 'raw_loc'. Handle it. Use
2892 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2893 looking at the breakpoint's type.
2894 (print_one_breakpoint): If handling "maint info breakpoints", also
2895 print locations of exception catchpoints.
2896 * breakpoint.h (is_exception_catchpoint): Declare.
2897
cb1e4e32
PA		 28982019-07-09 Pedro Alves <palves@redhat.com>
2899
2900 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2901 "addr" field.
2902 (allocate_location_exception_catchpoint): New.
2903 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2904 (initialize_throw_catchpoint_ops): Install
2905 allocate_location_exception_catchpoint as allocate_location
2906 method.
2907 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2908 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2909 bp_loc_other.
2910 (breakpoint_address_is_meaningful): Delete.
2911 (bl_address_is_meaningful): New.
2912 (breakpoint_locations_match): Adjust comment.
2913 (bp_location_from_bp_type): New, factored out of...
2914 (bp_location::bp_location(breakpoint *)): ... this.
2915 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2916 factored out of...
2917 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2918 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2919 breakpoint_address_is_meaningful.
2920 (bp_locations_compare): Adjust comment.
2921 (update_global_location_list): Use bl_address_is_meaningful
2922 instead of breakpoint_address_is_meaningful.
2923 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2924 explicit.
2925 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2926 * python/py-breakpoint.c (bppy_get_location): No longer check
2927 whether location is null.
2928
b58a68fe
PA		 29292019-07-09 Pedro Alves <palves@redhat.com>
2930
2931 PR c++/15468
2932 * breakpoint.c (print_one_breakpoint_location): Remove
2933 single-location assert.
2934
268a13a5
TT		 29352019-07-09 Tom Tromey <tom@tromey.com>
2936
2937 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2938 * configure: Rebuild.
2939 * configure.ac: Change common to gdbsupport.
2940 * gdbsupport: Rename from common.
2941 * acinclude.m4: Change common to gdbsupport.
2942 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2943 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2944 gdbsupport.
2945 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2946 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2947 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2948 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2949 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2950 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2951 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2952 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2953 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2954 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2955 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2956 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2957 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2958 coff-pe-read.c, command.h, compile/compile-c-support.c,
2959 compile/compile-c.h, compile/compile-cplus-symbols.c,
2960 compile/compile-cplus-types.c, compile/compile-cplus.h,
2961 compile/compile-loc2c.c, compile/compile.c, completer.c,
2962 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2963 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2964 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2965 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2966 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2967 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2968 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2969 features/aarch64-core.c, features/aarch64-fpu.c,
2970 features/aarch64-pauth.c, features/aarch64-sve.c,
2971 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2972 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2973 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2974 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2975 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2976 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2977 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2978 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2979 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2980 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2981 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2982 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2983 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2984 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2985 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2986 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2987 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2988 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2989 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2990 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2991 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2992 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2993 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2994 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2995 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2996 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2997 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2998 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2999 minsyms.c, mips-linux-tdep.c, namespace.h,
3000 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3001 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3002 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3003 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3004 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3005 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3006 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3007 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3008 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3009 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3010 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3011 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3012 procfs.c, producer.c, progspace.h, psymtab.h,
3013 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3014 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3015 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3016 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3017 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3018 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3019 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3020 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3021 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3022 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3023 target-memory.c, target.c, target.h, target/waitstatus.c,
3024 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3025 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3026 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3027 unittests/array-view-selftests.c,
3028 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3029 unittests/common-utils-selftests.c,
3030 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3031 unittests/format_pieces-selftests.c,
3032 unittests/function-view-selftests.c,
3033 unittests/lookup_name_info-selftests.c,
3034 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3035 unittests/mkdir-recursive-selftests.c,
3036 unittests/observable-selftests.c,
3037 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3038 unittests/parse-connection-spec-selftests.c,
3039 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3040 unittests/scoped_fd-selftests.c,
3041 unittests/scoped_mmap-selftests.c,
3042 unittests/scoped_restore-selftests.c,
3043 unittests/string_view-selftests.c, unittests/style-selftests.c,
3044 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3045 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3046 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3047 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3048 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3049 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3050
5b0e2db4
AB		 30512019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3052
3053 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3054 bool value.
3055 (decode_digits_ordinary): Set explicit_line field in sal.
3056 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3057 symtab_and_line that was set on an explicit line number in
3058 assembler code. Do always update the recorded symtab and line if
3059 we do skip the prologue.
3060
0ba852ab
AB		 30612019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3062
3063 * breakpoint.c (set_breakpoint_location_function): Remove
3064 explicit_loc parameter.
3065 (momentary_breakpoint_from_master): Update call to
3066 set_breakpoint_location_function.
3067 (add_location_to_breakpoint): Likewise.
3068
b3a7d171
AB		 30692019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3070
3071 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3072 required features based on default bfd type when no specific bfd
3073 is present.
3074
1f6f6e21
PW		 30752019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3076
3077 * NEWS: Mention that GDB printf and eval commands can now print
3078 C-style and Ada-style convenience var strings without
3079 calling the inferior.
3080 * printcmd.c (printf_c_string): Locally print GDB internal var
3081 instead of transiting via the inferior.
3082 (printf_wide_c_string): Likewise.
3083
30842019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH		 3085
3086 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3087
0598af48
TT		 30882019-07-04 Tom Tromey <tom@tromey.com>
3089
3090 PR tui/24724:
3091 * tui/tui-winsource.c (tui_clear_source_content): Update.
3092 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3093 (tui_update_breakpoint_info): Update.
3094 (tui_set_exec_info_content): Update.
3095 * tui/tui-source.c (tui_set_source_content_nil): Update.
3096 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3097 has_break.
3098 * tui/tui-data.h (enum tui_bp_flag): New.
3099 (tui_bp_flags): New enum flags type.
3100 (struct tui_source_element) <break_mode>: Change type. Rename
3101 from has_break.
3102 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3103 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3104 constants.
3105 * tui/tui-winsource.h: Fix comment.
3106
350fab54
AH		 31072019-07-04 Alan Hayward <alan.hayward@arm.com>
3108
3109 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3110 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3111 (store_fpregs_to_thread)
3112 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3113 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3114 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3115 (IWMMXT_REGS_SIZE): Add define.
3116 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3117 (fetch_vfp_regs, store_vfp_regs)
3118 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3119 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3120
f0452268
AH		 31212019-07-04 Alan Hayward <alan.hayward@arm.com>
3122
3123 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3124 defines.
3125 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3126 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3127 (ARM_INT_REGISTER_SIZE): ...to this.
3128 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3129 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3130 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3131 (arm_linux_collect_gregset, supply_nwfpe_register)
3132 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3133 defines.
3134 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3135 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3136 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3137 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3138 (arm_return_in_memory, arm_store_return_value)
3139 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3140 (arm_record_ld_st_multiple): Likewise.
3141 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3142 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3143
e935475c
AH		 31442019-07-04 Alan Hayward <alan.hayward@arm.com>
3145
3146 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3147 AARCH64_DISPLACED_MODIFIED_INSNS.
3148 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3149 (aarch64_displaced_step_copy_insn): Likewise.
3150 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3151 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3152 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3153 ARM_DISPLACED_MODIFIED_INSNS.
3154 * arm-tdep.c (arm_gdbarch_init): Likewise.
3155 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3156 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3157 (struct arm_displaced_step_closure): Use
3158 ARM_DISPLACED_MODIFIED_INSNS.
3159
df0bb381
AH		 31602019-07-04 Alan Hayward <alan.hayward@arm.com>
3161
3162 * features/Makefile: Remove unused xml files.
3163 * features/aarch64.xml: Remove.
3164 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3165 * features/i386/amd64-avx-avx512.xml: Remove.
3166 * features/i386/amd64-avx-linux.xml: Remove.
3167 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3168 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3169 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3170 * features/i386/amd64-avx-mpx.xml: Remove.
3171 * features/i386/amd64-avx.xml: Remove.
3172 * features/i386/amd64-linux.xml: Remove.
3173 * features/i386/amd64-mpx-linux.xml: Remove.
3174 * features/i386/amd64-mpx.xml: Remove.
3175 * features/i386/amd64.xml: Remove.
3176 * features/i386/i386-avx-avx512-linux.xml: Remove.
3177 * features/i386/i386-avx-avx512.xml: Remove.
3178 * features/i386/i386-avx-linux.xml: Remove.
3179 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3180 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3181 * features/i386/i386-avx-mpx-linux.xml: Remove.
3182 * features/i386/i386-avx-mpx.xml: Remove.
3183 * features/i386/i386-avx.xml: Remove.
3184 * features/i386/i386-linux.xml: Remove.
3185 * features/i386/i386-mmx-linux.xml: Remove.
3186 * features/i386/i386-mmx.xml: Remove.
3187 * features/i386/i386-mpx-linux.xml: Remove.
3188 * features/i386/i386-mpx.xml: Remove.
3189 * features/i386/i386.xml: Remove.
3190 * features/i386/x32-avx-avx512-linux.xml: Remove.
3191 * features/i386/x32-avx-linux.xml: Remove.
3192 * features/i386/x32-linux.xml: Remove.
3193
edd6266a
AH		 31942019-07-04 Alan Hayward <alan.hayward@arm.com>
3195
3196 * regformats/aarch64.dat: Remove.
3197 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3198 * regformats/i386/amd64-avx-linux.dat: Remove.
3199 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3200 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3201 * regformats/i386/amd64-linux.dat: Remove.
3202 * regformats/i386/amd64-mpx-linux.dat: Remove.
3203 * regformats/i386/amd64.dat: Remove.
3204 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3205 * regformats/i386/i386-avx-linux.dat: Remove.
3206 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3207 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3208 * regformats/i386/i386-linux.dat: Remove.
3209 * regformats/i386/i386-mmx-linux.dat: Remove.
3210 * regformats/i386/i386-mpx-linux.dat: Remove.
3211 * regformats/i386/i386.dat: Remove.
3212 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3213 * regformats/i386/x32-avx-linux.dat: Remove.
3214 * regformats/i386/x32-linux.dat: Remove.
3215
2b40fda7
AH		 32162019-07-04 Alan Hayward <alan.hayward@arm.com>
3217
3218 * aarch64-tdep.c: Remove xml self tests.
3219 * amd64-linux-tdep.c: Likewise.
3220 * amd64-tdep.c: Likewise.
3221 * i386-linux-tdep.c: Likewise.
3222 * i386-tdep.c: Likewise.
3223
5f4ba3e7
PA		 32242019-07-03 Pedro Alves <palves@redhat.com>
3225
3226 PR cli/24732
3227 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3228 (pipe_cmd_option_defs): New.
3229 (make_pipe_cmd_options_def_group): New.
3230 (pipe_command): Use gdb::option::process_options.
3231 (pipe_command_completer): New function.
3232 (_initialize_cli_cmds): Install completer for "pipe" command.
3233
3d9be6f5
PA		 32342019-07-03 Pedro Alves <palves@redhat.com>
3235
3236 * cli/cli-option.c (union option_value) <string>: New field.
3237 (struct option_def_and_value): Add ctor, move ctor, dtor and
3238 use DISABLE_COPY_AND_ASSIGN.
3239 (option_def_and_value::clear_value): New.
3240 (parse_option, save_option_value_in_ctx, get_val_type_str)
3241 (add_setshow_cmds_for_options): Handle var_string.
3242 * cli-option.h (union option_def::var_address) <string>: New
3243 field.
3244 (struct string_option_def): New.
3245 * maint-test-options.c (struct test_options_opts): Add default
3246 ctor and use DISABLE_COPY_AND_ASSIGN.
3247 <string_opt>: New field.
3248 (test_options_opts::~test_options_opts): New.
3249 (test_options_opts::dump): Also dump "-string".
3250 (test_options_option_defs): Install "string.
3251
41fc454c
PA		 32522019-07-03 Pedro Alves <palves@redhat.com>
3253
3254 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3255 option_value with a null enumeration.
3256 (complete_options): Save the option values in the context.
3257 (save_option_value_in_ctx): New, factored out from ...
3258 (process_options): ... here.
3259 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3260 of the function.
3261 * maint-test-options.c (test_options_opts::dump): New, factored
3262 out from ...
3263 (maintenance_test_options_command_mode): ... here.
3264 (maintenance_test_options_command_completion_result): Delete.
3265 (maintenance_test_options_command_completion_text): Update
3266 comment.
3267 (maintenance_show_test_options_completion_result): Change
3268 prototype. Just print
3269 maintenance_test_options_command_completion_text.
3270 (save_completion_result): New.
3271 (maintenance_test_options_completer_mode): Pass options context to
3272 complete_options, and then save a dump.
3273 (_initialize_maint_test_options): Use add_cmd to install "maint
3274 show test-options-completion-result".
3275
fdbc9870
PA		 32762019-07-03 Pedro Alves <palves@redhat.com>
3277
3278 * NEWS (New commands): Mention "with" and "maint with".
3279 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3280 (with_command, with_command_completer): New.
3281 (pipe_command): Adjust to new repeat_previous
3282 interface.
3283 (_initialize_cli_cmds): Install the "with" command and its "w"
3284 alias.
3285 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3286 declarations.
3287 * cli/cli-setshow.c (parse_cli_var_uinteger)
3288 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3289 argument strings for all var_types.
3290 (get_setshow_command_value_string): New, factored out from ...
3291 (do_show_command): ... this.
3292 * cli/cli-setshow.h: Include <string>.
3293 (get_setshow_command_value_string): Declare.
3294 * command.h (repeat_previous): Now returns const char *. Adjust
3295 comment.
3296 * maint.c: Include "cli/cli-cmds.h".
3297 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3298 (_initialize_maint_cmds): Register the "maintenance with" command.
3299 * top.c (repeat_previous): Move bits from pipe_command here:
3300 Return the saved command line, if any; error out if there's no
3301 command to relaunch.
3302
c6ac8931
PA		 33032019-07-03 Pedro Alves <palves@redhat.com>
3304
3305 * NEWS (New commands): Mention "maint set/show test-settings"
3306 instead of "maint test-settings".
3307 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3308 (maintenance_test_settings_set_list): Rename to ...
3309 (maintenance_set_test_settings_list): ... this.
3310 (maintenance_test_settings_show_list): Rename to ...
3311 (maintenance_show_test_settings_list): ... this.
3312 (maintenance_test_settings_cmd): Delete.
3313 (maintenance_test_settings_set_cmd): ...
3314 (maintenance_set_test_settings_cmd): ... this.
3315 (maintenance_test_settings_show_cmd): ...
3316 (maintenance_show_test_settings_cmd): ... this.
3317 (maintenance_test_settings_show_value_cmd):
3318 (maintenance_show_test_settings_value_cmd): ... this.
3319 (_initialize_maint_test_settings): No longer install the "maint
3320 test-settings" prefix command. Rename "maint test-settings set"
3321 to "maint set test-settings", and "maint test-settings show" to
3322 "maint show test-settings". Adjust all subcommands.
3323
d1fcf2fd
PA		 33242019-07-03 Pedro Alves <palves@redhat.com>
3325
3326 * maint-test-settings.c: Fix file's intro comment. Replace all
3327 references to "test-options" with references to "test-settings",
3328 in comments.
3329
970f9d09
PA		 33302019-07-03 Pedro Alves <palves@redhat.com>
3331
3332 * maint-test-settings.c (maintenance_test_settings_xxx)
3333 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3334 New.
3335 (maintenance_test_settings_enums): Use them.
3336 (maintenance_test_settings_enum): Default to
3337 maintenance_test_settings_xxx.
3338 (_initialize_maint_test_settings): Initialize
3339 MAINTENANCE_TEST_SETTINGS_FILENAME.
3340
f3869b1a
SM		 33412019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3342
3343 * breakpoint.h (remove_breakpoints_inf): Change return type to
3344 void, move function documentation here.
3345 * breakpoint.c (remove_breakpoints_inf): Change return type to
3346 void, move function documentation to header.
3347
54d66006
PA		 33482019-07-02 Pedro Alves <palves@redhat.com>
3349
3350 * NEWS (Completion improvements): Mention "info threads".
3351 * thread.c (struct info_threads_opts, info_threads_option_defs)
3352 (make_info_threads_options_def_group): New.
3353 (info_threads_command): Use gdb::option::process_options.
3354 (info_threads_command_completer): New.
3355 (_initialize_thread): Use gdb::option::build_help to build the
3356 help text for "info threads".
3357
854f6088
SM		 33582019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3359
3360 * defs.h (generic_load): Move from here...
3361 * symfile.h (generic_load): ... to here. Rename name parameter
3362 to args.
3363 * symfile.c (generic_load): Add comment.
3364
54ee4252
TT		 33652019-07-01 Tom Tromey <tromey@adacore.com>
3366
3367 * dwarf2read.c
3368 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3369 declaration of without_params. Fix formatting.
3370
65392b3e
TT		 33712019-07-01 Tom Tromey <tromey@adacore.com>
3372
3373 * ada-exp.y (find_primitive_type): Update.
3374 * ada-lang.h (ada_lookup_symbol): Update.
3375 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3376 parameter.
3377 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3378
7d7571f0
SDJ		 33792019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3380
3381 PR breakpoints/24541
3382 * gdbarch.c: Regenerate.
3383 * gdbarch.h: Regenerate.
3384 * gdbarch.sh: Add 'stap_adjust_register'.
3385 * i386-tdep.c: Include '<unordered_set>'.
3386 (i386_stap_adjust_register): New function.
3387 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3388 * stap-probe.c (stap_parse_register_operand): Call
3389 'gdbarch_stap_adjust_register'.
3390
5af5392a
SDJ		 33912019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3392
3393 PR python/24742
3394 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3395 * python/python.c (do_start_initialization): Use 'xmalloc'
3396 instead of 'PyMem_Malloc'.
3397
10d06d82
TT		 33982019-06-28 Tom Tromey <tromey@adacore.com>
3399
3400 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3401 for Ada.
3402
1b7f24cd
TT		 34032019-06-27 Tom Tromey <tromey@adacore.com>
3404
3405 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3406 objfile_key.
3407 (arm_find_mapping_symbol, arm_record_special_symbol)
3408 (_initialize_arm_tdep): Update.
3409 (arm_objfile_data_free): Remove.
3410
3d507ff2
TT		 34112019-06-27 Tom Tromey <tromey@adacore.com>
3412
3413 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3414 to cp_print_static_field.
3415
762c164d
TT		 34162019-06-26 Tom Tromey <tromey@adacore.com>
3417
3418 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3419 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3420 declare.
3421
aa2f9bcf
AH		 34222019-06-26 Alan Hayward <alan.hayward@arm.com>
3423
3424 * features/aarch64-core.c (create_feature_aarch64_core):
3425 Regenerate.
3426 * features/aarch64-core.xml: Add cpsr flags.
3427
3426ae57
AH		 34282019-06-26 Alan Hayward <alan.hayward@arm.com>
3429
3430 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3431 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3432
4838e44c
SM		 34332019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3434
3435 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3436 field.
3437 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3438 use.
3439 (arm_record_special_symbol): Don't insert new symbol in sorted
3440 position, push it at the end.
3441
54cc7474
SM		 34422019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3443
3444 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3445 (arm_mapping_symbol_s): Remove.
3446 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3447 (arm_mapping_symbol_vec): New typedef.
3448 (struct arm_per_objfile): Add constructor.
3449 <section_maps>: Change type to
3450 std::unique_ptr<arm_mapping_symbol_vec[]>.
3451 (arm_compare_mapping_symbols): Remove.
3452 (arm_find_mapping_symbol): Adjust to section_maps type change.
3453 (arm_objfile_data_free): Call delete on arm_per_objfile.
3454 (arm_record_special_symbol): Adjust to section_maps type change.
3455 Allocate arm_per_objfile with new.
3456
b65b566c
PW		 34572019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3458
3459 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3460 with the command prefix.
3461
c2fc64f5
TT		 34622019-06-25 Tom Tromey <tom@tromey.com>
3463
3464 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3465 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3466
fb54fa76
TT		 34672019-06-25 Tom Tromey <tom@tromey.com>
3468
3469 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3470 type.
3471 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3472 protected.
3473
f7952c57
TT		 34742019-06-25 Tom Tromey <tom@tromey.com>
3475
3476 * tui/tui-winsource.c
3477 (tui_source_window_base::set_is_exec_point_at): Add check against
3478 LOA_ADDRESS.
3479
17568d78
TT		 34802019-06-25 Tom Tromey <tom@tromey.com>
3481
3482 * tui/tui-source.c (tui_set_source_content): Don't check before
3483 xfree.
3484 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3485
53e7cdba
TT		 34862019-06-25 Tom Tromey <tom@tromey.com>
3487
3488 * tui/tui-winsource.h (tui_update_source_window_as_is)
3489 (tui_alloc_source_buffer, tui_line_is_displayed)
3490 (tui_addr_is_displayed): Change type of win_info.
3491 * tui/tui-winsource.c (tui_update_source_window_as_is)
3492 (tui_clear_source_content, tui_show_source_line)
3493 (tui_show_source_content, tui_source_window_base::refill)
3494 (tui_source_window_base::set_is_exec_point_at)
3495 (tui_source_window_base::set_is_exec_point_at)
3496 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3497 (tui_alloc_source_buffer, tui_line_is_displayed)
3498 (tui_addr_is_displayed): Change type of win_info. Update.
3499 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3500 (tui_source_window_base::do_make_visible_with_new_height):
3501 Update.
3502 * tui/tui-source.c (tui_set_source_content)
3503 (tui_set_source_content_nil)
3504 (tui_source_window::do_scroll_vertical): Update.
3505 * tui/tui-layout.c (show_layout): Update.
3506 * tui/tui-disasm.c (tui_set_disassem_content)
3507 (tui_disasm_window::do_scroll_vertical): Update.
3508 * tui/tui-data.h (tui_win_content): Remove.
3509 (struct tui_gen_win_info) <content, content_size>: Remove.
3510 (struct tui_source_element): Add initializers and destructor.
3511 (union tui_which_element, struct tui_win_element): Remove.
3512 (struct tui_source_window_base) <content>: New field.
3513 (struct tui_data_window): Remove destructor.
3514 (tui_alloc_content, tui_free_win_content)
3515 (tui_free_all_source_wins_content): Don't declare.
3516 * tui/tui-data.c (tui_initialize_static_data): Update.
3517 (init_content_element, tui_alloc_content): Remove.
3518 (~tui_gen_win_info): Update.
3519 (~tui_data_window, tui_free_all_source_wins_content)
3520 (tui_free_win_content, free_content, free_content_elements):
3521 Remove.
3522
7908abbf
TT		 35232019-06-25 Tom Tromey <tom@tromey.com>
3524
3525 * tui/tui-winsource.h (tui_clear_source_content)
3526 (tui_erase_source_content, tui_show_source_content): Change type
3527 of win_info.
3528 * tui/tui-winsource.c (tui_clear_source_content)
3529 (tui_erase_source_content, tui_show_source_content): Change type
3530 of win_info.
3531 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3532 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3533 win_info.
3534 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3535 win_info.
3536 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3537
02c28df0
TT		 35382019-06-25 Tom Tromey <tom@tromey.com>
3539
3540 * tui/tui-winsource.c (tui_clear_source_content)
3541 (tui_source_window_base::set_is_exec_point_at): Update.
3542 * tui/tui-source.c (tui_set_source_content_nil): Update.
3543 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3544 a bool.
3545 * tui/tui-data.c (init_content_element): Update.
3546
6658b1bf
TT		 35472019-06-25 Tom Tromey <tom@tromey.com>
3548
3549 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3550 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3551 * tui/tui-layout.c (init_and_make_win): Update.
3552 * tui/tui.h (enum tui_win_type): Update.
3553 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3554 tui_win_is_auxillary.
3555 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3556 tui_win_is_auxillary.
3557
21e1c91e
TT		 35582019-06-25 Tom Tromey <tom@tromey.com>
3559
3560 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3561 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3562 (tui_delete_data_content_windows, tui_display_all_data)
3563 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3564 Update.
3565 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3566 * tui/tui-regs.c (tui_last_regs_line_no)
3567 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3568 (tui_show_registers): Update.
3569 (tui_show_register_group): Return void. Update.
3570 (tui_display_registers_from, tui_display_reg_element_at_line)
3571 (tui_display_registers_from_line, tui_check_register_values):
3572 Update.
3573 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3574 member.
3575 (struct tui_data_window) <regs_content>: Now a std::vector.
3576 <regs_content_count>: Remove.
3577 (tui_add_content_elements, tui_free_data_content): Don't declare.
3578 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3579 (init_content_element): Remove DATA_WIN case. Add assert.
3580 (tui_add_content_elements): Remove.
3581 (tui_data_window): Update.
3582 (tui_free_data_content): Remove.
3583 (free_content_elements): Remove DATA_WIN case.
3584
115ac53b
TT		 35852019-06-25 Tom Tromey <tom@tromey.com>
3586
3587 * tui/tui-data.c (tui_data_item_window): Update.
3588 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3589 * tui/tui-windata.c (tui_display_all_data)
3590 (tui_display_data_from_line): Update.
3591 (tui_check_data_values): Remove.
3592 * tui/tui-regs.c (tui_show_register_group)
3593 (tui_display_reg_element_at_line): Update.
3594 * tui/tui-hooks.c (tui_register_changed)
3595 (tui_refresh_frame_and_register_information): Call
3596 tui_check_register_values.
3597 * tui/tui-data.h (struct tui_data_window) <data_content,
3598 data_content_count, data_type>: Remove.
3599 (enum tui_data_type): Remove.
3600
3601 * tui/tui-data.c (tui_data_window::clear_detail)
3602 (~tui_data_window): Update.
3603
eaf9738b
TT		 36042019-06-25 Tom Tromey <tom@tromey.com>
3605
3606 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3607 declare.
3608 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3609 Rename from tui_first_data_item_displayed. Update.
3610 (tui_data_window::refresh_all)
3611 (tui_data_window::do_scroll_vertical): Update.
3612 * tui/tui-data.h (struct tui_data_window)
3613 <first_data_item_displayed>: Declare new method.
3614
31ca4723
TT		 36152019-06-25 Tom Tromey <tom@tromey.com>
3616
3617 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3618 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3619 contents...
3620 (tui_initialize_static_data): ...here.
3621
41bcff7f
TT		 36222019-06-25 Tom Tromey <tom@tromey.com>
3623
3624 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3625 (tui_display_registers_from, tui_check_register_values): Update.
3626 (tui_display_register): Remove win_info parameter; update.
3627 (tui_get_register): Change type of parameters.
3628 * tui/tui-data.h (struct tui_data_element): Remove.
3629 (union tui_which_element) <data>: Remove.
3630 <data_window>: Change type.
3631 (struct tui_data_item_window): New.
3632 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3633 case. Add assert.
3634 (~tui_data_item_window): New destructor.
3635 (free_content_elements): Remove DATA_ITEM_WIN case.
3636
d2802c33
TT		 36372019-06-25 Tom Tromey <tom@tromey.com>
3638
3639 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3640 Remove.
3641
dd835f8b
TT		 36422019-06-25 Tom Tromey <tom@tromey.com>
3643
3644 * tui/tui-data.h (struct tui_command_element): Remove.
3645 (union tui_which_element) <command>: Remove.
3646 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3647 assert.
3648 (free_content_elements): Remove CMD_WIN case.
3649
bd7db367
TT		 36502019-06-25 Tom Tromey <tom@tromey.com>
3651
3652 * tui/tui-layout.c (tui_set_layout): Update.
3653 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3654 * tui/tui-data.c (layout_def): Update.
3655
3add462f
TT		 36562019-06-25 Tom Tromey <tom@tromey.com>
3657
3658 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3659 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3660 (tui_source_window_base::set_new_height): Update.
3661 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3662 Update.
3663 (tui_set_locator_fullname, tui_set_locator_info)
3664 (tui_show_frame_info): Update.
3665 * tui/tui-source.c (tui_set_source_content)
3666 (tui_source_is_displayed): Update.
3667 * tui/tui-layout.c (show_source_disasm_command, show_data)
3668 (show_source_or_disasm_and_command): Update.
3669 * tui/tui-disasm.c (tui_set_disassem_content)
3670 (tui_get_begin_asm_address): Update.
3671 * tui/tui-data.h (struct tui_locator_element): Remove.
3672 (union tui_which_element) <locator>: Remove.
3673 (struct tui_locator_window): New.
3674 (tui_locator_win_info_ptr): Change return type.
3675 * tui/tui-data.c (_locator): Change type.
3676 (tui_locator_win_info_ptr): Change return type.
3677 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3678 (tui_alloc_content): Add assert.
3679
489e9d8b
TT		 36802019-06-25 Tom Tromey <tom@tromey.com>
3681
3682 * tui/tui-winsource.c
3683 (tui_exec_info_window::maybe_allocate_content): New method.
3684 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3685 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3686 (make_source_or_disasm_window): Add cast.
3687 * tui/tui-data.h (union tui_which_element) <simple_string>:
3688 Remove.
3689 (struct tui_source_info): New.
3690 (struct tui_source_window_base) <execution_info>: Change type.
3691 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3692 case, and add assert.
3693 (tui_alloc_content): Add assert.
3694
c3fabb7d
TT		 36952019-06-25 Tom Tromey <tom@tromey.com>
3696
3697 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3698 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3699 * tui/tui-data.c (tui_alloc_win_info): Remove.
3700
bbc228ee
TT		 37012019-06-25 Tom Tromey <tom@tromey.com>
3702
3703 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3704 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3705 can_highlight.
3706
5fcee43a
TT		 37072019-06-25 Tom Tromey <tom@tromey.com>
3708
3709 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3710 make_visible_with_new_height method.
3711 (tui_win_info::make_visible_with_new_height): New method.
3712 (tui_source_window_base::do_make_visible_with_new_height)
3713 (tui_data_window::do_make_visible_with_new_height)
3714 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3715 (make_visible_with_new_height): Remove.
3716 (tui_resize_all, tui_adjust_win_heights): Use
3717 make_visible_with_new_height method.
3718 * tui/tui-data.h (struct tui_win_info)
3719 <do_make_visible_with_new_height, make_visible_with_new_height>:
3720 New methods.
3721 (struct tui_source_window_base, struct tui_data_window)
3722 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3723 methods.
3724
d83f1fe6
TT		 37252019-06-25 Tom Tromey <tom@tromey.com>
3726
3727 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3728 method.
3729 (update_tab_width): Call update_tab_width method.
3730 * tui/tui-data.h (struct tui_win_info)
3731 (struct tui_source_window_base) <update_tab_width>: New methods.
3732
17374de4
TT		 37332019-06-25 Tom Tromey <tom@tromey.com>
3734
3735 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3736 parameter.
3737 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3738 parameter.
3739 (tui_gen_win_info::make_visible): Update.
3740 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3741 parameter.
3742 * tui/tui-data.h (enum tui_box): New enum.
3743 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3744
f936bca2
TT		 37452019-06-25 Tom Tromey <tom@tromey.com>
3746
3747 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3748 init_and_make_win for EXEC_INFO_WIN.
3749 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3750 longer inline.
3751 (struct tui_win_info) <~tui_win_info>: Inline.
3752 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3753 Don't declare.
3754 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3755 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3756 Remove.
3757 (tui_initialize_static_data): Update.
3758 (~tui_gen_win_info): Handle more cleanup here.
3759 (~tui_source_window_base): Delete "execution_info".
3760 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3761
d6ba6a11
TT		 37622019-06-25 Tom Tromey <tom@tromey.com>
3763
3764 * tui/tui-layout.c (make_command_window): Don't set
3765 can_highlight.
3766 (show_source_disasm_command): Call the reset method.
3767 (show_data): Don't set can_highlight. Call the reset method.
3768 (tui_gen_win_info::reset): Rename from init_gen_win_info
3769 (init_and_make_win): Simplify. Return tui_gen_win_info.
3770 (show_source_or_disasm_and_command): Call the reset method.
3771 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3772 (struct tui_cmd_window): Set can_highlight.
3773
48a3bd16
TT		 37742019-06-25 Tom Tromey <tom@tromey.com>
3775
3776 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3777 from make_visible.
3778 (tui_make_visible, tui_make_invisible): Rewrite.
3779 (tui_win_info::make_visible): Remove.
3780 (tui_source_window_base::make_visible): Update.
3781 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3782 method. Moved from...
3783 (struct tui_win_info) <make_visible>: ...here.
3784
c3bd716f
TT		 37852019-06-25 Tom Tromey <tom@tromey.com>
3786
3787 * tui/tui-winsource.c
3788 (tui_source_window_base::do_scroll_horizontal): Remove direction
3789 parameter.
3790 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3791 direction parameter.
3792 * tui/tui-win.c (tui_win_info::forward_scroll)
3793 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3794 (tui_win_info::right_scroll): Update.
3795 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3796 direction parameter.
3797 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3798 direction parameter.
3799 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3800 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3801 Remove direction parameter.
3802 (struct tui_source_window_base, struct tui_source_window)
3803 (struct tui_disasm_window, struct tui_data_window)
3804 (struct tui_cmd_window): Update.
3805
21c32dca
TT		 38062019-06-25 Tom Tromey <tom@tromey.com>
3807
3808 * tui/tui-winsource.h (tui_set_exec_info_content)
3809 (tui_show_exec_info_content, tui_erase_exec_info_content)
3810 (tui_clear_exec_info_content, tui_update_exec_info): Change
3811 argument to tui_source_window_base.
3812 * tui/tui-winsource.c (tui_set_exec_info_content)
3813 (tui_show_exec_info_content, tui_erase_exec_info_content)
3814 (tui_clear_exec_info_content, tui_update_exec_info): Change
3815 argument to tui_source_window_base.
3816
73fbdc65
TT		 38172019-06-25 Tom Tromey <tom@tromey.com>
3818
3819 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3820 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3821
33325343
TT		 38222019-06-25 Tom Tromey <tom@tromey.com>
3823
3824 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3825 check.
3826
29d2c474
TT		 38272019-06-25 Tom Tromey <tom@tromey.com>
3828
3829 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3830 type to void.
3831 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3832 type to void.
3833 * tui/tui-source.c (tui_set_source_content): Update.
3834 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3835
152f3f4b
TT		 38362019-06-25 Tom Tromey <tom@tromey.com>
3837
3838 * tui/tui-win.c (window_name_completer, tui_set_focus)
3839 (tui_all_windows_info): Use name method.
3840 * tui/tui-data.h (struct tui_gen_win_info)
3841 (struct tui_source_window, struct tui_disasm_window)
3842 (struct tui_data_window, struct tui_cmd_window) <name>: New
3843 method.
3844 (tui_win_name): Don't declare.
3845 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3846 (tui_win_name): Remove.
3847
be4da588
TT		 38482019-06-25 Tom Tromey <tom@tromey.com>
3849
3850 * tui/tui-winsource.h (tui_update_source_window)
3851 (tui_update_source_window_as_is): Change parameter type.
3852 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3853 to be a tui_source_window_base.
3854 (tui_update_source_window_as_is): Likewise.
3855 * tui/tui-win.c (make_visible_with_new_height): Update.
3856
5b81daba
TT		 38572019-06-25 Tom Tromey <tom@tromey.com>
3858
3859 * tui/tui-winsource.c (tui_erase_source_content)
3860 (tui_show_source_content, tui_show_exec_info_content)
3861 (tui_erase_exec_info_content): Use refresh_window method.
3862 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3863 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3864 from tui_refresh_win.
3865 (tui_data_window::refresh_window): New method.
3866 (tui_win_info::refresh, tui_source_window_base::refresh)
3867 (tui_refresh_all): Use refresh_window method.
3868 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3869 method.
3870 * tui/tui-regs.c (tui_display_register): Call refresh_window
3871 method.
3872 * tui/tui-layout.c (show_source_disasm_command)
3873 (show_source_or_disasm_and_command): Call refresh_window method.
3874 * tui/tui-data.h (struct tui_gen_win_info)
3875 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3876 New method.
3877
cb2ce893
TT		 38782019-06-25 Tom Tromey <tom@tromey.com>
3879
3880 * tui/tui.c (tui_rl_other_window, tui_enable)
3881 (tui_is_window_visible, tui_get_command_dimension): Update.
3882 * tui/tui-winsource.c (tui_update_source_window_as_is)
3883 (tui_clear_source_content, tui_erase_source_content)
3884 (tui_show_source_line, tui_source_window_base::refill)
3885 (tui_source_window_base::do_scroll_horizontal)
3886 (tui_source_window_base::set_is_exec_point_at)
3887 (tui_update_breakpoint_info, tui_set_exec_info_content)
3888 (tui_alloc_source_buffer, tui_line_is_displayed)
3889 (tui_addr_is_displayed): Update.
3890 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3891 (tui_check_and_display_highlight_if_needed)
3892 (tui_win_info::make_visible, tui_win_info::refresh)
3893 (tui_refresh_all): Update.
3894 * tui/tui-windata.c (tui_first_data_item_displayed)
3895 (tui_delete_data_content_windows, tui_erase_data_content)
3896 (tui_display_all_data, tui_data_window::refresh_all)
3897 (tui_check_data_values): Update.
3898 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3899 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3900 (tui_win_info::backward_scroll, tui_refresh_all_win)
3901 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3902 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3903 (tui_source_window_base::set_new_height)
3904 (tui_data_window::set_new_height)
3905 (make_invisible_and_set_new_height)
3906 (make_visible_with_new_height, new_height_ok)
3907 (parse_scrolling_args): Update.
3908 * tui/tui-stack.c (tui_show_frame_info): Update.
3909 * tui/tui-source.c (tui_set_source_content)
3910 (tui_set_source_content_nil, tui_source_is_displayed)
3911 (tui_source_window::do_scroll_vertical): Update.
3912 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3913 (tui_display_registers_from, tui_display_reg_element_at_line)
3914 (tui_check_register_values, tui_reg_command): Update.
3915 * tui/tui-layout.c (tui_default_win_height)
3916 (show_source_disasm_command, show_data, init_and_make_win)
3917 (show_source_or_disasm_and_command): Update.
3918 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3919 (tui_redisplay_readline, tui_mld_flush)
3920 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3921 (tui_getc): Update.
3922 * tui/tui-disasm.c (tui_set_disassem_content)
3923 (tui_disasm_window::do_scroll_vertical): Update.
3924 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3925 Now virtual.
3926 (struct tui_win_info): Derive from tui_gen_win_info.
3927 <~tui_win_info>: Mark as override.
3928 <generic>: Remove member.
3929 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3930 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3931 (~tui_data_window, ~tui_win_info)
3932 (tui_free_all_source_wins_content): Update.
3933 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3934
ab313b35
TT		 39352019-06-25 Tom Tromey <tom@tromey.com>
3936
3937 * tui/tui-layout.c (init_and_make_win): Use new.
3938 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3939 destructor, initializers.
3940 (tui_alloc_generic_win_info): Don't declare.
3941 * tui/tui-data.c (_locator): Add argument to constructor.
3942 (source_win, disasm_win): New globals.
3943 (exec_info): Remove.
3944 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3945 Update.
3946 (tui_alloc_generic_win_info): Remove.
3947 (init_content_element): Use new.
3948 (tui_win_info::tui_win_info): Update.
3949 (free_content_elements) <case DATA_WIN>: Use delete.
3950
dc2c33e4
TT		 39512019-06-25 Tom Tromey <tom@tromey.com>
3952
3953 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3954 * tui/tui-windata.c (tui_first_data_item_displayed)
3955 (tui_delete_data_content_windows): Update.
3956 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3957 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3958 (tui_display_registers_from, tui_check_register_values): Update.
3959 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3960 pointer.
3961 * tui/tui-data.c (init_content_element): Update. Allocate the new
3962 window.
3963 (tui_free_data_content): Update.
3964 (free_content_elements) <case DATA_WIN>: Free the window.
3965
214a5cbe
TT		 39662019-06-25 Tom Tromey <tom@tromey.com>
3967
3968 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3969 Update.
3970 * tui/tui-layout.c (make_command_window)
3971 (show_source_disasm_command, show_data, init_and_make_win)
3972 (show_source_or_disasm_and_command): Update.
3973 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3974 method.
3975 <can_highight, is_highlighted>: Now bool.
3976 (tui_set_win_highlight): Don't declare.
3977 * tui/tui-data.c (tui_set_win_highlight): Remove.
3978
8e2daf15
TT		 39792019-06-25 Tom Tromey <tom@tromey.com>
3980
3981 * tui/tui-wingeneral.c (make_visible): Remove check of window
3982 type.
3983
8903bd8a
TT		 39842019-06-25 Tom Tromey <tom@tromey.com>
3985
3986 * tui/tui-win.c (tui_win_info::max_height)
3987 (tui_cmd_window::max_height): New methods.
3988 (new_height_ok): Call max_height.
3989 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3990 <max_height>: New method.
3991
3f02ce1e
TT		 39922019-06-25 Tom Tromey <tom@tromey.com>
3993
3994 * tui/tui-win.c (tui_source_window_base::set_new_height)
3995 (tui_data_window::set_new_height): New methods.
3996 (make_invisible_and_set_new_height): Call set_new_height method.
3997 * tui/tui-data.h (struct tui_win_info)
3998 (struct tui_source_window_base, struct tui_data_window)
3999 <set_new_height>: New method.
4000
1825f487
TT		 40012019-06-25 Tom Tromey <tom@tromey.com>
4002
4003 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4004 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4005 tui_refresh_data_win.
4006 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4007 method.
4008 (tui_refresh_all_win): Call the refresh_all method.
4009 (tui_set_focus): Likewise.
4010 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4011 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4012 Likewise.
4013
ad54d15b
TT		 40142019-06-25 Tom Tromey <tom@tromey.com>
4015
4016 * tui/tui-winsource.h (tui_refill_source_window)
4017 (tui_set_is_exec_point_at): Don't declare.
4018 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4019 (tui_source_window_base::refill): Rename from
4020 tui_refill_source_window.
4021 (tui_source_window_base::do_scroll_horizontal): Update.
4022 (tui_source_window_base::set_is_exec_point_at): Rename from
4023 tui_set_is_exec_point_at.
4024 (tui_update_all_breakpoint_info): Update.
4025 * tui/tui-stack.c (tui_show_frame_info): Update.
4026 * tui/tui-layout.c (show_data): Add cast.
4027 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4028 * tui/tui-data.h (struct tui_source_window_base) <refill,
4029 set_is_exec_point_at>: New methods.
4030 (tui_source_windows, tui_add_to_source_windows): Update types.
4031 (tui_add_to_source_windows): Remove redundant declaration.
4032 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4033 (tui_source_windows): Change return type.
4034 (tui_clear_source_windows_detail): Update.
4035 (tui_add_to_source_windows): Change type of parameter.
4036 (tui_free_all_source_wins_content): Update.
4037
2042b506
TT		 40382019-06-25 Tom Tromey <tom@tromey.com>
4039
4040 * tui/tui-wingeneral.c (tui_win_info::refresh)
4041 (tui_source_window_base::refresh): New methods.
4042 (tui_refresh_all): Call the refresh method.
4043 * tui/tui-data.h (struct tui_win_info)
4044 (struct tui_source_window_base) <refresh>: New method.
4045
56122977
TT		 40462019-06-25 Tom Tromey <tom@tromey.com>
4047
4048 * tui/tui.h (tui_is_window_visible): Return bool.
4049 * tui/tui.c (tui_is_window_visible): Return bool.
4050 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4051 (tui_make_visible, tui_make_invisible)
4052 (tui_win_info::make_visible)
4053 (tui_source_window_base::make_visible, make_all_visible)
4054 (tui_make_all_visible, tui_make_all_invisible): Update.
4055 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4056 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4057 bool.
4058 (struct tui_win_info, struct tui_source_window_base)
4059 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4060 * tui/tui-data.c (tui_init_generic_part): Update.
4061
cda37efb
TT		 40622019-06-25 Tom Tromey <tom@tromey.com>
4063
4064 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4065 (tui_source_window_base::make_visible): New methods.
4066 (make_all_visible): Make method call.
4067 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4068 (struct tui_source_window_base, struct tui_cmd_window): Override
4069 make_visible.
4070 (tui_win_is_source_type): Don't declare.
4071 * tui/tui-data.c (tui_win_is_source_type): Remove.
4072
6a0ee02c
TT		 40732019-06-25 Tom Tromey <tom@tromey.com>
4074
4075 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4076 NULL check.
4077
63901aec
TT		 40782019-06-25 Tom Tromey <tom@tromey.com>
4079
4080 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4081 Inline constructor. Add initializers for members.
4082 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4083 constructors; now inline in class.
4084
ceb13a13
TT		 40852019-06-25 Tom Tromey <tom@tromey.com>
4086
4087 * tui/tui-regs.c (tui_show_registers): Update.
4088 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4089 bool.
4090 * tui/tui-data.c (tui_data_window::clear_detail)
4091 (tui_data_window): Update.
4092
238eb706
TT		 40932019-06-25 Tom Tromey <tom@tromey.com>
4094
4095 * tui/tui-windata.c (tui_display_all_data)
4096 (tui_display_data_from_line, tui_display_data_from)
4097 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4098 Update.
4099 * tui/tui-regs.c (tui_last_regs_line_no)
4100 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4101 (tui_show_registers, tui_show_register_group)
4102 (tui_display_registers_from, tui_display_reg_element_at_line)
4103 (tui_display_registers_from_line, tui_check_register_values)
4104 (tui_reg_next, tui_reg_prev): Update.
4105 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4106 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4107 tui_data_window.
4108 (struct tui_win_info) <detail>: Remove. Add new fields from
4109 tui_data_info.
4110 (TUI_DATA_WIN): Add cast.
4111 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4112 (~tui_data_window): Simplify.
4113
81491aa0
TT		 41142019-06-25 Tom Tromey <tom@tromey.com>
4115
4116 * tui/tui-layout.c (show_source_disasm_command)
4117 (show_source_or_disasm_and_command): Update.
4118 * tui/tui-io.c (update_cmdwin_start_line)
4119 (tui_redisplay_readline): Update.
4120 * tui/tui-data.h (struct tui_command_info): Remove.
4121 (struct tui_win_info) <detail>: Remove command_info member.
4122 (struct tui_data_window) <start_line>: New member, from
4123 tui_command_info.
4124 (TUI_CMD_WIN): Add casts.
4125
e6e41501
TT		 41262019-06-25 Tom Tromey <tom@tromey.com>
4127
4128 * tui/tui-winsource.c (tui_update_source_window)
4129 (tui_refill_source_window)
4130 (tui_source_window_base::do_scroll_horizontal)
4131 (tui_update_breakpoint_info, tui_set_exec_info_content)
4132 (tui_show_exec_info_content, tui_erase_exec_info_content)
4133 (tui_clear_exec_info_content): Update.
4134 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4135 Update.
4136 * tui/tui-win.c (make_invisible_and_set_new_height)
4137 (make_visible_with_new_height): Update.
4138 * tui/tui-source.c (tui_set_source_content)
4139 (tui_show_symtab_source): Update.
4140 * tui/tui-layout.c (extract_display_start_addr)
4141 (show_source_disasm_command, show_data)
4142 (make_source_or_disasm_window)
4143 (show_source_or_disasm_and_command): Update.
4144 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4145 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4146 "gdbarch".
4147 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4148 to tui_source_window_base.
4149 (struct tui_win_info) <detail>: Remove source_info member.
4150 (struct tui_source_window_base) <has_locator>: Inline.
4151 Move contents from tui_source_info; rename has_locator member to
4152 m_has_locator.
4153 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4154 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4155 header file.
4156 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4157 Simplify.
4158 (tui_free_all_source_wins_content): Cast to
4159 tui_source_window_base.
4160
44f0e208
TT		 41612019-06-25 Tom Tromey <tom@tromey.com>
4162
4163 * tui/tui-win.c (make_invisible_and_set_new_height)
4164 (make_visible_with_new_height): Call has_locator method.
4165 * tui/tui-layout.c (show_source_disasm_command, show_data)
4166 (show_source_or_disasm_and_command): Update for bool change.
4167 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4168 (tui_win_info) <has_locator>: New method.
4169 (struct tui_source_window_base) <has_locator>: New method.
4170 (tui_win_has_locator): Don't declare.
4171 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4172 from tui_win_has_locator.
4173 (tui_source_window_base): Use false, not FALSE.
4174
7778b912
TT		 41752019-06-25 Tom Tromey <tom@tromey.com>
4176
4177 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4178 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4179 clear_detail method directly.
4180 (tui_clear_win_detail): Remove.
4181
f83d391c
TT		 41822019-06-25 Tom Tromey <tom@tromey.com>
4183
4184 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4185 "this", not TUI_DISASM_WIN.
4186
13446e05
TT		 41872019-06-25 Tom Tromey <tom@tromey.com>
4188
4189 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4190 declare.
4191 * tui/tui-winsource.c
4192 (tui_source_window_base::do_scroll_horizontal): Rename from
4193 tui_horizontal_source_scroll.
4194 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4195 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4196 from tui_vertical_data_scroll.
4197 * tui/tui-win.h (tui_scroll): Don't declare.
4198 * tui/tui-win.c (tui_win_info::forward_scroll)
4199 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4200 (tui_win_info::right_scroll): Rename and update.
4201 (tui_scroll_forward_command, tui_scroll_backward_command)
4202 (tui_scroll_left_command, tui_scroll_right_command): Update.
4203 (tui_scroll): Remove.
4204 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4205 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4206 from tui_vertical_source_scroll.
4207 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4208 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4209 from tui_vertical_disassem_scroll.
4210 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4211 do_scroll_horizontal>: New methods.
4212 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4213 Likewise.
4214 (struct tui_source_window_base): Add do_scroll_horizontal.
4215 (struct tui_source_window, struct tui_disasm_window): Add
4216 do_scroll_vertical.
4217 (struct tui_data_window, struct tui_cmd_window): Add
4218 do_scroll_horizontal and do_scroll_vertical.
4219 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4220
5cf82909
TT		 42212019-06-25 Tom Tromey <tom@tromey.com>
4222
4223 * tui/tui-data.h (struct tui_source_window_base): New struct.
4224 (struct tui_source_window): Derive from tui_source_window_base.
4225 (struct tui_disasm_window): New struct.
4226 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4227 from tui_source_window::clear_detail.
4228 (tui_source_window_base): Rename from tui_source_window.
4229 (~tui_source_window_base): Rename from ~tui_source_window.
4230 (tui_alloc_win_info): Create a tui_disasm_window.
4231
ee1d42d6
TT		 42322019-06-25 Tom Tromey <tom@tromey.com>
4233
4234 * tui/tui-data.h (struct tui_source_window)
4235 (struct tui_data_window): Declare destructors.
4236 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4237 destructors.
4238 (tui_win_info): Simplify.
4239
b4eb2452
TT		 42402019-06-25 Tom Tromey <tom@tromey.com>
4241
4242 * tui/tui-winsource.c (tui_display_main)
4243 (tui_update_source_windows_with_addr)
4244 (tui_update_all_breakpoint_info): Update.
4245 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4246 (new_height_ok, parse_scrolling_args): Update.
4247 * tui/tui-stack.c (tui_show_frame_info): Update.
4248 * tui/tui-data.h (struct tui_list): Remove.
4249 (tui_source_windows): Return a reference to a std::vector.
4250 * tui/tui-data.c (source_windows): Now a std::vector.
4251 (tui_source_windows): Change return type.
4252 (tui_clear_source_windows): Rewrite.
4253 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4254 (tui_free_all_source_wins_content): Rewrite.
4255
8761a91b
TT		 42562019-06-25 Tom Tromey <tom@tromey.com>
4257
4258 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4259 (struct tui_data_window, struct tui_cmd_window): Declare
4260 clear_detail method.
4261 * tui/tui-data.c (tui_source_window::clear_detail)
4262 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4263 methods.
4264 (tui_clear_win_detail): Simplify.
4265
0ed69eda
TT		 42662019-06-25 Tom Tromey <tom@tromey.com>
4267
4268 * tui/tui-layout.c (make_source_window, make_disasm_window)
4269 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4270 Return the new window.
4271 (show_source_disasm_command, show_data)
4272 (show_source_or_disasm_and_command): Update.
4273
82432e10
TT		 42742019-06-25 Tom Tromey <tom@tromey.com>
4275
4276 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4277 parameter. Return the new window.
4278 (show_source_disasm_command): Update and remove NULL check.
4279 (show_source_or_disasm_and_command): Update.
4280
ec328aa5
TT		 42812019-06-25 Tom Tromey <tom@tromey.com>
4282
4283 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4284
33b906ab
TT		 42852019-06-25 Tom Tromey <tom@tromey.com>
4286
4287 * tui/tui-data.h (struct tui_win_info): Make constructor
4288 protected. Make destructor virtual. Add initializers.
4289 (tui_source_window, tui_data_window, tui_cmd_window): New
4290 classes.
4291 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4292 constructor. Add "type" parameter.
4293 (tui_source_window, tui_data_window, tui_cmd_window): New
4294 constructors.
4295 (tui_alloc_win_info): Instantiate the appropriate subclass.
4296
e7e11af4
TT		 42972019-06-25 Tom Tromey <tom@tromey.com>
4298
4299 * tui/tui-win.c (tui_resize_all): Use delete.
4300 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4301 destructor.
4302 (tui_free_window): Don't declare.
4303 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4304 Update.
4305
6792b55e
TT		 43062019-06-25 Tom Tromey <tom@tromey.com>
4307
4308 * tui/tui-data.h (struct tui_win_info): Add constructor.
4309 * tui/tui-data.c (tui_alloc_win_info): Use new.
4310 (tui_free_window): Use delete.
4311
f95675e1
TT		 43122019-06-22 Tom Tromey <tom@tromey.com>
4313
4314 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4315 declare.
4316 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4317
5bff081c
TT		 43182019-06-22 Tom Tromey <tom@tromey.com>
4319
4320 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4321 declare.
4322 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4323
47e3f474
TV		 43242019-06-22 Tom de Vries <tdevries@suse.de>
4325
4326 * dwarf2read.c (create_addrmap_from_aranges)
4327 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4328 instead of '%zu'.
4329
fd5866f6
SM		 43302019-06-21 Simon Marchi <simon.marchi@efficios.com>
4331
4332 * dwarf2read.h (dwarf2_section_info_def): Remove.
4333 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4334 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4335 std::vector<dwarf2_section_info>.
4336 (struct dwo_file) <~dwo_file>: Remove.
4337 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4338 types field.
4339 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4340 (dwarf2_read_debug_names): Likewise.
4341 (create_debug_types_hash_table): Change parameter type to
4342 array_view, adjust code accordingly.
4343 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4344 (partial_die_info::fixup): Likewise.
4345 (determine_prefix): Likewise.
4346 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4347
fb1eb2f9
SM		 43482019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4349
4350 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4351 gdb_bfd_ref_ptr.
4352 <~dwo_file>: Remove call to gdb_bfd_unref.
4353 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4354 gdb_bfd_ref_ptr::get.
4355
51ac9db5
SM		 43562019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4357
4358 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4359 type to htab_up.
4360 * dwarf2read.c (struct dwo_file): Initialize fields.
4361 <~dwo_file>: New.
4362 (free_dwo_file): Remove, move content to ~dwo_file.
4363 (struct dwo_file_deleter): Remove.
4364 (dwo_file_up>: Remove custom deleter.
4365 (free_dwo_files): Remove.
4366 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4367 dwo_files.
4368 (process_skeletonless_type_units): Call unique_ptr::get.
4369 (allocate_dwo_file_hash_table): Add deleter to created hash
4370 table. Change return type to htab_up.
4371 (lookup_dwo_file_slot): Don't memset dwo_file, call
4372 unique_ptr::get.
4373 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4374 (create_dwo_unit_in_dwp_v2): Likewise.
4375 (open_and_init_dwo_file): Likewise.
4376 (free_dwo_file_from_slot): Remove.
4377
dc4ccb6f
SM		 43782019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4379
4380 * dwarf2read.h (struct dwarf2_section_info) <readin,
4381 is_virtual>: Change type to bool.
4382 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4383 true instead of 1.
4384
e6a1c5cb
TT		 43852019-06-19 Tom Tromey <tom@tromey.com>
4386
4387 * tui/tui-data.h (tui_init_content_element): Don't declare.
4388
6f6ffbeb
TT		 43892019-06-19 Tom Tromey <tom@tromey.com>
4390
4391 * tui/tui-data.h (tui_init_win_info): Don't declare.
4392
f23f598e
TV		 43932019-06-19 Tom de Vries <tdevries@suse.de>
4394
4395 * dwarf2read.h (abstract_to_concrete): Change type to
4396 std::unordered_map<sect_offset, std::vector<sect_offset>,
4397 gdb::hash_enum<sect_offset>>.
4398
680e1bee
TT		 43992019-06-19 Tom Tromey <tromey@adacore.com>
4400
4401 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4402 EVAL_AVOID_SIDE_EFFECTS specially.
4403
dcf37923
TT		 44042019-06-19 Tom Tromey <tromey@adacore.com>
4405
4406 * source-cache.c (highlighter): New global.
4407 (source_cache::get_source_lines): Create a highlighter on demand.
4408
494986d5
AB		 44092019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4410
4411 * defs.h (deprecated_interactive_hook): Delete declaration.
4412 * interps.c (clear_interpreter_hooks): Remove use of
4413 deprecated_interactive_hook.
4414 * top.c (deprecated_interactive_hook): Delete definition.
4415 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4416
3360b6e7
TV		 44172019-06-18 Tom de Vries <tdevries@suse.de>
4418
4419 PR gdb/24515
4420 * dwarf2read.h (abstract_to_concrete): Change type from
4421 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4422 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4423 * dwarf2read.c (read_variable): Update.
4424 (dwarf2_fetch_die_loc_sect_off): Update.
4425
310b3441
TV		 44262019-06-17 Tom de Vries <tdevries@suse.de>
4427
4428 PR gdb/24617
4429 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4430 accessing parent[parent_len - 1].
4431
ba9777be
PP		 44322019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4433
4434 PR gdb/24364
4435 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4436 call dtrace_process_dof with NULL dof.
4437
2b9f6e89
TV		 44382019-06-16 Tom de Vries <tdevries@suse.de>
4439
4440 PR gdb/24445
4441 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4442
431b3ead
TT		 44432019-06-16 Tom Tromey <tom@tromey.com>
4444
4445 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4446 (make_all_visible): Use address of member.
4447
d04b44a1
TT		 44482019-06-16 Tom Tromey <tom@tromey.com>
4449
4450 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4451 (tui_free_window, free_content, free_content_elements): Remove
4452 unnecessary cast.
4453 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4454 cast.
4455 * tui/tui-regs.c (tui_show_register_group)
4456 (tui_display_registers_from, tui_display_reg_element_at_line):
4457 Remove unnecessary cast.
4458
bf5142e7
AB		 44592019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4460
4461 * linux-nat.c (normal_mask): Delete.
4462 (_initialize_linux_nat): Don't initialise normal_mask.
4463
c4973306
SM		 44642019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4465
4466 PR gdb/24445
4467 * dwarf-index-write.h (write_psymtabs_to_index): Add
4468 dwz_basename parameter.
4469 * dwarf-index-write.c (write_gdbindex): Move file writing to
4470 write_gdbindex_1. Change return type void.
4471 (assert_file_size): Move up, remove filename parameter.
4472 (write_gdbindex_1): New function.
4473 (write_debug_names): Change return type to void, call
4474 assert_file_size.
4475 (struct index_wip_file): New struct.
4476 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4477 file logic to index_wip_file. Write index for dwz file if
4478 needed.
4479 (save_gdb_index_command): Pass basename of dwz file, if present.
4480 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4481 build-id of dwz file, if present.
4482 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4483 (dwarf2_get_dwz_file): Likewise.
4484 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4485 (dwarf2_get_dwz_file): Likewise.
4486
395f9c91
TT		 44872019-06-16 Tom Tromey <tom@tromey.com>
4488
4489 * coffread.c (process_coff_symbol): Use xstrdup.
4490 * value.c (create_internalvar): Use xstrdup.
4491
cafb3438
TT		 44922019-06-16 Tom Tromey <tom@tromey.com>
4493
4494 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4495 * breakpoint.c (stopin_command, stopat_command)
4496 (until_break_command, decode_location_default): Remove unnecessary
4497 cast.
4498 * utils.c (subset_compare): Remove unnecessary cast.
4499 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4500 cast.
4501 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4502 cast.
4503 * infcmd.c (path_command): Remove unnecessary cast.
4504 * coffread.c (decode_type): Remove unnecessary cast.
4505 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4506 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4507 * tui/tui-stack.c (tui_show_locator_content)
4508 (tui_show_frame_info): Remove unnecessary cast.
4509 * tui/tui-win.c (tui_scroll_forward_command)
4510 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4511 (parse_scrolling_args): Remove unnecessary cast.
4512 * tui/tui-data.c (init_win_info, tui_del_window)
4513 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4514 (free_content_elements): Remove unnecessary cast.
4515 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4516 unnecessary cast.
4517 * tui/tui-source.c (tui_set_source_content)
4518 (tui_vertical_source_scroll): Remove unnecessary cast.
4519 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4520 cast.
4521 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4522 * tui/tui-regs.c (tui_display_registers_from)
4523 (tui_display_register): Remove unnecessary cast.
4524 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4525 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4526 (make_visible): Remove unnecessary cast.
4527 * tui/tui-winsource.c (tui_erase_source_content)
4528 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4529 unnecessary cast.
4530 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4531 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4532 * stabsread.c (read_type, read_array_type, read_range_type):
4533 Remove unnecessary cast.
4534 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4535 (parse_symbol, parse_type, upgrade_type, parse_external)
4536 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4537 unnecessary cast.
4538 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4539
730ead81
TT		 45402019-06-16 Tom Tromey <tom@tromey.com>
4541
4542 * tui/tui-data.c (tui_alloc_generic_win_info)
4543 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4544 checks.
4545
584a927c
AB		 45462019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4547 Andrew Burgess <andrew.burgess@embecosm.com>
4548
4549 * f-typeprint.c (f_print_type): Don't return early for not
4550 associated or not allocated types.
4551 (f_type_print_varspec_suffix): Add print_rank parameter and print
4552 ranks of array types in case they dangling.
4553 (f_type_print_base): Add print_rank parameter.
4554
30056ea0
AB		 45552019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4556
4557 * NEWS: Mention new MI commands.
4558 * break-catch-throw.c (enum exception_event_kind): Move to
4559 breakpoint.h.
4560 (print_mention_exception_catchpoint): Output text as a single
4561 message.
4562 (catch_exception_command_1): Rename to...
4563 (catch_exception_event): ...this, make non-static, update header
4564 command, and change some parameter types.
4565 (catch_catch_command): Update for changes to
4566 catch_exception_command_1.
4567 (catch_throw_command): Likewise.
4568 (catch_rethrow_command): Likewise.
4569 * breakpoint.c (enum exception_event_kind): Delete.
4570 * breakpoint.h (enum exception_event_kind): Moved here from
4571 break-catch-throw.c.
4572 (catch_exception_event): Declare.
4573 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4574 (mi_cmd_catch_throw): New function.
4575 (mi_cmd_catch_rethrow): New function.
4576 (mi_cmd_catch_catch): New function.
4577 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4578 'catch-catch' entries.
4579 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4580 (mi_cmd_catch_rethrow): Declare.
4581 (mi_cmd_catch_catch): Declare.
4582
ec8e2b6d
AB		 45832019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4584
4585 * annotate.c (annotate_source_line): Change return type to void,
4586 update implementation to match.
4587 * annotate.h (annotate_source_line): Change return type to void,
4588 update header comment.
4589 * stack.c (print_frame_info): Don't change what frame information
4590 is printed based on whether annotations are on or not.
4591
0d3abd8c
AB		 45922019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4593
4594 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4595 (annotate_source): Make static.
4596 (annotate_source_line): Moved from source.c and renamed from
4597 identify_source_line. Update the return type.
4598 * annotate.h (annotate_source): Delete declaration.
4599 (annotate_source_line): Declaration moved from source.h, and
4600 renamed from identify_source_line. Return type updated.
4601 * source.c (identify_source_line): Moved to annotate.c and renamed
4602 to annotate_source_line.
4603 (info_line_command): Remove check of annotation_level.
4604 * source.h (identify_source_line): Move declaration to annotate.h
4605 and rename to annotate_source_line.
4606 * stack.c: Add 'annotate.h' include.
4607 (print_frame_info): Remove check of annotation_level before
4608 calling annotate_source_line.
4609
00df30ae
AB		 46102019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4611
4612 * source-cache.c (source_cache::get_plain_source_lines): Use
4613 open_source_file_with_line_charpos instead of just
4614 open_source_file, remove call to find_source_lines.
4615 (source_cache::get_source_lines): Likewise.
4616 * source.c (find_source_lines): Make static.
4617 (get_filename_and_charpos): Renamed into...
4618 (open_source_file_with_line_charpos): ..this along with changes to
4619 return a scoped_fd, and some other minor clean ups.
4620 (identify_source_line): Use open_source_file_with_line_charpos.
4621 (search_command_helper): Use open_source_file_with_line_charpos
4622 instead of just open_source_file, remove call to
4623 find_source_lines.
4624 * source.h (open_source_file_with_line_charpos): Declare new
4625 function.
4626 (find_source_lines): Delete declaration.
4627
afda45a2
AB		 46282019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4629
4630 * source.c (get_filename_and_charpos): Remove fullname
4631 parameter.
4632 (identify_source_line): Update call to get_filename_and_charpos.
4633
0735b091
TT		 46342019-06-14 Tom Tromey <tromey@adacore.com>
4635
4636 PR gdb/24502:
4637 * ui-style.h (skip_ansi_escape): Update comment.
4638 * ui-file.h (class no_terminal_escape_file): New class.
4639 * ui-file.c (no_terminal_escape_file::write)
4640 (no_terminal_escape_file::puts): New methods.
4641 * cli/cli-logging.c (handle_redirections): Use
4642 no_terminal_escape_file.
4643
52ce35e2
TT		 46442019-06-14 Tom Tromey <tromey@adacore.com>
4645
4646 * NEWS: Move convenience variable news above Python news.
4647
73cc7272
TT		 46482019-06-14 Tom Tromey <tom@tromey.com>
4649
4650 * gnulib: Move directory to top-level.
4651 * configure.ac: Don't configure gnulib.
4652 * configure: Rebuild.
4653 * common/common-defs.h: Use new path to gnulib.
4654 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4655 (GNULIB_H): Remove.
4656 (INCGNU): Look in new gnulib location.
4657 (HFILES_NO_SRCDIR): Remove gnulib files.
4658 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4659 (generated_files): Remove GNULIB_H.
4660 ($(LIBGNU), all-lib): Remove targets.
4661 (distclean): Don't mention GNULIB_BUILDDIR.
4662 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4663
f5686554
TT		 46642019-06-14 Tom Tromey <tromey@adacore.com>
4665
4666 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4667 Warn if symbol file does not provide any symbols.
4668
a0c1ffed
TT		 46692019-06-14 Tom Tromey <tromey@adacore.com>
4670
4671 * source.c (find_and_open_source): Respect basenames_may_differ.
4672
7c39e397
AB		 46732019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4674
4675 * annotate.c (annotate_breakpoints_invalid): Make use of
4676 scoped_restore_terminal_state.
4677 (annotate_frames_invalid): Likewise.
4678
f411722c
TT		 46792019-06-14 Tom Tromey <tromey@adacore.com>
4680
4681 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4682 allow assignment to an internalvar.
4683
4268ec18
TT		 46842019-06-14 Tom Tromey <tromey@adacore.com>
4685
4686 * ada-lex.l: Allow "_" in attribute names.
4687
abdb711e
TT		 46882019-06-14 Tom Tromey <tromey@adacore.com>
4689
4690 PR gdb/24653:
4691 * regcache.c (registers_changed): Don't call alloca.
4692 * top.c (execute_command): Don't call alloca.
4693
4c048731
PA		 46942019-06-13 Pedro Alves <palves@redhat.com>
4695
4696 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4697 'expression'. When parsing an expression, error out if there's
4698 junk after "unlimited".
4699 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4700 (do_set_command): Adjust calls to is_unlimited_literal.
4701
66eb1ed3
PA		 47022019-06-13 Pedro Alves <palves@redhat.com>
4703
4704 * compile/compile.c (make_compile_options_def_group): Add braces
4705 around array_view initializer.
4706 * thread.c (make_thread_apply_all_options_def_group)
4707 (make_thread_apply_all_options_def_group): Likewise.
4708
3345721a
PA		 47092019-06-13 Pedro Alves <palves@redhat.com>
4710
4711 * NEWS (New commands): Mention "maint test-options
4712 require-delimiter", "maint test-options unknown-is-error", "maint
4713 test-options unknown-is-operand" and "maint show
4714 test-options-completion-result".
4715 (New command options, command completion): New section.
4716 (Completion improvements): New section.
4717 Mention that you can abbreviate "unlimited".
4718
6206060d
PA		 47192019-06-13 Pedro Alves <palves@redhat.com>
4720
4721 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4722 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4723 * unittests/cli-utils-selftests.c (test_parse_flags)
4724 (test_parse_flags_qcs): Delete.
4725 (test_cli_utils): Don't call deleted functions.
4726
6665660a
PA		 47272019-06-13 Pedro Alves <palves@redhat.com>
4728
4729 * thread.c: Include "cli/cli-option.h".
4730 (tp_array_compar_ascending): Global.
4731 (tp_array_compar): Delete function.
4732 (tp_array_compar_ascending, tp_array_compar_descending): New
4733 functions.
4734 (ascending_option_def, qcs_flag_option_def)
4735 (thr_qcs_flags_option_defs)
4736 (make_thread_apply_all_options_def_group)
4737 (make_thread_apply_options_def_group): New.
4738 (thread_apply_all_command): Use gdb::option::process_options.
4739 (thread_apply_command_completer)
4740 (thread_apply_all_command_completer): New.
4741 (thread_apply_command): Use gdb::option::process_options.
4742 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4743 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4744 to generate help text of "thread apply". Adjust "taas"'s help.
4745 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4746 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4747
f7e13587
PA		 47482019-06-13 Pedro Alves <palves@redhat.com>
4749
4750 * thread.c (thread_apply_command): Check for invalid TID with
4751 isdigit instead of !isalpha.
4752
5d707134
PA		 47532019-06-13 Pedro Alves <palves@redhat.com>
4754
4755 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4756 (validate_flags_qcs): New.
4757 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4758 (validate_flags_qcs): Declare.
4759 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4760 (make_frame_apply_options_def_group): New.
4761 (frame_apply_command_count): Process options with
4762 gdb::option::process_options.
4763 (frame_apply_completer): New.
4764 (frame_apply_level_completer, frame_apply_all_completer)
4765 (frame_apply_completer): New.
4766 (_initialize_stack): Update help of "frame apply", "frame apply
4767 level", "frame apply all" and "faas" to mention supported options
4768 and install command completers.
4769 * stack.h (frame_apply_all_completer): Declare.
4770 * thread.c: Include "stack.h".
4771 (tfaas_command): Add "--".
4772 (_initialize_thread): Update help "tfaas" to mention supported
4773 options and install command completer.
4774
272d4594
PA		 47752019-06-13 Pedro Alves <palves@redhat.com>
4776
4777 * completer.c (complete_nested_command_line): New.
4778 (gdb_completion_word_break_characters_throw): Add assertion.
4779 * completer.h (complete_nested_command_line): Declare.
4780
90a1ef87
PA		 47812019-06-13 Pedro Alves <palves@redhat.com>
4782
4783 * stack.c (parse_backtrace_qualifiers): New.
4784 (backtrace_command): Use it.
4785 (backtrace_command_completer): Complete on qualifiers.
4786
d4c16835
PA		 47872019-06-13 Pedro Alves <palves@redhat.com>
4788
4789 * frame.c: Include "cli/cli-option.h.
4790 (user_set_backtrace_options): New.
4791 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4792 Delete.
4793 (get_prev_frame): Adjust.
4794 (boolean_option_def, uinteger_option_def)
4795 (set_backtrace_option_defs): New.
4796 (_initialize_frame): Adjust and use
4797 gdb::option::add_setshow_cmds_for_options to install "set
4798 backtrace past-main" and "set backtrace past-entry".
4799 * frame.h: Include "cli/cli-option.h".
4800 (struct frame_print_options): Forward declare.
4801 (print_frame_arguments_all, print_frame_arguments_scalars)
4802 (print_frame_arguments_none): Declare.
4803 (print_entry_values): Delete declaration.
4804 (struct frame_print_options, user_frame_print_options): New.
4805 (struct set_backtrace_options): New.
4806 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4807 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4808 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4809 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4810 (list_args_or_locals): Add frame_print_options parameter.
4811 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4812 * python/py-framefilter.c (enumerate_args): Pass down
4813 USER_FRAME_PRINT_OPTIONS.
4814 * stack.c: Include "cli/cli-option.h".
4815 (print_frame_arguments_all, print_frame_arguments_scalars)
4816 (print_frame_arguments_none): Declare.
4817 (print_raw_frame_arguments, print_entry_values): Delete.
4818 (user_frame_print_options): New.
4819 (boolean_option_def, enum_option_def, frame_print_option_defs):
4820 New.
4821 (struct backtrace_cmd_options): New.
4822 (bt_flag_option_def): New.
4823 (backtrace_command_option_defs): New.
4824 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4825 (print_frame_arg, read_frame_arg, print_frame_args)
4826 (print_frame_info, print_frame): Add frame_print_options parameter
4827 and use it.
4828 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4829 (backtrace_command_1): Add frame_print_options and
4830 backtrace_cmd_options parameters and use them.
4831 (make_backtrace_options_def_group): New.
4832 (backtrace_command): Process command options with
4833 gdb::option::process_options.
4834 (backtrace_command_completer): New.
4835 (_initialize_stack): Extend "backtrace"'s help to mention
4836 supported options. Install completer for "backtrace".
4837 Install some settings commands with add_setshow_cmds_for_options.
4838
2daf894e
PA		 48392019-06-13 Pedro Alves <palves@redhat.com>
4840
4841 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4842 and that "set/show print raw frame-arguments" are now deprecated.
4843
4844 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4845 command.
4846 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4847 * stack.c (_initialize_stack): Install "set/show print
4848 raw-frame-arguments", and deprecate "set/show print raw
4849 frame-arguments".
4850 * valprint.c (_initialize_valprint): Deprecate "set/show print
4851 raw".
4852
e6ed716c
PA		 48532019-06-13 Pedro Alves <palves@redhat.com>
4854
4855 * compile/compile.c (struct compile_options): New.
4856 (compile_flag_option_def, compile_command_option_defs)
4857 (make_compile_options_def_group): New.
4858 (compile_file_command): Handle options with
4859 gdb::option::process_options.
4860 (compile_file_command_completer): New function.
4861 (compile_code_command): Handle options with
4862 gdb::option::process_options.
4863 (compile_code_command_completer): New function.
4864 (_initialize_compiler): Install completers for "compile code" and
4865 "compile file". Mention available options in "compile code" and
4866 "compile code"'s help.
4867 * completer.c (advance_to_completion_word): New, factored out from
4868 ...
4869 (advance_to_expression_complete_word_point): ... this.
4870 (advance_to_filename_complete_word_point): New.
4871 * completer.h (advance_to_filename_complete_word_point): New
4872 declaration.
4873
7d8062de
PA		 48742019-06-13 Pedro Alves <palves@redhat.com>
4875
4876 * compile/compile.c: Include "cli/cli-option.h".
4877 (compile_print_value): Scope data pointer is now a
4878 value_print_options pointer; adjust.
4879 (compile_print_command): Process options. Scope data pointer is
4880 now a value_print_options pointer; adjust.
4881 (_initialize_compile): Update "compile print"'s help to include
4882 supported options. Install a completer for "compile print".
4883 * cp-valprint.c (show_vtblprint, show_objectprint)
4884 (show_static_field_print): Delete.
4885 (_initialize_cp_valprint): Don't install "set print
4886 static-members", "set print vtbl", "set print object" here.
4887 * printcmd.c: Include "cli/cli-option.h" and
4888 "common/gdb_optional.h".
4889 (print_command_parse_format): Rework to fill in a
4890 value_print_options instead of a format_data.
4891 (print_value): Change parameter type from format_data pointer to
4892 value_print_options reference. Adjust.
4893 (print_command_1): Process options. Adjust to pass down a
4894 value_print_options.
4895 (print_command_completer): New.
4896 (_initialize_printcmd): Install print_command_completer as
4897 handle_brkchars completer for the "print" command. Update
4898 "print"'s help to include supported options.
4899 * valprint.c: Include "cli/cli-option.h".
4900 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4901 here from cp-valprint.c.
4902 (boolean_option_def, uinteger_option_def)
4903 (value_print_option_defs, make_value_print_options_def_group):
4904 New. Use gdb::option::add_setshow_cmds_for_options to install
4905 "set print elements", "set print null-stop", "set print repeats",
4906 "set print pretty", "set print union", "set print array", "set
4907 print address", "set print symbol", "set print array-indexes".
4908 * valprint.h: Include <string> and "cli/cli-option.h".
4909 (make_value_print_options_def_group): Declare.
4910 (print_value): Change parameter type from format_data pointer to
4911 value_print_options reference.
4912 (print_command_completer): Declare.
4913
9d0faba9
PA		 49142019-06-13 Pedro Alves <palves@redhat.com>
4915
4916 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4917 (COMMON_SFILES): Add maint-test-settings.c.
4918 * cli/cli-decode.c (boolean_enums): New global, factored out from
4919 ...
4920 (add_setshow_boolean_cmd): ... here.
4921 * cli/cli-decode.h (boolean_enums): Declare.
4922 * cli/cli-option.c: New file.
4923 * cli/cli-option.h: New file.
4924 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4925 factored out from ...
4926 (parse_cli_boolean_value(const char *)): ... this.
4927 (is_unlimited_literal): Change parameter type to pointer to
4928 pointer. Adjust and advance ARG pointer.
4929 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4930 (parse_cli_var_enum): New, factored out from ...
4931 (do_set_command): ... this. Adjust.
4932 * cli/cli-setshow.h (parse_cli_boolean_value)
4933 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4934 (parse_cli_var_enum): Declare.
4935 * cli/cli-utils.c: Include "cli/cli-option.h".
4936 (get_ulongest): New.
4937 * cli/cli-utils.h (get_ulongest): Declare.
4938 (check_for_argument): New overloads.
4939 * maint-test-options.c: New file.
4940
2c722807
PA		 49412019-06-13 Pedro Alves <palves@redhat.com>
4942
4943 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4944 parse a range if "-" is at the end of the string.
4945
dee7b4c8
PA		 49462019-06-13 Pedro Alves <palves@redhat.com>
4947
4948 * cli/cli-setshow.c (parse_auto_binary_operation)
4949 (parse_cli_boolean_value): Don't allow "o".
4950
dca0f6c0
PA		 49512019-06-13 Pedro Alves <palves@redhat.com>
4952
4953 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4954 * NEWS: Mention maint test-settings KIND.
4955 * maint-test-settings.c: New file.
4956
597bf39d
PA		 49572019-06-13 Pedro Alves <palves@redhat.com>
4958
4959 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4960 completer.
4961 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4962 "set" completers.
4963
48c410fb
PA		 49642019-06-13 Pedro Alves <palves@redhat.com>
4965
4966 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4967 after item.
4968
93bcb043
PA		 49692019-06-13 Pedro Alves <palves@redhat.com>
4970
4971 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4972
cbba3ecd
PA		 49732019-06-13 Pedro Alves <palves@redhat.com>
4974
4975 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4976 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4977 call.
4978 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4979 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4980 calls.
4981 (check_for_argument): Skip spaces after argument.
4982
b9a3f842
PA		 49832019-06-13 Pedro Alves <palves@redhat.com>
4984
4985 * thread.c (thread_apply_command): Adjust TID parsing.
4986 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4987 detected before end of string.
4988 (tid_is_in_list): Error out if LIST is invalid.
4989
3844e605
PA		 49902019-06-13 Pedro Alves <palves@redhat.com>
4991
4992 * completer.c (complete_line_internal_1): Rewind completion word
4993 point.
4994 (completion_tracker::advance_custom_word_point_by): Change
4995 parameter type to int.
4996 * completer.h (completion_tracker::advance_custom_word_point_by):
4997 Likewise.
4998
00b56dbe
PA		 49992019-06-13 Pedro Alves <palves@redhat.com>
5000
5001 * completer.c (advance_to_completion_word): Handle delimiters.
5002
d106773e
PA		 50032019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5004
5005 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5006
08f10e02
TT		 50072019-06-11 Tom Tromey <tom@tromey.com>
5008
5009 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5010 (xmalloc_failed): Move to alloc.c.
5011 * alloc.c: New file.
5012 * Makefile.in (COMMON_SFILES): Add alloc.c.
5013
1c7fe951
TT		 50142019-06-11 Tom Tromey <tom@tromey.com>
5015
5016 * nat/linux-waitpid.c: Don't include server.h.
5017 (linux_debug): Remove.
5018 (my_waitpid): Update.
5019
89549d7f
TT		 50202019-06-11 Tom Tromey <tromey@adacore.com>
5021
5022 * infcall.c (_initialize_infcall): Remove trailing newline from
5023 help.
5024 * user-regs.c (_initialize_user_regs): Remove trailing newline
5025 from help.
5026 * typeprint.c (_initialize_typeprint): Remove trailing newline
5027 from help.
5028 * reverse.c (_initialize_reverse): Remove trailing newlines from
5029 help.
5030 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5031 from help.
5032 * language.c (add_set_language_command): Remove trailing newline
5033 from help.
5034 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5035 help.
5036 * disasm.c (_initialize_disasm): Remove trailing newline from
5037 help.
5038 * top.c (init_main): Remove trailing newline from help.
5039 * interps.c (_initialize_interpreter): Remove trailing newline
5040 from help.
5041 * btrace.c (_initialize_btrace): Remove trailing newlines from
5042 help.
5043 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5044 from help.
5045 * python/python.c (_initialize_python): Remove trailing newline
5046 from help.
5047 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5048 help.
5049 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5050 from help. Reformat some text.
5051 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5052 from help.
5053 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5054 newline from help.
5055
86108c13
TT		 50562019-06-11 Tom Tromey <tromey@adacore.com>
5057
5058 * darwin-nat.c (darwin_decode_exception_message)
5059 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5060
a7067863
AB		 50612019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5062
5063 * valops.c (value_slice): Check for not allocated or not
5064 associated values.
5065
9ab08412
TV		 50662019-06-10 Tom de Vries <tdevries@suse.de>
5067
5068 PR gdb/24618
5069 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5070 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5071 invalid.
5072
f19e22e9
TV		 50732019-06-10 Tom de Vries <tdevries@suse.de>
5074
5075 PR gdb/24611
5076 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5077 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5078
e99f9db0
TV		 50792019-06-10 Tom de Vries <tdevries@suse.de>
5080
5081 PR symtab/24545
5082 * symtab.c (struct demangled_name_entry): Add language field.
5083 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5084 static minimal symbol". Set and use language field.
5085
9bf7038b
TT		 50862019-06-10 Tom Tromey <tromey@adacore.com>
5087
5088 * ada-lang.c (_initialize_ada_language): Update help text.
5089
422186a9
TT		 50902019-06-10 Tom Tromey <tromey@adacore.com>
5091
5092 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5093 with a newline.
5094 * guile/guile.c (handle_boot_error): Don't end warning with a
5095 newline.
5096 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5097 warning with a newline.
5098 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5099 newline.
5100 (s12z_frame_cache): Likewise.
5101 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5102 a newline.
5103 * solib-svr4.c (disable_probes_interface): Don't end warning with
5104 a newline.
5105 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5106 newline.
5107 * python/python.c (do_finish_initialization): Don't end warning
5108 with a newline.
5109
25ce02ee
TT		 51102019-06-10 Tom Tromey <tom@tromey.com>
5111
5112 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5113 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5114 gdbpy_enter.
5115
caa429d8
TT		 51162019-06-10 Tom Tromey <tromey@adacore.com>
5117
5118 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5119 data.
5120 (elf_new_init): Don't call stabsread_new_init.
5121 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5122 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5123 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5124
81873cc8
TV		 51252019-06-10 Tom de Vries <tdevries@suse.de>
5126
5127 PR symtab/16264
5128 PR symtab/24517
5129 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5130
4fa0265e
РИ		 51312019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5132
5133 * source.c (find_and_open_source): Also rewrite relative file
5134 names.
5135
1a3da2cd
AB		 51362019-04-26 Amos Bird <amosbird@gmail.com>
5137
5138 * annotate.c (annotate_thread_exited): Add "thread-exited"
5139 annotation.
5140
3847a7bf
TT		 51412019-06-06 Tom Tromey <tromey@adacore.com>
5142
5143 * maint.h (class scoped_command_stats): Use
5144 DISABLE_COPY_AND_ASSIGN.
5145 <print_time>: New method.
5146 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5147 print_time.
5148 (scoped_command_stats::print_time): New method.
5149
312617a3
AB		 51502019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5151
5152 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5153 instructions of lengths 6 or 8 bytes.
5154
b02f78f9
PA		 51552019-06-04 Pedro Alves <palves@redhat.com>
5156
5157 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5158
5159 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5160 * breakpoint.c (condition_completer): Likewise.
5161 * cli/cli-dump.c (scan_expression): Likewise.
5162 * common/filestuff.c (mkdir_recursive): Likewise.
5163 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5164 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5165 (gdb_abspath): Likewise.
5166 * compile/compile-cplus-types.c
5167 (compile_cplus_instance::decl_name): Likewise.
5168 * completer.c (complete_explicit_location):
5169 (signal_completer, reg_or_group_completer_1): Likewise.
5170 * cp-support.c (cp_remove_params_if_any): Likewise.
5171 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5172 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5173 * infcmd.c (strip_bg_char): Likewise.
5174 * linespec.c (copy_token_string): Likewise.
5175 * mi/mi-main.c (output_cores): Likewise.
5176 * psymtab.c (psymtab_search_name):
5177 * symfile.c (test_set_ext_lang_command): Likewise.
5178 * target.c (target_fileio_read_stralloc): Likewise.
5179 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5180 * value.c (complete_internalvar): Likewise.
5181
e1f2e1a2
CB		 51822019-06-04 Christian Biesinger <cbiesinger@google.com>
5183
5184 Add objfile property to gdb.Type.
d3238f7d
PA		 5185 * NEWS: Mention Python API addition.
5186 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 5187
e664d728
PW		 51882019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5189
5190 * NEWS: Mention the new set|show style [title|highlight].
5191 Mention changes to "show style", "help" and "apropos".
5192
66d8c862
PW		 51932019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5194
5195 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5196 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5197 instead of print_help_for_command.
5198 (print_doc_of_command): New function.
5199 (help_list): Add 'apropos -v word' suggestion.
5200 (print_help_for_command): Style the command name using title style.
5201 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5202 (_initialize_cli_cmds): Describe -v in apropos_command help.
5203
9303eb2f
PW		 52042019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5205
5206 * cli/cli-style.h (cli_style_option): Add name in constructor,
5207 add m_name class member, add constructor with intensity,
5208 add name class function.
5209 (cli_style_option::add_setshow_commands): Remove name argument.
5210 (highlight_style, title_style): New styles.
5211 * cli/cli-style.c (do_show): New function that shows a style
5212 characteristic styling the style name with itself.
5213 (set_style_name): New function.
5214 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5215 Update all callers according to the changes in cli/cli-style.h.
5216 * utils.h (fputs_highlighted): New function.
5217 * utils.c (fputs_highlighted): Likewise.
5218
e2c52041
PW		 52192019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5220
5221 * NEWS: Mention new pipe command and new convenience variables.
5222
947d3946
PW		 52232019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5224
5225 * cli/cli-cmds.c (pipe_command): New function.
5226 (_initialize_cli_cmds): Call add_com for pipe_command.
5227 Define | as an alias for pipe.
5228 (exit_status_set_internal_vars): New function.
5229 (shell_escape): Call exit_status_set_internal_vars.
5230 cli/cli-decode.c (find_command_name_length): Recognize | as
5231 a single character command.
5232
b8fd0918
PW		 52332019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5234
5235 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5236 top.c (execute_command_to_ui_file): New function, mostly a copy
5237 of execute_command_to_string.
5238 (execute_command_to_string): Implement by calling
5239 execute_command_to_ui_file.
5240
68bb5386
PW		 52412019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5242
5243 * top.h (saved_command_line): Remove declaration.
5244 * top.c (previous_saved_command_line, previous_repeat_arguments):
5245 New variables.
5246 (saved_command_line): Make static, define together with other
5247 'repeat variables'.
5248 (dont_repeat): Clear repeat_arguments.
5249 (repeat_previous, get_saved_command_line, save_command_line):
5250 New functions.
5251 (gdb_init): Initialize saved_command_line
5252 and previous_saved_command_line.
5253 * main.c (captured_main_1): Remove saved_command_line initialization.
5254 * event-top.c (handle_line_of_input): Update to use
5255 the new 'repeat' related functions instead of direct access to
5256 saved_command_line.
5257 * command.h (repeat_previous, get_saved_command_line,
5258 save_command_line): New declarations.
5259 (dont_repeat): Add comment.
5260
bfcdb852
TT		 52612019-05-30 Tom Tromey <tromey@adacore.com>
5262
5263 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5264 Fix comment.
5265 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5266
0ef209f2
JV		 52672019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5268
5269 PR cli/24587
5270 * completer.c (complete): Initialize variable word.
5271
955b06fa
SDJ		 52722019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5273
5274 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5275 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5276 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5277 'body' is NULL to the outter 'if', protecting the '!is_define'
5278 situation as well.
5279
fa9c3fa0
TT		 52802019-05-29 Tom Tromey <tromey@adacore.com>
5281
5282 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5283 (dwarf_unknown): New function.
5284 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5285 (dwarf_type_encoding_name): Use dwarf_unknown.
5286
4330d61d
TT		 52872019-05-29 Tom Tromey <tromey@adacore.com>
5288
5289 PR c++/20020:
5290 * cp-valprint.c (cp_print_value_fields): Call
5291 cp_print_static_field inside "try".
5292
33a6bc35
TT		 52932019-05-29 Tom Tromey <tromey@adacore.com>
5294
5295 * inflow.c (struct terminal_info): Add default operator=.
5296 * configure: Rebuild.
5297 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5298 -Wdeprecated-copy-dtor, -Wredundant-move.
5299
000439d5
TT		 53002019-05-29 Tom Tromey <tromey@adacore.com>
5301
5302 * NEWS: Add entry.
5303 * infcmd.c (print_return_value_1): Handle finish_print
5304 option.
5305 (show_print_finish): New function.
5306 (_initialize_infcmd): Add "set/show print finish" commands.
5307 * valprint.c (user_print_options): Initialize new member.
5308 * valprint.h (struct value_print_options) <finish_print>: New
5309 member.
5310
c0e70c62
TT		 53112019-05-28 Tom Tromey <tromey@adacore.com>
5312
5313 * ada-lang.c (ada_remove_Xbn_suffix)
5314 (find_old_style_renaming_symbol)
5315 (parse_old_style_renaming): Remove.
5316 (ada_find_renaming_symbol): Don't call
5317 find_old_style_renaming_symbol.
5318 (ada_is_renaming_symbol): Rename from
5319 ada_find_renaming_symbol. Remove "block" parameter. Return
5320 bool. Now static.
5321 (ada_read_var_value): Update and simplify.
5322 * ada-exp.y (write_var_or_type): Remove old code.
5323
766f8836
AH		 53242019-05-28 Alan Hayward <alan.hayward@arm.com>
5325
5326 * event-top.c: Remove include comment.
5327 * inflow.c (class scoped_ignore_sigttou): Move from here...
5328 * inflow.h (class scoped_ignore_sigttou): ...to here.
5329 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5330 * top.c: Remove include comment.
5331
eb41253a
TT		 53322019-05-27 Tom Tromey <tom@tromey.com>
5333
5334 * NEWS: Fix typo.
5335
4ca51187
TT		 53362019-05-22 Tom Tromey <tromey@adacore.com>
5337
5338 * target.c (target_follow_exec): Constify parameter.
5339 * target-delegates.c: Rebuild.
5340 * remote.c (remote_target::follow_exec): Constify parameter.
5341 * infrun.c (follow_exec): Constify parameter.
5342 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5343 (target_follow_exec): Likewise.
5344
8fca4da0
AH		 53452019-05-22 Alan Hayward <alan.hayward@arm.com>
5346
5347 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5348 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5349
b7060614
AH		 53502019-05-22 Alan Hayward <alan.hayward@arm.com>
5351
5352 * NEWS: Add debugredirect and testsuite sections.
5353
0a5954bd
SC		 53542019-05-22 Simon Cook <simon.cook@embecosm.com>
5355
5356 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5357 target descriptions using exclusively floating point register name
5358 aliases.
5359
dc42e902
AB		 53602019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5361
5362 PR gdb/18644:
5363 * f-lang.c (build_fortran_types): Handle the case where
5364 gdbarch_floatformat_for_type returns a nullptr.
5365
fb7806c7
TV		 53662019-05-21 Tom de Vries <tdevries@suse.de>
5367
5368 PR cli/24587
5369 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5370
34d11c68
AB		 53712019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5372
5373 PR gdb/18644:
5374 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5375 16-byte floats.
5376 * i386-tdep.c (i386_floatformat_for_type): Use
5377 floatformats_ia64_quad for the 16-byte floating point component
5378 within a fortran 32-byte complex number.
5379
122cf0f2
AB		 53802019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5381
5382 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5383 delete default constructor.
5384 (find_partial_die): Update to return const struct.
5385 (partial_die_parent_scope): Move variable declaration into scope
5386 of its use and change its type to auto.
5387 (guess_partial_die_structure_name): Likewise.
5388 (partial_die_info::fixup): Likewise.
5389
33d0e35a
TT		 53902019-05-17 Tom Tromey <tromey@adacore.com>
5391
5392 * source.c (find_and_open_source): Remove cast.
5393
a45575b0
TT		 53942019-05-17 Tom Tromey <tromey@adacore.com>
5395
5396 * annotate.c (annotate_source): Make "filename" const.
5397 * annotate.h (annotate_source): Use const.
5398
81f47ac2
AH		 53992019-05-17 Alan Hayward <alan.hayward@arm.com>
5400
5401 * disasm.c (set_disassembler_options): Send errors to stderr.
5402
ca1285d1
AH		 54032019-05-17 Alan Hayward <alan.hayward@arm.com>
5404
5405 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5406 (cli_interp_base::set_logging): Check debug_redirect.
5407 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5408 * cli/cli-logging.c (debug_redirect): Add static variable.
5409 (pop_output_files): Add default param.
5410 (handle_redirections): Print debug setting.
5411 (show_logging_command): Likewise.
5412 (_initialize_cli_logging): Add debugredirect command.
5413 * interps.c (current_interp_set_logging): Add debug_redirect
5414 parameter.
5415 * interps.h (set_logging): Add debug_redirect parameter.
5416 (current_interp_set_logging): Likewise.
5417 * mi/mi-common.h: Likewise.
5418 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5419
54202019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 5421 Tom Tromey <tromey@adacore.com>
5422
5423 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5424 directly.
5425 * cli/cli-interp.h (make_logging_output): Remove declaration.
5426 * cli/cli-logging.c (make_logging_output): Remove function.
5427 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5428 directly.
5429 * ui-file.c (tee_file::tee_file): Remove bools.
5430 (tee_file::~tee_file): Remove deletes.
5431 * ui-file.h (tee_file): Remove bools.
5432
26648588
JV		 54332019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5434
5435 * mi/mi-cmds.h (mi_cmd_complete): New function.
5436 * mi/mi-main.c (mi_cmd_complete): Likewise.
5437 * mi/mi-cmds.c: Define new MI command -complete.
5438 * NEWS: Mention new -complete command.
5439
6e035501
JV		 54402019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5441
5442 * completer.h (complete): New function.
5443 * completer.c (complete): Likewise.
5444 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5445 function defined in completer.h.
5446
7d0e2ece
JV		 54472019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5448
e79be6e5 5449 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 5450
fb816e8b
TV		 54512019-05-17 Tom de Vries <tdevries@suse.de>
5452
5453 PR gdb/24094
5454 * dwarf2read.c (struct cu_partial_die_info): New struct.
5455 (find_partial_die): Return cu_partial_die_info.
5456 (partial_die_parent_scope, guess_partial_die_structure_name)
5457 (partial_die_info::fixup): Handle new return type of find_partial_die.
5458
677052f2
SDJ		 54592019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5460
5461 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5462 "std::string", simplifying the algorithm.
5463
f3da9116
SDJ		 54642019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5465
5466 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5467 (stap_static_probe_ops::get_probes): Likewise.
5468
f1bb75ab
SDJ		 54692019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5470
5471 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5472 '-')" and "else if".
5473 (stap_parse_single_operand): Join checks for
5474 "gdbarch_stap_parse_special_token_p" and
5475 "gdbarch_stap_parse_special_token" in the same "if" statement.
5476 Invert check when verifying for operation on register
5477 displacement.
5478
3ca58cde
SDJ		 54792019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5480
5481 * stap-probe.c (stap_get_opcode): Update comment.
5482 (stap_get_expected_argument_type): Likewise.
5483 (handle_stap_probe): Likewise.
5484
af2d9bee
SDJ		 54852019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5486
5487 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5488 return type to 'bool'. Adjust comment. Use 'bool' when
5489 appropriate.
5490 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5491 * stap-probe.c (stap_parse_argument_1): Likewise.
5492 (stap_is_operator): Likewise.
5493 (stap_is_generic_prefix): Likewise.
5494 (stap_is_register_prefix): Likewise.
5495 (stap_is_register_indirection_prefix): Likewise.
5496 (stap_is_integer_prefix): Likewise.
5497 (stap_generic_check_suffix): Likewise.
5498 (stap_check_integer_suffix): Likewise.
5499 (stap_check_register_suffix): Likewise.
5500 (stap_check_register_indirection_suffix): Likewise.
5501 (stap_parse_register_operand): Likewise.
5502 (stap_parse_single_operand): Likewise.
5503 (stap_parse_argument_1): Likewise.
5504 (stap_probe::get_argument_count): Likewise.
5505 (stap_is_operator): Likewise.
5506
61c9c421
TT		 55072019-05-16 Tom Tromey <tromey@adacore.com>
5508
5509 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5510 keyword to foreach.
5511
9ddc1af1
SM		 55122019-05-15 Simon Marchi <simon.marchi@efficios.com>
5513
5514 * linux-thread-db.c (try_thread_db_load_1): Change return type
5515 to bool.
5516 (try_thread_db_load): Likewise.
5517 (try_thread_db_load_from_pdir_1): Likewise.
5518 (try_thread_db_load_from_pdir): Likewise.
5519 (try_thread_db_load_from_sdir): Likewise.
5520 (try_thread_db_load_from_dir): Likewise.
5521 (thread_db_load_search): Likewise.
5522 (has_libpthread): Likewise.
5523 (thread_db_load): Likewise.
5524
7bede828
SDJ		 55252019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5526
5527 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5528 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5529 NULL, and complain/return if that's the case.
5530
c5358db4
JD		 55312019-05-15 John Darrington <john@darrington.wattle.id.au>
5532
5533 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5534 (advance, posn, abstract_read_memory): New functions.
5535 [struct mem_read_abstraction]: New struct.
5536 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5537
c408a94f
TT		 55382019-05-14 Tom Tromey <tromey@adacore.com>
5539
5540 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5541 value is not lval_memory.
5542
e7bd7fba
TT		 55432019-05-14 Tom Tromey <tromey@adacore.com>
5544
5545 * solib.c (info_sharedlibrary_command): Style the file name.
5546
a6d0f249
AH		 55472019-05-14 Alan Hayward <alan.hayward@arm.com>
5548
5549 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5550 (aarch64_vnv_type): Likewise.
5551 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5552 * common/tdesc.c: Likewise.
5553 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5554 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5555 * features/aarch64-fpu.xml: Add ieee half view.
5556 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5557 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5558 * gdbtypes.h (struct builtin_type): Likewise.
5559 (struct objfile_type): Likewise.
5560
66b8bb74
SM		 55612019-05-12 Paul Naert <paul.naert@polymtl.ca>
5562
5563 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5564 typo.
5565 * location.h (string_to_event_location): Likewise.
5566
21c219fd
JB		 55672019-05-11 Joel Brobecker <brobecker@adacore.com>
5568
5569 GDB 8.3 released.
5570
13674803
SM		 55712019-05-10 Simon Marchi <simon.marchi@efficios.com>
5572
5573 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5574 New variable declaration.
5575 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5576 New variable.
5577 (print_one_breakpoint): Use ui_out::test_flags and new global
5578 variable to compute use_fixed_output.
5579 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5580 Remove.
5581 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5582 (mi_multi_location_breakpoint_output_fixed): Remove.
5583 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5584 new variable.
5585 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5586 fix_multi_location_breakpoint_output flag if version >= 3.
5587 * ui-out.h (enum ui_out_flag)
5588 <fix_multi_location_breakpoint_output>: New enumerator.
5589
a9eac7f9
SM		 55902019-05-10 Simon Marchi <simon.marchi@efficios.com>
5591
5592 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5593
71bed2db
TT		 55942019-05-10 Tom Tromey <tromey@adacore.com>
5595
5596 * ada-lang.c (catch_ada_completer): New function.
5597 (_initialize_ada_language): Use it.
5598
24c54127
TT		 55992019-05-10 Tom Tromey <tromey@adacore.com>
5600
5601 * thread.c (print_thread_info): Make "requested_threads" const.
5602 * gdbthread.h (print_thread_info): Make "requested_threads"
5603 const.
5604 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5605 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5606
7a102139
TT		 56072019-05-08 Tom Tromey <tom@tromey.com>
5608
5609 * gdbtypes.c (objfile_type_data): Change type.
5610 (objfile_type, _initialize_gdbtypes): Update.
5611
924d79e2
TT		 56122019-05-08 Tom Tromey <tom@tromey.com>
5613
5614 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5615 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5616 (_initialize_dwarf2_frame): Update.
5617
4c58e337
TT		 56182019-05-08 Tom Tromey <tom@tromey.com>
5619
5620 * objc-lang.c (objc_objfile_data): Change type.
5621 (find_methods): Update.
5622 (_initialize_objc_lang): Remove.
5623
d772d2ab
TT		 56242019-05-08 Tom Tromey <tom@tromey.com>
5625
5626 * stabsread.c (rs6000_builtin_type_data): Change type.
5627 (rs6000_builtin_type, _initialize_stabsread): Update.
5628
d11d83f4
TT		 56292019-05-08 Tom Tromey <tom@tromey.com>
5630
5631 * mips-tdep.c (mips_pdr_data): Remove.
5632 (_initialize_mips_tdep): Update.
5633
9a73f0ad
TT		 56342019-05-08 Tom Tromey <tom@tromey.com>
5635
5636 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5637 (hppa_init_objfile_priv_data, read_unwind_info)
5638 (find_unwind_entry, _initialize_hppa_tdep): Update.
5639
8127a2fa
TT		 56402019-05-08 Tom Tromey <tom@tromey.com>
5641
5642 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5643 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5644 on obstack.
5645 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5646
91d3055d
TT		 56472019-05-08 Tom Tromey <tom@tromey.com>
5648
5649 * mdebugread.c (basic_type_data): Change type.
5650 (basic_type, _initialize_mdebugread): Update.
5651
31930bd3
TT		 56522019-05-08 Tom Tromey <tom@tromey.com>
5653
5654 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5655
bdb3ed9e
TT		 56562019-05-08 Tom Tromey <tom@tromey.com>
5657
5658 * nto-tdep.c (nto_inferior_data_reg): Change type.
5659 (nto_inferior_data): Update.
5660 (nto_inferior_data_cleanup, nto_new_inferior_data)
5661 (_initialize_nto_tdep): Remove.
5662 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5663
f37b313d
TT		 56642019-05-08 Tom Tromey <tom@tromey.com>
5665
5666 * ada-lang.c (struct ada_inferior_data): Add initializers.
5667 (ada_inferior_data): Change type.
5668 (ada_inferior_data_cleanup): Remove.
5669 (get_ada_inferior_data, ada_inferior_exit)
5670 (struct ada_pspace_data): Add initializers, destructor.
5671 (ada_pspace_data_handle): Change type.
5672 (get_ada_pspace_data): Update.
5673 (ada_pspace_data_cleanup): Remove.
5674
24699405
TT		 56752019-05-08 Tom Tromey <tom@tromey.com>
5676
5677 * coffread.c (struct coff_symfile_info): Add initializers.
5678 (coff_objfile_data_key): Move lower. Change type.
5679 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5680 Update.
5681 (coff_free_info): Remove.
5682
d4e05d2f
TT		 56832019-05-08 Tom Tromey <tom@tromey.com>
5684
5685 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5686 (fbsd_pspace_data_handle): Move lower. Change type.
5687 (get_fbsd_pspace_data): Update.
5688 (fbsd_pspace_data_cleanup): Remove.
5689 (_initialize_fbsd_tdep): Update.
5690
14ef6690
TT		 56912019-05-08 Tom Tromey <tom@tromey.com>
5692
5693 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5694 (get_ada_tasks_pspace_data): Update.
5695 (ada_tasks_pspace_data_cleanup): Remove.
5696 (_initialize_tasks): Update.
5697 (ada_tasks_inferior_data_handle): Change type.
5698 (get_ada_tasks_inferior_data): Update.
5699 (ada_tasks_inferior_data_cleanup): Remove.
5700 (struct ada_tasks_pspace_data): Add initializers.
5701
814cf43a
TT		 57022019-05-08 Tom Tromey <tom@tromey.com>
5703
5704 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5705 * symfile-debug.c (debug_sym_get_probes): Change type.
5706 * stap-probe.c (handle_stap_probe):
5707 (stap_static_probe_ops::get_probes): Change type.
5708 * probe.h (class static_probe_ops) <get_probes>: Change type.
5709 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5710 (parse_probes_in_pspace): Update.
5711 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5712 Update.
5713 (any_static_probe_ops::get_probes): Change type.
5714 * elfread.c (elfread_data): New typedef.
5715 (probe_key): Change type.
5716 (elf_get_probes): Likewise. Update.
5717 (probe_key_free): Remove.
5718 (_initialize_elfread): Update.
5719 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5720 Change type.
5721 (dtrace_process_dof_probe, dtrace_process_dof)
5722 (dtrace_static_probe_ops::get_probe): Change type.
5723
02dc647e
TT		 57242019-05-08 Tom Tromey <tom@tromey.com>
5725
5726 * xcoffread.c (struct xcoff_symfile_info): Rename from
5727 coff_symfile_info. Add initializers.
5728 (xcoff_objfile_data_key): Move lower. Change type.
5729 (XCOFF_DATA): Rewrite.
5730 (xcoff_free_info): Remove.
5731 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5732 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5733 (xcoff_initial_scan): Update.
5734
09232438
TT		 57352019-05-08 Tom Tromey <tom@tromey.com>
5736
5737 * solib-svr4.c (struct svr4_info): Add initializers and
5738 destructor.
5739 <probes_table>: Now an htab_up.
5740 (solib_svr4_pspace_data): Change type.
5741 (free_probes_table): Simplify.
5742 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5743 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5744 (probes_table_remove_objfile_probes, register_solib_event_probe)
5745 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5746 (_initialize_svr4_solib): Update.
5747
7b4a314f
TT		 57482019-05-08 Tom Tromey <tom@tromey.com>
5749
5750 * remote.c (remote_pspace_data): Change type.
5751 (remote_pspace_data_cleanup): Remove.
5752 (get_remote_exec_file, set_pspace_remote_exec_file)
5753 (_initialize_remote): Update.
5754
51d3063a
TT		 57552019-05-08 Tom Tromey <tom@tromey.com>
5756
5757 * breakpoint.c (breakpoint_objfile_key): Change type.
5758 (get_breakpoint_objfile_data): Update.
5759 (free_breakpoint_objfile_data): Remove.
5760 (_initialize_breakpoint): Update.
5761
89fb8848
TT		 57622019-05-08 Tom Tromey <tom@tromey.com>
5763
5764 * linux-tdep.c (struct linux_info): Add initializers.
5765 (linux_inferior_data): Move. Change type.
5766 (invalidate_linux_cache_inf): Update.
5767 (linux_inferior_data_cleanup): Remove.
5768 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5769
e9b89e2d
TT		 57702019-05-08 Tom Tromey <tom@tromey.com>
5771
5772 * auxv.c (auxv_inferior_data): Move. Change type.
5773 (auxv_inferior_data_cleanup): Remove.
5774 (invalidate_auxv_cache_inf): Rewrite.
5775 (get_auxv_inferior_data, _initialize_auxv): Update.
5776
8c42777c
TT		 57772019-05-08 Tom Tromey <tom@tromey.com>
5778
5779 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5780 (symfile_debug_objfile_data_key): Change type.
5781 (symfile_debug_installed, debug_qf_has_symbols)
5782 (debug_qf_find_last_source_symtab)
5783 (debug_qf_forget_cached_source_info)
5784 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5785 (debug_qf_print_stats, debug_qf_dump)
5786 (debug_qf_expand_symtabs_for_function)
5787 (debug_qf_expand_all_symtabs)
5788 (debug_qf_expand_symtabs_with_fullname)
5789 (debug_qf_map_matching_symbols)
5790 (debug_qf_expand_symtabs_matching)
5791 (debug_qf_find_pc_sect_compunit_symtab)
5792 (debug_qf_map_symbol_filenames)
5793 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5794 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5795 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5796 (debug_sym_read_linetable, debug_sym_relocate): Update.
5797 (symfile_debug_free_objfile): Remove.
5798 (install_symfile_debug_logging, _initialize_symfile_debug):
5799 Update.
5800
5bfd760d
TT		 58012019-05-08 Tom Tromey <tom@tromey.com>
5802
5803 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5804 allocate_on_obstack.
5805 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5806 (get_dwarf2_per_objfile): Update.
5807 (set_dwarf2_per_objfile): Remove.
5808 (dwarf2_has_info, dwarf2_get_section_info): Update.
5809 (dwarf2_free_objfile): Remove.
5810 (_initialize_dwarf2_read): Update.
5811
e85e19b4
TT		 58122019-05-08 Tom Tromey <tom@tromey.com>
5813
5814 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5815 initializers.
5816 <unsupported_script_warning_printed,
5817 script_not_found_warning_printed>: Now bool.
5818 (auto_load_pspace_data): Change type.
5819 (~auto_load_pspace_info): Rename from
5820 auto_load_pspace_data_cleanup.
5821 (get_auto_load_pspace_data, init_loaded_scripts_info)
5822 (clear_section_scripts, maybe_print_unsupported_script_warning)
5823 (maybe_print_script_not_found_warning, _initialize_auto_load):
5824 Update.
5825
f6aa7436
TT		 58262019-05-08 Tom Tromey <tom@tromey.com>
5827
5828 * objfiles.c (objfile_pspace_info): Add destructor and
5829 initializers.
5830 (objfiles_pspace_data): Change type.
5831 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5832 (get_objfile_pspace_data): Update.
5833 (objfiles_bfd_data): Change type.
5834 (get_objfile_bfd_data): Update.
5835 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5836
6ae614f6
TT		 58372019-05-08 Tom Tromey <tom@tromey.com>
5838
5839 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5840 Change type.
5841 (get_catch_syscall_inferior_data): Update.
5842 (catch_syscall_inferior_data_cleanup): Remove.
5843 (_initialize_break_catch_syscall): Update.
5844
6509b8eb
TT		 58452019-05-08 Tom Tromey <tom@tromey.com>
5846
5847 * inflow.c (struct terminal_info): Add destructor and
5848 initializers.
5849 (inflow_inferior_data): Change type.
5850 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5851 (get_inflow_inferior_data, inflow_inferior_exit)
5852 (swap_terminal_info, _initialize_inflow): Update.
5853
35632941
TT		 58542019-05-08 Tom Tromey <tom@tromey.com>
5855
5856 * target-dcache.c (target_dcache_cleanup): Remove.
5857 (target_dcache_aspace_key): Change type.
5858 (target_dcache_init_p, target_dcache_invalidate)
5859 (target_dcache_get, target_dcache_get_or_init)
5860 (_initialize_target_dcache): Update.
5861 * dcache.h (struct dcache_deleter): New.
5862
3017b94d
TT		 58632019-05-08 Tom Tromey <tom@tromey.com>
5864
5865 * symtab.c (struct symbol_cache): Add destructor and
5866 initializers.
5867 (symbol_cache_key): Move. Change type.
5868 (make_symbol_cache, free_symbol_cache): Remove.
5869 (get_symbol_cache): Update.
5870 (symbol_cache_cleanup): Remove.
5871 (ALL_PSPACES, symbol_cache_flush)
5872 (maintenance_print_symbol_cache)
5873 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5874 Update.
5875
a32ad8c5
TT		 58762019-05-08 Tom Tromey <tom@tromey.com>
5877
5878 * symtab.c (struct main_info): Add destructor and initializers.
5879 (main_progspace_key): Move. Change type.
5880 (get_main_info): Update.
5881 (main_info_cleanup): Remove.
5882 (_initialize_symtab): Update.
5883
5f6e90a0
TT		 58842019-05-08 Tom Tromey <tom@tromey.com>
5885
5886 * registry.h (DECLARE_REGISTRY): Define the _key class.
5887
1bd0c6e4
AB		 58882019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5889
5890 * NEWS: Merge two 'New commands' sections.
5891
2228ef77
XR		 58922019-05-08 Joel Brobecker <brobecker@adacore.com>
5893
5894 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5895 parameter and use Ada language definition instead.
5896 (ada_val_print_ptr): Remove unused language parameter.
5897 (ada_val_print_num): Remove language parameter and use Ada language
5898 definition instead.
5899 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5900 parameter.
5901 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5902 parameter and use Ada language definition instead.
5903 (ada_val_print_1): Update all ada_val_print_xxx calls.
5904 Remove language parameter.
5905 (ada_val_print): Update ada_val_print_1 call.
5906
60fcc1c3
TT		 59072019-05-08 Tom Tromey <tromey@adacore.com>
5908
5909 * remote.c (remote_hw_watchpoint_limit)
5910 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5911 Now static.
5912
ed2b7c17
TT		 59132019-05-08 Tom Tromey <tromey@adacore.com>
5914
5915 * maint.c (_initialize_maint_cmds): Move initialization code to
5916 remote.c.
5917 (watchdog, show_watchdog): Move to remote.c.
5918 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5919 "watchdog" static.
5920 (_initialize_remote): Move initialization code from maint.c.
5921 * defs.h (watchdog): Don't declare.
5922
b0be6c91
TT		 59232019-05-08 Tom Tromey <tromey@adacore.com>
5924
5925 * tui/tui-interp.c: Include main.h.
5926 * interps.c: Include main.h.
5927 * main.h (interpreter_p): Declare.
5928 * defs.h (interpreter_p): Don't declare.
5929
587ee17b
TT		 59302019-05-08 Tom Tromey <tromey@adacore.com>
5931
5932 * dwarf2loc.c: Include dwarf2read.h.
5933 * defs.h (read_unsigned_leb128): Don't declare.
5934 * dwarf2read.h (read_unsigned_leb128): Declare.
5935
ca1df239
TT		 59362019-05-08 Tom Tromey <tromey@adacore.com>
5937
5938 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5939 method.
5940
99f20f08
TT		 59412019-05-08 Tom Tromey <tromey@adacore.com>
5942
5943 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5944 when no wrap column is set.
5945
80e55b13
TT		 59462019-05-08 Tom Tromey <tromey@adacore.com>
5947
5948 * c-lang.c (c_get_string): Handle non-C-style arrays.
5949
9d3421af
TT		 59502019-05-08 Tom Tromey <tromey@adacore.com>
5951
5952 * typeprint.c (print_offset_data::update): Print the bit offset,
5953 not the number of bits remaining.
5954
844333e2
TT		 59552019-05-08 Tom Tromey <tromey@adacore.com>
5956
5957 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5958 padding at end of comment.
5959
988915ee
TT		 59602019-05-08 Tom Tromey <tromey@adacore.com>
5961
5962 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5963 Compare main types.
5964
26bfd823
TT		 59652019-05-06 Tom Tromey <tom@tromey.com>
5966
5967 * common/scoped_mmap.c: Include common-defs.h.
5968 * common/scoped_mmap.h: Don't include config.h.
5969
89055eaa
TT		 59702019-05-04 Tom Tromey <tom@tromey.com>
5971
5972 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5973 (struct aarch64_call_info): Add initializers.
5974 <si>: Now a std::vector.
5975 (pass_on_stack, aarch64_push_dummy_call): Update.
5976
5da01df5
TT		 59772019-05-04 Simon Marchi <simon.marchi@efficios.com>
5978 Tom Tromey <tom@tromey.com>
5979
5980 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5981 (ppc_threads): Now a std::vector. Now static.
5982 (hwdebug_find_thread_points_by_tid)
5983 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5984 Update.
5985
fbdf05a1
TT		 59862019-05-04 Tom Tromey <tom@tromey.com>
5987
5988 * arc-tdep.c (arc_tdesc_init): Return bool.
5989
06d16ec9
TT		 59902019-05-04 Tom Tromey <tom@tromey.com>
5991
5992 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5993 Use gdb_assert_not_reached.
5994
9c056022
TT		 59952019-05-04 Tom Tromey <tom@tromey.com>
5996
5997 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5998 "false".
5999
fa9c2a59
TT		 60002019-05-04 Tom Tromey <tom@tromey.com>
6001
6002 * arc-tdep.c (arc_tdesc_init): Use bool.
6003
e2eb806a
TT		 60042019-05-04 Tom Tromey <tom@tromey.com>
6005
6006 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6007
6fe87677
TT		 60082019-05-04 Tom Tromey <tom@tromey.com>
6009
6010 * cli/cli-cmds.c (valid_command_p): Return bool.
6011
7f008c9e
TT		 60122019-05-04 Tom Tromey <tom@tromey.com>
6013
6014 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6015 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6016
b6484282
RT		 60172019-05-04 Raul Tambre <raul@tambre.ee>
6018
6019 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6020 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6021 operator for comparison.
6022
af97b416
TT		 60232019-05-04 Tom Tromey <tom@tromey.com>
6024
6025 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6026 (lookup_partial_symbol, print_partial_symbols)
6027 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6028 (psymbol_compare): Update.
6029 (add_psymbol_to_bcache): Clear the entire psymbol.
6030 (maintenance_check_psymtabs): Update.
6031 * psympriv.h (struct partial_symbol): Don't derive from
6032 general_symbol_info.
6033 <obj_section, unrelocated_address, address,
6034 set_unrelocated_address>: Update.
6035 <ginfo>: New member.
6036 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6037 (debug_names::write_psymbols): Update.
6038
9d6d4be8
TV		 60392019-05-04 Tom de Vries <tdevries@suse.de>
6040
6041 * contrib/cc-with-tweaks.sh: Support -n arg.
6042
66452beb
PW		 60432019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6044
6045 * corelow.c (core_target::detach): Ensure frame cache and
6046 register caches are cleared.
6047 inferior.c (exit_inferior_1): Likewise.
6048
bde09ab7
TT		 60492019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6050 Tom Tromey <tom@tromey.com>
6051
6052 * dictionary.c (collate_pending_symbols_by_language): Remove
6053 "struct" from foreach.
6054 * symtab.c (lookup_global_symbol_from_objfile)
6055 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6056 foreach.
6057 * ser-tcp.c (net_open): Remove "struct" from foreach.
6058 * objfiles.c (objfile_relocate, objfile_rebase)
6059 (objfile_has_symbols): Remove "struct" from foreach.
6060 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6061 from foreach.
6062 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6063 foreach.
6064 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6065 "struct" from foreach.
6066 * ada-lang.c (create_excep_cond_exprs)
6067 (ada_exception_catchpoint_cond_string): Remove "struct" from
6068 foreach.
6069
222a8d25
TT		 60702019-05-03 Tom Tromey <tromey@adacore.com>
6071
6072 * ada-exp.y (convert_char_literal): Check suffix of each
6073 enumerator.
6074
fcd60b84
DP		 60752019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6076
6077 PR ada/21406:
6078 * ada-exp.y (yywrap): Don't define.
6079 * ada-lex.l (%option): Add noyywrap
6080 (yywrap): Remove.
6081
5f2459c2
EZ		 60822019-05-03 Eli Zaretskii <eliz@gnu.org>
6083
353ea2d1
EZ		 6084 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6085 _WIN32_WINNT to the XP level, unless already defined to a higher
6086 level.
6087
6088 * unittests/parse-connection-spec-selftests.c:
6089 * ser-tcp.c:
6090 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6091 override.
6092
5f2459c2
EZ		 6093 * symfile.c (find_separate_debug_file): Remove colon from the
6094 drive spec of DOS/Windows file names of the target, so that the
6095 file name produced from DEBUGDIR and the target's directory will
6096 be valid on DOS/Windows systems.
6097
80062eb9
AB		 60982019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6099
6100 * rust-lang.c (val_print_struct): Handle printing structures
6101 containing strings.
6102
b8c05e85
TT		 61032019-05-02 Tom Tromey <tromey@adacore.com>
6104
6105 * valarith.c (_initialize_valarith): Remove.
6106
4504bbde
TT		 61072019-05-01 Tom Tromey <tromey@adacore.com>
6108
6109 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6110 bitfields.
6111
d48e62f4
TT		 61122019-05-01 Tom Tromey <tromey@adacore.com>
6113
6114 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6115 for big-endian copies.
6116
15f18d14
AT		 61172019-04-30 Ali Tamur <tamur@google.com>
6118 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6119 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6120 (read_3_bytes): New function.
6121
ab4ee614
JB		 61222019-04-30 Joel Brobecker <brobecker@adacore.com>
6123
6124 * windows-nat.c (main_thread_id): Delete.
6125 (handle_output_debug_string): Replace main_thread_id by
6126 current_event.dwThreadId.
6127 (fake_create_process): Likewise.
6128 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6129 Do not set main_thread_id.
6130 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6131 current_event.dwThreadId.
6132 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6133
8ed5b76e
JB		 61342019-04-30 Joel Brobecker <brobecker@adacore.com>
6135
6136 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6137 Use current_event.dwThreadId instead of main_thread_id.
6138
2ff0a947
TT		 61392019-04-30 Tom Tromey <tromey@adacore.com>
6140
6141 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6142 (create_excep_cond_exprs): Iterate over program spaces.
6143 (ada_exception_catchpoint_cond_string): Examine all minimal
6144 symbols for exception types.
6145
a776957c
TT		 61462019-04-30 Tom Tromey <tromey@adacore.com>
6147
6148 PR c++/24470:
6149 * dwarf2read.c (process_structure_scope): Handle case where type
6150 has template parameters but no symbol was created.
6151
bc68014d
AB		 61522019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6153 Chris January <chris.january@arm.com>
6154
6155 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6156 qualifier.
6157 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6158
f1fdc960
AB		 61592019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6160
6161 * f-typeprint.c (f_print_type): Update rules for printing
6162 whitespace.
6163 (f_type_print_varspec_suffix): Likewise.
6164
bf7a4de1
AB		 61652019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6166 Chris January <chris.january@arm.com>
6167
6168 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6169 function arguments.
6170
bbe75b9d
AB		 61712019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6172
6173 * f-lang.c (build_fortran_types): Change name of void type to
6174 lower case.
6175 * f-typeprint.c (f_type_print_base): Print the name of the void
6176 type, rather than a fixed string.
6177 * f-valprint.c (f_decorations): Use lower case void string.
6178
1db455a7
AB		 61792019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6180 Chris January <chris.january@arm.com>
6181
6182 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6183 types for Fortran.
6184
b6d03bb2
AB		 61852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6186 Chris January <chris.january@arm.com>
6187 David Lecomber <david.lecomber@arm.com>
6188
6189 * f-exp.y (BINOP_INTRINSIC): New token.
6190 (exp): New parser rule handling BINOP_INTRINSIC.
6191 (f77_keywords): Add new builtin procedures.
6192 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6193 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6194 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6195 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6196 (print_unop_subexp_f): New function.
6197 (print_binop_subexp_f): New function.
6198 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6199 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6200 (dump_subexp_body_f): Likewise.
6201 (operator_check_f): Likewise.
6202 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6203 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6204
83228e93
AB		 62052019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6206
6207 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6208 UNOP_KIND.
6209 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6210 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6211 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6212 (operator_length_f): New fuction.
6213 (print_subexp_f): New function.
6214 (op_name_f): New function.
6215 (dump_subexp_body_f): New function.
6216 (operator_check_f): New function.
6217 (exp_descriptor_f): Replace standard expression handling functions
6218 with new functions.
6219 * gdb/fortran-operator.def: New file.
6220 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6221 * gdb/std-operator.def: Remove UNOP_KIND.
6222
6fdcd7cc
AB		 62232019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6224
6225 * std-operator.def: Remove unbalanced, stray double quote
6226 character.
6227
2e62ab40
AB		 62282019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6229 Chris January <chris.january@arm.com>
6230 Daniel Everett <daniel.everett@arm.com>
6231 Nick Forrington <nick.forrington@arm.com>
6232 Richard Bunt <richard.bunt@arm.com>
6233
6234 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6235 of depth when printing anonymous structs or unions.
6236 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6237 Don't print either the top-level value, or the children if the
6238 max-depth is exceeded.
6239 (ppscm_print_children): When printing the key of a map, allow one
6240 extra level of depth.
6241 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6242 print either the top-level value, or the children if the max-depth
6243 is exceeded.
6244 (print_children): When printing the key of a map, allow one extra
6245 level of depth.
6246 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6247 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6248 (user_print_options): Initialise max_depth field.
6249 (val_print_scalar_or_string_type_p): New function.
6250 (val_print): Check to see if the max depth has been reached.
6251 (val_print_check_max_depth): Define new function.
6252 (show_print_max_depth): New function.
6253 (_initialize_valprint): Add 'print max-depth' option.
6254 * valprint.h (struct value_print_options) <max_depth>: New field.
6255 (val_print_check_max_depth): Declare new function.
6256 * NEWS: Document new feature.
6257
4be290b2
AB		 62582019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6259
6260 * ada-lang.c (ada_language_defn): Initialise new field.
6261 * c-lang.c (c_is_string_type_p): New function.
6262 (c_language_defn): Initialise new field.
6263 (cplus_language_defn): Initialise new field.
6264 (asm_language_defn): Initialise new field.
6265 (minimal_language_defn): Initialise new field.
6266 * c-lang.h (c_is_string_type_p): Declare new function.
6267 * d-lang.c (d_language_defn): Initialise new field.
6268 * f-lang.c (f_is_string_type_p): New function.
6269 (f_language_defn): Initialise new field.
6270 * go-lang.c (go_is_string_type_p): New function.
6271 (go_language_defn): Initialise new field.
6272 * language.c (default_is_string_type_p): New function.
6273 (unknown_language_defn): Initialise new field.
6274 (auto_language_defn): Initialise new field.
6275 * language.h (struct language_defn) <la_is_string_type_p>: New
6276 member variable.
6277 (default_is_string_type_p): Declare new function.
6278 * m2-lang.c (m2_language_defn): Initialise new field.
6279 * objc-lang.c (objc_language_defn): Initialise new field.
6280 * opencl-lang.c (opencl_language_defn): Initialise new field.
6281 * p-lang.c (pascal_is_string_type_p): New function.
6282 (pascal_language_defn): Initialise new field.
6283 * rust-lang.c (rust_is_string_type_p): New function.
6284 (rust_language_defn): Initialise new field.
6285
721b08c6
AB		 62862019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6287
6288 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6289 New field.
6290 * ada-lang.c (ada_language_defn): Initialise new field.
6291 * c-lang.c (c_language_defn): Likewise.
6292 (cplus_language_defn): Likewise.
6293 (asm_language_defn): Likewise.
6294 (minimal_language_defn): Likewise.
6295 * d-lang.c (d_language_defn): Likewise.
6296 * f-lang.c (f_language_defn): Likewise.
6297 * go-lang.c (go_language_defn): Likewise.
6298 * language.c (unknown_language_defn): Likewise.
6299 (auto_language_defn): Likewise.
6300 * m2-lang.c (m2_language_defn): Likewise.
6301 * objc-lang.c (objc_language_defn): Likewise.
6302 * opencl-lang.c (opencl_language_defn): Likewise.
6303 * p-lang.c (pascal_language_defn): Likewise.
6304 * rust-lang.c (rust_language_defn): Likewise.
6305
fc913e53
AB		 63062019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6307
6308 * ada-lang.c (ada_is_character_type): Change return type to bool.
6309 (ada_is_string_type): Likewise.
6310 * ada-lang.h (ada_is_character_type): Update declaration
6311 (ada_is_string_type): Likewise.
6312
fa731fa0
PW		 63132019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6314
6315 Support style in 'frame|thread apply'
6316
6317 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6318 * record.c (record_start, record_stop): Update callers of
6319 execute_command_to_string with false.
6320 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6321 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6322 methods.
6323 (class string_file): New constructor with term_out parameter.
6324 Override methods term_out and can_emit_style_escape. New member
6325 term_out.
6326 (class stdio_file): Override can_emit_style_escape.
6327 (class tee_file): Override term_out and can_emit_style_escape.
6328 * utils.h (can_emit_style_escape): Remove.
6329 * utils.c (can_emit_style_escape): Likewise.
6330 Update all callers of can_emit_style_escape (SOMESTREAM) to
6331 SOMESTREAM->can_emit_style_escape.
6332 * source-cache.c (source_cache::get_source_lines): Likewise.
6333 * stack.c (frame_apply_command_count): Call execute_command_to_string
6334 passing the term_out characteristic of the current gdb_stdout.
6335 * thread.c (thr_try_catch_cmd): Likewise.
6336 * top.c (execute_command_to_string): pass term_out parameter
6337 to construct the string_file for the command output.
6338 * ui-file.c (term_cli_styling): New function (most code moved
6339 from utils.c can_emit_style_escape).
6340 (string_file::string_file, string_file::can_emit_style_escape,
6341 stdio_file::can_emit_style_escape, tee_file::term_out,
6342 tee_file::can_emit_style_escape): New functions.
6343
136afab8
PW		 63442019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6345
6346 * NEWS: Mention the new set|show may-call-functions.
6347 * infcall.c (may_call_functions_p): New variable.
6348 (show_may_call_functions_p): New function.
6349 (call_function_by_hand_dummy): Throws an error if not
6350 may-call-functions.
6351 (_initialize_infcall): Call add_setshow_boolean_cmd for
6352 may-call-functions.
6353
725cbb63
KS		 63542019-04-25 Keith Seitz <keiths@redhat.com>
6355
6356 PR c++/24367
6357 * cp-support.c (inspect_type): Don't attempt substitutions
6358 of symbol with the same name.
6359
3d1cbb78
TT		 63602019-04-25 Tom Tromey <tromey@adacore.com>
6361
6362 PR gdb/24475:
6363 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6364 static.
6365
94aeb44b
TT		 63662019-04-25 Tom Tromey <tromey@adacore.com>
6367
6368 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6369 rvalue reference.
6370 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6371 (gdb_xml_parser::parse): Use std::move.
6372 * python/python-internal.h (gdbpy_convert_exception): Take a const
6373 reference.
6374 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6375 std::move.
6376 * python/py-utils.c (gdbpy_convert_exception): Take a const
6377 reference.
6378 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6379 Use std::move.
6380 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6381 Use std::move.
6382 * mi/mi-main.c (mi_print_exception): Take a const reference.
6383 * main.c (handle_command_errors): Take a const reference.
6384 * linespec.c (parse_linespec): Use std::move.
6385 * infcall.c (run_inferior_call): Use std::move.
6386 (call_function_by_hand_dummy): Use std::move.
6387 * exec.c (try_open_exec_file): Use std::move.
6388 * exceptions.h (exception_print, exception_fprintf)
6389 (exception_print_same): Update.
6390 * exceptions.c (print_exception, exception_print)
6391 (exception_fprintf, exception_print_same): Change parameters to
6392 const reference.
6393 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6394 * common/new-op.c: Use std::move.
6395 * common/common-exceptions.h (struct gdb_exception): Add move
6396 constructor.
6397 (struct gdb_exception_error, struct gdb_exception_quit, struct
6398 gdb_quit_bad_alloc): Change constructor to move constructor.
6399 (throw_exception): Change parameter to rvalue reference.
6400 * common/common-exceptions.c (throw_exception): Take rvalue
6401 reference.
6402 * cli/cli-interp.c (safe_execute_command): Use std::move.
6403 * breakpoint.c (insert_bp_location, location_to_sals): Use
6404 std::move.
6405
680d7fd5
TT		 64062019-04-25 Tom Tromey <tromey@adacore.com>
6407
6408 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6409 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6410 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6411 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6412 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6413 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6414 guile/scm-value.c: Use unpack.
6415 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6416 gdbscm_gdb_exception.
6417 (gdbscm_throw_gdb_exception): Likewise.
6418 (struct gdbscm_gdb_exception): New.
6419 (unpack): New function.
6420 (gdbscm_wrap): Use unpack.
6421
c6fdd8b2
TT		 64222019-04-25 Tom Tromey <tromey@adacore.com>
6423
6424 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6425 (gdb_rl_callback_handler): Use std::move.
6426 * common/common-exceptions.h (struct gdb_exception): Add move
6427 assignment operator.
6428 (throw_exception_sjlj): Change "exception" to const reference.
6429 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6430 (throw_exception_sjlj): Change "exception" to const reference.
6431
cc06b668
TT		 64322019-04-25 Tom Tromey <tromey@adacore.com>
6433
6434 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6435 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6436 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6437 Update.
6438 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6439 Update.
6440 * mi/mi-interp.c (mi_interp::exec): Update.
6441 * linespec.c (parse_linespec): Update.
6442 * infcall.c (run_inferior_call): Update.
6443 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6444 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6445 (gdbscm_lookup_global_symbol): Update.
6446 * guile/scm-param.c (gdbscm_parameter_value): Update.
6447 * guile/scm-frame.c (gdbscm_frame_read_register)
6448 (gdbscm_frame_read_var): Update.
6449 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6450 * exec.c (try_open_exec_file): Update.
6451 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6452 (gdb_rl_callback_handler): Update.
6453 * common/common-exceptions.h (exception_none): Don't declare.
6454 * common/common-exceptions.c (exception_none): Don't define.
6455 (struct catcher) <exception>: Update.
6456 * cli/cli-interp.c (safe_execute_command): Update.
6457 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6458
cf532bd1
AT		 64592019-04-25 Ali Tamur <tamur@google.com>
6460
6461 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6462 (read_attribute_value): Likewise.
6463 (dwarf2_read_addr_index): Update comment.
6464 (read_str_index): Add DW_FORM_strx.
6465 (dwarf2_string_attr): Likewise.
6466 (dwarf2_const_value_attr): Likewise.
6467 (dump_die_shallow): Likewise.
6468 (dwarf2_fetch_constant_bytes): Likewise.
6469 (skip_form_bytes): Likewise.
6470 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6471
82433e3e
SDJ		 64722019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6473
6474 PR corefiles/11608
6475 PR corefiles/18187
6476 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6477 OFFSET. Verify if current mapping contains an ELF header.
6478 (linux_find_memory_regions_full): Adjust call to
6479 dump_mapping_p.
6480
723adb65
SL		 64812019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6482 Kang Li <kanglictf@gmail.com>
6483
6484 PR gdb/21600
6485
6486 * dwarf2-frame.c (read_initial_length): Be consistent about using
6487 unsigned representation of length.
6488 (decode_frame_entry_1): Likewise. Check for wraparound of
6489 end pointer as well as buffer overflow.
6490
596179f7
SDJ		 64912019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6492
6493 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6494 "vq".
6495
a59240a4
TT		 64962019-04-24 Tom Tromey <tromey@adacore.com>
6497
6498 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6499
f872fdbb
AB		 65002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6501
6502 * s12z-tdep.c (s12z_unwind_pc): Delete.
6503 (s12z_unwind_sp): Delete.
6504 (s12z_gdbarch_init): Don't register deleted functions with
6505 gdbarch.
6506
b614e6f3
AB		 65072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6508
6509 * rl78-tdep.c (rl78_unwind_sp): Delete.
6510 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6511
14faed38
AB		 65122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6513
6514 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6515 (xstormy16_unwind_pc): Delete.
6516 (xstormy16_dummy_id): Delete.
6517 (xstormy16_gdbarch_init): Don't register deleted functions with
6518 gdbarch.
6519
541aad8a
AB		 65202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6521
6522 * vax-tdep.c (vax_unwind_pc): Delete.
6523 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6524
29222070
AB		 65252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6526
6527 * v850-tdep.c (v850_unwind_sp): Delete.
6528 (v850_unwind_pc): Delete.
6529 (v850_dummy_id): Delete.
6530 (v850_gdbarch_init): Don't register deleted functions with
6531 gdbarch.
6532
0f534d76
AB		 65332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6534
6535 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6536 (tilegx_unwind_pc): Delete.
6537 (tilegx_unwind_dummy_id): Delete.
6538 (tilegx_gdbarch_init): Don't register deleted functions with
6539 gdbarch.
6540
1ba7b7f9
AB		 65412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6542
6543 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6544 (tic6x_dummy_id): Delete.
6545 (tic6x_gdbarch_init): Don't register deleted functions with
6546 gdbarch.
6547
d31f262c
AB		 65482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6549
6550 * sparc-tdep.c (sparc_unwind_pc): Delete.
6551 (sparc32_gdbarch_init): Don't register deleted function with
6552 gdbarch.
6553
6d14d64d
AB		 65542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6555
6556 * sh-tdep.c (sh_unwind_sp): Delete.
6557 (sh_unwind_pc): Delete.
6558 (sh_dummy_id): Delete.
6559 (sh_gdbarch_init): Don't register deleted functions with
6560 gdbarch.
6561
a40dde9d
AB		 65622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6563
6564 * score-tdep.c (score_unwind_sp): Delete.
6565 (score_unwind_pc): Delete.
6566 (score_dummy_id): Delete.
6567 (score_gdbarch_init): Don't register deleted functions with
6568 gdbarch.
6569
47c47d69
AB		 65702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6571
6572 * rx-tdep.c (rx_unwind_pc): Delete.
6573 (rx_unwind_sp): Delete.
6574 (rx_dummy_id): Delete.
6575 (rx_gdbarch_init): Don't register deleted functions with
6576 gdbarch. Update comment.
6577
833a4480
AB		 65782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6579
6580 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6581 (rs6000_dummy_id): Delete.
6582 (rs6000_gdbarch_init): Don't register deleted functions with
6583 gdbarch.
6584
3f2cef49
AB		 65852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6586
6587 * or1k-tdep.c (or1k_dummy_id): Delete.
6588 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6589
96acf884
AB		 65902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6591
6592 * nios2-tdep.c (nios2_dummy_id): Delete.
6593 (nios2_unwind_sp): Delete.
6594 (nios2_gdbarch_init): Don't register deleted functions with
6595 gdbarch.
6596
ca0ab0aa
AB		 65972019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6598
6599 * nds32-tdep.c (nds32_dummy_id): Delete.
6600 (nds32_unwind_pc): Delete.
6601 (nds32_unwind_sp): Delete.
6602 (nds32_gdbarch_init): Don't register deleted functions with
6603 gdbarch.
6604
c8259044
AB		 66052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6606
6607 * msp430-tdep.c (msp430_unwind_pc): Delete.
6608 (msp430_unwind_sp): Delete.
6609 (msp430_dummy_id): Delete.
6610 (msp430_gdbarch_init): Don't register deleted functions with
6611 gdbarch.
6612
27f113c8
AB		 66132019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6614
6615 * moxie-tdep.c (moxie_unwind_sp): Delete.
6616 (moxie_unwind_pc): Delete.
6617 (moxie_dummy_id): Delete.
6618 (moxie_gdbarch_init): Don't register deleted functions with
6619 gdbarch.
6620
aee6c3cd
AB		 66212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6622
6623 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6624 (mn10300_unwind_pc): Delete.
6625 (mn10300_unwind_sp): Delete.
6626 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6627 mn10300_unwind_sp.
6628 (mn10300_frame_unwind_init): Don't register deleted functions with
6629 gdbarch.
6630
8e2b5aea
AB		 66312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6632
6633 * mep-tdep.c (mep_unwind_pc): Delete.
6634 (mep_unwind_sp): Delete.
6635 (mep_dummy_id): Delete.
6636 (mep_gdbarch_init): Don't register deleted functions with
6637 gdbarch.
6638
43cf3ede
AB		 66392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6640
6641 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6642 (m68hc11_unwind_sp): Delete.
6643 (m68hc11_gdbarch_init): Don't register deleted functions with
6644 gdbarch.
6645
5e79b7bb
AB		 66462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6647
6648 * m32r-tdep.c (m32r_unwind_sp): Delete.
6649 (m32r_unwind_pc): Delete.
6650 (m32r_dummy_id): Delete.
6651 (m32r_gdbarch_init): Don't register deleted functions with
6652 gdbarch.
6653
89b268d8
AB		 66542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6655
6656 * m32c-tdep.c (m32c_unwind_pc): Delete.
6657 (m32c_unwind_sp): Delete.
6658 (m32c_dummy_id): Delete.
6659 (m32c_gdbarch_init): Don't register deleted functions with
6660 gdbarch.
6661
946c28d2
AB		 66622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6663
6664 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6665 (lm32_unwind_pc): Delete.
6666 (lm32_dummy_id): Delete.
6667 (lm32_gdbarch_init): Don't register deleted functions with
6668 gdbarch.
6669
bf12844a
AB		 66702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6671
6672 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6673 (iq2000_unwind_pc): Delete.
6674 (iq2000_dummy_id): Delete.
6675 (iq2000_gdbarch_init): Don't register deleted functions with
6676 gdbarch.
6677
ecbc06d2
AB		 66782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6679
6680 * nds32-tdep.c (nds32_type_align): Delete.
6681 (nds32_push_dummy_call): Use type_align instead.
6682
030197b4
AB		 66832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6684
6685 * arm-tdep.c (arm_type_align): Only handle vector override case.
6686 (arm_push_dummy_call): Use type_align.
6687 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6688
b907456c
AB		 66892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6690
6691 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6692 case.
6693 (pass_on_stack): Use type_align.
6694 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6695 function.
6696
9e97ba43
TT		 66972019-04-23 Tom Tromey <tromey@adacore.com>
6698
6699 * dwarf2read.c (line_header::file_name_at): Remove unused
6700 overload.
6701
6892f601
TV		 67022019-04-23 Tom de Vries <tdevries@suse.de>
6703
6704 PR gdb/24438
6705 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6706 invocation.
6707
336d760d
AT		 6708
67092019-03-27 Ali Tamur <tamur@google.com>
6710
6711 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6712 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6713 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6714 (dwarf_expr_context::get_addr_index): Likewise
6715 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6716 (symbol_needs_eval_context::get_addr_index): Likewise
6717 (disassemble_dwarf_expression): Add DW_OP_addrx
6718 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6719 (read_cutu_die_from_dwo): Update comment
6720 (skip_one_die): Add DW_FORM_addrx
6721 (read_attribute_value): Likewise
6722 (var_decode_location): Add DW_OP_addrx
6723 (dwarf2_const_value_attr): Add DW_FORM_addrx
6724 (dump_die_shallow): Likewise
6725 (dwarf2_fetch_constant_bytes): Likewise
6726 (decode_locdesc): Add DW_OP_addrx
6727 (skip_form_bytes): Add DW_FORM_addrx
6728
ad9d13f8
AT		 67292019-04-22 Ali Tamur <tamur@google.com>
6730
6731 * MAINTAINERS (Write After Approval): Add self.
6732
d70cc3ba
SM		 67332019-04-22 Simon Marchi <simon.marchi@efficios.com>
6734
6735 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6736 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6737 (open_symbol_file_object): Likewise.
6738 (svr4_default_sos): Add info parameter.
6739 (svr4_read_so_list): Likewise.
6740 (svr4_current_sos_direct): Adjust functions calls to pass down
6741 info.
6742 (svr4_current_sos_1): Add info parameter.
6743 (svr4_current_sos): Call get_svr4_info, pass info down to
6744 svr4_current_sos_1.
6745 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6746 get_svr4_info.
6747 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6748 get_svr4_info.
6749 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6750 to get_svr4_info.
6751 (probes_table_remove_objfile_probes): Likewise.
6752 (register_solib_event_probe): Add info parameter.
6753 (solist_update_incremental): Pass info parameter down to
6754 svr4_read_so_list.
6755 (disable_probes_interface): Add info parameter.
6756 (svr4_handle_solib_event): Pass current_program_space to
6757 get_svr4_info. Adjust disable_probes_interface cleanup.
6758 (svr4_create_probe_breakpoints): Add info parameter, pass it
6759 down to register_solib_event_probe.
6760 (svr4_create_solib_event_breakpoints): Add info parameter,
6761 pass it down to svr4_create_probe_breakpoints.
6762 (enable_break): Pass info down to
6763 svr4_create_solib_event_breakpoints.
6764 (svr4_solib_create_inferior_hook): Pass current_program_space to
6765 get_svr4_info.
6766 (svr4_clear_solib): Likewise.
6767
7905fc35
PA		 67682019-04-22 Pedro Alves <palves@redhat.com>
6769
6770 * solib-svr4.c (svr4_free_objfile_observer): New.
6771 (probe_and_action::objfile): New field.
6772 (probes_table_htab_remove_objfile_probes)
6773 (probes_table_remove_objfile_probes): New functions.
6774 (register_solib_event_probe): Add 'objfile' parameter. Store it
6775 in the new probe_and_action. Don't store the probe in 'lookup'.
6776 (svr4_create_probe_breakpoints): Pass objfile to
6777 register_solib_event_probe.
6778 (_initialize_svr4_solib): Register a free_objfile observer.
6779
fb881986
TT		 67802019-04-19 Tom Tromey <tom@tromey.com>
6781
6782 * common/queue.h: Remove.
6783
8732db6c
TT		 67842019-04-19 Tom Tromey <tom@tromey.com>
6785
6786 * event-loop.c: Don't include "common/queue.h".
6787
97dfbadd
TT		 67882019-04-19 Tom Tromey <tom@tromey.com>
6789
6790 * remote.c (remote_target): Use delete.
6791 * remote-notif.h: Include <list>, not "common/queue.h".
6792 (notif_client_p): Remove typedef.
6793 (remote_notif_state): Add constructor, destructor, initializer.
6794 <notif_queue>: Now a std::list.
6795 (remote_notif_state_xfree): Don't declare.
6796 * remote-notif.c (remote_notif_process, handle_notification)
6797 (remote_notif_state_allocate): Update.
6798 (~remote_notif_state): Rename from remote_notif_state_xfree.
6799
cf250e36
TT		 68002019-04-19 Tom Tromey <tom@tromey.com>
6801
6802 * symfile.c (reread_symbols): Update.
6803 * objfiles.c (objfile_register_static_link)
6804 (objfile_lookup_static_link): Update
6805 (~objfile) Don't delete static_links.
6806 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6807
61f4b350
TT		 68082019-04-19 Tom Tromey <tom@tromey.com>
6809
6810 * type-stack.h (struct type_stack) <insert>: Constify string.
6811 * type-stack.c (type_stack::insert): Constify string.
6812 * gdbtypes.h (lookup_template_type): Update.
6813 (address_space_name_to_int): Update.
6814 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6815 const.
6816 (lookup_template_type): Make name const.
6817 * c-exp.y: Update rules.
6818 (lex_one_token, classify_name, classify_inner_name)
6819 (c_print_token): Update.
6820 * p-exp.y: Update rules.
6821 (yylex): Update.
6822 * f-exp.y: Update rules.
6823 (yylex): Update.
6824 * d-exp.y: Update rules.
6825 (lex_one_token, classify_name, classify_inner_name): Update.
6826 * parse.c (write_dollar_variable, copy_name): Return std::string.
6827 * parser-defs.h (copy_name): Change return type.
6828 * m2-exp.y: Update rules.
6829 (yylex): Update.
6830 * go-exp.y (lex_one_token): Update.
6831 Update rules.
6832 (classify_unsafe_function, classify_packaged_name)
6833 (classify_name, yylex): Update.
6834
189b8c2e
ST		 68352019-04-19 Sergei Trofimovich <siarheit@google.com>
6836
6837 * configure.ac: add --enable-source-highlight switch.
6838 * configure: Regenerate.
6839 * top.c (print_gdb_version): plumb --enable-source-highlight
6840 status to "show configuration".
6841
8ecb59f8
TT		 68422019-04-19 Tom Tromey <tromey@adacore.com>
6843
6844 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6845 Check ADA_TYPE_P.
6846 (empty_record, ada_template_to_fixed_record_type_1)
6847 (template_to_static_fixed_type)
6848 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6849 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6850 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6851 macros.
6852
62160ec9
TT		 68532019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6854
6855 PR symtab/24423:
6856 * source.c (print_source_lines_base): Advance "iter" when a
6857 control character is seen.
6858
f2ae8bc8
PW		 68592019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6860
6861 * inferior.h (struct infcall_suspend_state_deleter):
6862 Catch exception in destructor to avoid crash.
6863
d563b953
PW		 68642019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6865
6866 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6867 close to the add_com "shell".
6868
dc34c897
TT		 68692019-04-18 Tom Tromey <tromey@adacore.com>
6870
6871 * process-stratum-target.h (class process_stratum_target)
6872 <stratum>: Add "final".
6873
a12e5744
TT		 68742019-04-17 Tom Tromey <tromey@adacore.com>
6875
6876 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6877 against nullptr before use.
6878
a7e559cc
AH		 68792019-04-17 Alan Hayward <alan.hayward@arm.com>
6880
6881 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6882
c01660c6
AB		 68832019-04-17 Jim Wilson <jimw@sifive.com>
6884 Andrew Burgess <andrew.burgess@embecosm.com>
6885
6886 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6887 code read might fail, assume 4-byte breakpoint in that case.
6888
4aa866af
LS		 68892019-04-15 Leszek Swirski <leszeks@google.com>
6890
6891 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6892 rather than a hand-rolled POD check when checking for forced MEMORY
6893 classification.
6894
48574d91
AH		 68952019-04-15 Alan Hayward <alan.hayward@arm.com>
6896
6897 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6898 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6899 function.
6900 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6901 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6902 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6903 declaration.
6904
4da037ef
AH		 69052019-04-15 Alan Hayward <alan.hayward@arm.com>
6906
6907 * aarch64-linux-nat.c
6908 (aarch64_linux_nat_target::thread_architecture): Add override.
6909 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6910 each VQ.
6911
ccb8d7e8
AH		 69122019-04-15 Alan Hayward <alan.hayward@arm.com>
6913
6914 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6915
35add35e
AB		 69162019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6917
6918 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6919 target types of size 96-bits, add some additional comments, and
6920 check that the builtin type we found was the correct size.
6921
51196bbc
EZ		 69222019-04-12 Eli Zaretskii <eliz@gnu.org>
6923
6924 * utils.c (prompt_for_continue): Don't restore the styling at the
6925 end, as applied_style has the wrong value. This fixes styling in
6926 long lists of file names that are interrupted by the "Continue?"
6927 prompt.
6928
62253a61
AB		 69292019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6930
6931 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6932 * c-lang.c (c_language_defn): Likewise.
6933 (cplus_language_defn): Likewise.
6934 (asm_language_defn): Likewise.
6935 (minimal_language_defn): Likewise.
6936 * d-lang.c (d_language_defn): Likewise.
6937 * f-lang.c (f_language_defn): Likewise.
6938 * go-lang.c (go_language_defn): Likewise.
6939 * language.c (unknown_language_defn): Likewise.
6940 (auto_language_defn): Likewise.
6941 * language.h (struct language_defn): Remove la_magic field.
6942 (LANG_MAGIC): Delete.
6943 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6944 * objc-lang.c (objc_language_defn): Likewise.
6945 * opencl-lang.c (opencl_language_defn): Likewise.
6946 * p-lang.c (pascal_language_defn): Likewise.
6947 * rust-lang.c (rust_language_defn): Likewise.
6948
a9158a86
AB		 69492019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6950
6951 * riscv-tdep.c (riscv_type_align): New function.
6952 (riscv_type_alignment): Delete.
6953 (riscv_arg_location): Use 'type_align'.
6954 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6955
41077b66
AB		 69562019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6957
6958 * gdbtypes.c (type_align): A struct with no non-static fields also
6959 has alignment of 1.
6960
9f0272f8
AB		 69612019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6962
6963 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6964 component to 0.
6965 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6966 member.
6967 (riscv_struct_info::analyse): New implementation using new
6968 analyse_inner member function.
6969 (riscv_struct_info::field_offset): New member function.
6970 (riscv_struct_info::m_offsets): New member variable.
6971 (riscv_struct_info::analyse_inner): New private member function,
6972 takes the old implementation of riscv_struct_info::analyse but
6973 extended to track field offsets.
6974 (riscv_call_arg_struct): Update the struct folding special cases
6975 to handle cases where empty C++ structs, which are non-zero
6976 length, are found.
6977 (riscv_arg_location): Initialise the length of each location, a
6978 non-zero length now indicates the location is in use.
6979 (riscv_push_dummy_call): Allow for the first location having a
6980 non-zero offset when setting up arguments.
6981 (riscv_return_value): Likewise, but for return values.
6982
02cf60c7
TT		 69832019-04-11 Tom Tromey <tromey@adacore.com>
6984
6985 * utils.c (internal_vproblem): Make "msg" const.
6986
68811f8f
AH		 69872019-04-11 Alan Hayward <alan.hayward@arm.com>
6988
6989 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6990 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6991 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6992 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6993
3f52fdbc
KB		 69942019-04-10 Kevin Buettner <kevinb@redhat.com>
6995
6996 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6997 function.
6998 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6999 of amd64_collect_native_gregset.
7000 (amd64_linux_nat_target::store_registers): Likewise.
7001
e9ad22ee
TT		 70022019-04-10 Tom Tromey <tom@tromey.com>
7003
7004 * symtab.c (lookup_global_symbol_from_objfile)
7005 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7006 * objfiles.h (class separate_debug_iterator): New.
7007 (class separate_debug_range): New.
7008 (struct objfile) <separate_debug_objfiles>: New method.
7009 (objfile_separate_debug_iterate): Don't declare.
7010 * objfiles.c (separate_debug_iterator::operator++): Rename from
7011 objfile_separate_debug_iterate.
7012 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7013 iterator.
7014 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7015 iterator.
7016
ee371134
TT		 70172019-04-10 Tom Tromey <tom@tromey.com>
7018
7019 * symfile.c (reread_symbols): Remove old comment.
7020 * objfiles.c (free_all_objfiles): Fix a typo.
7021
bf227d61
TT		 70222019-04-10 Tom Tromey <tom@tromey.com>
7023
7024 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7025 * minsyms.c (lookup_minimal_symbol): Use foreach.
7026 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7027 (lookup_minimal_symbol_solib_trampoline): Likewise.
7028 * symfile.c (reread_symbols): Use foreach.
7029
8dc433a0
TT		 70302019-04-09 Ivan Begert <ivanbegert@gmail.com>
7031 Tom Tromey <tromey@adacore.com>
7032
7033 PR rust/24414:
7034 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7035 (rust_lex_int_test): Change "value" to be LONGEST.
7036 (rust_lex_tests): Add test for long integer literal.
7037
9ab8741a
TT		 70382019-04-09 Tom Tromey <tromey@adacore.com>
7039
7040 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7041 to bool.
7042 (extended_remote_target::attach): Update.
7043 (remote_target::remote_notice_new_inferior): Update.
7044 (remote_target::add_current_inferior_and_thread): Update.
7045 * inferior.c (exit_inferior_1): Use "false".
7046 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7047
e242fd12
SM		 70482019-04-09 Simon Marchi <simon.marchi@efficios.com>
7049
9ca1957f 7050 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 7051 the "start" command.
7052
2b0c8b01
KB		 70532019-04-08 Kevin Buettner <kevinb@redhat.com>
7054
7055 * python/py-inferior.c (infpy_thread_from_thread_handle):
7056 Adjust comments to reflect renaming of thread_from_thread_handle
7057 to thread_from_handle. Adjust keywords. Fix type error message.
7058 (inferior_object_methods): Add thread_from_handle. Retain
7059 thread_from_thread_handle, but mark it as deprecated.
7060
50a82723
KB		 70612019-04-08 Kevin Buettner <kevinb@redhat.com>
7062
7063 * gdbthread.h (find_thread_by_handle): Revise declaration.
7064 * thread.c (find_thread_by_handle): Likewise. Adjust
7065 implementation too.
7066 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7067 support for buffer objects as handles.
7068
cf63b016
KB		 70692019-04-08 Kevin Buettner <kevinb@redhat.com>
7070
7071 * python/py-infthread.c (thpy_thread_handle): New function.
7072 (thread_object_methods): Register thpy_thread_handle.
7073
3d6c6204
KB		 70742019-04-08 Kevin Buettner <kevinb@redhat.com>
7075
7076 * gdbthread.h (thread_to_thread_handle): Declare.
7077 * thread.c (gdbtypes.h): Include.
7078 (thread_to_thread_handle): New function.
7079
7080 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7081 (target_thread_info_to_thread_handle): Declare.
7082 * target.c (target_thread_info_to_thread_handle): New function.
7083 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7084 * target-delegates.c: Regenerate.
7085
7086 * linux-thread-db.c (class thread_db_target): Add method
7087 thread_info_to_thread_handle.
7088 (thread_db_target::thread_info_to_thread_handle): Define.
7089 * remote.c (class remote_target): Add new method
7090 thread_info_to_thread_handle.
7091 (remote_target::thread_info_to_thread_handle): Define.
7092
56be6ea8
PA		 70932019-04-08 Pedro Alves <palves@redhat.com>
7094
7095 * common/common-exceptions.c (throw_exception): Don't create
7096 named object to throw; throw directly.
7097 (throw_it): Likewise. Don't initialize gdb_exception::message
7098 here, with new; pass FMT and AP to the ctor instead.
7099 * common/common-exceptions.h: Include <string>.
7100 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7101 const char *, va_list)): New ctor. Use std::make_shared.
7102 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7103 errors)): Delete.
7104 (gdb_exception_error::gdb_exception_error(enum errors, const char
7105 *, va_list)): New.
7106 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7107 Add assertion.
7108 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7109 errors)): Delete.
7110 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7111 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7112 Add assertion.
7113
eedc3f4f
TT		 71142019-04-08 Tom Tromey <tom@tromey.com>
7115
7116 * valops.c (value_rtti_indirect_type): Replace throw_exception
7117 with throw.
7118 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7119 with throw.
7120 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7121 throw.
7122 * target.c (target_translate_tls_address): Replace throw_exception
7123 with throw.
7124 * stack.c (frame_apply_command_count): Replace throw_exception
7125 with throw.
7126 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7127 throw.
7128 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7129 with throw.
7130 * rs6000-tdep.c (rs6000_frame_cache)
7131 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7132 * remote.c: Replace throw_exception with throw.
7133 * record-full.c (record_full_message, record_full_wait_1)
7134 (record_full_restore): Replace throw_exception with throw.
7135 * record-btrace.c:
7136 (get_thread_current_frame_id, record_btrace_start_replaying)
7137 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7138 (cmd_record_btrace_start): Replace throw_exception with throw.
7139 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7140 throw.
7141 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7142 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7143 * linespec.c:
7144 (find_linespec_symbols): Replace throw_exception with throw.
7145 * infrun.c (displaced_step_prepare, resume): Replace
7146 throw_exception with throw.
7147 * infcmd.c (post_create_inferior): Replace throw_exception with
7148 throw.
7149 * inf-loop.c (inferior_event_handler): Replace throw_exception
7150 with throw.
7151 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7152 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7153 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7154 (get_prev_frame_always, get_frame_pc_if_available)
7155 (get_frame_address_in_block_if_available, get_frame_language):
7156 Replace throw_exception with throw.
7157 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7158 throw_exception with throw.
7159 * eval.c (fetch_subexp_value, evaluate_var_value)
7160 (evaluate_funcall, evaluate_subexp_standard): Replace
7161 throw_exception with throw.
7162 * dwarf2loc.c (call_site_find_chain)
7163 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7164 Replace throw_exception with throw.
7165 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7166 with throw.
7167 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7168 throw.
7169 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7170 * completer.c (complete_line_internal): Replace throw_exception
7171 with throw.
7172 * compile/compile-object-run.c (compile_object_run): Replace
7173 throw_exception with throw.
7174 * cli/cli-script.c (process_next_line): Replace throw_exception
7175 with throw.
7176 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7177 (btrace_enable, btrace_maint_update_pt_packets): Replace
7178 throw_exception with throw.
7179 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7180 throw_exception with throw.
7181 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7182 throw_exception with throw.
7183 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7184 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7185 * aarch64-tdep.c (aarch64_make_prologue_cache)
7186 (aarch64_make_stub_cache): Replace throw_exception with throw.
7187
26003a20
TT		 71882019-04-08 Tom Tromey <tom@tromey.com>
7189
7190 * common/common-exceptions.c (throw_exception): Rename from
7191 throw_exception_cxx. Remove old copy. Make argument const.
7192 (throw_it): Create and throw exception objects directly.
7193 * common/common-exceptions.h (throw_exception): Make argument
7194 const.
7195 (struct gdb_exception_error): Add constructor.
7196 (struct gdb_exception_quit): Add constructor.
7197
d272eb37
TT		 71982019-04-08 Tom Tromey <tom@tromey.com>
7199
7200 * common/common-exceptions.h (exception_rethrow): Don't declare.
7201 (TRY_SJLJ): Update comment.
7202 (TRY, CATCH, END_CATCH): Remove.
7203 * common/common-exceptions.c (exception_rethrow): Remove.
7204
230d2906
TT		 72052019-04-08 Tom Tromey <tom@tromey.com>
7206
7207 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7208 Remove.
7209 (gdb_exception_error): Rename from
7210 gdb_exception_RETURN_MASK_ERROR.
7211 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7212 (gdb_quit_bad_alloc): Update.
7213 * aarch64-tdep.c: Update.
7214 * ada-lang.c: Update.
7215 * ada-typeprint.c: Update.
7216 * ada-valprint.c: Update.
7217 * amd64-tdep.c: Update.
7218 * arch-utils.c: Update.
7219 * break-catch-throw.c: Update.
7220 * breakpoint.c: Update.
7221 * btrace.c: Update.
7222 * c-varobj.c: Update.
7223 * cli/cli-cmds.c: Update.
7224 * cli/cli-interp.c: Update.
7225 * cli/cli-script.c: Update.
7226 * common/common-exceptions.c: Update.
7227 * common/new-op.c: Update.
7228 * common/selftest.c: Update.
7229 * compile/compile-c-symbols.c: Update.
7230 * compile/compile-cplus-symbols.c: Update.
7231 * compile/compile-object-load.c: Update.
7232 * compile/compile-object-run.c: Update.
7233 * completer.c: Update.
7234 * corelow.c: Update.
7235 * cp-abi.c: Update.
7236 * cp-support.c: Update.
7237 * cp-valprint.c: Update.
7238 * darwin-nat.c: Update.
7239 * disasm-selftests.c: Update.
7240 * dtrace-probe.c: Update.
7241 * dwarf-index-cache.c: Update.
7242 * dwarf-index-write.c: Update.
7243 * dwarf2-frame-tailcall.c: Update.
7244 * dwarf2-frame.c: Update.
7245 * dwarf2loc.c: Update.
7246 * dwarf2read.c: Update.
7247 * eval.c: Update.
7248 * event-loop.c: Update.
7249 * event-top.c: Update.
7250 * exec.c: Update.
7251 * f-valprint.c: Update.
7252 * fbsd-tdep.c: Update.
7253 * frame-unwind.c: Update.
7254 * frame.c: Update.
7255 * gdbtypes.c: Update.
7256 * gnu-v3-abi.c: Update.
7257 * guile/guile-internal.h: Update.
7258 * guile/scm-block.c: Update.
7259 * guile/scm-breakpoint.c: Update.
7260 * guile/scm-cmd.c: Update.
7261 * guile/scm-disasm.c: Update.
7262 * guile/scm-frame.c: Update.
7263 * guile/scm-lazy-string.c: Update.
7264 * guile/scm-math.c: Update.
7265 * guile/scm-param.c: Update.
7266 * guile/scm-ports.c: Update.
7267 * guile/scm-pretty-print.c: Update.
7268 * guile/scm-symbol.c: Update.
7269 * guile/scm-symtab.c: Update.
7270 * guile/scm-type.c: Update.
7271 * guile/scm-value.c: Update.
7272 * i386-linux-tdep.c: Update.
7273 * i386-tdep.c: Update.
7274 * inf-loop.c: Update.
7275 * infcall.c: Update.
7276 * infcmd.c: Update.
7277 * infrun.c: Update.
7278 * jit.c: Update.
7279 * language.c: Update.
7280 * linespec.c: Update.
7281 * linux-fork.c: Update.
7282 * linux-nat.c: Update.
7283 * linux-tdep.c: Update.
7284 * linux-thread-db.c: Update.
7285 * main.c: Update.
7286 * mi/mi-cmd-break.c: Update.
7287 * mi/mi-cmd-stack.c: Update.
7288 * mi/mi-interp.c: Update.
7289 * mi/mi-main.c: Update.
7290 * objc-lang.c: Update.
7291 * p-valprint.c: Update.
7292 * parse.c: Update.
7293 * ppc-linux-tdep.c: Update.
7294 * printcmd.c: Update.
7295 * python/py-arch.c: Update.
7296 * python/py-breakpoint.c: Update.
7297 * python/py-cmd.c: Update.
7298 * python/py-finishbreakpoint.c: Update.
7299 * python/py-frame.c: Update.
7300 * python/py-framefilter.c: Update.
7301 * python/py-gdb-readline.c: Update.
7302 * python/py-inferior.c: Update.
7303 * python/py-infthread.c: Update.
7304 * python/py-lazy-string.c: Update.
7305 * python/py-linetable.c: Update.
7306 * python/py-objfile.c: Update.
7307 * python/py-param.c: Update.
7308 * python/py-prettyprint.c: Update.
7309 * python/py-progspace.c: Update.
7310 * python/py-record-btrace.c: Update.
7311 * python/py-record.c: Update.
7312 * python/py-symbol.c: Update.
7313 * python/py-type.c: Update.
7314 * python/py-unwind.c: Update.
7315 * python/py-utils.c: Update.
7316 * python/py-value.c: Update.
7317 * python/python.c: Update.
7318 * record-btrace.c: Update.
7319 * record-full.c: Update.
7320 * remote-fileio.c: Update.
7321 * remote.c: Update.
7322 * riscv-tdep.c: Update.
7323 * rs6000-aix-tdep.c: Update.
7324 * rs6000-tdep.c: Update.
7325 * rust-exp.y: Update.
7326 * rust-lang.c: Update.
7327 * s390-tdep.c: Update.
7328 * selftest-arch.c: Update.
7329 * solib-dsbt.c: Update.
7330 * solib-frv.c: Update.
7331 * solib-spu.c: Update.
7332 * solib-svr4.c: Update.
7333 * solib.c: Update.
7334 * sparc64-linux-tdep.c: Update.
7335 * stack.c: Update.
7336 * symfile-mem.c: Update.
7337 * symmisc.c: Update.
7338 * target.c: Update.
7339 * thread.c: Update.
7340 * top.c: Update.
7341 * tracefile-tfile.c: Update.
7342 * tui/tui.c: Update.
7343 * typeprint.c: Update.
7344 * unittests/cli-utils-selftests.c: Update.
7345 * unittests/parse-connection-spec-selftests.c: Update.
7346 * valops.c: Update.
7347 * valprint.c: Update.
7348 * value.c: Update.
7349 * varobj.c: Update.
7350 * windows-nat.c: Update.
7351 * x86-linux-nat.c: Update.
7352 * xml-support.c: Update.
7353
a70b8144
TT		 73542019-04-08 Tom Tromey <tom@tromey.com>
7355
7356 * xml-support.c: Use C++ exception handling.
7357 * x86-linux-nat.c: Use C++ exception handling.
7358 * windows-nat.c: Use C++ exception handling.
7359 * varobj.c: Use C++ exception handling.
7360 * value.c: Use C++ exception handling.
7361 * valprint.c: Use C++ exception handling.
7362 * valops.c: Use C++ exception handling.
7363 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7364 handling.
7365 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7366 * typeprint.c: Use C++ exception handling.
7367 * tui/tui.c: Use C++ exception handling.
7368 * tracefile-tfile.c: Use C++ exception handling.
7369 * top.c: Use C++ exception handling.
7370 * thread.c: Use C++ exception handling.
7371 * target.c: Use C++ exception handling.
7372 * symmisc.c: Use C++ exception handling.
7373 * symfile-mem.c: Use C++ exception handling.
7374 * stack.c: Use C++ exception handling.
7375 * sparc64-linux-tdep.c: Use C++ exception handling.
7376 * solib.c: Use C++ exception handling.
7377 * solib-svr4.c: Use C++ exception handling.
7378 * solib-spu.c: Use C++ exception handling.
7379 * solib-frv.c: Use C++ exception handling.
7380 * solib-dsbt.c: Use C++ exception handling.
7381 * selftest-arch.c: Use C++ exception handling.
7382 * s390-tdep.c: Use C++ exception handling.
7383 * rust-lang.c: Use C++ exception handling.
7384 * rust-exp.y: Use C++ exception handling.
7385 * rs6000-tdep.c: Use C++ exception handling.
7386 * rs6000-aix-tdep.c: Use C++ exception handling.
7387 * riscv-tdep.c: Use C++ exception handling.
7388 * remote.c: Use C++ exception handling.
7389 * remote-fileio.c: Use C++ exception handling.
7390 * record-full.c: Use C++ exception handling.
7391 * record-btrace.c: Use C++ exception handling.
7392 * python/python.c: Use C++ exception handling.
7393 * python/py-value.c: Use C++ exception handling.
7394 * python/py-utils.c: Use C++ exception handling.
7395 * python/py-unwind.c: Use C++ exception handling.
7396 * python/py-type.c: Use C++ exception handling.
7397 * python/py-symbol.c: Use C++ exception handling.
7398 * python/py-record.c: Use C++ exception handling.
7399 * python/py-record-btrace.c: Use C++ exception handling.
7400 * python/py-progspace.c: Use C++ exception handling.
7401 * python/py-prettyprint.c: Use C++ exception handling.
7402 * python/py-param.c: Use C++ exception handling.
7403 * python/py-objfile.c: Use C++ exception handling.
7404 * python/py-linetable.c: Use C++ exception handling.
7405 * python/py-lazy-string.c: Use C++ exception handling.
7406 * python/py-infthread.c: Use C++ exception handling.
7407 * python/py-inferior.c: Use C++ exception handling.
7408 * python/py-gdb-readline.c: Use C++ exception handling.
7409 * python/py-framefilter.c: Use C++ exception handling.
7410 * python/py-frame.c: Use C++ exception handling.
7411 * python/py-finishbreakpoint.c: Use C++ exception handling.
7412 * python/py-cmd.c: Use C++ exception handling.
7413 * python/py-breakpoint.c: Use C++ exception handling.
7414 * python/py-arch.c: Use C++ exception handling.
7415 * printcmd.c: Use C++ exception handling.
7416 * ppc-linux-tdep.c: Use C++ exception handling.
7417 * parse.c: Use C++ exception handling.
7418 * p-valprint.c: Use C++ exception handling.
7419 * objc-lang.c: Use C++ exception handling.
7420 * mi/mi-main.c: Use C++ exception handling.
7421 * mi/mi-interp.c: Use C++ exception handling.
7422 * mi/mi-cmd-stack.c: Use C++ exception handling.
7423 * mi/mi-cmd-break.c: Use C++ exception handling.
7424 * main.c: Use C++ exception handling.
7425 * linux-thread-db.c: Use C++ exception handling.
7426 * linux-tdep.c: Use C++ exception handling.
7427 * linux-nat.c: Use C++ exception handling.
7428 * linux-fork.c: Use C++ exception handling.
7429 * linespec.c: Use C++ exception handling.
7430 * language.c: Use C++ exception handling.
7431 * jit.c: Use C++ exception handling.
7432 * infrun.c: Use C++ exception handling.
7433 * infcmd.c: Use C++ exception handling.
7434 * infcall.c: Use C++ exception handling.
7435 * inf-loop.c: Use C++ exception handling.
7436 * i386-tdep.c: Use C++ exception handling.
7437 * i386-linux-tdep.c: Use C++ exception handling.
7438 * guile/scm-value.c: Use C++ exception handling.
7439 * guile/scm-type.c: Use C++ exception handling.
7440 * guile/scm-symtab.c: Use C++ exception handling.
7441 * guile/scm-symbol.c: Use C++ exception handling.
7442 * guile/scm-pretty-print.c: Use C++ exception handling.
7443 * guile/scm-ports.c: Use C++ exception handling.
7444 * guile/scm-param.c: Use C++ exception handling.
7445 * guile/scm-math.c: Use C++ exception handling.
7446 * guile/scm-lazy-string.c: Use C++ exception handling.
7447 * guile/scm-frame.c: Use C++ exception handling.
7448 * guile/scm-disasm.c: Use C++ exception handling.
7449 * guile/scm-cmd.c: Use C++ exception handling.
7450 * guile/scm-breakpoint.c: Use C++ exception handling.
7451 * guile/scm-block.c: Use C++ exception handling.
7452 * guile/guile-internal.h: Use C++ exception handling.
7453 * gnu-v3-abi.c: Use C++ exception handling.
7454 * gdbtypes.c: Use C++ exception handling.
7455 * frame.c: Use C++ exception handling.
7456 * frame-unwind.c: Use C++ exception handling.
7457 * fbsd-tdep.c: Use C++ exception handling.
7458 * f-valprint.c: Use C++ exception handling.
7459 * exec.c: Use C++ exception handling.
7460 * event-top.c: Use C++ exception handling.
7461 * event-loop.c: Use C++ exception handling.
7462 * eval.c: Use C++ exception handling.
7463 * dwarf2read.c: Use C++ exception handling.
7464 * dwarf2loc.c: Use C++ exception handling.
7465 * dwarf2-frame.c: Use C++ exception handling.
7466 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7467 * dwarf-index-write.c: Use C++ exception handling.
7468 * dwarf-index-cache.c: Use C++ exception handling.
7469 * dtrace-probe.c: Use C++ exception handling.
7470 * disasm-selftests.c: Use C++ exception handling.
7471 * darwin-nat.c: Use C++ exception handling.
7472 * cp-valprint.c: Use C++ exception handling.
7473 * cp-support.c: Use C++ exception handling.
7474 * cp-abi.c: Use C++ exception handling.
7475 * corelow.c: Use C++ exception handling.
7476 * completer.c: Use C++ exception handling.
7477 * compile/compile-object-run.c: Use C++ exception handling.
7478 * compile/compile-object-load.c: Use C++ exception handling.
7479 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7480 * compile/compile-c-symbols.c: Use C++ exception handling.
7481 * common/selftest.c: Use C++ exception handling.
7482 * common/new-op.c: Use C++ exception handling.
7483 * cli/cli-script.c: Use C++ exception handling.
7484 * cli/cli-interp.c: Use C++ exception handling.
7485 * cli/cli-cmds.c: Use C++ exception handling.
7486 * c-varobj.c: Use C++ exception handling.
7487 * btrace.c: Use C++ exception handling.
7488 * breakpoint.c: Use C++ exception handling.
7489 * break-catch-throw.c: Use C++ exception handling.
7490 * arch-utils.c: Use C++ exception handling.
7491 * amd64-tdep.c: Use C++ exception handling.
7492 * ada-valprint.c: Use C++ exception handling.
7493 * ada-typeprint.c: Use C++ exception handling.
7494 * ada-lang.c: Use C++ exception handling.
7495 * aarch64-tdep.c: Use C++ exception handling.
7496
3d6e9d23
TT		 74972019-04-08 Tom Tromey <tom@tromey.com>
7498
7499 * xml-support.c (gdb_xml_parser::parse): Update.
7500 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7501 * value.c (show_convenience): Update.
7502 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7503 (test_parse_flags_qcs): Update.
7504 * thread.c (thr_try_catch_cmd): Update.
7505 * target.c (target_translate_tls_address): Update.
7506 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7507 (info_frame_command_core, frame_apply_command_count): Update.
7508 * rust-exp.y (rust_lex_exception_test): Update.
7509 * riscv-tdep.c (riscv_print_one_register_info): Update.
7510 * remote.c (remote_target::enable_btrace): Update.
7511 * record-btrace.c (record_btrace_enable_warn): Update.
7512 * python/py-utils.c (gdbpy_convert_exception): Update.
7513 * printcmd.c (do_one_display, print_variable_and_value): Update.
7514 * mi/mi-main.c (mi_print_exception): Update.
7515 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7516 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7517 * linux-nat.c (linux_nat_target::attach): Update.
7518 * linux-fork.c (class scoped_switch_fork_info): Update.
7519 * infrun.c (displaced_step_prepare): Update.
7520 * infcall.c (call_function_by_hand_dummy): Update.
7521 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7522 * gnu-v3-abi.c (print_one_vtable): Update.
7523 * frame.c (get_prev_frame_always): Update.
7524 * f-valprint.c (info_common_command_for_block): Update.
7525 * exec.c (try_open_exec_file): Update.
7526 * exceptions.c (print_exception, exception_print)
7527 (exception_fprintf, exception_print_same): Update.
7528 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7529 * dwarf-index-cache.c (index_cache::store)
7530 (index_cache::lookup_gdb_index): Update.
7531 * darwin-nat.c (maybe_cache_shell): Update.
7532 * cp-valprint.c (cp_print_value_fields): Update.
7533 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7534 (gcc_cplus_symbol_address): Update.
7535 * compile/compile-c-symbols.c (gcc_convert_symbol)
7536 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7537 * common/selftest.c: Update.
7538 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7539 a std::string.
7540 (exception_try_scope_entry, exception_try_scope_exit): Don't
7541 declare.
7542 (struct exception_try_scope): Remove.
7543 (TRY): Don't use exception_try_scope.
7544 (struct gdb_exception): Add constructor, operator=.
7545 <what>: New method.
7546 (struct gdb_exception_RETURN_MASK_ALL)
7547 (struct gdb_exception_RETURN_MASK_ERROR)
7548 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7549 (struct gdb_quit_bad_alloc): Update.
7550 * common/common-exceptions.c (exception_none): Change
7551 initializer.
7552 (struct catcher) <state, exception>: Initialize inline.
7553 <prev>: Remove member.
7554 (current_catcher): Remove.
7555 (catchers): New global.
7556 (exceptions_state_mc_init): Simplify.
7557 (catcher_pop): Remove.
7558 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7559 (try_scope_depth, exception_try_scope_entry)
7560 (exception_try_scope_exit): Remove.
7561 (throw_exception_sjlj): Update.
7562 (exception_messages, exception_messages_size): Remove.
7563 (throw_it): Simplify.
7564 (gdb_exception_sliced_copy): Remove.
7565 (throw_exception_cxx): Update.
7566 * cli/cli-script.c (script_from_file): Update.
7567 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7568 Update.
7569 * ada-valprint.c (ada_val_print): Update.
7570 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7571 (create_excep_cond_exprs): Update.
7572
c5c10118
TT		 75732019-04-08 Tom Tromey <tom@tromey.com>
7574
7575 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7576 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7577 (TRY, CATCH, END_CATCH): Remove some definitions.
7578 * common/common-exceptions.c: Don't use GDB_XCPT.
7579 (catcher_list_size): Remove.
7580 (throw_exception, throw_it): Simplify.
7581
4de283e4
TT		 75822019-04-05 Tom Tromey <tom@tromey.com>
7583
7584 Revert the header-sorting patch.
7585 * ft32-tdep.c: Revert.
7586 * frv-tdep.c: Revert.
7587 * frv-linux-tdep.c: Revert.
7588 * frame.c: Revert.
7589 * frame-unwind.c: Revert.
7590 * frame-base.c: Revert.
7591 * fork-child.c: Revert.
7592 * findvar.c: Revert.
7593 * findcmd.c: Revert.
7594 * filesystem.c: Revert.
7595 * filename-seen-cache.h: Revert.
7596 * filename-seen-cache.c: Revert.
7597 * fbsd-tdep.c: Revert.
7598 * fbsd-nat.h: Revert.
7599 * fbsd-nat.c: Revert.
7600 * f-valprint.c: Revert.
7601 * f-typeprint.c: Revert.
7602 * f-lang.c: Revert.
7603 * extension.h: Revert.
7604 * extension.c: Revert.
7605 * extension-priv.h: Revert.
7606 * expprint.c: Revert.
7607 * exec.h: Revert.
7608 * exec.c: Revert.
7609 * exceptions.c: Revert.
7610 * event-top.c: Revert.
7611 * event-loop.c: Revert.
7612 * eval.c: Revert.
7613 * elfread.c: Revert.
7614 * dwarf2read.h: Revert.
7615 * dwarf2read.c: Revert.
7616 * dwarf2loc.c: Revert.
7617 * dwarf2expr.h: Revert.
7618 * dwarf2expr.c: Revert.
7619 * dwarf2-frame.c: Revert.
7620 * dwarf2-frame-tailcall.c: Revert.
7621 * dwarf-index-write.h: Revert.
7622 * dwarf-index-write.c: Revert.
7623 * dwarf-index-common.c: Revert.
7624 * dwarf-index-cache.h: Revert.
7625 * dwarf-index-cache.c: Revert.
7626 * dummy-frame.c: Revert.
7627 * dtrace-probe.c: Revert.
7628 * disasm.h: Revert.
7629 * disasm.c: Revert.
7630 * disasm-selftests.c: Revert.
7631 * dictionary.c: Revert.
7632 * dicos-tdep.c: Revert.
7633 * demangle.c: Revert.
7634 * dcache.h: Revert.
7635 * dcache.c: Revert.
7636 * darwin-nat.h: Revert.
7637 * darwin-nat.c: Revert.
7638 * darwin-nat-info.c: Revert.
7639 * d-valprint.c: Revert.
7640 * d-namespace.c: Revert.
7641 * d-lang.c: Revert.
7642 * ctf.c: Revert.
7643 * csky-tdep.c: Revert.
7644 * csky-linux-tdep.c: Revert.
7645 * cris-tdep.c: Revert.
7646 * cris-linux-tdep.c: Revert.
7647 * cp-valprint.c: Revert.
7648 * cp-support.c: Revert.
7649 * cp-namespace.c: Revert.
7650 * cp-abi.c: Revert.
7651 * corelow.c: Revert.
7652 * corefile.c: Revert.
7653 * continuations.c: Revert.
7654 * completer.h: Revert.
7655 * completer.c: Revert.
7656 * complaints.c: Revert.
7657 * coffread.c: Revert.
7658 * coff-pe-read.c: Revert.
7659 * cli-out.h: Revert.
7660 * cli-out.c: Revert.
7661 * charset.c: Revert.
7662 * c-varobj.c: Revert.
7663 * c-valprint.c: Revert.
7664 * c-typeprint.c: Revert.
7665 * c-lang.c: Revert.
7666 * buildsym.c: Revert.
7667 * buildsym-legacy.c: Revert.
7668 * build-id.h: Revert.
7669 * build-id.c: Revert.
7670 * btrace.c: Revert.
7671 * bsd-uthread.c: Revert.
7672 * breakpoint.h: Revert.
7673 * breakpoint.c: Revert.
7674 * break-catch-throw.c: Revert.
7675 * break-catch-syscall.c: Revert.
7676 * break-catch-sig.c: Revert.
7677 * blockframe.c: Revert.
7678 * block.c: Revert.
7679 * bfin-tdep.c: Revert.
7680 * bfin-linux-tdep.c: Revert.
7681 * bfd-target.c: Revert.
7682 * bcache.c: Revert.
7683 * ax-general.c: Revert.
7684 * ax-gdb.h: Revert.
7685 * ax-gdb.c: Revert.
7686 * avr-tdep.c: Revert.
7687 * auxv.c: Revert.
7688 * auto-load.c: Revert.
7689 * arm-wince-tdep.c: Revert.
7690 * arm-tdep.c: Revert.
7691 * arm-symbian-tdep.c: Revert.
7692 * arm-pikeos-tdep.c: Revert.
7693 * arm-obsd-tdep.c: Revert.
7694 * arm-nbsd-tdep.c: Revert.
7695 * arm-nbsd-nat.c: Revert.
7696 * arm-linux-tdep.c: Revert.
7697 * arm-linux-nat.c: Revert.
7698 * arm-fbsd-tdep.c: Revert.
7699 * arm-fbsd-nat.c: Revert.
7700 * arm-bsd-tdep.c: Revert.
7701 * arch-utils.c: Revert.
7702 * arc-tdep.c: Revert.
7703 * arc-newlib-tdep.c: Revert.
7704 * annotate.h: Revert.
7705 * annotate.c: Revert.
7706 * amd64-windows-tdep.c: Revert.
7707 * amd64-windows-nat.c: Revert.
7708 * amd64-tdep.c: Revert.
7709 * amd64-sol2-tdep.c: Revert.
7710 * amd64-obsd-tdep.c: Revert.
7711 * amd64-obsd-nat.c: Revert.
7712 * amd64-nbsd-tdep.c: Revert.
7713 * amd64-nbsd-nat.c: Revert.
7714 * amd64-nat.c: Revert.
7715 * amd64-linux-tdep.c: Revert.
7716 * amd64-linux-nat.c: Revert.
7717 * amd64-fbsd-tdep.c: Revert.
7718 * amd64-fbsd-nat.c: Revert.
7719 * amd64-dicos-tdep.c: Revert.
7720 * amd64-darwin-tdep.c: Revert.
7721 * amd64-bsd-nat.c: Revert.
7722 * alpha-tdep.c: Revert.
7723 * alpha-obsd-tdep.c: Revert.
7724 * alpha-nbsd-tdep.c: Revert.
7725 * alpha-mdebug-tdep.c: Revert.
7726 * alpha-linux-tdep.c: Revert.
7727 * alpha-linux-nat.c: Revert.
7728 * alpha-bsd-tdep.c: Revert.
7729 * alpha-bsd-nat.c: Revert.
7730 * aix-thread.c: Revert.
7731 * agent.c: Revert.
7732 * addrmap.c: Revert.
7733 * ada-varobj.c: Revert.
7734 * ada-valprint.c: Revert.
7735 * ada-typeprint.c: Revert.
7736 * ada-tasks.c: Revert.
7737 * ada-lang.c: Revert.
7738 * aarch64-tdep.c: Revert.
7739 * aarch64-ravenscar-thread.c: Revert.
7740 * aarch64-newlib-tdep.c: Revert.
7741 * aarch64-linux-tdep.c: Revert.
7742 * aarch64-linux-nat.c: Revert.
7743 * aarch64-fbsd-tdep.c: Revert.
7744 * aarch64-fbsd-nat.c: Revert.
7745 * aarch32-linux-nat.c: Revert.
7746
d55e5aa6
TT		 77472019-04-05 Tom Tromey <tom@tromey.com>
7748
7749 * ft32-tdep.c: Sort headers.
7750 * frv-tdep.c: Sort headers.
7751 * frv-linux-tdep.c: Sort headers.
7752 * frame.c: Sort headers.
7753 * frame-unwind.c: Sort headers.
7754 * frame-base.c: Sort headers.
7755 * fork-child.c: Sort headers.
7756 * findvar.c: Sort headers.
7757 * findcmd.c: Sort headers.
7758 * filesystem.c: Sort headers.
7759 * filename-seen-cache.h: Sort headers.
7760 * filename-seen-cache.c: Sort headers.
7761 * fbsd-tdep.c: Sort headers.
7762 * fbsd-nat.h: Sort headers.
7763 * fbsd-nat.c: Sort headers.
7764 * f-valprint.c: Sort headers.
7765 * f-typeprint.c: Sort headers.
7766 * f-lang.c: Sort headers.
7767 * extension.h: Sort headers.
7768 * extension.c: Sort headers.
7769 * extension-priv.h: Sort headers.
7770 * expprint.c: Sort headers.
7771 * exec.h: Sort headers.
7772 * exec.c: Sort headers.
7773 * exceptions.c: Sort headers.
7774 * event-top.c: Sort headers.
7775 * event-loop.c: Sort headers.
7776 * eval.c: Sort headers.
7777 * elfread.c: Sort headers.
7778 * dwarf2read.h: Sort headers.
7779 * dwarf2read.c: Sort headers.
7780 * dwarf2loc.c: Sort headers.
7781 * dwarf2expr.h: Sort headers.
7782 * dwarf2expr.c: Sort headers.
7783 * dwarf2-frame.c: Sort headers.
7784 * dwarf2-frame-tailcall.c: Sort headers.
7785 * dwarf-index-write.h: Sort headers.
7786 * dwarf-index-write.c: Sort headers.
7787 * dwarf-index-common.c: Sort headers.
7788 * dwarf-index-cache.h: Sort headers.
7789 * dwarf-index-cache.c: Sort headers.
7790 * dummy-frame.c: Sort headers.
7791 * dtrace-probe.c: Sort headers.
7792 * disasm.h: Sort headers.
7793 * disasm.c: Sort headers.
7794 * disasm-selftests.c: Sort headers.
7795 * dictionary.c: Sort headers.
7796 * dicos-tdep.c: Sort headers.
7797 * demangle.c: Sort headers.
7798 * dcache.h: Sort headers.
7799 * dcache.c: Sort headers.
7800 * darwin-nat.h: Sort headers.
7801 * darwin-nat.c: Sort headers.
7802 * darwin-nat-info.c: Sort headers.
7803 * d-valprint.c: Sort headers.
7804 * d-namespace.c: Sort headers.
7805 * d-lang.c: Sort headers.
7806 * ctf.c: Sort headers.
7807 * csky-tdep.c: Sort headers.
7808 * csky-linux-tdep.c: Sort headers.
7809 * cris-tdep.c: Sort headers.
7810 * cris-linux-tdep.c: Sort headers.
7811 * cp-valprint.c: Sort headers.
7812 * cp-support.c: Sort headers.
7813 * cp-namespace.c: Sort headers.
7814 * cp-abi.c: Sort headers.
7815 * corelow.c: Sort headers.
7816 * corefile.c: Sort headers.
7817 * continuations.c: Sort headers.
7818 * completer.h: Sort headers.
7819 * completer.c: Sort headers.
7820 * complaints.c: Sort headers.
7821 * coffread.c: Sort headers.
7822 * coff-pe-read.c: Sort headers.
7823 * cli-out.h: Sort headers.
7824 * cli-out.c: Sort headers.
7825 * charset.c: Sort headers.
7826 * c-varobj.c: Sort headers.
7827 * c-valprint.c: Sort headers.
7828 * c-typeprint.c: Sort headers.
7829 * c-lang.c: Sort headers.
7830 * buildsym.c: Sort headers.
7831 * buildsym-legacy.c: Sort headers.
7832 * build-id.h: Sort headers.
7833 * build-id.c: Sort headers.
7834 * btrace.c: Sort headers.
7835 * bsd-uthread.c: Sort headers.
7836 * breakpoint.h: Sort headers.
7837 * breakpoint.c: Sort headers.
7838 * break-catch-throw.c: Sort headers.
7839 * break-catch-syscall.c: Sort headers.
7840 * break-catch-sig.c: Sort headers.
7841 * blockframe.c: Sort headers.
7842 * block.c: Sort headers.
7843 * bfin-tdep.c: Sort headers.
7844 * bfin-linux-tdep.c: Sort headers.
7845 * bfd-target.c: Sort headers.
7846 * bcache.c: Sort headers.
7847 * ax-general.c: Sort headers.
7848 * ax-gdb.h: Sort headers.
7849 * ax-gdb.c: Sort headers.
7850 * avr-tdep.c: Sort headers.
7851 * auxv.c: Sort headers.
7852 * auto-load.c: Sort headers.
7853 * arm-wince-tdep.c: Sort headers.
7854 * arm-tdep.c: Sort headers.
7855 * arm-symbian-tdep.c: Sort headers.
7856 * arm-pikeos-tdep.c: Sort headers.
7857 * arm-obsd-tdep.c: Sort headers.
7858 * arm-nbsd-tdep.c: Sort headers.
7859 * arm-nbsd-nat.c: Sort headers.
7860 * arm-linux-tdep.c: Sort headers.
7861 * arm-linux-nat.c: Sort headers.
7862 * arm-fbsd-tdep.c: Sort headers.
7863 * arm-fbsd-nat.c: Sort headers.
7864 * arm-bsd-tdep.c: Sort headers.
7865 * arch-utils.c: Sort headers.
7866 * arc-tdep.c: Sort headers.
7867 * arc-newlib-tdep.c: Sort headers.
7868 * annotate.h: Sort headers.
7869 * annotate.c: Sort headers.
7870 * amd64-windows-tdep.c: Sort headers.
7871 * amd64-windows-nat.c: Sort headers.
7872 * amd64-tdep.c: Sort headers.
7873 * amd64-sol2-tdep.c: Sort headers.
7874 * amd64-obsd-tdep.c: Sort headers.
7875 * amd64-obsd-nat.c: Sort headers.
7876 * amd64-nbsd-tdep.c: Sort headers.
7877 * amd64-nbsd-nat.c: Sort headers.
7878 * amd64-nat.c: Sort headers.
7879 * amd64-linux-tdep.c: Sort headers.
7880 * amd64-linux-nat.c: Sort headers.
7881 * amd64-fbsd-tdep.c: Sort headers.
7882 * amd64-fbsd-nat.c: Sort headers.
7883 * amd64-dicos-tdep.c: Sort headers.
7884 * amd64-darwin-tdep.c: Sort headers.
7885 * amd64-bsd-nat.c: Sort headers.
7886 * alpha-tdep.c: Sort headers.
7887 * alpha-obsd-tdep.c: Sort headers.
7888 * alpha-nbsd-tdep.c: Sort headers.
7889 * alpha-mdebug-tdep.c: Sort headers.
7890 * alpha-linux-tdep.c: Sort headers.
7891 * alpha-linux-nat.c: Sort headers.
7892 * alpha-bsd-tdep.c: Sort headers.
7893 * alpha-bsd-nat.c: Sort headers.
7894 * aix-thread.c: Sort headers.
7895 * agent.c: Sort headers.
7896 * addrmap.c: Sort headers.
7897 * ada-varobj.c: Sort headers.
7898 * ada-valprint.c: Sort headers.
7899 * ada-typeprint.c: Sort headers.
7900 * ada-tasks.c: Sort headers.
7901 * ada-lang.c: Sort headers.
7902 * aarch64-tdep.c: Sort headers.
7903 * aarch64-ravenscar-thread.c: Sort headers.
7904 * aarch64-newlib-tdep.c: Sort headers.
7905 * aarch64-linux-tdep.c: Sort headers.
7906 * aarch64-linux-nat.c: Sort headers.
7907 * aarch64-fbsd-tdep.c: Sort headers.
7908 * aarch64-fbsd-nat.c: Sort headers.
7909 * aarch32-linux-nat.c: Sort headers.
7910
699bd4cf
TT		 79112019-04-04 Tom Tromey <tom@tromey.com>
7912
7913 * varobj.c (varobj_create): Update.
7914 * rust-exp.y (struct rust_parser) <update_innermost_block,
7915 lookup_symbol>: New methods.
7916 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7917 Rename.
7918 (rust_parser::rust_lookup_type)
7919 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7920 * printcmd.c (display_command, do_one_display): Update.
7921 * parser-defs.h (struct parser_state) <parser_state>: Add
7922 "tracker" parameter.
7923 (block_tracker): New member.
7924 (class innermost_block_tracker) <innermost_block_tracker>: Add
7925 "types" parameter.
7926 <reset>: Remove method.
7927 (innermost_block): Don't declare.
7928 (null_post_parser): Update.
7929 * parse.c (innermost_block): Remove global.
7930 (write_dollar_variable): Update.
7931 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7932 Remove "tracker_types" parameter.
7933 (parse_expression): Add "tracker" parameter.
7934 (parse_expression_for_completion): Update.
7935 (null_post_parser): Add "tracker" parameter.
7936 * p-exp.y: Update rules.
7937 * m2-exp.y: Update rules.
7938 * language.h (struct language_defn) <la_post_parser>: Add
7939 "tracker" parameter.
7940 * go-exp.y: Update rules.
7941 * f-exp.y: Update rules.
7942 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7943 parameter.
7944 * d-exp.y: Update rules.
7945 * c-exp.y: Update rules.
7946 * breakpoint.c (set_breakpoint_condition): Create an
7947 innermost_block_tracker.
7948 (watch_command_1): Likewise.
7949 * ada-lang.c (resolve): Add "tracker" parameter.
7950 (resolve_subexp): Likewise.
7951 * ada-exp.y (write_var_from_sym): Update.
7952
dac43e32
TT		 79532019-04-04 Tom Tromey <tom@tromey.com>
7954
7955 * type-stack.h: New file.
7956 * type-stack.c: New file.
7957 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7958 type-stack.h.
7959 (insert_into_type_stack, insert_type, push_type, push_type_int)
7960 (insert_type_address_space, pop_type, pop_type_int)
7961 (pop_typelist, pop_type_stack, append_type_stack)
7962 (push_type_stack, get_type_stack, push_typelist)
7963 (follow_type_instance_flags, follow_types): Don't declare.
7964 * parse.c (type_stack): Remove global.
7965 (parse_exp_in_context): Update.
7966 (insert_into_type_stack, insert_type, push_type, push_type_int)
7967 (insert_type_address_space, pop_type, pop_type_int)
7968 (pop_typelist, pop_type_stack, append_type_stack)
7969 (push_type_stack, get_type_stack, push_typelist)
7970 (follow_type_instance_flags, follow_types): Remove (moved to
7971 type-stack.c).
7972 * f-exp.y (type_stack): New global.
7973 Update rules.
7974 (push_kind_type, f_parse): Update.
7975 * d-exp.y (type_stack): New global.
7976 Update rules.
7977 (d_parse): Update.
7978 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7979 Update rules.
7980 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7981 (HFILES_NO_SRCDIR): Add type-stack.h.
7982
2a612529
TT		 79832019-04-04 Tom Tromey <tom@tromey.com>
7984
7985 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7986 (rust_parser::convert_ast_to_expression, rust_parse)
7987 (rust_lex_test_completion, rust_lex_tests): Update.
7988 * parser-defs.h (struct expr_completion_state): New.
7989 (struct parser_state) <parser_state>: Add completion parameter.
7990 <mark_struct_expression, mark_completion_tag>: New methods.
7991 <parse_completion, m_completion_state>: New members.
7992 (prefixify_expression, null_post_parser): Update.
7993 (mark_struct_expression, mark_completion_tag): Don't declare.
7994 * parse.c (parse_completion, expout_last_struct)
7995 (expout_tag_completion_type, expout_completion_name): Remove
7996 globals.
7997 (parser_state::mark_struct_expression)
7998 (parser_state::mark_completion_tag): Now methods.
7999 (prefixify_expression): Add last_struct parameter.
8000 (prefixify_subexp): Likewise.
8001 (parse_exp_1): Update.
8002 (parse_exp_in_context): Add cstate parameter. Update.
8003 (parse_expression_for_completion): Create an
8004 expr_completion_state.
8005 (null_post_parser): Add "completion" parameter.
8006 * p-exp.y: Update rules.
8007 (yylex): Update.
8008 * language.h (struct language_defn) <la_post_parser>: Add
8009 "completing" parameter.
8010 * go-exp.y: Update rules.
8011 (lex_one_token): Update.
8012 * expression.h (parse_completion): Don't declare.
8013 * d-exp.y: Update rules.
8014 (lex_one_token): Update rules.
8015 * c-exp.y: Update rules.
8016 (lex_one_token): Update.
8017 * ada-lang.c (resolve): Add "parse_completion" parameter.
8018 (resolve_subexp): Likewise.
8019 (ada_resolve_function): Likewise.
8020
43476f0b
TT		 80212019-04-04 Tom Tromey <tom@tromey.com>
8022
8023 * parser-defs.h (struct parser_state) <start_arglist,
8024 end_arglist>: New methods.
8025 <arglist_len, m_funcall_chain>: New members.
8026 (arglist_len, start_arglist, end_arglist): Don't declare.
8027 * parse.c (arglist_len, funcall_chain): Remove global.
8028 (start_arglist, end_arglist): Remove functions.
8029 (parse_exp_in_context): Update.
8030 * p-exp.y: Update rules.
8031 * m2-exp.y: Update rules.
8032 * go-exp.y: Update rules.
8033 * f-exp.y: Update rules.
8034 * d-exp.y: Update rules.
8035 * c-exp.y: Update rules.
8036
5776fca3
TT		 80372019-04-04 Tom Tromey <tom@tromey.com>
8038
8039 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8040 lex_operator, push_back>: New methods.
8041 Update all rules.
8042 (rust_parser::lex_hex, lex_escape): Rename and update.
8043 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8044 (rust_parser::lex_operator): Rename and update.
8045 (rust_parser::lex_number, rustyylex, rustyyerror)
8046 (rust_lex_test_init, rust_lex_test_sequence)
8047 (rust_lex_test_push_back, rust_lex_tests): Update.
8048 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8049 parameter.
8050 <lexptr, prev_lexptr>: New members.
8051 (lexptr, prev_lexptr): Don't declare.
8052 * parse.c (lexptr, prev_lexptr): Remove globals.
8053 (parse_exp_in_context): Update.
8054 * p-exp.y (yylex, yyerror): Update.
8055 * m2-exp.y (parse_number, yylex, yyerror): Update.
8056 * go-exp.y (lex_one_token, yyerror): Update.
8057 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8058 * d-exp.y (lex_one_token, yyerror): Update.
8059 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8060 (lex_one_token, yyerror): Update.
8061 * ada-lex.l (YY_INPUT): Update.
8062 (rewind_to_char): Update.
8063 * ada-exp.y (yyerror): Update.
8064
8621b685
TT		 80652019-04-04 Tom Tromey <tom@tromey.com>
8066
8067 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8068 * parser-defs.h (struct parser_state) <parser_state>: Add new
8069 parameter.
8070 <comma_terminates>: New member.
8071 (comma_terminates): Don't declare global.
8072 * parse.c (comma_terminates): Remove global.
8073 (parse_exp_in_context): Update.
8074 * p-exp.y (yylex): Update.
8075 * m2-exp.y (yylex): Update.
8076 * go-exp.y (lex_one_token): Update.
8077 * f-exp.y (yylex): Update.
8078 * d-exp.y (lex_one_token): Update.
8079 * c-exp.y (lex_one_token): Update.
8080 * ada-lex.l: Update.
8081
28aaf3fd
TT		 80822019-04-04 Tom Tromey <tom@tromey.com>
8083
8084 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8085 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8086 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8087 * parser-defs.h (paren_depth): Don't declare.
8088 * parse.c (paren_depth): Remove global.
8089 (parse_exp_in_context): Update.
8090 * p-exp.y (paren_depth): New global.
8091 (pascal_parse): Initialize it.
8092 * m2-exp.y (paren_depth): New global.
8093 (m2_parse): Initialize it.
8094 * go-exp.y (paren_depth): New global.
8095 (go_parse): Initialize it.
8096 * f-exp.y (paren_depth): New global.
8097 (f_parse): Initialize it.
8098 * d-exp.y (paren_depth): New global.
8099 (d_parse): Initialize it.
8100 * c-exp.y (paren_depth): New global.
8101 (c_parse): Initialize it.
8102 * ada-lex.l (paren_depth): New global.
8103 (lexer_init): Initialize it.
8104
1e58a4a4
TT		 81052019-04-04 Tom Tromey <tom@tromey.com>
8106
8107 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8108 (rust_parser::convert_ast_to_type)
8109 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8110 * parser-defs.h (struct parser_state) <parser_state>: Add
8111 parameters. Initialize new members.
8112 <expression_context_block, expression_context_pc>: New members.
8113 * parse.c (expression_context_block, expression_context_pc):
8114 Remove globals.
8115 (parse_exp_in_context): Update.
8116 * p-exp.y: Update all rules.
8117 (yylex): Update.
8118 * m2-exp.y: Update all rules.
8119 (yylex): Update.
8120 * go-exp.y (yylex): Update.
8121 * f-exp.y (yylex): Update.
8122 * d-exp.y: Update all rules.
8123 (yylex): Update.
8124 * c-exp.y: Update all rules.
8125 (lex_one_token, classify_name, yylex, c_parse): Update.
8126 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8127
37eedb39
TT		 81282019-04-04 Tom Tromey <tom@tromey.com>
8129
8130 * gdbarch.h, gdbarch.c: Rebuild.
8131 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8132 * stap-probe.h:
8133 (struct stap_parse_info): Replace "parser_state" with
8134 "expr_builder".
8135 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8136 (parser_state): New class.
8137 * parse.c (expr_builder): Rename.
8138 (expr_builder::release): Rename.
8139 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8140 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8141 (write_exp_elt_longcst, write_exp_elt_floatcst)
8142 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8143 (write_exp_string_vector, write_exp_bitstring)
8144 (write_exp_msymbol, mark_struct_expression)
8145 (write_dollar_variable)
8146 (insert_type_address_space, increase_expout_size): Replace
8147 "parser_state" with "expr_builder".
8148 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8149 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8150 "parser_state" with "expr_builder".
8151
73923d7e
TT		 81522019-04-04 Tom Tromey <tom@tromey.com>
8153
8154 * rust-exp.y: Replace "parse_language" with method call.
8155 * p-exp.y:
8156 (yylex): Replace "parse_language" with method call.
8157 * m2-exp.y:
8158 (yylex): Replace "parse_language" with method call.
8159 * go-exp.y (classify_name): Replace "parse_language" with method
8160 call.
8161 * f-exp.y (yylex): Replace "parse_language" with method call.
8162 * d-exp.y (lex_one_token): Replace "parse_language" with method
8163 call.
8164 * c-exp.y:
8165 (lex_one_token, classify_name, yylex): Replace "parse_language"
8166 with method call.
8167 * ada-exp.y (find_primitive_type, type_char)
8168 (type_system_address): Replace "parse_language" with method call.
8169
fa9f5be6
TT		 81702019-04-04 Tom Tromey <tom@tromey.com>
8171
8172 * rust-exp.y: Replace "parse_gdbarch" with method call.
8173 * parse.c (write_dollar_variable, insert_type_address_space):
8174 Replace "parse_gdbarch" with method call.
8175 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8176 call.
8177 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8178 call.
8179 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8180 "parse_gdbarch" with method call.
8181 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8182 with method call.
8183 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8184 "parse_gdbarch" with method call.
8185 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8186 "parse_gdbarch" with method call.
8187 * c-exp.y (parse_type, parse_number, classify_name): Replace
8188 "parse_gdbarch" with method call.
8189 * ada-lex.l: Replace "parse_gdbarch" with method call.
8190 * ada-exp.y (parse_type, find_primitive_type, type_char)
8191 (type_system_address): Replace "parse_gdbarch" with method call.
8192
1201a264
TT		 81932019-04-04 Tom Tromey <tom@tromey.com>
8194
8195 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8196 * stap-probe.c (stap_parse_argument): Update.
8197 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8198 initial_size parameter.
8199 * rust-exp.y (rust_lex_tests): Update.
8200 * parse.c (parser_state): Update.
8201 (parse_exp_in_context): Update.
8202 * parser-defs.h (struct parser_state) <parser_state>: Remove
8203 "initial_size" parameter.
8204
e3980ce2
TT		 82052019-04-04 Tom Tromey <tom@tromey.com>
8206
8207 * parser-defs.h (increase_expout_size): Don't declare.
8208 * parse.c (increase_expout_size): Now static.
8209
e9f8e3f1
TS		 82102019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8211
8212 * gnu-nat.c (gnu_nat_target::wait): Fix
8213 target_waitstatus_to_string call.
8214
d7df6549
AB		 82152019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8216
8217 * eval.c (evaluate_subexp_standard): Handle internal functions
8218 during Fortran function call handling.
8219
8bdc1658
AB		 82202019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8221
8222 * NEWS: Mention new internal functions.
8223 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8224 (read_base_type): Use dwarf2_init_complex_target_type.
8225 * value.c (creal_internal_fn): New function.
8226 (cimag_internal_fn): New function.
8227 (_initialize_values): Register new internal functions.
8228
c29705b7
PW		 82292019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8230
8231 * infrun.c (stop_all_threads): If debug_infrun, always
8232 trace the wait status after wait_one, using
8233 target_waitstatus_to_string and target_pid_to_str.
8234 (handle_inferior_event): Replace various trace of
8235 wait status kind by a single trace.
8236 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8237 wait status kind image by target_waitstatus_to_string.
8238 * target/waitstatus.c (target_waitstatus_to_string): Fix
8239 obsolete comment.
8240
05caa1d2
TT		 82412019-04-01 Tom Tromey <tromey@adacore.com>
8242
8243 PR symtab/23331:
8244 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8245
9d1447e0
SDJ		 82462019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8247 Pedro Alves <palves@redhat.com>
8248
8249 * top.c (quit_force): Call 'finalize_values'.
8250 * value.c (finalize_values): New function.
8251 * value.h (finalize_values): Declare.
8252
7734102d
EZ		 82532019-03-30 Eli Zaretskii <eliz@gnu.org>
8254
8255 * NEWS: Announce $_gdb_major and $_gdb_minor.
8256
8257 * top.c (init_gdb_version_vars): New function.
8258 (gdb_init): Call init_gdb_version_vars.
8259
188e1fa9
TT		 82602019-03-29 Tom Tromey <tromey@adacore.com>
8261
8262 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8263 help text. Remove dead code.
8264
2880242d
KS		 82652019-03-29 Keith Seitz <keiths@redhat.com>
8266
8267 From Siddhesh Poyarekar:
8268 * f-lang.h (f77_get_upperbound): Return LONGEST.
8269 (f77_get_lowerbound): Likewise.
8270 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8271 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8272 print them.
8273 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8274 plongest to format print it.
8275 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8276 (f77_get_upperbound): Likewise.
8277 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8278 LOWER_BOUND to LONGEST.
8279 (f77_create_arrayprint_offset_tbl): Likewise.
8280
cc1defb1
KS		 82812019-03-29 Keith Seitz <keiths@redhat.com>
8282
8283 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8284 %s/pulongest for TYPE_LENGTH instead of %d in format
8285 strings.
8286 * ada-typerint.c (ada_print_type): Likewise.
8287 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8288 * compile/compile-c-support.c (generate_register_struct): Likewise.
8289 * gdbtypes.c (recursive_dump_type): Likewise.
8290 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8291 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8292 instead of %d in format strings.
8293 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8294 to std::min to ULONGEST.
8295 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8296 instead of %d in format strings.
8297 * tracepoint.c (info_scope_command): Likewise.
8298 * typeprint.c (print_offset_data::update)
8299 (print_offset_data::finish): Likewise.
8300 * xtensa-tdep.c (xtensa_store_return_value)
8301 (xtensa_push_dummy_call): Likewise.
8302
e432ccf1
JT		 83032019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8304
8305 * windows-nat.c (display_selector): Fixed format specifications
8306 for 64-bit Cygwin.
8307
65d2b333
PW		 83082019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8309
8310 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8311
f489207e
SL		 83122019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8313
8314 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8315 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8316 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8317 (nios2_linux_init_abi): Install it.
8318
bffa1015
AH		 83192019-03-28 Alan Hayward <alan.hayward@arm.com>
8320
8321 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8322
fc96163a
AH		 83232019-03-28 Alan Hayward <alan.hayward@arm.com>
8324
8325 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8326
20dc7e9b
PW		 83272019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8328 Tom Tromey <tromey@adacore.com>
8329
8330 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8331
7f5331a8
JB		 83322019-03-26 Joel Brobecker <brobecker@adacore.com>
8333
8334 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8335 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8336 method to compute the bounds of range types. Also print "[evaluated]"
8337 if the bounds' values come from a dynamic evaluation.
8338
18c77628
AB		 83392019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8340
8341 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8342 whitespace when pretty printing is on.
8343
53c973f2
AH		 83442019-03-26 Alan Hayward <alan.hayward@arm.com>
8345
e79be6e5 8346 * ppc-linux-nat.c: Add include.
53c973f2 8347
d851aa71
AH		 83482019-03-26 Alan Hayward <alan.hayward@arm.com>
8349
e79be6e5 8350 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 8351
2fe7bab7
AH		 83522019-03-26 Alan Hayward <alan.hayward@arm.com>
8353
e79be6e5 8354 * arm-linux-nat.c: Add include.
2fe7bab7 8355
068ef30e
SM		 83562019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8357
8358 * source-cache.c (source_cache::get_source_lines): Re-read
8359 fullname after calling open_source_file.
8360
81a24d04
JB		 83612019-03-25 John Baldwin <jhb@FreeBSD.org>
8362
8363 * NEWS: Mention TLS support for FreeBSD.
8364
79e7ae11
TT		 83652019-03-25 Tom Tromey <tromey@adacore.com>
8366
8367 * minsyms.c (BUNCH_SIZE): Update comment.
8368 (~minimal_symbol_reader): Remove old comment.
8369 (compact_minimal_symbols): Update comment.
8370 (minimal_symbol_reader::install): Remove old comment. Update
8371 other comments.
8372
d45963c2
AH		 83732019-03-25 Alan Hayward <alan.hayward@arm.com>
8374
8375 * s390-linux-nat.c: Add include.
8376
0f83012e
AH		 83772019-03-25 Alan Hayward <alan.hayward@arm.com>
8378
8379 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8380 Call linux_get_hwcap.
8381 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8382 Likewise.
8383 (aarch64_linux_get_hwcap): Remove function.
8384 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8385 declaration.
8386 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8387 linux_get_hwcap.
8388 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8389 * linux-tdep.c (linux_get_hwcap): Add function.
8390 (linux_get_hwcap2): Likewise.
8391 * linux-tdep.h (linux_get_hwcap): Add declaration.
8392 (linux_get_hwcap2): Likewise.
8393 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8394 (ppc_linux_get_hwcap2): Likewise.
8395 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8396 linux_get_hwcap.
8397 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8398 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8399 (ppc_linux_nat_target::read_description): Likewise.
8400 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8401 * s390-linux-nat.c: Likewise.
8402 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8403
6640a367
TT		 84042019-03-24 Tom Tromey <tom@tromey.com>
8405
8406 * ada-lang.c (standard_lookup): Simplify initialization.
8407 (ada_lookup_symbol_nonlocal): Simplify return.
8408 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8409 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8410 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8411 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8412 initialization.
8413 * solib.c (solib_global_lookup): Simplify.
8414 * symtab.c (null_block_symbol): Remove.
8415 (symbol_cache_lookup): Simplify returns.
8416 (lookup_language_this): Simplify returns.
8417 (lookup_symbol_aux): Simplify return.
8418 (lookup_local_symbol): Simplify returns.
8419 (lookup_global_symbol_from_objfile): Simplify return.
8420 (lookup_symbol_in_objfile_symtabs)
8421 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8422 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8423 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8424 * cp-namespace.c (cp_lookup_bare_symbol)
8425 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8426 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8427 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8428 (cp_lookup_symbol_via_imports): Simplify initialization.
8429 (find_symbol_in_baseclass): Likewise.
8430 * symtab.h (null_block_symbol): Remove.
8431 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8432 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8433 (d_lookup_symbol_module): Likewise.
8434 (find_symbol_in_baseclass): Simplify initialization.
8435
a930ebcd
TT		 84362019-03-24 Tom Tromey <tom@tromey.com>
8437
8438 * expression.h: Don't include symtab.h.
8439 (struct block): Forward declare.
8440
582942f4
TT		 84412019-03-24 Tom Tromey <tom@tromey.com>
8442
8443 * c-exp.y (typebase): Remove casts.
8444 * gdbtypes.c (lookup_unsigned_typename, )
8445 (lookup_signed_typename): Remove cast.
8446 * eval.c (parse_to_comma_and_eval): Remove cast.
8447 * parse.c (write_dollar_variable): Remove cast.
8448 * block.h (struct block) <superblock>: Now const.
8449 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8450 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8451 (map_block): Make "block" const.
8452 * symfile.h (struct quick_symbol_functions)
8453 <map_matching_symbols>: Constify block argument to "callback".
8454 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8455 const.
8456 (find_pc_sect_compunit_symtab): Make "b" const.
8457 (find_symbol_at_address): Likewise.
8458 (search_symbols): Likewise.
8459 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8460 (dw2_debug_names_lookup_symbol): Likewise.
8461 (dw2_map_matching_symbols): Update.
8462 * p-valprint.c (pascal_val_print): Remove "block".
8463 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8464 (aux_add_nonlocal_symbols): Make "block" const.
8465 (resolve_subexp): Remove cast.
8466 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8467 const.
8468 (iterate_over_file_blocks): Likewise.
8469 * f-exp.y (%union) <bval>: Remove.
8470 * coffread.c (patch_opaque_types): Make "b" const.
8471 * spu-tdep.c (spu_catch_start): Make "block" const.
8472 * c-valprint.c (print_unpacked_pointer): Remove "block".
8473 * symmisc.c (dump_symtab_1): Make "b" const.
8474 (block_depth): Make "block" const.
8475 * d-exp.y (%union) <bval>: Remove.
8476 * cp-support.h (cp_lookup_rtti_type): Update.
8477 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8478 * psymtab.c (psym_lookup_symbol): Make "block" const.
8479 (maintenance_check_psymtabs): Make "b" const.
8480 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8481 (enumerate_locals, enumerate_args): Update.
8482 * python/py-symtab.c (stpy_global_block): Make "block" const.
8483 (stpy_static_block): Likewise.
8484 * inline-frame.c (block_starting_point_at): Make "new_block"
8485 const.
8486 * block.c (find_block_in_blockvector): Make return type const.
8487 (blockvector_for_pc_sect): Make "b" const.
8488 (find_block_in_blockvector): Make "b" const.
8489
7ad417dd
TT		 84902019-03-23 Tom Tromey <tom@tromey.com>
8491
8492 * varobj.c (varobj_create): Update.
8493 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8494 * printcmd.c (display_command, do_one_display): Don't reset
8495 innermost_block.
8496 * parser-defs.h (enum innermost_block_tracker_type): Move to
8497 expression.h.
8498 (innermost_block): Update comment.
8499 * parse.c (parse_exp_1): Add tracker_types parameter.
8500 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8501 tracker_types parameter. Reset innermost_block.
8502 (parse_exp_in_context): Remove.
8503 (parse_expression_for_completion): Update.
8504 * objfiles.c (~objfile): Don't reset expression_context_block or
8505 innermost_block.
8506 * expression.h (enum innermost_block_tracker_type): Move from
8507 parser-defs.h.
8508 (parse_exp_1): Add tracker_types parameter.
8509 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8510 reset innermost_block.
8511
b366c208
TT		 85122019-03-23 Tom Tromey <tom@tromey.com>
8513
8514 * objfiles.h: Include bcache.h.
8515
9bb9b2f9
TT		 85162019-03-23 Tom Tromey <tom@tromey.com>
8517
8518 * linespec.c (get_current_search_block): Use
8519 scoped_restore_current_language.
8520 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8521
59c28372
AH		 85222019-03-22 Alan Hayward <alan.hayward@arm.com>
8523 Jiong Wang <jiong.wang@arm.com>
8524
8525 * aarch64-linux-tdep.c
8526 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8527 section.
8528 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8529
17e116a7
AH		 85302019-03-22 Alan Hayward <alan.hayward@arm.com>
8531 Jiong Wang <jiong.wang@arm.com>
8532
8533 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8534 instructions.
8535 (aarch64_analyze_prologue_test): Add PACIASP test.
8536 (aarch64_prologue_prev_register): Unmask PC value.
8537
11e1b75f
AH		 85382019-03-22 Alan Hayward <alan.hayward@arm.com>
8539 Jiong Wang <jiong.wang@arm.com>
8540
8541 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8542 (aarch64_dwarf2_prev_register): Unmask PC value.
8543 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8544 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8545 DW_CFA_AARCH64_negate_ra_state.
8546 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8547
34dcc7cf
AH		 85482019-03-22 Alan Hayward <alan.hayward@arm.com>
8549 Jiong Wang <jiong.wang@arm.com>
8550
8551 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8552 registers.
8553 (aarch64_pseudo_register_name): Likewise.
8554 (aarch64_pseudo_register_type): Likewise.
8555 (aarch64_pseudo_register_reggroup_p): Likewise.
8556 (aarch64_gdbarch_init): Add pauth registers.
8557 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8558 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8559 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8560 (struct gdbarch_tdep): Add regnum for ra_state.
8561
1ef53e6b
AH		 85622019-03-22 Alan Hayward <alan.hayward@arm.com>
8563 Jiong Wang <jiong.wang@arm.com>
8564
8565 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8566
76bed0fd
AH		 85672019-03-22 Alan Hayward <alan.hayward@arm.com>
8568 Jiong Wang <jiong.wang@arm.com>
8569
8570 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8571 function.
8572 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8573 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8574 (aarch64_gdbarch_init): Add puth registers.
8575 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8576 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8577 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8578
ee4fbcfa
AH		 85792019-03-22 Alan Hayward <alan.hayward@arm.com>
8580 Jiong Wang <jiong.wang@arm.com>
8581
8582 * aarch64-linux-nat.c
8583 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8584 * aarch64-linux-tdep.c
8585 (aarch64_linux_core_read_description): Likewise.
8586 (aarch64_linux_get_hwcap): New function.
8587 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8588 (aarch64_linux_get_hwcap): New declaration.
8589
6dc0ebde
AH		 85902019-03-22 Alan Hayward <alan.hayward@arm.com>
8591 Jiong Wang <jiong.wang@arm.com>
8592
8593 * aarch64-linux-nat.c
8594 (aarch64_linux_nat_target::read_description): Add pauth param.
8595 * aarch64-linux-tdep.c
8596 (aarch64_linux_core_read_description): Likewise.
8597 * aarch64-tdep.c (struct target_desc): Add in pauth.
8598 (aarch64_read_description): Add pauth param.
8599 (aarch64_gdbarch_init): Likewise.
8600 * aarch64-tdep.h (aarch64_read_description): Likewise.
8601 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8602 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8603 * features/Makefile: Add new files.
8604 * features/aarch64-pauth.c: New file.
8605 * features/aarch64-pauth.xml: New file.
8606
595915c1
TT		 86072019-03-20 Tom Tromey <tromey@adacore.com>
8608
8609 * infrun.c (handle_inferior_event): Rename from
8610 handle_inferior_event_1. Create a scoped_value_mark.
8611 (handle_inferior_event): Remove.
8612
4c7d57e7
TT		 86132019-03-19 Tom Tromey <tromey@adacore.com>
8614
8615 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8616 * infrun.h (print_stop_event): Add "displays" parameter.
8617 * infrun.c (print_stop_event): Add "displays" parameter.
8618
cb246234
PA		 86192019-03-19 Pedro Alves <palves@redhat.com>
8620
8621 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8622 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8623 to -1. Fix TABs vs spaces.
8624 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8625 * tui/tui-out.h (tui_ui_out) Add intro comments.
8626 <m_line, m_start_of_line>: In-class initialize, and add describing
8627 comment.
8628
3a0e45b2
AH		 86292019-03-18 Alan Hayward <alan.hayward@arm.com>
8630
8631 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8632 variable names.
8633 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8634
5371b850
PA		 86352019-03-18 Pedro Alves <palves@redhat.com>
8636 Eli Zaretskii <eliz@gnu.org>
8637
8638 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8639 m_line and m_start_of_line.
8640
b17c4cd0
EZ		 86412019-03-18 Eli Zaretskii <eliz@gnu.org>
8642
8643 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8644 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8645 it returns a newline. This fixes a regression in TU mode, whereby
8646 the next line is output on the same screen line as the user input.
8647
4bd56d18
TT		 86482019-03-18 Tom Tromey <tromey@adacore.com>
8649
8650 * minsyms.c (minimal_symbol_reader::install): Remove call to
8651 obstack_blank.
8652
55c10aca
PA		 86532019-03-18 Pedro Alves <palves@redhat.com>
8654
8655 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8656 New globals.
8657 (apply_style): New, factored out from ...
8658 (apply_ansi_escape): ... this. Handle reverse video mode.
8659 (tui_set_reverse_mode): New function.
8660 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8661 * tui/tui-winsource.c (tui_show_source_line): Use
8662 tui_set_reverse_mode instead of setting A_STANDOUT.
8663 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8664 New setter methods.
8665
647bb750
HD		 86662019-03-18 Hannes Domani <ssbssa@yahoo.de>
8667
8668 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8669 Handle tabs.
8670
bff8c71f
TT		 86712019-03-18 Tom Tromey <tromey@adacore.com>
8672
8673 * ada-lang.c (empty_array): Add "high" parameter.
8674 (ada_evaluate_subexp): Update.
8675
58785d98
ST		 86762019-03-17 Sergei Trofimovich <siarheit@google.com>
8677
8678 * unittests/string_view-selftests.c: Define
8679 _initialize_string_view_selftests unconditionally.
8680
d4cbef22
ВМ		 86812019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8682
8683 PR gdb/24350
8684 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8685
fce4c071
ВМ		 86862019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8687
8688 PR gdb/24351
8689 * windows-nat.c (display_selector): Fix format specifiers.
8690
f7f0a123
EZ		 86912019-03-17 Eli Zaretskii <eliz@gnu.org>
8692
8693 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8694 tui_refill_source_window instead of tui_refresh_win, to update the
8695 current execution line. This fixes redisplay of the current line
8696 when stepping through the code with "next" or "step".
8697
ab42892f
EZ		 86982019-03-16 Eli Zaretskii <eliz@gnu.org>
8699
8700 * source-cache.c (source_cache::get_source_lines): Call
8701 find_source_lines to initialize s->nlines. This fixes vertical
8702 scrolling of TUI source window when the DOWN arrow is pressed.
8703
8d8c087f
PW		 87042019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8705
8706 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8707 linux-thread-db.c (_initialize_thread_db): Likewise.
8708
798e1c30
EZ		 87092019-03-16 Eli Zaretskii <eliz@gnu.org>
8710
8711 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8712 wclrtoeol in tui_show_source_line". This reverts changes made in
8713 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8714
eefba3da
TT		 87152019-03-15 Tom Tromey <tom@tromey.com>
8716
8717 * symtab.h (struct minimal_symbol): Derive from
8718 general_symbol_info.
8719 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8720 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8721 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8722 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8723 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8724 (MSYMBOL_SEARCH_NAME): Update.
8725 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8726 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8727 * minsyms.c (minimal_symbol_reader::record_full): Update.
8728
0de2420c
TT		 87292019-03-15 Tom Tromey <tom@tromey.com>
8730
8731 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8732
042d75e4
TT		 87332019-03-15 Tom Tromey <tom@tromey.com>
8734
8735 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8736 unique_xmalloc_ptr.
8737 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8738 Update.
8739 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8740 (build_minimal_symbol_hash_tables)
8741 (minimal_symbol_reader::install): Update.
8742
db92718b
TT		 87432019-03-15 Tom Tromey <tom@tromey.com>
8744
8745 * symtab.c (create_demangled_names_hash): Update.
8746 (symbol_set_names): Update.
8747 * objfiles.h (struct objfile_per_bfd_storage)
8748 <demangled_names_hash>: Now an htab_up.
8749 * objfiles.c (objfile_per_bfd_storage): Simplify.
8750
d6797f46
TT		 87512019-03-15 Tom Tromey <tom@tromey.com>
8752
8753 * objfiles.h (struct objfile_per_bfd_storage): Declare
8754 destructor.
8755 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8756 New.
8757 (get_objfile_bfd_data): Use new. Don't initialize
8758 language_of_main.
8759 (free_objfile_per_bfd_storage): Remove.
8760 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8761
741d7538
TT		 87622019-03-15 Tom Tromey <tom@tromey.com>
8763
8764 * symfile.c (reread_symbols): Update.
8765 * objfiles.c (objfile::objfile): Update.
8766 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8767 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8768 comment.
8769 (minimal_symbol_reader::install): Update.
8770 (terminate_minimal_symbol_table): Remove.
8771 * jit.c (jit_object_close_impl): Update.
8772
788c80d1
TT		 87732019-03-15 Tom Tromey <tom@tromey.com>
8774
8775 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8776 initializations.
8777
1b7a07cb
TT		 87782019-03-15 Tom Tromey <tom@tromey.com>
8779
8780 * objfiles.h (struct objfile_per_bfd_storage)
8781 <demangled_hash_languages>: Now a bitset.
8782 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8783 (lookup_minimal_symbol): Update.
8784
3db066bc
TT		 87852019-03-15 Tom Tromey <tom@tromey.com>
8786
8787 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8788 Don't return the symbol.
8789 * coffread.c (record_minimal_symbol): Use record_full.
8790
3fff2c37
EZ		 87912019-03-14 Eli Zaretskii <eliz@gnu.org>
8792
8793 The MS-Windows port of ncurses fails to switch to a color pair if
8794 one or both of the colors are the implicit default colors. This
8795 change records the default colors when TUI is initialized, and
8796 then specifies them explicitly when a color pair uses the default
8797 colors. This allows color styling in TUI mode on MS-Windows.
8798
8799 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8800 ncurses_norm_attr.
8801 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8802 colors in ncurses_norm_attr.
8803 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8804 "none", replace it with the default color recorded in
8805 ncurses_norm_attr.
8806
3b336828
TT		 88072019-03-14 Tom Tromey <tromey@adacore.com>
8808
8809 * source-cache.h (class source_cache) <get_source_lines>: Return
8810 std::string.
8811 * source-cache.c (source_cache::extract_lines): Handle case where
8812 first_pos==npos. Return std::string.
8813 (source_cache::get_source_lines): Update.
8814
d085f989
TT		 88152019-03-14 Tom Tromey <tromey@adacore.com>
8816
8817 * NEWS: Add item for "style sources" commands.
8818 * source-cache.c (source_cache::get_source_lines): Check
8819 source_styling.
8820 * cli/cli-style.c (source_styling): New global.
8821 (_initialize_cli_style): Add "style sources" commands.
8822 (show_style_sources): New function.
8823 * cli/cli-style.h (source_styling): Declare.
8824
6f11e682
TT		 88252019-03-14 Pedro Alves <palves@redhat.com>
8826 Tom Tromey <tromey@adacore.com>
8827
8828 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8829 * tui/tui-winsource.c (tui_refill_source_window): New function,
8830 from...
8831 (tui_horizontal_source_scroll): ... here. Move some logic.
8832 * cli/cli-style.c (set_style_enabled): Notify new observable.
8833 * tui/tui-hooks.c (tui_redisplay_source): New function.
8834 (tui_attach_detach_observers): Attach or detach
8835 tui_redisplay_source.
8836 * observable.h (source_styling_changed): New observable.
8837 * observable.c: Define source_styling_changed observable.
8838
a068643d
TT		 88392019-03-13 Tom Tromey <tromey@adacore.com>
8840
8841 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8842 (i386_gnu_nat_target::store_registers): Update.
8843 * target-debug.h (target_debug_print_std_string): New macro.
8844 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8845 * windows-tdep.c (display_one_tib): Update.
8846 * tui/tui-stack.c (tui_make_status_line): Update.
8847 * top.c (print_inferior_quit_action): Update.
8848 * thread.c (thr_try_catch_cmd): Update.
8849 (add_thread_with_info): Update.
8850 (thread_target_id_str): Update.
8851 (thr_try_catch_cmd): Update.
8852 (thread_command): Update.
8853 (thread_find_command): Update.
8854 * record-btrace.c (record_btrace_target::info_record)
8855 (record_btrace_resume_thread, record_btrace_target::resume)
8856 (record_btrace_cancel_resume, record_btrace_step_thread)
8857 (record_btrace_target::wait, record_btrace_target::wait)
8858 (record_btrace_target::wait, record_btrace_target::stop): Update.
8859 * progspace.c (print_program_space): Update.
8860 * process-stratum-target.c
8861 (process_stratum_target::thread_address_space): Update.
8862 * linux-fork.c (linux_fork_mourn_inferior)
8863 (detach_checkpoint_command, info_checkpoints_command)
8864 (linux_fork_context): Update.
8865 (linux_fork_detach): Update.
8866 (class scoped_switch_fork_info): Update.
8867 (delete_checkpoint_command): Update.
8868 * infrun.c (follow_fork_inferior): Update.
8869 (follow_fork_inferior): Update.
8870 (proceed_after_vfork_done): Update.
8871 (handle_vfork_child_exec_or_exit): Update.
8872 (follow_exec): Update.
8873 (displaced_step_prepare_throw): Update.
8874 (displaced_step_restore): Update.
8875 (start_step_over): Update.
8876 (resume_1): Update.
8877 (clear_proceed_status_thread): Update.
8878 (proceed): Update.
8879 (print_target_wait_results): Update.
8880 (do_target_wait): Update.
8881 (context_switch): Update.
8882 (stop_all_threads): Update.
8883 (restart_threads): Update.
8884 (finish_step_over): Update.
8885 (handle_signal_stop): Update.
8886 (switch_back_to_stepped_thread): Update.
8887 (keep_going_pass_signal): Update.
8888 (print_exited_reason): Update.
8889 (normal_stop): Update.
8890 * inferior.c (inferior_pid_to_str): Change return type.
8891 (print_selected_inferior): Update.
8892 (add_inferior): Update.
8893 (detach_inferior): Update.
8894 * dummy-frame.c (fprint_dummy_frames): Update.
8895 * dcache.c (dcache_info_1): Update.
8896 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8897 (btrace_fetch, btrace_clear): Update.
8898 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8899 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8900 type.
8901 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8902 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8903 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8904 * gdbarch.c, gdbarch.h: Rebuild.
8905 * gdbarch.sh (core_pid_to_str): Change return type.
8906 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8907 return type.
8908 (windows_nat_target::pid_to_str): Change return type.
8909 (windows_delete_thread): Update.
8910 (windows_nat_target::attach): Update.
8911 (windows_nat_target::files_info): Update.
8912 * target-delegates.c: Rebuild.
8913 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8914 return type.
8915 (sol_thread_target::pid_to_str): Change return type.
8916 * remote.c (class remote_target) <pid_to_str>: Change return
8917 type.
8918 (remote_target::pid_to_str): Change return type.
8919 (extended_remote_target::attach, remote_target::remote_stop_ns)
8920 (remote_target::remote_notif_remove_queued_reply)
8921 (remote_target::push_stop_reply, remote_target::disable_btrace):
8922 Update.
8923 (extended_remote_target::attach): Update.
8924 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8925 type.
8926 (gdbsim_target::pid_to_str): Change return type.
8927 * ravenscar-thread.c (struct ravenscar_thread_target)
8928 <pid_to_str>: Change return type.
8929 (ravenscar_thread_target::pid_to_str): Change return type.
8930 * procfs.c (class procfs_target) <pid_to_str>: Change return
8931 type.
8932 (procfs_target::pid_to_str): Change return type.
8933 (procfs_target::attach): Update.
8934 (procfs_target::detach): Update.
8935 (procfs_target::fetch_registers): Update.
8936 (procfs_target::store_registers): Update.
8937 (procfs_target::wait): Update.
8938 (procfs_target::files_info): Update.
8939 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8940 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8941 return type.
8942 (nto_procfs_target::pid_to_str): Change return type.
8943 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8944 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8945 return type.
8946 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8947 (exit_lwp): Update.
8948 (attach_proc_task_lwp_callback, get_detach_signal)
8949 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8950 (linux_nat_target::resume, wait_lwp, stop_callback)
8951 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8952 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8953 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8954 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8955 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8956 type.
8957 (inf_ptrace_target::attach): Update.
8958 (inf_ptrace_target::files_info): Update.
8959 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8960 type.
8961 (go32_nat_target::pid_to_str): Change return type.
8962 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8963 (gnu_nat_target::wait): Update.
8964 (gnu_nat_target::wait): Update.
8965 (gnu_nat_target::resume): Update.
8966 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8967 (fbsd_nat_target::wait): Update.
8968 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8969 type.
8970 (darwin_nat_target::attach): Update.
8971 * corelow.c (class core_target) <pid_to_str>: Change return type.
8972 (core_target::pid_to_str): Change return type.
8973 * target.c (normal_pid_to_str): Change return type.
8974 (default_pid_to_str): Likewise.
8975 (target_pid_to_str): Change return type.
8976 (target_translate_tls_address): Update.
8977 (target_announce_detach): Update.
8978 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8979 return type.
8980 (bsd_uthread_target::pid_to_str): Change return type.
8981 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8982 type.
8983 (bsd_kvm_target::pid_to_str): Change return type.
8984 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8985 return type.
8986 (aix_thread_target::pid_to_str): Change return type.
8987 * target.h (struct target_ops) <pid_to_str>: Change return type.
8988 (target_pid_to_str, normal_pid_to_str): Likewise.
8989 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8990 type.
8991 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8992 type.
8993 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8994 return type.
8995 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8996 type.
8997 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8998 type.
8999 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9000 return type.
9001
b4be1b06
SM		 90022019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9003
9004 * NEWS: Mention that the new default MI version is 3. Mention
9005 changes to the output of commands and events that deal with
9006 multi-location breakpoints.
9007 * breakpoint.c: Include "mi/mi-out.h".
9008 (print_one_breakpoint): Change output syntax if using MI version
9009 >= 3.
9010 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9011 New.
9012 (mi_multi_location_breakpoint_output_fixed): New.
9013 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9014 (mi_cmd_fix_multi_location_breakpoint_output): New.
9015 (mi_multi_location_breakpoint_output_fixed): New.
9016 * mi/mi-cmds.c (mi_cmds): Register command
9017 -fix-multi-location-breakpoint-output.
9018 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9019 interpreter "mi".
9020
8e5e5494
SM		 90212019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9022
9023 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9024 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9025 instantiate mi_ui_out based on interpreter name.
9026 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9027 * mi/mi-main.c (mi_load_progress): Likewise.
9028
197df35e
JB		 90292019-03-12 John Baldwin <jhb@FreeBSD.org>
9030
9031 * NEWS: Combine separate "New targets" sections for 8.3.
9032
8399425f
JB		 90332019-03-12 John Baldwin <jhb@FreeBSD.org>
9034
9035 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9036 (ppcfbsd_init_abi): Install gdbarch
9037 "fetch_tls_load_module_address" and "get_thread_local_address"
9038 methods.
9039
b0f87ed0
JB		 90402019-03-12 John Baldwin <jhb@FreeBSD.org>
9041
9042 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9043 (riscv_fbsd_init_abi): Install gdbarch
9044 "fetch_tls_load_module_address" and "get_thread_local_address"
9045 methods.
9046
ce25aa57
JB		 90472019-03-12 John Baldwin <jhb@FreeBSD.org>
9048
9049 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9050 (i386fbsd_init_abi): Install gdbarch
9051 "fetch_tls_load_module_address" and "get_thread_local_address"
9052 methods.
9053
f5424cfa
JB		 90542019-03-12 John Baldwin <jhb@FreeBSD.org>
9055
9056 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9057 (amd64fbsd_init_abi): Install gdbarch
9058 "fetch_tls_load_module_address" and "get_thread_local_address"
9059 methods.
9060
945f3901
JB		 90612019-03-12 John Baldwin <jhb@FreeBSD.org>
9062
9063 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9064 (struct fbsd_pspace_data): New type.
9065 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9066 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9067 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9068 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9069 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9070
ef0bd204
JB		 90712019-03-12 John Baldwin <jhb@FreeBSD.org>
9072
9073 * gdbtypes.c (lookup_struct_elt): New function.
9074 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9075 * gdbtypes.h (struct struct_elt): New type.
9076 (lookup_struct_elt): New prototype.
9077
36c53a02
JB		 90782019-03-12 John Baldwin <jhb@FreeBSD.org>
9079
9080 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9081 remove disabled code block.
9082
6e056c81
JB		 90832019-03-12 John Baldwin <jhb@FreeBSD.org>
9084
9085 * gdbarch.sh (get_thread_local_address): New method.
9086 * gdbarch.h, gdbarch.c: Regenerate.
9087 * target.c (target_translate_tls_address): Use
9088 gdbarch_get_thread_local_address if present instead of
9089 target::get_thread_local_address.
9090
cd250a18
JB		 90912019-03-12 John Baldwin <jhb@FreeBSD.org>
9092
9093 * target.h (target::get_thread_local_address): Update comment.
9094
df22c1e5
JB		 90952019-03-12 John Baldwin <jhb@FreeBSD.org>
9096
9097 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9098 objfile->separate_debug_objfile_backlink if not NULL.
9099
dd6876c9
JB		 91002019-03-12 John Baldwin <jhb@FreeBSD.org>
9101
9102 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9103 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9104 (amd64bsd_store_inferior_registers): Likewise.
9105 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9106 Enable segment base registers.
9107 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9108 PT_GETFSBASE and PT_GETGSBASE.
9109 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9110 PT_SETGSBASE.
9111 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9112 segment base registers.
9113 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9114
1163a4b7
JB		 91152019-03-12 John Baldwin <jhb@FreeBSD.org>
9116
9117 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9118 Update calls to i386_target_description to add 'segments'
9119 parameter.
9120 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9121 add segment base registers.
9122 * arch/i386.c (i386_create_target_description): Add 'segments'
9123 parameter to enable segment base registers.
9124 * arch/i386.h (i386_create_target_description): Likewise.
9125 * features/i386/32bit-segments.xml: New file.
9126 * features/i386/32bit-segments.c: Generate.
9127 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9128 call to i386_target_description to add 'segments' parameter.
9129 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9130 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9131 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9132 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9133 if feature is present.
9134 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9135 Add 'segments' parameter to call to i386_target_description.
9136 (i386_target_description): Add 'segments' parameter to enable
9137 segment base registers.
9138 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9139 to call to i386_target_description.
9140 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9141 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9142 Define I386_NUM_REGS.
9143 (i386_target_description): Add 'segments' parameter to enable
9144 segment base registers.
9145
3a350822
EZ		 91462019-03-12 Eli Zaretskii <eliz@gnu.org>
9147
9148 PR/24325
9149 * source-cache.c: #undef open and close, to avoid unresolved
9150 externals during linking.
9151
ffdd69cf
TT		 91522019-03-12 Tom Tromey <tromey@adacore.com>
9153
9154 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9155 const. Add initializers.
9156 (_initialize_remote): Don't initialize ptid globals.
9157
ec148c57
PA		 91582019-03-12 Pedro Alves <palves@redhat.com>
9159
9160 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9161
32764270
PA		 91622019-03-12 Pedro Alves <palves@redhat.com>
9163
9164 * cp-name-parser.y (main): Remove unused 'len' variable.
9165
17547186
TT		 91662019-03-12 Tom Tromey <tromey@adacore.com>
9167
9168 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9169 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9170
d3a70e03
TT		 91712019-03-12 Tom Tromey <tromey@adacore.com>
9172
9173 * linux-nat.c (iterate_over_lwps): Update.
9174 (stop_callback): Remove parameter.
9175 (stop_wait_callback, detach_callback, resume_set_callback)
9176 (select_singlestep_lwp_callback, set_ignore_sigint)
9177 (status_callback, resumed_callback, resume_clear_callback)
9178 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9179 data parameter.
9180 (linux_nat_target::detach, linux_nat_target::resume)
9181 (linux_stop_and_wait_all_lwps, select_event_lwp)
9182 (linux_nat_filter_event, linux_nat_wait_1)
9183 (linux_nat_target::kill, linux_nat_target::stop)
9184 (linux_nat_target::stop): Update.
9185 (linux_nat_resume_callback): Change type.
9186 (resume_stopped_resumed_lwps, count_events_callback)
9187 (select_event_lwp_callback): Likewise.
9188 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9189 * arm-linux-nat.c (struct update_registers_data): Remove.
9190 (update_registers_callback): Change type.
9191 (arm_linux_insert_hw_breakpoint1): Update.
9192 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9193 parameter.
9194 (x86_linux_dr_set_addr): Update.
9195 (x86_linux_dr_set_control): Update.
9196 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9197 (iterate_over_lwps): Use gdb::function_view.
9198 * nat/aarch64-linux-hw-point.c (struct
9199 aarch64_dr_update_callback_param): Remove.
9200 (debug_reg_change_callback): Change type.
9201 (aarch64_notify_debug_reg_change): Update.
9202 * s390-linux-nat.c (s390_refresh_per_info): Update.
9203
82cb27ff
TT		 92042019-03-11 Tom Tromey <tromey@adacore.com>
9205
9206 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9207 redundant assignment to "this_cu".
9208
568c0683
SM		 92092019-03-08 Simon Marchi <simon.marchi@efficios.com>
9210
9211 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9212
f09ce22d
SM		 92132019-03-08 Simon Marchi <simon.marchi@efficios.com>
9214
9215 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9216 from...
9217 (rank_one_type): ... this.
9218
595f96a9
SM		 92192019-03-08 Simon Marchi <simon.marchi@efficios.com>
9220
9221 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9222 from...
9223 (rank_one_type): ... this.
9224
2598a94b
SM		 92252019-03-08 Simon Marchi <simon.marchi@efficios.com>
9226
9227 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9228 from...
9229 (rank_one_type): ... this.
9230
7f17b20d
SM		 92312019-03-08 Simon Marchi <simon.marchi@efficios.com>
9232
9233 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9234 from...
9235 (rank_one_type): ... this.
9236
2c509035
SM		 92372019-03-08 Simon Marchi <simon.marchi@efficios.com>
9238
9239 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9240 from...
9241 (rank_one_type): ... this.
9242
0dd322dc
SM		 92432019-03-08 Simon Marchi <simon.marchi@efficios.com>
9244
9245 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9246 from...
9247 (rank_one_type): ... this.
9248
41ea4728
SM		 92492019-03-08 Simon Marchi <simon.marchi@efficios.com>
9250
9251 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9252 from...
9253 (rank_one_type): ... this.
9254
793cd1d2
SM		 92552019-03-08 Simon Marchi <simon.marchi@efficios.com>
9256
9257 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9258 from...
9259 (rank_one_type): ... this.
9260
34910087
SM		 92612019-03-08 Simon Marchi <simon.marchi@efficios.com>
9262
9263 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9264 from...
9265 (rank_one_type): ... this.
9266
f1f832d6
SM		 92672019-03-08 Simon Marchi <simon.marchi@efficios.com>
9268
9269 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9270 from...
9271 (rank_one_type): ... this.
9272
b9f4512f
SM		 92732019-03-08 Simon Marchi <simon.marchi@efficios.com>
9274
9275 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9276 from...
9277 (rank_one_type): ... this.
9278
9293fc63
SM		 92792019-03-08 Simon Marchi <simon.marchi@efficios.com>
9280
9281 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9282 from...
9283 (rank_one_type): ... this.
9284
e3abbe7e
PW		 92852019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9286
9287 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9288 inferior-events' shows the example events.
9289
e4adb939
EZ		 92902019-03-08 Eli Zaretskii <eliz@gnu.org>
9291
9292 Support styling on native MS-Windows console
9293
9294 PR/24315
9295 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9296 on MS-Windows if $TERM is not defined.
9297
9298 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9299
9300 * posix-hdep.c (gdb_console_fputs):
9301 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9302 functions.
9303 * ui-file.h (gdb_console_fputs): Add prototype.
9304
9305 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9306 back to fputs only if the former returns zero.
9307
25629dfd
TT		 93082019-03-07 Tom Tromey <tom@tromey.com>
9309
9310 * symmisc.c (print_symbol_bcache_statistics): Update.
9311 (print_objfile_statistics): Update.
9312 * symfile.c (allocate_symtab): Update.
9313 * stabsread.c: Don't include bcache.h.
9314 * psymtab.h (struct psymbol_bcache): Don't declare.
9315 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9316 (psymbol_bcache_init, psymbol_bcache_free)
9317 (psymbol_bcache_get_bcache): Don't declare.
9318 * psymtab.c (struct psymbol_bcache): Remove.
9319 (psymtab_storage::psymtab_storage): Update.
9320 (psymtab_storage::~psymtab_storage): Update.
9321 (psymbol_bcache_init, psymbol_bcache_free)
9322 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9323 (add_psymbol_to_bcache): Update.
9324 (allocate_psymtab): Update.
9325 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9326 macro_cache>: No longer pointers.
9327 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9328 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9329 * macrotab.c (macro_bcache): Update.
9330 * macroexp.c: Don't include bcache.h.
9331 * gdbtypes.c (check_types_worklist): Update.
9332 (types_deeply_equal): Remove TRY/CATCH. Update.
9333 * elfread.c (elf_symtab_read): Update.
9334 * dwarf2read.c: Don't include bcache.h.
9335 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9336 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9337 (print_bcache_statistics, bcache_memory_used): Don't declare.
9338 (struct bcache): Move from bcache.c. Add constructor, destructor,
9339 methods. Rename all data members.
9340 * bcache.c (struct bcache): Move to bcache.h.
9341 (bcache::expand_hash_table): Rename from expand_hash_table.
9342 (bcache): Remove.
9343 (bcache::insert): Rename from bcache_full.
9344 (bcache::compare): Rename from bcache_compare.
9345 (bcache_xmalloc): Remove.
9346 (bcache::~bcache): Rename from bcache_xfree.
9347 (bcache::print_statistics): Rename from print_bcache_statistics.
9348 (bcache::memory_used): Rename from bcache_memory_used.
9349
fe726667
PA		 93502019-03-07 Pedro Alves <palves@redhat.com>
9351
9352 * infrun.c (normal_stop): Also check for
9353 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9354
7584bb30
AB		 93552019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9356
9357 * f-lang.c (value_from_host_double): Moved to...
9358 * value.c (value_from_host_double): ...here.
9359 * value.h (value_from_host_double): Declare.
9360 * guile/scm-math.c (vlscm_convert_typed_number): Use
9361 value_from_host_double.
9362 (vlscm_convert_number): Likewise.
9363 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9364 * python/py-value.c (convert_value_from_python): Likewise.
9365
a7b1986e
TT		 93662019-03-06 Tom Tromey <tom@tromey.com>
9367
9368 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9369
0ccf4211
TT		 93702019-03-06 Tom Tromey <tom@tromey.com>
9371
9372 * utils.h (free_current_contents): Don't declare.
9373 * utils.c (free_current_contents): Remove.
9374
fe7b42e5
TT		 93752019-03-06 Tom Tromey <tom@tromey.com>
9376
9377 * top.c (quit_force): Update.
9378 * main.c (captured_command_loop): Update.
9379 * common/new-op.c (operator new): Update.
9380 * common/common-exceptions.c (struct catcher)
9381 <save_cleanup_chain>: Remove member.
9382 (exceptions_state_mc_init): Update.
9383 (exception_try_scope_entry): Return nullptr.
9384 (exception_try_scope_exit, exception_rethrow)
9385 (throw_exception_sjlj, throw_exception_cxx): Update.
9386 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9387 (all_cleanups, do_cleanups, discard_cleanups)
9388 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9389 (restore_cleanups, restore_final_cleanups): Don't declare.
9390 (do_final_cleanups): Remove parameter.
9391 * common/cleanups.c (cleanup_chain, make_cleanup)
9392 (make_cleanup_dtor, all_cleanups, do_cleanups)
9393 (discard_my_cleanups, discard_cleanups)
9394 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9395 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9396 (null_cleanup): Remove.
9397 (do_final_cleanups): Remove parameter.
9398
c6321f19
TT		 93992019-03-06 Tom Tromey <tom@tromey.com>
9400
9401 * remote.c (remote_target::remote_parse_stop_reply): Use
9402 unique_xmalloc_ptr.
9403
61b30099
TT		 94042019-03-06 Tom Tromey <tom@tromey.com>
9405
9406 * stabsread.c (struct stabs_field_info): Rename from field_info.
9407 <list, fnlist>: Add initializers.
9408 <obstack>: New member.
9409 (read_member_functions, read_struct_fields, read_baseclasses):
9410 Allocate on obstack. Don't use cleanups.
9411 (read_one_struct_field, read_member_functions, read_struct_fields)
9412 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9413 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9414 (read_struct_type): Update.
9415
6cceac94
TT		 94162019-03-06 Tom Tromey <tom@tromey.com>
9417
9418 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9419 * common/filestuff.h (make_cleanup_close): Don't declare.
9420 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9421 Remove.
9422
72412762
TT		 94232019-03-06 Tom Tromey <tom@tromey.com>
9424
9425 * solib-aix.c: Use make_scope_exit.
9426
2b6ff1c0
TT		 94272019-03-06 Tom Tromey <tom@tromey.com>
9428
9429 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9430 Use make_scope_exit.
9431
d01c5877
TT		 94322019-03-06 Tom Tromey <tom@tromey.com>
9433
9434 * solib-svr4.c (disable_probes_interface): Remove parameter.
9435 (svr4_handle_solib_event): Use make_scope_exit.
9436
32603266
TT		 94372019-03-06 Tom Tromey <tom@tromey.com>
9438
9439 * remote.c (struct stop_reply_deleter): Remove.
9440 (stop_reply_up): Update.
9441 (struct stop_reply): Derive from notif_event. Don't typedef.
9442 <regcache>: Now a std::vector.
9443 (stop_reply_xfree): Remove.
9444 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9445 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9446 (remote_target::discard_pending_stop_replies): Use delete.
9447 (remote_target::remote_parse_stop_reply): Update.
9448 (remote_target::process_stop_reply): Update.
9449 * remote-notif.h (struct notif_event): Add virtual destructor.
9450 Remove "dtr" member.
9451 (struct notif_client) <alloc_event>: Return a unique_ptr.
9452 (notif_event_xfree): Don't declare.
9453 (notif_event_up): New typedef.
9454 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9455 (notif_event_xfree, do_notif_event_xfree): Remove.
9456 (remote_notif_state_xfree): Update.
9457
9799571e
TT		 94582019-03-06 Tom Tromey <tom@tromey.com>
9459
9460 * infrun.c (displaced_step_clear_cleanup): Now a
9461 forward_scope_exit type.
9462 (displaced_step_prepare_throw): Update.
9463 (displaced_step_fixup): Update.
9464
09e3c4ca
TT		 94652019-03-06 Tom Tromey <tom@tromey.com>
9466
9467 * inferior.h (class inferior): Update comment.
9468 * gdbthread.h (class thread_info): Update comment.
9469
e2a03548
TT		 94702019-03-06 Joel Brobecker <brobecker@adacore.com>
9471 Tom Tromey <tom@tromey.com>
9472
9473 * stabsread.h (struct stab_section_list): Remove.
9474 (coffstab_build_psymtabs): Update.
9475 * dbxread.c (symbuf_sections): Now a std::vector.
9476 (sect_idx): New global.
9477 (fill_symbuf): Update.
9478 (coffstab_build_psymtabs): Change type of stabsects parameter.
9479 Update.
9480 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9481 std::vector.
9482 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9483 (coff_locate_sections): Update.
9484 (coff_symfile_read): Remove cleanups. Update.
9485 (init_stringtab): Add storage parameter.
9486 (free_stringtab, free_stringtab_cleanup): Remove.
9487 (init_lineno): Add storage parameter.
9488 (free_linetab, free_linetab_cleanup): Remove.
9489
b7e60d85
PA		 94902019-03-06 Pedro Alves <palves@redhat.com>
9491
9492 * linux-fork.c (fork_info::clobber_regs): Delete.
9493 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9494 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9495 comment. Adjust.
9496 (scoped_switch_fork_info::scoped_switch_fork_info)
9497 (checkpoint_command, linux_fork_context): Adjust
9498 fork_save_infrun_state calls.
9499
e52c971f
PA		 95002019-03-06 Pedro Alves <palves@redhat.com>
9501
9502 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9503 (inf_has_multiple_threads): Return 'bool' and rewrite using
9504 inferior_info::threads().
9505
06974e6c
PA		 95062019-03-06 Pedro Alves <palves@redhat.com>
9507
9508 * linux-fork.c: Include <list>.
9509 (fork_list): Now a std::list instance.
9510 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9511 (forks_exist_p, find_last_fork): Adjust.
9512 (new_fork): Delete.
9513 (one_fork_p): New.
9514 (add_fork): Adjust.
9515 (free_fork): Delete, folded into fork_info::~fork_info().
9516 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9517 Adjust.
9518 (init_fork_list): Delete.
9519 (linux_fork_killall, linux_fork_mourn_inferior)
9520 (linux_fork_detach, info_checkpoints_command): Adjust.
9521 (_initialize_linux_fork): No longer call init_fork_list.
9522
72f31aea
PA		 95232019-03-06 Pedro Alves <palves@redhat.com>
9524
9525 * linux-fork.c (new_fork): New, split out of ...
9526 (add_fork): ... this. Return void. Move "first fork" special
9527 case from here, to ...
9528 (checkpoint_command): ... here.
9529 * linux-linux.h (add_fork): Return void.
9530
efbecbc1
AB		 95312019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9532
9533 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9534
0841c79a
AB		 95352019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9536 Chris January <chris.january@arm.com>
9537 David Lecomber <david.lecomber@arm.com>
9538
9539 * f-exp.y: New token, UNOP_INTRINSIC.
9540 (exp): New pattern using UNOP_INTRINSIC token.
9541 (f77_keywords): Add 'abs' keyword.
9542 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9543 (value_from_host_double): New function.
9544 (evaluate_subexp_f): Support UNOP_ABS.
9545
4a270568
AB		 95462019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9547
9548 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9549 types.
9550
067630bd
AB		 95512019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9552
9553 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9554 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9555 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9556
3be47f7a
AB		 95572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9558
9559 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9560
4d00f5d8
AB		 95612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9562 Chris January <chris.january@arm.com>
9563
9564 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9565 * f-exp.y: Define 'KIND' token.
9566 (exp): New pattern for KIND expressions.
9567 (ptype): Handle types with a kind extension.
9568 (direct_abs_decl): Extend to spot kind extensions.
9569 (f77_keywords): Add 'kind' to the list.
9570 (push_kind_type): New function.
9571 (convert_to_kind_type): New function.
9572 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9573 * parse.c (operator_length_standard): Likewise.
9574 * parser-defs.h (enum type_pieces): Add tp_kind.
9575 * std-operator.def: Add UNOP_KIND.
9576
e454224f
AB		 95772019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9578
9579 * f-exp.y (f_parse): Set yydebug.
9580
9dad4a58
AB		 95812019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9582
9583 * f-lang.c (evaluate_subexp_f): New function.
9584 (exp_descriptor_f): New global.
9585 (f_language_defn): Use exp_descriptor_f instead of
9586 exp_descriptor_standard.
9587
c8f91604
AB		 95882019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9589
9590 * f-exp.y (struct token): Add comments.
9591 (dot_ops): Remove uppercase versions and the end marker.
9592 (f77_keywords): Likewise.
9593 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9594 entries in the dot_ops array are case insensitive, and use
9595 strncasecmp to compare strings. Also some whitespace cleanup in
9596 this area. Similar for the f77_keywords array, except entries in
9597 this list might be case sensitive.
9598
dd9f2c76
AB		 95992019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9600
9601 * f-exp.y (struct f77_boolean_val): Add comments.
9602 (boolean_values): Remove uppercase versions, and end marker.
9603 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9604 and use strncasecmp to achieve case insensitivity. Additionally,
9605 perform whitespace cleanup around this code.
9606
67a3048c
TT		 96072019-03-06 Tom Tromey <tromey@adacore.com>
9608
9609 * remote-sim.c (gdbsim_target_open): Use result of
9610 gdb_argv::release.
9611
aa3cfbda
RB		 96122019-03-06 Richard Bunt <richard.bunt@arm.com>
9613 Dirk Schubert <dirk.schubert@arm.com>
9614 Chris January <chris.january@arm.com>
9615
9616 * eval.c (evaluate_subexp_standard): Call Fortran argument
9617 wrapping logic.
9618 * f-lang.c (struct value): A value which can be passed into a
9619 Fortran function call.
9620 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9621 where appropriate.
9622 (struct type): Value ready for a Fortran function call.
9623 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9624 is needed.
9625 * f-lang.h (fortran_argument_convert): Declaration.
9626 (fortran_preserve_arg_pointer): Declaration.
9627 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9628
ea38e5df
TT		 96292019-03-05 Tom Tromey <tromey@adacore.com>
9630
9631 * python/py-prettyprint.c (print_string_repr): Remove #if.
9632 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9633
06b5b831
TT		 96342019-03-05 Tom Tromey <tromey@adacore.com>
9635
9636 * target.c (the_dummy_target): Move later. Change type to
9637 "dummy_target".
9638 (initialize_targets): Don't initialize the_dummy_target.
9639
edbd9e45
TT		 96402019-03-05 Tom Tromey <tromey@adacore.com>
9641
9642 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9643 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9644
c119e040
TT		 96452019-03-05 Tom Tromey <tromey@adacore.com>
9646
9647 * windows-nat.c (windows_nat_target::attach)
9648 (windows_nat_target::detach): Don't call gdb_flush.
9649 * valprint.c (generic_val_print, val_print, val_print_string):
9650 Don't call gdb_flush.
9651 * utils.c (defaulted_query): Don't call gdb_flush.
9652 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9653 * target.c (target_announce_detach): Don't call gdb_flush.
9654 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9655 * remote.c (extended_remote_target::attach): Don't call
9656 gdb_flush.
9657 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9658 * printcmd.c (do_examine): Don't call gdb_flush.
9659 (info_display_command): Don't call gdb_flush.
9660 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9661 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9662 * memattr.c (info_mem_command): Don't call gdb_flush.
9663 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9664 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9665 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9666 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9667 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9668 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9669 (gnu_nat_target::detach): Don't call gdb_flush.
9670 * f-valprint.c (f_val_print): Don't call gdb_flush.
9671 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9672 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9673 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9674 gdb_flush.
9675 * c-valprint.c (c_val_print): Don't call gdb_flush.
9676 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9677
895dafa6
TT		 96782019-03-05 Tom Tromey <tromey@adacore.com>
9679
9680 * varobj.c (update_dynamic_varobj_children): Update.
9681 (install_default_visualizer): Use reset, not release.
9682 * value.c (set_internalvar): Update.
9683 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9684 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9685 ATTRIBUTE_UNUSED_RESULT.
9686
88a774b9
TT		 96872019-03-05 Tom Tromey <tromey@adacore.com>
9688
9689 * remote.c (class scoped_remote_fd) <release>: Add
9690 ATTRIBUTE_UNUSED_RESULT.
9691
4e4a8b93
TT		 96922019-03-05 Tom Tromey <tromey@adacore.com>
9693
9694 * macroexp.c (struct macro_buffer) <release>: Add
9695 ATTRIBUTE_UNUSED_RESULT.
9696
083eef1f
TT		 96972019-03-05 Tom Tromey <tromey@adacore.com>
9698
9699 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9700 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9701 ATTRIBUTE_UNUSED_RESULT.
9702
3cabd438
TT		 97032019-03-05 Tom Tromey <tromey@adacore.com>
9704
9705 * common/scoped_fd.h (class scoped_fd) <release>: Add
9706 ATTRIBUTE_UNUSED_RESULT.
9707
41e3300a
TT		 97082019-03-05 Tom Tromey <tromey@adacore.com>
9709
9710 * parser-defs.h (struct parser_state) <release>: Add
9711 ATTRIBUTE_UNUSED_RESULT.
9712
18cb7c9f
TT		 97132019-03-05 Tom Tromey <tromey@adacore.com>
9714
9715 * utils.h (class gdb_argv) <release>: Add
9716 ATTRIBUTE_UNUSED_RESULT.
9717 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9718
41fa577f
EZ		 97192019-03-02 Eli Zaretskii <eliz@gnu.org>
9720
a6a4b2c6
EZ		 9721 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9722 for-loop range, to avoid compiler warnings.
9723
9724 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9725 avoid compiler warnings about unused variables.
9726
742a7df5
EZ		 9727 * NEWS: Mention end of support for native debugging on MS-Windows
9728 before XP.
9729
41fa577f
EZ		 9730 PR gdb/24292
9731 * common/netstuff.c:
9732 * gdbserver/gdbreplay.c
9733 * gdbserver/remote-utils.c:
9734 * ser-tcp.c:
9735 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9736 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9737 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9738 'getaddrinfo' and 'freeaddrinfo' were not available before
9739 Windows XP, and mingw.org's MinGW headers by default define
9740 _WIN32_WINNT to 0x500.
9741
827f438f
GB		 97422019-03-01 Gary Benson <gbenson@redhat.com>
9743
9744 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9745
92137da0
RO		 97462019-02-28 Brian Vandenberg <phantall@gmail.com>
9747 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9748
9749 PR gdb/8527
9750 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9751 set_sigint_trap, clear_sigint_trap.
9752
799efbe8
PW		 97532019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9754
9755 * target.c (target_detach): Clear the regcache and the
9756 frame cache.
9757
8ed25214
PA		 97582019-02-27 Pedro Alves <palves@redhat.com>
9759
9760 * utils.c (set_screen_size): When we cap the height/width sizes,
9761 tweak the corresponding command variable to show "unlimited":
9762
23031e31
SJ		 97632019-02-27 Saagar Jha <saagar@saagarjha.com>
9764 Pedro Alves <palves@redhat.com>
9765
9766 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9767 before calling rl_set_screen_size.
9768
6c28e44a
TT		 97692019-02-27 Tom Tromey <tromey@adacore.com>
9770
9771 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9772 define.
9773 * python/py-value.c: Remove Python 2.4 workaround.
9774 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9775 workaround.
9776 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9777 Python 2.4 workaround.
9778 * python/python-internal.h: Remove Python 2.4 comment.
9779 (Py_ssize_t): Don't define.
9780 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9781 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9782 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9783 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9784 * python/python.c (do_start_initialization): Remove Python 2.4
9785 workaround.
9786 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9787 (print_children): Remove Python 2.4 workaround.
9788 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9789 workaround.
9790 (CHARBUFFERPROC_NAME): Remove.
9791 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9792 Python 2.4 workaround.
9793
2c3fc25d 97942019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9795
2c3fc25d
KB		 9796 * NEWS: Note minimum Python version.
9797
6ca62222
KB		 97982019-02-27 Kevin Buettner <kevinb@redhat.com>
9799
9800 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9801 code from these functions. Remove corresponding ifdefs. Use
9802 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9803 Remove gotos and target of gotos.
9804 (infpy_search_memory): Likewise.
9805
f4bc7d2c
AB		 98062019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9807
9808 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9809 (hppa_gdbarch_init): Don't register deleted functions with
9810 gdbarch.
9811
9734a586
AB		 98122019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9813
9814 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9815 (h8300_unwind_sp): Delete.
9816 (h8300_dummy_id): Delete.
9817 (h8300_gdbarch_init): Don't register deleted functions with
9818 gdbarch.
9819
68b867f3
AB		 98202019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9821
9822 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9823 (ft32_unwind_pc): Delete.
9824 (ft32_unwind_sp): Delete.
9825 (ft32_gdbarch_init): Don't register deleted functions with
9826 gdbarch.
9827
2fbe7ad0
AB		 98282019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9829
9830 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9831 (frv_unwind_pc): Delete.
9832 (frv_unwind_sp): Delete.
9833 (frv_gdbarch_init): Don't register deleted functions with
9834 gdbarch.
9835
76055cbe
AB		 98362019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9837
9838 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9839 (riscv_unwind_pc): Delete.
9840 (riscv_unwind_sp): Delete.
9841 (riscv_gdbarch_init): Don't register deleted functions with
9842 gdbarch.
9843
4133e5a1
AB		 98442019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9845
9846 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9847 (csky_unwind_pc): Delete.
9848 (csky_unwind_sp): Delete.
9849 (csky_gdbarch_init): Don't register deleted functions with
9850 gdbarch.
9851
8010f576
AB		 98522019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9853
9854 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9855 (cris_unwind_pc): Delete.
9856 (cris_unwind_sp): Delete.
9857 (cris_gdbarch_init): Don't register deleted functions with
9858 gdbarch.
9859
b56bf084
AB		 98602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9861
9862 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9863 (bfin_unwind_pc): Delete.
9864 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9865
a19a650f
AB		 98662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9867
9868 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9869 (arm_unwind_pc): Delete.
9870 (arm_unwind_sp): Delete.
9871 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9872
f8278c3c
AB		 98732019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9874
9875 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9876 (arc_unwind_pc): Delete.
9877 (arc_unwind_sp): Delete.
9878 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9879
480e46cf
AB		 98802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9881
9882 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9883 (alpha_unwind_pc): Delete.
9884 (alpha_gdbarch_init): Don't register deleted functions with
9885 gdbarch.
9886
7a995095
AB		 98872019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9888
9889 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9890 (aarch64_unwind_pc): Delete.
9891 (aarch64_unwind_sp): Delete.
9892 (aarch64_gdbarch_init): Don't register deleted functions with
9893 gdbarch.
9894
bf9a735e
AB		 98952019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9896
9897 * gdbtypes.c (type_align): Don't consider static members when
9898 computing structure alignment.
9899
5561fc30
AB		 99002019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9901
9902 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9903 return 0 for other types.
9904 * arch-utils.c (default_type_align): Always return 0.
9905 * gdbarch.h: Regenerate.
9906 * gdbarch.sh (type_align): Extend comment.
9907 * gdbtypes.c (type_align): Add additional comments, always call
9908 gdbarch_type_align before applying the default rules.
9909 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9910 generic code will then apply a suitable default.
9911 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9912 types, return 0 for other types.
9913
9335e75a
JB		 99142019-02-27 Joel Brobecker <brobecker@adacore.com>
9915
9916 * NEWS: Create a new section for the next release branch.
9917 Rename the section of the current branch, now that it has
9918 been cut.
9919
3d34d8de
JB		 99202019-02-27 Joel Brobecker <brobecker@adacore.com>
9921
9922 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9923 * version.in: Bump version to 8.3.50.DATE-git.
9924
143420fb
SM		 99252019-02-26 Simon Marchi <simon.marchi@efficios.com>
9926
9927 * aix-thread.c (ptid_cmp): Remove unused variable.
9928 (get_signaled_thread): Likewise.
9929 (store_regs_user_thread): Likewise.
9930 (store_regs_kernel_thread): Likewise.
9931 (fetch_regs_kernel_thread): Remove shadowed variable.
9932
172fb711
AB		 99332019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9934
9935 * features/riscv/32bit-cpu.xml: Add register numbers.
9936 * features/riscv/32bit-fpu.c: Regenerate.
9937 * features/riscv/32bit-fpu.xml: Add register numbers.
9938 * features/riscv/64bit-cpu.xml: Add register numbers.
9939 * features/riscv/64bit-fpu.c: Regenerate.
9940 * features/riscv/64bit-fpu.xml: Add register numbers.
9941
26c89782
KB		 99422019-02-26 Kevin Buettner <kevinb@redhat.com>
9943
af54ade9 9944 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 9945 * python/py-value.c (convert_buffer_and_type_to_value): New
9946 function.
9947 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9948 Add support for handling an optional second argument. Call
9949 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 9950 * python/python-internal.h (Py_buffer_deleter): New struct.
9951 (Py_buffer_up): New typedef.
9952
0f58c9e8
JB		 99532019-02-25 John Baldwin <jhb@FreeBSD.org>
9954
9955 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9956 instead of releasing ownership.
9957
0a0f4c01
JR		 99582019-02-25 Jordan Rupprecht <rupprecht@google.com>
9959
9960 * dwarf2read.c (open_and_init_dwp_file): Call
9961 elf_numsections instead of bfd_count_sections to initialize
9962 dwp_file->num_sections.
9963
cd5a152c
TT		 99642019-02-25 Tom Tromey <tromey@adacore.com>
9965
9966 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9967
8a6a8513
SDJ		 99682019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9969
9970 * gcore.in: Add '--readnever' option when invoking GDB.
9971
04dcda9c
SM		 99722019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9973
9974 * MAINTAINERS: Update my email address.
9975
07bc701d
SM		 99762019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9977
9978 * build-id.c (build_id_to_debug_bfd_1): New function.
9979 (build_id_to_debug_bfd): Look for separate debug file in
9980 sysroot.
9981
c6f4a5d0
AB		 99822019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9983
9984 * gdbarch.sh: Update the copyright year range that is placed into
9985 generated files.
9986
9600246d
KS		 99872019-02-22 Keith Seitz <keiths@redhat.com>
9988
9989 PR symtab/23853
9990 * linespec.c (create_sals_line_offset): Search for the default
9991 symtab's filename instead of its fullname.
9992
7557a514
AH		 99932019-02-21 Alan Hayward <alan.hayward@arm.com>
9994
9995 * NEWS: Update style defaults.
9996
ee2bcb0c
AH		 99972019-02-21 Alan Hayward <alan.hayward@arm.com>
9998
9999 * main.c (captured_main_1): Disable styling in batch mode.
10000
0c95f9ed
TT		 100012019-02-20 Tom Tromey <tom@tromey.com>
10002
10003 * symtab.c (symtab_symbol_info): Fix typos.
10004
c763b894
TT		 100052019-02-20 Tom Tromey <tromey@adacore.com>
10006
10007 * findcmd.c (_initialize_mem_search): Use upper case for
10008 metasyntactic variables.
10009
0ef8a082
AH		 100102019-02-20 Alan Hayward <alan.hayward@arm.com>
10011
10012 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10013 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10014
6caa91b6
SM		 100152019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10016
10017 * top.h (source_file_name): Change to std::string.
10018 * top.c (source_file_name): Likewise.
10019 (command_line_input): Adjust.
10020 * cli/cli-script.c (script_from_file): Adjust.
10021
98814c6c
TT		 100222019-02-19 Tom Tromey <tromey@adacore.com>
10023
10024 * ravenscar-thread.c
10025 (ravenscar_thread_target::update_thread_list): Don't call
10026 ada_build_task_list.
10027 * ada-lang.h (ada_build_task_list): Don't declare.
10028 * ada-tasks.c (struct ada_tasks_inferior_data)
10029 <task_list_valid_p>: Now bool.
10030 (read_known_tasks, ada_task_list_changed)
10031 (ada_tasks_invalidate_inferior_data): Update.
10032 (read_known_tasks_array): Return bool.
10033 (read_known_tasks_list): Likewise.
10034 (read_known_tasks): Return void.
10035 (ada_build_task_list): Now static.
10036
70cd633e
AB		 100372019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10038
10039 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10040 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10041
040b3e95
PW		 100422019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10043
10044 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10045 variant for ada_tasks_pspace_data_handle and
10046 ada_tasks_inferior_data_handle.
10047 (ada_tasks_pspace_data_cleanup): New function.
10048 (ada_tasks_inferior_data_cleanup): New function.
10049
9409233b
TT		 100502019-02-17 Tom Tromey <tom@tromey.com>
10051
10052 * macrotab.h (macro_source_fullname): Return a std::string.
10053 * macrotab.c (macro_include, check_for_redefinition)
10054 (macro_undef, macro_lookup_definition, foreach_macro)
10055 (foreach_macro_in_scope): Update.
10056 (macro_source_fullname): Return a std::string.
10057 * macrocmd.c (show_pp_source_pos): Update.
10058
6506371f
TT		 100592019-02-17 Tom Tromey <tom@tromey.com>
10060
10061 * macrocmd.c (show_pp_source_pos): Style the file names.
10062
0c820d67
TT		 100632019-02-17 Tom Tromey <tom@tromey.com>
10064
10065 PR tui/24197:
10066 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10067
a0087920
TT		 100682019-02-17 Tom Tromey <tom@tromey.com>
10069
10070 * ada-lang.c (user_select_syms): Use filtered printing.
10071 * utils.c (wrap_style): New global.
10072 (desired_style): Remove.
10073 (emit_style_escape): Add stream parameter.
10074 (set_output_style, reset_terminal_style, prompt_for_continue):
10075 Update.
10076 (flush_wrap_buffer): Only flush gdb_stdout.
10077 (wrap_here): Set wrap_style.
10078 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10079 treat escape sequences as a character. Change when wrap buffer is
10080 flushed.
10081 (fputs_styled): Do not set the output style when the default is
10082 requested.
10083 * ui-style.h (struct ui_file_style) <is_default>: New method.
10084 * source.c (print_source_lines_base): Emit escape sequences in one
10085 piece.
10086
75ba10dc
JB		 100872019-02-17 Joel Brobecker <brobecker@adacore.com>
10088
10089 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10090 integers and enumeration types.
10091
a2cd4f14
JB		 100922019-02-17 Joel Brobecker <brobecker@adacore.com>
10093
10094 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10095 instead of lookup_symbol_in_language
10096 (do_exact_match): New function.
10097 (ada_get_symbol_name_matcher): Return do_exact_match when
10098 doing a verbatim match.
10099
485b851b
TT		 101002019-02-15 Tom Tromey <tromey@adacore.com>
10101
10102 * ravenscar-thread.c (ravenscar_thread_target::resume)
10103 (ravenscar_thread_target::wait): Special case wildcard requests.
10104
0b790b1e
TT		 101052019-02-15 Tom Tromey <tromey@adacore.com>
10106
10107 * ravenscar-thread.c (base_ptid): Remove.
10108 (struct ravenscar_thread_target) <close>: New method.
10109 <m_base_ptid>: New member.
10110 <update_inferior_ptid, active_task, task_is_currently_active,
10111 runtime_initialized>: Declare methods.
10112 <ravenscar_thread_target>: Add constructor.
10113 (ravenscar_thread_target::task_is_currently_active)
10114 (ravenscar_thread_target::update_inferior_ptid)
10115 (ravenscar_runtime_initialized): Rename. Now methods.
10116 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10117 (ravenscar_thread_target::update_thread_list): Update.
10118 (ravenscar_thread_target::active_task): Now method.
10119 (ravenscar_thread_target::store_registers)
10120 (ravenscar_thread_target::prepare_to_store)
10121 (ravenscar_thread_target::prepare_to_store)
10122 (ravenscar_thread_target::mourn_inferior): Update.
10123 (ravenscar_inferior_created): Use "new" to create target.
10124 (ravenscar_thread_target::get_ada_task_ptid): Update.
10125 (_initialize_ravenscar): Don't initialize base_ptid.
10126 (ravenscar_ops): Remove global.
10127
dea57a62
TT		 101282019-02-15 Tom Tromey <tromey@adacore.com>
10129
10130 * target.h (push_target): Declare new overload.
10131 * target.c (push_target): New overload, taking an rvalue reference.
10132 * remote.c (remote_target::open_1): Use push_target overload.
10133 * corelow.c (core_target_open): Use push_target overload.
10134
989f3c58
TT		 101352019-02-15 Tom Tromey <tromey@adacore.com>
10136
10137 * ravenscar-thread.c (is_ravenscar_task)
10138 (ravenscar_task_is_currently_active): Return bool.
10139 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10140 (_initialize_ravenscar): Remove "(void)".
10141 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10142 Return bool.
10143
6cbcc006
TT		 101442019-02-15 Tom Tromey <tromey@adacore.com>
10145
10146 * ravenscar-thread.c (ravenscar_runtime_initializer)
10147 (has_ravenscar_runtime, get_running_thread_id)
10148 (ravenscar_thread_target::resume): Fix indentation.
10149
7657f14d
TT		 101502019-02-15 Tom Tromey <tromey@adacore.com>
10151
10152 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10153 from ravenscar_arch_ops.
10154 (sparc_ravenscar_ops::fetch_registers)
10155 (sparc_ravenscar_ops::store_registers): Now methods.
10156 (sparc_ravenscar_prepare_to_store): Remove.
10157 (sparc_ravenscar_ops): Redefine.
10158 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10159 methods and destructor. Remove members.
10160 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10161 (ravenscar_thread_target::store_registers)
10162 (ravenscar_thread_target::prepare_to_store): Update.
10163 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10164 Remove.
10165 (struct ppc_ravenscar_powerpc_ops): Derive from
10166 ravenscar_arch_ops.
10167 (ppc_ravenscar_powerpc_ops::fetch_registers)
10168 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10169 (ppc_ravenscar_powerpc_ops): Redefine.
10170 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10171 (ppc_ravenscar_e500_ops::fetch_registers)
10172 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10173 (ppc_ravenscar_e500_ops): Redefine.
10174 * aarch64-ravenscar-thread.c
10175 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10176 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10177 (aarch64_ravenscar_fetch_registers)
10178 (aarch64_ravenscar_store_registers): Now methods.
10179 (aarch64_ravenscar_ops): Redefine.
10180
5b6ea500
TT		 101812019-02-15 Tom Tromey <tromey@adacore.com>
10182
10183 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10184 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10185 (ravenscar_thread_target::stopped_by_watchpoint)
10186 (ravenscar_thread_target::stopped_data_address)
10187 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10188
e397fd39
TT		 101892019-02-15 Tom Tromey <tromey@adacore.com>
10190
10191 * ravenscar-thread.c: Fix some typos.
10192
cc12f4a8
TT		 101932019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10194 Tom Tromey <tromey@adacore.com>
10195
10196 * ada-lang.c (ada_exception_sal): Change addr_string to a
10197 std::string.
10198 (create_ada_exception_catchpoint): Update.
10199
5f486660
TT		 102002019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10201 Tom Tromey <tromey@adacore.com>
10202
10203 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10204 (bp_location_ops): Remove.
10205 (base_breakpoint_allocate_location): Update.
10206 (free_bp_location): Update.
10207 * ada-lang.c (class ada_catchpoint_location)
10208 <ada_catchpoint_location>: Remove ops parameter.
10209 (ada_catchpoint_location_dtor): Remove.
10210 (ada_catchpoint_location_ops): Remove.
10211 (allocate_location_exception): Update.
10212 * breakpoint.h (struct bp_location_ops): Remove.
10213 (class bp_location) <bp_location>: Remove bp_location_ops
10214 parameter.
10215 <~bp_location>: Add destructor.
10216 <ops>: Remove.
10217
b671c7fb
TS		 102182019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10219 Pedro Alves <palves@redhat.com>
10220
10221 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10222 'PATH_MAX'.
10223
8071c5ce
DM		 102242019-02-14 David Michael <fedora.dm0@gmail.com>
10225 Samuel Thibault <samuel.thibault@gnu.org>
10226 Thomas Schwinge <thomas@codesourcery.com>
10227
10228 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10229 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10230
b1041ae0
TS		 102312019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10232
924514e1
TS		 10233 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10234 (check_empty): Use "const char *".
10235
c29ee8d4
TS		 10236 * gnu-nat.c (gnu_nat_target::detach): Instead of
10237 'detach_inferior (pid)' call
10238 'detach_inferior (find_inferior_pid (pid))'.
10239
6c6ef69f
TS		 10240 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10241 'nat/fork-inferior.o'.
10242 * gnu-nat.c: #include "nat/fork-inferior.h".
10243
2d0a338c
TS		 10244 * gnu-nat.c (gnu_nat_target::detach): Instead of
10245 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10246 * gnu-nat.h: #include "inf-child.h".
10247 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10248 'i386_gnu_nat_target::fetch_registers'.
10249 (gnu_store_registers): Rename/move to
10250 'i386_gnu_nat_target::store_registers'.
10251
cabb5f06
TS		 10252 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10253 * gnu-nat.h (mach_thread_info): New function.
10254 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10255
b1041ae0
TS		 10256 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10257
2988d01e
KF		 102582019-02-14 Frederic Konrad <konrad@adacore.com>
10259
10260 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10261
c559d709
JB		 102622019-02-14 Joel Brobecker <brobecker@adacore.com>
10263
10264 * windows-nat.c (windows_add_thread): Add new parameter
10265 "main_thread_p" with default value set to false. Update
10266 function documentation as well as all callers.
10267 (windows_delete_thread): Likewise.
10268 (fake_create_process): Update call to windows_add_thread.
10269 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10270 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10271 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10272 call to windows_delete_thread.
10273
007024cc
SM		 102742019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10275
10276 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10277
f62318e9
JB		 102782019-02-12 John Baldwin <jhb@FreeBSD.org>
10279
10280 * symfile.c (find_separate_debug_file): Use canonical path of
10281 sysroot with child_path instead of gdb_sysroot if it is valid.
10282
cd4b7848
JB		 102832019-02-12 John Baldwin <jhb@FreeBSD.org>
10284
10285 * symfile.c (find_separate_debug_file): Use child_path to
10286 determine if an object file is under a sysroot.
10287
efac4bfe
JB		 102882019-02-12 John Baldwin <jhb@FreeBSD.org>
10289
10290 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10291 unittests/child-path-selftests.c.
10292 * common/pathstuff.c (child_path): New function.
10293 * common/pathstuff.h (child_path): New prototype.
10294 * unittests/child-path-selftests.c: New file.
10295
402d2bfe
JB		 102962019-02-12 John Baldwin <jhb@FreeBSD.org>
10297
10298 * symfile.c (find_separate_debug_file): Look for separate debug
10299 files in debug directories under the sysroot.
10300
1ed9f74e
PW		 103012019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10302
10303 * symtab.h (struct minimal_symbol data_p): New const method.
10304 (struct minimal_symbol text_p): Likewise.
10305 * symtab.c (output_source_filename): Use file name style
10306 to print file name.
10307 (print_symbol_info): Likewise.
10308 (print_msymbol_info): Use address style to print addresses.
10309 Use function name style to print executable text symbols.
10310 (expand_symtab_containing_pc): Use data_p.
10311 (find_pc_sect_compunit_symtab): Likewise.
10312
2636d81d
PW		 103132019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10314
10315 * breakpoint.c (describe_other_breakpoints): Use address style
10316 to print addresses.
10317 (say_where): Likewise.
10318
ac8c53cc
PW		 103192019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10320
10321 * ada-typeprint.c (print_func_type): Print function name
10322 style to print function name.
10323 * c-typeprint.c (c_print_type_1): Likewise.
10324
ea638c43
AH		 103252019-02-11 Alan Hayward <alan.hayward@arm.com>
10326
10327 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10328 for execve.
10329
ab759ca8
PW		 103302019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10331
10332 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10333 type_stack.
10334
aff29d1c
JB		 103352019-02-10 Joel Brobecker <brobecker@adacore.com>
10336
10337 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10338 TYPE_CODE_REF types.
10339
617126bc
JW		 103402019-02-08 Jim Wilson <jimw@sifive.com>
10341
10342 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10343 (riscv_linux_fregset): New.
10344 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10345
46e3ed7f
TT		 103462019-02-07 Tom Tromey <tom@tromey.com>
10347
10348 * thread.c (thread_cancel_execution_command): Update.
10349 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10350 methods.
10351 (struct thread_fsm_ops): Remove.
10352 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10353 (thread_fsm_should_stop, thread_fsm_return_value)
10354 (thread_fsm_set_finished, thread_fsm_finished_p)
10355 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10356 Don't declare.
10357 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10358 * infrun.c (clear_proceed_status_thread)
10359 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10360 (print_stop_event): Update.
10361 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10362 Add constructor.
10363 (step_command_fsm_ops): Remove.
10364 (new_step_command_fsm): Remove.
10365 (step_1): Update.
10366 (step_command_fsm::should_stop): Rename from
10367 step_command_fsm_should_stop.
10368 (step_command_fsm::clean_up): Rename from
10369 step_command_fsm_clean_up.
10370 (step_command_fsm::do_async_reply_reason): Rename from
10371 step_command_fsm_async_reply_reason.
10372 (struct until_next_fsm): Inherit from thread_fsm. Add
10373 constructor.
10374 (until_next_fsm_ops): Remove.
10375 (new_until_next_fsm): Remove.
10376 (until_next_fsm::should_stop): Rename from
10377 until_next_fsm_should_stop.
10378 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10379 (until_next_fsm::do_async_reply_reason): Rename from
10380 until_next_fsm_async_reply_reason.
10381 (struct finish_command_fsm): Inherit from thread_fsm. Add
10382 constructor. Change type of breakpoint.
10383 (finish_command_fsm_ops): Remove.
10384 (new_finish_command_fsm): Remove.
10385 (finish_command_fsm::should_stop): Rename from
10386 finish_command_fsm_should_stop.
10387 (finish_command_fsm::clean_up): Rename from
10388 finish_command_fsm_clean_up.
10389 (finish_command_fsm::return_value): Rename from
10390 finish_command_fsm_return_value.
10391 (finish_command_fsm::do_async_reply_reason): Rename from
10392 finish_command_fsm_async_reply_reason.
10393 (finish_command): Update.
10394 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10395 Add constructor.
10396 (call_thread_fsm_ops): Remove.
10397 (call_thread_fsm::call_thread_fsm): Rename from
10398 new_call_thread_fsm.
10399 (call_thread_fsm::should_stop): Rename from
10400 call_thread_fsm_should_stop.
10401 (call_thread_fsm::should_notify_stop): Rename from
10402 call_thread_fsm_should_notify_stop.
10403 (run_inferior_call, call_function_by_hand_dummy): Update.
10404 * cli/cli-interp.c (should_print_stop_to_console): Update.
10405 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10406 Add constructor. Change type of location_breakpoint,
10407 caller_breakpoint.
10408 (until_break_fsm_ops): Remove.
10409 (new_until_break_fsm): Remove.
10410 (until_break_fsm::should_stop): Rename from
10411 until_break_fsm_should_stop.
10412 (until_break_fsm::clean_up): Rename from
10413 until_break_fsm_clean_up.
10414 (until_break_fsm::do_async_reply_reason): Rename from
10415 until_break_fsm_async_reply_reason.
10416 (until_break_command): Update.
10417 * thread-fsm.c: Remove.
10418 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10419
1a5c2598
TT		 104202019-02-07 Tom Tromey <tom@tromey.com>
10421
10422 * yy-remap.h: Add include guard.
10423 * xtensa-tdep.h: Add include guard.
10424 * xcoffread.h: Rename include guard.
10425 * varobj-iter.h: Add include guard.
10426 * tui/tui.h: Rename include guard.
10427 * tui/tui-winsource.h: Rename include guard.
10428 * tui/tui-wingeneral.h: Rename include guard.
10429 * tui/tui-windata.h: Rename include guard.
10430 * tui/tui-win.h: Rename include guard.
10431 * tui/tui-stack.h: Rename include guard.
10432 * tui/tui-source.h: Rename include guard.
10433 * tui/tui-regs.h: Rename include guard.
10434 * tui/tui-out.h: Rename include guard.
10435 * tui/tui-layout.h: Rename include guard.
10436 * tui/tui-io.h: Rename include guard.
10437 * tui/tui-hooks.h: Rename include guard.
10438 * tui/tui-file.h: Rename include guard.
10439 * tui/tui-disasm.h: Rename include guard.
10440 * tui/tui-data.h: Rename include guard.
10441 * tui/tui-command.h: Rename include guard.
10442 * tic6x-tdep.h: Add include guard.
10443 * target/waitstatus.h: Rename include guard.
10444 * target/wait.h: Rename include guard.
10445 * target/target.h: Rename include guard.
10446 * target/resume.h: Rename include guard.
10447 * target-float.h: Rename include guard.
10448 * stabsread.h: Add include guard.
10449 * rs6000-tdep.h: Add include guard.
10450 * riscv-fbsd-tdep.h: Add include guard.
10451 * regformats/regdef.h: Rename include guard.
10452 * record.h: Rename include guard.
10453 * python/python.h: Rename include guard.
10454 * python/python-internal.h: Rename include guard.
10455 * python/py-stopevent.h: Rename include guard.
10456 * python/py-ref.h: Rename include guard.
10457 * python/py-record.h: Rename include guard.
10458 * python/py-record-full.h: Rename include guard.
10459 * python/py-record-btrace.h: Rename include guard.
10460 * python/py-instruction.h: Rename include guard.
10461 * python/py-events.h: Rename include guard.
10462 * python/py-event.h: Rename include guard.
10463 * procfs.h: Add include guard.
10464 * proc-utils.h: Add include guard.
10465 * p-lang.h: Add include guard.
10466 * or1k-tdep.h: Rename include guard.
10467 * observable.h: Rename include guard.
10468 * nto-tdep.h: Rename include guard.
10469 * nat/x86-linux.h: Rename include guard.
10470 * nat/x86-linux-dregs.h: Rename include guard.
10471 * nat/x86-gcc-cpuid.h: Add include guard.
10472 * nat/x86-dregs.h: Rename include guard.
10473 * nat/x86-cpuid.h: Rename include guard.
10474 * nat/ppc-linux.h: Rename include guard.
10475 * nat/mips-linux-watch.h: Rename include guard.
10476 * nat/linux-waitpid.h: Rename include guard.
10477 * nat/linux-ptrace.h: Rename include guard.
10478 * nat/linux-procfs.h: Rename include guard.
10479 * nat/linux-osdata.h: Rename include guard.
10480 * nat/linux-nat.h: Rename include guard.
10481 * nat/linux-namespaces.h: Rename include guard.
10482 * nat/linux-btrace.h: Rename include guard.
10483 * nat/glibc_thread_db.h: Rename include guard.
10484 * nat/gdb_thread_db.h: Rename include guard.
10485 * nat/gdb_ptrace.h: Rename include guard.
10486 * nat/fork-inferior.h: Rename include guard.
10487 * nat/amd64-linux-siginfo.h: Rename include guard.
10488 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10489 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10490 * nat/aarch64-linux.h: Rename include guard.
10491 * nat/aarch64-linux-hw-point.h: Rename include guard.
10492 * mn10300-tdep.h: Add include guard.
10493 * mips-linux-tdep.h: Add include guard.
10494 * mi/mi-parse.h: Rename include guard.
10495 * mi/mi-out.h: Rename include guard.
10496 * mi/mi-main.h: Rename include guard.
10497 * mi/mi-interp.h: Rename include guard.
10498 * mi/mi-getopt.h: Rename include guard.
10499 * mi/mi-console.h: Rename include guard.
10500 * mi/mi-common.h: Rename include guard.
10501 * mi/mi-cmds.h: Rename include guard.
10502 * mi/mi-cmd-break.h: Rename include guard.
10503 * m2-lang.h: Add include guard.
10504 * location.h: Rename include guard.
10505 * linux-record.h: Rename include guard.
10506 * linux-nat.h: Add include guard.
10507 * linux-fork.h: Add include guard.
10508 * i386-darwin-tdep.h: Rename include guard.
10509 * hppa-linux-offsets.h: Add include guard.
10510 * guile/guile.h: Rename include guard.
10511 * guile/guile-internal.h: Rename include guard.
10512 * gnu-nat.h: Rename include guard.
10513 * gdb-stabs.h: Rename include guard.
10514 * frv-tdep.h: Add include guard.
10515 * f-lang.h: Add include guard.
10516 * event-loop.h: Add include guard.
10517 * darwin-nat.h: Rename include guard.
10518 * cp-abi.h: Rename include guard.
10519 * config/sparc/nm-sol2.h: Rename include guard.
10520 * config/nm-nto.h: Rename include guard.
10521 * config/nm-linux.h: Add include guard.
10522 * config/i386/nm-i386gnu.h: Rename include guard.
10523 * config/djgpp/nl_types.h: Rename include guard.
10524 * config/djgpp/langinfo.h: Rename include guard.
10525 * compile/gcc-cp-plugin.h: Add include guard.
10526 * compile/gcc-c-plugin.h: Add include guard.
10527 * compile/compile.h: Rename include guard.
10528 * compile/compile-object-run.h: Rename include guard.
10529 * compile/compile-object-load.h: Rename include guard.
10530 * compile/compile-internal.h: Rename include guard.
10531 * compile/compile-cplus.h: Rename include guard.
10532 * compile/compile-c.h: Rename include guard.
10533 * common/xml-utils.h: Rename include guard.
10534 * common/x86-xstate.h: Rename include guard.
10535 * common/version.h: Rename include guard.
10536 * common/vec.h: Rename include guard.
10537 * common/tdesc.h: Rename include guard.
10538 * common/selftest.h: Rename include guard.
10539 * common/scoped_restore.h: Rename include guard.
10540 * common/scoped_mmap.h: Rename include guard.
10541 * common/scoped_fd.h: Rename include guard.
10542 * common/safe-iterator.h: Rename include guard.
10543 * common/run-time-clock.h: Rename include guard.
10544 * common/refcounted-object.h: Rename include guard.
10545 * common/queue.h: Rename include guard.
10546 * common/ptid.h: Rename include guard.
10547 * common/print-utils.h: Rename include guard.
10548 * common/preprocessor.h: Rename include guard.
10549 * common/pathstuff.h: Rename include guard.
10550 * common/observable.h: Rename include guard.
10551 * common/netstuff.h: Rename include guard.
10552 * common/job-control.h: Rename include guard.
10553 * common/host-defs.h: Rename include guard.
10554 * common/gdb_wait.h: Rename include guard.
10555 * common/gdb_vecs.h: Rename include guard.
10556 * common/gdb_unlinker.h: Rename include guard.
10557 * common/gdb_unique_ptr.h: Rename include guard.
10558 * common/gdb_tilde_expand.h: Rename include guard.
10559 * common/gdb_sys_time.h: Rename include guard.
10560 * common/gdb_string_view.h: Rename include guard.
10561 * common/gdb_splay_tree.h: Rename include guard.
10562 * common/gdb_setjmp.h: Rename include guard.
10563 * common/gdb_ref_ptr.h: Rename include guard.
10564 * common/gdb_optional.h: Rename include guard.
10565 * common/gdb_locale.h: Rename include guard.
10566 * common/gdb_assert.h: Rename include guard.
10567 * common/filtered-iterator.h: Rename include guard.
10568 * common/filestuff.h: Rename include guard.
10569 * common/fileio.h: Rename include guard.
10570 * common/environ.h: Rename include guard.
10571 * common/common-utils.h: Rename include guard.
10572 * common/common-types.h: Rename include guard.
10573 * common/common-regcache.h: Rename include guard.
10574 * common/common-inferior.h: Rename include guard.
10575 * common/common-gdbthread.h: Rename include guard.
10576 * common/common-exceptions.h: Rename include guard.
10577 * common/common-defs.h: Rename include guard.
10578 * common/common-debug.h: Rename include guard.
10579 * common/cleanups.h: Rename include guard.
10580 * common/buffer.h: Rename include guard.
10581 * common/btrace-common.h: Rename include guard.
10582 * common/break-common.h: Rename include guard.
10583 * cli/cli-utils.h: Rename include guard.
10584 * cli/cli-style.h: Rename include guard.
10585 * cli/cli-setshow.h: Rename include guard.
10586 * cli/cli-script.h: Rename include guard.
10587 * cli/cli-interp.h: Rename include guard.
10588 * cli/cli-decode.h: Rename include guard.
10589 * cli/cli-cmds.h: Rename include guard.
10590 * charset-list.h: Add include guard.
10591 * buildsym-legacy.h: Rename include guard.
10592 * bfin-tdep.h: Add include guard.
10593 * ax.h: Rename include guard.
10594 * arm-linux-tdep.h: Add include guard.
10595 * arm-fbsd-tdep.h: Add include guard.
10596 * arch/xtensa.h: Rename include guard.
10597 * arch/tic6x.h: Add include guard.
10598 * arch/i386.h: Add include guard.
10599 * arch/arm.h: Rename include guard.
10600 * arch/arm-linux.h: Rename include guard.
10601 * arch/arm-get-next-pcs.h: Rename include guard.
10602 * arch/amd64.h: Add include guard.
10603 * arch/aarch64-insn.h: Rename include guard.
10604 * arch-utils.h: Rename include guard.
10605 * annotate.h: Add include guard.
10606 * amd64-darwin-tdep.h: Rename include guard.
10607 * aarch64-linux-tdep.h: Add include guard.
10608 * aarch64-fbsd-tdep.h: Add include guard.
10609 * aarch32-linux-nat.h: Add include guard.
10610
ab9268d2
PW		 106112019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10612
10613 * macrotab.c (macro_define_internal): New function that
10614 factorizes macro_define_object_internal and macro_define_function
10615 code.
10616 (macro_define_object_internal): Use macro_define_internal.
10617 (macro_define_function): Likewise.
10618
bb0da2b4
PW		 106192019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10620
10621 * macrocmd.c (extract_identifier): Return
10622 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10623 callers.
10624
424eb552
JB		 106252019-02-06 John Baldwin <jhb@FreeBSD.org>
10626
10627 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10628
1688cb29
TT		 106292019-02-05 Tom Tromey <tom@tromey.com>
10630
10631 * target.c (target_stack::unpush): Move assertion earlier.
10632
b5eba2d8
TT		 106332019-01-30 Tom Tromey <tom@tromey.com>
10634
10635 PR python/23615:
10636 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10637 (gdbpy_parse_and_eval): Likewise.
10638 * python/python-internal.h (gdbpy_allow_threads): New class.
10639
7054e2ff
JB		 106402019-01-28 John Baldwin <jhb@FreeBSD.org>
10641
10642 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10643 (aarch64_fbsd_fpregmap): Move earlier.
10644 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10645 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10646 instead of individual calls to trad_frame_set_reg_addr.
10647 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10648 earlier.
10649 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10650 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10651 instead of individual calls to trad_frame_set_reg_addr.
10652
36c25ffa
AH		 106532019-01-28 Alan Hayward <alan.hayward@arm.com>
10654
10655 * CONTRIBUTE: Replace contribution list with wiki link.
10656
a0707f3c
TT		 106572019-01-25 Tom Tromey <tom@tromey.com>
10658
10659 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10660
0747795c
TT		 106612019-01-25 Tom Tromey <tom@tromey.com>
10662
10663 * xtensa-linux-nat.c: Fix common/ includes.
10664 * xml-support.h: Fix common/ includes.
10665 * xml-support.c: Fix common/ includes.
10666 * x86-linux-nat.c: Fix common/ includes.
10667 * windows-nat.c: Fix common/ includes.
10668 * varobj.h: Fix common/ includes.
10669 * varobj.c: Fix common/ includes.
10670 * value.c: Fix common/ includes.
10671 * valops.c: Fix common/ includes.
10672 * utils.c: Fix common/ includes.
10673 * unittests/xml-utils-selftests.c: Fix common/ includes.
10674 * unittests/utils-selftests.c: Fix common/ includes.
10675 * unittests/unpack-selftests.c: Fix common/ includes.
10676 * unittests/tracepoint-selftests.c: Fix common/ includes.
10677 * unittests/style-selftests.c: Fix common/ includes.
10678 * unittests/string_view-selftests.c: Fix common/ includes.
10679 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10680 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10681 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10682 * unittests/rsp-low-selftests.c: Fix common/ includes.
10683 * unittests/parse-connection-spec-selftests.c: Fix common/
10684 includes.
10685 * unittests/optional-selftests.c: Fix common/ includes.
10686 * unittests/offset-type-selftests.c: Fix common/ includes.
10687 * unittests/observable-selftests.c: Fix common/ includes.
10688 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10689 * unittests/memrange-selftests.c: Fix common/ includes.
10690 * unittests/memory-map-selftests.c: Fix common/ includes.
10691 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10692 * unittests/function-view-selftests.c: Fix common/ includes.
10693 * unittests/environ-selftests.c: Fix common/ includes.
10694 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10695 * unittests/common-utils-selftests.c: Fix common/ includes.
10696 * unittests/cli-utils-selftests.c: Fix common/ includes.
10697 * unittests/array-view-selftests.c: Fix common/ includes.
10698 * ui-file.c: Fix common/ includes.
10699 * tui/tui-io.c: Fix common/ includes.
10700 * tracepoint.h: Fix common/ includes.
10701 * tracepoint.c: Fix common/ includes.
10702 * tracefile-tfile.c: Fix common/ includes.
10703 * top.h: Fix common/ includes.
10704 * top.c: Fix common/ includes.
10705 * thread.c: Fix common/ includes.
10706 * target/waitstatus.h: Fix common/ includes.
10707 * target/waitstatus.c: Fix common/ includes.
10708 * target.h: Fix common/ includes.
10709 * target.c: Fix common/ includes.
10710 * target-memory.c: Fix common/ includes.
10711 * target-descriptions.c: Fix common/ includes.
10712 * symtab.h: Fix common/ includes.
10713 * symfile.c: Fix common/ includes.
10714 * stap-probe.c: Fix common/ includes.
10715 * spu-linux-nat.c: Fix common/ includes.
10716 * sparc-nat.c: Fix common/ includes.
10717 * source.c: Fix common/ includes.
10718 * solib.c: Fix common/ includes.
10719 * solib-target.c: Fix common/ includes.
10720 * ser-unix.c: Fix common/ includes.
10721 * ser-tcp.c: Fix common/ includes.
10722 * ser-pipe.c: Fix common/ includes.
10723 * ser-base.c: Fix common/ includes.
10724 * selftest-arch.c: Fix common/ includes.
10725 * s12z-tdep.c: Fix common/ includes.
10726 * rust-exp.y: Fix common/ includes.
10727 * rs6000-aix-tdep.c: Fix common/ includes.
10728 * riscv-tdep.c: Fix common/ includes.
10729 * remote.c: Fix common/ includes.
10730 * remote-notif.h: Fix common/ includes.
10731 * remote-fileio.h: Fix common/ includes.
10732 * remote-fileio.c: Fix common/ includes.
10733 * regcache.h: Fix common/ includes.
10734 * regcache.c: Fix common/ includes.
10735 * record-btrace.c: Fix common/ includes.
10736 * python/python.c: Fix common/ includes.
10737 * python/py-type.c: Fix common/ includes.
10738 * python/py-inferior.c: Fix common/ includes.
10739 * progspace.h: Fix common/ includes.
10740 * producer.c: Fix common/ includes.
10741 * procfs.c: Fix common/ includes.
10742 * proc-api.c: Fix common/ includes.
10743 * printcmd.c: Fix common/ includes.
10744 * ppc-linux-nat.c: Fix common/ includes.
10745 * parser-defs.h: Fix common/ includes.
10746 * osdata.c: Fix common/ includes.
10747 * obsd-nat.c: Fix common/ includes.
10748 * nat/x86-linux.c: Fix common/ includes.
10749 * nat/x86-linux-dregs.c: Fix common/ includes.
10750 * nat/x86-dregs.h: Fix common/ includes.
10751 * nat/x86-dregs.c: Fix common/ includes.
10752 * nat/ppc-linux.c: Fix common/ includes.
10753 * nat/mips-linux-watch.h: Fix common/ includes.
10754 * nat/mips-linux-watch.c: Fix common/ includes.
10755 * nat/linux-waitpid.c: Fix common/ includes.
10756 * nat/linux-ptrace.h: Fix common/ includes.
10757 * nat/linux-ptrace.c: Fix common/ includes.
10758 * nat/linux-procfs.c: Fix common/ includes.
10759 * nat/linux-personality.c: Fix common/ includes.
10760 * nat/linux-osdata.c: Fix common/ includes.
10761 * nat/linux-namespaces.c: Fix common/ includes.
10762 * nat/linux-btrace.h: Fix common/ includes.
10763 * nat/linux-btrace.c: Fix common/ includes.
10764 * nat/fork-inferior.c: Fix common/ includes.
10765 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10766 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10767 * nat/aarch64-linux.c: Fix common/ includes.
10768 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10769 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10770 * namespace.h: Fix common/ includes.
10771 * mips-linux-tdep.c: Fix common/ includes.
10772 * minsyms.c: Fix common/ includes.
10773 * mi/mi-parse.h: Fix common/ includes.
10774 * mi/mi-main.c: Fix common/ includes.
10775 * mi/mi-cmd-env.c: Fix common/ includes.
10776 * memrange.h: Fix common/ includes.
10777 * memattr.c: Fix common/ includes.
10778 * maint.h: Fix common/ includes.
10779 * maint.c: Fix common/ includes.
10780 * main.c: Fix common/ includes.
10781 * machoread.c: Fix common/ includes.
10782 * location.c: Fix common/ includes.
10783 * linux-thread-db.c: Fix common/ includes.
10784 * linux-nat.c: Fix common/ includes.
10785 * linux-fork.c: Fix common/ includes.
10786 * inline-frame.c: Fix common/ includes.
10787 * infrun.c: Fix common/ includes.
10788 * inflow.c: Fix common/ includes.
10789 * inferior.h: Fix common/ includes.
10790 * inferior.c: Fix common/ includes.
10791 * infcmd.c: Fix common/ includes.
10792 * inf-ptrace.c: Fix common/ includes.
10793 * inf-child.c: Fix common/ includes.
10794 * ia64-linux-nat.c: Fix common/ includes.
10795 * i387-tdep.c: Fix common/ includes.
10796 * i386-tdep.c: Fix common/ includes.
10797 * i386-linux-tdep.c: Fix common/ includes.
10798 * i386-linux-nat.c: Fix common/ includes.
10799 * i386-go32-tdep.c: Fix common/ includes.
10800 * i386-fbsd-tdep.c: Fix common/ includes.
10801 * i386-fbsd-nat.c: Fix common/ includes.
10802 * guile/scm-type.c: Fix common/ includes.
10803 * guile/guile.c: Fix common/ includes.
10804 * go32-nat.c: Fix common/ includes.
10805 * gnu-nat.c: Fix common/ includes.
10806 * gdbthread.h: Fix common/ includes.
10807 * gdbarch-selftests.c: Fix common/ includes.
10808 * gdb_usleep.c: Fix common/ includes.
10809 * gdb_select.h: Fix common/ includes.
10810 * gdb_bfd.c: Fix common/ includes.
10811 * gcore.c: Fix common/ includes.
10812 * fork-child.c: Fix common/ includes.
10813 * findvar.c: Fix common/ includes.
10814 * fbsd-nat.c: Fix common/ includes.
10815 * event-top.c: Fix common/ includes.
10816 * event-loop.c: Fix common/ includes.
10817 * dwarf2read.c: Fix common/ includes.
10818 * dwarf2loc.c: Fix common/ includes.
10819 * dwarf2-frame.c: Fix common/ includes.
10820 * dwarf-index-cache.c: Fix common/ includes.
10821 * dtrace-probe.c: Fix common/ includes.
10822 * disasm-selftests.c: Fix common/ includes.
10823 * defs.h: Fix common/ includes.
10824 * csky-tdep.c: Fix common/ includes.
10825 * cp-valprint.c: Fix common/ includes.
10826 * cp-support.h: Fix common/ includes.
10827 * cp-support.c: Fix common/ includes.
10828 * corelow.c: Fix common/ includes.
10829 * completer.h: Fix common/ includes.
10830 * completer.c: Fix common/ includes.
10831 * compile/compile.c: Fix common/ includes.
10832 * compile/compile-loc2c.c: Fix common/ includes.
10833 * compile/compile-cplus-types.c: Fix common/ includes.
10834 * compile/compile-cplus-symbols.c: Fix common/ includes.
10835 * command.h: Fix common/ includes.
10836 * cli/cli-dump.c: Fix common/ includes.
10837 * cli/cli-cmds.c: Fix common/ includes.
10838 * charset.c: Fix common/ includes.
10839 * build-id.c: Fix common/ includes.
10840 * btrace.h: Fix common/ includes.
10841 * btrace.c: Fix common/ includes.
10842 * breakpoint.h: Fix common/ includes.
10843 * breakpoint.c: Fix common/ includes.
10844 * ax.h:
10845 (enum agent_op): Fix common/ includes.
10846 * ax-general.c (struct aop_map): Fix common/ includes.
10847 * ax-gdb.c: Fix common/ includes.
10848 * auxv.c: Fix common/ includes.
10849 * auto-load.c: Fix common/ includes.
10850 * arm-tdep.c: Fix common/ includes.
10851 * arch/riscv.c: Fix common/ includes.
10852 * arch/ppc-linux-common.c: Fix common/ includes.
10853 * arch/i386.c: Fix common/ includes.
10854 * arch/arm.c: Fix common/ includes.
10855 * arch/arm-linux.c: Fix common/ includes.
10856 * arch/arm-get-next-pcs.c: Fix common/ includes.
10857 * arch/amd64.c: Fix common/ includes.
10858 * arch/aarch64.c: Fix common/ includes.
10859 * arch/aarch64-insn.c: Fix common/ includes.
10860 * arch-utils.c: Fix common/ includes.
10861 * amd64-windows-tdep.c: Fix common/ includes.
10862 * amd64-tdep.c: Fix common/ includes.
10863 * amd64-sol2-tdep.c: Fix common/ includes.
10864 * amd64-obsd-tdep.c: Fix common/ includes.
10865 * amd64-nbsd-tdep.c: Fix common/ includes.
10866 * amd64-linux-tdep.c: Fix common/ includes.
10867 * amd64-linux-nat.c: Fix common/ includes.
10868 * amd64-fbsd-tdep.c: Fix common/ includes.
10869 * amd64-fbsd-nat.c: Fix common/ includes.
10870 * amd64-dicos-tdep.c: Fix common/ includes.
10871 * amd64-darwin-tdep.c: Fix common/ includes.
10872 * agent.c: Fix common/ includes.
10873 * ada-lang.h: Fix common/ includes.
10874 * ada-lang.c: Fix common/ includes.
10875 * aarch64-tdep.c: Fix common/ includes.
10876
2f5c153e
TT		 108772019-01-25 Tom Tromey <tom@tromey.com>
10878
10879 * common/create-version.sh: Use common/version.h.
10880
adc6a863
PA		 108812019-01-24 Pedro Alves <palves@redhat.com>
10882
10883 * infrun.c (signal_stop, signal_print, signal_program)
10884 (signal_catch, signal_pass): Now arrays instead of pointers.
10885 (update_signals_program_target, do_target_resume)
10886 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10887 * linux-nat.c (linux_nat_target::pass_signals)
10888 (linux_nat_target::create_inferior, linux_nat_target::attach):
10889 Adjust.
10890 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10891 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10892 * procfs.c (procfs_target::pass_signals): Adjust.
10893 * record-full.c (record_full_target::resume): Adjust.
10894 * remote.c (remote_target::pass_signals)
10895 (remote_target::program_signals): Adjust.
10896 * target-debug.h (target_debug_print_signals): Now takes a
10897 gdb::array_view as parameter. Adjust.
10898 * target.h (target_ops) <pass_signals, program_signals>: Replace
10899 pointer and length parameters with gdb::array_view.
10900 (target_pass_signals, target_program_signals): Likewise.
10901 * target-delegates.c: Regenerate.
10902
3046d67a
PA		 109032019-01-24 Pedro Alves <palves@redhat.com>
10904
10905 * common/forward-scope-exit.h
10906 (forward_scope_exit::forward_scope_exit): Pass arguments to
10907 m_bind_function directly, instead of creating a std::bind and
10908 copying that.
10909
353229bf
AH		 109102019-01-24 Alan Hayward <alan.hayward@arm.com>
10911
10912 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10913 for static members.
10914 (pass_in_v_vfp_candidate): Likewise.
10915
311dc83a
TT		 109162019-01-23 Tom Tromey <tom@tromey.com>
10917 Pedro Alves <palves@redhat.com>
10918
10919 * regcache.c (class regcache_invalidator): Remove.
10920 (regcache::raw_write): Use make_scope_exit.
10921
296bd123
TT		 109222019-01-23 Tom Tromey <tom@tromey.com>
10923
10924 * ui-out.h (class ui_out_emit_type): Update comment.
10925
979a0d13
TT		 109262019-01-23 Tom Tromey <tom@tromey.com>
10927
10928 * infrun.c (fetch_inferior_event): Update comment.
10929
d238133d
TT		 109302019-01-23 Tom Tromey <tom@tromey.com>
10931 Pedro Alves <palves@redhat.com>
10932
10933 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10934 parameter.
10935 (fetch_inferior_event): Use SCOPE_EXIT.
10936
10937
9885e6bb
TT		 109382019-01-23 Tom Tromey <tom@tromey.com>
10939 Pedro Alves <palves@redhat.com>
10940
10941 * infrun.c (disable_thread_events): Delete.
10942 (stop_all_threads): Use SCOPE_EXIT.
10943
286526c1
TT		 109442019-01-23 Tom Tromey <tom@tromey.com>
10945 Pedro Alves <palves@redhat.com>
10946
10947 * symfile.c: Include forward-scope-exit.h.
10948 (clear_symtab_users_cleanup): Replace forward declaration with
10949 a FORWARD_SCOPE_EXIT.
10950 (syms_from_objfile_1): Use the forward_scope_exit and
10951 gdb::optional instead of cleanup_function.
10952 (reread_symbols): Use the forward_scope_exit instead of
10953 cleanup_function.
10954 (clear_symtab_users_cleanup): Remove function.
10955
1db93f14
TT		 109562019-01-23 Tom Tromey <tom@tromey.com>
10957 Pedro Alves <palves@redhat.com>
10958
10959 * linux-nat.c: Include scope-exit.h.
10960 (cleanup_target_stop): Remove.
10961 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10962 SCOPE_EXIT.
10963
2cc83d1e
TT		 109642019-01-23 Tom Tromey <tom@tromey.com>
10965 Pedro Alves <palves@redhat.com>
10966
10967 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10968 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10969
694c6bf5
TT		 109702019-01-23 Tom Tromey <tom@tromey.com>
10971 Andrew Burgess <andrew.burgess@embecosm.com>
10972 Pedro Alves <palves@redhat.com>
10973
10974 * infrun.c (fetch_inferior_event): Use scope_exit.
10975 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10976 * top.c (execute_command): Use scope_exit.
10977 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10978 * utils.c (do_bpstat_clear_actions_cleanup)
10979 (make_bpstat_clear_actions_cleanup): Remove.
10980
4c41382a
TT		 109812019-01-23 Tom Tromey <tom@tromey.com>
10982 Pedro Alves <palves@redhat.com>
10983
10984 * infrun.c: Include "common/scope-exit.h"
10985 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10986 (wait_for_inferior): Use SCOPE_EXIT.
10987 (fetch_inferior_event): Use scope_exit.
10988
89f8fb50
TT		 109892019-01-23 Tom Tromey <tom@tromey.com>
10990 Pedro Alves <palves@redhat.com>
10991
10992 * breakpoint.c (create_breakpoint): Remove cleanup.
10993
5419bdae
TT		 109942019-01-23 Tom Tromey <tom@tromey.com>
10995 Andrew Burgess <andrew.burgess@embecosm.com>
10996 Pedro Alves <palves@redhat.com>
10997
e587ef42
PA		 109982019-01-23 Pedro Alves <palves@redhat.com>
10999
11000 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11001
77f0e74c
PA		 110022019-01-23 Pedro Alves <palves@redhat.com>
11003 Andrew Burgess <andrew.burgess@embecosm.com>
11004
11005 * gdbthread.h: Include "common/forward-scope-exit.h".
11006 (scoped_finish_thread_state): Redefine custom class in terms of
11007 forward_scope_exit.
11008
5b9b3e53
PA		 110092019-01-23 Pedro Alves <palves@redhat.com>
11010 Andrew Burgess <andrew.burgess@embecosm.com>
11011
11012 * common/forward-scope-exit.h: New file.
11013
54b65c9b
PA		 110142019-01-23 Pedro Alves <palves@redhat.com>
11015 Andrew Burgess <andrew.burgess@embecosm.com>
11016 Tom Tromey <tom@tromey.com>
11017
11018 * common/scope-exit.h: New file.
11019
cf08fb29
PA		 110202019-01-23 Pedro Alves <palves@redhat.com>
11021
11022 * common/preprocessor.h (ESC): Rename to ...
11023 (ESC_PARENS): ... this.
11024 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11025 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11026
ae73e2e2
TT		 110272019-01-23 Tom Tromey <tom@tromey.com>
11028
11029 * language.h (class scoped_switch_to_sym_language_if_auto):
11030 Initialize m_lang in both cases.
11031
6594e122
AH		 110322019-01-23 Alan Hayward <alan.hayward@arm.com>
11033
11034 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11035 with XCNEW.
11036
a7c9855d
TT		 110372019-01-22 Tom Tromey <tom@tromey.com>
11038
11039 * corelow.c: Do not include sys/file.h.
11040
93cc1d53
TT		 110412019-01-22 Tom Tromey <tom@tromey.com>
11042
11043 * tui/tui-wingeneral.h: Include gdb_curses.h.
11044
38561778
TT		 110452019-01-22 Tom Tromey <tom@tromey.com>
11046
11047 * source-cache.h (class source_cache) <get_source_lines,
11048 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11049
37b3ab5b
TT		 110502019-01-22 Tom Tromey <tom@tromey.com>
11051
11052 * remote-fileio.h (struct remote_target): Declare.
11053
3fabc016
TT		 110542019-01-22 Tom Tromey <tom@tromey.com>
11055
11056 * python/py-arch.c: Do not include py-ref.h.
11057 * python/py-bpevent.c: Do not include py-ref.h.
11058 * python/py-cmd.c: Do not include py-ref.h.
11059 * python/py-continueevent.c: Do not include py-ref.h.
11060 * python/py-event.h: Do not include py-ref.h.
11061 * python/py-evtregistry.c: Do not include py-ref.h.
11062 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11063 * python/py-frame.c: Do not include py-ref.h.
11064 * python/py-framefilter.c: Do not include py-ref.h.
11065 * python/py-function.c: Do not include py-ref.h.
11066 * python/py-infevents.c: Do not include py-ref.h.
11067 * python/py-linetable.c: Do not include py-ref.h.
11068 * python/py-objfile.c: Do not include py-ref.h.
11069 * python/py-param.c: Do not include py-ref.h.
11070 * python/py-prettyprint.c: Do not include py-ref.h.
11071 * python/py-progspace.c: Do not include py-ref.h.
11072 * python/py-symbol.c: Do not include py-ref.h.
11073 * python/py-symtab.c: Do not include py-ref.h.
11074 * python/py-type.c: Do not include py-ref.h.
11075 * python/py-unwind.c: Do not include py-ref.h.
11076 * python/py-utils.c: Do not include py-ref.h.
11077 * python/py-value.c: Do not include py-ref.h.
11078 * python/py-varobj.c: Do not include py-ref.h.
11079 * python/py-xmethods.c: Do not include py-ref.h.
11080 * python/python.c: Do not include py-ref.h.
11081 * varobj.c: Do not include py-ref.h.
11082
6b4d7774
TT		 110832019-01-22 Tom Tromey <tom@tromey.com>
11084
11085 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11086 keyword for bcache.
11087
7af7e9b5
TT		 110882019-01-22 Tom Tromey <tom@tromey.com>
11089
11090 * compile/compile-cplus-types.c: Remove a comment by #include.
11091
951d1049
TT		 110922019-01-22 Tom Tromey <tom@tromey.com>
11093
11094 * compile/gcc-c-plugin.h: Include compile-internal.h.
11095
d65d5705
TT		 110962019-01-22 Tom Tromey <tom@tromey.com>
11097
11098 * stabsread.c (EXTERN): Do not define.
11099 (symnum, next_symbol_text_func, processing_gcc_compilation)
11100 (within_function, global_sym_chain, global_stabs)
11101 (previous_stab_code, this_object_header_files)
11102 (n_this_object_header_files)
11103 (n_allocated_this_object_header_files): Define.
11104 * stabsread.h (EXTERN): Never define. Use "extern".
11105
b6fb1ee5
PW		 111062019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11107
11108 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11109 history_value.
11110
be6d4f74
TT		 111112019-01-21 Tom Tromey <tom@tromey.com>
11112
11113 * ui-out.c: Fix includes.
11114 * tui/tui-source.c: Fix includes.
11115 * target.c: Fix includes.
11116 * remote.c: Fix includes.
11117 * regcache.c: Fix includes.
11118 * python/py-block.c: Fix includes.
11119 * printcmd.c: Fix includes.
11120 * or1k-tdep.c: Fix includes.
11121 * mi/mi-main.c: Fix includes.
11122 * m32r-tdep.c: Fix includes.
11123 * csky-tdep.c: Fix includes.
11124 * compile/compile-cplus-types.c: Fix includes.
11125 * cli/cli-interp.c: Fix includes.
11126
73021deb
AH		 111272019-01-21 Alan Hayward <alan.hayward@arm.com>
11128
11129 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11130 for padding.
11131
7932255d
TT		 111322019-01-16 Tom Tromey <tom@tromey.com>
11133
11134 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11135 earlier.
11136 (struct objfile) <msymbols_range>: Move from top level.
11137 <msymbols>: New method.
11138 (class objfile_msymbols): Remove.
11139 * symtab.c (default_collect_symbol_completion_matches_break_on):
11140 Update.
11141 * symmisc.c (dump_msymbols): Update.
11142 * stabsread.c (scan_file_globals): Update.
11143 * objc-lang.c (info_selectors_command, info_classes_command)
11144 (find_methods): Update.
11145 * minsyms.c (find_solib_trampoline_target): Update.
11146 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11147 * coffread.c (coff_symfile_read): Update.
11148 * ada-lang.c (ada_lookup_simple_minsym)
11149 (ada_collect_symbol_completion_matches): Update.
11150
604b1bfb
TT		 111512019-01-16 Tom Tromey <tom@tromey.com>
11152
11153 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11154 type. Remove no-argument constructor.
11155 <iterator::operator++>: Simplify.
11156 <begin>: Update.
11157 <end>: Use minimal_symbol_count.
11158
f252c6d5
TT		 111592019-01-16 Tom Tromey <tom@tromey.com>
11160
11161 * objfiles.h (struct objfile) <psymtabs>: New method.
11162 (class objfile_psymtabs): Remove.
11163 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11164 typedef.
11165 <range>: New method.
11166 (require_partial_symbols): Change return type.
11167 * psymtab.c (require_partial_symbols)
11168 (psym_expand_symtabs_matching): Update.
11169 * mdebugread.c (parse_partial_symbols): Update.
11170 * dbxread.c (dbx_end_psymtab): Update.
11171
b669c953
TT		 111722019-01-15 Tom Tromey <tom@tromey.com>
11173
11174 * symtab.c (lookup_objfile_from_block)
11175 (lookup_symbol_in_objfile_symtabs)
11176 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11177 (find_line_symtab, info_sources_command)
11178 (default_collect_symbol_completion_matches_break_on)
11179 (make_source_files_completion_list): Update.
11180 * symmisc.c (print_objfile_statistics, dump_objfile)
11181 (maintenance_print_symbols, maintenance_info_symtabs)
11182 (maintenance_check_symtabs, maintenance_info_line_tables):
11183 Update.
11184 * source.c (select_source_symtab)
11185 (forget_cached_source_info_for_objfile): Update.
11186 * objfiles.h (class objfile_compunits): Remove.
11187 (struct objfile) <compunits_range>: New typedef.
11188 (compunits): New method.
11189 * objfiles.c (objfile_relocate1): Update.
11190 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11191 * maint.c (count_symtabs_and_blocks): Update.
11192 * linespec.c (iterate_over_all_matching_symtabs): Update.
11193 * cp-support.c (add_symbol_overload_list_qualified): Update.
11194 * coffread.c (coff_symtab_read): Update.
11195 * ada-lang.c (add_nonlocal_symbols)
11196 (ada_collect_symbol_completion_matches)
11197 (ada_add_global_exceptions): Update.
11198
7e955d83
TT		 111992019-01-15 Tom Tromey <tom@tromey.com>
11200
11201 * progspace.h (program_space) <objfiles_safe_range>: New
11202 typedef.
11203 <objfiles_safe>: New method.
11204 * objfiles.h (class all_objfiles_safe): Remove.
11205 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11206 * jit.c (jit_inferior_exit_hook): Update.
11207
2030c079
TT		 112082019-01-17 Tom Tromey <tom@tromey.com>
11209
11210 * progspace.h (program_space) <objfiles_range>: New typedef.
11211 <objfiles>: New method.
11212 <objfiles_head>: Rename from objfiles.
11213 (object_files): Update.
11214 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11215 * guile/scm-pretty-print.c
11216 (ppscm_find_pretty_printer_from_objfiles): Update.
11217 * guile/scm-objfile.c (gdbscm_objfiles): Update.
11218 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11219 Update.
11220 * python/py-progspace.c (pspy_get_objfiles): Update.
11221 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11222 Update.
11223 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11224 (objfpy_lookup_objfile_by_build_id): Update.
11225 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11226 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11227 Update.
11228 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11229 (expand_symtab_containing_pc, lookup_objfile_from_block)
11230 (lookup_static_symbol, basic_lookup_transparent_type)
11231 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11232 (find_line_symtab, info_sources_command)
11233 (default_collect_symbol_completion_matches_break_on)
11234 (make_source_files_completion_list, find_main_name): Update.
11235 * symmisc.c (print_symbol_bcache_statistics)
11236 (print_objfile_statistics, maintenance_print_symbols)
11237 (maintenance_print_msymbols, maintenance_print_objfiles)
11238 (maintenance_info_symtabs, maintenance_check_symtabs)
11239 (maintenance_expand_symtabs, maintenance_info_line_tables):
11240 Update.
11241 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11242 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11243 (map_overlay_command, unmap_overlay_command)
11244 (simple_overlay_update, expand_symtabs_matching)
11245 (map_symbol_filenames): Update.
11246 * symfile-debug.c (set_debug_symfile): Update.
11247 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11248 Update.
11249 * source.c (select_source_symtab, forget_cached_source_info):
11250 Update.
11251 * solib.c (solib_read_symbols): Update.
11252 * solib-spu.c (append_ocl_sos): Update.
11253 * psymtab.c (maintenance_print_psymbols)
11254 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11255 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11256 * printcmd.c (info_symbol_command): Update.
11257 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11258 Update.
11259 * objfiles.h (class all_objfiles): Remove.
11260 * objfiles.c (have_partial_symbols, have_full_symbols)
11261 (have_minimal_symbols, qsort_cmp, update_section_map)
11262 (shared_objfile_contains_address_p)
11263 (default_iterate_over_objfiles_in_search_order): Update.
11264 * objc-lang.c (info_selectors_command, info_classes_command)
11265 (find_methods): Update.
11266 * minsyms.c (find_solib_trampoline_target): Update.
11267 * maint.c (maintenance_info_sections)
11268 (maintenance_translate_address, count_symtabs_and_blocks):
11269 Update.
11270 * main.c (captured_main_1): Update.
11271 * linux-thread-db.c (try_thread_db_load_from_pdir)
11272 (has_libpthread): Update.
11273 * linespec.c (iterate_over_all_matching_symtabs)
11274 (search_minsyms_for_name): Update.
11275 * jit.c (jit_find_objf_with_entry_addr): Update.
11276 * hppa-tdep.c (find_unwind_entry)
11277 (hppa_lookup_stub_minimal_symbol): Update.
11278 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11279 Update.
11280 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11281 (elf_gnu_ifunc_resolve_by_got): Update.
11282 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11283 * dwarf-index-write.c (save_gdb_index_command): Update.
11284 * cp-support.c (add_symbol_overload_list_qualified): Update.
11285 * breakpoint.c (create_overlay_event_breakpoint)
11286 (create_longjmp_master_breakpoint)
11287 (create_std_terminate_master_breakpoint)
11288 (create_exception_master_breakpoint): Update.
11289 * blockframe.c (find_pc_partial_function): Update.
11290 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11291 (ada_collect_symbol_completion_matches)
11292 (ada_add_global_exceptions): Update.
11293
776489e0
TT		 112942019-01-17 Tom Tromey <tom@tromey.com>
11295
11296 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11297 declare VEC.
11298 (solib_target_parse_libraries): Change return type.
11299 (library_list_start_segment, library_list_start_section)
11300 (library_list_end_library, library_list_start_library); Update.
11301 (solib_target_free_library_list): Remove.
11302 (solib_target_parse_libraries): Remove cleanup. Change return
11303 type.
11304 (solib_target_current_sos): Update.
11305
6471e7d2
TT		 113062019-01-17 Tom Tromey <tromey@bapiya>
11307
11308 * valprint.c: Replace "the the" with "the".
11309 * symtab.c: Replace "the the" with "the".
11310 * solib.c: Replace "the the" with "the".
11311 * solib-dsbt.c: Replace "the the" with "the".
11312 * linespec.c: Replace "the the" with "the".
11313 * dwarf2loc.h: Replace "the the" with "the".
11314 * amd64-windows-tdep.c: Replace "the the" with "the".
11315 * aarch64-tdep.c: Replace "the the" with "the".
11316
c24bdb02
KS		 113172019-01-16 Keith Seitz <keiths@redhat.com>
11318
11319 PR gdb/23773
11320 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11321 <builder>: Rename to ..
11322 <m_builder>: ... this and make private.
11323 (dwarf2_cu::get_builder): New method. Change all users of
11324 `builder' to use this method.
11325 (dwarf2_start_symtab): Move to ...
11326 (dwarf2_cu::start_symtab): ... here. Update all callers
11327 (setup_type_unit_groups): Move to ...
11328 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11329 callers.
11330 (dwarf2_cu::reset_builder): New method.
11331 (process_full_compunit, process_full_type_unit): Use
11332 dwarf2_cu::reset_builder.
11333 (follow_die_offset): Record the ancestor CU if it is different
11334 from the followed DIE's CU.
11335 (follow_die_sig_1): Likewise.
11336
8d64371b
TT		 113372019-01-15 Tom Tromey <tom@tromey.com>
11338
11339 * remote.c (class remote_state) <buf>: Now a char_vector.
11340 <buf_size>: Remove.
11341 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11342 parameter.
11343 (remote_target::getpkt_or_notif_sane_1)
11344 (remote_target::getpkt_sane)
11345 (remote_target::getpkt_or_notif_sane): Likewise.
11346 (class remote_target) <putpkt>: New overload.
11347 (remote_target::read_frame): Change type of "buf_p". Remove
11348 sizeof_p parameter.
11349 (packet_ok): New overload.
11350 (packet_check_result): New overload.
11351 Update all uses.
11352
bb277751
TT		 113532019-01-14 Tom Tromey <tom@tromey.com>
11354
11355 * remote-notif.c (handle_notification, remote_notif_ack)
11356 (remote_notif_parse): Make "buf" const.
11357 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11358 const.
11359 (remote_notif_parse, remote_notif_ack, handle_notification):
11360 Likewise.
11361 * remote.c (remote_notif_stop_parse): Make "buf" const.
11362 (remote_target::remote_parse_stop_reply): Make "buf" const.
11363 (remote_notif_stop_ack): Make "buf" const.
11364
05be00a8
TT		 113652019-01-14 Tom Tromey <tom@tromey.com>
11366
11367 * remote.c (remote_console_output): Make parameter const.
11368
491adeca
TT		 113692019-01-14 Tom Tromey <tom@tromey.com>
11370
11371 * target-debug.h (target_debug_print_signals): Constify.
11372 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11373 * procfs.c (procfs_target::pass_signals): Update.
11374 * linux-nat.c (linux_nat_target::pass_signals): Update.
11375 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11376 * target-delegates.c: Rebuild.
11377 * remote.c (remote_target::program_signals): Update.
11378 (remote_target::pass_signals): Update.
11379 * target.c (target_pass_signals): Constify argument.
11380 (target_program_signals): Likewise.
11381 * target.h (struct target_ops) <pass_signals, program_signals>:
11382 Constify argument.
11383 (target_pass_signals, target_program_signals): Constify argument.
11384
bbd94648
TT		 113852019-01-14 Tom Tromey <tom@tromey.com>
11386
11387 PR tui/28819:
11388 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11389
6f072a10
PFC		 113902019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11391
11392 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11393 field.
11394 * rs6000-tdep.c: Include reggroups.h.
11395 (IS_V_ALIAS_PSEUDOREG): Define.
11396 (rs6000_register_name): Return names for the "vX" aliases.
11397 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11398 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11399 aliases. Call default_register_reggroup_p for all other
11400 pseudo-registers.
11401 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11402 New functions.
11403 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11404 Handle "vX" aliases.
11405 (v_alias_pseudo_register_collect): New function.
11406 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11407 (rs6000_gdbarch_init): Initialize "vX" aliases as
11408 pseudo-registers. Restore registration of
11409 rs6000_pseudo_register_reggroup_p with
11410 set_tdesc_pseudo_register_reggroup_p.
11411
1a782351
MF		 114122019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11413
11414 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11415 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11416 set_gdbarch_num_pseudo_regs.
11417
d73cff18
PW		 114182019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11419
11420 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11421 Remove arg prefixname, add do_set and do_show.
11422 Add member functions set_list and show_list.
11423 * cli/cli-style.c (class cli_style_option): Update accordingly.
11424 (style_set_list): Move to file scope.
11425 (style_show_list): Likewise.
11426 (set_style): Call help_list.
11427 (show_style): Call cmd_show_list.
11428 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11429 Update to use the new macro.
11430
60a90376
JB		 114312019-10-12 Joel Brobecker <brobecker@adacore.com>
11432
11433 * ada-lang.c (_initialize_ada_language): Expand the help text
11434 for the "catch exception" command.
11435
9d7c67bf
PW		 114362019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11437
11438 * symtab.c (matching_obj_sections): Initialize obj,
11439 declare it closer to its usage.
11440
7cf47dc4
TT		 114412019-01-10 Tom Tromey <tom@tromey.com>
11442
11443 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11444 (basic_inf_threads_range): Remove.
11445 (inf_threads_range, inf_non_exited_threads_range)
11446 (safe_inf_threads_range): Use next_adapter.
11447
d3cb6808
KS		 114482019-01-10 Keith Seitz <keiths@redhat.com>
11449
11450 PR gdb/23712
11451 PR symtab/23010
11452 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11453 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11454
63a20375
KS		 114552019-01-10 Keith Seitz <keiths@redhat.com>
11456
11457 PR gdb/23712
11458 PR symtab/23010
11459 * dictionary.c (pending_to_vector): Remove.
11460 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11461 Remove _1 suffix, replacing functions of the same name. Update
11462 all callers.
11463 (dict_create_hashed, dict_create_hashed_expandable)
11464 (dict_create_linear, dict_create_linear_expandable, dict_free)
11465 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11466 Make functions static.
11467
b026f593
KS		 114682019-01-10 Keith Seitz <keiths@redhat.com>
11469
11470 PR gdb/23712
11471 PR symtab/23010
11472 * dictionary.h (struct dictionary): Replace declaration with
11473 multidictionary.
11474 (dict_create_hashed, dict_create_hashed_expandable)
11475 (dict_create_linear, dict_create_linear_expandable)
11476 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11477 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11478 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11479 taking multidictionary argument.
11480 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11481 * block.h (struct block) <dict>: Change to multidictionary
11482 and rename `multidict'.
11483 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11484 symmisc.c: Update all dictionary references to multidictionary.
11485
c7748ee9
KS		 114862019-01-10 Keith Seitz <keiths@redhat.com>
11487
11488 PR gdb/23712
11489 PR symtab/23010
11490 * dictionary.c: Include unordered_map.
11491 (pending_to_vector): New function.
11492 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11493 Rewrite the non-"_1" functions to take vector instead
11494 of linked list.
11495 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11496 "new" _1 versions of the same name.
11497 (multidictionary): Define.
11498 (std::hash<enum language): New definition.
11499 (collate_pending_symbols_by_language, mdict_create_hashed)
11500 (mdict_create_hashed_expandable, mdict_create_linear)
11501 (mdict_create_linear_expandable, mdict_free)
11502 (find_language_dictionary, create_new_language_dictionary)
11503 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11504 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11505 (mdict_size, mdict_empty): New functions.
11506 * dictionary.h (mdict_iterator): Define.
11507
67aa1f3c
PA		 115082019-01-10 Pedro Alves <palves@redhat.com>
11509
11510 * breakpoint.c (read_uploaded_action)
11511 (create_tracepoint_from_upload): Adjust to use
11512 gdb::unique_xmalloc_ptr.
11513 * ctf.c (ctf_write_uploaded_tp):
11514 (SET_ARRAY_FIELD): Use emplace_back.
11515 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11516 * tracefile-tfile.c (tfile_write_uploaded_tp):
11517 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11518 gdb::unique_xmalloc_ptr.
11519 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11520 at_string, cond_string, cmd_strings>: Replace char pointers
11521 with gdb::unique_xmalloc_ptr.
11522
2f667667
PA		 115232019-01-10 Pedro Alves <palves@redhat.com>
11524
11525 * solib-target.c (library_list_start_library): Don't xstrdup name.
11526
36cb7237
PA		 115272019-01-10 Pedro Alves <palves@redhat.com>
11528
11529 * mdebugread.c (parse_partial_symbols): Use
11530 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11531
da584958
AB		 115322019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11533
11534 * linux-fork.c (scoped_switch_fork_info)
11535 <~scoped_switch_fork_info>: Fix incorrect variable name.
11536
1ef8573c
AB		 115372019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11538
11539 * linux-fork.c (scoped_switch_fork_info)
11540 <scoped_switch_fork_info>: Make explicit.
11541 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11542
8d7bcccb
TT		 115432019-01-10 Tom Tromey <tom@tromey.com>
11544
11545 * objfiles.h (objfile::reset_psymtabs): Update.
11546 * objfiles.c (objfile::objfile): Update.
11547 * psymtab.h (psymtab_storage::obstack): Update.
11548 (psymtab_storage::m_obstack): Use gdb::optional.
11549 (class psymtab_storage): Update comment. Remove objfile
11550 parameter.
11551 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11552
b596a3c7
TT		 115532019-01-10 Tom Tromey <tom@tromey.com>
11554
11555 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11556 <free_psymtabs>: Now private.
11557 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11558 (allocate_psymtab): Use new method.
11559
a9342b62
TT		 115602019-01-10 Tom Tromey <tom@tromey.com>
11561
11562 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11563 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11564 * mdebugread.c (parse_partial_symbols): Use
11565 allocate_dependencies.
11566 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11567 allocate_dependencies.
11568 (process_psymtab_comp_unit_reader)
11569 (build_type_psymtab_dependencies): Likewise.
11570 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11571
5af70966
TT		 115722019-01-10 Tom Tromey <tom@tromey.com>
11573
11574 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11575 PSYMBOL_SET_LANGUAGE.
11576 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11577
5923a04c
TT		 115782019-01-10 Tom Tromey <tom@tromey.com>
11579
11580 * psymtab.h (psymtab_storage::obstack): New method.
11581 <m_obstack>: Rename from obstack; now private.
11582 * psymtab.c (psymtab_storage): Update.
11583 * dwarf2read.c (create_addrmap_from_index)
11584 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11585 Update.
11586
6d6a12bf
TT		 115872019-01-10 Tom Tromey <tom@tromey.com>
11588
11589 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11590 * objfiles.h (objfile::reset_psymtabs): New method.
11591
d320c2b5
TT		 115922019-01-10 Tom Tromey <tom@tromey.com>
11593
11594 * symmisc.c (print_symbol_bcache_statistics): Update.
11595 (print_objfile_statistics): Update.
11596 * symfile.c (reread_symbols): Update.
11597 * psymtab.h (class psymtab_storage): New.
11598 * psymtab.c (psymtab_storage): New constructor.
11599 (~psymtab_storage): New destructor.
11600 (require_partial_symbols): Update.
11601 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11602 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11603 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11604 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11605 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11606 (start_psymtab_common, end_psymtab_common)
11607 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11608 (allocate_psymtab): Update.
11609 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11610 Update.
11611 (dump_psymtab_addrmap, maintenance_print_psymbols)
11612 (maintenance_check_psymtabs): Update.
11613 (class objfile_psymtabs): Move to objfiles.h.
11614 * psympriv.h (discard_psymtab): Now inline.
11615 (psymtab_discarder::psymtab_discarder): Update.
11616 (psymtab_discarder::~psymtab_discarder): Update.
11617 (ALL_OBJFILE_PSYMTABS): Rewrite.
11618 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11619 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11620 Remove fields.
11621 <partial_symtabs>: New field.
11622 (class objfile_psymtabs): Move from psymtab.h. Update.
11623 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11624 psymbol_cache.
11625 (objfile::~objfile): Don't destroy psymbol_cache.
11626 * mdebugread.c (parse_partial_symbols): Update.
11627 * dwarf2read.c (create_addrmap_from_index)
11628 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11629 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11630 (add_partial_subprogram, dwarf2_ranges_read): Update.
11631 * dwarf-index-write.c (write_address_map)
11632 (write_one_signatured_type, recursively_write_psymbols)
11633 (class debug_names, class debug_names, write_psymtabs_to_index):
11634 Update.
11635
1d94a5a3
TT		 116362019-01-10 Tom Tromey <tom@tromey.com>
11637
11638 * symtab.h (SYMBOL_SET_NAMES): Update.
11639 (symbol_set_names): Update.
11640 (MSYMBOL_SET_NAMES): Update.
11641 * symtab.c (symbol_set_names): Change argument to be an
11642 objfile_per_bfd_storage.
11643 * psymtab.c (add_psymbol_to_bcache): Update.
11644 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11645
0f14768a
TT		 116462019-01-10 Tom Tromey <tom@tromey.com>
11647
11648 * symtab.c (create_demangled_names_hash): Change argument to be an
11649 objfile_per_bfd_storage.
11650 (symbol_set_names): Update.
11651
6eee24ce
TT		 116522019-01-10 Tom Tromey <tom@tromey.com>
11653
11654 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11655 init_psymbol_list.
11656 * psymtab.c (init_psymbol_list): Do nothing if already called.
11657 * psympriv.h (init_psymbol_list): Add comment.
11658 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11659 init_psymbol_list.
11660 * dbxread.c (dbx_symfile_read): Unconditionally call
11661 init_psymbol_list.
11662
75aedd27
TT		 116632019-01-10 Tom Tromey <tom@tromey.com>
11664
11665 * xcoffread.c (scan_xcoff_symtab): Update.
11666 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11667 "where".
11668 * mdebugread.c (parse_partial_symbols)
11669 (handle_psymbol_enumerators): Update.
11670 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11671 * dbxread.c (read_dbx_symtab): Update.
11672 * psympriv.h (psymbol_placement): New enum.
11673 (add_psymbol_to_list): Update.
11674
939652a5
TT		 116752019-01-10 Tom Tromey <tom@tromey.com>
11676
11677 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11678 static_psymbols parameters.
11679 (scan_xcoff_symtab): Update.
11680 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11681 static_psymbols parameters.
11682 * psympriv.h (start_psymtab_common): Update.
11683 * mdebugread.c (parse_partial_symbols): Update.
11684 * dwarf2read.c (create_partial_symtab): Update.
11685 * dbxread.c (read_dbx_symtab): Update.
11686 (start_psymtab): Remove global_psymbols and static_psymbols
11687 parameters.
11688
baa62830
TT		 116892019-01-10 Tom Tromey <tom@tromey.com>
11690
11691 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11692 * psymtab.c (allocate_psymtab): Add comment.
11693 * psympriv.h (allocate_psymtab): Add comment.
11694 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11695 initializations.
11696 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11697
0e8f53ba
TT		 116982019-01-10 Tom Tromey <tom@tromey.com>
11699
11700 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11701 Don't declare.
11702 * mipsread.c: Include mdebugread.h.
11703 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11704 Declare.
11705 * elfread.c: Include mdebugread.h.
11706
b22a7c6a
TT		 117072019-01-09 Tom Tromey <tom@tromey.com>
11708
11709 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11710 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11711 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11712 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11713 (psym_lookup_symbol, psym_find_last_source_symtab)
11714 (psym_forget_cached_source_info, psym_print_stats)
11715 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11716 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11717 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11718 (psym_find_compunit_symtab_by_address)
11719 (maintenance_print_psymbols, maintenance_info_psymtabs)
11720 (maintenance_check_psymtabs): Use ranged for.
11721 * psymtab.h (class objfile_psymtabs): New.
11722 (require_partial_symbols): Return objfile_psymtabs.
11723 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11724
3b9d3ac2
TT		 117252019-01-09 Tom Tromey <tom@tromey.com>
11726
11727 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11728 (find_pc_mapped_section, list_overlays_command)
11729 (map_overlay_command, unmap_overlay_command)
11730 (simple_overlay_update): Use all_objfiles.
11731 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11732 * printcmd.c (info_symbol_command): Use all_objfiles.
11733 * objfiles.h (ALL_OBJSECTIONS): Remove.
11734 * maint.c (maintenance_translate_address): Use all_objfiles.
11735 * gcore.c (gcore_create_callback): Use all_objfiles.
11736 (objfile_find_memory_regions): Likewise.
11737
8b31193a
TT		 117382019-01-09 Tom Tromey <tom@tromey.com>
11739
11740 * symtab.c (find_line_symtab, info_sources_command)
11741 (make_source_files_completion_list): Use objfile_compunits.
11742 * source.c (select_source_symtab): Use objfile_compunits.
11743 * objfiles.h (struct objfile): Update comment.
11744 (ALL_OBJFILES): Remove.
11745 (ALL_FILETABS): Remove.
11746 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11747 objfile_compunits.
11748
d5da8b3c
TT		 117492019-01-09 Tom Tromey <tom@tromey.com>
11750
11751 * symmisc.c (print_objfile_statistics, dump_objfile)
11752 (maintenance_print_symbols): Use compunit_filetabs.
11753 * source.c (forget_cached_source_info_for_objfile): Use
11754 compunit_filetabs.
11755 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11756 (ALL_FILETABS): Use compunit_filetabs.
11757 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11758 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11759
5accd1a0
TT		 117602019-01-09 Tom Tromey <tom@tromey.com>
11761
11762 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11763 (compunit_filetabs): New.
11764 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11765 compunit_filetabs.
11766 (info_sources_command, make_source_files_completion_list): Remove
11767 declaration.
11768 * symmisc.c (print_objfile_statistics, dump_objfile)
11769 (maintenance_print_symbols): Remove declaration.
11770 (maintenance_info_symtabs): Use compunit_filetabs.
11771 (maintenance_info_line_tables): Likewise.
11772 * source.c (select_source_symtab): Change local variable name.
11773 (forget_cached_source_info_for_objfile): Remove declaration.
11774 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11775 * objfiles.c (objfile_relocate1): Remove declaration.
11776 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11777 declaration.
11778 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11779 * coffread.c (coff_symtab_read): Remove declaration.
11780 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11781 compunit_filetabs.
11782
d8aeb77f
TT		 117832019-01-09 Tom Tromey <tom@tromey.com>
11784
11785 * symtab.c (lookup_objfile_from_block)
11786 (find_pc_sect_compunit_symtab, search_symbols)
11787 (default_collect_symbol_completion_matches_break_on): Use
11788 objfile_compunits.
11789 * objfiles.h (ALL_COMPUNITS): Remove.
11790 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11791 * cp-support.c (add_symbol_overload_list_qualified): Use
11792 objfile_compunits.
11793 * ada-lang.c (ada_collect_symbol_completion_matches)
11794 (ada_add_global_exceptions): Use objfile_compunits.
11795
592553c4
TT		 117962019-01-09 Tom Tromey <tom@tromey.com>
11797
11798 * source.c (select_source_symtab)
11799 (forget_cached_source_info_for_objfile): Remove declaration.
11800 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11801 declaration.
11802 * maint.c (count_symtabs_and_blocks): Remove declaration.
11803 * cp-support.c (add_symbol_overload_list_qualified): Remove
11804 declaration.
11805 * coffread.c (coff_symtab_read): Remove declaration.
11806 * symtab.c (lookup_symbol_in_objfile_symtabs)
11807 (basic_lookup_transparent_type_1): Use objfile_compunits.
11808 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11809 (info_sources_command, search_symbols)
11810 (default_collect_symbol_completion_matches_break_on)
11811 (make_source_files_completion_list): Remove declaration.
11812 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11813 (ada_collect_symbol_completion_matches)
11814 (ada_add_global_exceptions): Remove declaration.
11815 * linespec.c (iterate_over_all_matching_symtabs): Use
11816 objfile_compunits.
11817 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11818 (class objfile_compunits): New.
11819 (ALL_COMPUNITS): Use objfile_compunits.
11820 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11821 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11822 objfile_compunits.
11823 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11824
5325b9bf
TT		 118252019-01-09 Tom Tromey <tom@tromey.com>
11826
11827 * symtab.c (search_symbols)
11828 (default_collect_symbol_completion_matches_break_on): Use
11829 objfile_msymbols.
11830 * ada-lang.c (ada_lookup_simple_minsym)
11831 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11832 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11833 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11834 objfile_msymbols.
11835 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11836 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11837 * objc-lang.c (find_methods): Use objfile_msymbols.
11838 (info_selectors_command, info_classes_command): Likewise.
11839 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11840 * objfiles.h (class objfile_msymbols): New.
11841 (ALL_OBJFILE_MSYMBOLS): Remove.
11842 (ALL_MSYMBOLS): Remove.
11843
cac85af2
TT		 118442019-01-09 Tom Tromey <tom@tromey.com>
11845
11846 * common/next-iterator.h (next_adapter): Add Iterator template
11847 parameter.
11848 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11849 (class all_objfiles_safe): New.
11850 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11851 * objfiles.c (put_objfile_before): Update comment.
11852 (add_separate_debug_objfile): Likewise.
11853 (free_all_objfiles): Use all_objfiles_safe.
11854 (objfile_purge_solibs): Likewise.
11855
aed57c53
TT		 118562019-01-09 Tom Tromey <tom@tromey.com>
11857
11858 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11859 (expand_symtab_containing_pc, lookup_static_symbol)
11860 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11861 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11862 all_objfiles.
11863 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11864 * breakpoint.c (create_overlay_event_breakpoint)
11865 (create_longjmp_master_breakpoint)
11866 (create_std_terminate_master_breakpoint)
11867 (create_exception_master_breakpoint): Use all_objfiles.
11868 * linux-thread-db.c (try_thread_db_load_from_pdir)
11869 (has_libpthread): Use all_objfiles.
11870 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11871 * linespec.c (iterate_over_all_matching_symtabs)
11872 (search_minsyms_for_name): Use all_objfiles.
11873 * maint.c (maintenance_info_sections): Use all_objfiles.
11874 * main.c (captured_main_1): Use all_objfiles.
11875 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11876 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11877 * guile/scm-pretty-print.c
11878 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11879 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11880 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11881 (maintenance_print_msymbols): Use all_objfiles.
11882 * source.c (select_source_symtab): Use all_objfiles.
11883 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11884 * symfile.c (remove_symbol_file_command)
11885 (expand_symtabs_matching, map_symbol_filenames): Use
11886 all_objfiles.
11887 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11888 all_objfiles.
11889 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11890 * objc-lang.c (find_methods): Use all_objfiles.
11891 * objfiles.c (have_partial_symbols, have_full_symbols)
11892 (have_minimal_symbols, qsort_cmp)
11893 (default_iterate_over_objfiles_in_search_order): Use
11894 all_objfiles.
11895 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11896 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11897 (maintenance_check_psymtabs): Use all_objfiles.
11898 (ALL_PSYMTABS): Remove.
11899 * compile/compile-object-run.c (do_module_cleanup): Use
11900 all_objfiles.
11901 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11902 * cp-support.c (add_symbol_overload_list_qualified): Use
11903 all_objfiles.
11904 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11905 Use all_objfiles.
11906 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11907 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11908 all_objfiles.
11909 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11910 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11911 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11912 Uses all_objfiles.
11913 * solib.c (solib_read_symbols): Use all_objfiles
11914
99d89cde
TT		 119152019-01-09 Tom Tromey <tom@tromey.com>
11916
11917 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11918 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11919 all_objfiles.
11920 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11921 * symmisc.c (print_symbol_bcache_statistics)
11922 (print_objfile_statistics, maintenance_print_objfiles)
11923 (maintenance_info_symtabs, maintenance_check_symtabs)
11924 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11925 all_objfiles.
11926 * source.c (forget_cached_source_info): Use all_objfiles.
11927 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11928 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11929 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11930 * objfiles.c (update_section_map): Use all_objfiles.
11931 (shared_objfile_contains_address_p): Likewise.
11932 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11933 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11934
21708325
TT		 119352019-01-09 Tom Tromey <tom@tromey.com>
11936
11937 * common/next-iterator.h: New file.
11938 * objfiles.h (class all_objfiles): New.
11939 (struct objfile_iterator): New.
11940
669e09f6
PW		 119412019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11942
11943 * NEWS: Move the description of the changed "frame", "select-frame",
11944 and "info frame" commands to the Changed commands section.
11945
041be526
SM		 119462019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11947
11948 * gdbtypes.c (check_stub_method_group): Remove handling of old
11949 mangling schemes.
11950 * linespec.c (find_methods): Likewise.
11951 * stabsread.c (read_member_functions): Likewise.
11952 * valops.c (search_struct_method): Likewise.
11953 (value_struct_elt_for_reference): Likewise.
11954 * NEWS: Mention this change.
11955
0e2a2133
AB		 119562019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11957
11958 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11959 print_source_lines.
11960 * source.c (print_source_lines_base): Update line number check.
11961 (print_source_lines): New function.
11962 (source_lines_range::source_lines_range): New function.
11963 * source.h (class source_lines_range): New class.
11964 (print_source_lines): New declaration.
11965
1055a3b4
PW		 119662019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11967
11968 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11969
cfeadda5
TT		 119702019-01-08 Tom Tromey <tom@tromey.com>
11971 Simon Marchi <simon.marchi@ericsson.com>
11972
11973 PR gdb/24060
11974 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11975 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11976 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11977 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11978 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11979 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11980
583068ca
AB		 119812019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11982
11983 * source.c (select_source_symtab): Move header comment to
11984 declaration in source.h.
11985 (forget_cached_source_info_for_objfile): Likewise.
11986 (forget_cached_source_info): Likewise.
11987 (identify_source_line): Likewise.
11988 * source.h (identify_source_line): Move declaration from symtab.h
11989 and add comment from source.c
11990 (print_source_lines): Likewise.
11991 (forget_cached_source_info_for_objfile): Likewise.
11992 (forget_cached_source_info): Likewise.
11993 (select_source_symtab): Likewise.
11994 (enum print_source_lines_flag): Move definition from symtab.h.
11995 * symtab.h (identify_source_line): Move declaration to source.h.
11996 (print_source_lines): Likewise.
11997 (forget_cached_source_info_for_objfile): Likewise.
11998 (forget_cached_source_info): Likewise.
11999 (select_source_symtab): Likewise.
12000 (enum print_source_lines_flag): Move definition to source.h.
12001 * tui/tui-hooks.c: Add 'source.h' include.
12002
ec98a4ad
AB		 120032019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12004
12005 * source.c (print_source_lines_base): Handle requests to print
12006 reverse line number sequences, and guard against empty lines
12007 string.
12008
62ea19c1
AB		 120092019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12010
12011 * source.c (print_source_lines_base): Fix skip of '\r' if next
12012 character is '\n'.
12013
9d30e1fd
TT		 120142019-01-06 Tom Tromey <tom@tromey.com>
12015
12016 * c-exp.y (struct c_parse_state) <macro_original_text,
12017 expansion_obstack>: New member.
12018 (macro_original_text, expansion_obstack): Remove globals.
12019 (scan_macro_expansion, scanning_macro_expansion)
12020 (finished_macro_expansion): Update.
12021 (scan_macro_cleanup): Remove.
12022 (yylex, c_parse): Update.
12023
c65bac38
TT		 120242019-01-06 Tom Tromey <tom@tromey.com>
12025
12026 * c-exp.y (struct c_parse_state) <strings>: New member.
12027 (operator_stoken): Update.
12028
02e12e38
TT		 120292019-01-06 Tom Tromey <tom@tromey.com>
12030
12031 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12032 (union type_stack_elt) <typelist_val>: Now a pointer to
12033 std::vector.
12034 (type_stack_cleanup): Don't declare.
12035 (push_typelist): Update.
12036 * parse.c (pop_typelist): Return a std::vector.
12037 (push_typelist): Take a std::vector.
12038 (follow_types): Update. Do not free args.
12039 (type_stack_cleanup): Remove.
12040 * c-exp.y (struct c_parse_state): New.
12041 (cpstate): New global.
12042 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12043 (nonempty_typelist): Update.
12044 (func_mod): Create a new vector.
12045 (c_parse): Create a c_parse_state.
12046 (check_parameter_typelist): Do not delete params.
12047 (function_method): Update. Do not delete type_list.
12048
f097f5ad
TT		 120492019-01-06 Tom Tromey <tom@tromey.com>
12050
12051 PR gdb/28155:
12052 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12053 check_typedef.
12054 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12055 (print_return_value): Likewise.
12056
d2adf9f1
TT		 120572019-01-05 Tom Tromey <tom@tromey.com>
12058
12059 * contrib/cleanup_check.py: Remove.
12060 * contrib/gcc-with-excheck: Remove.
12061 * contrib/exsummary.py: Remove.
12062 * contrib/excheck.py: Remove.
12063
2eab46b1
JB		 120642019-01-05 Joel Brobecker <brobecker@adacore.com>
12065
12066 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12067 NULL. Initialize tpprev to NULL instead of assigning it
12068 to NULL on the next statement.
12069 * windows-nat.c (windows_delete_thread): Remove check for
12070 main_thread_id before printing thread exit notifications.
12071 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12072 Remove thread ID check against main_thread_id.
12073 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12074 windows_delete_thread.
12075 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12076
48c5e7e2
TT		 120772019-01-04 Tom Tromey <tom@tromey.com>
12078
12079 * compile/compile.c (_initialize_compile): Use upper case for
12080 metasyntactic variables.
12081 * symmisc.c (_initialize_symmisc): Use upper case for
12082 metasyntactic variables.
12083 * psymtab.c (_initialize_psymtab): Use upper case for
12084 metasyntactic variables.
12085 * demangle.c (demangle_command): Use upper case for metasyntactic
12086 variables.
12087 (_initialize_demangler): Likewise.
12088 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12089 variables.
12090
986041cd
TT		 120912019-01-03 Tom Tromey <tom@tromey.com>
12092
12093 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12094
7c711119
TT		 120952019-01-03 Tom Tromey <tom@tromey.com>
12096
12097 * python/py-symtab.c (salpy_str): Update.
12098 (struct salpy_sal_object) <symtab>: Now a PyObject.
12099 (salpy_dealloc): Update.
12100 (del_objfile_sal): Use gdbpy_ref.
12101
1b20edf0
TT		 121022019-01-03 Tom Tromey <tom@tromey.com>
12103
12104 * python/py-type.c (convert_field): Use new_reference. Return
12105 gdbpy_ref.
12106 (make_fielditem): Return gdbpy_ref.
12107 (typy_fields): Update.
12108 (typy_getitem): Update.
12109 (field_name): Return gdbpy_ref. Use new_reference.
12110 (typy_iterator_iternext): Update.
12111
ea41325b
TT		 121122019-01-03 Tom Tromey <tom@tromey.com>
12113
12114 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12115
2a3c71d6
TT		 121162019-01-03 Tom Tromey <tom@tromey.com>
12117
12118 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12119 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12120 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12121 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12122 (pspy_set_type_printers): Likewise.
12123 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12124 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12125 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12126 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12127 (objfpy_set_type_printers): Likewise.
12128
5c329e6a
TT		 121292019-01-03 Tom Tromey <tom@tromey.com>
12130
12131 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12132 (gdbpy_print_stack): Use gdbpy_err_fetch.
12133 * python/python-internal.h (class gdbpy_err_fetch): New class.
12134 (class gdbpy_enter) <m_error_type, m_error_value,
12135 m_error_traceback>: Remove.
12136 <m_error>: New member.
12137 (gdbpy_exception_to_string): Don't declare.
12138 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12139 * python/py-value.c (convert_value_from_python): Use
12140 gdbpy_err_fetch.
12141 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12142 gdbpy_exception_to_string.
12143 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12144 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12145 gdbpy_err_fetch.
12146
169bb27b
AB		 121472019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12148
12149 * linux-nat.c (delete_lwp_cleanup): Delete.
12150 (struct lwp_deleter): New struct.
12151 (lwp_info_up): New typedef.
12152 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12153 lwp_info_up.
12154
a07c8880
AB		 121552019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12156
12157 * linux-fork.c (class scoped_switch_fork_info): New class.
12158 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12159
26089c49
AB		 121602019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12161
12162 * valops.c (find_overload_match): Remove use of null_cleanup, and
12163 calls to do_cleanups.
12164
06d3e5b0
AB		 121652019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12166
12167 * compile/compile-cplus-types.c
12168 (compile_cplus_instance::decl_name): Handle changes to
12169 cp_func_name.
12170 * cp-support.c (cp_func_name): Update header comment, update
12171 return type.
12172 * cp-support.h (cp_func_name): Update return type in declaration.
12173 * valops.c (find_overload_match): Move temp_func local to top
12174 level of function and change its type. Use temp_func to hold and
12175 delete temporary string obtained from cp_func_name.
12176
66644cd3
AB		 121772019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12178
12179 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12180 gdb::char_vector, remove cleanup, and update uses of `msg`.
12181
592d8c0a
JW		 121822019-01-03 Jim Wilson <jimw@sifive.com>
12183
12184 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12185
c55d06ec
TT		 121862019-01-02 Tom Tromey <tom@tromey.com>
12187
12188 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12189 (tdesc_parse_xml): Remove cleanups.
12190 * target-descriptions.h (make_cleanup_free_target_description):
12191 Don't declare.
12192 (target_desc_deleter): New struct.
12193 (target_desc_up): New typedef.
12194 * target-descriptions.c (target_desc_deleter::operator()): Rename
12195 from free_target_description.
12196 (make_cleanup_free_target_description): Remove.
12197
3a6ae42d
TT		 121982019-01-02 Tom Tromey <tom@tromey.com>
12199
12200 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12201 constructor, destructor.
12202 (linespec_parser): Remove typedef.
12203 (~linespec_parser): Rename from linespec_parser_delete.
12204 (linespec_lex_to_end, linespec_complete_label)
12205 (linespec_complete): Update.
12206 (decode_line_full): Remove cleanups.
12207 (decode_line_1): Update.
12208
61fd3e73
TT		 122092019-01-02 Tom Tromey <tom@tromey.com>
12210
12211 * python/python-internal.h (inferior_to_inferior_object): Change
12212 return type.
12213 * python/py-exitedevent.c (create_exited_event_object): Update.
12214 * python/py-inferior.c (inferior_to_inferior_object): Return
12215 gdbpy_ref.
12216 (python_new_inferior, python_inferior_deleted)
12217 (thread_to_thread_object, delete_thread_object)
12218 (build_inferior_list, gdbpy_selected_inferior): Update.
12219 * python/py-infthread.c (create_thread_object): Update. Also fail
12220 if inferior_to_inferior_object fails.
12221
d20172fc
SM		 122222019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12223
12224 * inferior.h (class inferior) <displaced_step_state>: New field.
12225 * infrun.h (struct displaced_step_state): Move here from
12226 infrun.c. Initialize fields, add constructor.
12227 <inf>: Remove field.
12228 <reset>: New method.
12229 * infrun.c (struct displaced_step_inferior_state): Move to
12230 infrun.h.
12231 (displaced_step_inferior_states): Remove.
12232 (get_displaced_stepping_state): Adust.
12233 (displaced_step_in_progress_any_inferior): Adjust.
12234 (displaced_step_in_progress_thread): Adjust.
12235 (displaced_step_in_progress): Adjust.
12236 (add_displaced_stepping_state): Remove.
12237 (get_displaced_step_closure_by_addr): Adjust.
12238 (remove_displaced_stepping_state): Remove.
12239 (infrun_inferior_exit): Call displaced_step_state.reset.
12240 (use_displaced_stepping): Don't check for NULL.
12241 (displaced_step_prepare_throw): Call
12242 get_displaced_stepping_state.
12243 (displaced_step_fixup): Don't check for NULL.
12244 (prepare_for_detach): Don't check for NULL.
12245
e3319240
PW		 122462019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12247
12248 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12249 in case of call that did not complete.
12250
5d36dfb9
AU		 122512019-01-02 Andrey Utkin <autkin@undo.io>
12252
12253 * symfile.c (find_separate_debug_file): Fix search of debug files for
12254 remote debuggee.
12255
8833fbf0
TT		 122562019-01-02 Tom Tromey <tom@tromey.com>
12257
12258 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12259 indentation.
12260 * python/py-frame.c (frapy_older): Remove cast.
12261 (frapy_newer): Likewise.
12262 * python/py-breakpoint.c (local_setattro): Remove cast.
12263 * python/py-arch.c (archpy_name): Remove local variable.
12264 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12265
4ada3dfd
JB		 122662019-01-02 Joel Brobecker <brobecker@adacore.com>
12267
12268 * unittests/basic_string_view/element_access/char/empty.cc:
12269 Fix year range in copyright header.
12270
113b7b81
AB		 122712019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12272
12273 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12274 Delete.
12275 <operator==>: Update with for removed field.
12276 <hash>: Likewise.
12277 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12278 <isa_features>: ...this.
12279 <abi_features>: New field.
12280 (riscv_isa_flen): Update comment.
12281 (riscv_abi_xlen): New declaration.
12282 (riscv_abi_flen): New declaration.
12283 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12284 isa_features.
12285 (riscv_abi_xlen): New function.
12286 (riscv_isa_flen): Update to get answer from isa_features.
12287 (riscv_abi_flen): New function.
12288 (riscv_has_fp_abi): Update to get answer from abi_features.
12289 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12290 xlen and flen.
12291 (riscv_call_info) <xlen, flen>: Update comment.
12292 (riscv_call_arg_struct): Remove invalid assertions
12293 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12294 is removed.
12295 (riscv_gdbarch_init): Gather isa features and abi features
12296 separately, ensure both match on the gdbarch when reusing an old
12297 gdbarch. Relax an error check to allow 32-bit abi float to run on
12298 a target with 64-bit float hardware.
12299
b18ca514
PW		 123002019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12301
12302 * source.c (search_command_helper): Stop reverse search
12303 when line 1 has been searched.
12304
ec70d8db
PW		 123052019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12306
12307 * record-full.c (record_full_base_target::close): Rewrite
12308 record_full_core_buf_list free logic.
12309
5b38f9c1
PW		 123102019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12311
12312 * break-catch-syscall.c (print_one_catch_syscall): xfree
12313 the last text.
12314
66d91b39
JB		 123152019-01-01 Joel Brobecker <brobecker@adacore.com>
12316
12317 * top.c (print_gdb_version): Update Copyright year in version
12318 message.
12319
42a4f53d
JB		 123202019-01-01 Joel Brobecker <brobecker@adacore.com>
12321
12322 Update copyright year range in all GDB files.
12323
7e955d83 123242019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 12325
5bbd631d 12326 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 12327
5bbd631d 12328For older changes see ChangeLog-2018.
c906108c
SS		 12329\f
12330Local Variables:
12331mode: change-log
12332left-margin: 8
12333fill-column: 74
12334version-control: never
57da7796 12335coding: utf-8
c906108c 12336End:
5bbd631d 12337
GDB Binutils - Deliverables
This page took 2.738052 seconds and 4 git commands to generate.