Set TUI locator height to 1
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
1b935acf
TT
12019-09-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4 height for locator.
5 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
6 * tui/tui-layout.c (show_source_disasm_command, show_data)
7 (show_source_or_disasm_and_command): Use 1 as height for locator.
8
9abd8a65
TT
92019-09-20 Tom Tromey <tom@tromey.com>
10
11 * tui/tui.c (tui_enable): Update.
12 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
13 Update.
14 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
15 Update.
16 * tui/tui-data.c (win_resized): Now bool.
17 (tui_win_resized): Return bool.
18 (tui_set_win_resized_to): Accept a bool.
19
b5457826
TT
202019-09-20 Tom Tromey <tom@tromey.com>
21
22 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
23 Change type of "refresh_values_only".
24 * tui/tui-regs.c (tui_data_window::show_register_group): Change
25 type of "refresh_values_only".
26
6b915f7d
TT
272019-09-20 Tom Tromey <tom@tromey.com>
28
29 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
30 std::string.
31 (tui_disassemble): Add "pos" parameter.
32 (tui_disasm_window::set_contents): Simplify.
33
2ad52f6f
TT
342019-09-20 Tom Tromey <tom@tromey.com>
35
36 * tui/tui-winsource.h (struct tui_source_window_base)
37 <show_source_content>: Now private.
38 * tui/tui-winsource.c
39 (tui_source_window_base::show_source_content): Don't handle empty
40 content case.
41
b3b1bde6
TT
422019-09-20 Tom Tromey <tom@tromey.com>
43
44 * tui/tui-layout.c (show_source_disasm_command)
45 (show_source_or_disasm_and_command): Don't call
46 show_source_content.
47
71a25ed2
TT
482019-09-20 Tom Tromey <tom@tromey.com>
49
50 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
51 Declare.
52 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
53 from tui_make_status_line.
54 (tui_locator_window::rerender): Update.
55
f8532154
TT
562019-09-20 Tom Tromey <tom@tromey.com>
57
58 * tui/tui-stack.c (tui_make_status_line): Return std::string.
59 (tui_locator_window::rerender): Update.
60
2d81b349
TT
612019-09-20 Tom Tromey <tom@tromey.com>
62
63 * tui/tui-winsource.h (struct tui_source_window_base)
64 <~tui_source_window_base>: Don't declare.
65 <fullname>: Remove.
66 * tui/tui-winsource.c (~tui_source_window_base): Remove.
67 * tui/tui-source.h (struct tui_source_window) <fullname>: New
68 member.
69 * tui/tui-source.c (tui_source_window::set_contents): Update.
70 (tui_source_window::location_matches_p)
71 (tui_source_window::maybe_update): Update.
72
f14bec58
TT
732019-09-20 Tom Tromey <tom@tromey.com>
74
75 * tui/tui-winsource.h (~tui_source_element): Remove.
76 (tui_source_element): Update.
77 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
78 * tui/tui-winsource.c (tui_show_source_line): Update.
79 * tui/tui-source.c (tui_source_window::set_contents): Update.
80 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
81
78d5933a
TT
822019-09-20 Tom Tromey <tom@tromey.com>
83
84 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
85 declare.
86 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
87 tui_clear_source_windows_detail.
88 * tui/tui-winsource.h (struct tui_source_window_base)
89 <clear_detail>: Don't declare.
90 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
91 Remove.
92 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
93
d4207696
TT
942019-09-20 Tom Tromey <tromey@adacore.com>
95
96 PR ada/24919:
97 * block.c (contained_in): Fix final return value.
98
00f93c44
AM
992019-09-20 Alan Modra <amodra@gmail.com>
100
101 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
102 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
103 (read_indirect_string_from_dwz): Use bfd accessor.
104 * dwarf2read.h (struct dwz_file <filename>): Likewise.
105 * machoread.c (macho_symfile_read_all_oso): Likewise.
106 * solib.c (solib_bfd_open): Likewise.
107
e4153ae6
CB
1082019-09-19 Christian Biesinger <cbiesinger@google.com>
109
110 * eval.c: Move declaration of overload_resolution to...
111 * value.h: ...here.
112
c7ae7675
CB
1132019-09-19 Christian Biesinger <cbiesinger@google.com>
114
115 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
116 * arm-linux-tdep.c: Likewise.
117 * arm-nbsd-nat.c: Likewise.
118 * arm-tdep.h: Declare arm_apcs_32.
119 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
120
e86f08d2
CB
1212019-09-19 Christian Biesinger <cbiesinger@google.com>
122
123 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
124 * dwarf2read.h: Declare dwarf_always_disassemble.
125
f64e2f40
TV
1262019-09-19 Tom de Vries <tdevries@suse.de>
127
128 PR gdb/25009
129 * source-cache.c (source_cache::ensure): Catch exception thrown during
130 construction of the highlighter.
131
fd361982
AM
1322019-09-18 Alan Modra <amodra@gmail.com>
133
134 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
135 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
136 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
137 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
138 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
139 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
140 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
141 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
142 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
143 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
144 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
145 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
146 * solib-spu.c, * solib-svr4.c, * solib-target.c,
147 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
148 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
149 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
150 * mi/mi-interp.c: Update throughout for bfd section macro and
151 function changes.
152 * gcore (gcore_create_callback): Use bfd_set_section_lma.
153 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
154
11061048
TT
1552019-09-18 Tom Tromey <tom@tromey.com>
156
157 * NEWS: Add entry.
158 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
159 call rl_initialize.
160 (tui_enable): Do not call rl_initialize.
161
7a27b85f
CG
1622019-09-18 Christian Groessler <chris@groessler.org>
163
164 * alpha-linux-nat.c: Include gdbarch.h.
165
f64eea3a
SM
1662019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
167
168 * ui-file.c: Include cli/cli-style.h.
169 (term_cli_styling): Remove cli_styling declaration.
170
e6f7f6d1
AM
1712019-09-18 Alan Modra <amodra@gmail.com>
172
173 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
174 to bfd_asymbol_section.
175
1d38e9d1
AM
1762019-09-18 Alan Modra <amodra@gmail.com>
177
178 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
179 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
180 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
181
90d92a63
AM
1822019-09-18 Alan Modra <amodra@gmail.com>
183
184 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
185 * spu-linux-nat.c (spu_bfd_open): Likewise.
186
a3d181d2
CB
1872019-09-18 Christian Biesinger <cbiesinger@google.com>
188
189 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
190 to bool to match definition in dwarf2read.c.
191
491144b5
CB
1922019-09-17 Christian Biesinger <cbiesinger@google.com>
193
194 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
195 (print_signatures): Likewise.
196 (trust_pad_over_xvs): Likewise.
197 * arch/aarch64-insn.c (aarch64_debug): Likewise.
198 * arch/aarch64-insn.h (aarch64_debug): Likewise.
199 * arm-linux-nat.c (arm_apcs_32): Likewise.
200 * arm-linux-tdep.c (arm_apcs_32): Likewise.
201 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
202 * arm-tdep.c (arm_debug): Likewise.
203 (arm_apcs_32): Likewise.
204 * auto-load.c (debug_auto_load): Likewise.
205 (auto_load_gdb_scripts): Likewise.
206 (global_auto_load): Likewise.
207 (auto_load_local_gdbinit): Likewise.
208 (auto_load_local_gdbinit_loaded): Likewise.
209 * auto-load.h (global_auto_load): Likewise.
210 (auto_load_local_gdbinit): Likewise.
211 (auto_load_local_gdbinit_loaded): Likewise.
212 * breakpoint.c (disconnected_dprintf): Likewise.
213 (breakpoint_proceeded): Likewise.
214 (automatic_hardware_breakpoints): Likewise.
215 (always_inserted_mode): Likewise.
216 (target_exact_watchpoints): Likewise.
217 (_initialize_breakpoint): Update.
218 * breakpoint.h (target_exact_watchpoints): Change to bool.
219 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
220 * cli/cli-cmds.c (trace_commands): Likewise.
221 * cli/cli-cmds.h (trace_commands): Likewise.
222 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
223 to bool*.
224 * cli/cli-logging.c (logging_overwrite): Change to bool.
225 (logging_redirect): Likewise.
226 (debug_redirect): Likewise.
227 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
228 (struct boolean_option_def) <get_var_address_cb_>: Change return type
229 to bool.
230 <boolean_option_def>: Update.
231 (struct flag_option_def): Change default type of Context to bool
232 from int.
233 <flag_option_def>: Change return type of var_address_cb_ to bool*.
234 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
235 (get_setshow_command_value_string): Likewise.
236 * cli/cli-style.c (cli_styling): Change to bool.
237 (source_styling): Likewise.
238 * cli/cli-style.h (source_styling): Likewise.
239 (cli_styling): Likewise.
240 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
241 to bool.
242 * command.h (var_types): Update comment.
243 (add_setshow_boolean_cmd): Change int* var argument to bool*.
244 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
245 bool.
246 (debug_compile_cplus_scopes): Likewise.
247 * compile/compile-internal.h (compile_debug): Likewise.
248 * compile/compile.c (compile_debug): Likewise.
249 (struct compile_options) <raw>: Likewise.
250 * cp-support.c (catch_demangler_crashes): Likewise.
251 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
252 (usr_cmd_cris_dwarf2_cfi): Likewise.
253 * csky-tdep.c (csky_debug): Likewise.
254 * darwin-nat.c (enable_mach_exceptions): Likewise.
255 * dcache.c (dcache_enabled_p): Likewise.
256 * defs.h (info_verbose): Likewise.
257 * demangle.c (demangle): Likewise.
258 (asm_demangle): Likewise.
259 * dwarf-index-cache.c (debug_index_cache): Likewise.
260 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
261 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
262 * dwarf2read.c (check_physname): Likewise.
263 (use_deprecated_index_sections): Likewise.
264 (dwarf_always_disassemble): Likewise.
265 * eval.c (overload_resolution): Likewise.
266 * event-top.c (set_editing_cmd_var): Likewise.
267 (exec_done_display_p): Likewise.
268 * event-top.h (set_editing_cmd_var): Likewise.
269 (exec_done_display_p): Likewise.
270 * exec.c (write_files): Likewise.
271 * fbsd-nat.c (debug_fbsd_lwp): Likewise
272 (debug_fbsd_nat): Likewise.
273 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
274 Likewise.
275 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
276 <backtrace_past_entry> Likewise.
277 * gdb-demangle.h (demangle): Likewise.
278 (asm_demangle): Likewise.
279 * gdb_bfd.c (bfd_sharing): Likewise.
280 * gdbcore.h (write_files): Likewise.
281 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
282 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
283 * gdbthread.h (print_thread_events): Likewise.
284 * gdbtypes.c (opaque_type_resolution): Likewise.
285 (strict_type_checking): Likewise.
286 * gnu-nat.c (gnu_debug_flag): Likewise.
287 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
288 * guile/scm-param.c (pascm_variable): Add boolval.
289 (add_setshow_generic): Update.
290 (pascm_param_value): Update.
291 (pascm_set_param_value_x): Update.
292 * hppa-tdep.c (hppa_debug): Change to bool..
293 * infcall.c (may_call_functions_p): Likewise.
294 (coerce_float_to_double_p): Likewise.
295 (unwind_on_signal_p): Likewise.
296 (unwind_on_terminating_exception_p): Likewise.
297 * infcmd.c (startup_with_shell): Likewise.
298 * inferior.c (print_inferior_events): Likewise.
299 * inferior.h (startup_with_shell): Likewise.
300 (print_inferior_events): Likewise.
301 * infrun.c (step_stop_if_no_debug): Likewise.
302 (detach_fork): Likewise.
303 (debug_displaced): Likewise.
304 (disable_randomization): Likewise.
305 (non_stop): Likewise.
306 (non_stop_1): Likewise.
307 (observer_mode): Likewise.
308 (observer_mode_1): Likewise.
309 (set_observer_mode): Update.
310 (sched_multi): Change to bool.
311 * infrun.h (debug_displaced): Likewise.
312 (sched_multi): Likewise.
313 (step_stop_if_no_debug): Likewise.
314 (non_stop): Likewise.
315 (disable_randomization): Likewise.
316 * linux-tdep.c (use_coredump_filter): Likewise.
317 (dump_excluded_mappings): Likewise.
318 * linux-thread-db.c (auto_load_thread_db): Likewise.
319 (check_thread_db_on_load): Likewise.
320 * main.c (captured_main_1): Update.
321 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
322 xx2_opt, boolean_opt>: Change to bool.
323 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
324 * maint.c (maintenance_profile_p): Likewise.
325 (per_command_time): Likewise.
326 (per_command_space): Likewise.
327 (per_command_symtab): Likewise.
328 * memattr.c (inaccessible_by_default): Likewise.
329 * mi/mi-main.c (mi_async): Likewise.
330 (mi_async_1): Likewise.
331 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
332 * nat/fork-inferior.h (startup_with_shell): Likewise.
333 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
334 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
335 * nios2-tdep.c (nios2_debug): Likewise.
336 * or1k-tdep.c (or1k_debug): Likewise.
337 * parse.c (parser_debug): Likewise.
338 * parser-defs.h (parser_debug): Likewise.
339 * printcmd.c (print_symbol_filename): Likewise.
340 * proc-api.c (procfs_trace): Likewise.
341 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
342 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
343 (set_parameter_value): Update.
344 (add_setshow_generic): Update.
345 * python/py-value.c (copy_py_bool_obj): Change argument from int*
346 to bool*.
347 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
348 int*.
349 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
350 * record-btrace.c (record_btrace_target::store_registers): Update.
351 * record-full.c (record_full_memory_query): Change to bool.
352 (record_full_stop_at_limit): Likewise.
353 * record-full.h (record_full_memory_query): Likewise.
354 * remote-notif.c (notif_debug): Likewise.
355 * remote-notif.h (notif_debug): Likewise.
356 * remote.c (use_range_stepping): Likewise.
357 (interrupt_on_connect): Likewise.
358 (remote_break): Likewise.
359 * ser-tcp.c (tcp_auto_retry): Likewise.
360 * ser-unix.c (serial_hwflow): Likewise.
361 * skip.c (debug_skip): Likewise.
362 * solib-aix.c (solib_aix_debug): Likewise.
363 * spu-tdep.c (spu_stop_on_load_p): Likewise.
364 (spu_auto_flush_cache_p): Likewise.
365 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
366 Likewise.
367 (struct info_print_options) <quiet>: Likewise.
368 * symfile-debug.c (debug_symfile): Likewise.
369 * symfile.c (auto_solib_add): Likewise.
370 (separate_debug_file_debug): Likewise.
371 * symfile.h (auto_solib_add): Likewise.
372 (separate_debug_file_debug): Likewise.
373 * symtab.c (basenames_may_differ): Likewise.
374 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
375 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
376 (struct info_types_options) <quiet>: Likewise.
377 * symtab.h (demangle): Likewise.
378 (basenames_may_differ): Likewise.
379 * target-dcache.c (stack_cache_enabled_1): Likewise.
380 (code_cache_enabled_1): Likewise.
381 * target.c (trust_readonly): Likewise.
382 (may_write_registers): Likewise.
383 (may_write_memory): Likewise.
384 (may_insert_breakpoints): Likewise.
385 (may_insert_tracepoints): Likewise.
386 (may_insert_fast_tracepoints): Likewise.
387 (may_stop): Likewise.
388 (auto_connect_native_target): Likewise.
389 (target_stop_and_wait): Update.
390 (target_async_permitted): Change to bool.
391 (target_async_permitted_1): Likewise.
392 (may_write_registers_1): Likewise.
393 (may_write_memory_1): Likewise.
394 (may_insert_breakpoints_1): Likewise.
395 (may_insert_tracepoints_1): Likewise.
396 (may_insert_fast_tracepoints_1): Likewise.
397 (may_stop_1): Likewise.
398 * target.h (target_async_permitted): Likewise.
399 (may_write_registers): Likewise.
400 (may_write_memory): Likewise.
401 (may_insert_breakpoints): Likewise.
402 (may_insert_tracepoints): Likewise.
403 (may_insert_fast_tracepoints): Likewise.
404 (may_stop): Likewise.
405 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
406 (make_thread_apply_all_options_def_group): Change argument from int*
407 to bool*.
408 (thread_apply_all_command): Update.
409 (print_thread_events): Change to bool.
410 * top.c (confirm): Likewise.
411 (command_editing_p): Likewise.
412 (history_expansion_p): Likewise.
413 (write_history_p): Likewise.
414 (info_verbose): Likewise.
415 * top.h (confirm): Likewise.
416 (history_expansion_p): Likewise.
417 * tracepoint.c (disconnected_tracing): Likewise.
418 (circular_trace_buffer): Likewise.
419 * typeprint.c (print_methods): Likewise.
420 (print_typedefs): Likewise.
421 * utils.c (debug_timestamp): Likewise.
422 (sevenbit_strings): Likewise.
423 (pagination_enabled): Likewise.
424 * utils.h (sevenbit_strings): Likewise.
425 (pagination_enabled): Likewise.
426 * valops.c (overload_resolution): Likewise.
427 * valprint.h (struct value_print_options) <prettyformat_arrays,
428 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
429 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
430 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
431 Likewise.
432 * windows-nat.c (new_console): Likewise.
433 (cygwin_exceptions): Likewise.
434 (new_group): Likewise.
435 (debug_exec): Likewise.
436 (debug_events): Likewise.
437 (debug_memory): Likewise.
438 (debug_exceptions): Likewise.
439 (useshell): Likewise.
440 * windows-tdep.c (maint_display_all_tib): Likewise.
441 * xml-support.c (debug_xml): Likewise.
442
f1b620e9
MG
4432019-09-17 Mike Gulick <mgulick@mathworks.com>
444
445 * source.c (prepare_path_for_appending): New function.
446 (openp): Make use of new function.
447 (find_and_open_source): Search for the compilation directory and
448 source file as a relative path beneath the directory search path.
449
67f3ed6a
AB
4502019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
451
452 * source-cache.c (source_cache::get_line_charpos): Catch
453 exceptions and return false, this matches the behaviour documented
454 in the header file.
455
74332189
JB
4562019-09-17 Joel Brobecker <brobecker@adacore.com>
457
458 * ada-tasks.c (info_task): Remove quoting of the task's name.
459
f2f24aa9
CB
4602019-09-16 Christian Biesinger <cbiesinger@google.com>
461
462 * symfile.c (auto_solib_add): Replace comment with a reference
463 to the header file.
464
6a062a93
CB
4652019-09-14 Christian Biesinger <cbiesinger@google.com>
466
467 * NEWS: Mention that gdb can now be compiled with Python 3
468 on Windows.
469
ec6c8338
AB
4702019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
471
472 * maint.c (maint_print_section_data::maint_print_section_data):
473 Force use of 'float log10 (float)' by casting the argument to
474 float.
475
aa17805f
AB
4762019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
477
478 * maint.c: Add 'cmath' include.
479 (struct maint_print_section_data): New structure.
480 (print_section_index): New function.
481 (print_bfd_section_info): Add header comment, small whitespace
482 cleanup, and update to call new print_section_index function.
483 (print_objfile_section_info): Likewise.
484 (maint_obj_section_from_bfd_section): New function.
485 (print_bfd_section_info_maybe_relocated): New function.
486 (maintenance_info_sections): Add header comment, always use
487 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
488
3dd9bb46
AB
4892019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
490
491 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
492 inner scope, add check that the objfile has psymtabs before
493 checking psymtabs_addrmap.
494 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
495
4993045d
PW
4962019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
497
498 * NEWS: Announce that Ada task names are now shown at more places,
499 and between quotes (except in info task output).
500 * gdb/ada-tasks.c (task_to_str): New function.
501 (display_current_task_id): Call task_to_str.
502 (task_command_1): Likewise.
503 (print_ada_task_info): In non-mi mode, Properly align headers and data
504 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
505
7a289707
RO
5062019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
507
508 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
509 prstatus.pr_lwp.pr_info instead of making it up.
510
f2aec7f6
CB
5112019-09-11 Christian Biesinger <cbiesinger@google.com>
512
513 * auto-load.c (auto_load_expand_dir_vars): Update.
514 * defs.h (gdb_datadir): Change to std::string.
515 (python_libdir): Likewise.
516 (relocate_gdb_directory): Change return type to std::string.
517 * guile/guile.c (gdbscm_data_directory): Update.
518 (initialize_scheme_side): Update.
519 * jit.c (jit_reader_dir): Change to std::string.
520 (jit_reader_load_command): Update.
521 * main.c (gdb_datadir): Change to std::string.
522 (python_libdir): Likewise.
523 (set_gdb_data_directory): Update.
524 (relocate_path): Change to return std::string.
525 (relocate_gdb_directory): Change to return std::string.
526 (relocate_gdbinit_path_maybe_in_datadir): Update.
527 (captured_main_1): Update.
528 * python/python.c (do_start_initialization): Update.
529 * top.c (show_gdb_datadir): Update.
530 * xml-syscall.c (xml_init_syscalls_info): Update.
531 (init_syscalls_info): Update.
532
9224a013
CB
5332019-09-11 Christian Biesinger <cbiesinger@google.com>
534
535 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
536 out of get_init_files.
537 (get_init_files): Update.
538
f48cd836
CB
5392019-09-11 Christian Biesinger <cbiesinger@google.com>
540
541 * main.c (get_init_files): Change to use std::string.
542 (captured_main_1): Update.
543 (print_gdb_help): Update.
544
9cab7ecd
AT
5452019-09-11 Ali Tamur <tamur@google.com>
546
547 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
548 implementation.
549
67547d89
CB
5502019-09-11 Christian Biesinger <cbiesinger@google.com>
551
552 * dbxread.c (read_dbx_symtab): Update.
553 * dwarf2read.c (load_partial_dies): Update.
554 * mdebugread.c (parse_partial_symbols): Update.
555 (handle_psymbol_enumerators): Update.
556 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
557 * psymtab.c (add_psymbol_to_bcache): Likewise.
558 (add_psymbol_to_list): Likewise.
559 * symtab.c (symbol_set_names): Likewise.
560 * symtab.h (symbol_set_names): Likewise.
561 * xcoffread.c (scan_xcoff_symtab): Update.
562
64b2d4a0
TT
5632019-09-11 Tom Tromey <tom@tromey.com>
564
565 * symfile-mem.c (symbol_file_add_from_memory): Use
566 bfd_set_filename.
567 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
568 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
569
3b00ef10
TT
5702019-09-10 Tom Tromey <tromey@adacore.com>
571
572 * dwarf-index-write.c (write_psymbols): Extend error message.
573 (debug_names::insert): Add Ada code.
574 (debug_names::write_psymbols): Remove Ada check.
575 (debug_names) <m_string_obstack>: New member.
576 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
577 (gdb_index_symbol_name_matcher::matches): Remove.
578 (mapped_index_base::find_name_components_bounds): Add "lang"
579 parameter.
580 (mapped_index_base::build_name_components): Also split names
581 according to Ada syntax.
582 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
583 type of "match_callback".
584 (check_match, check_find_bounds_finds)
585 (dw2_expand_symtabs_matching): Update.
586 (dw2_debug_names_iterator): Add new constructor.
587 (dw2_debug_names_map_matching_symbols): New function.
588 (dw2_debug_names_expand_symtabs_matching): Update.
589 (dwarf2_debug_names_functions): Use
590 dw2_debug_names_map_matching_symbols.
591
aa391654
TT
5922019-09-10 Tom Tromey <tromey@adacore.com>
593
594 * dwarf2read.c (dw2_get_file_names_reader): Add the
595 CU's file name to the results.
596
b054970d
TT
5972019-09-10 Tom Tromey <tromey@adacore.com>
598
599 * ada-lang.c (add_nonlocal_symbols): Combine calls to
600 map_matching_symbols. Update.
601 * dwarf2read.c (dw2_map_matching_symbols): Update.
602 * psymtab.c (match_partial_symbol): Change type; update.
603 (psym_map_matching_symbols): Likewise.
604 * symfile-debug.c (debug_qf_map_matching_symbols): Change
605 type; update.
606 * symfile.h (struct quick_symbol_functions)
607 <map_matching_symbols>: Change "name" to be a lookup_name_info.
608 Remove "match".
609
6a3dbf1b
TT
6102019-09-10 Tom Tromey <tromey@adacore.com>
611
612 * psymtab.c (map_block): Remove.
613 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
614 * symtab.c (iterate_over_symbols_terminated): New function.
615 * symtab.c (iterate_over_symbols_terminated): Declare.
616
6969f124
TT
6172019-09-10 Tom Tromey <tromey@adacore.com>
618
619 * ada-lang.c (ada_iterate_over_symbols): Return bool.
620 * language.h (struct language_defn) <la_iterate_over_symbols>:
621 Return bool.
622 * symtab.c (iterate_over_symbols): Return bool.
623 * symtab.h (iterate_over_symbols): Return bool.
624
199b4314
TT
6252019-09-10 Tom Tromey <tromey@adacore.com>
626
627 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
628 (add_nonlocal_symbols): Update.
629 * dwarf2read.c (dw2_map_matching_symbols): Change type.
630 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
631 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
632 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
633 Change type of "callback". Remove "data".
634
a084a2a6
AT
635
6362019-09-09 Ali Tamur <tamur@google.com>
637
638 * dwarf2read.c (comp_unit_head): Update comment.
639 (dwarf2_dwo_name): New function declaration.
640 (dwarf_unit_type_name): New function declaration.
641 (read_comp_unit_head): Add support for new compilation units,
642 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
643 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
644 (currently named as "signature") in their header. Also clarify error
645 messages.
646 (lookup_dwo_id): New function. Returns the dwo id of the given
647 compile unit.
648 (lookup_dwo_unit): Use the new lookup_dwo_id function.
649 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
650 functions.
651 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
652 (dwarf2_dwo_name): Get the dwo name if present.
653 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
654 purposes.
655
25a2915e
TT
6562019-09-09 Tom Tromey <tom@tromey.com>
657
658 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
659
e4df0874
PW
6602019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
661
662 * python/python.c (do_start_initialization): Make progname_copy static,
663 to avoid a leak report.
664
8634b462
TT
6652019-09-08 Tom Tromey <tom@tromey.com>
666
667 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
668
c7f839cb
SM
6692019-09-07 Simon Marchi <simon.marchi@efficios.com>
670
671 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
672 Change type to gdb::optional<block_enum>.
673 (dw2_symtab_iter_init): Change block_index parameter type
674 to gdb::optional<block_enum>.
675 (dw2_lookup_symbol): Change block_index parameter
676 type to block_enum.c
677 (dw2_debug_names_lookup_symbol): Likewise.
678 * psymtab.c (psym_lookup_symbol): Likewise.
679 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
680 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
681 Likewise.
682
ead0e69a
CB
6832019-09-06 Christian Biesinger <cbiesinger@google.com>
684
685 * defs.h (relocate_gdb_directory): Change int to bool in
686 signature and rename flag to relocatable.
687 * main.c (relocate_path): Likewise.
688 (relocate_gdb_directory): Likewise.
689
b16c44de
AM
6902019-09-06 Alan Modra <amodra@gmail.com>
691
692 * coffread.c (coff_symfile_read): Constify filename variable.
693 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
694 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
695 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
696 * solib.c (reload_shared_libraries_1): Likewise.
697 * symfile.c (reread_symbols): Likewise.
698 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
699 * solib-darwin.c (darwin_bfd_open): Likewise.
700 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
701
06ff036e
AB
7022019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
703
704 * psymtab.c (print_partial_symbols): Handle missing domain_enum
705 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
706
4e962e74
TT
7072019-09-03 Tom Tromey <tromey@adacore.com>
708
709 * ada-valprint.c (ada_val_print_num): Don't recurse for range
710 types.
711 (has_negatives): Unbias a range type bound.
712 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
713 * gdbtypes.c (operator==): Handle new field.
714 (create_range_type): Add "bias" parameter.
715 (create_static_range_type, resolve_dynamic_range): Update.
716 * gdbtypes.h (struct range_bounds) <bias>: New member.
717 (create_range_type): Add bias parameter.
718 * printcmd.c (print_scalar_formatted): Unbias range types.
719 * value.c (unpack_long): Unbias range types.
720 (pack_long): Bias range types.
721
d90b8f26
AH
7222019-09-02 Alan Hayward <alan.hayward@arm.com>
723
724 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
725 probe arguments.
726
fe01123e
AH
7272019-09-02 Alan Hayward <alan.hayward@arm.com>
728
729 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
730 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
731 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
732 (compile_probe_arg): Likewise.
733 * probe.h (get_argument_count): Likewise.
734 * solib-svr4.c (solib_event_probe_action): Likewise.
735 * stap-probe.c (stap_probe::get_argument_count): Likewise.
736
e661ef01
AH
7372019-09-02 Alan Hayward <alan.hayward@arm.com>
738
739 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
740 code to here...
741 (svr4_create_solib_event_breakpoints): ...from here.
742
47a536d9
SDJ
7432019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
744
745 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
746 suffix from warning message.
747
d6a00eba
TT
7482019-08-30 Tom Tromey <tom@tromey.com>
749
750 * tui/tui-winsource.h (struct tui_source_window_base)
751 <refresh_all>: Don't declare.
752 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
753 Remove.
754 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
755 tui_show_locator_content.
756 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
757 declare.
758 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
759 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
760 declare.
761
55b2657b
TT
7622019-08-30 Tom Tromey <tom@tromey.com>
763
764 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
765
12a8555a
TT
7662019-08-30 Tom Tromey <tom@tromey.com>
767
768 * tui/tui-stack.c (_initialize_tui_stack): Move later.
769 Remove unnecessary forward declarations.
770
900ac242
TT
7712019-08-30 Tom Tromey <tom@tromey.com>
772
773 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
774 rerender.
775 (tui_update_locator_fullname, tui_show_frame_info): Don't call
776 tui_show_locator_content.
777
99ab33fb
TT
7782019-08-30 Tom Tromey <tom@tromey.com>
779
780 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
781 (tui_locator_window::rerender): Rewrite using body of previous
782 tui_show_locator_content.
783
e594a5d1
TT
7842019-08-30 Tom Tromey <tom@tromey.com>
785
786 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
787 set_locator_fullname>: New methods.
788 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
789 Rename from tui_set_locator_fullname.
790 (tui_locator_window::set_locator_info): Rename from
791 tui_set_locator_info. Return bool.
792 (tui_update_locator_fullname, tui_show_frame_info): Update.
793
715bb467
TT
7942019-08-30 Tom Tromey <tom@tromey.com>
795
796 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
797
772f3f03
TT
7982019-08-30 Tom Tromey <tom@tromey.com>
799
800 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
801 call touchwin.
802
108e13ab
TT
8032019-08-30 Tom Tromey <tom@tromey.com>
804
805 * tui/tui-wingeneral.c (box_win): Assume win_info and
806 win_info->handle cannot be NULL.
807
cdaa6eb4
TT
8082019-08-30 Tom Tromey <tom@tromey.com>
809
810 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
811 refresh_window>: Declare.
812 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
813 resize.
814 (tui_data_item_window::rerender): Rename from
815 tui_display_register.
816 (tui_data_item_window::refresh_window): New method.
817 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
818 no-op.
819
89df7f90
TT
8202019-08-30 Tom Tromey <tom@tromey.com>
821
822 * tui/tui-regs.h (struct tui_data_window) <regs_content,
823 regs_column_count, current_group>: Move later. Now private.
824 <get_current_group>: New method.
825 * tui/tui-regs.c (tui_reg_command): Update.
826 * tui/tui-layout.c (tui_set_layout): Update.
827
1bf2866a
TT
8282019-08-30 Tom Tromey <tom@tromey.com>
829
830 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
831 (tui_data_window::rerender): Don't call
832 check_and_display_highlight_if_needed.
833 (tui_data_window::refresh_all): Remove call to
834 erase_data_content.
835
0670413d
TT
8362019-08-30 Tom Tromey <tom@tromey.com>
837
838 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
839 (tui_data_window::display_registers_from)
840 (tui_data_window::display_reg_element_at_line)
841 (tui_data_window::display_registers_from_line): Remove checks of
842 "empty".
843
18bb55c7
TT
8442019-08-30 Tom Tromey <tom@tromey.com>
845
846 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
847 Don't declare.
848 * tui/tui-regs.c (tui_data_window::show_registers): Call
849 rerender.
850 (tui_data_window::rerender): Rename from display_all_data.
851 (tui_data_window::rerender): Remove old implementation.
852
1f6d2f10
TT
8532019-08-30 Tom Tromey <tom@tromey.com>
854
855 * tui/tui-regs.c (tui_data_window::display_all_data): Change
856 text.
857 * tui/tui-data.h (NO_DATA_STRING): Remove define.
858
16d01f9c
BW
8592019-08-29 Bernhard Wodok <barto@gmx.net>
860 Sergio Durigan Junior <sergiodj@redhat.com>
861
862 PR win32/24284
863 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
864
d8f27c60
AB
8652019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
866
867 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
868 when searching for types.
869
1f20c35e
AB
8702019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
871
872 * f-lang.c (f_language_defn): Use f_print_typedef.
873 * f-lang.h (f_print_typedef): Declare.
874 * f-typeprint.c (f_print_typedef): Define.
875
550105b7
CB
8762019-08-27 Christian Biesinger <cbiesinger@google.com>
877
878 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
879
4acfdd20
AB
8802019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
881
882 * cli/cli-utils.c (info_print_options_defs): Delete.
883 (make_info_print_options_def_group): Delete.
884 (extract_info_print_options): Delete.
885 (info_print_command_completer): Delete.
886 (info_print_args_help): Add extra parameter, and optionally
887 include text about -n flag.
888 * cli/cli-utils.h (struct info_print_options): Delete.
889 (extract_info_print_options): Delete declaration.
890 (info_print_command_completer): Delete declaration.
891 (info_print_args_help): Add extra parameter, extend header
892 comment.
893 * python/python.c (gdbpy_rbreak): Pass additional parameter to
894 search_symbols.
895 * stack.c (struct info_print_options): New type.
896 (info_print_options_defs): New file scoped variable.
897 (make_info_print_options_def_group): New static function.
898 (info_print_command_completer): New static function.
899 (info_locals_command): Update to use new local functions.
900 (info_args_command): Likewise.
901 (_initialize_stack): Add extra parameter to calls to
902 info_print_args_help.
903 * symtab.c (search_symbols): Add extra parameter, use this to
904 possibly excluse non-debug symbols.
905 (symtab_symbol_info): Add extra parameter, which is passed on to
906 search_symbols.
907 (struct info_print_options): New type.
908 (info_print_options_defs): New file scoped variable.
909 (make_info_print_options_def_group): New static function.
910 (info_print_command_completer): New static function.
911 (info_variables_command): Update to use local functions, and pass
912 extra parameter through to symtab_symbol_info.
913 (info_functions_command): Likewise.
914 (info_types_command): Pass additional argument through to
915 symtab_symbol_info.
916 (rbreak_command): Pass extra argument to search_symbols.
917 (_initialize_symtab): Add extra arguments for calls to
918 info_print_args_help, and update help text for 'info variables',
919 'whereis', and 'info functions' commands.
920 * symtab.h (search_symbols): Add extra argument to declaration.
921 * NEWS: Mention new flags.
922
9aa55206
CB
9232019-08-26 Christian Biesinger <cbiesinger@google.com>
924
925 * symtab.c (lookup_static_symbol): Call the new function (and move
926 it down to be next to lookup_global_symbol).
927 (struct global_sym_lookup_data): Add block_enum member and rename to...
928 (struct global_or_static_sym_lookup_data): ...this.
929 (lookup_symbol_global_iterator_cb): Pass block_index instead of
930 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
931 (lookup_symbol_global_or_static_iterator_cb): ...this.
932 (lookup_global_or_static_symbol): New function.
933 (lookup_global_symbol): Call new function.
934
5c31b358
TV
9352019-08-26 Tom de Vries <tdevries@suse.de>
936
937 PR c++/24852
938 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
939 when pc_probe.prob == NULL.
940
23c13d42
SM
9412019-08-25 Simon Marchi <simon.marchi@efficios.com>
942
943 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
944 variable symbol_linkage to symbol_linkage_.
945
beadd3e8
SM
9462019-08-25 Simon Marchi <simon.marchi@efficios.com>
947
948 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
949 represent whether the symbol is static, dynamic, or we don't
950 know.
951
e3ec872f
YS
9522019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
953
954 * gdb/rx-tdep.c (rx_register_names): New.
955 (rx_register_name): Delete.
956 (rx_psw_type): Delete.
957 (rx_fpsw_type): Delete.
958 (rx_register_type): Delete.
959 (rx_gdbarch_init): Convert target-descriptions.
960 (_initialize_rx_tdep): Add initialize_tdesc_rx.
961 * gdb/features/Makefile: Add rx.xml.
962 * gdb/features/rx.xml: New.
963 * gdb/features/rx.c: Generated.
964 * gdb/NEWS: Mention target description support.
965
d0509ba4
CB
9662019-08-22 Christian Biesinger <cbiesinger@google.com>
967
968 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
969 *slot_ptr.
970
2d41fa11
SDJ
9712019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
972
973 * configure.ac: Don't check for 'dlfcn.h' (moved to
974 gdbsupport/common.m4).
975 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
976 'gdbsupport/'.
977 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
978 * compile/compile-c-support.c: Include
979 'gdbsupport/gdb-dlfcn.h'.
980 * gdbsupport/common.m4: Check for 'dlfcn.h'.
981 * gdb-dlfcn.c: Move to...
982 * gdbsupport/gdb-dlfcn.c: ... here.
983 * gdb-dlfcn.h: Move to...
984 * gdbsupport/gdb-dlfcn.h: ... here.
985
de8af808
SL
9862019-08-23 Sandra Loosemore <sandra@codesourcery.com>
987
988 * nios2-tdep.c (struct reg_value): Improve comments. Make
989 the offset field signed.
990
27204489
CB
9912019-08-22 Christian Biesinger <cbiesinger@google.com>
992
993 * python/lib/gdb/__init__.py (_execute_file): New function.
994 * python/python.c (python_run_simple_file): Call gdb._execute_file
995 on Windows.
996
43771869
AB
9972019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
998
999 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1000 all uses as this was never set to anything but a zero value.
1001
26c957f1
PA
10022019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1003
1004 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1005
c07aae6e
CB
10062019-08-21 Christian Biesinger <cbiesinger@google.com>
1007
1008 * tui/tui-data.h (tui_gen_win_info): Add an =default
1009 move constructor, required by some GCC versions.
1010
3960cb7a
JF
10112019-08-21 Jinke Fan <fanjinke51@yeah.net>
1012
1013 * go32-nat.c (go32_sysinfo): Add hygon_p.
1014
04c72a68
TT
10152019-08-20 Tom Tromey <tom@tromey.com>
1016
1017 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1018 line_from_reg_element_no, first_reg_element_no_inline,
1019 display_all_data, delete_data_content_windows,
1020 erase_data_content>: Now private.
1021
072272ce
TT
10222019-08-20 Tom Tromey <tom@tromey.com>
1023
1024 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1025 (tui_unhighlight_win, tui_highlight_win)
1026 (tui_win_info::make_window): Update.
1027 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1028
973961bd
TT
10292019-08-20 Tom Tromey <tom@tromey.com>
1030
1031 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1032 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1033 (MAX_PID_WIDTH): Move to tui-stack.c.
1034 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1035 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1036 (MAX_PID_WIDTH): Move from tui-data.h.
1037
ab0e1f1a
TT
10382019-08-20 Tom Tromey <tom@tromey.com>
1039
1040 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1041 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1042 (box_win): Update.
1043 (tui_gen_win_info::make_window): Rename from tui_make_window.
1044 (tui_win_info::make_window): New method.
1045 (tui_gen_win_info::make_visible): Update.
1046 * tui/tui-source.c (tui_source_window::set_contents): Update.
1047 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1048 (tui_data_window::display_registers_from): Update.
1049 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1050 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1051 Declare.
1052 <can_box>: Remove.
1053 <title>: Remove.
1054 (struct tui_win_info) <make_window>: Declare.
1055 <can_box>: Now virtual.
1056 <title>: New member.
1057 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1058 * tui/tui-command.c (tui_cmd_window::resize): Update.
1059
100c2bf3
TT
10602019-08-20 Tom Tromey <tom@tromey.com>
1061
1062 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1063 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1064 (tui_data_window::check_register_values): Update.
1065
fa4dc567
TT
10662019-08-20 Tom Tromey <tom@tromey.com>
1067
1068 * tui/tui-regs.h (struct tui_data_window): Use
1069 DISABLE_COPY_AND_ASSIGN.
1070 <regs_content>: Change type, removing unique_ptr.
1071 <tui_data_window>: Add move constructor.
1072 * tui/tui-regs.c (tui_data_window::show_registers)
1073 (tui_data_window::show_register_group)
1074 (tui_data_window::display_registers_from)
1075 (tui_data_window::display_registers_from)
1076 (tui_data_window::first_data_item_displayed)
1077 (tui_data_window::delete_data_content_windows)
1078 (tui_data_window::rerender, tui_data_window::refresh_window)
1079 (tui_data_window::check_register_values): Update.
1080
ca02d7c8
TT
10812019-08-20 Tom Tromey <tom@tromey.com>
1082
1083 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1084 show_register_group>: Declare.
1085 (tui_show_register_group): Don't declare.
1086 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1087 tui_show_registers.
1088 (tui_data_window::show_register_group): Rename from
1089 tui_show_register_group.
1090 (tui_data_window::check_register_values, tui_reg_command):
1091 Update.
1092 * tui/tui-layout.c (tui_set_layout): Update.
1093
63356bfd
TT
10942019-08-20 Tom Tromey <tom@tromey.com>
1095
1096 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1097 Declare.
1098 (tui_check_register_values): Don't declare.
1099 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1100 from tui_check_register_values.
1101 * tui/tui-hooks.c (tui_register_changed): Update.
1102
42cc14a7
TT
11032019-08-20 Tom Tromey <tom@tromey.com>
1104
1105 * tui/tui-regs.c (tui_reg_layout): Move later.
1106 (tui_show_registers): Don't enable TUI mode or change layout.
1107
b9ad3686
TT
11082019-08-20 Tom Tromey <tom@tromey.com>
1109
1110 * tui/tui-regs.h (struct tui_data_item_window)
1111 <~tui_data_item_window>: Remove.
1112 <content>: Now a unique_xmalloc_ptr.
1113 * tui/tui-regs.c (tui_register_format): Return a
1114 unique_xmalloc_ptr.
1115 (tui_get_register): Update.
1116 (~tui_data_item_window): Remove.
1117 (tui_data_window::display_registers_from, tui_display_register):
1118 Update.
1119 * tui/tui-io.h (tui_expand_tabs): Update.
1120 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1121 Remove "col" parameter.
1122
8e114aab
TT
11232019-08-20 Tom Tromey <tom@tromey.com>
1124
1125 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1126 field.
1127 * tui/tui-regs.c (~tui_data_item_window): Update.
1128
1a4f81dd
TT
11292019-08-20 Tom Tromey <tom@tromey.com>
1130
1131 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1132 earlier.
1133
0f8d8876
TT
11342019-08-20 Tom Tromey <tom@tromey.com>
1135
1136 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1137
605dc2c2
TT
11382019-08-20 Tom Tromey <tom@tromey.com>
1139
1140 * tui/tui-source.h (struct tui_source_window): Update.
1141 * tui/tui-regs.c (tui_show_registers): Update.
1142 * tui/tui-disasm.h (struct tui_disasm_window): Update.
1143 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1144 (NO_REGS_STRING): Remove defines.
1145
aedbe3bb
CM
11462019-08-20 Conrad Meyer <cem@FreeBSD.org>
1147
1148 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1149 unnecessary thread walk if remote doesn't support the packet.
1150
7ce8f214
TT
11512019-08-19 Tom Tromey <tromey@adacore.com>
1152
1153 * python/py-value.c (value_has_field): Fix indentation.
1154
f21c2bd7
TT
11552019-08-19 Tom Tromey <tromey@adacore.com>
1156
1157 * printcmd.c (do_one_display, info_display_command): Update.
1158 * block.h (contained_in): Return bool. Add allow_nested
1159 parameter.
1160 * block.c (contained_in): Return bool. Add allow_nested
1161 parameter.
1162
d806ea2d
TT
11632019-08-19 Tom Tromey <tom@tromey.com>
1164
1165 * configure: Rebuild.
1166 * configure.ac: Disallow the combination of -static-libstdc++ and
1167 source highlight.
1168 * source-cache.c (get_language_name): Handle rust.
1169 (source_cache::get_source_lines): Ignore highlighting exceptions.
1170
398fdd60
TT
11712019-08-16 Tom Tromey <tom@tromey.com>
1172
1173 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1174 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1175 (struct tui_source_window_base) <make_visible, refresh_window,
1176 resize>: Remove methods.
1177 <execution_info>: Remove field.
1178 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1179 (tui_show_source_line, tui_source_window_base)
1180 (~tui_source_window_base): Update.
1181 (tui_source_window_base::resize)
1182 (tui_source_window_base::make_visible)
1183 (tui_source_window_base::refresh_window): Remove.
1184 (tui_source_window_base::update_exec_info): Update.
1185 * tui/tui-source.c (tui_source_window::set_contents): Update.
1186 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1187
e699d331
TT
11882019-08-16 Tom Tromey <tom@tromey.com>
1189
1190 * tui/tui-hooks.c (tui_remove_hooks): Don't set
1191 deprecated_query_hook.
1192
bb01dbfc
TT
11932019-08-16 Tom Tromey <tom@tromey.com>
1194
1195 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1196 (tui_update_source_windows_with_line): Update.
1197 * tui/tui-source.h (struct tui_source_window)
1198 <show_symtab_source>: Declare.
1199 (tui_show_symtab_source): Don't declare.
1200 * tui/tui-source.c (tui_show_symtab_source): Rename from
1201 tui_show_symtab_source.
1202
81c82c4b
TT
12032019-08-16 Tom Tromey <tom@tromey.com>
1204
1205 * tui/tui-winsource.h (struct tui_source_window_base)
1206 <set_contents>: Declare.
1207 * tui/tui-winsource.c
1208 (tui_source_window_base::update_source_window_as_is): Update.
1209 * tui/tui-source.h (struct tui_source_window) <set_contents>:
1210 Declare.
1211 (tui_set_source_content): Don't declare.
1212 * tui/tui-source.c (tui_source_window::set_contents): Rename from
1213 tui_set_source_content.
1214 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1215 Declare.
1216 (tui_set_disassem_content): Don't declare.
1217 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1218 tui_set_disassem_content.
1219
2ddaf614
TT
12202019-08-16 Tom Tromey <tom@tromey.com>
1221
1222 * tui/tui-winsource.h (struct tui_source_window_base)
1223 <update_breakpoint_info>: Declare.
1224 (tui_update_breakpoint_info): Don't declare.
1225 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1226 (tui_update_all_breakpoint_info): Update.
1227 (tui_source_window_base::update_breakpoint_info): Rename from
1228 tui_update_breakpoint_info.
1229 (tui_source_window_base::update_exec_info): Update.
1230
017f9828
TT
12312019-08-16 Tom Tromey <tom@tromey.com>
1232
1233 * tui/tui-winsource.h (struct tui_source_window_base)
1234 <update_source_window>: Declare.
1235 (tui_update_source_window): Don't declare.
1236 * tui/tui-winsource.c
1237 (tui_source_window_base::update_source_window): Rename from
1238 tui_update_source_window.
1239 (tui_source_window_base::rerender): Update.
1240 * tui/tui-source.c (tui_source_window::maybe_update): Update.
1241 * tui/tui-disasm.c (tui_show_disassem)
1242 (tui_show_disassem_and_update_source)
1243 (tui_disasm_window::maybe_update): Update.
1244
ed8358e9
TT
12452019-08-16 Tom Tromey <tom@tromey.com>
1246
1247 * tui/tui-winsource.h (struct tui_source_window_base)
1248 <update_source_window_as_is>: Declare.
1249 (tui_update_source_window_as_is): Don't declare.
1250 * tui/tui-winsource.c (tui_update_source_window): Update
1251 (tui_source_window_base::update_source_window_as_is): Rename from
1252 tui_update_source_window_as_is.
1253 (tui_source_window_base::refill): Update.
1254 * tui/tui-source.c (tui_show_symtab_source): Update.
1255 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1256 Update.
1257
20149b6b
TT
12582019-08-16 Tom Tromey <tom@tromey.com>
1259
1260 * tui/tui-winsource.h (tui_update_source_window)
1261 (tui_update_source_window_as_is): Remove "noerror" parameter.
1262 * tui/tui-winsource.c (tui_update_source_window)
1263 (tui_update_source_window_as_is): Remove "noerror" parameter.
1264 (tui_update_source_windows_with_addr)
1265 (tui_update_source_windows_with_line)
1266 (tui_source_window_base::rerender)
1267 (tui_source_window_base::refill): Update.
1268 * tui/tui-source.h (tui_set_source_content)
1269 (tui_show_symtab_source): Remove "noerror" parameter.
1270 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1271 parameter.
1272 (tui_show_symtab_source): Likewise.
1273 (tui_source_window::maybe_update): Update.
1274 * tui/tui-disasm.c (tui_show_disassem)
1275 (tui_show_disassem_and_update_source)
1276 (tui_disasm_window::do_scroll_vertical)
1277 (tui_disasm_window::maybe_update): Update.
1278
2d83e710
TT
12792019-08-16 Tom Tromey <tom@tromey.com>
1280
1281 * tui/tui.c (tui_is_window_visible): Update.
1282 * tui/tui-wingeneral.c (tui_make_window)
1283 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1284 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1285 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1286 (tui_set_win_height_command, parse_scrolling_args): Update.
1287 * tui/tui-source.c (tui_source_window::style_changed): Update.
1288 * tui/tui-regs.c (tui_show_registers)
1289 (tui_data_window::first_data_item_displayed)
1290 (tui_data_window::delete_data_content_windows)
1291 (tui_check_register_values, tui_reg_command): Update.
1292 * tui/tui-disasm.c (tui_show_disassem): Update.
1293 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1294 method.
1295 <is_visible>: Remove field.
1296 * tui/tui-data.c (tui_next_win, tui_prev_win)
1297 (tui_delete_invisible_windows): Update.
1298
d4ab829a
TT
12992019-08-16 Tom Tromey <tom@tromey.com>
1300
1301 * tui/tui-winsource.h (struct tui_source_window_base)
1302 <m_has_locator>: Remove.
1303 * tui/tui-layout.c (show_source_disasm_command, show_data)
1304 (show_source_or_disasm_and_command): Update.
1305
aa7ca1bb
AH
13062019-08-16 Alan Hayward <alan.hayward@arm.com>
1307
1308 * NEWS (Other MI changes): New subsection.
1309 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1310 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1311 * arch-utils.c (default_get_pc_address_flags): New function.
1312 * arch-utils.h (default_get_pc_address_flags): New declaration.
1313 * gdbarch.sh: Add get_pc_address_flags.
1314 * gdbarch.c: Regenerate.
1315 * gdbarch.h: Likewise.
1316 * stack.c (print_pc): New function.
1317 (print_frame_info) (print_frame): Call print_pc.
1318
6eac171f
TV
13192019-08-16 Tom de Vries <tdevries@suse.de>
1320
1321 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1322 print_objfile_section_info.
1323
3df505f6
TT
13242019-08-15 Tom Tromey <tom@tromey.com>
1325
1326 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1327 calling update_cmdwin_start_line.
1328 * tui/tui-winsource.h (struct tui_source_window_base)
1329 <do_make_visible_with_new_height, set_new_height>: Don't declare.
1330 <rerender>: Declare.
1331 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1332 Call rerender.
1333 (tui_source_window_base::set_new_height): Remove.
1334 (tui_source_window_base::rerender): Rename from
1335 do_make_visible_with_new_height.
1336 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1337 resize method.
1338 (tui_win_info::make_invisible_and_set_new_height)
1339 (tui_win_info::make_visible_with_new_height): Remove.
1340 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1341 Declare.
1342 * tui/tui-stack.c (tui_locator_window::rerender): New method.
1343 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1344 do_make_visible_with_new_height>: Don't declare.
1345 <rerender>: Declare.
1346 * tui/tui-regs.c (tui_data_window::rerender): Rename from
1347 set_new_height.
1348 (tui_data_window::do_make_visible_with_new_height): Remove.
1349 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1350 call tui_show_locator_content.
1351 (tui_gen_win_info::resize): Call rerender.
1352 (show_source_or_disasm_and_command): Don't call
1353 tui_show_locator_content.
1354 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1355 method.
1356 (struct tui_win_info) <rerender>: Declare.
1357 <set_new_height, make_invisible_and_set_new_height,
1358 make_visible_with_new_height>: Don't declare.
1359 * tui/tui-data.c (tui_win_list::rerender): New method.
1360 * tui/tui-command.h (struct tui_cmd_window)
1361 <do_make_visible_with_new_height>: Don't declare.
1362 * tui/tui-command.c
1363 (tui_cmd_window::do_make_visible_with_new_height): Remove.
1364
272560b5
TT
13652019-08-15 Tom Tromey <tromey@adacore.com>
1366
1367 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1368 * ada-lang.c (ada_enum_name): Likewise.
1369
08235187
CB
13702019-08-15 Christian Biesinger <cbiesinger@google.com>
1371
1372 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1373 leading underscore.
1374 (GdbOutputErrorFile): Likewise.
1375 (global scope): Adjust constructor calls to GdbOutput{,Error}File
1376 accordingly.
1377 (execute_unwinders): Rename to have a leading underscore.
1378 (auto_load_packages): Likewise.
1379 (global scope): Adjust call to auto_load_packages accordingly.
1380 (GdbSetPythonDirectory): Likewise.
1381 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1382 instead of execute_unwinders.
1383
db502012
TT
13842019-08-15 Tom Tromey <tom@tromey.com>
1385
1386 * tui/tui-layout.c (show_layout, show_source_disasm_command)
1387 (show_data): Don't change window visibility.
1388 (tui_gen_win_info::resize): Remove special case for command
1389 window. Use wresize, when available.
1390 (show_source_or_disasm_and_command): Don't change window
1391 visibility.
1392 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1393 <make_visible>: New method.
1394 * tui/tui-command.c (tui_cmd_window::resize): New method.
1395
3891b65e
TT
13962019-08-15 Tom Tromey <tom@tromey.com>
1397
1398 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1399 (struct tui_source_windows): New.
1400 * tui/tui-winsource.c (tui_display_main): Update.
1401 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1402 (new_height_ok, parse_scrolling_args): Update.
1403 * tui/tui-layout.c (show_layout, show_data): Update.
1404 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1405 (tui_add_to_source_windows): Don't declare.
1406 * tui/tui-data.c (source_windows, tui_source_windows)
1407 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1408
ee556432
TT
14092019-08-15 Tom Tromey <tom@tromey.com>
1410
1411 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1412 Rename from reset.
1413 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1414 * tui/tui-layout.c (show_source_disasm_command, show_data):
1415 Update.
1416 (tui_gen_win_info::resize): Rename.
1417 (show_source_or_disasm_and_command): Update.
1418 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1419 reset.
1420
46f438e3
TT
14212019-08-15 Tom Tromey <tom@tromey.com>
1422
1423 * tui/tui-stack.c (tui_initialize_static_data): Remove.
1424 * tui/tui-interp.c (tui_interp::init): Don't call
1425 tui_initialize_static_data.
1426 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1427
f4ce562c
TT
14282019-08-15 Tom Tromey <tom@tromey.com>
1429
1430 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1431 examine tui_win_list.
1432
c398c3d0
TT
14332019-08-15 Tom Tromey <tom@tromey.com>
1434
1435 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1436 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1437 tui_clear_source_content.
1438 (tui_clear_source_content): Remove.
1439 (tui_source_window_base::do_erase_source_content): Hoist call to
1440 content.clear().
1441 * tui/tui-stack.c (tui_show_frame_info): Don't call
1442 tui_clear_source_content.
1443
e25d2004
TT
14442019-08-15 Tom Tromey <tom@tromey.com>
1445
1446 * tui/tui-winsource.h (struct tui_source_window_base)
1447 <do_erase_source_content>: New method.
1448 <erase_source_content>: New method.
1449 (tui_erase_source_content): Don't declare.
1450 * tui/tui-winsource.c (tui_clear_source_content): Update.
1451 (tui_source_window_base::do_erase_source_content): Rename from
1452 tui_erase_source_content.
1453 (tui_source_window_base::show_source_content): Update.
1454 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1455 * tui/tui-source.h (struct tui_source_window)
1456 <erase_source_content>: New method.
1457 * tui/tui-disasm.h (struct tui_disasm_window)
1458 <erase_source_content>: New method.
1459
002f15c2
TT
14602019-08-15 Tom Tromey <tom@tromey.com>
1461
1462 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1463 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1464 constructor.
1465 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1466 * tui/tui-source.c (tui_set_source_content): Update.
1467 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1468
c9033fe8
TT
14692019-08-15 Tom Tromey <tom@tromey.com>
1470
1471 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1472 * tui/tui-winsource.c (tui_line_is_displayed): Move to
1473 tui-source.c.
1474 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1475 Declare.
1476 * tui/tui-source.c (tui_source_window::line_is_displayed): New
1477 method.
1478 (tui_source_window::maybe_update): Update.
1479
088f37dd
TT
14802019-08-15 Tom Tromey <tom@tromey.com>
1481
1482 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1483 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1484 tui-disasm.c.
1485 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1486 Declare.
1487 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1488 method.
1489 (tui_disasm_window::maybe_update): Update.
1490
a54700c6
TT
14912019-08-15 Tom Tromey <tom@tromey.com>
1492
1493 * tui/tui-winsource.h (struct tui_source_window_base)
1494 <maybe_update>: Declare.
1495 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1496 method.
1497 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1498 Declare.
1499 * tui/tui-source.c (tui_source_window::maybe_update): New method.
1500 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1501 Declare.
1502 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1503
e2a678a5
TT
15042019-08-15 Tom Tromey <tom@tromey.com>
1505
1506 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1507
f2dda477
TT
15082019-08-15 Tom Tromey <tom@tromey.com>
1509
1510 * tui/tui-wingeneral.c: Include tui-stack.h.
1511 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1512 (struct tui_locator_window): Move from tui-data.h.
1513 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1514 (tui_initialize_static_data): Move from tui-data.c.
1515 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1516 (struct tui_locator_window): Move to tui-stack.c.
1517 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1518 (tui_initialize_static_data): Move to tui-stack.c.
1519
ed4a1084
TT
15202019-08-15 Tom Tromey <tom@tromey.com>
1521
1522 * tui/tui-layout.c (show_source_disasm_command)
1523 (show_source_or_disasm_and_command): Use make_visible method, not
1524 tui_make_window.
1525 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1526 Remove.
1527
65962b20
TT
15282019-08-15 Tom Tromey <tom@tromey.com>
1529
1530 * tui/tui-wingeneral.h (tui_make_window): Update.
1531 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1532 parameter.
1533 (tui_gen_win_info::make_visible): Update.
1534 * tui/tui-regs.c (tui_data_window::display_registers_from):
1535 Update.
1536 * tui/tui-layout.c (show_source_disasm_command)
1537 (show_source_or_disasm_and_command): Update.
1538 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1539 (enum tui_box): Remove.
1540 (struct tui_win_info) <can_box>: New method.
1541 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1542 method.
1543
2208ee91
TV
15442019-08-15 Tom de Vries <tdevries@suse.de>
1545
1546 * linux-nat-trad.c: Include gdbarch.h.
1547
75faf5c4
AH
15482019-08-14 Alan Hayward <alan.hayward@arm.com>
1549
1550 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1551 register sizes.
1552
b1c896b3
TT
15532019-08-14 Tom Tromey <tromey@adacore.com>
1554
1555 * darwin-nat.c: Include gdbarch.h.
1556 * darwin-nat-info.c: Include gdbarch.h.
1557
6405cd73
TT
15582019-08-13 Tom Tromey <tom@tromey.com>
1559
1560 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1561 Remove.
1562 * tui/tui-data.c (tui_initialize_static_data): Update.
1563
5216580d
TT
15642019-08-13 Tom Tromey <tom@tromey.com>
1565
1566 * tui/tui-winsource.h (struct tui_exec_info_window)
1567 <~tui_exec_info_window, maybe_allocate_content, get_content,
1568 m_content>: Remove.
1569 (struct tui_source_window_base) <set_exec_info_content,
1570 show_exec_info_content>: Don't declare.
1571 * tui/tui-winsource.c
1572 (tui_exec_info_window::maybe_allocate_content): Remove.
1573 (tui_source_window_base::update_exec_info): Rename from
1574 set_exec_info_content.
1575 (tui_source_window_base::show_exec_info_content)
1576 (tui_source_window_base::update_exec_info): Remove.
1577
93858ad3
TT
15782019-08-13 Tom Tromey <tom@tromey.com>
1579
1580 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1581 declare.
1582 * tui/tui-winsource.c (tui_update_source_window_as_is)
1583 (tui_update_source_windows_with_addr, tui_erase_source_content):
1584 Update.
1585 (tui_clear_exec_info_content): Remove.
1586
e321e7ce
TT
15872019-08-13 Tom Tromey <tom@tromey.com>
1588
1589 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1590 declare.
1591 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1592 call tui_erase_exec_info_content.
1593 (tui_clear_exec_info_content): Rename from
1594 tui_erase_exec_info_content.
1595 (tui_clear_exec_info_content): Delete.
1596
8270ac62
TT
15972019-08-13 Tom Tromey <tom@tromey.com>
1598
1599 * tui/tui-winsource.h (struct tui_source_window_base)
1600 <show_exec_info_content>: Declare.
1601 (tui_show_exec_info_content): Don't declare.
1602 * tui/tui-winsource.c
1603 (tui_source_window_base::show_exec_info_content): Rename from
1604 tui_show_exec_info_content.
1605 (tui_source_window_base::update_exec_info): Update.
1606
7b56485d
TT
16072019-08-13 Tom Tromey <tom@tromey.com>
1608
1609 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1610 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1611 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1612 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1613 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1614 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1615 ... here.
1616
7ba913dc
TT
16172019-08-13 Tom Tromey <tom@tromey.com>
1618
1619 * tui/tui-winsource.h (struct tui_source_window_base)
1620 <update_exec_info>: Declare.
1621 (tui_update_exec_info): Don't declare.
1622 * tui/tui-winsource.c (tui_update_source_window_as_is)
1623 (tui_source_window_base::refresh_all)
1624 (tui_update_all_breakpoint_info): Update.
1625 (tui_source_window_base::update_exec_info): Rename from
1626 tui_update_exec_info.
1627 * tui/tui-stack.c (tui_show_frame_info): Update.
1628
37a4a131
TT
16292019-08-13 Tom Tromey <tom@tromey.com>
1630
1631 * tui/tui-winsource.h (struct tui_source_window_base)
1632 <set_exec_info_content>: Declare.
1633 (tui_set_exec_info_content): Don't declare.
1634 * tui/tui-winsource.c
1635 (tui_source_window_base::set_exec_info_content): Rename from
1636 tui_set_exec_info_content.
1637 (tui_update_exec_info): Update.
1638
0bd27e07
TT
16392019-08-13 Tom Tromey <tom@tromey.com>
1640
1641 * tui/tui-winsource.h (struct tui_source_window_base)
1642 <show_source_content>: Declare.
1643 (tui_show_source_content): Don't declare.
1644 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1645 (tui_source_window_base::show_source_content): Rename from
1646 tui_show_source_content.
1647 (tui_source_window_base::refresh_all): Update.
1648 * tui/tui-layout.c (show_source_disasm_command)
1649 (show_source_or_disasm_and_command): Update.
1650
b4ef5aeb
TT
16512019-08-13 Tom Tromey <tom@tromey.com>
1652
1653 * tui/tui-winsource.c (tui_erase_source_content)
1654 (tui_show_source_content, tui_source_window_base::refresh_all):
1655 Update.
1656 * tui/tui-wingeneral.h
1657 (tui_check_and_display_highlight_if_needed): Don't declare.
1658 * tui/tui-wingeneral.c
1659 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1660 check_and_display_highlight_if_needed.
1661 * tui/tui-win.c (tui_rehighlight_all)
1662 (tui_win_info::make_visible_with_new_height): Update.
1663 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1664 (tui_data_window::erase_data_content)
1665 (tui_data_window::display_all_data): Update.
1666 * tui/tui-data.h (struct tui_win_info)
1667 <check_and_display_highlight_if_needed>: Declare.
1668
fede5273
TT
16692019-08-13 Tom Tromey <tom@tromey.com>
1670
1671 * tui/tui-win.c (tui_resize_all): Call
1672 tui_delete_invisible_windows.
1673 * tui/tui-layout.c (show_layout): Call
1674 tui_delete_invisible_windows.
1675 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1676 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1677
22c3f490
TT
16782019-08-13 Tom Tromey <tom@tromey.com>
1679
1680 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1681 tui_add_win_to_layout.
1682
16cb7910
TT
16832019-08-13 Tom Tromey <tom@tromey.com>
1684
1685 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1686 * tui/tui-layout.c (tui_default_win_height): Now static.
1687
cc0c3ffb
TT
16882019-08-13 Tom Tromey <tom@tromey.com>
1689
1690 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1691 single switch.
1692 (show_source_disasm_command, show_source_or_disasm_and_command):
1693 Don't check current layout.
1694
3f3ffe54
TT
16952019-08-13 Tom Tromey <tom@tromey.com>
1696
1697 * tui/tui-wingeneral.c (make_all_visible): Remove.
1698 (tui_make_all_invisible): Simplify.
1699 * tui/tui-layout.c (tui_make_all_invisible): Move from
1700 tui-wingeneral.c; simplify.
1701 (show_layout): Hoist call to tui_make_all_invisible.
1702 (show_data): Don't call tui_make_all_invisible.
1703
69258091
TT
17042019-08-13 Tom Tromey <tom@tromey.com>
1705
1706 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1707 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1708
62cf57fe
TT
17092019-08-13 Tom Tromey <tom@tromey.com>
1710
1711 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1712 tui-data.c.
1713 (show_source_disasm_command, show_data)
1714 (show_source_or_disasm_and_command): Don't use
1715 tui_set_current_layout_to.
1716 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1717 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1718 tui-layout.c.
1719 (tui_set_current_layout_to): Remove.
1720
2afade5d
TT
17212019-08-13 Tom Tromey <tom@tromey.com>
1722
1723 * tui/tui-layout.c (tui_set_layout): Update.
1724 * tui/tui-data.h (struct tui_layout_def): Remove.
1725 (tui_layout_def): Don't declare.
1726 * tui/tui-data.c (layout_def): Remove.
1727 (tui_layout_def): Remove.
1728
a3504e96
TT
17292019-08-13 Tom Tromey <tom@tromey.com>
1730
1731 * tui/tui-winsource.h (struct tui_source_window_base)
1732 <clear_detail>: No longer "override".
1733 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1734 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1735 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1736 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1737 Remove.
1738 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1739
29c92911
TT
17402019-08-13 Tom Tromey <tromey@adacore.com>
1741
1742 * tracepoint.c: Don't include readline.h or history.h.
1743
86c6b807
TT
17442019-08-12 Tom Tromey <tom@tromey.com>
1745
1746 * configure: Rebuild.
1747 * configure.ac: Check for readline 7.
1748 * NEWS: Mention readline 7 requirement.
1749 * README: Update.
1750
5db2718c
TT
17512019-08-12 Tom Tromey <tom@tromey.com>
1752
1753 * mingw-hdep.c (gdb_select): Remove readline hack.
1754
dac36daf
PFC
17552019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1756
1757 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1758 when the function fails.
1759
1022c627
AA
17602019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1761
1762 * s390-tdep.c (s390_type_align): New function.
1763 (s390_gdbarch_init): Set it as type_align gdbarch method.
1764
eba4caf2
TV
17652019-08-09 Tom de Vries <tdevries@suse.de>
1766
1767 PR gdb/24591
1768 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1769 pc_low with relocation offset.
1770
123cd851
TT
17712019-08-07 Tom Tromey <tromey@adacore.com>
1772
1773 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1774 (print_frame_args): Update.
1775 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1776 Update.
1777 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1778 * frame.h (struct frame_arg): Add initializers.
1779 <error>: Now a unique_xmalloc_ptr.
1780
3d31bc39
AH
17812019-08-07 Alan Hayward <alan.hayward@arm.com>
1782
1783 * NEWS: Expand the Pointer Authentication entry.
1784 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1785 (aarch64_frame_unmask_lr): ... to this.
1786 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1787 Call aarch64_frame_unmask_lr.
1788 * frame.c (struct frame_info): Add "masked" variable.
1789 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1790 (fprint_frame): Check for masked pc.
1791 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1792 declarations.
1793 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1794 * stack.c (print_frame): Check for masked pc.
1795
0cf9feb9
TT
17962019-08-06 Tom Tromey <tom@tromey.com>
1797
1798 * stabsread.c (patch_block_stabs, read_one_struct_field)
1799 (read_enum_type): Use obstack_strndup.
1800 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1801 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1802 * dwarf2read.c (guess_full_die_structure_name)
1803 (anonymous_struct_prefix): Use obstack_strndup.
1804 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1805 * c-exp.y (yylex): Use obstack_strndup.
1806 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1807 (write_var_or_type): Use obstack_strndup.
1808
efba19b0
TT
18092019-08-06 Tom Tromey <tom@tromey.com>
1810
1811 * symfile.c (reread_symbols): Use obstack_strdup.
1812 * stabsread.c (read_type): Use obstack_strdup.
1813 * gdb_obstack.h (obstack_strdup): New overload.
1814 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1815 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1816 (dwarf2_canonicalize_name): Use obstack_strdup.
1817 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1818 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1819 Use obstack_strdup.
1820
f25102f7
TT
18212019-08-06 Tom Tromey <tom@tromey.com>
1822
1823 * gdb_obstack.h (obstack_strdup): Define.
1824 * gdb_obstack.c (obstack_strdup): Don't define.
1825
021887d8
TT
18262019-08-06 Tom Tromey <tom@tromey.com>
1827
1828 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1829 obstack_strdup.
1830 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1831 obstack_strdup.
1832 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1833 * stabsread.c (common_block_start): Use obstack_strdup.
1834 * objfiles.c (set_objfile_main_name, objfile): Use
1835 obstack_strdup.
1836 * namespace.c (add_using_directive): Use obstack_strdup.
1837 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1838 * jit.c (finalize_symtab): Use obstack_strdup.
1839 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1840 (guess_partial_die_structure_name, partial_die_info::fixup)
1841 (dwarf2_name): Use obstack_strdup.
1842 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1843 obstack_strdup.
1844 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1845 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1846 obstack_strdup.
1847 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1848
d2834edc
PW
18492019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1850
1851 * unittests/help-doc-selftests.c: New file.
1852 * Makefile.in: Add the new file.
1853
590042fc
PW
18542019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1855
1856 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1857 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1858 the full first line, except when FOR_VALUE_PREFIX. In this case,
1859 the trailing '.' is not output, and the first character is uppercased.
1860 (print_help_for_command): Update call to print_doc_line.
1861 (print_doc_of_command): Likewise.
1862 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1863 * cli/cli-option.c (append_indented_doc): Do not append newline.
1864 (build_help_option): Append newline after first appended_indented_doc
1865 only if a second call is done.
1866 (build_help): Append 2 new lines before each option, except the first
1867 one.
1868 * compile/compile.c (_initialize_compile): Add new lines after
1869 %OPTIONS%, when not at the end of the help.
1870 Change help doc or code
1871 producing the help doc to respect the invariants.
1872 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1873 Also removed the new line after 'Options:', as all other commands
1874 do not put an empty line between 'Options:' and the first option.
1875 * printcmd.c (_initialize_printcmd): Likewise.
1876 * stack.c (_initialize_stack): Likewise.
1877 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1878 incorrectly telling COMMAND is optional.
1879 * ada-lang.c (_initialize_ada_language): Change help doc or code
1880 producing the help doc to respect the invariants.
1881 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1882 * breakpoint.c (_initialize_breakpoint): Likewise.
1883 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1884 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1885 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1886 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1887 _initialize_cli_style): Likewise.
1888 * corelow.c (core_target_info): Likewise.
1889 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1890 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1891 * filesystem.c (_initialize_filesystem): Likewise.
1892 * frame.c (_initialize_frame): Likewise.
1893 * gnu-nat.c (add_task_commands): Likewise.
1894 * infcall.c (_initialize_infcall): Likewise.
1895 * infcmd.c (_initialize_infcmd): Likewise.
1896 * interps.c (_initialize_interpreter): Likewise.
1897 * language.c (_initialize_language): Likewise.
1898 * linux-fork.c (_initialize_linux_fork): Likewise.
1899 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1900 * maint.c (_initialize_maint_cmds): Likewise.
1901 * memattr.c (_initialize_mem): Likewise.
1902 * printcmd.c (_initialize_printcmd): Likewise.
1903 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1904 _RegEx): Likewise.
1905 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1906 * record-btrace.c (_initialize_record_btrace): Likewise.
1907 * record-full.c (_initialize_record_full): Likewise.
1908 * record.c (_initialize_record): Likewise.
1909 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1910 * regcache.c (_initialize_regcache): Likewise.
1911 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1912 _initialize_remote): Likewise.
1913 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1914 * serial.c (_initialize_serial): Likewise.
1915 * skip.c (_initialize_step_skip): Likewise.
1916 * source.c (_initialize_source): Likewise.
1917 * stack.c (_initialize_stack): Likewise.
1918 * symfile.c (_initialize_symfile): Likewise.
1919 * symtab.c (_initialize_symtab): Likewise.
1920 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1921 * top.c (init_main): Likewise.
1922 * tracefile-tfile.c (tfile_target_info): Likewise.
1923 * tracepoint.c (_initialize_tracepoint): Likewise.
1924 * tui/tui-win.c (_initialize_tui_win): Likewise.
1925 * utils.c (add_internal_problem_command): Likewise.
1926 * valprint.c (value_print_option_defs): Likewise.
1927
404f2902
FCE
19282019-08-06 Frank Ch. Eigler <fche@redhat.com>
1929
1930 PR build/24886
1931 * configure.ac: Drop enable-libmcheck support.
1932 * configure, config.in: Rebuild.
1933 * libmcheck.m4: Remove.
1934 * acinclude.m4: Don't include it.
1935 * Makefile.in: Don't distribute it.
1936 * top.c (print_gdb_configuration): Don't mention it.
1937
046bebe1
TT
19382019-08-06 Tom Tromey <tom@tromey.com>
1939
1940 * utils.c (set_output_style): Sometimes pass stream to
1941 emit_style_escape.
1942 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1943 * record-btrace.c (btrace_insn_history): Update.
1944 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1945 method.
1946 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1947 Update initializers.
1948 <m_uiout>: New field.
1949 <m_di>: Move lower.
1950 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1951 Remove "uiout" parameter.
1952 (dump_insns): Update.
1953 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1954 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1955
ddbcedf5
CB
19562019-08-06 Christian Biesinger <cbiesinger@google.com>
1957
1958 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1959 (error_in_psymtab_expansion): Likewise.
1960 (lookup_symbol_via_quick_fns): Likewise.
1961 (basic_lookup_transparent_type_quick): Likewise.
1962 (basic_lookup_transparent_type_1): Likewise.
1963
b08b16c8
TT
19642019-08-06 Tom Tromey <tromey@adacore.com>
1965
1966 * source.c (last_source_error): Now bool.
1967 (print_source_lines_base): Make "noprint" bool. Only open
1968 source file when last_source_visited changes.
1969
cb44333d
TT
19702019-08-06 Tom Tromey <tromey@adacore.com>
1971
1972 * annotate.c (annotate_source_line): Use g_source_cache.
1973 * source-cache.c (source_cache::get_plain_source_lines): Change
1974 parameters. Populate m_offset_cache.
1975 (source_cache::ensure): New method.
1976 (source_cache::get_line_charpos): New method.
1977 (extract_lines): Move lower. Change parameters.
1978 (source_cache::get_source_lines): Move lower.
1979 * source-cache.h (class source_cache): Update comment.
1980 <get_line_charpos>: New method.
1981 <get_source_lines>: Update comment.
1982 <clear>: Clear m_offset_cache.
1983 <get_plain_source_lines>: Change parameters.
1984 <ensure>: New method
1985 <m_offset_cache>: New member.
1986 * source.c (forget_cached_source_info_for_objfile): Update.
1987 (info_source_command): Use g_source_cache.
1988 (find_source_lines, open_source_file_with_line_charpos): Remove.
1989 (print_source_lines_base, search_command_helper): Use g_source_cache.
1990 * source.h (open_source_file_with_line_charpos): Don't declare.
1991 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1992 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1993 Use g_source_cache.
1994
872dceaa
TT
19952019-08-06 Tom Tromey <tromey@adacore.com>
1996
1997 * source-cache.c (source_cache::get_plain_source_lines):
1998 Remove "first_line" and "last_line" parameters.
1999 (source_cache::get_source_lines): Cache plain text.
2000 * source-cache.h (class source_cache)
2001 <get_plain_source_lines>: Update.
2002
269249d9
TT
20032019-08-06 Tom Tromey <tromey@adacore.com>
2004
2005 * source-cache.c (extract_lines): No longer a method.
2006 Changed type of parameter. Include final newline.
2007 (selftests::extract_lines_test): New function.
2008 (_initialize_source_cache): Likewise.
2009 * source-cache.h (class source_cache)
2010 <extract_lines>: Don't declare.
2011
c0e8dcd8
TT
20122019-08-06 Tom Tromey <tromey@adacore.com>
2013
2014 * breakpoint.c (init_breakpoint_sal): Update.
2015 (breakpoint): Update.
2016 * breakpoint.h (struct breakpoint) <filter>: Now a
2017 unique_xmalloc_ptr.
2018
0b27c27d
CB
20192019-08-05 Christian Biesinger <cbiesinger@google.com>
2020
2021 * NEWS: Mention dictionary access on blocks.
2022 * python/py-block.c (blpy_getitem): New function.
2023 (block_object_as_mapping): New struct.
2024 (block_object_type): Use new struct for tp_as_mapping field.
2025
4ee94178
CB
20262019-08-05 Christian Biesinger <cbiesinger@google.com>
2027
2028 * objfiles.h (objfile): Add a comment describing partial symbols.
2029
8abfcabc
TT
20302019-08-05 Tom Tromey <tromey@adacore.com>
2031
2032 * compile/compile.c (_initialize_compile): Use _(), not N_().
2033 * thread.c (_initialize_thread): Use _(), not N_().
2034 * stack.c (_initialize_stack): Use _(), not N_().
2035 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2036
2b79f376
SM
20372019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2038
2039 * dwarf2read.c (struct dw2_symtab_iterator):
2040 <want_specific_block>: Remove.
2041 <block_index>: Change type to gdb::optional.
2042 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2043 change type of BLOCK_INDEX parameter to gdb::optional.
2044 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2045 (dw2_lookup_symbol): Don't pass argument for
2046 WANT_SPECIFIC_BLOCK.
2047 (dw2_expand_symtabs_for_function): Don't pass argument for
2048 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2049 (class dw2_debug_names_iterator)
2050 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2051 parameter, change BLOCK_INDEX type to gdb::optional.
2052 <m_want_specific_block>: Remove.
2053 <m_block_index>: Change type to gdb::optional.
2054 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2055 gdb::optional. Re-write in function of gdb::optional.
2056 (dw2_debug_names_lookup_symbol): Don't pass argument for
2057 WANT_SPECIFIC_BLOCK.
2058 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2059 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2060 BLOCK_INDEX.
2061
ae60f04e
PW
20622019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2063
2064 * NEWS: Mention changes to "info sources" command.
2065
28cd9371
PW
20662019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2067
2068 * symtab.c (filename_partial_match_opts): New struct type.
2069 (struct output_source_filename_data): New members
2070 regexp, c_regexp, partial_match.
2071 (output_source_filename): Use new members to decide to print file.
2072 (info_sources_option_defs): New variable.
2073 (make_info_sources_options_def_group, print_info_sources_header,
2074 info_sources_command_completer):
2075 New functions.
2076 (info_sources_command): Read new optional arguments.
2077 (_initialize_symtab): Update info sources help.
2078
ca683e3a
AO
20792019-08-02 Alexandre Oliva <oliva@adacore.com>
2080
2081 * ada-lang.c (exception_support_info_v0): Renamed from...
2082 (default_exception_support_info): ... this. Create new
2083 definition for v1.
2084 (ada_has_this_exception_support): Look up catch_handlers_sym.
2085 (ada_exception_support_info_sniffer): Try v0 after default.
2086
f1264162
TT
20872019-08-01 Tom Tromey <tromey@adacore.com>
2088
2089 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2090 gdbarch.h.
2091
0a7b2485
CB
20922019-08-01 Christian Biesinger <cbiesinger@google.com>
2093
2094 * s12z-tdep.c: Fix include path for s12z-opc.h.
2095
c6bdbeb7
AH
20962019-08-01 Alan Hayward <alan.hayward@arm.com>
2097
2098 * NEWS: Require GNU make 3.82.
2099
a2bd7b82
TT
21002019-07-16 Tom Tromey <tom@tromey.com>
2101
2102 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2103 declare.
2104
aa3b6533
TT
21052019-07-30 Tom Tromey <tromey@adacore.com>
2106
2107 * block.c (contained_in): Remove BLOCK_FUNCTION check.
2108
a1530dc7
KB
21092019-07-30 Kevin Buettner <kevinb@redhat.com>
2110
2111 * printcmd.c (print_address_symbolic): Print negative offsets.
2112 (build_address_symbolic): Force signed arithmetic when computing
2113 offset.
2114
2906593f
CB
21152019-07-30 Christian Biesinger <cbiesinger@google.com>
2116
2117 PR/24474: Add a function to lookup static variables.
2118 * NEWS: Mention this new function.
2119 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2120 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2121 * python/python.c (python_GdbMethods): Add new function.
2122
c620ed88
CB
21232019-07-29 Christian Biesinger <cbiesinger@google.com>
2124
2125 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2126 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2127 (objfpy_lookup_static_symbol): New function.
2128 (objfile_object_methods): Add new functions.
2129
bc4268a5
PW
21302019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2131
2132 * NEWS: Mention 'set|show print frame-info'. Mention new
2133 'presence' value for 'frame-arguments'. Mention new '-frame-info'
2134 backtrace argument. Mention that python frame filtering code
2135 is now consistent with what 'backtrace' command prints.
2136
4b5e8d19
PW
21372019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2138
2139 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2140 comments.
2141 (print_frame_info_auto, print_frame_info_source_line,
2142 print_frame_info_location, print_frame_info_source_and_location,
2143 print_frame_info_location_and_address, print_frame_info_short_location):
2144 New declarations.
2145 (struct frame_print_options): New member print_frame_info.
2146 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2147 * stack.h (get_user_print_what_frame_info): New declaration.
2148 (frame_show_address): New declaration.
2149 * stack.c (print_frame_arguments_choices): New value 'presence'.
2150 (print_frame_info_auto, print_frame_info_source_line,
2151 print_frame_info_location, print_frame_info_source_and_location,
2152 print_frame_info_location_and_address, print_frame_info_short_location,
2153 print_frame_info_choices, print_frame_info_print_what): New definitions.
2154 (print_frame_args): Only print dots for args if print frame-arguments
2155 is 'presence'.
2156 (frame_print_option_defs): New element for "frame-info".
2157 (get_user_print_what_frame_info): New function.
2158 (frame_show_address): Make non static. Move comment to stack.h.
2159 (print_frame_info_to_print_what): New function.
2160 (print_frame_info): Update comment. Use fp_opts.print_frame_info
2161 to decide what to print.
2162 (backtrace_command_1): Handle the new print_frame_arguments_presence
2163 value.
2164 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2165 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2166 (py_print_frame): In non-mi mode, use LOCATION as default for
2167 print_what, similarly to frame information printed directly by
2168 backtrace command. Handle frame-info user option in non MI mode.
2169
6bdfee81
KB
21702019-07-27 Kevin Buettner <kevinb@redhat.com>
2171
2172 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2173 Add case for debugging 32-bit target on 64-bit host. Revise
2174 comment.
2175
98a617f8
KB
21762019-07-27 Kevin Buettner <kevinb@redhat.com>
2177
2178 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2179 instead of find_function_entry_range_from_pc.
2180
567238c9
KB
21812019-07-27 Kevin Buettner <kevinb@redhat.com>
2182
2183 * stack.c (find_frame_funname): Remove code which preferred
2184 minsym over symtab sym in "certain pathological cases".
2185
2dc80cf8
KB
2186 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2187 parameter. Change type of "do_demangle" to bool.
2188 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2189 Pass suitable "prefer_sym_over_minsym" flag to
2190 build_address_symbolic(). Don't output "+" for negative offsets.
2191 * printcmd.c (print_address_symbolic): Update invocation of
2192 build_address_symbolic to include a "prefer_sym_over_minsym"
2193 flag.
2194 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2195 Restrict cases in which use of minimal symbol is preferred to that
2196 of a found symbol. Update comments.
2197
1aff7173
KB
2198 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2199 for entry pc when entry pc is out of range for that FDE.
2200
89b085ac
BC
22012019-07-26 Brian Callahan <bcallah@openbsd.org>
2202
2203 PR gdb/24839:
2204 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2205 type.
2206
f32feb4a
CB
22072019-07-25 Christian Biesinger <cbiesinger@google.com>
2208
2209 * python/py-objfile.c (add_separate_debug_file): Fix comment about
2210 this function's Python signature.
2211
2212
22132019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
2214
2215 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2216 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2217 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2218 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2219 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2220
2221
c54e4253
YS
22222019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
2223
2224 * h8300-tdep.c (h8300_register_name_common): New.
2225 h8300_register_name): Use h8300_register_name_common.
2226 (h8300s_register_name): Likewise.
2227 (h8300sx_register_name): Likewise.
2228 (h8300h_register_nam): New.
2229 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2230
2231
40eadf04
SP
22322019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
2233
2234 * arm-tdep.c (arm_skip_cmse_entry): New function.
2235 (arm_is_sgstubs_section): New function.
2236 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2237
bfa2a36d
TT
22382019-07-22 Tom Tromey <tom@tromey.com>
2239
2240 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2241 Don't self-assign.
2242
a8e9d247
AB
22432019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2244
2245 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2246 type_print.
2247
eb86c5e2
AB
22482019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2249
2250 * symtab.c (search_symbols): Adjust msymbol matching type arrays
2251 so that GDB doesn't match any msymbols when searching in the
2252 TYPES_DOMAIN.
2253 (print_symbol_info): Print using typedef_print or type_print based
2254 on the type of the symbol. Add updated FIXME comment moved from...
2255 (_initialize_symtab): ... move and update FIXME comment to above.
2256
a8eab7c6
AB
22572019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2258
2259 * NEWS: Mention adding -q option to "info types".
2260 * symtab.c (struct info_types_options): New struct.
2261 (info_types_options_defs): New variable.
2262 (make_info_types_options_def_group): New function.
2263 (info_types_command): Use gdb::option framework to parse options.
2264 (info_types_command_completer): New function.
2265 (_initialize_symtab): Extend the help text on "info types" and
2266 register command completer.
2267
b4603c34
CB
22682019-07-21 Christian Biesinger <cbiesinger@google.com>
2269
2270 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2271 (lookup_symbol_in_objfile): Change int to block_enum and add a
2272 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2273
c8cdc1e0
CB
22742019-07-20 Christian Biesinger <cbiesinger@google.com>
2275
2276 * MAINTAINERS (Write After Approval): Add self.
2277
01e175fe
AB
22782019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
2279
2280 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2281 instruction to the dummy code region.
2282
56f79b63
TT
22832019-07-19 Tom Tromey <tromey@adacore.com>
2284
2285 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2286 (ARGSUSED, PARAMS, __func__): Remove rules.
2287
4c5aa8e0
AH
22882019-07-19 Alan Hayward <alan.hayward@arm.com>
2289
2290 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2291 * features/arm/arm-with-iwmmxt.c: Remove.
2292 * features/arm/arm-with-iwmmxt.xml: Remove.
2293 * features/arm/arm-with-m-fpa-layout.c: Remove.
2294 * features/arm/arm-with-m-fpa-layout.xml: Remove.
2295 * features/arm/arm-with-m-vfp-d16.c: Remove.
2296 * features/arm/arm-with-m-vfp-d16.xml: Remove.
2297 * features/arm/arm-with-m.c: Remove.
2298 * features/arm/arm-with-m.xml: Remove.
2299 * features/arm/arm-with-neon.c: Remove.
2300 * features/arm/arm-with-neon.xml: Remove.
2301 * features/arm/arm-with-vfpv2.c: Remove.
2302 * features/arm/arm-with-vfpv2.xml: Remove.
2303 * features/arm/arm-with-vfpv3.c: Remove.
2304 * features/arm/arm-with-vfpv3.xml: Remove.
2305
f42b2617
AH
23062019-07-19 Alan Hayward <alan.hayward@arm.com>
2307
2308 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2309
f29ec966
AH
23102019-07-19 Alan Hayward <alan.hayward@arm.com>
2311
2312 * arch/aarch32.c (aarch32_create_target_description): Create
2313 target descriptions using features.
2314 * arch/arm.c (arm_create_target_description)
2315 (arm_create_mprofile_target_description): Likewise.
2316 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2317
d105cce5
AH
23182019-07-19 Alan Hayward <alan.hayward@arm.com>
2319
2320 * Makefile.in: Add new files.
2321 * aarch32-tdep.c: New file.
2322 * aarch32-tdep.h: New file.
2323 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2324 Call aarch32_read_description.
2325 * arch/aarch32.c: New file.
2326 * arch/aarch32.h: New file.
2327 * arch/arm.c (arm_create_target_description)
2328 (arm_create_mprofile_target_description): New function.
2329 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2330 (arm_create_target_description)
2331 (arm_create_mprofile_target_description): New declaration.
2332 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2333 read_description functions.
2334 * arm-linux-nat.c (arm_linux_nat_target::read_description):
2335 Likewise.
2336 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2337 * arm-tdep.c (tdesc_arm_list): New variable.
2338 (arm_register_g_packet_guesses): Call create description functions.
2339 (arm_read_description) (arm_read_mprofile_description): New
2340 function.
2341 * arm-tdep.h (arm_read_description)
2342 (arm_read_mprofile_description): Add declaration.
2343 * configure.tgt: Add new files.
2344
afe09f0b
GL
23452019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
2346
2347 * top.c (new_ui_command): Open specified terminal just once.
2348
cd215b2e
TT
23492019-07-18 Tom Tromey <tromey@adacore.com>
2350
2351 * symtab.c (main_name): Constify return type.
2352 * symfile.c (set_initial_language): Update.
2353 * symtab.h (main_name): Constify return type.
2354
d8f68fcb
TT
23552019-07-17 Tom Tromey <tom@tromey.com>
2356
2357 * tui/tui-winsource.c (tui_update_source_window)
2358 (tui_update_source_window_as_is)
2359 (tui_update_source_windows_with_line): Remove return.
2360 * tui/tui-disasm.c (tui_show_disassem)
2361 (tui_show_disassem_and_update_source): Remove return.
2362 * tui/tui.c (tui_reset): Remove return.
2363 * tui/tui-wingeneral.c
2364 (tui_check_and_display_highlight_if_needed): Remove return.
2365
ca5af91e
TT
23662019-07-17 Tom Tromey <tom@tromey.com>
2367
2368 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2369
5104fe36
TT
23702019-07-17 Tom Tromey <tom@tromey.com>
2371
2372 * tui/tui-winsource.h (struct tui_exec_info_window)
2373 (struct tui_source_window_base): Move from tui-data.h.
2374 * tui/tui-winsource.c: Move many method definitions from
2375 elsewhere. Remove "structuring" comments.
2376 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2377 (tui_source_window_base::refresh_window): Move to
2378 tui-winsource.c.
2379 * tui/tui-win.c (tui_source_window_base::refresh_all)
2380 (tui_source_window_base::update_tab_width)
2381 (tui_source_window_base::set_new_height)
2382 (tui_source_window_base::do_make_visible_with_new_height): Move to
2383 tui-winsource.c.
2384 * tui/tui-source.h: Update.
2385 * tui/tui-source.c (tui_source_window_base::reset): Move to
2386 tui-winsource.c.
2387 * tui/tui-disasm.h: Update.
2388 * tui/tui-data.h (struct tui_exec_info_window): Move to
2389 tui-winsource.h.
2390 (struct tui_source_window_base): Likewise.
2391 * tui/tui-data.c (tui_source_window_base::clear_detail)
2392 (tui_source_window_base, ~tui_source_window_base): Move to
2393 tui-winsource.c.
2394
daa15dde
TT
23952019-07-17 Tom Tromey <tom@tromey.com>
2396
2397 * tui/tui-win.c (tui_resize_all)
2398 (tui_source_window_base::update_tab_width)
2399 (tui_adjust_win_heights): Update.
2400 (tui_win_info::make_invisible_and_set_new_height): Rename from
2401 make_invisible_and_set_new_height.
2402 * tui/tui-data.h (struct tui_win_info)
2403 <make_invisible_and_set_new_height>: New method.
2404
bfad4537
TT
24052019-07-17 Tom Tromey <tom@tromey.com>
2406
2407 * tui/tui.c: Update.
2408 * tui/tui-source.h (struct tui_source_window): Move from
2409 tui-data.h.
2410 * tui/tui-layout.c: Update.
2411 * tui/tui-disasm.c: Update.
2412 * tui/tui-data.h (struct tui_source_window): Move to
2413 tui-source.h.
2414
88f7e873
TT
24152019-07-17 Tom Tromey <tom@tromey.com>
2416
2417 * tui/tui-disasm.h (struct tui_disasm_window): Move from
2418 tui-data.h.
2419 * tui/tui-data.h (struct tui_disasm_window): Move to
2420 tui-disasm.h.
2421
96bd6233
TT
24222019-07-17 Tom Tromey <tom@tromey.com>
2423
2424 * tui/tui-regs.h (struct tui_data_item_window): Move from
2425 tui-data.h.
2426 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2427 * tui/tui-data.h (struct tui_data_item_window): Move to
2428 tui-regs.h.
2429 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2430
ce38393b
TT
24312019-07-17 Tom Tromey <tom@tromey.com>
2432
2433 * tui/tui.c: Update.
2434 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2435 (tui_cmd_window::max_height): Move to tui-command.c.
2436 * tui/tui-layout.c: Update.
2437 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2438 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2439 tui-command.c.
2440 * tui/tui-command.h (struct tui_cmd_window): Move from
2441 tui-data.h.
2442 * tui/tui-command.c: Remove "structuring" comments.
2443 (tui_cmd_window::clear_detail)
2444 (tui_cmd_window::do_make_visible_with_new_height)
2445 (tui_cmd_window::max_height): Move from elsewhere.
2446
2d8b51cb
TT
24472019-07-17 Tom Tromey <tom@tromey.com>
2448
2449 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2450 Now static.
2451 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2452 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2453
18ab23af
TT
24542019-07-17 Tom Tromey <tom@tromey.com>
2455
2456 * tui/tui.c: Update.
2457 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2458 tui-regs.c.
2459 * tui/tui-windata.h: Remove file.
2460 * tui/tui-windata.c: Remove file.
2461 * tui/tui-win.c (tui_data_window::set_new_height)
2462 (tui_data_window::do_make_visible_with_new_height): Move to
2463 tui-regs.c.
2464 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2465 * tui/tui-regs.c: Remove "structuring" comments.
2466 (tui_data_window::first_data_item_displayed)
2467 (tui_data_window::delete_data_content_windows)
2468 (tui_data_window::erase_data_content)
2469 (tui_data_window::display_all_data)
2470 (tui_data_window::refresh_all)
2471 (tui_data_window::do_scroll_vertical)
2472 (tui_data_window::clear_detail, tui_data_window::set_new_height)
2473 (tui_data_window::do_make_visible_with_new_height)
2474 (tui_data_window::refresh_window): Move from elsewhere.
2475 (_initialize_tui_regs): Move to end of file.
2476 * tui/tui-layout.c: Update.
2477 * tui/tui-hooks.c: Update.
2478 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2479 * tui/tui-data.c (tui_data_window::clear_detail): Move to
2480 tui-regs.c.
2481 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2482
88b7e7cc
TT
24832019-07-17 Tom Tromey <tom@tromey.com>
2484
2485 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2486 seen.
2487
0fcd3711
TT
24882019-07-17 Tom Tromey <tom@tromey.com>
2489
2490 * tui/tui-win.c (tui_source_window_base::set_new_height)
2491 (tui_source_window_base::do_make_visible_with_new_height): Use
2492 m_has_locator field directly.
2493 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2494 method.
2495 (struct tui_source_window_base) <has_locator>: Likewise.
2496
4a38112d
TT
24972019-07-17 Tom Tromey <tom@tromey.com>
2498
2499 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2500 Don't declare.
2501 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2502 Remove.
2503 * tui/tui-win.c (tui_source_window_base::set_new_height)
2504 (tui_source_window_base::set_new_height)
2505 (make_invisible_and_set_new_height)
2506 (tui_source_window_base::do_make_visible_with_new_height)
2507 (tui_source_window_base::do_make_visible_with_new_height):
2508 Update.
2509 * tui/tui-layout.c (show_source_disasm_command, show_data)
2510 (show_source_or_disasm_and_command): Update.
2511 * tui/tui-layout.c (show_layout): Update.
2512
09129226
TT
25132019-07-17 Tom Tromey <tom@tromey.com>
2514
2515 * tui/tui-layout.c (make_data_window): Remove.
2516 (show_data): Unify creation and re-initialization cases.
2517
4a8a5e84
TT
25182019-07-17 Tom Tromey <tom@tromey.com>
2519
2520 * tui/tui-layout.c (make_source_window, make_disasm_window):
2521 Remove.
2522 (show_data): Unify creation and re-initialization cases.
2523
76d2be8e
TT
25242019-07-17 Tom Tromey <tom@tromey.com>
2525
2526 * tui/tui-layout.c (make_command_window): Remove.
2527 (show_source_disasm_command, show_source_or_disasm_and_command):
2528 Unify creation and re-initialization cases.
2529
890b8bde
TT
25302019-07-17 Tom Tromey <tom@tromey.com>
2531
2532 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2533 creation and re-initialization cases.
2534
2cdfa113
TT
25352019-07-17 Tom Tromey <tom@tromey.com>
2536
2537 * tui/tui-regs.c (tui_get_register): Return void.
2538
8e3cfd09
TT
25392019-07-17 Tom Tromey <tom@tromey.com>
2540
2541 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2542 Simplify.
2543
f4e04977
TT
25442019-07-17 Tom Tromey <tom@tromey.com>
2545
2546 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2547 resetting.
2548
0379b883
TT
25492019-07-17 Tom Tromey <tom@tromey.com>
2550
2551 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2552 * tui/tui-regs.c (tui_reg_layout): New function.
2553 (tui_show_registers, tui_reg_command): Use it.
2554 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2555 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2556 parameters.
2557 (tui_layout_command): Remove.
2558
b7fbad91
TT
25592019-07-17 Tom Tromey <tom@tromey.com>
2560
2561 * tui/tui-layout.h (tui/tui-layout): Return void.
2562 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2563
4e1e56b9
TT
25642019-07-17 Tom Tromey <tom@tromey.com>
2565
2566 * tui/tui-layout.c (show_source_disasm_command, show_data):
2567 Update.
2568 (reset_locator): Remove.
2569 (show_source_or_disasm_and_command): Update.
2570
1e0c09ba
TT
25712019-07-17 Tom Tromey <tom@tromey.com>
2572
2573 * tui/tui-source.c (tui_source_window_base::reset): Remove
2574 win_type parameter.
2575 * tui/tui-layout.c (make_command_window, make_source_window)
2576 (make_disasm_window, make_data_window)
2577 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2578 (reset_locator, show_source_or_disasm_and_command): Update.
2579 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2580 win_type parameter.
2581 (struct tui_source_window_base) <reset>: Likewise.
2582
1bf605de
TT
25832019-07-17 Tom Tromey <tom@tromey.com>
2584
2585 * tui/tui-layout.c (show_source_disasm_command): Use
2586 reset_locator.
2587 (reset_locator): New function.
2588 (init_and_make_win): Remove.
2589 (show_source_or_disasm_and_command): Use reset_locator.
2590
098f9ed4
TT
25912019-07-17 Tom Tromey <tom@tromey.com>
2592
2593 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2594 condition.
2595 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2596 Remove condition.
2597 * tui/tui-source.c (tui_source_window_base::reset): New method.
2598 * tui/tui-layout.c (make_command_window): Don't call
2599 init_and_make_win.
2600 (make_source_window, make_disasm_window): Don't call
2601 make_source_or_disasm_window.
2602 (make_data_window): Don't call init_and_make_win. Change calling
2603 convention.
2604 (show_source_disasm_command, show_data): Simplify.
2605 (make_source_or_disasm_window): Remove.
2606 (show_source_or_disasm_and_command): Simplify.
2607 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2608 (struct tui_source_window_base) <reset>: Likewise.
2609 <execution_info>: Remove initializer.
2610 * tui/tui-data.c (tui_source_window_base): Initialize
2611 execution_info.
2612
80110957
TT
26132019-07-17 Tom Tromey <tom@tromey.com>
2614
2615 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2616 variable.
2617
cf82af05
TT
26182019-07-17 Tom Tromey <tom@tromey.com>
2619
2620 * tui/tui.c (tui_rl_other_window): Update.
2621 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2622 superclass method first. Always iterate over regs_content.
2623 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2624 method.
2625 * tui/tui-win.c (tui_set_focus_command): Update.
2626
01aeb396
TT
26272019-07-17 Tom Tromey <tom@tromey.com>
2628
2629 * tui/tui-win.c (tui_set_focus_command): Rename from
2630 tui_set_focus. Call tui_enable.
2631 (tui_set_focus_command): Remove.
2632
fd6c75ee
TT
26332019-07-17 Tom Tromey <tom@tromey.com>
2634
2635 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2636 refresh_window.
2637 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2638 touchwin.
2639 (tui_data_window::refresh_window): Call refresh_window on data
2640 items. Always call superclass refresh_window.
2641 (tui_win_info::refresh): Remove.
2642 (tui_source_window_base::refresh_window): Update.
2643 (tui_refresh_all): Update.
2644 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2645 refresh_window.
2646 (show_source_or_disasm_and_command): Likewise.
2647 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2648 (struct tui_source_window_base) <refresh>: Likewise.
2649
f6cc34a9
TT
26502019-07-17 Tom Tromey <tom@tromey.com>
2651
2652 * tui/tui-winsource.c (tui_clear_source_content)
2653 (tui_show_source_content): Update.
2654 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2655 whether content is empty.
2656 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2657 Remove.
2658
f31ec9af
TT
26592019-07-17 Tom Tromey <tom@tromey.com>
2660
2661 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2662 window's contents.
2663 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2664 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2665
d1b6f1e5
TT
26662019-07-17 Tom Tromey <tom@tromey.com>
2667
2668 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2669 (struct tui_data_item_window): Update.
2670
d9743a13
TT
26712019-07-17 Tom Tromey <tom@tromey.com>
2672
2673 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2674 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2675 defines.
2676
caf0bc4e
TT
26772019-07-17 Tom Tromey <tom@tromey.com>
2678
2679 * tui/tui-winsource.h (tui_erase_source_content)
2680 (tui_clear_source_content): Remove "display_prompt" parameter.
2681 * tui/tui-winsource.c (tui_update_source_window_as_is)
2682 (tui_update_source_windows_with_addr): Update.
2683 (tui_clear_source_content): Remove "display_prompt" parameter.
2684 (tui_erase_source_content): Likewise. Simplify.
2685 (tui_show_source_content): Update.
2686 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2687 * tui/tui-stack.c (tui_show_frame_info): Update.
2688 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2689 Remove defines.
2690
9d391078
TT
26912019-07-17 Tom Tromey <tom@tromey.com>
2692
2693 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2694 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2695 parameter.
2696 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2697 parameter.
2698
a38da35d
TT
26992019-07-17 Tom Tromey <tom@tromey.com>
2700
2701 * tui/tui-winsource.c (tui_clear_source_content)
2702 (tui_show_source_content, tui_show_exec_info_content)
2703 (tui_clear_exec_info_content): Update.
2704 * tui/tui-stack.c (tui_show_locator_content): Update.
2705 (tui_show_frame_info): Update.
2706 * tui/tui-source.h (tui_source_window): Don't declare.
2707 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2708 from tui_source_is_displayed.
2709 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2710 Remove field.
2711 (struct tui_source_window_base) <content_in_use>: New field. Now
2712 bool.
2713 (struct tui_source_window) <showing_source_p>: New method.
2714 (TUI_SRC_WIN): Change cast.
2715 * tui/tui-data.c (tui_initialize_static_data): Update.
2716
c2cd8994
TT
27172019-07-17 Tom Tromey <tom@tromey.com>
2718
2719 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2720 location_matches_p.
2721 * tui/tui-source.c (tui_source_window::location_matches_p): New
2722 method.
2723 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2724 method.
2725 * tui/tui-data.h (struct tui_source_window_base)
2726 <location_matches_p>: New method.
2727 (struct tui_source_window, struct tui_disasm_window)
2728 <location_matches_p>: Likewise.
2729
4dde7b34
TT
27302019-07-17 Tom Tromey <tom@tromey.com>
2731
2732 * tui/tui-win.c (tui_set_win_height_command): Rename from
2733 tui_set_win_height.
2734 (tui_set_win_height_command): Remove.
2735
b73dd877
TT
27362019-07-17 Tom Tromey <tom@tromey.com>
2737
2738 * tui/tui-source.c (tui_source_window): New constructor. Add
2739 observer.
2740 (~tui_source_window): New destructor.
2741 (tui_source_window::style_changed): New method.
2742 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2743 (tui_attach_detach_observers): Update.
2744 * tui/tui-data.h (struct tui_source_window): Make constructor not
2745 inline. Add destructor.
2746 (struct tui_source_window) <style_changed>: New method.
2747 <m_observable>: New member.
2748
ae2b5380
TT
27492019-07-17 Tom Tromey <tom@tromey.com>
2750
2751 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2752 * tui/tui-win.c (tui_resize_all): Fix typo.
2753
1ce3e844
TT
27542019-07-17 Tom Tromey <tom@tromey.com>
2755
2756 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2757 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2758 (tui_refresh_all): Remove "list" parameter. Use foreach.
2759 * tui/tui-win.c (window_name_completer): Use foreach.
2760 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2761 (update_tab_width): Likewise.
2762 * tui/tui-layout.c (show_layout): Update.
2763 * tui/tui-data.h (class tui_window_iterator): New.
2764 (struct all_tui_windows): New.
2765 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2766
fe3eaf1c
TT
27672019-07-17 Tom Tromey <tom@tromey.com>
2768
2769 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2770 parameter. Don't reference globals.
2771 (tui_reg_command): Update.
2772
368c1354
TT
27732019-07-17 Tom Tromey <tom@tromey.com>
2774
2775 * tui/tui-regs.c (tui_show_registers): Simplify.
2776
e80cd204
TT
27772019-07-17 Tom Tromey <tom@tromey.com>
2778
2779 * tui/tui-regs.c (tui_show_registers): Update.
2780 (tui_show_register_group): Add win_info parameter.
2781
aca2dd16
TT
27822019-07-17 Tom Tromey <tom@tromey.com>
2783
2784 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2785 Rename from tui_display_reg_element_at_line.
2786 (tui_data_window::display_registers_from_line): Update.
2787 * tui/tui-data.h (struct tui_data_window)
2788 <display_reg_element_at_line>: New method.
2789
517e9505
TT
27902019-07-17 Tom Tromey <tom@tromey.com>
2791
2792 * tui/tui-regs.h (tui_display_registers_from)
2793 (tui_display_registers_from_line): Don't declare.
2794 * tui/tui-windata.c (tui_data_window::display_all_data)
2795 (tui_data_window::refresh_all)
2796 (tui_data_window::do_scroll_vertical): Update.
2797 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2798 from tui_display_registers_from.
2799 (tui_display_reg_element_at_line): Update.
2800 (tui_data_window::display_registers_from_line): Rename from
2801 tui_display_registers_from_line.
2802 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2803 display_registers_from_line>: New methods.
2804
f76d8b19
TT
28052019-07-17 Tom Tromey <tom@tromey.com>
2806
2807 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2808 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2809 from tui_erase_data_content.
2810 (tui_data_window::display_all_data)
2811 (tui_data_window::refresh_all)
2812 (tui_data_window::do_scroll_vertical): Update.
2813 * tui/tui-regs.c (tui_show_registers): Update.
2814 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2815 New method.
2816
b4094625
TT
28172019-07-17 Tom Tromey <tom@tromey.com>
2818
2819 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2820 declare.
2821 * tui/tui-windata.c
2822 (tui_data_window::delete_data_content_windows): Rename from
2823 tui_delete_data_content_windows.
2824 (tui_data_window::display_all_data)
2825 (tui_data_window::do_scroll_vertical): Update.
2826 * tui/tui-data.h (struct tui_data_window)
2827 <delete_data_content_windows>: New method.
2828
c223a729
TT
28292019-07-17 Tom Tromey <tom@tromey.com>
2830
2831 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2832 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2833
50daf268
TT
28342019-07-17 Tom Tromey <tom@tromey.com>
2835
2836 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2837 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2838 from tui_display_all_data.
2839 * tui/tui-win.c
2840 (tui_data_window::do_make_visible_with_new_height): Update.
2841 * tui/tui-regs.c (tui_show_registers): Update.
2842 * tui/tui-layout.c (tui_set_layout): Update.
2843 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2844 method.
2845
df5f8cab
TT
28462019-07-17 Tom Tromey <tom@tromey.com>
2847
2848 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2849 * tui/tui-windata.c (tui_display_data_from): Remove.
2850 (tui_data_window::refresh_all): Update.
2851
80cb6c27
TT
28522019-07-17 Tom Tromey <tom@tromey.com>
2853
2854 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2855 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2856 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2857 tui_display_registers_from_line.
2858 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2859 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2860 "force_display" parameter.
2861
baff0c28
TT
28622019-07-17 Tom Tromey <tom@tromey.com>
2863
2864 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2865 declare.
2866 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2867 Rename from tui_first_reg_element_no_inline.
2868 (tui_display_reg_element_at_line)
2869 (tui_display_registers_from_line): Update.
2870 * tui/tui-data.h (struct tui_data_window)
2871 <first_reg_element_no_inline>: New method.
2872
3b23c5f2
TT
28732019-07-17 Tom Tromey <tom@tromey.com>
2874
2875 * tui/tui-windata.c (tui_display_data_from)
2876 (tui_data_window::do_scroll_vertical): Update.
2877 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2878 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2879 Rename from tui_line_from_reg_element_no.
2880 (tui_display_registers_from_line): Update.
2881 * tui/tui-data.h (struct tui_data_window)
2882 <line_from_reg_element_no>: New method.
2883
0b5ec218
TT
28842019-07-17 Tom Tromey <tom@tromey.com>
2885
2886 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2887 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2888 tui_last_regs_line_no.
2889 (tui_display_reg_element_at_line)
2890 (tui_display_registers_from_line): Update.
2891 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2892 method.
2893
0807ab7b
TT
28942019-07-17 Tom Tromey <tom@tromey.com>
2895
2896 PR tui/24722:
2897 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2898 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2899 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2900 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2901 (tui_update_breakpoint_info): Likewise.
2902 * tui/tui-hooks.c (tui_event_create_breakpoint)
2903 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2904 Update.
2905
9ad7fdef
TT
29062019-07-17 Tom Tromey <tom@tromey.com>
2907
2908 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2909
5813316f
TT
29102019-07-17 Tom Tromey <tom@tromey.com>
2911
2912 * tui/tui-winsource.c (tui_update_source_window_as_is)
2913 (tui_update_source_windows_with_addr): Update.
2914 * tui/tui-source.h (tui_set_source_content)
2915 (tui_show_symtab_source): Add "win_info" parameter.
2916 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2917 parameter.
2918 (tui_show_symtab_source): Likewise.
2919
00e264e7
TT
29202019-07-17 Tom Tromey <tom@tromey.com>
2921
2922 * tui/tui-wingeneral.c
2923 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2924
06210ce4
TT
29252019-07-17 Tom Tromey <tom@tromey.com>
2926
2927 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2928 (struct tui_cmd_window) <can_scroll>: New method.
2929 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2930 method.
2931
381befee
TT
29322019-07-17 Tom Tromey <tromey@adacore.com>
2933
2934 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2935 do_field_signed>: Rename. Change type of "value".
2936 * ui-out.c (ui_out::field_signed): Rename from field_int.
2937 Change type of "value".
2938 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2939 type of "value".
2940 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2941 do_field_int. Change type of "value".
2942 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2943 do_field_int. Change type of "value".
2944 * tracepoint.c (trace_status_mi, tfind_1)
2945 (print_one_static_tracepoint_marker): Update.
2946 * thread.c (print_thread_info_1, print_selected_thread_frame):
2947 Update.
2948 * stack.c (print_frame, print_frame_info): Update.
2949 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2950 Update.
2951 * source.c (print_source_lines_base): Update.
2952 * skip.c (info_skip_command): Update.
2953 * record-btrace.c (btrace_ui_out_decode_error)
2954 (btrace_call_history_src_line): Update.
2955 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2956 Update.
2957 * progspace.c (print_program_space): Update.
2958 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2959 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2960 do_field_int. Change type of "value".
2961 * mi/mi-out.c (mi_ui_out::do_table_begin)
2962 (mi_ui_out::do_table_header): Update.
2963 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2964 type of "value".
2965 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2966 (mi_cmd_data_list_changed_registers, output_register)
2967 (mi_cmd_data_read_memory, mi_load_progress)
2968 (mi_cmd_trace_frame_collected): Update.
2969 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2970 Update.
2971 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2972 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2973 (mi_cmd_var_list_children, varobj_update_one): Update.
2974 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2975 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2976 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2977 * inferior.c (print_inferior): Update.
2978 * gdb_bfd.c (print_one_bfd): Update.
2979 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2980 Update.
2981 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2982 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2983 do_field_int. Change type of "value".
2984 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2985 do_field_int. Change type of "value".
2986 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2987 (print_one_breakpoint_location, print_it_catch_fork)
2988 (print_one_catch_fork, print_it_catch_vfork)
2989 (print_one_catch_vfork, print_it_catch_solib)
2990 (print_it_catch_exec, print_it_ranged_breakpoint)
2991 (print_mention_watchpoint, print_mention_masked_watchpoint)
2992 (bkpt_print_it, update_static_tracepoint): Update.
2993 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2994 * break-catch-syscall.c (print_it_catch_syscall): Update.
2995 * ada-tasks.c (print_ada_task_info): Update.
2996 * ada-lang.c (print_it_exception, print_mention_exception):
2997 Update.
2998
6b78c3f8
AB
29992019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3000
3001 PR breakpoints/24541
3002 * gdbarch.c: Regenerate.
3003 * gdbarch.h: Regenerate.
3004 * gdbarch.sh: Adjust return type and parameter types for
3005 'stap_adjust_register'.
3006 (i386_stap_adjust_register): Adjust signature and return new
3007 register name.
3008 * stap-probe.c (stap_parse_register_operand): Adjust use of
3009 'gdbarch_stap_adjust_register'.
3010
d72a9b85
TT
30112019-07-17 Tom Tromey <tromey@adacore.com>
3012
3013 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3014 declare VEC.
3015 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3016 std::vector.
3017 (struct s390_process_info): Add initializers.
3018 (s390_add_process): Use new.
3019 (s390_linux_nat_target::low_forget_process): Use delete.
3020 (s390_linux_nat_target::low_new_fork)
3021 (s390_linux_nat_target::stopped_by_watchpoint)
3022 (s390_linux_nat_target::low_prepare_to_resume)
3023 (s390_linux_nat_target::insert_watchpoint)
3024 (s390_linux_nat_target::insert_hw_breakpoint)
3025 (s390_linux_nat_target::remove_watchpoint)
3026 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3027
206e6c58
JB
30282019-07-16 John Baldwin <jhb@FreeBSD.org>
3029
3030 * aarch64-fbsd-nat.c: Include regcache.h.
3031 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3032 argument.
3033 (aarch64_fbsd_nat_target::fetch_registers)
3034 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3035 variable.
3036 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3037
cbde90f2
JB
30382019-07-16 John Baldwin <jhb@FreeBSD.org>
3039
3040 * fbsd-nat.c: Include gdbarch.h.
3041
07128006
TT
30422019-07-15 Tom Tromey <tromey@adacore.com>
3043
3044 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3045
1f77b012
TT
30462019-07-15 Tom Tromey <tromey@adacore.com>
3047
3048 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3049 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3050 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3051 * cli-out.c (cli_ui_out::do_field_int): New method.
3052 * ui-out.c (ui_out::field_unsigned): New method.
3053 * symfile.c (generic_load): Use field_unsigned.
3054 (print_transfer_performance): Likewise.
3055 * record-btrace.c (ui_out_field_uint): Remove.
3056 (btrace_call_history_insn_range, btrace_call_history): Use
3057 field_unsigned.
3058 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3059 field_unsigned.
3060 * ui-out.h (class ui_out) <field_unsigned>: New method.
3061 <do_field_unsigned>: Likewise.
3062
33eca680
TT
30632019-07-15 Tom Tromey <tromey@adacore.com>
3064
3065 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3066 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3067 * target.c (flash_erase_command): Use field_string.
3068 * infrun.c (print_signal_received_reason): Use field_string.
3069 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3070 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3071 field_string.
3072 * ada-tasks.c (print_ada_task_info): Use field_string.
3073
ca8d69be
TT
30742019-07-15 Tom Tromey <tromey@adacore.com>
3075
3076 * target.c (flash_erase_command): Use field_core_addr.
3077 * symfile.c (generic_load): Use field_core_addr.
3078 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3079 Use field_core_addr.
3080 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3081 field_core_addr.
3082
0d4e84ed
AB
30832019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3084
3085 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3086 value if its desired type is smaller than a CORE_ADDR and signed.
3087
9a49df9d
AB
30882019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3089
3090 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3091 of changes to field names, and use new is_reference field to
3092 decide if a property is a reference or not.
3093 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3094 field.
3095 (struct dwarf2_property_baton): Update header comment, rename
3096 'referenced_type' to 'property_type' and update comments.
3097 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3098 default property type, store in property baton, update to take
3099 accound of renamed field.
3100 (read_func_scope): Update call to attr_to_dynamic_prop.
3101 (read_array_type): Likewise.
3102 (dwarf2_per_cu_addr_sized_int_type): New function.
3103 (read_subrange_index_type): Move type finding code to
3104 dwarf2_per_cu_addr_sized_int_type.
3105 (read_subrange_type): Update calls to attr_to_dynamic_prop.
3106 (dwarf2_per_cu_addr_type): New function.
3107 (set_die_type): Update calls to attr_to_dynamic_prop.
3108
b86352cf
AB
31092019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3110
3111 * dwarf2read.c (read_subrange_index_type): New function.
3112 (read_subrange_type): Move code into new function and call it.
3113 * gdbtypes.c (create_range_type): Add some asserts.
3114
603490bf
AB
31152019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3116
3117 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3118 update return statements.
3119 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3120 declaration, and update comment to match.
3121 * gdbtypes.c (resolve_dynamic_array): Update call to
3122 dwarf2_evaluate_property to match new return type.
3123
592f9d27
AB
31242019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3125
3126 * valarith.c (value_subscripted_rvalue): Change lowerbound
3127 parameter type from int to LONGEST.
3128 * value.h (value_subscripted_rvalue): Likewise in declaration.
3129
60cfcb20
AB
31302019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3131
3132 * cli/cli-utils.c (info_print_command_completer): New function.
3133 * cli/cli-utils.h: Add 'completer.h' include, and forward
3134 declaration for 'struct cmd_list_element'.
3135 (info_print_command_completer): Declare.
3136 * stack.c (_initialize_stack): Add completer for 'info locals' and
3137 'info args'.
3138 * symtab.c (_initialize_symtab): Add completer for 'info
3139 variables' and 'info functions'.
3140 * NEWS: Mention completion for additional info commands.
3141
b16507e0
AB
31422019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3143
3144 * cli/cli-utils.c (extract_info_print_args): Delete.
3145 (extract_arg_maybe_quoted): Delete.
3146 (info_print_options_defs): New variable.
3147 (make_info_print_options_def_group): New function.
3148 (extract_info_print_options): Define new function.
3149 * cli/cli-utils.h (extract_info_print_args): Delete.
3150 (struct info_print_options): New structure.
3151 (extract_info_print_options): Declare new function.
3152 * stack.c (info_locals_command): Update to use new
3153 extract_info_print_options, also add a header comment.
3154 (info_args_command): Likewise.
3155 * symtab.c (info_variables_command): Likewise.
3156 (info_functions_command): Likewise.
3157
021d8588
AB
31582019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3159
3160 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3161 to extract string arguments.
3162 * common/common-utils.c (extract_string_maybe_quoted): New function.
3163 * common/common-utils.h (extract_string_maybe_quoted): Declare.
3164
b777eb6d
TT
31652019-07-11 Tom Tromey <tromey@adacore.com>
3166
3167 * main.c (get_init_files): Use GDBINIT, not gdbinit.
3168 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3169 * top.h (gdbinit): Don't declare.
3170 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3171 into...
3172 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
3173 * top.c (gdb_init): Don't call init_cli_cmds.
3174 (gdbinit): Remove.
3175 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3176
72ee03ff
TT
31772019-07-11 Tom Tromey <tromey@adacore.com>
3178
3179 * python/py-inferior.c (add_thread_object): Don't use thread_obj
3180 after it has been moved.
3181
00db9531
SM
31822019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3183
3184 * valops.c (value_must_coerce_to_target): Change return type to
3185 bool.
3186 * value.h (value_must_coerce_to_target): Likewise.
3187
f2478a7e
SM
31882019-07-10 Simon Marchi <simon.marchi@efficios.com>
3189
3190 * breakpoint.c (is_hardware_watchpoint): Remove
3191 forward-declaration.
3192 (is_masked_watchpoint): Change return type to bool.
3193 (is_tracepoint): Likewise.
3194 (is_breakpoint): Likewise.
3195 (is_hardware_watchpoint): Likewise.
3196 (is_watchpoint): Likewise.
3197 (is_no_memory_software_watchpoint): Likewise.
3198 (is_catchpoint): Likewise.
3199 (breakpoint_1): Make FILTER parameter's return type bool.
3200 is_masked_watchpoint): Change return type to bool.
3201 (save_breakpoints): Make FILTER parameter's return type bool.
3202 * breakpoint.h (is_breakpoint): Change return type to bool.
3203 (is_watchpoint): Likewise.
3204 (is_catchpoint): Likewise.
3205 (is_tracepoint): Likewise.
3206
0d12e84c
TT
32072019-07-10 Tom Tromey <tom@tromey.com>
3208
3209 * defs.h: Don't include gdbarch.h.
3210 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3211 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3212 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3213 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3214 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3215 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3216 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3217 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3218 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3219 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3220 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3221 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3222 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3223 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3224 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3225 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3226 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3227 record-btrace.c, record.h, regcache-dump.c, regcache.h,
3228 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3229 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3230 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3231 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3232 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3233 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3234 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3235 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3236 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3237
f06f1252
TT
32382019-07-10 Tom Tromey <tromey@adacore.com>
3239
3240 * ada-lang.h (is_ada_exception_catchpoint): Declare.
3241 * breakpoint.c (init_ada_exception_breakpoint): Register as
3242 bp_catchpoint.
3243 (print_one_breakpoint_location, print_one_breakpoint): Use
3244 is_ada_exception_catchpoint.
3245 * ada-lang.c (class ada_catchpoint_location): Pass
3246 bp_loc_software_breakpoint to bp_location constructor.
3247 (is_ada_exception_catchpoint): New function.
3248
7a5d944b
TT
32492019-07-10 Tom Tromey <tromey@adacore.com>
3250
3251 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
3252 VEC.
3253 (struct arm_exidx_entry): New method operator<.
3254 (struct arm_exidx_data) <section_maps>: Change type.
3255 (arm_exidx_data_free): Remove.
3256 (arm_exidx_data_key): Change type. Move lower.
3257 (arm_exidx_new_objfile): Update.
3258 (arm_compare_exidx_entries): Remove.
3259 (arm_find_exidx_entry, _initialize_arm_tdep)
3260
48c66e1d
TT
32612019-07-10 Tom Tromey <tromey@adacore.com>
3262
3263 * solib-spu.c (ocl_program_data_key): Change type.
3264 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3265 Update.
3266
a269fbf1
TT
32672019-07-10 Tom Tromey <tromey@adacore.com>
3268
3269 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
3270 (struct solib_aix_inferior_data) <library_list>: Change type.
3271 (solib_aix_inferior_data_handle): Change type.
3272 (get_solib_aix_inferior_data): Update.
3273 (solib_aix_free_library_list): Remove.
3274 (library_list_start_library): Update.
3275 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3276 return type.
3277 (solib_aix_get_library_list)
3278 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3279 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3280
c294730c
TT
32812019-07-10 Tom Tromey <tromey@adacore.com>
3282
3283 * solib-dsbt.c (struct dsbt_info): Add initializers.
3284 (solib_dsbt_pspace_data): Change type.
3285 (dsbt_pspace_data_cleanup): Remove.
3286 (get_dsbt_info, _initialize_dsbt_solib): Update.
3287
9d52077d
TT
32882019-07-10 Tom Tromey <tromey@adacore.com>
3289
3290 * spu-tdep.c (spu_overlay_data): Change type.
3291 (spu_get_overlay_table, spu_overlay_new_objfile)
3292 (_initialize_spu_tdep): Update.
3293
22a20dca
TT
32942019-07-10 Tom Tromey <tromey@adacore.com>
3295
3296 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3297 destructor.
3298 (dbx_objfile_data_key): Change type and declare later.
3299 (DBX_SYMFILE_INFO): Rewrite.
3300 * dbxread.c (dbx_objfile_data_key): Change type.
3301 (dbx_symfile_init): Update.
3302 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
3303 (coffstab_build_psymtabs, elfstab_build_psymtabs)
3304 (stabsect_build_psymtabs, _initialize_dbxread): Update.
3305
cb60f420
TT
33062019-07-10 Tom Tromey <tromey@adacore.com>
3307
3308 * jit.c (jit_program_space_key): Change type. Move lower.
3309 (get_jit_program_space_data): Update.
3310 (jit_program_space_data_cleanup): Remove.
3311 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3312 Update.
3313 (struct jit_program_space_data): Add initializers.
3314
51df2ae3
TT
33152019-07-10 Tom Tromey <tromey@adacore.com>
3316
3317 * solib-darwin.c (struct darwin_info): Add initializers.
3318 (solib_darwin_pspace_data): Change type.
3319 (darwin_pspace_data_cleanup): Remove.
3320 (get_darwin_info, _initialize_darwin_solib): Update.
3321
18101a35
TT
33222019-07-10 Tom Tromey <tromey@adacore.com>
3323
3324 * remote-sim.c (struct sim_inferior_data): Add initializers,
3325 constructor, and destructor.
3326 (sim_inferior_data_key): Change type. Move lower.
3327 (check_for_duplicate_sim_descriptor): Update.
3328 (get_sim_inferior_data): Use new. Update.
3329 (~sim_inferior_data_cleanup): Rename from
3330 sim_inferior_data_cleanup. Simplify.
3331 (gdbsim_close_inferior, simulator_command)
3332 (sim_command_completer, _initialize_remote_sim): Update.
3333 (next_pid, INITIAL_PID): Move earlier.
3334
05b08ac1
TT
33352019-07-10 Tom Tromey <tromey@adacore.com>
3336
3337 * python/python-internal.h (create_thread_object): Return
3338 gdbpy_ref.
3339 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3340 * python/py-inferior.c (struct threadlist_entry): Add
3341 constructor.
3342 <thread_obj>: Now a gdbpy_ref.
3343 (thread_to_thread_object): Update.
3344 (add_thread_object): Use new.
3345 (delete_thread_object): Use delete.
3346 (infpy_threads): Update.
3347 (py_free_inferior): Update. Construct "inf_obj" after acquiring
3348 GIL.
3349
32372d80
TT
33502019-07-10 Tom Tromey <tromey@adacore.com>
3351
3352 * valops.c (value_cast): Specialize error message for Ada.
3353
5c458ae8
SM
33542019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3355
3356 * breakpoint.c (breakpoint_1): Update doc and parameter names.
3357
4c462cb0
SM
33582019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3359
3360 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3361 bpstat_should_step): Return bool, adjust comments.
3362 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3363 bpstat_should_step): Likewise.
3364
89abbcc2
AH
33652019-07-10 Alan Hayward <alan.hayward@arm.com>
3366
3367 * features/Makefile: Use feature target descriptions for Arm.
3368 * features/arm/arm-core.c: Generate new file.
3369 * features/arm/arm-fpa.c: Likewise.
3370 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3371 * features/arm/arm-m-profile.c: Likewise.
3372 * features/arm/arm-vfpv2.c: Likewise.
3373 * features/arm/arm-vfpv3.c: Likewise.
3374 * features/arm/xscale-iwmmxt.c: Likewise.
3375 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3376
166a82be
AH
33772019-07-10 Alan Hayward <alan.hayward@arm.com>
3378
3379 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3380 ptrace earlier.
3381
9fb4c7e9
AH
33822019-07-10 Alan Hayward <alan.hayward@arm.com>
3383
3384 * features/aarch64-pauth.c: Regenerate.
3385
e2d0f980
SM
33862019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
3387
3388 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3389 bool.
3390 (bpstat_what): Use false instead of 0.
3391
a38118e5
PA
33922019-07-09 Pedro Alves <palves@redhat.com>
3393
3394 * break-catch-throw.c (is_exception_catchpoint): New.
3395 * breakpoint.c (print_one_breakpoint_location): New parameter
3396 'raw_loc'. Handle it. Use
3397 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3398 looking at the breakpoint's type.
3399 (print_one_breakpoint): If handling "maint info breakpoints", also
3400 print locations of exception catchpoints.
3401 * breakpoint.h (is_exception_catchpoint): Declare.
3402
cb1e4e32
PA
34032019-07-09 Pedro Alves <palves@redhat.com>
3404
3405 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3406 "addr" field.
3407 (allocate_location_exception_catchpoint): New.
3408 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3409 (initialize_throw_catchpoint_ops): Install
3410 allocate_location_exception_catchpoint as allocate_location
3411 method.
3412 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3413 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3414 bp_loc_other.
3415 (breakpoint_address_is_meaningful): Delete.
3416 (bl_address_is_meaningful): New.
3417 (breakpoint_locations_match): Adjust comment.
3418 (bp_location_from_bp_type): New, factored out of...
3419 (bp_location::bp_location(breakpoint *)): ... this.
3420 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3421 factored out of...
3422 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
3423 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3424 breakpoint_address_is_meaningful.
3425 (bp_locations_compare): Adjust comment.
3426 (update_global_location_list): Use bl_address_is_meaningful
3427 instead of breakpoint_address_is_meaningful.
3428 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3429 explicit.
3430 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3431 * python/py-breakpoint.c (bppy_get_location): No longer check
3432 whether location is null.
3433
b58a68fe
PA
34342019-07-09 Pedro Alves <palves@redhat.com>
3435
3436 PR c++/15468
3437 * breakpoint.c (print_one_breakpoint_location): Remove
3438 single-location assert.
3439
268a13a5
TT
34402019-07-09 Tom Tromey <tom@tromey.com>
3441
3442 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3443 * configure: Rebuild.
3444 * configure.ac: Change common to gdbsupport.
3445 * gdbsupport: Rename from common.
3446 * acinclude.m4: Change common to gdbsupport.
3447 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3448 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3449 gdbsupport.
3450 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3451 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3452 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3453 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3454 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3455 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3456 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3457 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3458 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3459 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3460 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3461 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3462 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3463 coff-pe-read.c, command.h, compile/compile-c-support.c,
3464 compile/compile-c.h, compile/compile-cplus-symbols.c,
3465 compile/compile-cplus-types.c, compile/compile-cplus.h,
3466 compile/compile-loc2c.c, compile/compile.c, completer.c,
3467 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3468 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3469 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3470 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3471 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3472 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3473 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3474 features/aarch64-core.c, features/aarch64-fpu.c,
3475 features/aarch64-pauth.c, features/aarch64-sve.c,
3476 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3477 features/i386/32bit-core.c, features/i386/32bit-linux.c,
3478 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3479 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3480 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3481 features/i386/64bit-core.c, features/i386/64bit-linux.c,
3482 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3483 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3484 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3485 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3486 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3487 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3488 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3489 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3490 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3491 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3492 go32-nat.c, guile/guile.c, guile/scm-ports.c,
3493 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3494 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3495 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3496 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3497 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3498 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3499 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3500 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3501 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3502 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3503 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3504 minsyms.c, mips-linux-tdep.c, namespace.h,
3505 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3506 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3507 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3508 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3509 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3510 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3511 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3512 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3513 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3514 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3515 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3516 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3517 procfs.c, producer.c, progspace.h, psymtab.h,
3518 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3519 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3520 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3521 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3522 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3523 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3524 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3525 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3526 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3527 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3528 target-memory.c, target.c, target.h, target/waitstatus.c,
3529 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3530 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3531 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3532 unittests/array-view-selftests.c,
3533 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3534 unittests/common-utils-selftests.c,
3535 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3536 unittests/format_pieces-selftests.c,
3537 unittests/function-view-selftests.c,
3538 unittests/lookup_name_info-selftests.c,
3539 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3540 unittests/mkdir-recursive-selftests.c,
3541 unittests/observable-selftests.c,
3542 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3543 unittests/parse-connection-spec-selftests.c,
3544 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3545 unittests/scoped_fd-selftests.c,
3546 unittests/scoped_mmap-selftests.c,
3547 unittests/scoped_restore-selftests.c,
3548 unittests/string_view-selftests.c, unittests/style-selftests.c,
3549 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3550 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3551 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3552 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3553 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3554 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3555
5b0e2db4
AB
35562019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3557
3558 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3559 bool value.
3560 (decode_digits_ordinary): Set explicit_line field in sal.
3561 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3562 symtab_and_line that was set on an explicit line number in
3563 assembler code. Do always update the recorded symtab and line if
3564 we do skip the prologue.
3565
0ba852ab
AB
35662019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3567
3568 * breakpoint.c (set_breakpoint_location_function): Remove
3569 explicit_loc parameter.
3570 (momentary_breakpoint_from_master): Update call to
3571 set_breakpoint_location_function.
3572 (add_location_to_breakpoint): Likewise.
3573
b3a7d171
AB
35742019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3575
3576 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3577 required features based on default bfd type when no specific bfd
3578 is present.
3579
1f6f6e21
PW
35802019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3581
3582 * NEWS: Mention that GDB printf and eval commands can now print
3583 C-style and Ada-style convenience var strings without
3584 calling the inferior.
3585 * printcmd.c (printf_c_string): Locally print GDB internal var
3586 instead of transiting via the inferior.
3587 (printf_wide_c_string): Likewise.
3588
35892019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
3590
3591 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3592
0598af48
TT
35932019-07-04 Tom Tromey <tom@tromey.com>
3594
3595 PR tui/24724:
3596 * tui/tui-winsource.c (tui_clear_source_content): Update.
3597 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3598 (tui_update_breakpoint_info): Update.
3599 (tui_set_exec_info_content): Update.
3600 * tui/tui-source.c (tui_set_source_content_nil): Update.
3601 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3602 has_break.
3603 * tui/tui-data.h (enum tui_bp_flag): New.
3604 (tui_bp_flags): New enum flags type.
3605 (struct tui_source_element) <break_mode>: Change type. Rename
3606 from has_break.
3607 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3608 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3609 constants.
3610 * tui/tui-winsource.h: Fix comment.
3611
350fab54
AH
36122019-07-04 Alan Hayward <alan.hayward@arm.com>
3613
3614 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3615 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3616 (store_fpregs_to_thread)
3617 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3618 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3619 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3620 (IWMMXT_REGS_SIZE): Add define.
3621 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3622 (fetch_vfp_regs, store_vfp_regs)
3623 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3624 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3625
f0452268
AH
36262019-07-04 Alan Hayward <alan.hayward@arm.com>
3627
3628 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3629 defines.
3630 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3631 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3632 (ARM_INT_REGISTER_SIZE): ...to this.
3633 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3634 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3635 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3636 (arm_linux_collect_gregset, supply_nwfpe_register)
3637 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3638 defines.
3639 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3640 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3641 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3642 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3643 (arm_return_in_memory, arm_store_return_value)
3644 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3645 (arm_record_ld_st_multiple): Likewise.
3646 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3647 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3648
e935475c
AH
36492019-07-04 Alan Hayward <alan.hayward@arm.com>
3650
3651 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3652 AARCH64_DISPLACED_MODIFIED_INSNS.
3653 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3654 (aarch64_displaced_step_copy_insn): Likewise.
3655 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3656 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3657 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3658 ARM_DISPLACED_MODIFIED_INSNS.
3659 * arm-tdep.c (arm_gdbarch_init): Likewise.
3660 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3661 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3662 (struct arm_displaced_step_closure): Use
3663 ARM_DISPLACED_MODIFIED_INSNS.
3664
df0bb381
AH
36652019-07-04 Alan Hayward <alan.hayward@arm.com>
3666
3667 * features/Makefile: Remove unused xml files.
3668 * features/aarch64.xml: Remove.
3669 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3670 * features/i386/amd64-avx-avx512.xml: Remove.
3671 * features/i386/amd64-avx-linux.xml: Remove.
3672 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3673 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3674 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3675 * features/i386/amd64-avx-mpx.xml: Remove.
3676 * features/i386/amd64-avx.xml: Remove.
3677 * features/i386/amd64-linux.xml: Remove.
3678 * features/i386/amd64-mpx-linux.xml: Remove.
3679 * features/i386/amd64-mpx.xml: Remove.
3680 * features/i386/amd64.xml: Remove.
3681 * features/i386/i386-avx-avx512-linux.xml: Remove.
3682 * features/i386/i386-avx-avx512.xml: Remove.
3683 * features/i386/i386-avx-linux.xml: Remove.
3684 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3685 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3686 * features/i386/i386-avx-mpx-linux.xml: Remove.
3687 * features/i386/i386-avx-mpx.xml: Remove.
3688 * features/i386/i386-avx.xml: Remove.
3689 * features/i386/i386-linux.xml: Remove.
3690 * features/i386/i386-mmx-linux.xml: Remove.
3691 * features/i386/i386-mmx.xml: Remove.
3692 * features/i386/i386-mpx-linux.xml: Remove.
3693 * features/i386/i386-mpx.xml: Remove.
3694 * features/i386/i386.xml: Remove.
3695 * features/i386/x32-avx-avx512-linux.xml: Remove.
3696 * features/i386/x32-avx-linux.xml: Remove.
3697 * features/i386/x32-linux.xml: Remove.
3698
edd6266a
AH
36992019-07-04 Alan Hayward <alan.hayward@arm.com>
3700
3701 * regformats/aarch64.dat: Remove.
3702 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3703 * regformats/i386/amd64-avx-linux.dat: Remove.
3704 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3705 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3706 * regformats/i386/amd64-linux.dat: Remove.
3707 * regformats/i386/amd64-mpx-linux.dat: Remove.
3708 * regformats/i386/amd64.dat: Remove.
3709 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3710 * regformats/i386/i386-avx-linux.dat: Remove.
3711 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3712 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3713 * regformats/i386/i386-linux.dat: Remove.
3714 * regformats/i386/i386-mmx-linux.dat: Remove.
3715 * regformats/i386/i386-mpx-linux.dat: Remove.
3716 * regformats/i386/i386.dat: Remove.
3717 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3718 * regformats/i386/x32-avx-linux.dat: Remove.
3719 * regformats/i386/x32-linux.dat: Remove.
3720
2b40fda7
AH
37212019-07-04 Alan Hayward <alan.hayward@arm.com>
3722
3723 * aarch64-tdep.c: Remove xml self tests.
3724 * amd64-linux-tdep.c: Likewise.
3725 * amd64-tdep.c: Likewise.
3726 * i386-linux-tdep.c: Likewise.
3727 * i386-tdep.c: Likewise.
3728
5f4ba3e7
PA
37292019-07-03 Pedro Alves <palves@redhat.com>
3730
3731 PR cli/24732
3732 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3733 (pipe_cmd_option_defs): New.
3734 (make_pipe_cmd_options_def_group): New.
3735 (pipe_command): Use gdb::option::process_options.
3736 (pipe_command_completer): New function.
3737 (_initialize_cli_cmds): Install completer for "pipe" command.
3738
3d9be6f5
PA
37392019-07-03 Pedro Alves <palves@redhat.com>
3740
3741 * cli/cli-option.c (union option_value) <string>: New field.
3742 (struct option_def_and_value): Add ctor, move ctor, dtor and
3743 use DISABLE_COPY_AND_ASSIGN.
3744 (option_def_and_value::clear_value): New.
3745 (parse_option, save_option_value_in_ctx, get_val_type_str)
3746 (add_setshow_cmds_for_options): Handle var_string.
3747 * cli-option.h (union option_def::var_address) <string>: New
3748 field.
3749 (struct string_option_def): New.
3750 * maint-test-options.c (struct test_options_opts): Add default
3751 ctor and use DISABLE_COPY_AND_ASSIGN.
3752 <string_opt>: New field.
3753 (test_options_opts::~test_options_opts): New.
3754 (test_options_opts::dump): Also dump "-string".
3755 (test_options_option_defs): Install "string.
3756
41fc454c
PA
37572019-07-03 Pedro Alves <palves@redhat.com>
3758
3759 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3760 option_value with a null enumeration.
3761 (complete_options): Save the option values in the context.
3762 (save_option_value_in_ctx): New, factored out from ...
3763 (process_options): ... here.
3764 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3765 of the function.
3766 * maint-test-options.c (test_options_opts::dump): New, factored
3767 out from ...
3768 (maintenance_test_options_command_mode): ... here.
3769 (maintenance_test_options_command_completion_result): Delete.
3770 (maintenance_test_options_command_completion_text): Update
3771 comment.
3772 (maintenance_show_test_options_completion_result): Change
3773 prototype. Just print
3774 maintenance_test_options_command_completion_text.
3775 (save_completion_result): New.
3776 (maintenance_test_options_completer_mode): Pass options context to
3777 complete_options, and then save a dump.
3778 (_initialize_maint_test_options): Use add_cmd to install "maint
3779 show test-options-completion-result".
3780
fdbc9870
PA
37812019-07-03 Pedro Alves <palves@redhat.com>
3782
3783 * NEWS (New commands): Mention "with" and "maint with".
3784 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3785 (with_command, with_command_completer): New.
3786 (pipe_command): Adjust to new repeat_previous
3787 interface.
3788 (_initialize_cli_cmds): Install the "with" command and its "w"
3789 alias.
3790 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3791 declarations.
3792 * cli/cli-setshow.c (parse_cli_var_uinteger)
3793 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3794 argument strings for all var_types.
3795 (get_setshow_command_value_string): New, factored out from ...
3796 (do_show_command): ... this.
3797 * cli/cli-setshow.h: Include <string>.
3798 (get_setshow_command_value_string): Declare.
3799 * command.h (repeat_previous): Now returns const char *. Adjust
3800 comment.
3801 * maint.c: Include "cli/cli-cmds.h".
3802 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3803 (_initialize_maint_cmds): Register the "maintenance with" command.
3804 * top.c (repeat_previous): Move bits from pipe_command here:
3805 Return the saved command line, if any; error out if there's no
3806 command to relaunch.
3807
c6ac8931
PA
38082019-07-03 Pedro Alves <palves@redhat.com>
3809
3810 * NEWS (New commands): Mention "maint set/show test-settings"
3811 instead of "maint test-settings".
3812 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3813 (maintenance_test_settings_set_list): Rename to ...
3814 (maintenance_set_test_settings_list): ... this.
3815 (maintenance_test_settings_show_list): Rename to ...
3816 (maintenance_show_test_settings_list): ... this.
3817 (maintenance_test_settings_cmd): Delete.
3818 (maintenance_test_settings_set_cmd): ...
3819 (maintenance_set_test_settings_cmd): ... this.
3820 (maintenance_test_settings_show_cmd): ...
3821 (maintenance_show_test_settings_cmd): ... this.
3822 (maintenance_test_settings_show_value_cmd):
3823 (maintenance_show_test_settings_value_cmd): ... this.
3824 (_initialize_maint_test_settings): No longer install the "maint
3825 test-settings" prefix command. Rename "maint test-settings set"
3826 to "maint set test-settings", and "maint test-settings show" to
3827 "maint show test-settings". Adjust all subcommands.
3828
d1fcf2fd
PA
38292019-07-03 Pedro Alves <palves@redhat.com>
3830
3831 * maint-test-settings.c: Fix file's intro comment. Replace all
3832 references to "test-options" with references to "test-settings",
3833 in comments.
3834
970f9d09
PA
38352019-07-03 Pedro Alves <palves@redhat.com>
3836
3837 * maint-test-settings.c (maintenance_test_settings_xxx)
3838 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3839 New.
3840 (maintenance_test_settings_enums): Use them.
3841 (maintenance_test_settings_enum): Default to
3842 maintenance_test_settings_xxx.
3843 (_initialize_maint_test_settings): Initialize
3844 MAINTENANCE_TEST_SETTINGS_FILENAME.
3845
f3869b1a
SM
38462019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3847
3848 * breakpoint.h (remove_breakpoints_inf): Change return type to
3849 void, move function documentation here.
3850 * breakpoint.c (remove_breakpoints_inf): Change return type to
3851 void, move function documentation to header.
3852
54d66006
PA
38532019-07-02 Pedro Alves <palves@redhat.com>
3854
3855 * NEWS (Completion improvements): Mention "info threads".
3856 * thread.c (struct info_threads_opts, info_threads_option_defs)
3857 (make_info_threads_options_def_group): New.
3858 (info_threads_command): Use gdb::option::process_options.
3859 (info_threads_command_completer): New.
3860 (_initialize_thread): Use gdb::option::build_help to build the
3861 help text for "info threads".
3862
854f6088
SM
38632019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3864
3865 * defs.h (generic_load): Move from here...
3866 * symfile.h (generic_load): ... to here. Rename name parameter
3867 to args.
3868 * symfile.c (generic_load): Add comment.
3869
54ee4252
TT
38702019-07-01 Tom Tromey <tromey@adacore.com>
3871
3872 * dwarf2read.c
3873 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3874 declaration of without_params. Fix formatting.
3875
65392b3e
TT
38762019-07-01 Tom Tromey <tromey@adacore.com>
3877
3878 * ada-exp.y (find_primitive_type): Update.
3879 * ada-lang.h (ada_lookup_symbol): Update.
3880 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3881 parameter.
3882 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3883
7d7571f0
SDJ
38842019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3885
3886 PR breakpoints/24541
3887 * gdbarch.c: Regenerate.
3888 * gdbarch.h: Regenerate.
3889 * gdbarch.sh: Add 'stap_adjust_register'.
3890 * i386-tdep.c: Include '<unordered_set>'.
3891 (i386_stap_adjust_register): New function.
3892 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3893 * stap-probe.c (stap_parse_register_operand): Call
3894 'gdbarch_stap_adjust_register'.
3895
5af5392a
SDJ
38962019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3897
3898 PR python/24742
3899 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3900 * python/python.c (do_start_initialization): Use 'xmalloc'
3901 instead of 'PyMem_Malloc'.
3902
10d06d82
TT
39032019-06-28 Tom Tromey <tromey@adacore.com>
3904
3905 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3906 for Ada.
3907
1b7f24cd
TT
39082019-06-27 Tom Tromey <tromey@adacore.com>
3909
3910 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3911 objfile_key.
3912 (arm_find_mapping_symbol, arm_record_special_symbol)
3913 (_initialize_arm_tdep): Update.
3914 (arm_objfile_data_free): Remove.
3915
3d507ff2
TT
39162019-06-27 Tom Tromey <tromey@adacore.com>
3917
3918 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3919 to cp_print_static_field.
3920
762c164d
TT
39212019-06-26 Tom Tromey <tromey@adacore.com>
3922
3923 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3924 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3925 declare.
3926
aa2f9bcf
AH
39272019-06-26 Alan Hayward <alan.hayward@arm.com>
3928
3929 * features/aarch64-core.c (create_feature_aarch64_core):
3930 Regenerate.
3931 * features/aarch64-core.xml: Add cpsr flags.
3932
3426ae57
AH
39332019-06-26 Alan Hayward <alan.hayward@arm.com>
3934
3935 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3936 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3937
4838e44c
SM
39382019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3939
3940 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3941 field.
3942 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3943 use.
3944 (arm_record_special_symbol): Don't insert new symbol in sorted
3945 position, push it at the end.
3946
54cc7474
SM
39472019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3948
3949 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3950 (arm_mapping_symbol_s): Remove.
3951 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3952 (arm_mapping_symbol_vec): New typedef.
3953 (struct arm_per_objfile): Add constructor.
3954 <section_maps>: Change type to
3955 std::unique_ptr<arm_mapping_symbol_vec[]>.
3956 (arm_compare_mapping_symbols): Remove.
3957 (arm_find_mapping_symbol): Adjust to section_maps type change.
3958 (arm_objfile_data_free): Call delete on arm_per_objfile.
3959 (arm_record_special_symbol): Adjust to section_maps type change.
3960 Allocate arm_per_objfile with new.
3961
b65b566c
PW
39622019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3963
3964 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3965 with the command prefix.
3966
c2fc64f5
TT
39672019-06-25 Tom Tromey <tom@tromey.com>
3968
3969 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3970 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3971
fb54fa76
TT
39722019-06-25 Tom Tromey <tom@tromey.com>
3973
3974 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3975 type.
3976 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3977 protected.
3978
f7952c57
TT
39792019-06-25 Tom Tromey <tom@tromey.com>
3980
3981 * tui/tui-winsource.c
3982 (tui_source_window_base::set_is_exec_point_at): Add check against
3983 LOA_ADDRESS.
3984
17568d78
TT
39852019-06-25 Tom Tromey <tom@tromey.com>
3986
3987 * tui/tui-source.c (tui_set_source_content): Don't check before
3988 xfree.
3989 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3990
53e7cdba
TT
39912019-06-25 Tom Tromey <tom@tromey.com>
3992
3993 * tui/tui-winsource.h (tui_update_source_window_as_is)
3994 (tui_alloc_source_buffer, tui_line_is_displayed)
3995 (tui_addr_is_displayed): Change type of win_info.
3996 * tui/tui-winsource.c (tui_update_source_window_as_is)
3997 (tui_clear_source_content, tui_show_source_line)
3998 (tui_show_source_content, tui_source_window_base::refill)
3999 (tui_source_window_base::set_is_exec_point_at)
4000 (tui_source_window_base::set_is_exec_point_at)
4001 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4002 (tui_alloc_source_buffer, tui_line_is_displayed)
4003 (tui_addr_is_displayed): Change type of win_info. Update.
4004 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4005 (tui_source_window_base::do_make_visible_with_new_height):
4006 Update.
4007 * tui/tui-source.c (tui_set_source_content)
4008 (tui_set_source_content_nil)
4009 (tui_source_window::do_scroll_vertical): Update.
4010 * tui/tui-layout.c (show_layout): Update.
4011 * tui/tui-disasm.c (tui_set_disassem_content)
4012 (tui_disasm_window::do_scroll_vertical): Update.
4013 * tui/tui-data.h (tui_win_content): Remove.
4014 (struct tui_gen_win_info) <content, content_size>: Remove.
4015 (struct tui_source_element): Add initializers and destructor.
4016 (union tui_which_element, struct tui_win_element): Remove.
4017 (struct tui_source_window_base) <content>: New field.
4018 (struct tui_data_window): Remove destructor.
4019 (tui_alloc_content, tui_free_win_content)
4020 (tui_free_all_source_wins_content): Don't declare.
4021 * tui/tui-data.c (tui_initialize_static_data): Update.
4022 (init_content_element, tui_alloc_content): Remove.
4023 (~tui_gen_win_info): Update.
4024 (~tui_data_window, tui_free_all_source_wins_content)
4025 (tui_free_win_content, free_content, free_content_elements):
4026 Remove.
4027
7908abbf
TT
40282019-06-25 Tom Tromey <tom@tromey.com>
4029
4030 * tui/tui-winsource.h (tui_clear_source_content)
4031 (tui_erase_source_content, tui_show_source_content): Change type
4032 of win_info.
4033 * tui/tui-winsource.c (tui_clear_source_content)
4034 (tui_erase_source_content, tui_show_source_content): Change type
4035 of win_info.
4036 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4037 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4038 win_info.
4039 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4040 win_info.
4041 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4042
02c28df0
TT
40432019-06-25 Tom Tromey <tom@tromey.com>
4044
4045 * tui/tui-winsource.c (tui_clear_source_content)
4046 (tui_source_window_base::set_is_exec_point_at): Update.
4047 * tui/tui-source.c (tui_set_source_content_nil): Update.
4048 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4049 a bool.
4050 * tui/tui-data.c (init_content_element): Update.
4051
6658b1bf
TT
40522019-06-25 Tom Tromey <tom@tromey.com>
4053
4054 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4055 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4056 * tui/tui-layout.c (init_and_make_win): Update.
4057 * tui/tui.h (enum tui_win_type): Update.
4058 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4059 tui_win_is_auxillary.
4060 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4061 tui_win_is_auxillary.
4062
21e1c91e
TT
40632019-06-25 Tom Tromey <tom@tromey.com>
4064
4065 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4066 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4067 (tui_delete_data_content_windows, tui_display_all_data)
4068 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4069 Update.
4070 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4071 * tui/tui-regs.c (tui_last_regs_line_no)
4072 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4073 (tui_show_registers): Update.
4074 (tui_show_register_group): Return void. Update.
4075 (tui_display_registers_from, tui_display_reg_element_at_line)
4076 (tui_display_registers_from_line, tui_check_register_values):
4077 Update.
4078 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4079 member.
4080 (struct tui_data_window) <regs_content>: Now a std::vector.
4081 <regs_content_count>: Remove.
4082 (tui_add_content_elements, tui_free_data_content): Don't declare.
4083 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4084 (init_content_element): Remove DATA_WIN case. Add assert.
4085 (tui_add_content_elements): Remove.
4086 (tui_data_window): Update.
4087 (tui_free_data_content): Remove.
4088 (free_content_elements): Remove DATA_WIN case.
4089
115ac53b
TT
40902019-06-25 Tom Tromey <tom@tromey.com>
4091
4092 * tui/tui-data.c (tui_data_item_window): Update.
4093 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4094 * tui/tui-windata.c (tui_display_all_data)
4095 (tui_display_data_from_line): Update.
4096 (tui_check_data_values): Remove.
4097 * tui/tui-regs.c (tui_show_register_group)
4098 (tui_display_reg_element_at_line): Update.
4099 * tui/tui-hooks.c (tui_register_changed)
4100 (tui_refresh_frame_and_register_information): Call
4101 tui_check_register_values.
4102 * tui/tui-data.h (struct tui_data_window) <data_content,
4103 data_content_count, data_type>: Remove.
4104 (enum tui_data_type): Remove.
4105
4106 * tui/tui-data.c (tui_data_window::clear_detail)
4107 (~tui_data_window): Update.
4108
eaf9738b
TT
41092019-06-25 Tom Tromey <tom@tromey.com>
4110
4111 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4112 declare.
4113 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4114 Rename from tui_first_data_item_displayed. Update.
4115 (tui_data_window::refresh_all)
4116 (tui_data_window::do_scroll_vertical): Update.
4117 * tui/tui-data.h (struct tui_data_window)
4118 <first_data_item_displayed>: Declare new method.
4119
31ca4723
TT
41202019-06-25 Tom Tromey <tom@tromey.com>
4121
4122 * tui/tui-data.h (tui_init_generic_part): Don't declare.
4123 * tui/tui-data.c (tui_init_generic_part): Remove, moving
4124 contents...
4125 (tui_initialize_static_data): ...here.
4126
41bcff7f
TT
41272019-06-25 Tom Tromey <tom@tromey.com>
4128
4129 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4130 (tui_display_registers_from, tui_check_register_values): Update.
4131 (tui_display_register): Remove win_info parameter; update.
4132 (tui_get_register): Change type of parameters.
4133 * tui/tui-data.h (struct tui_data_element): Remove.
4134 (union tui_which_element) <data>: Remove.
4135 <data_window>: Change type.
4136 (struct tui_data_item_window): New.
4137 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4138 case. Add assert.
4139 (~tui_data_item_window): New destructor.
4140 (free_content_elements): Remove DATA_ITEM_WIN case.
4141
d2802c33
TT
41422019-06-25 Tom Tromey <tom@tromey.com>
4143
4144 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4145 Remove.
4146
dd835f8b
TT
41472019-06-25 Tom Tromey <tom@tromey.com>
4148
4149 * tui/tui-data.h (struct tui_command_element): Remove.
4150 (union tui_which_element) <command>: Remove.
4151 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
4152 assert.
4153 (free_content_elements): Remove CMD_WIN case.
4154
bd7db367
TT
41552019-06-25 Tom Tromey <tom@tromey.com>
4156
4157 * tui/tui-layout.c (tui_set_layout): Update.
4158 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4159 * tui/tui-data.c (layout_def): Update.
4160
3add462f
TT
41612019-06-25 Tom Tromey <tom@tromey.com>
4162
4163 * tui/tui-wingeneral.c (tui_refresh_all): Update.
4164 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4165 (tui_source_window_base::set_new_height): Update.
4166 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4167 Update.
4168 (tui_set_locator_fullname, tui_set_locator_info)
4169 (tui_show_frame_info): Update.
4170 * tui/tui-source.c (tui_set_source_content)
4171 (tui_source_is_displayed): Update.
4172 * tui/tui-layout.c (show_source_disasm_command, show_data)
4173 (show_source_or_disasm_and_command): Update.
4174 * tui/tui-disasm.c (tui_set_disassem_content)
4175 (tui_get_begin_asm_address): Update.
4176 * tui/tui-data.h (struct tui_locator_element): Remove.
4177 (union tui_which_element) <locator>: Remove.
4178 (struct tui_locator_window): New.
4179 (tui_locator_win_info_ptr): Change return type.
4180 * tui/tui-data.c (_locator): Change type.
4181 (tui_locator_win_info_ptr): Change return type.
4182 (init_content_element): Remove LOCATOR_WIN case. Add assert.
4183 (tui_alloc_content): Add assert.
4184
489e9d8b
TT
41852019-06-25 Tom Tromey <tom@tromey.com>
4186
4187 * tui/tui-winsource.c
4188 (tui_exec_info_window::maybe_allocate_content): New method.
4189 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4190 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4191 (make_source_or_disasm_window): Add cast.
4192 * tui/tui-data.h (union tui_which_element) <simple_string>:
4193 Remove.
4194 (struct tui_source_info): New.
4195 (struct tui_source_window_base) <execution_info>: Change type.
4196 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4197 case, and add assert.
4198 (tui_alloc_content): Add assert.
4199
c3fabb7d
TT
42002019-06-25 Tom Tromey <tom@tromey.com>
4201
4202 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4203 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4204 * tui/tui-data.c (tui_alloc_win_info): Remove.
4205
bbc228ee
TT
42062019-06-25 Tom Tromey <tom@tromey.com>
4207
4208 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4209 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4210 can_highlight.
4211
5fcee43a
TT
42122019-06-25 Tom Tromey <tom@tromey.com>
4213
4214 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4215 make_visible_with_new_height method.
4216 (tui_win_info::make_visible_with_new_height): New method.
4217 (tui_source_window_base::do_make_visible_with_new_height)
4218 (tui_data_window::do_make_visible_with_new_height)
4219 (tui_cmd_window::do_make_visible_with_new_height): New methods.
4220 (make_visible_with_new_height): Remove.
4221 (tui_resize_all, tui_adjust_win_heights): Use
4222 make_visible_with_new_height method.
4223 * tui/tui-data.h (struct tui_win_info)
4224 <do_make_visible_with_new_height, make_visible_with_new_height>:
4225 New methods.
4226 (struct tui_source_window_base, struct tui_data_window)
4227 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4228 methods.
4229
d83f1fe6
TT
42302019-06-25 Tom Tromey <tom@tromey.com>
4231
4232 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4233 method.
4234 (update_tab_width): Call update_tab_width method.
4235 * tui/tui-data.h (struct tui_win_info)
4236 (struct tui_source_window_base) <update_tab_width>: New methods.
4237
17374de4
TT
42382019-06-25 Tom Tromey <tom@tromey.com>
4239
4240 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4241 parameter.
4242 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4243 parameter.
4244 (tui_gen_win_info::make_visible): Update.
4245 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4246 parameter.
4247 * tui/tui-data.h (enum tui_box): New enum.
4248 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4249
f936bca2
TT
42502019-06-25 Tom Tromey <tom@tromey.com>
4251
4252 * tui/tui-layout.c (make_source_or_disasm_window): Always use
4253 init_and_make_win for EXEC_INFO_WIN.
4254 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4255 longer inline.
4256 (struct tui_win_info) <~tui_win_info>: Inline.
4257 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4258 Don't declare.
4259 * tui/tui-data.c (source_win, disasm_win): Remove globals.
4260 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4261 Remove.
4262 (tui_initialize_static_data): Update.
4263 (~tui_gen_win_info): Handle more cleanup here.
4264 (~tui_source_window_base): Delete "execution_info".
4265 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4266
d6ba6a11
TT
42672019-06-25 Tom Tromey <tom@tromey.com>
4268
4269 * tui/tui-layout.c (make_command_window): Don't set
4270 can_highlight.
4271 (show_source_disasm_command): Call the reset method.
4272 (show_data): Don't set can_highlight. Call the reset method.
4273 (tui_gen_win_info::reset): Rename from init_gen_win_info
4274 (init_and_make_win): Simplify. Return tui_gen_win_info.
4275 (show_source_or_disasm_and_command): Call the reset method.
4276 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4277 (struct tui_cmd_window): Set can_highlight.
4278
48a3bd16
TT
42792019-06-25 Tom Tromey <tom@tromey.com>
4280
4281 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4282 from make_visible.
4283 (tui_make_visible, tui_make_invisible): Rewrite.
4284 (tui_win_info::make_visible): Remove.
4285 (tui_source_window_base::make_visible): Update.
4286 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4287 method. Moved from...
4288 (struct tui_win_info) <make_visible>: ...here.
4289
c3bd716f
TT
42902019-06-25 Tom Tromey <tom@tromey.com>
4291
4292 * tui/tui-winsource.c
4293 (tui_source_window_base::do_scroll_horizontal): Remove direction
4294 parameter.
4295 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4296 direction parameter.
4297 * tui/tui-win.c (tui_win_info::forward_scroll)
4298 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4299 (tui_win_info::right_scroll): Update.
4300 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4301 direction parameter.
4302 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4303 direction parameter.
4304 * tui/tui-data.h (enum tui_scroll_direction): Remove.
4305 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4306 Remove direction parameter.
4307 (struct tui_source_window_base, struct tui_source_window)
4308 (struct tui_disasm_window, struct tui_data_window)
4309 (struct tui_cmd_window): Update.
4310
21c32dca
TT
43112019-06-25 Tom Tromey <tom@tromey.com>
4312
4313 * tui/tui-winsource.h (tui_set_exec_info_content)
4314 (tui_show_exec_info_content, tui_erase_exec_info_content)
4315 (tui_clear_exec_info_content, tui_update_exec_info): Change
4316 argument to tui_source_window_base.
4317 * tui/tui-winsource.c (tui_set_exec_info_content)
4318 (tui_show_exec_info_content, tui_erase_exec_info_content)
4319 (tui_clear_exec_info_content, tui_update_exec_info): Change
4320 argument to tui_source_window_base.
4321
73fbdc65
TT
43222019-06-25 Tom Tromey <tom@tromey.com>
4323
4324 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4325 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4326
33325343
TT
43272019-06-25 Tom Tromey <tom@tromey.com>
4328
4329 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4330 check.
4331
29d2c474
TT
43322019-06-25 Tom Tromey <tom@tromey.com>
4333
4334 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4335 type to void.
4336 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4337 type to void.
4338 * tui/tui-source.c (tui_set_source_content): Update.
4339 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4340
152f3f4b
TT
43412019-06-25 Tom Tromey <tom@tromey.com>
4342
4343 * tui/tui-win.c (window_name_completer, tui_set_focus)
4344 (tui_all_windows_info): Use name method.
4345 * tui/tui-data.h (struct tui_gen_win_info)
4346 (struct tui_source_window, struct tui_disasm_window)
4347 (struct tui_data_window, struct tui_cmd_window) <name>: New
4348 method.
4349 (tui_win_name): Don't declare.
4350 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4351 (tui_win_name): Remove.
4352
be4da588
TT
43532019-06-25 Tom Tromey <tom@tromey.com>
4354
4355 * tui/tui-winsource.h (tui_update_source_window)
4356 (tui_update_source_window_as_is): Change parameter type.
4357 * tui/tui-winsource.c (tui_update_source_window): Change win_info
4358 to be a tui_source_window_base.
4359 (tui_update_source_window_as_is): Likewise.
4360 * tui/tui-win.c (make_visible_with_new_height): Update.
4361
5b81daba
TT
43622019-06-25 Tom Tromey <tom@tromey.com>
4363
4364 * tui/tui-winsource.c (tui_erase_source_content)
4365 (tui_show_source_content, tui_show_exec_info_content)
4366 (tui_erase_exec_info_content): Use refresh_window method.
4367 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4368 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4369 from tui_refresh_win.
4370 (tui_data_window::refresh_window): New method.
4371 (tui_win_info::refresh, tui_source_window_base::refresh)
4372 (tui_refresh_all): Use refresh_window method.
4373 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4374 method.
4375 * tui/tui-regs.c (tui_display_register): Call refresh_window
4376 method.
4377 * tui/tui-layout.c (show_source_disasm_command)
4378 (show_source_or_disasm_and_command): Call refresh_window method.
4379 * tui/tui-data.h (struct tui_gen_win_info)
4380 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4381 New method.
4382
cb2ce893
TT
43832019-06-25 Tom Tromey <tom@tromey.com>
4384
4385 * tui/tui.c (tui_rl_other_window, tui_enable)
4386 (tui_is_window_visible, tui_get_command_dimension): Update.
4387 * tui/tui-winsource.c (tui_update_source_window_as_is)
4388 (tui_clear_source_content, tui_erase_source_content)
4389 (tui_show_source_line, tui_source_window_base::refill)
4390 (tui_source_window_base::do_scroll_horizontal)
4391 (tui_source_window_base::set_is_exec_point_at)
4392 (tui_update_breakpoint_info, tui_set_exec_info_content)
4393 (tui_alloc_source_buffer, tui_line_is_displayed)
4394 (tui_addr_is_displayed): Update.
4395 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4396 (tui_check_and_display_highlight_if_needed)
4397 (tui_win_info::make_visible, tui_win_info::refresh)
4398 (tui_refresh_all): Update.
4399 * tui/tui-windata.c (tui_first_data_item_displayed)
4400 (tui_delete_data_content_windows, tui_erase_data_content)
4401 (tui_display_all_data, tui_data_window::refresh_all)
4402 (tui_check_data_values): Update.
4403 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4404 (tui_set_win_focus_to, tui_win_info::forward_scroll)
4405 (tui_win_info::backward_scroll, tui_refresh_all_win)
4406 (tui_resize_all, tui_set_focus, tui_all_windows_info)
4407 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4408 (tui_source_window_base::set_new_height)
4409 (tui_data_window::set_new_height)
4410 (make_invisible_and_set_new_height)
4411 (make_visible_with_new_height, new_height_ok)
4412 (parse_scrolling_args): Update.
4413 * tui/tui-stack.c (tui_show_frame_info): Update.
4414 * tui/tui-source.c (tui_set_source_content)
4415 (tui_set_source_content_nil, tui_source_is_displayed)
4416 (tui_source_window::do_scroll_vertical): Update.
4417 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4418 (tui_display_registers_from, tui_display_reg_element_at_line)
4419 (tui_check_register_values, tui_reg_command): Update.
4420 * tui/tui-layout.c (tui_default_win_height)
4421 (show_source_disasm_command, show_data, init_and_make_win)
4422 (show_source_or_disasm_and_command): Update.
4423 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4424 (tui_redisplay_readline, tui_mld_flush)
4425 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4426 (tui_getc): Update.
4427 * tui/tui-disasm.c (tui_set_disassem_content)
4428 (tui_disasm_window::do_scroll_vertical): Update.
4429 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4430 Now virtual.
4431 (struct tui_win_info): Derive from tui_gen_win_info.
4432 <~tui_win_info>: Mark as override.
4433 <generic>: Remove member.
4434 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4435 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4436 (~tui_data_window, ~tui_win_info)
4437 (tui_free_all_source_wins_content): Update.
4438 * tui/tui-command.c (tui_refresh_cmd_win): Update.
4439
ab313b35
TT
44402019-06-25 Tom Tromey <tom@tromey.com>
4441
4442 * tui/tui-layout.c (init_and_make_win): Use new.
4443 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4444 destructor, initializers.
4445 (tui_alloc_generic_win_info): Don't declare.
4446 * tui/tui-data.c (_locator): Add argument to constructor.
4447 (source_win, disasm_win): New globals.
4448 (exec_info): Remove.
4449 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4450 Update.
4451 (tui_alloc_generic_win_info): Remove.
4452 (init_content_element): Use new.
4453 (tui_win_info::tui_win_info): Update.
4454 (free_content_elements) <case DATA_WIN>: Use delete.
4455
dc2c33e4
TT
44562019-06-25 Tom Tromey <tom@tromey.com>
4457
4458 * tui/tui-wingeneral.c (tui_refresh_win): Update.
4459 * tui/tui-windata.c (tui_first_data_item_displayed)
4460 (tui_delete_data_content_windows): Update.
4461 * tui/tui-win.c (tui_data_window::set_new_height): Update.
4462 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4463 (tui_display_registers_from, tui_check_register_values): Update.
4464 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4465 pointer.
4466 * tui/tui-data.c (init_content_element): Update. Allocate the new
4467 window.
4468 (tui_free_data_content): Update.
4469 (free_content_elements) <case DATA_WIN>: Free the window.
4470
214a5cbe
TT
44712019-06-25 Tom Tromey <tom@tromey.com>
4472
4473 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4474 Update.
4475 * tui/tui-layout.c (make_command_window)
4476 (show_source_disasm_command, show_data, init_and_make_win)
4477 (show_source_or_disasm_and_command): Update.
4478 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4479 method.
4480 <can_highight, is_highlighted>: Now bool.
4481 (tui_set_win_highlight): Don't declare.
4482 * tui/tui-data.c (tui_set_win_highlight): Remove.
4483
8e2daf15
TT
44842019-06-25 Tom Tromey <tom@tromey.com>
4485
4486 * tui/tui-wingeneral.c (make_visible): Remove check of window
4487 type.
4488
8903bd8a
TT
44892019-06-25 Tom Tromey <tom@tromey.com>
4490
4491 * tui/tui-win.c (tui_win_info::max_height)
4492 (tui_cmd_window::max_height): New methods.
4493 (new_height_ok): Call max_height.
4494 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4495 <max_height>: New method.
4496
3f02ce1e
TT
44972019-06-25 Tom Tromey <tom@tromey.com>
4498
4499 * tui/tui-win.c (tui_source_window_base::set_new_height)
4500 (tui_data_window::set_new_height): New methods.
4501 (make_invisible_and_set_new_height): Call set_new_height method.
4502 * tui/tui-data.h (struct tui_win_info)
4503 (struct tui_source_window_base, struct tui_data_window)
4504 <set_new_height>: New method.
4505
1825f487
TT
45062019-06-25 Tom Tromey <tom@tromey.com>
4507
4508 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4509 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4510 tui_refresh_data_win.
4511 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4512 method.
4513 (tui_refresh_all_win): Call the refresh_all method.
4514 (tui_set_focus): Likewise.
4515 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4516 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4517 Likewise.
4518
ad54d15b
TT
45192019-06-25 Tom Tromey <tom@tromey.com>
4520
4521 * tui/tui-winsource.h (tui_refill_source_window)
4522 (tui_set_is_exec_point_at): Don't declare.
4523 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4524 (tui_source_window_base::refill): Rename from
4525 tui_refill_source_window.
4526 (tui_source_window_base::do_scroll_horizontal): Update.
4527 (tui_source_window_base::set_is_exec_point_at): Rename from
4528 tui_set_is_exec_point_at.
4529 (tui_update_all_breakpoint_info): Update.
4530 * tui/tui-stack.c (tui_show_frame_info): Update.
4531 * tui/tui-layout.c (show_data): Add cast.
4532 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4533 * tui/tui-data.h (struct tui_source_window_base) <refill,
4534 set_is_exec_point_at>: New methods.
4535 (tui_source_windows, tui_add_to_source_windows): Update types.
4536 (tui_add_to_source_windows): Remove redundant declaration.
4537 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4538 (tui_source_windows): Change return type.
4539 (tui_clear_source_windows_detail): Update.
4540 (tui_add_to_source_windows): Change type of parameter.
4541 (tui_free_all_source_wins_content): Update.
4542
2042b506
TT
45432019-06-25 Tom Tromey <tom@tromey.com>
4544
4545 * tui/tui-wingeneral.c (tui_win_info::refresh)
4546 (tui_source_window_base::refresh): New methods.
4547 (tui_refresh_all): Call the refresh method.
4548 * tui/tui-data.h (struct tui_win_info)
4549 (struct tui_source_window_base) <refresh>: New method.
4550
56122977
TT
45512019-06-25 Tom Tromey <tom@tromey.com>
4552
4553 * tui/tui.h (tui_is_window_visible): Return bool.
4554 * tui/tui.c (tui_is_window_visible): Return bool.
4555 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4556 (tui_make_visible, tui_make_invisible)
4557 (tui_win_info::make_visible)
4558 (tui_source_window_base::make_visible, make_all_visible)
4559 (tui_make_all_visible, tui_make_all_invisible): Update.
4560 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4561 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4562 bool.
4563 (struct tui_win_info, struct tui_source_window_base)
4564 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4565 * tui/tui-data.c (tui_init_generic_part): Update.
4566
cda37efb
TT
45672019-06-25 Tom Tromey <tom@tromey.com>
4568
4569 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4570 (tui_source_window_base::make_visible): New methods.
4571 (make_all_visible): Make method call.
4572 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4573 (struct tui_source_window_base, struct tui_cmd_window): Override
4574 make_visible.
4575 (tui_win_is_source_type): Don't declare.
4576 * tui/tui-data.c (tui_win_is_source_type): Remove.
4577
6a0ee02c
TT
45782019-06-25 Tom Tromey <tom@tromey.com>
4579
4580 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4581 NULL check.
4582
63901aec
TT
45832019-06-25 Tom Tromey <tom@tromey.com>
4584
4585 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4586 Inline constructor. Add initializers for members.
4587 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4588 constructors; now inline in class.
4589
ceb13a13
TT
45902019-06-25 Tom Tromey <tom@tromey.com>
4591
4592 * tui/tui-regs.c (tui_show_registers): Update.
4593 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4594 bool.
4595 * tui/tui-data.c (tui_data_window::clear_detail)
4596 (tui_data_window): Update.
4597
238eb706
TT
45982019-06-25 Tom Tromey <tom@tromey.com>
4599
4600 * tui/tui-windata.c (tui_display_all_data)
4601 (tui_display_data_from_line, tui_display_data_from)
4602 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4603 Update.
4604 * tui/tui-regs.c (tui_last_regs_line_no)
4605 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4606 (tui_show_registers, tui_show_register_group)
4607 (tui_display_registers_from, tui_display_reg_element_at_line)
4608 (tui_display_registers_from_line, tui_check_register_values)
4609 (tui_reg_next, tui_reg_prev): Update.
4610 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4611 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4612 tui_data_window.
4613 (struct tui_win_info) <detail>: Remove. Add new fields from
4614 tui_data_info.
4615 (TUI_DATA_WIN): Add cast.
4616 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4617 (~tui_data_window): Simplify.
4618
81491aa0
TT
46192019-06-25 Tom Tromey <tom@tromey.com>
4620
4621 * tui/tui-layout.c (show_source_disasm_command)
4622 (show_source_or_disasm_and_command): Update.
4623 * tui/tui-io.c (update_cmdwin_start_line)
4624 (tui_redisplay_readline): Update.
4625 * tui/tui-data.h (struct tui_command_info): Remove.
4626 (struct tui_win_info) <detail>: Remove command_info member.
4627 (struct tui_data_window) <start_line>: New member, from
4628 tui_command_info.
4629 (TUI_CMD_WIN): Add casts.
4630
e6e41501
TT
46312019-06-25 Tom Tromey <tom@tromey.com>
4632
4633 * tui/tui-winsource.c (tui_update_source_window)
4634 (tui_refill_source_window)
4635 (tui_source_window_base::do_scroll_horizontal)
4636 (tui_update_breakpoint_info, tui_set_exec_info_content)
4637 (tui_show_exec_info_content, tui_erase_exec_info_content)
4638 (tui_clear_exec_info_content): Update.
4639 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4640 Update.
4641 * tui/tui-win.c (make_invisible_and_set_new_height)
4642 (make_visible_with_new_height): Update.
4643 * tui/tui-source.c (tui_set_source_content)
4644 (tui_show_symtab_source): Update.
4645 * tui/tui-layout.c (extract_display_start_addr)
4646 (show_source_disasm_command, show_data)
4647 (make_source_or_disasm_window)
4648 (show_source_or_disasm_and_command): Update.
4649 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4650 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4651 "gdbarch".
4652 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4653 to tui_source_window_base.
4654 (struct tui_win_info) <detail>: Remove source_info member.
4655 (struct tui_source_window_base) <has_locator>: Inline.
4656 Move contents from tui_source_info; rename has_locator member to
4657 m_has_locator.
4658 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4659 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4660 header file.
4661 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4662 Simplify.
4663 (tui_free_all_source_wins_content): Cast to
4664 tui_source_window_base.
4665
44f0e208
TT
46662019-06-25 Tom Tromey <tom@tromey.com>
4667
4668 * tui/tui-win.c (make_invisible_and_set_new_height)
4669 (make_visible_with_new_height): Call has_locator method.
4670 * tui/tui-layout.c (show_source_disasm_command, show_data)
4671 (show_source_or_disasm_and_command): Update for bool change.
4672 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4673 (tui_win_info) <has_locator>: New method.
4674 (struct tui_source_window_base) <has_locator>: New method.
4675 (tui_win_has_locator): Don't declare.
4676 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4677 from tui_win_has_locator.
4678 (tui_source_window_base): Use false, not FALSE.
4679
7778b912
TT
46802019-06-25 Tom Tromey <tom@tromey.com>
4681
4682 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4683 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4684 clear_detail method directly.
4685 (tui_clear_win_detail): Remove.
4686
f83d391c
TT
46872019-06-25 Tom Tromey <tom@tromey.com>
4688
4689 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4690 "this", not TUI_DISASM_WIN.
4691
13446e05
TT
46922019-06-25 Tom Tromey <tom@tromey.com>
4693
4694 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4695 declare.
4696 * tui/tui-winsource.c
4697 (tui_source_window_base::do_scroll_horizontal): Rename from
4698 tui_horizontal_source_scroll.
4699 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4700 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4701 from tui_vertical_data_scroll.
4702 * tui/tui-win.h (tui_scroll): Don't declare.
4703 * tui/tui-win.c (tui_win_info::forward_scroll)
4704 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4705 (tui_win_info::right_scroll): Rename and update.
4706 (tui_scroll_forward_command, tui_scroll_backward_command)
4707 (tui_scroll_left_command, tui_scroll_right_command): Update.
4708 (tui_scroll): Remove.
4709 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4710 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4711 from tui_vertical_source_scroll.
4712 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4713 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4714 from tui_vertical_disassem_scroll.
4715 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4716 do_scroll_horizontal>: New methods.
4717 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4718 Likewise.
4719 (struct tui_source_window_base): Add do_scroll_horizontal.
4720 (struct tui_source_window, struct tui_disasm_window): Add
4721 do_scroll_vertical.
4722 (struct tui_data_window, struct tui_cmd_window): Add
4723 do_scroll_horizontal and do_scroll_vertical.
4724 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4725
5cf82909
TT
47262019-06-25 Tom Tromey <tom@tromey.com>
4727
4728 * tui/tui-data.h (struct tui_source_window_base): New struct.
4729 (struct tui_source_window): Derive from tui_source_window_base.
4730 (struct tui_disasm_window): New struct.
4731 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4732 from tui_source_window::clear_detail.
4733 (tui_source_window_base): Rename from tui_source_window.
4734 (~tui_source_window_base): Rename from ~tui_source_window.
4735 (tui_alloc_win_info): Create a tui_disasm_window.
4736
ee1d42d6
TT
47372019-06-25 Tom Tromey <tom@tromey.com>
4738
4739 * tui/tui-data.h (struct tui_source_window)
4740 (struct tui_data_window): Declare destructors.
4741 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4742 destructors.
4743 (tui_win_info): Simplify.
4744
b4eb2452
TT
47452019-06-25 Tom Tromey <tom@tromey.com>
4746
4747 * tui/tui-winsource.c (tui_display_main)
4748 (tui_update_source_windows_with_addr)
4749 (tui_update_all_breakpoint_info): Update.
4750 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4751 (new_height_ok, parse_scrolling_args): Update.
4752 * tui/tui-stack.c (tui_show_frame_info): Update.
4753 * tui/tui-data.h (struct tui_list): Remove.
4754 (tui_source_windows): Return a reference to a std::vector.
4755 * tui/tui-data.c (source_windows): Now a std::vector.
4756 (tui_source_windows): Change return type.
4757 (tui_clear_source_windows): Rewrite.
4758 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4759 (tui_free_all_source_wins_content): Rewrite.
4760
8761a91b
TT
47612019-06-25 Tom Tromey <tom@tromey.com>
4762
4763 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4764 (struct tui_data_window, struct tui_cmd_window): Declare
4765 clear_detail method.
4766 * tui/tui-data.c (tui_source_window::clear_detail)
4767 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4768 methods.
4769 (tui_clear_win_detail): Simplify.
4770
0ed69eda
TT
47712019-06-25 Tom Tromey <tom@tromey.com>
4772
4773 * tui/tui-layout.c (make_source_window, make_disasm_window)
4774 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4775 Return the new window.
4776 (show_source_disasm_command, show_data)
4777 (show_source_or_disasm_and_command): Update.
4778
82432e10
TT
47792019-06-25 Tom Tromey <tom@tromey.com>
4780
4781 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4782 parameter. Return the new window.
4783 (show_source_disasm_command): Update and remove NULL check.
4784 (show_source_or_disasm_and_command): Update.
4785
ec328aa5
TT
47862019-06-25 Tom Tromey <tom@tromey.com>
4787
4788 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4789
33b906ab
TT
47902019-06-25 Tom Tromey <tom@tromey.com>
4791
4792 * tui/tui-data.h (struct tui_win_info): Make constructor
4793 protected. Make destructor virtual. Add initializers.
4794 (tui_source_window, tui_data_window, tui_cmd_window): New
4795 classes.
4796 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4797 constructor. Add "type" parameter.
4798 (tui_source_window, tui_data_window, tui_cmd_window): New
4799 constructors.
4800 (tui_alloc_win_info): Instantiate the appropriate subclass.
4801
e7e11af4
TT
48022019-06-25 Tom Tromey <tom@tromey.com>
4803
4804 * tui/tui-win.c (tui_resize_all): Use delete.
4805 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4806 destructor.
4807 (tui_free_window): Don't declare.
4808 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4809 Update.
4810
6792b55e
TT
48112019-06-25 Tom Tromey <tom@tromey.com>
4812
4813 * tui/tui-data.h (struct tui_win_info): Add constructor.
4814 * tui/tui-data.c (tui_alloc_win_info): Use new.
4815 (tui_free_window): Use delete.
4816
f95675e1
TT
48172019-06-22 Tom Tromey <tom@tromey.com>
4818
4819 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4820 declare.
4821 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4822
5bff081c
TT
48232019-06-22 Tom Tromey <tom@tromey.com>
4824
4825 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4826 declare.
4827 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4828
47e3f474
TV
48292019-06-22 Tom de Vries <tdevries@suse.de>
4830
4831 * dwarf2read.c (create_addrmap_from_aranges)
4832 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4833 instead of '%zu'.
4834
fd5866f6
SM
48352019-06-21 Simon Marchi <simon.marchi@efficios.com>
4836
4837 * dwarf2read.h (dwarf2_section_info_def): Remove.
4838 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4839 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4840 std::vector<dwarf2_section_info>.
4841 (struct dwo_file) <~dwo_file>: Remove.
4842 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4843 types field.
4844 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4845 (dwarf2_read_debug_names): Likewise.
4846 (create_debug_types_hash_table): Change parameter type to
4847 array_view, adjust code accordingly.
4848 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4849 (partial_die_info::fixup): Likewise.
4850 (determine_prefix): Likewise.
4851 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4852
fb1eb2f9
SM
48532019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4854
4855 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4856 gdb_bfd_ref_ptr.
4857 <~dwo_file>: Remove call to gdb_bfd_unref.
4858 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4859 gdb_bfd_ref_ptr::get.
4860
51ac9db5
SM
48612019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4862
4863 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4864 type to htab_up.
4865 * dwarf2read.c (struct dwo_file): Initialize fields.
4866 <~dwo_file>: New.
4867 (free_dwo_file): Remove, move content to ~dwo_file.
4868 (struct dwo_file_deleter): Remove.
4869 (dwo_file_up>: Remove custom deleter.
4870 (free_dwo_files): Remove.
4871 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4872 dwo_files.
4873 (process_skeletonless_type_units): Call unique_ptr::get.
4874 (allocate_dwo_file_hash_table): Add deleter to created hash
4875 table. Change return type to htab_up.
4876 (lookup_dwo_file_slot): Don't memset dwo_file, call
4877 unique_ptr::get.
4878 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4879 (create_dwo_unit_in_dwp_v2): Likewise.
4880 (open_and_init_dwo_file): Likewise.
4881 (free_dwo_file_from_slot): Remove.
4882
dc4ccb6f
SM
48832019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4884
4885 * dwarf2read.h (struct dwarf2_section_info) <readin,
4886 is_virtual>: Change type to bool.
4887 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4888 true instead of 1.
4889
e6a1c5cb
TT
48902019-06-19 Tom Tromey <tom@tromey.com>
4891
4892 * tui/tui-data.h (tui_init_content_element): Don't declare.
4893
6f6ffbeb
TT
48942019-06-19 Tom Tromey <tom@tromey.com>
4895
4896 * tui/tui-data.h (tui_init_win_info): Don't declare.
4897
f23f598e
TV
48982019-06-19 Tom de Vries <tdevries@suse.de>
4899
4900 * dwarf2read.h (abstract_to_concrete): Change type to
4901 std::unordered_map<sect_offset, std::vector<sect_offset>,
4902 gdb::hash_enum<sect_offset>>.
4903
680e1bee
TT
49042019-06-19 Tom Tromey <tromey@adacore.com>
4905
4906 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4907 EVAL_AVOID_SIDE_EFFECTS specially.
4908
dcf37923
TT
49092019-06-19 Tom Tromey <tromey@adacore.com>
4910
4911 * source-cache.c (highlighter): New global.
4912 (source_cache::get_source_lines): Create a highlighter on demand.
4913
494986d5
AB
49142019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4915
4916 * defs.h (deprecated_interactive_hook): Delete declaration.
4917 * interps.c (clear_interpreter_hooks): Remove use of
4918 deprecated_interactive_hook.
4919 * top.c (deprecated_interactive_hook): Delete definition.
4920 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4921
3360b6e7
TV
49222019-06-18 Tom de Vries <tdevries@suse.de>
4923
4924 PR gdb/24515
4925 * dwarf2read.h (abstract_to_concrete): Change type from
4926 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4927 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4928 * dwarf2read.c (read_variable): Update.
4929 (dwarf2_fetch_die_loc_sect_off): Update.
4930
310b3441
TV
49312019-06-17 Tom de Vries <tdevries@suse.de>
4932
4933 PR gdb/24617
4934 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4935 accessing parent[parent_len - 1].
4936
ba9777be
PP
49372019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4938
4939 PR gdb/24364
4940 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4941 call dtrace_process_dof with NULL dof.
4942
2b9f6e89
TV
49432019-06-16 Tom de Vries <tdevries@suse.de>
4944
4945 PR gdb/24445
4946 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4947
431b3ead
TT
49482019-06-16 Tom Tromey <tom@tromey.com>
4949
4950 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4951 (make_all_visible): Use address of member.
4952
d04b44a1
TT
49532019-06-16 Tom Tromey <tom@tromey.com>
4954
4955 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4956 (tui_free_window, free_content, free_content_elements): Remove
4957 unnecessary cast.
4958 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4959 cast.
4960 * tui/tui-regs.c (tui_show_register_group)
4961 (tui_display_registers_from, tui_display_reg_element_at_line):
4962 Remove unnecessary cast.
4963
bf5142e7
AB
49642019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4965
4966 * linux-nat.c (normal_mask): Delete.
4967 (_initialize_linux_nat): Don't initialise normal_mask.
4968
c4973306
SM
49692019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4970
4971 PR gdb/24445
4972 * dwarf-index-write.h (write_psymtabs_to_index): Add
4973 dwz_basename parameter.
4974 * dwarf-index-write.c (write_gdbindex): Move file writing to
4975 write_gdbindex_1. Change return type void.
4976 (assert_file_size): Move up, remove filename parameter.
4977 (write_gdbindex_1): New function.
4978 (write_debug_names): Change return type to void, call
4979 assert_file_size.
4980 (struct index_wip_file): New struct.
4981 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4982 file logic to index_wip_file. Write index for dwz file if
4983 needed.
4984 (save_gdb_index_command): Pass basename of dwz file, if present.
4985 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4986 build-id of dwz file, if present.
4987 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4988 (dwarf2_get_dwz_file): Likewise.
4989 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4990 (dwarf2_get_dwz_file): Likewise.
4991
395f9c91
TT
49922019-06-16 Tom Tromey <tom@tromey.com>
4993
4994 * coffread.c (process_coff_symbol): Use xstrdup.
4995 * value.c (create_internalvar): Use xstrdup.
4996
cafb3438
TT
49972019-06-16 Tom Tromey <tom@tromey.com>
4998
4999 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5000 * breakpoint.c (stopin_command, stopat_command)
5001 (until_break_command, decode_location_default): Remove unnecessary
5002 cast.
5003 * utils.c (subset_compare): Remove unnecessary cast.
5004 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5005 cast.
5006 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5007 cast.
5008 * infcmd.c (path_command): Remove unnecessary cast.
5009 * coffread.c (decode_type): Remove unnecessary cast.
5010 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5011 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5012 * tui/tui-stack.c (tui_show_locator_content)
5013 (tui_show_frame_info): Remove unnecessary cast.
5014 * tui/tui-win.c (tui_scroll_forward_command)
5015 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5016 (parse_scrolling_args): Remove unnecessary cast.
5017 * tui/tui-data.c (init_win_info, tui_del_window)
5018 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5019 (free_content_elements): Remove unnecessary cast.
5020 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5021 unnecessary cast.
5022 * tui/tui-source.c (tui_set_source_content)
5023 (tui_vertical_source_scroll): Remove unnecessary cast.
5024 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5025 cast.
5026 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5027 * tui/tui-regs.c (tui_display_registers_from)
5028 (tui_display_register): Remove unnecessary cast.
5029 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5030 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5031 (make_visible): Remove unnecessary cast.
5032 * tui/tui-winsource.c (tui_erase_source_content)
5033 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5034 unnecessary cast.
5035 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5036 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5037 * stabsread.c (read_type, read_array_type, read_range_type):
5038 Remove unnecessary cast.
5039 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5040 (parse_symbol, parse_type, upgrade_type, parse_external)
5041 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5042 unnecessary cast.
5043 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5044
730ead81
TT
50452019-06-16 Tom Tromey <tom@tromey.com>
5046
5047 * tui/tui-data.c (tui_alloc_generic_win_info)
5048 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5049 checks.
5050
584a927c
AB
50512019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5052 Andrew Burgess <andrew.burgess@embecosm.com>
5053
5054 * f-typeprint.c (f_print_type): Don't return early for not
5055 associated or not allocated types.
5056 (f_type_print_varspec_suffix): Add print_rank parameter and print
5057 ranks of array types in case they dangling.
5058 (f_type_print_base): Add print_rank parameter.
5059
30056ea0
AB
50602019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5061
5062 * NEWS: Mention new MI commands.
5063 * break-catch-throw.c (enum exception_event_kind): Move to
5064 breakpoint.h.
5065 (print_mention_exception_catchpoint): Output text as a single
5066 message.
5067 (catch_exception_command_1): Rename to...
5068 (catch_exception_event): ...this, make non-static, update header
5069 command, and change some parameter types.
5070 (catch_catch_command): Update for changes to
5071 catch_exception_command_1.
5072 (catch_throw_command): Likewise.
5073 (catch_rethrow_command): Likewise.
5074 * breakpoint.c (enum exception_event_kind): Delete.
5075 * breakpoint.h (enum exception_event_kind): Moved here from
5076 break-catch-throw.c.
5077 (catch_exception_event): Declare.
5078 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5079 (mi_cmd_catch_throw): New function.
5080 (mi_cmd_catch_rethrow): New function.
5081 (mi_cmd_catch_catch): New function.
5082 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5083 'catch-catch' entries.
5084 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5085 (mi_cmd_catch_rethrow): Declare.
5086 (mi_cmd_catch_catch): Declare.
5087
ec8e2b6d
AB
50882019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5089
5090 * annotate.c (annotate_source_line): Change return type to void,
5091 update implementation to match.
5092 * annotate.h (annotate_source_line): Change return type to void,
5093 update header comment.
5094 * stack.c (print_frame_info): Don't change what frame information
5095 is printed based on whether annotations are on or not.
5096
0d3abd8c
AB
50972019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5098
5099 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5100 (annotate_source): Make static.
5101 (annotate_source_line): Moved from source.c and renamed from
5102 identify_source_line. Update the return type.
5103 * annotate.h (annotate_source): Delete declaration.
5104 (annotate_source_line): Declaration moved from source.h, and
5105 renamed from identify_source_line. Return type updated.
5106 * source.c (identify_source_line): Moved to annotate.c and renamed
5107 to annotate_source_line.
5108 (info_line_command): Remove check of annotation_level.
5109 * source.h (identify_source_line): Move declaration to annotate.h
5110 and rename to annotate_source_line.
5111 * stack.c: Add 'annotate.h' include.
5112 (print_frame_info): Remove check of annotation_level before
5113 calling annotate_source_line.
5114
00df30ae
AB
51152019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5116
5117 * source-cache.c (source_cache::get_plain_source_lines): Use
5118 open_source_file_with_line_charpos instead of just
5119 open_source_file, remove call to find_source_lines.
5120 (source_cache::get_source_lines): Likewise.
5121 * source.c (find_source_lines): Make static.
5122 (get_filename_and_charpos): Renamed into...
5123 (open_source_file_with_line_charpos): ..this along with changes to
5124 return a scoped_fd, and some other minor clean ups.
5125 (identify_source_line): Use open_source_file_with_line_charpos.
5126 (search_command_helper): Use open_source_file_with_line_charpos
5127 instead of just open_source_file, remove call to
5128 find_source_lines.
5129 * source.h (open_source_file_with_line_charpos): Declare new
5130 function.
5131 (find_source_lines): Delete declaration.
5132
afda45a2
AB
51332019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5134
5135 * source.c (get_filename_and_charpos): Remove fullname
5136 parameter.
5137 (identify_source_line): Update call to get_filename_and_charpos.
5138
0735b091
TT
51392019-06-14 Tom Tromey <tromey@adacore.com>
5140
5141 PR gdb/24502:
5142 * ui-style.h (skip_ansi_escape): Update comment.
5143 * ui-file.h (class no_terminal_escape_file): New class.
5144 * ui-file.c (no_terminal_escape_file::write)
5145 (no_terminal_escape_file::puts): New methods.
5146 * cli/cli-logging.c (handle_redirections): Use
5147 no_terminal_escape_file.
5148
52ce35e2
TT
51492019-06-14 Tom Tromey <tromey@adacore.com>
5150
5151 * NEWS: Move convenience variable news above Python news.
5152
73cc7272
TT
51532019-06-14 Tom Tromey <tom@tromey.com>
5154
5155 * gnulib: Move directory to top-level.
5156 * configure.ac: Don't configure gnulib.
5157 * configure: Rebuild.
5158 * common/common-defs.h: Use new path to gnulib.
5159 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5160 (GNULIB_H): Remove.
5161 (INCGNU): Look in new gnulib location.
5162 (HFILES_NO_SRCDIR): Remove gnulib files.
5163 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5164 (generated_files): Remove GNULIB_H.
5165 ($(LIBGNU), all-lib): Remove targets.
5166 (distclean): Don't mention GNULIB_BUILDDIR.
5167 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5168
f5686554
TT
51692019-06-14 Tom Tromey <tromey@adacore.com>
5170
5171 * symfile.c (add_symbol_file_command): Remove obsolete comment.
5172 Warn if symbol file does not provide any symbols.
5173
a0c1ffed
TT
51742019-06-14 Tom Tromey <tromey@adacore.com>
5175
5176 * source.c (find_and_open_source): Respect basenames_may_differ.
5177
7c39e397
AB
51782019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
5179
5180 * annotate.c (annotate_breakpoints_invalid): Make use of
5181 scoped_restore_terminal_state.
5182 (annotate_frames_invalid): Likewise.
5183
f411722c
TT
51842019-06-14 Tom Tromey <tromey@adacore.com>
5185
5186 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5187 allow assignment to an internalvar.
5188
4268ec18
TT
51892019-06-14 Tom Tromey <tromey@adacore.com>
5190
5191 * ada-lex.l: Allow "_" in attribute names.
5192
abdb711e
TT
51932019-06-14 Tom Tromey <tromey@adacore.com>
5194
5195 PR gdb/24653:
5196 * regcache.c (registers_changed): Don't call alloca.
5197 * top.c (execute_command): Don't call alloca.
5198
4c048731
PA
51992019-06-13 Pedro Alves <palves@redhat.com>
5200
5201 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5202 'expression'. When parsing an expression, error out if there's
5203 junk after "unlimited".
5204 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5205 (do_set_command): Adjust calls to is_unlimited_literal.
5206
66eb1ed3
PA
52072019-06-13 Pedro Alves <palves@redhat.com>
5208
5209 * compile/compile.c (make_compile_options_def_group): Add braces
5210 around array_view initializer.
5211 * thread.c (make_thread_apply_all_options_def_group)
5212 (make_thread_apply_all_options_def_group): Likewise.
5213
3345721a
PA
52142019-06-13 Pedro Alves <palves@redhat.com>
5215
5216 * NEWS (New commands): Mention "maint test-options
5217 require-delimiter", "maint test-options unknown-is-error", "maint
5218 test-options unknown-is-operand" and "maint show
5219 test-options-completion-result".
5220 (New command options, command completion): New section.
5221 (Completion improvements): New section.
5222 Mention that you can abbreviate "unlimited".
5223
6206060d
PA
52242019-06-13 Pedro Alves <palves@redhat.com>
5225
5226 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5227 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5228 * unittests/cli-utils-selftests.c (test_parse_flags)
5229 (test_parse_flags_qcs): Delete.
5230 (test_cli_utils): Don't call deleted functions.
5231
6665660a
PA
52322019-06-13 Pedro Alves <palves@redhat.com>
5233
5234 * thread.c: Include "cli/cli-option.h".
5235 (tp_array_compar_ascending): Global.
5236 (tp_array_compar): Delete function.
5237 (tp_array_compar_ascending, tp_array_compar_descending): New
5238 functions.
5239 (ascending_option_def, qcs_flag_option_def)
5240 (thr_qcs_flags_option_defs)
5241 (make_thread_apply_all_options_def_group)
5242 (make_thread_apply_options_def_group): New.
5243 (thread_apply_all_command): Use gdb::option::process_options.
5244 (thread_apply_command_completer)
5245 (thread_apply_all_command_completer): New.
5246 (thread_apply_command): Use gdb::option::process_options.
5247 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5248 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
5249 to generate help text of "thread apply". Adjust "taas"'s help.
5250 * tid-parse.c (tid_range_parser::in_thread_range): New method.
5251 * tid-parse.h (tid_range_parser::in_thread_range): New method.
5252
f7e13587
PA
52532019-06-13 Pedro Alves <palves@redhat.com>
5254
5255 * thread.c (thread_apply_command): Check for invalid TID with
5256 isdigit instead of !isalpha.
5257
5d707134
PA
52582019-06-13 Pedro Alves <palves@redhat.com>
5259
5260 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5261 (validate_flags_qcs): New.
5262 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5263 (validate_flags_qcs): Declare.
5264 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5265 (make_frame_apply_options_def_group): New.
5266 (frame_apply_command_count): Process options with
5267 gdb::option::process_options.
5268 (frame_apply_completer): New.
5269 (frame_apply_level_completer, frame_apply_all_completer)
5270 (frame_apply_completer): New.
5271 (_initialize_stack): Update help of "frame apply", "frame apply
5272 level", "frame apply all" and "faas" to mention supported options
5273 and install command completers.
5274 * stack.h (frame_apply_all_completer): Declare.
5275 * thread.c: Include "stack.h".
5276 (tfaas_command): Add "--".
5277 (_initialize_thread): Update help "tfaas" to mention supported
5278 options and install command completer.
5279
272d4594
PA
52802019-06-13 Pedro Alves <palves@redhat.com>
5281
5282 * completer.c (complete_nested_command_line): New.
5283 (gdb_completion_word_break_characters_throw): Add assertion.
5284 * completer.h (complete_nested_command_line): Declare.
5285
90a1ef87
PA
52862019-06-13 Pedro Alves <palves@redhat.com>
5287
5288 * stack.c (parse_backtrace_qualifiers): New.
5289 (backtrace_command): Use it.
5290 (backtrace_command_completer): Complete on qualifiers.
5291
d4c16835
PA
52922019-06-13 Pedro Alves <palves@redhat.com>
5293
5294 * frame.c: Include "cli/cli-option.h.
5295 (user_set_backtrace_options): New.
5296 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5297 Delete.
5298 (get_prev_frame): Adjust.
5299 (boolean_option_def, uinteger_option_def)
5300 (set_backtrace_option_defs): New.
5301 (_initialize_frame): Adjust and use
5302 gdb::option::add_setshow_cmds_for_options to install "set
5303 backtrace past-main" and "set backtrace past-entry".
5304 * frame.h: Include "cli/cli-option.h".
5305 (struct frame_print_options): Forward declare.
5306 (print_frame_arguments_all, print_frame_arguments_scalars)
5307 (print_frame_arguments_none): Declare.
5308 (print_entry_values): Delete declaration.
5309 (struct frame_print_options, user_frame_print_options): New.
5310 (struct set_backtrace_options): New.
5311 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5312 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5313 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5314 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5315 (list_args_or_locals): Add frame_print_options parameter.
5316 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5317 * python/py-framefilter.c (enumerate_args): Pass down
5318 USER_FRAME_PRINT_OPTIONS.
5319 * stack.c: Include "cli/cli-option.h".
5320 (print_frame_arguments_all, print_frame_arguments_scalars)
5321 (print_frame_arguments_none): Declare.
5322 (print_raw_frame_arguments, print_entry_values): Delete.
5323 (user_frame_print_options): New.
5324 (boolean_option_def, enum_option_def, frame_print_option_defs):
5325 New.
5326 (struct backtrace_cmd_options): New.
5327 (bt_flag_option_def): New.
5328 (backtrace_command_option_defs): New.
5329 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5330 (print_frame_arg, read_frame_arg, print_frame_args)
5331 (print_frame_info, print_frame): Add frame_print_options parameter
5332 and use it.
5333 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5334 (backtrace_command_1): Add frame_print_options and
5335 backtrace_cmd_options parameters and use them.
5336 (make_backtrace_options_def_group): New.
5337 (backtrace_command): Process command options with
5338 gdb::option::process_options.
5339 (backtrace_command_completer): New.
5340 (_initialize_stack): Extend "backtrace"'s help to mention
5341 supported options. Install completer for "backtrace".
5342 Install some settings commands with add_setshow_cmds_for_options.
5343
2daf894e
PA
53442019-06-13 Pedro Alves <palves@redhat.com>
5345
5346 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5347 and that "set/show print raw frame-arguments" are now deprecated.
5348
5349 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5350 command.
5351 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5352 * stack.c (_initialize_stack): Install "set/show print
5353 raw-frame-arguments", and deprecate "set/show print raw
5354 frame-arguments".
5355 * valprint.c (_initialize_valprint): Deprecate "set/show print
5356 raw".
5357
e6ed716c
PA
53582019-06-13 Pedro Alves <palves@redhat.com>
5359
5360 * compile/compile.c (struct compile_options): New.
5361 (compile_flag_option_def, compile_command_option_defs)
5362 (make_compile_options_def_group): New.
5363 (compile_file_command): Handle options with
5364 gdb::option::process_options.
5365 (compile_file_command_completer): New function.
5366 (compile_code_command): Handle options with
5367 gdb::option::process_options.
5368 (compile_code_command_completer): New function.
5369 (_initialize_compiler): Install completers for "compile code" and
5370 "compile file". Mention available options in "compile code" and
5371 "compile code"'s help.
5372 * completer.c (advance_to_completion_word): New, factored out from
5373 ...
5374 (advance_to_expression_complete_word_point): ... this.
5375 (advance_to_filename_complete_word_point): New.
5376 * completer.h (advance_to_filename_complete_word_point): New
5377 declaration.
5378
7d8062de
PA
53792019-06-13 Pedro Alves <palves@redhat.com>
5380
5381 * compile/compile.c: Include "cli/cli-option.h".
5382 (compile_print_value): Scope data pointer is now a
5383 value_print_options pointer; adjust.
5384 (compile_print_command): Process options. Scope data pointer is
5385 now a value_print_options pointer; adjust.
5386 (_initialize_compile): Update "compile print"'s help to include
5387 supported options. Install a completer for "compile print".
5388 * cp-valprint.c (show_vtblprint, show_objectprint)
5389 (show_static_field_print): Delete.
5390 (_initialize_cp_valprint): Don't install "set print
5391 static-members", "set print vtbl", "set print object" here.
5392 * printcmd.c: Include "cli/cli-option.h" and
5393 "common/gdb_optional.h".
5394 (print_command_parse_format): Rework to fill in a
5395 value_print_options instead of a format_data.
5396 (print_value): Change parameter type from format_data pointer to
5397 value_print_options reference. Adjust.
5398 (print_command_1): Process options. Adjust to pass down a
5399 value_print_options.
5400 (print_command_completer): New.
5401 (_initialize_printcmd): Install print_command_completer as
5402 handle_brkchars completer for the "print" command. Update
5403 "print"'s help to include supported options.
5404 * valprint.c: Include "cli/cli-option.h".
5405 (show_vtblprint, show_objectprint, show_static_field_print): Moved
5406 here from cp-valprint.c.
5407 (boolean_option_def, uinteger_option_def)
5408 (value_print_option_defs, make_value_print_options_def_group):
5409 New. Use gdb::option::add_setshow_cmds_for_options to install
5410 "set print elements", "set print null-stop", "set print repeats",
5411 "set print pretty", "set print union", "set print array", "set
5412 print address", "set print symbol", "set print array-indexes".
5413 * valprint.h: Include <string> and "cli/cli-option.h".
5414 (make_value_print_options_def_group): Declare.
5415 (print_value): Change parameter type from format_data pointer to
5416 value_print_options reference.
5417 (print_command_completer): Declare.
5418
9d0faba9
PA
54192019-06-13 Pedro Alves <palves@redhat.com>
5420
5421 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5422 (COMMON_SFILES): Add maint-test-settings.c.
5423 * cli/cli-decode.c (boolean_enums): New global, factored out from
5424 ...
5425 (add_setshow_boolean_cmd): ... here.
5426 * cli/cli-decode.h (boolean_enums): Declare.
5427 * cli/cli-option.c: New file.
5428 * cli/cli-option.h: New file.
5429 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5430 factored out from ...
5431 (parse_cli_boolean_value(const char *)): ... this.
5432 (is_unlimited_literal): Change parameter type to pointer to
5433 pointer. Adjust and advance ARG pointer.
5434 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5435 (parse_cli_var_enum): New, factored out from ...
5436 (do_set_command): ... this. Adjust.
5437 * cli/cli-setshow.h (parse_cli_boolean_value)
5438 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5439 (parse_cli_var_enum): Declare.
5440 * cli/cli-utils.c: Include "cli/cli-option.h".
5441 (get_ulongest): New.
5442 * cli/cli-utils.h (get_ulongest): Declare.
5443 (check_for_argument): New overloads.
5444 * maint-test-options.c: New file.
5445
2c722807
PA
54462019-06-13 Pedro Alves <palves@redhat.com>
5447
5448 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5449 parse a range if "-" is at the end of the string.
5450
dee7b4c8
PA
54512019-06-13 Pedro Alves <palves@redhat.com>
5452
5453 * cli/cli-setshow.c (parse_auto_binary_operation)
5454 (parse_cli_boolean_value): Don't allow "o".
5455
dca0f6c0
PA
54562019-06-13 Pedro Alves <palves@redhat.com>
5457
5458 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5459 * NEWS: Mention maint test-settings KIND.
5460 * maint-test-settings.c: New file.
5461
597bf39d
PA
54622019-06-13 Pedro Alves <palves@redhat.com>
5463
5464 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5465 completer.
5466 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5467 "set" completers.
5468
48c410fb
PA
54692019-06-13 Pedro Alves <palves@redhat.com>
5470
5471 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5472 after item.
5473
93bcb043
PA
54742019-06-13 Pedro Alves <palves@redhat.com>
5475
5476 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5477
cbba3ecd
PA
54782019-06-13 Pedro Alves <palves@redhat.com>
5479
5480 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5481 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5482 call.
5483 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5484 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5485 calls.
5486 (check_for_argument): Skip spaces after argument.
5487
b9a3f842
PA
54882019-06-13 Pedro Alves <palves@redhat.com>
5489
5490 * thread.c (thread_apply_command): Adjust TID parsing.
5491 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5492 detected before end of string.
5493 (tid_is_in_list): Error out if LIST is invalid.
5494
3844e605
PA
54952019-06-13 Pedro Alves <palves@redhat.com>
5496
5497 * completer.c (complete_line_internal_1): Rewind completion word
5498 point.
5499 (completion_tracker::advance_custom_word_point_by): Change
5500 parameter type to int.
5501 * completer.h (completion_tracker::advance_custom_word_point_by):
5502 Likewise.
5503
00b56dbe
PA
55042019-06-13 Pedro Alves <palves@redhat.com>
5505
5506 * completer.c (advance_to_completion_word): Handle delimiters.
5507
d106773e
PA
55082019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5509
5510 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5511
08f10e02
TT
55122019-06-11 Tom Tromey <tom@tromey.com>
5513
5514 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5515 (xmalloc_failed): Move to alloc.c.
5516 * alloc.c: New file.
5517 * Makefile.in (COMMON_SFILES): Add alloc.c.
5518
1c7fe951
TT
55192019-06-11 Tom Tromey <tom@tromey.com>
5520
5521 * nat/linux-waitpid.c: Don't include server.h.
5522 (linux_debug): Remove.
5523 (my_waitpid): Update.
5524
89549d7f
TT
55252019-06-11 Tom Tromey <tromey@adacore.com>
5526
5527 * infcall.c (_initialize_infcall): Remove trailing newline from
5528 help.
5529 * user-regs.c (_initialize_user_regs): Remove trailing newline
5530 from help.
5531 * typeprint.c (_initialize_typeprint): Remove trailing newline
5532 from help.
5533 * reverse.c (_initialize_reverse): Remove trailing newlines from
5534 help.
5535 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5536 from help.
5537 * language.c (add_set_language_command): Remove trailing newline
5538 from help.
5539 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5540 help.
5541 * disasm.c (_initialize_disasm): Remove trailing newline from
5542 help.
5543 * top.c (init_main): Remove trailing newline from help.
5544 * interps.c (_initialize_interpreter): Remove trailing newline
5545 from help.
5546 * btrace.c (_initialize_btrace): Remove trailing newlines from
5547 help.
5548 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5549 from help.
5550 * python/python.c (_initialize_python): Remove trailing newline
5551 from help.
5552 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5553 help.
5554 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5555 from help. Reformat some text.
5556 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5557 from help.
5558 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5559 newline from help.
5560
86108c13
TT
55612019-06-11 Tom Tromey <tromey@adacore.com>
5562
5563 * darwin-nat.c (darwin_decode_exception_message)
5564 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5565
a7067863
AB
55662019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5567
5568 * valops.c (value_slice): Check for not allocated or not
5569 associated values.
5570
9ab08412
TV
55712019-06-10 Tom de Vries <tdevries@suse.de>
5572
5573 PR gdb/24618
5574 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5575 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5576 invalid.
5577
f19e22e9
TV
55782019-06-10 Tom de Vries <tdevries@suse.de>
5579
5580 PR gdb/24611
5581 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5582 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5583
e99f9db0
TV
55842019-06-10 Tom de Vries <tdevries@suse.de>
5585
5586 PR symtab/24545
5587 * symtab.c (struct demangled_name_entry): Add language field.
5588 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5589 static minimal symbol". Set and use language field.
5590
9bf7038b
TT
55912019-06-10 Tom Tromey <tromey@adacore.com>
5592
5593 * ada-lang.c (_initialize_ada_language): Update help text.
5594
422186a9
TT
55952019-06-10 Tom Tromey <tromey@adacore.com>
5596
5597 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5598 with a newline.
5599 * guile/guile.c (handle_boot_error): Don't end warning with a
5600 newline.
5601 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5602 warning with a newline.
5603 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5604 newline.
5605 (s12z_frame_cache): Likewise.
5606 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5607 a newline.
5608 * solib-svr4.c (disable_probes_interface): Don't end warning with
5609 a newline.
5610 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5611 newline.
5612 * python/python.c (do_finish_initialization): Don't end warning
5613 with a newline.
5614
25ce02ee
TT
56152019-06-10 Tom Tromey <tom@tromey.com>
5616
5617 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5618 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5619 gdbpy_enter.
5620
caa429d8
TT
56212019-06-10 Tom Tromey <tromey@adacore.com>
5622
5623 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5624 data.
5625 (elf_new_init): Don't call stabsread_new_init.
5626 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5627 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5628 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5629
81873cc8
TV
56302019-06-10 Tom de Vries <tdevries@suse.de>
5631
5632 PR symtab/16264
5633 PR symtab/24517
5634 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5635
4fa0265e
РИ
56362019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5637
5638 * source.c (find_and_open_source): Also rewrite relative file
5639 names.
5640
1a3da2cd
AB
56412019-04-26 Amos Bird <amosbird@gmail.com>
5642
5643 * annotate.c (annotate_thread_exited): Add "thread-exited"
5644 annotation.
5645
3847a7bf
TT
56462019-06-06 Tom Tromey <tromey@adacore.com>
5647
5648 * maint.h (class scoped_command_stats): Use
5649 DISABLE_COPY_AND_ASSIGN.
5650 <print_time>: New method.
5651 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5652 print_time.
5653 (scoped_command_stats::print_time): New method.
5654
312617a3
AB
56552019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5656
5657 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5658 instructions of lengths 6 or 8 bytes.
5659
b02f78f9
PA
56602019-06-04 Pedro Alves <palves@redhat.com>
5661
5662 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5663
5664 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5665 * breakpoint.c (condition_completer): Likewise.
5666 * cli/cli-dump.c (scan_expression): Likewise.
5667 * common/filestuff.c (mkdir_recursive): Likewise.
5668 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5669 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5670 (gdb_abspath): Likewise.
5671 * compile/compile-cplus-types.c
5672 (compile_cplus_instance::decl_name): Likewise.
5673 * completer.c (complete_explicit_location):
5674 (signal_completer, reg_or_group_completer_1): Likewise.
5675 * cp-support.c (cp_remove_params_if_any): Likewise.
5676 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5677 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5678 * infcmd.c (strip_bg_char): Likewise.
5679 * linespec.c (copy_token_string): Likewise.
5680 * mi/mi-main.c (output_cores): Likewise.
5681 * psymtab.c (psymtab_search_name):
5682 * symfile.c (test_set_ext_lang_command): Likewise.
5683 * target.c (target_fileio_read_stralloc): Likewise.
5684 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5685 * value.c (complete_internalvar): Likewise.
5686
e1f2e1a2
CB
56872019-06-04 Christian Biesinger <cbiesinger@google.com>
5688
5689 Add objfile property to gdb.Type.
d3238f7d
PA
5690 * NEWS: Mention Python API addition.
5691 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 5692
e664d728
PW
56932019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5694
5695 * NEWS: Mention the new set|show style [title|highlight].
5696 Mention changes to "show style", "help" and "apropos".
5697
66d8c862
PW
56982019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5699
5700 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5701 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5702 instead of print_help_for_command.
5703 (print_doc_of_command): New function.
5704 (help_list): Add 'apropos -v word' suggestion.
5705 (print_help_for_command): Style the command name using title style.
5706 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5707 (_initialize_cli_cmds): Describe -v in apropos_command help.
5708
9303eb2f
PW
57092019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5710
5711 * cli/cli-style.h (cli_style_option): Add name in constructor,
5712 add m_name class member, add constructor with intensity,
5713 add name class function.
5714 (cli_style_option::add_setshow_commands): Remove name argument.
5715 (highlight_style, title_style): New styles.
5716 * cli/cli-style.c (do_show): New function that shows a style
5717 characteristic styling the style name with itself.
5718 (set_style_name): New function.
5719 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5720 Update all callers according to the changes in cli/cli-style.h.
5721 * utils.h (fputs_highlighted): New function.
5722 * utils.c (fputs_highlighted): Likewise.
5723
e2c52041
PW
57242019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5725
5726 * NEWS: Mention new pipe command and new convenience variables.
5727
947d3946
PW
57282019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5729
5730 * cli/cli-cmds.c (pipe_command): New function.
5731 (_initialize_cli_cmds): Call add_com for pipe_command.
5732 Define | as an alias for pipe.
5733 (exit_status_set_internal_vars): New function.
5734 (shell_escape): Call exit_status_set_internal_vars.
5735 cli/cli-decode.c (find_command_name_length): Recognize | as
5736 a single character command.
5737
b8fd0918
PW
57382019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5739
5740 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5741 top.c (execute_command_to_ui_file): New function, mostly a copy
5742 of execute_command_to_string.
5743 (execute_command_to_string): Implement by calling
5744 execute_command_to_ui_file.
5745
68bb5386
PW
57462019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5747
5748 * top.h (saved_command_line): Remove declaration.
5749 * top.c (previous_saved_command_line, previous_repeat_arguments):
5750 New variables.
5751 (saved_command_line): Make static, define together with other
5752 'repeat variables'.
5753 (dont_repeat): Clear repeat_arguments.
5754 (repeat_previous, get_saved_command_line, save_command_line):
5755 New functions.
5756 (gdb_init): Initialize saved_command_line
5757 and previous_saved_command_line.
5758 * main.c (captured_main_1): Remove saved_command_line initialization.
5759 * event-top.c (handle_line_of_input): Update to use
5760 the new 'repeat' related functions instead of direct access to
5761 saved_command_line.
5762 * command.h (repeat_previous, get_saved_command_line,
5763 save_command_line): New declarations.
5764 (dont_repeat): Add comment.
5765
bfcdb852
TT
57662019-05-30 Tom Tromey <tromey@adacore.com>
5767
5768 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5769 Fix comment.
5770 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5771
0ef209f2
JV
57722019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5773
5774 PR cli/24587
5775 * completer.c (complete): Initialize variable word.
5776
955b06fa
SDJ
57772019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5778
5779 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5780 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5781 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5782 'body' is NULL to the outter 'if', protecting the '!is_define'
5783 situation as well.
5784
fa9c3fa0
TT
57852019-05-29 Tom Tromey <tromey@adacore.com>
5786
5787 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5788 (dwarf_unknown): New function.
5789 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5790 (dwarf_type_encoding_name): Use dwarf_unknown.
5791
4330d61d
TT
57922019-05-29 Tom Tromey <tromey@adacore.com>
5793
5794 PR c++/20020:
5795 * cp-valprint.c (cp_print_value_fields): Call
5796 cp_print_static_field inside "try".
5797
33a6bc35
TT
57982019-05-29 Tom Tromey <tromey@adacore.com>
5799
5800 * inflow.c (struct terminal_info): Add default operator=.
5801 * configure: Rebuild.
5802 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5803 -Wdeprecated-copy-dtor, -Wredundant-move.
5804
000439d5
TT
58052019-05-29 Tom Tromey <tromey@adacore.com>
5806
5807 * NEWS: Add entry.
5808 * infcmd.c (print_return_value_1): Handle finish_print
5809 option.
5810 (show_print_finish): New function.
5811 (_initialize_infcmd): Add "set/show print finish" commands.
5812 * valprint.c (user_print_options): Initialize new member.
5813 * valprint.h (struct value_print_options) <finish_print>: New
5814 member.
5815
c0e70c62
TT
58162019-05-28 Tom Tromey <tromey@adacore.com>
5817
5818 * ada-lang.c (ada_remove_Xbn_suffix)
5819 (find_old_style_renaming_symbol)
5820 (parse_old_style_renaming): Remove.
5821 (ada_find_renaming_symbol): Don't call
5822 find_old_style_renaming_symbol.
5823 (ada_is_renaming_symbol): Rename from
5824 ada_find_renaming_symbol. Remove "block" parameter. Return
5825 bool. Now static.
5826 (ada_read_var_value): Update and simplify.
5827 * ada-exp.y (write_var_or_type): Remove old code.
5828
766f8836
AH
58292019-05-28 Alan Hayward <alan.hayward@arm.com>
5830
5831 * event-top.c: Remove include comment.
5832 * inflow.c (class scoped_ignore_sigttou): Move from here...
5833 * inflow.h (class scoped_ignore_sigttou): ...to here.
5834 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5835 * top.c: Remove include comment.
5836
eb41253a
TT
58372019-05-27 Tom Tromey <tom@tromey.com>
5838
5839 * NEWS: Fix typo.
5840
4ca51187
TT
58412019-05-22 Tom Tromey <tromey@adacore.com>
5842
5843 * target.c (target_follow_exec): Constify parameter.
5844 * target-delegates.c: Rebuild.
5845 * remote.c (remote_target::follow_exec): Constify parameter.
5846 * infrun.c (follow_exec): Constify parameter.
5847 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5848 (target_follow_exec): Likewise.
5849
8fca4da0
AH
58502019-05-22 Alan Hayward <alan.hayward@arm.com>
5851
5852 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5853 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5854
b7060614
AH
58552019-05-22 Alan Hayward <alan.hayward@arm.com>
5856
5857 * NEWS: Add debugredirect and testsuite sections.
5858
0a5954bd
SC
58592019-05-22 Simon Cook <simon.cook@embecosm.com>
5860
5861 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5862 target descriptions using exclusively floating point register name
5863 aliases.
5864
dc42e902
AB
58652019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5866
5867 PR gdb/18644:
5868 * f-lang.c (build_fortran_types): Handle the case where
5869 gdbarch_floatformat_for_type returns a nullptr.
5870
fb7806c7
TV
58712019-05-21 Tom de Vries <tdevries@suse.de>
5872
5873 PR cli/24587
5874 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5875
34d11c68
AB
58762019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5877
5878 PR gdb/18644:
5879 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5880 16-byte floats.
5881 * i386-tdep.c (i386_floatformat_for_type): Use
5882 floatformats_ia64_quad for the 16-byte floating point component
5883 within a fortran 32-byte complex number.
5884
122cf0f2
AB
58852019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5886
5887 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5888 delete default constructor.
5889 (find_partial_die): Update to return const struct.
5890 (partial_die_parent_scope): Move variable declaration into scope
5891 of its use and change its type to auto.
5892 (guess_partial_die_structure_name): Likewise.
5893 (partial_die_info::fixup): Likewise.
5894
33d0e35a
TT
58952019-05-17 Tom Tromey <tromey@adacore.com>
5896
5897 * source.c (find_and_open_source): Remove cast.
5898
a45575b0
TT
58992019-05-17 Tom Tromey <tromey@adacore.com>
5900
5901 * annotate.c (annotate_source): Make "filename" const.
5902 * annotate.h (annotate_source): Use const.
5903
81f47ac2
AH
59042019-05-17 Alan Hayward <alan.hayward@arm.com>
5905
5906 * disasm.c (set_disassembler_options): Send errors to stderr.
5907
ca1285d1
AH
59082019-05-17 Alan Hayward <alan.hayward@arm.com>
5909
5910 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5911 (cli_interp_base::set_logging): Check debug_redirect.
5912 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5913 * cli/cli-logging.c (debug_redirect): Add static variable.
5914 (pop_output_files): Add default param.
5915 (handle_redirections): Print debug setting.
5916 (show_logging_command): Likewise.
5917 (_initialize_cli_logging): Add debugredirect command.
5918 * interps.c (current_interp_set_logging): Add debug_redirect
5919 parameter.
5920 * interps.h (set_logging): Add debug_redirect parameter.
5921 (current_interp_set_logging): Likewise.
5922 * mi/mi-common.h: Likewise.
5923 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5924
59252019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
5926 Tom Tromey <tromey@adacore.com>
5927
5928 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5929 directly.
5930 * cli/cli-interp.h (make_logging_output): Remove declaration.
5931 * cli/cli-logging.c (make_logging_output): Remove function.
5932 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5933 directly.
5934 * ui-file.c (tee_file::tee_file): Remove bools.
5935 (tee_file::~tee_file): Remove deletes.
5936 * ui-file.h (tee_file): Remove bools.
5937
26648588
JV
59382019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5939
5940 * mi/mi-cmds.h (mi_cmd_complete): New function.
5941 * mi/mi-main.c (mi_cmd_complete): Likewise.
5942 * mi/mi-cmds.c: Define new MI command -complete.
5943 * NEWS: Mention new -complete command.
5944
6e035501
JV
59452019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5946
5947 * completer.h (complete): New function.
5948 * completer.c (complete): Likewise.
5949 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5950 function defined in completer.h.
5951
7d0e2ece
JV
59522019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5953
e79be6e5 5954 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 5955
fb816e8b
TV
59562019-05-17 Tom de Vries <tdevries@suse.de>
5957
5958 PR gdb/24094
5959 * dwarf2read.c (struct cu_partial_die_info): New struct.
5960 (find_partial_die): Return cu_partial_die_info.
5961 (partial_die_parent_scope, guess_partial_die_structure_name)
5962 (partial_die_info::fixup): Handle new return type of find_partial_die.
5963
677052f2
SDJ
59642019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5965
a1726c38 5966 PR breakpoints/24541
677052f2
SDJ
5967 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5968 "std::string", simplifying the algorithm.
5969
f3da9116
SDJ
59702019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5971
5972 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5973 (stap_static_probe_ops::get_probes): Likewise.
5974
f1bb75ab
SDJ
59752019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5976
5977 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5978 '-')" and "else if".
5979 (stap_parse_single_operand): Join checks for
5980 "gdbarch_stap_parse_special_token_p" and
5981 "gdbarch_stap_parse_special_token" in the same "if" statement.
5982 Invert check when verifying for operation on register
5983 displacement.
5984
3ca58cde
SDJ
59852019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5986
5987 * stap-probe.c (stap_get_opcode): Update comment.
5988 (stap_get_expected_argument_type): Likewise.
5989 (handle_stap_probe): Likewise.
5990
af2d9bee
SDJ
59912019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5992
5993 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5994 return type to 'bool'. Adjust comment. Use 'bool' when
5995 appropriate.
5996 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5997 * stap-probe.c (stap_parse_argument_1): Likewise.
5998 (stap_is_operator): Likewise.
5999 (stap_is_generic_prefix): Likewise.
6000 (stap_is_register_prefix): Likewise.
6001 (stap_is_register_indirection_prefix): Likewise.
6002 (stap_is_integer_prefix): Likewise.
6003 (stap_generic_check_suffix): Likewise.
6004 (stap_check_integer_suffix): Likewise.
6005 (stap_check_register_suffix): Likewise.
6006 (stap_check_register_indirection_suffix): Likewise.
6007 (stap_parse_register_operand): Likewise.
6008 (stap_parse_single_operand): Likewise.
6009 (stap_parse_argument_1): Likewise.
6010 (stap_probe::get_argument_count): Likewise.
6011 (stap_is_operator): Likewise.
6012
61c9c421
TT
60132019-05-16 Tom Tromey <tromey@adacore.com>
6014
6015 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6016 keyword to foreach.
6017
9ddc1af1
SM
60182019-05-15 Simon Marchi <simon.marchi@efficios.com>
6019
6020 * linux-thread-db.c (try_thread_db_load_1): Change return type
6021 to bool.
6022 (try_thread_db_load): Likewise.
6023 (try_thread_db_load_from_pdir_1): Likewise.
6024 (try_thread_db_load_from_pdir): Likewise.
6025 (try_thread_db_load_from_sdir): Likewise.
6026 (try_thread_db_load_from_dir): Likewise.
6027 (thread_db_load_search): Likewise.
6028 (has_libpthread): Likewise.
6029 (thread_db_load): Likewise.
6030
7bede828
SDJ
60312019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6032
6033 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6034 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6035 NULL, and complain/return if that's the case.
6036
c5358db4
JD
60372019-05-15 John Darrington <john@darrington.wattle.id.au>
6038
6039 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6040 (advance, posn, abstract_read_memory): New functions.
6041 [struct mem_read_abstraction]: New struct.
6042 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6043
c408a94f
TT
60442019-05-14 Tom Tromey <tromey@adacore.com>
6045
6046 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6047 value is not lval_memory.
6048
e7bd7fba
TT
60492019-05-14 Tom Tromey <tromey@adacore.com>
6050
6051 * solib.c (info_sharedlibrary_command): Style the file name.
6052
a6d0f249
AH
60532019-05-14 Alan Hayward <alan.hayward@arm.com>
6054
6055 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6056 (aarch64_vnv_type): Likewise.
6057 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6058 * common/tdesc.c: Likewise.
6059 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6060 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6061 * features/aarch64-fpu.xml: Add ieee half view.
6062 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6063 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6064 * gdbtypes.h (struct builtin_type): Likewise.
6065 (struct objfile_type): Likewise.
6066
66b8bb74
SM
60672019-05-12 Paul Naert <paul.naert@polymtl.ca>
6068
6069 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6070 typo.
6071 * location.h (string_to_event_location): Likewise.
6072
21c219fd
JB
60732019-05-11 Joel Brobecker <brobecker@adacore.com>
6074
6075 GDB 8.3 released.
6076
13674803
SM
60772019-05-10 Simon Marchi <simon.marchi@efficios.com>
6078
6079 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6080 New variable declaration.
6081 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6082 New variable.
6083 (print_one_breakpoint): Use ui_out::test_flags and new global
6084 variable to compute use_fixed_output.
6085 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6086 Remove.
6087 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6088 (mi_multi_location_breakpoint_output_fixed): Remove.
6089 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6090 new variable.
6091 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6092 fix_multi_location_breakpoint_output flag if version >= 3.
6093 * ui-out.h (enum ui_out_flag)
6094 <fix_multi_location_breakpoint_output>: New enumerator.
6095
a9eac7f9
SM
60962019-05-10 Simon Marchi <simon.marchi@efficios.com>
6097
6098 * contrib/cc-with-tweaks.sh: Validate dwz's work.
6099
71bed2db
TT
61002019-05-10 Tom Tromey <tromey@adacore.com>
6101
6102 * ada-lang.c (catch_ada_completer): New function.
6103 (_initialize_ada_language): Use it.
6104
24c54127
TT
61052019-05-10 Tom Tromey <tromey@adacore.com>
6106
6107 * thread.c (print_thread_info): Make "requested_threads" const.
6108 * gdbthread.h (print_thread_info): Make "requested_threads"
6109 const.
6110 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6111 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6112
7a102139
TT
61132019-05-08 Tom Tromey <tom@tromey.com>
6114
6115 * gdbtypes.c (objfile_type_data): Change type.
6116 (objfile_type, _initialize_gdbtypes): Update.
6117
924d79e2
TT
61182019-05-08 Tom Tromey <tom@tromey.com>
6119
6120 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6121 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6122 (_initialize_dwarf2_frame): Update.
6123
4c58e337
TT
61242019-05-08 Tom Tromey <tom@tromey.com>
6125
6126 * objc-lang.c (objc_objfile_data): Change type.
6127 (find_methods): Update.
6128 (_initialize_objc_lang): Remove.
6129
d772d2ab
TT
61302019-05-08 Tom Tromey <tom@tromey.com>
6131
6132 * stabsread.c (rs6000_builtin_type_data): Change type.
6133 (rs6000_builtin_type, _initialize_stabsread): Update.
6134
d11d83f4
TT
61352019-05-08 Tom Tromey <tom@tromey.com>
6136
6137 * mips-tdep.c (mips_pdr_data): Remove.
6138 (_initialize_mips_tdep): Update.
6139
9a73f0ad
TT
61402019-05-08 Tom Tromey <tom@tromey.com>
6141
6142 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6143 (hppa_init_objfile_priv_data, read_unwind_info)
6144 (find_unwind_entry, _initialize_hppa_tdep): Update.
6145
8127a2fa
TT
61462019-05-08 Tom Tromey <tom@tromey.com>
6147
6148 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6149 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
6150 on obstack.
6151 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6152
91d3055d
TT
61532019-05-08 Tom Tromey <tom@tromey.com>
6154
6155 * mdebugread.c (basic_type_data): Change type.
6156 (basic_type, _initialize_mdebugread): Update.
6157
31930bd3
TT
61582019-05-08 Tom Tromey <tom@tromey.com>
6159
6160 * common/gdb_unique_ptr.h (struct noop_deleter): New.
6161
bdb3ed9e
TT
61622019-05-08 Tom Tromey <tom@tromey.com>
6163
6164 * nto-tdep.c (nto_inferior_data_reg): Change type.
6165 (nto_inferior_data): Update.
6166 (nto_inferior_data_cleanup, nto_new_inferior_data)
6167 (_initialize_nto_tdep): Remove.
6168 * nto-tdep.h (struct nto_inferior_data): Add initializers.
6169
f37b313d
TT
61702019-05-08 Tom Tromey <tom@tromey.com>
6171
6172 * ada-lang.c (struct ada_inferior_data): Add initializers.
6173 (ada_inferior_data): Change type.
6174 (ada_inferior_data_cleanup): Remove.
6175 (get_ada_inferior_data, ada_inferior_exit)
6176 (struct ada_pspace_data): Add initializers, destructor.
6177 (ada_pspace_data_handle): Change type.
6178 (get_ada_pspace_data): Update.
6179 (ada_pspace_data_cleanup): Remove.
6180
24699405
TT
61812019-05-08 Tom Tromey <tom@tromey.com>
6182
6183 * coffread.c (struct coff_symfile_info): Add initializers.
6184 (coff_objfile_data_key): Move lower. Change type.
6185 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6186 Update.
6187 (coff_free_info): Remove.
6188
d4e05d2f
TT
61892019-05-08 Tom Tromey <tom@tromey.com>
6190
6191 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6192 (fbsd_pspace_data_handle): Move lower. Change type.
6193 (get_fbsd_pspace_data): Update.
6194 (fbsd_pspace_data_cleanup): Remove.
6195 (_initialize_fbsd_tdep): Update.
6196
14ef6690
TT
61972019-05-08 Tom Tromey <tom@tromey.com>
6198
6199 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6200 (get_ada_tasks_pspace_data): Update.
6201 (ada_tasks_pspace_data_cleanup): Remove.
6202 (_initialize_tasks): Update.
6203 (ada_tasks_inferior_data_handle): Change type.
6204 (get_ada_tasks_inferior_data): Update.
6205 (ada_tasks_inferior_data_cleanup): Remove.
6206 (struct ada_tasks_pspace_data): Add initializers.
6207
814cf43a
TT
62082019-05-08 Tom Tromey <tom@tromey.com>
6209
6210 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6211 * symfile-debug.c (debug_sym_get_probes): Change type.
6212 * stap-probe.c (handle_stap_probe):
6213 (stap_static_probe_ops::get_probes): Change type.
6214 * probe.h (class static_probe_ops) <get_probes>: Change type.
6215 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6216 (parse_probes_in_pspace): Update.
6217 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6218 Update.
6219 (any_static_probe_ops::get_probes): Change type.
6220 * elfread.c (elfread_data): New typedef.
6221 (probe_key): Change type.
6222 (elf_get_probes): Likewise. Update.
6223 (probe_key_free): Remove.
6224 (_initialize_elfread): Update.
6225 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6226 Change type.
6227 (dtrace_process_dof_probe, dtrace_process_dof)
6228 (dtrace_static_probe_ops::get_probe): Change type.
6229
02dc647e
TT
62302019-05-08 Tom Tromey <tom@tromey.com>
6231
6232 * xcoffread.c (struct xcoff_symfile_info): Rename from
6233 coff_symfile_info. Add initializers.
6234 (xcoff_objfile_data_key): Move lower. Change type.
6235 (XCOFF_DATA): Rewrite.
6236 (xcoff_free_info): Remove.
6237 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6238 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6239 (xcoff_initial_scan): Update.
6240
09232438
TT
62412019-05-08 Tom Tromey <tom@tromey.com>
6242
6243 * solib-svr4.c (struct svr4_info): Add initializers and
6244 destructor.
6245 <probes_table>: Now an htab_up.
6246 (solib_svr4_pspace_data): Change type.
6247 (free_probes_table): Simplify.
6248 (~svr4_info): Rename from svr4_pspace_data_cleanup.
6249 (get_svr4_info, probes_table_htab_remove_objfile_probes)
6250 (probes_table_remove_objfile_probes, register_solib_event_probe)
6251 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6252 (_initialize_svr4_solib): Update.
6253
7b4a314f
TT
62542019-05-08 Tom Tromey <tom@tromey.com>
6255
6256 * remote.c (remote_pspace_data): Change type.
6257 (remote_pspace_data_cleanup): Remove.
6258 (get_remote_exec_file, set_pspace_remote_exec_file)
6259 (_initialize_remote): Update.
6260
51d3063a
TT
62612019-05-08 Tom Tromey <tom@tromey.com>
6262
6263 * breakpoint.c (breakpoint_objfile_key): Change type.
6264 (get_breakpoint_objfile_data): Update.
6265 (free_breakpoint_objfile_data): Remove.
6266 (_initialize_breakpoint): Update.
6267
89fb8848
TT
62682019-05-08 Tom Tromey <tom@tromey.com>
6269
6270 * linux-tdep.c (struct linux_info): Add initializers.
6271 (linux_inferior_data): Move. Change type.
6272 (invalidate_linux_cache_inf): Update.
6273 (linux_inferior_data_cleanup): Remove.
6274 (get_linux_inferior_data, _initialize_linux_tdep): Update.
6275
e9b89e2d
TT
62762019-05-08 Tom Tromey <tom@tromey.com>
6277
6278 * auxv.c (auxv_inferior_data): Move. Change type.
6279 (auxv_inferior_data_cleanup): Remove.
6280 (invalidate_auxv_cache_inf): Rewrite.
6281 (get_auxv_inferior_data, _initialize_auxv): Update.
6282
8c42777c
TT
62832019-05-08 Tom Tromey <tom@tromey.com>
6284
6285 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6286 (symfile_debug_objfile_data_key): Change type.
6287 (symfile_debug_installed, debug_qf_has_symbols)
6288 (debug_qf_find_last_source_symtab)
6289 (debug_qf_forget_cached_source_info)
6290 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6291 (debug_qf_print_stats, debug_qf_dump)
6292 (debug_qf_expand_symtabs_for_function)
6293 (debug_qf_expand_all_symtabs)
6294 (debug_qf_expand_symtabs_with_fullname)
6295 (debug_qf_map_matching_symbols)
6296 (debug_qf_expand_symtabs_matching)
6297 (debug_qf_find_pc_sect_compunit_symtab)
6298 (debug_qf_map_symbol_filenames)
6299 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6300 (debug_sym_new_init, debug_sym_init, debug_sym_read)
6301 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6302 (debug_sym_read_linetable, debug_sym_relocate): Update.
6303 (symfile_debug_free_objfile): Remove.
6304 (install_symfile_debug_logging, _initialize_symfile_debug):
6305 Update.
6306
5bfd760d
TT
63072019-05-08 Tom Tromey <tom@tromey.com>
6308
6309 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6310 allocate_on_obstack.
6311 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6312 (get_dwarf2_per_objfile): Update.
6313 (set_dwarf2_per_objfile): Remove.
6314 (dwarf2_has_info, dwarf2_get_section_info): Update.
6315 (dwarf2_free_objfile): Remove.
6316 (_initialize_dwarf2_read): Update.
6317
e85e19b4
TT
63182019-05-08 Tom Tromey <tom@tromey.com>
6319
6320 * auto-load.c (struct auto_load_pspace_info): Add destructor and
6321 initializers.
6322 <unsupported_script_warning_printed,
6323 script_not_found_warning_printed>: Now bool.
6324 (auto_load_pspace_data): Change type.
6325 (~auto_load_pspace_info): Rename from
6326 auto_load_pspace_data_cleanup.
6327 (get_auto_load_pspace_data, init_loaded_scripts_info)
6328 (clear_section_scripts, maybe_print_unsupported_script_warning)
6329 (maybe_print_script_not_found_warning, _initialize_auto_load):
6330 Update.
6331
f6aa7436
TT
63322019-05-08 Tom Tromey <tom@tromey.com>
6333
6334 * objfiles.c (objfile_pspace_info): Add destructor and
6335 initializers.
6336 (objfiles_pspace_data): Change type.
6337 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6338 (get_objfile_pspace_data): Update.
6339 (objfiles_bfd_data): Change type.
6340 (get_objfile_bfd_data): Update.
6341 (objfile_bfd_data_free, _initialize_objfiles): Remove.
6342
6ae614f6
TT
63432019-05-08 Tom Tromey <tom@tromey.com>
6344
6345 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6346 Change type.
6347 (get_catch_syscall_inferior_data): Update.
6348 (catch_syscall_inferior_data_cleanup): Remove.
6349 (_initialize_break_catch_syscall): Update.
6350
6509b8eb
TT
63512019-05-08 Tom Tromey <tom@tromey.com>
6352
6353 * inflow.c (struct terminal_info): Add destructor and
6354 initializers.
6355 (inflow_inferior_data): Change type.
6356 (~terminal_info): Rename from inflow_inferior_data_cleanup.
6357 (get_inflow_inferior_data, inflow_inferior_exit)
6358 (swap_terminal_info, _initialize_inflow): Update.
6359
35632941
TT
63602019-05-08 Tom Tromey <tom@tromey.com>
6361
6362 * target-dcache.c (target_dcache_cleanup): Remove.
6363 (target_dcache_aspace_key): Change type.
6364 (target_dcache_init_p, target_dcache_invalidate)
6365 (target_dcache_get, target_dcache_get_or_init)
6366 (_initialize_target_dcache): Update.
6367 * dcache.h (struct dcache_deleter): New.
6368
3017b94d
TT
63692019-05-08 Tom Tromey <tom@tromey.com>
6370
6371 * symtab.c (struct symbol_cache): Add destructor and
6372 initializers.
6373 (symbol_cache_key): Move. Change type.
6374 (make_symbol_cache, free_symbol_cache): Remove.
6375 (get_symbol_cache): Update.
6376 (symbol_cache_cleanup): Remove.
6377 (ALL_PSPACES, symbol_cache_flush)
6378 (maintenance_print_symbol_cache)
6379 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6380 Update.
6381
a32ad8c5
TT
63822019-05-08 Tom Tromey <tom@tromey.com>
6383
6384 * symtab.c (struct main_info): Add destructor and initializers.
6385 (main_progspace_key): Move. Change type.
6386 (get_main_info): Update.
6387 (main_info_cleanup): Remove.
6388 (_initialize_symtab): Update.
6389
5f6e90a0
TT
63902019-05-08 Tom Tromey <tom@tromey.com>
6391
6392 * registry.h (DECLARE_REGISTRY): Define the _key class.
6393
1bd0c6e4
AB
63942019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
6395
6396 * NEWS: Merge two 'New commands' sections.
6397
2228ef77
XR
63982019-05-08 Joel Brobecker <brobecker@adacore.com>
6399
6400 * ada-valprint.c (ada_val_print_gnat_array): Remove language
6401 parameter and use Ada language definition instead.
6402 (ada_val_print_ptr): Remove unused language parameter.
6403 (ada_val_print_num): Remove language parameter and use Ada language
6404 definition instead.
6405 (ada_val_print_enum, ada_val_print_flt): Remove unused language
6406 parameter.
6407 (ada_val_print_struct_union, ada_val_print_ref): Remove language
6408 parameter and use Ada language definition instead.
6409 (ada_val_print_1): Update all ada_val_print_xxx calls.
6410 Remove language parameter.
6411 (ada_val_print): Update ada_val_print_1 call.
6412
60fcc1c3
TT
64132019-05-08 Tom Tromey <tromey@adacore.com>
6414
6415 * remote.c (remote_hw_watchpoint_limit)
6416 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6417 Now static.
6418
ed2b7c17
TT
64192019-05-08 Tom Tromey <tromey@adacore.com>
6420
6421 * maint.c (_initialize_maint_cmds): Move initialization code to
6422 remote.c.
6423 (watchdog, show_watchdog): Move to remote.c.
6424 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
6425 "watchdog" static.
6426 (_initialize_remote): Move initialization code from maint.c.
6427 * defs.h (watchdog): Don't declare.
6428
b0be6c91
TT
64292019-05-08 Tom Tromey <tromey@adacore.com>
6430
6431 * tui/tui-interp.c: Include main.h.
6432 * interps.c: Include main.h.
6433 * main.h (interpreter_p): Declare.
6434 * defs.h (interpreter_p): Don't declare.
6435
587ee17b
TT
64362019-05-08 Tom Tromey <tromey@adacore.com>
6437
6438 * dwarf2loc.c: Include dwarf2read.h.
6439 * defs.h (read_unsigned_leb128): Don't declare.
6440 * dwarf2read.h (read_unsigned_leb128): Declare.
6441
ca1df239
TT
64422019-05-08 Tom Tromey <tromey@adacore.com>
6443
6444 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6445 method.
6446
99f20f08
TT
64472019-05-08 Tom Tromey <tromey@adacore.com>
6448
6449 * utils.c (fputs_maybe_filtered): Reset style after paging, even
6450 when no wrap column is set.
6451
80e55b13
TT
64522019-05-08 Tom Tromey <tromey@adacore.com>
6453
6454 * c-lang.c (c_get_string): Handle non-C-style arrays.
6455
9d3421af
TT
64562019-05-08 Tom Tromey <tromey@adacore.com>
6457
6458 * typeprint.c (print_offset_data::update): Print the bit offset,
6459 not the number of bits remaining.
6460
844333e2
TT
64612019-05-08 Tom Tromey <tromey@adacore.com>
6462
6463 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6464 padding at end of comment.
6465
988915ee
TT
64662019-05-08 Tom Tromey <tromey@adacore.com>
6467
6468 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6469 Compare main types.
6470
26bfd823
TT
64712019-05-06 Tom Tromey <tom@tromey.com>
6472
6473 * common/scoped_mmap.c: Include common-defs.h.
6474 * common/scoped_mmap.h: Don't include config.h.
6475
89055eaa
TT
64762019-05-04 Tom Tromey <tom@tromey.com>
6477
6478 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6479 (struct aarch64_call_info): Add initializers.
6480 <si>: Now a std::vector.
6481 (pass_on_stack, aarch64_push_dummy_call): Update.
6482
5da01df5
TT
64832019-05-04 Simon Marchi <simon.marchi@efficios.com>
6484 Tom Tromey <tom@tromey.com>
6485
6486 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6487 (ppc_threads): Now a std::vector. Now static.
6488 (hwdebug_find_thread_points_by_tid)
6489 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6490 Update.
6491
fbdf05a1
TT
64922019-05-04 Tom Tromey <tom@tromey.com>
6493
6494 * arc-tdep.c (arc_tdesc_init): Return bool.
6495
06d16ec9
TT
64962019-05-04 Tom Tromey <tom@tromey.com>
6497
6498 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6499 Use gdb_assert_not_reached.
6500
9c056022
TT
65012019-05-04 Tom Tromey <tom@tromey.com>
6502
6503 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6504 "false".
6505
fa9c2a59
TT
65062019-05-04 Tom Tromey <tom@tromey.com>
6507
6508 * arc-tdep.c (arc_tdesc_init): Use bool.
6509
e2eb806a
TT
65102019-05-04 Tom Tromey <tom@tromey.com>
6511
6512 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6513
6fe87677
TT
65142019-05-04 Tom Tromey <tom@tromey.com>
6515
6516 * cli/cli-cmds.c (valid_command_p): Return bool.
6517
7f008c9e
TT
65182019-05-04 Tom Tromey <tom@tromey.com>
6519
6520 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6521 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6522
b6484282
RT
65232019-05-04 Raul Tambre <raul@tambre.ee>
6524
6525 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6526 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6527 operator for comparison.
6528
af97b416
TT
65292019-05-04 Tom Tromey <tom@tromey.com>
6530
6531 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6532 (lookup_partial_symbol, print_partial_symbols)
6533 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6534 (psymbol_compare): Update.
6535 (add_psymbol_to_bcache): Clear the entire psymbol.
6536 (maintenance_check_psymtabs): Update.
6537 * psympriv.h (struct partial_symbol): Don't derive from
6538 general_symbol_info.
6539 <obj_section, unrelocated_address, address,
6540 set_unrelocated_address>: Update.
6541 <ginfo>: New member.
6542 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6543 (debug_names::write_psymbols): Update.
6544
9d6d4be8
TV
65452019-05-04 Tom de Vries <tdevries@suse.de>
6546
6547 * contrib/cc-with-tweaks.sh: Support -n arg.
6548
66452beb
PW
65492019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6550
6551 * corelow.c (core_target::detach): Ensure frame cache and
6552 register caches are cleared.
6553 inferior.c (exit_inferior_1): Likewise.
6554
bde09ab7
TT
65552019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6556 Tom Tromey <tom@tromey.com>
6557
6558 * dictionary.c (collate_pending_symbols_by_language): Remove
6559 "struct" from foreach.
6560 * symtab.c (lookup_global_symbol_from_objfile)
6561 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6562 foreach.
6563 * ser-tcp.c (net_open): Remove "struct" from foreach.
6564 * objfiles.c (objfile_relocate, objfile_rebase)
6565 (objfile_has_symbols): Remove "struct" from foreach.
6566 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6567 from foreach.
6568 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6569 foreach.
6570 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6571 "struct" from foreach.
6572 * ada-lang.c (create_excep_cond_exprs)
6573 (ada_exception_catchpoint_cond_string): Remove "struct" from
6574 foreach.
6575
222a8d25
TT
65762019-05-03 Tom Tromey <tromey@adacore.com>
6577
6578 * ada-exp.y (convert_char_literal): Check suffix of each
6579 enumerator.
6580
fcd60b84
DP
65812019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6582
6583 PR ada/21406:
6584 * ada-exp.y (yywrap): Don't define.
6585 * ada-lex.l (%option): Add noyywrap
6586 (yywrap): Remove.
6587
5f2459c2
EZ
65882019-05-03 Eli Zaretskii <eliz@gnu.org>
6589
353ea2d1
EZ
6590 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6591 _WIN32_WINNT to the XP level, unless already defined to a higher
6592 level.
6593
6594 * unittests/parse-connection-spec-selftests.c:
6595 * ser-tcp.c:
6596 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6597 override.
6598
5f2459c2
EZ
6599 * symfile.c (find_separate_debug_file): Remove colon from the
6600 drive spec of DOS/Windows file names of the target, so that the
6601 file name produced from DEBUGDIR and the target's directory will
6602 be valid on DOS/Windows systems.
6603
80062eb9
AB
66042019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6605
6606 * rust-lang.c (val_print_struct): Handle printing structures
6607 containing strings.
6608
b8c05e85
TT
66092019-05-02 Tom Tromey <tromey@adacore.com>
6610
6611 * valarith.c (_initialize_valarith): Remove.
6612
4504bbde
TT
66132019-05-01 Tom Tromey <tromey@adacore.com>
6614
6615 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6616 bitfields.
6617
d48e62f4
TT
66182019-05-01 Tom Tromey <tromey@adacore.com>
6619
6620 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6621 for big-endian copies.
6622
15f18d14
AT
66232019-04-30 Ali Tamur <tamur@google.com>
6624 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6625 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6626 (read_3_bytes): New function.
6627
ab4ee614
JB
66282019-04-30 Joel Brobecker <brobecker@adacore.com>
6629
6630 * windows-nat.c (main_thread_id): Delete.
6631 (handle_output_debug_string): Replace main_thread_id by
6632 current_event.dwThreadId.
6633 (fake_create_process): Likewise.
6634 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6635 Do not set main_thread_id.
6636 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6637 current_event.dwThreadId.
6638 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6639
8ed5b76e
JB
66402019-04-30 Joel Brobecker <brobecker@adacore.com>
6641
6642 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6643 Use current_event.dwThreadId instead of main_thread_id.
6644
2ff0a947
TT
66452019-04-30 Tom Tromey <tromey@adacore.com>
6646
6647 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6648 (create_excep_cond_exprs): Iterate over program spaces.
6649 (ada_exception_catchpoint_cond_string): Examine all minimal
6650 symbols for exception types.
6651
a776957c
TT
66522019-04-30 Tom Tromey <tromey@adacore.com>
6653
6654 PR c++/24470:
6655 * dwarf2read.c (process_structure_scope): Handle case where type
6656 has template parameters but no symbol was created.
6657
bc68014d
AB
66582019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6659 Chris January <chris.january@arm.com>
6660
6661 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6662 qualifier.
6663 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6664
f1fdc960
AB
66652019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6666
6667 * f-typeprint.c (f_print_type): Update rules for printing
6668 whitespace.
6669 (f_type_print_varspec_suffix): Likewise.
6670
bf7a4de1
AB
66712019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6672 Chris January <chris.january@arm.com>
6673
6674 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6675 function arguments.
6676
bbe75b9d
AB
66772019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6678
6679 * f-lang.c (build_fortran_types): Change name of void type to
6680 lower case.
6681 * f-typeprint.c (f_type_print_base): Print the name of the void
6682 type, rather than a fixed string.
6683 * f-valprint.c (f_decorations): Use lower case void string.
6684
1db455a7
AB
66852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6686 Chris January <chris.january@arm.com>
6687
6688 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6689 types for Fortran.
6690
b6d03bb2
AB
66912019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6692 Chris January <chris.january@arm.com>
6693 David Lecomber <david.lecomber@arm.com>
6694
6695 * f-exp.y (BINOP_INTRINSIC): New token.
6696 (exp): New parser rule handling BINOP_INTRINSIC.
6697 (f77_keywords): Add new builtin procedures.
6698 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6699 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6700 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6701 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6702 (print_unop_subexp_f): New function.
6703 (print_binop_subexp_f): New function.
6704 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6705 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6706 (dump_subexp_body_f): Likewise.
6707 (operator_check_f): Likewise.
6708 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6709 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6710
83228e93
AB
67112019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6712
6713 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6714 UNOP_KIND.
6715 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6716 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6717 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6718 (operator_length_f): New fuction.
6719 (print_subexp_f): New function.
6720 (op_name_f): New function.
6721 (dump_subexp_body_f): New function.
6722 (operator_check_f): New function.
6723 (exp_descriptor_f): Replace standard expression handling functions
6724 with new functions.
6725 * gdb/fortran-operator.def: New file.
6726 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6727 * gdb/std-operator.def: Remove UNOP_KIND.
6728
6fdcd7cc
AB
67292019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6730
6731 * std-operator.def: Remove unbalanced, stray double quote
6732 character.
6733
2e62ab40
AB
67342019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6735 Chris January <chris.january@arm.com>
6736 Daniel Everett <daniel.everett@arm.com>
6737 Nick Forrington <nick.forrington@arm.com>
6738 Richard Bunt <richard.bunt@arm.com>
6739
6740 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6741 of depth when printing anonymous structs or unions.
6742 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6743 Don't print either the top-level value, or the children if the
6744 max-depth is exceeded.
6745 (ppscm_print_children): When printing the key of a map, allow one
6746 extra level of depth.
6747 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6748 print either the top-level value, or the children if the max-depth
6749 is exceeded.
6750 (print_children): When printing the key of a map, allow one extra
6751 level of depth.
6752 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6753 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6754 (user_print_options): Initialise max_depth field.
6755 (val_print_scalar_or_string_type_p): New function.
6756 (val_print): Check to see if the max depth has been reached.
6757 (val_print_check_max_depth): Define new function.
6758 (show_print_max_depth): New function.
6759 (_initialize_valprint): Add 'print max-depth' option.
6760 * valprint.h (struct value_print_options) <max_depth>: New field.
6761 (val_print_check_max_depth): Declare new function.
6762 * NEWS: Document new feature.
6763
4be290b2
AB
67642019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6765
6766 * ada-lang.c (ada_language_defn): Initialise new field.
6767 * c-lang.c (c_is_string_type_p): New function.
6768 (c_language_defn): Initialise new field.
6769 (cplus_language_defn): Initialise new field.
6770 (asm_language_defn): Initialise new field.
6771 (minimal_language_defn): Initialise new field.
6772 * c-lang.h (c_is_string_type_p): Declare new function.
6773 * d-lang.c (d_language_defn): Initialise new field.
6774 * f-lang.c (f_is_string_type_p): New function.
6775 (f_language_defn): Initialise new field.
6776 * go-lang.c (go_is_string_type_p): New function.
6777 (go_language_defn): Initialise new field.
6778 * language.c (default_is_string_type_p): New function.
6779 (unknown_language_defn): Initialise new field.
6780 (auto_language_defn): Initialise new field.
6781 * language.h (struct language_defn) <la_is_string_type_p>: New
6782 member variable.
6783 (default_is_string_type_p): Declare new function.
6784 * m2-lang.c (m2_language_defn): Initialise new field.
6785 * objc-lang.c (objc_language_defn): Initialise new field.
6786 * opencl-lang.c (opencl_language_defn): Initialise new field.
6787 * p-lang.c (pascal_is_string_type_p): New function.
6788 (pascal_language_defn): Initialise new field.
6789 * rust-lang.c (rust_is_string_type_p): New function.
6790 (rust_language_defn): Initialise new field.
6791
721b08c6
AB
67922019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6793
6794 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6795 New field.
6796 * ada-lang.c (ada_language_defn): Initialise new field.
6797 * c-lang.c (c_language_defn): Likewise.
6798 (cplus_language_defn): Likewise.
6799 (asm_language_defn): Likewise.
6800 (minimal_language_defn): Likewise.
6801 * d-lang.c (d_language_defn): Likewise.
6802 * f-lang.c (f_language_defn): Likewise.
6803 * go-lang.c (go_language_defn): Likewise.
6804 * language.c (unknown_language_defn): Likewise.
6805 (auto_language_defn): Likewise.
6806 * m2-lang.c (m2_language_defn): Likewise.
6807 * objc-lang.c (objc_language_defn): Likewise.
6808 * opencl-lang.c (opencl_language_defn): Likewise.
6809 * p-lang.c (pascal_language_defn): Likewise.
6810 * rust-lang.c (rust_language_defn): Likewise.
6811
fc913e53
AB
68122019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6813
6814 * ada-lang.c (ada_is_character_type): Change return type to bool.
6815 (ada_is_string_type): Likewise.
6816 * ada-lang.h (ada_is_character_type): Update declaration
6817 (ada_is_string_type): Likewise.
6818
fa731fa0
PW
68192019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6820
6821 Support style in 'frame|thread apply'
6822
6823 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6824 * record.c (record_start, record_stop): Update callers of
6825 execute_command_to_string with false.
6826 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6827 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6828 methods.
6829 (class string_file): New constructor with term_out parameter.
6830 Override methods term_out and can_emit_style_escape. New member
6831 term_out.
6832 (class stdio_file): Override can_emit_style_escape.
6833 (class tee_file): Override term_out and can_emit_style_escape.
6834 * utils.h (can_emit_style_escape): Remove.
6835 * utils.c (can_emit_style_escape): Likewise.
6836 Update all callers of can_emit_style_escape (SOMESTREAM) to
6837 SOMESTREAM->can_emit_style_escape.
6838 * source-cache.c (source_cache::get_source_lines): Likewise.
6839 * stack.c (frame_apply_command_count): Call execute_command_to_string
6840 passing the term_out characteristic of the current gdb_stdout.
6841 * thread.c (thr_try_catch_cmd): Likewise.
6842 * top.c (execute_command_to_string): pass term_out parameter
6843 to construct the string_file for the command output.
6844 * ui-file.c (term_cli_styling): New function (most code moved
6845 from utils.c can_emit_style_escape).
6846 (string_file::string_file, string_file::can_emit_style_escape,
6847 stdio_file::can_emit_style_escape, tee_file::term_out,
6848 tee_file::can_emit_style_escape): New functions.
6849
136afab8
PW
68502019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6851
6852 * NEWS: Mention the new set|show may-call-functions.
6853 * infcall.c (may_call_functions_p): New variable.
6854 (show_may_call_functions_p): New function.
6855 (call_function_by_hand_dummy): Throws an error if not
6856 may-call-functions.
6857 (_initialize_infcall): Call add_setshow_boolean_cmd for
6858 may-call-functions.
6859
725cbb63
KS
68602019-04-25 Keith Seitz <keiths@redhat.com>
6861
6862 PR c++/24367
6863 * cp-support.c (inspect_type): Don't attempt substitutions
6864 of symbol with the same name.
6865
3d1cbb78
TT
68662019-04-25 Tom Tromey <tromey@adacore.com>
6867
6868 PR gdb/24475:
6869 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6870 static.
6871
94aeb44b
TT
68722019-04-25 Tom Tromey <tromey@adacore.com>
6873
6874 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6875 rvalue reference.
6876 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6877 (gdb_xml_parser::parse): Use std::move.
6878 * python/python-internal.h (gdbpy_convert_exception): Take a const
6879 reference.
6880 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6881 std::move.
6882 * python/py-utils.c (gdbpy_convert_exception): Take a const
6883 reference.
6884 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6885 Use std::move.
6886 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6887 Use std::move.
6888 * mi/mi-main.c (mi_print_exception): Take a const reference.
6889 * main.c (handle_command_errors): Take a const reference.
6890 * linespec.c (parse_linespec): Use std::move.
6891 * infcall.c (run_inferior_call): Use std::move.
6892 (call_function_by_hand_dummy): Use std::move.
6893 * exec.c (try_open_exec_file): Use std::move.
6894 * exceptions.h (exception_print, exception_fprintf)
6895 (exception_print_same): Update.
6896 * exceptions.c (print_exception, exception_print)
6897 (exception_fprintf, exception_print_same): Change parameters to
6898 const reference.
6899 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6900 * common/new-op.c: Use std::move.
6901 * common/common-exceptions.h (struct gdb_exception): Add move
6902 constructor.
6903 (struct gdb_exception_error, struct gdb_exception_quit, struct
6904 gdb_quit_bad_alloc): Change constructor to move constructor.
6905 (throw_exception): Change parameter to rvalue reference.
6906 * common/common-exceptions.c (throw_exception): Take rvalue
6907 reference.
6908 * cli/cli-interp.c (safe_execute_command): Use std::move.
6909 * breakpoint.c (insert_bp_location, location_to_sals): Use
6910 std::move.
6911
680d7fd5
TT
69122019-04-25 Tom Tromey <tromey@adacore.com>
6913
6914 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6915 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6916 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6917 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6918 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6919 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6920 guile/scm-value.c: Use unpack.
6921 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6922 gdbscm_gdb_exception.
6923 (gdbscm_throw_gdb_exception): Likewise.
6924 (struct gdbscm_gdb_exception): New.
6925 (unpack): New function.
6926 (gdbscm_wrap): Use unpack.
6927
c6fdd8b2
TT
69282019-04-25 Tom Tromey <tromey@adacore.com>
6929
6930 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6931 (gdb_rl_callback_handler): Use std::move.
6932 * common/common-exceptions.h (struct gdb_exception): Add move
6933 assignment operator.
6934 (throw_exception_sjlj): Change "exception" to const reference.
6935 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6936 (throw_exception_sjlj): Change "exception" to const reference.
6937
cc06b668
TT
69382019-04-25 Tom Tromey <tromey@adacore.com>
6939
6940 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6941 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6942 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6943 Update.
6944 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6945 Update.
6946 * mi/mi-interp.c (mi_interp::exec): Update.
6947 * linespec.c (parse_linespec): Update.
6948 * infcall.c (run_inferior_call): Update.
6949 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6950 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6951 (gdbscm_lookup_global_symbol): Update.
6952 * guile/scm-param.c (gdbscm_parameter_value): Update.
6953 * guile/scm-frame.c (gdbscm_frame_read_register)
6954 (gdbscm_frame_read_var): Update.
6955 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6956 * exec.c (try_open_exec_file): Update.
6957 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6958 (gdb_rl_callback_handler): Update.
6959 * common/common-exceptions.h (exception_none): Don't declare.
6960 * common/common-exceptions.c (exception_none): Don't define.
6961 (struct catcher) <exception>: Update.
6962 * cli/cli-interp.c (safe_execute_command): Update.
6963 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6964
cf532bd1
AT
69652019-04-25 Ali Tamur <tamur@google.com>
6966
6967 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6968 (read_attribute_value): Likewise.
6969 (dwarf2_read_addr_index): Update comment.
6970 (read_str_index): Add DW_FORM_strx.
6971 (dwarf2_string_attr): Likewise.
6972 (dwarf2_const_value_attr): Likewise.
6973 (dump_die_shallow): Likewise.
6974 (dwarf2_fetch_constant_bytes): Likewise.
6975 (skip_form_bytes): Likewise.
6976 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6977
82433e3e
SDJ
69782019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6979
6980 PR corefiles/11608
6981 PR corefiles/18187
6982 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6983 OFFSET. Verify if current mapping contains an ELF header.
6984 (linux_find_memory_regions_full): Adjust call to
6985 dump_mapping_p.
6986
723adb65
SL
69872019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6988 Kang Li <kanglictf@gmail.com>
6989
6990 PR gdb/21600
6991
6992 * dwarf2-frame.c (read_initial_length): Be consistent about using
6993 unsigned representation of length.
6994 (decode_frame_entry_1): Likewise. Check for wraparound of
6995 end pointer as well as buffer overflow.
6996
596179f7
SDJ
69972019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6998
6999 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7000 "vq".
7001
a59240a4
TT
70022019-04-24 Tom Tromey <tromey@adacore.com>
7003
7004 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7005
f872fdbb
AB
70062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7007
7008 * s12z-tdep.c (s12z_unwind_pc): Delete.
7009 (s12z_unwind_sp): Delete.
7010 (s12z_gdbarch_init): Don't register deleted functions with
7011 gdbarch.
7012
b614e6f3
AB
70132019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7014
7015 * rl78-tdep.c (rl78_unwind_sp): Delete.
7016 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7017
14faed38
AB
70182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7019
7020 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7021 (xstormy16_unwind_pc): Delete.
7022 (xstormy16_dummy_id): Delete.
7023 (xstormy16_gdbarch_init): Don't register deleted functions with
7024 gdbarch.
7025
541aad8a
AB
70262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7027
7028 * vax-tdep.c (vax_unwind_pc): Delete.
7029 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7030
29222070
AB
70312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7032
7033 * v850-tdep.c (v850_unwind_sp): Delete.
7034 (v850_unwind_pc): Delete.
7035 (v850_dummy_id): Delete.
7036 (v850_gdbarch_init): Don't register deleted functions with
7037 gdbarch.
7038
0f534d76
AB
70392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7040
7041 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7042 (tilegx_unwind_pc): Delete.
7043 (tilegx_unwind_dummy_id): Delete.
7044 (tilegx_gdbarch_init): Don't register deleted functions with
7045 gdbarch.
7046
1ba7b7f9
AB
70472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7048
7049 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7050 (tic6x_dummy_id): Delete.
7051 (tic6x_gdbarch_init): Don't register deleted functions with
7052 gdbarch.
7053
d31f262c
AB
70542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7055
7056 * sparc-tdep.c (sparc_unwind_pc): Delete.
7057 (sparc32_gdbarch_init): Don't register deleted function with
7058 gdbarch.
7059
6d14d64d
AB
70602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7061
7062 * sh-tdep.c (sh_unwind_sp): Delete.
7063 (sh_unwind_pc): Delete.
7064 (sh_dummy_id): Delete.
7065 (sh_gdbarch_init): Don't register deleted functions with
7066 gdbarch.
7067
a40dde9d
AB
70682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7069
7070 * score-tdep.c (score_unwind_sp): Delete.
7071 (score_unwind_pc): Delete.
7072 (score_dummy_id): Delete.
7073 (score_gdbarch_init): Don't register deleted functions with
7074 gdbarch.
7075
47c47d69
AB
70762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7077
7078 * rx-tdep.c (rx_unwind_pc): Delete.
7079 (rx_unwind_sp): Delete.
7080 (rx_dummy_id): Delete.
7081 (rx_gdbarch_init): Don't register deleted functions with
7082 gdbarch. Update comment.
7083
833a4480
AB
70842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7085
7086 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7087 (rs6000_dummy_id): Delete.
7088 (rs6000_gdbarch_init): Don't register deleted functions with
7089 gdbarch.
7090
3f2cef49
AB
70912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7092
7093 * or1k-tdep.c (or1k_dummy_id): Delete.
7094 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7095
96acf884
AB
70962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7097
7098 * nios2-tdep.c (nios2_dummy_id): Delete.
7099 (nios2_unwind_sp): Delete.
7100 (nios2_gdbarch_init): Don't register deleted functions with
7101 gdbarch.
7102
ca0ab0aa
AB
71032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7104
7105 * nds32-tdep.c (nds32_dummy_id): Delete.
7106 (nds32_unwind_pc): Delete.
7107 (nds32_unwind_sp): Delete.
7108 (nds32_gdbarch_init): Don't register deleted functions with
7109 gdbarch.
7110
c8259044
AB
71112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7112
7113 * msp430-tdep.c (msp430_unwind_pc): Delete.
7114 (msp430_unwind_sp): Delete.
7115 (msp430_dummy_id): Delete.
7116 (msp430_gdbarch_init): Don't register deleted functions with
7117 gdbarch.
7118
27f113c8
AB
71192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7120
7121 * moxie-tdep.c (moxie_unwind_sp): Delete.
7122 (moxie_unwind_pc): Delete.
7123 (moxie_dummy_id): Delete.
7124 (moxie_gdbarch_init): Don't register deleted functions with
7125 gdbarch.
7126
aee6c3cd
AB
71272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7128
7129 * mn10300-tdep.c (mn10300_dummy_id): Delete.
7130 (mn10300_unwind_pc): Delete.
7131 (mn10300_unwind_sp): Delete.
7132 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7133 mn10300_unwind_sp.
7134 (mn10300_frame_unwind_init): Don't register deleted functions with
7135 gdbarch.
7136
8e2b5aea
AB
71372019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7138
7139 * mep-tdep.c (mep_unwind_pc): Delete.
7140 (mep_unwind_sp): Delete.
7141 (mep_dummy_id): Delete.
7142 (mep_gdbarch_init): Don't register deleted functions with
7143 gdbarch.
7144
43cf3ede
AB
71452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7146
7147 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7148 (m68hc11_unwind_sp): Delete.
7149 (m68hc11_gdbarch_init): Don't register deleted functions with
7150 gdbarch.
7151
5e79b7bb
AB
71522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7153
7154 * m32r-tdep.c (m32r_unwind_sp): Delete.
7155 (m32r_unwind_pc): Delete.
7156 (m32r_dummy_id): Delete.
7157 (m32r_gdbarch_init): Don't register deleted functions with
7158 gdbarch.
7159
89b268d8
AB
71602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7161
7162 * m32c-tdep.c (m32c_unwind_pc): Delete.
7163 (m32c_unwind_sp): Delete.
7164 (m32c_dummy_id): Delete.
7165 (m32c_gdbarch_init): Don't register deleted functions with
7166 gdbarch.
7167
946c28d2
AB
71682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7169
7170 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7171 (lm32_unwind_pc): Delete.
7172 (lm32_dummy_id): Delete.
7173 (lm32_gdbarch_init): Don't register deleted functions with
7174 gdbarch.
7175
bf12844a
AB
71762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7177
7178 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7179 (iq2000_unwind_pc): Delete.
7180 (iq2000_dummy_id): Delete.
7181 (iq2000_gdbarch_init): Don't register deleted functions with
7182 gdbarch.
7183
ecbc06d2
AB
71842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7185
7186 * nds32-tdep.c (nds32_type_align): Delete.
7187 (nds32_push_dummy_call): Use type_align instead.
7188
030197b4
AB
71892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7190
7191 * arm-tdep.c (arm_type_align): Only handle vector override case.
7192 (arm_push_dummy_call): Use type_align.
7193 (arm_gdbarch_init): Register arm_type_align gdbarch function.
7194
b907456c
AB
71952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7196
7197 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7198 case.
7199 (pass_on_stack): Use type_align.
7200 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7201 function.
7202
9e97ba43
TT
72032019-04-23 Tom Tromey <tromey@adacore.com>
7204
7205 * dwarf2read.c (line_header::file_name_at): Remove unused
7206 overload.
7207
6892f601
TV
72082019-04-23 Tom de Vries <tdevries@suse.de>
7209
7210 PR gdb/24438
7211 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7212 invocation.
7213
336d760d
AT
7214
72152019-03-27 Ali Tamur <tamur@google.com>
7216
7217 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7218 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7219 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7220 (dwarf_expr_context::get_addr_index): Likewise
7221 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7222 (symbol_needs_eval_context::get_addr_index): Likewise
7223 (disassemble_dwarf_expression): Add DW_OP_addrx
7224 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7225 (read_cutu_die_from_dwo): Update comment
7226 (skip_one_die): Add DW_FORM_addrx
7227 (read_attribute_value): Likewise
7228 (var_decode_location): Add DW_OP_addrx
7229 (dwarf2_const_value_attr): Add DW_FORM_addrx
7230 (dump_die_shallow): Likewise
7231 (dwarf2_fetch_constant_bytes): Likewise
7232 (decode_locdesc): Add DW_OP_addrx
7233 (skip_form_bytes): Add DW_FORM_addrx
7234
ad9d13f8
AT
72352019-04-22 Ali Tamur <tamur@google.com>
7236
7237 * MAINTAINERS (Write After Approval): Add self.
7238
d70cc3ba
SM
72392019-04-22 Simon Marchi <simon.marchi@efficios.com>
7240
7241 * solib-svr4.c (get_svr4_info): Add pspace parameter.
7242 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7243 (open_symbol_file_object): Likewise.
7244 (svr4_default_sos): Add info parameter.
7245 (svr4_read_so_list): Likewise.
7246 (svr4_current_sos_direct): Adjust functions calls to pass down
7247 info.
7248 (svr4_current_sos_1): Add info parameter.
7249 (svr4_current_sos): Call get_svr4_info, pass info down to
7250 svr4_current_sos_1.
7251 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7252 get_svr4_info.
7253 (svr4_in_dynsym_resolve_code): Pass current_program_space to
7254 get_svr4_info.
7255 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7256 to get_svr4_info.
7257 (probes_table_remove_objfile_probes): Likewise.
7258 (register_solib_event_probe): Add info parameter.
7259 (solist_update_incremental): Pass info parameter down to
7260 svr4_read_so_list.
7261 (disable_probes_interface): Add info parameter.
7262 (svr4_handle_solib_event): Pass current_program_space to
7263 get_svr4_info. Adjust disable_probes_interface cleanup.
7264 (svr4_create_probe_breakpoints): Add info parameter, pass it
7265 down to register_solib_event_probe.
7266 (svr4_create_solib_event_breakpoints): Add info parameter,
7267 pass it down to svr4_create_probe_breakpoints.
7268 (enable_break): Pass info down to
7269 svr4_create_solib_event_breakpoints.
7270 (svr4_solib_create_inferior_hook): Pass current_program_space to
7271 get_svr4_info.
7272 (svr4_clear_solib): Likewise.
7273
7905fc35
PA
72742019-04-22 Pedro Alves <palves@redhat.com>
7275
7276 * solib-svr4.c (svr4_free_objfile_observer): New.
7277 (probe_and_action::objfile): New field.
7278 (probes_table_htab_remove_objfile_probes)
7279 (probes_table_remove_objfile_probes): New functions.
7280 (register_solib_event_probe): Add 'objfile' parameter. Store it
7281 in the new probe_and_action. Don't store the probe in 'lookup'.
7282 (svr4_create_probe_breakpoints): Pass objfile to
7283 register_solib_event_probe.
7284 (_initialize_svr4_solib): Register a free_objfile observer.
7285
fb881986
TT
72862019-04-19 Tom Tromey <tom@tromey.com>
7287
7288 * common/queue.h: Remove.
7289
8732db6c
TT
72902019-04-19 Tom Tromey <tom@tromey.com>
7291
7292 * event-loop.c: Don't include "common/queue.h".
7293
97dfbadd
TT
72942019-04-19 Tom Tromey <tom@tromey.com>
7295
7296 * remote.c (remote_target): Use delete.
7297 * remote-notif.h: Include <list>, not "common/queue.h".
7298 (notif_client_p): Remove typedef.
7299 (remote_notif_state): Add constructor, destructor, initializer.
7300 <notif_queue>: Now a std::list.
7301 (remote_notif_state_xfree): Don't declare.
7302 * remote-notif.c (remote_notif_process, handle_notification)
7303 (remote_notif_state_allocate): Update.
7304 (~remote_notif_state): Rename from remote_notif_state_xfree.
7305
cf250e36
TT
73062019-04-19 Tom Tromey <tom@tromey.com>
7307
7308 * symfile.c (reread_symbols): Update.
7309 * objfiles.c (objfile_register_static_link)
7310 (objfile_lookup_static_link): Update
7311 (~objfile) Don't delete static_links.
7312 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7313
61f4b350
TT
73142019-04-19 Tom Tromey <tom@tromey.com>
7315
7316 * type-stack.h (struct type_stack) <insert>: Constify string.
7317 * type-stack.c (type_stack::insert): Constify string.
7318 * gdbtypes.h (lookup_template_type): Update.
7319 (address_space_name_to_int): Update.
7320 * gdbtypes.c (address_space_name_to_int): Make space_identifier
7321 const.
7322 (lookup_template_type): Make name const.
7323 * c-exp.y: Update rules.
7324 (lex_one_token, classify_name, classify_inner_name)
7325 (c_print_token): Update.
7326 * p-exp.y: Update rules.
7327 (yylex): Update.
7328 * f-exp.y: Update rules.
7329 (yylex): Update.
7330 * d-exp.y: Update rules.
7331 (lex_one_token, classify_name, classify_inner_name): Update.
7332 * parse.c (write_dollar_variable, copy_name): Return std::string.
7333 * parser-defs.h (copy_name): Change return type.
7334 * m2-exp.y: Update rules.
7335 (yylex): Update.
7336 * go-exp.y (lex_one_token): Update.
7337 Update rules.
7338 (classify_unsafe_function, classify_packaged_name)
7339 (classify_name, yylex): Update.
7340
189b8c2e
ST
73412019-04-19 Sergei Trofimovich <siarheit@google.com>
7342
7343 * configure.ac: add --enable-source-highlight switch.
7344 * configure: Regenerate.
7345 * top.c (print_gdb_version): plumb --enable-source-highlight
7346 status to "show configuration".
7347
8ecb59f8
TT
73482019-04-19 Tom Tromey <tromey@adacore.com>
7349
7350 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7351 Check ADA_TYPE_P.
7352 (empty_record, ada_template_to_fixed_record_type_1)
7353 (template_to_static_fixed_type)
7354 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7355 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7356 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7357 macros.
7358
62160ec9
TT
73592019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
7360
7361 PR symtab/24423:
7362 * source.c (print_source_lines_base): Advance "iter" when a
7363 control character is seen.
7364
f2ae8bc8
PW
73652019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7366
7367 * inferior.h (struct infcall_suspend_state_deleter):
7368 Catch exception in destructor to avoid crash.
7369
d563b953
PW
73702019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7371
7372 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7373 close to the add_com "shell".
7374
dc34c897
TT
73752019-04-18 Tom Tromey <tromey@adacore.com>
7376
7377 * process-stratum-target.h (class process_stratum_target)
7378 <stratum>: Add "final".
7379
a12e5744
TT
73802019-04-17 Tom Tromey <tromey@adacore.com>
7381
7382 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7383 against nullptr before use.
7384
a7e559cc
AH
73852019-04-17 Alan Hayward <alan.hayward@arm.com>
7386
7387 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7388
c01660c6
AB
73892019-04-17 Jim Wilson <jimw@sifive.com>
7390 Andrew Burgess <andrew.burgess@embecosm.com>
7391
7392 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7393 code read might fail, assume 4-byte breakpoint in that case.
7394
4aa866af
LS
73952019-04-15 Leszek Swirski <leszeks@google.com>
7396
7397 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7398 rather than a hand-rolled POD check when checking for forced MEMORY
7399 classification.
7400
48574d91
AH
74012019-04-15 Alan Hayward <alan.hayward@arm.com>
7402
7403 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7404 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7405 function.
7406 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7407 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7408 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7409 declaration.
7410
4da037ef
AH
74112019-04-15 Alan Hayward <alan.hayward@arm.com>
7412
7413 * aarch64-linux-nat.c
7414 (aarch64_linux_nat_target::thread_architecture): Add override.
7415 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7416 each VQ.
7417
ccb8d7e8
AH
74182019-04-15 Alan Hayward <alan.hayward@arm.com>
7419
7420 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7421
35add35e
AB
74222019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
7423
7424 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7425 target types of size 96-bits, add some additional comments, and
7426 check that the builtin type we found was the correct size.
7427
51196bbc
EZ
74282019-04-12 Eli Zaretskii <eliz@gnu.org>
7429
7430 * utils.c (prompt_for_continue): Don't restore the styling at the
7431 end, as applied_style has the wrong value. This fixes styling in
7432 long lists of file names that are interrupted by the "Continue?"
7433 prompt.
7434
62253a61
AB
74352019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
7436
7437 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7438 * c-lang.c (c_language_defn): Likewise.
7439 (cplus_language_defn): Likewise.
7440 (asm_language_defn): Likewise.
7441 (minimal_language_defn): Likewise.
7442 * d-lang.c (d_language_defn): Likewise.
7443 * f-lang.c (f_language_defn): Likewise.
7444 * go-lang.c (go_language_defn): Likewise.
7445 * language.c (unknown_language_defn): Likewise.
7446 (auto_language_defn): Likewise.
7447 * language.h (struct language_defn): Remove la_magic field.
7448 (LANG_MAGIC): Delete.
7449 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7450 * objc-lang.c (objc_language_defn): Likewise.
7451 * opencl-lang.c (opencl_language_defn): Likewise.
7452 * p-lang.c (pascal_language_defn): Likewise.
7453 * rust-lang.c (rust_language_defn): Likewise.
7454
a9158a86
AB
74552019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7456
7457 * riscv-tdep.c (riscv_type_align): New function.
7458 (riscv_type_alignment): Delete.
7459 (riscv_arg_location): Use 'type_align'.
7460 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7461
41077b66
AB
74622019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7463
7464 * gdbtypes.c (type_align): A struct with no non-static fields also
7465 has alignment of 1.
7466
9f0272f8
AB
74672019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7468
7469 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7470 component to 0.
7471 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7472 member.
7473 (riscv_struct_info::analyse): New implementation using new
7474 analyse_inner member function.
7475 (riscv_struct_info::field_offset): New member function.
7476 (riscv_struct_info::m_offsets): New member variable.
7477 (riscv_struct_info::analyse_inner): New private member function,
7478 takes the old implementation of riscv_struct_info::analyse but
7479 extended to track field offsets.
7480 (riscv_call_arg_struct): Update the struct folding special cases
7481 to handle cases where empty C++ structs, which are non-zero
7482 length, are found.
7483 (riscv_arg_location): Initialise the length of each location, a
7484 non-zero length now indicates the location is in use.
7485 (riscv_push_dummy_call): Allow for the first location having a
7486 non-zero offset when setting up arguments.
7487 (riscv_return_value): Likewise, but for return values.
7488
02cf60c7
TT
74892019-04-11 Tom Tromey <tromey@adacore.com>
7490
7491 * utils.c (internal_vproblem): Make "msg" const.
7492
68811f8f
AH
74932019-04-11 Alan Hayward <alan.hayward@arm.com>
7494
7495 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7496 * trad-frame.c (trad_frame_reset_saved_regs): New function.
7497 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7498 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7499
3f52fdbc
KB
75002019-04-10 Kevin Buettner <kevinb@redhat.com>
7501
7502 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7503 function.
7504 (fill_gregset): Call amd64_linux_collect_native_gregset instead
7505 of amd64_collect_native_gregset.
7506 (amd64_linux_nat_target::store_registers): Likewise.
7507
e9ad22ee
TT
75082019-04-10 Tom Tromey <tom@tromey.com>
7509
7510 * symtab.c (lookup_global_symbol_from_objfile)
7511 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7512 * objfiles.h (class separate_debug_iterator): New.
7513 (class separate_debug_range): New.
7514 (struct objfile) <separate_debug_objfiles>: New method.
7515 (objfile_separate_debug_iterate): Don't declare.
7516 * objfiles.c (separate_debug_iterator::operator++): Rename from
7517 objfile_separate_debug_iterate.
7518 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7519 iterator.
7520 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7521 iterator.
7522
ee371134
TT
75232019-04-10 Tom Tromey <tom@tromey.com>
7524
7525 * symfile.c (reread_symbols): Remove old comment.
7526 * objfiles.c (free_all_objfiles): Fix a typo.
7527
bf227d61
TT
75282019-04-10 Tom Tromey <tom@tromey.com>
7529
7530 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7531 * minsyms.c (lookup_minimal_symbol): Use foreach.
7532 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7533 (lookup_minimal_symbol_solib_trampoline): Likewise.
7534 * symfile.c (reread_symbols): Use foreach.
7535
8dc433a0
TT
75362019-04-09 Ivan Begert <ivanbegert@gmail.com>
7537 Tom Tromey <tromey@adacore.com>
7538
7539 PR rust/24414:
7540 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7541 (rust_lex_int_test): Change "value" to be LONGEST.
7542 (rust_lex_tests): Add test for long integer literal.
7543
9ab8741a
TT
75442019-04-09 Tom Tromey <tromey@adacore.com>
7545
7546 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7547 to bool.
7548 (extended_remote_target::attach): Update.
7549 (remote_target::remote_notice_new_inferior): Update.
7550 (remote_target::add_current_inferior_and_thread): Update.
7551 * inferior.c (exit_inferior_1): Use "false".
7552 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7553
e242fd12
SM
75542019-04-09 Simon Marchi <simon.marchi@efficios.com>
7555
9ca1957f 7556 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
7557 the "start" command.
7558
2b0c8b01
KB
75592019-04-08 Kevin Buettner <kevinb@redhat.com>
7560
7561 * python/py-inferior.c (infpy_thread_from_thread_handle):
7562 Adjust comments to reflect renaming of thread_from_thread_handle
7563 to thread_from_handle. Adjust keywords. Fix type error message.
7564 (inferior_object_methods): Add thread_from_handle. Retain
7565 thread_from_thread_handle, but mark it as deprecated.
7566
50a82723
KB
75672019-04-08 Kevin Buettner <kevinb@redhat.com>
7568
7569 * gdbthread.h (find_thread_by_handle): Revise declaration.
7570 * thread.c (find_thread_by_handle): Likewise. Adjust
7571 implementation too.
7572 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7573 support for buffer objects as handles.
7574
cf63b016
KB
75752019-04-08 Kevin Buettner <kevinb@redhat.com>
7576
7577 * python/py-infthread.c (thpy_thread_handle): New function.
7578 (thread_object_methods): Register thpy_thread_handle.
7579
3d6c6204
KB
75802019-04-08 Kevin Buettner <kevinb@redhat.com>
7581
7582 * gdbthread.h (thread_to_thread_handle): Declare.
7583 * thread.c (gdbtypes.h): Include.
7584 (thread_to_thread_handle): New function.
7585
7586 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7587 (target_thread_info_to_thread_handle): Declare.
7588 * target.c (target_thread_info_to_thread_handle): New function.
7589 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7590 * target-delegates.c: Regenerate.
7591
7592 * linux-thread-db.c (class thread_db_target): Add method
7593 thread_info_to_thread_handle.
7594 (thread_db_target::thread_info_to_thread_handle): Define.
7595 * remote.c (class remote_target): Add new method
7596 thread_info_to_thread_handle.
7597 (remote_target::thread_info_to_thread_handle): Define.
7598
56be6ea8
PA
75992019-04-08 Pedro Alves <palves@redhat.com>
7600
7601 * common/common-exceptions.c (throw_exception): Don't create
7602 named object to throw; throw directly.
7603 (throw_it): Likewise. Don't initialize gdb_exception::message
7604 here, with new; pass FMT and AP to the ctor instead.
7605 * common/common-exceptions.h: Include <string>.
7606 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7607 const char *, va_list)): New ctor. Use std::make_shared.
7608 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7609 errors)): Delete.
7610 (gdb_exception_error::gdb_exception_error(enum errors, const char
7611 *, va_list)): New.
7612 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7613 Add assertion.
7614 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7615 errors)): Delete.
7616 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7617 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7618 Add assertion.
7619
eedc3f4f
TT
76202019-04-08 Tom Tromey <tom@tromey.com>
7621
7622 * valops.c (value_rtti_indirect_type): Replace throw_exception
7623 with throw.
7624 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7625 with throw.
7626 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7627 throw.
7628 * target.c (target_translate_tls_address): Replace throw_exception
7629 with throw.
7630 * stack.c (frame_apply_command_count): Replace throw_exception
7631 with throw.
7632 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7633 throw.
7634 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7635 with throw.
7636 * rs6000-tdep.c (rs6000_frame_cache)
7637 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7638 * remote.c: Replace throw_exception with throw.
7639 * record-full.c (record_full_message, record_full_wait_1)
7640 (record_full_restore): Replace throw_exception with throw.
7641 * record-btrace.c:
7642 (get_thread_current_frame_id, record_btrace_start_replaying)
7643 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7644 (cmd_record_btrace_start): Replace throw_exception with throw.
7645 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7646 throw.
7647 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7648 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7649 * linespec.c:
7650 (find_linespec_symbols): Replace throw_exception with throw.
7651 * infrun.c (displaced_step_prepare, resume): Replace
7652 throw_exception with throw.
7653 * infcmd.c (post_create_inferior): Replace throw_exception with
7654 throw.
7655 * inf-loop.c (inferior_event_handler): Replace throw_exception
7656 with throw.
7657 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7658 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7659 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7660 (get_prev_frame_always, get_frame_pc_if_available)
7661 (get_frame_address_in_block_if_available, get_frame_language):
7662 Replace throw_exception with throw.
7663 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7664 throw_exception with throw.
7665 * eval.c (fetch_subexp_value, evaluate_var_value)
7666 (evaluate_funcall, evaluate_subexp_standard): Replace
7667 throw_exception with throw.
7668 * dwarf2loc.c (call_site_find_chain)
7669 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7670 Replace throw_exception with throw.
7671 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7672 with throw.
7673 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7674 throw.
7675 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7676 * completer.c (complete_line_internal): Replace throw_exception
7677 with throw.
7678 * compile/compile-object-run.c (compile_object_run): Replace
7679 throw_exception with throw.
7680 * cli/cli-script.c (process_next_line): Replace throw_exception
7681 with throw.
7682 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7683 (btrace_enable, btrace_maint_update_pt_packets): Replace
7684 throw_exception with throw.
7685 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7686 throw_exception with throw.
7687 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7688 throw_exception with throw.
7689 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7690 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7691 * aarch64-tdep.c (aarch64_make_prologue_cache)
7692 (aarch64_make_stub_cache): Replace throw_exception with throw.
7693
26003a20
TT
76942019-04-08 Tom Tromey <tom@tromey.com>
7695
7696 * common/common-exceptions.c (throw_exception): Rename from
7697 throw_exception_cxx. Remove old copy. Make argument const.
7698 (throw_it): Create and throw exception objects directly.
7699 * common/common-exceptions.h (throw_exception): Make argument
7700 const.
7701 (struct gdb_exception_error): Add constructor.
7702 (struct gdb_exception_quit): Add constructor.
7703
d272eb37
TT
77042019-04-08 Tom Tromey <tom@tromey.com>
7705
7706 * common/common-exceptions.h (exception_rethrow): Don't declare.
7707 (TRY_SJLJ): Update comment.
7708 (TRY, CATCH, END_CATCH): Remove.
7709 * common/common-exceptions.c (exception_rethrow): Remove.
7710
230d2906
TT
77112019-04-08 Tom Tromey <tom@tromey.com>
7712
7713 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7714 Remove.
7715 (gdb_exception_error): Rename from
7716 gdb_exception_RETURN_MASK_ERROR.
7717 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7718 (gdb_quit_bad_alloc): Update.
7719 * aarch64-tdep.c: Update.
7720 * ada-lang.c: Update.
7721 * ada-typeprint.c: Update.
7722 * ada-valprint.c: Update.
7723 * amd64-tdep.c: Update.
7724 * arch-utils.c: Update.
7725 * break-catch-throw.c: Update.
7726 * breakpoint.c: Update.
7727 * btrace.c: Update.
7728 * c-varobj.c: Update.
7729 * cli/cli-cmds.c: Update.
7730 * cli/cli-interp.c: Update.
7731 * cli/cli-script.c: Update.
7732 * common/common-exceptions.c: Update.
7733 * common/new-op.c: Update.
7734 * common/selftest.c: Update.
7735 * compile/compile-c-symbols.c: Update.
7736 * compile/compile-cplus-symbols.c: Update.
7737 * compile/compile-object-load.c: Update.
7738 * compile/compile-object-run.c: Update.
7739 * completer.c: Update.
7740 * corelow.c: Update.
7741 * cp-abi.c: Update.
7742 * cp-support.c: Update.
7743 * cp-valprint.c: Update.
7744 * darwin-nat.c: Update.
7745 * disasm-selftests.c: Update.
7746 * dtrace-probe.c: Update.
7747 * dwarf-index-cache.c: Update.
7748 * dwarf-index-write.c: Update.
7749 * dwarf2-frame-tailcall.c: Update.
7750 * dwarf2-frame.c: Update.
7751 * dwarf2loc.c: Update.
7752 * dwarf2read.c: Update.
7753 * eval.c: Update.
7754 * event-loop.c: Update.
7755 * event-top.c: Update.
7756 * exec.c: Update.
7757 * f-valprint.c: Update.
7758 * fbsd-tdep.c: Update.
7759 * frame-unwind.c: Update.
7760 * frame.c: Update.
7761 * gdbtypes.c: Update.
7762 * gnu-v3-abi.c: Update.
7763 * guile/guile-internal.h: Update.
7764 * guile/scm-block.c: Update.
7765 * guile/scm-breakpoint.c: Update.
7766 * guile/scm-cmd.c: Update.
7767 * guile/scm-disasm.c: Update.
7768 * guile/scm-frame.c: Update.
7769 * guile/scm-lazy-string.c: Update.
7770 * guile/scm-math.c: Update.
7771 * guile/scm-param.c: Update.
7772 * guile/scm-ports.c: Update.
7773 * guile/scm-pretty-print.c: Update.
7774 * guile/scm-symbol.c: Update.
7775 * guile/scm-symtab.c: Update.
7776 * guile/scm-type.c: Update.
7777 * guile/scm-value.c: Update.
7778 * i386-linux-tdep.c: Update.
7779 * i386-tdep.c: Update.
7780 * inf-loop.c: Update.
7781 * infcall.c: Update.
7782 * infcmd.c: Update.
7783 * infrun.c: Update.
7784 * jit.c: Update.
7785 * language.c: Update.
7786 * linespec.c: Update.
7787 * linux-fork.c: Update.
7788 * linux-nat.c: Update.
7789 * linux-tdep.c: Update.
7790 * linux-thread-db.c: Update.
7791 * main.c: Update.
7792 * mi/mi-cmd-break.c: Update.
7793 * mi/mi-cmd-stack.c: Update.
7794 * mi/mi-interp.c: Update.
7795 * mi/mi-main.c: Update.
7796 * objc-lang.c: Update.
7797 * p-valprint.c: Update.
7798 * parse.c: Update.
7799 * ppc-linux-tdep.c: Update.
7800 * printcmd.c: Update.
7801 * python/py-arch.c: Update.
7802 * python/py-breakpoint.c: Update.
7803 * python/py-cmd.c: Update.
7804 * python/py-finishbreakpoint.c: Update.
7805 * python/py-frame.c: Update.
7806 * python/py-framefilter.c: Update.
7807 * python/py-gdb-readline.c: Update.
7808 * python/py-inferior.c: Update.
7809 * python/py-infthread.c: Update.
7810 * python/py-lazy-string.c: Update.
7811 * python/py-linetable.c: Update.
7812 * python/py-objfile.c: Update.
7813 * python/py-param.c: Update.
7814 * python/py-prettyprint.c: Update.
7815 * python/py-progspace.c: Update.
7816 * python/py-record-btrace.c: Update.
7817 * python/py-record.c: Update.
7818 * python/py-symbol.c: Update.
7819 * python/py-type.c: Update.
7820 * python/py-unwind.c: Update.
7821 * python/py-utils.c: Update.
7822 * python/py-value.c: Update.
7823 * python/python.c: Update.
7824 * record-btrace.c: Update.
7825 * record-full.c: Update.
7826 * remote-fileio.c: Update.
7827 * remote.c: Update.
7828 * riscv-tdep.c: Update.
7829 * rs6000-aix-tdep.c: Update.
7830 * rs6000-tdep.c: Update.
7831 * rust-exp.y: Update.
7832 * rust-lang.c: Update.
7833 * s390-tdep.c: Update.
7834 * selftest-arch.c: Update.
7835 * solib-dsbt.c: Update.
7836 * solib-frv.c: Update.
7837 * solib-spu.c: Update.
7838 * solib-svr4.c: Update.
7839 * solib.c: Update.
7840 * sparc64-linux-tdep.c: Update.
7841 * stack.c: Update.
7842 * symfile-mem.c: Update.
7843 * symmisc.c: Update.
7844 * target.c: Update.
7845 * thread.c: Update.
7846 * top.c: Update.
7847 * tracefile-tfile.c: Update.
7848 * tui/tui.c: Update.
7849 * typeprint.c: Update.
7850 * unittests/cli-utils-selftests.c: Update.
7851 * unittests/parse-connection-spec-selftests.c: Update.
7852 * valops.c: Update.
7853 * valprint.c: Update.
7854 * value.c: Update.
7855 * varobj.c: Update.
7856 * windows-nat.c: Update.
7857 * x86-linux-nat.c: Update.
7858 * xml-support.c: Update.
7859
a70b8144
TT
78602019-04-08 Tom Tromey <tom@tromey.com>
7861
7862 * xml-support.c: Use C++ exception handling.
7863 * x86-linux-nat.c: Use C++ exception handling.
7864 * windows-nat.c: Use C++ exception handling.
7865 * varobj.c: Use C++ exception handling.
7866 * value.c: Use C++ exception handling.
7867 * valprint.c: Use C++ exception handling.
7868 * valops.c: Use C++ exception handling.
7869 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7870 handling.
7871 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7872 * typeprint.c: Use C++ exception handling.
7873 * tui/tui.c: Use C++ exception handling.
7874 * tracefile-tfile.c: Use C++ exception handling.
7875 * top.c: Use C++ exception handling.
7876 * thread.c: Use C++ exception handling.
7877 * target.c: Use C++ exception handling.
7878 * symmisc.c: Use C++ exception handling.
7879 * symfile-mem.c: Use C++ exception handling.
7880 * stack.c: Use C++ exception handling.
7881 * sparc64-linux-tdep.c: Use C++ exception handling.
7882 * solib.c: Use C++ exception handling.
7883 * solib-svr4.c: Use C++ exception handling.
7884 * solib-spu.c: Use C++ exception handling.
7885 * solib-frv.c: Use C++ exception handling.
7886 * solib-dsbt.c: Use C++ exception handling.
7887 * selftest-arch.c: Use C++ exception handling.
7888 * s390-tdep.c: Use C++ exception handling.
7889 * rust-lang.c: Use C++ exception handling.
7890 * rust-exp.y: Use C++ exception handling.
7891 * rs6000-tdep.c: Use C++ exception handling.
7892 * rs6000-aix-tdep.c: Use C++ exception handling.
7893 * riscv-tdep.c: Use C++ exception handling.
7894 * remote.c: Use C++ exception handling.
7895 * remote-fileio.c: Use C++ exception handling.
7896 * record-full.c: Use C++ exception handling.
7897 * record-btrace.c: Use C++ exception handling.
7898 * python/python.c: Use C++ exception handling.
7899 * python/py-value.c: Use C++ exception handling.
7900 * python/py-utils.c: Use C++ exception handling.
7901 * python/py-unwind.c: Use C++ exception handling.
7902 * python/py-type.c: Use C++ exception handling.
7903 * python/py-symbol.c: Use C++ exception handling.
7904 * python/py-record.c: Use C++ exception handling.
7905 * python/py-record-btrace.c: Use C++ exception handling.
7906 * python/py-progspace.c: Use C++ exception handling.
7907 * python/py-prettyprint.c: Use C++ exception handling.
7908 * python/py-param.c: Use C++ exception handling.
7909 * python/py-objfile.c: Use C++ exception handling.
7910 * python/py-linetable.c: Use C++ exception handling.
7911 * python/py-lazy-string.c: Use C++ exception handling.
7912 * python/py-infthread.c: Use C++ exception handling.
7913 * python/py-inferior.c: Use C++ exception handling.
7914 * python/py-gdb-readline.c: Use C++ exception handling.
7915 * python/py-framefilter.c: Use C++ exception handling.
7916 * python/py-frame.c: Use C++ exception handling.
7917 * python/py-finishbreakpoint.c: Use C++ exception handling.
7918 * python/py-cmd.c: Use C++ exception handling.
7919 * python/py-breakpoint.c: Use C++ exception handling.
7920 * python/py-arch.c: Use C++ exception handling.
7921 * printcmd.c: Use C++ exception handling.
7922 * ppc-linux-tdep.c: Use C++ exception handling.
7923 * parse.c: Use C++ exception handling.
7924 * p-valprint.c: Use C++ exception handling.
7925 * objc-lang.c: Use C++ exception handling.
7926 * mi/mi-main.c: Use C++ exception handling.
7927 * mi/mi-interp.c: Use C++ exception handling.
7928 * mi/mi-cmd-stack.c: Use C++ exception handling.
7929 * mi/mi-cmd-break.c: Use C++ exception handling.
7930 * main.c: Use C++ exception handling.
7931 * linux-thread-db.c: Use C++ exception handling.
7932 * linux-tdep.c: Use C++ exception handling.
7933 * linux-nat.c: Use C++ exception handling.
7934 * linux-fork.c: Use C++ exception handling.
7935 * linespec.c: Use C++ exception handling.
7936 * language.c: Use C++ exception handling.
7937 * jit.c: Use C++ exception handling.
7938 * infrun.c: Use C++ exception handling.
7939 * infcmd.c: Use C++ exception handling.
7940 * infcall.c: Use C++ exception handling.
7941 * inf-loop.c: Use C++ exception handling.
7942 * i386-tdep.c: Use C++ exception handling.
7943 * i386-linux-tdep.c: Use C++ exception handling.
7944 * guile/scm-value.c: Use C++ exception handling.
7945 * guile/scm-type.c: Use C++ exception handling.
7946 * guile/scm-symtab.c: Use C++ exception handling.
7947 * guile/scm-symbol.c: Use C++ exception handling.
7948 * guile/scm-pretty-print.c: Use C++ exception handling.
7949 * guile/scm-ports.c: Use C++ exception handling.
7950 * guile/scm-param.c: Use C++ exception handling.
7951 * guile/scm-math.c: Use C++ exception handling.
7952 * guile/scm-lazy-string.c: Use C++ exception handling.
7953 * guile/scm-frame.c: Use C++ exception handling.
7954 * guile/scm-disasm.c: Use C++ exception handling.
7955 * guile/scm-cmd.c: Use C++ exception handling.
7956 * guile/scm-breakpoint.c: Use C++ exception handling.
7957 * guile/scm-block.c: Use C++ exception handling.
7958 * guile/guile-internal.h: Use C++ exception handling.
7959 * gnu-v3-abi.c: Use C++ exception handling.
7960 * gdbtypes.c: Use C++ exception handling.
7961 * frame.c: Use C++ exception handling.
7962 * frame-unwind.c: Use C++ exception handling.
7963 * fbsd-tdep.c: Use C++ exception handling.
7964 * f-valprint.c: Use C++ exception handling.
7965 * exec.c: Use C++ exception handling.
7966 * event-top.c: Use C++ exception handling.
7967 * event-loop.c: Use C++ exception handling.
7968 * eval.c: Use C++ exception handling.
7969 * dwarf2read.c: Use C++ exception handling.
7970 * dwarf2loc.c: Use C++ exception handling.
7971 * dwarf2-frame.c: Use C++ exception handling.
7972 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7973 * dwarf-index-write.c: Use C++ exception handling.
7974 * dwarf-index-cache.c: Use C++ exception handling.
7975 * dtrace-probe.c: Use C++ exception handling.
7976 * disasm-selftests.c: Use C++ exception handling.
7977 * darwin-nat.c: Use C++ exception handling.
7978 * cp-valprint.c: Use C++ exception handling.
7979 * cp-support.c: Use C++ exception handling.
7980 * cp-abi.c: Use C++ exception handling.
7981 * corelow.c: Use C++ exception handling.
7982 * completer.c: Use C++ exception handling.
7983 * compile/compile-object-run.c: Use C++ exception handling.
7984 * compile/compile-object-load.c: Use C++ exception handling.
7985 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7986 * compile/compile-c-symbols.c: Use C++ exception handling.
7987 * common/selftest.c: Use C++ exception handling.
7988 * common/new-op.c: Use C++ exception handling.
7989 * cli/cli-script.c: Use C++ exception handling.
7990 * cli/cli-interp.c: Use C++ exception handling.
7991 * cli/cli-cmds.c: Use C++ exception handling.
7992 * c-varobj.c: Use C++ exception handling.
7993 * btrace.c: Use C++ exception handling.
7994 * breakpoint.c: Use C++ exception handling.
7995 * break-catch-throw.c: Use C++ exception handling.
7996 * arch-utils.c: Use C++ exception handling.
7997 * amd64-tdep.c: Use C++ exception handling.
7998 * ada-valprint.c: Use C++ exception handling.
7999 * ada-typeprint.c: Use C++ exception handling.
8000 * ada-lang.c: Use C++ exception handling.
8001 * aarch64-tdep.c: Use C++ exception handling.
8002
3d6e9d23
TT
80032019-04-08 Tom Tromey <tom@tromey.com>
8004
8005 * xml-support.c (gdb_xml_parser::parse): Update.
8006 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8007 * value.c (show_convenience): Update.
8008 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8009 (test_parse_flags_qcs): Update.
8010 * thread.c (thr_try_catch_cmd): Update.
8011 * target.c (target_translate_tls_address): Update.
8012 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8013 (info_frame_command_core, frame_apply_command_count): Update.
8014 * rust-exp.y (rust_lex_exception_test): Update.
8015 * riscv-tdep.c (riscv_print_one_register_info): Update.
8016 * remote.c (remote_target::enable_btrace): Update.
8017 * record-btrace.c (record_btrace_enable_warn): Update.
8018 * python/py-utils.c (gdbpy_convert_exception): Update.
8019 * printcmd.c (do_one_display, print_variable_and_value): Update.
8020 * mi/mi-main.c (mi_print_exception): Update.
8021 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8022 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8023 * linux-nat.c (linux_nat_target::attach): Update.
8024 * linux-fork.c (class scoped_switch_fork_info): Update.
8025 * infrun.c (displaced_step_prepare): Update.
8026 * infcall.c (call_function_by_hand_dummy): Update.
8027 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8028 * gnu-v3-abi.c (print_one_vtable): Update.
8029 * frame.c (get_prev_frame_always): Update.
8030 * f-valprint.c (info_common_command_for_block): Update.
8031 * exec.c (try_open_exec_file): Update.
8032 * exceptions.c (print_exception, exception_print)
8033 (exception_fprintf, exception_print_same): Update.
8034 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8035 * dwarf-index-cache.c (index_cache::store)
8036 (index_cache::lookup_gdb_index): Update.
8037 * darwin-nat.c (maybe_cache_shell): Update.
8038 * cp-valprint.c (cp_print_value_fields): Update.
8039 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8040 (gcc_cplus_symbol_address): Update.
8041 * compile/compile-c-symbols.c (gcc_convert_symbol)
8042 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8043 * common/selftest.c: Update.
8044 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8045 a std::string.
8046 (exception_try_scope_entry, exception_try_scope_exit): Don't
8047 declare.
8048 (struct exception_try_scope): Remove.
8049 (TRY): Don't use exception_try_scope.
8050 (struct gdb_exception): Add constructor, operator=.
8051 <what>: New method.
8052 (struct gdb_exception_RETURN_MASK_ALL)
8053 (struct gdb_exception_RETURN_MASK_ERROR)
8054 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8055 (struct gdb_quit_bad_alloc): Update.
8056 * common/common-exceptions.c (exception_none): Change
8057 initializer.
8058 (struct catcher) <state, exception>: Initialize inline.
8059 <prev>: Remove member.
8060 (current_catcher): Remove.
8061 (catchers): New global.
8062 (exceptions_state_mc_init): Simplify.
8063 (catcher_pop): Remove.
8064 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8065 (try_scope_depth, exception_try_scope_entry)
8066 (exception_try_scope_exit): Remove.
8067 (throw_exception_sjlj): Update.
8068 (exception_messages, exception_messages_size): Remove.
8069 (throw_it): Simplify.
8070 (gdb_exception_sliced_copy): Remove.
8071 (throw_exception_cxx): Update.
8072 * cli/cli-script.c (script_from_file): Update.
8073 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8074 Update.
8075 * ada-valprint.c (ada_val_print): Update.
8076 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8077 (create_excep_cond_exprs): Update.
8078
c5c10118
TT
80792019-04-08 Tom Tromey <tom@tromey.com>
8080
8081 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8082 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8083 (TRY, CATCH, END_CATCH): Remove some definitions.
8084 * common/common-exceptions.c: Don't use GDB_XCPT.
8085 (catcher_list_size): Remove.
8086 (throw_exception, throw_it): Simplify.
8087
4de283e4
TT
80882019-04-05 Tom Tromey <tom@tromey.com>
8089
8090 Revert the header-sorting patch.
8091 * ft32-tdep.c: Revert.
8092 * frv-tdep.c: Revert.
8093 * frv-linux-tdep.c: Revert.
8094 * frame.c: Revert.
8095 * frame-unwind.c: Revert.
8096 * frame-base.c: Revert.
8097 * fork-child.c: Revert.
8098 * findvar.c: Revert.
8099 * findcmd.c: Revert.
8100 * filesystem.c: Revert.
8101 * filename-seen-cache.h: Revert.
8102 * filename-seen-cache.c: Revert.
8103 * fbsd-tdep.c: Revert.
8104 * fbsd-nat.h: Revert.
8105 * fbsd-nat.c: Revert.
8106 * f-valprint.c: Revert.
8107 * f-typeprint.c: Revert.
8108 * f-lang.c: Revert.
8109 * extension.h: Revert.
8110 * extension.c: Revert.
8111 * extension-priv.h: Revert.
8112 * expprint.c: Revert.
8113 * exec.h: Revert.
8114 * exec.c: Revert.
8115 * exceptions.c: Revert.
8116 * event-top.c: Revert.
8117 * event-loop.c: Revert.
8118 * eval.c: Revert.
8119 * elfread.c: Revert.
8120 * dwarf2read.h: Revert.
8121 * dwarf2read.c: Revert.
8122 * dwarf2loc.c: Revert.
8123 * dwarf2expr.h: Revert.
8124 * dwarf2expr.c: Revert.
8125 * dwarf2-frame.c: Revert.
8126 * dwarf2-frame-tailcall.c: Revert.
8127 * dwarf-index-write.h: Revert.
8128 * dwarf-index-write.c: Revert.
8129 * dwarf-index-common.c: Revert.
8130 * dwarf-index-cache.h: Revert.
8131 * dwarf-index-cache.c: Revert.
8132 * dummy-frame.c: Revert.
8133 * dtrace-probe.c: Revert.
8134 * disasm.h: Revert.
8135 * disasm.c: Revert.
8136 * disasm-selftests.c: Revert.
8137 * dictionary.c: Revert.
8138 * dicos-tdep.c: Revert.
8139 * demangle.c: Revert.
8140 * dcache.h: Revert.
8141 * dcache.c: Revert.
8142 * darwin-nat.h: Revert.
8143 * darwin-nat.c: Revert.
8144 * darwin-nat-info.c: Revert.
8145 * d-valprint.c: Revert.
8146 * d-namespace.c: Revert.
8147 * d-lang.c: Revert.
8148 * ctf.c: Revert.
8149 * csky-tdep.c: Revert.
8150 * csky-linux-tdep.c: Revert.
8151 * cris-tdep.c: Revert.
8152 * cris-linux-tdep.c: Revert.
8153 * cp-valprint.c: Revert.
8154 * cp-support.c: Revert.
8155 * cp-namespace.c: Revert.
8156 * cp-abi.c: Revert.
8157 * corelow.c: Revert.
8158 * corefile.c: Revert.
8159 * continuations.c: Revert.
8160 * completer.h: Revert.
8161 * completer.c: Revert.
8162 * complaints.c: Revert.
8163 * coffread.c: Revert.
8164 * coff-pe-read.c: Revert.
8165 * cli-out.h: Revert.
8166 * cli-out.c: Revert.
8167 * charset.c: Revert.
8168 * c-varobj.c: Revert.
8169 * c-valprint.c: Revert.
8170 * c-typeprint.c: Revert.
8171 * c-lang.c: Revert.
8172 * buildsym.c: Revert.
8173 * buildsym-legacy.c: Revert.
8174 * build-id.h: Revert.
8175 * build-id.c: Revert.
8176 * btrace.c: Revert.
8177 * bsd-uthread.c: Revert.
8178 * breakpoint.h: Revert.
8179 * breakpoint.c: Revert.
8180 * break-catch-throw.c: Revert.
8181 * break-catch-syscall.c: Revert.
8182 * break-catch-sig.c: Revert.
8183 * blockframe.c: Revert.
8184 * block.c: Revert.
8185 * bfin-tdep.c: Revert.
8186 * bfin-linux-tdep.c: Revert.
8187 * bfd-target.c: Revert.
8188 * bcache.c: Revert.
8189 * ax-general.c: Revert.
8190 * ax-gdb.h: Revert.
8191 * ax-gdb.c: Revert.
8192 * avr-tdep.c: Revert.
8193 * auxv.c: Revert.
8194 * auto-load.c: Revert.
8195 * arm-wince-tdep.c: Revert.
8196 * arm-tdep.c: Revert.
8197 * arm-symbian-tdep.c: Revert.
8198 * arm-pikeos-tdep.c: Revert.
8199 * arm-obsd-tdep.c: Revert.
8200 * arm-nbsd-tdep.c: Revert.
8201 * arm-nbsd-nat.c: Revert.
8202 * arm-linux-tdep.c: Revert.
8203 * arm-linux-nat.c: Revert.
8204 * arm-fbsd-tdep.c: Revert.
8205 * arm-fbsd-nat.c: Revert.
8206 * arm-bsd-tdep.c: Revert.
8207 * arch-utils.c: Revert.
8208 * arc-tdep.c: Revert.
8209 * arc-newlib-tdep.c: Revert.
8210 * annotate.h: Revert.
8211 * annotate.c: Revert.
8212 * amd64-windows-tdep.c: Revert.
8213 * amd64-windows-nat.c: Revert.
8214 * amd64-tdep.c: Revert.
8215 * amd64-sol2-tdep.c: Revert.
8216 * amd64-obsd-tdep.c: Revert.
8217 * amd64-obsd-nat.c: Revert.
8218 * amd64-nbsd-tdep.c: Revert.
8219 * amd64-nbsd-nat.c: Revert.
8220 * amd64-nat.c: Revert.
8221 * amd64-linux-tdep.c: Revert.
8222 * amd64-linux-nat.c: Revert.
8223 * amd64-fbsd-tdep.c: Revert.
8224 * amd64-fbsd-nat.c: Revert.
8225 * amd64-dicos-tdep.c: Revert.
8226 * amd64-darwin-tdep.c: Revert.
8227 * amd64-bsd-nat.c: Revert.
8228 * alpha-tdep.c: Revert.
8229 * alpha-obsd-tdep.c: Revert.
8230 * alpha-nbsd-tdep.c: Revert.
8231 * alpha-mdebug-tdep.c: Revert.
8232 * alpha-linux-tdep.c: Revert.
8233 * alpha-linux-nat.c: Revert.
8234 * alpha-bsd-tdep.c: Revert.
8235 * alpha-bsd-nat.c: Revert.
8236 * aix-thread.c: Revert.
8237 * agent.c: Revert.
8238 * addrmap.c: Revert.
8239 * ada-varobj.c: Revert.
8240 * ada-valprint.c: Revert.
8241 * ada-typeprint.c: Revert.
8242 * ada-tasks.c: Revert.
8243 * ada-lang.c: Revert.
8244 * aarch64-tdep.c: Revert.
8245 * aarch64-ravenscar-thread.c: Revert.
8246 * aarch64-newlib-tdep.c: Revert.
8247 * aarch64-linux-tdep.c: Revert.
8248 * aarch64-linux-nat.c: Revert.
8249 * aarch64-fbsd-tdep.c: Revert.
8250 * aarch64-fbsd-nat.c: Revert.
8251 * aarch32-linux-nat.c: Revert.
8252
d55e5aa6
TT
82532019-04-05 Tom Tromey <tom@tromey.com>
8254
8255 * ft32-tdep.c: Sort headers.
8256 * frv-tdep.c: Sort headers.
8257 * frv-linux-tdep.c: Sort headers.
8258 * frame.c: Sort headers.
8259 * frame-unwind.c: Sort headers.
8260 * frame-base.c: Sort headers.
8261 * fork-child.c: Sort headers.
8262 * findvar.c: Sort headers.
8263 * findcmd.c: Sort headers.
8264 * filesystem.c: Sort headers.
8265 * filename-seen-cache.h: Sort headers.
8266 * filename-seen-cache.c: Sort headers.
8267 * fbsd-tdep.c: Sort headers.
8268 * fbsd-nat.h: Sort headers.
8269 * fbsd-nat.c: Sort headers.
8270 * f-valprint.c: Sort headers.
8271 * f-typeprint.c: Sort headers.
8272 * f-lang.c: Sort headers.
8273 * extension.h: Sort headers.
8274 * extension.c: Sort headers.
8275 * extension-priv.h: Sort headers.
8276 * expprint.c: Sort headers.
8277 * exec.h: Sort headers.
8278 * exec.c: Sort headers.
8279 * exceptions.c: Sort headers.
8280 * event-top.c: Sort headers.
8281 * event-loop.c: Sort headers.
8282 * eval.c: Sort headers.
8283 * elfread.c: Sort headers.
8284 * dwarf2read.h: Sort headers.
8285 * dwarf2read.c: Sort headers.
8286 * dwarf2loc.c: Sort headers.
8287 * dwarf2expr.h: Sort headers.
8288 * dwarf2expr.c: Sort headers.
8289 * dwarf2-frame.c: Sort headers.
8290 * dwarf2-frame-tailcall.c: Sort headers.
8291 * dwarf-index-write.h: Sort headers.
8292 * dwarf-index-write.c: Sort headers.
8293 * dwarf-index-common.c: Sort headers.
8294 * dwarf-index-cache.h: Sort headers.
8295 * dwarf-index-cache.c: Sort headers.
8296 * dummy-frame.c: Sort headers.
8297 * dtrace-probe.c: Sort headers.
8298 * disasm.h: Sort headers.
8299 * disasm.c: Sort headers.
8300 * disasm-selftests.c: Sort headers.
8301 * dictionary.c: Sort headers.
8302 * dicos-tdep.c: Sort headers.
8303 * demangle.c: Sort headers.
8304 * dcache.h: Sort headers.
8305 * dcache.c: Sort headers.
8306 * darwin-nat.h: Sort headers.
8307 * darwin-nat.c: Sort headers.
8308 * darwin-nat-info.c: Sort headers.
8309 * d-valprint.c: Sort headers.
8310 * d-namespace.c: Sort headers.
8311 * d-lang.c: Sort headers.
8312 * ctf.c: Sort headers.
8313 * csky-tdep.c: Sort headers.
8314 * csky-linux-tdep.c: Sort headers.
8315 * cris-tdep.c: Sort headers.
8316 * cris-linux-tdep.c: Sort headers.
8317 * cp-valprint.c: Sort headers.
8318 * cp-support.c: Sort headers.
8319 * cp-namespace.c: Sort headers.
8320 * cp-abi.c: Sort headers.
8321 * corelow.c: Sort headers.
8322 * corefile.c: Sort headers.
8323 * continuations.c: Sort headers.
8324 * completer.h: Sort headers.
8325 * completer.c: Sort headers.
8326 * complaints.c: Sort headers.
8327 * coffread.c: Sort headers.
8328 * coff-pe-read.c: Sort headers.
8329 * cli-out.h: Sort headers.
8330 * cli-out.c: Sort headers.
8331 * charset.c: Sort headers.
8332 * c-varobj.c: Sort headers.
8333 * c-valprint.c: Sort headers.
8334 * c-typeprint.c: Sort headers.
8335 * c-lang.c: Sort headers.
8336 * buildsym.c: Sort headers.
8337 * buildsym-legacy.c: Sort headers.
8338 * build-id.h: Sort headers.
8339 * build-id.c: Sort headers.
8340 * btrace.c: Sort headers.
8341 * bsd-uthread.c: Sort headers.
8342 * breakpoint.h: Sort headers.
8343 * breakpoint.c: Sort headers.
8344 * break-catch-throw.c: Sort headers.
8345 * break-catch-syscall.c: Sort headers.
8346 * break-catch-sig.c: Sort headers.
8347 * blockframe.c: Sort headers.
8348 * block.c: Sort headers.
8349 * bfin-tdep.c: Sort headers.
8350 * bfin-linux-tdep.c: Sort headers.
8351 * bfd-target.c: Sort headers.
8352 * bcache.c: Sort headers.
8353 * ax-general.c: Sort headers.
8354 * ax-gdb.h: Sort headers.
8355 * ax-gdb.c: Sort headers.
8356 * avr-tdep.c: Sort headers.
8357 * auxv.c: Sort headers.
8358 * auto-load.c: Sort headers.
8359 * arm-wince-tdep.c: Sort headers.
8360 * arm-tdep.c: Sort headers.
8361 * arm-symbian-tdep.c: Sort headers.
8362 * arm-pikeos-tdep.c: Sort headers.
8363 * arm-obsd-tdep.c: Sort headers.
8364 * arm-nbsd-tdep.c: Sort headers.
8365 * arm-nbsd-nat.c: Sort headers.
8366 * arm-linux-tdep.c: Sort headers.
8367 * arm-linux-nat.c: Sort headers.
8368 * arm-fbsd-tdep.c: Sort headers.
8369 * arm-fbsd-nat.c: Sort headers.
8370 * arm-bsd-tdep.c: Sort headers.
8371 * arch-utils.c: Sort headers.
8372 * arc-tdep.c: Sort headers.
8373 * arc-newlib-tdep.c: Sort headers.
8374 * annotate.h: Sort headers.
8375 * annotate.c: Sort headers.
8376 * amd64-windows-tdep.c: Sort headers.
8377 * amd64-windows-nat.c: Sort headers.
8378 * amd64-tdep.c: Sort headers.
8379 * amd64-sol2-tdep.c: Sort headers.
8380 * amd64-obsd-tdep.c: Sort headers.
8381 * amd64-obsd-nat.c: Sort headers.
8382 * amd64-nbsd-tdep.c: Sort headers.
8383 * amd64-nbsd-nat.c: Sort headers.
8384 * amd64-nat.c: Sort headers.
8385 * amd64-linux-tdep.c: Sort headers.
8386 * amd64-linux-nat.c: Sort headers.
8387 * amd64-fbsd-tdep.c: Sort headers.
8388 * amd64-fbsd-nat.c: Sort headers.
8389 * amd64-dicos-tdep.c: Sort headers.
8390 * amd64-darwin-tdep.c: Sort headers.
8391 * amd64-bsd-nat.c: Sort headers.
8392 * alpha-tdep.c: Sort headers.
8393 * alpha-obsd-tdep.c: Sort headers.
8394 * alpha-nbsd-tdep.c: Sort headers.
8395 * alpha-mdebug-tdep.c: Sort headers.
8396 * alpha-linux-tdep.c: Sort headers.
8397 * alpha-linux-nat.c: Sort headers.
8398 * alpha-bsd-tdep.c: Sort headers.
8399 * alpha-bsd-nat.c: Sort headers.
8400 * aix-thread.c: Sort headers.
8401 * agent.c: Sort headers.
8402 * addrmap.c: Sort headers.
8403 * ada-varobj.c: Sort headers.
8404 * ada-valprint.c: Sort headers.
8405 * ada-typeprint.c: Sort headers.
8406 * ada-tasks.c: Sort headers.
8407 * ada-lang.c: Sort headers.
8408 * aarch64-tdep.c: Sort headers.
8409 * aarch64-ravenscar-thread.c: Sort headers.
8410 * aarch64-newlib-tdep.c: Sort headers.
8411 * aarch64-linux-tdep.c: Sort headers.
8412 * aarch64-linux-nat.c: Sort headers.
8413 * aarch64-fbsd-tdep.c: Sort headers.
8414 * aarch64-fbsd-nat.c: Sort headers.
8415 * aarch32-linux-nat.c: Sort headers.
8416
699bd4cf
TT
84172019-04-04 Tom Tromey <tom@tromey.com>
8418
8419 * varobj.c (varobj_create): Update.
8420 * rust-exp.y (struct rust_parser) <update_innermost_block,
8421 lookup_symbol>: New methods.
8422 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8423 Rename.
8424 (rust_parser::rust_lookup_type)
8425 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8426 * printcmd.c (display_command, do_one_display): Update.
8427 * parser-defs.h (struct parser_state) <parser_state>: Add
8428 "tracker" parameter.
8429 (block_tracker): New member.
8430 (class innermost_block_tracker) <innermost_block_tracker>: Add
8431 "types" parameter.
8432 <reset>: Remove method.
8433 (innermost_block): Don't declare.
8434 (null_post_parser): Update.
8435 * parse.c (innermost_block): Remove global.
8436 (write_dollar_variable): Update.
8437 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8438 Remove "tracker_types" parameter.
8439 (parse_expression): Add "tracker" parameter.
8440 (parse_expression_for_completion): Update.
8441 (null_post_parser): Add "tracker" parameter.
8442 * p-exp.y: Update rules.
8443 * m2-exp.y: Update rules.
8444 * language.h (struct language_defn) <la_post_parser>: Add
8445 "tracker" parameter.
8446 * go-exp.y: Update rules.
8447 * f-exp.y: Update rules.
8448 * expression.h (parse_expression, parse_exp_1): Add "tracker"
8449 parameter.
8450 * d-exp.y: Update rules.
8451 * c-exp.y: Update rules.
8452 * breakpoint.c (set_breakpoint_condition): Create an
8453 innermost_block_tracker.
8454 (watch_command_1): Likewise.
8455 * ada-lang.c (resolve): Add "tracker" parameter.
8456 (resolve_subexp): Likewise.
8457 * ada-exp.y (write_var_from_sym): Update.
8458
dac43e32
TT
84592019-04-04 Tom Tromey <tom@tromey.com>
8460
8461 * type-stack.h: New file.
8462 * type-stack.c: New file.
8463 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8464 type-stack.h.
8465 (insert_into_type_stack, insert_type, push_type, push_type_int)
8466 (insert_type_address_space, pop_type, pop_type_int)
8467 (pop_typelist, pop_type_stack, append_type_stack)
8468 (push_type_stack, get_type_stack, push_typelist)
8469 (follow_type_instance_flags, follow_types): Don't declare.
8470 * parse.c (type_stack): Remove global.
8471 (parse_exp_in_context): Update.
8472 (insert_into_type_stack, insert_type, push_type, push_type_int)
8473 (insert_type_address_space, pop_type, pop_type_int)
8474 (pop_typelist, pop_type_stack, append_type_stack)
8475 (push_type_stack, get_type_stack, push_typelist)
8476 (follow_type_instance_flags, follow_types): Remove (moved to
8477 type-stack.c).
8478 * f-exp.y (type_stack): New global.
8479 Update rules.
8480 (push_kind_type, f_parse): Update.
8481 * d-exp.y (type_stack): New global.
8482 Update rules.
8483 (d_parse): Update.
8484 * c-exp.y (struct c_parse_state) <type_stack>: New member.
8485 Update rules.
8486 * Makefile.in (COMMON_SFILES): Add type-stack.c.
8487 (HFILES_NO_SRCDIR): Add type-stack.h.
8488
2a612529
TT
84892019-04-04 Tom Tromey <tom@tromey.com>
8490
8491 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8492 (rust_parser::convert_ast_to_expression, rust_parse)
8493 (rust_lex_test_completion, rust_lex_tests): Update.
8494 * parser-defs.h (struct expr_completion_state): New.
8495 (struct parser_state) <parser_state>: Add completion parameter.
8496 <mark_struct_expression, mark_completion_tag>: New methods.
8497 <parse_completion, m_completion_state>: New members.
8498 (prefixify_expression, null_post_parser): Update.
8499 (mark_struct_expression, mark_completion_tag): Don't declare.
8500 * parse.c (parse_completion, expout_last_struct)
8501 (expout_tag_completion_type, expout_completion_name): Remove
8502 globals.
8503 (parser_state::mark_struct_expression)
8504 (parser_state::mark_completion_tag): Now methods.
8505 (prefixify_expression): Add last_struct parameter.
8506 (prefixify_subexp): Likewise.
8507 (parse_exp_1): Update.
8508 (parse_exp_in_context): Add cstate parameter. Update.
8509 (parse_expression_for_completion): Create an
8510 expr_completion_state.
8511 (null_post_parser): Add "completion" parameter.
8512 * p-exp.y: Update rules.
8513 (yylex): Update.
8514 * language.h (struct language_defn) <la_post_parser>: Add
8515 "completing" parameter.
8516 * go-exp.y: Update rules.
8517 (lex_one_token): Update.
8518 * expression.h (parse_completion): Don't declare.
8519 * d-exp.y: Update rules.
8520 (lex_one_token): Update rules.
8521 * c-exp.y: Update rules.
8522 (lex_one_token): Update.
8523 * ada-lang.c (resolve): Add "parse_completion" parameter.
8524 (resolve_subexp): Likewise.
8525 (ada_resolve_function): Likewise.
8526
43476f0b
TT
85272019-04-04 Tom Tromey <tom@tromey.com>
8528
8529 * parser-defs.h (struct parser_state) <start_arglist,
8530 end_arglist>: New methods.
8531 <arglist_len, m_funcall_chain>: New members.
8532 (arglist_len, start_arglist, end_arglist): Don't declare.
8533 * parse.c (arglist_len, funcall_chain): Remove global.
8534 (start_arglist, end_arglist): Remove functions.
8535 (parse_exp_in_context): Update.
8536 * p-exp.y: Update rules.
8537 * m2-exp.y: Update rules.
8538 * go-exp.y: Update rules.
8539 * f-exp.y: Update rules.
8540 * d-exp.y: Update rules.
8541 * c-exp.y: Update rules.
8542
5776fca3
TT
85432019-04-04 Tom Tromey <tom@tromey.com>
8544
8545 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8546 lex_operator, push_back>: New methods.
8547 Update all rules.
8548 (rust_parser::lex_hex, lex_escape): Rename and update.
8549 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8550 (rust_parser::lex_operator): Rename and update.
8551 (rust_parser::lex_number, rustyylex, rustyyerror)
8552 (rust_lex_test_init, rust_lex_test_sequence)
8553 (rust_lex_test_push_back, rust_lex_tests): Update.
8554 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8555 parameter.
8556 <lexptr, prev_lexptr>: New members.
8557 (lexptr, prev_lexptr): Don't declare.
8558 * parse.c (lexptr, prev_lexptr): Remove globals.
8559 (parse_exp_in_context): Update.
8560 * p-exp.y (yylex, yyerror): Update.
8561 * m2-exp.y (parse_number, yylex, yyerror): Update.
8562 * go-exp.y (lex_one_token, yyerror): Update.
8563 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8564 * d-exp.y (lex_one_token, yyerror): Update.
8565 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8566 (lex_one_token, yyerror): Update.
8567 * ada-lex.l (YY_INPUT): Update.
8568 (rewind_to_char): Update.
8569 * ada-exp.y (yyerror): Update.
8570
8621b685
TT
85712019-04-04 Tom Tromey <tom@tromey.com>
8572
8573 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8574 * parser-defs.h (struct parser_state) <parser_state>: Add new
8575 parameter.
8576 <comma_terminates>: New member.
8577 (comma_terminates): Don't declare global.
8578 * parse.c (comma_terminates): Remove global.
8579 (parse_exp_in_context): Update.
8580 * p-exp.y (yylex): Update.
8581 * m2-exp.y (yylex): Update.
8582 * go-exp.y (lex_one_token): Update.
8583 * f-exp.y (yylex): Update.
8584 * d-exp.y (lex_one_token): Update.
8585 * c-exp.y (lex_one_token): Update.
8586 * ada-lex.l: Update.
8587
28aaf3fd
TT
85882019-04-04 Tom Tromey <tom@tromey.com>
8589
8590 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8591 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8592 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8593 * parser-defs.h (paren_depth): Don't declare.
8594 * parse.c (paren_depth): Remove global.
8595 (parse_exp_in_context): Update.
8596 * p-exp.y (paren_depth): New global.
8597 (pascal_parse): Initialize it.
8598 * m2-exp.y (paren_depth): New global.
8599 (m2_parse): Initialize it.
8600 * go-exp.y (paren_depth): New global.
8601 (go_parse): Initialize it.
8602 * f-exp.y (paren_depth): New global.
8603 (f_parse): Initialize it.
8604 * d-exp.y (paren_depth): New global.
8605 (d_parse): Initialize it.
8606 * c-exp.y (paren_depth): New global.
8607 (c_parse): Initialize it.
8608 * ada-lex.l (paren_depth): New global.
8609 (lexer_init): Initialize it.
8610
1e58a4a4
TT
86112019-04-04 Tom Tromey <tom@tromey.com>
8612
8613 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8614 (rust_parser::convert_ast_to_type)
8615 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8616 * parser-defs.h (struct parser_state) <parser_state>: Add
8617 parameters. Initialize new members.
8618 <expression_context_block, expression_context_pc>: New members.
8619 * parse.c (expression_context_block, expression_context_pc):
8620 Remove globals.
8621 (parse_exp_in_context): Update.
8622 * p-exp.y: Update all rules.
8623 (yylex): Update.
8624 * m2-exp.y: Update all rules.
8625 (yylex): Update.
8626 * go-exp.y (yylex): Update.
8627 * f-exp.y (yylex): Update.
8628 * d-exp.y: Update all rules.
8629 (yylex): Update.
8630 * c-exp.y: Update all rules.
8631 (lex_one_token, classify_name, yylex, c_parse): Update.
8632 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8633
37eedb39
TT
86342019-04-04 Tom Tromey <tom@tromey.com>
8635
8636 * gdbarch.h, gdbarch.c: Rebuild.
8637 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8638 * stap-probe.h:
8639 (struct stap_parse_info): Replace "parser_state" with
8640 "expr_builder".
8641 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8642 (parser_state): New class.
8643 * parse.c (expr_builder): Rename.
8644 (expr_builder::release): Rename.
8645 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8646 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8647 (write_exp_elt_longcst, write_exp_elt_floatcst)
8648 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8649 (write_exp_string_vector, write_exp_bitstring)
8650 (write_exp_msymbol, mark_struct_expression)
8651 (write_dollar_variable)
8652 (insert_type_address_space, increase_expout_size): Replace
8653 "parser_state" with "expr_builder".
8654 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8655 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8656 "parser_state" with "expr_builder".
8657
73923d7e
TT
86582019-04-04 Tom Tromey <tom@tromey.com>
8659
8660 * rust-exp.y: Replace "parse_language" with method call.
8661 * p-exp.y:
8662 (yylex): Replace "parse_language" with method call.
8663 * m2-exp.y:
8664 (yylex): Replace "parse_language" with method call.
8665 * go-exp.y (classify_name): Replace "parse_language" with method
8666 call.
8667 * f-exp.y (yylex): Replace "parse_language" with method call.
8668 * d-exp.y (lex_one_token): Replace "parse_language" with method
8669 call.
8670 * c-exp.y:
8671 (lex_one_token, classify_name, yylex): Replace "parse_language"
8672 with method call.
8673 * ada-exp.y (find_primitive_type, type_char)
8674 (type_system_address): Replace "parse_language" with method call.
8675
fa9f5be6
TT
86762019-04-04 Tom Tromey <tom@tromey.com>
8677
8678 * rust-exp.y: Replace "parse_gdbarch" with method call.
8679 * parse.c (write_dollar_variable, insert_type_address_space):
8680 Replace "parse_gdbarch" with method call.
8681 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8682 call.
8683 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8684 call.
8685 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8686 "parse_gdbarch" with method call.
8687 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8688 with method call.
8689 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8690 "parse_gdbarch" with method call.
8691 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8692 "parse_gdbarch" with method call.
8693 * c-exp.y (parse_type, parse_number, classify_name): Replace
8694 "parse_gdbarch" with method call.
8695 * ada-lex.l: Replace "parse_gdbarch" with method call.
8696 * ada-exp.y (parse_type, find_primitive_type, type_char)
8697 (type_system_address): Replace "parse_gdbarch" with method call.
8698
1201a264
TT
86992019-04-04 Tom Tromey <tom@tromey.com>
8700
8701 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8702 * stap-probe.c (stap_parse_argument): Update.
8703 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8704 initial_size parameter.
8705 * rust-exp.y (rust_lex_tests): Update.
8706 * parse.c (parser_state): Update.
8707 (parse_exp_in_context): Update.
8708 * parser-defs.h (struct parser_state) <parser_state>: Remove
8709 "initial_size" parameter.
8710
e3980ce2
TT
87112019-04-04 Tom Tromey <tom@tromey.com>
8712
8713 * parser-defs.h (increase_expout_size): Don't declare.
8714 * parse.c (increase_expout_size): Now static.
8715
e9f8e3f1
TS
87162019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8717
8718 * gnu-nat.c (gnu_nat_target::wait): Fix
8719 target_waitstatus_to_string call.
8720
d7df6549
AB
87212019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8722
8723 * eval.c (evaluate_subexp_standard): Handle internal functions
8724 during Fortran function call handling.
8725
8bdc1658
AB
87262019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8727
8728 * NEWS: Mention new internal functions.
8729 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8730 (read_base_type): Use dwarf2_init_complex_target_type.
8731 * value.c (creal_internal_fn): New function.
8732 (cimag_internal_fn): New function.
8733 (_initialize_values): Register new internal functions.
8734
c29705b7
PW
87352019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8736
8737 * infrun.c (stop_all_threads): If debug_infrun, always
8738 trace the wait status after wait_one, using
8739 target_waitstatus_to_string and target_pid_to_str.
8740 (handle_inferior_event): Replace various trace of
8741 wait status kind by a single trace.
8742 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8743 wait status kind image by target_waitstatus_to_string.
8744 * target/waitstatus.c (target_waitstatus_to_string): Fix
8745 obsolete comment.
8746
05caa1d2
TT
87472019-04-01 Tom Tromey <tromey@adacore.com>
8748
8749 PR symtab/23331:
8750 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8751
9d1447e0
SDJ
87522019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8753 Pedro Alves <palves@redhat.com>
8754
8755 * top.c (quit_force): Call 'finalize_values'.
8756 * value.c (finalize_values): New function.
8757 * value.h (finalize_values): Declare.
8758
7734102d
EZ
87592019-03-30 Eli Zaretskii <eliz@gnu.org>
8760
8761 * NEWS: Announce $_gdb_major and $_gdb_minor.
8762
8763 * top.c (init_gdb_version_vars): New function.
8764 (gdb_init): Call init_gdb_version_vars.
8765
188e1fa9
TT
87662019-03-29 Tom Tromey <tromey@adacore.com>
8767
8768 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8769 help text. Remove dead code.
8770
2880242d
KS
87712019-03-29 Keith Seitz <keiths@redhat.com>
8772
8773 From Siddhesh Poyarekar:
8774 * f-lang.h (f77_get_upperbound): Return LONGEST.
8775 (f77_get_lowerbound): Likewise.
8776 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8777 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8778 print them.
8779 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8780 plongest to format print it.
8781 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8782 (f77_get_upperbound): Likewise.
8783 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8784 LOWER_BOUND to LONGEST.
8785 (f77_create_arrayprint_offset_tbl): Likewise.
8786
cc1defb1
KS
87872019-03-29 Keith Seitz <keiths@redhat.com>
8788
8789 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8790 %s/pulongest for TYPE_LENGTH instead of %d in format
8791 strings.
8792 * ada-typerint.c (ada_print_type): Likewise.
8793 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8794 * compile/compile-c-support.c (generate_register_struct): Likewise.
8795 * gdbtypes.c (recursive_dump_type): Likewise.
8796 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8797 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8798 instead of %d in format strings.
8799 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8800 to std::min to ULONGEST.
8801 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8802 instead of %d in format strings.
8803 * tracepoint.c (info_scope_command): Likewise.
8804 * typeprint.c (print_offset_data::update)
8805 (print_offset_data::finish): Likewise.
8806 * xtensa-tdep.c (xtensa_store_return_value)
8807 (xtensa_push_dummy_call): Likewise.
8808
e432ccf1
JT
88092019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8810
8811 * windows-nat.c (display_selector): Fixed format specifications
8812 for 64-bit Cygwin.
8813
65d2b333
PW
88142019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8815
8816 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8817
f489207e
SL
88182019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8819
8820 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8821 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8822 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8823 (nios2_linux_init_abi): Install it.
8824
bffa1015
AH
88252019-03-28 Alan Hayward <alan.hayward@arm.com>
8826
8827 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8828
fc96163a
AH
88292019-03-28 Alan Hayward <alan.hayward@arm.com>
8830
8831 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8832
20dc7e9b
PW
88332019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8834 Tom Tromey <tromey@adacore.com>
8835
8836 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8837
7f5331a8
JB
88382019-03-26 Joel Brobecker <brobecker@adacore.com>
8839
8840 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8841 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8842 method to compute the bounds of range types. Also print "[evaluated]"
8843 if the bounds' values come from a dynamic evaluation.
8844
18c77628
AB
88452019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8846
8847 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8848 whitespace when pretty printing is on.
8849
53c973f2
AH
88502019-03-26 Alan Hayward <alan.hayward@arm.com>
8851
e79be6e5 8852 * ppc-linux-nat.c: Add include.
53c973f2 8853
d851aa71
AH
88542019-03-26 Alan Hayward <alan.hayward@arm.com>
8855
e79be6e5 8856 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 8857
2fe7bab7
AH
88582019-03-26 Alan Hayward <alan.hayward@arm.com>
8859
e79be6e5 8860 * arm-linux-nat.c: Add include.
2fe7bab7 8861
068ef30e
SM
88622019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8863
8864 * source-cache.c (source_cache::get_source_lines): Re-read
8865 fullname after calling open_source_file.
8866
81a24d04
JB
88672019-03-25 John Baldwin <jhb@FreeBSD.org>
8868
8869 * NEWS: Mention TLS support for FreeBSD.
8870
79e7ae11
TT
88712019-03-25 Tom Tromey <tromey@adacore.com>
8872
8873 * minsyms.c (BUNCH_SIZE): Update comment.
8874 (~minimal_symbol_reader): Remove old comment.
8875 (compact_minimal_symbols): Update comment.
8876 (minimal_symbol_reader::install): Remove old comment. Update
8877 other comments.
8878
d45963c2
AH
88792019-03-25 Alan Hayward <alan.hayward@arm.com>
8880
8881 * s390-linux-nat.c: Add include.
8882
0f83012e
AH
88832019-03-25 Alan Hayward <alan.hayward@arm.com>
8884
8885 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8886 Call linux_get_hwcap.
8887 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8888 Likewise.
8889 (aarch64_linux_get_hwcap): Remove function.
8890 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8891 declaration.
8892 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8893 linux_get_hwcap.
8894 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8895 * linux-tdep.c (linux_get_hwcap): Add function.
8896 (linux_get_hwcap2): Likewise.
8897 * linux-tdep.h (linux_get_hwcap): Add declaration.
8898 (linux_get_hwcap2): Likewise.
8899 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8900 (ppc_linux_get_hwcap2): Likewise.
8901 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8902 linux_get_hwcap.
8903 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8904 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8905 (ppc_linux_nat_target::read_description): Likewise.
8906 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8907 * s390-linux-nat.c: Likewise.
8908 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8909
6640a367
TT
89102019-03-24 Tom Tromey <tom@tromey.com>
8911
8912 * ada-lang.c (standard_lookup): Simplify initialization.
8913 (ada_lookup_symbol_nonlocal): Simplify return.
8914 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8915 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8916 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8917 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8918 initialization.
8919 * solib.c (solib_global_lookup): Simplify.
8920 * symtab.c (null_block_symbol): Remove.
8921 (symbol_cache_lookup): Simplify returns.
8922 (lookup_language_this): Simplify returns.
8923 (lookup_symbol_aux): Simplify return.
8924 (lookup_local_symbol): Simplify returns.
8925 (lookup_global_symbol_from_objfile): Simplify return.
8926 (lookup_symbol_in_objfile_symtabs)
8927 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8928 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8929 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8930 * cp-namespace.c (cp_lookup_bare_symbol)
8931 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8932 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8933 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8934 (cp_lookup_symbol_via_imports): Simplify initialization.
8935 (find_symbol_in_baseclass): Likewise.
8936 * symtab.h (null_block_symbol): Remove.
8937 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8938 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8939 (d_lookup_symbol_module): Likewise.
8940 (find_symbol_in_baseclass): Simplify initialization.
8941
a930ebcd
TT
89422019-03-24 Tom Tromey <tom@tromey.com>
8943
8944 * expression.h: Don't include symtab.h.
8945 (struct block): Forward declare.
8946
582942f4
TT
89472019-03-24 Tom Tromey <tom@tromey.com>
8948
8949 * c-exp.y (typebase): Remove casts.
8950 * gdbtypes.c (lookup_unsigned_typename, )
8951 (lookup_signed_typename): Remove cast.
8952 * eval.c (parse_to_comma_and_eval): Remove cast.
8953 * parse.c (write_dollar_variable): Remove cast.
8954 * block.h (struct block) <superblock>: Now const.
8955 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8956 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8957 (map_block): Make "block" const.
8958 * symfile.h (struct quick_symbol_functions)
8959 <map_matching_symbols>: Constify block argument to "callback".
8960 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8961 const.
8962 (find_pc_sect_compunit_symtab): Make "b" const.
8963 (find_symbol_at_address): Likewise.
8964 (search_symbols): Likewise.
8965 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8966 (dw2_debug_names_lookup_symbol): Likewise.
8967 (dw2_map_matching_symbols): Update.
8968 * p-valprint.c (pascal_val_print): Remove "block".
8969 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8970 (aux_add_nonlocal_symbols): Make "block" const.
8971 (resolve_subexp): Remove cast.
8972 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8973 const.
8974 (iterate_over_file_blocks): Likewise.
8975 * f-exp.y (%union) <bval>: Remove.
8976 * coffread.c (patch_opaque_types): Make "b" const.
8977 * spu-tdep.c (spu_catch_start): Make "block" const.
8978 * c-valprint.c (print_unpacked_pointer): Remove "block".
8979 * symmisc.c (dump_symtab_1): Make "b" const.
8980 (block_depth): Make "block" const.
8981 * d-exp.y (%union) <bval>: Remove.
8982 * cp-support.h (cp_lookup_rtti_type): Update.
8983 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8984 * psymtab.c (psym_lookup_symbol): Make "block" const.
8985 (maintenance_check_psymtabs): Make "b" const.
8986 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8987 (enumerate_locals, enumerate_args): Update.
8988 * python/py-symtab.c (stpy_global_block): Make "block" const.
8989 (stpy_static_block): Likewise.
8990 * inline-frame.c (block_starting_point_at): Make "new_block"
8991 const.
8992 * block.c (find_block_in_blockvector): Make return type const.
8993 (blockvector_for_pc_sect): Make "b" const.
8994 (find_block_in_blockvector): Make "b" const.
8995
7ad417dd
TT
89962019-03-23 Tom Tromey <tom@tromey.com>
8997
8998 * varobj.c (varobj_create): Update.
8999 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9000 * printcmd.c (display_command, do_one_display): Don't reset
9001 innermost_block.
9002 * parser-defs.h (enum innermost_block_tracker_type): Move to
9003 expression.h.
9004 (innermost_block): Update comment.
9005 * parse.c (parse_exp_1): Add tracker_types parameter.
9006 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9007 tracker_types parameter. Reset innermost_block.
9008 (parse_exp_in_context): Remove.
9009 (parse_expression_for_completion): Update.
9010 * objfiles.c (~objfile): Don't reset expression_context_block or
9011 innermost_block.
9012 * expression.h (enum innermost_block_tracker_type): Move from
9013 parser-defs.h.
9014 (parse_exp_1): Add tracker_types parameter.
9015 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9016 reset innermost_block.
9017
b366c208
TT
90182019-03-23 Tom Tromey <tom@tromey.com>
9019
9020 * objfiles.h: Include bcache.h.
9021
9bb9b2f9
TT
90222019-03-23 Tom Tromey <tom@tromey.com>
9023
9024 * linespec.c (get_current_search_block): Use
9025 scoped_restore_current_language.
9026 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9027
59c28372
AH
90282019-03-22 Alan Hayward <alan.hayward@arm.com>
9029 Jiong Wang <jiong.wang@arm.com>
9030
9031 * aarch64-linux-tdep.c
9032 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9033 section.
9034 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9035
17e116a7
AH
90362019-03-22 Alan Hayward <alan.hayward@arm.com>
9037 Jiong Wang <jiong.wang@arm.com>
9038
9039 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9040 instructions.
9041 (aarch64_analyze_prologue_test): Add PACIASP test.
9042 (aarch64_prologue_prev_register): Unmask PC value.
9043
11e1b75f
AH
90442019-03-22 Alan Hayward <alan.hayward@arm.com>
9045 Jiong Wang <jiong.wang@arm.com>
9046
9047 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9048 (aarch64_dwarf2_prev_register): Unmask PC value.
9049 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9050 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9051 DW_CFA_AARCH64_negate_ra_state.
9052 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9053
34dcc7cf
AH
90542019-03-22 Alan Hayward <alan.hayward@arm.com>
9055 Jiong Wang <jiong.wang@arm.com>
9056
9057 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9058 registers.
9059 (aarch64_pseudo_register_name): Likewise.
9060 (aarch64_pseudo_register_type): Likewise.
9061 (aarch64_pseudo_register_reggroup_p): Likewise.
9062 (aarch64_gdbarch_init): Add pauth registers.
9063 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9064 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9065 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9066 (struct gdbarch_tdep): Add regnum for ra_state.
9067
1ef53e6b
AH
90682019-03-22 Alan Hayward <alan.hayward@arm.com>
9069 Jiong Wang <jiong.wang@arm.com>
9070
9071 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9072
76bed0fd
AH
90732019-03-22 Alan Hayward <alan.hayward@arm.com>
9074 Jiong Wang <jiong.wang@arm.com>
9075
9076 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9077 function.
9078 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9079 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9080 (aarch64_gdbarch_init): Add puth registers.
9081 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9082 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9083 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9084
ee4fbcfa
AH
90852019-03-22 Alan Hayward <alan.hayward@arm.com>
9086 Jiong Wang <jiong.wang@arm.com>
9087
9088 * aarch64-linux-nat.c
9089 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9090 * aarch64-linux-tdep.c
9091 (aarch64_linux_core_read_description): Likewise.
9092 (aarch64_linux_get_hwcap): New function.
9093 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9094 (aarch64_linux_get_hwcap): New declaration.
9095
6dc0ebde
AH
90962019-03-22 Alan Hayward <alan.hayward@arm.com>
9097 Jiong Wang <jiong.wang@arm.com>
9098
9099 * aarch64-linux-nat.c
9100 (aarch64_linux_nat_target::read_description): Add pauth param.
9101 * aarch64-linux-tdep.c
9102 (aarch64_linux_core_read_description): Likewise.
9103 * aarch64-tdep.c (struct target_desc): Add in pauth.
9104 (aarch64_read_description): Add pauth param.
9105 (aarch64_gdbarch_init): Likewise.
9106 * aarch64-tdep.h (aarch64_read_description): Likewise.
9107 * arch/aarch64.c (aarch64_create_target_description): Likewise.
9108 * arch/aarch64.h (aarch64_create_target_description): Likewise.
9109 * features/Makefile: Add new files.
9110 * features/aarch64-pauth.c: New file.
9111 * features/aarch64-pauth.xml: New file.
9112
595915c1
TT
91132019-03-20 Tom Tromey <tromey@adacore.com>
9114
9115 * infrun.c (handle_inferior_event): Rename from
9116 handle_inferior_event_1. Create a scoped_value_mark.
9117 (handle_inferior_event): Remove.
9118
4c7d57e7
TT
91192019-03-19 Tom Tromey <tromey@adacore.com>
9120
9121 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9122 * infrun.h (print_stop_event): Add "displays" parameter.
9123 * infrun.c (print_stop_event): Add "displays" parameter.
9124
cb246234
PA
91252019-03-19 Pedro Alves <palves@redhat.com>
9126
9127 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9128 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
9129 to -1. Fix TABs vs spaces.
9130 (tui_ui_out::tui_ui_out): Don't initialize fields here.
9131 * tui/tui-out.h (tui_ui_out) Add intro comments.
9132 <m_line, m_start_of_line>: In-class initialize, and add describing
9133 comment.
9134
3a0e45b2
AH
91352019-03-18 Alan Hayward <alan.hayward@arm.com>
9136
9137 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9138 variable names.
9139 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9140
5371b850
PA
91412019-03-18 Pedro Alves <palves@redhat.com>
9142 Eli Zaretskii <eliz@gnu.org>
9143
9144 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9145 m_line and m_start_of_line.
9146
b17c4cd0
EZ
91472019-03-18 Eli Zaretskii <eliz@gnu.org>
9148
9149 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9150 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9151 it returns a newline. This fixes a regression in TU mode, whereby
9152 the next line is output on the same screen line as the user input.
9153
4bd56d18
TT
91542019-03-18 Tom Tromey <tromey@adacore.com>
9155
9156 * minsyms.c (minimal_symbol_reader::install): Remove call to
9157 obstack_blank.
9158
55c10aca
PA
91592019-03-18 Pedro Alves <palves@redhat.com>
9160
9161 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9162 New globals.
9163 (apply_style): New, factored out from ...
9164 (apply_ansi_escape): ... this. Handle reverse video mode.
9165 (tui_set_reverse_mode): New function.
9166 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9167 * tui/tui-winsource.c (tui_show_source_line): Use
9168 tui_set_reverse_mode instead of setting A_STANDOUT.
9169 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9170 New setter methods.
9171
647bb750
HD
91722019-03-18 Hannes Domani <ssbssa@yahoo.de>
9173
9174 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9175 Handle tabs.
9176
bff8c71f
TT
91772019-03-18 Tom Tromey <tromey@adacore.com>
9178
9179 * ada-lang.c (empty_array): Add "high" parameter.
9180 (ada_evaluate_subexp): Update.
9181
58785d98
ST
91822019-03-17 Sergei Trofimovich <siarheit@google.com>
9183
9184 * unittests/string_view-selftests.c: Define
9185 _initialize_string_view_selftests unconditionally.
9186
d4cbef22
ВМ
91872019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9188
9189 PR gdb/24350
9190 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9191
fce4c071
ВМ
91922019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9193
9194 PR gdb/24351
9195 * windows-nat.c (display_selector): Fix format specifiers.
9196
f7f0a123
EZ
91972019-03-17 Eli Zaretskii <eliz@gnu.org>
9198
9199 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9200 tui_refill_source_window instead of tui_refresh_win, to update the
9201 current execution line. This fixes redisplay of the current line
9202 when stepping through the code with "next" or "step".
9203
ab42892f
EZ
92042019-03-16 Eli Zaretskii <eliz@gnu.org>
9205
9206 * source-cache.c (source_cache::get_source_lines): Call
9207 find_source_lines to initialize s->nlines. This fixes vertical
9208 scrolling of TUI source window when the DOWN arrow is pressed.
9209
8d8c087f
PW
92102019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9211
9212 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9213 linux-thread-db.c (_initialize_thread_db): Likewise.
9214
798e1c30
EZ
92152019-03-16 Eli Zaretskii <eliz@gnu.org>
9216
9217 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9218 wclrtoeol in tui_show_source_line". This reverts changes made in
9219 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9220
eefba3da
TT
92212019-03-15 Tom Tromey <tom@tromey.com>
9222
9223 * symtab.h (struct minimal_symbol): Derive from
9224 general_symbol_info.
9225 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9226 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9227 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9228 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9229 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9230 (MSYMBOL_SEARCH_NAME): Update.
9231 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9232 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9233 * minsyms.c (minimal_symbol_reader::record_full): Update.
9234
0de2420c
TT
92352019-03-15 Tom Tromey <tom@tromey.com>
9236
9237 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9238
042d75e4
TT
92392019-03-15 Tom Tromey <tom@tromey.com>
9240
9241 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9242 unique_xmalloc_ptr.
9243 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9244 Update.
9245 * minsyms.c (lookup_minimal_symbol_by_pc_section)
9246 (build_minimal_symbol_hash_tables)
9247 (minimal_symbol_reader::install): Update.
9248
db92718b
TT
92492019-03-15 Tom Tromey <tom@tromey.com>
9250
9251 * symtab.c (create_demangled_names_hash): Update.
9252 (symbol_set_names): Update.
9253 * objfiles.h (struct objfile_per_bfd_storage)
9254 <demangled_names_hash>: Now an htab_up.
9255 * objfiles.c (objfile_per_bfd_storage): Simplify.
9256
d6797f46
TT
92572019-03-15 Tom Tromey <tom@tromey.com>
9258
9259 * objfiles.h (struct objfile_per_bfd_storage): Declare
9260 destructor.
9261 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9262 New.
9263 (get_objfile_bfd_data): Use new. Don't initialize
9264 language_of_main.
9265 (free_objfile_per_bfd_storage): Remove.
9266 (objfile_bfd_data_free, objfile::~objfile): Use delete.
9267
741d7538
TT
92682019-03-15 Tom Tromey <tom@tromey.com>
9269
9270 * symfile.c (reread_symbols): Update.
9271 * objfiles.c (objfile::objfile): Update.
9272 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9273 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9274 comment.
9275 (minimal_symbol_reader::install): Update.
9276 (terminate_minimal_symbol_table): Remove.
9277 * jit.c (jit_object_close_impl): Update.
9278
788c80d1
TT
92792019-03-15 Tom Tromey <tom@tromey.com>
9280
9281 * minsyms.c (minimal_symbol_reader::record_full): Remove some
9282 initializations.
9283
1b7a07cb
TT
92842019-03-15 Tom Tromey <tom@tromey.com>
9285
9286 * objfiles.h (struct objfile_per_bfd_storage)
9287 <demangled_hash_languages>: Now a bitset.
9288 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9289 (lookup_minimal_symbol): Update.
9290
3db066bc
TT
92912019-03-15 Tom Tromey <tom@tromey.com>
9292
9293 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9294 Don't return the symbol.
9295 * coffread.c (record_minimal_symbol): Use record_full.
9296
3fff2c37
EZ
92972019-03-14 Eli Zaretskii <eliz@gnu.org>
9298
9299 The MS-Windows port of ncurses fails to switch to a color pair if
9300 one or both of the colors are the implicit default colors. This
9301 change records the default colors when TUI is initialized, and
9302 then specifies them explicitly when a color pair uses the default
9303 colors. This allows color styling in TUI mode on MS-Windows.
9304
9305 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
9306 ncurses_norm_attr.
9307 (tui_initialize_io) [__MINGW32__]: Record the default terminal
9308 colors in ncurses_norm_attr.
9309 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9310 "none", replace it with the default color recorded in
9311 ncurses_norm_attr.
9312
3b336828
TT
93132019-03-14 Tom Tromey <tromey@adacore.com>
9314
9315 * source-cache.h (class source_cache) <get_source_lines>: Return
9316 std::string.
9317 * source-cache.c (source_cache::extract_lines): Handle case where
9318 first_pos==npos. Return std::string.
9319 (source_cache::get_source_lines): Update.
9320
d085f989
TT
93212019-03-14 Tom Tromey <tromey@adacore.com>
9322
9323 * NEWS: Add item for "style sources" commands.
9324 * source-cache.c (source_cache::get_source_lines): Check
9325 source_styling.
9326 * cli/cli-style.c (source_styling): New global.
9327 (_initialize_cli_style): Add "style sources" commands.
9328 (show_style_sources): New function.
9329 * cli/cli-style.h (source_styling): Declare.
9330
6f11e682
TT
93312019-03-14 Pedro Alves <palves@redhat.com>
9332 Tom Tromey <tromey@adacore.com>
9333
9334 * tui/tui-winsource.h (tui_refill_source_window): Declare.
9335 * tui/tui-winsource.c (tui_refill_source_window): New function,
9336 from...
9337 (tui_horizontal_source_scroll): ... here. Move some logic.
9338 * cli/cli-style.c (set_style_enabled): Notify new observable.
9339 * tui/tui-hooks.c (tui_redisplay_source): New function.
9340 (tui_attach_detach_observers): Attach or detach
9341 tui_redisplay_source.
9342 * observable.h (source_styling_changed): New observable.
9343 * observable.c: Define source_styling_changed observable.
9344
a068643d
TT
93452019-03-13 Tom Tromey <tromey@adacore.com>
9346
9347 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9348 (i386_gnu_nat_target::store_registers): Update.
9349 * target-debug.h (target_debug_print_std_string): New macro.
9350 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9351 * windows-tdep.c (display_one_tib): Update.
9352 * tui/tui-stack.c (tui_make_status_line): Update.
9353 * top.c (print_inferior_quit_action): Update.
9354 * thread.c (thr_try_catch_cmd): Update.
9355 (add_thread_with_info): Update.
9356 (thread_target_id_str): Update.
9357 (thr_try_catch_cmd): Update.
9358 (thread_command): Update.
9359 (thread_find_command): Update.
9360 * record-btrace.c (record_btrace_target::info_record)
9361 (record_btrace_resume_thread, record_btrace_target::resume)
9362 (record_btrace_cancel_resume, record_btrace_step_thread)
9363 (record_btrace_target::wait, record_btrace_target::wait)
9364 (record_btrace_target::wait, record_btrace_target::stop): Update.
9365 * progspace.c (print_program_space): Update.
9366 * process-stratum-target.c
9367 (process_stratum_target::thread_address_space): Update.
9368 * linux-fork.c (linux_fork_mourn_inferior)
9369 (detach_checkpoint_command, info_checkpoints_command)
9370 (linux_fork_context): Update.
9371 (linux_fork_detach): Update.
9372 (class scoped_switch_fork_info): Update.
9373 (delete_checkpoint_command): Update.
9374 * infrun.c (follow_fork_inferior): Update.
9375 (follow_fork_inferior): Update.
9376 (proceed_after_vfork_done): Update.
9377 (handle_vfork_child_exec_or_exit): Update.
9378 (follow_exec): Update.
9379 (displaced_step_prepare_throw): Update.
9380 (displaced_step_restore): Update.
9381 (start_step_over): Update.
9382 (resume_1): Update.
9383 (clear_proceed_status_thread): Update.
9384 (proceed): Update.
9385 (print_target_wait_results): Update.
9386 (do_target_wait): Update.
9387 (context_switch): Update.
9388 (stop_all_threads): Update.
9389 (restart_threads): Update.
9390 (finish_step_over): Update.
9391 (handle_signal_stop): Update.
9392 (switch_back_to_stepped_thread): Update.
9393 (keep_going_pass_signal): Update.
9394 (print_exited_reason): Update.
9395 (normal_stop): Update.
9396 * inferior.c (inferior_pid_to_str): Change return type.
9397 (print_selected_inferior): Update.
9398 (add_inferior): Update.
9399 (detach_inferior): Update.
9400 * dummy-frame.c (fprint_dummy_frames): Update.
9401 * dcache.c (dcache_info_1): Update.
9402 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9403 (btrace_fetch, btrace_clear): Update.
9404 * linux-tdep.c (linux_core_pid_to_str): Change return type.
9405 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9406 type.
9407 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9408 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9409 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9410 * gdbarch.c, gdbarch.h: Rebuild.
9411 * gdbarch.sh (core_pid_to_str): Change return type.
9412 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9413 return type.
9414 (windows_nat_target::pid_to_str): Change return type.
9415 (windows_delete_thread): Update.
9416 (windows_nat_target::attach): Update.
9417 (windows_nat_target::files_info): Update.
9418 * target-delegates.c: Rebuild.
9419 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9420 return type.
9421 (sol_thread_target::pid_to_str): Change return type.
9422 * remote.c (class remote_target) <pid_to_str>: Change return
9423 type.
9424 (remote_target::pid_to_str): Change return type.
9425 (extended_remote_target::attach, remote_target::remote_stop_ns)
9426 (remote_target::remote_notif_remove_queued_reply)
9427 (remote_target::push_stop_reply, remote_target::disable_btrace):
9428 Update.
9429 (extended_remote_target::attach): Update.
9430 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9431 type.
9432 (gdbsim_target::pid_to_str): Change return type.
9433 * ravenscar-thread.c (struct ravenscar_thread_target)
9434 <pid_to_str>: Change return type.
9435 (ravenscar_thread_target::pid_to_str): Change return type.
9436 * procfs.c (class procfs_target) <pid_to_str>: Change return
9437 type.
9438 (procfs_target::pid_to_str): Change return type.
9439 (procfs_target::attach): Update.
9440 (procfs_target::detach): Update.
9441 (procfs_target::fetch_registers): Update.
9442 (procfs_target::store_registers): Update.
9443 (procfs_target::wait): Update.
9444 (procfs_target::files_info): Update.
9445 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9446 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9447 return type.
9448 (nto_procfs_target::pid_to_str): Change return type.
9449 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9450 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9451 return type.
9452 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9453 (exit_lwp): Update.
9454 (attach_proc_task_lwp_callback, get_detach_signal)
9455 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9456 (linux_nat_target::resume, wait_lwp, stop_callback)
9457 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9458 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9459 (linux_nat_wait_1, resume_stopped_resumed_lwps)
9460 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9461 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9462 type.
9463 (inf_ptrace_target::attach): Update.
9464 (inf_ptrace_target::files_info): Update.
9465 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9466 type.
9467 (go32_nat_target::pid_to_str): Change return type.
9468 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9469 (gnu_nat_target::wait): Update.
9470 (gnu_nat_target::wait): Update.
9471 (gnu_nat_target::resume): Update.
9472 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9473 (fbsd_nat_target::wait): Update.
9474 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9475 type.
9476 (darwin_nat_target::attach): Update.
9477 * corelow.c (class core_target) <pid_to_str>: Change return type.
9478 (core_target::pid_to_str): Change return type.
9479 * target.c (normal_pid_to_str): Change return type.
9480 (default_pid_to_str): Likewise.
9481 (target_pid_to_str): Change return type.
9482 (target_translate_tls_address): Update.
9483 (target_announce_detach): Update.
9484 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9485 return type.
9486 (bsd_uthread_target::pid_to_str): Change return type.
9487 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9488 type.
9489 (bsd_kvm_target::pid_to_str): Change return type.
9490 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9491 return type.
9492 (aix_thread_target::pid_to_str): Change return type.
9493 * target.h (struct target_ops) <pid_to_str>: Change return type.
9494 (target_pid_to_str, normal_pid_to_str): Likewise.
9495 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9496 type.
9497 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9498 type.
9499 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9500 return type.
9501 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9502 type.
9503 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9504 type.
9505 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9506 return type.
9507
b4be1b06
SM
95082019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9509
9510 * NEWS: Mention that the new default MI version is 3. Mention
9511 changes to the output of commands and events that deal with
9512 multi-location breakpoints.
9513 * breakpoint.c: Include "mi/mi-out.h".
9514 (print_one_breakpoint): Change output syntax if using MI version
9515 >= 3.
9516 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9517 New.
9518 (mi_multi_location_breakpoint_output_fixed): New.
9519 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9520 (mi_cmd_fix_multi_location_breakpoint_output): New.
9521 (mi_multi_location_breakpoint_output_fixed): New.
9522 * mi/mi-cmds.c (mi_cmds): Register command
9523 -fix-multi-location-breakpoint-output.
9524 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9525 interpreter "mi".
9526
8e5e5494
SM
95272019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9528
9529 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9530 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9531 instantiate mi_ui_out based on interpreter name.
9532 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9533 * mi/mi-main.c (mi_load_progress): Likewise.
9534
197df35e
JB
95352019-03-12 John Baldwin <jhb@FreeBSD.org>
9536
9537 * NEWS: Combine separate "New targets" sections for 8.3.
9538
8399425f
JB
95392019-03-12 John Baldwin <jhb@FreeBSD.org>
9540
9541 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9542 (ppcfbsd_init_abi): Install gdbarch
9543 "fetch_tls_load_module_address" and "get_thread_local_address"
9544 methods.
9545
b0f87ed0
JB
95462019-03-12 John Baldwin <jhb@FreeBSD.org>
9547
9548 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9549 (riscv_fbsd_init_abi): Install gdbarch
9550 "fetch_tls_load_module_address" and "get_thread_local_address"
9551 methods.
9552
ce25aa57
JB
95532019-03-12 John Baldwin <jhb@FreeBSD.org>
9554
9555 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9556 (i386fbsd_init_abi): Install gdbarch
9557 "fetch_tls_load_module_address" and "get_thread_local_address"
9558 methods.
9559
f5424cfa
JB
95602019-03-12 John Baldwin <jhb@FreeBSD.org>
9561
9562 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9563 (amd64fbsd_init_abi): Install gdbarch
9564 "fetch_tls_load_module_address" and "get_thread_local_address"
9565 methods.
9566
945f3901
JB
95672019-03-12 John Baldwin <jhb@FreeBSD.org>
9568
9569 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9570 (struct fbsd_pspace_data): New type.
9571 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9572 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9573 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9574 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9575 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9576
ef0bd204
JB
95772019-03-12 John Baldwin <jhb@FreeBSD.org>
9578
9579 * gdbtypes.c (lookup_struct_elt): New function.
9580 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9581 * gdbtypes.h (struct struct_elt): New type.
9582 (lookup_struct_elt): New prototype.
9583
36c53a02
JB
95842019-03-12 John Baldwin <jhb@FreeBSD.org>
9585
9586 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9587 remove disabled code block.
9588
6e056c81
JB
95892019-03-12 John Baldwin <jhb@FreeBSD.org>
9590
9591 * gdbarch.sh (get_thread_local_address): New method.
9592 * gdbarch.h, gdbarch.c: Regenerate.
9593 * target.c (target_translate_tls_address): Use
9594 gdbarch_get_thread_local_address if present instead of
9595 target::get_thread_local_address.
9596
cd250a18
JB
95972019-03-12 John Baldwin <jhb@FreeBSD.org>
9598
9599 * target.h (target::get_thread_local_address): Update comment.
9600
df22c1e5
JB
96012019-03-12 John Baldwin <jhb@FreeBSD.org>
9602
9603 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9604 objfile->separate_debug_objfile_backlink if not NULL.
9605
dd6876c9
JB
96062019-03-12 John Baldwin <jhb@FreeBSD.org>
9607
9608 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9609 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9610 (amd64bsd_store_inferior_registers): Likewise.
9611 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9612 Enable segment base registers.
9613 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9614 PT_GETFSBASE and PT_GETGSBASE.
9615 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9616 PT_SETGSBASE.
9617 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9618 segment base registers.
9619 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9620
1163a4b7
JB
96212019-03-12 John Baldwin <jhb@FreeBSD.org>
9622
9623 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9624 Update calls to i386_target_description to add 'segments'
9625 parameter.
9626 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9627 add segment base registers.
9628 * arch/i386.c (i386_create_target_description): Add 'segments'
9629 parameter to enable segment base registers.
9630 * arch/i386.h (i386_create_target_description): Likewise.
9631 * features/i386/32bit-segments.xml: New file.
9632 * features/i386/32bit-segments.c: Generate.
9633 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9634 call to i386_target_description to add 'segments' parameter.
9635 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9636 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9637 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9638 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9639 if feature is present.
9640 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9641 Add 'segments' parameter to call to i386_target_description.
9642 (i386_target_description): Add 'segments' parameter to enable
9643 segment base registers.
9644 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9645 to call to i386_target_description.
9646 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9647 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9648 Define I386_NUM_REGS.
9649 (i386_target_description): Add 'segments' parameter to enable
9650 segment base registers.
9651
3a350822
EZ
96522019-03-12 Eli Zaretskii <eliz@gnu.org>
9653
9654 PR/24325
9655 * source-cache.c: #undef open and close, to avoid unresolved
9656 externals during linking.
9657
ffdd69cf
TT
96582019-03-12 Tom Tromey <tromey@adacore.com>
9659
9660 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9661 const. Add initializers.
9662 (_initialize_remote): Don't initialize ptid globals.
9663
ec148c57
PA
96642019-03-12 Pedro Alves <palves@redhat.com>
9665
9666 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9667
32764270
PA
96682019-03-12 Pedro Alves <palves@redhat.com>
9669
9670 * cp-name-parser.y (main): Remove unused 'len' variable.
9671
17547186
TT
96722019-03-12 Tom Tromey <tromey@adacore.com>
9673
9674 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9675 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9676
d3a70e03
TT
96772019-03-12 Tom Tromey <tromey@adacore.com>
9678
9679 * linux-nat.c (iterate_over_lwps): Update.
9680 (stop_callback): Remove parameter.
9681 (stop_wait_callback, detach_callback, resume_set_callback)
9682 (select_singlestep_lwp_callback, set_ignore_sigint)
9683 (status_callback, resumed_callback, resume_clear_callback)
9684 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9685 data parameter.
9686 (linux_nat_target::detach, linux_nat_target::resume)
9687 (linux_stop_and_wait_all_lwps, select_event_lwp)
9688 (linux_nat_filter_event, linux_nat_wait_1)
9689 (linux_nat_target::kill, linux_nat_target::stop)
9690 (linux_nat_target::stop): Update.
9691 (linux_nat_resume_callback): Change type.
9692 (resume_stopped_resumed_lwps, count_events_callback)
9693 (select_event_lwp_callback): Likewise.
9694 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9695 * arm-linux-nat.c (struct update_registers_data): Remove.
9696 (update_registers_callback): Change type.
9697 (arm_linux_insert_hw_breakpoint1): Update.
9698 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9699 parameter.
9700 (x86_linux_dr_set_addr): Update.
9701 (x86_linux_dr_set_control): Update.
9702 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9703 (iterate_over_lwps): Use gdb::function_view.
9704 * nat/aarch64-linux-hw-point.c (struct
9705 aarch64_dr_update_callback_param): Remove.
9706 (debug_reg_change_callback): Change type.
9707 (aarch64_notify_debug_reg_change): Update.
9708 * s390-linux-nat.c (s390_refresh_per_info): Update.
9709
82cb27ff
TT
97102019-03-11 Tom Tromey <tromey@adacore.com>
9711
9712 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9713 redundant assignment to "this_cu".
9714
568c0683
SM
97152019-03-08 Simon Marchi <simon.marchi@efficios.com>
9716
9717 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9718
f09ce22d
SM
97192019-03-08 Simon Marchi <simon.marchi@efficios.com>
9720
9721 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9722 from...
9723 (rank_one_type): ... this.
9724
595f96a9
SM
97252019-03-08 Simon Marchi <simon.marchi@efficios.com>
9726
9727 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9728 from...
9729 (rank_one_type): ... this.
9730
2598a94b
SM
97312019-03-08 Simon Marchi <simon.marchi@efficios.com>
9732
9733 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9734 from...
9735 (rank_one_type): ... this.
9736
7f17b20d
SM
97372019-03-08 Simon Marchi <simon.marchi@efficios.com>
9738
9739 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9740 from...
9741 (rank_one_type): ... this.
9742
2c509035
SM
97432019-03-08 Simon Marchi <simon.marchi@efficios.com>
9744
9745 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9746 from...
9747 (rank_one_type): ... this.
9748
0dd322dc
SM
97492019-03-08 Simon Marchi <simon.marchi@efficios.com>
9750
9751 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9752 from...
9753 (rank_one_type): ... this.
9754
41ea4728
SM
97552019-03-08 Simon Marchi <simon.marchi@efficios.com>
9756
9757 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9758 from...
9759 (rank_one_type): ... this.
9760
793cd1d2
SM
97612019-03-08 Simon Marchi <simon.marchi@efficios.com>
9762
9763 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9764 from...
9765 (rank_one_type): ... this.
9766
34910087
SM
97672019-03-08 Simon Marchi <simon.marchi@efficios.com>
9768
9769 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9770 from...
9771 (rank_one_type): ... this.
9772
f1f832d6
SM
97732019-03-08 Simon Marchi <simon.marchi@efficios.com>
9774
9775 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9776 from...
9777 (rank_one_type): ... this.
9778
b9f4512f
SM
97792019-03-08 Simon Marchi <simon.marchi@efficios.com>
9780
9781 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9782 from...
9783 (rank_one_type): ... this.
9784
9293fc63
SM
97852019-03-08 Simon Marchi <simon.marchi@efficios.com>
9786
9787 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9788 from...
9789 (rank_one_type): ... this.
9790
e3abbe7e
PW
97912019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9792
9793 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9794 inferior-events' shows the example events.
9795
e4adb939
EZ
97962019-03-08 Eli Zaretskii <eliz@gnu.org>
9797
9798 Support styling on native MS-Windows console
9799
9800 PR/24315
9801 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9802 on MS-Windows if $TERM is not defined.
9803
9804 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9805
9806 * posix-hdep.c (gdb_console_fputs):
9807 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9808 functions.
9809 * ui-file.h (gdb_console_fputs): Add prototype.
9810
9811 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9812 back to fputs only if the former returns zero.
9813
25629dfd
TT
98142019-03-07 Tom Tromey <tom@tromey.com>
9815
9816 * symmisc.c (print_symbol_bcache_statistics): Update.
9817 (print_objfile_statistics): Update.
9818 * symfile.c (allocate_symtab): Update.
9819 * stabsread.c: Don't include bcache.h.
9820 * psymtab.h (struct psymbol_bcache): Don't declare.
9821 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9822 (psymbol_bcache_init, psymbol_bcache_free)
9823 (psymbol_bcache_get_bcache): Don't declare.
9824 * psymtab.c (struct psymbol_bcache): Remove.
9825 (psymtab_storage::psymtab_storage): Update.
9826 (psymtab_storage::~psymtab_storage): Update.
9827 (psymbol_bcache_init, psymbol_bcache_free)
9828 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9829 (add_psymbol_to_bcache): Update.
9830 (allocate_psymtab): Update.
9831 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9832 macro_cache>: No longer pointers.
9833 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9834 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9835 * macrotab.c (macro_bcache): Update.
9836 * macroexp.c: Don't include bcache.h.
9837 * gdbtypes.c (check_types_worklist): Update.
9838 (types_deeply_equal): Remove TRY/CATCH. Update.
9839 * elfread.c (elf_symtab_read): Update.
9840 * dwarf2read.c: Don't include bcache.h.
9841 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9842 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9843 (print_bcache_statistics, bcache_memory_used): Don't declare.
9844 (struct bcache): Move from bcache.c. Add constructor, destructor,
9845 methods. Rename all data members.
9846 * bcache.c (struct bcache): Move to bcache.h.
9847 (bcache::expand_hash_table): Rename from expand_hash_table.
9848 (bcache): Remove.
9849 (bcache::insert): Rename from bcache_full.
9850 (bcache::compare): Rename from bcache_compare.
9851 (bcache_xmalloc): Remove.
9852 (bcache::~bcache): Rename from bcache_xfree.
9853 (bcache::print_statistics): Rename from print_bcache_statistics.
9854 (bcache::memory_used): Rename from bcache_memory_used.
9855
fe726667
PA
98562019-03-07 Pedro Alves <palves@redhat.com>
9857
9858 * infrun.c (normal_stop): Also check for
9859 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9860
7584bb30
AB
98612019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9862
9863 * f-lang.c (value_from_host_double): Moved to...
9864 * value.c (value_from_host_double): ...here.
9865 * value.h (value_from_host_double): Declare.
9866 * guile/scm-math.c (vlscm_convert_typed_number): Use
9867 value_from_host_double.
9868 (vlscm_convert_number): Likewise.
9869 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9870 * python/py-value.c (convert_value_from_python): Likewise.
9871
a7b1986e
TT
98722019-03-06 Tom Tromey <tom@tromey.com>
9873
9874 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9875
0ccf4211
TT
98762019-03-06 Tom Tromey <tom@tromey.com>
9877
9878 * utils.h (free_current_contents): Don't declare.
9879 * utils.c (free_current_contents): Remove.
9880
fe7b42e5
TT
98812019-03-06 Tom Tromey <tom@tromey.com>
9882
9883 * top.c (quit_force): Update.
9884 * main.c (captured_command_loop): Update.
9885 * common/new-op.c (operator new): Update.
9886 * common/common-exceptions.c (struct catcher)
9887 <save_cleanup_chain>: Remove member.
9888 (exceptions_state_mc_init): Update.
9889 (exception_try_scope_entry): Return nullptr.
9890 (exception_try_scope_exit, exception_rethrow)
9891 (throw_exception_sjlj, throw_exception_cxx): Update.
9892 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9893 (all_cleanups, do_cleanups, discard_cleanups)
9894 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9895 (restore_cleanups, restore_final_cleanups): Don't declare.
9896 (do_final_cleanups): Remove parameter.
9897 * common/cleanups.c (cleanup_chain, make_cleanup)
9898 (make_cleanup_dtor, all_cleanups, do_cleanups)
9899 (discard_my_cleanups, discard_cleanups)
9900 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9901 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9902 (null_cleanup): Remove.
9903 (do_final_cleanups): Remove parameter.
9904
c6321f19
TT
99052019-03-06 Tom Tromey <tom@tromey.com>
9906
9907 * remote.c (remote_target::remote_parse_stop_reply): Use
9908 unique_xmalloc_ptr.
9909
61b30099
TT
99102019-03-06 Tom Tromey <tom@tromey.com>
9911
9912 * stabsread.c (struct stabs_field_info): Rename from field_info.
9913 <list, fnlist>: Add initializers.
9914 <obstack>: New member.
9915 (read_member_functions, read_struct_fields, read_baseclasses):
9916 Allocate on obstack. Don't use cleanups.
9917 (read_one_struct_field, read_member_functions, read_struct_fields)
9918 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9919 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9920 (read_struct_type): Update.
9921
6cceac94
TT
99222019-03-06 Tom Tromey <tom@tromey.com>
9923
9924 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9925 * common/filestuff.h (make_cleanup_close): Don't declare.
9926 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9927 Remove.
9928
72412762
TT
99292019-03-06 Tom Tromey <tom@tromey.com>
9930
9931 * solib-aix.c: Use make_scope_exit.
9932
2b6ff1c0
TT
99332019-03-06 Tom Tromey <tom@tromey.com>
9934
9935 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9936 Use make_scope_exit.
9937
d01c5877
TT
99382019-03-06 Tom Tromey <tom@tromey.com>
9939
9940 * solib-svr4.c (disable_probes_interface): Remove parameter.
9941 (svr4_handle_solib_event): Use make_scope_exit.
9942
32603266
TT
99432019-03-06 Tom Tromey <tom@tromey.com>
9944
9945 * remote.c (struct stop_reply_deleter): Remove.
9946 (stop_reply_up): Update.
9947 (struct stop_reply): Derive from notif_event. Don't typedef.
9948 <regcache>: Now a std::vector.
9949 (stop_reply_xfree): Remove.
9950 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9951 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9952 (remote_target::discard_pending_stop_replies): Use delete.
9953 (remote_target::remote_parse_stop_reply): Update.
9954 (remote_target::process_stop_reply): Update.
9955 * remote-notif.h (struct notif_event): Add virtual destructor.
9956 Remove "dtr" member.
9957 (struct notif_client) <alloc_event>: Return a unique_ptr.
9958 (notif_event_xfree): Don't declare.
9959 (notif_event_up): New typedef.
9960 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9961 (notif_event_xfree, do_notif_event_xfree): Remove.
9962 (remote_notif_state_xfree): Update.
9963
9799571e
TT
99642019-03-06 Tom Tromey <tom@tromey.com>
9965
9966 * infrun.c (displaced_step_clear_cleanup): Now a
9967 forward_scope_exit type.
9968 (displaced_step_prepare_throw): Update.
9969 (displaced_step_fixup): Update.
9970
09e3c4ca
TT
99712019-03-06 Tom Tromey <tom@tromey.com>
9972
9973 * inferior.h (class inferior): Update comment.
9974 * gdbthread.h (class thread_info): Update comment.
9975
e2a03548
TT
99762019-03-06 Joel Brobecker <brobecker@adacore.com>
9977 Tom Tromey <tom@tromey.com>
9978
9979 * stabsread.h (struct stab_section_list): Remove.
9980 (coffstab_build_psymtabs): Update.
9981 * dbxread.c (symbuf_sections): Now a std::vector.
9982 (sect_idx): New global.
9983 (fill_symbuf): Update.
9984 (coffstab_build_psymtabs): Change type of stabsects parameter.
9985 Update.
9986 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9987 std::vector.
9988 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9989 (coff_locate_sections): Update.
9990 (coff_symfile_read): Remove cleanups. Update.
9991 (init_stringtab): Add storage parameter.
9992 (free_stringtab, free_stringtab_cleanup): Remove.
9993 (init_lineno): Add storage parameter.
9994 (free_linetab, free_linetab_cleanup): Remove.
9995
b7e60d85
PA
99962019-03-06 Pedro Alves <palves@redhat.com>
9997
9998 * linux-fork.c (fork_info::clobber_regs): Delete.
9999 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10000 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10001 comment. Adjust.
10002 (scoped_switch_fork_info::scoped_switch_fork_info)
10003 (checkpoint_command, linux_fork_context): Adjust
10004 fork_save_infrun_state calls.
10005
e52c971f
PA
100062019-03-06 Pedro Alves <palves@redhat.com>
10007
10008 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10009 (inf_has_multiple_threads): Return 'bool' and rewrite using
10010 inferior_info::threads().
10011
06974e6c
PA
100122019-03-06 Pedro Alves <palves@redhat.com>
10013
10014 * linux-fork.c: Include <list>.
10015 (fork_list): Now a std::list instance.
10016 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10017 (forks_exist_p, find_last_fork): Adjust.
10018 (new_fork): Delete.
10019 (one_fork_p): New.
10020 (add_fork): Adjust.
10021 (free_fork): Delete, folded into fork_info::~fork_info().
10022 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10023 Adjust.
10024 (init_fork_list): Delete.
10025 (linux_fork_killall, linux_fork_mourn_inferior)
10026 (linux_fork_detach, info_checkpoints_command): Adjust.
10027 (_initialize_linux_fork): No longer call init_fork_list.
10028
72f31aea
PA
100292019-03-06 Pedro Alves <palves@redhat.com>
10030
10031 * linux-fork.c (new_fork): New, split out of ...
10032 (add_fork): ... this. Return void. Move "first fork" special
10033 case from here, to ...
10034 (checkpoint_command): ... here.
10035 * linux-linux.h (add_fork): Return void.
10036
efbecbc1
AB
100372019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10038
10039 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10040
0841c79a
AB
100412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10042 Chris January <chris.january@arm.com>
10043 David Lecomber <david.lecomber@arm.com>
10044
10045 * f-exp.y: New token, UNOP_INTRINSIC.
10046 (exp): New pattern using UNOP_INTRINSIC token.
10047 (f77_keywords): Add 'abs' keyword.
10048 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10049 (value_from_host_double): New function.
10050 (evaluate_subexp_f): Support UNOP_ABS.
10051
4a270568
AB
100522019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10053
10054 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10055 types.
10056
067630bd
AB
100572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10058
10059 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10060 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10061 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10062
3be47f7a
AB
100632019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10064
10065 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10066
4d00f5d8
AB
100672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10068 Chris January <chris.january@arm.com>
10069
10070 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10071 * f-exp.y: Define 'KIND' token.
10072 (exp): New pattern for KIND expressions.
10073 (ptype): Handle types with a kind extension.
10074 (direct_abs_decl): Extend to spot kind extensions.
10075 (f77_keywords): Add 'kind' to the list.
10076 (push_kind_type): New function.
10077 (convert_to_kind_type): New function.
10078 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10079 * parse.c (operator_length_standard): Likewise.
10080 * parser-defs.h (enum type_pieces): Add tp_kind.
10081 * std-operator.def: Add UNOP_KIND.
10082
e454224f
AB
100832019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10084
10085 * f-exp.y (f_parse): Set yydebug.
10086
9dad4a58
AB
100872019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10088
10089 * f-lang.c (evaluate_subexp_f): New function.
10090 (exp_descriptor_f): New global.
10091 (f_language_defn): Use exp_descriptor_f instead of
10092 exp_descriptor_standard.
10093
c8f91604
AB
100942019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10095
10096 * f-exp.y (struct token): Add comments.
10097 (dot_ops): Remove uppercase versions and the end marker.
10098 (f77_keywords): Likewise.
10099 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10100 entries in the dot_ops array are case insensitive, and use
10101 strncasecmp to compare strings. Also some whitespace cleanup in
10102 this area. Similar for the f77_keywords array, except entries in
10103 this list might be case sensitive.
10104
dd9f2c76
AB
101052019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10106
10107 * f-exp.y (struct f77_boolean_val): Add comments.
10108 (boolean_values): Remove uppercase versions, and end marker.
10109 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10110 and use strncasecmp to achieve case insensitivity. Additionally,
10111 perform whitespace cleanup around this code.
10112
67a3048c
TT
101132019-03-06 Tom Tromey <tromey@adacore.com>
10114
10115 * remote-sim.c (gdbsim_target_open): Use result of
10116 gdb_argv::release.
10117
aa3cfbda
RB
101182019-03-06 Richard Bunt <richard.bunt@arm.com>
10119 Dirk Schubert <dirk.schubert@arm.com>
10120 Chris January <chris.january@arm.com>
10121
10122 * eval.c (evaluate_subexp_standard): Call Fortran argument
10123 wrapping logic.
10124 * f-lang.c (struct value): A value which can be passed into a
10125 Fortran function call.
10126 (fortran_argument_convert): Wrap Fortran arguments in a pointer
10127 where appropriate.
10128 (struct type): Value ready for a Fortran function call.
10129 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10130 is needed.
10131 * f-lang.h (fortran_argument_convert): Declaration.
10132 (fortran_preserve_arg_pointer): Declaration.
10133 * infcall.c (value_arg_coerce): Call Fortran argument logic.
10134
ea38e5df
TT
101352019-03-05 Tom Tromey <tromey@adacore.com>
10136
10137 * python/py-prettyprint.c (print_string_repr): Remove #if.
10138 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10139
06b5b831
TT
101402019-03-05 Tom Tromey <tromey@adacore.com>
10141
10142 * target.c (the_dummy_target): Move later. Change type to
10143 "dummy_target".
10144 (initialize_targets): Don't initialize the_dummy_target.
10145
edbd9e45
TT
101462019-03-05 Tom Tromey <tromey@adacore.com>
10147
10148 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10149 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10150
c119e040
TT
101512019-03-05 Tom Tromey <tromey@adacore.com>
10152
10153 * windows-nat.c (windows_nat_target::attach)
10154 (windows_nat_target::detach): Don't call gdb_flush.
10155 * valprint.c (generic_val_print, val_print, val_print_string):
10156 Don't call gdb_flush.
10157 * utils.c (defaulted_query): Don't call gdb_flush.
10158 * typeprint.c (print_type_scalar): Don't call gdb_flush.
10159 * target.c (target_announce_detach): Don't call gdb_flush.
10160 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10161 * remote.c (extended_remote_target::attach): Don't call
10162 gdb_flush.
10163 * procfs.c (procfs_target::detach): Don't call gdb_flush.
10164 * printcmd.c (do_examine): Don't call gdb_flush.
10165 (info_display_command): Don't call gdb_flush.
10166 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10167 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10168 * memattr.c (info_mem_command): Don't call gdb_flush.
10169 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10170 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10171 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10172 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10173 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10174 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10175 (gnu_nat_target::detach): Don't call gdb_flush.
10176 * f-valprint.c (f_val_print): Don't call gdb_flush.
10177 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10178 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10179 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10180 gdb_flush.
10181 * c-valprint.c (c_val_print): Don't call gdb_flush.
10182 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10183
895dafa6
TT
101842019-03-05 Tom Tromey <tromey@adacore.com>
10185
10186 * varobj.c (update_dynamic_varobj_children): Update.
10187 (install_default_visualizer): Use reset, not release.
10188 * value.c (set_internalvar): Update.
10189 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10190 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10191 ATTRIBUTE_UNUSED_RESULT.
10192
88a774b9
TT
101932019-03-05 Tom Tromey <tromey@adacore.com>
10194
10195 * remote.c (class scoped_remote_fd) <release>: Add
10196 ATTRIBUTE_UNUSED_RESULT.
10197
4e4a8b93
TT
101982019-03-05 Tom Tromey <tromey@adacore.com>
10199
10200 * macroexp.c (struct macro_buffer) <release>: Add
10201 ATTRIBUTE_UNUSED_RESULT.
10202
083eef1f
TT
102032019-03-05 Tom Tromey <tromey@adacore.com>
10204
10205 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10206 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10207 ATTRIBUTE_UNUSED_RESULT.
10208
3cabd438
TT
102092019-03-05 Tom Tromey <tromey@adacore.com>
10210
10211 * common/scoped_fd.h (class scoped_fd) <release>: Add
10212 ATTRIBUTE_UNUSED_RESULT.
10213
41e3300a
TT
102142019-03-05 Tom Tromey <tromey@adacore.com>
10215
10216 * parser-defs.h (struct parser_state) <release>: Add
10217 ATTRIBUTE_UNUSED_RESULT.
10218
18cb7c9f
TT
102192019-03-05 Tom Tromey <tromey@adacore.com>
10220
10221 * utils.h (class gdb_argv) <release>: Add
10222 ATTRIBUTE_UNUSED_RESULT.
10223 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10224
41fa577f
EZ
102252019-03-02 Eli Zaretskii <eliz@gnu.org>
10226
a6a4b2c6
EZ
10227 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10228 for-loop range, to avoid compiler warnings.
10229
10230 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10231 avoid compiler warnings about unused variables.
10232
742a7df5
EZ
10233 * NEWS: Mention end of support for native debugging on MS-Windows
10234 before XP.
10235
41fa577f
EZ
10236 PR gdb/24292
10237 * common/netstuff.c:
10238 * gdbserver/gdbreplay.c
10239 * gdbserver/remote-utils.c:
10240 * ser-tcp.c:
10241 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10242 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
10243 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10244 'getaddrinfo' and 'freeaddrinfo' were not available before
10245 Windows XP, and mingw.org's MinGW headers by default define
10246 _WIN32_WINNT to 0x500.
10247
827f438f
GB
102482019-03-01 Gary Benson <gbenson@redhat.com>
10249
10250 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10251
92137da0
RO
102522019-02-28 Brian Vandenberg <phantall@gmail.com>
10253 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
10254
10255 PR gdb/8527
10256 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10257 set_sigint_trap, clear_sigint_trap.
10258
799efbe8
PW
102592019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10260
10261 * target.c (target_detach): Clear the regcache and the
10262 frame cache.
10263
8ed25214
PA
102642019-02-27 Pedro Alves <palves@redhat.com>
10265
10266 * utils.c (set_screen_size): When we cap the height/width sizes,
10267 tweak the corresponding command variable to show "unlimited":
10268
23031e31
SJ
102692019-02-27 Saagar Jha <saagar@saagarjha.com>
10270 Pedro Alves <palves@redhat.com>
10271
10272 * utils.c (set_screen_size): Reduce "infinite" rows and columns
10273 before calling rl_set_screen_size.
10274
6c28e44a
TT
102752019-02-27 Tom Tromey <tromey@adacore.com>
10276
10277 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10278 define.
10279 * python/py-value.c: Remove Python 2.4 workaround.
10280 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10281 workaround.
10282 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10283 Python 2.4 workaround.
10284 * python/python-internal.h: Remove Python 2.4 comment.
10285 (Py_ssize_t): Don't define.
10286 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10287 (gdb_Py_DECREF): Remove Python 2.4 workaround.
10288 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10289 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10290 * python/python.c (do_start_initialization): Remove Python 2.4
10291 workaround.
10292 * python/py-prettyprint.c (class dummy_python_frame): Remove.
10293 (print_children): Remove Python 2.4 workaround.
10294 * python/py-inferior.c (buffer_procs): Remove Python 2.4
10295 workaround.
10296 (CHARBUFFERPROC_NAME): Remove.
10297 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10298 Python 2.4 workaround.
10299
2c3fc25d 103002019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 10301
2c3fc25d
KB
10302 * NEWS: Note minimum Python version.
10303
6ca62222
KB
103042019-02-27 Kevin Buettner <kevinb@redhat.com>
10305
10306 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10307 code from these functions. Remove corresponding ifdefs. Use
10308 Py_buffer_up instead of explicit calls to PyBuffer_Release.
10309 Remove gotos and target of gotos.
10310 (infpy_search_memory): Likewise.
10311
f4bc7d2c
AB
103122019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10313
10314 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10315 (hppa_gdbarch_init): Don't register deleted functions with
10316 gdbarch.
10317
9734a586
AB
103182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10319
10320 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10321 (h8300_unwind_sp): Delete.
10322 (h8300_dummy_id): Delete.
10323 (h8300_gdbarch_init): Don't register deleted functions with
10324 gdbarch.
10325
68b867f3
AB
103262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10327
10328 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10329 (ft32_unwind_pc): Delete.
10330 (ft32_unwind_sp): Delete.
10331 (ft32_gdbarch_init): Don't register deleted functions with
10332 gdbarch.
10333
2fbe7ad0
AB
103342019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10335
10336 * gdb/frv-tdep.c (frv_dummy_id): Delete.
10337 (frv_unwind_pc): Delete.
10338 (frv_unwind_sp): Delete.
10339 (frv_gdbarch_init): Don't register deleted functions with
10340 gdbarch.
10341
76055cbe
AB
103422019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10343
10344 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10345 (riscv_unwind_pc): Delete.
10346 (riscv_unwind_sp): Delete.
10347 (riscv_gdbarch_init): Don't register deleted functions with
10348 gdbarch.
10349
4133e5a1
AB
103502019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10351
10352 * gdb/csky-tdep.c (csky_dummy_id): Delete.
10353 (csky_unwind_pc): Delete.
10354 (csky_unwind_sp): Delete.
10355 (csky_gdbarch_init): Don't register deleted functions with
10356 gdbarch.
10357
8010f576
AB
103582019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10359
10360 * gdb/cris-tdep.c (cris_dummy_id): Delete.
10361 (cris_unwind_pc): Delete.
10362 (cris_unwind_sp): Delete.
10363 (cris_gdbarch_init): Don't register deleted functions with
10364 gdbarch.
10365
b56bf084
AB
103662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10367
10368 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10369 (bfin_unwind_pc): Delete.
10370 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10371
a19a650f
AB
103722019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10373
10374 * gdb/arm-tdep.c (arm_dummy_id): Delete.
10375 (arm_unwind_pc): Delete.
10376 (arm_unwind_sp): Delete.
10377 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10378
f8278c3c
AB
103792019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10380
10381 * gdb/arc-tdep.c (arc_dummy_id): Delete.
10382 (arc_unwind_pc): Delete.
10383 (arc_unwind_sp): Delete.
10384 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10385
480e46cf
AB
103862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10387
10388 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10389 (alpha_unwind_pc): Delete.
10390 (alpha_gdbarch_init): Don't register deleted functions with
10391 gdbarch.
10392
7a995095
AB
103932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10394
10395 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10396 (aarch64_unwind_pc): Delete.
10397 (aarch64_unwind_sp): Delete.
10398 (aarch64_gdbarch_init): Don't register deleted functions with
10399 gdbarch.
10400
bf9a735e
AB
104012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10402
10403 * gdbtypes.c (type_align): Don't consider static members when
10404 computing structure alignment.
10405
5561fc30
AB
104062019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10407
10408 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10409 return 0 for other types.
10410 * arch-utils.c (default_type_align): Always return 0.
10411 * gdbarch.h: Regenerate.
10412 * gdbarch.sh (type_align): Extend comment.
10413 * gdbtypes.c (type_align): Add additional comments, always call
10414 gdbarch_type_align before applying the default rules.
10415 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10416 generic code will then apply a suitable default.
10417 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10418 types, return 0 for other types.
10419
9335e75a
JB
104202019-02-27 Joel Brobecker <brobecker@adacore.com>
10421
10422 * NEWS: Create a new section for the next release branch.
10423 Rename the section of the current branch, now that it has
10424 been cut.
10425
3d34d8de
JB
104262019-02-27 Joel Brobecker <brobecker@adacore.com>
10427
10428 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10429 * version.in: Bump version to 8.3.50.DATE-git.
10430
143420fb
SM
104312019-02-26 Simon Marchi <simon.marchi@efficios.com>
10432
10433 * aix-thread.c (ptid_cmp): Remove unused variable.
10434 (get_signaled_thread): Likewise.
10435 (store_regs_user_thread): Likewise.
10436 (store_regs_kernel_thread): Likewise.
10437 (fetch_regs_kernel_thread): Remove shadowed variable.
10438
172fb711
AB
104392019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
10440
10441 * features/riscv/32bit-cpu.xml: Add register numbers.
10442 * features/riscv/32bit-fpu.c: Regenerate.
10443 * features/riscv/32bit-fpu.xml: Add register numbers.
10444 * features/riscv/64bit-cpu.xml: Add register numbers.
10445 * features/riscv/64bit-fpu.c: Regenerate.
10446 * features/riscv/64bit-fpu.xml: Add register numbers.
10447
26c89782
KB
104482019-02-26 Kevin Buettner <kevinb@redhat.com>
10449
af54ade9 10450 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
10451 * python/py-value.c (convert_buffer_and_type_to_value): New
10452 function.
10453 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10454 Add support for handling an optional second argument. Call
10455 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
10456 * python/python-internal.h (Py_buffer_deleter): New struct.
10457 (Py_buffer_up): New typedef.
10458
0f58c9e8
JB
104592019-02-25 John Baldwin <jhb@FreeBSD.org>
10460
10461 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10462 instead of releasing ownership.
10463
0a0f4c01
JR
104642019-02-25 Jordan Rupprecht <rupprecht@google.com>
10465
10466 * dwarf2read.c (open_and_init_dwp_file): Call
10467 elf_numsections instead of bfd_count_sections to initialize
10468 dwp_file->num_sections.
10469
cd5a152c
TT
104702019-02-25 Tom Tromey <tromey@adacore.com>
10471
10472 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10473
8a6a8513
SDJ
104742019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
10475
10476 * gcore.in: Add '--readnever' option when invoking GDB.
10477
04dcda9c
SM
104782019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10479
10480 * MAINTAINERS: Update my email address.
10481
07bc701d
SM
104822019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10483
10484 * build-id.c (build_id_to_debug_bfd_1): New function.
10485 (build_id_to_debug_bfd): Look for separate debug file in
10486 sysroot.
10487
c6f4a5d0
AB
104882019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
10489
10490 * gdbarch.sh: Update the copyright year range that is placed into
10491 generated files.
10492
9600246d
KS
104932019-02-22 Keith Seitz <keiths@redhat.com>
10494
10495 PR symtab/23853
10496 * linespec.c (create_sals_line_offset): Search for the default
10497 symtab's filename instead of its fullname.
10498
7557a514
AH
104992019-02-21 Alan Hayward <alan.hayward@arm.com>
10500
10501 * NEWS: Update style defaults.
10502
ee2bcb0c
AH
105032019-02-21 Alan Hayward <alan.hayward@arm.com>
10504
10505 * main.c (captured_main_1): Disable styling in batch mode.
10506
0c95f9ed
TT
105072019-02-20 Tom Tromey <tom@tromey.com>
10508
10509 * symtab.c (symtab_symbol_info): Fix typos.
10510
c763b894
TT
105112019-02-20 Tom Tromey <tromey@adacore.com>
10512
10513 * findcmd.c (_initialize_mem_search): Use upper case for
10514 metasyntactic variables.
10515
0ef8a082
AH
105162019-02-20 Alan Hayward <alan.hayward@arm.com>
10517
10518 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10519 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10520
6caa91b6
SM
105212019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10522
10523 * top.h (source_file_name): Change to std::string.
10524 * top.c (source_file_name): Likewise.
10525 (command_line_input): Adjust.
10526 * cli/cli-script.c (script_from_file): Adjust.
10527
98814c6c
TT
105282019-02-19 Tom Tromey <tromey@adacore.com>
10529
10530 * ravenscar-thread.c
10531 (ravenscar_thread_target::update_thread_list): Don't call
10532 ada_build_task_list.
10533 * ada-lang.h (ada_build_task_list): Don't declare.
10534 * ada-tasks.c (struct ada_tasks_inferior_data)
10535 <task_list_valid_p>: Now bool.
10536 (read_known_tasks, ada_task_list_changed)
10537 (ada_tasks_invalidate_inferior_data): Update.
10538 (read_known_tasks_array): Return bool.
10539 (read_known_tasks_list): Likewise.
10540 (read_known_tasks): Return void.
10541 (ada_build_task_list): Now static.
10542
70cd633e
AB
105432019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10544
10545 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10546 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10547
040b3e95
PW
105482019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10549
10550 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10551 variant for ada_tasks_pspace_data_handle and
10552 ada_tasks_inferior_data_handle.
10553 (ada_tasks_pspace_data_cleanup): New function.
10554 (ada_tasks_inferior_data_cleanup): New function.
10555
9409233b
TT
105562019-02-17 Tom Tromey <tom@tromey.com>
10557
10558 * macrotab.h (macro_source_fullname): Return a std::string.
10559 * macrotab.c (macro_include, check_for_redefinition)
10560 (macro_undef, macro_lookup_definition, foreach_macro)
10561 (foreach_macro_in_scope): Update.
10562 (macro_source_fullname): Return a std::string.
10563 * macrocmd.c (show_pp_source_pos): Update.
10564
6506371f
TT
105652019-02-17 Tom Tromey <tom@tromey.com>
10566
10567 * macrocmd.c (show_pp_source_pos): Style the file names.
10568
0c820d67
TT
105692019-02-17 Tom Tromey <tom@tromey.com>
10570
10571 PR tui/24197:
10572 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10573
a0087920
TT
105742019-02-17 Tom Tromey <tom@tromey.com>
10575
10576 * ada-lang.c (user_select_syms): Use filtered printing.
10577 * utils.c (wrap_style): New global.
10578 (desired_style): Remove.
10579 (emit_style_escape): Add stream parameter.
10580 (set_output_style, reset_terminal_style, prompt_for_continue):
10581 Update.
10582 (flush_wrap_buffer): Only flush gdb_stdout.
10583 (wrap_here): Set wrap_style.
10584 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10585 treat escape sequences as a character. Change when wrap buffer is
10586 flushed.
10587 (fputs_styled): Do not set the output style when the default is
10588 requested.
10589 * ui-style.h (struct ui_file_style) <is_default>: New method.
10590 * source.c (print_source_lines_base): Emit escape sequences in one
10591 piece.
10592
75ba10dc
JB
105932019-02-17 Joel Brobecker <brobecker@adacore.com>
10594
10595 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10596 integers and enumeration types.
10597
a2cd4f14
JB
105982019-02-17 Joel Brobecker <brobecker@adacore.com>
10599
10600 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10601 instead of lookup_symbol_in_language
10602 (do_exact_match): New function.
10603 (ada_get_symbol_name_matcher): Return do_exact_match when
10604 doing a verbatim match.
10605
485b851b
TT
106062019-02-15 Tom Tromey <tromey@adacore.com>
10607
10608 * ravenscar-thread.c (ravenscar_thread_target::resume)
10609 (ravenscar_thread_target::wait): Special case wildcard requests.
10610
0b790b1e
TT
106112019-02-15 Tom Tromey <tromey@adacore.com>
10612
10613 * ravenscar-thread.c (base_ptid): Remove.
10614 (struct ravenscar_thread_target) <close>: New method.
10615 <m_base_ptid>: New member.
10616 <update_inferior_ptid, active_task, task_is_currently_active,
10617 runtime_initialized>: Declare methods.
10618 <ravenscar_thread_target>: Add constructor.
10619 (ravenscar_thread_target::task_is_currently_active)
10620 (ravenscar_thread_target::update_inferior_ptid)
10621 (ravenscar_runtime_initialized): Rename. Now methods.
10622 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10623 (ravenscar_thread_target::update_thread_list): Update.
10624 (ravenscar_thread_target::active_task): Now method.
10625 (ravenscar_thread_target::store_registers)
10626 (ravenscar_thread_target::prepare_to_store)
10627 (ravenscar_thread_target::prepare_to_store)
10628 (ravenscar_thread_target::mourn_inferior): Update.
10629 (ravenscar_inferior_created): Use "new" to create target.
10630 (ravenscar_thread_target::get_ada_task_ptid): Update.
10631 (_initialize_ravenscar): Don't initialize base_ptid.
10632 (ravenscar_ops): Remove global.
10633
dea57a62
TT
106342019-02-15 Tom Tromey <tromey@adacore.com>
10635
10636 * target.h (push_target): Declare new overload.
10637 * target.c (push_target): New overload, taking an rvalue reference.
10638 * remote.c (remote_target::open_1): Use push_target overload.
10639 * corelow.c (core_target_open): Use push_target overload.
10640
989f3c58
TT
106412019-02-15 Tom Tromey <tromey@adacore.com>
10642
10643 * ravenscar-thread.c (is_ravenscar_task)
10644 (ravenscar_task_is_currently_active): Return bool.
10645 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10646 (_initialize_ravenscar): Remove "(void)".
10647 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10648 Return bool.
10649
6cbcc006
TT
106502019-02-15 Tom Tromey <tromey@adacore.com>
10651
10652 * ravenscar-thread.c (ravenscar_runtime_initializer)
10653 (has_ravenscar_runtime, get_running_thread_id)
10654 (ravenscar_thread_target::resume): Fix indentation.
10655
7657f14d
TT
106562019-02-15 Tom Tromey <tromey@adacore.com>
10657
10658 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10659 from ravenscar_arch_ops.
10660 (sparc_ravenscar_ops::fetch_registers)
10661 (sparc_ravenscar_ops::store_registers): Now methods.
10662 (sparc_ravenscar_prepare_to_store): Remove.
10663 (sparc_ravenscar_ops): Redefine.
10664 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10665 methods and destructor. Remove members.
10666 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10667 (ravenscar_thread_target::store_registers)
10668 (ravenscar_thread_target::prepare_to_store): Update.
10669 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10670 Remove.
10671 (struct ppc_ravenscar_powerpc_ops): Derive from
10672 ravenscar_arch_ops.
10673 (ppc_ravenscar_powerpc_ops::fetch_registers)
10674 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10675 (ppc_ravenscar_powerpc_ops): Redefine.
10676 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10677 (ppc_ravenscar_e500_ops::fetch_registers)
10678 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10679 (ppc_ravenscar_e500_ops): Redefine.
10680 * aarch64-ravenscar-thread.c
10681 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10682 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10683 (aarch64_ravenscar_fetch_registers)
10684 (aarch64_ravenscar_store_registers): Now methods.
10685 (aarch64_ravenscar_ops): Redefine.
10686
5b6ea500
TT
106872019-02-15 Tom Tromey <tromey@adacore.com>
10688
10689 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10690 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10691 (ravenscar_thread_target::stopped_by_watchpoint)
10692 (ravenscar_thread_target::stopped_data_address)
10693 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10694
e397fd39
TT
106952019-02-15 Tom Tromey <tromey@adacore.com>
10696
10697 * ravenscar-thread.c: Fix some typos.
10698
cc12f4a8
TT
106992019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10700 Tom Tromey <tromey@adacore.com>
10701
10702 * ada-lang.c (ada_exception_sal): Change addr_string to a
10703 std::string.
10704 (create_ada_exception_catchpoint): Update.
10705
5f486660
TT
107062019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10707 Tom Tromey <tromey@adacore.com>
10708
10709 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10710 (bp_location_ops): Remove.
10711 (base_breakpoint_allocate_location): Update.
10712 (free_bp_location): Update.
10713 * ada-lang.c (class ada_catchpoint_location)
10714 <ada_catchpoint_location>: Remove ops parameter.
10715 (ada_catchpoint_location_dtor): Remove.
10716 (ada_catchpoint_location_ops): Remove.
10717 (allocate_location_exception): Update.
10718 * breakpoint.h (struct bp_location_ops): Remove.
10719 (class bp_location) <bp_location>: Remove bp_location_ops
10720 parameter.
10721 <~bp_location>: Add destructor.
10722 <ops>: Remove.
10723
b671c7fb
TS
107242019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10725 Pedro Alves <palves@redhat.com>
10726
10727 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10728 'PATH_MAX'.
10729
8071c5ce
DM
107302019-02-14 David Michael <fedora.dm0@gmail.com>
10731 Samuel Thibault <samuel.thibault@gnu.org>
10732 Thomas Schwinge <thomas@codesourcery.com>
10733
10734 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10735 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10736
b1041ae0
TS
107372019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10738
924514e1
TS
10739 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10740 (check_empty): Use "const char *".
10741
c29ee8d4
TS
10742 * gnu-nat.c (gnu_nat_target::detach): Instead of
10743 'detach_inferior (pid)' call
10744 'detach_inferior (find_inferior_pid (pid))'.
10745
6c6ef69f
TS
10746 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10747 'nat/fork-inferior.o'.
10748 * gnu-nat.c: #include "nat/fork-inferior.h".
10749
2d0a338c
TS
10750 * gnu-nat.c (gnu_nat_target::detach): Instead of
10751 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10752 * gnu-nat.h: #include "inf-child.h".
10753 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10754 'i386_gnu_nat_target::fetch_registers'.
10755 (gnu_store_registers): Rename/move to
10756 'i386_gnu_nat_target::store_registers'.
10757
cabb5f06
TS
10758 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10759 * gnu-nat.h (mach_thread_info): New function.
10760 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10761
b1041ae0
TS
10762 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10763
2988d01e
KF
107642019-02-14 Frederic Konrad <konrad@adacore.com>
10765
10766 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10767
c559d709
JB
107682019-02-14 Joel Brobecker <brobecker@adacore.com>
10769
10770 * windows-nat.c (windows_add_thread): Add new parameter
10771 "main_thread_p" with default value set to false. Update
10772 function documentation as well as all callers.
10773 (windows_delete_thread): Likewise.
10774 (fake_create_process): Update call to windows_add_thread.
10775 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10776 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10777 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10778 call to windows_delete_thread.
10779
007024cc
SM
107802019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10781
10782 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10783
f62318e9
JB
107842019-02-12 John Baldwin <jhb@FreeBSD.org>
10785
10786 * symfile.c (find_separate_debug_file): Use canonical path of
10787 sysroot with child_path instead of gdb_sysroot if it is valid.
10788
cd4b7848
JB
107892019-02-12 John Baldwin <jhb@FreeBSD.org>
10790
10791 * symfile.c (find_separate_debug_file): Use child_path to
10792 determine if an object file is under a sysroot.
10793
efac4bfe
JB
107942019-02-12 John Baldwin <jhb@FreeBSD.org>
10795
10796 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10797 unittests/child-path-selftests.c.
10798 * common/pathstuff.c (child_path): New function.
10799 * common/pathstuff.h (child_path): New prototype.
10800 * unittests/child-path-selftests.c: New file.
10801
402d2bfe
JB
108022019-02-12 John Baldwin <jhb@FreeBSD.org>
10803
10804 * symfile.c (find_separate_debug_file): Look for separate debug
10805 files in debug directories under the sysroot.
10806
1ed9f74e
PW
108072019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10808
10809 * symtab.h (struct minimal_symbol data_p): New const method.
10810 (struct minimal_symbol text_p): Likewise.
10811 * symtab.c (output_source_filename): Use file name style
10812 to print file name.
10813 (print_symbol_info): Likewise.
10814 (print_msymbol_info): Use address style to print addresses.
10815 Use function name style to print executable text symbols.
10816 (expand_symtab_containing_pc): Use data_p.
10817 (find_pc_sect_compunit_symtab): Likewise.
10818
2636d81d
PW
108192019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10820
10821 * breakpoint.c (describe_other_breakpoints): Use address style
10822 to print addresses.
10823 (say_where): Likewise.
10824
ac8c53cc
PW
108252019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10826
10827 * ada-typeprint.c (print_func_type): Print function name
10828 style to print function name.
10829 * c-typeprint.c (c_print_type_1): Likewise.
10830
ea638c43
AH
108312019-02-11 Alan Hayward <alan.hayward@arm.com>
10832
10833 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10834 for execve.
10835
ab759ca8
PW
108362019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10837
10838 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10839 type_stack.
10840
aff29d1c
JB
108412019-02-10 Joel Brobecker <brobecker@adacore.com>
10842
10843 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10844 TYPE_CODE_REF types.
10845
617126bc
JW
108462019-02-08 Jim Wilson <jimw@sifive.com>
10847
10848 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10849 (riscv_linux_fregset): New.
10850 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10851
46e3ed7f
TT
108522019-02-07 Tom Tromey <tom@tromey.com>
10853
10854 * thread.c (thread_cancel_execution_command): Update.
10855 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10856 methods.
10857 (struct thread_fsm_ops): Remove.
10858 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10859 (thread_fsm_should_stop, thread_fsm_return_value)
10860 (thread_fsm_set_finished, thread_fsm_finished_p)
10861 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10862 Don't declare.
10863 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10864 * infrun.c (clear_proceed_status_thread)
10865 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10866 (print_stop_event): Update.
10867 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10868 Add constructor.
10869 (step_command_fsm_ops): Remove.
10870 (new_step_command_fsm): Remove.
10871 (step_1): Update.
10872 (step_command_fsm::should_stop): Rename from
10873 step_command_fsm_should_stop.
10874 (step_command_fsm::clean_up): Rename from
10875 step_command_fsm_clean_up.
10876 (step_command_fsm::do_async_reply_reason): Rename from
10877 step_command_fsm_async_reply_reason.
10878 (struct until_next_fsm): Inherit from thread_fsm. Add
10879 constructor.
10880 (until_next_fsm_ops): Remove.
10881 (new_until_next_fsm): Remove.
10882 (until_next_fsm::should_stop): Rename from
10883 until_next_fsm_should_stop.
10884 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10885 (until_next_fsm::do_async_reply_reason): Rename from
10886 until_next_fsm_async_reply_reason.
10887 (struct finish_command_fsm): Inherit from thread_fsm. Add
10888 constructor. Change type of breakpoint.
10889 (finish_command_fsm_ops): Remove.
10890 (new_finish_command_fsm): Remove.
10891 (finish_command_fsm::should_stop): Rename from
10892 finish_command_fsm_should_stop.
10893 (finish_command_fsm::clean_up): Rename from
10894 finish_command_fsm_clean_up.
10895 (finish_command_fsm::return_value): Rename from
10896 finish_command_fsm_return_value.
10897 (finish_command_fsm::do_async_reply_reason): Rename from
10898 finish_command_fsm_async_reply_reason.
10899 (finish_command): Update.
10900 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10901 Add constructor.
10902 (call_thread_fsm_ops): Remove.
10903 (call_thread_fsm::call_thread_fsm): Rename from
10904 new_call_thread_fsm.
10905 (call_thread_fsm::should_stop): Rename from
10906 call_thread_fsm_should_stop.
10907 (call_thread_fsm::should_notify_stop): Rename from
10908 call_thread_fsm_should_notify_stop.
10909 (run_inferior_call, call_function_by_hand_dummy): Update.
10910 * cli/cli-interp.c (should_print_stop_to_console): Update.
10911 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10912 Add constructor. Change type of location_breakpoint,
10913 caller_breakpoint.
10914 (until_break_fsm_ops): Remove.
10915 (new_until_break_fsm): Remove.
10916 (until_break_fsm::should_stop): Rename from
10917 until_break_fsm_should_stop.
10918 (until_break_fsm::clean_up): Rename from
10919 until_break_fsm_clean_up.
10920 (until_break_fsm::do_async_reply_reason): Rename from
10921 until_break_fsm_async_reply_reason.
10922 (until_break_command): Update.
10923 * thread-fsm.c: Remove.
10924 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10925
1a5c2598
TT
109262019-02-07 Tom Tromey <tom@tromey.com>
10927
10928 * yy-remap.h: Add include guard.
10929 * xtensa-tdep.h: Add include guard.
10930 * xcoffread.h: Rename include guard.
10931 * varobj-iter.h: Add include guard.
10932 * tui/tui.h: Rename include guard.
10933 * tui/tui-winsource.h: Rename include guard.
10934 * tui/tui-wingeneral.h: Rename include guard.
10935 * tui/tui-windata.h: Rename include guard.
10936 * tui/tui-win.h: Rename include guard.
10937 * tui/tui-stack.h: Rename include guard.
10938 * tui/tui-source.h: Rename include guard.
10939 * tui/tui-regs.h: Rename include guard.
10940 * tui/tui-out.h: Rename include guard.
10941 * tui/tui-layout.h: Rename include guard.
10942 * tui/tui-io.h: Rename include guard.
10943 * tui/tui-hooks.h: Rename include guard.
10944 * tui/tui-file.h: Rename include guard.
10945 * tui/tui-disasm.h: Rename include guard.
10946 * tui/tui-data.h: Rename include guard.
10947 * tui/tui-command.h: Rename include guard.
10948 * tic6x-tdep.h: Add include guard.
10949 * target/waitstatus.h: Rename include guard.
10950 * target/wait.h: Rename include guard.
10951 * target/target.h: Rename include guard.
10952 * target/resume.h: Rename include guard.
10953 * target-float.h: Rename include guard.
10954 * stabsread.h: Add include guard.
10955 * rs6000-tdep.h: Add include guard.
10956 * riscv-fbsd-tdep.h: Add include guard.
10957 * regformats/regdef.h: Rename include guard.
10958 * record.h: Rename include guard.
10959 * python/python.h: Rename include guard.
10960 * python/python-internal.h: Rename include guard.
10961 * python/py-stopevent.h: Rename include guard.
10962 * python/py-ref.h: Rename include guard.
10963 * python/py-record.h: Rename include guard.
10964 * python/py-record-full.h: Rename include guard.
10965 * python/py-record-btrace.h: Rename include guard.
10966 * python/py-instruction.h: Rename include guard.
10967 * python/py-events.h: Rename include guard.
10968 * python/py-event.h: Rename include guard.
10969 * procfs.h: Add include guard.
10970 * proc-utils.h: Add include guard.
10971 * p-lang.h: Add include guard.
10972 * or1k-tdep.h: Rename include guard.
10973 * observable.h: Rename include guard.
10974 * nto-tdep.h: Rename include guard.
10975 * nat/x86-linux.h: Rename include guard.
10976 * nat/x86-linux-dregs.h: Rename include guard.
10977 * nat/x86-gcc-cpuid.h: Add include guard.
10978 * nat/x86-dregs.h: Rename include guard.
10979 * nat/x86-cpuid.h: Rename include guard.
10980 * nat/ppc-linux.h: Rename include guard.
10981 * nat/mips-linux-watch.h: Rename include guard.
10982 * nat/linux-waitpid.h: Rename include guard.
10983 * nat/linux-ptrace.h: Rename include guard.
10984 * nat/linux-procfs.h: Rename include guard.
10985 * nat/linux-osdata.h: Rename include guard.
10986 * nat/linux-nat.h: Rename include guard.
10987 * nat/linux-namespaces.h: Rename include guard.
10988 * nat/linux-btrace.h: Rename include guard.
10989 * nat/glibc_thread_db.h: Rename include guard.
10990 * nat/gdb_thread_db.h: Rename include guard.
10991 * nat/gdb_ptrace.h: Rename include guard.
10992 * nat/fork-inferior.h: Rename include guard.
10993 * nat/amd64-linux-siginfo.h: Rename include guard.
10994 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10995 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10996 * nat/aarch64-linux.h: Rename include guard.
10997 * nat/aarch64-linux-hw-point.h: Rename include guard.
10998 * mn10300-tdep.h: Add include guard.
10999 * mips-linux-tdep.h: Add include guard.
11000 * mi/mi-parse.h: Rename include guard.
11001 * mi/mi-out.h: Rename include guard.
11002 * mi/mi-main.h: Rename include guard.
11003 * mi/mi-interp.h: Rename include guard.
11004 * mi/mi-getopt.h: Rename include guard.
11005 * mi/mi-console.h: Rename include guard.
11006 * mi/mi-common.h: Rename include guard.
11007 * mi/mi-cmds.h: Rename include guard.
11008 * mi/mi-cmd-break.h: Rename include guard.
11009 * m2-lang.h: Add include guard.
11010 * location.h: Rename include guard.
11011 * linux-record.h: Rename include guard.
11012 * linux-nat.h: Add include guard.
11013 * linux-fork.h: Add include guard.
11014 * i386-darwin-tdep.h: Rename include guard.
11015 * hppa-linux-offsets.h: Add include guard.
11016 * guile/guile.h: Rename include guard.
11017 * guile/guile-internal.h: Rename include guard.
11018 * gnu-nat.h: Rename include guard.
11019 * gdb-stabs.h: Rename include guard.
11020 * frv-tdep.h: Add include guard.
11021 * f-lang.h: Add include guard.
11022 * event-loop.h: Add include guard.
11023 * darwin-nat.h: Rename include guard.
11024 * cp-abi.h: Rename include guard.
11025 * config/sparc/nm-sol2.h: Rename include guard.
11026 * config/nm-nto.h: Rename include guard.
11027 * config/nm-linux.h: Add include guard.
11028 * config/i386/nm-i386gnu.h: Rename include guard.
11029 * config/djgpp/nl_types.h: Rename include guard.
11030 * config/djgpp/langinfo.h: Rename include guard.
11031 * compile/gcc-cp-plugin.h: Add include guard.
11032 * compile/gcc-c-plugin.h: Add include guard.
11033 * compile/compile.h: Rename include guard.
11034 * compile/compile-object-run.h: Rename include guard.
11035 * compile/compile-object-load.h: Rename include guard.
11036 * compile/compile-internal.h: Rename include guard.
11037 * compile/compile-cplus.h: Rename include guard.
11038 * compile/compile-c.h: Rename include guard.
11039 * common/xml-utils.h: Rename include guard.
11040 * common/x86-xstate.h: Rename include guard.
11041 * common/version.h: Rename include guard.
11042 * common/vec.h: Rename include guard.
11043 * common/tdesc.h: Rename include guard.
11044 * common/selftest.h: Rename include guard.
11045 * common/scoped_restore.h: Rename include guard.
11046 * common/scoped_mmap.h: Rename include guard.
11047 * common/scoped_fd.h: Rename include guard.
11048 * common/safe-iterator.h: Rename include guard.
11049 * common/run-time-clock.h: Rename include guard.
11050 * common/refcounted-object.h: Rename include guard.
11051 * common/queue.h: Rename include guard.
11052 * common/ptid.h: Rename include guard.
11053 * common/print-utils.h: Rename include guard.
11054 * common/preprocessor.h: Rename include guard.
11055 * common/pathstuff.h: Rename include guard.
11056 * common/observable.h: Rename include guard.
11057 * common/netstuff.h: Rename include guard.
11058 * common/job-control.h: Rename include guard.
11059 * common/host-defs.h: Rename include guard.
11060 * common/gdb_wait.h: Rename include guard.
11061 * common/gdb_vecs.h: Rename include guard.
11062 * common/gdb_unlinker.h: Rename include guard.
11063 * common/gdb_unique_ptr.h: Rename include guard.
11064 * common/gdb_tilde_expand.h: Rename include guard.
11065 * common/gdb_sys_time.h: Rename include guard.
11066 * common/gdb_string_view.h: Rename include guard.
11067 * common/gdb_splay_tree.h: Rename include guard.
11068 * common/gdb_setjmp.h: Rename include guard.
11069 * common/gdb_ref_ptr.h: Rename include guard.
11070 * common/gdb_optional.h: Rename include guard.
11071 * common/gdb_locale.h: Rename include guard.
11072 * common/gdb_assert.h: Rename include guard.
11073 * common/filtered-iterator.h: Rename include guard.
11074 * common/filestuff.h: Rename include guard.
11075 * common/fileio.h: Rename include guard.
11076 * common/environ.h: Rename include guard.
11077 * common/common-utils.h: Rename include guard.
11078 * common/common-types.h: Rename include guard.
11079 * common/common-regcache.h: Rename include guard.
11080 * common/common-inferior.h: Rename include guard.
11081 * common/common-gdbthread.h: Rename include guard.
11082 * common/common-exceptions.h: Rename include guard.
11083 * common/common-defs.h: Rename include guard.
11084 * common/common-debug.h: Rename include guard.
11085 * common/cleanups.h: Rename include guard.
11086 * common/buffer.h: Rename include guard.
11087 * common/btrace-common.h: Rename include guard.
11088 * common/break-common.h: Rename include guard.
11089 * cli/cli-utils.h: Rename include guard.
11090 * cli/cli-style.h: Rename include guard.
11091 * cli/cli-setshow.h: Rename include guard.
11092 * cli/cli-script.h: Rename include guard.
11093 * cli/cli-interp.h: Rename include guard.
11094 * cli/cli-decode.h: Rename include guard.
11095 * cli/cli-cmds.h: Rename include guard.
11096 * charset-list.h: Add include guard.
11097 * buildsym-legacy.h: Rename include guard.
11098 * bfin-tdep.h: Add include guard.
11099 * ax.h: Rename include guard.
11100 * arm-linux-tdep.h: Add include guard.
11101 * arm-fbsd-tdep.h: Add include guard.
11102 * arch/xtensa.h: Rename include guard.
11103 * arch/tic6x.h: Add include guard.
11104 * arch/i386.h: Add include guard.
11105 * arch/arm.h: Rename include guard.
11106 * arch/arm-linux.h: Rename include guard.
11107 * arch/arm-get-next-pcs.h: Rename include guard.
11108 * arch/amd64.h: Add include guard.
11109 * arch/aarch64-insn.h: Rename include guard.
11110 * arch-utils.h: Rename include guard.
11111 * annotate.h: Add include guard.
11112 * amd64-darwin-tdep.h: Rename include guard.
11113 * aarch64-linux-tdep.h: Add include guard.
11114 * aarch64-fbsd-tdep.h: Add include guard.
11115 * aarch32-linux-nat.h: Add include guard.
11116
ab9268d2
PW
111172019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11118
11119 * macrotab.c (macro_define_internal): New function that
11120 factorizes macro_define_object_internal and macro_define_function
11121 code.
11122 (macro_define_object_internal): Use macro_define_internal.
11123 (macro_define_function): Likewise.
11124
bb0da2b4
PW
111252019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11126
11127 * macrocmd.c (extract_identifier): Return
11128 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11129 callers.
11130
424eb552
JB
111312019-02-06 John Baldwin <jhb@FreeBSD.org>
11132
11133 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11134
1688cb29
TT
111352019-02-05 Tom Tromey <tom@tromey.com>
11136
11137 * target.c (target_stack::unpush): Move assertion earlier.
11138
b5eba2d8
TT
111392019-01-30 Tom Tromey <tom@tromey.com>
11140
11141 PR python/23615:
11142 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11143 (gdbpy_parse_and_eval): Likewise.
11144 * python/python-internal.h (gdbpy_allow_threads): New class.
11145
7054e2ff
JB
111462019-01-28 John Baldwin <jhb@FreeBSD.org>
11147
11148 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11149 (aarch64_fbsd_fpregmap): Move earlier.
11150 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11151 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11152 instead of individual calls to trad_frame_set_reg_addr.
11153 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11154 earlier.
11155 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11156 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11157 instead of individual calls to trad_frame_set_reg_addr.
11158
36c25ffa
AH
111592019-01-28 Alan Hayward <alan.hayward@arm.com>
11160
11161 * CONTRIBUTE: Replace contribution list with wiki link.
11162
a0707f3c
TT
111632019-01-25 Tom Tromey <tom@tromey.com>
11164
11165 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11166
0747795c
TT
111672019-01-25 Tom Tromey <tom@tromey.com>
11168
11169 * xtensa-linux-nat.c: Fix common/ includes.
11170 * xml-support.h: Fix common/ includes.
11171 * xml-support.c: Fix common/ includes.
11172 * x86-linux-nat.c: Fix common/ includes.
11173 * windows-nat.c: Fix common/ includes.
11174 * varobj.h: Fix common/ includes.
11175 * varobj.c: Fix common/ includes.
11176 * value.c: Fix common/ includes.
11177 * valops.c: Fix common/ includes.
11178 * utils.c: Fix common/ includes.
11179 * unittests/xml-utils-selftests.c: Fix common/ includes.
11180 * unittests/utils-selftests.c: Fix common/ includes.
11181 * unittests/unpack-selftests.c: Fix common/ includes.
11182 * unittests/tracepoint-selftests.c: Fix common/ includes.
11183 * unittests/style-selftests.c: Fix common/ includes.
11184 * unittests/string_view-selftests.c: Fix common/ includes.
11185 * unittests/scoped_restore-selftests.c: Fix common/ includes.
11186 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11187 * unittests/scoped_fd-selftests.c: Fix common/ includes.
11188 * unittests/rsp-low-selftests.c: Fix common/ includes.
11189 * unittests/parse-connection-spec-selftests.c: Fix common/
11190 includes.
11191 * unittests/optional-selftests.c: Fix common/ includes.
11192 * unittests/offset-type-selftests.c: Fix common/ includes.
11193 * unittests/observable-selftests.c: Fix common/ includes.
11194 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11195 * unittests/memrange-selftests.c: Fix common/ includes.
11196 * unittests/memory-map-selftests.c: Fix common/ includes.
11197 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11198 * unittests/function-view-selftests.c: Fix common/ includes.
11199 * unittests/environ-selftests.c: Fix common/ includes.
11200 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11201 * unittests/common-utils-selftests.c: Fix common/ includes.
11202 * unittests/cli-utils-selftests.c: Fix common/ includes.
11203 * unittests/array-view-selftests.c: Fix common/ includes.
11204 * ui-file.c: Fix common/ includes.
11205 * tui/tui-io.c: Fix common/ includes.
11206 * tracepoint.h: Fix common/ includes.
11207 * tracepoint.c: Fix common/ includes.
11208 * tracefile-tfile.c: Fix common/ includes.
11209 * top.h: Fix common/ includes.
11210 * top.c: Fix common/ includes.
11211 * thread.c: Fix common/ includes.
11212 * target/waitstatus.h: Fix common/ includes.
11213 * target/waitstatus.c: Fix common/ includes.
11214 * target.h: Fix common/ includes.
11215 * target.c: Fix common/ includes.
11216 * target-memory.c: Fix common/ includes.
11217 * target-descriptions.c: Fix common/ includes.
11218 * symtab.h: Fix common/ includes.
11219 * symfile.c: Fix common/ includes.
11220 * stap-probe.c: Fix common/ includes.
11221 * spu-linux-nat.c: Fix common/ includes.
11222 * sparc-nat.c: Fix common/ includes.
11223 * source.c: Fix common/ includes.
11224 * solib.c: Fix common/ includes.
11225 * solib-target.c: Fix common/ includes.
11226 * ser-unix.c: Fix common/ includes.
11227 * ser-tcp.c: Fix common/ includes.
11228 * ser-pipe.c: Fix common/ includes.
11229 * ser-base.c: Fix common/ includes.
11230 * selftest-arch.c: Fix common/ includes.
11231 * s12z-tdep.c: Fix common/ includes.
11232 * rust-exp.y: Fix common/ includes.
11233 * rs6000-aix-tdep.c: Fix common/ includes.
11234 * riscv-tdep.c: Fix common/ includes.
11235 * remote.c: Fix common/ includes.
11236 * remote-notif.h: Fix common/ includes.
11237 * remote-fileio.h: Fix common/ includes.
11238 * remote-fileio.c: Fix common/ includes.
11239 * regcache.h: Fix common/ includes.
11240 * regcache.c: Fix common/ includes.
11241 * record-btrace.c: Fix common/ includes.
11242 * python/python.c: Fix common/ includes.
11243 * python/py-type.c: Fix common/ includes.
11244 * python/py-inferior.c: Fix common/ includes.
11245 * progspace.h: Fix common/ includes.
11246 * producer.c: Fix common/ includes.
11247 * procfs.c: Fix common/ includes.
11248 * proc-api.c: Fix common/ includes.
11249 * printcmd.c: Fix common/ includes.
11250 * ppc-linux-nat.c: Fix common/ includes.
11251 * parser-defs.h: Fix common/ includes.
11252 * osdata.c: Fix common/ includes.
11253 * obsd-nat.c: Fix common/ includes.
11254 * nat/x86-linux.c: Fix common/ includes.
11255 * nat/x86-linux-dregs.c: Fix common/ includes.
11256 * nat/x86-dregs.h: Fix common/ includes.
11257 * nat/x86-dregs.c: Fix common/ includes.
11258 * nat/ppc-linux.c: Fix common/ includes.
11259 * nat/mips-linux-watch.h: Fix common/ includes.
11260 * nat/mips-linux-watch.c: Fix common/ includes.
11261 * nat/linux-waitpid.c: Fix common/ includes.
11262 * nat/linux-ptrace.h: Fix common/ includes.
11263 * nat/linux-ptrace.c: Fix common/ includes.
11264 * nat/linux-procfs.c: Fix common/ includes.
11265 * nat/linux-personality.c: Fix common/ includes.
11266 * nat/linux-osdata.c: Fix common/ includes.
11267 * nat/linux-namespaces.c: Fix common/ includes.
11268 * nat/linux-btrace.h: Fix common/ includes.
11269 * nat/linux-btrace.c: Fix common/ includes.
11270 * nat/fork-inferior.c: Fix common/ includes.
11271 * nat/amd64-linux-siginfo.c: Fix common/ includes.
11272 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11273 * nat/aarch64-linux.c: Fix common/ includes.
11274 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11275 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11276 * namespace.h: Fix common/ includes.
11277 * mips-linux-tdep.c: Fix common/ includes.
11278 * minsyms.c: Fix common/ includes.
11279 * mi/mi-parse.h: Fix common/ includes.
11280 * mi/mi-main.c: Fix common/ includes.
11281 * mi/mi-cmd-env.c: Fix common/ includes.
11282 * memrange.h: Fix common/ includes.
11283 * memattr.c: Fix common/ includes.
11284 * maint.h: Fix common/ includes.
11285 * maint.c: Fix common/ includes.
11286 * main.c: Fix common/ includes.
11287 * machoread.c: Fix common/ includes.
11288 * location.c: Fix common/ includes.
11289 * linux-thread-db.c: Fix common/ includes.
11290 * linux-nat.c: Fix common/ includes.
11291 * linux-fork.c: Fix common/ includes.
11292 * inline-frame.c: Fix common/ includes.
11293 * infrun.c: Fix common/ includes.
11294 * inflow.c: Fix common/ includes.
11295 * inferior.h: Fix common/ includes.
11296 * inferior.c: Fix common/ includes.
11297 * infcmd.c: Fix common/ includes.
11298 * inf-ptrace.c: Fix common/ includes.
11299 * inf-child.c: Fix common/ includes.
11300 * ia64-linux-nat.c: Fix common/ includes.
11301 * i387-tdep.c: Fix common/ includes.
11302 * i386-tdep.c: Fix common/ includes.
11303 * i386-linux-tdep.c: Fix common/ includes.
11304 * i386-linux-nat.c: Fix common/ includes.
11305 * i386-go32-tdep.c: Fix common/ includes.
11306 * i386-fbsd-tdep.c: Fix common/ includes.
11307 * i386-fbsd-nat.c: Fix common/ includes.
11308 * guile/scm-type.c: Fix common/ includes.
11309 * guile/guile.c: Fix common/ includes.
11310 * go32-nat.c: Fix common/ includes.
11311 * gnu-nat.c: Fix common/ includes.
11312 * gdbthread.h: Fix common/ includes.
11313 * gdbarch-selftests.c: Fix common/ includes.
11314 * gdb_usleep.c: Fix common/ includes.
11315 * gdb_select.h: Fix common/ includes.
11316 * gdb_bfd.c: Fix common/ includes.
11317 * gcore.c: Fix common/ includes.
11318 * fork-child.c: Fix common/ includes.
11319 * findvar.c: Fix common/ includes.
11320 * fbsd-nat.c: Fix common/ includes.
11321 * event-top.c: Fix common/ includes.
11322 * event-loop.c: Fix common/ includes.
11323 * dwarf2read.c: Fix common/ includes.
11324 * dwarf2loc.c: Fix common/ includes.
11325 * dwarf2-frame.c: Fix common/ includes.
11326 * dwarf-index-cache.c: Fix common/ includes.
11327 * dtrace-probe.c: Fix common/ includes.
11328 * disasm-selftests.c: Fix common/ includes.
11329 * defs.h: Fix common/ includes.
11330 * csky-tdep.c: Fix common/ includes.
11331 * cp-valprint.c: Fix common/ includes.
11332 * cp-support.h: Fix common/ includes.
11333 * cp-support.c: Fix common/ includes.
11334 * corelow.c: Fix common/ includes.
11335 * completer.h: Fix common/ includes.
11336 * completer.c: Fix common/ includes.
11337 * compile/compile.c: Fix common/ includes.
11338 * compile/compile-loc2c.c: Fix common/ includes.
11339 * compile/compile-cplus-types.c: Fix common/ includes.
11340 * compile/compile-cplus-symbols.c: Fix common/ includes.
11341 * command.h: Fix common/ includes.
11342 * cli/cli-dump.c: Fix common/ includes.
11343 * cli/cli-cmds.c: Fix common/ includes.
11344 * charset.c: Fix common/ includes.
11345 * build-id.c: Fix common/ includes.
11346 * btrace.h: Fix common/ includes.
11347 * btrace.c: Fix common/ includes.
11348 * breakpoint.h: Fix common/ includes.
11349 * breakpoint.c: Fix common/ includes.
11350 * ax.h:
11351 (enum agent_op): Fix common/ includes.
11352 * ax-general.c (struct aop_map): Fix common/ includes.
11353 * ax-gdb.c: Fix common/ includes.
11354 * auxv.c: Fix common/ includes.
11355 * auto-load.c: Fix common/ includes.
11356 * arm-tdep.c: Fix common/ includes.
11357 * arch/riscv.c: Fix common/ includes.
11358 * arch/ppc-linux-common.c: Fix common/ includes.
11359 * arch/i386.c: Fix common/ includes.
11360 * arch/arm.c: Fix common/ includes.
11361 * arch/arm-linux.c: Fix common/ includes.
11362 * arch/arm-get-next-pcs.c: Fix common/ includes.
11363 * arch/amd64.c: Fix common/ includes.
11364 * arch/aarch64.c: Fix common/ includes.
11365 * arch/aarch64-insn.c: Fix common/ includes.
11366 * arch-utils.c: Fix common/ includes.
11367 * amd64-windows-tdep.c: Fix common/ includes.
11368 * amd64-tdep.c: Fix common/ includes.
11369 * amd64-sol2-tdep.c: Fix common/ includes.
11370 * amd64-obsd-tdep.c: Fix common/ includes.
11371 * amd64-nbsd-tdep.c: Fix common/ includes.
11372 * amd64-linux-tdep.c: Fix common/ includes.
11373 * amd64-linux-nat.c: Fix common/ includes.
11374 * amd64-fbsd-tdep.c: Fix common/ includes.
11375 * amd64-fbsd-nat.c: Fix common/ includes.
11376 * amd64-dicos-tdep.c: Fix common/ includes.
11377 * amd64-darwin-tdep.c: Fix common/ includes.
11378 * agent.c: Fix common/ includes.
11379 * ada-lang.h: Fix common/ includes.
11380 * ada-lang.c: Fix common/ includes.
11381 * aarch64-tdep.c: Fix common/ includes.
11382
2f5c153e
TT
113832019-01-25 Tom Tromey <tom@tromey.com>
11384
11385 * common/create-version.sh: Use common/version.h.
11386
adc6a863
PA
113872019-01-24 Pedro Alves <palves@redhat.com>
11388
11389 * infrun.c (signal_stop, signal_print, signal_program)
11390 (signal_catch, signal_pass): Now arrays instead of pointers.
11391 (update_signals_program_target, do_target_resume)
11392 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11393 * linux-nat.c (linux_nat_target::pass_signals)
11394 (linux_nat_target::create_inferior, linux_nat_target::attach):
11395 Adjust.
11396 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11397 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11398 * procfs.c (procfs_target::pass_signals): Adjust.
11399 * record-full.c (record_full_target::resume): Adjust.
11400 * remote.c (remote_target::pass_signals)
11401 (remote_target::program_signals): Adjust.
11402 * target-debug.h (target_debug_print_signals): Now takes a
11403 gdb::array_view as parameter. Adjust.
11404 * target.h (target_ops) <pass_signals, program_signals>: Replace
11405 pointer and length parameters with gdb::array_view.
11406 (target_pass_signals, target_program_signals): Likewise.
11407 * target-delegates.c: Regenerate.
11408
3046d67a
PA
114092019-01-24 Pedro Alves <palves@redhat.com>
11410
11411 * common/forward-scope-exit.h
11412 (forward_scope_exit::forward_scope_exit): Pass arguments to
11413 m_bind_function directly, instead of creating a std::bind and
11414 copying that.
11415
353229bf
AH
114162019-01-24 Alan Hayward <alan.hayward@arm.com>
11417
11418 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11419 for static members.
11420 (pass_in_v_vfp_candidate): Likewise.
11421
311dc83a
TT
114222019-01-23 Tom Tromey <tom@tromey.com>
11423 Pedro Alves <palves@redhat.com>
11424
11425 * regcache.c (class regcache_invalidator): Remove.
11426 (regcache::raw_write): Use make_scope_exit.
11427
296bd123
TT
114282019-01-23 Tom Tromey <tom@tromey.com>
11429
11430 * ui-out.h (class ui_out_emit_type): Update comment.
11431
979a0d13
TT
114322019-01-23 Tom Tromey <tom@tromey.com>
11433
11434 * infrun.c (fetch_inferior_event): Update comment.
11435
d238133d
TT
114362019-01-23 Tom Tromey <tom@tromey.com>
11437 Pedro Alves <palves@redhat.com>
11438
11439 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11440 parameter.
11441 (fetch_inferior_event): Use SCOPE_EXIT.
11442
11443
9885e6bb
TT
114442019-01-23 Tom Tromey <tom@tromey.com>
11445 Pedro Alves <palves@redhat.com>
11446
11447 * infrun.c (disable_thread_events): Delete.
11448 (stop_all_threads): Use SCOPE_EXIT.
11449
286526c1
TT
114502019-01-23 Tom Tromey <tom@tromey.com>
11451 Pedro Alves <palves@redhat.com>
11452
11453 * symfile.c: Include forward-scope-exit.h.
11454 (clear_symtab_users_cleanup): Replace forward declaration with
11455 a FORWARD_SCOPE_EXIT.
11456 (syms_from_objfile_1): Use the forward_scope_exit and
11457 gdb::optional instead of cleanup_function.
11458 (reread_symbols): Use the forward_scope_exit instead of
11459 cleanup_function.
11460 (clear_symtab_users_cleanup): Remove function.
11461
1db93f14
TT
114622019-01-23 Tom Tromey <tom@tromey.com>
11463 Pedro Alves <palves@redhat.com>
11464
11465 * linux-nat.c: Include scope-exit.h.
11466 (cleanup_target_stop): Remove.
11467 (linux_nat_target::static_tracepoint_markers_by_strid): Use
11468 SCOPE_EXIT.
11469
2cc83d1e
TT
114702019-01-23 Tom Tromey <tom@tromey.com>
11471 Pedro Alves <palves@redhat.com>
11472
11473 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11474 (call_function_by_hand_dummy): Use SCOPE_EXIT.
11475
694c6bf5
TT
114762019-01-23 Tom Tromey <tom@tromey.com>
11477 Andrew Burgess <andrew.burgess@embecosm.com>
11478 Pedro Alves <palves@redhat.com>
11479
11480 * infrun.c (fetch_inferior_event): Use scope_exit.
11481 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11482 * top.c (execute_command): Use scope_exit.
11483 * breakpoint.c (bpstat_do_actions): Use scope_exit.
11484 * utils.c (do_bpstat_clear_actions_cleanup)
11485 (make_bpstat_clear_actions_cleanup): Remove.
11486
4c41382a
TT
114872019-01-23 Tom Tromey <tom@tromey.com>
11488 Pedro Alves <palves@redhat.com>
11489
11490 * infrun.c: Include "common/scope-exit.h"
11491 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11492 (wait_for_inferior): Use SCOPE_EXIT.
11493 (fetch_inferior_event): Use scope_exit.
11494
89f8fb50
TT
114952019-01-23 Tom Tromey <tom@tromey.com>
11496 Pedro Alves <palves@redhat.com>
11497
11498 * breakpoint.c (create_breakpoint): Remove cleanup.
11499
5419bdae
TT
115002019-01-23 Tom Tromey <tom@tromey.com>
11501 Andrew Burgess <andrew.burgess@embecosm.com>
11502 Pedro Alves <palves@redhat.com>
11503
e587ef42
PA
115042019-01-23 Pedro Alves <palves@redhat.com>
11505
11506 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11507
77f0e74c
PA
115082019-01-23 Pedro Alves <palves@redhat.com>
11509 Andrew Burgess <andrew.burgess@embecosm.com>
11510
11511 * gdbthread.h: Include "common/forward-scope-exit.h".
11512 (scoped_finish_thread_state): Redefine custom class in terms of
11513 forward_scope_exit.
11514
5b9b3e53
PA
115152019-01-23 Pedro Alves <palves@redhat.com>
11516 Andrew Burgess <andrew.burgess@embecosm.com>
11517
11518 * common/forward-scope-exit.h: New file.
11519
54b65c9b
PA
115202019-01-23 Pedro Alves <palves@redhat.com>
11521 Andrew Burgess <andrew.burgess@embecosm.com>
11522 Tom Tromey <tom@tromey.com>
11523
11524 * common/scope-exit.h: New file.
11525
cf08fb29
PA
115262019-01-23 Pedro Alves <palves@redhat.com>
11527
11528 * common/preprocessor.h (ESC): Rename to ...
11529 (ESC_PARENS): ... this.
11530 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11531 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11532
ae73e2e2
TT
115332019-01-23 Tom Tromey <tom@tromey.com>
11534
11535 * language.h (class scoped_switch_to_sym_language_if_auto):
11536 Initialize m_lang in both cases.
11537
6594e122
AH
115382019-01-23 Alan Hayward <alan.hayward@arm.com>
11539
11540 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11541 with XCNEW.
11542
a7c9855d
TT
115432019-01-22 Tom Tromey <tom@tromey.com>
11544
11545 * corelow.c: Do not include sys/file.h.
11546
93cc1d53
TT
115472019-01-22 Tom Tromey <tom@tromey.com>
11548
11549 * tui/tui-wingeneral.h: Include gdb_curses.h.
11550
38561778
TT
115512019-01-22 Tom Tromey <tom@tromey.com>
11552
11553 * source-cache.h (class source_cache) <get_source_lines,
11554 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11555
37b3ab5b
TT
115562019-01-22 Tom Tromey <tom@tromey.com>
11557
11558 * remote-fileio.h (struct remote_target): Declare.
11559
3fabc016
TT
115602019-01-22 Tom Tromey <tom@tromey.com>
11561
11562 * python/py-arch.c: Do not include py-ref.h.
11563 * python/py-bpevent.c: Do not include py-ref.h.
11564 * python/py-cmd.c: Do not include py-ref.h.
11565 * python/py-continueevent.c: Do not include py-ref.h.
11566 * python/py-event.h: Do not include py-ref.h.
11567 * python/py-evtregistry.c: Do not include py-ref.h.
11568 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11569 * python/py-frame.c: Do not include py-ref.h.
11570 * python/py-framefilter.c: Do not include py-ref.h.
11571 * python/py-function.c: Do not include py-ref.h.
11572 * python/py-infevents.c: Do not include py-ref.h.
11573 * python/py-linetable.c: Do not include py-ref.h.
11574 * python/py-objfile.c: Do not include py-ref.h.
11575 * python/py-param.c: Do not include py-ref.h.
11576 * python/py-prettyprint.c: Do not include py-ref.h.
11577 * python/py-progspace.c: Do not include py-ref.h.
11578 * python/py-symbol.c: Do not include py-ref.h.
11579 * python/py-symtab.c: Do not include py-ref.h.
11580 * python/py-type.c: Do not include py-ref.h.
11581 * python/py-unwind.c: Do not include py-ref.h.
11582 * python/py-utils.c: Do not include py-ref.h.
11583 * python/py-value.c: Do not include py-ref.h.
11584 * python/py-varobj.c: Do not include py-ref.h.
11585 * python/py-xmethods.c: Do not include py-ref.h.
11586 * python/python.c: Do not include py-ref.h.
11587 * varobj.c: Do not include py-ref.h.
11588
6b4d7774
TT
115892019-01-22 Tom Tromey <tom@tromey.com>
11590
11591 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11592 keyword for bcache.
11593
7af7e9b5
TT
115942019-01-22 Tom Tromey <tom@tromey.com>
11595
11596 * compile/compile-cplus-types.c: Remove a comment by #include.
11597
951d1049
TT
115982019-01-22 Tom Tromey <tom@tromey.com>
11599
11600 * compile/gcc-c-plugin.h: Include compile-internal.h.
11601
d65d5705
TT
116022019-01-22 Tom Tromey <tom@tromey.com>
11603
11604 * stabsread.c (EXTERN): Do not define.
11605 (symnum, next_symbol_text_func, processing_gcc_compilation)
11606 (within_function, global_sym_chain, global_stabs)
11607 (previous_stab_code, this_object_header_files)
11608 (n_this_object_header_files)
11609 (n_allocated_this_object_header_files): Define.
11610 * stabsread.h (EXTERN): Never define. Use "extern".
11611
b6fb1ee5
PW
116122019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11613
11614 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11615 history_value.
11616
be6d4f74
TT
116172019-01-21 Tom Tromey <tom@tromey.com>
11618
11619 * ui-out.c: Fix includes.
11620 * tui/tui-source.c: Fix includes.
11621 * target.c: Fix includes.
11622 * remote.c: Fix includes.
11623 * regcache.c: Fix includes.
11624 * python/py-block.c: Fix includes.
11625 * printcmd.c: Fix includes.
11626 * or1k-tdep.c: Fix includes.
11627 * mi/mi-main.c: Fix includes.
11628 * m32r-tdep.c: Fix includes.
11629 * csky-tdep.c: Fix includes.
11630 * compile/compile-cplus-types.c: Fix includes.
11631 * cli/cli-interp.c: Fix includes.
11632
73021deb
AH
116332019-01-21 Alan Hayward <alan.hayward@arm.com>
11634
11635 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11636 for padding.
11637
7932255d
TT
116382019-01-16 Tom Tromey <tom@tromey.com>
11639
11640 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11641 earlier.
11642 (struct objfile) <msymbols_range>: Move from top level.
11643 <msymbols>: New method.
11644 (class objfile_msymbols): Remove.
11645 * symtab.c (default_collect_symbol_completion_matches_break_on):
11646 Update.
11647 * symmisc.c (dump_msymbols): Update.
11648 * stabsread.c (scan_file_globals): Update.
11649 * objc-lang.c (info_selectors_command, info_classes_command)
11650 (find_methods): Update.
11651 * minsyms.c (find_solib_trampoline_target): Update.
11652 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11653 * coffread.c (coff_symfile_read): Update.
11654 * ada-lang.c (ada_lookup_simple_minsym)
11655 (ada_collect_symbol_completion_matches): Update.
11656
604b1bfb
TT
116572019-01-16 Tom Tromey <tom@tromey.com>
11658
11659 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11660 type. Remove no-argument constructor.
11661 <iterator::operator++>: Simplify.
11662 <begin>: Update.
11663 <end>: Use minimal_symbol_count.
11664
f252c6d5
TT
116652019-01-16 Tom Tromey <tom@tromey.com>
11666
11667 * objfiles.h (struct objfile) <psymtabs>: New method.
11668 (class objfile_psymtabs): Remove.
11669 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11670 typedef.
11671 <range>: New method.
11672 (require_partial_symbols): Change return type.
11673 * psymtab.c (require_partial_symbols)
11674 (psym_expand_symtabs_matching): Update.
11675 * mdebugread.c (parse_partial_symbols): Update.
11676 * dbxread.c (dbx_end_psymtab): Update.
11677
b669c953
TT
116782019-01-15 Tom Tromey <tom@tromey.com>
11679
11680 * symtab.c (lookup_objfile_from_block)
11681 (lookup_symbol_in_objfile_symtabs)
11682 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11683 (find_line_symtab, info_sources_command)
11684 (default_collect_symbol_completion_matches_break_on)
11685 (make_source_files_completion_list): Update.
11686 * symmisc.c (print_objfile_statistics, dump_objfile)
11687 (maintenance_print_symbols, maintenance_info_symtabs)
11688 (maintenance_check_symtabs, maintenance_info_line_tables):
11689 Update.
11690 * source.c (select_source_symtab)
11691 (forget_cached_source_info_for_objfile): Update.
11692 * objfiles.h (class objfile_compunits): Remove.
11693 (struct objfile) <compunits_range>: New typedef.
11694 (compunits): New method.
11695 * objfiles.c (objfile_relocate1): Update.
11696 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11697 * maint.c (count_symtabs_and_blocks): Update.
11698 * linespec.c (iterate_over_all_matching_symtabs): Update.
11699 * cp-support.c (add_symbol_overload_list_qualified): Update.
11700 * coffread.c (coff_symtab_read): Update.
11701 * ada-lang.c (add_nonlocal_symbols)
11702 (ada_collect_symbol_completion_matches)
11703 (ada_add_global_exceptions): Update.
11704
7e955d83
TT
117052019-01-15 Tom Tromey <tom@tromey.com>
11706
11707 * progspace.h (program_space) <objfiles_safe_range>: New
11708 typedef.
11709 <objfiles_safe>: New method.
11710 * objfiles.h (class all_objfiles_safe): Remove.
11711 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11712 * jit.c (jit_inferior_exit_hook): Update.
11713
2030c079
TT
117142019-01-17 Tom Tromey <tom@tromey.com>
11715
11716 * progspace.h (program_space) <objfiles_range>: New typedef.
11717 <objfiles>: New method.
11718 <objfiles_head>: Rename from objfiles.
11719 (object_files): Update.
11720 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11721 * guile/scm-pretty-print.c
11722 (ppscm_find_pretty_printer_from_objfiles): Update.
11723 * guile/scm-objfile.c (gdbscm_objfiles): Update.
11724 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11725 Update.
11726 * python/py-progspace.c (pspy_get_objfiles): Update.
11727 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11728 Update.
11729 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11730 (objfpy_lookup_objfile_by_build_id): Update.
11731 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11732 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11733 Update.
11734 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11735 (expand_symtab_containing_pc, lookup_objfile_from_block)
11736 (lookup_static_symbol, basic_lookup_transparent_type)
11737 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11738 (find_line_symtab, info_sources_command)
11739 (default_collect_symbol_completion_matches_break_on)
11740 (make_source_files_completion_list, find_main_name): Update.
11741 * symmisc.c (print_symbol_bcache_statistics)
11742 (print_objfile_statistics, maintenance_print_symbols)
11743 (maintenance_print_msymbols, maintenance_print_objfiles)
11744 (maintenance_info_symtabs, maintenance_check_symtabs)
11745 (maintenance_expand_symtabs, maintenance_info_line_tables):
11746 Update.
11747 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11748 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11749 (map_overlay_command, unmap_overlay_command)
11750 (simple_overlay_update, expand_symtabs_matching)
11751 (map_symbol_filenames): Update.
11752 * symfile-debug.c (set_debug_symfile): Update.
11753 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11754 Update.
11755 * source.c (select_source_symtab, forget_cached_source_info):
11756 Update.
11757 * solib.c (solib_read_symbols): Update.
11758 * solib-spu.c (append_ocl_sos): Update.
11759 * psymtab.c (maintenance_print_psymbols)
11760 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11761 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11762 * printcmd.c (info_symbol_command): Update.
11763 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11764 Update.
11765 * objfiles.h (class all_objfiles): Remove.
11766 * objfiles.c (have_partial_symbols, have_full_symbols)
11767 (have_minimal_symbols, qsort_cmp, update_section_map)
11768 (shared_objfile_contains_address_p)
11769 (default_iterate_over_objfiles_in_search_order): Update.
11770 * objc-lang.c (info_selectors_command, info_classes_command)
11771 (find_methods): Update.
11772 * minsyms.c (find_solib_trampoline_target): Update.
11773 * maint.c (maintenance_info_sections)
11774 (maintenance_translate_address, count_symtabs_and_blocks):
11775 Update.
11776 * main.c (captured_main_1): Update.
11777 * linux-thread-db.c (try_thread_db_load_from_pdir)
11778 (has_libpthread): Update.
11779 * linespec.c (iterate_over_all_matching_symtabs)
11780 (search_minsyms_for_name): Update.
11781 * jit.c (jit_find_objf_with_entry_addr): Update.
11782 * hppa-tdep.c (find_unwind_entry)
11783 (hppa_lookup_stub_minimal_symbol): Update.
11784 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11785 Update.
11786 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11787 (elf_gnu_ifunc_resolve_by_got): Update.
11788 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11789 * dwarf-index-write.c (save_gdb_index_command): Update.
11790 * cp-support.c (add_symbol_overload_list_qualified): Update.
11791 * breakpoint.c (create_overlay_event_breakpoint)
11792 (create_longjmp_master_breakpoint)
11793 (create_std_terminate_master_breakpoint)
11794 (create_exception_master_breakpoint): Update.
11795 * blockframe.c (find_pc_partial_function): Update.
11796 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11797 (ada_collect_symbol_completion_matches)
11798 (ada_add_global_exceptions): Update.
11799
776489e0
TT
118002019-01-17 Tom Tromey <tom@tromey.com>
11801
11802 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11803 declare VEC.
11804 (solib_target_parse_libraries): Change return type.
11805 (library_list_start_segment, library_list_start_section)
11806 (library_list_end_library, library_list_start_library); Update.
11807 (solib_target_free_library_list): Remove.
11808 (solib_target_parse_libraries): Remove cleanup. Change return
11809 type.
11810 (solib_target_current_sos): Update.
11811
6471e7d2
TT
118122019-01-17 Tom Tromey <tromey@bapiya>
11813
11814 * valprint.c: Replace "the the" with "the".
11815 * symtab.c: Replace "the the" with "the".
11816 * solib.c: Replace "the the" with "the".
11817 * solib-dsbt.c: Replace "the the" with "the".
11818 * linespec.c: Replace "the the" with "the".
11819 * dwarf2loc.h: Replace "the the" with "the".
11820 * amd64-windows-tdep.c: Replace "the the" with "the".
11821 * aarch64-tdep.c: Replace "the the" with "the".
11822
c24bdb02
KS
118232019-01-16 Keith Seitz <keiths@redhat.com>
11824
11825 PR gdb/23773
11826 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11827 <builder>: Rename to ..
11828 <m_builder>: ... this and make private.
11829 (dwarf2_cu::get_builder): New method. Change all users of
11830 `builder' to use this method.
11831 (dwarf2_start_symtab): Move to ...
11832 (dwarf2_cu::start_symtab): ... here. Update all callers
11833 (setup_type_unit_groups): Move to ...
11834 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11835 callers.
11836 (dwarf2_cu::reset_builder): New method.
11837 (process_full_compunit, process_full_type_unit): Use
11838 dwarf2_cu::reset_builder.
11839 (follow_die_offset): Record the ancestor CU if it is different
11840 from the followed DIE's CU.
11841 (follow_die_sig_1): Likewise.
11842
8d64371b
TT
118432019-01-15 Tom Tromey <tom@tromey.com>
11844
11845 * remote.c (class remote_state) <buf>: Now a char_vector.
11846 <buf_size>: Remove.
11847 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11848 parameter.
11849 (remote_target::getpkt_or_notif_sane_1)
11850 (remote_target::getpkt_sane)
11851 (remote_target::getpkt_or_notif_sane): Likewise.
11852 (class remote_target) <putpkt>: New overload.
11853 (remote_target::read_frame): Change type of "buf_p". Remove
11854 sizeof_p parameter.
11855 (packet_ok): New overload.
11856 (packet_check_result): New overload.
11857 Update all uses.
11858
bb277751
TT
118592019-01-14 Tom Tromey <tom@tromey.com>
11860
11861 * remote-notif.c (handle_notification, remote_notif_ack)
11862 (remote_notif_parse): Make "buf" const.
11863 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11864 const.
11865 (remote_notif_parse, remote_notif_ack, handle_notification):
11866 Likewise.
11867 * remote.c (remote_notif_stop_parse): Make "buf" const.
11868 (remote_target::remote_parse_stop_reply): Make "buf" const.
11869 (remote_notif_stop_ack): Make "buf" const.
11870
05be00a8
TT
118712019-01-14 Tom Tromey <tom@tromey.com>
11872
11873 * remote.c (remote_console_output): Make parameter const.
11874
491adeca
TT
118752019-01-14 Tom Tromey <tom@tromey.com>
11876
11877 * target-debug.h (target_debug_print_signals): Constify.
11878 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11879 * procfs.c (procfs_target::pass_signals): Update.
11880 * linux-nat.c (linux_nat_target::pass_signals): Update.
11881 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11882 * target-delegates.c: Rebuild.
11883 * remote.c (remote_target::program_signals): Update.
11884 (remote_target::pass_signals): Update.
11885 * target.c (target_pass_signals): Constify argument.
11886 (target_program_signals): Likewise.
11887 * target.h (struct target_ops) <pass_signals, program_signals>:
11888 Constify argument.
11889 (target_pass_signals, target_program_signals): Constify argument.
11890
bbd94648
TT
118912019-01-14 Tom Tromey <tom@tromey.com>
11892
11893 PR tui/28819:
11894 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11895
6f072a10
PFC
118962019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11897
11898 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11899 field.
11900 * rs6000-tdep.c: Include reggroups.h.
11901 (IS_V_ALIAS_PSEUDOREG): Define.
11902 (rs6000_register_name): Return names for the "vX" aliases.
11903 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11904 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11905 aliases. Call default_register_reggroup_p for all other
11906 pseudo-registers.
11907 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11908 New functions.
11909 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11910 Handle "vX" aliases.
11911 (v_alias_pseudo_register_collect): New function.
11912 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11913 (rs6000_gdbarch_init): Initialize "vX" aliases as
11914 pseudo-registers. Restore registration of
11915 rs6000_pseudo_register_reggroup_p with
11916 set_tdesc_pseudo_register_reggroup_p.
11917
1a782351
MF
119182019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11919
11920 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11921 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11922 set_gdbarch_num_pseudo_regs.
11923
d73cff18
PW
119242019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11925
11926 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11927 Remove arg prefixname, add do_set and do_show.
11928 Add member functions set_list and show_list.
11929 * cli/cli-style.c (class cli_style_option): Update accordingly.
11930 (style_set_list): Move to file scope.
11931 (style_show_list): Likewise.
11932 (set_style): Call help_list.
11933 (show_style): Call cmd_show_list.
11934 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11935 Update to use the new macro.
11936
60a90376
JB
119372019-10-12 Joel Brobecker <brobecker@adacore.com>
11938
11939 * ada-lang.c (_initialize_ada_language): Expand the help text
11940 for the "catch exception" command.
11941
9d7c67bf
PW
119422019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11943
11944 * symtab.c (matching_obj_sections): Initialize obj,
11945 declare it closer to its usage.
11946
7cf47dc4
TT
119472019-01-10 Tom Tromey <tom@tromey.com>
11948
11949 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11950 (basic_inf_threads_range): Remove.
11951 (inf_threads_range, inf_non_exited_threads_range)
11952 (safe_inf_threads_range): Use next_adapter.
11953
d3cb6808
KS
119542019-01-10 Keith Seitz <keiths@redhat.com>
11955
11956 PR gdb/23712
11957 PR symtab/23010
11958 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11959 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11960
63a20375
KS
119612019-01-10 Keith Seitz <keiths@redhat.com>
11962
11963 PR gdb/23712
11964 PR symtab/23010
11965 * dictionary.c (pending_to_vector): Remove.
11966 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11967 Remove _1 suffix, replacing functions of the same name. Update
11968 all callers.
11969 (dict_create_hashed, dict_create_hashed_expandable)
11970 (dict_create_linear, dict_create_linear_expandable, dict_free)
11971 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11972 Make functions static.
11973
b026f593
KS
119742019-01-10 Keith Seitz <keiths@redhat.com>
11975
11976 PR gdb/23712
11977 PR symtab/23010
11978 * dictionary.h (struct dictionary): Replace declaration with
11979 multidictionary.
11980 (dict_create_hashed, dict_create_hashed_expandable)
11981 (dict_create_linear, dict_create_linear_expandable)
11982 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11983 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11984 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11985 taking multidictionary argument.
11986 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11987 * block.h (struct block) <dict>: Change to multidictionary
11988 and rename `multidict'.
11989 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11990 symmisc.c: Update all dictionary references to multidictionary.
11991
c7748ee9
KS
119922019-01-10 Keith Seitz <keiths@redhat.com>
11993
11994 PR gdb/23712
11995 PR symtab/23010
11996 * dictionary.c: Include unordered_map.
11997 (pending_to_vector): New function.
11998 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11999 Rewrite the non-"_1" functions to take vector instead
12000 of linked list.
12001 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12002 "new" _1 versions of the same name.
12003 (multidictionary): Define.
12004 (std::hash<enum language): New definition.
12005 (collate_pending_symbols_by_language, mdict_create_hashed)
12006 (mdict_create_hashed_expandable, mdict_create_linear)
12007 (mdict_create_linear_expandable, mdict_free)
12008 (find_language_dictionary, create_new_language_dictionary)
12009 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12010 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12011 (mdict_size, mdict_empty): New functions.
12012 * dictionary.h (mdict_iterator): Define.
12013
67aa1f3c
PA
120142019-01-10 Pedro Alves <palves@redhat.com>
12015
12016 * breakpoint.c (read_uploaded_action)
12017 (create_tracepoint_from_upload): Adjust to use
12018 gdb::unique_xmalloc_ptr.
12019 * ctf.c (ctf_write_uploaded_tp):
12020 (SET_ARRAY_FIELD): Use emplace_back.
12021 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12022 * tracefile-tfile.c (tfile_write_uploaded_tp):
12023 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12024 gdb::unique_xmalloc_ptr.
12025 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12026 at_string, cond_string, cmd_strings>: Replace char pointers
12027 with gdb::unique_xmalloc_ptr.
12028
2f667667
PA
120292019-01-10 Pedro Alves <palves@redhat.com>
12030
12031 * solib-target.c (library_list_start_library): Don't xstrdup name.
12032
36cb7237
PA
120332019-01-10 Pedro Alves <palves@redhat.com>
12034
12035 * mdebugread.c (parse_partial_symbols): Use
12036 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12037
da584958
AB
120382019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12039
12040 * linux-fork.c (scoped_switch_fork_info)
12041 <~scoped_switch_fork_info>: Fix incorrect variable name.
12042
1ef8573c
AB
120432019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12044
12045 * linux-fork.c (scoped_switch_fork_info)
12046 <scoped_switch_fork_info>: Make explicit.
12047 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12048
8d7bcccb
TT
120492019-01-10 Tom Tromey <tom@tromey.com>
12050
12051 * objfiles.h (objfile::reset_psymtabs): Update.
12052 * objfiles.c (objfile::objfile): Update.
12053 * psymtab.h (psymtab_storage::obstack): Update.
12054 (psymtab_storage::m_obstack): Use gdb::optional.
12055 (class psymtab_storage): Update comment. Remove objfile
12056 parameter.
12057 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12058
b596a3c7
TT
120592019-01-10 Tom Tromey <tom@tromey.com>
12060
12061 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12062 <free_psymtabs>: Now private.
12063 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12064 (allocate_psymtab): Use new method.
12065
a9342b62
TT
120662019-01-10 Tom Tromey <tom@tromey.com>
12067
12068 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12069 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12070 * mdebugread.c (parse_partial_symbols): Use
12071 allocate_dependencies.
12072 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12073 allocate_dependencies.
12074 (process_psymtab_comp_unit_reader)
12075 (build_type_psymtab_dependencies): Likewise.
12076 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12077
5af70966
TT
120782019-01-10 Tom Tromey <tom@tromey.com>
12079
12080 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12081 PSYMBOL_SET_LANGUAGE.
12082 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12083
5923a04c
TT
120842019-01-10 Tom Tromey <tom@tromey.com>
12085
12086 * psymtab.h (psymtab_storage::obstack): New method.
12087 <m_obstack>: Rename from obstack; now private.
12088 * psymtab.c (psymtab_storage): Update.
12089 * dwarf2read.c (create_addrmap_from_index)
12090 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12091 Update.
12092
6d6a12bf
TT
120932019-01-10 Tom Tromey <tom@tromey.com>
12094
12095 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12096 * objfiles.h (objfile::reset_psymtabs): New method.
12097
d320c2b5
TT
120982019-01-10 Tom Tromey <tom@tromey.com>
12099
12100 * symmisc.c (print_symbol_bcache_statistics): Update.
12101 (print_objfile_statistics): Update.
12102 * symfile.c (reread_symbols): Update.
12103 * psymtab.h (class psymtab_storage): New.
12104 * psymtab.c (psymtab_storage): New constructor.
12105 (~psymtab_storage): New destructor.
12106 (require_partial_symbols): Update.
12107 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12108 (find_pc_sect_psymtab, find_pc_sect_psymbol)
12109 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12110 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12111 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12112 (start_psymtab_common, end_psymtab_common)
12113 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12114 (allocate_psymtab): Update.
12115 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12116 Update.
12117 (dump_psymtab_addrmap, maintenance_print_psymbols)
12118 (maintenance_check_psymtabs): Update.
12119 (class objfile_psymtabs): Move to objfiles.h.
12120 * psympriv.h (discard_psymtab): Now inline.
12121 (psymtab_discarder::psymtab_discarder): Update.
12122 (psymtab_discarder::~psymtab_discarder): Update.
12123 (ALL_OBJFILE_PSYMTABS): Rewrite.
12124 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12125 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12126 Remove fields.
12127 <partial_symtabs>: New field.
12128 (class objfile_psymtabs): Move from psymtab.h. Update.
12129 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12130 psymbol_cache.
12131 (objfile::~objfile): Don't destroy psymbol_cache.
12132 * mdebugread.c (parse_partial_symbols): Update.
12133 * dwarf2read.c (create_addrmap_from_index)
12134 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12135 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12136 (add_partial_subprogram, dwarf2_ranges_read): Update.
12137 * dwarf-index-write.c (write_address_map)
12138 (write_one_signatured_type, recursively_write_psymbols)
12139 (class debug_names, class debug_names, write_psymtabs_to_index):
12140 Update.
12141
1d94a5a3
TT
121422019-01-10 Tom Tromey <tom@tromey.com>
12143
12144 * symtab.h (SYMBOL_SET_NAMES): Update.
12145 (symbol_set_names): Update.
12146 (MSYMBOL_SET_NAMES): Update.
12147 * symtab.c (symbol_set_names): Change argument to be an
12148 objfile_per_bfd_storage.
12149 * psymtab.c (add_psymbol_to_bcache): Update.
12150 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12151
0f14768a
TT
121522019-01-10 Tom Tromey <tom@tromey.com>
12153
12154 * symtab.c (create_demangled_names_hash): Change argument to be an
12155 objfile_per_bfd_storage.
12156 (symbol_set_names): Update.
12157
6eee24ce
TT
121582019-01-10 Tom Tromey <tom@tromey.com>
12159
12160 * xcoffread.c (xcoff_initial_scan): Unconditionally call
12161 init_psymbol_list.
12162 * psymtab.c (init_psymbol_list): Do nothing if already called.
12163 * psympriv.h (init_psymbol_list): Add comment.
12164 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12165 init_psymbol_list.
12166 * dbxread.c (dbx_symfile_read): Unconditionally call
12167 init_psymbol_list.
12168
75aedd27
TT
121692019-01-10 Tom Tromey <tom@tromey.com>
12170
12171 * xcoffread.c (scan_xcoff_symtab): Update.
12172 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12173 "where".
12174 * mdebugread.c (parse_partial_symbols)
12175 (handle_psymbol_enumerators): Update.
12176 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12177 * dbxread.c (read_dbx_symtab): Update.
12178 * psympriv.h (psymbol_placement): New enum.
12179 (add_psymbol_to_list): Update.
12180
939652a5
TT
121812019-01-10 Tom Tromey <tom@tromey.com>
12182
12183 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12184 static_psymbols parameters.
12185 (scan_xcoff_symtab): Update.
12186 * psymtab.c (start_psymtab_common): Remove global_psymbols and
12187 static_psymbols parameters.
12188 * psympriv.h (start_psymtab_common): Update.
12189 * mdebugread.c (parse_partial_symbols): Update.
12190 * dwarf2read.c (create_partial_symtab): Update.
12191 * dbxread.c (read_dbx_symtab): Update.
12192 (start_psymtab): Remove global_psymbols and static_psymbols
12193 parameters.
12194
baa62830
TT
121952019-01-10 Tom Tromey <tom@tromey.com>
12196
12197 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12198 * psymtab.c (allocate_psymtab): Add comment.
12199 * psympriv.h (allocate_psymtab): Add comment.
12200 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12201 initializations.
12202 * dbxread.c (dbx_end_psymtab): Remove some initializations.
12203
0e8f53ba
TT
122042019-01-10 Tom Tromey <tom@tromey.com>
12205
12206 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12207 Don't declare.
12208 * mipsread.c: Include mdebugread.h.
12209 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12210 Declare.
12211 * elfread.c: Include mdebugread.h.
12212
b22a7c6a
TT
122132019-01-09 Tom Tromey <tom@tromey.com>
12214
12215 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12216 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12217 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12218 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12219 (psym_lookup_symbol, psym_find_last_source_symtab)
12220 (psym_forget_cached_source_info, psym_print_stats)
12221 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12222 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12223 (psym_map_matching_symbols, psym_expand_symtabs_matching)
12224 (psym_find_compunit_symtab_by_address)
12225 (maintenance_print_psymbols, maintenance_info_psymtabs)
12226 (maintenance_check_psymtabs): Use ranged for.
12227 * psymtab.h (class objfile_psymtabs): New.
12228 (require_partial_symbols): Return objfile_psymtabs.
12229 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12230
3b9d3ac2
TT
122312019-01-09 Tom Tromey <tom@tromey.com>
12232
12233 * symfile.c (overlay_invalidate_all, find_pc_overlay)
12234 (find_pc_mapped_section, list_overlays_command)
12235 (map_overlay_command, unmap_overlay_command)
12236 (simple_overlay_update): Use all_objfiles.
12237 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12238 * printcmd.c (info_symbol_command): Use all_objfiles.
12239 * objfiles.h (ALL_OBJSECTIONS): Remove.
12240 * maint.c (maintenance_translate_address): Use all_objfiles.
12241 * gcore.c (gcore_create_callback): Use all_objfiles.
12242 (objfile_find_memory_regions): Likewise.
12243
8b31193a
TT
122442019-01-09 Tom Tromey <tom@tromey.com>
12245
12246 * symtab.c (find_line_symtab, info_sources_command)
12247 (make_source_files_completion_list): Use objfile_compunits.
12248 * source.c (select_source_symtab): Use objfile_compunits.
12249 * objfiles.h (struct objfile): Update comment.
12250 (ALL_OBJFILES): Remove.
12251 (ALL_FILETABS): Remove.
12252 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12253 objfile_compunits.
12254
d5da8b3c
TT
122552019-01-09 Tom Tromey <tom@tromey.com>
12256
12257 * symmisc.c (print_objfile_statistics, dump_objfile)
12258 (maintenance_print_symbols): Use compunit_filetabs.
12259 * source.c (forget_cached_source_info_for_objfile): Use
12260 compunit_filetabs.
12261 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12262 (ALL_FILETABS): Use compunit_filetabs.
12263 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12264 * coffread.c (coff_symtab_read): Use compunit_filetabs.
12265
5accd1a0
TT
122662019-01-09 Tom Tromey <tom@tromey.com>
12267
12268 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12269 (compunit_filetabs): New.
12270 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12271 compunit_filetabs.
12272 (info_sources_command, make_source_files_completion_list): Remove
12273 declaration.
12274 * symmisc.c (print_objfile_statistics, dump_objfile)
12275 (maintenance_print_symbols): Remove declaration.
12276 (maintenance_info_symtabs): Use compunit_filetabs.
12277 (maintenance_info_line_tables): Likewise.
12278 * source.c (select_source_symtab): Change local variable name.
12279 (forget_cached_source_info_for_objfile): Remove declaration.
12280 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12281 * objfiles.c (objfile_relocate1): Remove declaration.
12282 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12283 declaration.
12284 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12285 * coffread.c (coff_symtab_read): Remove declaration.
12286 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12287 compunit_filetabs.
12288
d8aeb77f
TT
122892019-01-09 Tom Tromey <tom@tromey.com>
12290
12291 * symtab.c (lookup_objfile_from_block)
12292 (find_pc_sect_compunit_symtab, search_symbols)
12293 (default_collect_symbol_completion_matches_break_on): Use
12294 objfile_compunits.
12295 * objfiles.h (ALL_COMPUNITS): Remove.
12296 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12297 * cp-support.c (add_symbol_overload_list_qualified): Use
12298 objfile_compunits.
12299 * ada-lang.c (ada_collect_symbol_completion_matches)
12300 (ada_add_global_exceptions): Use objfile_compunits.
12301
592553c4
TT
123022019-01-09 Tom Tromey <tom@tromey.com>
12303
12304 * source.c (select_source_symtab)
12305 (forget_cached_source_info_for_objfile): Remove declaration.
12306 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12307 declaration.
12308 * maint.c (count_symtabs_and_blocks): Remove declaration.
12309 * cp-support.c (add_symbol_overload_list_qualified): Remove
12310 declaration.
12311 * coffread.c (coff_symtab_read): Remove declaration.
12312 * symtab.c (lookup_symbol_in_objfile_symtabs)
12313 (basic_lookup_transparent_type_1): Use objfile_compunits.
12314 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12315 (info_sources_command, search_symbols)
12316 (default_collect_symbol_completion_matches_break_on)
12317 (make_source_files_completion_list): Remove declaration.
12318 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12319 (ada_collect_symbol_completion_matches)
12320 (ada_add_global_exceptions): Remove declaration.
12321 * linespec.c (iterate_over_all_matching_symtabs): Use
12322 objfile_compunits.
12323 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12324 (class objfile_compunits): New.
12325 (ALL_COMPUNITS): Use objfile_compunits.
12326 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12327 (maintenance_check_symtabs, maintenance_info_line_tables): Use
12328 objfile_compunits.
12329 * objfiles.c (objfile_relocate1): Use objfile_compunits.
12330
5325b9bf
TT
123312019-01-09 Tom Tromey <tom@tromey.com>
12332
12333 * symtab.c (search_symbols)
12334 (default_collect_symbol_completion_matches_break_on): Use
12335 objfile_msymbols.
12336 * ada-lang.c (ada_lookup_simple_minsym)
12337 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12338 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12339 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12340 objfile_msymbols.
12341 * coffread.c (coff_symfile_read): Use objfile_msymbols.
12342 * symmisc.c (dump_msymbols): Use objfile_msymbols.
12343 * objc-lang.c (find_methods): Use objfile_msymbols.
12344 (info_selectors_command, info_classes_command): Likewise.
12345 * stabsread.c (scan_file_globals): Use objfile_msymbols.
12346 * objfiles.h (class objfile_msymbols): New.
12347 (ALL_OBJFILE_MSYMBOLS): Remove.
12348 (ALL_MSYMBOLS): Remove.
12349
cac85af2
TT
123502019-01-09 Tom Tromey <tom@tromey.com>
12351
12352 * common/next-iterator.h (next_adapter): Add Iterator template
12353 parameter.
12354 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12355 (class all_objfiles_safe): New.
12356 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12357 * objfiles.c (put_objfile_before): Update comment.
12358 (add_separate_debug_objfile): Likewise.
12359 (free_all_objfiles): Use all_objfiles_safe.
12360 (objfile_purge_solibs): Likewise.
12361
aed57c53
TT
123622019-01-09 Tom Tromey <tom@tromey.com>
12363
12364 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12365 (expand_symtab_containing_pc, lookup_static_symbol)
12366 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12367 (find_symbol_at_address, find_line_symtab, find_main_name): Use
12368 all_objfiles.
12369 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12370 * breakpoint.c (create_overlay_event_breakpoint)
12371 (create_longjmp_master_breakpoint)
12372 (create_std_terminate_master_breakpoint)
12373 (create_exception_master_breakpoint): Use all_objfiles.
12374 * linux-thread-db.c (try_thread_db_load_from_pdir)
12375 (has_libpthread): Use all_objfiles.
12376 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12377 * linespec.c (iterate_over_all_matching_symtabs)
12378 (search_minsyms_for_name): Use all_objfiles.
12379 * maint.c (maintenance_info_sections): Use all_objfiles.
12380 * main.c (captured_main_1): Use all_objfiles.
12381 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12382 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12383 * guile/scm-pretty-print.c
12384 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12385 * solib-spu.c (append_ocl_sos): Use all_objfiles.
12386 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12387 (maintenance_print_msymbols): Use all_objfiles.
12388 * source.c (select_source_symtab): Use all_objfiles.
12389 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12390 * symfile.c (remove_symbol_file_command)
12391 (expand_symtabs_matching, map_symbol_filenames): Use
12392 all_objfiles.
12393 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12394 all_objfiles.
12395 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12396 * objc-lang.c (find_methods): Use all_objfiles.
12397 * objfiles.c (have_partial_symbols, have_full_symbols)
12398 (have_minimal_symbols, qsort_cmp)
12399 (default_iterate_over_objfiles_in_search_order): Use
12400 all_objfiles.
12401 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12402 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12403 (maintenance_check_psymtabs): Use all_objfiles.
12404 (ALL_PSYMTABS): Remove.
12405 * compile/compile-object-run.c (do_module_cleanup): Use
12406 all_objfiles.
12407 * blockframe.c (find_pc_partial_function): Use all_objfiles.
12408 * cp-support.c (add_symbol_overload_list_qualified): Use
12409 all_objfiles.
12410 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12411 Use all_objfiles.
12412 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12413 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12414 all_objfiles.
12415 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12416 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12417 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12418 Uses all_objfiles.
12419 * solib.c (solib_read_symbols): Use all_objfiles
12420
99d89cde
TT
124212019-01-09 Tom Tromey <tom@tromey.com>
12422
12423 * probe.c (parse_probes_in_pspace): Use all_objfiles.
12424 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12425 all_objfiles.
12426 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12427 * symmisc.c (print_symbol_bcache_statistics)
12428 (print_objfile_statistics, maintenance_print_objfiles)
12429 (maintenance_info_symtabs, maintenance_check_symtabs)
12430 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12431 all_objfiles.
12432 * source.c (forget_cached_source_info): Use all_objfiles.
12433 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12434 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12435 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12436 * objfiles.c (update_section_map): Use all_objfiles.
12437 (shared_objfile_contains_address_p): Likewise.
12438 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12439 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12440
21708325
TT
124412019-01-09 Tom Tromey <tom@tromey.com>
12442
12443 * common/next-iterator.h: New file.
12444 * objfiles.h (class all_objfiles): New.
12445 (struct objfile_iterator): New.
12446
669e09f6
PW
124472019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12448
12449 * NEWS: Move the description of the changed "frame", "select-frame",
12450 and "info frame" commands to the Changed commands section.
12451
041be526
SM
124522019-01-09 Simon Marchi <simon.marchi@ericsson.com>
12453
12454 * gdbtypes.c (check_stub_method_group): Remove handling of old
12455 mangling schemes.
12456 * linespec.c (find_methods): Likewise.
12457 * stabsread.c (read_member_functions): Likewise.
12458 * valops.c (search_struct_method): Likewise.
12459 (value_struct_elt_for_reference): Likewise.
12460 * NEWS: Mention this change.
12461
0e2a2133
AB
124622019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
12463
12464 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12465 print_source_lines.
12466 * source.c (print_source_lines_base): Update line number check.
12467 (print_source_lines): New function.
12468 (source_lines_range::source_lines_range): New function.
12469 * source.h (class source_lines_range): New class.
12470 (print_source_lines): New declaration.
12471
1055a3b4
PW
124722019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12473
12474 * linespec.c (linespec_state_destructor): Free self->canonical_names.
12475
cfeadda5
TT
124762019-01-08 Tom Tromey <tom@tromey.com>
12477 Simon Marchi <simon.marchi@ericsson.com>
12478
12479 PR gdb/24060
12480 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12481 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12482 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12483 * f-exp.y (DOLLAR_VARIABLE): Likewise.
12484 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12485 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12486
583068ca
AB
124872019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12488
12489 * source.c (select_source_symtab): Move header comment to
12490 declaration in source.h.
12491 (forget_cached_source_info_for_objfile): Likewise.
12492 (forget_cached_source_info): Likewise.
12493 (identify_source_line): Likewise.
12494 * source.h (identify_source_line): Move declaration from symtab.h
12495 and add comment from source.c
12496 (print_source_lines): Likewise.
12497 (forget_cached_source_info_for_objfile): Likewise.
12498 (forget_cached_source_info): Likewise.
12499 (select_source_symtab): Likewise.
12500 (enum print_source_lines_flag): Move definition from symtab.h.
12501 * symtab.h (identify_source_line): Move declaration to source.h.
12502 (print_source_lines): Likewise.
12503 (forget_cached_source_info_for_objfile): Likewise.
12504 (forget_cached_source_info): Likewise.
12505 (select_source_symtab): Likewise.
12506 (enum print_source_lines_flag): Move definition to source.h.
12507 * tui/tui-hooks.c: Add 'source.h' include.
12508
ec98a4ad
AB
125092019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12510
12511 * source.c (print_source_lines_base): Handle requests to print
12512 reverse line number sequences, and guard against empty lines
12513 string.
12514
62ea19c1
AB
125152019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12516
12517 * source.c (print_source_lines_base): Fix skip of '\r' if next
12518 character is '\n'.
12519
9d30e1fd
TT
125202019-01-06 Tom Tromey <tom@tromey.com>
12521
12522 * c-exp.y (struct c_parse_state) <macro_original_text,
12523 expansion_obstack>: New member.
12524 (macro_original_text, expansion_obstack): Remove globals.
12525 (scan_macro_expansion, scanning_macro_expansion)
12526 (finished_macro_expansion): Update.
12527 (scan_macro_cleanup): Remove.
12528 (yylex, c_parse): Update.
12529
c65bac38
TT
125302019-01-06 Tom Tromey <tom@tromey.com>
12531
12532 * c-exp.y (struct c_parse_state) <strings>: New member.
12533 (operator_stoken): Update.
12534
02e12e38
TT
125352019-01-06 Tom Tromey <tom@tromey.com>
12536
12537 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12538 (union type_stack_elt) <typelist_val>: Now a pointer to
12539 std::vector.
12540 (type_stack_cleanup): Don't declare.
12541 (push_typelist): Update.
12542 * parse.c (pop_typelist): Return a std::vector.
12543 (push_typelist): Take a std::vector.
12544 (follow_types): Update. Do not free args.
12545 (type_stack_cleanup): Remove.
12546 * c-exp.y (struct c_parse_state): New.
12547 (cpstate): New global.
12548 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12549 (nonempty_typelist): Update.
12550 (func_mod): Create a new vector.
12551 (c_parse): Create a c_parse_state.
12552 (check_parameter_typelist): Do not delete params.
12553 (function_method): Update. Do not delete type_list.
12554
f097f5ad
TT
125552019-01-06 Tom Tromey <tom@tromey.com>
12556
12557 PR gdb/28155:
12558 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12559 check_typedef.
12560 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12561 (print_return_value): Likewise.
12562
d2adf9f1
TT
125632019-01-05 Tom Tromey <tom@tromey.com>
12564
12565 * contrib/cleanup_check.py: Remove.
12566 * contrib/gcc-with-excheck: Remove.
12567 * contrib/exsummary.py: Remove.
12568 * contrib/excheck.py: Remove.
12569
2eab46b1
JB
125702019-01-05 Joel Brobecker <brobecker@adacore.com>
12571
12572 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12573 NULL. Initialize tpprev to NULL instead of assigning it
12574 to NULL on the next statement.
12575 * windows-nat.c (windows_delete_thread): Remove check for
12576 main_thread_id before printing thread exit notifications.
12577 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12578 Remove thread ID check against main_thread_id.
12579 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12580 windows_delete_thread.
12581 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12582
48c5e7e2
TT
125832019-01-04 Tom Tromey <tom@tromey.com>
12584
12585 * compile/compile.c (_initialize_compile): Use upper case for
12586 metasyntactic variables.
12587 * symmisc.c (_initialize_symmisc): Use upper case for
12588 metasyntactic variables.
12589 * psymtab.c (_initialize_psymtab): Use upper case for
12590 metasyntactic variables.
12591 * demangle.c (demangle_command): Use upper case for metasyntactic
12592 variables.
12593 (_initialize_demangler): Likewise.
12594 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12595 variables.
12596
986041cd
TT
125972019-01-03 Tom Tromey <tom@tromey.com>
12598
12599 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12600
7c711119
TT
126012019-01-03 Tom Tromey <tom@tromey.com>
12602
12603 * python/py-symtab.c (salpy_str): Update.
12604 (struct salpy_sal_object) <symtab>: Now a PyObject.
12605 (salpy_dealloc): Update.
12606 (del_objfile_sal): Use gdbpy_ref.
12607
1b20edf0
TT
126082019-01-03 Tom Tromey <tom@tromey.com>
12609
12610 * python/py-type.c (convert_field): Use new_reference. Return
12611 gdbpy_ref.
12612 (make_fielditem): Return gdbpy_ref.
12613 (typy_fields): Update.
12614 (typy_getitem): Update.
12615 (field_name): Return gdbpy_ref. Use new_reference.
12616 (typy_iterator_iternext): Update.
12617
ea41325b
TT
126182019-01-03 Tom Tromey <tom@tromey.com>
12619
12620 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12621
2a3c71d6
TT
126222019-01-03 Tom Tromey <tom@tromey.com>
12623
12624 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12625 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12626 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12627 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12628 (pspy_set_type_printers): Likewise.
12629 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12630 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12631 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12632 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12633 (objfpy_set_type_printers): Likewise.
12634
5c329e6a
TT
126352019-01-03 Tom Tromey <tom@tromey.com>
12636
12637 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12638 (gdbpy_print_stack): Use gdbpy_err_fetch.
12639 * python/python-internal.h (class gdbpy_err_fetch): New class.
12640 (class gdbpy_enter) <m_error_type, m_error_value,
12641 m_error_traceback>: Remove.
12642 <m_error>: New member.
12643 (gdbpy_exception_to_string): Don't declare.
12644 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12645 * python/py-value.c (convert_value_from_python): Use
12646 gdbpy_err_fetch.
12647 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12648 gdbpy_exception_to_string.
12649 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12650 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12651 gdbpy_err_fetch.
12652
169bb27b
AB
126532019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12654
12655 * linux-nat.c (delete_lwp_cleanup): Delete.
12656 (struct lwp_deleter): New struct.
12657 (lwp_info_up): New typedef.
12658 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12659 lwp_info_up.
12660
a07c8880
AB
126612019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12662
12663 * linux-fork.c (class scoped_switch_fork_info): New class.
12664 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12665
26089c49
AB
126662019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12667
12668 * valops.c (find_overload_match): Remove use of null_cleanup, and
12669 calls to do_cleanups.
12670
06d3e5b0
AB
126712019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12672
12673 * compile/compile-cplus-types.c
12674 (compile_cplus_instance::decl_name): Handle changes to
12675 cp_func_name.
12676 * cp-support.c (cp_func_name): Update header comment, update
12677 return type.
12678 * cp-support.h (cp_func_name): Update return type in declaration.
12679 * valops.c (find_overload_match): Move temp_func local to top
12680 level of function and change its type. Use temp_func to hold and
12681 delete temporary string obtained from cp_func_name.
12682
66644cd3
AB
126832019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12684
12685 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12686 gdb::char_vector, remove cleanup, and update uses of `msg`.
12687
592d8c0a
JW
126882019-01-03 Jim Wilson <jimw@sifive.com>
12689
12690 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12691
c55d06ec
TT
126922019-01-02 Tom Tromey <tom@tromey.com>
12693
12694 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12695 (tdesc_parse_xml): Remove cleanups.
12696 * target-descriptions.h (make_cleanup_free_target_description):
12697 Don't declare.
12698 (target_desc_deleter): New struct.
12699 (target_desc_up): New typedef.
12700 * target-descriptions.c (target_desc_deleter::operator()): Rename
12701 from free_target_description.
12702 (make_cleanup_free_target_description): Remove.
12703
3a6ae42d
TT
127042019-01-02 Tom Tromey <tom@tromey.com>
12705
12706 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12707 constructor, destructor.
12708 (linespec_parser): Remove typedef.
12709 (~linespec_parser): Rename from linespec_parser_delete.
12710 (linespec_lex_to_end, linespec_complete_label)
12711 (linespec_complete): Update.
12712 (decode_line_full): Remove cleanups.
12713 (decode_line_1): Update.
12714
61fd3e73
TT
127152019-01-02 Tom Tromey <tom@tromey.com>
12716
12717 * python/python-internal.h (inferior_to_inferior_object): Change
12718 return type.
12719 * python/py-exitedevent.c (create_exited_event_object): Update.
12720 * python/py-inferior.c (inferior_to_inferior_object): Return
12721 gdbpy_ref.
12722 (python_new_inferior, python_inferior_deleted)
12723 (thread_to_thread_object, delete_thread_object)
12724 (build_inferior_list, gdbpy_selected_inferior): Update.
12725 * python/py-infthread.c (create_thread_object): Update. Also fail
12726 if inferior_to_inferior_object fails.
12727
d20172fc
SM
127282019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12729
12730 * inferior.h (class inferior) <displaced_step_state>: New field.
12731 * infrun.h (struct displaced_step_state): Move here from
12732 infrun.c. Initialize fields, add constructor.
12733 <inf>: Remove field.
12734 <reset>: New method.
12735 * infrun.c (struct displaced_step_inferior_state): Move to
12736 infrun.h.
12737 (displaced_step_inferior_states): Remove.
12738 (get_displaced_stepping_state): Adust.
12739 (displaced_step_in_progress_any_inferior): Adjust.
12740 (displaced_step_in_progress_thread): Adjust.
12741 (displaced_step_in_progress): Adjust.
12742 (add_displaced_stepping_state): Remove.
12743 (get_displaced_step_closure_by_addr): Adjust.
12744 (remove_displaced_stepping_state): Remove.
12745 (infrun_inferior_exit): Call displaced_step_state.reset.
12746 (use_displaced_stepping): Don't check for NULL.
12747 (displaced_step_prepare_throw): Call
12748 get_displaced_stepping_state.
12749 (displaced_step_fixup): Don't check for NULL.
12750 (prepare_for_detach): Don't check for NULL.
12751
e3319240
PW
127522019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12753
12754 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12755 in case of call that did not complete.
12756
5d36dfb9
AU
127572019-01-02 Andrey Utkin <autkin@undo.io>
12758
12759 * symfile.c (find_separate_debug_file): Fix search of debug files for
12760 remote debuggee.
12761
8833fbf0
TT
127622019-01-02 Tom Tromey <tom@tromey.com>
12763
12764 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12765 indentation.
12766 * python/py-frame.c (frapy_older): Remove cast.
12767 (frapy_newer): Likewise.
12768 * python/py-breakpoint.c (local_setattro): Remove cast.
12769 * python/py-arch.c (archpy_name): Remove local variable.
12770 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12771
4ada3dfd
JB
127722019-01-02 Joel Brobecker <brobecker@adacore.com>
12773
12774 * unittests/basic_string_view/element_access/char/empty.cc:
12775 Fix year range in copyright header.
12776
113b7b81
AB
127772019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12778
12779 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12780 Delete.
12781 <operator==>: Update with for removed field.
12782 <hash>: Likewise.
12783 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12784 <isa_features>: ...this.
12785 <abi_features>: New field.
12786 (riscv_isa_flen): Update comment.
12787 (riscv_abi_xlen): New declaration.
12788 (riscv_abi_flen): New declaration.
12789 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12790 isa_features.
12791 (riscv_abi_xlen): New function.
12792 (riscv_isa_flen): Update to get answer from isa_features.
12793 (riscv_abi_flen): New function.
12794 (riscv_has_fp_abi): Update to get answer from abi_features.
12795 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12796 xlen and flen.
12797 (riscv_call_info) <xlen, flen>: Update comment.
12798 (riscv_call_arg_struct): Remove invalid assertions
12799 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12800 is removed.
12801 (riscv_gdbarch_init): Gather isa features and abi features
12802 separately, ensure both match on the gdbarch when reusing an old
12803 gdbarch. Relax an error check to allow 32-bit abi float to run on
12804 a target with 64-bit float hardware.
12805
b18ca514
PW
128062019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12807
12808 * source.c (search_command_helper): Stop reverse search
12809 when line 1 has been searched.
12810
ec70d8db
PW
128112019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12812
12813 * record-full.c (record_full_base_target::close): Rewrite
12814 record_full_core_buf_list free logic.
12815
5b38f9c1
PW
128162019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12817
12818 * break-catch-syscall.c (print_one_catch_syscall): xfree
12819 the last text.
12820
66d91b39
JB
128212019-01-01 Joel Brobecker <brobecker@adacore.com>
12822
12823 * top.c (print_gdb_version): Update Copyright year in version
12824 message.
12825
42a4f53d
JB
128262019-01-01 Joel Brobecker <brobecker@adacore.com>
12827
12828 Update copyright year range in all GDB files.
12829
7e955d83 128302019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 12831
5bbd631d 12832 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 12833
5bbd631d 12834For older changes see ChangeLog-2018.
c906108c
SS
12835\f
12836Local Variables:
12837mode: change-log
12838left-margin: 8
12839fill-column: 74
12840version-control: never
57da7796 12841coding: utf-8
c906108c 12842End:
5bbd631d 12843
This page took 3.658332 seconds and 4 git commands to generate.