qsort: ldctor.c CONSTRUCTORS
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
284782de
SM
12019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2
3 * ui-out.c (ui_out::call_do_message): Silence
4 -Wformat-nonliteral warning.
5
073bbbb0
SM
62019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
7
8 * breakpoint.c: Remove some includes: continuations.h, skip.h,
9 mi/mi-main.h, readline/readline.h, readline/history.h. Add
10 include: readline/tilde.h.
11
7b9a15e1
CB
122019-10-12 Christian Biesinger <cbiesinger@google.com>
13
14 * remote.c (remote_target::get_trace_status): Remove declaration of
15 trace_regblock_size.
16
cc8dee1f
CB
172019-10-12 Christian Biesinger <cbiesinger@google.com>
18
19 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
20 (show_user): Remove declaration of cmdlist.
21 * cli/cli-cmds.h (max_user_call_depth): Declare.
22 * cli/cli-script.c (execute_user_command): Remove declaration
23 of max_user_call_depth.
24
a83d4ef6
JW
252019-10-11 Jim Wilson <jimw@sifive.com>
26
5f93c5a6
JW
27 * gdbsupport/print-utils.h (pulongest): Fix comment.
28 (plongest): Likewise.
29 (phex): Add missing comment, mention leading zeros.
30 (phex_nz): Add mention of no leading zeros to comment.
31
a83d4ef6
JW
32 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
33 plongest instead of unsigned long long cast.
34
26344e0c
CB
352019-10-10 Christian Biesinger <cbiesinger@google.com>
36
37 * main.c (captured_main_1): Include gdbtk.h and remove declarations
38 for external_editor_command and gdbtk_test.
39
c2c440a9
CB
402019-10-10 Christian Biesinger <cbiesinger@google.com>
41
42 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
43 * varobj.c (varobjdebug): Move comment to...
44 * varobj.h (varobjdebug): ...here, and declare.
45
a31bff9d
TT
462019-10-09 Tom Tromey <tom@tromey.com>
47
48 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
49 erase_data_content.
50
7523da63
TT
512019-10-09 Tom Tromey <tom@tromey.com>
52
53 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
54 * tui/tui-stack.c (tui_locator_window::rerender): Update.
55 * tui/tui-command.c (tui_cmd_window::resize)
56 (tui_refresh_cmd_win): Update.
57 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
58 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
59 * tui/tui-data.c (~tui_gen_win_info): Remove.
60 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
61 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
62 (tui_redisplay_readline, tui_mld_flush)
63 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
64 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
65 (tui_data_window::erase_data_content)
66 (tui_data_item_window::rerender)
67 (tui_data_item_window::refresh_window): Update.
68 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
69 (box_win, tui_gen_win_info::make_window)
70 (tui_gen_win_info::make_visible): Update.
71 (tui_delete_win): Remove.
72 * tui/tui-winsource.c
73 (tui_source_window_base::do_erase_source_content): Update.
74 (tui_show_source_line, tui_source_window_base::update_tab_width)
75 (tui_source_window_base::update_exec_info): Update.
76 * tui/tui-data.h (struct curses_deleter): New.
77 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
78 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
79
a7798e7f
TT
802019-10-09 Tom Tromey <tom@tromey.com>
81
82 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
83
5c45899e
TT
842019-10-09 Tom Tromey <tom@tromey.com>
85
86 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
87 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
88
6d7fd9aa
TT
892019-10-09 Tom Tromey <tom@tromey.com>
90
91 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
92 window height directly.
93 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
94 declare.
95 * tui/tui-layout.c (tui_default_win_height): Remove.
96 (tui_default_win_viewport_height): Remove.
97
d2dd1084
TT
982019-10-09 Tom Tromey <tom@tromey.com>
99
100 * tui/tui.h: Remove comments.
101
cff32449
TV
1022019-10-09 Tom de Vries <tdevries@suse.de>
103
104 * python/lib/gdb/printer/bound_registers.py: Use
105 '^builtin_type_bound128' as regexp argument for
106 add_builtin_pretty_printer.
107
6a25e8a2
CB
1082019-10-09 Christian Biesinger <cbiesinger@google.com>
109
110 * guile/guile.c (guile_extension_script_ops): Remove forward
111 declaration and mark as static.
112 (guile_script_ops): Likewise.
113 (extension_language_guile): Move further down in the file so
114 it can reference the definitions for guile_{extension_,}script_ops.
115
6d9d6da4
AA
1162019-10-09 Andreas Arnez <arnez@linux.ibm.com>
117
118 * s390-tdep.c (390_process_record): Handle new arch13 instructions
119 except SORTL, DFLTCC, and KDSA.
120
3abea05d
TT
1212019-10-08 Tom Tromey <tromey@adacore.com>
122
123 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
124 (struct safe_symbol_file_add_args): Remove.
125
dde996e2
TT
1262019-10-08 Tom Tromey <tromey@adacore.com>
127
128 * windows-nat.c: Don't include buildsym-legacy.h.
129
cd6fdaa1
TT
1302019-10-08 Tom Tromey <tromey@adacore.com>
131
132 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
133
79bb1944
CB
1342019-10-08 Christian Biesinger <cbiesinger@google.com>
135
136 * gdbtypes.c (overload_debug): Move comment to header.
137 * gdbtypes.h (overload_debug): Declare.
138 * valops.c: Remove declaration of overload_debug, instead
139 include gdbtypes.h.
140
34916edc
CB
1412019-10-08 Christian Biesinger <cbiesinger@google.com>
142
143 * language.c (show_language_command): Pass lang_frame_mismatch_warn
144 through _().
145 (lang_frame_mismatch_warn): Make const, mark with N_(), and
146 move comment...
147 * language.h (lang_frame_mismatch_warn): ... here. Also add
148 declaration.
149 * top.c (lang_frame_mismatch_warn): Remove declaration.
150 (check_frame_language_change): Pass lang_frame_mismatch_warn
151 through _().
152
bad5c026
CB
1532019-10-07 Christian Biesinger <cbiesinger@google.com>
154
155 * c-lang.h (vtbl_ptr_name): Declare.
156 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
157 it from the header.
158 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
159
51f1fdc3
CB
1602019-10-07 Christian Biesinger <cbiesinger@google.com>
161
162 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
163 gdb_static_assert.
164
30d1f018
WP
1652019-10-07 Weimin Pan <weimin.pan@oracle.com>
166
606813d5
WP
167 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
168 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
169 * ctfread.c: New file.
170 * ctfread.h: New file.
171 * elfread.c: Include ctfread.h.
172 (struct elfinfo text_p): New member ctfsect.
173 (elf_locate_sections): Mark CTF section.
174 (elf_symfile_read): Call elfctf_build_psymtabs.
175 * Makefile.in (LIBCTF): Add.
176 (CLIBS): Use it.
177 (CDEPS): Likewise.
178 (DIST): Add ctfread.c.
606813d5
WP
179
1802019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
181
182 * ctfread.c (struct nextfield): Renamed to ...
183 (struct ctf_nextfield): ... this.
184 (struct field_info): Renamed to ...
185 (strut ctf_field_info): ... this.
186 (attach_fields_to_type): Update for renamed structures.
187 (ctf_add_member_cb): Likewise.
188 (ctf_add_enum_member_cb): Likewise.
189 (process_struct_members): Likewise.
190 (process_enum_type): Likewise.
30d1f018 191
518fe38c
WP
1922019-10-07 Weimin Pan <weimin.pan@oracle.com>
193
194 * tracectf.h: Rename, was ctf.h.
195 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
196 * tracefile.c: Likewise.
197 * tracepoint.c: Remove unused include ctf.h.
198 * mi/mi-main.c: Likewise.
199 * Makefile.in Replace ctf.c with tracectf.c.
200
225f296a
JB
2012019-10-06 Joel Brobecker <brobecker@adacore.com>
202
203 * version.in: Change version number to "9.0.50.DATE-git".
204
77c2dba3
TT
2052019-10-03 Tom Tromey <tom@tromey.com>
206
207 PR rust/24976:
208 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
209
179aed7f
AB
2102019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
211
212 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
213 cp_search_name_hash.
214 * NEWS: Add entry about nested function support.
215
0a4b0913
AB
2162019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
217 Andrew Burgess <andrew.burgess@embecosm.com>
218
219 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
220 for nested static variables when searchin VAR_DOMAIN.
221 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
222 global scope, update comment.
223 (add_partial_subprogram): Call add_partial_subprogram recursively
224 for nested subroutines when processinng Fortran.
225 (load_partial_dies): Process the child entities of a subprogram
226 when processing Fortran.
227 (partial_die_parent_scope): Handle building scope
228 for Fortran nested functions.
229 (process_die): Record that nested functions have a scope.
230 (new_symbol): Always record Fortran subprograms on the global
231 symbol list.
232 (determine_prefix): How to build the prefix for Fortran
233 subprograms.
234
d8c06f22
AB
2352019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
236
237 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
238 have just sent the thread a SIGSTOP and are waiting for it to
239 arrive.
240
a8b3b8e9
AB
2412019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
242
243 * btrace.c (btrace_add_pc): Remove whitespace before the template
244 parameter in 'std::vector <...>'.
245 (parse_xml_btrace_block): Likewise.
246 (btrace_maint_decode_pt): Likewise.
247 (btrace_maint_update_packets): Likewise.
248 (btrace_maint_print_packets): Likewise.
249 * btrace.h (struct btrace_maint_info): Likewise.
250 * dwarf2read.c (struct type_unit_group): Likewise.
251 (build_type_psymtabs_reader): Likewise.
252 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
253 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
254 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
255
4d825eab
TV
2562019-10-03 Tom de Vries <tdevries@suse.de>
257
258 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
259 the first line of the help text for set/show style metadata.
260
80fd2826
TT
2612019-10-02 Tom Tromey <tromey@adacore.com>
262
263 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
264 * gdbsupport/common-inferior.c: New file.
265 * infcmd.c (startup_with_shell): Don't define.
266 * nat/fork-inferior.h (startup_with_shell): Don't declare.
267 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
268 * inferior.h (startup_with_shell): Don't declare.
269
70054538
CB
2702019-10-02 Christian Biesinger <cbiesinger@google.com>
271
272 * gdbsupport/gdb_assert.h: Include errors.h.
273 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
274
37f6a7f4
TT
2752019-10-02 Tom Tromey <tromey@adacore.com>
276
277 * NEWS: Add $_ada_exception entry.
278 * ada-lang.c (struct ada_catchpoint): Add constructor.
279 <m_kind>: New member.
280 (allocate_location_exception, re_set_exception): Remove
281 "ex" parameter.
282 (should_stop_exception): Compute $_ada_exception.
283 (check_status_exception, print_it_exception)
284 (print_one_exception, print_mention_exception): Remove
285 "ex" parameter.
286 (allocate_location_catch_exception, re_set_catch_exception)
287 (check_status_exception, print_it_catch_exception)
288 (print_one_catch_exception, print_mention_catch_exception)
289 (print_recreate_catch_exception)
290 (allocate_location_catch_exception_unhandled)
291 (re_set_catch_exception_unhandled)
292 (check_status_exception, print_it_catch_exception_unhandled)
293 (print_one_catch_exception_unhandled)
294 (print_mention_catch_exception_unhandled)
295 (print_recreate_catch_exception_unhandled)
296 (allocate_location_catch_assert, re_set_catch_assert)
297 (check_status_assert, print_it_catch_assert)
298 (print_one_catch_assert, print_mention_catch_assert)
299 (print_recreate_catch_assert)
300 (allocate_location_catch_handlers, re_set_catch_handlers)
301 (check_status_handlers, print_it_catch_handlers)
302 (print_one_catch_handlers, print_mention_catch_handlers)
303 (print_recreate_catch_handlers): Remove.
304 (create_ada_exception_catchpoint): Update.
305 (initialize_ada_catchpoint_ops): Update.
306
fccf9de1
TT
3072019-10-02 Tom Tromey <tromey@adacore.com>
308
309 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
310 (create_excep_cond_exprs): Simplify exception string computation.
311 (ada_exception_catchpoint_cond_string): Likewise.
312
4b610737
TT
3132019-10-02 Tom Tromey <tromey@adacore.com>
314
315 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
316 * ada-lang.c (lesseq_defined_than): Handle
317 LOC_STATIC.
318 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
319 parameter.
320 (dwarf2_has_info): Likewise.
321 (new_symbol): Set maybe_copied on symbol when
322 appropriate.
323 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
324 parameter.
325 <can_copy>: New member.
326 * elfread.c (record_minimal_symbol): Set maybe_copied
327 on symbol when appropriate.
328 (elf_symfile_read): Update call to dwarf2_has_info.
329 * minsyms.c (lookup_minimal_symbol_linkage): New
330 function.
331 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
332 * symtab.c (get_symbol_address, get_msymbol_address):
333 New functions.
334 * symtab.h (get_symbol_address, get_msymbol_address):
335 Declare.
336 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
337 maybe_copied.
338 (struct symbol, struct minimal_symbol) <maybe_copied>:
339 New member.
340
1dd58850
TT
3412019-10-02 Tom Tromey <tromey@adacore.com>
342
343 * source.c (struct current_source_location): New.
344 (current_source_key): New global.
345 (current_source_symtab, current_source_line)
346 (current_source_pspace): Remove.
347 (get_source_location): New function.
348 (get_current_source_symtab_and_line)
349 (set_default_source_symtab_and_line)
350 (set_current_source_symtab_and_line)
351 (clear_current_source_symtab_and_line, select_source_symtab)
352 (info_source_command, print_source_lines_base)
353 (info_line_command, search_command_helper, _initialize_source):
354 Update.
355
5c281dbb
TT
3562019-10-02 Tom Tromey <tromey@adacore.com>
357
358 * source.c (select_source_symtab): Don't call
359 decode_line_with_current_source.
360
d3d32391
AB
3612019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
362
363 * symtab.c (lookup_global_symbol): Search global block.
364
38583298
TT
3652019-10-02 Tom Tromey <tromey@adacore.com>
366
367 * coffread.c (process_coff_symbol): Update.
368 * dwarf2read.c (var_decode_location, new_symbol): Update.
369 * mdebugread.c (parse_symbol): Update.
370 * objfiles.c (relocate_one_symbol): Update.
371 * stabsread.c (define_symbol, fix_common_block)
372 (scan_file_globals): Update.
373 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
374 (SET_SYMBOL_VALUE_ADDRESS): New macro.
375 * xcoffread.c (process_xcoff_symbol): Update.
376
9344c18f
AA
3772019-10-02 Andreas Arnez <arnez@linux.ibm.com>
378
379 * MAINTAINERS: Update my email address.
380
df07e2c7
AB
3812019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
382
383 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
384 std::vector.
385 (build_type_psymtabs_reader): Update for std::vector.
386 (build_type_psymtab_dependencies): Likewise.
387 * dwarf2read.h: Remove use of DEF_VEC_P.
388 (typedef sig_type_ptr): Delete.
389
554ac434
AB
3902019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
391
392 * btrace.c (btrace_maint_clear): Update to handle change from VEC
393 to std::vector.
394 (btrace_maint_decode_pt): Likewise, and move allocation of the
395 vector outside of the loop.
396 (btrace_maint_update_packets): Update to handle change from VEC to
397 std::vector.
398 (btrace_maint_print_packets): Likewise.
399 (maint_info_btrace_cmd): Likewise.
400 * btrace.h: Remove use of DEF_VEC_O.
401 (typedef btrace_pt_packet_s): Delete.
402 (struct btrace_maint_info) <packets>: Change fromm VEC to
403 std::vector.
404 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
405
46f29a9a
AB
4062019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
407
408 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
409 make accesses into the vector constant references.
410 (btrace_add_pc): Update for std::vector.
411 (btrace_stitch_bts): Likewise.
412 (parse_xml_btrace_block): Likewise.
413 (btrace_maint_update_packets): Likewise.
414 (btrace_maint_print_packets): Likewise.
415 (maint_info_btrace_cmd): Likewise.
416 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
417 std::vector.
418 (btrace_data::empty): Likewise.
419 (btrace_data_append): Likewise.
420 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
421 (typedef btrace_block_s): Delete.
422 (struct btrace_block): Add constructor.
423 (struct btrace_data_bts) <blocks>: Change to std::vector.
424 * nat/linux-btrace.c (perf_event_read_bts): Update for
425 std::vector.
426 (linux_read_bts): Likewise.
427
d770d56f
TT
4282019-10-01 Tom Tromey <tom@tromey.com>
429
430 * cli/cli-logging.c (show_logging_filename): Use styled_string.
431
9d636d67
TT
4322019-10-01 Tom Tromey <tom@tromey.com>
433
434 * stack.c (print_frame, info_frame_command_core): Use
435 styled_string.
436 * linux-thread-db.c (try_thread_db_load_1)
437 (try_thread_db_load_from_pdir_1): Use styled_string.
438 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
439 (auto_load_section_scripts, info_auto_load_local_gdbinit)
440 (maybe_print_unsupported_script_warning)
441 (maybe_print_script_not_found_warning): Use styled_string.
442 * ada-lang.c (user_select_syms): Use styled_string.
443
7f6aba03
TT
4442019-10-01 Tom Tromey <tom@tromey.com>
445
446 * p-lang.c (pascal_printstr): Use metadata style.
447 * value.c (show_convenience): Use metadata style.
448 * valprint.c (valprint_check_validity, val_print_optimized_out)
449 (val_print_not_saved, val_print_unavailable)
450 (val_print_invalid_address, generic_val_print, val_print)
451 (value_check_printable, val_print_array_elements): Use metadata
452 style.
453 * ui-out.h (class ui_out) <field_fmt>: New overload.
454 <do_field_fmt>: Add style parameter.
455 * ui-out.c (ui_out::field_fmt): New overload.
456 * typeprint.c (type_print_unknown_return_type)
457 (val_print_not_allocated, val_print_not_associated): Use metadata
458 style.
459 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
460 parameter.
461 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
462 * tracepoint.c (tvariables_info_1): Use metadata style.
463 * stack.c (print_frame_arg, print_frame_info, print_frame)
464 (info_frame_command_core): Use metadata style.
465 * skip.c (info_skip_command): Use metadata style.
466 * rust-lang.c (rust_print_enum): Use metadata style.
467 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
468 metadata style.
469 * python/py-framefilter.c (py_print_single_arg): Use metadata
470 style.
471 * printcmd.c (do_one_display, print_variable_and_value): Use
472 metadata style.
473 * p-valprint.c (pascal_val_print)
474 (pascal_object_print_value_fields): Use metadata style.
475 * p-typeprint.c (pascal_type_print_base): Use metadata style.
476 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
477 parameter.
478 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
479 * m2-valprint.c (m2_print_long_set): Use metadata style.
480 * m2-typeprint.c (m2_print_type): Use metadata style.
481 * infcmd.c (print_return_value_1): Use metadata style.
482 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
483 * f-valprint.c (info_common_command_for_block): Use metadata
484 style.
485 * f-typeprint.c (f_type_print_base): Use metadata style.
486 * expprint.c (print_subexp_standard): Use metadata style.
487 * cp-valprint.c (cp_print_value_fields): Use metadata style.
488 * cli/cli-style.h (class cli_style_option): Add constructor.
489 (metadata_style): Declare.
490 * cli/cli-style.c (metadata_style): New global.
491 (_initialize_cli_style): Register metadata style.
492 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
493 parameter.
494 * cli-out.c (cli_ui_out::do_field_fmt): Update.
495 * c-typeprint.c (c_type_print_base_struct_union)
496 (c_type_print_base_1): Use metadata style.
497 * breakpoint.c (watchpoint_value_print)
498 (print_one_breakpoint_location): Use metadata style.
499 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
500 style.
501 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
502 style.
503 * ada-valprint.c (val_print_packed_array_elements, printstr)
504 (print_field_values, ada_val_print_ref, ada_val_print): Use
505 metadata style.
506 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
507 style.
508 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
509 style.
510 * ada-lang.c (user_select_syms): Use metadata style.
511
14309bb6
TT
5122019-10-01 Tom Tromey <tom@tromey.com>
513
514 * cli/cli-cmds.c (pwd_command): Style output.
515
6a831f06
PA
5162019-10-01 Pedro Alves <palves@redhat.com>
517 Tom Tromey <tom@tromey.com>
518
519 * symtab.c (print_symbol_info): Use %ps.
520 (print_msymbol_info): Use %ps.
521 * symfile.c (symbol_file_add_with_addrs): Use %ps.
522 * printcmd.c (print_variable_and_value): Use %ps.
523 * macrocmd.c (show_pp_source_pos): Use %ps.
524 * infrun.c (print_exited_reason): Use ui_out::message.
525 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
526 (describe_other_breakpoints): Use ui_out::message and new
527 formats.
528 (say_where): Use new formats.
529 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
530 and new formats.
531
2a3c1174
PA
5322019-10-01 Pedro Alves <palves@redhat.com>
533 Tom Tromey <tom@tromey.com>
534
535 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
536 (test_gdb_formats): New function.
537 (run_tests): Call it.
538 (test_format_specifier): Update.
539 * utils.h (fputs_filtered): Update comment.
540 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
541 (fputs_styled_unfiltered): Declare.
542 * utils.c (fputs_styled_unfiltered): New function.
543 (vfprintf_maybe_filtered): Add gdbfmt parameter.
544 (vfprintf_filtered): Update.
545 (vfprintf_unfiltered, vprintf_filtered): Update.
546 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
547 * ui-out.h (enum ui_out_flag) <unfiltered_output,
548 disallow_ui_out_field>: New constants.
549 (enum class field_kind): New.
550 (struct base_field_s, struct signed_field_s): New.
551 (signed_field): New function.
552 (struct string_field_s): New.
553 (string_field): New function.
554 (struct styled_string_s): New.
555 (styled_string): New function.
556 (class ui_out) <message>: Add comment.
557 <vmessage, call_do_message>: New methods.
558 <do_message>: Add style parameter.
559 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
560 methods.
561 (ui_out::message): Rewrite.
562 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
563 parameter.
564 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
565 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
566 gdb_extensions parameter.
567 (class format_piece): Add parameter to constructor.
568 (n_int_args): New field.
569 * gdbsupport/format.c (format_pieces::format_pieces): Add
570 gdb_extensions parameter. Handle '*'.
571 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
572 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
573 vfprintf_styled_no_gdbfmt.
574 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
575 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
576 unfiltered output.
577 * ui-style.h (struct ui_file_style) <ptr>: New method.
578
0dfe5bfb
TT
5792019-10-01 Tom Tromey <tom@tromey.com>
580
581 * unittests/format_pieces-selftests.c: Update. Add final format.
582 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
583 empty literal pieces.
584
e43b10e1
TT
5852019-10-01 Tom Tromey <tom@tromey.com>
586
587 * ui-out.h (enum class ui_out_style_kind): Remove.
588 (class ui_out) <field_string, field_stsream, do_field_string>:
589 Change type of "style".
590 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
591 (ui_out::field_string): Update.
592 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
593 of "style".
594 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
595 * tracepoint.c (print_one_static_tracepoint_marker): Update.
596 * stack.c (print_frame_arg, print_frame_info, print_frame):
597 Update.
598 * source.c (print_source_lines_base): Update.
599 * solib.c (info_sharedlibrary_command): Update.
600 * skip.c (info_skip_command): Update.
601 * record-btrace.c (btrace_call_history_src_line)
602 (btrace_call_history): Update.
603 * python/py-framefilter.c (py_print_frame): Update.
604 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
605 "style".
606 * mi/mi-out.c (mi_ui_out::do_table_header)
607 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
608 (mi_ui_out::do_field_string): Update.
609 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
610 Update.
611 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
612 "style".
613 * cli-out.c (cli_ui_out::do_table_header)
614 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
615 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
616 (cli_ui_out::do_field_fmt): Update.
617 * breakpoint.c (print_breakpoint_location): Update.
618 (update_static_tracepoint): Update.
619
cd7c32c3
PW
6202019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
621
622 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
623 conversion of gdb_datadir.
624 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
625 remove not needed c_str ().
626
8fe0f950
AT
6272019-09-30 Ali Tamur <tamur@google.com>
628
629 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
630 (dwarf2_string_attr): Likewise.
631
5f48f8f3
AT
6322019-09-30 Ali Tamur <tamur@google.com>
633
634 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
635 (process_full_type_unit): Likewise.
636 (dump_die_shallow): Likewise.
637 (cu_debug_loc_section): Likewise.
638
6fb08628
CB
6392019-09-28 Christian Biesinger <cbiesinger@google.com>
640
641 * minsyms.c (compare_minimal_symbols): Rename to...
642 (minimal_symbol_is_less_than): ...this, and adjust to STL
643 conventions (return bool, take arguments as references)
644 (minimal_symbol_reader::install): Call std::sort instead
645 of qsort.
646
c7ee338a
CB
6472019-09-29 Christian Biesinger <cbiesinger@google.com>
648
649 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
650 hash and why.
651 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
652 msymbol_hash, msymbol_demangled_hash>: Improve comments.
653
703a86c2
SM
6542019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
655
656 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
657 * psympriv.h (add_psymbol_to_list): Move comment here and update
658 it.
659
0df0352a
TV
6602019-09-29 Tom de Vries <tdevries@suse.de>
661
662 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
663 Use $tmpdir/$(basename "$output_file").dwz instead of
664 "${output_file}.dwz".
665
ad75efa6
SM
6662019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
667
668 PR gdb/25045
669 * hppa-linux-nat.c: Include gdbarch.h.
670
ececd218
CB
6712019-09-26 Christian Biesinger <cbiesinger@google.com>
672
673 * blockframe.c (find_pc_partial_function): Change return type to bool.
674 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
675 * minsyms.c (in_gnu_ifunc_stub): Likewise.
676 (stub_gnu_ifunc_resolve_name): Likewise.
677 * symtab.c (compare_filenames_for_search): Likewise.
678 (compare_glob_filenames_for_search): Likewise.
679 (matching_obj_sections): Likewise.
680 (symbol_matches_domain): Likewise.
681 (find_line_symtab): Change out param EXACT_MATCH to bool *.
682 (find_line_pc): Change return type to bool.
683 (find_line_pc_range): Likewise.
684 (producer_is_realview): Likewise.
685 * symtab.h (symbol_matches_domain): Likewise.
686 (find_pc_partial_function): Likewise.
687 (find_pc_line_pc_range): Likewise.
688 (in_gnu_ifunc_stub): Likewise.
689 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
690 (find_line_pc): Likewise.
691 (find_line_pc_range): Likewise.
692 (matching_obj_sections): Likewise.
693 (find_line_symtab): Change out parameter to bool.
694 (producer_is_realview): Change return type to bool.
695 (compare_filenames_for_search): Likewise.
696 (compare_glob_filenames_for_search): Likewise.
697
27a900b8
TT
6982019-09-26 Tom Tromey <tom@tromey.com>
699
700 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
701 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
702 * gdb_usleep.h: Remove.
703 * gdb_usleep.c: Remove.
704 * utils.c: Don't include gdb_usleep.h.
705
5d63b30a
TT
7062019-09-26 Tom Tromey <tromey@adacore.com>
707
708 * python/py-type.c (type_to_type_object): Call check_typedef
709 for stub types.
710
12904d37
TT
7112019-09-26 Tom Tromey <tom@tromey.com>
712
713 * utils.h (initialize_utils): Don't declare.
714 * top.c (gdb_init): Don't call initialize_utils.
715 * utils.c (initialize_utils): Remove. Move contents...
716 (_initialize_utils): ... here.
717
858f25f0
TT
7182019-09-25 Tom Tromey <tom@tromey.com>
719
720 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
721 * utils.h (make_hex_string): Don't declare.
722 * utils.c (make_hex_string): Remove.
723
3d435220
TV
7242019-09-24 Tom de Vries <tdevries@suse.de>
725
726 PR gdb/23815
727 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
728 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
729
ddd44b70
DD
7302019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
731
732 * NEWS: Mention new simulator port for PRU.
733
f945dedf
CB
7342019-09-23 Christian Biesinger <cbiesinger@google.com>
735
736 * ada-exp.y (write_object_remaining): Update.
737 * ada-lang.c (ada_decode): Return a std::string instead of a char*
738 and eliminate the static buffer.
739 (ada_decode_symbol): Update.
740 (ada_la_decode): Update.
741 (ada_sniff_from_mangled_name): Update.
742 (is_valid_name_for_wild_match): Update.
743 (ada_lookup_name_info::matches): Update and simplify.
744 (name_matches_regex): Update.
745 (ada_add_global_exceptions): Update.
746 * ada-lang.h (ada_decode): Update signature.
747 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
748 * dwarf-index-write.c (debug_names::insert): Update.
749
7ab78ccb
SM
7502019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
751
752 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
753 formatting.
754
9252448b
SM
7552019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
756
757 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
758 Change "nonzero" to "true" in documentation.
759
626ca2c0
CB
7602019-09-20 Christian Biesinger <cbiesinger@google.com>
761
762 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
763 (_initialize_darwin_solib): Don't set
764 darwin_so_ops.lookup_lib_global_symbol.
765 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
766 set_gdbarch_iterate_over_objfiles_in_search_order.
767 (elf_lookup_lib_symbol): Rename to...
768 (svr4_iterate_over_objfiles_in_search_order): this, and update
769 to iterate semantics.
770 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
771 * solib.c (solib_global_lookup): Remove.
772 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
773 (solib_global_lookup): Remove.
774 * symtab.c (lookup_global_or_static_symbol): Remove call to
775 solib_global_lookup.
776
5a3a0d63
JB
7772019-09-20 Joel Brobecker <brobecker@adacore.com>
778
779 * NEWS: Move entries about default MI version now being
780 version 3, and about the GDB/MI fix for multi-location
781 breakpoints to the "since GDB 8.3" section.
782
ffea1427
JB
7832019-09-20 Joel Brobecker <brobecker@adacore.com>
784
785 GDB 8.3.1 released.
786
abf516c6
UW
7872019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
788
789 * NEWS: Mention that Cell/B.E. debugging support was removed.
790 * MAINTAINERS: Remove spu target.
791
792 * config/djgpp/fnchange.lst: Remove entries for removed files.
793
794 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
795 spu-multiarch.o, and spu-tdep.o.
796 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
797 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
798 spu-multiarch.c, and spu-tdep.c.
799 * spu-linux-nat.c: Remove file.
800 * spu-multiarch.c: Remove file.
801 * spu-tdep.c: Remove file.
802 * spu-tdep.h: Remove file.
803 * solib-spu.c: Remove file.
804 * solib-spu.h: Remove file.
805
806 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
807 * configure.nat (spu-linux): Remove.
808 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
809 solib-multiarch.o from gdb_target_obs.
810 (spu*-*-*): Remove.
811
812 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
813 feature flag.
814 (ppc_linux_no_features): Update.
815 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
816 Cell/B.E. support.
817 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
818 (tdesc_powerpc_cell64l): Likewise.
819 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
820 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
821 Cell/B.E. support.
822 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
823 Do not include "features/rs6000/powerpc-cell32l.c" or
824 "features/rs6000/powerpc-cell64l.c".
825 (ppc_linux_spu_section): Remove.
826 (ppc_linux_core_read_description): Remove Cell/B.E. support.
827 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
828 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
829 (ppc_linux_spe_context_lookup): Remove.
830 (ppc_linux_spe_context_inferior_created): Remove.
831 (ppc_linux_spe_context_solib_loaded): Remove.
832 (ppc_linux_spe_context_solib_unloaded): Remove.
833 (ppc_linux_spe_context): Remove.
834 (struct ppu2spu_cache): Remove.
835 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
836 (struct ppu2spu_data): Remove.
837 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
838 ppu2spu_unwind): Remove.
839 (ppc_linux_init_abi): Remove Cell/B.E. support.
840 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
841
842 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
843 (rs6000/powerpc-cell64l-expedite): Likewise
844 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
845 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
846 rs6000/powerpc-cell64l.xml.
847 * features/rs6000/powerpc-cell32l.xml: Remove.
848 * features/rs6000/powerpc-cell64l.xml: Likewise.
849 * features/rs6000/powerpc-cell32l.c: Remove generated file.
850 * features/rs6000/powerpc-cell64l.c: Likewise.
851 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
852 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
853 * regformats/reg-spu.dat: Remove.
854
855 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
856 * corelow.c (struct spuid_list): Remove.
857 (add_to_spuid_list): Remove.
858 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
859 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
860 (remote_protocol_features): Remove associated entries.
861 (_initialize_remote): No longer initialize them.
862 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
863 * linux-nat.c (SPUFS_MAGIC): Remove.
864 (linux_proc_xfer_spu): Remove.
865 (spu_enumerate_spu_ids): Remove.
866 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
867 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
868 (linux_make_corefile_notes): No longer call it.
869
870 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
871 (cooked_write_test): Likewise.
872
78e8cb91
TT
8732019-09-20 Tom Tromey <tom@tromey.com>
874
875 * NEWS: Mention case-sensitivity of TUI commands.
876 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
877 (tui_set_win_height_command, parse_scrolling_args): Likewise.
878 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
879
f074b67e
TT
8802019-09-20 Tom Tromey <tom@tromey.com>
881
882 * tui/tui-source.c (tui_source_window::set_contents): Use
883 make_unique_xstrdup.
884 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
885 make_unique_xstrdup.
886
63c4bf19
TT
8872019-09-20 Tom Tromey <tom@tromey.com>
888
889 * tui/tui-data.c: Remove separator comments.
890 * tui/tui-layout.c: Remove separator comments.
891 * tui/tui-win.c: Remove separator comments.
892 * tui/tui-wingeneral.c: Remove separator comments.
893
43df9b2f
TT
8942019-09-20 Tom Tromey <tom@tromey.com>
895
896 * tui/tui.h (strcat_to_buf): Don't declare.
897 * tui/tui.c (strcat_to_buf): Remove.
898
7226433c
TT
8992019-09-20 Tom Tromey <tom@tromey.com>
900
901 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
902 from "fullname".
903 * tui/tui-source.c (tui_source_window::set_contents)
904 (tui_source_window::location_matches_p)
905 (tui_source_window::maybe_update): Update.
906
80df3337
TT
9072019-09-20 Tom Tromey <tom@tromey.com>
908
909 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
910 Update.
911 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
912 prefix.
913 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
914 (tui_data_window::line_from_reg_element_no)
915 (tui_data_window::first_reg_element_no_inline)
916 (tui_data_window::show_registers)
917 (tui_data_window::show_register_group)
918 (tui_data_window::display_registers_from)
919 (tui_data_window::display_registers_from_line)
920 (tui_data_window::first_data_item_displayed)
921 (tui_data_window::delete_data_content_windows)
922 (tui_data_window::erase_data_content)
923 (tui_data_window::do_scroll_vertical)
924 (tui_data_window::refresh_window)
925 (tui_data_window::check_register_values): Update.
926
9923f347
TT
9272019-09-20 Tom Tromey <tom@tromey.com>
928
929 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
930 (struct tui_locator_window) <full_name, proc_name>: Now
931 std::string.
932 * tui/tui-stack.c (tui_locator_window::make_status_line)
933 (tui_locator_window::set_locator_fullname)
934 (tui_locator_window::set_locator_info): Update.
935 * tui/tui-source.c (tui_source_window::set_contents)
936 (tui_source_window::showing_source_p): Update.
937
b76251ab
TT
9382019-09-20 Tom Tromey <tom@tromey.com>
939
940 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
941 Don't call tui_locator_win_info_ptr.
942
0891be08
TT
9432019-09-20 Tom Tromey <tom@tromey.com>
944
945 * tui/tui-win.c (tui_resize_all): Don't call refresh.
946
1b935acf
TT
9472019-09-20 Tom Tromey <tom@tromey.com>
948
949 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
950 height for locator.
951 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
952 * tui/tui-layout.c (show_source_disasm_command, show_data)
953 (show_source_or_disasm_and_command): Use 1 as height for locator.
954
9abd8a65
TT
9552019-09-20 Tom Tromey <tom@tromey.com>
956
957 * tui/tui.c (tui_enable): Update.
958 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
959 Update.
960 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
961 Update.
962 * tui/tui-data.c (win_resized): Now bool.
963 (tui_win_resized): Return bool.
964 (tui_set_win_resized_to): Accept a bool.
965
b5457826
TT
9662019-09-20 Tom Tromey <tom@tromey.com>
967
968 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
969 Change type of "refresh_values_only".
970 * tui/tui-regs.c (tui_data_window::show_register_group): Change
971 type of "refresh_values_only".
972
6b915f7d
TT
9732019-09-20 Tom Tromey <tom@tromey.com>
974
975 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
976 std::string.
977 (tui_disassemble): Add "pos" parameter.
978 (tui_disasm_window::set_contents): Simplify.
979
2ad52f6f
TT
9802019-09-20 Tom Tromey <tom@tromey.com>
981
982 * tui/tui-winsource.h (struct tui_source_window_base)
983 <show_source_content>: Now private.
984 * tui/tui-winsource.c
985 (tui_source_window_base::show_source_content): Don't handle empty
986 content case.
987
b3b1bde6
TT
9882019-09-20 Tom Tromey <tom@tromey.com>
989
990 * tui/tui-layout.c (show_source_disasm_command)
991 (show_source_or_disasm_and_command): Don't call
992 show_source_content.
993
71a25ed2
TT
9942019-09-20 Tom Tromey <tom@tromey.com>
995
996 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
997 Declare.
998 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
999 from tui_make_status_line.
1000 (tui_locator_window::rerender): Update.
1001
f8532154
TT
10022019-09-20 Tom Tromey <tom@tromey.com>
1003
1004 * tui/tui-stack.c (tui_make_status_line): Return std::string.
1005 (tui_locator_window::rerender): Update.
1006
2d81b349
TT
10072019-09-20 Tom Tromey <tom@tromey.com>
1008
1009 * tui/tui-winsource.h (struct tui_source_window_base)
1010 <~tui_source_window_base>: Don't declare.
1011 <fullname>: Remove.
1012 * tui/tui-winsource.c (~tui_source_window_base): Remove.
1013 * tui/tui-source.h (struct tui_source_window) <fullname>: New
1014 member.
1015 * tui/tui-source.c (tui_source_window::set_contents): Update.
1016 (tui_source_window::location_matches_p)
1017 (tui_source_window::maybe_update): Update.
1018
f14bec58
TT
10192019-09-20 Tom Tromey <tom@tromey.com>
1020
1021 * tui/tui-winsource.h (~tui_source_element): Remove.
1022 (tui_source_element): Update.
1023 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1024 * tui/tui-winsource.c (tui_show_source_line): Update.
1025 * tui/tui-source.c (tui_source_window::set_contents): Update.
1026 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1027
78d5933a
TT
10282019-09-20 Tom Tromey <tom@tromey.com>
1029
1030 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1031 declare.
1032 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1033 tui_clear_source_windows_detail.
1034 * tui/tui-winsource.h (struct tui_source_window_base)
1035 <clear_detail>: Don't declare.
1036 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1037 Remove.
1038 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1039
d4207696
TT
10402019-09-20 Tom Tromey <tromey@adacore.com>
1041
1042 PR ada/24919:
1043 * block.c (contained_in): Fix final return value.
1044
00f93c44
AM
10452019-09-20 Alan Modra <amodra@gmail.com>
1046
1047 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1048 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1049 (read_indirect_string_from_dwz): Use bfd accessor.
1050 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1051 * machoread.c (macho_symfile_read_all_oso): Likewise.
1052 * solib.c (solib_bfd_open): Likewise.
1053
e4153ae6
CB
10542019-09-19 Christian Biesinger <cbiesinger@google.com>
1055
1056 * eval.c: Move declaration of overload_resolution to...
1057 * value.h: ...here.
1058
c7ae7675
CB
10592019-09-19 Christian Biesinger <cbiesinger@google.com>
1060
1061 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1062 * arm-linux-tdep.c: Likewise.
1063 * arm-nbsd-nat.c: Likewise.
1064 * arm-tdep.h: Declare arm_apcs_32.
1065 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1066
e86f08d2
CB
10672019-09-19 Christian Biesinger <cbiesinger@google.com>
1068
1069 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1070 * dwarf2read.h: Declare dwarf_always_disassemble.
1071
f64e2f40
TV
10722019-09-19 Tom de Vries <tdevries@suse.de>
1073
1074 PR gdb/25009
1075 * source-cache.c (source_cache::ensure): Catch exception thrown during
1076 construction of the highlighter.
1077
fd361982
AM
10782019-09-18 Alan Modra <amodra@gmail.com>
1079
1080 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1081 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1082 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1083 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1084 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1085 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1086 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1087 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1088 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1089 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1090 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1091 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1092 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1093 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1094 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1095 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1096 * mi/mi-interp.c: Update throughout for bfd section macro and
1097 function changes.
1098 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1099 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1100
11061048
TT
11012019-09-18 Tom Tromey <tom@tromey.com>
1102
1103 * NEWS: Add entry.
1104 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1105 call rl_initialize.
1106 (tui_enable): Do not call rl_initialize.
1107
7a27b85f
CG
11082019-09-18 Christian Groessler <chris@groessler.org>
1109
1110 * alpha-linux-nat.c: Include gdbarch.h.
1111
f64eea3a
SM
11122019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1113
1114 * ui-file.c: Include cli/cli-style.h.
1115 (term_cli_styling): Remove cli_styling declaration.
1116
e6f7f6d1
AM
11172019-09-18 Alan Modra <amodra@gmail.com>
1118
1119 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1120 to bfd_asymbol_section.
1121
1d38e9d1
AM
11222019-09-18 Alan Modra <amodra@gmail.com>
1123
1124 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1125 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1126 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1127
90d92a63
AM
11282019-09-18 Alan Modra <amodra@gmail.com>
1129
1130 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1131 * spu-linux-nat.c (spu_bfd_open): Likewise.
1132
a3d181d2
CB
11332019-09-18 Christian Biesinger <cbiesinger@google.com>
1134
1135 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1136 to bool to match definition in dwarf2read.c.
1137
491144b5
CB
11382019-09-17 Christian Biesinger <cbiesinger@google.com>
1139
1140 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1141 (print_signatures): Likewise.
1142 (trust_pad_over_xvs): Likewise.
1143 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1144 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1145 * arm-linux-nat.c (arm_apcs_32): Likewise.
1146 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1147 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1148 * arm-tdep.c (arm_debug): Likewise.
1149 (arm_apcs_32): Likewise.
1150 * auto-load.c (debug_auto_load): Likewise.
1151 (auto_load_gdb_scripts): Likewise.
1152 (global_auto_load): Likewise.
1153 (auto_load_local_gdbinit): Likewise.
1154 (auto_load_local_gdbinit_loaded): Likewise.
1155 * auto-load.h (global_auto_load): Likewise.
1156 (auto_load_local_gdbinit): Likewise.
1157 (auto_load_local_gdbinit_loaded): Likewise.
1158 * breakpoint.c (disconnected_dprintf): Likewise.
1159 (breakpoint_proceeded): Likewise.
1160 (automatic_hardware_breakpoints): Likewise.
1161 (always_inserted_mode): Likewise.
1162 (target_exact_watchpoints): Likewise.
1163 (_initialize_breakpoint): Update.
1164 * breakpoint.h (target_exact_watchpoints): Change to bool.
1165 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1166 * cli/cli-cmds.c (trace_commands): Likewise.
1167 * cli/cli-cmds.h (trace_commands): Likewise.
1168 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1169 to bool*.
1170 * cli/cli-logging.c (logging_overwrite): Change to bool.
1171 (logging_redirect): Likewise.
1172 (debug_redirect): Likewise.
1173 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1174 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1175 to bool.
1176 <boolean_option_def>: Update.
1177 (struct flag_option_def): Change default type of Context to bool
1178 from int.
1179 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1180 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1181 (get_setshow_command_value_string): Likewise.
1182 * cli/cli-style.c (cli_styling): Change to bool.
1183 (source_styling): Likewise.
1184 * cli/cli-style.h (source_styling): Likewise.
1185 (cli_styling): Likewise.
1186 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1187 to bool.
1188 * command.h (var_types): Update comment.
1189 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1190 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1191 bool.
1192 (debug_compile_cplus_scopes): Likewise.
1193 * compile/compile-internal.h (compile_debug): Likewise.
1194 * compile/compile.c (compile_debug): Likewise.
1195 (struct compile_options) <raw>: Likewise.
1196 * cp-support.c (catch_demangler_crashes): Likewise.
1197 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1198 (usr_cmd_cris_dwarf2_cfi): Likewise.
1199 * csky-tdep.c (csky_debug): Likewise.
1200 * darwin-nat.c (enable_mach_exceptions): Likewise.
1201 * dcache.c (dcache_enabled_p): Likewise.
1202 * defs.h (info_verbose): Likewise.
1203 * demangle.c (demangle): Likewise.
1204 (asm_demangle): Likewise.
1205 * dwarf-index-cache.c (debug_index_cache): Likewise.
1206 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1207 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1208 * dwarf2read.c (check_physname): Likewise.
1209 (use_deprecated_index_sections): Likewise.
1210 (dwarf_always_disassemble): Likewise.
1211 * eval.c (overload_resolution): Likewise.
1212 * event-top.c (set_editing_cmd_var): Likewise.
1213 (exec_done_display_p): Likewise.
1214 * event-top.h (set_editing_cmd_var): Likewise.
1215 (exec_done_display_p): Likewise.
1216 * exec.c (write_files): Likewise.
1217 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1218 (debug_fbsd_nat): Likewise.
1219 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1220 Likewise.
1221 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1222 <backtrace_past_entry> Likewise.
1223 * gdb-demangle.h (demangle): Likewise.
1224 (asm_demangle): Likewise.
1225 * gdb_bfd.c (bfd_sharing): Likewise.
1226 * gdbcore.h (write_files): Likewise.
1227 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1228 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1229 * gdbthread.h (print_thread_events): Likewise.
1230 * gdbtypes.c (opaque_type_resolution): Likewise.
1231 (strict_type_checking): Likewise.
1232 * gnu-nat.c (gnu_debug_flag): Likewise.
1233 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1234 * guile/scm-param.c (pascm_variable): Add boolval.
1235 (add_setshow_generic): Update.
1236 (pascm_param_value): Update.
1237 (pascm_set_param_value_x): Update.
1238 * hppa-tdep.c (hppa_debug): Change to bool..
1239 * infcall.c (may_call_functions_p): Likewise.
1240 (coerce_float_to_double_p): Likewise.
1241 (unwind_on_signal_p): Likewise.
1242 (unwind_on_terminating_exception_p): Likewise.
1243 * infcmd.c (startup_with_shell): Likewise.
1244 * inferior.c (print_inferior_events): Likewise.
1245 * inferior.h (startup_with_shell): Likewise.
1246 (print_inferior_events): Likewise.
1247 * infrun.c (step_stop_if_no_debug): Likewise.
1248 (detach_fork): Likewise.
1249 (debug_displaced): Likewise.
1250 (disable_randomization): Likewise.
1251 (non_stop): Likewise.
1252 (non_stop_1): Likewise.
1253 (observer_mode): Likewise.
1254 (observer_mode_1): Likewise.
1255 (set_observer_mode): Update.
1256 (sched_multi): Change to bool.
1257 * infrun.h (debug_displaced): Likewise.
1258 (sched_multi): Likewise.
1259 (step_stop_if_no_debug): Likewise.
1260 (non_stop): Likewise.
1261 (disable_randomization): Likewise.
1262 * linux-tdep.c (use_coredump_filter): Likewise.
1263 (dump_excluded_mappings): Likewise.
1264 * linux-thread-db.c (auto_load_thread_db): Likewise.
1265 (check_thread_db_on_load): Likewise.
1266 * main.c (captured_main_1): Update.
1267 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1268 xx2_opt, boolean_opt>: Change to bool.
1269 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1270 * maint.c (maintenance_profile_p): Likewise.
1271 (per_command_time): Likewise.
1272 (per_command_space): Likewise.
1273 (per_command_symtab): Likewise.
1274 * memattr.c (inaccessible_by_default): Likewise.
1275 * mi/mi-main.c (mi_async): Likewise.
1276 (mi_async_1): Likewise.
1277 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1278 * nat/fork-inferior.h (startup_with_shell): Likewise.
1279 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1280 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1281 * nios2-tdep.c (nios2_debug): Likewise.
1282 * or1k-tdep.c (or1k_debug): Likewise.
1283 * parse.c (parser_debug): Likewise.
1284 * parser-defs.h (parser_debug): Likewise.
1285 * printcmd.c (print_symbol_filename): Likewise.
1286 * proc-api.c (procfs_trace): Likewise.
1287 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1288 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1289 (set_parameter_value): Update.
1290 (add_setshow_generic): Update.
1291 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1292 to bool*.
1293 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1294 int*.
1295 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1296 * record-btrace.c (record_btrace_target::store_registers): Update.
1297 * record-full.c (record_full_memory_query): Change to bool.
1298 (record_full_stop_at_limit): Likewise.
1299 * record-full.h (record_full_memory_query): Likewise.
1300 * remote-notif.c (notif_debug): Likewise.
1301 * remote-notif.h (notif_debug): Likewise.
1302 * remote.c (use_range_stepping): Likewise.
1303 (interrupt_on_connect): Likewise.
1304 (remote_break): Likewise.
1305 * ser-tcp.c (tcp_auto_retry): Likewise.
1306 * ser-unix.c (serial_hwflow): Likewise.
1307 * skip.c (debug_skip): Likewise.
1308 * solib-aix.c (solib_aix_debug): Likewise.
1309 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1310 (spu_auto_flush_cache_p): Likewise.
1311 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1312 Likewise.
1313 (struct info_print_options) <quiet>: Likewise.
1314 * symfile-debug.c (debug_symfile): Likewise.
1315 * symfile.c (auto_solib_add): Likewise.
1316 (separate_debug_file_debug): Likewise.
1317 * symfile.h (auto_solib_add): Likewise.
1318 (separate_debug_file_debug): Likewise.
1319 * symtab.c (basenames_may_differ): Likewise.
1320 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1321 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1322 (struct info_types_options) <quiet>: Likewise.
1323 * symtab.h (demangle): Likewise.
1324 (basenames_may_differ): Likewise.
1325 * target-dcache.c (stack_cache_enabled_1): Likewise.
1326 (code_cache_enabled_1): Likewise.
1327 * target.c (trust_readonly): Likewise.
1328 (may_write_registers): Likewise.
1329 (may_write_memory): Likewise.
1330 (may_insert_breakpoints): Likewise.
1331 (may_insert_tracepoints): Likewise.
1332 (may_insert_fast_tracepoints): Likewise.
1333 (may_stop): Likewise.
1334 (auto_connect_native_target): Likewise.
1335 (target_stop_and_wait): Update.
1336 (target_async_permitted): Change to bool.
1337 (target_async_permitted_1): Likewise.
1338 (may_write_registers_1): Likewise.
1339 (may_write_memory_1): Likewise.
1340 (may_insert_breakpoints_1): Likewise.
1341 (may_insert_tracepoints_1): Likewise.
1342 (may_insert_fast_tracepoints_1): Likewise.
1343 (may_stop_1): Likewise.
1344 * target.h (target_async_permitted): Likewise.
1345 (may_write_registers): Likewise.
1346 (may_write_memory): Likewise.
1347 (may_insert_breakpoints): Likewise.
1348 (may_insert_tracepoints): Likewise.
1349 (may_insert_fast_tracepoints): Likewise.
1350 (may_stop): Likewise.
1351 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1352 (make_thread_apply_all_options_def_group): Change argument from int*
1353 to bool*.
1354 (thread_apply_all_command): Update.
1355 (print_thread_events): Change to bool.
1356 * top.c (confirm): Likewise.
1357 (command_editing_p): Likewise.
1358 (history_expansion_p): Likewise.
1359 (write_history_p): Likewise.
1360 (info_verbose): Likewise.
1361 * top.h (confirm): Likewise.
1362 (history_expansion_p): Likewise.
1363 * tracepoint.c (disconnected_tracing): Likewise.
1364 (circular_trace_buffer): Likewise.
1365 * typeprint.c (print_methods): Likewise.
1366 (print_typedefs): Likewise.
1367 * utils.c (debug_timestamp): Likewise.
1368 (sevenbit_strings): Likewise.
1369 (pagination_enabled): Likewise.
1370 * utils.h (sevenbit_strings): Likewise.
1371 (pagination_enabled): Likewise.
1372 * valops.c (overload_resolution): Likewise.
1373 * valprint.h (struct value_print_options) <prettyformat_arrays,
1374 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1375 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1376 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1377 Likewise.
1378 * windows-nat.c (new_console): Likewise.
1379 (cygwin_exceptions): Likewise.
1380 (new_group): Likewise.
1381 (debug_exec): Likewise.
1382 (debug_events): Likewise.
1383 (debug_memory): Likewise.
1384 (debug_exceptions): Likewise.
1385 (useshell): Likewise.
1386 * windows-tdep.c (maint_display_all_tib): Likewise.
1387 * xml-support.c (debug_xml): Likewise.
1388
f1b620e9
MG
13892019-09-17 Mike Gulick <mgulick@mathworks.com>
1390
1391 * source.c (prepare_path_for_appending): New function.
1392 (openp): Make use of new function.
1393 (find_and_open_source): Search for the compilation directory and
1394 source file as a relative path beneath the directory search path.
1395
67f3ed6a
AB
13962019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1397
1398 * source-cache.c (source_cache::get_line_charpos): Catch
1399 exceptions and return false, this matches the behaviour documented
1400 in the header file.
1401
74332189
JB
14022019-09-17 Joel Brobecker <brobecker@adacore.com>
1403
1404 * ada-tasks.c (info_task): Remove quoting of the task's name.
1405
f2f24aa9
CB
14062019-09-16 Christian Biesinger <cbiesinger@google.com>
1407
1408 * symfile.c (auto_solib_add): Replace comment with a reference
1409 to the header file.
1410
6a062a93
CB
14112019-09-14 Christian Biesinger <cbiesinger@google.com>
1412
1413 * NEWS: Mention that gdb can now be compiled with Python 3
1414 on Windows.
1415
ec6c8338
AB
14162019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1417
1418 * maint.c (maint_print_section_data::maint_print_section_data):
1419 Force use of 'float log10 (float)' by casting the argument to
1420 float.
1421
aa17805f
AB
14222019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1423
1424 * maint.c: Add 'cmath' include.
1425 (struct maint_print_section_data): New structure.
1426 (print_section_index): New function.
1427 (print_bfd_section_info): Add header comment, small whitespace
1428 cleanup, and update to call new print_section_index function.
1429 (print_objfile_section_info): Likewise.
1430 (maint_obj_section_from_bfd_section): New function.
1431 (print_bfd_section_info_maybe_relocated): New function.
1432 (maintenance_info_sections): Add header comment, always use
1433 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1434
3dd9bb46
AB
14352019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1436
1437 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1438 inner scope, add check that the objfile has psymtabs before
1439 checking psymtabs_addrmap.
1440 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1441
4993045d
PW
14422019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1443
1444 * NEWS: Announce that Ada task names are now shown at more places,
1445 and between quotes (except in info task output).
1446 * gdb/ada-tasks.c (task_to_str): New function.
1447 (display_current_task_id): Call task_to_str.
1448 (task_command_1): Likewise.
1449 (print_ada_task_info): In non-mi mode, Properly align headers and data
1450 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1451
7a289707
RO
14522019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1453
1454 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1455 prstatus.pr_lwp.pr_info instead of making it up.
1456
f2aec7f6
CB
14572019-09-11 Christian Biesinger <cbiesinger@google.com>
1458
1459 * auto-load.c (auto_load_expand_dir_vars): Update.
1460 * defs.h (gdb_datadir): Change to std::string.
1461 (python_libdir): Likewise.
1462 (relocate_gdb_directory): Change return type to std::string.
1463 * guile/guile.c (gdbscm_data_directory): Update.
1464 (initialize_scheme_side): Update.
1465 * jit.c (jit_reader_dir): Change to std::string.
1466 (jit_reader_load_command): Update.
1467 * main.c (gdb_datadir): Change to std::string.
1468 (python_libdir): Likewise.
1469 (set_gdb_data_directory): Update.
1470 (relocate_path): Change to return std::string.
1471 (relocate_gdb_directory): Change to return std::string.
1472 (relocate_gdbinit_path_maybe_in_datadir): Update.
1473 (captured_main_1): Update.
1474 * python/python.c (do_start_initialization): Update.
1475 * top.c (show_gdb_datadir): Update.
1476 * xml-syscall.c (xml_init_syscalls_info): Update.
1477 (init_syscalls_info): Update.
1478
9224a013
CB
14792019-09-11 Christian Biesinger <cbiesinger@google.com>
1480
1481 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1482 out of get_init_files.
1483 (get_init_files): Update.
1484
f48cd836
CB
14852019-09-11 Christian Biesinger <cbiesinger@google.com>
1486
1487 * main.c (get_init_files): Change to use std::string.
1488 (captured_main_1): Update.
1489 (print_gdb_help): Update.
1490
9cab7ecd
AT
14912019-09-11 Ali Tamur <tamur@google.com>
1492
1493 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1494 implementation.
1495
67547d89
CB
14962019-09-11 Christian Biesinger <cbiesinger@google.com>
1497
1498 * dbxread.c (read_dbx_symtab): Update.
1499 * dwarf2read.c (load_partial_dies): Update.
1500 * mdebugread.c (parse_partial_symbols): Update.
1501 (handle_psymbol_enumerators): Update.
1502 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1503 * psymtab.c (add_psymbol_to_bcache): Likewise.
1504 (add_psymbol_to_list): Likewise.
1505 * symtab.c (symbol_set_names): Likewise.
1506 * symtab.h (symbol_set_names): Likewise.
1507 * xcoffread.c (scan_xcoff_symtab): Update.
1508
64b2d4a0
TT
15092019-09-11 Tom Tromey <tom@tromey.com>
1510
1511 * symfile-mem.c (symbol_file_add_from_memory): Use
1512 bfd_set_filename.
1513 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1514 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1515
3b00ef10
TT
15162019-09-10 Tom Tromey <tromey@adacore.com>
1517
1518 * dwarf-index-write.c (write_psymbols): Extend error message.
1519 (debug_names::insert): Add Ada code.
1520 (debug_names::write_psymbols): Remove Ada check.
1521 (debug_names) <m_string_obstack>: New member.
1522 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1523 (gdb_index_symbol_name_matcher::matches): Remove.
1524 (mapped_index_base::find_name_components_bounds): Add "lang"
1525 parameter.
1526 (mapped_index_base::build_name_components): Also split names
1527 according to Ada syntax.
1528 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
1529 type of "match_callback".
1530 (check_match, check_find_bounds_finds)
1531 (dw2_expand_symtabs_matching): Update.
1532 (dw2_debug_names_iterator): Add new constructor.
1533 (dw2_debug_names_map_matching_symbols): New function.
1534 (dw2_debug_names_expand_symtabs_matching): Update.
1535 (dwarf2_debug_names_functions): Use
1536 dw2_debug_names_map_matching_symbols.
1537
aa391654
TT
15382019-09-10 Tom Tromey <tromey@adacore.com>
1539
1540 * dwarf2read.c (dw2_get_file_names_reader): Add the
1541 CU's file name to the results.
1542
b054970d
TT
15432019-09-10 Tom Tromey <tromey@adacore.com>
1544
1545 * ada-lang.c (add_nonlocal_symbols): Combine calls to
1546 map_matching_symbols. Update.
1547 * dwarf2read.c (dw2_map_matching_symbols): Update.
1548 * psymtab.c (match_partial_symbol): Change type; update.
1549 (psym_map_matching_symbols): Likewise.
1550 * symfile-debug.c (debug_qf_map_matching_symbols): Change
1551 type; update.
1552 * symfile.h (struct quick_symbol_functions)
1553 <map_matching_symbols>: Change "name" to be a lookup_name_info.
1554 Remove "match".
1555
6a3dbf1b
TT
15562019-09-10 Tom Tromey <tromey@adacore.com>
1557
1558 * psymtab.c (map_block): Remove.
1559 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1560 * symtab.c (iterate_over_symbols_terminated): New function.
1561 * symtab.c (iterate_over_symbols_terminated): Declare.
1562
6969f124
TT
15632019-09-10 Tom Tromey <tromey@adacore.com>
1564
1565 * ada-lang.c (ada_iterate_over_symbols): Return bool.
1566 * language.h (struct language_defn) <la_iterate_over_symbols>:
1567 Return bool.
1568 * symtab.c (iterate_over_symbols): Return bool.
1569 * symtab.h (iterate_over_symbols): Return bool.
1570
199b4314
TT
15712019-09-10 Tom Tromey <tromey@adacore.com>
1572
1573 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1574 (add_nonlocal_symbols): Update.
1575 * dwarf2read.c (dw2_map_matching_symbols): Change type.
1576 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1577 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1578 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1579 Change type of "callback". Remove "data".
1580
a084a2a6
AT
1581
15822019-09-09 Ali Tamur <tamur@google.com>
1583
1584 * dwarf2read.c (comp_unit_head): Update comment.
1585 (dwarf2_dwo_name): New function declaration.
1586 (dwarf_unit_type_name): New function declaration.
1587 (read_comp_unit_head): Add support for new compilation units,
1588 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1589 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1590 (currently named as "signature") in their header. Also clarify error
1591 messages.
1592 (lookup_dwo_id): New function. Returns the dwo id of the given
1593 compile unit.
1594 (lookup_dwo_unit): Use the new lookup_dwo_id function.
1595 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1596 functions.
1597 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1598 (dwarf2_dwo_name): Get the dwo name if present.
1599 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1600 purposes.
1601
25a2915e
TT
16022019-09-09 Tom Tromey <tom@tromey.com>
1603
1604 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1605
e4df0874
PW
16062019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1607
1608 * python/python.c (do_start_initialization): Make progname_copy static,
1609 to avoid a leak report.
1610
8634b462
TT
16112019-09-08 Tom Tromey <tom@tromey.com>
1612
1613 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1614
c7f839cb
SM
16152019-09-07 Simon Marchi <simon.marchi@efficios.com>
1616
1617 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1618 Change type to gdb::optional<block_enum>.
1619 (dw2_symtab_iter_init): Change block_index parameter type
1620 to gdb::optional<block_enum>.
1621 (dw2_lookup_symbol): Change block_index parameter
1622 type to block_enum.c
1623 (dw2_debug_names_lookup_symbol): Likewise.
1624 * psymtab.c (psym_lookup_symbol): Likewise.
1625 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1626 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1627 Likewise.
1628
ead0e69a
CB
16292019-09-06 Christian Biesinger <cbiesinger@google.com>
1630
1631 * defs.h (relocate_gdb_directory): Change int to bool in
1632 signature and rename flag to relocatable.
1633 * main.c (relocate_path): Likewise.
1634 (relocate_gdb_directory): Likewise.
1635
b16c44de
AM
16362019-09-06 Alan Modra <amodra@gmail.com>
1637
1638 * coffread.c (coff_symfile_read): Constify filename variable.
1639 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1640 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1641 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1642 * solib.c (reload_shared_libraries_1): Likewise.
1643 * symfile.c (reread_symbols): Likewise.
1644 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1645 * solib-darwin.c (darwin_bfd_open): Likewise.
1646 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1647
06ff036e
AB
16482019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
1649
1650 * psymtab.c (print_partial_symbols): Handle missing domain_enum
1651 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1652
4e962e74
TT
16532019-09-03 Tom Tromey <tromey@adacore.com>
1654
1655 * ada-valprint.c (ada_val_print_num): Don't recurse for range
1656 types.
1657 (has_negatives): Unbias a range type bound.
1658 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1659 * gdbtypes.c (operator==): Handle new field.
1660 (create_range_type): Add "bias" parameter.
1661 (create_static_range_type, resolve_dynamic_range): Update.
1662 * gdbtypes.h (struct range_bounds) <bias>: New member.
1663 (create_range_type): Add bias parameter.
1664 * printcmd.c (print_scalar_formatted): Unbias range types.
1665 * value.c (unpack_long): Unbias range types.
1666 (pack_long): Bias range types.
1667
d90b8f26
AH
16682019-09-02 Alan Hayward <alan.hayward@arm.com>
1669
1670 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1671 probe arguments.
1672
fe01123e
AH
16732019-09-02 Alan Hayward <alan.hayward@arm.com>
1674
1675 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1676 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1677 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1678 (compile_probe_arg): Likewise.
1679 * probe.h (get_argument_count): Likewise.
1680 * solib-svr4.c (solib_event_probe_action): Likewise.
1681 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1682
e661ef01
AH
16832019-09-02 Alan Hayward <alan.hayward@arm.com>
1684
1685 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1686 code to here...
1687 (svr4_create_solib_event_breakpoints): ...from here.
1688
47a536d9
SDJ
16892019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1690
1691 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1692 suffix from warning message.
1693
d6a00eba
TT
16942019-08-30 Tom Tromey <tom@tromey.com>
1695
1696 * tui/tui-winsource.h (struct tui_source_window_base)
1697 <refresh_all>: Don't declare.
1698 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1699 Remove.
1700 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1701 tui_show_locator_content.
1702 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1703 declare.
1704 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1705 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1706 declare.
1707
55b2657b
TT
17082019-08-30 Tom Tromey <tom@tromey.com>
1709
1710 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1711
12a8555a
TT
17122019-08-30 Tom Tromey <tom@tromey.com>
1713
1714 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1715 Remove unnecessary forward declarations.
1716
900ac242
TT
17172019-08-30 Tom Tromey <tom@tromey.com>
1718
1719 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1720 rerender.
1721 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1722 tui_show_locator_content.
1723
99ab33fb
TT
17242019-08-30 Tom Tromey <tom@tromey.com>
1725
1726 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1727 (tui_locator_window::rerender): Rewrite using body of previous
1728 tui_show_locator_content.
1729
e594a5d1
TT
17302019-08-30 Tom Tromey <tom@tromey.com>
1731
1732 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1733 set_locator_fullname>: New methods.
1734 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1735 Rename from tui_set_locator_fullname.
1736 (tui_locator_window::set_locator_info): Rename from
1737 tui_set_locator_info. Return bool.
1738 (tui_update_locator_fullname, tui_show_frame_info): Update.
1739
715bb467
TT
17402019-08-30 Tom Tromey <tom@tromey.com>
1741
1742 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1743
772f3f03
TT
17442019-08-30 Tom Tromey <tom@tromey.com>
1745
1746 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1747 call touchwin.
1748
108e13ab
TT
17492019-08-30 Tom Tromey <tom@tromey.com>
1750
1751 * tui/tui-wingeneral.c (box_win): Assume win_info and
1752 win_info->handle cannot be NULL.
1753
cdaa6eb4
TT
17542019-08-30 Tom Tromey <tom@tromey.com>
1755
1756 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1757 refresh_window>: Declare.
1758 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1759 resize.
1760 (tui_data_item_window::rerender): Rename from
1761 tui_display_register.
1762 (tui_data_item_window::refresh_window): New method.
1763 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1764 no-op.
1765
89df7f90
TT
17662019-08-30 Tom Tromey <tom@tromey.com>
1767
1768 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1769 regs_column_count, current_group>: Move later. Now private.
1770 <get_current_group>: New method.
1771 * tui/tui-regs.c (tui_reg_command): Update.
1772 * tui/tui-layout.c (tui_set_layout): Update.
1773
1bf2866a
TT
17742019-08-30 Tom Tromey <tom@tromey.com>
1775
1776 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1777 (tui_data_window::rerender): Don't call
1778 check_and_display_highlight_if_needed.
1779 (tui_data_window::refresh_all): Remove call to
1780 erase_data_content.
1781
0670413d
TT
17822019-08-30 Tom Tromey <tom@tromey.com>
1783
1784 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1785 (tui_data_window::display_registers_from)
1786 (tui_data_window::display_reg_element_at_line)
1787 (tui_data_window::display_registers_from_line): Remove checks of
1788 "empty".
1789
18bb55c7
TT
17902019-08-30 Tom Tromey <tom@tromey.com>
1791
1792 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1793 Don't declare.
1794 * tui/tui-regs.c (tui_data_window::show_registers): Call
1795 rerender.
1796 (tui_data_window::rerender): Rename from display_all_data.
1797 (tui_data_window::rerender): Remove old implementation.
1798
1f6d2f10
TT
17992019-08-30 Tom Tromey <tom@tromey.com>
1800
1801 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1802 text.
1803 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1804
16d01f9c
BW
18052019-08-29 Bernhard Wodok <barto@gmx.net>
1806 Sergio Durigan Junior <sergiodj@redhat.com>
1807
1808 PR win32/24284
1809 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1810
d8f27c60
AB
18112019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1812
1813 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1814 when searching for types.
1815
1f20c35e
AB
18162019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1817
1818 * f-lang.c (f_language_defn): Use f_print_typedef.
1819 * f-lang.h (f_print_typedef): Declare.
1820 * f-typeprint.c (f_print_typedef): Define.
1821
550105b7
CB
18222019-08-27 Christian Biesinger <cbiesinger@google.com>
1823
1824 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1825
4acfdd20
AB
18262019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1827
1828 * cli/cli-utils.c (info_print_options_defs): Delete.
1829 (make_info_print_options_def_group): Delete.
1830 (extract_info_print_options): Delete.
1831 (info_print_command_completer): Delete.
1832 (info_print_args_help): Add extra parameter, and optionally
1833 include text about -n flag.
1834 * cli/cli-utils.h (struct info_print_options): Delete.
1835 (extract_info_print_options): Delete declaration.
1836 (info_print_command_completer): Delete declaration.
1837 (info_print_args_help): Add extra parameter, extend header
1838 comment.
1839 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1840 search_symbols.
1841 * stack.c (struct info_print_options): New type.
1842 (info_print_options_defs): New file scoped variable.
1843 (make_info_print_options_def_group): New static function.
1844 (info_print_command_completer): New static function.
1845 (info_locals_command): Update to use new local functions.
1846 (info_args_command): Likewise.
1847 (_initialize_stack): Add extra parameter to calls to
1848 info_print_args_help.
1849 * symtab.c (search_symbols): Add extra parameter, use this to
1850 possibly excluse non-debug symbols.
1851 (symtab_symbol_info): Add extra parameter, which is passed on to
1852 search_symbols.
1853 (struct info_print_options): New type.
1854 (info_print_options_defs): New file scoped variable.
1855 (make_info_print_options_def_group): New static function.
1856 (info_print_command_completer): New static function.
1857 (info_variables_command): Update to use local functions, and pass
1858 extra parameter through to symtab_symbol_info.
1859 (info_functions_command): Likewise.
1860 (info_types_command): Pass additional argument through to
1861 symtab_symbol_info.
1862 (rbreak_command): Pass extra argument to search_symbols.
1863 (_initialize_symtab): Add extra arguments for calls to
1864 info_print_args_help, and update help text for 'info variables',
1865 'whereis', and 'info functions' commands.
1866 * symtab.h (search_symbols): Add extra argument to declaration.
1867 * NEWS: Mention new flags.
1868
9aa55206
CB
18692019-08-26 Christian Biesinger <cbiesinger@google.com>
1870
1871 * symtab.c (lookup_static_symbol): Call the new function (and move
1872 it down to be next to lookup_global_symbol).
1873 (struct global_sym_lookup_data): Add block_enum member and rename to...
1874 (struct global_or_static_sym_lookup_data): ...this.
1875 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1876 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1877 (lookup_symbol_global_or_static_iterator_cb): ...this.
1878 (lookup_global_or_static_symbol): New function.
1879 (lookup_global_symbol): Call new function.
1880
5c31b358
TV
18812019-08-26 Tom de Vries <tdevries@suse.de>
1882
1883 PR c++/24852
1884 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1885 when pc_probe.prob == NULL.
1886
23c13d42
SM
18872019-08-25 Simon Marchi <simon.marchi@efficios.com>
1888
1889 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1890 variable symbol_linkage to symbol_linkage_.
1891
beadd3e8
SM
18922019-08-25 Simon Marchi <simon.marchi@efficios.com>
1893
1894 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1895 represent whether the symbol is static, dynamic, or we don't
1896 know.
1897
e3ec872f
YS
18982019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1899
1900 * gdb/rx-tdep.c (rx_register_names): New.
1901 (rx_register_name): Delete.
1902 (rx_psw_type): Delete.
1903 (rx_fpsw_type): Delete.
1904 (rx_register_type): Delete.
1905 (rx_gdbarch_init): Convert target-descriptions.
1906 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1907 * gdb/features/Makefile: Add rx.xml.
1908 * gdb/features/rx.xml: New.
1909 * gdb/features/rx.c: Generated.
1910 * gdb/NEWS: Mention target description support.
1911
d0509ba4
CB
19122019-08-22 Christian Biesinger <cbiesinger@google.com>
1913
1914 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1915 *slot_ptr.
1916
2d41fa11
SDJ
19172019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1918
1919 * configure.ac: Don't check for 'dlfcn.h' (moved to
1920 gdbsupport/common.m4).
1921 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1922 'gdbsupport/'.
1923 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1924 * compile/compile-c-support.c: Include
1925 'gdbsupport/gdb-dlfcn.h'.
1926 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1927 * gdb-dlfcn.c: Move to...
1928 * gdbsupport/gdb-dlfcn.c: ... here.
1929 * gdb-dlfcn.h: Move to...
1930 * gdbsupport/gdb-dlfcn.h: ... here.
1931
de8af808
SL
19322019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1933
1934 * nios2-tdep.c (struct reg_value): Improve comments. Make
1935 the offset field signed.
1936
27204489
CB
19372019-08-22 Christian Biesinger <cbiesinger@google.com>
1938
1939 * python/lib/gdb/__init__.py (_execute_file): New function.
1940 * python/python.c (python_run_simple_file): Call gdb._execute_file
1941 on Windows.
1942
43771869
AB
19432019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1944
1945 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1946 all uses as this was never set to anything but a zero value.
1947
26c957f1
PA
19482019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1949
1950 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1951
c07aae6e
CB
19522019-08-21 Christian Biesinger <cbiesinger@google.com>
1953
1954 * tui/tui-data.h (tui_gen_win_info): Add an =default
1955 move constructor, required by some GCC versions.
1956
3960cb7a
JF
19572019-08-21 Jinke Fan <fanjinke51@yeah.net>
1958
1959 * go32-nat.c (go32_sysinfo): Add hygon_p.
1960
04c72a68
TT
19612019-08-20 Tom Tromey <tom@tromey.com>
1962
1963 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1964 line_from_reg_element_no, first_reg_element_no_inline,
1965 display_all_data, delete_data_content_windows,
1966 erase_data_content>: Now private.
1967
072272ce
TT
19682019-08-20 Tom Tromey <tom@tromey.com>
1969
1970 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1971 (tui_unhighlight_win, tui_highlight_win)
1972 (tui_win_info::make_window): Update.
1973 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1974
973961bd
TT
19752019-08-20 Tom Tromey <tom@tromey.com>
1976
1977 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1978 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1979 (MAX_PID_WIDTH): Move to tui-stack.c.
1980 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1981 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1982 (MAX_PID_WIDTH): Move from tui-data.h.
1983
ab0e1f1a
TT
19842019-08-20 Tom Tromey <tom@tromey.com>
1985
1986 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1987 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1988 (box_win): Update.
1989 (tui_gen_win_info::make_window): Rename from tui_make_window.
1990 (tui_win_info::make_window): New method.
1991 (tui_gen_win_info::make_visible): Update.
1992 * tui/tui-source.c (tui_source_window::set_contents): Update.
1993 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1994 (tui_data_window::display_registers_from): Update.
1995 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1996 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1997 Declare.
1998 <can_box>: Remove.
1999 <title>: Remove.
2000 (struct tui_win_info) <make_window>: Declare.
2001 <can_box>: Now virtual.
2002 <title>: New member.
2003 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2004 * tui/tui-command.c (tui_cmd_window::resize): Update.
2005
100c2bf3
TT
20062019-08-20 Tom Tromey <tom@tromey.com>
2007
2008 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2009 * tui/tui-regs.c (tui_data_window::show_registers): Update.
2010 (tui_data_window::check_register_values): Update.
2011
fa4dc567
TT
20122019-08-20 Tom Tromey <tom@tromey.com>
2013
2014 * tui/tui-regs.h (struct tui_data_window): Use
2015 DISABLE_COPY_AND_ASSIGN.
2016 <regs_content>: Change type, removing unique_ptr.
2017 <tui_data_window>: Add move constructor.
2018 * tui/tui-regs.c (tui_data_window::show_registers)
2019 (tui_data_window::show_register_group)
2020 (tui_data_window::display_registers_from)
2021 (tui_data_window::display_registers_from)
2022 (tui_data_window::first_data_item_displayed)
2023 (tui_data_window::delete_data_content_windows)
2024 (tui_data_window::rerender, tui_data_window::refresh_window)
2025 (tui_data_window::check_register_values): Update.
2026
ca02d7c8
TT
20272019-08-20 Tom Tromey <tom@tromey.com>
2028
2029 * tui/tui-regs.h (struct tui_data_window) <show_registers,
2030 show_register_group>: Declare.
2031 (tui_show_register_group): Don't declare.
2032 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2033 tui_show_registers.
2034 (tui_data_window::show_register_group): Rename from
2035 tui_show_register_group.
2036 (tui_data_window::check_register_values, tui_reg_command):
2037 Update.
2038 * tui/tui-layout.c (tui_set_layout): Update.
2039
63356bfd
TT
20402019-08-20 Tom Tromey <tom@tromey.com>
2041
2042 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2043 Declare.
2044 (tui_check_register_values): Don't declare.
2045 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2046 from tui_check_register_values.
2047 * tui/tui-hooks.c (tui_register_changed): Update.
2048
42cc14a7
TT
20492019-08-20 Tom Tromey <tom@tromey.com>
2050
2051 * tui/tui-regs.c (tui_reg_layout): Move later.
2052 (tui_show_registers): Don't enable TUI mode or change layout.
2053
b9ad3686
TT
20542019-08-20 Tom Tromey <tom@tromey.com>
2055
2056 * tui/tui-regs.h (struct tui_data_item_window)
2057 <~tui_data_item_window>: Remove.
2058 <content>: Now a unique_xmalloc_ptr.
2059 * tui/tui-regs.c (tui_register_format): Return a
2060 unique_xmalloc_ptr.
2061 (tui_get_register): Update.
2062 (~tui_data_item_window): Remove.
2063 (tui_data_window::display_registers_from, tui_display_register):
2064 Update.
2065 * tui/tui-io.h (tui_expand_tabs): Update.
2066 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2067 Remove "col" parameter.
2068
8e114aab
TT
20692019-08-20 Tom Tromey <tom@tromey.com>
2070
2071 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2072 field.
2073 * tui/tui-regs.c (~tui_data_item_window): Update.
2074
1a4f81dd
TT
20752019-08-20 Tom Tromey <tom@tromey.com>
2076
2077 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2078 earlier.
2079
0f8d8876
TT
20802019-08-20 Tom Tromey <tom@tromey.com>
2081
2082 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2083
605dc2c2
TT
20842019-08-20 Tom Tromey <tom@tromey.com>
2085
2086 * tui/tui-source.h (struct tui_source_window): Update.
2087 * tui/tui-regs.c (tui_show_registers): Update.
2088 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2089 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2090 (NO_REGS_STRING): Remove defines.
2091
aedbe3bb
CM
20922019-08-20 Conrad Meyer <cem@FreeBSD.org>
2093
2094 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2095 unnecessary thread walk if remote doesn't support the packet.
2096
7ce8f214
TT
20972019-08-19 Tom Tromey <tromey@adacore.com>
2098
2099 * python/py-value.c (value_has_field): Fix indentation.
2100
f21c2bd7
TT
21012019-08-19 Tom Tromey <tromey@adacore.com>
2102
2103 * printcmd.c (do_one_display, info_display_command): Update.
2104 * block.h (contained_in): Return bool. Add allow_nested
2105 parameter.
2106 * block.c (contained_in): Return bool. Add allow_nested
2107 parameter.
2108
d806ea2d
TT
21092019-08-19 Tom Tromey <tom@tromey.com>
2110
2111 * configure: Rebuild.
2112 * configure.ac: Disallow the combination of -static-libstdc++ and
2113 source highlight.
2114 * source-cache.c (get_language_name): Handle rust.
2115 (source_cache::get_source_lines): Ignore highlighting exceptions.
2116
398fdd60
TT
21172019-08-16 Tom Tromey <tom@tromey.com>
2118
2119 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2120 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2121 (struct tui_source_window_base) <make_visible, refresh_window,
2122 resize>: Remove methods.
2123 <execution_info>: Remove field.
2124 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2125 (tui_show_source_line, tui_source_window_base)
2126 (~tui_source_window_base): Update.
2127 (tui_source_window_base::resize)
2128 (tui_source_window_base::make_visible)
2129 (tui_source_window_base::refresh_window): Remove.
2130 (tui_source_window_base::update_exec_info): Update.
2131 * tui/tui-source.c (tui_source_window::set_contents): Update.
2132 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2133
e699d331
TT
21342019-08-16 Tom Tromey <tom@tromey.com>
2135
2136 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2137 deprecated_query_hook.
2138
bb01dbfc
TT
21392019-08-16 Tom Tromey <tom@tromey.com>
2140
2141 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2142 (tui_update_source_windows_with_line): Update.
2143 * tui/tui-source.h (struct tui_source_window)
2144 <show_symtab_source>: Declare.
2145 (tui_show_symtab_source): Don't declare.
2146 * tui/tui-source.c (tui_show_symtab_source): Rename from
2147 tui_show_symtab_source.
2148
81c82c4b
TT
21492019-08-16 Tom Tromey <tom@tromey.com>
2150
2151 * tui/tui-winsource.h (struct tui_source_window_base)
2152 <set_contents>: Declare.
2153 * tui/tui-winsource.c
2154 (tui_source_window_base::update_source_window_as_is): Update.
2155 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2156 Declare.
2157 (tui_set_source_content): Don't declare.
2158 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2159 tui_set_source_content.
2160 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2161 Declare.
2162 (tui_set_disassem_content): Don't declare.
2163 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2164 tui_set_disassem_content.
2165
2ddaf614
TT
21662019-08-16 Tom Tromey <tom@tromey.com>
2167
2168 * tui/tui-winsource.h (struct tui_source_window_base)
2169 <update_breakpoint_info>: Declare.
2170 (tui_update_breakpoint_info): Don't declare.
2171 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2172 (tui_update_all_breakpoint_info): Update.
2173 (tui_source_window_base::update_breakpoint_info): Rename from
2174 tui_update_breakpoint_info.
2175 (tui_source_window_base::update_exec_info): Update.
2176
017f9828
TT
21772019-08-16 Tom Tromey <tom@tromey.com>
2178
2179 * tui/tui-winsource.h (struct tui_source_window_base)
2180 <update_source_window>: Declare.
2181 (tui_update_source_window): Don't declare.
2182 * tui/tui-winsource.c
2183 (tui_source_window_base::update_source_window): Rename from
2184 tui_update_source_window.
2185 (tui_source_window_base::rerender): Update.
2186 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2187 * tui/tui-disasm.c (tui_show_disassem)
2188 (tui_show_disassem_and_update_source)
2189 (tui_disasm_window::maybe_update): Update.
2190
ed8358e9
TT
21912019-08-16 Tom Tromey <tom@tromey.com>
2192
2193 * tui/tui-winsource.h (struct tui_source_window_base)
2194 <update_source_window_as_is>: Declare.
2195 (tui_update_source_window_as_is): Don't declare.
2196 * tui/tui-winsource.c (tui_update_source_window): Update
2197 (tui_source_window_base::update_source_window_as_is): Rename from
2198 tui_update_source_window_as_is.
2199 (tui_source_window_base::refill): Update.
2200 * tui/tui-source.c (tui_show_symtab_source): Update.
2201 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2202 Update.
2203
20149b6b
TT
22042019-08-16 Tom Tromey <tom@tromey.com>
2205
2206 * tui/tui-winsource.h (tui_update_source_window)
2207 (tui_update_source_window_as_is): Remove "noerror" parameter.
2208 * tui/tui-winsource.c (tui_update_source_window)
2209 (tui_update_source_window_as_is): Remove "noerror" parameter.
2210 (tui_update_source_windows_with_addr)
2211 (tui_update_source_windows_with_line)
2212 (tui_source_window_base::rerender)
2213 (tui_source_window_base::refill): Update.
2214 * tui/tui-source.h (tui_set_source_content)
2215 (tui_show_symtab_source): Remove "noerror" parameter.
2216 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2217 parameter.
2218 (tui_show_symtab_source): Likewise.
2219 (tui_source_window::maybe_update): Update.
2220 * tui/tui-disasm.c (tui_show_disassem)
2221 (tui_show_disassem_and_update_source)
2222 (tui_disasm_window::do_scroll_vertical)
2223 (tui_disasm_window::maybe_update): Update.
2224
2d83e710
TT
22252019-08-16 Tom Tromey <tom@tromey.com>
2226
2227 * tui/tui.c (tui_is_window_visible): Update.
2228 * tui/tui-wingeneral.c (tui_make_window)
2229 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2230 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2231 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2232 (tui_set_win_height_command, parse_scrolling_args): Update.
2233 * tui/tui-source.c (tui_source_window::style_changed): Update.
2234 * tui/tui-regs.c (tui_show_registers)
2235 (tui_data_window::first_data_item_displayed)
2236 (tui_data_window::delete_data_content_windows)
2237 (tui_check_register_values, tui_reg_command): Update.
2238 * tui/tui-disasm.c (tui_show_disassem): Update.
2239 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2240 method.
2241 <is_visible>: Remove field.
2242 * tui/tui-data.c (tui_next_win, tui_prev_win)
2243 (tui_delete_invisible_windows): Update.
2244
d4ab829a
TT
22452019-08-16 Tom Tromey <tom@tromey.com>
2246
2247 * tui/tui-winsource.h (struct tui_source_window_base)
2248 <m_has_locator>: Remove.
2249 * tui/tui-layout.c (show_source_disasm_command, show_data)
2250 (show_source_or_disasm_and_command): Update.
2251
aa7ca1bb
AH
22522019-08-16 Alan Hayward <alan.hayward@arm.com>
2253
2254 * NEWS (Other MI changes): New subsection.
2255 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2256 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2257 * arch-utils.c (default_get_pc_address_flags): New function.
2258 * arch-utils.h (default_get_pc_address_flags): New declaration.
2259 * gdbarch.sh: Add get_pc_address_flags.
2260 * gdbarch.c: Regenerate.
2261 * gdbarch.h: Likewise.
2262 * stack.c (print_pc): New function.
2263 (print_frame_info) (print_frame): Call print_pc.
2264
6eac171f
TV
22652019-08-16 Tom de Vries <tdevries@suse.de>
2266
2267 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2268 print_objfile_section_info.
2269
3df505f6
TT
22702019-08-15 Tom Tromey <tom@tromey.com>
2271
2272 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2273 calling update_cmdwin_start_line.
2274 * tui/tui-winsource.h (struct tui_source_window_base)
2275 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2276 <rerender>: Declare.
2277 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2278 Call rerender.
2279 (tui_source_window_base::set_new_height): Remove.
2280 (tui_source_window_base::rerender): Rename from
2281 do_make_visible_with_new_height.
2282 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2283 resize method.
2284 (tui_win_info::make_invisible_and_set_new_height)
2285 (tui_win_info::make_visible_with_new_height): Remove.
2286 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2287 Declare.
2288 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2289 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2290 do_make_visible_with_new_height>: Don't declare.
2291 <rerender>: Declare.
2292 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2293 set_new_height.
2294 (tui_data_window::do_make_visible_with_new_height): Remove.
2295 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2296 call tui_show_locator_content.
2297 (tui_gen_win_info::resize): Call rerender.
2298 (show_source_or_disasm_and_command): Don't call
2299 tui_show_locator_content.
2300 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2301 method.
2302 (struct tui_win_info) <rerender>: Declare.
2303 <set_new_height, make_invisible_and_set_new_height,
2304 make_visible_with_new_height>: Don't declare.
2305 * tui/tui-data.c (tui_win_list::rerender): New method.
2306 * tui/tui-command.h (struct tui_cmd_window)
2307 <do_make_visible_with_new_height>: Don't declare.
2308 * tui/tui-command.c
2309 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2310
272560b5
TT
23112019-08-15 Tom Tromey <tromey@adacore.com>
2312
2313 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2314 * ada-lang.c (ada_enum_name): Likewise.
2315
08235187
CB
23162019-08-15 Christian Biesinger <cbiesinger@google.com>
2317
2318 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2319 leading underscore.
2320 (GdbOutputErrorFile): Likewise.
2321 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2322 accordingly.
2323 (execute_unwinders): Rename to have a leading underscore.
2324 (auto_load_packages): Likewise.
2325 (global scope): Adjust call to auto_load_packages accordingly.
2326 (GdbSetPythonDirectory): Likewise.
2327 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2328 instead of execute_unwinders.
2329
db502012
TT
23302019-08-15 Tom Tromey <tom@tromey.com>
2331
2332 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2333 (show_data): Don't change window visibility.
2334 (tui_gen_win_info::resize): Remove special case for command
2335 window. Use wresize, when available.
2336 (show_source_or_disasm_and_command): Don't change window
2337 visibility.
2338 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2339 <make_visible>: New method.
2340 * tui/tui-command.c (tui_cmd_window::resize): New method.
2341
3891b65e
TT
23422019-08-15 Tom Tromey <tom@tromey.com>
2343
2344 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2345 (struct tui_source_windows): New.
2346 * tui/tui-winsource.c (tui_display_main): Update.
2347 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2348 (new_height_ok, parse_scrolling_args): Update.
2349 * tui/tui-layout.c (show_layout, show_data): Update.
2350 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2351 (tui_add_to_source_windows): Don't declare.
2352 * tui/tui-data.c (source_windows, tui_source_windows)
2353 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2354
ee556432
TT
23552019-08-15 Tom Tromey <tom@tromey.com>
2356
2357 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2358 Rename from reset.
2359 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2360 * tui/tui-layout.c (show_source_disasm_command, show_data):
2361 Update.
2362 (tui_gen_win_info::resize): Rename.
2363 (show_source_or_disasm_and_command): Update.
2364 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2365 reset.
2366
46f438e3
TT
23672019-08-15 Tom Tromey <tom@tromey.com>
2368
2369 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2370 * tui/tui-interp.c (tui_interp::init): Don't call
2371 tui_initialize_static_data.
2372 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2373
f4ce562c
TT
23742019-08-15 Tom Tromey <tom@tromey.com>
2375
2376 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2377 examine tui_win_list.
2378
c398c3d0
TT
23792019-08-15 Tom Tromey <tom@tromey.com>
2380
2381 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2382 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2383 tui_clear_source_content.
2384 (tui_clear_source_content): Remove.
2385 (tui_source_window_base::do_erase_source_content): Hoist call to
2386 content.clear().
2387 * tui/tui-stack.c (tui_show_frame_info): Don't call
2388 tui_clear_source_content.
2389
e25d2004
TT
23902019-08-15 Tom Tromey <tom@tromey.com>
2391
2392 * tui/tui-winsource.h (struct tui_source_window_base)
2393 <do_erase_source_content>: New method.
2394 <erase_source_content>: New method.
2395 (tui_erase_source_content): Don't declare.
2396 * tui/tui-winsource.c (tui_clear_source_content): Update.
2397 (tui_source_window_base::do_erase_source_content): Rename from
2398 tui_erase_source_content.
2399 (tui_source_window_base::show_source_content): Update.
2400 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2401 * tui/tui-source.h (struct tui_source_window)
2402 <erase_source_content>: New method.
2403 * tui/tui-disasm.h (struct tui_disasm_window)
2404 <erase_source_content>: New method.
2405
002f15c2
TT
24062019-08-15 Tom Tromey <tom@tromey.com>
2407
2408 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2409 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2410 constructor.
2411 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2412 * tui/tui-source.c (tui_set_source_content): Update.
2413 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2414
c9033fe8
TT
24152019-08-15 Tom Tromey <tom@tromey.com>
2416
2417 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2418 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2419 tui-source.c.
2420 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2421 Declare.
2422 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2423 method.
2424 (tui_source_window::maybe_update): Update.
2425
088f37dd
TT
24262019-08-15 Tom Tromey <tom@tromey.com>
2427
2428 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2429 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2430 tui-disasm.c.
2431 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2432 Declare.
2433 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2434 method.
2435 (tui_disasm_window::maybe_update): Update.
2436
a54700c6
TT
24372019-08-15 Tom Tromey <tom@tromey.com>
2438
2439 * tui/tui-winsource.h (struct tui_source_window_base)
2440 <maybe_update>: Declare.
2441 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2442 method.
2443 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2444 Declare.
2445 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2446 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2447 Declare.
2448 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2449
e2a678a5
TT
24502019-08-15 Tom Tromey <tom@tromey.com>
2451
2452 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2453
f2dda477
TT
24542019-08-15 Tom Tromey <tom@tromey.com>
2455
2456 * tui/tui-wingeneral.c: Include tui-stack.h.
2457 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2458 (struct tui_locator_window): Move from tui-data.h.
2459 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2460 (tui_initialize_static_data): Move from tui-data.c.
2461 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2462 (struct tui_locator_window): Move to tui-stack.c.
2463 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2464 (tui_initialize_static_data): Move to tui-stack.c.
2465
ed4a1084
TT
24662019-08-15 Tom Tromey <tom@tromey.com>
2467
2468 * tui/tui-layout.c (show_source_disasm_command)
2469 (show_source_or_disasm_and_command): Use make_visible method, not
2470 tui_make_window.
2471 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2472 Remove.
2473
65962b20
TT
24742019-08-15 Tom Tromey <tom@tromey.com>
2475
2476 * tui/tui-wingeneral.h (tui_make_window): Update.
2477 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2478 parameter.
2479 (tui_gen_win_info::make_visible): Update.
2480 * tui/tui-regs.c (tui_data_window::display_registers_from):
2481 Update.
2482 * tui/tui-layout.c (show_source_disasm_command)
2483 (show_source_or_disasm_and_command): Update.
2484 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2485 (enum tui_box): Remove.
2486 (struct tui_win_info) <can_box>: New method.
2487 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2488 method.
2489
2208ee91
TV
24902019-08-15 Tom de Vries <tdevries@suse.de>
2491
2492 * linux-nat-trad.c: Include gdbarch.h.
2493
75faf5c4
AH
24942019-08-14 Alan Hayward <alan.hayward@arm.com>
2495
2496 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2497 register sizes.
2498
b1c896b3
TT
24992019-08-14 Tom Tromey <tromey@adacore.com>
2500
2501 * darwin-nat.c: Include gdbarch.h.
2502 * darwin-nat-info.c: Include gdbarch.h.
2503
6405cd73
TT
25042019-08-13 Tom Tromey <tom@tromey.com>
2505
2506 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2507 Remove.
2508 * tui/tui-data.c (tui_initialize_static_data): Update.
2509
5216580d
TT
25102019-08-13 Tom Tromey <tom@tromey.com>
2511
2512 * tui/tui-winsource.h (struct tui_exec_info_window)
2513 <~tui_exec_info_window, maybe_allocate_content, get_content,
2514 m_content>: Remove.
2515 (struct tui_source_window_base) <set_exec_info_content,
2516 show_exec_info_content>: Don't declare.
2517 * tui/tui-winsource.c
2518 (tui_exec_info_window::maybe_allocate_content): Remove.
2519 (tui_source_window_base::update_exec_info): Rename from
2520 set_exec_info_content.
2521 (tui_source_window_base::show_exec_info_content)
2522 (tui_source_window_base::update_exec_info): Remove.
2523
93858ad3
TT
25242019-08-13 Tom Tromey <tom@tromey.com>
2525
2526 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2527 declare.
2528 * tui/tui-winsource.c (tui_update_source_window_as_is)
2529 (tui_update_source_windows_with_addr, tui_erase_source_content):
2530 Update.
2531 (tui_clear_exec_info_content): Remove.
2532
e321e7ce
TT
25332019-08-13 Tom Tromey <tom@tromey.com>
2534
2535 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2536 declare.
2537 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2538 call tui_erase_exec_info_content.
2539 (tui_clear_exec_info_content): Rename from
2540 tui_erase_exec_info_content.
2541 (tui_clear_exec_info_content): Delete.
2542
8270ac62
TT
25432019-08-13 Tom Tromey <tom@tromey.com>
2544
2545 * tui/tui-winsource.h (struct tui_source_window_base)
2546 <show_exec_info_content>: Declare.
2547 (tui_show_exec_info_content): Don't declare.
2548 * tui/tui-winsource.c
2549 (tui_source_window_base::show_exec_info_content): Rename from
2550 tui_show_exec_info_content.
2551 (tui_source_window_base::update_exec_info): Update.
2552
7b56485d
TT
25532019-08-13 Tom Tromey <tom@tromey.com>
2554
2555 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2556 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2557 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2558 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2559 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2560 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2561 ... here.
2562
7ba913dc
TT
25632019-08-13 Tom Tromey <tom@tromey.com>
2564
2565 * tui/tui-winsource.h (struct tui_source_window_base)
2566 <update_exec_info>: Declare.
2567 (tui_update_exec_info): Don't declare.
2568 * tui/tui-winsource.c (tui_update_source_window_as_is)
2569 (tui_source_window_base::refresh_all)
2570 (tui_update_all_breakpoint_info): Update.
2571 (tui_source_window_base::update_exec_info): Rename from
2572 tui_update_exec_info.
2573 * tui/tui-stack.c (tui_show_frame_info): Update.
2574
37a4a131
TT
25752019-08-13 Tom Tromey <tom@tromey.com>
2576
2577 * tui/tui-winsource.h (struct tui_source_window_base)
2578 <set_exec_info_content>: Declare.
2579 (tui_set_exec_info_content): Don't declare.
2580 * tui/tui-winsource.c
2581 (tui_source_window_base::set_exec_info_content): Rename from
2582 tui_set_exec_info_content.
2583 (tui_update_exec_info): Update.
2584
0bd27e07
TT
25852019-08-13 Tom Tromey <tom@tromey.com>
2586
2587 * tui/tui-winsource.h (struct tui_source_window_base)
2588 <show_source_content>: Declare.
2589 (tui_show_source_content): Don't declare.
2590 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2591 (tui_source_window_base::show_source_content): Rename from
2592 tui_show_source_content.
2593 (tui_source_window_base::refresh_all): Update.
2594 * tui/tui-layout.c (show_source_disasm_command)
2595 (show_source_or_disasm_and_command): Update.
2596
b4ef5aeb
TT
25972019-08-13 Tom Tromey <tom@tromey.com>
2598
2599 * tui/tui-winsource.c (tui_erase_source_content)
2600 (tui_show_source_content, tui_source_window_base::refresh_all):
2601 Update.
2602 * tui/tui-wingeneral.h
2603 (tui_check_and_display_highlight_if_needed): Don't declare.
2604 * tui/tui-wingeneral.c
2605 (tui_win_info::check_and_display_highlight_if_needed): Rename from
2606 check_and_display_highlight_if_needed.
2607 * tui/tui-win.c (tui_rehighlight_all)
2608 (tui_win_info::make_visible_with_new_height): Update.
2609 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2610 (tui_data_window::erase_data_content)
2611 (tui_data_window::display_all_data): Update.
2612 * tui/tui-data.h (struct tui_win_info)
2613 <check_and_display_highlight_if_needed>: Declare.
2614
fede5273
TT
26152019-08-13 Tom Tromey <tom@tromey.com>
2616
2617 * tui/tui-win.c (tui_resize_all): Call
2618 tui_delete_invisible_windows.
2619 * tui/tui-layout.c (show_layout): Call
2620 tui_delete_invisible_windows.
2621 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2622 * tui/tui-data.c (tui_delete_invisible_windows): New function.
2623
22c3f490
TT
26242019-08-13 Tom Tromey <tom@tromey.com>
2625
2626 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
2627 tui_add_win_to_layout.
2628
16cb7910
TT
26292019-08-13 Tom Tromey <tom@tromey.com>
2630
2631 * tui/tui-layout.h (tui_default_win_height): Don't declare.
2632 * tui/tui-layout.c (tui_default_win_height): Now static.
2633
cc0c3ffb
TT
26342019-08-13 Tom Tromey <tom@tromey.com>
2635
2636 * tui/tui-layout.c (show_layout): Unify all layout cases into a
2637 single switch.
2638 (show_source_disasm_command, show_source_or_disasm_and_command):
2639 Don't check current layout.
2640
3f3ffe54
TT
26412019-08-13 Tom Tromey <tom@tromey.com>
2642
2643 * tui/tui-wingeneral.c (make_all_visible): Remove.
2644 (tui_make_all_invisible): Simplify.
2645 * tui/tui-layout.c (tui_make_all_invisible): Move from
2646 tui-wingeneral.c; simplify.
2647 (show_layout): Hoist call to tui_make_all_invisible.
2648 (show_data): Don't call tui_make_all_invisible.
2649
69258091
TT
26502019-08-13 Tom Tromey <tom@tromey.com>
2651
2652 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2653 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2654
62cf57fe
TT
26552019-08-13 Tom Tromey <tom@tromey.com>
2656
2657 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2658 tui-data.c.
2659 (show_source_disasm_command, show_data)
2660 (show_source_or_disasm_and_command): Don't use
2661 tui_set_current_layout_to.
2662 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2663 * tui/tui-data.c (current_layout, tui_current_layout): Move to
2664 tui-layout.c.
2665 (tui_set_current_layout_to): Remove.
2666
2afade5d
TT
26672019-08-13 Tom Tromey <tom@tromey.com>
2668
2669 * tui/tui-layout.c (tui_set_layout): Update.
2670 * tui/tui-data.h (struct tui_layout_def): Remove.
2671 (tui_layout_def): Don't declare.
2672 * tui/tui-data.c (layout_def): Remove.
2673 (tui_layout_def): Remove.
2674
a3504e96
TT
26752019-08-13 Tom Tromey <tom@tromey.com>
2676
2677 * tui/tui-winsource.h (struct tui_source_window_base)
2678 <clear_detail>: No longer "override".
2679 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2680 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2681 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2682 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2683 Remove.
2684 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2685
29c92911
TT
26862019-08-13 Tom Tromey <tromey@adacore.com>
2687
2688 * tracepoint.c: Don't include readline.h or history.h.
2689
86c6b807
TT
26902019-08-12 Tom Tromey <tom@tromey.com>
2691
2692 * configure: Rebuild.
2693 * configure.ac: Check for readline 7.
2694 * NEWS: Mention readline 7 requirement.
2695 * README: Update.
2696
5db2718c
TT
26972019-08-12 Tom Tromey <tom@tromey.com>
2698
2699 * mingw-hdep.c (gdb_select): Remove readline hack.
2700
dac36daf
PFC
27012019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2702
2703 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2704 when the function fails.
2705
1022c627
AA
27062019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2707
2708 * s390-tdep.c (s390_type_align): New function.
2709 (s390_gdbarch_init): Set it as type_align gdbarch method.
2710
eba4caf2
TV
27112019-08-09 Tom de Vries <tdevries@suse.de>
2712
2713 PR gdb/24591
2714 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2715 pc_low with relocation offset.
2716
123cd851
TT
27172019-08-07 Tom Tromey <tromey@adacore.com>
2718
2719 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2720 (print_frame_args): Update.
2721 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2722 Update.
2723 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2724 * frame.h (struct frame_arg): Add initializers.
2725 <error>: Now a unique_xmalloc_ptr.
2726
3d31bc39
AH
27272019-08-07 Alan Hayward <alan.hayward@arm.com>
2728
2729 * NEWS: Expand the Pointer Authentication entry.
2730 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2731 (aarch64_frame_unmask_lr): ... to this.
2732 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2733 Call aarch64_frame_unmask_lr.
2734 * frame.c (struct frame_info): Add "masked" variable.
2735 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2736 (fprint_frame): Check for masked pc.
2737 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2738 declarations.
2739 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2740 * stack.c (print_frame): Check for masked pc.
2741
0cf9feb9
TT
27422019-08-06 Tom Tromey <tom@tromey.com>
2743
2744 * stabsread.c (patch_block_stabs, read_one_struct_field)
2745 (read_enum_type): Use obstack_strndup.
2746 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2747 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2748 * dwarf2read.c (guess_full_die_structure_name)
2749 (anonymous_struct_prefix): Use obstack_strndup.
2750 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2751 * c-exp.y (yylex): Use obstack_strndup.
2752 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2753 (write_var_or_type): Use obstack_strndup.
2754
efba19b0
TT
27552019-08-06 Tom Tromey <tom@tromey.com>
2756
2757 * symfile.c (reread_symbols): Use obstack_strdup.
2758 * stabsread.c (read_type): Use obstack_strdup.
2759 * gdb_obstack.h (obstack_strdup): New overload.
2760 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2761 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2762 (dwarf2_canonicalize_name): Use obstack_strdup.
2763 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2764 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2765 Use obstack_strdup.
2766
f25102f7
TT
27672019-08-06 Tom Tromey <tom@tromey.com>
2768
2769 * gdb_obstack.h (obstack_strdup): Define.
2770 * gdb_obstack.c (obstack_strdup): Don't define.
2771
021887d8
TT
27722019-08-06 Tom Tromey <tom@tromey.com>
2773
2774 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2775 obstack_strdup.
2776 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2777 obstack_strdup.
2778 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2779 * stabsread.c (common_block_start): Use obstack_strdup.
2780 * objfiles.c (set_objfile_main_name, objfile): Use
2781 obstack_strdup.
2782 * namespace.c (add_using_directive): Use obstack_strdup.
2783 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2784 * jit.c (finalize_symtab): Use obstack_strdup.
2785 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2786 (guess_partial_die_structure_name, partial_die_info::fixup)
2787 (dwarf2_name): Use obstack_strdup.
2788 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2789 obstack_strdup.
2790 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2791 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2792 obstack_strdup.
2793 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2794
d2834edc
PW
27952019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2796
2797 * unittests/help-doc-selftests.c: New file.
2798 * Makefile.in: Add the new file.
2799
590042fc
PW
28002019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2801
2802 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2803 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2804 the full first line, except when FOR_VALUE_PREFIX. In this case,
2805 the trailing '.' is not output, and the first character is uppercased.
2806 (print_help_for_command): Update call to print_doc_line.
2807 (print_doc_of_command): Likewise.
2808 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2809 * cli/cli-option.c (append_indented_doc): Do not append newline.
2810 (build_help_option): Append newline after first appended_indented_doc
2811 only if a second call is done.
2812 (build_help): Append 2 new lines before each option, except the first
2813 one.
2814 * compile/compile.c (_initialize_compile): Add new lines after
2815 %OPTIONS%, when not at the end of the help.
2816 Change help doc or code
2817 producing the help doc to respect the invariants.
2818 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2819 Also removed the new line after 'Options:', as all other commands
2820 do not put an empty line between 'Options:' and the first option.
2821 * printcmd.c (_initialize_printcmd): Likewise.
2822 * stack.c (_initialize_stack): Likewise.
2823 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2824 incorrectly telling COMMAND is optional.
2825 * ada-lang.c (_initialize_ada_language): Change help doc or code
2826 producing the help doc to respect the invariants.
2827 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2828 * breakpoint.c (_initialize_breakpoint): Likewise.
2829 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2830 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2831 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2832 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2833 _initialize_cli_style): Likewise.
2834 * corelow.c (core_target_info): Likewise.
2835 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2836 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2837 * filesystem.c (_initialize_filesystem): Likewise.
2838 * frame.c (_initialize_frame): Likewise.
2839 * gnu-nat.c (add_task_commands): Likewise.
2840 * infcall.c (_initialize_infcall): Likewise.
2841 * infcmd.c (_initialize_infcmd): Likewise.
2842 * interps.c (_initialize_interpreter): Likewise.
2843 * language.c (_initialize_language): Likewise.
2844 * linux-fork.c (_initialize_linux_fork): Likewise.
2845 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2846 * maint.c (_initialize_maint_cmds): Likewise.
2847 * memattr.c (_initialize_mem): Likewise.
2848 * printcmd.c (_initialize_printcmd): Likewise.
2849 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2850 _RegEx): Likewise.
2851 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2852 * record-btrace.c (_initialize_record_btrace): Likewise.
2853 * record-full.c (_initialize_record_full): Likewise.
2854 * record.c (_initialize_record): Likewise.
2855 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2856 * regcache.c (_initialize_regcache): Likewise.
2857 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2858 _initialize_remote): Likewise.
2859 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2860 * serial.c (_initialize_serial): Likewise.
2861 * skip.c (_initialize_step_skip): Likewise.
2862 * source.c (_initialize_source): Likewise.
2863 * stack.c (_initialize_stack): Likewise.
2864 * symfile.c (_initialize_symfile): Likewise.
2865 * symtab.c (_initialize_symtab): Likewise.
2866 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2867 * top.c (init_main): Likewise.
2868 * tracefile-tfile.c (tfile_target_info): Likewise.
2869 * tracepoint.c (_initialize_tracepoint): Likewise.
2870 * tui/tui-win.c (_initialize_tui_win): Likewise.
2871 * utils.c (add_internal_problem_command): Likewise.
2872 * valprint.c (value_print_option_defs): Likewise.
2873
404f2902
FCE
28742019-08-06 Frank Ch. Eigler <fche@redhat.com>
2875
2876 PR build/24886
2877 * configure.ac: Drop enable-libmcheck support.
2878 * configure, config.in: Rebuild.
2879 * libmcheck.m4: Remove.
2880 * acinclude.m4: Don't include it.
2881 * Makefile.in: Don't distribute it.
2882 * top.c (print_gdb_configuration): Don't mention it.
2883
046bebe1
TT
28842019-08-06 Tom Tromey <tom@tromey.com>
2885
2886 * utils.c (set_output_style): Sometimes pass stream to
2887 emit_style_escape.
2888 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2889 * record-btrace.c (btrace_insn_history): Update.
2890 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2891 method.
2892 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2893 Update initializers.
2894 <m_uiout>: New field.
2895 <m_di>: Move lower.
2896 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2897 Remove "uiout" parameter.
2898 (dump_insns): Update.
2899 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2900 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2901
ddbcedf5
CB
29022019-08-06 Christian Biesinger <cbiesinger@google.com>
2903
2904 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2905 (error_in_psymtab_expansion): Likewise.
2906 (lookup_symbol_via_quick_fns): Likewise.
2907 (basic_lookup_transparent_type_quick): Likewise.
2908 (basic_lookup_transparent_type_1): Likewise.
2909
b08b16c8
TT
29102019-08-06 Tom Tromey <tromey@adacore.com>
2911
2912 * source.c (last_source_error): Now bool.
2913 (print_source_lines_base): Make "noprint" bool. Only open
2914 source file when last_source_visited changes.
2915
cb44333d
TT
29162019-08-06 Tom Tromey <tromey@adacore.com>
2917
2918 * annotate.c (annotate_source_line): Use g_source_cache.
2919 * source-cache.c (source_cache::get_plain_source_lines): Change
2920 parameters. Populate m_offset_cache.
2921 (source_cache::ensure): New method.
2922 (source_cache::get_line_charpos): New method.
2923 (extract_lines): Move lower. Change parameters.
2924 (source_cache::get_source_lines): Move lower.
2925 * source-cache.h (class source_cache): Update comment.
2926 <get_line_charpos>: New method.
2927 <get_source_lines>: Update comment.
2928 <clear>: Clear m_offset_cache.
2929 <get_plain_source_lines>: Change parameters.
2930 <ensure>: New method
2931 <m_offset_cache>: New member.
2932 * source.c (forget_cached_source_info_for_objfile): Update.
2933 (info_source_command): Use g_source_cache.
2934 (find_source_lines, open_source_file_with_line_charpos): Remove.
2935 (print_source_lines_base, search_command_helper): Use g_source_cache.
2936 * source.h (open_source_file_with_line_charpos): Don't declare.
2937 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2938 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2939 Use g_source_cache.
2940
872dceaa
TT
29412019-08-06 Tom Tromey <tromey@adacore.com>
2942
2943 * source-cache.c (source_cache::get_plain_source_lines):
2944 Remove "first_line" and "last_line" parameters.
2945 (source_cache::get_source_lines): Cache plain text.
2946 * source-cache.h (class source_cache)
2947 <get_plain_source_lines>: Update.
2948
269249d9
TT
29492019-08-06 Tom Tromey <tromey@adacore.com>
2950
2951 * source-cache.c (extract_lines): No longer a method.
2952 Changed type of parameter. Include final newline.
2953 (selftests::extract_lines_test): New function.
2954 (_initialize_source_cache): Likewise.
2955 * source-cache.h (class source_cache)
2956 <extract_lines>: Don't declare.
2957
c0e8dcd8
TT
29582019-08-06 Tom Tromey <tromey@adacore.com>
2959
2960 * breakpoint.c (init_breakpoint_sal): Update.
2961 (breakpoint): Update.
2962 * breakpoint.h (struct breakpoint) <filter>: Now a
2963 unique_xmalloc_ptr.
2964
0b27c27d
CB
29652019-08-05 Christian Biesinger <cbiesinger@google.com>
2966
2967 * NEWS: Mention dictionary access on blocks.
2968 * python/py-block.c (blpy_getitem): New function.
2969 (block_object_as_mapping): New struct.
2970 (block_object_type): Use new struct for tp_as_mapping field.
2971
4ee94178
CB
29722019-08-05 Christian Biesinger <cbiesinger@google.com>
2973
2974 * objfiles.h (objfile): Add a comment describing partial symbols.
2975
8abfcabc
TT
29762019-08-05 Tom Tromey <tromey@adacore.com>
2977
2978 * compile/compile.c (_initialize_compile): Use _(), not N_().
2979 * thread.c (_initialize_thread): Use _(), not N_().
2980 * stack.c (_initialize_stack): Use _(), not N_().
2981 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2982
2b79f376
SM
29832019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2984
2985 * dwarf2read.c (struct dw2_symtab_iterator):
2986 <want_specific_block>: Remove.
2987 <block_index>: Change type to gdb::optional.
2988 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2989 change type of BLOCK_INDEX parameter to gdb::optional.
2990 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2991 (dw2_lookup_symbol): Don't pass argument for
2992 WANT_SPECIFIC_BLOCK.
2993 (dw2_expand_symtabs_for_function): Don't pass argument for
2994 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2995 (class dw2_debug_names_iterator)
2996 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2997 parameter, change BLOCK_INDEX type to gdb::optional.
2998 <m_want_specific_block>: Remove.
2999 <m_block_index>: Change type to gdb::optional.
3000 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3001 gdb::optional. Re-write in function of gdb::optional.
3002 (dw2_debug_names_lookup_symbol): Don't pass argument for
3003 WANT_SPECIFIC_BLOCK.
3004 (dw2_debug_names_expand_symtabs_for_function): Don't pass
3005 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3006 BLOCK_INDEX.
3007
ae60f04e
PW
30082019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3009
3010 * NEWS: Mention changes to "info sources" command.
3011
28cd9371
PW
30122019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3013
3014 * symtab.c (filename_partial_match_opts): New struct type.
3015 (struct output_source_filename_data): New members
3016 regexp, c_regexp, partial_match.
3017 (output_source_filename): Use new members to decide to print file.
3018 (info_sources_option_defs): New variable.
3019 (make_info_sources_options_def_group, print_info_sources_header,
3020 info_sources_command_completer):
3021 New functions.
3022 (info_sources_command): Read new optional arguments.
3023 (_initialize_symtab): Update info sources help.
3024
ca683e3a
AO
30252019-08-02 Alexandre Oliva <oliva@adacore.com>
3026
3027 * ada-lang.c (exception_support_info_v0): Renamed from...
3028 (default_exception_support_info): ... this. Create new
3029 definition for v1.
3030 (ada_has_this_exception_support): Look up catch_handlers_sym.
3031 (ada_exception_support_info_sniffer): Try v0 after default.
3032
f1264162
TT
30332019-08-01 Tom Tromey <tromey@adacore.com>
3034
3035 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3036 gdbarch.h.
3037
0a7b2485
CB
30382019-08-01 Christian Biesinger <cbiesinger@google.com>
3039
3040 * s12z-tdep.c: Fix include path for s12z-opc.h.
3041
c6bdbeb7
AH
30422019-08-01 Alan Hayward <alan.hayward@arm.com>
3043
3044 * NEWS: Require GNU make 3.82.
3045
a2bd7b82
TT
30462019-07-16 Tom Tromey <tom@tromey.com>
3047
3048 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3049 declare.
3050
aa3b6533
TT
30512019-07-30 Tom Tromey <tromey@adacore.com>
3052
3053 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3054
a1530dc7
KB
30552019-07-30 Kevin Buettner <kevinb@redhat.com>
3056
3057 * printcmd.c (print_address_symbolic): Print negative offsets.
3058 (build_address_symbolic): Force signed arithmetic when computing
3059 offset.
3060
2906593f
CB
30612019-07-30 Christian Biesinger <cbiesinger@google.com>
3062
3063 PR/24474: Add a function to lookup static variables.
3064 * NEWS: Mention this new function.
3065 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3066 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3067 * python/python.c (python_GdbMethods): Add new function.
3068
c620ed88
CB
30692019-07-29 Christian Biesinger <cbiesinger@google.com>
3070
3071 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3072 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3073 (objfpy_lookup_static_symbol): New function.
3074 (objfile_object_methods): Add new functions.
3075
bc4268a5
PW
30762019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3077
3078 * NEWS: Mention 'set|show print frame-info'. Mention new
3079 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3080 backtrace argument. Mention that python frame filtering code
3081 is now consistent with what 'backtrace' command prints.
3082
4b5e8d19
PW
30832019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3084
3085 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3086 comments.
3087 (print_frame_info_auto, print_frame_info_source_line,
3088 print_frame_info_location, print_frame_info_source_and_location,
3089 print_frame_info_location_and_address, print_frame_info_short_location):
3090 New declarations.
3091 (struct frame_print_options): New member print_frame_info.
3092 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3093 * stack.h (get_user_print_what_frame_info): New declaration.
3094 (frame_show_address): New declaration.
3095 * stack.c (print_frame_arguments_choices): New value 'presence'.
3096 (print_frame_info_auto, print_frame_info_source_line,
3097 print_frame_info_location, print_frame_info_source_and_location,
3098 print_frame_info_location_and_address, print_frame_info_short_location,
3099 print_frame_info_choices, print_frame_info_print_what): New definitions.
3100 (print_frame_args): Only print dots for args if print frame-arguments
3101 is 'presence'.
3102 (frame_print_option_defs): New element for "frame-info".
3103 (get_user_print_what_frame_info): New function.
3104 (frame_show_address): Make non static. Move comment to stack.h.
3105 (print_frame_info_to_print_what): New function.
3106 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3107 to decide what to print.
3108 (backtrace_command_1): Handle the new print_frame_arguments_presence
3109 value.
3110 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3111 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3112 (py_print_frame): In non-mi mode, use LOCATION as default for
3113 print_what, similarly to frame information printed directly by
3114 backtrace command. Handle frame-info user option in non MI mode.
3115
6bdfee81
KB
31162019-07-27 Kevin Buettner <kevinb@redhat.com>
3117
3118 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3119 Add case for debugging 32-bit target on 64-bit host. Revise
3120 comment.
3121
98a617f8
KB
31222019-07-27 Kevin Buettner <kevinb@redhat.com>
3123
3124 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3125 instead of find_function_entry_range_from_pc.
3126
567238c9
KB
31272019-07-27 Kevin Buettner <kevinb@redhat.com>
3128
3129 * stack.c (find_frame_funname): Remove code which preferred
3130 minsym over symtab sym in "certain pathological cases".
3131
2dc80cf8
KB
3132 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3133 parameter. Change type of "do_demangle" to bool.
3134 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3135 Pass suitable "prefer_sym_over_minsym" flag to
3136 build_address_symbolic(). Don't output "+" for negative offsets.
3137 * printcmd.c (print_address_symbolic): Update invocation of
3138 build_address_symbolic to include a "prefer_sym_over_minsym"
3139 flag.
3140 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3141 Restrict cases in which use of minimal symbol is preferred to that
3142 of a found symbol. Update comments.
3143
1aff7173
KB
3144 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3145 for entry pc when entry pc is out of range for that FDE.
3146
89b085ac
BC
31472019-07-26 Brian Callahan <bcallah@openbsd.org>
3148
3149 PR gdb/24839:
3150 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3151 type.
3152
f32feb4a
CB
31532019-07-25 Christian Biesinger <cbiesinger@google.com>
3154
3155 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3156 this function's Python signature.
3157
3158
31592019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
3160
3161 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3162 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3163 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3164 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3165 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3166
3167
c54e4253
YS
31682019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3169
3170 * h8300-tdep.c (h8300_register_name_common): New.
3171 h8300_register_name): Use h8300_register_name_common.
3172 (h8300s_register_name): Likewise.
3173 (h8300sx_register_name): Likewise.
3174 (h8300h_register_nam): New.
3175 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3176
3177
40eadf04
SP
31782019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3179
3180 * arm-tdep.c (arm_skip_cmse_entry): New function.
3181 (arm_is_sgstubs_section): New function.
3182 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3183
bfa2a36d
TT
31842019-07-22 Tom Tromey <tom@tromey.com>
3185
3186 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3187 Don't self-assign.
3188
a8e9d247
AB
31892019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3190
3191 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3192 type_print.
3193
eb86c5e2
AB
31942019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3195
3196 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3197 so that GDB doesn't match any msymbols when searching in the
3198 TYPES_DOMAIN.
3199 (print_symbol_info): Print using typedef_print or type_print based
3200 on the type of the symbol. Add updated FIXME comment moved from...
3201 (_initialize_symtab): ... move and update FIXME comment to above.
3202
a8eab7c6
AB
32032019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3204
3205 * NEWS: Mention adding -q option to "info types".
3206 * symtab.c (struct info_types_options): New struct.
3207 (info_types_options_defs): New variable.
3208 (make_info_types_options_def_group): New function.
3209 (info_types_command): Use gdb::option framework to parse options.
3210 (info_types_command_completer): New function.
3211 (_initialize_symtab): Extend the help text on "info types" and
3212 register command completer.
3213
b4603c34
CB
32142019-07-21 Christian Biesinger <cbiesinger@google.com>
3215
3216 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3217 (lookup_symbol_in_objfile): Change int to block_enum and add a
3218 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3219
c8cdc1e0
CB
32202019-07-20 Christian Biesinger <cbiesinger@google.com>
3221
3222 * MAINTAINERS (Write After Approval): Add self.
3223
01e175fe
AB
32242019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3225
3226 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3227 instruction to the dummy code region.
3228
56f79b63
TT
32292019-07-19 Tom Tromey <tromey@adacore.com>
3230
3231 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3232 (ARGSUSED, PARAMS, __func__): Remove rules.
3233
4c5aa8e0
AH
32342019-07-19 Alan Hayward <alan.hayward@arm.com>
3235
3236 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3237 * features/arm/arm-with-iwmmxt.c: Remove.
3238 * features/arm/arm-with-iwmmxt.xml: Remove.
3239 * features/arm/arm-with-m-fpa-layout.c: Remove.
3240 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3241 * features/arm/arm-with-m-vfp-d16.c: Remove.
3242 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3243 * features/arm/arm-with-m.c: Remove.
3244 * features/arm/arm-with-m.xml: Remove.
3245 * features/arm/arm-with-neon.c: Remove.
3246 * features/arm/arm-with-neon.xml: Remove.
3247 * features/arm/arm-with-vfpv2.c: Remove.
3248 * features/arm/arm-with-vfpv2.xml: Remove.
3249 * features/arm/arm-with-vfpv3.c: Remove.
3250 * features/arm/arm-with-vfpv3.xml: Remove.
3251
f42b2617
AH
32522019-07-19 Alan Hayward <alan.hayward@arm.com>
3253
3254 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3255
f29ec966
AH
32562019-07-19 Alan Hayward <alan.hayward@arm.com>
3257
3258 * arch/aarch32.c (aarch32_create_target_description): Create
3259 target descriptions using features.
3260 * arch/arm.c (arm_create_target_description)
3261 (arm_create_mprofile_target_description): Likewise.
3262 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3263
d105cce5
AH
32642019-07-19 Alan Hayward <alan.hayward@arm.com>
3265
3266 * Makefile.in: Add new files.
3267 * aarch32-tdep.c: New file.
3268 * aarch32-tdep.h: New file.
3269 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3270 Call aarch32_read_description.
3271 * arch/aarch32.c: New file.
3272 * arch/aarch32.h: New file.
3273 * arch/arm.c (arm_create_target_description)
3274 (arm_create_mprofile_target_description): New function.
3275 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3276 (arm_create_target_description)
3277 (arm_create_mprofile_target_description): New declaration.
3278 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3279 read_description functions.
3280 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3281 Likewise.
3282 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3283 * arm-tdep.c (tdesc_arm_list): New variable.
3284 (arm_register_g_packet_guesses): Call create description functions.
3285 (arm_read_description) (arm_read_mprofile_description): New
3286 function.
3287 * arm-tdep.h (arm_read_description)
3288 (arm_read_mprofile_description): Add declaration.
3289 * configure.tgt: Add new files.
3290
afe09f0b
GL
32912019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3292
3293 * top.c (new_ui_command): Open specified terminal just once.
3294
cd215b2e
TT
32952019-07-18 Tom Tromey <tromey@adacore.com>
3296
3297 * symtab.c (main_name): Constify return type.
3298 * symfile.c (set_initial_language): Update.
3299 * symtab.h (main_name): Constify return type.
3300
d8f68fcb
TT
33012019-07-17 Tom Tromey <tom@tromey.com>
3302
3303 * tui/tui-winsource.c (tui_update_source_window)
3304 (tui_update_source_window_as_is)
3305 (tui_update_source_windows_with_line): Remove return.
3306 * tui/tui-disasm.c (tui_show_disassem)
3307 (tui_show_disassem_and_update_source): Remove return.
3308 * tui/tui.c (tui_reset): Remove return.
3309 * tui/tui-wingeneral.c
3310 (tui_check_and_display_highlight_if_needed): Remove return.
3311
ca5af91e
TT
33122019-07-17 Tom Tromey <tom@tromey.com>
3313
3314 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3315
5104fe36
TT
33162019-07-17 Tom Tromey <tom@tromey.com>
3317
3318 * tui/tui-winsource.h (struct tui_exec_info_window)
3319 (struct tui_source_window_base): Move from tui-data.h.
3320 * tui/tui-winsource.c: Move many method definitions from
3321 elsewhere. Remove "structuring" comments.
3322 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3323 (tui_source_window_base::refresh_window): Move to
3324 tui-winsource.c.
3325 * tui/tui-win.c (tui_source_window_base::refresh_all)
3326 (tui_source_window_base::update_tab_width)
3327 (tui_source_window_base::set_new_height)
3328 (tui_source_window_base::do_make_visible_with_new_height): Move to
3329 tui-winsource.c.
3330 * tui/tui-source.h: Update.
3331 * tui/tui-source.c (tui_source_window_base::reset): Move to
3332 tui-winsource.c.
3333 * tui/tui-disasm.h: Update.
3334 * tui/tui-data.h (struct tui_exec_info_window): Move to
3335 tui-winsource.h.
3336 (struct tui_source_window_base): Likewise.
3337 * tui/tui-data.c (tui_source_window_base::clear_detail)
3338 (tui_source_window_base, ~tui_source_window_base): Move to
3339 tui-winsource.c.
3340
daa15dde
TT
33412019-07-17 Tom Tromey <tom@tromey.com>
3342
3343 * tui/tui-win.c (tui_resize_all)
3344 (tui_source_window_base::update_tab_width)
3345 (tui_adjust_win_heights): Update.
3346 (tui_win_info::make_invisible_and_set_new_height): Rename from
3347 make_invisible_and_set_new_height.
3348 * tui/tui-data.h (struct tui_win_info)
3349 <make_invisible_and_set_new_height>: New method.
3350
bfad4537
TT
33512019-07-17 Tom Tromey <tom@tromey.com>
3352
3353 * tui/tui.c: Update.
3354 * tui/tui-source.h (struct tui_source_window): Move from
3355 tui-data.h.
3356 * tui/tui-layout.c: Update.
3357 * tui/tui-disasm.c: Update.
3358 * tui/tui-data.h (struct tui_source_window): Move to
3359 tui-source.h.
3360
88f7e873
TT
33612019-07-17 Tom Tromey <tom@tromey.com>
3362
3363 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3364 tui-data.h.
3365 * tui/tui-data.h (struct tui_disasm_window): Move to
3366 tui-disasm.h.
3367
96bd6233
TT
33682019-07-17 Tom Tromey <tom@tromey.com>
3369
3370 * tui/tui-regs.h (struct tui_data_item_window): Move from
3371 tui-data.h.
3372 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3373 * tui/tui-data.h (struct tui_data_item_window): Move to
3374 tui-regs.h.
3375 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3376
ce38393b
TT
33772019-07-17 Tom Tromey <tom@tromey.com>
3378
3379 * tui/tui.c: Update.
3380 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3381 (tui_cmd_window::max_height): Move to tui-command.c.
3382 * tui/tui-layout.c: Update.
3383 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3384 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3385 tui-command.c.
3386 * tui/tui-command.h (struct tui_cmd_window): Move from
3387 tui-data.h.
3388 * tui/tui-command.c: Remove "structuring" comments.
3389 (tui_cmd_window::clear_detail)
3390 (tui_cmd_window::do_make_visible_with_new_height)
3391 (tui_cmd_window::max_height): Move from elsewhere.
3392
2d8b51cb
TT
33932019-07-17 Tom Tromey <tom@tromey.com>
3394
3395 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3396 Now static.
3397 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3398 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3399
18ab23af
TT
34002019-07-17 Tom Tromey <tom@tromey.com>
3401
3402 * tui/tui.c: Update.
3403 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3404 tui-regs.c.
3405 * tui/tui-windata.h: Remove file.
3406 * tui/tui-windata.c: Remove file.
3407 * tui/tui-win.c (tui_data_window::set_new_height)
3408 (tui_data_window::do_make_visible_with_new_height): Move to
3409 tui-regs.c.
3410 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3411 * tui/tui-regs.c: Remove "structuring" comments.
3412 (tui_data_window::first_data_item_displayed)
3413 (tui_data_window::delete_data_content_windows)
3414 (tui_data_window::erase_data_content)
3415 (tui_data_window::display_all_data)
3416 (tui_data_window::refresh_all)
3417 (tui_data_window::do_scroll_vertical)
3418 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3419 (tui_data_window::do_make_visible_with_new_height)
3420 (tui_data_window::refresh_window): Move from elsewhere.
3421 (_initialize_tui_regs): Move to end of file.
3422 * tui/tui-layout.c: Update.
3423 * tui/tui-hooks.c: Update.
3424 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3425 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3426 tui-regs.c.
3427 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3428
88b7e7cc
TT
34292019-07-17 Tom Tromey <tom@tromey.com>
3430
3431 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3432 seen.
3433
0fcd3711
TT
34342019-07-17 Tom Tromey <tom@tromey.com>
3435
3436 * tui/tui-win.c (tui_source_window_base::set_new_height)
3437 (tui_source_window_base::do_make_visible_with_new_height): Use
3438 m_has_locator field directly.
3439 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3440 method.
3441 (struct tui_source_window_base) <has_locator>: Likewise.
3442
4a38112d
TT
34432019-07-17 Tom Tromey <tom@tromey.com>
3444
3445 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3446 Don't declare.
3447 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3448 Remove.
3449 * tui/tui-win.c (tui_source_window_base::set_new_height)
3450 (tui_source_window_base::set_new_height)
3451 (make_invisible_and_set_new_height)
3452 (tui_source_window_base::do_make_visible_with_new_height)
3453 (tui_source_window_base::do_make_visible_with_new_height):
3454 Update.
3455 * tui/tui-layout.c (show_source_disasm_command, show_data)
3456 (show_source_or_disasm_and_command): Update.
3457 * tui/tui-layout.c (show_layout): Update.
3458
09129226
TT
34592019-07-17 Tom Tromey <tom@tromey.com>
3460
3461 * tui/tui-layout.c (make_data_window): Remove.
3462 (show_data): Unify creation and re-initialization cases.
3463
4a8a5e84
TT
34642019-07-17 Tom Tromey <tom@tromey.com>
3465
3466 * tui/tui-layout.c (make_source_window, make_disasm_window):
3467 Remove.
3468 (show_data): Unify creation and re-initialization cases.
3469
76d2be8e
TT
34702019-07-17 Tom Tromey <tom@tromey.com>
3471
3472 * tui/tui-layout.c (make_command_window): Remove.
3473 (show_source_disasm_command, show_source_or_disasm_and_command):
3474 Unify creation and re-initialization cases.
3475
890b8bde
TT
34762019-07-17 Tom Tromey <tom@tromey.com>
3477
3478 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3479 creation and re-initialization cases.
3480
2cdfa113
TT
34812019-07-17 Tom Tromey <tom@tromey.com>
3482
3483 * tui/tui-regs.c (tui_get_register): Return void.
3484
8e3cfd09
TT
34852019-07-17 Tom Tromey <tom@tromey.com>
3486
3487 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3488 Simplify.
3489
f4e04977
TT
34902019-07-17 Tom Tromey <tom@tromey.com>
3491
3492 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3493 resetting.
3494
0379b883
TT
34952019-07-17 Tom Tromey <tom@tromey.com>
3496
3497 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3498 * tui/tui-regs.c (tui_reg_layout): New function.
3499 (tui_show_registers, tui_reg_command): Use it.
3500 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3501 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3502 parameters.
3503 (tui_layout_command): Remove.
3504
b7fbad91
TT
35052019-07-17 Tom Tromey <tom@tromey.com>
3506
3507 * tui/tui-layout.h (tui/tui-layout): Return void.
3508 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3509
4e1e56b9
TT
35102019-07-17 Tom Tromey <tom@tromey.com>
3511
3512 * tui/tui-layout.c (show_source_disasm_command, show_data):
3513 Update.
3514 (reset_locator): Remove.
3515 (show_source_or_disasm_and_command): Update.
3516
1e0c09ba
TT
35172019-07-17 Tom Tromey <tom@tromey.com>
3518
3519 * tui/tui-source.c (tui_source_window_base::reset): Remove
3520 win_type parameter.
3521 * tui/tui-layout.c (make_command_window, make_source_window)
3522 (make_disasm_window, make_data_window)
3523 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3524 (reset_locator, show_source_or_disasm_and_command): Update.
3525 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3526 win_type parameter.
3527 (struct tui_source_window_base) <reset>: Likewise.
3528
1bf605de
TT
35292019-07-17 Tom Tromey <tom@tromey.com>
3530
3531 * tui/tui-layout.c (show_source_disasm_command): Use
3532 reset_locator.
3533 (reset_locator): New function.
3534 (init_and_make_win): Remove.
3535 (show_source_or_disasm_and_command): Use reset_locator.
3536
098f9ed4
TT
35372019-07-17 Tom Tromey <tom@tromey.com>
3538
3539 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3540 condition.
3541 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3542 Remove condition.
3543 * tui/tui-source.c (tui_source_window_base::reset): New method.
3544 * tui/tui-layout.c (make_command_window): Don't call
3545 init_and_make_win.
3546 (make_source_window, make_disasm_window): Don't call
3547 make_source_or_disasm_window.
3548 (make_data_window): Don't call init_and_make_win. Change calling
3549 convention.
3550 (show_source_disasm_command, show_data): Simplify.
3551 (make_source_or_disasm_window): Remove.
3552 (show_source_or_disasm_and_command): Simplify.
3553 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3554 (struct tui_source_window_base) <reset>: Likewise.
3555 <execution_info>: Remove initializer.
3556 * tui/tui-data.c (tui_source_window_base): Initialize
3557 execution_info.
3558
80110957
TT
35592019-07-17 Tom Tromey <tom@tromey.com>
3560
3561 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3562 variable.
3563
cf82af05
TT
35642019-07-17 Tom Tromey <tom@tromey.com>
3565
3566 * tui/tui.c (tui_rl_other_window): Update.
3567 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3568 superclass method first. Always iterate over regs_content.
3569 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3570 method.
3571 * tui/tui-win.c (tui_set_focus_command): Update.
3572
01aeb396
TT
35732019-07-17 Tom Tromey <tom@tromey.com>
3574
3575 * tui/tui-win.c (tui_set_focus_command): Rename from
3576 tui_set_focus. Call tui_enable.
3577 (tui_set_focus_command): Remove.
3578
fd6c75ee
TT
35792019-07-17 Tom Tromey <tom@tromey.com>
3580
3581 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3582 refresh_window.
3583 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3584 touchwin.
3585 (tui_data_window::refresh_window): Call refresh_window on data
3586 items. Always call superclass refresh_window.
3587 (tui_win_info::refresh): Remove.
3588 (tui_source_window_base::refresh_window): Update.
3589 (tui_refresh_all): Update.
3590 * tui/tui-layout.c (show_source_disasm_command): Remove call to
3591 refresh_window.
3592 (show_source_or_disasm_and_command): Likewise.
3593 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3594 (struct tui_source_window_base) <refresh>: Likewise.
3595
f6cc34a9
TT
35962019-07-17 Tom Tromey <tom@tromey.com>
3597
3598 * tui/tui-winsource.c (tui_clear_source_content)
3599 (tui_show_source_content): Update.
3600 * tui/tui-source.c (tui_source_window::showing_source_p): Check
3601 whether content is empty.
3602 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3603 Remove.
3604
f31ec9af
TT
36052019-07-17 Tom Tromey <tom@tromey.com>
3606
3607 * tui/tui-winsource.c (tui_erase_source_content): Clear the
3608 window's contents.
3609 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3610 * tui/tui-source.c (tui_set_source_content_nil): Remove.
3611
d1b6f1e5
TT
36122019-07-17 Tom Tromey <tom@tromey.com>
3613
3614 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3615 (struct tui_data_item_window): Update.
3616
d9743a13
TT
36172019-07-17 Tom Tromey <tom@tromey.com>
3618
3619 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3620 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3621 defines.
3622
caf0bc4e
TT
36232019-07-17 Tom Tromey <tom@tromey.com>
3624
3625 * tui/tui-winsource.h (tui_erase_source_content)
3626 (tui_clear_source_content): Remove "display_prompt" parameter.
3627 * tui/tui-winsource.c (tui_update_source_window_as_is)
3628 (tui_update_source_windows_with_addr): Update.
3629 (tui_clear_source_content): Remove "display_prompt" parameter.
3630 (tui_erase_source_content): Likewise. Simplify.
3631 (tui_show_source_content): Update.
3632 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3633 * tui/tui-stack.c (tui_show_frame_info): Update.
3634 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3635 Remove defines.
3636
9d391078
TT
36372019-07-17 Tom Tromey <tom@tromey.com>
3638
3639 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3640 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3641 parameter.
3642 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3643 parameter.
3644
a38da35d
TT
36452019-07-17 Tom Tromey <tom@tromey.com>
3646
3647 * tui/tui-winsource.c (tui_clear_source_content)
3648 (tui_show_source_content, tui_show_exec_info_content)
3649 (tui_clear_exec_info_content): Update.
3650 * tui/tui-stack.c (tui_show_locator_content): Update.
3651 (tui_show_frame_info): Update.
3652 * tui/tui-source.h (tui_source_window): Don't declare.
3653 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3654 from tui_source_is_displayed.
3655 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3656 Remove field.
3657 (struct tui_source_window_base) <content_in_use>: New field. Now
3658 bool.
3659 (struct tui_source_window) <showing_source_p>: New method.
3660 (TUI_SRC_WIN): Change cast.
3661 * tui/tui-data.c (tui_initialize_static_data): Update.
3662
c2cd8994
TT
36632019-07-17 Tom Tromey <tom@tromey.com>
3664
3665 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3666 location_matches_p.
3667 * tui/tui-source.c (tui_source_window::location_matches_p): New
3668 method.
3669 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3670 method.
3671 * tui/tui-data.h (struct tui_source_window_base)
3672 <location_matches_p>: New method.
3673 (struct tui_source_window, struct tui_disasm_window)
3674 <location_matches_p>: Likewise.
3675
4dde7b34
TT
36762019-07-17 Tom Tromey <tom@tromey.com>
3677
3678 * tui/tui-win.c (tui_set_win_height_command): Rename from
3679 tui_set_win_height.
3680 (tui_set_win_height_command): Remove.
3681
b73dd877
TT
36822019-07-17 Tom Tromey <tom@tromey.com>
3683
3684 * tui/tui-source.c (tui_source_window): New constructor. Add
3685 observer.
3686 (~tui_source_window): New destructor.
3687 (tui_source_window::style_changed): New method.
3688 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3689 (tui_attach_detach_observers): Update.
3690 * tui/tui-data.h (struct tui_source_window): Make constructor not
3691 inline. Add destructor.
3692 (struct tui_source_window) <style_changed>: New method.
3693 <m_observable>: New member.
3694
ae2b5380
TT
36952019-07-17 Tom Tromey <tom@tromey.com>
3696
3697 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3698 * tui/tui-win.c (tui_resize_all): Fix typo.
3699
1ce3e844
TT
37002019-07-17 Tom Tromey <tom@tromey.com>
3701
3702 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3703 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3704 (tui_refresh_all): Remove "list" parameter. Use foreach.
3705 * tui/tui-win.c (window_name_completer): Use foreach.
3706 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3707 (update_tab_width): Likewise.
3708 * tui/tui-layout.c (show_layout): Update.
3709 * tui/tui-data.h (class tui_window_iterator): New.
3710 (struct all_tui_windows): New.
3711 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3712
fe3eaf1c
TT
37132019-07-17 Tom Tromey <tom@tromey.com>
3714
3715 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3716 parameter. Don't reference globals.
3717 (tui_reg_command): Update.
3718
368c1354
TT
37192019-07-17 Tom Tromey <tom@tromey.com>
3720
3721 * tui/tui-regs.c (tui_show_registers): Simplify.
3722
e80cd204
TT
37232019-07-17 Tom Tromey <tom@tromey.com>
3724
3725 * tui/tui-regs.c (tui_show_registers): Update.
3726 (tui_show_register_group): Add win_info parameter.
3727
aca2dd16
TT
37282019-07-17 Tom Tromey <tom@tromey.com>
3729
3730 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3731 Rename from tui_display_reg_element_at_line.
3732 (tui_data_window::display_registers_from_line): Update.
3733 * tui/tui-data.h (struct tui_data_window)
3734 <display_reg_element_at_line>: New method.
3735
517e9505
TT
37362019-07-17 Tom Tromey <tom@tromey.com>
3737
3738 * tui/tui-regs.h (tui_display_registers_from)
3739 (tui_display_registers_from_line): Don't declare.
3740 * tui/tui-windata.c (tui_data_window::display_all_data)
3741 (tui_data_window::refresh_all)
3742 (tui_data_window::do_scroll_vertical): Update.
3743 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3744 from tui_display_registers_from.
3745 (tui_display_reg_element_at_line): Update.
3746 (tui_data_window::display_registers_from_line): Rename from
3747 tui_display_registers_from_line.
3748 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3749 display_registers_from_line>: New methods.
3750
f76d8b19
TT
37512019-07-17 Tom Tromey <tom@tromey.com>
3752
3753 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3754 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3755 from tui_erase_data_content.
3756 (tui_data_window::display_all_data)
3757 (tui_data_window::refresh_all)
3758 (tui_data_window::do_scroll_vertical): Update.
3759 * tui/tui-regs.c (tui_show_registers): Update.
3760 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3761 New method.
3762
b4094625
TT
37632019-07-17 Tom Tromey <tom@tromey.com>
3764
3765 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3766 declare.
3767 * tui/tui-windata.c
3768 (tui_data_window::delete_data_content_windows): Rename from
3769 tui_delete_data_content_windows.
3770 (tui_data_window::display_all_data)
3771 (tui_data_window::do_scroll_vertical): Update.
3772 * tui/tui-data.h (struct tui_data_window)
3773 <delete_data_content_windows>: New method.
3774
c223a729
TT
37752019-07-17 Tom Tromey <tom@tromey.com>
3776
3777 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3778 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3779
50daf268
TT
37802019-07-17 Tom Tromey <tom@tromey.com>
3781
3782 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3783 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3784 from tui_display_all_data.
3785 * tui/tui-win.c
3786 (tui_data_window::do_make_visible_with_new_height): Update.
3787 * tui/tui-regs.c (tui_show_registers): Update.
3788 * tui/tui-layout.c (tui_set_layout): Update.
3789 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3790 method.
3791
df5f8cab
TT
37922019-07-17 Tom Tromey <tom@tromey.com>
3793
3794 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3795 * tui/tui-windata.c (tui_display_data_from): Remove.
3796 (tui_data_window::refresh_all): Update.
3797
80cb6c27
TT
37982019-07-17 Tom Tromey <tom@tromey.com>
3799
3800 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3801 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3802 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3803 tui_display_registers_from_line.
3804 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3805 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3806 "force_display" parameter.
3807
baff0c28
TT
38082019-07-17 Tom Tromey <tom@tromey.com>
3809
3810 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3811 declare.
3812 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3813 Rename from tui_first_reg_element_no_inline.
3814 (tui_display_reg_element_at_line)
3815 (tui_display_registers_from_line): Update.
3816 * tui/tui-data.h (struct tui_data_window)
3817 <first_reg_element_no_inline>: New method.
3818
3b23c5f2
TT
38192019-07-17 Tom Tromey <tom@tromey.com>
3820
3821 * tui/tui-windata.c (tui_display_data_from)
3822 (tui_data_window::do_scroll_vertical): Update.
3823 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3824 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3825 Rename from tui_line_from_reg_element_no.
3826 (tui_display_registers_from_line): Update.
3827 * tui/tui-data.h (struct tui_data_window)
3828 <line_from_reg_element_no>: New method.
3829
0b5ec218
TT
38302019-07-17 Tom Tromey <tom@tromey.com>
3831
3832 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3833 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3834 tui_last_regs_line_no.
3835 (tui_display_reg_element_at_line)
3836 (tui_display_registers_from_line): Update.
3837 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3838 method.
3839
0807ab7b
TT
38402019-07-17 Tom Tromey <tom@tromey.com>
3841
3842 PR tui/24722:
3843 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3844 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3845 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3846 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3847 (tui_update_breakpoint_info): Likewise.
3848 * tui/tui-hooks.c (tui_event_create_breakpoint)
3849 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3850 Update.
3851
9ad7fdef
TT
38522019-07-17 Tom Tromey <tom@tromey.com>
3853
3854 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3855
5813316f
TT
38562019-07-17 Tom Tromey <tom@tromey.com>
3857
3858 * tui/tui-winsource.c (tui_update_source_window_as_is)
3859 (tui_update_source_windows_with_addr): Update.
3860 * tui/tui-source.h (tui_set_source_content)
3861 (tui_show_symtab_source): Add "win_info" parameter.
3862 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3863 parameter.
3864 (tui_show_symtab_source): Likewise.
3865
00e264e7
TT
38662019-07-17 Tom Tromey <tom@tromey.com>
3867
3868 * tui/tui-wingeneral.c
3869 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3870
06210ce4
TT
38712019-07-17 Tom Tromey <tom@tromey.com>
3872
3873 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3874 (struct tui_cmd_window) <can_scroll>: New method.
3875 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3876 method.
3877
381befee
TT
38782019-07-17 Tom Tromey <tromey@adacore.com>
3879
3880 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3881 do_field_signed>: Rename. Change type of "value".
3882 * ui-out.c (ui_out::field_signed): Rename from field_int.
3883 Change type of "value".
3884 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3885 type of "value".
3886 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3887 do_field_int. Change type of "value".
3888 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3889 do_field_int. Change type of "value".
3890 * tracepoint.c (trace_status_mi, tfind_1)
3891 (print_one_static_tracepoint_marker): Update.
3892 * thread.c (print_thread_info_1, print_selected_thread_frame):
3893 Update.
3894 * stack.c (print_frame, print_frame_info): Update.
3895 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3896 Update.
3897 * source.c (print_source_lines_base): Update.
3898 * skip.c (info_skip_command): Update.
3899 * record-btrace.c (btrace_ui_out_decode_error)
3900 (btrace_call_history_src_line): Update.
3901 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3902 Update.
3903 * progspace.c (print_program_space): Update.
3904 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3905 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3906 do_field_int. Change type of "value".
3907 * mi/mi-out.c (mi_ui_out::do_table_begin)
3908 (mi_ui_out::do_table_header): Update.
3909 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3910 type of "value".
3911 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3912 (mi_cmd_data_list_changed_registers, output_register)
3913 (mi_cmd_data_read_memory, mi_load_progress)
3914 (mi_cmd_trace_frame_collected): Update.
3915 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3916 Update.
3917 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3918 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3919 (mi_cmd_var_list_children, varobj_update_one): Update.
3920 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3921 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3922 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3923 * inferior.c (print_inferior): Update.
3924 * gdb_bfd.c (print_one_bfd): Update.
3925 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3926 Update.
3927 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3928 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3929 do_field_int. Change type of "value".
3930 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3931 do_field_int. Change type of "value".
3932 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3933 (print_one_breakpoint_location, print_it_catch_fork)
3934 (print_one_catch_fork, print_it_catch_vfork)
3935 (print_one_catch_vfork, print_it_catch_solib)
3936 (print_it_catch_exec, print_it_ranged_breakpoint)
3937 (print_mention_watchpoint, print_mention_masked_watchpoint)
3938 (bkpt_print_it, update_static_tracepoint): Update.
3939 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3940 * break-catch-syscall.c (print_it_catch_syscall): Update.
3941 * ada-tasks.c (print_ada_task_info): Update.
3942 * ada-lang.c (print_it_exception, print_mention_exception):
3943 Update.
3944
6b78c3f8
AB
39452019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3946
3947 PR breakpoints/24541
3948 * gdbarch.c: Regenerate.
3949 * gdbarch.h: Regenerate.
3950 * gdbarch.sh: Adjust return type and parameter types for
3951 'stap_adjust_register'.
3952 (i386_stap_adjust_register): Adjust signature and return new
3953 register name.
3954 * stap-probe.c (stap_parse_register_operand): Adjust use of
3955 'gdbarch_stap_adjust_register'.
3956
d72a9b85
TT
39572019-07-17 Tom Tromey <tromey@adacore.com>
3958
3959 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3960 declare VEC.
3961 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3962 std::vector.
3963 (struct s390_process_info): Add initializers.
3964 (s390_add_process): Use new.
3965 (s390_linux_nat_target::low_forget_process): Use delete.
3966 (s390_linux_nat_target::low_new_fork)
3967 (s390_linux_nat_target::stopped_by_watchpoint)
3968 (s390_linux_nat_target::low_prepare_to_resume)
3969 (s390_linux_nat_target::insert_watchpoint)
3970 (s390_linux_nat_target::insert_hw_breakpoint)
3971 (s390_linux_nat_target::remove_watchpoint)
3972 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3973
206e6c58
JB
39742019-07-16 John Baldwin <jhb@FreeBSD.org>
3975
3976 * aarch64-fbsd-nat.c: Include regcache.h.
3977 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3978 argument.
3979 (aarch64_fbsd_nat_target::fetch_registers)
3980 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3981 variable.
3982 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3983
cbde90f2
JB
39842019-07-16 John Baldwin <jhb@FreeBSD.org>
3985
3986 * fbsd-nat.c: Include gdbarch.h.
3987
07128006
TT
39882019-07-15 Tom Tromey <tromey@adacore.com>
3989
3990 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3991
1f77b012
TT
39922019-07-15 Tom Tromey <tromey@adacore.com>
3993
3994 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3995 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3996 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3997 * cli-out.c (cli_ui_out::do_field_int): New method.
3998 * ui-out.c (ui_out::field_unsigned): New method.
3999 * symfile.c (generic_load): Use field_unsigned.
4000 (print_transfer_performance): Likewise.
4001 * record-btrace.c (ui_out_field_uint): Remove.
4002 (btrace_call_history_insn_range, btrace_call_history): Use
4003 field_unsigned.
4004 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4005 field_unsigned.
4006 * ui-out.h (class ui_out) <field_unsigned>: New method.
4007 <do_field_unsigned>: Likewise.
4008
33eca680
TT
40092019-07-15 Tom Tromey <tromey@adacore.com>
4010
4011 * mi/mi-main.c (list_available_thread_groups): Use field_string.
4012 * mi/mi-interp.c (mi_memory_changed): Use field_string.
4013 * target.c (flash_erase_command): Use field_string.
4014 * infrun.c (print_signal_received_reason): Use field_string.
4015 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4016 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4017 field_string.
4018 * ada-tasks.c (print_ada_task_info): Use field_string.
4019
ca8d69be
TT
40202019-07-15 Tom Tromey <tromey@adacore.com>
4021
4022 * target.c (flash_erase_command): Use field_core_addr.
4023 * symfile.c (generic_load): Use field_core_addr.
4024 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4025 Use field_core_addr.
4026 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4027 field_core_addr.
4028
0d4e84ed
AB
40292019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4030
4031 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4032 value if its desired type is smaller than a CORE_ADDR and signed.
4033
9a49df9d
AB
40342019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4035
4036 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4037 of changes to field names, and use new is_reference field to
4038 decide if a property is a reference or not.
4039 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4040 field.
4041 (struct dwarf2_property_baton): Update header comment, rename
4042 'referenced_type' to 'property_type' and update comments.
4043 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4044 default property type, store in property baton, update to take
4045 accound of renamed field.
4046 (read_func_scope): Update call to attr_to_dynamic_prop.
4047 (read_array_type): Likewise.
4048 (dwarf2_per_cu_addr_sized_int_type): New function.
4049 (read_subrange_index_type): Move type finding code to
4050 dwarf2_per_cu_addr_sized_int_type.
4051 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4052 (dwarf2_per_cu_addr_type): New function.
4053 (set_die_type): Update calls to attr_to_dynamic_prop.
4054
b86352cf
AB
40552019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4056
4057 * dwarf2read.c (read_subrange_index_type): New function.
4058 (read_subrange_type): Move code into new function and call it.
4059 * gdbtypes.c (create_range_type): Add some asserts.
4060
603490bf
AB
40612019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4062
4063 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4064 update return statements.
4065 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4066 declaration, and update comment to match.
4067 * gdbtypes.c (resolve_dynamic_array): Update call to
4068 dwarf2_evaluate_property to match new return type.
4069
592f9d27
AB
40702019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4071
4072 * valarith.c (value_subscripted_rvalue): Change lowerbound
4073 parameter type from int to LONGEST.
4074 * value.h (value_subscripted_rvalue): Likewise in declaration.
4075
60cfcb20
AB
40762019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4077
4078 * cli/cli-utils.c (info_print_command_completer): New function.
4079 * cli/cli-utils.h: Add 'completer.h' include, and forward
4080 declaration for 'struct cmd_list_element'.
4081 (info_print_command_completer): Declare.
4082 * stack.c (_initialize_stack): Add completer for 'info locals' and
4083 'info args'.
4084 * symtab.c (_initialize_symtab): Add completer for 'info
4085 variables' and 'info functions'.
4086 * NEWS: Mention completion for additional info commands.
4087
b16507e0
AB
40882019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4089
4090 * cli/cli-utils.c (extract_info_print_args): Delete.
4091 (extract_arg_maybe_quoted): Delete.
4092 (info_print_options_defs): New variable.
4093 (make_info_print_options_def_group): New function.
4094 (extract_info_print_options): Define new function.
4095 * cli/cli-utils.h (extract_info_print_args): Delete.
4096 (struct info_print_options): New structure.
4097 (extract_info_print_options): Declare new function.
4098 * stack.c (info_locals_command): Update to use new
4099 extract_info_print_options, also add a header comment.
4100 (info_args_command): Likewise.
4101 * symtab.c (info_variables_command): Likewise.
4102 (info_functions_command): Likewise.
4103
021d8588
AB
41042019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4105
4106 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4107 to extract string arguments.
4108 * common/common-utils.c (extract_string_maybe_quoted): New function.
4109 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4110
b777eb6d
TT
41112019-07-11 Tom Tromey <tromey@adacore.com>
4112
4113 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4114 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4115 * top.h (gdbinit): Don't declare.
4116 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4117 into...
4118 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4119 * top.c (gdb_init): Don't call init_cli_cmds.
4120 (gdbinit): Remove.
4121 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4122
72ee03ff
TT
41232019-07-11 Tom Tromey <tromey@adacore.com>
4124
4125 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4126 after it has been moved.
4127
00db9531
SM
41282019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4129
4130 * valops.c (value_must_coerce_to_target): Change return type to
4131 bool.
4132 * value.h (value_must_coerce_to_target): Likewise.
4133
f2478a7e
SM
41342019-07-10 Simon Marchi <simon.marchi@efficios.com>
4135
4136 * breakpoint.c (is_hardware_watchpoint): Remove
4137 forward-declaration.
4138 (is_masked_watchpoint): Change return type to bool.
4139 (is_tracepoint): Likewise.
4140 (is_breakpoint): Likewise.
4141 (is_hardware_watchpoint): Likewise.
4142 (is_watchpoint): Likewise.
4143 (is_no_memory_software_watchpoint): Likewise.
4144 (is_catchpoint): Likewise.
4145 (breakpoint_1): Make FILTER parameter's return type bool.
4146 is_masked_watchpoint): Change return type to bool.
4147 (save_breakpoints): Make FILTER parameter's return type bool.
4148 * breakpoint.h (is_breakpoint): Change return type to bool.
4149 (is_watchpoint): Likewise.
4150 (is_catchpoint): Likewise.
4151 (is_tracepoint): Likewise.
4152
0d12e84c
TT
41532019-07-10 Tom Tromey <tom@tromey.com>
4154
4155 * defs.h: Don't include gdbarch.h.
4156 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4157 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4158 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4159 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4160 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4161 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4162 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4163 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4164 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4165 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4166 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4167 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4168 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4169 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4170 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4171 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4172 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4173 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4174 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4175 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4176 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4177 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4178 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4179 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4180 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4181 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4182 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4183
f06f1252
TT
41842019-07-10 Tom Tromey <tromey@adacore.com>
4185
4186 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4187 * breakpoint.c (init_ada_exception_breakpoint): Register as
4188 bp_catchpoint.
4189 (print_one_breakpoint_location, print_one_breakpoint): Use
4190 is_ada_exception_catchpoint.
4191 * ada-lang.c (class ada_catchpoint_location): Pass
4192 bp_loc_software_breakpoint to bp_location constructor.
4193 (is_ada_exception_catchpoint): New function.
4194
7a5d944b
TT
41952019-07-10 Tom Tromey <tromey@adacore.com>
4196
4197 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4198 VEC.
4199 (struct arm_exidx_entry): New method operator<.
4200 (struct arm_exidx_data) <section_maps>: Change type.
4201 (arm_exidx_data_free): Remove.
4202 (arm_exidx_data_key): Change type. Move lower.
4203 (arm_exidx_new_objfile): Update.
4204 (arm_compare_exidx_entries): Remove.
4205 (arm_find_exidx_entry, _initialize_arm_tdep)
4206
48c66e1d
TT
42072019-07-10 Tom Tromey <tromey@adacore.com>
4208
4209 * solib-spu.c (ocl_program_data_key): Change type.
4210 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4211 Update.
4212
a269fbf1
TT
42132019-07-10 Tom Tromey <tromey@adacore.com>
4214
4215 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4216 (struct solib_aix_inferior_data) <library_list>: Change type.
4217 (solib_aix_inferior_data_handle): Change type.
4218 (get_solib_aix_inferior_data): Update.
4219 (solib_aix_free_library_list): Remove.
4220 (library_list_start_library): Update.
4221 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4222 return type.
4223 (solib_aix_get_library_list)
4224 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4225 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4226
c294730c
TT
42272019-07-10 Tom Tromey <tromey@adacore.com>
4228
4229 * solib-dsbt.c (struct dsbt_info): Add initializers.
4230 (solib_dsbt_pspace_data): Change type.
4231 (dsbt_pspace_data_cleanup): Remove.
4232 (get_dsbt_info, _initialize_dsbt_solib): Update.
4233
9d52077d
TT
42342019-07-10 Tom Tromey <tromey@adacore.com>
4235
4236 * spu-tdep.c (spu_overlay_data): Change type.
4237 (spu_get_overlay_table, spu_overlay_new_objfile)
4238 (_initialize_spu_tdep): Update.
4239
22a20dca
TT
42402019-07-10 Tom Tromey <tromey@adacore.com>
4241
4242 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4243 destructor.
4244 (dbx_objfile_data_key): Change type and declare later.
4245 (DBX_SYMFILE_INFO): Rewrite.
4246 * dbxread.c (dbx_objfile_data_key): Change type.
4247 (dbx_symfile_init): Update.
4248 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4249 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4250 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4251
cb60f420
TT
42522019-07-10 Tom Tromey <tromey@adacore.com>
4253
4254 * jit.c (jit_program_space_key): Change type. Move lower.
4255 (get_jit_program_space_data): Update.
4256 (jit_program_space_data_cleanup): Remove.
4257 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4258 Update.
4259 (struct jit_program_space_data): Add initializers.
4260
51df2ae3
TT
42612019-07-10 Tom Tromey <tromey@adacore.com>
4262
4263 * solib-darwin.c (struct darwin_info): Add initializers.
4264 (solib_darwin_pspace_data): Change type.
4265 (darwin_pspace_data_cleanup): Remove.
4266 (get_darwin_info, _initialize_darwin_solib): Update.
4267
18101a35
TT
42682019-07-10 Tom Tromey <tromey@adacore.com>
4269
4270 * remote-sim.c (struct sim_inferior_data): Add initializers,
4271 constructor, and destructor.
4272 (sim_inferior_data_key): Change type. Move lower.
4273 (check_for_duplicate_sim_descriptor): Update.
4274 (get_sim_inferior_data): Use new. Update.
4275 (~sim_inferior_data_cleanup): Rename from
4276 sim_inferior_data_cleanup. Simplify.
4277 (gdbsim_close_inferior, simulator_command)
4278 (sim_command_completer, _initialize_remote_sim): Update.
4279 (next_pid, INITIAL_PID): Move earlier.
4280
05b08ac1
TT
42812019-07-10 Tom Tromey <tromey@adacore.com>
4282
4283 * python/python-internal.h (create_thread_object): Return
4284 gdbpy_ref.
4285 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4286 * python/py-inferior.c (struct threadlist_entry): Add
4287 constructor.
4288 <thread_obj>: Now a gdbpy_ref.
4289 (thread_to_thread_object): Update.
4290 (add_thread_object): Use new.
4291 (delete_thread_object): Use delete.
4292 (infpy_threads): Update.
4293 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4294 GIL.
4295
32372d80
TT
42962019-07-10 Tom Tromey <tromey@adacore.com>
4297
4298 * valops.c (value_cast): Specialize error message for Ada.
4299
5c458ae8
SM
43002019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4301
4302 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4303
4c462cb0
SM
43042019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4305
4306 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4307 bpstat_should_step): Return bool, adjust comments.
4308 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4309 bpstat_should_step): Likewise.
4310
89abbcc2
AH
43112019-07-10 Alan Hayward <alan.hayward@arm.com>
4312
4313 * features/Makefile: Use feature target descriptions for Arm.
4314 * features/arm/arm-core.c: Generate new file.
4315 * features/arm/arm-fpa.c: Likewise.
4316 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4317 * features/arm/arm-m-profile.c: Likewise.
4318 * features/arm/arm-vfpv2.c: Likewise.
4319 * features/arm/arm-vfpv3.c: Likewise.
4320 * features/arm/xscale-iwmmxt.c: Likewise.
4321 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4322
166a82be
AH
43232019-07-10 Alan Hayward <alan.hayward@arm.com>
4324
4325 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4326 ptrace earlier.
4327
9fb4c7e9
AH
43282019-07-10 Alan Hayward <alan.hayward@arm.com>
4329
4330 * features/aarch64-pauth.c: Regenerate.
4331
e2d0f980
SM
43322019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4333
4334 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4335 bool.
4336 (bpstat_what): Use false instead of 0.
4337
a38118e5
PA
43382019-07-09 Pedro Alves <palves@redhat.com>
4339
4340 * break-catch-throw.c (is_exception_catchpoint): New.
4341 * breakpoint.c (print_one_breakpoint_location): New parameter
4342 'raw_loc'. Handle it. Use
4343 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4344 looking at the breakpoint's type.
4345 (print_one_breakpoint): If handling "maint info breakpoints", also
4346 print locations of exception catchpoints.
4347 * breakpoint.h (is_exception_catchpoint): Declare.
4348
cb1e4e32
PA
43492019-07-09 Pedro Alves <palves@redhat.com>
4350
4351 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4352 "addr" field.
4353 (allocate_location_exception_catchpoint): New.
4354 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4355 (initialize_throw_catchpoint_ops): Install
4356 allocate_location_exception_catchpoint as allocate_location
4357 method.
4358 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4359 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4360 bp_loc_other.
4361 (breakpoint_address_is_meaningful): Delete.
4362 (bl_address_is_meaningful): New.
4363 (breakpoint_locations_match): Adjust comment.
4364 (bp_location_from_bp_type): New, factored out of...
4365 (bp_location::bp_location(breakpoint *)): ... this.
4366 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4367 factored out of...
4368 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4369 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4370 breakpoint_address_is_meaningful.
4371 (bp_locations_compare): Adjust comment.
4372 (update_global_location_list): Use bl_address_is_meaningful
4373 instead of breakpoint_address_is_meaningful.
4374 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4375 explicit.
4376 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4377 * python/py-breakpoint.c (bppy_get_location): No longer check
4378 whether location is null.
4379
b58a68fe
PA
43802019-07-09 Pedro Alves <palves@redhat.com>
4381
4382 PR c++/15468
4383 * breakpoint.c (print_one_breakpoint_location): Remove
4384 single-location assert.
4385
268a13a5
TT
43862019-07-09 Tom Tromey <tom@tromey.com>
4387
4388 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4389 * configure: Rebuild.
4390 * configure.ac: Change common to gdbsupport.
4391 * gdbsupport: Rename from common.
4392 * acinclude.m4: Change common to gdbsupport.
4393 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4394 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4395 gdbsupport.
4396 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4397 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4398 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4399 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4400 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4401 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4402 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4403 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4404 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4405 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4406 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4407 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4408 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4409 coff-pe-read.c, command.h, compile/compile-c-support.c,
4410 compile/compile-c.h, compile/compile-cplus-symbols.c,
4411 compile/compile-cplus-types.c, compile/compile-cplus.h,
4412 compile/compile-loc2c.c, compile/compile.c, completer.c,
4413 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4414 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4415 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4416 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4417 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4418 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4419 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4420 features/aarch64-core.c, features/aarch64-fpu.c,
4421 features/aarch64-pauth.c, features/aarch64-sve.c,
4422 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4423 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4424 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4425 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4426 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4427 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4428 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4429 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4430 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4431 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4432 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4433 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4434 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4435 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4436 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4437 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4438 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4439 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4440 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4441 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4442 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4443 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4444 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4445 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4446 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4447 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4448 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4449 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4450 minsyms.c, mips-linux-tdep.c, namespace.h,
4451 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4452 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4453 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4454 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4455 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4456 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4457 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4458 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4459 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4460 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4461 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4462 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4463 procfs.c, producer.c, progspace.h, psymtab.h,
4464 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4465 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4466 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4467 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4468 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4469 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4470 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4471 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4472 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4473 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4474 target-memory.c, target.c, target.h, target/waitstatus.c,
4475 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4476 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4477 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4478 unittests/array-view-selftests.c,
4479 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4480 unittests/common-utils-selftests.c,
4481 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4482 unittests/format_pieces-selftests.c,
4483 unittests/function-view-selftests.c,
4484 unittests/lookup_name_info-selftests.c,
4485 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4486 unittests/mkdir-recursive-selftests.c,
4487 unittests/observable-selftests.c,
4488 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4489 unittests/parse-connection-spec-selftests.c,
4490 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4491 unittests/scoped_fd-selftests.c,
4492 unittests/scoped_mmap-selftests.c,
4493 unittests/scoped_restore-selftests.c,
4494 unittests/string_view-selftests.c, unittests/style-selftests.c,
4495 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4496 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4497 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4498 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4499 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4500 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4501
5b0e2db4
AB
45022019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4503
4504 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4505 bool value.
4506 (decode_digits_ordinary): Set explicit_line field in sal.
4507 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4508 symtab_and_line that was set on an explicit line number in
4509 assembler code. Do always update the recorded symtab and line if
4510 we do skip the prologue.
4511
0ba852ab
AB
45122019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4513
4514 * breakpoint.c (set_breakpoint_location_function): Remove
4515 explicit_loc parameter.
4516 (momentary_breakpoint_from_master): Update call to
4517 set_breakpoint_location_function.
4518 (add_location_to_breakpoint): Likewise.
4519
b3a7d171
AB
45202019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4521
4522 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4523 required features based on default bfd type when no specific bfd
4524 is present.
4525
1f6f6e21
PW
45262019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4527
4528 * NEWS: Mention that GDB printf and eval commands can now print
4529 C-style and Ada-style convenience var strings without
4530 calling the inferior.
4531 * printcmd.c (printf_c_string): Locally print GDB internal var
4532 instead of transiting via the inferior.
4533 (printf_wide_c_string): Likewise.
4534
45352019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 4536
5862c886 4537 PR breakpoints/25011
ea142fbf
AH
4538 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4539
0598af48
TT
45402019-07-04 Tom Tromey <tom@tromey.com>
4541
4542 PR tui/24724:
4543 * tui/tui-winsource.c (tui_clear_source_content): Update.
4544 (tui_source_window_base::set_is_exec_point_at): Fix comment.
4545 (tui_update_breakpoint_info): Update.
4546 (tui_set_exec_info_content): Update.
4547 * tui/tui-source.c (tui_set_source_content_nil): Update.
4548 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4549 has_break.
4550 * tui/tui-data.h (enum tui_bp_flag): New.
4551 (tui_bp_flags): New enum flags type.
4552 (struct tui_source_element) <break_mode>: Change type. Rename
4553 from has_break.
4554 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4555 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
4556 constants.
4557 * tui/tui-winsource.h: Fix comment.
4558
350fab54
AH
45592019-07-04 Alan Hayward <alan.hayward@arm.com>
4560
4561 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4562 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4563 (store_fpregs_to_thread)
4564 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4565 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4566 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4567 (IWMMXT_REGS_SIZE): Add define.
4568 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4569 (fetch_vfp_regs, store_vfp_regs)
4570 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4571 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4572
f0452268
AH
45732019-07-04 Alan Hayward <alan.hayward@arm.com>
4574
4575 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4576 defines.
4577 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4578 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4579 (ARM_INT_REGISTER_SIZE): ...to this.
4580 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4581 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4582 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4583 (arm_linux_collect_gregset, supply_nwfpe_register)
4584 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4585 defines.
4586 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4587 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4588 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4589 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4590 (arm_return_in_memory, arm_store_return_value)
4591 (arm_get_longjmp_target, arm_register_g_packet_guesses)
4592 (arm_record_ld_st_multiple): Likewise.
4593 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4594 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4595
e935475c
AH
45962019-07-04 Alan Hayward <alan.hayward@arm.com>
4597
4598 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4599 AARCH64_DISPLACED_MODIFIED_INSNS.
4600 * aarch64-tdep.c (struct aarch64_displaced_step_data)
4601 (aarch64_displaced_step_copy_insn): Likewise.
4602 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4603 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4604 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4605 ARM_DISPLACED_MODIFIED_INSNS.
4606 * arm-tdep.c (arm_gdbarch_init): Likewise.
4607 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4608 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4609 (struct arm_displaced_step_closure): Use
4610 ARM_DISPLACED_MODIFIED_INSNS.
4611
df0bb381
AH
46122019-07-04 Alan Hayward <alan.hayward@arm.com>
4613
4614 * features/Makefile: Remove unused xml files.
4615 * features/aarch64.xml: Remove.
4616 * features/i386/amd64-avx-avx512-linux.xml: Remove.
4617 * features/i386/amd64-avx-avx512.xml: Remove.
4618 * features/i386/amd64-avx-linux.xml: Remove.
4619 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4620 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4621 * features/i386/amd64-avx-mpx-linux.xml: Remove.
4622 * features/i386/amd64-avx-mpx.xml: Remove.
4623 * features/i386/amd64-avx.xml: Remove.
4624 * features/i386/amd64-linux.xml: Remove.
4625 * features/i386/amd64-mpx-linux.xml: Remove.
4626 * features/i386/amd64-mpx.xml: Remove.
4627 * features/i386/amd64.xml: Remove.
4628 * features/i386/i386-avx-avx512-linux.xml: Remove.
4629 * features/i386/i386-avx-avx512.xml: Remove.
4630 * features/i386/i386-avx-linux.xml: Remove.
4631 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4632 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4633 * features/i386/i386-avx-mpx-linux.xml: Remove.
4634 * features/i386/i386-avx-mpx.xml: Remove.
4635 * features/i386/i386-avx.xml: Remove.
4636 * features/i386/i386-linux.xml: Remove.
4637 * features/i386/i386-mmx-linux.xml: Remove.
4638 * features/i386/i386-mmx.xml: Remove.
4639 * features/i386/i386-mpx-linux.xml: Remove.
4640 * features/i386/i386-mpx.xml: Remove.
4641 * features/i386/i386.xml: Remove.
4642 * features/i386/x32-avx-avx512-linux.xml: Remove.
4643 * features/i386/x32-avx-linux.xml: Remove.
4644 * features/i386/x32-linux.xml: Remove.
4645
edd6266a
AH
46462019-07-04 Alan Hayward <alan.hayward@arm.com>
4647
4648 * regformats/aarch64.dat: Remove.
4649 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4650 * regformats/i386/amd64-avx-linux.dat: Remove.
4651 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4652 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4653 * regformats/i386/amd64-linux.dat: Remove.
4654 * regformats/i386/amd64-mpx-linux.dat: Remove.
4655 * regformats/i386/amd64.dat: Remove.
4656 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4657 * regformats/i386/i386-avx-linux.dat: Remove.
4658 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4659 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4660 * regformats/i386/i386-linux.dat: Remove.
4661 * regformats/i386/i386-mmx-linux.dat: Remove.
4662 * regformats/i386/i386-mpx-linux.dat: Remove.
4663 * regformats/i386/i386.dat: Remove.
4664 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4665 * regformats/i386/x32-avx-linux.dat: Remove.
4666 * regformats/i386/x32-linux.dat: Remove.
4667
2b40fda7
AH
46682019-07-04 Alan Hayward <alan.hayward@arm.com>
4669
4670 * aarch64-tdep.c: Remove xml self tests.
4671 * amd64-linux-tdep.c: Likewise.
4672 * amd64-tdep.c: Likewise.
4673 * i386-linux-tdep.c: Likewise.
4674 * i386-tdep.c: Likewise.
4675
5f4ba3e7
PA
46762019-07-03 Pedro Alves <palves@redhat.com>
4677
4678 PR cli/24732
4679 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4680 (pipe_cmd_option_defs): New.
4681 (make_pipe_cmd_options_def_group): New.
4682 (pipe_command): Use gdb::option::process_options.
4683 (pipe_command_completer): New function.
4684 (_initialize_cli_cmds): Install completer for "pipe" command.
4685
3d9be6f5
PA
46862019-07-03 Pedro Alves <palves@redhat.com>
4687
4688 * cli/cli-option.c (union option_value) <string>: New field.
4689 (struct option_def_and_value): Add ctor, move ctor, dtor and
4690 use DISABLE_COPY_AND_ASSIGN.
4691 (option_def_and_value::clear_value): New.
4692 (parse_option, save_option_value_in_ctx, get_val_type_str)
4693 (add_setshow_cmds_for_options): Handle var_string.
4694 * cli-option.h (union option_def::var_address) <string>: New
4695 field.
4696 (struct string_option_def): New.
4697 * maint-test-options.c (struct test_options_opts): Add default
4698 ctor and use DISABLE_COPY_AND_ASSIGN.
4699 <string_opt>: New field.
4700 (test_options_opts::~test_options_opts): New.
4701 (test_options_opts::dump): Also dump "-string".
4702 (test_options_option_defs): Install "string.
4703
41fc454c
PA
47042019-07-03 Pedro Alves <palves@redhat.com>
4705
4706 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4707 option_value with a null enumeration.
4708 (complete_options): Save the option values in the context.
4709 (save_option_value_in_ctx): New, factored out from ...
4710 (process_options): ... here.
4711 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4712 of the function.
4713 * maint-test-options.c (test_options_opts::dump): New, factored
4714 out from ...
4715 (maintenance_test_options_command_mode): ... here.
4716 (maintenance_test_options_command_completion_result): Delete.
4717 (maintenance_test_options_command_completion_text): Update
4718 comment.
4719 (maintenance_show_test_options_completion_result): Change
4720 prototype. Just print
4721 maintenance_test_options_command_completion_text.
4722 (save_completion_result): New.
4723 (maintenance_test_options_completer_mode): Pass options context to
4724 complete_options, and then save a dump.
4725 (_initialize_maint_test_options): Use add_cmd to install "maint
4726 show test-options-completion-result".
4727
fdbc9870
PA
47282019-07-03 Pedro Alves <palves@redhat.com>
4729
4730 * NEWS (New commands): Mention "with" and "maint with".
4731 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4732 (with_command, with_command_completer): New.
4733 (pipe_command): Adjust to new repeat_previous
4734 interface.
4735 (_initialize_cli_cmds): Install the "with" command and its "w"
4736 alias.
4737 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4738 declarations.
4739 * cli/cli-setshow.c (parse_cli_var_uinteger)
4740 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4741 argument strings for all var_types.
4742 (get_setshow_command_value_string): New, factored out from ...
4743 (do_show_command): ... this.
4744 * cli/cli-setshow.h: Include <string>.
4745 (get_setshow_command_value_string): Declare.
4746 * command.h (repeat_previous): Now returns const char *. Adjust
4747 comment.
4748 * maint.c: Include "cli/cli-cmds.h".
4749 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4750 (_initialize_maint_cmds): Register the "maintenance with" command.
4751 * top.c (repeat_previous): Move bits from pipe_command here:
4752 Return the saved command line, if any; error out if there's no
4753 command to relaunch.
4754
c6ac8931
PA
47552019-07-03 Pedro Alves <palves@redhat.com>
4756
4757 * NEWS (New commands): Mention "maint set/show test-settings"
4758 instead of "maint test-settings".
4759 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4760 (maintenance_test_settings_set_list): Rename to ...
4761 (maintenance_set_test_settings_list): ... this.
4762 (maintenance_test_settings_show_list): Rename to ...
4763 (maintenance_show_test_settings_list): ... this.
4764 (maintenance_test_settings_cmd): Delete.
4765 (maintenance_test_settings_set_cmd): ...
4766 (maintenance_set_test_settings_cmd): ... this.
4767 (maintenance_test_settings_show_cmd): ...
4768 (maintenance_show_test_settings_cmd): ... this.
4769 (maintenance_test_settings_show_value_cmd):
4770 (maintenance_show_test_settings_value_cmd): ... this.
4771 (_initialize_maint_test_settings): No longer install the "maint
4772 test-settings" prefix command. Rename "maint test-settings set"
4773 to "maint set test-settings", and "maint test-settings show" to
4774 "maint show test-settings". Adjust all subcommands.
4775
d1fcf2fd
PA
47762019-07-03 Pedro Alves <palves@redhat.com>
4777
4778 * maint-test-settings.c: Fix file's intro comment. Replace all
4779 references to "test-options" with references to "test-settings",
4780 in comments.
4781
970f9d09
PA
47822019-07-03 Pedro Alves <palves@redhat.com>
4783
4784 * maint-test-settings.c (maintenance_test_settings_xxx)
4785 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4786 New.
4787 (maintenance_test_settings_enums): Use them.
4788 (maintenance_test_settings_enum): Default to
4789 maintenance_test_settings_xxx.
4790 (_initialize_maint_test_settings): Initialize
4791 MAINTENANCE_TEST_SETTINGS_FILENAME.
4792
f3869b1a
SM
47932019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4794
4795 * breakpoint.h (remove_breakpoints_inf): Change return type to
4796 void, move function documentation here.
4797 * breakpoint.c (remove_breakpoints_inf): Change return type to
4798 void, move function documentation to header.
4799
54d66006
PA
48002019-07-02 Pedro Alves <palves@redhat.com>
4801
4802 * NEWS (Completion improvements): Mention "info threads".
4803 * thread.c (struct info_threads_opts, info_threads_option_defs)
4804 (make_info_threads_options_def_group): New.
4805 (info_threads_command): Use gdb::option::process_options.
4806 (info_threads_command_completer): New.
4807 (_initialize_thread): Use gdb::option::build_help to build the
4808 help text for "info threads".
4809
854f6088
SM
48102019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4811
4812 * defs.h (generic_load): Move from here...
4813 * symfile.h (generic_load): ... to here. Rename name parameter
4814 to args.
4815 * symfile.c (generic_load): Add comment.
4816
54ee4252
TT
48172019-07-01 Tom Tromey <tromey@adacore.com>
4818
4819 * dwarf2read.c
4820 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4821 declaration of without_params. Fix formatting.
4822
65392b3e
TT
48232019-07-01 Tom Tromey <tromey@adacore.com>
4824
4825 * ada-exp.y (find_primitive_type): Update.
4826 * ada-lang.h (ada_lookup_symbol): Update.
4827 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4828 parameter.
4829 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4830
7d7571f0
SDJ
48312019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4832
4833 PR breakpoints/24541
4834 * gdbarch.c: Regenerate.
4835 * gdbarch.h: Regenerate.
4836 * gdbarch.sh: Add 'stap_adjust_register'.
4837 * i386-tdep.c: Include '<unordered_set>'.
4838 (i386_stap_adjust_register): New function.
4839 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4840 * stap-probe.c (stap_parse_register_operand): Call
4841 'gdbarch_stap_adjust_register'.
4842
5af5392a
SDJ
48432019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4844
4845 PR python/24742
4846 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4847 * python/python.c (do_start_initialization): Use 'xmalloc'
4848 instead of 'PyMem_Malloc'.
4849
10d06d82
TT
48502019-06-28 Tom Tromey <tromey@adacore.com>
4851
4852 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4853 for Ada.
4854
1b7f24cd
TT
48552019-06-27 Tom Tromey <tromey@adacore.com>
4856
4857 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4858 objfile_key.
4859 (arm_find_mapping_symbol, arm_record_special_symbol)
4860 (_initialize_arm_tdep): Update.
4861 (arm_objfile_data_free): Remove.
4862
3d507ff2
TT
48632019-06-27 Tom Tromey <tromey@adacore.com>
4864
4865 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4866 to cp_print_static_field.
4867
762c164d
TT
48682019-06-26 Tom Tromey <tromey@adacore.com>
4869
4870 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4871 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4872 declare.
4873
aa2f9bcf
AH
48742019-06-26 Alan Hayward <alan.hayward@arm.com>
4875
4876 * features/aarch64-core.c (create_feature_aarch64_core):
4877 Regenerate.
4878 * features/aarch64-core.xml: Add cpsr flags.
4879
3426ae57
AH
48802019-06-26 Alan Hayward <alan.hayward@arm.com>
4881
4882 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4883 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4884
4838e44c
SM
48852019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4886
4887 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4888 field.
4889 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4890 use.
4891 (arm_record_special_symbol): Don't insert new symbol in sorted
4892 position, push it at the end.
4893
54cc7474
SM
48942019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4895
4896 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4897 (arm_mapping_symbol_s): Remove.
4898 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4899 (arm_mapping_symbol_vec): New typedef.
4900 (struct arm_per_objfile): Add constructor.
4901 <section_maps>: Change type to
4902 std::unique_ptr<arm_mapping_symbol_vec[]>.
4903 (arm_compare_mapping_symbols): Remove.
4904 (arm_find_mapping_symbol): Adjust to section_maps type change.
4905 (arm_objfile_data_free): Call delete on arm_per_objfile.
4906 (arm_record_special_symbol): Adjust to section_maps type change.
4907 Allocate arm_per_objfile with new.
4908
b65b566c
PW
49092019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4910
4911 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4912 with the command prefix.
4913
c2fc64f5
TT
49142019-06-25 Tom Tromey <tom@tromey.com>
4915
4916 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4917 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4918
fb54fa76
TT
49192019-06-25 Tom Tromey <tom@tromey.com>
4920
4921 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4922 type.
4923 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4924 protected.
4925
f7952c57
TT
49262019-06-25 Tom Tromey <tom@tromey.com>
4927
4928 * tui/tui-winsource.c
4929 (tui_source_window_base::set_is_exec_point_at): Add check against
4930 LOA_ADDRESS.
4931
17568d78
TT
49322019-06-25 Tom Tromey <tom@tromey.com>
4933
4934 * tui/tui-source.c (tui_set_source_content): Don't check before
4935 xfree.
4936 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4937
53e7cdba
TT
49382019-06-25 Tom Tromey <tom@tromey.com>
4939
4940 * tui/tui-winsource.h (tui_update_source_window_as_is)
4941 (tui_alloc_source_buffer, tui_line_is_displayed)
4942 (tui_addr_is_displayed): Change type of win_info.
4943 * tui/tui-winsource.c (tui_update_source_window_as_is)
4944 (tui_clear_source_content, tui_show_source_line)
4945 (tui_show_source_content, tui_source_window_base::refill)
4946 (tui_source_window_base::set_is_exec_point_at)
4947 (tui_source_window_base::set_is_exec_point_at)
4948 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4949 (tui_alloc_source_buffer, tui_line_is_displayed)
4950 (tui_addr_is_displayed): Change type of win_info. Update.
4951 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4952 (tui_source_window_base::do_make_visible_with_new_height):
4953 Update.
4954 * tui/tui-source.c (tui_set_source_content)
4955 (tui_set_source_content_nil)
4956 (tui_source_window::do_scroll_vertical): Update.
4957 * tui/tui-layout.c (show_layout): Update.
4958 * tui/tui-disasm.c (tui_set_disassem_content)
4959 (tui_disasm_window::do_scroll_vertical): Update.
4960 * tui/tui-data.h (tui_win_content): Remove.
4961 (struct tui_gen_win_info) <content, content_size>: Remove.
4962 (struct tui_source_element): Add initializers and destructor.
4963 (union tui_which_element, struct tui_win_element): Remove.
4964 (struct tui_source_window_base) <content>: New field.
4965 (struct tui_data_window): Remove destructor.
4966 (tui_alloc_content, tui_free_win_content)
4967 (tui_free_all_source_wins_content): Don't declare.
4968 * tui/tui-data.c (tui_initialize_static_data): Update.
4969 (init_content_element, tui_alloc_content): Remove.
4970 (~tui_gen_win_info): Update.
4971 (~tui_data_window, tui_free_all_source_wins_content)
4972 (tui_free_win_content, free_content, free_content_elements):
4973 Remove.
4974
7908abbf
TT
49752019-06-25 Tom Tromey <tom@tromey.com>
4976
4977 * tui/tui-winsource.h (tui_clear_source_content)
4978 (tui_erase_source_content, tui_show_source_content): Change type
4979 of win_info.
4980 * tui/tui-winsource.c (tui_clear_source_content)
4981 (tui_erase_source_content, tui_show_source_content): Change type
4982 of win_info.
4983 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4984 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4985 win_info.
4986 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4987 win_info.
4988 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4989
02c28df0
TT
49902019-06-25 Tom Tromey <tom@tromey.com>
4991
4992 * tui/tui-winsource.c (tui_clear_source_content)
4993 (tui_source_window_base::set_is_exec_point_at): Update.
4994 * tui/tui-source.c (tui_set_source_content_nil): Update.
4995 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4996 a bool.
4997 * tui/tui-data.c (init_content_element): Update.
4998
6658b1bf
TT
49992019-06-25 Tom Tromey <tom@tromey.com>
5000
5001 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5002 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5003 * tui/tui-layout.c (init_and_make_win): Update.
5004 * tui/tui.h (enum tui_win_type): Update.
5005 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5006 tui_win_is_auxillary.
5007 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5008 tui_win_is_auxillary.
5009
21e1c91e
TT
50102019-06-25 Tom Tromey <tom@tromey.com>
5011
5012 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5013 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5014 (tui_delete_data_content_windows, tui_display_all_data)
5015 (tui_data_window::do_scroll_vertical, tui_display_data_from):
5016 Update.
5017 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5018 * tui/tui-regs.c (tui_last_regs_line_no)
5019 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5020 (tui_show_registers): Update.
5021 (tui_show_register_group): Return void. Update.
5022 (tui_display_registers_from, tui_display_reg_element_at_line)
5023 (tui_display_registers_from_line, tui_check_register_values):
5024 Update.
5025 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5026 member.
5027 (struct tui_data_window) <regs_content>: Now a std::vector.
5028 <regs_content_count>: Remove.
5029 (tui_add_content_elements, tui_free_data_content): Don't declare.
5030 * tui/tui-data.c (tui_data_window::clear_detail): Update.
5031 (init_content_element): Remove DATA_WIN case. Add assert.
5032 (tui_add_content_elements): Remove.
5033 (tui_data_window): Update.
5034 (tui_free_data_content): Remove.
5035 (free_content_elements): Remove DATA_WIN case.
5036
115ac53b
TT
50372019-06-25 Tom Tromey <tom@tromey.com>
5038
5039 * tui/tui-data.c (tui_data_item_window): Update.
5040 * tui/tui-windata.h (tui_check_data_values): Don't declare.
5041 * tui/tui-windata.c (tui_display_all_data)
5042 (tui_display_data_from_line): Update.
5043 (tui_check_data_values): Remove.
5044 * tui/tui-regs.c (tui_show_register_group)
5045 (tui_display_reg_element_at_line): Update.
5046 * tui/tui-hooks.c (tui_register_changed)
5047 (tui_refresh_frame_and_register_information): Call
5048 tui_check_register_values.
5049 * tui/tui-data.h (struct tui_data_window) <data_content,
5050 data_content_count, data_type>: Remove.
5051 (enum tui_data_type): Remove.
5052
5053 * tui/tui-data.c (tui_data_window::clear_detail)
5054 (~tui_data_window): Update.
5055
eaf9738b
TT
50562019-06-25 Tom Tromey <tom@tromey.com>
5057
5058 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5059 declare.
5060 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5061 Rename from tui_first_data_item_displayed. Update.
5062 (tui_data_window::refresh_all)
5063 (tui_data_window::do_scroll_vertical): Update.
5064 * tui/tui-data.h (struct tui_data_window)
5065 <first_data_item_displayed>: Declare new method.
5066
31ca4723
TT
50672019-06-25 Tom Tromey <tom@tromey.com>
5068
5069 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5070 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5071 contents...
5072 (tui_initialize_static_data): ...here.
5073
41bcff7f
TT
50742019-06-25 Tom Tromey <tom@tromey.com>
5075
5076 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5077 (tui_display_registers_from, tui_check_register_values): Update.
5078 (tui_display_register): Remove win_info parameter; update.
5079 (tui_get_register): Change type of parameters.
5080 * tui/tui-data.h (struct tui_data_element): Remove.
5081 (union tui_which_element) <data>: Remove.
5082 <data_window>: Change type.
5083 (struct tui_data_item_window): New.
5084 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5085 case. Add assert.
5086 (~tui_data_item_window): New destructor.
5087 (free_content_elements): Remove DATA_ITEM_WIN case.
5088
d2802c33
TT
50892019-06-25 Tom Tromey <tom@tromey.com>
5090
5091 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5092 Remove.
5093
dd835f8b
TT
50942019-06-25 Tom Tromey <tom@tromey.com>
5095
5096 * tui/tui-data.h (struct tui_command_element): Remove.
5097 (union tui_which_element) <command>: Remove.
5098 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5099 assert.
5100 (free_content_elements): Remove CMD_WIN case.
5101
bd7db367
TT
51022019-06-25 Tom Tromey <tom@tromey.com>
5103
5104 * tui/tui-layout.c (tui_set_layout): Update.
5105 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5106 * tui/tui-data.c (layout_def): Update.
5107
3add462f
TT
51082019-06-25 Tom Tromey <tom@tromey.com>
5109
5110 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5111 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5112 (tui_source_window_base::set_new_height): Update.
5113 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5114 Update.
5115 (tui_set_locator_fullname, tui_set_locator_info)
5116 (tui_show_frame_info): Update.
5117 * tui/tui-source.c (tui_set_source_content)
5118 (tui_source_is_displayed): Update.
5119 * tui/tui-layout.c (show_source_disasm_command, show_data)
5120 (show_source_or_disasm_and_command): Update.
5121 * tui/tui-disasm.c (tui_set_disassem_content)
5122 (tui_get_begin_asm_address): Update.
5123 * tui/tui-data.h (struct tui_locator_element): Remove.
5124 (union tui_which_element) <locator>: Remove.
5125 (struct tui_locator_window): New.
5126 (tui_locator_win_info_ptr): Change return type.
5127 * tui/tui-data.c (_locator): Change type.
5128 (tui_locator_win_info_ptr): Change return type.
5129 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5130 (tui_alloc_content): Add assert.
5131
489e9d8b
TT
51322019-06-25 Tom Tromey <tom@tromey.com>
5133
5134 * tui/tui-winsource.c
5135 (tui_exec_info_window::maybe_allocate_content): New method.
5136 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5137 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5138 (make_source_or_disasm_window): Add cast.
5139 * tui/tui-data.h (union tui_which_element) <simple_string>:
5140 Remove.
5141 (struct tui_source_info): New.
5142 (struct tui_source_window_base) <execution_info>: Change type.
5143 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5144 case, and add assert.
5145 (tui_alloc_content): Add assert.
5146
c3fabb7d
TT
51472019-06-25 Tom Tromey <tom@tromey.com>
5148
5149 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5150 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5151 * tui/tui-data.c (tui_alloc_win_info): Remove.
5152
bbc228ee
TT
51532019-06-25 Tom Tromey <tom@tromey.com>
5154
5155 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5156 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5157 can_highlight.
5158
5fcee43a
TT
51592019-06-25 Tom Tromey <tom@tromey.com>
5160
5161 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5162 make_visible_with_new_height method.
5163 (tui_win_info::make_visible_with_new_height): New method.
5164 (tui_source_window_base::do_make_visible_with_new_height)
5165 (tui_data_window::do_make_visible_with_new_height)
5166 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5167 (make_visible_with_new_height): Remove.
5168 (tui_resize_all, tui_adjust_win_heights): Use
5169 make_visible_with_new_height method.
5170 * tui/tui-data.h (struct tui_win_info)
5171 <do_make_visible_with_new_height, make_visible_with_new_height>:
5172 New methods.
5173 (struct tui_source_window_base, struct tui_data_window)
5174 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5175 methods.
5176
d83f1fe6
TT
51772019-06-25 Tom Tromey <tom@tromey.com>
5178
5179 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5180 method.
5181 (update_tab_width): Call update_tab_width method.
5182 * tui/tui-data.h (struct tui_win_info)
5183 (struct tui_source_window_base) <update_tab_width>: New methods.
5184
17374de4
TT
51852019-06-25 Tom Tromey <tom@tromey.com>
5186
5187 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5188 parameter.
5189 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5190 parameter.
5191 (tui_gen_win_info::make_visible): Update.
5192 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5193 parameter.
5194 * tui/tui-data.h (enum tui_box): New enum.
5195 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5196
f936bca2
TT
51972019-06-25 Tom Tromey <tom@tromey.com>
5198
5199 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5200 init_and_make_win for EXEC_INFO_WIN.
5201 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5202 longer inline.
5203 (struct tui_win_info) <~tui_win_info>: Inline.
5204 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5205 Don't declare.
5206 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5207 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5208 Remove.
5209 (tui_initialize_static_data): Update.
5210 (~tui_gen_win_info): Handle more cleanup here.
5211 (~tui_source_window_base): Delete "execution_info".
5212 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5213
d6ba6a11
TT
52142019-06-25 Tom Tromey <tom@tromey.com>
5215
5216 * tui/tui-layout.c (make_command_window): Don't set
5217 can_highlight.
5218 (show_source_disasm_command): Call the reset method.
5219 (show_data): Don't set can_highlight. Call the reset method.
5220 (tui_gen_win_info::reset): Rename from init_gen_win_info
5221 (init_and_make_win): Simplify. Return tui_gen_win_info.
5222 (show_source_or_disasm_and_command): Call the reset method.
5223 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5224 (struct tui_cmd_window): Set can_highlight.
5225
48a3bd16
TT
52262019-06-25 Tom Tromey <tom@tromey.com>
5227
5228 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5229 from make_visible.
5230 (tui_make_visible, tui_make_invisible): Rewrite.
5231 (tui_win_info::make_visible): Remove.
5232 (tui_source_window_base::make_visible): Update.
5233 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5234 method. Moved from...
5235 (struct tui_win_info) <make_visible>: ...here.
5236
c3bd716f
TT
52372019-06-25 Tom Tromey <tom@tromey.com>
5238
5239 * tui/tui-winsource.c
5240 (tui_source_window_base::do_scroll_horizontal): Remove direction
5241 parameter.
5242 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5243 direction parameter.
5244 * tui/tui-win.c (tui_win_info::forward_scroll)
5245 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5246 (tui_win_info::right_scroll): Update.
5247 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5248 direction parameter.
5249 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5250 direction parameter.
5251 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5252 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5253 Remove direction parameter.
5254 (struct tui_source_window_base, struct tui_source_window)
5255 (struct tui_disasm_window, struct tui_data_window)
5256 (struct tui_cmd_window): Update.
5257
21c32dca
TT
52582019-06-25 Tom Tromey <tom@tromey.com>
5259
5260 * tui/tui-winsource.h (tui_set_exec_info_content)
5261 (tui_show_exec_info_content, tui_erase_exec_info_content)
5262 (tui_clear_exec_info_content, tui_update_exec_info): Change
5263 argument to tui_source_window_base.
5264 * tui/tui-winsource.c (tui_set_exec_info_content)
5265 (tui_show_exec_info_content, tui_erase_exec_info_content)
5266 (tui_clear_exec_info_content, tui_update_exec_info): Change
5267 argument to tui_source_window_base.
5268
73fbdc65
TT
52692019-06-25 Tom Tromey <tom@tromey.com>
5270
5271 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5272 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5273
33325343
TT
52742019-06-25 Tom Tromey <tom@tromey.com>
5275
5276 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5277 check.
5278
29d2c474
TT
52792019-06-25 Tom Tromey <tom@tromey.com>
5280
5281 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5282 type to void.
5283 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5284 type to void.
5285 * tui/tui-source.c (tui_set_source_content): Update.
5286 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5287
152f3f4b
TT
52882019-06-25 Tom Tromey <tom@tromey.com>
5289
5290 * tui/tui-win.c (window_name_completer, tui_set_focus)
5291 (tui_all_windows_info): Use name method.
5292 * tui/tui-data.h (struct tui_gen_win_info)
5293 (struct tui_source_window, struct tui_disasm_window)
5294 (struct tui_data_window, struct tui_cmd_window) <name>: New
5295 method.
5296 (tui_win_name): Don't declare.
5297 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5298 (tui_win_name): Remove.
5299
be4da588
TT
53002019-06-25 Tom Tromey <tom@tromey.com>
5301
5302 * tui/tui-winsource.h (tui_update_source_window)
5303 (tui_update_source_window_as_is): Change parameter type.
5304 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5305 to be a tui_source_window_base.
5306 (tui_update_source_window_as_is): Likewise.
5307 * tui/tui-win.c (make_visible_with_new_height): Update.
5308
5b81daba
TT
53092019-06-25 Tom Tromey <tom@tromey.com>
5310
5311 * tui/tui-winsource.c (tui_erase_source_content)
5312 (tui_show_source_content, tui_show_exec_info_content)
5313 (tui_erase_exec_info_content): Use refresh_window method.
5314 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5315 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5316 from tui_refresh_win.
5317 (tui_data_window::refresh_window): New method.
5318 (tui_win_info::refresh, tui_source_window_base::refresh)
5319 (tui_refresh_all): Use refresh_window method.
5320 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5321 method.
5322 * tui/tui-regs.c (tui_display_register): Call refresh_window
5323 method.
5324 * tui/tui-layout.c (show_source_disasm_command)
5325 (show_source_or_disasm_and_command): Call refresh_window method.
5326 * tui/tui-data.h (struct tui_gen_win_info)
5327 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5328 New method.
5329
cb2ce893
TT
53302019-06-25 Tom Tromey <tom@tromey.com>
5331
5332 * tui/tui.c (tui_rl_other_window, tui_enable)
5333 (tui_is_window_visible, tui_get_command_dimension): Update.
5334 * tui/tui-winsource.c (tui_update_source_window_as_is)
5335 (tui_clear_source_content, tui_erase_source_content)
5336 (tui_show_source_line, tui_source_window_base::refill)
5337 (tui_source_window_base::do_scroll_horizontal)
5338 (tui_source_window_base::set_is_exec_point_at)
5339 (tui_update_breakpoint_info, tui_set_exec_info_content)
5340 (tui_alloc_source_buffer, tui_line_is_displayed)
5341 (tui_addr_is_displayed): Update.
5342 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5343 (tui_check_and_display_highlight_if_needed)
5344 (tui_win_info::make_visible, tui_win_info::refresh)
5345 (tui_refresh_all): Update.
5346 * tui/tui-windata.c (tui_first_data_item_displayed)
5347 (tui_delete_data_content_windows, tui_erase_data_content)
5348 (tui_display_all_data, tui_data_window::refresh_all)
5349 (tui_check_data_values): Update.
5350 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5351 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5352 (tui_win_info::backward_scroll, tui_refresh_all_win)
5353 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5354 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5355 (tui_source_window_base::set_new_height)
5356 (tui_data_window::set_new_height)
5357 (make_invisible_and_set_new_height)
5358 (make_visible_with_new_height, new_height_ok)
5359 (parse_scrolling_args): Update.
5360 * tui/tui-stack.c (tui_show_frame_info): Update.
5361 * tui/tui-source.c (tui_set_source_content)
5362 (tui_set_source_content_nil, tui_source_is_displayed)
5363 (tui_source_window::do_scroll_vertical): Update.
5364 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5365 (tui_display_registers_from, tui_display_reg_element_at_line)
5366 (tui_check_register_values, tui_reg_command): Update.
5367 * tui/tui-layout.c (tui_default_win_height)
5368 (show_source_disasm_command, show_data, init_and_make_win)
5369 (show_source_or_disasm_and_command): Update.
5370 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5371 (tui_redisplay_readline, tui_mld_flush)
5372 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5373 (tui_getc): Update.
5374 * tui/tui-disasm.c (tui_set_disassem_content)
5375 (tui_disasm_window::do_scroll_vertical): Update.
5376 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5377 Now virtual.
5378 (struct tui_win_info): Derive from tui_gen_win_info.
5379 <~tui_win_info>: Mark as override.
5380 <generic>: Remove member.
5381 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5382 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5383 (~tui_data_window, ~tui_win_info)
5384 (tui_free_all_source_wins_content): Update.
5385 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5386
ab313b35
TT
53872019-06-25 Tom Tromey <tom@tromey.com>
5388
5389 * tui/tui-layout.c (init_and_make_win): Use new.
5390 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5391 destructor, initializers.
5392 (tui_alloc_generic_win_info): Don't declare.
5393 * tui/tui-data.c (_locator): Add argument to constructor.
5394 (source_win, disasm_win): New globals.
5395 (exec_info): Remove.
5396 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5397 Update.
5398 (tui_alloc_generic_win_info): Remove.
5399 (init_content_element): Use new.
5400 (tui_win_info::tui_win_info): Update.
5401 (free_content_elements) <case DATA_WIN>: Use delete.
5402
dc2c33e4
TT
54032019-06-25 Tom Tromey <tom@tromey.com>
5404
5405 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5406 * tui/tui-windata.c (tui_first_data_item_displayed)
5407 (tui_delete_data_content_windows): Update.
5408 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5409 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5410 (tui_display_registers_from, tui_check_register_values): Update.
5411 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5412 pointer.
5413 * tui/tui-data.c (init_content_element): Update. Allocate the new
5414 window.
5415 (tui_free_data_content): Update.
5416 (free_content_elements) <case DATA_WIN>: Free the window.
5417
214a5cbe
TT
54182019-06-25 Tom Tromey <tom@tromey.com>
5419
5420 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5421 Update.
5422 * tui/tui-layout.c (make_command_window)
5423 (show_source_disasm_command, show_data, init_and_make_win)
5424 (show_source_or_disasm_and_command): Update.
5425 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5426 method.
5427 <can_highight, is_highlighted>: Now bool.
5428 (tui_set_win_highlight): Don't declare.
5429 * tui/tui-data.c (tui_set_win_highlight): Remove.
5430
8e2daf15
TT
54312019-06-25 Tom Tromey <tom@tromey.com>
5432
5433 * tui/tui-wingeneral.c (make_visible): Remove check of window
5434 type.
5435
8903bd8a
TT
54362019-06-25 Tom Tromey <tom@tromey.com>
5437
5438 * tui/tui-win.c (tui_win_info::max_height)
5439 (tui_cmd_window::max_height): New methods.
5440 (new_height_ok): Call max_height.
5441 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5442 <max_height>: New method.
5443
3f02ce1e
TT
54442019-06-25 Tom Tromey <tom@tromey.com>
5445
5446 * tui/tui-win.c (tui_source_window_base::set_new_height)
5447 (tui_data_window::set_new_height): New methods.
5448 (make_invisible_and_set_new_height): Call set_new_height method.
5449 * tui/tui-data.h (struct tui_win_info)
5450 (struct tui_source_window_base, struct tui_data_window)
5451 <set_new_height>: New method.
5452
1825f487
TT
54532019-06-25 Tom Tromey <tom@tromey.com>
5454
5455 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5456 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5457 tui_refresh_data_win.
5458 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5459 method.
5460 (tui_refresh_all_win): Call the refresh_all method.
5461 (tui_set_focus): Likewise.
5462 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5463 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5464 Likewise.
5465
ad54d15b
TT
54662019-06-25 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-winsource.h (tui_refill_source_window)
5469 (tui_set_is_exec_point_at): Don't declare.
5470 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5471 (tui_source_window_base::refill): Rename from
5472 tui_refill_source_window.
5473 (tui_source_window_base::do_scroll_horizontal): Update.
5474 (tui_source_window_base::set_is_exec_point_at): Rename from
5475 tui_set_is_exec_point_at.
5476 (tui_update_all_breakpoint_info): Update.
5477 * tui/tui-stack.c (tui_show_frame_info): Update.
5478 * tui/tui-layout.c (show_data): Add cast.
5479 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5480 * tui/tui-data.h (struct tui_source_window_base) <refill,
5481 set_is_exec_point_at>: New methods.
5482 (tui_source_windows, tui_add_to_source_windows): Update types.
5483 (tui_add_to_source_windows): Remove redundant declaration.
5484 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5485 (tui_source_windows): Change return type.
5486 (tui_clear_source_windows_detail): Update.
5487 (tui_add_to_source_windows): Change type of parameter.
5488 (tui_free_all_source_wins_content): Update.
5489
2042b506
TT
54902019-06-25 Tom Tromey <tom@tromey.com>
5491
5492 * tui/tui-wingeneral.c (tui_win_info::refresh)
5493 (tui_source_window_base::refresh): New methods.
5494 (tui_refresh_all): Call the refresh method.
5495 * tui/tui-data.h (struct tui_win_info)
5496 (struct tui_source_window_base) <refresh>: New method.
5497
56122977
TT
54982019-06-25 Tom Tromey <tom@tromey.com>
5499
5500 * tui/tui.h (tui_is_window_visible): Return bool.
5501 * tui/tui.c (tui_is_window_visible): Return bool.
5502 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5503 (tui_make_visible, tui_make_invisible)
5504 (tui_win_info::make_visible)
5505 (tui_source_window_base::make_visible, make_all_visible)
5506 (tui_make_all_visible, tui_make_all_invisible): Update.
5507 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5508 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5509 bool.
5510 (struct tui_win_info, struct tui_source_window_base)
5511 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5512 * tui/tui-data.c (tui_init_generic_part): Update.
5513
cda37efb
TT
55142019-06-25 Tom Tromey <tom@tromey.com>
5515
5516 * tui/tui-wingeneral.c (tui_win_info::make_visible)
5517 (tui_source_window_base::make_visible): New methods.
5518 (make_all_visible): Make method call.
5519 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5520 (struct tui_source_window_base, struct tui_cmd_window): Override
5521 make_visible.
5522 (tui_win_is_source_type): Don't declare.
5523 * tui/tui-data.c (tui_win_is_source_type): Remove.
5524
6a0ee02c
TT
55252019-06-25 Tom Tromey <tom@tromey.com>
5526
5527 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5528 NULL check.
5529
63901aec
TT
55302019-06-25 Tom Tromey <tom@tromey.com>
5531
5532 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5533 Inline constructor. Add initializers for members.
5534 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5535 constructors; now inline in class.
5536
ceb13a13
TT
55372019-06-25 Tom Tromey <tom@tromey.com>
5538
5539 * tui/tui-regs.c (tui_show_registers): Update.
5540 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5541 bool.
5542 * tui/tui-data.c (tui_data_window::clear_detail)
5543 (tui_data_window): Update.
5544
238eb706
TT
55452019-06-25 Tom Tromey <tom@tromey.com>
5546
5547 * tui/tui-windata.c (tui_display_all_data)
5548 (tui_display_data_from_line, tui_display_data_from)
5549 (tui_check_data_values, tui_data_window::do_scroll_vertical):
5550 Update.
5551 * tui/tui-regs.c (tui_last_regs_line_no)
5552 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5553 (tui_show_registers, tui_show_register_group)
5554 (tui_display_registers_from, tui_display_reg_element_at_line)
5555 (tui_display_registers_from_line, tui_check_register_values)
5556 (tui_reg_next, tui_reg_prev): Update.
5557 * tui/tui-layout.c (tui_set_layout, show_data): Update.
5558 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
5559 tui_data_window.
5560 (struct tui_win_info) <detail>: Remove. Add new fields from
5561 tui_data_info.
5562 (TUI_DATA_WIN): Add cast.
5563 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5564 (~tui_data_window): Simplify.
5565
81491aa0
TT
55662019-06-25 Tom Tromey <tom@tromey.com>
5567
5568 * tui/tui-layout.c (show_source_disasm_command)
5569 (show_source_or_disasm_and_command): Update.
5570 * tui/tui-io.c (update_cmdwin_start_line)
5571 (tui_redisplay_readline): Update.
5572 * tui/tui-data.h (struct tui_command_info): Remove.
5573 (struct tui_win_info) <detail>: Remove command_info member.
5574 (struct tui_data_window) <start_line>: New member, from
5575 tui_command_info.
5576 (TUI_CMD_WIN): Add casts.
5577
e6e41501
TT
55782019-06-25 Tom Tromey <tom@tromey.com>
5579
5580 * tui/tui-winsource.c (tui_update_source_window)
5581 (tui_refill_source_window)
5582 (tui_source_window_base::do_scroll_horizontal)
5583 (tui_update_breakpoint_info, tui_set_exec_info_content)
5584 (tui_show_exec_info_content, tui_erase_exec_info_content)
5585 (tui_clear_exec_info_content): Update.
5586 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5587 Update.
5588 * tui/tui-win.c (make_invisible_and_set_new_height)
5589 (make_visible_with_new_height): Update.
5590 * tui/tui-source.c (tui_set_source_content)
5591 (tui_show_symtab_source): Update.
5592 * tui/tui-layout.c (extract_display_start_addr)
5593 (show_source_disasm_command, show_data)
5594 (make_source_or_disasm_window)
5595 (show_source_or_disasm_and_command): Update.
5596 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5597 (tui_disasm_window::do_scroll_vertical): Remove shadowing
5598 "gdbarch".
5599 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
5600 to tui_source_window_base.
5601 (struct tui_win_info) <detail>: Remove source_info member.
5602 (struct tui_source_window_base) <has_locator>: Inline.
5603 Move contents from tui_source_info; rename has_locator member to
5604 m_has_locator.
5605 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5606 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5607 header file.
5608 (tui_source_window_base::clear_detail, ~tui_source_window_base):
5609 Simplify.
5610 (tui_free_all_source_wins_content): Cast to
5611 tui_source_window_base.
5612
44f0e208
TT
56132019-06-25 Tom Tromey <tom@tromey.com>
5614
5615 * tui/tui-win.c (make_invisible_and_set_new_height)
5616 (make_visible_with_new_height): Call has_locator method.
5617 * tui/tui-layout.c (show_source_disasm_command, show_data)
5618 (show_source_or_disasm_and_command): Update for bool change.
5619 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5620 (tui_win_info) <has_locator>: New method.
5621 (struct tui_source_window_base) <has_locator>: New method.
5622 (tui_win_has_locator): Don't declare.
5623 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5624 from tui_win_has_locator.
5625 (tui_source_window_base): Use false, not FALSE.
5626
7778b912
TT
56272019-06-25 Tom Tromey <tom@tromey.com>
5628
5629 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5630 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5631 clear_detail method directly.
5632 (tui_clear_win_detail): Remove.
5633
f83d391c
TT
56342019-06-25 Tom Tromey <tom@tromey.com>
5635
5636 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5637 "this", not TUI_DISASM_WIN.
5638
13446e05
TT
56392019-06-25 Tom Tromey <tom@tromey.com>
5640
5641 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
5642 declare.
5643 * tui/tui-winsource.c
5644 (tui_source_window_base::do_scroll_horizontal): Rename from
5645 tui_horizontal_source_scroll.
5646 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5647 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5648 from tui_vertical_data_scroll.
5649 * tui/tui-win.h (tui_scroll): Don't declare.
5650 * tui/tui-win.c (tui_win_info::forward_scroll)
5651 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5652 (tui_win_info::right_scroll): Rename and update.
5653 (tui_scroll_forward_command, tui_scroll_backward_command)
5654 (tui_scroll_left_command, tui_scroll_right_command): Update.
5655 (tui_scroll): Remove.
5656 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5657 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5658 from tui_vertical_source_scroll.
5659 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5660 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5661 from tui_vertical_disassem_scroll.
5662 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5663 do_scroll_horizontal>: New methods.
5664 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5665 Likewise.
5666 (struct tui_source_window_base): Add do_scroll_horizontal.
5667 (struct tui_source_window, struct tui_disasm_window): Add
5668 do_scroll_vertical.
5669 (struct tui_data_window, struct tui_cmd_window): Add
5670 do_scroll_horizontal and do_scroll_vertical.
5671 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5672
5cf82909
TT
56732019-06-25 Tom Tromey <tom@tromey.com>
5674
5675 * tui/tui-data.h (struct tui_source_window_base): New struct.
5676 (struct tui_source_window): Derive from tui_source_window_base.
5677 (struct tui_disasm_window): New struct.
5678 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5679 from tui_source_window::clear_detail.
5680 (tui_source_window_base): Rename from tui_source_window.
5681 (~tui_source_window_base): Rename from ~tui_source_window.
5682 (tui_alloc_win_info): Create a tui_disasm_window.
5683
ee1d42d6
TT
56842019-06-25 Tom Tromey <tom@tromey.com>
5685
5686 * tui/tui-data.h (struct tui_source_window)
5687 (struct tui_data_window): Declare destructors.
5688 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5689 destructors.
5690 (tui_win_info): Simplify.
5691
b4eb2452
TT
56922019-06-25 Tom Tromey <tom@tromey.com>
5693
5694 * tui/tui-winsource.c (tui_display_main)
5695 (tui_update_source_windows_with_addr)
5696 (tui_update_all_breakpoint_info): Update.
5697 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5698 (new_height_ok, parse_scrolling_args): Update.
5699 * tui/tui-stack.c (tui_show_frame_info): Update.
5700 * tui/tui-data.h (struct tui_list): Remove.
5701 (tui_source_windows): Return a reference to a std::vector.
5702 * tui/tui-data.c (source_windows): Now a std::vector.
5703 (tui_source_windows): Change return type.
5704 (tui_clear_source_windows): Rewrite.
5705 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5706 (tui_free_all_source_wins_content): Rewrite.
5707
8761a91b
TT
57082019-06-25 Tom Tromey <tom@tromey.com>
5709
5710 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5711 (struct tui_data_window, struct tui_cmd_window): Declare
5712 clear_detail method.
5713 * tui/tui-data.c (tui_source_window::clear_detail)
5714 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5715 methods.
5716 (tui_clear_win_detail): Simplify.
5717
0ed69eda
TT
57182019-06-25 Tom Tromey <tom@tromey.com>
5719
5720 * tui/tui-layout.c (make_source_window, make_disasm_window)
5721 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5722 Return the new window.
5723 (show_source_disasm_command, show_data)
5724 (show_source_or_disasm_and_command): Update.
5725
82432e10
TT
57262019-06-25 Tom Tromey <tom@tromey.com>
5727
5728 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5729 parameter. Return the new window.
5730 (show_source_disasm_command): Update and remove NULL check.
5731 (show_source_or_disasm_and_command): Update.
5732
ec328aa5
TT
57332019-06-25 Tom Tromey <tom@tromey.com>
5734
5735 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5736
33b906ab
TT
57372019-06-25 Tom Tromey <tom@tromey.com>
5738
5739 * tui/tui-data.h (struct tui_win_info): Make constructor
5740 protected. Make destructor virtual. Add initializers.
5741 (tui_source_window, tui_data_window, tui_cmd_window): New
5742 classes.
5743 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5744 constructor. Add "type" parameter.
5745 (tui_source_window, tui_data_window, tui_cmd_window): New
5746 constructors.
5747 (tui_alloc_win_info): Instantiate the appropriate subclass.
5748
e7e11af4
TT
57492019-06-25 Tom Tromey <tom@tromey.com>
5750
5751 * tui/tui-win.c (tui_resize_all): Use delete.
5752 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5753 destructor.
5754 (tui_free_window): Don't declare.
5755 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5756 Update.
5757
6792b55e
TT
57582019-06-25 Tom Tromey <tom@tromey.com>
5759
5760 * tui/tui-data.h (struct tui_win_info): Add constructor.
5761 * tui/tui-data.c (tui_alloc_win_info): Use new.
5762 (tui_free_window): Use delete.
5763
f95675e1
TT
57642019-06-22 Tom Tromey <tom@tromey.com>
5765
5766 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5767 declare.
5768 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5769
5bff081c
TT
57702019-06-22 Tom Tromey <tom@tromey.com>
5771
5772 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5773 declare.
5774 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5775
47e3f474
TV
57762019-06-22 Tom de Vries <tdevries@suse.de>
5777
5778 * dwarf2read.c (create_addrmap_from_aranges)
5779 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5780 instead of '%zu'.
5781
fd5866f6
SM
57822019-06-21 Simon Marchi <simon.marchi@efficios.com>
5783
5784 * dwarf2read.h (dwarf2_section_info_def): Remove.
5785 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5786 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5787 std::vector<dwarf2_section_info>.
5788 (struct dwo_file) <~dwo_file>: Remove.
5789 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5790 types field.
5791 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5792 (dwarf2_read_debug_names): Likewise.
5793 (create_debug_types_hash_table): Change parameter type to
5794 array_view, adjust code accordingly.
5795 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5796 (partial_die_info::fixup): Likewise.
5797 (determine_prefix): Likewise.
5798 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5799
fb1eb2f9
SM
58002019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5801
5802 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5803 gdb_bfd_ref_ptr.
5804 <~dwo_file>: Remove call to gdb_bfd_unref.
5805 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5806 gdb_bfd_ref_ptr::get.
5807
51ac9db5
SM
58082019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5809
5810 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5811 type to htab_up.
5812 * dwarf2read.c (struct dwo_file): Initialize fields.
5813 <~dwo_file>: New.
5814 (free_dwo_file): Remove, move content to ~dwo_file.
5815 (struct dwo_file_deleter): Remove.
5816 (dwo_file_up>: Remove custom deleter.
5817 (free_dwo_files): Remove.
5818 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5819 dwo_files.
5820 (process_skeletonless_type_units): Call unique_ptr::get.
5821 (allocate_dwo_file_hash_table): Add deleter to created hash
5822 table. Change return type to htab_up.
5823 (lookup_dwo_file_slot): Don't memset dwo_file, call
5824 unique_ptr::get.
5825 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5826 (create_dwo_unit_in_dwp_v2): Likewise.
5827 (open_and_init_dwo_file): Likewise.
5828 (free_dwo_file_from_slot): Remove.
5829
dc4ccb6f
SM
58302019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5831
5832 * dwarf2read.h (struct dwarf2_section_info) <readin,
5833 is_virtual>: Change type to bool.
5834 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5835 true instead of 1.
5836
e6a1c5cb
TT
58372019-06-19 Tom Tromey <tom@tromey.com>
5838
5839 * tui/tui-data.h (tui_init_content_element): Don't declare.
5840
6f6ffbeb
TT
58412019-06-19 Tom Tromey <tom@tromey.com>
5842
5843 * tui/tui-data.h (tui_init_win_info): Don't declare.
5844
f23f598e
TV
58452019-06-19 Tom de Vries <tdevries@suse.de>
5846
5847 * dwarf2read.h (abstract_to_concrete): Change type to
5848 std::unordered_map<sect_offset, std::vector<sect_offset>,
5849 gdb::hash_enum<sect_offset>>.
5850
680e1bee
TT
58512019-06-19 Tom Tromey <tromey@adacore.com>
5852
5853 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5854 EVAL_AVOID_SIDE_EFFECTS specially.
5855
dcf37923
TT
58562019-06-19 Tom Tromey <tromey@adacore.com>
5857
5858 * source-cache.c (highlighter): New global.
5859 (source_cache::get_source_lines): Create a highlighter on demand.
5860
494986d5
AB
58612019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5862
5863 * defs.h (deprecated_interactive_hook): Delete declaration.
5864 * interps.c (clear_interpreter_hooks): Remove use of
5865 deprecated_interactive_hook.
5866 * top.c (deprecated_interactive_hook): Delete definition.
5867 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5868
3360b6e7
TV
58692019-06-18 Tom de Vries <tdevries@suse.de>
5870
5871 PR gdb/24515
5872 * dwarf2read.h (abstract_to_concrete): Change type from
5873 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5874 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5875 * dwarf2read.c (read_variable): Update.
5876 (dwarf2_fetch_die_loc_sect_off): Update.
5877
310b3441
TV
58782019-06-17 Tom de Vries <tdevries@suse.de>
5879
5880 PR gdb/24617
5881 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5882 accessing parent[parent_len - 1].
5883
ba9777be
PP
58842019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5885
5886 PR gdb/24364
5887 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5888 call dtrace_process_dof with NULL dof.
5889
2b9f6e89
TV
58902019-06-16 Tom de Vries <tdevries@suse.de>
5891
5892 PR gdb/24445
5893 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5894
431b3ead
TT
58952019-06-16 Tom Tromey <tom@tromey.com>
5896
5897 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5898 (make_all_visible): Use address of member.
5899
d04b44a1
TT
59002019-06-16 Tom Tromey <tom@tromey.com>
5901
5902 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5903 (tui_free_window, free_content, free_content_elements): Remove
5904 unnecessary cast.
5905 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5906 cast.
5907 * tui/tui-regs.c (tui_show_register_group)
5908 (tui_display_registers_from, tui_display_reg_element_at_line):
5909 Remove unnecessary cast.
5910
bf5142e7
AB
59112019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5912
5913 * linux-nat.c (normal_mask): Delete.
5914 (_initialize_linux_nat): Don't initialise normal_mask.
5915
c4973306
SM
59162019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5917
5918 PR gdb/24445
5919 * dwarf-index-write.h (write_psymtabs_to_index): Add
5920 dwz_basename parameter.
5921 * dwarf-index-write.c (write_gdbindex): Move file writing to
5922 write_gdbindex_1. Change return type void.
5923 (assert_file_size): Move up, remove filename parameter.
5924 (write_gdbindex_1): New function.
5925 (write_debug_names): Change return type to void, call
5926 assert_file_size.
5927 (struct index_wip_file): New struct.
5928 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5929 file logic to index_wip_file. Write index for dwz file if
5930 needed.
5931 (save_gdb_index_command): Pass basename of dwz file, if present.
5932 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5933 build-id of dwz file, if present.
5934 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5935 (dwarf2_get_dwz_file): Likewise.
5936 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5937 (dwarf2_get_dwz_file): Likewise.
5938
395f9c91
TT
59392019-06-16 Tom Tromey <tom@tromey.com>
5940
5941 * coffread.c (process_coff_symbol): Use xstrdup.
5942 * value.c (create_internalvar): Use xstrdup.
5943
cafb3438
TT
59442019-06-16 Tom Tromey <tom@tromey.com>
5945
5946 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5947 * breakpoint.c (stopin_command, stopat_command)
5948 (until_break_command, decode_location_default): Remove unnecessary
5949 cast.
5950 * utils.c (subset_compare): Remove unnecessary cast.
5951 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5952 cast.
5953 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5954 cast.
5955 * infcmd.c (path_command): Remove unnecessary cast.
5956 * coffread.c (decode_type): Remove unnecessary cast.
5957 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5958 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5959 * tui/tui-stack.c (tui_show_locator_content)
5960 (tui_show_frame_info): Remove unnecessary cast.
5961 * tui/tui-win.c (tui_scroll_forward_command)
5962 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5963 (parse_scrolling_args): Remove unnecessary cast.
5964 * tui/tui-data.c (init_win_info, tui_del_window)
5965 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5966 (free_content_elements): Remove unnecessary cast.
5967 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5968 unnecessary cast.
5969 * tui/tui-source.c (tui_set_source_content)
5970 (tui_vertical_source_scroll): Remove unnecessary cast.
5971 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5972 cast.
5973 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5974 * tui/tui-regs.c (tui_display_registers_from)
5975 (tui_display_register): Remove unnecessary cast.
5976 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5977 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5978 (make_visible): Remove unnecessary cast.
5979 * tui/tui-winsource.c (tui_erase_source_content)
5980 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5981 unnecessary cast.
5982 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5983 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5984 * stabsread.c (read_type, read_array_type, read_range_type):
5985 Remove unnecessary cast.
5986 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5987 (parse_symbol, parse_type, upgrade_type, parse_external)
5988 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5989 unnecessary cast.
5990 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5991
730ead81
TT
59922019-06-16 Tom Tromey <tom@tromey.com>
5993
5994 * tui/tui-data.c (tui_alloc_generic_win_info)
5995 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5996 checks.
5997
584a927c
AB
59982019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5999 Andrew Burgess <andrew.burgess@embecosm.com>
6000
6001 * f-typeprint.c (f_print_type): Don't return early for not
6002 associated or not allocated types.
6003 (f_type_print_varspec_suffix): Add print_rank parameter and print
6004 ranks of array types in case they dangling.
6005 (f_type_print_base): Add print_rank parameter.
6006
30056ea0
AB
60072019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6008
6009 * NEWS: Mention new MI commands.
6010 * break-catch-throw.c (enum exception_event_kind): Move to
6011 breakpoint.h.
6012 (print_mention_exception_catchpoint): Output text as a single
6013 message.
6014 (catch_exception_command_1): Rename to...
6015 (catch_exception_event): ...this, make non-static, update header
6016 command, and change some parameter types.
6017 (catch_catch_command): Update for changes to
6018 catch_exception_command_1.
6019 (catch_throw_command): Likewise.
6020 (catch_rethrow_command): Likewise.
6021 * breakpoint.c (enum exception_event_kind): Delete.
6022 * breakpoint.h (enum exception_event_kind): Moved here from
6023 break-catch-throw.c.
6024 (catch_exception_event): Declare.
6025 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6026 (mi_cmd_catch_throw): New function.
6027 (mi_cmd_catch_rethrow): New function.
6028 (mi_cmd_catch_catch): New function.
6029 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6030 'catch-catch' entries.
6031 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6032 (mi_cmd_catch_rethrow): Declare.
6033 (mi_cmd_catch_catch): Declare.
6034
ec8e2b6d
AB
60352019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6036
6037 * annotate.c (annotate_source_line): Change return type to void,
6038 update implementation to match.
6039 * annotate.h (annotate_source_line): Change return type to void,
6040 update header comment.
6041 * stack.c (print_frame_info): Don't change what frame information
6042 is printed based on whether annotations are on or not.
6043
0d3abd8c
AB
60442019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6045
6046 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6047 (annotate_source): Make static.
6048 (annotate_source_line): Moved from source.c and renamed from
6049 identify_source_line. Update the return type.
6050 * annotate.h (annotate_source): Delete declaration.
6051 (annotate_source_line): Declaration moved from source.h, and
6052 renamed from identify_source_line. Return type updated.
6053 * source.c (identify_source_line): Moved to annotate.c and renamed
6054 to annotate_source_line.
6055 (info_line_command): Remove check of annotation_level.
6056 * source.h (identify_source_line): Move declaration to annotate.h
6057 and rename to annotate_source_line.
6058 * stack.c: Add 'annotate.h' include.
6059 (print_frame_info): Remove check of annotation_level before
6060 calling annotate_source_line.
6061
00df30ae
AB
60622019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6063
6064 * source-cache.c (source_cache::get_plain_source_lines): Use
6065 open_source_file_with_line_charpos instead of just
6066 open_source_file, remove call to find_source_lines.
6067 (source_cache::get_source_lines): Likewise.
6068 * source.c (find_source_lines): Make static.
6069 (get_filename_and_charpos): Renamed into...
6070 (open_source_file_with_line_charpos): ..this along with changes to
6071 return a scoped_fd, and some other minor clean ups.
6072 (identify_source_line): Use open_source_file_with_line_charpos.
6073 (search_command_helper): Use open_source_file_with_line_charpos
6074 instead of just open_source_file, remove call to
6075 find_source_lines.
6076 * source.h (open_source_file_with_line_charpos): Declare new
6077 function.
6078 (find_source_lines): Delete declaration.
6079
afda45a2
AB
60802019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6081
6082 * source.c (get_filename_and_charpos): Remove fullname
6083 parameter.
6084 (identify_source_line): Update call to get_filename_and_charpos.
6085
0735b091
TT
60862019-06-14 Tom Tromey <tromey@adacore.com>
6087
6088 PR gdb/24502:
6089 * ui-style.h (skip_ansi_escape): Update comment.
6090 * ui-file.h (class no_terminal_escape_file): New class.
6091 * ui-file.c (no_terminal_escape_file::write)
6092 (no_terminal_escape_file::puts): New methods.
6093 * cli/cli-logging.c (handle_redirections): Use
6094 no_terminal_escape_file.
6095
52ce35e2
TT
60962019-06-14 Tom Tromey <tromey@adacore.com>
6097
6098 * NEWS: Move convenience variable news above Python news.
6099
73cc7272
TT
61002019-06-14 Tom Tromey <tom@tromey.com>
6101
6102 * gnulib: Move directory to top-level.
6103 * configure.ac: Don't configure gnulib.
6104 * configure: Rebuild.
6105 * common/common-defs.h: Use new path to gnulib.
6106 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6107 (GNULIB_H): Remove.
6108 (INCGNU): Look in new gnulib location.
6109 (HFILES_NO_SRCDIR): Remove gnulib files.
6110 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6111 (generated_files): Remove GNULIB_H.
6112 ($(LIBGNU), all-lib): Remove targets.
6113 (distclean): Don't mention GNULIB_BUILDDIR.
6114 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6115
f5686554
TT
61162019-06-14 Tom Tromey <tromey@adacore.com>
6117
6118 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6119 Warn if symbol file does not provide any symbols.
6120
a0c1ffed
TT
61212019-06-14 Tom Tromey <tromey@adacore.com>
6122
6123 * source.c (find_and_open_source): Respect basenames_may_differ.
6124
7c39e397
AB
61252019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6126
6127 * annotate.c (annotate_breakpoints_invalid): Make use of
6128 scoped_restore_terminal_state.
6129 (annotate_frames_invalid): Likewise.
6130
f411722c
TT
61312019-06-14 Tom Tromey <tromey@adacore.com>
6132
6133 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6134 allow assignment to an internalvar.
6135
4268ec18
TT
61362019-06-14 Tom Tromey <tromey@adacore.com>
6137
6138 * ada-lex.l: Allow "_" in attribute names.
6139
abdb711e
TT
61402019-06-14 Tom Tromey <tromey@adacore.com>
6141
6142 PR gdb/24653:
6143 * regcache.c (registers_changed): Don't call alloca.
6144 * top.c (execute_command): Don't call alloca.
6145
4c048731
PA
61462019-06-13 Pedro Alves <palves@redhat.com>
6147
6148 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6149 'expression'. When parsing an expression, error out if there's
6150 junk after "unlimited".
6151 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6152 (do_set_command): Adjust calls to is_unlimited_literal.
6153
66eb1ed3
PA
61542019-06-13 Pedro Alves <palves@redhat.com>
6155
6156 * compile/compile.c (make_compile_options_def_group): Add braces
6157 around array_view initializer.
6158 * thread.c (make_thread_apply_all_options_def_group)
6159 (make_thread_apply_all_options_def_group): Likewise.
6160
3345721a
PA
61612019-06-13 Pedro Alves <palves@redhat.com>
6162
6163 * NEWS (New commands): Mention "maint test-options
6164 require-delimiter", "maint test-options unknown-is-error", "maint
6165 test-options unknown-is-operand" and "maint show
6166 test-options-completion-result".
6167 (New command options, command completion): New section.
6168 (Completion improvements): New section.
6169 Mention that you can abbreviate "unlimited".
6170
6206060d
PA
61712019-06-13 Pedro Alves <palves@redhat.com>
6172
6173 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6174 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6175 * unittests/cli-utils-selftests.c (test_parse_flags)
6176 (test_parse_flags_qcs): Delete.
6177 (test_cli_utils): Don't call deleted functions.
6178
6665660a
PA
61792019-06-13 Pedro Alves <palves@redhat.com>
6180
6181 * thread.c: Include "cli/cli-option.h".
6182 (tp_array_compar_ascending): Global.
6183 (tp_array_compar): Delete function.
6184 (tp_array_compar_ascending, tp_array_compar_descending): New
6185 functions.
6186 (ascending_option_def, qcs_flag_option_def)
6187 (thr_qcs_flags_option_defs)
6188 (make_thread_apply_all_options_def_group)
6189 (make_thread_apply_options_def_group): New.
6190 (thread_apply_all_command): Use gdb::option::process_options.
6191 (thread_apply_command_completer)
6192 (thread_apply_all_command_completer): New.
6193 (thread_apply_command): Use gdb::option::process_options.
6194 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6195 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6196 to generate help text of "thread apply". Adjust "taas"'s help.
6197 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6198 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6199
f7e13587
PA
62002019-06-13 Pedro Alves <palves@redhat.com>
6201
6202 * thread.c (thread_apply_command): Check for invalid TID with
6203 isdigit instead of !isalpha.
6204
5d707134
PA
62052019-06-13 Pedro Alves <palves@redhat.com>
6206
6207 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6208 (validate_flags_qcs): New.
6209 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6210 (validate_flags_qcs): Declare.
6211 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6212 (make_frame_apply_options_def_group): New.
6213 (frame_apply_command_count): Process options with
6214 gdb::option::process_options.
6215 (frame_apply_completer): New.
6216 (frame_apply_level_completer, frame_apply_all_completer)
6217 (frame_apply_completer): New.
6218 (_initialize_stack): Update help of "frame apply", "frame apply
6219 level", "frame apply all" and "faas" to mention supported options
6220 and install command completers.
6221 * stack.h (frame_apply_all_completer): Declare.
6222 * thread.c: Include "stack.h".
6223 (tfaas_command): Add "--".
6224 (_initialize_thread): Update help "tfaas" to mention supported
6225 options and install command completer.
6226
272d4594
PA
62272019-06-13 Pedro Alves <palves@redhat.com>
6228
6229 * completer.c (complete_nested_command_line): New.
6230 (gdb_completion_word_break_characters_throw): Add assertion.
6231 * completer.h (complete_nested_command_line): Declare.
6232
90a1ef87
PA
62332019-06-13 Pedro Alves <palves@redhat.com>
6234
6235 * stack.c (parse_backtrace_qualifiers): New.
6236 (backtrace_command): Use it.
6237 (backtrace_command_completer): Complete on qualifiers.
6238
d4c16835
PA
62392019-06-13 Pedro Alves <palves@redhat.com>
6240
6241 * frame.c: Include "cli/cli-option.h.
6242 (user_set_backtrace_options): New.
6243 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6244 Delete.
6245 (get_prev_frame): Adjust.
6246 (boolean_option_def, uinteger_option_def)
6247 (set_backtrace_option_defs): New.
6248 (_initialize_frame): Adjust and use
6249 gdb::option::add_setshow_cmds_for_options to install "set
6250 backtrace past-main" and "set backtrace past-entry".
6251 * frame.h: Include "cli/cli-option.h".
6252 (struct frame_print_options): Forward declare.
6253 (print_frame_arguments_all, print_frame_arguments_scalars)
6254 (print_frame_arguments_none): Declare.
6255 (print_entry_values): Delete declaration.
6256 (struct frame_print_options, user_frame_print_options): New.
6257 (struct set_backtrace_options): New.
6258 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6259 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6260 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6261 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6262 (list_args_or_locals): Add frame_print_options parameter.
6263 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6264 * python/py-framefilter.c (enumerate_args): Pass down
6265 USER_FRAME_PRINT_OPTIONS.
6266 * stack.c: Include "cli/cli-option.h".
6267 (print_frame_arguments_all, print_frame_arguments_scalars)
6268 (print_frame_arguments_none): Declare.
6269 (print_raw_frame_arguments, print_entry_values): Delete.
6270 (user_frame_print_options): New.
6271 (boolean_option_def, enum_option_def, frame_print_option_defs):
6272 New.
6273 (struct backtrace_cmd_options): New.
6274 (bt_flag_option_def): New.
6275 (backtrace_command_option_defs): New.
6276 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6277 (print_frame_arg, read_frame_arg, print_frame_args)
6278 (print_frame_info, print_frame): Add frame_print_options parameter
6279 and use it.
6280 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6281 (backtrace_command_1): Add frame_print_options and
6282 backtrace_cmd_options parameters and use them.
6283 (make_backtrace_options_def_group): New.
6284 (backtrace_command): Process command options with
6285 gdb::option::process_options.
6286 (backtrace_command_completer): New.
6287 (_initialize_stack): Extend "backtrace"'s help to mention
6288 supported options. Install completer for "backtrace".
6289 Install some settings commands with add_setshow_cmds_for_options.
6290
2daf894e
PA
62912019-06-13 Pedro Alves <palves@redhat.com>
6292
6293 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6294 and that "set/show print raw frame-arguments" are now deprecated.
6295
6296 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6297 command.
6298 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6299 * stack.c (_initialize_stack): Install "set/show print
6300 raw-frame-arguments", and deprecate "set/show print raw
6301 frame-arguments".
6302 * valprint.c (_initialize_valprint): Deprecate "set/show print
6303 raw".
6304
e6ed716c
PA
63052019-06-13 Pedro Alves <palves@redhat.com>
6306
6307 * compile/compile.c (struct compile_options): New.
6308 (compile_flag_option_def, compile_command_option_defs)
6309 (make_compile_options_def_group): New.
6310 (compile_file_command): Handle options with
6311 gdb::option::process_options.
6312 (compile_file_command_completer): New function.
6313 (compile_code_command): Handle options with
6314 gdb::option::process_options.
6315 (compile_code_command_completer): New function.
6316 (_initialize_compiler): Install completers for "compile code" and
6317 "compile file". Mention available options in "compile code" and
6318 "compile code"'s help.
6319 * completer.c (advance_to_completion_word): New, factored out from
6320 ...
6321 (advance_to_expression_complete_word_point): ... this.
6322 (advance_to_filename_complete_word_point): New.
6323 * completer.h (advance_to_filename_complete_word_point): New
6324 declaration.
6325
7d8062de
PA
63262019-06-13 Pedro Alves <palves@redhat.com>
6327
6328 * compile/compile.c: Include "cli/cli-option.h".
6329 (compile_print_value): Scope data pointer is now a
6330 value_print_options pointer; adjust.
6331 (compile_print_command): Process options. Scope data pointer is
6332 now a value_print_options pointer; adjust.
6333 (_initialize_compile): Update "compile print"'s help to include
6334 supported options. Install a completer for "compile print".
6335 * cp-valprint.c (show_vtblprint, show_objectprint)
6336 (show_static_field_print): Delete.
6337 (_initialize_cp_valprint): Don't install "set print
6338 static-members", "set print vtbl", "set print object" here.
6339 * printcmd.c: Include "cli/cli-option.h" and
6340 "common/gdb_optional.h".
6341 (print_command_parse_format): Rework to fill in a
6342 value_print_options instead of a format_data.
6343 (print_value): Change parameter type from format_data pointer to
6344 value_print_options reference. Adjust.
6345 (print_command_1): Process options. Adjust to pass down a
6346 value_print_options.
6347 (print_command_completer): New.
6348 (_initialize_printcmd): Install print_command_completer as
6349 handle_brkchars completer for the "print" command. Update
6350 "print"'s help to include supported options.
6351 * valprint.c: Include "cli/cli-option.h".
6352 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6353 here from cp-valprint.c.
6354 (boolean_option_def, uinteger_option_def)
6355 (value_print_option_defs, make_value_print_options_def_group):
6356 New. Use gdb::option::add_setshow_cmds_for_options to install
6357 "set print elements", "set print null-stop", "set print repeats",
6358 "set print pretty", "set print union", "set print array", "set
6359 print address", "set print symbol", "set print array-indexes".
6360 * valprint.h: Include <string> and "cli/cli-option.h".
6361 (make_value_print_options_def_group): Declare.
6362 (print_value): Change parameter type from format_data pointer to
6363 value_print_options reference.
6364 (print_command_completer): Declare.
6365
9d0faba9
PA
63662019-06-13 Pedro Alves <palves@redhat.com>
6367
6368 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6369 (COMMON_SFILES): Add maint-test-settings.c.
6370 * cli/cli-decode.c (boolean_enums): New global, factored out from
6371 ...
6372 (add_setshow_boolean_cmd): ... here.
6373 * cli/cli-decode.h (boolean_enums): Declare.
6374 * cli/cli-option.c: New file.
6375 * cli/cli-option.h: New file.
6376 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6377 factored out from ...
6378 (parse_cli_boolean_value(const char *)): ... this.
6379 (is_unlimited_literal): Change parameter type to pointer to
6380 pointer. Adjust and advance ARG pointer.
6381 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6382 (parse_cli_var_enum): New, factored out from ...
6383 (do_set_command): ... this. Adjust.
6384 * cli/cli-setshow.h (parse_cli_boolean_value)
6385 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6386 (parse_cli_var_enum): Declare.
6387 * cli/cli-utils.c: Include "cli/cli-option.h".
6388 (get_ulongest): New.
6389 * cli/cli-utils.h (get_ulongest): Declare.
6390 (check_for_argument): New overloads.
6391 * maint-test-options.c: New file.
6392
2c722807
PA
63932019-06-13 Pedro Alves <palves@redhat.com>
6394
6395 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6396 parse a range if "-" is at the end of the string.
6397
dee7b4c8
PA
63982019-06-13 Pedro Alves <palves@redhat.com>
6399
6400 * cli/cli-setshow.c (parse_auto_binary_operation)
6401 (parse_cli_boolean_value): Don't allow "o".
6402
dca0f6c0
PA
64032019-06-13 Pedro Alves <palves@redhat.com>
6404
6405 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6406 * NEWS: Mention maint test-settings KIND.
6407 * maint-test-settings.c: New file.
6408
597bf39d
PA
64092019-06-13 Pedro Alves <palves@redhat.com>
6410
6411 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6412 completer.
6413 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6414 "set" completers.
6415
48c410fb
PA
64162019-06-13 Pedro Alves <palves@redhat.com>
6417
6418 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6419 after item.
6420
93bcb043
PA
64212019-06-13 Pedro Alves <palves@redhat.com>
6422
6423 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6424
cbba3ecd
PA
64252019-06-13 Pedro Alves <palves@redhat.com>
6426
6427 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6428 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6429 call.
6430 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6431 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6432 calls.
6433 (check_for_argument): Skip spaces after argument.
6434
b9a3f842
PA
64352019-06-13 Pedro Alves <palves@redhat.com>
6436
6437 * thread.c (thread_apply_command): Adjust TID parsing.
6438 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6439 detected before end of string.
6440 (tid_is_in_list): Error out if LIST is invalid.
6441
3844e605
PA
64422019-06-13 Pedro Alves <palves@redhat.com>
6443
6444 * completer.c (complete_line_internal_1): Rewind completion word
6445 point.
6446 (completion_tracker::advance_custom_word_point_by): Change
6447 parameter type to int.
6448 * completer.h (completion_tracker::advance_custom_word_point_by):
6449 Likewise.
6450
00b56dbe
PA
64512019-06-13 Pedro Alves <palves@redhat.com>
6452
6453 * completer.c (advance_to_completion_word): Handle delimiters.
6454
d106773e
PA
64552019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6456
6457 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6458
08f10e02
TT
64592019-06-11 Tom Tromey <tom@tromey.com>
6460
6461 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6462 (xmalloc_failed): Move to alloc.c.
6463 * alloc.c: New file.
6464 * Makefile.in (COMMON_SFILES): Add alloc.c.
6465
1c7fe951
TT
64662019-06-11 Tom Tromey <tom@tromey.com>
6467
6468 * nat/linux-waitpid.c: Don't include server.h.
6469 (linux_debug): Remove.
6470 (my_waitpid): Update.
6471
89549d7f
TT
64722019-06-11 Tom Tromey <tromey@adacore.com>
6473
6474 * infcall.c (_initialize_infcall): Remove trailing newline from
6475 help.
6476 * user-regs.c (_initialize_user_regs): Remove trailing newline
6477 from help.
6478 * typeprint.c (_initialize_typeprint): Remove trailing newline
6479 from help.
6480 * reverse.c (_initialize_reverse): Remove trailing newlines from
6481 help.
6482 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6483 from help.
6484 * language.c (add_set_language_command): Remove trailing newline
6485 from help.
6486 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6487 help.
6488 * disasm.c (_initialize_disasm): Remove trailing newline from
6489 help.
6490 * top.c (init_main): Remove trailing newline from help.
6491 * interps.c (_initialize_interpreter): Remove trailing newline
6492 from help.
6493 * btrace.c (_initialize_btrace): Remove trailing newlines from
6494 help.
6495 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6496 from help.
6497 * python/python.c (_initialize_python): Remove trailing newline
6498 from help.
6499 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6500 help.
6501 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6502 from help. Reformat some text.
6503 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6504 from help.
6505 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6506 newline from help.
6507
86108c13
TT
65082019-06-11 Tom Tromey <tromey@adacore.com>
6509
6510 * darwin-nat.c (darwin_decode_exception_message)
6511 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6512
a7067863
AB
65132019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
6514
6515 * valops.c (value_slice): Check for not allocated or not
6516 associated values.
6517
9ab08412
TV
65182019-06-10 Tom de Vries <tdevries@suse.de>
6519
6520 PR gdb/24618
6521 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6522 sure an empty slot (defined by a 32-bit zero pair) is recognized as
6523 invalid.
6524
f19e22e9
TV
65252019-06-10 Tom de Vries <tdevries@suse.de>
6526
6527 PR gdb/24611
6528 * linespec.c (linespec_lexer_lex_string): Remove incorrect
6529 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
6530
e99f9db0
TV
65312019-06-10 Tom de Vries <tdevries@suse.de>
6532
6533 PR symtab/24545
6534 * symtab.c (struct demangled_name_entry): Add language field.
6535 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
6536 static minimal symbol". Set and use language field.
6537
9bf7038b
TT
65382019-06-10 Tom Tromey <tromey@adacore.com>
6539
6540 * ada-lang.c (_initialize_ada_language): Update help text.
6541
422186a9
TT
65422019-06-10 Tom Tromey <tromey@adacore.com>
6543
6544 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6545 with a newline.
6546 * guile/guile.c (handle_boot_error): Don't end warning with a
6547 newline.
6548 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6549 warning with a newline.
6550 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6551 newline.
6552 (s12z_frame_cache): Likewise.
6553 * dwarf-index-cache.c (index_cache::store): Don't end warning with
6554 a newline.
6555 * solib-svr4.c (disable_probes_interface): Don't end warning with
6556 a newline.
6557 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6558 newline.
6559 * python/python.c (do_finish_initialization): Don't end warning
6560 with a newline.
6561
25ce02ee
TT
65622019-06-10 Tom Tromey <tom@tromey.com>
6563
6564 * python/py-breakpoint.c (gdbpy_breakpoint_created)
6565 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6566 gdbpy_enter.
6567
caa429d8
TT
65682019-06-10 Tom Tromey <tromey@adacore.com>
6569
6570 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6571 data.
6572 (elf_new_init): Don't call stabsread_new_init.
6573 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6574 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
6575 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6576
81873cc8
TV
65772019-06-10 Tom de Vries <tdevries@suse.de>
6578
6579 PR symtab/16264
6580 PR symtab/24517
6581 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6582
4fa0265e
РИ
65832019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
6584
6585 * source.c (find_and_open_source): Also rewrite relative file
6586 names.
6587
1a3da2cd
AB
65882019-04-26 Amos Bird <amosbird@gmail.com>
6589
6590 * annotate.c (annotate_thread_exited): Add "thread-exited"
6591 annotation.
6592
3847a7bf
TT
65932019-06-06 Tom Tromey <tromey@adacore.com>
6594
6595 * maint.h (class scoped_command_stats): Use
6596 DISABLE_COPY_AND_ASSIGN.
6597 <print_time>: New method.
6598 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6599 print_time.
6600 (scoped_command_stats::print_time): New method.
6601
312617a3
AB
66022019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
6603
6604 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6605 instructions of lengths 6 or 8 bytes.
6606
b02f78f9
PA
66072019-06-04 Pedro Alves <palves@redhat.com>
6608
6609 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6610
6611 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6612 * breakpoint.c (condition_completer): Likewise.
6613 * cli/cli-dump.c (scan_expression): Likewise.
6614 * common/filestuff.c (mkdir_recursive): Likewise.
6615 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6616 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6617 (gdb_abspath): Likewise.
6618 * compile/compile-cplus-types.c
6619 (compile_cplus_instance::decl_name): Likewise.
6620 * completer.c (complete_explicit_location):
6621 (signal_completer, reg_or_group_completer_1): Likewise.
6622 * cp-support.c (cp_remove_params_if_any): Likewise.
6623 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6624 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6625 * infcmd.c (strip_bg_char): Likewise.
6626 * linespec.c (copy_token_string): Likewise.
6627 * mi/mi-main.c (output_cores): Likewise.
6628 * psymtab.c (psymtab_search_name):
6629 * symfile.c (test_set_ext_lang_command): Likewise.
6630 * target.c (target_fileio_read_stralloc): Likewise.
6631 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6632 * value.c (complete_internalvar): Likewise.
6633
e1f2e1a2
CB
66342019-06-04 Christian Biesinger <cbiesinger@google.com>
6635
6636 Add objfile property to gdb.Type.
d3238f7d
PA
6637 * NEWS: Mention Python API addition.
6638 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 6639
e664d728
PW
66402019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6641
6642 * NEWS: Mention the new set|show style [title|highlight].
6643 Mention changes to "show style", "help" and "apropos".
6644
66d8c862
PW
66452019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6646
6647 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6648 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
6649 instead of print_help_for_command.
6650 (print_doc_of_command): New function.
6651 (help_list): Add 'apropos -v word' suggestion.
6652 (print_help_for_command): Style the command name using title style.
6653 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6654 (_initialize_cli_cmds): Describe -v in apropos_command help.
6655
9303eb2f
PW
66562019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6657
6658 * cli/cli-style.h (cli_style_option): Add name in constructor,
6659 add m_name class member, add constructor with intensity,
6660 add name class function.
6661 (cli_style_option::add_setshow_commands): Remove name argument.
6662 (highlight_style, title_style): New styles.
6663 * cli/cli-style.c (do_show): New function that shows a style
6664 characteristic styling the style name with itself.
6665 (set_style_name): New function.
6666 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6667 Update all callers according to the changes in cli/cli-style.h.
6668 * utils.h (fputs_highlighted): New function.
6669 * utils.c (fputs_highlighted): Likewise.
6670
e2c52041
PW
66712019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6672
6673 * NEWS: Mention new pipe command and new convenience variables.
6674
947d3946
PW
66752019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6676
6677 * cli/cli-cmds.c (pipe_command): New function.
6678 (_initialize_cli_cmds): Call add_com for pipe_command.
6679 Define | as an alias for pipe.
6680 (exit_status_set_internal_vars): New function.
6681 (shell_escape): Call exit_status_set_internal_vars.
6682 cli/cli-decode.c (find_command_name_length): Recognize | as
6683 a single character command.
6684
b8fd0918
PW
66852019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6686
6687 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6688 top.c (execute_command_to_ui_file): New function, mostly a copy
6689 of execute_command_to_string.
6690 (execute_command_to_string): Implement by calling
6691 execute_command_to_ui_file.
6692
68bb5386
PW
66932019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6694
6695 * top.h (saved_command_line): Remove declaration.
6696 * top.c (previous_saved_command_line, previous_repeat_arguments):
6697 New variables.
6698 (saved_command_line): Make static, define together with other
6699 'repeat variables'.
6700 (dont_repeat): Clear repeat_arguments.
6701 (repeat_previous, get_saved_command_line, save_command_line):
6702 New functions.
6703 (gdb_init): Initialize saved_command_line
6704 and previous_saved_command_line.
6705 * main.c (captured_main_1): Remove saved_command_line initialization.
6706 * event-top.c (handle_line_of_input): Update to use
6707 the new 'repeat' related functions instead of direct access to
6708 saved_command_line.
6709 * command.h (repeat_previous, get_saved_command_line,
6710 save_command_line): New declarations.
6711 (dont_repeat): Add comment.
6712
bfcdb852
TT
67132019-05-30 Tom Tromey <tromey@adacore.com>
6714
6715 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6716 Fix comment.
6717 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6718
0ef209f2
JV
67192019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6720
6721 PR cli/24587
6722 * completer.c (complete): Initialize variable word.
6723
955b06fa
SDJ
67242019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6725
6726 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6727 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6728 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6729 'body' is NULL to the outter 'if', protecting the '!is_define'
6730 situation as well.
6731
fa9c3fa0
TT
67322019-05-29 Tom Tromey <tromey@adacore.com>
6733
6734 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6735 (dwarf_unknown): New function.
6736 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6737 (dwarf_type_encoding_name): Use dwarf_unknown.
6738
4330d61d
TT
67392019-05-29 Tom Tromey <tromey@adacore.com>
6740
6741 PR c++/20020:
6742 * cp-valprint.c (cp_print_value_fields): Call
6743 cp_print_static_field inside "try".
6744
33a6bc35
TT
67452019-05-29 Tom Tromey <tromey@adacore.com>
6746
6747 * inflow.c (struct terminal_info): Add default operator=.
6748 * configure: Rebuild.
6749 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6750 -Wdeprecated-copy-dtor, -Wredundant-move.
6751
000439d5
TT
67522019-05-29 Tom Tromey <tromey@adacore.com>
6753
6754 * NEWS: Add entry.
6755 * infcmd.c (print_return_value_1): Handle finish_print
6756 option.
6757 (show_print_finish): New function.
6758 (_initialize_infcmd): Add "set/show print finish" commands.
6759 * valprint.c (user_print_options): Initialize new member.
6760 * valprint.h (struct value_print_options) <finish_print>: New
6761 member.
6762
c0e70c62
TT
67632019-05-28 Tom Tromey <tromey@adacore.com>
6764
6765 * ada-lang.c (ada_remove_Xbn_suffix)
6766 (find_old_style_renaming_symbol)
6767 (parse_old_style_renaming): Remove.
6768 (ada_find_renaming_symbol): Don't call
6769 find_old_style_renaming_symbol.
6770 (ada_is_renaming_symbol): Rename from
6771 ada_find_renaming_symbol. Remove "block" parameter. Return
6772 bool. Now static.
6773 (ada_read_var_value): Update and simplify.
6774 * ada-exp.y (write_var_or_type): Remove old code.
6775
766f8836
AH
67762019-05-28 Alan Hayward <alan.hayward@arm.com>
6777
68255adc 6778 PR gdb/25010
766f8836
AH
6779 * event-top.c: Remove include comment.
6780 * inflow.c (class scoped_ignore_sigttou): Move from here...
6781 * inflow.h (class scoped_ignore_sigttou): ...to here.
6782 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6783 * top.c: Remove include comment.
6784
eb41253a
TT
67852019-05-27 Tom Tromey <tom@tromey.com>
6786
6787 * NEWS: Fix typo.
6788
4ca51187
TT
67892019-05-22 Tom Tromey <tromey@adacore.com>
6790
6791 * target.c (target_follow_exec): Constify parameter.
6792 * target-delegates.c: Rebuild.
6793 * remote.c (remote_target::follow_exec): Constify parameter.
6794 * infrun.c (follow_exec): Constify parameter.
6795 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6796 (target_follow_exec): Likewise.
6797
8fca4da0
AH
67982019-05-22 Alan Hayward <alan.hayward@arm.com>
6799
6800 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6801 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6802
b7060614
AH
68032019-05-22 Alan Hayward <alan.hayward@arm.com>
6804
6805 * NEWS: Add debugredirect and testsuite sections.
6806
0a5954bd
SC
68072019-05-22 Simon Cook <simon.cook@embecosm.com>
6808
6809 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6810 target descriptions using exclusively floating point register name
6811 aliases.
6812
dc42e902
AB
68132019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6814
6815 PR gdb/18644:
6816 * f-lang.c (build_fortran_types): Handle the case where
6817 gdbarch_floatformat_for_type returns a nullptr.
6818
fb7806c7
TV
68192019-05-21 Tom de Vries <tdevries@suse.de>
6820
6821 PR cli/24587
6822 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6823
34d11c68
AB
68242019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6825
6826 PR gdb/18644:
6827 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6828 16-byte floats.
6829 * i386-tdep.c (i386_floatformat_for_type): Use
6830 floatformats_ia64_quad for the 16-byte floating point component
6831 within a fortran 32-byte complex number.
6832
122cf0f2
AB
68332019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6834
6835 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6836 delete default constructor.
6837 (find_partial_die): Update to return const struct.
6838 (partial_die_parent_scope): Move variable declaration into scope
6839 of its use and change its type to auto.
6840 (guess_partial_die_structure_name): Likewise.
6841 (partial_die_info::fixup): Likewise.
6842
33d0e35a
TT
68432019-05-17 Tom Tromey <tromey@adacore.com>
6844
6845 * source.c (find_and_open_source): Remove cast.
6846
a45575b0
TT
68472019-05-17 Tom Tromey <tromey@adacore.com>
6848
6849 * annotate.c (annotate_source): Make "filename" const.
6850 * annotate.h (annotate_source): Use const.
6851
81f47ac2
AH
68522019-05-17 Alan Hayward <alan.hayward@arm.com>
6853
6854 * disasm.c (set_disassembler_options): Send errors to stderr.
6855
ca1285d1
AH
68562019-05-17 Alan Hayward <alan.hayward@arm.com>
6857
6858 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6859 (cli_interp_base::set_logging): Check debug_redirect.
6860 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6861 * cli/cli-logging.c (debug_redirect): Add static variable.
6862 (pop_output_files): Add default param.
6863 (handle_redirections): Print debug setting.
6864 (show_logging_command): Likewise.
6865 (_initialize_cli_logging): Add debugredirect command.
6866 * interps.c (current_interp_set_logging): Add debug_redirect
6867 parameter.
6868 * interps.h (set_logging): Add debug_redirect parameter.
6869 (current_interp_set_logging): Likewise.
6870 * mi/mi-common.h: Likewise.
6871 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6872
68732019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
6874 Tom Tromey <tromey@adacore.com>
6875
6876 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6877 directly.
6878 * cli/cli-interp.h (make_logging_output): Remove declaration.
6879 * cli/cli-logging.c (make_logging_output): Remove function.
6880 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6881 directly.
6882 * ui-file.c (tee_file::tee_file): Remove bools.
6883 (tee_file::~tee_file): Remove deletes.
6884 * ui-file.h (tee_file): Remove bools.
6885
26648588
JV
68862019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6887
6888 * mi/mi-cmds.h (mi_cmd_complete): New function.
6889 * mi/mi-main.c (mi_cmd_complete): Likewise.
6890 * mi/mi-cmds.c: Define new MI command -complete.
6891 * NEWS: Mention new -complete command.
6892
6e035501
JV
68932019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6894
6895 * completer.h (complete): New function.
6896 * completer.c (complete): Likewise.
6897 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6898 function defined in completer.h.
6899
7d0e2ece
JV
69002019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6901
e79be6e5 6902 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 6903
fb816e8b
TV
69042019-05-17 Tom de Vries <tdevries@suse.de>
6905
6906 PR gdb/24094
6907 * dwarf2read.c (struct cu_partial_die_info): New struct.
6908 (find_partial_die): Return cu_partial_die_info.
6909 (partial_die_parent_scope, guess_partial_die_structure_name)
6910 (partial_die_info::fixup): Handle new return type of find_partial_die.
6911
677052f2
SDJ
69122019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6913
a1726c38 6914 PR breakpoints/24541
677052f2
SDJ
6915 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6916 "std::string", simplifying the algorithm.
6917
f3da9116
SDJ
69182019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6919
6920 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6921 (stap_static_probe_ops::get_probes): Likewise.
6922
f1bb75ab
SDJ
69232019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6924
6925 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6926 '-')" and "else if".
6927 (stap_parse_single_operand): Join checks for
6928 "gdbarch_stap_parse_special_token_p" and
6929 "gdbarch_stap_parse_special_token" in the same "if" statement.
6930 Invert check when verifying for operation on register
6931 displacement.
6932
3ca58cde
SDJ
69332019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6934
6935 * stap-probe.c (stap_get_opcode): Update comment.
6936 (stap_get_expected_argument_type): Likewise.
6937 (handle_stap_probe): Likewise.
6938
af2d9bee
SDJ
69392019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6940
6941 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6942 return type to 'bool'. Adjust comment. Use 'bool' when
6943 appropriate.
6944 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6945 * stap-probe.c (stap_parse_argument_1): Likewise.
6946 (stap_is_operator): Likewise.
6947 (stap_is_generic_prefix): Likewise.
6948 (stap_is_register_prefix): Likewise.
6949 (stap_is_register_indirection_prefix): Likewise.
6950 (stap_is_integer_prefix): Likewise.
6951 (stap_generic_check_suffix): Likewise.
6952 (stap_check_integer_suffix): Likewise.
6953 (stap_check_register_suffix): Likewise.
6954 (stap_check_register_indirection_suffix): Likewise.
6955 (stap_parse_register_operand): Likewise.
6956 (stap_parse_single_operand): Likewise.
6957 (stap_parse_argument_1): Likewise.
6958 (stap_probe::get_argument_count): Likewise.
6959 (stap_is_operator): Likewise.
6960
61c9c421
TT
69612019-05-16 Tom Tromey <tromey@adacore.com>
6962
6963 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6964 keyword to foreach.
6965
9ddc1af1
SM
69662019-05-15 Simon Marchi <simon.marchi@efficios.com>
6967
6968 * linux-thread-db.c (try_thread_db_load_1): Change return type
6969 to bool.
6970 (try_thread_db_load): Likewise.
6971 (try_thread_db_load_from_pdir_1): Likewise.
6972 (try_thread_db_load_from_pdir): Likewise.
6973 (try_thread_db_load_from_sdir): Likewise.
6974 (try_thread_db_load_from_dir): Likewise.
6975 (thread_db_load_search): Likewise.
6976 (has_libpthread): Likewise.
6977 (thread_db_load): Likewise.
6978
7bede828
SDJ
69792019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6980
6981 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6982 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6983 NULL, and complain/return if that's the case.
6984
c5358db4
JD
69852019-05-15 John Darrington <john@darrington.wattle.id.au>
6986
6987 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6988 (advance, posn, abstract_read_memory): New functions.
6989 [struct mem_read_abstraction]: New struct.
6990 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6991
c408a94f
TT
69922019-05-14 Tom Tromey <tromey@adacore.com>
6993
6994 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6995 value is not lval_memory.
6996
e7bd7fba
TT
69972019-05-14 Tom Tromey <tromey@adacore.com>
6998
6999 * solib.c (info_sharedlibrary_command): Style the file name.
7000
a6d0f249
AH
70012019-05-14 Alan Hayward <alan.hayward@arm.com>
7002
7003 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7004 (aarch64_vnv_type): Likewise.
7005 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7006 * common/tdesc.c: Likewise.
7007 * common/tdesc.h (enum tdesc_type_kind): Likewise.
7008 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7009 * features/aarch64-fpu.xml: Add ieee half view.
7010 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7011 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7012 * gdbtypes.h (struct builtin_type): Likewise.
7013 (struct objfile_type): Likewise.
7014
66b8bb74
SM
70152019-05-12 Paul Naert <paul.naert@polymtl.ca>
7016
7017 * language.c (language_sniff_from_mangled_name): Fix "langauge"
7018 typo.
7019 * location.h (string_to_event_location): Likewise.
7020
21c219fd
JB
70212019-05-11 Joel Brobecker <brobecker@adacore.com>
7022
7023 GDB 8.3 released.
7024
13674803
SM
70252019-05-10 Simon Marchi <simon.marchi@efficios.com>
7026
7027 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7028 New variable declaration.
7029 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7030 New variable.
7031 (print_one_breakpoint): Use ui_out::test_flags and new global
7032 variable to compute use_fixed_output.
7033 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7034 Remove.
7035 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7036 (mi_multi_location_breakpoint_output_fixed): Remove.
7037 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7038 new variable.
7039 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7040 fix_multi_location_breakpoint_output flag if version >= 3.
7041 * ui-out.h (enum ui_out_flag)
7042 <fix_multi_location_breakpoint_output>: New enumerator.
7043
a9eac7f9
SM
70442019-05-10 Simon Marchi <simon.marchi@efficios.com>
7045
7046 * contrib/cc-with-tweaks.sh: Validate dwz's work.
7047
71bed2db
TT
70482019-05-10 Tom Tromey <tromey@adacore.com>
7049
7050 * ada-lang.c (catch_ada_completer): New function.
7051 (_initialize_ada_language): Use it.
7052
24c54127
TT
70532019-05-10 Tom Tromey <tromey@adacore.com>
7054
7055 * thread.c (print_thread_info): Make "requested_threads" const.
7056 * gdbthread.h (print_thread_info): Make "requested_threads"
7057 const.
7058 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7059 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7060
7a102139
TT
70612019-05-08 Tom Tromey <tom@tromey.com>
7062
7063 * gdbtypes.c (objfile_type_data): Change type.
7064 (objfile_type, _initialize_gdbtypes): Update.
7065
924d79e2
TT
70662019-05-08 Tom Tromey <tom@tromey.com>
7067
7068 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7069 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7070 (_initialize_dwarf2_frame): Update.
7071
4c58e337
TT
70722019-05-08 Tom Tromey <tom@tromey.com>
7073
7074 * objc-lang.c (objc_objfile_data): Change type.
7075 (find_methods): Update.
7076 (_initialize_objc_lang): Remove.
7077
d772d2ab
TT
70782019-05-08 Tom Tromey <tom@tromey.com>
7079
7080 * stabsread.c (rs6000_builtin_type_data): Change type.
7081 (rs6000_builtin_type, _initialize_stabsread): Update.
7082
d11d83f4
TT
70832019-05-08 Tom Tromey <tom@tromey.com>
7084
7085 * mips-tdep.c (mips_pdr_data): Remove.
7086 (_initialize_mips_tdep): Update.
7087
9a73f0ad
TT
70882019-05-08 Tom Tromey <tom@tromey.com>
7089
7090 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7091 (hppa_init_objfile_priv_data, read_unwind_info)
7092 (find_unwind_entry, _initialize_hppa_tdep): Update.
7093
8127a2fa
TT
70942019-05-08 Tom Tromey <tom@tromey.com>
7095
7096 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7097 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7098 on obstack.
7099 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7100
91d3055d
TT
71012019-05-08 Tom Tromey <tom@tromey.com>
7102
7103 * mdebugread.c (basic_type_data): Change type.
7104 (basic_type, _initialize_mdebugread): Update.
7105
31930bd3
TT
71062019-05-08 Tom Tromey <tom@tromey.com>
7107
7108 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7109
bdb3ed9e
TT
71102019-05-08 Tom Tromey <tom@tromey.com>
7111
7112 * nto-tdep.c (nto_inferior_data_reg): Change type.
7113 (nto_inferior_data): Update.
7114 (nto_inferior_data_cleanup, nto_new_inferior_data)
7115 (_initialize_nto_tdep): Remove.
7116 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7117
f37b313d
TT
71182019-05-08 Tom Tromey <tom@tromey.com>
7119
7120 * ada-lang.c (struct ada_inferior_data): Add initializers.
7121 (ada_inferior_data): Change type.
7122 (ada_inferior_data_cleanup): Remove.
7123 (get_ada_inferior_data, ada_inferior_exit)
7124 (struct ada_pspace_data): Add initializers, destructor.
7125 (ada_pspace_data_handle): Change type.
7126 (get_ada_pspace_data): Update.
7127 (ada_pspace_data_cleanup): Remove.
7128
24699405
TT
71292019-05-08 Tom Tromey <tom@tromey.com>
7130
7131 * coffread.c (struct coff_symfile_info): Add initializers.
7132 (coff_objfile_data_key): Move lower. Change type.
7133 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7134 Update.
7135 (coff_free_info): Remove.
7136
d4e05d2f
TT
71372019-05-08 Tom Tromey <tom@tromey.com>
7138
7139 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7140 (fbsd_pspace_data_handle): Move lower. Change type.
7141 (get_fbsd_pspace_data): Update.
7142 (fbsd_pspace_data_cleanup): Remove.
7143 (_initialize_fbsd_tdep): Update.
7144
14ef6690
TT
71452019-05-08 Tom Tromey <tom@tromey.com>
7146
7147 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7148 (get_ada_tasks_pspace_data): Update.
7149 (ada_tasks_pspace_data_cleanup): Remove.
7150 (_initialize_tasks): Update.
7151 (ada_tasks_inferior_data_handle): Change type.
7152 (get_ada_tasks_inferior_data): Update.
7153 (ada_tasks_inferior_data_cleanup): Remove.
7154 (struct ada_tasks_pspace_data): Add initializers.
7155
814cf43a
TT
71562019-05-08 Tom Tromey <tom@tromey.com>
7157
7158 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7159 * symfile-debug.c (debug_sym_get_probes): Change type.
7160 * stap-probe.c (handle_stap_probe):
7161 (stap_static_probe_ops::get_probes): Change type.
7162 * probe.h (class static_probe_ops) <get_probes>: Change type.
7163 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7164 (parse_probes_in_pspace): Update.
7165 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7166 Update.
7167 (any_static_probe_ops::get_probes): Change type.
7168 * elfread.c (elfread_data): New typedef.
7169 (probe_key): Change type.
7170 (elf_get_probes): Likewise. Update.
7171 (probe_key_free): Remove.
7172 (_initialize_elfread): Update.
7173 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7174 Change type.
7175 (dtrace_process_dof_probe, dtrace_process_dof)
7176 (dtrace_static_probe_ops::get_probe): Change type.
7177
02dc647e
TT
71782019-05-08 Tom Tromey <tom@tromey.com>
7179
7180 * xcoffread.c (struct xcoff_symfile_info): Rename from
7181 coff_symfile_info. Add initializers.
7182 (xcoff_objfile_data_key): Move lower. Change type.
7183 (XCOFF_DATA): Rewrite.
7184 (xcoff_free_info): Remove.
7185 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7186 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7187 (xcoff_initial_scan): Update.
7188
09232438
TT
71892019-05-08 Tom Tromey <tom@tromey.com>
7190
7191 * solib-svr4.c (struct svr4_info): Add initializers and
7192 destructor.
7193 <probes_table>: Now an htab_up.
7194 (solib_svr4_pspace_data): Change type.
7195 (free_probes_table): Simplify.
7196 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7197 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7198 (probes_table_remove_objfile_probes, register_solib_event_probe)
7199 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7200 (_initialize_svr4_solib): Update.
7201
7b4a314f
TT
72022019-05-08 Tom Tromey <tom@tromey.com>
7203
7204 * remote.c (remote_pspace_data): Change type.
7205 (remote_pspace_data_cleanup): Remove.
7206 (get_remote_exec_file, set_pspace_remote_exec_file)
7207 (_initialize_remote): Update.
7208
51d3063a
TT
72092019-05-08 Tom Tromey <tom@tromey.com>
7210
7211 * breakpoint.c (breakpoint_objfile_key): Change type.
7212 (get_breakpoint_objfile_data): Update.
7213 (free_breakpoint_objfile_data): Remove.
7214 (_initialize_breakpoint): Update.
7215
89fb8848
TT
72162019-05-08 Tom Tromey <tom@tromey.com>
7217
7218 * linux-tdep.c (struct linux_info): Add initializers.
7219 (linux_inferior_data): Move. Change type.
7220 (invalidate_linux_cache_inf): Update.
7221 (linux_inferior_data_cleanup): Remove.
7222 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7223
e9b89e2d
TT
72242019-05-08 Tom Tromey <tom@tromey.com>
7225
7226 * auxv.c (auxv_inferior_data): Move. Change type.
7227 (auxv_inferior_data_cleanup): Remove.
7228 (invalidate_auxv_cache_inf): Rewrite.
7229 (get_auxv_inferior_data, _initialize_auxv): Update.
7230
8c42777c
TT
72312019-05-08 Tom Tromey <tom@tromey.com>
7232
7233 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7234 (symfile_debug_objfile_data_key): Change type.
7235 (symfile_debug_installed, debug_qf_has_symbols)
7236 (debug_qf_find_last_source_symtab)
7237 (debug_qf_forget_cached_source_info)
7238 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7239 (debug_qf_print_stats, debug_qf_dump)
7240 (debug_qf_expand_symtabs_for_function)
7241 (debug_qf_expand_all_symtabs)
7242 (debug_qf_expand_symtabs_with_fullname)
7243 (debug_qf_map_matching_symbols)
7244 (debug_qf_expand_symtabs_matching)
7245 (debug_qf_find_pc_sect_compunit_symtab)
7246 (debug_qf_map_symbol_filenames)
7247 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7248 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7249 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7250 (debug_sym_read_linetable, debug_sym_relocate): Update.
7251 (symfile_debug_free_objfile): Remove.
7252 (install_symfile_debug_logging, _initialize_symfile_debug):
7253 Update.
7254
5bfd760d
TT
72552019-05-08 Tom Tromey <tom@tromey.com>
7256
7257 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7258 allocate_on_obstack.
7259 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7260 (get_dwarf2_per_objfile): Update.
7261 (set_dwarf2_per_objfile): Remove.
7262 (dwarf2_has_info, dwarf2_get_section_info): Update.
7263 (dwarf2_free_objfile): Remove.
7264 (_initialize_dwarf2_read): Update.
7265
e85e19b4
TT
72662019-05-08 Tom Tromey <tom@tromey.com>
7267
7268 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7269 initializers.
7270 <unsupported_script_warning_printed,
7271 script_not_found_warning_printed>: Now bool.
7272 (auto_load_pspace_data): Change type.
7273 (~auto_load_pspace_info): Rename from
7274 auto_load_pspace_data_cleanup.
7275 (get_auto_load_pspace_data, init_loaded_scripts_info)
7276 (clear_section_scripts, maybe_print_unsupported_script_warning)
7277 (maybe_print_script_not_found_warning, _initialize_auto_load):
7278 Update.
7279
f6aa7436
TT
72802019-05-08 Tom Tromey <tom@tromey.com>
7281
7282 * objfiles.c (objfile_pspace_info): Add destructor and
7283 initializers.
7284 (objfiles_pspace_data): Change type.
7285 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7286 (get_objfile_pspace_data): Update.
7287 (objfiles_bfd_data): Change type.
7288 (get_objfile_bfd_data): Update.
7289 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7290
6ae614f6
TT
72912019-05-08 Tom Tromey <tom@tromey.com>
7292
7293 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7294 Change type.
7295 (get_catch_syscall_inferior_data): Update.
7296 (catch_syscall_inferior_data_cleanup): Remove.
7297 (_initialize_break_catch_syscall): Update.
7298
6509b8eb
TT
72992019-05-08 Tom Tromey <tom@tromey.com>
7300
7301 * inflow.c (struct terminal_info): Add destructor and
7302 initializers.
7303 (inflow_inferior_data): Change type.
7304 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7305 (get_inflow_inferior_data, inflow_inferior_exit)
7306 (swap_terminal_info, _initialize_inflow): Update.
7307
35632941
TT
73082019-05-08 Tom Tromey <tom@tromey.com>
7309
7310 * target-dcache.c (target_dcache_cleanup): Remove.
7311 (target_dcache_aspace_key): Change type.
7312 (target_dcache_init_p, target_dcache_invalidate)
7313 (target_dcache_get, target_dcache_get_or_init)
7314 (_initialize_target_dcache): Update.
7315 * dcache.h (struct dcache_deleter): New.
7316
3017b94d
TT
73172019-05-08 Tom Tromey <tom@tromey.com>
7318
7319 * symtab.c (struct symbol_cache): Add destructor and
7320 initializers.
7321 (symbol_cache_key): Move. Change type.
7322 (make_symbol_cache, free_symbol_cache): Remove.
7323 (get_symbol_cache): Update.
7324 (symbol_cache_cleanup): Remove.
7325 (ALL_PSPACES, symbol_cache_flush)
7326 (maintenance_print_symbol_cache)
7327 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7328 Update.
7329
a32ad8c5
TT
73302019-05-08 Tom Tromey <tom@tromey.com>
7331
7332 * symtab.c (struct main_info): Add destructor and initializers.
7333 (main_progspace_key): Move. Change type.
7334 (get_main_info): Update.
7335 (main_info_cleanup): Remove.
7336 (_initialize_symtab): Update.
7337
5f6e90a0
TT
73382019-05-08 Tom Tromey <tom@tromey.com>
7339
7340 * registry.h (DECLARE_REGISTRY): Define the _key class.
7341
1bd0c6e4
AB
73422019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7343
7344 * NEWS: Merge two 'New commands' sections.
7345
2228ef77
XR
73462019-05-08 Joel Brobecker <brobecker@adacore.com>
7347
7348 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7349 parameter and use Ada language definition instead.
7350 (ada_val_print_ptr): Remove unused language parameter.
7351 (ada_val_print_num): Remove language parameter and use Ada language
7352 definition instead.
7353 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7354 parameter.
7355 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7356 parameter and use Ada language definition instead.
7357 (ada_val_print_1): Update all ada_val_print_xxx calls.
7358 Remove language parameter.
7359 (ada_val_print): Update ada_val_print_1 call.
7360
60fcc1c3
TT
73612019-05-08 Tom Tromey <tromey@adacore.com>
7362
7363 * remote.c (remote_hw_watchpoint_limit)
7364 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7365 Now static.
7366
ed2b7c17
TT
73672019-05-08 Tom Tromey <tromey@adacore.com>
7368
7369 * maint.c (_initialize_maint_cmds): Move initialization code to
7370 remote.c.
7371 (watchdog, show_watchdog): Move to remote.c.
7372 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7373 "watchdog" static.
7374 (_initialize_remote): Move initialization code from maint.c.
7375 * defs.h (watchdog): Don't declare.
7376
b0be6c91
TT
73772019-05-08 Tom Tromey <tromey@adacore.com>
7378
7379 * tui/tui-interp.c: Include main.h.
7380 * interps.c: Include main.h.
7381 * main.h (interpreter_p): Declare.
7382 * defs.h (interpreter_p): Don't declare.
7383
587ee17b
TT
73842019-05-08 Tom Tromey <tromey@adacore.com>
7385
7386 * dwarf2loc.c: Include dwarf2read.h.
7387 * defs.h (read_unsigned_leb128): Don't declare.
7388 * dwarf2read.h (read_unsigned_leb128): Declare.
7389
ca1df239
TT
73902019-05-08 Tom Tromey <tromey@adacore.com>
7391
7392 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7393 method.
7394
99f20f08
TT
73952019-05-08 Tom Tromey <tromey@adacore.com>
7396
7397 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7398 when no wrap column is set.
7399
80e55b13
TT
74002019-05-08 Tom Tromey <tromey@adacore.com>
7401
7402 * c-lang.c (c_get_string): Handle non-C-style arrays.
7403
9d3421af
TT
74042019-05-08 Tom Tromey <tromey@adacore.com>
7405
7406 * typeprint.c (print_offset_data::update): Print the bit offset,
7407 not the number of bits remaining.
7408
844333e2
TT
74092019-05-08 Tom Tromey <tromey@adacore.com>
7410
7411 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7412 padding at end of comment.
7413
988915ee
TT
74142019-05-08 Tom Tromey <tromey@adacore.com>
7415
7416 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7417 Compare main types.
7418
26bfd823
TT
74192019-05-06 Tom Tromey <tom@tromey.com>
7420
7421 * common/scoped_mmap.c: Include common-defs.h.
7422 * common/scoped_mmap.h: Don't include config.h.
7423
89055eaa
TT
74242019-05-04 Tom Tromey <tom@tromey.com>
7425
7426 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7427 (struct aarch64_call_info): Add initializers.
7428 <si>: Now a std::vector.
7429 (pass_on_stack, aarch64_push_dummy_call): Update.
7430
5da01df5
TT
74312019-05-04 Simon Marchi <simon.marchi@efficios.com>
7432 Tom Tromey <tom@tromey.com>
7433
7434 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7435 (ppc_threads): Now a std::vector. Now static.
7436 (hwdebug_find_thread_points_by_tid)
7437 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7438 Update.
7439
fbdf05a1
TT
74402019-05-04 Tom Tromey <tom@tromey.com>
7441
7442 * arc-tdep.c (arc_tdesc_init): Return bool.
7443
06d16ec9
TT
74442019-05-04 Tom Tromey <tom@tromey.com>
7445
7446 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7447 Use gdb_assert_not_reached.
7448
9c056022
TT
74492019-05-04 Tom Tromey <tom@tromey.com>
7450
7451 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7452 "false".
7453
fa9c2a59
TT
74542019-05-04 Tom Tromey <tom@tromey.com>
7455
7456 * arc-tdep.c (arc_tdesc_init): Use bool.
7457
e2eb806a
TT
74582019-05-04 Tom Tromey <tom@tromey.com>
7459
7460 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7461
6fe87677
TT
74622019-05-04 Tom Tromey <tom@tromey.com>
7463
7464 * cli/cli-cmds.c (valid_command_p): Return bool.
7465
7f008c9e
TT
74662019-05-04 Tom Tromey <tom@tromey.com>
7467
7468 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7469 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7470
b6484282
RT
74712019-05-04 Raul Tambre <raul@tambre.ee>
7472
7473 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7474 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7475 operator for comparison.
7476
af97b416
TT
74772019-05-04 Tom Tromey <tom@tromey.com>
7478
7479 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7480 (lookup_partial_symbol, print_partial_symbols)
7481 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7482 (psymbol_compare): Update.
7483 (add_psymbol_to_bcache): Clear the entire psymbol.
7484 (maintenance_check_psymtabs): Update.
7485 * psympriv.h (struct partial_symbol): Don't derive from
7486 general_symbol_info.
7487 <obj_section, unrelocated_address, address,
7488 set_unrelocated_address>: Update.
7489 <ginfo>: New member.
7490 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7491 (debug_names::write_psymbols): Update.
7492
9d6d4be8
TV
74932019-05-04 Tom de Vries <tdevries@suse.de>
7494
7495 * contrib/cc-with-tweaks.sh: Support -n arg.
7496
66452beb
PW
74972019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7498
7499 * corelow.c (core_target::detach): Ensure frame cache and
7500 register caches are cleared.
7501 inferior.c (exit_inferior_1): Likewise.
7502
bde09ab7
TT
75032019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7504 Tom Tromey <tom@tromey.com>
7505
7506 * dictionary.c (collate_pending_symbols_by_language): Remove
7507 "struct" from foreach.
7508 * symtab.c (lookup_global_symbol_from_objfile)
7509 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7510 foreach.
7511 * ser-tcp.c (net_open): Remove "struct" from foreach.
7512 * objfiles.c (objfile_relocate, objfile_rebase)
7513 (objfile_has_symbols): Remove "struct" from foreach.
7514 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7515 from foreach.
7516 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7517 foreach.
7518 * darwin-nat.c (thread_info_from_private_thread_info): Remove
7519 "struct" from foreach.
7520 * ada-lang.c (create_excep_cond_exprs)
7521 (ada_exception_catchpoint_cond_string): Remove "struct" from
7522 foreach.
7523
222a8d25
TT
75242019-05-03 Tom Tromey <tromey@adacore.com>
7525
7526 * ada-exp.y (convert_char_literal): Check suffix of each
7527 enumerator.
7528
fcd60b84
DP
75292019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
7530
7531 PR ada/21406:
7532 * ada-exp.y (yywrap): Don't define.
7533 * ada-lex.l (%option): Add noyywrap
7534 (yywrap): Remove.
7535
5f2459c2
EZ
75362019-05-03 Eli Zaretskii <eliz@gnu.org>
7537
353ea2d1
EZ
7538 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7539 _WIN32_WINNT to the XP level, unless already defined to a higher
7540 level.
7541
7542 * unittests/parse-connection-spec-selftests.c:
7543 * ser-tcp.c:
7544 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
7545 override.
7546
5f2459c2
EZ
7547 * symfile.c (find_separate_debug_file): Remove colon from the
7548 drive spec of DOS/Windows file names of the target, so that the
7549 file name produced from DEBUGDIR and the target's directory will
7550 be valid on DOS/Windows systems.
7551
80062eb9
AB
75522019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
7553
7554 * rust-lang.c (val_print_struct): Handle printing structures
7555 containing strings.
7556
b8c05e85
TT
75572019-05-02 Tom Tromey <tromey@adacore.com>
7558
7559 * valarith.c (_initialize_valarith): Remove.
7560
4504bbde
TT
75612019-05-01 Tom Tromey <tromey@adacore.com>
7562
7563 * ada-lang.c (ada_value_primitive_field): Treat more fields as
7564 bitfields.
7565
d48e62f4
TT
75662019-05-01 Tom Tromey <tromey@adacore.com>
7567
7568 * ada-lang.c (ada_value_assign): Correctly compute starting offset
7569 for big-endian copies.
7570
15f18d14
AT
75712019-04-30 Ali Tamur <tamur@google.com>
7572 * gdb/dwarf2read.c (read_3_bytes): New declaration.
7573 (read_attribute_value): Added DW_FORM_strx1-4 cases.
7574 (read_3_bytes): New function.
7575
ab4ee614
JB
75762019-04-30 Joel Brobecker <brobecker@adacore.com>
7577
7578 * windows-nat.c (main_thread_id): Delete.
7579 (handle_output_debug_string): Replace main_thread_id by
7580 current_event.dwThreadId.
7581 (fake_create_process): Likewise.
7582 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7583 Do not set main_thread_id.
7584 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7585 current_event.dwThreadId.
7586 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7587
8ed5b76e
JB
75882019-04-30 Joel Brobecker <brobecker@adacore.com>
7589
7590 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7591 Use current_event.dwThreadId instead of main_thread_id.
7592
2ff0a947
TT
75932019-04-30 Tom Tromey <tromey@adacore.com>
7594
7595 * ada-lang.c (ada_lookup_simple_minsyms): New function.
7596 (create_excep_cond_exprs): Iterate over program spaces.
7597 (ada_exception_catchpoint_cond_string): Examine all minimal
7598 symbols for exception types.
7599
a776957c
TT
76002019-04-30 Tom Tromey <tromey@adacore.com>
7601
7602 PR c++/24470:
7603 * dwarf2read.c (process_structure_scope): Handle case where type
7604 has template parameters but no symbol was created.
7605
bc68014d
AB
76062019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7607 Chris January <chris.january@arm.com>
7608
7609 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7610 qualifier.
7611 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7612
f1fdc960
AB
76132019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7614
7615 * f-typeprint.c (f_print_type): Update rules for printing
7616 whitespace.
7617 (f_type_print_varspec_suffix): Likewise.
7618
bf7a4de1
AB
76192019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7620 Chris January <chris.january@arm.com>
7621
7622 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7623 function arguments.
7624
bbe75b9d
AB
76252019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7626
7627 * f-lang.c (build_fortran_types): Change name of void type to
7628 lower case.
7629 * f-typeprint.c (f_type_print_base): Print the name of the void
7630 type, rather than a fixed string.
7631 * f-valprint.c (f_decorations): Use lower case void string.
7632
1db455a7
AB
76332019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7634 Chris January <chris.january@arm.com>
7635
7636 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7637 types for Fortran.
7638
b6d03bb2
AB
76392019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7640 Chris January <chris.january@arm.com>
7641 David Lecomber <david.lecomber@arm.com>
7642
7643 * f-exp.y (BINOP_INTRINSIC): New token.
7644 (exp): New parser rule handling BINOP_INTRINSIC.
7645 (f77_keywords): Add new builtin procedures.
7646 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7647 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7648 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7649 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7650 (print_unop_subexp_f): New function.
7651 (print_binop_subexp_f): New function.
7652 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7653 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7654 (dump_subexp_body_f): Likewise.
7655 (operator_check_f): Likewise.
7656 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7657 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7658
83228e93
AB
76592019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7660
7661 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7662 UNOP_KIND.
7663 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7664 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7665 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7666 (operator_length_f): New fuction.
7667 (print_subexp_f): New function.
7668 (op_name_f): New function.
7669 (dump_subexp_body_f): New function.
7670 (operator_check_f): New function.
7671 (exp_descriptor_f): Replace standard expression handling functions
7672 with new functions.
7673 * gdb/fortran-operator.def: New file.
7674 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7675 * gdb/std-operator.def: Remove UNOP_KIND.
7676
6fdcd7cc
AB
76772019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7678
7679 * std-operator.def: Remove unbalanced, stray double quote
7680 character.
7681
2e62ab40
AB
76822019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7683 Chris January <chris.january@arm.com>
7684 Daniel Everett <daniel.everett@arm.com>
7685 Nick Forrington <nick.forrington@arm.com>
7686 Richard Bunt <richard.bunt@arm.com>
7687
7688 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7689 of depth when printing anonymous structs or unions.
7690 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7691 Don't print either the top-level value, or the children if the
7692 max-depth is exceeded.
7693 (ppscm_print_children): When printing the key of a map, allow one
7694 extra level of depth.
7695 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7696 print either the top-level value, or the children if the max-depth
7697 is exceeded.
7698 (print_children): When printing the key of a map, allow one extra
7699 level of depth.
7700 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7701 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7702 (user_print_options): Initialise max_depth field.
7703 (val_print_scalar_or_string_type_p): New function.
7704 (val_print): Check to see if the max depth has been reached.
7705 (val_print_check_max_depth): Define new function.
7706 (show_print_max_depth): New function.
7707 (_initialize_valprint): Add 'print max-depth' option.
7708 * valprint.h (struct value_print_options) <max_depth>: New field.
7709 (val_print_check_max_depth): Declare new function.
7710 * NEWS: Document new feature.
7711
4be290b2
AB
77122019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7713
7714 * ada-lang.c (ada_language_defn): Initialise new field.
7715 * c-lang.c (c_is_string_type_p): New function.
7716 (c_language_defn): Initialise new field.
7717 (cplus_language_defn): Initialise new field.
7718 (asm_language_defn): Initialise new field.
7719 (minimal_language_defn): Initialise new field.
7720 * c-lang.h (c_is_string_type_p): Declare new function.
7721 * d-lang.c (d_language_defn): Initialise new field.
7722 * f-lang.c (f_is_string_type_p): New function.
7723 (f_language_defn): Initialise new field.
7724 * go-lang.c (go_is_string_type_p): New function.
7725 (go_language_defn): Initialise new field.
7726 * language.c (default_is_string_type_p): New function.
7727 (unknown_language_defn): Initialise new field.
7728 (auto_language_defn): Initialise new field.
7729 * language.h (struct language_defn) <la_is_string_type_p>: New
7730 member variable.
7731 (default_is_string_type_p): Declare new function.
7732 * m2-lang.c (m2_language_defn): Initialise new field.
7733 * objc-lang.c (objc_language_defn): Initialise new field.
7734 * opencl-lang.c (opencl_language_defn): Initialise new field.
7735 * p-lang.c (pascal_is_string_type_p): New function.
7736 (pascal_language_defn): Initialise new field.
7737 * rust-lang.c (rust_is_string_type_p): New function.
7738 (rust_language_defn): Initialise new field.
7739
721b08c6
AB
77402019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7741
7742 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7743 New field.
7744 * ada-lang.c (ada_language_defn): Initialise new field.
7745 * c-lang.c (c_language_defn): Likewise.
7746 (cplus_language_defn): Likewise.
7747 (asm_language_defn): Likewise.
7748 (minimal_language_defn): Likewise.
7749 * d-lang.c (d_language_defn): Likewise.
7750 * f-lang.c (f_language_defn): Likewise.
7751 * go-lang.c (go_language_defn): Likewise.
7752 * language.c (unknown_language_defn): Likewise.
7753 (auto_language_defn): Likewise.
7754 * m2-lang.c (m2_language_defn): Likewise.
7755 * objc-lang.c (objc_language_defn): Likewise.
7756 * opencl-lang.c (opencl_language_defn): Likewise.
7757 * p-lang.c (pascal_language_defn): Likewise.
7758 * rust-lang.c (rust_language_defn): Likewise.
7759
fc913e53
AB
77602019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7761
7762 * ada-lang.c (ada_is_character_type): Change return type to bool.
7763 (ada_is_string_type): Likewise.
7764 * ada-lang.h (ada_is_character_type): Update declaration
7765 (ada_is_string_type): Likewise.
7766
fa731fa0
PW
77672019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7768
7769 Support style in 'frame|thread apply'
7770
7771 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7772 * record.c (record_start, record_stop): Update callers of
7773 execute_command_to_string with false.
7774 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7775 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7776 methods.
7777 (class string_file): New constructor with term_out parameter.
7778 Override methods term_out and can_emit_style_escape. New member
7779 term_out.
7780 (class stdio_file): Override can_emit_style_escape.
7781 (class tee_file): Override term_out and can_emit_style_escape.
7782 * utils.h (can_emit_style_escape): Remove.
7783 * utils.c (can_emit_style_escape): Likewise.
7784 Update all callers of can_emit_style_escape (SOMESTREAM) to
7785 SOMESTREAM->can_emit_style_escape.
7786 * source-cache.c (source_cache::get_source_lines): Likewise.
7787 * stack.c (frame_apply_command_count): Call execute_command_to_string
7788 passing the term_out characteristic of the current gdb_stdout.
7789 * thread.c (thr_try_catch_cmd): Likewise.
7790 * top.c (execute_command_to_string): pass term_out parameter
7791 to construct the string_file for the command output.
7792 * ui-file.c (term_cli_styling): New function (most code moved
7793 from utils.c can_emit_style_escape).
7794 (string_file::string_file, string_file::can_emit_style_escape,
7795 stdio_file::can_emit_style_escape, tee_file::term_out,
7796 tee_file::can_emit_style_escape): New functions.
7797
136afab8
PW
77982019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7799
7800 * NEWS: Mention the new set|show may-call-functions.
7801 * infcall.c (may_call_functions_p): New variable.
7802 (show_may_call_functions_p): New function.
7803 (call_function_by_hand_dummy): Throws an error if not
7804 may-call-functions.
7805 (_initialize_infcall): Call add_setshow_boolean_cmd for
7806 may-call-functions.
7807
725cbb63
KS
78082019-04-25 Keith Seitz <keiths@redhat.com>
7809
7810 PR c++/24367
7811 * cp-support.c (inspect_type): Don't attempt substitutions
7812 of symbol with the same name.
7813
3d1cbb78
TT
78142019-04-25 Tom Tromey <tromey@adacore.com>
7815
7816 PR gdb/24475:
7817 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7818 static.
7819
94aeb44b
TT
78202019-04-25 Tom Tromey <tromey@adacore.com>
7821
7822 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7823 rvalue reference.
7824 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7825 (gdb_xml_parser::parse): Use std::move.
7826 * python/python-internal.h (gdbpy_convert_exception): Take a const
7827 reference.
7828 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7829 std::move.
7830 * python/py-utils.c (gdbpy_convert_exception): Take a const
7831 reference.
7832 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7833 Use std::move.
7834 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7835 Use std::move.
7836 * mi/mi-main.c (mi_print_exception): Take a const reference.
7837 * main.c (handle_command_errors): Take a const reference.
7838 * linespec.c (parse_linespec): Use std::move.
7839 * infcall.c (run_inferior_call): Use std::move.
7840 (call_function_by_hand_dummy): Use std::move.
7841 * exec.c (try_open_exec_file): Use std::move.
7842 * exceptions.h (exception_print, exception_fprintf)
7843 (exception_print_same): Update.
7844 * exceptions.c (print_exception, exception_print)
7845 (exception_fprintf, exception_print_same): Change parameters to
7846 const reference.
7847 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7848 * common/new-op.c: Use std::move.
7849 * common/common-exceptions.h (struct gdb_exception): Add move
7850 constructor.
7851 (struct gdb_exception_error, struct gdb_exception_quit, struct
7852 gdb_quit_bad_alloc): Change constructor to move constructor.
7853 (throw_exception): Change parameter to rvalue reference.
7854 * common/common-exceptions.c (throw_exception): Take rvalue
7855 reference.
7856 * cli/cli-interp.c (safe_execute_command): Use std::move.
7857 * breakpoint.c (insert_bp_location, location_to_sals): Use
7858 std::move.
7859
680d7fd5
TT
78602019-04-25 Tom Tromey <tromey@adacore.com>
7861
7862 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7863 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7864 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7865 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7866 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7867 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7868 guile/scm-value.c: Use unpack.
7869 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7870 gdbscm_gdb_exception.
7871 (gdbscm_throw_gdb_exception): Likewise.
7872 (struct gdbscm_gdb_exception): New.
7873 (unpack): New function.
7874 (gdbscm_wrap): Use unpack.
7875
c6fdd8b2
TT
78762019-04-25 Tom Tromey <tromey@adacore.com>
7877
7878 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7879 (gdb_rl_callback_handler): Use std::move.
7880 * common/common-exceptions.h (struct gdb_exception): Add move
7881 assignment operator.
7882 (throw_exception_sjlj): Change "exception" to const reference.
7883 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7884 (throw_exception_sjlj): Change "exception" to const reference.
7885
cc06b668
TT
78862019-04-25 Tom Tromey <tromey@adacore.com>
7887
7888 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7889 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7890 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7891 Update.
7892 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7893 Update.
7894 * mi/mi-interp.c (mi_interp::exec): Update.
7895 * linespec.c (parse_linespec): Update.
7896 * infcall.c (run_inferior_call): Update.
7897 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7898 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7899 (gdbscm_lookup_global_symbol): Update.
7900 * guile/scm-param.c (gdbscm_parameter_value): Update.
7901 * guile/scm-frame.c (gdbscm_frame_read_register)
7902 (gdbscm_frame_read_var): Update.
7903 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7904 * exec.c (try_open_exec_file): Update.
7905 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7906 (gdb_rl_callback_handler): Update.
7907 * common/common-exceptions.h (exception_none): Don't declare.
7908 * common/common-exceptions.c (exception_none): Don't define.
7909 (struct catcher) <exception>: Update.
7910 * cli/cli-interp.c (safe_execute_command): Update.
7911 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7912
cf532bd1
AT
79132019-04-25 Ali Tamur <tamur@google.com>
7914
7915 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7916 (read_attribute_value): Likewise.
7917 (dwarf2_read_addr_index): Update comment.
7918 (read_str_index): Add DW_FORM_strx.
7919 (dwarf2_string_attr): Likewise.
7920 (dwarf2_const_value_attr): Likewise.
7921 (dump_die_shallow): Likewise.
7922 (dwarf2_fetch_constant_bytes): Likewise.
7923 (skip_form_bytes): Likewise.
7924 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7925
82433e3e
SDJ
79262019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7927
7928 PR corefiles/11608
7929 PR corefiles/18187
7930 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7931 OFFSET. Verify if current mapping contains an ELF header.
7932 (linux_find_memory_regions_full): Adjust call to
7933 dump_mapping_p.
7934
723adb65
SL
79352019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7936 Kang Li <kanglictf@gmail.com>
7937
7938 PR gdb/21600
7939
7940 * dwarf2-frame.c (read_initial_length): Be consistent about using
7941 unsigned representation of length.
7942 (decode_frame_entry_1): Likewise. Check for wraparound of
7943 end pointer as well as buffer overflow.
7944
596179f7
SDJ
79452019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7946
7947 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7948 "vq".
7949
a59240a4
TT
79502019-04-24 Tom Tromey <tromey@adacore.com>
7951
7952 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7953
f872fdbb
AB
79542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7955
7956 * s12z-tdep.c (s12z_unwind_pc): Delete.
7957 (s12z_unwind_sp): Delete.
7958 (s12z_gdbarch_init): Don't register deleted functions with
7959 gdbarch.
7960
b614e6f3
AB
79612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7962
7963 * rl78-tdep.c (rl78_unwind_sp): Delete.
7964 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7965
14faed38
AB
79662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7967
7968 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7969 (xstormy16_unwind_pc): Delete.
7970 (xstormy16_dummy_id): Delete.
7971 (xstormy16_gdbarch_init): Don't register deleted functions with
7972 gdbarch.
7973
541aad8a
AB
79742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7975
7976 * vax-tdep.c (vax_unwind_pc): Delete.
7977 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7978
29222070
AB
79792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7980
7981 * v850-tdep.c (v850_unwind_sp): Delete.
7982 (v850_unwind_pc): Delete.
7983 (v850_dummy_id): Delete.
7984 (v850_gdbarch_init): Don't register deleted functions with
7985 gdbarch.
7986
0f534d76
AB
79872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7988
7989 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7990 (tilegx_unwind_pc): Delete.
7991 (tilegx_unwind_dummy_id): Delete.
7992 (tilegx_gdbarch_init): Don't register deleted functions with
7993 gdbarch.
7994
1ba7b7f9
AB
79952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7996
7997 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7998 (tic6x_dummy_id): Delete.
7999 (tic6x_gdbarch_init): Don't register deleted functions with
8000 gdbarch.
8001
d31f262c
AB
80022019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8003
8004 * sparc-tdep.c (sparc_unwind_pc): Delete.
8005 (sparc32_gdbarch_init): Don't register deleted function with
8006 gdbarch.
8007
6d14d64d
AB
80082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8009
8010 * sh-tdep.c (sh_unwind_sp): Delete.
8011 (sh_unwind_pc): Delete.
8012 (sh_dummy_id): Delete.
8013 (sh_gdbarch_init): Don't register deleted functions with
8014 gdbarch.
8015
a40dde9d
AB
80162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8017
8018 * score-tdep.c (score_unwind_sp): Delete.
8019 (score_unwind_pc): Delete.
8020 (score_dummy_id): Delete.
8021 (score_gdbarch_init): Don't register deleted functions with
8022 gdbarch.
8023
47c47d69
AB
80242019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8025
8026 * rx-tdep.c (rx_unwind_pc): Delete.
8027 (rx_unwind_sp): Delete.
8028 (rx_dummy_id): Delete.
8029 (rx_gdbarch_init): Don't register deleted functions with
8030 gdbarch. Update comment.
8031
833a4480
AB
80322019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8033
8034 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8035 (rs6000_dummy_id): Delete.
8036 (rs6000_gdbarch_init): Don't register deleted functions with
8037 gdbarch.
8038
3f2cef49
AB
80392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8040
8041 * or1k-tdep.c (or1k_dummy_id): Delete.
8042 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8043
96acf884
AB
80442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8045
8046 * nios2-tdep.c (nios2_dummy_id): Delete.
8047 (nios2_unwind_sp): Delete.
8048 (nios2_gdbarch_init): Don't register deleted functions with
8049 gdbarch.
8050
ca0ab0aa
AB
80512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8052
8053 * nds32-tdep.c (nds32_dummy_id): Delete.
8054 (nds32_unwind_pc): Delete.
8055 (nds32_unwind_sp): Delete.
8056 (nds32_gdbarch_init): Don't register deleted functions with
8057 gdbarch.
8058
c8259044
AB
80592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8060
8061 * msp430-tdep.c (msp430_unwind_pc): Delete.
8062 (msp430_unwind_sp): Delete.
8063 (msp430_dummy_id): Delete.
8064 (msp430_gdbarch_init): Don't register deleted functions with
8065 gdbarch.
8066
27f113c8
AB
80672019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8068
8069 * moxie-tdep.c (moxie_unwind_sp): Delete.
8070 (moxie_unwind_pc): Delete.
8071 (moxie_dummy_id): Delete.
8072 (moxie_gdbarch_init): Don't register deleted functions with
8073 gdbarch.
8074
aee6c3cd
AB
80752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8076
8077 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8078 (mn10300_unwind_pc): Delete.
8079 (mn10300_unwind_sp): Delete.
8080 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8081 mn10300_unwind_sp.
8082 (mn10300_frame_unwind_init): Don't register deleted functions with
8083 gdbarch.
8084
8e2b5aea
AB
80852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8086
8087 * mep-tdep.c (mep_unwind_pc): Delete.
8088 (mep_unwind_sp): Delete.
8089 (mep_dummy_id): Delete.
8090 (mep_gdbarch_init): Don't register deleted functions with
8091 gdbarch.
8092
43cf3ede
AB
80932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8094
8095 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8096 (m68hc11_unwind_sp): Delete.
8097 (m68hc11_gdbarch_init): Don't register deleted functions with
8098 gdbarch.
8099
5e79b7bb
AB
81002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8101
8102 * m32r-tdep.c (m32r_unwind_sp): Delete.
8103 (m32r_unwind_pc): Delete.
8104 (m32r_dummy_id): Delete.
8105 (m32r_gdbarch_init): Don't register deleted functions with
8106 gdbarch.
8107
89b268d8
AB
81082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8109
8110 * m32c-tdep.c (m32c_unwind_pc): Delete.
8111 (m32c_unwind_sp): Delete.
8112 (m32c_dummy_id): Delete.
8113 (m32c_gdbarch_init): Don't register deleted functions with
8114 gdbarch.
8115
946c28d2
AB
81162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8117
8118 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8119 (lm32_unwind_pc): Delete.
8120 (lm32_dummy_id): Delete.
8121 (lm32_gdbarch_init): Don't register deleted functions with
8122 gdbarch.
8123
bf12844a
AB
81242019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8125
8126 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8127 (iq2000_unwind_pc): Delete.
8128 (iq2000_dummy_id): Delete.
8129 (iq2000_gdbarch_init): Don't register deleted functions with
8130 gdbarch.
8131
ecbc06d2
AB
81322019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8133
8134 * nds32-tdep.c (nds32_type_align): Delete.
8135 (nds32_push_dummy_call): Use type_align instead.
8136
030197b4
AB
81372019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8138
8139 * arm-tdep.c (arm_type_align): Only handle vector override case.
8140 (arm_push_dummy_call): Use type_align.
8141 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8142
b907456c
AB
81432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8144
8145 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8146 case.
8147 (pass_on_stack): Use type_align.
8148 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8149 function.
8150
9e97ba43
TT
81512019-04-23 Tom Tromey <tromey@adacore.com>
8152
8153 * dwarf2read.c (line_header::file_name_at): Remove unused
8154 overload.
8155
6892f601
TV
81562019-04-23 Tom de Vries <tdevries@suse.de>
8157
8158 PR gdb/24438
8159 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8160 invocation.
8161
336d760d
AT
8162
81632019-03-27 Ali Tamur <tamur@google.com>
8164
8165 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8166 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8167 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8168 (dwarf_expr_context::get_addr_index): Likewise
8169 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8170 (symbol_needs_eval_context::get_addr_index): Likewise
8171 (disassemble_dwarf_expression): Add DW_OP_addrx
8172 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8173 (read_cutu_die_from_dwo): Update comment
8174 (skip_one_die): Add DW_FORM_addrx
8175 (read_attribute_value): Likewise
8176 (var_decode_location): Add DW_OP_addrx
8177 (dwarf2_const_value_attr): Add DW_FORM_addrx
8178 (dump_die_shallow): Likewise
8179 (dwarf2_fetch_constant_bytes): Likewise
8180 (decode_locdesc): Add DW_OP_addrx
8181 (skip_form_bytes): Add DW_FORM_addrx
8182
ad9d13f8
AT
81832019-04-22 Ali Tamur <tamur@google.com>
8184
8185 * MAINTAINERS (Write After Approval): Add self.
8186
d70cc3ba
SM
81872019-04-22 Simon Marchi <simon.marchi@efficios.com>
8188
8189 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8190 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8191 (open_symbol_file_object): Likewise.
8192 (svr4_default_sos): Add info parameter.
8193 (svr4_read_so_list): Likewise.
8194 (svr4_current_sos_direct): Adjust functions calls to pass down
8195 info.
8196 (svr4_current_sos_1): Add info parameter.
8197 (svr4_current_sos): Call get_svr4_info, pass info down to
8198 svr4_current_sos_1.
8199 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8200 get_svr4_info.
8201 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8202 get_svr4_info.
8203 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8204 to get_svr4_info.
8205 (probes_table_remove_objfile_probes): Likewise.
8206 (register_solib_event_probe): Add info parameter.
8207 (solist_update_incremental): Pass info parameter down to
8208 svr4_read_so_list.
8209 (disable_probes_interface): Add info parameter.
8210 (svr4_handle_solib_event): Pass current_program_space to
8211 get_svr4_info. Adjust disable_probes_interface cleanup.
8212 (svr4_create_probe_breakpoints): Add info parameter, pass it
8213 down to register_solib_event_probe.
8214 (svr4_create_solib_event_breakpoints): Add info parameter,
8215 pass it down to svr4_create_probe_breakpoints.
8216 (enable_break): Pass info down to
8217 svr4_create_solib_event_breakpoints.
8218 (svr4_solib_create_inferior_hook): Pass current_program_space to
8219 get_svr4_info.
8220 (svr4_clear_solib): Likewise.
8221
7905fc35
PA
82222019-04-22 Pedro Alves <palves@redhat.com>
8223
8224 * solib-svr4.c (svr4_free_objfile_observer): New.
8225 (probe_and_action::objfile): New field.
8226 (probes_table_htab_remove_objfile_probes)
8227 (probes_table_remove_objfile_probes): New functions.
8228 (register_solib_event_probe): Add 'objfile' parameter. Store it
8229 in the new probe_and_action. Don't store the probe in 'lookup'.
8230 (svr4_create_probe_breakpoints): Pass objfile to
8231 register_solib_event_probe.
8232 (_initialize_svr4_solib): Register a free_objfile observer.
8233
fb881986
TT
82342019-04-19 Tom Tromey <tom@tromey.com>
8235
8236 * common/queue.h: Remove.
8237
8732db6c
TT
82382019-04-19 Tom Tromey <tom@tromey.com>
8239
8240 * event-loop.c: Don't include "common/queue.h".
8241
97dfbadd
TT
82422019-04-19 Tom Tromey <tom@tromey.com>
8243
8244 * remote.c (remote_target): Use delete.
8245 * remote-notif.h: Include <list>, not "common/queue.h".
8246 (notif_client_p): Remove typedef.
8247 (remote_notif_state): Add constructor, destructor, initializer.
8248 <notif_queue>: Now a std::list.
8249 (remote_notif_state_xfree): Don't declare.
8250 * remote-notif.c (remote_notif_process, handle_notification)
8251 (remote_notif_state_allocate): Update.
8252 (~remote_notif_state): Rename from remote_notif_state_xfree.
8253
cf250e36
TT
82542019-04-19 Tom Tromey <tom@tromey.com>
8255
8256 * symfile.c (reread_symbols): Update.
8257 * objfiles.c (objfile_register_static_link)
8258 (objfile_lookup_static_link): Update
8259 (~objfile) Don't delete static_links.
8260 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8261
61f4b350
TT
82622019-04-19 Tom Tromey <tom@tromey.com>
8263
8264 * type-stack.h (struct type_stack) <insert>: Constify string.
8265 * type-stack.c (type_stack::insert): Constify string.
8266 * gdbtypes.h (lookup_template_type): Update.
8267 (address_space_name_to_int): Update.
8268 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8269 const.
8270 (lookup_template_type): Make name const.
8271 * c-exp.y: Update rules.
8272 (lex_one_token, classify_name, classify_inner_name)
8273 (c_print_token): Update.
8274 * p-exp.y: Update rules.
8275 (yylex): Update.
8276 * f-exp.y: Update rules.
8277 (yylex): Update.
8278 * d-exp.y: Update rules.
8279 (lex_one_token, classify_name, classify_inner_name): Update.
8280 * parse.c (write_dollar_variable, copy_name): Return std::string.
8281 * parser-defs.h (copy_name): Change return type.
8282 * m2-exp.y: Update rules.
8283 (yylex): Update.
8284 * go-exp.y (lex_one_token): Update.
8285 Update rules.
8286 (classify_unsafe_function, classify_packaged_name)
8287 (classify_name, yylex): Update.
8288
189b8c2e
ST
82892019-04-19 Sergei Trofimovich <siarheit@google.com>
8290
8291 * configure.ac: add --enable-source-highlight switch.
8292 * configure: Regenerate.
8293 * top.c (print_gdb_version): plumb --enable-source-highlight
8294 status to "show configuration".
8295
8ecb59f8
TT
82962019-04-19 Tom Tromey <tromey@adacore.com>
8297
8298 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8299 Check ADA_TYPE_P.
8300 (empty_record, ada_template_to_fixed_record_type_1)
8301 (template_to_static_fixed_type)
8302 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8303 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8304 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8305 macros.
8306
62160ec9
TT
83072019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8308
8309 PR symtab/24423:
8310 * source.c (print_source_lines_base): Advance "iter" when a
8311 control character is seen.
8312
f2ae8bc8
PW
83132019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8314
8315 * inferior.h (struct infcall_suspend_state_deleter):
8316 Catch exception in destructor to avoid crash.
8317
d563b953
PW
83182019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8319
8320 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8321 close to the add_com "shell".
8322
dc34c897
TT
83232019-04-18 Tom Tromey <tromey@adacore.com>
8324
8325 * process-stratum-target.h (class process_stratum_target)
8326 <stratum>: Add "final".
8327
a12e5744
TT
83282019-04-17 Tom Tromey <tromey@adacore.com>
8329
8330 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8331 against nullptr before use.
8332
a7e559cc
AH
83332019-04-17 Alan Hayward <alan.hayward@arm.com>
8334
8335 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8336
c01660c6
AB
83372019-04-17 Jim Wilson <jimw@sifive.com>
8338 Andrew Burgess <andrew.burgess@embecosm.com>
8339
8340 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8341 code read might fail, assume 4-byte breakpoint in that case.
8342
4aa866af
LS
83432019-04-15 Leszek Swirski <leszeks@google.com>
8344
8345 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8346 rather than a hand-rolled POD check when checking for forced MEMORY
8347 classification.
8348
48574d91
AH
83492019-04-15 Alan Hayward <alan.hayward@arm.com>
8350
8351 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8352 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8353 function.
8354 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8355 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8356 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8357 declaration.
8358
4da037ef
AH
83592019-04-15 Alan Hayward <alan.hayward@arm.com>
8360
8361 * aarch64-linux-nat.c
8362 (aarch64_linux_nat_target::thread_architecture): Add override.
8363 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8364 each VQ.
8365
ccb8d7e8
AH
83662019-04-15 Alan Hayward <alan.hayward@arm.com>
8367
8368 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8369
35add35e
AB
83702019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8371
8372 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8373 target types of size 96-bits, add some additional comments, and
8374 check that the builtin type we found was the correct size.
8375
51196bbc
EZ
83762019-04-12 Eli Zaretskii <eliz@gnu.org>
8377
8378 * utils.c (prompt_for_continue): Don't restore the styling at the
8379 end, as applied_style has the wrong value. This fixes styling in
8380 long lists of file names that are interrupted by the "Continue?"
8381 prompt.
8382
62253a61
AB
83832019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8384
8385 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8386 * c-lang.c (c_language_defn): Likewise.
8387 (cplus_language_defn): Likewise.
8388 (asm_language_defn): Likewise.
8389 (minimal_language_defn): Likewise.
8390 * d-lang.c (d_language_defn): Likewise.
8391 * f-lang.c (f_language_defn): Likewise.
8392 * go-lang.c (go_language_defn): Likewise.
8393 * language.c (unknown_language_defn): Likewise.
8394 (auto_language_defn): Likewise.
8395 * language.h (struct language_defn): Remove la_magic field.
8396 (LANG_MAGIC): Delete.
8397 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8398 * objc-lang.c (objc_language_defn): Likewise.
8399 * opencl-lang.c (opencl_language_defn): Likewise.
8400 * p-lang.c (pascal_language_defn): Likewise.
8401 * rust-lang.c (rust_language_defn): Likewise.
8402
a9158a86
AB
84032019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8404
8405 * riscv-tdep.c (riscv_type_align): New function.
8406 (riscv_type_alignment): Delete.
8407 (riscv_arg_location): Use 'type_align'.
8408 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8409
41077b66
AB
84102019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8411
8412 * gdbtypes.c (type_align): A struct with no non-static fields also
8413 has alignment of 1.
8414
9f0272f8
AB
84152019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8416
8417 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8418 component to 0.
8419 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8420 member.
8421 (riscv_struct_info::analyse): New implementation using new
8422 analyse_inner member function.
8423 (riscv_struct_info::field_offset): New member function.
8424 (riscv_struct_info::m_offsets): New member variable.
8425 (riscv_struct_info::analyse_inner): New private member function,
8426 takes the old implementation of riscv_struct_info::analyse but
8427 extended to track field offsets.
8428 (riscv_call_arg_struct): Update the struct folding special cases
8429 to handle cases where empty C++ structs, which are non-zero
8430 length, are found.
8431 (riscv_arg_location): Initialise the length of each location, a
8432 non-zero length now indicates the location is in use.
8433 (riscv_push_dummy_call): Allow for the first location having a
8434 non-zero offset when setting up arguments.
8435 (riscv_return_value): Likewise, but for return values.
8436
02cf60c7
TT
84372019-04-11 Tom Tromey <tromey@adacore.com>
8438
8439 * utils.c (internal_vproblem): Make "msg" const.
8440
68811f8f
AH
84412019-04-11 Alan Hayward <alan.hayward@arm.com>
8442
8443 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8444 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8445 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8446 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8447
3f52fdbc
KB
84482019-04-10 Kevin Buettner <kevinb@redhat.com>
8449
8450 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8451 function.
8452 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8453 of amd64_collect_native_gregset.
8454 (amd64_linux_nat_target::store_registers): Likewise.
8455
e9ad22ee
TT
84562019-04-10 Tom Tromey <tom@tromey.com>
8457
8458 * symtab.c (lookup_global_symbol_from_objfile)
8459 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8460 * objfiles.h (class separate_debug_iterator): New.
8461 (class separate_debug_range): New.
8462 (struct objfile) <separate_debug_objfiles>: New method.
8463 (objfile_separate_debug_iterate): Don't declare.
8464 * objfiles.c (separate_debug_iterator::operator++): Rename from
8465 objfile_separate_debug_iterate.
8466 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8467 iterator.
8468 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8469 iterator.
8470
ee371134
TT
84712019-04-10 Tom Tromey <tom@tromey.com>
8472
8473 * symfile.c (reread_symbols): Remove old comment.
8474 * objfiles.c (free_all_objfiles): Fix a typo.
8475
bf227d61
TT
84762019-04-10 Tom Tromey <tom@tromey.com>
8477
8478 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8479 * minsyms.c (lookup_minimal_symbol): Use foreach.
8480 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8481 (lookup_minimal_symbol_solib_trampoline): Likewise.
8482 * symfile.c (reread_symbols): Use foreach.
8483
8dc433a0
TT
84842019-04-09 Ivan Begert <ivanbegert@gmail.com>
8485 Tom Tromey <tromey@adacore.com>
8486
8487 PR rust/24414:
8488 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8489 (rust_lex_int_test): Change "value" to be LONGEST.
8490 (rust_lex_tests): Add test for long integer literal.
8491
9ab8741a
TT
84922019-04-09 Tom Tromey <tromey@adacore.com>
8493
8494 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8495 to bool.
8496 (extended_remote_target::attach): Update.
8497 (remote_target::remote_notice_new_inferior): Update.
8498 (remote_target::add_current_inferior_and_thread): Update.
8499 * inferior.c (exit_inferior_1): Use "false".
8500 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8501
e242fd12
SM
85022019-04-09 Simon Marchi <simon.marchi@efficios.com>
8503
9ca1957f 8504 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
8505 the "start" command.
8506
2b0c8b01
KB
85072019-04-08 Kevin Buettner <kevinb@redhat.com>
8508
8509 * python/py-inferior.c (infpy_thread_from_thread_handle):
8510 Adjust comments to reflect renaming of thread_from_thread_handle
8511 to thread_from_handle. Adjust keywords. Fix type error message.
8512 (inferior_object_methods): Add thread_from_handle. Retain
8513 thread_from_thread_handle, but mark it as deprecated.
8514
50a82723
KB
85152019-04-08 Kevin Buettner <kevinb@redhat.com>
8516
8517 * gdbthread.h (find_thread_by_handle): Revise declaration.
8518 * thread.c (find_thread_by_handle): Likewise. Adjust
8519 implementation too.
8520 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8521 support for buffer objects as handles.
8522
cf63b016
KB
85232019-04-08 Kevin Buettner <kevinb@redhat.com>
8524
8525 * python/py-infthread.c (thpy_thread_handle): New function.
8526 (thread_object_methods): Register thpy_thread_handle.
8527
3d6c6204
KB
85282019-04-08 Kevin Buettner <kevinb@redhat.com>
8529
8530 * gdbthread.h (thread_to_thread_handle): Declare.
8531 * thread.c (gdbtypes.h): Include.
8532 (thread_to_thread_handle): New function.
8533
8534 * target.h (struct target_ops): Add thread_info_to_thread_handle.
8535 (target_thread_info_to_thread_handle): Declare.
8536 * target.c (target_thread_info_to_thread_handle): New function.
8537 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8538 * target-delegates.c: Regenerate.
8539
8540 * linux-thread-db.c (class thread_db_target): Add method
8541 thread_info_to_thread_handle.
8542 (thread_db_target::thread_info_to_thread_handle): Define.
8543 * remote.c (class remote_target): Add new method
8544 thread_info_to_thread_handle.
8545 (remote_target::thread_info_to_thread_handle): Define.
8546
56be6ea8
PA
85472019-04-08 Pedro Alves <palves@redhat.com>
8548
8549 * common/common-exceptions.c (throw_exception): Don't create
8550 named object to throw; throw directly.
8551 (throw_it): Likewise. Don't initialize gdb_exception::message
8552 here, with new; pass FMT and AP to the ctor instead.
8553 * common/common-exceptions.h: Include <string>.
8554 (gdb_exception::gdb_exception(enum return_reason, enum errors,
8555 const char *, va_list)): New ctor. Use std::make_shared.
8556 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8557 errors)): Delete.
8558 (gdb_exception_error::gdb_exception_error(enum errors, const char
8559 *, va_list)): New.
8560 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8561 Add assertion.
8562 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8563 errors)): Delete.
8564 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8565 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8566 Add assertion.
8567
eedc3f4f
TT
85682019-04-08 Tom Tromey <tom@tromey.com>
8569
8570 * valops.c (value_rtti_indirect_type): Replace throw_exception
8571 with throw.
8572 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8573 with throw.
8574 * thread.c (thr_try_catch_cmd): Replace throw_exception with
8575 throw.
8576 * target.c (target_translate_tls_address): Replace throw_exception
8577 with throw.
8578 * stack.c (frame_apply_command_count): Replace throw_exception
8579 with throw.
8580 * solib-spu.c (append_ocl_sos): Replace throw_exception with
8581 throw.
8582 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8583 with throw.
8584 * rs6000-tdep.c (rs6000_frame_cache)
8585 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8586 * remote.c: Replace throw_exception with throw.
8587 * record-full.c (record_full_message, record_full_wait_1)
8588 (record_full_restore): Replace throw_exception with throw.
8589 * record-btrace.c:
8590 (get_thread_current_frame_id, record_btrace_start_replaying)
8591 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8592 (cmd_record_btrace_start): Replace throw_exception with throw.
8593 * parse.c (parse_exp_in_context_1): Replace throw_exception with
8594 throw.
8595 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8596 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8597 * linespec.c:
8598 (find_linespec_symbols): Replace throw_exception with throw.
8599 * infrun.c (displaced_step_prepare, resume): Replace
8600 throw_exception with throw.
8601 * infcmd.c (post_create_inferior): Replace throw_exception with
8602 throw.
8603 * inf-loop.c (inferior_event_handler): Replace throw_exception
8604 with throw.
8605 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8606 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8607 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8608 (get_prev_frame_always, get_frame_pc_if_available)
8609 (get_frame_address_in_block_if_available, get_frame_language):
8610 Replace throw_exception with throw.
8611 * frame-unwind.c (frame_unwind_try_unwinder): Replace
8612 throw_exception with throw.
8613 * eval.c (fetch_subexp_value, evaluate_var_value)
8614 (evaluate_funcall, evaluate_subexp_standard): Replace
8615 throw_exception with throw.
8616 * dwarf2loc.c (call_site_find_chain)
8617 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8618 Replace throw_exception with throw.
8619 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8620 with throw.
8621 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8622 throw.
8623 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8624 * completer.c (complete_line_internal): Replace throw_exception
8625 with throw.
8626 * compile/compile-object-run.c (compile_object_run): Replace
8627 throw_exception with throw.
8628 * cli/cli-script.c (process_next_line): Replace throw_exception
8629 with throw.
8630 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8631 (btrace_enable, btrace_maint_update_pt_packets): Replace
8632 throw_exception with throw.
8633 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8634 throw_exception with throw.
8635 * break-catch-throw.c (re_set_exception_catchpoint): Replace
8636 throw_exception with throw.
8637 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8638 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8639 * aarch64-tdep.c (aarch64_make_prologue_cache)
8640 (aarch64_make_stub_cache): Replace throw_exception with throw.
8641
26003a20
TT
86422019-04-08 Tom Tromey <tom@tromey.com>
8643
8644 * common/common-exceptions.c (throw_exception): Rename from
8645 throw_exception_cxx. Remove old copy. Make argument const.
8646 (throw_it): Create and throw exception objects directly.
8647 * common/common-exceptions.h (throw_exception): Make argument
8648 const.
8649 (struct gdb_exception_error): Add constructor.
8650 (struct gdb_exception_quit): Add constructor.
8651
d272eb37
TT
86522019-04-08 Tom Tromey <tom@tromey.com>
8653
8654 * common/common-exceptions.h (exception_rethrow): Don't declare.
8655 (TRY_SJLJ): Update comment.
8656 (TRY, CATCH, END_CATCH): Remove.
8657 * common/common-exceptions.c (exception_rethrow): Remove.
8658
230d2906
TT
86592019-04-08 Tom Tromey <tom@tromey.com>
8660
8661 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8662 Remove.
8663 (gdb_exception_error): Rename from
8664 gdb_exception_RETURN_MASK_ERROR.
8665 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8666 (gdb_quit_bad_alloc): Update.
8667 * aarch64-tdep.c: Update.
8668 * ada-lang.c: Update.
8669 * ada-typeprint.c: Update.
8670 * ada-valprint.c: Update.
8671 * amd64-tdep.c: Update.
8672 * arch-utils.c: Update.
8673 * break-catch-throw.c: Update.
8674 * breakpoint.c: Update.
8675 * btrace.c: Update.
8676 * c-varobj.c: Update.
8677 * cli/cli-cmds.c: Update.
8678 * cli/cli-interp.c: Update.
8679 * cli/cli-script.c: Update.
8680 * common/common-exceptions.c: Update.
8681 * common/new-op.c: Update.
8682 * common/selftest.c: Update.
8683 * compile/compile-c-symbols.c: Update.
8684 * compile/compile-cplus-symbols.c: Update.
8685 * compile/compile-object-load.c: Update.
8686 * compile/compile-object-run.c: Update.
8687 * completer.c: Update.
8688 * corelow.c: Update.
8689 * cp-abi.c: Update.
8690 * cp-support.c: Update.
8691 * cp-valprint.c: Update.
8692 * darwin-nat.c: Update.
8693 * disasm-selftests.c: Update.
8694 * dtrace-probe.c: Update.
8695 * dwarf-index-cache.c: Update.
8696 * dwarf-index-write.c: Update.
8697 * dwarf2-frame-tailcall.c: Update.
8698 * dwarf2-frame.c: Update.
8699 * dwarf2loc.c: Update.
8700 * dwarf2read.c: Update.
8701 * eval.c: Update.
8702 * event-loop.c: Update.
8703 * event-top.c: Update.
8704 * exec.c: Update.
8705 * f-valprint.c: Update.
8706 * fbsd-tdep.c: Update.
8707 * frame-unwind.c: Update.
8708 * frame.c: Update.
8709 * gdbtypes.c: Update.
8710 * gnu-v3-abi.c: Update.
8711 * guile/guile-internal.h: Update.
8712 * guile/scm-block.c: Update.
8713 * guile/scm-breakpoint.c: Update.
8714 * guile/scm-cmd.c: Update.
8715 * guile/scm-disasm.c: Update.
8716 * guile/scm-frame.c: Update.
8717 * guile/scm-lazy-string.c: Update.
8718 * guile/scm-math.c: Update.
8719 * guile/scm-param.c: Update.
8720 * guile/scm-ports.c: Update.
8721 * guile/scm-pretty-print.c: Update.
8722 * guile/scm-symbol.c: Update.
8723 * guile/scm-symtab.c: Update.
8724 * guile/scm-type.c: Update.
8725 * guile/scm-value.c: Update.
8726 * i386-linux-tdep.c: Update.
8727 * i386-tdep.c: Update.
8728 * inf-loop.c: Update.
8729 * infcall.c: Update.
8730 * infcmd.c: Update.
8731 * infrun.c: Update.
8732 * jit.c: Update.
8733 * language.c: Update.
8734 * linespec.c: Update.
8735 * linux-fork.c: Update.
8736 * linux-nat.c: Update.
8737 * linux-tdep.c: Update.
8738 * linux-thread-db.c: Update.
8739 * main.c: Update.
8740 * mi/mi-cmd-break.c: Update.
8741 * mi/mi-cmd-stack.c: Update.
8742 * mi/mi-interp.c: Update.
8743 * mi/mi-main.c: Update.
8744 * objc-lang.c: Update.
8745 * p-valprint.c: Update.
8746 * parse.c: Update.
8747 * ppc-linux-tdep.c: Update.
8748 * printcmd.c: Update.
8749 * python/py-arch.c: Update.
8750 * python/py-breakpoint.c: Update.
8751 * python/py-cmd.c: Update.
8752 * python/py-finishbreakpoint.c: Update.
8753 * python/py-frame.c: Update.
8754 * python/py-framefilter.c: Update.
8755 * python/py-gdb-readline.c: Update.
8756 * python/py-inferior.c: Update.
8757 * python/py-infthread.c: Update.
8758 * python/py-lazy-string.c: Update.
8759 * python/py-linetable.c: Update.
8760 * python/py-objfile.c: Update.
8761 * python/py-param.c: Update.
8762 * python/py-prettyprint.c: Update.
8763 * python/py-progspace.c: Update.
8764 * python/py-record-btrace.c: Update.
8765 * python/py-record.c: Update.
8766 * python/py-symbol.c: Update.
8767 * python/py-type.c: Update.
8768 * python/py-unwind.c: Update.
8769 * python/py-utils.c: Update.
8770 * python/py-value.c: Update.
8771 * python/python.c: Update.
8772 * record-btrace.c: Update.
8773 * record-full.c: Update.
8774 * remote-fileio.c: Update.
8775 * remote.c: Update.
8776 * riscv-tdep.c: Update.
8777 * rs6000-aix-tdep.c: Update.
8778 * rs6000-tdep.c: Update.
8779 * rust-exp.y: Update.
8780 * rust-lang.c: Update.
8781 * s390-tdep.c: Update.
8782 * selftest-arch.c: Update.
8783 * solib-dsbt.c: Update.
8784 * solib-frv.c: Update.
8785 * solib-spu.c: Update.
8786 * solib-svr4.c: Update.
8787 * solib.c: Update.
8788 * sparc64-linux-tdep.c: Update.
8789 * stack.c: Update.
8790 * symfile-mem.c: Update.
8791 * symmisc.c: Update.
8792 * target.c: Update.
8793 * thread.c: Update.
8794 * top.c: Update.
8795 * tracefile-tfile.c: Update.
8796 * tui/tui.c: Update.
8797 * typeprint.c: Update.
8798 * unittests/cli-utils-selftests.c: Update.
8799 * unittests/parse-connection-spec-selftests.c: Update.
8800 * valops.c: Update.
8801 * valprint.c: Update.
8802 * value.c: Update.
8803 * varobj.c: Update.
8804 * windows-nat.c: Update.
8805 * x86-linux-nat.c: Update.
8806 * xml-support.c: Update.
8807
a70b8144
TT
88082019-04-08 Tom Tromey <tom@tromey.com>
8809
8810 * xml-support.c: Use C++ exception handling.
8811 * x86-linux-nat.c: Use C++ exception handling.
8812 * windows-nat.c: Use C++ exception handling.
8813 * varobj.c: Use C++ exception handling.
8814 * value.c: Use C++ exception handling.
8815 * valprint.c: Use C++ exception handling.
8816 * valops.c: Use C++ exception handling.
8817 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8818 handling.
8819 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8820 * typeprint.c: Use C++ exception handling.
8821 * tui/tui.c: Use C++ exception handling.
8822 * tracefile-tfile.c: Use C++ exception handling.
8823 * top.c: Use C++ exception handling.
8824 * thread.c: Use C++ exception handling.
8825 * target.c: Use C++ exception handling.
8826 * symmisc.c: Use C++ exception handling.
8827 * symfile-mem.c: Use C++ exception handling.
8828 * stack.c: Use C++ exception handling.
8829 * sparc64-linux-tdep.c: Use C++ exception handling.
8830 * solib.c: Use C++ exception handling.
8831 * solib-svr4.c: Use C++ exception handling.
8832 * solib-spu.c: Use C++ exception handling.
8833 * solib-frv.c: Use C++ exception handling.
8834 * solib-dsbt.c: Use C++ exception handling.
8835 * selftest-arch.c: Use C++ exception handling.
8836 * s390-tdep.c: Use C++ exception handling.
8837 * rust-lang.c: Use C++ exception handling.
8838 * rust-exp.y: Use C++ exception handling.
8839 * rs6000-tdep.c: Use C++ exception handling.
8840 * rs6000-aix-tdep.c: Use C++ exception handling.
8841 * riscv-tdep.c: Use C++ exception handling.
8842 * remote.c: Use C++ exception handling.
8843 * remote-fileio.c: Use C++ exception handling.
8844 * record-full.c: Use C++ exception handling.
8845 * record-btrace.c: Use C++ exception handling.
8846 * python/python.c: Use C++ exception handling.
8847 * python/py-value.c: Use C++ exception handling.
8848 * python/py-utils.c: Use C++ exception handling.
8849 * python/py-unwind.c: Use C++ exception handling.
8850 * python/py-type.c: Use C++ exception handling.
8851 * python/py-symbol.c: Use C++ exception handling.
8852 * python/py-record.c: Use C++ exception handling.
8853 * python/py-record-btrace.c: Use C++ exception handling.
8854 * python/py-progspace.c: Use C++ exception handling.
8855 * python/py-prettyprint.c: Use C++ exception handling.
8856 * python/py-param.c: Use C++ exception handling.
8857 * python/py-objfile.c: Use C++ exception handling.
8858 * python/py-linetable.c: Use C++ exception handling.
8859 * python/py-lazy-string.c: Use C++ exception handling.
8860 * python/py-infthread.c: Use C++ exception handling.
8861 * python/py-inferior.c: Use C++ exception handling.
8862 * python/py-gdb-readline.c: Use C++ exception handling.
8863 * python/py-framefilter.c: Use C++ exception handling.
8864 * python/py-frame.c: Use C++ exception handling.
8865 * python/py-finishbreakpoint.c: Use C++ exception handling.
8866 * python/py-cmd.c: Use C++ exception handling.
8867 * python/py-breakpoint.c: Use C++ exception handling.
8868 * python/py-arch.c: Use C++ exception handling.
8869 * printcmd.c: Use C++ exception handling.
8870 * ppc-linux-tdep.c: Use C++ exception handling.
8871 * parse.c: Use C++ exception handling.
8872 * p-valprint.c: Use C++ exception handling.
8873 * objc-lang.c: Use C++ exception handling.
8874 * mi/mi-main.c: Use C++ exception handling.
8875 * mi/mi-interp.c: Use C++ exception handling.
8876 * mi/mi-cmd-stack.c: Use C++ exception handling.
8877 * mi/mi-cmd-break.c: Use C++ exception handling.
8878 * main.c: Use C++ exception handling.
8879 * linux-thread-db.c: Use C++ exception handling.
8880 * linux-tdep.c: Use C++ exception handling.
8881 * linux-nat.c: Use C++ exception handling.
8882 * linux-fork.c: Use C++ exception handling.
8883 * linespec.c: Use C++ exception handling.
8884 * language.c: Use C++ exception handling.
8885 * jit.c: Use C++ exception handling.
8886 * infrun.c: Use C++ exception handling.
8887 * infcmd.c: Use C++ exception handling.
8888 * infcall.c: Use C++ exception handling.
8889 * inf-loop.c: Use C++ exception handling.
8890 * i386-tdep.c: Use C++ exception handling.
8891 * i386-linux-tdep.c: Use C++ exception handling.
8892 * guile/scm-value.c: Use C++ exception handling.
8893 * guile/scm-type.c: Use C++ exception handling.
8894 * guile/scm-symtab.c: Use C++ exception handling.
8895 * guile/scm-symbol.c: Use C++ exception handling.
8896 * guile/scm-pretty-print.c: Use C++ exception handling.
8897 * guile/scm-ports.c: Use C++ exception handling.
8898 * guile/scm-param.c: Use C++ exception handling.
8899 * guile/scm-math.c: Use C++ exception handling.
8900 * guile/scm-lazy-string.c: Use C++ exception handling.
8901 * guile/scm-frame.c: Use C++ exception handling.
8902 * guile/scm-disasm.c: Use C++ exception handling.
8903 * guile/scm-cmd.c: Use C++ exception handling.
8904 * guile/scm-breakpoint.c: Use C++ exception handling.
8905 * guile/scm-block.c: Use C++ exception handling.
8906 * guile/guile-internal.h: Use C++ exception handling.
8907 * gnu-v3-abi.c: Use C++ exception handling.
8908 * gdbtypes.c: Use C++ exception handling.
8909 * frame.c: Use C++ exception handling.
8910 * frame-unwind.c: Use C++ exception handling.
8911 * fbsd-tdep.c: Use C++ exception handling.
8912 * f-valprint.c: Use C++ exception handling.
8913 * exec.c: Use C++ exception handling.
8914 * event-top.c: Use C++ exception handling.
8915 * event-loop.c: Use C++ exception handling.
8916 * eval.c: Use C++ exception handling.
8917 * dwarf2read.c: Use C++ exception handling.
8918 * dwarf2loc.c: Use C++ exception handling.
8919 * dwarf2-frame.c: Use C++ exception handling.
8920 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8921 * dwarf-index-write.c: Use C++ exception handling.
8922 * dwarf-index-cache.c: Use C++ exception handling.
8923 * dtrace-probe.c: Use C++ exception handling.
8924 * disasm-selftests.c: Use C++ exception handling.
8925 * darwin-nat.c: Use C++ exception handling.
8926 * cp-valprint.c: Use C++ exception handling.
8927 * cp-support.c: Use C++ exception handling.
8928 * cp-abi.c: Use C++ exception handling.
8929 * corelow.c: Use C++ exception handling.
8930 * completer.c: Use C++ exception handling.
8931 * compile/compile-object-run.c: Use C++ exception handling.
8932 * compile/compile-object-load.c: Use C++ exception handling.
8933 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8934 * compile/compile-c-symbols.c: Use C++ exception handling.
8935 * common/selftest.c: Use C++ exception handling.
8936 * common/new-op.c: Use C++ exception handling.
8937 * cli/cli-script.c: Use C++ exception handling.
8938 * cli/cli-interp.c: Use C++ exception handling.
8939 * cli/cli-cmds.c: Use C++ exception handling.
8940 * c-varobj.c: Use C++ exception handling.
8941 * btrace.c: Use C++ exception handling.
8942 * breakpoint.c: Use C++ exception handling.
8943 * break-catch-throw.c: Use C++ exception handling.
8944 * arch-utils.c: Use C++ exception handling.
8945 * amd64-tdep.c: Use C++ exception handling.
8946 * ada-valprint.c: Use C++ exception handling.
8947 * ada-typeprint.c: Use C++ exception handling.
8948 * ada-lang.c: Use C++ exception handling.
8949 * aarch64-tdep.c: Use C++ exception handling.
8950
3d6e9d23
TT
89512019-04-08 Tom Tromey <tom@tromey.com>
8952
8953 * xml-support.c (gdb_xml_parser::parse): Update.
8954 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8955 * value.c (show_convenience): Update.
8956 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8957 (test_parse_flags_qcs): Update.
8958 * thread.c (thr_try_catch_cmd): Update.
8959 * target.c (target_translate_tls_address): Update.
8960 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8961 (info_frame_command_core, frame_apply_command_count): Update.
8962 * rust-exp.y (rust_lex_exception_test): Update.
8963 * riscv-tdep.c (riscv_print_one_register_info): Update.
8964 * remote.c (remote_target::enable_btrace): Update.
8965 * record-btrace.c (record_btrace_enable_warn): Update.
8966 * python/py-utils.c (gdbpy_convert_exception): Update.
8967 * printcmd.c (do_one_display, print_variable_and_value): Update.
8968 * mi/mi-main.c (mi_print_exception): Update.
8969 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8970 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8971 * linux-nat.c (linux_nat_target::attach): Update.
8972 * linux-fork.c (class scoped_switch_fork_info): Update.
8973 * infrun.c (displaced_step_prepare): Update.
8974 * infcall.c (call_function_by_hand_dummy): Update.
8975 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8976 * gnu-v3-abi.c (print_one_vtable): Update.
8977 * frame.c (get_prev_frame_always): Update.
8978 * f-valprint.c (info_common_command_for_block): Update.
8979 * exec.c (try_open_exec_file): Update.
8980 * exceptions.c (print_exception, exception_print)
8981 (exception_fprintf, exception_print_same): Update.
8982 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8983 * dwarf-index-cache.c (index_cache::store)
8984 (index_cache::lookup_gdb_index): Update.
8985 * darwin-nat.c (maybe_cache_shell): Update.
8986 * cp-valprint.c (cp_print_value_fields): Update.
8987 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8988 (gcc_cplus_symbol_address): Update.
8989 * compile/compile-c-symbols.c (gcc_convert_symbol)
8990 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8991 * common/selftest.c: Update.
8992 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8993 a std::string.
8994 (exception_try_scope_entry, exception_try_scope_exit): Don't
8995 declare.
8996 (struct exception_try_scope): Remove.
8997 (TRY): Don't use exception_try_scope.
8998 (struct gdb_exception): Add constructor, operator=.
8999 <what>: New method.
9000 (struct gdb_exception_RETURN_MASK_ALL)
9001 (struct gdb_exception_RETURN_MASK_ERROR)
9002 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9003 (struct gdb_quit_bad_alloc): Update.
9004 * common/common-exceptions.c (exception_none): Change
9005 initializer.
9006 (struct catcher) <state, exception>: Initialize inline.
9007 <prev>: Remove member.
9008 (current_catcher): Remove.
9009 (catchers): New global.
9010 (exceptions_state_mc_init): Simplify.
9011 (catcher_pop): Remove.
9012 (exceptions_state_mc, exceptions_state_mc_catch): Update.
9013 (try_scope_depth, exception_try_scope_entry)
9014 (exception_try_scope_exit): Remove.
9015 (throw_exception_sjlj): Update.
9016 (exception_messages, exception_messages_size): Remove.
9017 (throw_it): Simplify.
9018 (gdb_exception_sliced_copy): Remove.
9019 (throw_exception_cxx): Update.
9020 * cli/cli-script.c (script_from_file): Update.
9021 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9022 Update.
9023 * ada-valprint.c (ada_val_print): Update.
9024 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9025 (create_excep_cond_exprs): Update.
9026
c5c10118
TT
90272019-04-08 Tom Tromey <tom@tromey.com>
9028
9029 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9030 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9031 (TRY, CATCH, END_CATCH): Remove some definitions.
9032 * common/common-exceptions.c: Don't use GDB_XCPT.
9033 (catcher_list_size): Remove.
9034 (throw_exception, throw_it): Simplify.
9035
4de283e4
TT
90362019-04-05 Tom Tromey <tom@tromey.com>
9037
9038 Revert the header-sorting patch.
9039 * ft32-tdep.c: Revert.
9040 * frv-tdep.c: Revert.
9041 * frv-linux-tdep.c: Revert.
9042 * frame.c: Revert.
9043 * frame-unwind.c: Revert.
9044 * frame-base.c: Revert.
9045 * fork-child.c: Revert.
9046 * findvar.c: Revert.
9047 * findcmd.c: Revert.
9048 * filesystem.c: Revert.
9049 * filename-seen-cache.h: Revert.
9050 * filename-seen-cache.c: Revert.
9051 * fbsd-tdep.c: Revert.
9052 * fbsd-nat.h: Revert.
9053 * fbsd-nat.c: Revert.
9054 * f-valprint.c: Revert.
9055 * f-typeprint.c: Revert.
9056 * f-lang.c: Revert.
9057 * extension.h: Revert.
9058 * extension.c: Revert.
9059 * extension-priv.h: Revert.
9060 * expprint.c: Revert.
9061 * exec.h: Revert.
9062 * exec.c: Revert.
9063 * exceptions.c: Revert.
9064 * event-top.c: Revert.
9065 * event-loop.c: Revert.
9066 * eval.c: Revert.
9067 * elfread.c: Revert.
9068 * dwarf2read.h: Revert.
9069 * dwarf2read.c: Revert.
9070 * dwarf2loc.c: Revert.
9071 * dwarf2expr.h: Revert.
9072 * dwarf2expr.c: Revert.
9073 * dwarf2-frame.c: Revert.
9074 * dwarf2-frame-tailcall.c: Revert.
9075 * dwarf-index-write.h: Revert.
9076 * dwarf-index-write.c: Revert.
9077 * dwarf-index-common.c: Revert.
9078 * dwarf-index-cache.h: Revert.
9079 * dwarf-index-cache.c: Revert.
9080 * dummy-frame.c: Revert.
9081 * dtrace-probe.c: Revert.
9082 * disasm.h: Revert.
9083 * disasm.c: Revert.
9084 * disasm-selftests.c: Revert.
9085 * dictionary.c: Revert.
9086 * dicos-tdep.c: Revert.
9087 * demangle.c: Revert.
9088 * dcache.h: Revert.
9089 * dcache.c: Revert.
9090 * darwin-nat.h: Revert.
9091 * darwin-nat.c: Revert.
9092 * darwin-nat-info.c: Revert.
9093 * d-valprint.c: Revert.
9094 * d-namespace.c: Revert.
9095 * d-lang.c: Revert.
9096 * ctf.c: Revert.
9097 * csky-tdep.c: Revert.
9098 * csky-linux-tdep.c: Revert.
9099 * cris-tdep.c: Revert.
9100 * cris-linux-tdep.c: Revert.
9101 * cp-valprint.c: Revert.
9102 * cp-support.c: Revert.
9103 * cp-namespace.c: Revert.
9104 * cp-abi.c: Revert.
9105 * corelow.c: Revert.
9106 * corefile.c: Revert.
9107 * continuations.c: Revert.
9108 * completer.h: Revert.
9109 * completer.c: Revert.
9110 * complaints.c: Revert.
9111 * coffread.c: Revert.
9112 * coff-pe-read.c: Revert.
9113 * cli-out.h: Revert.
9114 * cli-out.c: Revert.
9115 * charset.c: Revert.
9116 * c-varobj.c: Revert.
9117 * c-valprint.c: Revert.
9118 * c-typeprint.c: Revert.
9119 * c-lang.c: Revert.
9120 * buildsym.c: Revert.
9121 * buildsym-legacy.c: Revert.
9122 * build-id.h: Revert.
9123 * build-id.c: Revert.
9124 * btrace.c: Revert.
9125 * bsd-uthread.c: Revert.
9126 * breakpoint.h: Revert.
9127 * breakpoint.c: Revert.
9128 * break-catch-throw.c: Revert.
9129 * break-catch-syscall.c: Revert.
9130 * break-catch-sig.c: Revert.
9131 * blockframe.c: Revert.
9132 * block.c: Revert.
9133 * bfin-tdep.c: Revert.
9134 * bfin-linux-tdep.c: Revert.
9135 * bfd-target.c: Revert.
9136 * bcache.c: Revert.
9137 * ax-general.c: Revert.
9138 * ax-gdb.h: Revert.
9139 * ax-gdb.c: Revert.
9140 * avr-tdep.c: Revert.
9141 * auxv.c: Revert.
9142 * auto-load.c: Revert.
9143 * arm-wince-tdep.c: Revert.
9144 * arm-tdep.c: Revert.
9145 * arm-symbian-tdep.c: Revert.
9146 * arm-pikeos-tdep.c: Revert.
9147 * arm-obsd-tdep.c: Revert.
9148 * arm-nbsd-tdep.c: Revert.
9149 * arm-nbsd-nat.c: Revert.
9150 * arm-linux-tdep.c: Revert.
9151 * arm-linux-nat.c: Revert.
9152 * arm-fbsd-tdep.c: Revert.
9153 * arm-fbsd-nat.c: Revert.
9154 * arm-bsd-tdep.c: Revert.
9155 * arch-utils.c: Revert.
9156 * arc-tdep.c: Revert.
9157 * arc-newlib-tdep.c: Revert.
9158 * annotate.h: Revert.
9159 * annotate.c: Revert.
9160 * amd64-windows-tdep.c: Revert.
9161 * amd64-windows-nat.c: Revert.
9162 * amd64-tdep.c: Revert.
9163 * amd64-sol2-tdep.c: Revert.
9164 * amd64-obsd-tdep.c: Revert.
9165 * amd64-obsd-nat.c: Revert.
9166 * amd64-nbsd-tdep.c: Revert.
9167 * amd64-nbsd-nat.c: Revert.
9168 * amd64-nat.c: Revert.
9169 * amd64-linux-tdep.c: Revert.
9170 * amd64-linux-nat.c: Revert.
9171 * amd64-fbsd-tdep.c: Revert.
9172 * amd64-fbsd-nat.c: Revert.
9173 * amd64-dicos-tdep.c: Revert.
9174 * amd64-darwin-tdep.c: Revert.
9175 * amd64-bsd-nat.c: Revert.
9176 * alpha-tdep.c: Revert.
9177 * alpha-obsd-tdep.c: Revert.
9178 * alpha-nbsd-tdep.c: Revert.
9179 * alpha-mdebug-tdep.c: Revert.
9180 * alpha-linux-tdep.c: Revert.
9181 * alpha-linux-nat.c: Revert.
9182 * alpha-bsd-tdep.c: Revert.
9183 * alpha-bsd-nat.c: Revert.
9184 * aix-thread.c: Revert.
9185 * agent.c: Revert.
9186 * addrmap.c: Revert.
9187 * ada-varobj.c: Revert.
9188 * ada-valprint.c: Revert.
9189 * ada-typeprint.c: Revert.
9190 * ada-tasks.c: Revert.
9191 * ada-lang.c: Revert.
9192 * aarch64-tdep.c: Revert.
9193 * aarch64-ravenscar-thread.c: Revert.
9194 * aarch64-newlib-tdep.c: Revert.
9195 * aarch64-linux-tdep.c: Revert.
9196 * aarch64-linux-nat.c: Revert.
9197 * aarch64-fbsd-tdep.c: Revert.
9198 * aarch64-fbsd-nat.c: Revert.
9199 * aarch32-linux-nat.c: Revert.
9200
d55e5aa6
TT
92012019-04-05 Tom Tromey <tom@tromey.com>
9202
9203 * ft32-tdep.c: Sort headers.
9204 * frv-tdep.c: Sort headers.
9205 * frv-linux-tdep.c: Sort headers.
9206 * frame.c: Sort headers.
9207 * frame-unwind.c: Sort headers.
9208 * frame-base.c: Sort headers.
9209 * fork-child.c: Sort headers.
9210 * findvar.c: Sort headers.
9211 * findcmd.c: Sort headers.
9212 * filesystem.c: Sort headers.
9213 * filename-seen-cache.h: Sort headers.
9214 * filename-seen-cache.c: Sort headers.
9215 * fbsd-tdep.c: Sort headers.
9216 * fbsd-nat.h: Sort headers.
9217 * fbsd-nat.c: Sort headers.
9218 * f-valprint.c: Sort headers.
9219 * f-typeprint.c: Sort headers.
9220 * f-lang.c: Sort headers.
9221 * extension.h: Sort headers.
9222 * extension.c: Sort headers.
9223 * extension-priv.h: Sort headers.
9224 * expprint.c: Sort headers.
9225 * exec.h: Sort headers.
9226 * exec.c: Sort headers.
9227 * exceptions.c: Sort headers.
9228 * event-top.c: Sort headers.
9229 * event-loop.c: Sort headers.
9230 * eval.c: Sort headers.
9231 * elfread.c: Sort headers.
9232 * dwarf2read.h: Sort headers.
9233 * dwarf2read.c: Sort headers.
9234 * dwarf2loc.c: Sort headers.
9235 * dwarf2expr.h: Sort headers.
9236 * dwarf2expr.c: Sort headers.
9237 * dwarf2-frame.c: Sort headers.
9238 * dwarf2-frame-tailcall.c: Sort headers.
9239 * dwarf-index-write.h: Sort headers.
9240 * dwarf-index-write.c: Sort headers.
9241 * dwarf-index-common.c: Sort headers.
9242 * dwarf-index-cache.h: Sort headers.
9243 * dwarf-index-cache.c: Sort headers.
9244 * dummy-frame.c: Sort headers.
9245 * dtrace-probe.c: Sort headers.
9246 * disasm.h: Sort headers.
9247 * disasm.c: Sort headers.
9248 * disasm-selftests.c: Sort headers.
9249 * dictionary.c: Sort headers.
9250 * dicos-tdep.c: Sort headers.
9251 * demangle.c: Sort headers.
9252 * dcache.h: Sort headers.
9253 * dcache.c: Sort headers.
9254 * darwin-nat.h: Sort headers.
9255 * darwin-nat.c: Sort headers.
9256 * darwin-nat-info.c: Sort headers.
9257 * d-valprint.c: Sort headers.
9258 * d-namespace.c: Sort headers.
9259 * d-lang.c: Sort headers.
9260 * ctf.c: Sort headers.
9261 * csky-tdep.c: Sort headers.
9262 * csky-linux-tdep.c: Sort headers.
9263 * cris-tdep.c: Sort headers.
9264 * cris-linux-tdep.c: Sort headers.
9265 * cp-valprint.c: Sort headers.
9266 * cp-support.c: Sort headers.
9267 * cp-namespace.c: Sort headers.
9268 * cp-abi.c: Sort headers.
9269 * corelow.c: Sort headers.
9270 * corefile.c: Sort headers.
9271 * continuations.c: Sort headers.
9272 * completer.h: Sort headers.
9273 * completer.c: Sort headers.
9274 * complaints.c: Sort headers.
9275 * coffread.c: Sort headers.
9276 * coff-pe-read.c: Sort headers.
9277 * cli-out.h: Sort headers.
9278 * cli-out.c: Sort headers.
9279 * charset.c: Sort headers.
9280 * c-varobj.c: Sort headers.
9281 * c-valprint.c: Sort headers.
9282 * c-typeprint.c: Sort headers.
9283 * c-lang.c: Sort headers.
9284 * buildsym.c: Sort headers.
9285 * buildsym-legacy.c: Sort headers.
9286 * build-id.h: Sort headers.
9287 * build-id.c: Sort headers.
9288 * btrace.c: Sort headers.
9289 * bsd-uthread.c: Sort headers.
9290 * breakpoint.h: Sort headers.
9291 * breakpoint.c: Sort headers.
9292 * break-catch-throw.c: Sort headers.
9293 * break-catch-syscall.c: Sort headers.
9294 * break-catch-sig.c: Sort headers.
9295 * blockframe.c: Sort headers.
9296 * block.c: Sort headers.
9297 * bfin-tdep.c: Sort headers.
9298 * bfin-linux-tdep.c: Sort headers.
9299 * bfd-target.c: Sort headers.
9300 * bcache.c: Sort headers.
9301 * ax-general.c: Sort headers.
9302 * ax-gdb.h: Sort headers.
9303 * ax-gdb.c: Sort headers.
9304 * avr-tdep.c: Sort headers.
9305 * auxv.c: Sort headers.
9306 * auto-load.c: Sort headers.
9307 * arm-wince-tdep.c: Sort headers.
9308 * arm-tdep.c: Sort headers.
9309 * arm-symbian-tdep.c: Sort headers.
9310 * arm-pikeos-tdep.c: Sort headers.
9311 * arm-obsd-tdep.c: Sort headers.
9312 * arm-nbsd-tdep.c: Sort headers.
9313 * arm-nbsd-nat.c: Sort headers.
9314 * arm-linux-tdep.c: Sort headers.
9315 * arm-linux-nat.c: Sort headers.
9316 * arm-fbsd-tdep.c: Sort headers.
9317 * arm-fbsd-nat.c: Sort headers.
9318 * arm-bsd-tdep.c: Sort headers.
9319 * arch-utils.c: Sort headers.
9320 * arc-tdep.c: Sort headers.
9321 * arc-newlib-tdep.c: Sort headers.
9322 * annotate.h: Sort headers.
9323 * annotate.c: Sort headers.
9324 * amd64-windows-tdep.c: Sort headers.
9325 * amd64-windows-nat.c: Sort headers.
9326 * amd64-tdep.c: Sort headers.
9327 * amd64-sol2-tdep.c: Sort headers.
9328 * amd64-obsd-tdep.c: Sort headers.
9329 * amd64-obsd-nat.c: Sort headers.
9330 * amd64-nbsd-tdep.c: Sort headers.
9331 * amd64-nbsd-nat.c: Sort headers.
9332 * amd64-nat.c: Sort headers.
9333 * amd64-linux-tdep.c: Sort headers.
9334 * amd64-linux-nat.c: Sort headers.
9335 * amd64-fbsd-tdep.c: Sort headers.
9336 * amd64-fbsd-nat.c: Sort headers.
9337 * amd64-dicos-tdep.c: Sort headers.
9338 * amd64-darwin-tdep.c: Sort headers.
9339 * amd64-bsd-nat.c: Sort headers.
9340 * alpha-tdep.c: Sort headers.
9341 * alpha-obsd-tdep.c: Sort headers.
9342 * alpha-nbsd-tdep.c: Sort headers.
9343 * alpha-mdebug-tdep.c: Sort headers.
9344 * alpha-linux-tdep.c: Sort headers.
9345 * alpha-linux-nat.c: Sort headers.
9346 * alpha-bsd-tdep.c: Sort headers.
9347 * alpha-bsd-nat.c: Sort headers.
9348 * aix-thread.c: Sort headers.
9349 * agent.c: Sort headers.
9350 * addrmap.c: Sort headers.
9351 * ada-varobj.c: Sort headers.
9352 * ada-valprint.c: Sort headers.
9353 * ada-typeprint.c: Sort headers.
9354 * ada-tasks.c: Sort headers.
9355 * ada-lang.c: Sort headers.
9356 * aarch64-tdep.c: Sort headers.
9357 * aarch64-ravenscar-thread.c: Sort headers.
9358 * aarch64-newlib-tdep.c: Sort headers.
9359 * aarch64-linux-tdep.c: Sort headers.
9360 * aarch64-linux-nat.c: Sort headers.
9361 * aarch64-fbsd-tdep.c: Sort headers.
9362 * aarch64-fbsd-nat.c: Sort headers.
9363 * aarch32-linux-nat.c: Sort headers.
9364
699bd4cf
TT
93652019-04-04 Tom Tromey <tom@tromey.com>
9366
9367 * varobj.c (varobj_create): Update.
9368 * rust-exp.y (struct rust_parser) <update_innermost_block,
9369 lookup_symbol>: New methods.
9370 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9371 Rename.
9372 (rust_parser::rust_lookup_type)
9373 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9374 * printcmd.c (display_command, do_one_display): Update.
9375 * parser-defs.h (struct parser_state) <parser_state>: Add
9376 "tracker" parameter.
9377 (block_tracker): New member.
9378 (class innermost_block_tracker) <innermost_block_tracker>: Add
9379 "types" parameter.
9380 <reset>: Remove method.
9381 (innermost_block): Don't declare.
9382 (null_post_parser): Update.
9383 * parse.c (innermost_block): Remove global.
9384 (write_dollar_variable): Update.
9385 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9386 Remove "tracker_types" parameter.
9387 (parse_expression): Add "tracker" parameter.
9388 (parse_expression_for_completion): Update.
9389 (null_post_parser): Add "tracker" parameter.
9390 * p-exp.y: Update rules.
9391 * m2-exp.y: Update rules.
9392 * language.h (struct language_defn) <la_post_parser>: Add
9393 "tracker" parameter.
9394 * go-exp.y: Update rules.
9395 * f-exp.y: Update rules.
9396 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9397 parameter.
9398 * d-exp.y: Update rules.
9399 * c-exp.y: Update rules.
9400 * breakpoint.c (set_breakpoint_condition): Create an
9401 innermost_block_tracker.
9402 (watch_command_1): Likewise.
9403 * ada-lang.c (resolve): Add "tracker" parameter.
9404 (resolve_subexp): Likewise.
9405 * ada-exp.y (write_var_from_sym): Update.
9406
dac43e32
TT
94072019-04-04 Tom Tromey <tom@tromey.com>
9408
9409 * type-stack.h: New file.
9410 * type-stack.c: New file.
9411 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9412 type-stack.h.
9413 (insert_into_type_stack, insert_type, push_type, push_type_int)
9414 (insert_type_address_space, pop_type, pop_type_int)
9415 (pop_typelist, pop_type_stack, append_type_stack)
9416 (push_type_stack, get_type_stack, push_typelist)
9417 (follow_type_instance_flags, follow_types): Don't declare.
9418 * parse.c (type_stack): Remove global.
9419 (parse_exp_in_context): Update.
9420 (insert_into_type_stack, insert_type, push_type, push_type_int)
9421 (insert_type_address_space, pop_type, pop_type_int)
9422 (pop_typelist, pop_type_stack, append_type_stack)
9423 (push_type_stack, get_type_stack, push_typelist)
9424 (follow_type_instance_flags, follow_types): Remove (moved to
9425 type-stack.c).
9426 * f-exp.y (type_stack): New global.
9427 Update rules.
9428 (push_kind_type, f_parse): Update.
9429 * d-exp.y (type_stack): New global.
9430 Update rules.
9431 (d_parse): Update.
9432 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9433 Update rules.
9434 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9435 (HFILES_NO_SRCDIR): Add type-stack.h.
9436
2a612529
TT
94372019-04-04 Tom Tromey <tom@tromey.com>
9438
9439 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9440 (rust_parser::convert_ast_to_expression, rust_parse)
9441 (rust_lex_test_completion, rust_lex_tests): Update.
9442 * parser-defs.h (struct expr_completion_state): New.
9443 (struct parser_state) <parser_state>: Add completion parameter.
9444 <mark_struct_expression, mark_completion_tag>: New methods.
9445 <parse_completion, m_completion_state>: New members.
9446 (prefixify_expression, null_post_parser): Update.
9447 (mark_struct_expression, mark_completion_tag): Don't declare.
9448 * parse.c (parse_completion, expout_last_struct)
9449 (expout_tag_completion_type, expout_completion_name): Remove
9450 globals.
9451 (parser_state::mark_struct_expression)
9452 (parser_state::mark_completion_tag): Now methods.
9453 (prefixify_expression): Add last_struct parameter.
9454 (prefixify_subexp): Likewise.
9455 (parse_exp_1): Update.
9456 (parse_exp_in_context): Add cstate parameter. Update.
9457 (parse_expression_for_completion): Create an
9458 expr_completion_state.
9459 (null_post_parser): Add "completion" parameter.
9460 * p-exp.y: Update rules.
9461 (yylex): Update.
9462 * language.h (struct language_defn) <la_post_parser>: Add
9463 "completing" parameter.
9464 * go-exp.y: Update rules.
9465 (lex_one_token): Update.
9466 * expression.h (parse_completion): Don't declare.
9467 * d-exp.y: Update rules.
9468 (lex_one_token): Update rules.
9469 * c-exp.y: Update rules.
9470 (lex_one_token): Update.
9471 * ada-lang.c (resolve): Add "parse_completion" parameter.
9472 (resolve_subexp): Likewise.
9473 (ada_resolve_function): Likewise.
9474
43476f0b
TT
94752019-04-04 Tom Tromey <tom@tromey.com>
9476
9477 * parser-defs.h (struct parser_state) <start_arglist,
9478 end_arglist>: New methods.
9479 <arglist_len, m_funcall_chain>: New members.
9480 (arglist_len, start_arglist, end_arglist): Don't declare.
9481 * parse.c (arglist_len, funcall_chain): Remove global.
9482 (start_arglist, end_arglist): Remove functions.
9483 (parse_exp_in_context): Update.
9484 * p-exp.y: Update rules.
9485 * m2-exp.y: Update rules.
9486 * go-exp.y: Update rules.
9487 * f-exp.y: Update rules.
9488 * d-exp.y: Update rules.
9489 * c-exp.y: Update rules.
9490
5776fca3
TT
94912019-04-04 Tom Tromey <tom@tromey.com>
9492
9493 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9494 lex_operator, push_back>: New methods.
9495 Update all rules.
9496 (rust_parser::lex_hex, lex_escape): Rename and update.
9497 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9498 (rust_parser::lex_operator): Rename and update.
9499 (rust_parser::lex_number, rustyylex, rustyyerror)
9500 (rust_lex_test_init, rust_lex_test_sequence)
9501 (rust_lex_test_push_back, rust_lex_tests): Update.
9502 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9503 parameter.
9504 <lexptr, prev_lexptr>: New members.
9505 (lexptr, prev_lexptr): Don't declare.
9506 * parse.c (lexptr, prev_lexptr): Remove globals.
9507 (parse_exp_in_context): Update.
9508 * p-exp.y (yylex, yyerror): Update.
9509 * m2-exp.y (parse_number, yylex, yyerror): Update.
9510 * go-exp.y (lex_one_token, yyerror): Update.
9511 * f-exp.y (match_string_literal, yylex, yyerror): Update.
9512 * d-exp.y (lex_one_token, yyerror): Update.
9513 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9514 (lex_one_token, yyerror): Update.
9515 * ada-lex.l (YY_INPUT): Update.
9516 (rewind_to_char): Update.
9517 * ada-exp.y (yyerror): Update.
9518
8621b685
TT
95192019-04-04 Tom Tromey <tom@tromey.com>
9520
9521 * rust-exp.y (rustyylex, rust_lex_tests): Update.
9522 * parser-defs.h (struct parser_state) <parser_state>: Add new
9523 parameter.
9524 <comma_terminates>: New member.
9525 (comma_terminates): Don't declare global.
9526 * parse.c (comma_terminates): Remove global.
9527 (parse_exp_in_context): Update.
9528 * p-exp.y (yylex): Update.
9529 * m2-exp.y (yylex): Update.
9530 * go-exp.y (lex_one_token): Update.
9531 * f-exp.y (yylex): Update.
9532 * d-exp.y (lex_one_token): Update.
9533 * c-exp.y (lex_one_token): Update.
9534 * ada-lex.l: Update.
9535
28aaf3fd
TT
95362019-04-04 Tom Tromey <tom@tromey.com>
9537
9538 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9539 (rustyylex, rust_lex_test_init, rust_lex_test_one)
9540 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9541 * parser-defs.h (paren_depth): Don't declare.
9542 * parse.c (paren_depth): Remove global.
9543 (parse_exp_in_context): Update.
9544 * p-exp.y (paren_depth): New global.
9545 (pascal_parse): Initialize it.
9546 * m2-exp.y (paren_depth): New global.
9547 (m2_parse): Initialize it.
9548 * go-exp.y (paren_depth): New global.
9549 (go_parse): Initialize it.
9550 * f-exp.y (paren_depth): New global.
9551 (f_parse): Initialize it.
9552 * d-exp.y (paren_depth): New global.
9553 (d_parse): Initialize it.
9554 * c-exp.y (paren_depth): New global.
9555 (c_parse): Initialize it.
9556 * ada-lex.l (paren_depth): New global.
9557 (lexer_init): Initialize it.
9558
1e58a4a4
TT
95592019-04-04 Tom Tromey <tom@tromey.com>
9560
9561 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9562 (rust_parser::convert_ast_to_type)
9563 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9564 * parser-defs.h (struct parser_state) <parser_state>: Add
9565 parameters. Initialize new members.
9566 <expression_context_block, expression_context_pc>: New members.
9567 * parse.c (expression_context_block, expression_context_pc):
9568 Remove globals.
9569 (parse_exp_in_context): Update.
9570 * p-exp.y: Update all rules.
9571 (yylex): Update.
9572 * m2-exp.y: Update all rules.
9573 (yylex): Update.
9574 * go-exp.y (yylex): Update.
9575 * f-exp.y (yylex): Update.
9576 * d-exp.y: Update all rules.
9577 (yylex): Update.
9578 * c-exp.y: Update all rules.
9579 (lex_one_token, classify_name, yylex, c_parse): Update.
9580 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9581
37eedb39
TT
95822019-04-04 Tom Tromey <tom@tromey.com>
9583
9584 * gdbarch.h, gdbarch.c: Rebuild.
9585 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9586 * stap-probe.h:
9587 (struct stap_parse_info): Replace "parser_state" with
9588 "expr_builder".
9589 * parser-defs.h (struct expr_builder): Rename from "parser_state".
9590 (parser_state): New class.
9591 * parse.c (expr_builder): Rename.
9592 (expr_builder::release): Rename.
9593 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9594 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9595 (write_exp_elt_longcst, write_exp_elt_floatcst)
9596 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9597 (write_exp_string_vector, write_exp_bitstring)
9598 (write_exp_msymbol, mark_struct_expression)
9599 (write_dollar_variable)
9600 (insert_type_address_space, increase_expout_size): Replace
9601 "parser_state" with "expr_builder".
9602 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9603 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9604 "parser_state" with "expr_builder".
9605
73923d7e
TT
96062019-04-04 Tom Tromey <tom@tromey.com>
9607
9608 * rust-exp.y: Replace "parse_language" with method call.
9609 * p-exp.y:
9610 (yylex): Replace "parse_language" with method call.
9611 * m2-exp.y:
9612 (yylex): Replace "parse_language" with method call.
9613 * go-exp.y (classify_name): Replace "parse_language" with method
9614 call.
9615 * f-exp.y (yylex): Replace "parse_language" with method call.
9616 * d-exp.y (lex_one_token): Replace "parse_language" with method
9617 call.
9618 * c-exp.y:
9619 (lex_one_token, classify_name, yylex): Replace "parse_language"
9620 with method call.
9621 * ada-exp.y (find_primitive_type, type_char)
9622 (type_system_address): Replace "parse_language" with method call.
9623
fa9f5be6
TT
96242019-04-04 Tom Tromey <tom@tromey.com>
9625
9626 * rust-exp.y: Replace "parse_gdbarch" with method call.
9627 * parse.c (write_dollar_variable, insert_type_address_space):
9628 Replace "parse_gdbarch" with method call.
9629 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9630 call.
9631 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9632 call.
9633 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9634 "parse_gdbarch" with method call.
9635 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9636 with method call.
9637 * f-exp.y (parse_type, parse_f_type, yylex): Replace
9638 "parse_gdbarch" with method call.
9639 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9640 "parse_gdbarch" with method call.
9641 * c-exp.y (parse_type, parse_number, classify_name): Replace
9642 "parse_gdbarch" with method call.
9643 * ada-lex.l: Replace "parse_gdbarch" with method call.
9644 * ada-exp.y (parse_type, find_primitive_type, type_char)
9645 (type_system_address): Replace "parse_gdbarch" with method call.
9646
1201a264
TT
96472019-04-04 Tom Tromey <tom@tromey.com>
9648
9649 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9650 * stap-probe.c (stap_parse_argument): Update.
9651 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9652 initial_size parameter.
9653 * rust-exp.y (rust_lex_tests): Update.
9654 * parse.c (parser_state): Update.
9655 (parse_exp_in_context): Update.
9656 * parser-defs.h (struct parser_state) <parser_state>: Remove
9657 "initial_size" parameter.
9658
e3980ce2
TT
96592019-04-04 Tom Tromey <tom@tromey.com>
9660
9661 * parser-defs.h (increase_expout_size): Don't declare.
9662 * parse.c (increase_expout_size): Now static.
9663
e9f8e3f1
TS
96642019-04-04 Thomas Schwinge <thomas@codesourcery.com>
9665
9666 * gnu-nat.c (gnu_nat_target::wait): Fix
9667 target_waitstatus_to_string call.
9668
d7df6549
AB
96692019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9670
9671 * eval.c (evaluate_subexp_standard): Handle internal functions
9672 during Fortran function call handling.
9673
8bdc1658
AB
96742019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9675
9676 * NEWS: Mention new internal functions.
9677 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9678 (read_base_type): Use dwarf2_init_complex_target_type.
9679 * value.c (creal_internal_fn): New function.
9680 (cimag_internal_fn): New function.
9681 (_initialize_values): Register new internal functions.
9682
c29705b7
PW
96832019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9684
9685 * infrun.c (stop_all_threads): If debug_infrun, always
9686 trace the wait status after wait_one, using
9687 target_waitstatus_to_string and target_pid_to_str.
9688 (handle_inferior_event): Replace various trace of
9689 wait status kind by a single trace.
9690 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9691 wait status kind image by target_waitstatus_to_string.
9692 * target/waitstatus.c (target_waitstatus_to_string): Fix
9693 obsolete comment.
9694
05caa1d2
TT
96952019-04-01 Tom Tromey <tromey@adacore.com>
9696
9697 PR symtab/23331:
9698 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9699
9d1447e0
SDJ
97002019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9701 Pedro Alves <palves@redhat.com>
9702
9703 * top.c (quit_force): Call 'finalize_values'.
9704 * value.c (finalize_values): New function.
9705 * value.h (finalize_values): Declare.
9706
7734102d
EZ
97072019-03-30 Eli Zaretskii <eliz@gnu.org>
9708
9709 * NEWS: Announce $_gdb_major and $_gdb_minor.
9710
9711 * top.c (init_gdb_version_vars): New function.
9712 (gdb_init): Call init_gdb_version_vars.
9713
188e1fa9
TT
97142019-03-29 Tom Tromey <tromey@adacore.com>
9715
9716 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9717 help text. Remove dead code.
9718
2880242d
KS
97192019-03-29 Keith Seitz <keiths@redhat.com>
9720
9721 From Siddhesh Poyarekar:
9722 * f-lang.h (f77_get_upperbound): Return LONGEST.
9723 (f77_get_lowerbound): Likewise.
9724 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9725 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9726 print them.
9727 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9728 plongest to format print it.
9729 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9730 (f77_get_upperbound): Likewise.
9731 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9732 LOWER_BOUND to LONGEST.
9733 (f77_create_arrayprint_offset_tbl): Likewise.
9734
cc1defb1
KS
97352019-03-29 Keith Seitz <keiths@redhat.com>
9736
9737 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9738 %s/pulongest for TYPE_LENGTH instead of %d in format
9739 strings.
9740 * ada-typerint.c (ada_print_type): Likewise.
9741 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9742 * compile/compile-c-support.c (generate_register_struct): Likewise.
9743 * gdbtypes.c (recursive_dump_type): Likewise.
9744 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9745 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9746 instead of %d in format strings.
9747 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9748 to std::min to ULONGEST.
9749 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9750 instead of %d in format strings.
9751 * tracepoint.c (info_scope_command): Likewise.
9752 * typeprint.c (print_offset_data::update)
9753 (print_offset_data::finish): Likewise.
9754 * xtensa-tdep.c (xtensa_store_return_value)
9755 (xtensa_push_dummy_call): Likewise.
9756
e432ccf1
JT
97572019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9758
9759 * windows-nat.c (display_selector): Fixed format specifications
9760 for 64-bit Cygwin.
9761
65d2b333
PW
97622019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9763
9764 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9765
f489207e
SL
97662019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9767
9768 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9769 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9770 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9771 (nios2_linux_init_abi): Install it.
9772
bffa1015
AH
97732019-03-28 Alan Hayward <alan.hayward@arm.com>
9774
9775 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9776
fc96163a
AH
97772019-03-28 Alan Hayward <alan.hayward@arm.com>
9778
9779 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9780
20dc7e9b
PW
97812019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9782 Tom Tromey <tromey@adacore.com>
9783
9784 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9785
7f5331a8
JB
97862019-03-26 Joel Brobecker <brobecker@adacore.com>
9787
9788 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9789 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9790 method to compute the bounds of range types. Also print "[evaluated]"
9791 if the bounds' values come from a dynamic evaluation.
9792
18c77628
AB
97932019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9794
9795 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9796 whitespace when pretty printing is on.
9797
53c973f2
AH
97982019-03-26 Alan Hayward <alan.hayward@arm.com>
9799
e79be6e5 9800 * ppc-linux-nat.c: Add include.
53c973f2 9801
d851aa71
AH
98022019-03-26 Alan Hayward <alan.hayward@arm.com>
9803
e79be6e5 9804 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 9805
2fe7bab7
AH
98062019-03-26 Alan Hayward <alan.hayward@arm.com>
9807
e79be6e5 9808 * arm-linux-nat.c: Add include.
2fe7bab7 9809
068ef30e
SM
98102019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9811
9812 * source-cache.c (source_cache::get_source_lines): Re-read
9813 fullname after calling open_source_file.
9814
81a24d04
JB
98152019-03-25 John Baldwin <jhb@FreeBSD.org>
9816
9817 * NEWS: Mention TLS support for FreeBSD.
9818
79e7ae11
TT
98192019-03-25 Tom Tromey <tromey@adacore.com>
9820
9821 * minsyms.c (BUNCH_SIZE): Update comment.
9822 (~minimal_symbol_reader): Remove old comment.
9823 (compact_minimal_symbols): Update comment.
9824 (minimal_symbol_reader::install): Remove old comment. Update
9825 other comments.
9826
d45963c2
AH
98272019-03-25 Alan Hayward <alan.hayward@arm.com>
9828
9829 * s390-linux-nat.c: Add include.
9830
0f83012e
AH
98312019-03-25 Alan Hayward <alan.hayward@arm.com>
9832
9833 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9834 Call linux_get_hwcap.
9835 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9836 Likewise.
9837 (aarch64_linux_get_hwcap): Remove function.
9838 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9839 declaration.
9840 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9841 linux_get_hwcap.
9842 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9843 * linux-tdep.c (linux_get_hwcap): Add function.
9844 (linux_get_hwcap2): Likewise.
9845 * linux-tdep.h (linux_get_hwcap): Add declaration.
9846 (linux_get_hwcap2): Likewise.
9847 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9848 (ppc_linux_get_hwcap2): Likewise.
9849 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9850 linux_get_hwcap.
9851 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9852 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9853 (ppc_linux_nat_target::read_description): Likewise.
9854 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9855 * s390-linux-nat.c: Likewise.
9856 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9857
6640a367
TT
98582019-03-24 Tom Tromey <tom@tromey.com>
9859
9860 * ada-lang.c (standard_lookup): Simplify initialization.
9861 (ada_lookup_symbol_nonlocal): Simplify return.
9862 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9863 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9864 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9865 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9866 initialization.
9867 * solib.c (solib_global_lookup): Simplify.
9868 * symtab.c (null_block_symbol): Remove.
9869 (symbol_cache_lookup): Simplify returns.
9870 (lookup_language_this): Simplify returns.
9871 (lookup_symbol_aux): Simplify return.
9872 (lookup_local_symbol): Simplify returns.
9873 (lookup_global_symbol_from_objfile): Simplify return.
9874 (lookup_symbol_in_objfile_symtabs)
9875 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9876 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9877 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9878 * cp-namespace.c (cp_lookup_bare_symbol)
9879 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9880 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9881 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9882 (cp_lookup_symbol_via_imports): Simplify initialization.
9883 (find_symbol_in_baseclass): Likewise.
9884 * symtab.h (null_block_symbol): Remove.
9885 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9886 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9887 (d_lookup_symbol_module): Likewise.
9888 (find_symbol_in_baseclass): Simplify initialization.
9889
a930ebcd
TT
98902019-03-24 Tom Tromey <tom@tromey.com>
9891
9892 * expression.h: Don't include symtab.h.
9893 (struct block): Forward declare.
9894
582942f4
TT
98952019-03-24 Tom Tromey <tom@tromey.com>
9896
9897 * c-exp.y (typebase): Remove casts.
9898 * gdbtypes.c (lookup_unsigned_typename, )
9899 (lookup_signed_typename): Remove cast.
9900 * eval.c (parse_to_comma_and_eval): Remove cast.
9901 * parse.c (write_dollar_variable): Remove cast.
9902 * block.h (struct block) <superblock>: Now const.
9903 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9904 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9905 (map_block): Make "block" const.
9906 * symfile.h (struct quick_symbol_functions)
9907 <map_matching_symbols>: Constify block argument to "callback".
9908 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9909 const.
9910 (find_pc_sect_compunit_symtab): Make "b" const.
9911 (find_symbol_at_address): Likewise.
9912 (search_symbols): Likewise.
9913 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9914 (dw2_debug_names_lookup_symbol): Likewise.
9915 (dw2_map_matching_symbols): Update.
9916 * p-valprint.c (pascal_val_print): Remove "block".
9917 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9918 (aux_add_nonlocal_symbols): Make "block" const.
9919 (resolve_subexp): Remove cast.
9920 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9921 const.
9922 (iterate_over_file_blocks): Likewise.
9923 * f-exp.y (%union) <bval>: Remove.
9924 * coffread.c (patch_opaque_types): Make "b" const.
9925 * spu-tdep.c (spu_catch_start): Make "block" const.
9926 * c-valprint.c (print_unpacked_pointer): Remove "block".
9927 * symmisc.c (dump_symtab_1): Make "b" const.
9928 (block_depth): Make "block" const.
9929 * d-exp.y (%union) <bval>: Remove.
9930 * cp-support.h (cp_lookup_rtti_type): Update.
9931 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9932 * psymtab.c (psym_lookup_symbol): Make "block" const.
9933 (maintenance_check_psymtabs): Make "b" const.
9934 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9935 (enumerate_locals, enumerate_args): Update.
9936 * python/py-symtab.c (stpy_global_block): Make "block" const.
9937 (stpy_static_block): Likewise.
9938 * inline-frame.c (block_starting_point_at): Make "new_block"
9939 const.
9940 * block.c (find_block_in_blockvector): Make return type const.
9941 (blockvector_for_pc_sect): Make "b" const.
9942 (find_block_in_blockvector): Make "b" const.
9943
7ad417dd
TT
99442019-03-23 Tom Tromey <tom@tromey.com>
9945
9946 * varobj.c (varobj_create): Update.
9947 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9948 * printcmd.c (display_command, do_one_display): Don't reset
9949 innermost_block.
9950 * parser-defs.h (enum innermost_block_tracker_type): Move to
9951 expression.h.
9952 (innermost_block): Update comment.
9953 * parse.c (parse_exp_1): Add tracker_types parameter.
9954 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9955 tracker_types parameter. Reset innermost_block.
9956 (parse_exp_in_context): Remove.
9957 (parse_expression_for_completion): Update.
9958 * objfiles.c (~objfile): Don't reset expression_context_block or
9959 innermost_block.
9960 * expression.h (enum innermost_block_tracker_type): Move from
9961 parser-defs.h.
9962 (parse_exp_1): Add tracker_types parameter.
9963 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9964 reset innermost_block.
9965
b366c208
TT
99662019-03-23 Tom Tromey <tom@tromey.com>
9967
9968 * objfiles.h: Include bcache.h.
9969
9bb9b2f9
TT
99702019-03-23 Tom Tromey <tom@tromey.com>
9971
9972 * linespec.c (get_current_search_block): Use
9973 scoped_restore_current_language.
9974 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9975
59c28372
AH
99762019-03-22 Alan Hayward <alan.hayward@arm.com>
9977 Jiong Wang <jiong.wang@arm.com>
9978
9979 * aarch64-linux-tdep.c
9980 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9981 section.
9982 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9983
17e116a7
AH
99842019-03-22 Alan Hayward <alan.hayward@arm.com>
9985 Jiong Wang <jiong.wang@arm.com>
9986
9987 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9988 instructions.
9989 (aarch64_analyze_prologue_test): Add PACIASP test.
9990 (aarch64_prologue_prev_register): Unmask PC value.
9991
11e1b75f
AH
99922019-03-22 Alan Hayward <alan.hayward@arm.com>
9993 Jiong Wang <jiong.wang@arm.com>
9994
9995 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9996 (aarch64_dwarf2_prev_register): Unmask PC value.
9997 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9998 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9999 DW_CFA_AARCH64_negate_ra_state.
10000 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10001
34dcc7cf
AH
100022019-03-22 Alan Hayward <alan.hayward@arm.com>
10003 Jiong Wang <jiong.wang@arm.com>
10004
10005 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10006 registers.
10007 (aarch64_pseudo_register_name): Likewise.
10008 (aarch64_pseudo_register_type): Likewise.
10009 (aarch64_pseudo_register_reggroup_p): Likewise.
10010 (aarch64_gdbarch_init): Add pauth registers.
10011 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10012 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10013 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10014 (struct gdbarch_tdep): Add regnum for ra_state.
10015
1ef53e6b
AH
100162019-03-22 Alan Hayward <alan.hayward@arm.com>
10017 Jiong Wang <jiong.wang@arm.com>
10018
10019 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10020
76bed0fd
AH
100212019-03-22 Alan Hayward <alan.hayward@arm.com>
10022 Jiong Wang <jiong.wang@arm.com>
10023
10024 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10025 function.
10026 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10027 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10028 (aarch64_gdbarch_init): Add puth registers.
10029 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10030 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10031 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10032
ee4fbcfa
AH
100332019-03-22 Alan Hayward <alan.hayward@arm.com>
10034 Jiong Wang <jiong.wang@arm.com>
10035
10036 * aarch64-linux-nat.c
10037 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10038 * aarch64-linux-tdep.c
10039 (aarch64_linux_core_read_description): Likewise.
10040 (aarch64_linux_get_hwcap): New function.
10041 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10042 (aarch64_linux_get_hwcap): New declaration.
10043
6dc0ebde
AH
100442019-03-22 Alan Hayward <alan.hayward@arm.com>
10045 Jiong Wang <jiong.wang@arm.com>
10046
10047 * aarch64-linux-nat.c
10048 (aarch64_linux_nat_target::read_description): Add pauth param.
10049 * aarch64-linux-tdep.c
10050 (aarch64_linux_core_read_description): Likewise.
10051 * aarch64-tdep.c (struct target_desc): Add in pauth.
10052 (aarch64_read_description): Add pauth param.
10053 (aarch64_gdbarch_init): Likewise.
10054 * aarch64-tdep.h (aarch64_read_description): Likewise.
10055 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10056 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10057 * features/Makefile: Add new files.
10058 * features/aarch64-pauth.c: New file.
10059 * features/aarch64-pauth.xml: New file.
10060
595915c1
TT
100612019-03-20 Tom Tromey <tromey@adacore.com>
10062
10063 * infrun.c (handle_inferior_event): Rename from
10064 handle_inferior_event_1. Create a scoped_value_mark.
10065 (handle_inferior_event): Remove.
10066
4c7d57e7
TT
100672019-03-19 Tom Tromey <tromey@adacore.com>
10068
10069 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10070 * infrun.h (print_stop_event): Add "displays" parameter.
10071 * infrun.c (print_stop_event): Add "displays" parameter.
10072
cb246234
PA
100732019-03-19 Pedro Alves <palves@redhat.com>
10074
10075 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10076 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10077 to -1. Fix TABs vs spaces.
10078 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10079 * tui/tui-out.h (tui_ui_out) Add intro comments.
10080 <m_line, m_start_of_line>: In-class initialize, and add describing
10081 comment.
10082
3a0e45b2
AH
100832019-03-18 Alan Hayward <alan.hayward@arm.com>
10084
10085 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10086 variable names.
10087 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10088
5371b850
PA
100892019-03-18 Pedro Alves <palves@redhat.com>
10090 Eli Zaretskii <eliz@gnu.org>
10091
10092 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10093 m_line and m_start_of_line.
10094
b17c4cd0
EZ
100952019-03-18 Eli Zaretskii <eliz@gnu.org>
10096
10097 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10098 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10099 it returns a newline. This fixes a regression in TU mode, whereby
10100 the next line is output on the same screen line as the user input.
10101
4bd56d18
TT
101022019-03-18 Tom Tromey <tromey@adacore.com>
10103
10104 * minsyms.c (minimal_symbol_reader::install): Remove call to
10105 obstack_blank.
10106
55c10aca
PA
101072019-03-18 Pedro Alves <palves@redhat.com>
10108
10109 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10110 New globals.
10111 (apply_style): New, factored out from ...
10112 (apply_ansi_escape): ... this. Handle reverse video mode.
10113 (tui_set_reverse_mode): New function.
10114 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10115 * tui/tui-winsource.c (tui_show_source_line): Use
10116 tui_set_reverse_mode instead of setting A_STANDOUT.
10117 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10118 New setter methods.
10119
647bb750
HD
101202019-03-18 Hannes Domani <ssbssa@yahoo.de>
10121
10122 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10123 Handle tabs.
10124
bff8c71f
TT
101252019-03-18 Tom Tromey <tromey@adacore.com>
10126
10127 * ada-lang.c (empty_array): Add "high" parameter.
10128 (ada_evaluate_subexp): Update.
10129
58785d98
ST
101302019-03-17 Sergei Trofimovich <siarheit@google.com>
10131
10132 * unittests/string_view-selftests.c: Define
10133 _initialize_string_view_selftests unconditionally.
10134
d4cbef22
ВМ
101352019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10136
10137 PR gdb/24350
10138 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10139
fce4c071
ВМ
101402019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10141
10142 PR gdb/24351
10143 * windows-nat.c (display_selector): Fix format specifiers.
10144
f7f0a123
EZ
101452019-03-17 Eli Zaretskii <eliz@gnu.org>
10146
10147 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10148 tui_refill_source_window instead of tui_refresh_win, to update the
10149 current execution line. This fixes redisplay of the current line
10150 when stepping through the code with "next" or "step".
10151
ab42892f
EZ
101522019-03-16 Eli Zaretskii <eliz@gnu.org>
10153
10154 * source-cache.c (source_cache::get_source_lines): Call
10155 find_source_lines to initialize s->nlines. This fixes vertical
10156 scrolling of TUI source window when the DOWN arrow is pressed.
10157
8d8c087f
PW
101582019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10159
10160 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10161 linux-thread-db.c (_initialize_thread_db): Likewise.
10162
798e1c30
EZ
101632019-03-16 Eli Zaretskii <eliz@gnu.org>
10164
10165 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10166 wclrtoeol in tui_show_source_line". This reverts changes made in
10167 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10168
eefba3da
TT
101692019-03-15 Tom Tromey <tom@tromey.com>
10170
10171 * symtab.h (struct minimal_symbol): Derive from
10172 general_symbol_info.
10173 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10174 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10175 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10176 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10177 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10178 (MSYMBOL_SEARCH_NAME): Update.
10179 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10180 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10181 * minsyms.c (minimal_symbol_reader::record_full): Update.
10182
0de2420c
TT
101832019-03-15 Tom Tromey <tom@tromey.com>
10184
10185 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10186
042d75e4
TT
101872019-03-15 Tom Tromey <tom@tromey.com>
10188
10189 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10190 unique_xmalloc_ptr.
10191 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10192 Update.
10193 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10194 (build_minimal_symbol_hash_tables)
10195 (minimal_symbol_reader::install): Update.
10196
db92718b
TT
101972019-03-15 Tom Tromey <tom@tromey.com>
10198
10199 * symtab.c (create_demangled_names_hash): Update.
10200 (symbol_set_names): Update.
10201 * objfiles.h (struct objfile_per_bfd_storage)
10202 <demangled_names_hash>: Now an htab_up.
10203 * objfiles.c (objfile_per_bfd_storage): Simplify.
10204
d6797f46
TT
102052019-03-15 Tom Tromey <tom@tromey.com>
10206
10207 * objfiles.h (struct objfile_per_bfd_storage): Declare
10208 destructor.
10209 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10210 New.
10211 (get_objfile_bfd_data): Use new. Don't initialize
10212 language_of_main.
10213 (free_objfile_per_bfd_storage): Remove.
10214 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10215
741d7538
TT
102162019-03-15 Tom Tromey <tom@tromey.com>
10217
10218 * symfile.c (reread_symbols): Update.
10219 * objfiles.c (objfile::objfile): Update.
10220 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10221 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10222 comment.
10223 (minimal_symbol_reader::install): Update.
10224 (terminate_minimal_symbol_table): Remove.
10225 * jit.c (jit_object_close_impl): Update.
10226
788c80d1
TT
102272019-03-15 Tom Tromey <tom@tromey.com>
10228
10229 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10230 initializations.
10231
1b7a07cb
TT
102322019-03-15 Tom Tromey <tom@tromey.com>
10233
10234 * objfiles.h (struct objfile_per_bfd_storage)
10235 <demangled_hash_languages>: Now a bitset.
10236 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10237 (lookup_minimal_symbol): Update.
10238
3db066bc
TT
102392019-03-15 Tom Tromey <tom@tromey.com>
10240
10241 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10242 Don't return the symbol.
10243 * coffread.c (record_minimal_symbol): Use record_full.
10244
3fff2c37
EZ
102452019-03-14 Eli Zaretskii <eliz@gnu.org>
10246
10247 The MS-Windows port of ncurses fails to switch to a color pair if
10248 one or both of the colors are the implicit default colors. This
10249 change records the default colors when TUI is initialized, and
10250 then specifies them explicitly when a color pair uses the default
10251 colors. This allows color styling in TUI mode on MS-Windows.
10252
10253 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10254 ncurses_norm_attr.
10255 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10256 colors in ncurses_norm_attr.
10257 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10258 "none", replace it with the default color recorded in
10259 ncurses_norm_attr.
10260
3b336828
TT
102612019-03-14 Tom Tromey <tromey@adacore.com>
10262
10263 * source-cache.h (class source_cache) <get_source_lines>: Return
10264 std::string.
10265 * source-cache.c (source_cache::extract_lines): Handle case where
10266 first_pos==npos. Return std::string.
10267 (source_cache::get_source_lines): Update.
10268
d085f989
TT
102692019-03-14 Tom Tromey <tromey@adacore.com>
10270
10271 * NEWS: Add item for "style sources" commands.
10272 * source-cache.c (source_cache::get_source_lines): Check
10273 source_styling.
10274 * cli/cli-style.c (source_styling): New global.
10275 (_initialize_cli_style): Add "style sources" commands.
10276 (show_style_sources): New function.
10277 * cli/cli-style.h (source_styling): Declare.
10278
6f11e682
TT
102792019-03-14 Pedro Alves <palves@redhat.com>
10280 Tom Tromey <tromey@adacore.com>
10281
10282 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10283 * tui/tui-winsource.c (tui_refill_source_window): New function,
10284 from...
10285 (tui_horizontal_source_scroll): ... here. Move some logic.
10286 * cli/cli-style.c (set_style_enabled): Notify new observable.
10287 * tui/tui-hooks.c (tui_redisplay_source): New function.
10288 (tui_attach_detach_observers): Attach or detach
10289 tui_redisplay_source.
10290 * observable.h (source_styling_changed): New observable.
10291 * observable.c: Define source_styling_changed observable.
10292
a068643d
TT
102932019-03-13 Tom Tromey <tromey@adacore.com>
10294
10295 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10296 (i386_gnu_nat_target::store_registers): Update.
10297 * target-debug.h (target_debug_print_std_string): New macro.
10298 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10299 * windows-tdep.c (display_one_tib): Update.
10300 * tui/tui-stack.c (tui_make_status_line): Update.
10301 * top.c (print_inferior_quit_action): Update.
10302 * thread.c (thr_try_catch_cmd): Update.
10303 (add_thread_with_info): Update.
10304 (thread_target_id_str): Update.
10305 (thr_try_catch_cmd): Update.
10306 (thread_command): Update.
10307 (thread_find_command): Update.
10308 * record-btrace.c (record_btrace_target::info_record)
10309 (record_btrace_resume_thread, record_btrace_target::resume)
10310 (record_btrace_cancel_resume, record_btrace_step_thread)
10311 (record_btrace_target::wait, record_btrace_target::wait)
10312 (record_btrace_target::wait, record_btrace_target::stop): Update.
10313 * progspace.c (print_program_space): Update.
10314 * process-stratum-target.c
10315 (process_stratum_target::thread_address_space): Update.
10316 * linux-fork.c (linux_fork_mourn_inferior)
10317 (detach_checkpoint_command, info_checkpoints_command)
10318 (linux_fork_context): Update.
10319 (linux_fork_detach): Update.
10320 (class scoped_switch_fork_info): Update.
10321 (delete_checkpoint_command): Update.
10322 * infrun.c (follow_fork_inferior): Update.
10323 (follow_fork_inferior): Update.
10324 (proceed_after_vfork_done): Update.
10325 (handle_vfork_child_exec_or_exit): Update.
10326 (follow_exec): Update.
10327 (displaced_step_prepare_throw): Update.
10328 (displaced_step_restore): Update.
10329 (start_step_over): Update.
10330 (resume_1): Update.
10331 (clear_proceed_status_thread): Update.
10332 (proceed): Update.
10333 (print_target_wait_results): Update.
10334 (do_target_wait): Update.
10335 (context_switch): Update.
10336 (stop_all_threads): Update.
10337 (restart_threads): Update.
10338 (finish_step_over): Update.
10339 (handle_signal_stop): Update.
10340 (switch_back_to_stepped_thread): Update.
10341 (keep_going_pass_signal): Update.
10342 (print_exited_reason): Update.
10343 (normal_stop): Update.
10344 * inferior.c (inferior_pid_to_str): Change return type.
10345 (print_selected_inferior): Update.
10346 (add_inferior): Update.
10347 (detach_inferior): Update.
10348 * dummy-frame.c (fprint_dummy_frames): Update.
10349 * dcache.c (dcache_info_1): Update.
10350 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10351 (btrace_fetch, btrace_clear): Update.
10352 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10353 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10354 type.
10355 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10356 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10357 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10358 * gdbarch.c, gdbarch.h: Rebuild.
10359 * gdbarch.sh (core_pid_to_str): Change return type.
10360 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10361 return type.
10362 (windows_nat_target::pid_to_str): Change return type.
10363 (windows_delete_thread): Update.
10364 (windows_nat_target::attach): Update.
10365 (windows_nat_target::files_info): Update.
10366 * target-delegates.c: Rebuild.
10367 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10368 return type.
10369 (sol_thread_target::pid_to_str): Change return type.
10370 * remote.c (class remote_target) <pid_to_str>: Change return
10371 type.
10372 (remote_target::pid_to_str): Change return type.
10373 (extended_remote_target::attach, remote_target::remote_stop_ns)
10374 (remote_target::remote_notif_remove_queued_reply)
10375 (remote_target::push_stop_reply, remote_target::disable_btrace):
10376 Update.
10377 (extended_remote_target::attach): Update.
10378 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10379 type.
10380 (gdbsim_target::pid_to_str): Change return type.
10381 * ravenscar-thread.c (struct ravenscar_thread_target)
10382 <pid_to_str>: Change return type.
10383 (ravenscar_thread_target::pid_to_str): Change return type.
10384 * procfs.c (class procfs_target) <pid_to_str>: Change return
10385 type.
10386 (procfs_target::pid_to_str): Change return type.
10387 (procfs_target::attach): Update.
10388 (procfs_target::detach): Update.
10389 (procfs_target::fetch_registers): Update.
10390 (procfs_target::store_registers): Update.
10391 (procfs_target::wait): Update.
10392 (procfs_target::files_info): Update.
10393 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10394 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10395 return type.
10396 (nto_procfs_target::pid_to_str): Change return type.
10397 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10398 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10399 return type.
10400 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10401 (exit_lwp): Update.
10402 (attach_proc_task_lwp_callback, get_detach_signal)
10403 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10404 (linux_nat_target::resume, wait_lwp, stop_callback)
10405 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10406 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10407 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10408 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10409 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10410 type.
10411 (inf_ptrace_target::attach): Update.
10412 (inf_ptrace_target::files_info): Update.
10413 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10414 type.
10415 (go32_nat_target::pid_to_str): Change return type.
10416 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10417 (gnu_nat_target::wait): Update.
10418 (gnu_nat_target::wait): Update.
10419 (gnu_nat_target::resume): Update.
10420 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10421 (fbsd_nat_target::wait): Update.
10422 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10423 type.
10424 (darwin_nat_target::attach): Update.
10425 * corelow.c (class core_target) <pid_to_str>: Change return type.
10426 (core_target::pid_to_str): Change return type.
10427 * target.c (normal_pid_to_str): Change return type.
10428 (default_pid_to_str): Likewise.
10429 (target_pid_to_str): Change return type.
10430 (target_translate_tls_address): Update.
10431 (target_announce_detach): Update.
10432 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10433 return type.
10434 (bsd_uthread_target::pid_to_str): Change return type.
10435 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10436 type.
10437 (bsd_kvm_target::pid_to_str): Change return type.
10438 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10439 return type.
10440 (aix_thread_target::pid_to_str): Change return type.
10441 * target.h (struct target_ops) <pid_to_str>: Change return type.
10442 (target_pid_to_str, normal_pid_to_str): Likewise.
10443 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10444 type.
10445 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10446 type.
10447 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10448 return type.
10449 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10450 type.
10451 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10452 type.
10453 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10454 return type.
10455
b4be1b06
SM
104562019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10457
10458 * NEWS: Mention that the new default MI version is 3. Mention
10459 changes to the output of commands and events that deal with
10460 multi-location breakpoints.
10461 * breakpoint.c: Include "mi/mi-out.h".
10462 (print_one_breakpoint): Change output syntax if using MI version
10463 >= 3.
10464 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10465 New.
10466 (mi_multi_location_breakpoint_output_fixed): New.
10467 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10468 (mi_cmd_fix_multi_location_breakpoint_output): New.
10469 (mi_multi_location_breakpoint_output_fixed): New.
10470 * mi/mi-cmds.c (mi_cmds): Register command
10471 -fix-multi-location-breakpoint-output.
10472 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10473 interpreter "mi".
10474
8e5e5494
SM
104752019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10476
10477 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10478 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10479 instantiate mi_ui_out based on interpreter name.
10480 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10481 * mi/mi-main.c (mi_load_progress): Likewise.
10482
197df35e
JB
104832019-03-12 John Baldwin <jhb@FreeBSD.org>
10484
10485 * NEWS: Combine separate "New targets" sections for 8.3.
10486
8399425f
JB
104872019-03-12 John Baldwin <jhb@FreeBSD.org>
10488
10489 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10490 (ppcfbsd_init_abi): Install gdbarch
10491 "fetch_tls_load_module_address" and "get_thread_local_address"
10492 methods.
10493
b0f87ed0
JB
104942019-03-12 John Baldwin <jhb@FreeBSD.org>
10495
10496 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10497 (riscv_fbsd_init_abi): Install gdbarch
10498 "fetch_tls_load_module_address" and "get_thread_local_address"
10499 methods.
10500
ce25aa57
JB
105012019-03-12 John Baldwin <jhb@FreeBSD.org>
10502
10503 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10504 (i386fbsd_init_abi): Install gdbarch
10505 "fetch_tls_load_module_address" and "get_thread_local_address"
10506 methods.
10507
f5424cfa
JB
105082019-03-12 John Baldwin <jhb@FreeBSD.org>
10509
10510 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10511 (amd64fbsd_init_abi): Install gdbarch
10512 "fetch_tls_load_module_address" and "get_thread_local_address"
10513 methods.
10514
945f3901
JB
105152019-03-12 John Baldwin <jhb@FreeBSD.org>
10516
10517 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10518 (struct fbsd_pspace_data): New type.
10519 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10520 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10521 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10522 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10523 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10524
ef0bd204
JB
105252019-03-12 John Baldwin <jhb@FreeBSD.org>
10526
10527 * gdbtypes.c (lookup_struct_elt): New function.
10528 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10529 * gdbtypes.h (struct struct_elt): New type.
10530 (lookup_struct_elt): New prototype.
10531
36c53a02
JB
105322019-03-12 John Baldwin <jhb@FreeBSD.org>
10533
10534 * gdbtypes.c (lookup_struct_elt_type): Update comment and
10535 remove disabled code block.
10536
6e056c81
JB
105372019-03-12 John Baldwin <jhb@FreeBSD.org>
10538
10539 * gdbarch.sh (get_thread_local_address): New method.
10540 * gdbarch.h, gdbarch.c: Regenerate.
10541 * target.c (target_translate_tls_address): Use
10542 gdbarch_get_thread_local_address if present instead of
10543 target::get_thread_local_address.
10544
cd250a18
JB
105452019-03-12 John Baldwin <jhb@FreeBSD.org>
10546
10547 * target.h (target::get_thread_local_address): Update comment.
10548
df22c1e5
JB
105492019-03-12 John Baldwin <jhb@FreeBSD.org>
10550
10551 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10552 objfile->separate_debug_objfile_backlink if not NULL.
10553
dd6876c9
JB
105542019-03-12 John Baldwin <jhb@FreeBSD.org>
10555
10556 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10557 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10558 (amd64bsd_store_inferior_registers): Likewise.
10559 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10560 Enable segment base registers.
10561 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10562 PT_GETFSBASE and PT_GETGSBASE.
10563 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10564 PT_SETGSBASE.
10565 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10566 segment base registers.
10567 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10568
1163a4b7
JB
105692019-03-12 John Baldwin <jhb@FreeBSD.org>
10570
10571 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10572 Update calls to i386_target_description to add 'segments'
10573 parameter.
10574 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
10575 add segment base registers.
10576 * arch/i386.c (i386_create_target_description): Add 'segments'
10577 parameter to enable segment base registers.
10578 * arch/i386.h (i386_create_target_description): Likewise.
10579 * features/i386/32bit-segments.xml: New file.
10580 * features/i386/32bit-segments.c: Generate.
10581 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10582 call to i386_target_description to add 'segments' parameter.
10583 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10584 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10585 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10586 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10587 if feature is present.
10588 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10589 Add 'segments' parameter to call to i386_target_description.
10590 (i386_target_description): Add 'segments' parameter to enable
10591 segment base registers.
10592 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10593 to call to i386_target_description.
10594 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10595 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10596 Define I386_NUM_REGS.
10597 (i386_target_description): Add 'segments' parameter to enable
10598 segment base registers.
10599
3a350822
EZ
106002019-03-12 Eli Zaretskii <eliz@gnu.org>
10601
10602 PR/24325
10603 * source-cache.c: #undef open and close, to avoid unresolved
10604 externals during linking.
10605
ffdd69cf
TT
106062019-03-12 Tom Tromey <tromey@adacore.com>
10607
10608 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10609 const. Add initializers.
10610 (_initialize_remote): Don't initialize ptid globals.
10611
ec148c57
PA
106122019-03-12 Pedro Alves <palves@redhat.com>
10613
10614 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10615
32764270
PA
106162019-03-12 Pedro Alves <palves@redhat.com>
10617
10618 * cp-name-parser.y (main): Remove unused 'len' variable.
10619
17547186
TT
106202019-03-12 Tom Tromey <tromey@adacore.com>
10621
10622 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10623 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10624
d3a70e03
TT
106252019-03-12 Tom Tromey <tromey@adacore.com>
10626
10627 * linux-nat.c (iterate_over_lwps): Update.
10628 (stop_callback): Remove parameter.
10629 (stop_wait_callback, detach_callback, resume_set_callback)
10630 (select_singlestep_lwp_callback, set_ignore_sigint)
10631 (status_callback, resumed_callback, resume_clear_callback)
10632 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10633 data parameter.
10634 (linux_nat_target::detach, linux_nat_target::resume)
10635 (linux_stop_and_wait_all_lwps, select_event_lwp)
10636 (linux_nat_filter_event, linux_nat_wait_1)
10637 (linux_nat_target::kill, linux_nat_target::stop)
10638 (linux_nat_target::stop): Update.
10639 (linux_nat_resume_callback): Change type.
10640 (resume_stopped_resumed_lwps, count_events_callback)
10641 (select_event_lwp_callback): Likewise.
10642 (linux_stop_lwp, linux_nat_stop_lwp): Update.
10643 * arm-linux-nat.c (struct update_registers_data): Remove.
10644 (update_registers_callback): Change type.
10645 (arm_linux_insert_hw_breakpoint1): Update.
10646 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10647 parameter.
10648 (x86_linux_dr_set_addr): Update.
10649 (x86_linux_dr_set_control): Update.
10650 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10651 (iterate_over_lwps): Use gdb::function_view.
10652 * nat/aarch64-linux-hw-point.c (struct
10653 aarch64_dr_update_callback_param): Remove.
10654 (debug_reg_change_callback): Change type.
10655 (aarch64_notify_debug_reg_change): Update.
10656 * s390-linux-nat.c (s390_refresh_per_info): Update.
10657
82cb27ff
TT
106582019-03-11 Tom Tromey <tromey@adacore.com>
10659
10660 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10661 redundant assignment to "this_cu".
10662
568c0683
SM
106632019-03-08 Simon Marchi <simon.marchi@efficios.com>
10664
10665 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10666
f09ce22d
SM
106672019-03-08 Simon Marchi <simon.marchi@efficios.com>
10668
10669 * gdbtypes.c (rank_one_type_parm_set): New function extracted
10670 from...
10671 (rank_one_type): ... this.
10672
595f96a9
SM
106732019-03-08 Simon Marchi <simon.marchi@efficios.com>
10674
10675 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10676 from...
10677 (rank_one_type): ... this.
10678
2598a94b
SM
106792019-03-08 Simon Marchi <simon.marchi@efficios.com>
10680
10681 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10682 from...
10683 (rank_one_type): ... this.
10684
7f17b20d
SM
106852019-03-08 Simon Marchi <simon.marchi@efficios.com>
10686
10687 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10688 from...
10689 (rank_one_type): ... this.
10690
2c509035
SM
106912019-03-08 Simon Marchi <simon.marchi@efficios.com>
10692
10693 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10694 from...
10695 (rank_one_type): ... this.
10696
0dd322dc
SM
106972019-03-08 Simon Marchi <simon.marchi@efficios.com>
10698
10699 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10700 from...
10701 (rank_one_type): ... this.
10702
41ea4728
SM
107032019-03-08 Simon Marchi <simon.marchi@efficios.com>
10704
10705 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10706 from...
10707 (rank_one_type): ... this.
10708
793cd1d2
SM
107092019-03-08 Simon Marchi <simon.marchi@efficios.com>
10710
10711 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10712 from...
10713 (rank_one_type): ... this.
10714
34910087
SM
107152019-03-08 Simon Marchi <simon.marchi@efficios.com>
10716
10717 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10718 from...
10719 (rank_one_type): ... this.
10720
f1f832d6
SM
107212019-03-08 Simon Marchi <simon.marchi@efficios.com>
10722
10723 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10724 from...
10725 (rank_one_type): ... this.
10726
b9f4512f
SM
107272019-03-08 Simon Marchi <simon.marchi@efficios.com>
10728
10729 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10730 from...
10731 (rank_one_type): ... this.
10732
9293fc63
SM
107332019-03-08 Simon Marchi <simon.marchi@efficios.com>
10734
10735 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10736 from...
10737 (rank_one_type): ... this.
10738
e3abbe7e
PW
107392019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10740
10741 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10742 inferior-events' shows the example events.
10743
e4adb939
EZ
107442019-03-08 Eli Zaretskii <eliz@gnu.org>
10745
10746 Support styling on native MS-Windows console
10747
10748 PR/24315
10749 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10750 on MS-Windows if $TERM is not defined.
10751
10752 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10753
10754 * posix-hdep.c (gdb_console_fputs):
10755 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10756 functions.
10757 * ui-file.h (gdb_console_fputs): Add prototype.
10758
10759 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10760 back to fputs only if the former returns zero.
10761
25629dfd
TT
107622019-03-07 Tom Tromey <tom@tromey.com>
10763
10764 * symmisc.c (print_symbol_bcache_statistics): Update.
10765 (print_objfile_statistics): Update.
10766 * symfile.c (allocate_symtab): Update.
10767 * stabsread.c: Don't include bcache.h.
10768 * psymtab.h (struct psymbol_bcache): Don't declare.
10769 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10770 (psymbol_bcache_init, psymbol_bcache_free)
10771 (psymbol_bcache_get_bcache): Don't declare.
10772 * psymtab.c (struct psymbol_bcache): Remove.
10773 (psymtab_storage::psymtab_storage): Update.
10774 (psymtab_storage::~psymtab_storage): Update.
10775 (psymbol_bcache_init, psymbol_bcache_free)
10776 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10777 (add_psymbol_to_bcache): Update.
10778 (allocate_psymtab): Update.
10779 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10780 macro_cache>: No longer pointers.
10781 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10782 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10783 * macrotab.c (macro_bcache): Update.
10784 * macroexp.c: Don't include bcache.h.
10785 * gdbtypes.c (check_types_worklist): Update.
10786 (types_deeply_equal): Remove TRY/CATCH. Update.
10787 * elfread.c (elf_symtab_read): Update.
10788 * dwarf2read.c: Don't include bcache.h.
10789 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10790 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10791 (print_bcache_statistics, bcache_memory_used): Don't declare.
10792 (struct bcache): Move from bcache.c. Add constructor, destructor,
10793 methods. Rename all data members.
10794 * bcache.c (struct bcache): Move to bcache.h.
10795 (bcache::expand_hash_table): Rename from expand_hash_table.
10796 (bcache): Remove.
10797 (bcache::insert): Rename from bcache_full.
10798 (bcache::compare): Rename from bcache_compare.
10799 (bcache_xmalloc): Remove.
10800 (bcache::~bcache): Rename from bcache_xfree.
10801 (bcache::print_statistics): Rename from print_bcache_statistics.
10802 (bcache::memory_used): Rename from bcache_memory_used.
10803
fe726667
PA
108042019-03-07 Pedro Alves <palves@redhat.com>
10805
10806 * infrun.c (normal_stop): Also check for
10807 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10808
7584bb30
AB
108092019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10810
10811 * f-lang.c (value_from_host_double): Moved to...
10812 * value.c (value_from_host_double): ...here.
10813 * value.h (value_from_host_double): Declare.
10814 * guile/scm-math.c (vlscm_convert_typed_number): Use
10815 value_from_host_double.
10816 (vlscm_convert_number): Likewise.
10817 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10818 * python/py-value.c (convert_value_from_python): Likewise.
10819
a7b1986e
TT
108202019-03-06 Tom Tromey <tom@tromey.com>
10821
10822 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10823
0ccf4211
TT
108242019-03-06 Tom Tromey <tom@tromey.com>
10825
10826 * utils.h (free_current_contents): Don't declare.
10827 * utils.c (free_current_contents): Remove.
10828
fe7b42e5
TT
108292019-03-06 Tom Tromey <tom@tromey.com>
10830
10831 * top.c (quit_force): Update.
10832 * main.c (captured_command_loop): Update.
10833 * common/new-op.c (operator new): Update.
10834 * common/common-exceptions.c (struct catcher)
10835 <save_cleanup_chain>: Remove member.
10836 (exceptions_state_mc_init): Update.
10837 (exception_try_scope_entry): Return nullptr.
10838 (exception_try_scope_exit, exception_rethrow)
10839 (throw_exception_sjlj, throw_exception_cxx): Update.
10840 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10841 (all_cleanups, do_cleanups, discard_cleanups)
10842 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10843 (restore_cleanups, restore_final_cleanups): Don't declare.
10844 (do_final_cleanups): Remove parameter.
10845 * common/cleanups.c (cleanup_chain, make_cleanup)
10846 (make_cleanup_dtor, all_cleanups, do_cleanups)
10847 (discard_my_cleanups, discard_cleanups)
10848 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10849 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10850 (null_cleanup): Remove.
10851 (do_final_cleanups): Remove parameter.
10852
c6321f19
TT
108532019-03-06 Tom Tromey <tom@tromey.com>
10854
10855 * remote.c (remote_target::remote_parse_stop_reply): Use
10856 unique_xmalloc_ptr.
10857
61b30099
TT
108582019-03-06 Tom Tromey <tom@tromey.com>
10859
10860 * stabsread.c (struct stabs_field_info): Rename from field_info.
10861 <list, fnlist>: Add initializers.
10862 <obstack>: New member.
10863 (read_member_functions, read_struct_fields, read_baseclasses):
10864 Allocate on obstack. Don't use cleanups.
10865 (read_one_struct_field, read_member_functions, read_struct_fields)
10866 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10867 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10868 (read_struct_type): Update.
10869
6cceac94
TT
108702019-03-06 Tom Tromey <tom@tromey.com>
10871
10872 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10873 * common/filestuff.h (make_cleanup_close): Don't declare.
10874 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10875 Remove.
10876
72412762
TT
108772019-03-06 Tom Tromey <tom@tromey.com>
10878
10879 * solib-aix.c: Use make_scope_exit.
10880
2b6ff1c0
TT
108812019-03-06 Tom Tromey <tom@tromey.com>
10882
10883 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10884 Use make_scope_exit.
10885
d01c5877
TT
108862019-03-06 Tom Tromey <tom@tromey.com>
10887
10888 * solib-svr4.c (disable_probes_interface): Remove parameter.
10889 (svr4_handle_solib_event): Use make_scope_exit.
10890
32603266
TT
108912019-03-06 Tom Tromey <tom@tromey.com>
10892
10893 * remote.c (struct stop_reply_deleter): Remove.
10894 (stop_reply_up): Update.
10895 (struct stop_reply): Derive from notif_event. Don't typedef.
10896 <regcache>: Now a std::vector.
10897 (stop_reply_xfree): Remove.
10898 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10899 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10900 (remote_target::discard_pending_stop_replies): Use delete.
10901 (remote_target::remote_parse_stop_reply): Update.
10902 (remote_target::process_stop_reply): Update.
10903 * remote-notif.h (struct notif_event): Add virtual destructor.
10904 Remove "dtr" member.
10905 (struct notif_client) <alloc_event>: Return a unique_ptr.
10906 (notif_event_xfree): Don't declare.
10907 (notif_event_up): New typedef.
10908 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10909 (notif_event_xfree, do_notif_event_xfree): Remove.
10910 (remote_notif_state_xfree): Update.
10911
9799571e
TT
109122019-03-06 Tom Tromey <tom@tromey.com>
10913
10914 * infrun.c (displaced_step_clear_cleanup): Now a
10915 forward_scope_exit type.
10916 (displaced_step_prepare_throw): Update.
10917 (displaced_step_fixup): Update.
10918
09e3c4ca
TT
109192019-03-06 Tom Tromey <tom@tromey.com>
10920
10921 * inferior.h (class inferior): Update comment.
10922 * gdbthread.h (class thread_info): Update comment.
10923
e2a03548
TT
109242019-03-06 Joel Brobecker <brobecker@adacore.com>
10925 Tom Tromey <tom@tromey.com>
10926
10927 * stabsread.h (struct stab_section_list): Remove.
10928 (coffstab_build_psymtabs): Update.
10929 * dbxread.c (symbuf_sections): Now a std::vector.
10930 (sect_idx): New global.
10931 (fill_symbuf): Update.
10932 (coffstab_build_psymtabs): Change type of stabsects parameter.
10933 Update.
10934 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10935 std::vector.
10936 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10937 (coff_locate_sections): Update.
10938 (coff_symfile_read): Remove cleanups. Update.
10939 (init_stringtab): Add storage parameter.
10940 (free_stringtab, free_stringtab_cleanup): Remove.
10941 (init_lineno): Add storage parameter.
10942 (free_linetab, free_linetab_cleanup): Remove.
10943
b7e60d85
PA
109442019-03-06 Pedro Alves <palves@redhat.com>
10945
10946 * linux-fork.c (fork_info::clobber_regs): Delete.
10947 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10948 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10949 comment. Adjust.
10950 (scoped_switch_fork_info::scoped_switch_fork_info)
10951 (checkpoint_command, linux_fork_context): Adjust
10952 fork_save_infrun_state calls.
10953
e52c971f
PA
109542019-03-06 Pedro Alves <palves@redhat.com>
10955
10956 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10957 (inf_has_multiple_threads): Return 'bool' and rewrite using
10958 inferior_info::threads().
10959
06974e6c
PA
109602019-03-06 Pedro Alves <palves@redhat.com>
10961
10962 * linux-fork.c: Include <list>.
10963 (fork_list): Now a std::list instance.
10964 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10965 (forks_exist_p, find_last_fork): Adjust.
10966 (new_fork): Delete.
10967 (one_fork_p): New.
10968 (add_fork): Adjust.
10969 (free_fork): Delete, folded into fork_info::~fork_info().
10970 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10971 Adjust.
10972 (init_fork_list): Delete.
10973 (linux_fork_killall, linux_fork_mourn_inferior)
10974 (linux_fork_detach, info_checkpoints_command): Adjust.
10975 (_initialize_linux_fork): No longer call init_fork_list.
10976
72f31aea
PA
109772019-03-06 Pedro Alves <palves@redhat.com>
10978
10979 * linux-fork.c (new_fork): New, split out of ...
10980 (add_fork): ... this. Return void. Move "first fork" special
10981 case from here, to ...
10982 (checkpoint_command): ... here.
10983 * linux-linux.h (add_fork): Return void.
10984
efbecbc1
AB
109852019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10986
10987 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10988
0841c79a
AB
109892019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10990 Chris January <chris.january@arm.com>
10991 David Lecomber <david.lecomber@arm.com>
10992
10993 * f-exp.y: New token, UNOP_INTRINSIC.
10994 (exp): New pattern using UNOP_INTRINSIC token.
10995 (f77_keywords): Add 'abs' keyword.
10996 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10997 (value_from_host_double): New function.
10998 (evaluate_subexp_f): Support UNOP_ABS.
10999
4a270568
AB
110002019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11001
11002 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11003 types.
11004
067630bd
AB
110052019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11006
11007 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11008 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11009 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11010
3be47f7a
AB
110112019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11012
11013 * f-exp.y (convert_to_kind_type): Handle more type kinds.
11014
4d00f5d8
AB
110152019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11016 Chris January <chris.january@arm.com>
11017
11018 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11019 * f-exp.y: Define 'KIND' token.
11020 (exp): New pattern for KIND expressions.
11021 (ptype): Handle types with a kind extension.
11022 (direct_abs_decl): Extend to spot kind extensions.
11023 (f77_keywords): Add 'kind' to the list.
11024 (push_kind_type): New function.
11025 (convert_to_kind_type): New function.
11026 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11027 * parse.c (operator_length_standard): Likewise.
11028 * parser-defs.h (enum type_pieces): Add tp_kind.
11029 * std-operator.def: Add UNOP_KIND.
11030
e454224f
AB
110312019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11032
11033 * f-exp.y (f_parse): Set yydebug.
11034
9dad4a58
AB
110352019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11036
11037 * f-lang.c (evaluate_subexp_f): New function.
11038 (exp_descriptor_f): New global.
11039 (f_language_defn): Use exp_descriptor_f instead of
11040 exp_descriptor_standard.
11041
c8f91604
AB
110422019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11043
11044 * f-exp.y (struct token): Add comments.
11045 (dot_ops): Remove uppercase versions and the end marker.
11046 (f77_keywords): Likewise.
11047 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11048 entries in the dot_ops array are case insensitive, and use
11049 strncasecmp to compare strings. Also some whitespace cleanup in
11050 this area. Similar for the f77_keywords array, except entries in
11051 this list might be case sensitive.
11052
dd9f2c76
AB
110532019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11054
11055 * f-exp.y (struct f77_boolean_val): Add comments.
11056 (boolean_values): Remove uppercase versions, and end marker.
11057 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11058 and use strncasecmp to achieve case insensitivity. Additionally,
11059 perform whitespace cleanup around this code.
11060
67a3048c
TT
110612019-03-06 Tom Tromey <tromey@adacore.com>
11062
11063 * remote-sim.c (gdbsim_target_open): Use result of
11064 gdb_argv::release.
11065
aa3cfbda
RB
110662019-03-06 Richard Bunt <richard.bunt@arm.com>
11067 Dirk Schubert <dirk.schubert@arm.com>
11068 Chris January <chris.january@arm.com>
11069
11070 * eval.c (evaluate_subexp_standard): Call Fortran argument
11071 wrapping logic.
11072 * f-lang.c (struct value): A value which can be passed into a
11073 Fortran function call.
11074 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11075 where appropriate.
11076 (struct type): Value ready for a Fortran function call.
11077 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11078 is needed.
11079 * f-lang.h (fortran_argument_convert): Declaration.
11080 (fortran_preserve_arg_pointer): Declaration.
11081 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11082
ea38e5df
TT
110832019-03-05 Tom Tromey <tromey@adacore.com>
11084
11085 * python/py-prettyprint.c (print_string_repr): Remove #if.
11086 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11087
06b5b831
TT
110882019-03-05 Tom Tromey <tromey@adacore.com>
11089
11090 * target.c (the_dummy_target): Move later. Change type to
11091 "dummy_target".
11092 (initialize_targets): Don't initialize the_dummy_target.
11093
edbd9e45
TT
110942019-03-05 Tom Tromey <tromey@adacore.com>
11095
11096 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11097 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11098
c119e040
TT
110992019-03-05 Tom Tromey <tromey@adacore.com>
11100
11101 * windows-nat.c (windows_nat_target::attach)
11102 (windows_nat_target::detach): Don't call gdb_flush.
11103 * valprint.c (generic_val_print, val_print, val_print_string):
11104 Don't call gdb_flush.
11105 * utils.c (defaulted_query): Don't call gdb_flush.
11106 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11107 * target.c (target_announce_detach): Don't call gdb_flush.
11108 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11109 * remote.c (extended_remote_target::attach): Don't call
11110 gdb_flush.
11111 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11112 * printcmd.c (do_examine): Don't call gdb_flush.
11113 (info_display_command): Don't call gdb_flush.
11114 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11115 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11116 * memattr.c (info_mem_command): Don't call gdb_flush.
11117 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11118 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11119 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11120 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11121 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11122 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11123 (gnu_nat_target::detach): Don't call gdb_flush.
11124 * f-valprint.c (f_val_print): Don't call gdb_flush.
11125 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11126 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11127 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11128 gdb_flush.
11129 * c-valprint.c (c_val_print): Don't call gdb_flush.
11130 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11131
895dafa6
TT
111322019-03-05 Tom Tromey <tromey@adacore.com>
11133
11134 * varobj.c (update_dynamic_varobj_children): Update.
11135 (install_default_visualizer): Use reset, not release.
11136 * value.c (set_internalvar): Update.
11137 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11138 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11139 ATTRIBUTE_UNUSED_RESULT.
11140
88a774b9
TT
111412019-03-05 Tom Tromey <tromey@adacore.com>
11142
11143 * remote.c (class scoped_remote_fd) <release>: Add
11144 ATTRIBUTE_UNUSED_RESULT.
11145
4e4a8b93
TT
111462019-03-05 Tom Tromey <tromey@adacore.com>
11147
11148 * macroexp.c (struct macro_buffer) <release>: Add
11149 ATTRIBUTE_UNUSED_RESULT.
11150
083eef1f
TT
111512019-03-05 Tom Tromey <tromey@adacore.com>
11152
11153 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11154 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11155 ATTRIBUTE_UNUSED_RESULT.
11156
3cabd438
TT
111572019-03-05 Tom Tromey <tromey@adacore.com>
11158
11159 * common/scoped_fd.h (class scoped_fd) <release>: Add
11160 ATTRIBUTE_UNUSED_RESULT.
11161
41e3300a
TT
111622019-03-05 Tom Tromey <tromey@adacore.com>
11163
11164 * parser-defs.h (struct parser_state) <release>: Add
11165 ATTRIBUTE_UNUSED_RESULT.
11166
18cb7c9f
TT
111672019-03-05 Tom Tromey <tromey@adacore.com>
11168
11169 * utils.h (class gdb_argv) <release>: Add
11170 ATTRIBUTE_UNUSED_RESULT.
11171 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11172
41fa577f
EZ
111732019-03-02 Eli Zaretskii <eliz@gnu.org>
11174
a6a4b2c6
EZ
11175 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11176 for-loop range, to avoid compiler warnings.
11177
11178 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11179 avoid compiler warnings about unused variables.
11180
742a7df5
EZ
11181 * NEWS: Mention end of support for native debugging on MS-Windows
11182 before XP.
11183
41fa577f
EZ
11184 PR gdb/24292
11185 * common/netstuff.c:
11186 * gdbserver/gdbreplay.c
11187 * gdbserver/remote-utils.c:
11188 * ser-tcp.c:
11189 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11190 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11191 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11192 'getaddrinfo' and 'freeaddrinfo' were not available before
11193 Windows XP, and mingw.org's MinGW headers by default define
11194 _WIN32_WINNT to 0x500.
11195
827f438f
GB
111962019-03-01 Gary Benson <gbenson@redhat.com>
11197
11198 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11199
92137da0
RO
112002019-02-28 Brian Vandenberg <phantall@gmail.com>
11201 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11202
11203 PR gdb/8527
11204 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11205 set_sigint_trap, clear_sigint_trap.
11206
799efbe8
PW
112072019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11208
11209 * target.c (target_detach): Clear the regcache and the
11210 frame cache.
11211
8ed25214
PA
112122019-02-27 Pedro Alves <palves@redhat.com>
11213
11214 * utils.c (set_screen_size): When we cap the height/width sizes,
11215 tweak the corresponding command variable to show "unlimited":
11216
23031e31
SJ
112172019-02-27 Saagar Jha <saagar@saagarjha.com>
11218 Pedro Alves <palves@redhat.com>
11219
11220 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11221 before calling rl_set_screen_size.
11222
6c28e44a
TT
112232019-02-27 Tom Tromey <tromey@adacore.com>
11224
11225 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11226 define.
11227 * python/py-value.c: Remove Python 2.4 workaround.
11228 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11229 workaround.
11230 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11231 Python 2.4 workaround.
11232 * python/python-internal.h: Remove Python 2.4 comment.
11233 (Py_ssize_t): Don't define.
11234 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11235 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11236 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11237 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11238 * python/python.c (do_start_initialization): Remove Python 2.4
11239 workaround.
11240 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11241 (print_children): Remove Python 2.4 workaround.
11242 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11243 workaround.
11244 (CHARBUFFERPROC_NAME): Remove.
11245 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11246 Python 2.4 workaround.
11247
2c3fc25d 112482019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 11249
2c3fc25d
KB
11250 * NEWS: Note minimum Python version.
11251
6ca62222
KB
112522019-02-27 Kevin Buettner <kevinb@redhat.com>
11253
11254 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11255 code from these functions. Remove corresponding ifdefs. Use
11256 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11257 Remove gotos and target of gotos.
11258 (infpy_search_memory): Likewise.
11259
f4bc7d2c
AB
112602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11261
11262 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11263 (hppa_gdbarch_init): Don't register deleted functions with
11264 gdbarch.
11265
9734a586
AB
112662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11267
11268 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11269 (h8300_unwind_sp): Delete.
11270 (h8300_dummy_id): Delete.
11271 (h8300_gdbarch_init): Don't register deleted functions with
11272 gdbarch.
11273
68b867f3
AB
112742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11275
11276 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11277 (ft32_unwind_pc): Delete.
11278 (ft32_unwind_sp): Delete.
11279 (ft32_gdbarch_init): Don't register deleted functions with
11280 gdbarch.
11281
2fbe7ad0
AB
112822019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11283
11284 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11285 (frv_unwind_pc): Delete.
11286 (frv_unwind_sp): Delete.
11287 (frv_gdbarch_init): Don't register deleted functions with
11288 gdbarch.
11289
76055cbe
AB
112902019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11291
11292 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11293 (riscv_unwind_pc): Delete.
11294 (riscv_unwind_sp): Delete.
11295 (riscv_gdbarch_init): Don't register deleted functions with
11296 gdbarch.
11297
4133e5a1
AB
112982019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11299
11300 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11301 (csky_unwind_pc): Delete.
11302 (csky_unwind_sp): Delete.
11303 (csky_gdbarch_init): Don't register deleted functions with
11304 gdbarch.
11305
8010f576
AB
113062019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11307
11308 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11309 (cris_unwind_pc): Delete.
11310 (cris_unwind_sp): Delete.
11311 (cris_gdbarch_init): Don't register deleted functions with
11312 gdbarch.
11313
b56bf084
AB
113142019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11315
11316 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11317 (bfin_unwind_pc): Delete.
11318 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11319
a19a650f
AB
113202019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11321
11322 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11323 (arm_unwind_pc): Delete.
11324 (arm_unwind_sp): Delete.
11325 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11326
f8278c3c
AB
113272019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11328
11329 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11330 (arc_unwind_pc): Delete.
11331 (arc_unwind_sp): Delete.
11332 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11333
480e46cf
AB
113342019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11335
11336 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11337 (alpha_unwind_pc): Delete.
11338 (alpha_gdbarch_init): Don't register deleted functions with
11339 gdbarch.
11340
7a995095
AB
113412019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11342
11343 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11344 (aarch64_unwind_pc): Delete.
11345 (aarch64_unwind_sp): Delete.
11346 (aarch64_gdbarch_init): Don't register deleted functions with
11347 gdbarch.
11348
bf9a735e
AB
113492019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11350
11351 * gdbtypes.c (type_align): Don't consider static members when
11352 computing structure alignment.
11353
5561fc30
AB
113542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11355
11356 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11357 return 0 for other types.
11358 * arch-utils.c (default_type_align): Always return 0.
11359 * gdbarch.h: Regenerate.
11360 * gdbarch.sh (type_align): Extend comment.
11361 * gdbtypes.c (type_align): Add additional comments, always call
11362 gdbarch_type_align before applying the default rules.
11363 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11364 generic code will then apply a suitable default.
11365 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11366 types, return 0 for other types.
11367
9335e75a
JB
113682019-02-27 Joel Brobecker <brobecker@adacore.com>
11369
11370 * NEWS: Create a new section for the next release branch.
11371 Rename the section of the current branch, now that it has
11372 been cut.
11373
3d34d8de
JB
113742019-02-27 Joel Brobecker <brobecker@adacore.com>
11375
11376 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11377 * version.in: Bump version to 8.3.50.DATE-git.
11378
143420fb
SM
113792019-02-26 Simon Marchi <simon.marchi@efficios.com>
11380
11381 * aix-thread.c (ptid_cmp): Remove unused variable.
11382 (get_signaled_thread): Likewise.
11383 (store_regs_user_thread): Likewise.
11384 (store_regs_kernel_thread): Likewise.
11385 (fetch_regs_kernel_thread): Remove shadowed variable.
11386
172fb711
AB
113872019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11388
11389 * features/riscv/32bit-cpu.xml: Add register numbers.
11390 * features/riscv/32bit-fpu.c: Regenerate.
11391 * features/riscv/32bit-fpu.xml: Add register numbers.
11392 * features/riscv/64bit-cpu.xml: Add register numbers.
11393 * features/riscv/64bit-fpu.c: Regenerate.
11394 * features/riscv/64bit-fpu.xml: Add register numbers.
11395
26c89782
KB
113962019-02-26 Kevin Buettner <kevinb@redhat.com>
11397
af54ade9 11398 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
11399 * python/py-value.c (convert_buffer_and_type_to_value): New
11400 function.
11401 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11402 Add support for handling an optional second argument. Call
11403 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
11404 * python/python-internal.h (Py_buffer_deleter): New struct.
11405 (Py_buffer_up): New typedef.
11406
0f58c9e8
JB
114072019-02-25 John Baldwin <jhb@FreeBSD.org>
11408
11409 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11410 instead of releasing ownership.
11411
0a0f4c01
JR
114122019-02-25 Jordan Rupprecht <rupprecht@google.com>
11413
11414 * dwarf2read.c (open_and_init_dwp_file): Call
11415 elf_numsections instead of bfd_count_sections to initialize
11416 dwp_file->num_sections.
11417
cd5a152c
TT
114182019-02-25 Tom Tromey <tromey@adacore.com>
11419
11420 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11421
8a6a8513
SDJ
114222019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11423
11424 * gcore.in: Add '--readnever' option when invoking GDB.
11425
04dcda9c
SM
114262019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11427
11428 * MAINTAINERS: Update my email address.
11429
07bc701d
SM
114302019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11431
11432 * build-id.c (build_id_to_debug_bfd_1): New function.
11433 (build_id_to_debug_bfd): Look for separate debug file in
11434 sysroot.
11435
c6f4a5d0
AB
114362019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11437
11438 * gdbarch.sh: Update the copyright year range that is placed into
11439 generated files.
11440
9600246d
KS
114412019-02-22 Keith Seitz <keiths@redhat.com>
11442
11443 PR symtab/23853
11444 * linespec.c (create_sals_line_offset): Search for the default
11445 symtab's filename instead of its fullname.
11446
7557a514
AH
114472019-02-21 Alan Hayward <alan.hayward@arm.com>
11448
11449 * NEWS: Update style defaults.
11450
ee2bcb0c
AH
114512019-02-21 Alan Hayward <alan.hayward@arm.com>
11452
11453 * main.c (captured_main_1): Disable styling in batch mode.
11454
0c95f9ed
TT
114552019-02-20 Tom Tromey <tom@tromey.com>
11456
11457 * symtab.c (symtab_symbol_info): Fix typos.
11458
c763b894
TT
114592019-02-20 Tom Tromey <tromey@adacore.com>
11460
11461 * findcmd.c (_initialize_mem_search): Use upper case for
11462 metasyntactic variables.
11463
0ef8a082
AH
114642019-02-20 Alan Hayward <alan.hayward@arm.com>
11465
11466 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11467 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11468
6caa91b6
SM
114692019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11470
11471 * top.h (source_file_name): Change to std::string.
11472 * top.c (source_file_name): Likewise.
11473 (command_line_input): Adjust.
11474 * cli/cli-script.c (script_from_file): Adjust.
11475
98814c6c
TT
114762019-02-19 Tom Tromey <tromey@adacore.com>
11477
11478 * ravenscar-thread.c
11479 (ravenscar_thread_target::update_thread_list): Don't call
11480 ada_build_task_list.
11481 * ada-lang.h (ada_build_task_list): Don't declare.
11482 * ada-tasks.c (struct ada_tasks_inferior_data)
11483 <task_list_valid_p>: Now bool.
11484 (read_known_tasks, ada_task_list_changed)
11485 (ada_tasks_invalidate_inferior_data): Update.
11486 (read_known_tasks_array): Return bool.
11487 (read_known_tasks_list): Likewise.
11488 (read_known_tasks): Return void.
11489 (ada_build_task_list): Now static.
11490
70cd633e
AB
114912019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11492
11493 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11494 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11495
040b3e95
PW
114962019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11497
11498 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11499 variant for ada_tasks_pspace_data_handle and
11500 ada_tasks_inferior_data_handle.
11501 (ada_tasks_pspace_data_cleanup): New function.
11502 (ada_tasks_inferior_data_cleanup): New function.
11503
9409233b
TT
115042019-02-17 Tom Tromey <tom@tromey.com>
11505
11506 * macrotab.h (macro_source_fullname): Return a std::string.
11507 * macrotab.c (macro_include, check_for_redefinition)
11508 (macro_undef, macro_lookup_definition, foreach_macro)
11509 (foreach_macro_in_scope): Update.
11510 (macro_source_fullname): Return a std::string.
11511 * macrocmd.c (show_pp_source_pos): Update.
11512
6506371f
TT
115132019-02-17 Tom Tromey <tom@tromey.com>
11514
11515 * macrocmd.c (show_pp_source_pos): Style the file names.
11516
0c820d67
TT
115172019-02-17 Tom Tromey <tom@tromey.com>
11518
11519 PR tui/24197:
11520 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11521
a0087920
TT
115222019-02-17 Tom Tromey <tom@tromey.com>
11523
11524 * ada-lang.c (user_select_syms): Use filtered printing.
11525 * utils.c (wrap_style): New global.
11526 (desired_style): Remove.
11527 (emit_style_escape): Add stream parameter.
11528 (set_output_style, reset_terminal_style, prompt_for_continue):
11529 Update.
11530 (flush_wrap_buffer): Only flush gdb_stdout.
11531 (wrap_here): Set wrap_style.
11532 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
11533 treat escape sequences as a character. Change when wrap buffer is
11534 flushed.
11535 (fputs_styled): Do not set the output style when the default is
11536 requested.
11537 * ui-style.h (struct ui_file_style) <is_default>: New method.
11538 * source.c (print_source_lines_base): Emit escape sequences in one
11539 piece.
11540
75ba10dc
JB
115412019-02-17 Joel Brobecker <brobecker@adacore.com>
11542
11543 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11544 integers and enumeration types.
11545
a2cd4f14
JB
115462019-02-17 Joel Brobecker <brobecker@adacore.com>
11547
11548 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11549 instead of lookup_symbol_in_language
11550 (do_exact_match): New function.
11551 (ada_get_symbol_name_matcher): Return do_exact_match when
11552 doing a verbatim match.
11553
485b851b
TT
115542019-02-15 Tom Tromey <tromey@adacore.com>
11555
11556 * ravenscar-thread.c (ravenscar_thread_target::resume)
11557 (ravenscar_thread_target::wait): Special case wildcard requests.
11558
0b790b1e
TT
115592019-02-15 Tom Tromey <tromey@adacore.com>
11560
11561 * ravenscar-thread.c (base_ptid): Remove.
11562 (struct ravenscar_thread_target) <close>: New method.
11563 <m_base_ptid>: New member.
11564 <update_inferior_ptid, active_task, task_is_currently_active,
11565 runtime_initialized>: Declare methods.
11566 <ravenscar_thread_target>: Add constructor.
11567 (ravenscar_thread_target::task_is_currently_active)
11568 (ravenscar_thread_target::update_inferior_ptid)
11569 (ravenscar_runtime_initialized): Rename. Now methods.
11570 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11571 (ravenscar_thread_target::update_thread_list): Update.
11572 (ravenscar_thread_target::active_task): Now method.
11573 (ravenscar_thread_target::store_registers)
11574 (ravenscar_thread_target::prepare_to_store)
11575 (ravenscar_thread_target::prepare_to_store)
11576 (ravenscar_thread_target::mourn_inferior): Update.
11577 (ravenscar_inferior_created): Use "new" to create target.
11578 (ravenscar_thread_target::get_ada_task_ptid): Update.
11579 (_initialize_ravenscar): Don't initialize base_ptid.
11580 (ravenscar_ops): Remove global.
11581
dea57a62
TT
115822019-02-15 Tom Tromey <tromey@adacore.com>
11583
11584 * target.h (push_target): Declare new overload.
11585 * target.c (push_target): New overload, taking an rvalue reference.
11586 * remote.c (remote_target::open_1): Use push_target overload.
11587 * corelow.c (core_target_open): Use push_target overload.
11588
989f3c58
TT
115892019-02-15 Tom Tromey <tromey@adacore.com>
11590
11591 * ravenscar-thread.c (is_ravenscar_task)
11592 (ravenscar_task_is_currently_active): Return bool.
11593 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11594 (_initialize_ravenscar): Remove "(void)".
11595 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11596 Return bool.
11597
6cbcc006
TT
115982019-02-15 Tom Tromey <tromey@adacore.com>
11599
11600 * ravenscar-thread.c (ravenscar_runtime_initializer)
11601 (has_ravenscar_runtime, get_running_thread_id)
11602 (ravenscar_thread_target::resume): Fix indentation.
11603
7657f14d
TT
116042019-02-15 Tom Tromey <tromey@adacore.com>
11605
11606 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11607 from ravenscar_arch_ops.
11608 (sparc_ravenscar_ops::fetch_registers)
11609 (sparc_ravenscar_ops::store_registers): Now methods.
11610 (sparc_ravenscar_prepare_to_store): Remove.
11611 (sparc_ravenscar_ops): Redefine.
11612 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11613 methods and destructor. Remove members.
11614 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11615 (ravenscar_thread_target::store_registers)
11616 (ravenscar_thread_target::prepare_to_store): Update.
11617 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11618 Remove.
11619 (struct ppc_ravenscar_powerpc_ops): Derive from
11620 ravenscar_arch_ops.
11621 (ppc_ravenscar_powerpc_ops::fetch_registers)
11622 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11623 (ppc_ravenscar_powerpc_ops): Redefine.
11624 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11625 (ppc_ravenscar_e500_ops::fetch_registers)
11626 (ppc_ravenscar_e500_ops::store_registers): Now methods.
11627 (ppc_ravenscar_e500_ops): Redefine.
11628 * aarch64-ravenscar-thread.c
11629 (aarch64_ravenscar_generic_prepare_to_store): Remove.
11630 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11631 (aarch64_ravenscar_fetch_registers)
11632 (aarch64_ravenscar_store_registers): Now methods.
11633 (aarch64_ravenscar_ops): Redefine.
11634
5b6ea500
TT
116352019-02-15 Tom Tromey <tromey@adacore.com>
11636
11637 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11638 (ravenscar_thread_target::stopped_by_hw_breakpoint)
11639 (ravenscar_thread_target::stopped_by_watchpoint)
11640 (ravenscar_thread_target::stopped_data_address)
11641 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11642
e397fd39
TT
116432019-02-15 Tom Tromey <tromey@adacore.com>
11644
11645 * ravenscar-thread.c: Fix some typos.
11646
cc12f4a8
TT
116472019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11648 Tom Tromey <tromey@adacore.com>
11649
11650 * ada-lang.c (ada_exception_sal): Change addr_string to a
11651 std::string.
11652 (create_ada_exception_catchpoint): Update.
11653
5f486660
TT
116542019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11655 Tom Tromey <tromey@adacore.com>
11656
11657 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11658 (bp_location_ops): Remove.
11659 (base_breakpoint_allocate_location): Update.
11660 (free_bp_location): Update.
11661 * ada-lang.c (class ada_catchpoint_location)
11662 <ada_catchpoint_location>: Remove ops parameter.
11663 (ada_catchpoint_location_dtor): Remove.
11664 (ada_catchpoint_location_ops): Remove.
11665 (allocate_location_exception): Update.
11666 * breakpoint.h (struct bp_location_ops): Remove.
11667 (class bp_location) <bp_location>: Remove bp_location_ops
11668 parameter.
11669 <~bp_location>: Add destructor.
11670 <ops>: Remove.
11671
b671c7fb
TS
116722019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11673 Pedro Alves <palves@redhat.com>
11674
11675 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11676 'PATH_MAX'.
11677
8071c5ce
DM
116782019-02-14 David Michael <fedora.dm0@gmail.com>
11679 Samuel Thibault <samuel.thibault@gnu.org>
11680 Thomas Schwinge <thomas@codesourcery.com>
11681
11682 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11683 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11684
b1041ae0
TS
116852019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11686
924514e1
TS
11687 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11688 (check_empty): Use "const char *".
11689
c29ee8d4
TS
11690 * gnu-nat.c (gnu_nat_target::detach): Instead of
11691 'detach_inferior (pid)' call
11692 'detach_inferior (find_inferior_pid (pid))'.
11693
6c6ef69f
TS
11694 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11695 'nat/fork-inferior.o'.
11696 * gnu-nat.c: #include "nat/fork-inferior.h".
11697
2d0a338c
TS
11698 * gnu-nat.c (gnu_nat_target::detach): Instead of
11699 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11700 * gnu-nat.h: #include "inf-child.h".
11701 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11702 'i386_gnu_nat_target::fetch_registers'.
11703 (gnu_store_registers): Rename/move to
11704 'i386_gnu_nat_target::store_registers'.
11705
cabb5f06
TS
11706 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11707 * gnu-nat.h (mach_thread_info): New function.
11708 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11709
b1041ae0
TS
11710 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11711
2988d01e
KF
117122019-02-14 Frederic Konrad <konrad@adacore.com>
11713
11714 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11715
c559d709
JB
117162019-02-14 Joel Brobecker <brobecker@adacore.com>
11717
11718 * windows-nat.c (windows_add_thread): Add new parameter
11719 "main_thread_p" with default value set to false. Update
11720 function documentation as well as all callers.
11721 (windows_delete_thread): Likewise.
11722 (fake_create_process): Update call to windows_add_thread.
11723 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11724 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11725 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11726 call to windows_delete_thread.
11727
007024cc
SM
117282019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11729
11730 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11731
f62318e9
JB
117322019-02-12 John Baldwin <jhb@FreeBSD.org>
11733
11734 * symfile.c (find_separate_debug_file): Use canonical path of
11735 sysroot with child_path instead of gdb_sysroot if it is valid.
11736
cd4b7848
JB
117372019-02-12 John Baldwin <jhb@FreeBSD.org>
11738
11739 * symfile.c (find_separate_debug_file): Use child_path to
11740 determine if an object file is under a sysroot.
11741
efac4bfe
JB
117422019-02-12 John Baldwin <jhb@FreeBSD.org>
11743
11744 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11745 unittests/child-path-selftests.c.
11746 * common/pathstuff.c (child_path): New function.
11747 * common/pathstuff.h (child_path): New prototype.
11748 * unittests/child-path-selftests.c: New file.
11749
402d2bfe
JB
117502019-02-12 John Baldwin <jhb@FreeBSD.org>
11751
11752 * symfile.c (find_separate_debug_file): Look for separate debug
11753 files in debug directories under the sysroot.
11754
1ed9f74e
PW
117552019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11756
11757 * symtab.h (struct minimal_symbol data_p): New const method.
11758 (struct minimal_symbol text_p): Likewise.
11759 * symtab.c (output_source_filename): Use file name style
11760 to print file name.
11761 (print_symbol_info): Likewise.
11762 (print_msymbol_info): Use address style to print addresses.
11763 Use function name style to print executable text symbols.
11764 (expand_symtab_containing_pc): Use data_p.
11765 (find_pc_sect_compunit_symtab): Likewise.
11766
2636d81d
PW
117672019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11768
11769 * breakpoint.c (describe_other_breakpoints): Use address style
11770 to print addresses.
11771 (say_where): Likewise.
11772
ac8c53cc
PW
117732019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11774
11775 * ada-typeprint.c (print_func_type): Print function name
11776 style to print function name.
11777 * c-typeprint.c (c_print_type_1): Likewise.
11778
ea638c43
AH
117792019-02-11 Alan Hayward <alan.hayward@arm.com>
11780
11781 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11782 for execve.
11783
ab759ca8
PW
117842019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11785
11786 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11787 type_stack.
11788
aff29d1c
JB
117892019-02-10 Joel Brobecker <brobecker@adacore.com>
11790
11791 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11792 TYPE_CODE_REF types.
11793
617126bc
JW
117942019-02-08 Jim Wilson <jimw@sifive.com>
11795
11796 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11797 (riscv_linux_fregset): New.
11798 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11799
46e3ed7f
TT
118002019-02-07 Tom Tromey <tom@tromey.com>
11801
11802 * thread.c (thread_cancel_execution_command): Update.
11803 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11804 methods.
11805 (struct thread_fsm_ops): Remove.
11806 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11807 (thread_fsm_should_stop, thread_fsm_return_value)
11808 (thread_fsm_set_finished, thread_fsm_finished_p)
11809 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11810 Don't declare.
11811 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11812 * infrun.c (clear_proceed_status_thread)
11813 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11814 (print_stop_event): Update.
11815 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11816 Add constructor.
11817 (step_command_fsm_ops): Remove.
11818 (new_step_command_fsm): Remove.
11819 (step_1): Update.
11820 (step_command_fsm::should_stop): Rename from
11821 step_command_fsm_should_stop.
11822 (step_command_fsm::clean_up): Rename from
11823 step_command_fsm_clean_up.
11824 (step_command_fsm::do_async_reply_reason): Rename from
11825 step_command_fsm_async_reply_reason.
11826 (struct until_next_fsm): Inherit from thread_fsm. Add
11827 constructor.
11828 (until_next_fsm_ops): Remove.
11829 (new_until_next_fsm): Remove.
11830 (until_next_fsm::should_stop): Rename from
11831 until_next_fsm_should_stop.
11832 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11833 (until_next_fsm::do_async_reply_reason): Rename from
11834 until_next_fsm_async_reply_reason.
11835 (struct finish_command_fsm): Inherit from thread_fsm. Add
11836 constructor. Change type of breakpoint.
11837 (finish_command_fsm_ops): Remove.
11838 (new_finish_command_fsm): Remove.
11839 (finish_command_fsm::should_stop): Rename from
11840 finish_command_fsm_should_stop.
11841 (finish_command_fsm::clean_up): Rename from
11842 finish_command_fsm_clean_up.
11843 (finish_command_fsm::return_value): Rename from
11844 finish_command_fsm_return_value.
11845 (finish_command_fsm::do_async_reply_reason): Rename from
11846 finish_command_fsm_async_reply_reason.
11847 (finish_command): Update.
11848 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11849 Add constructor.
11850 (call_thread_fsm_ops): Remove.
11851 (call_thread_fsm::call_thread_fsm): Rename from
11852 new_call_thread_fsm.
11853 (call_thread_fsm::should_stop): Rename from
11854 call_thread_fsm_should_stop.
11855 (call_thread_fsm::should_notify_stop): Rename from
11856 call_thread_fsm_should_notify_stop.
11857 (run_inferior_call, call_function_by_hand_dummy): Update.
11858 * cli/cli-interp.c (should_print_stop_to_console): Update.
11859 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11860 Add constructor. Change type of location_breakpoint,
11861 caller_breakpoint.
11862 (until_break_fsm_ops): Remove.
11863 (new_until_break_fsm): Remove.
11864 (until_break_fsm::should_stop): Rename from
11865 until_break_fsm_should_stop.
11866 (until_break_fsm::clean_up): Rename from
11867 until_break_fsm_clean_up.
11868 (until_break_fsm::do_async_reply_reason): Rename from
11869 until_break_fsm_async_reply_reason.
11870 (until_break_command): Update.
11871 * thread-fsm.c: Remove.
11872 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11873
1a5c2598
TT
118742019-02-07 Tom Tromey <tom@tromey.com>
11875
11876 * yy-remap.h: Add include guard.
11877 * xtensa-tdep.h: Add include guard.
11878 * xcoffread.h: Rename include guard.
11879 * varobj-iter.h: Add include guard.
11880 * tui/tui.h: Rename include guard.
11881 * tui/tui-winsource.h: Rename include guard.
11882 * tui/tui-wingeneral.h: Rename include guard.
11883 * tui/tui-windata.h: Rename include guard.
11884 * tui/tui-win.h: Rename include guard.
11885 * tui/tui-stack.h: Rename include guard.
11886 * tui/tui-source.h: Rename include guard.
11887 * tui/tui-regs.h: Rename include guard.
11888 * tui/tui-out.h: Rename include guard.
11889 * tui/tui-layout.h: Rename include guard.
11890 * tui/tui-io.h: Rename include guard.
11891 * tui/tui-hooks.h: Rename include guard.
11892 * tui/tui-file.h: Rename include guard.
11893 * tui/tui-disasm.h: Rename include guard.
11894 * tui/tui-data.h: Rename include guard.
11895 * tui/tui-command.h: Rename include guard.
11896 * tic6x-tdep.h: Add include guard.
11897 * target/waitstatus.h: Rename include guard.
11898 * target/wait.h: Rename include guard.
11899 * target/target.h: Rename include guard.
11900 * target/resume.h: Rename include guard.
11901 * target-float.h: Rename include guard.
11902 * stabsread.h: Add include guard.
11903 * rs6000-tdep.h: Add include guard.
11904 * riscv-fbsd-tdep.h: Add include guard.
11905 * regformats/regdef.h: Rename include guard.
11906 * record.h: Rename include guard.
11907 * python/python.h: Rename include guard.
11908 * python/python-internal.h: Rename include guard.
11909 * python/py-stopevent.h: Rename include guard.
11910 * python/py-ref.h: Rename include guard.
11911 * python/py-record.h: Rename include guard.
11912 * python/py-record-full.h: Rename include guard.
11913 * python/py-record-btrace.h: Rename include guard.
11914 * python/py-instruction.h: Rename include guard.
11915 * python/py-events.h: Rename include guard.
11916 * python/py-event.h: Rename include guard.
11917 * procfs.h: Add include guard.
11918 * proc-utils.h: Add include guard.
11919 * p-lang.h: Add include guard.
11920 * or1k-tdep.h: Rename include guard.
11921 * observable.h: Rename include guard.
11922 * nto-tdep.h: Rename include guard.
11923 * nat/x86-linux.h: Rename include guard.
11924 * nat/x86-linux-dregs.h: Rename include guard.
11925 * nat/x86-gcc-cpuid.h: Add include guard.
11926 * nat/x86-dregs.h: Rename include guard.
11927 * nat/x86-cpuid.h: Rename include guard.
11928 * nat/ppc-linux.h: Rename include guard.
11929 * nat/mips-linux-watch.h: Rename include guard.
11930 * nat/linux-waitpid.h: Rename include guard.
11931 * nat/linux-ptrace.h: Rename include guard.
11932 * nat/linux-procfs.h: Rename include guard.
11933 * nat/linux-osdata.h: Rename include guard.
11934 * nat/linux-nat.h: Rename include guard.
11935 * nat/linux-namespaces.h: Rename include guard.
11936 * nat/linux-btrace.h: Rename include guard.
11937 * nat/glibc_thread_db.h: Rename include guard.
11938 * nat/gdb_thread_db.h: Rename include guard.
11939 * nat/gdb_ptrace.h: Rename include guard.
11940 * nat/fork-inferior.h: Rename include guard.
11941 * nat/amd64-linux-siginfo.h: Rename include guard.
11942 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11943 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11944 * nat/aarch64-linux.h: Rename include guard.
11945 * nat/aarch64-linux-hw-point.h: Rename include guard.
11946 * mn10300-tdep.h: Add include guard.
11947 * mips-linux-tdep.h: Add include guard.
11948 * mi/mi-parse.h: Rename include guard.
11949 * mi/mi-out.h: Rename include guard.
11950 * mi/mi-main.h: Rename include guard.
11951 * mi/mi-interp.h: Rename include guard.
11952 * mi/mi-getopt.h: Rename include guard.
11953 * mi/mi-console.h: Rename include guard.
11954 * mi/mi-common.h: Rename include guard.
11955 * mi/mi-cmds.h: Rename include guard.
11956 * mi/mi-cmd-break.h: Rename include guard.
11957 * m2-lang.h: Add include guard.
11958 * location.h: Rename include guard.
11959 * linux-record.h: Rename include guard.
11960 * linux-nat.h: Add include guard.
11961 * linux-fork.h: Add include guard.
11962 * i386-darwin-tdep.h: Rename include guard.
11963 * hppa-linux-offsets.h: Add include guard.
11964 * guile/guile.h: Rename include guard.
11965 * guile/guile-internal.h: Rename include guard.
11966 * gnu-nat.h: Rename include guard.
11967 * gdb-stabs.h: Rename include guard.
11968 * frv-tdep.h: Add include guard.
11969 * f-lang.h: Add include guard.
11970 * event-loop.h: Add include guard.
11971 * darwin-nat.h: Rename include guard.
11972 * cp-abi.h: Rename include guard.
11973 * config/sparc/nm-sol2.h: Rename include guard.
11974 * config/nm-nto.h: Rename include guard.
11975 * config/nm-linux.h: Add include guard.
11976 * config/i386/nm-i386gnu.h: Rename include guard.
11977 * config/djgpp/nl_types.h: Rename include guard.
11978 * config/djgpp/langinfo.h: Rename include guard.
11979 * compile/gcc-cp-plugin.h: Add include guard.
11980 * compile/gcc-c-plugin.h: Add include guard.
11981 * compile/compile.h: Rename include guard.
11982 * compile/compile-object-run.h: Rename include guard.
11983 * compile/compile-object-load.h: Rename include guard.
11984 * compile/compile-internal.h: Rename include guard.
11985 * compile/compile-cplus.h: Rename include guard.
11986 * compile/compile-c.h: Rename include guard.
11987 * common/xml-utils.h: Rename include guard.
11988 * common/x86-xstate.h: Rename include guard.
11989 * common/version.h: Rename include guard.
11990 * common/vec.h: Rename include guard.
11991 * common/tdesc.h: Rename include guard.
11992 * common/selftest.h: Rename include guard.
11993 * common/scoped_restore.h: Rename include guard.
11994 * common/scoped_mmap.h: Rename include guard.
11995 * common/scoped_fd.h: Rename include guard.
11996 * common/safe-iterator.h: Rename include guard.
11997 * common/run-time-clock.h: Rename include guard.
11998 * common/refcounted-object.h: Rename include guard.
11999 * common/queue.h: Rename include guard.
12000 * common/ptid.h: Rename include guard.
12001 * common/print-utils.h: Rename include guard.
12002 * common/preprocessor.h: Rename include guard.
12003 * common/pathstuff.h: Rename include guard.
12004 * common/observable.h: Rename include guard.
12005 * common/netstuff.h: Rename include guard.
12006 * common/job-control.h: Rename include guard.
12007 * common/host-defs.h: Rename include guard.
12008 * common/gdb_wait.h: Rename include guard.
12009 * common/gdb_vecs.h: Rename include guard.
12010 * common/gdb_unlinker.h: Rename include guard.
12011 * common/gdb_unique_ptr.h: Rename include guard.
12012 * common/gdb_tilde_expand.h: Rename include guard.
12013 * common/gdb_sys_time.h: Rename include guard.
12014 * common/gdb_string_view.h: Rename include guard.
12015 * common/gdb_splay_tree.h: Rename include guard.
12016 * common/gdb_setjmp.h: Rename include guard.
12017 * common/gdb_ref_ptr.h: Rename include guard.
12018 * common/gdb_optional.h: Rename include guard.
12019 * common/gdb_locale.h: Rename include guard.
12020 * common/gdb_assert.h: Rename include guard.
12021 * common/filtered-iterator.h: Rename include guard.
12022 * common/filestuff.h: Rename include guard.
12023 * common/fileio.h: Rename include guard.
12024 * common/environ.h: Rename include guard.
12025 * common/common-utils.h: Rename include guard.
12026 * common/common-types.h: Rename include guard.
12027 * common/common-regcache.h: Rename include guard.
12028 * common/common-inferior.h: Rename include guard.
12029 * common/common-gdbthread.h: Rename include guard.
12030 * common/common-exceptions.h: Rename include guard.
12031 * common/common-defs.h: Rename include guard.
12032 * common/common-debug.h: Rename include guard.
12033 * common/cleanups.h: Rename include guard.
12034 * common/buffer.h: Rename include guard.
12035 * common/btrace-common.h: Rename include guard.
12036 * common/break-common.h: Rename include guard.
12037 * cli/cli-utils.h: Rename include guard.
12038 * cli/cli-style.h: Rename include guard.
12039 * cli/cli-setshow.h: Rename include guard.
12040 * cli/cli-script.h: Rename include guard.
12041 * cli/cli-interp.h: Rename include guard.
12042 * cli/cli-decode.h: Rename include guard.
12043 * cli/cli-cmds.h: Rename include guard.
12044 * charset-list.h: Add include guard.
12045 * buildsym-legacy.h: Rename include guard.
12046 * bfin-tdep.h: Add include guard.
12047 * ax.h: Rename include guard.
12048 * arm-linux-tdep.h: Add include guard.
12049 * arm-fbsd-tdep.h: Add include guard.
12050 * arch/xtensa.h: Rename include guard.
12051 * arch/tic6x.h: Add include guard.
12052 * arch/i386.h: Add include guard.
12053 * arch/arm.h: Rename include guard.
12054 * arch/arm-linux.h: Rename include guard.
12055 * arch/arm-get-next-pcs.h: Rename include guard.
12056 * arch/amd64.h: Add include guard.
12057 * arch/aarch64-insn.h: Rename include guard.
12058 * arch-utils.h: Rename include guard.
12059 * annotate.h: Add include guard.
12060 * amd64-darwin-tdep.h: Rename include guard.
12061 * aarch64-linux-tdep.h: Add include guard.
12062 * aarch64-fbsd-tdep.h: Add include guard.
12063 * aarch32-linux-nat.h: Add include guard.
12064
ab9268d2
PW
120652019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12066
12067 * macrotab.c (macro_define_internal): New function that
12068 factorizes macro_define_object_internal and macro_define_function
12069 code.
12070 (macro_define_object_internal): Use macro_define_internal.
12071 (macro_define_function): Likewise.
12072
bb0da2b4
PW
120732019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12074
12075 * macrocmd.c (extract_identifier): Return
12076 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12077 callers.
12078
424eb552
JB
120792019-02-06 John Baldwin <jhb@FreeBSD.org>
12080
12081 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12082
1688cb29
TT
120832019-02-05 Tom Tromey <tom@tromey.com>
12084
12085 * target.c (target_stack::unpush): Move assertion earlier.
12086
b5eba2d8
TT
120872019-01-30 Tom Tromey <tom@tromey.com>
12088
12089 PR python/23615:
12090 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12091 (gdbpy_parse_and_eval): Likewise.
12092 * python/python-internal.h (gdbpy_allow_threads): New class.
12093
7054e2ff
JB
120942019-01-28 John Baldwin <jhb@FreeBSD.org>
12095
12096 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12097 (aarch64_fbsd_fpregmap): Move earlier.
12098 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12099 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12100 instead of individual calls to trad_frame_set_reg_addr.
12101 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12102 earlier.
12103 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12104 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12105 instead of individual calls to trad_frame_set_reg_addr.
12106
36c25ffa
AH
121072019-01-28 Alan Hayward <alan.hayward@arm.com>
12108
12109 * CONTRIBUTE: Replace contribution list with wiki link.
12110
a0707f3c
TT
121112019-01-25 Tom Tromey <tom@tromey.com>
12112
12113 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12114
0747795c
TT
121152019-01-25 Tom Tromey <tom@tromey.com>
12116
12117 * xtensa-linux-nat.c: Fix common/ includes.
12118 * xml-support.h: Fix common/ includes.
12119 * xml-support.c: Fix common/ includes.
12120 * x86-linux-nat.c: Fix common/ includes.
12121 * windows-nat.c: Fix common/ includes.
12122 * varobj.h: Fix common/ includes.
12123 * varobj.c: Fix common/ includes.
12124 * value.c: Fix common/ includes.
12125 * valops.c: Fix common/ includes.
12126 * utils.c: Fix common/ includes.
12127 * unittests/xml-utils-selftests.c: Fix common/ includes.
12128 * unittests/utils-selftests.c: Fix common/ includes.
12129 * unittests/unpack-selftests.c: Fix common/ includes.
12130 * unittests/tracepoint-selftests.c: Fix common/ includes.
12131 * unittests/style-selftests.c: Fix common/ includes.
12132 * unittests/string_view-selftests.c: Fix common/ includes.
12133 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12134 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12135 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12136 * unittests/rsp-low-selftests.c: Fix common/ includes.
12137 * unittests/parse-connection-spec-selftests.c: Fix common/
12138 includes.
12139 * unittests/optional-selftests.c: Fix common/ includes.
12140 * unittests/offset-type-selftests.c: Fix common/ includes.
12141 * unittests/observable-selftests.c: Fix common/ includes.
12142 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12143 * unittests/memrange-selftests.c: Fix common/ includes.
12144 * unittests/memory-map-selftests.c: Fix common/ includes.
12145 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12146 * unittests/function-view-selftests.c: Fix common/ includes.
12147 * unittests/environ-selftests.c: Fix common/ includes.
12148 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12149 * unittests/common-utils-selftests.c: Fix common/ includes.
12150 * unittests/cli-utils-selftests.c: Fix common/ includes.
12151 * unittests/array-view-selftests.c: Fix common/ includes.
12152 * ui-file.c: Fix common/ includes.
12153 * tui/tui-io.c: Fix common/ includes.
12154 * tracepoint.h: Fix common/ includes.
12155 * tracepoint.c: Fix common/ includes.
12156 * tracefile-tfile.c: Fix common/ includes.
12157 * top.h: Fix common/ includes.
12158 * top.c: Fix common/ includes.
12159 * thread.c: Fix common/ includes.
12160 * target/waitstatus.h: Fix common/ includes.
12161 * target/waitstatus.c: Fix common/ includes.
12162 * target.h: Fix common/ includes.
12163 * target.c: Fix common/ includes.
12164 * target-memory.c: Fix common/ includes.
12165 * target-descriptions.c: Fix common/ includes.
12166 * symtab.h: Fix common/ includes.
12167 * symfile.c: Fix common/ includes.
12168 * stap-probe.c: Fix common/ includes.
12169 * spu-linux-nat.c: Fix common/ includes.
12170 * sparc-nat.c: Fix common/ includes.
12171 * source.c: Fix common/ includes.
12172 * solib.c: Fix common/ includes.
12173 * solib-target.c: Fix common/ includes.
12174 * ser-unix.c: Fix common/ includes.
12175 * ser-tcp.c: Fix common/ includes.
12176 * ser-pipe.c: Fix common/ includes.
12177 * ser-base.c: Fix common/ includes.
12178 * selftest-arch.c: Fix common/ includes.
12179 * s12z-tdep.c: Fix common/ includes.
12180 * rust-exp.y: Fix common/ includes.
12181 * rs6000-aix-tdep.c: Fix common/ includes.
12182 * riscv-tdep.c: Fix common/ includes.
12183 * remote.c: Fix common/ includes.
12184 * remote-notif.h: Fix common/ includes.
12185 * remote-fileio.h: Fix common/ includes.
12186 * remote-fileio.c: Fix common/ includes.
12187 * regcache.h: Fix common/ includes.
12188 * regcache.c: Fix common/ includes.
12189 * record-btrace.c: Fix common/ includes.
12190 * python/python.c: Fix common/ includes.
12191 * python/py-type.c: Fix common/ includes.
12192 * python/py-inferior.c: Fix common/ includes.
12193 * progspace.h: Fix common/ includes.
12194 * producer.c: Fix common/ includes.
12195 * procfs.c: Fix common/ includes.
12196 * proc-api.c: Fix common/ includes.
12197 * printcmd.c: Fix common/ includes.
12198 * ppc-linux-nat.c: Fix common/ includes.
12199 * parser-defs.h: Fix common/ includes.
12200 * osdata.c: Fix common/ includes.
12201 * obsd-nat.c: Fix common/ includes.
12202 * nat/x86-linux.c: Fix common/ includes.
12203 * nat/x86-linux-dregs.c: Fix common/ includes.
12204 * nat/x86-dregs.h: Fix common/ includes.
12205 * nat/x86-dregs.c: Fix common/ includes.
12206 * nat/ppc-linux.c: Fix common/ includes.
12207 * nat/mips-linux-watch.h: Fix common/ includes.
12208 * nat/mips-linux-watch.c: Fix common/ includes.
12209 * nat/linux-waitpid.c: Fix common/ includes.
12210 * nat/linux-ptrace.h: Fix common/ includes.
12211 * nat/linux-ptrace.c: Fix common/ includes.
12212 * nat/linux-procfs.c: Fix common/ includes.
12213 * nat/linux-personality.c: Fix common/ includes.
12214 * nat/linux-osdata.c: Fix common/ includes.
12215 * nat/linux-namespaces.c: Fix common/ includes.
12216 * nat/linux-btrace.h: Fix common/ includes.
12217 * nat/linux-btrace.c: Fix common/ includes.
12218 * nat/fork-inferior.c: Fix common/ includes.
12219 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12220 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12221 * nat/aarch64-linux.c: Fix common/ includes.
12222 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12223 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12224 * namespace.h: Fix common/ includes.
12225 * mips-linux-tdep.c: Fix common/ includes.
12226 * minsyms.c: Fix common/ includes.
12227 * mi/mi-parse.h: Fix common/ includes.
12228 * mi/mi-main.c: Fix common/ includes.
12229 * mi/mi-cmd-env.c: Fix common/ includes.
12230 * memrange.h: Fix common/ includes.
12231 * memattr.c: Fix common/ includes.
12232 * maint.h: Fix common/ includes.
12233 * maint.c: Fix common/ includes.
12234 * main.c: Fix common/ includes.
12235 * machoread.c: Fix common/ includes.
12236 * location.c: Fix common/ includes.
12237 * linux-thread-db.c: Fix common/ includes.
12238 * linux-nat.c: Fix common/ includes.
12239 * linux-fork.c: Fix common/ includes.
12240 * inline-frame.c: Fix common/ includes.
12241 * infrun.c: Fix common/ includes.
12242 * inflow.c: Fix common/ includes.
12243 * inferior.h: Fix common/ includes.
12244 * inferior.c: Fix common/ includes.
12245 * infcmd.c: Fix common/ includes.
12246 * inf-ptrace.c: Fix common/ includes.
12247 * inf-child.c: Fix common/ includes.
12248 * ia64-linux-nat.c: Fix common/ includes.
12249 * i387-tdep.c: Fix common/ includes.
12250 * i386-tdep.c: Fix common/ includes.
12251 * i386-linux-tdep.c: Fix common/ includes.
12252 * i386-linux-nat.c: Fix common/ includes.
12253 * i386-go32-tdep.c: Fix common/ includes.
12254 * i386-fbsd-tdep.c: Fix common/ includes.
12255 * i386-fbsd-nat.c: Fix common/ includes.
12256 * guile/scm-type.c: Fix common/ includes.
12257 * guile/guile.c: Fix common/ includes.
12258 * go32-nat.c: Fix common/ includes.
12259 * gnu-nat.c: Fix common/ includes.
12260 * gdbthread.h: Fix common/ includes.
12261 * gdbarch-selftests.c: Fix common/ includes.
12262 * gdb_usleep.c: Fix common/ includes.
12263 * gdb_select.h: Fix common/ includes.
12264 * gdb_bfd.c: Fix common/ includes.
12265 * gcore.c: Fix common/ includes.
12266 * fork-child.c: Fix common/ includes.
12267 * findvar.c: Fix common/ includes.
12268 * fbsd-nat.c: Fix common/ includes.
12269 * event-top.c: Fix common/ includes.
12270 * event-loop.c: Fix common/ includes.
12271 * dwarf2read.c: Fix common/ includes.
12272 * dwarf2loc.c: Fix common/ includes.
12273 * dwarf2-frame.c: Fix common/ includes.
12274 * dwarf-index-cache.c: Fix common/ includes.
12275 * dtrace-probe.c: Fix common/ includes.
12276 * disasm-selftests.c: Fix common/ includes.
12277 * defs.h: Fix common/ includes.
12278 * csky-tdep.c: Fix common/ includes.
12279 * cp-valprint.c: Fix common/ includes.
12280 * cp-support.h: Fix common/ includes.
12281 * cp-support.c: Fix common/ includes.
12282 * corelow.c: Fix common/ includes.
12283 * completer.h: Fix common/ includes.
12284 * completer.c: Fix common/ includes.
12285 * compile/compile.c: Fix common/ includes.
12286 * compile/compile-loc2c.c: Fix common/ includes.
12287 * compile/compile-cplus-types.c: Fix common/ includes.
12288 * compile/compile-cplus-symbols.c: Fix common/ includes.
12289 * command.h: Fix common/ includes.
12290 * cli/cli-dump.c: Fix common/ includes.
12291 * cli/cli-cmds.c: Fix common/ includes.
12292 * charset.c: Fix common/ includes.
12293 * build-id.c: Fix common/ includes.
12294 * btrace.h: Fix common/ includes.
12295 * btrace.c: Fix common/ includes.
12296 * breakpoint.h: Fix common/ includes.
12297 * breakpoint.c: Fix common/ includes.
12298 * ax.h:
12299 (enum agent_op): Fix common/ includes.
12300 * ax-general.c (struct aop_map): Fix common/ includes.
12301 * ax-gdb.c: Fix common/ includes.
12302 * auxv.c: Fix common/ includes.
12303 * auto-load.c: Fix common/ includes.
12304 * arm-tdep.c: Fix common/ includes.
12305 * arch/riscv.c: Fix common/ includes.
12306 * arch/ppc-linux-common.c: Fix common/ includes.
12307 * arch/i386.c: Fix common/ includes.
12308 * arch/arm.c: Fix common/ includes.
12309 * arch/arm-linux.c: Fix common/ includes.
12310 * arch/arm-get-next-pcs.c: Fix common/ includes.
12311 * arch/amd64.c: Fix common/ includes.
12312 * arch/aarch64.c: Fix common/ includes.
12313 * arch/aarch64-insn.c: Fix common/ includes.
12314 * arch-utils.c: Fix common/ includes.
12315 * amd64-windows-tdep.c: Fix common/ includes.
12316 * amd64-tdep.c: Fix common/ includes.
12317 * amd64-sol2-tdep.c: Fix common/ includes.
12318 * amd64-obsd-tdep.c: Fix common/ includes.
12319 * amd64-nbsd-tdep.c: Fix common/ includes.
12320 * amd64-linux-tdep.c: Fix common/ includes.
12321 * amd64-linux-nat.c: Fix common/ includes.
12322 * amd64-fbsd-tdep.c: Fix common/ includes.
12323 * amd64-fbsd-nat.c: Fix common/ includes.
12324 * amd64-dicos-tdep.c: Fix common/ includes.
12325 * amd64-darwin-tdep.c: Fix common/ includes.
12326 * agent.c: Fix common/ includes.
12327 * ada-lang.h: Fix common/ includes.
12328 * ada-lang.c: Fix common/ includes.
12329 * aarch64-tdep.c: Fix common/ includes.
12330
2f5c153e
TT
123312019-01-25 Tom Tromey <tom@tromey.com>
12332
12333 * common/create-version.sh: Use common/version.h.
12334
adc6a863
PA
123352019-01-24 Pedro Alves <palves@redhat.com>
12336
12337 * infrun.c (signal_stop, signal_print, signal_program)
12338 (signal_catch, signal_pass): Now arrays instead of pointers.
12339 (update_signals_program_target, do_target_resume)
12340 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12341 * linux-nat.c (linux_nat_target::pass_signals)
12342 (linux_nat_target::create_inferior, linux_nat_target::attach):
12343 Adjust.
12344 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12345 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12346 * procfs.c (procfs_target::pass_signals): Adjust.
12347 * record-full.c (record_full_target::resume): Adjust.
12348 * remote.c (remote_target::pass_signals)
12349 (remote_target::program_signals): Adjust.
12350 * target-debug.h (target_debug_print_signals): Now takes a
12351 gdb::array_view as parameter. Adjust.
12352 * target.h (target_ops) <pass_signals, program_signals>: Replace
12353 pointer and length parameters with gdb::array_view.
12354 (target_pass_signals, target_program_signals): Likewise.
12355 * target-delegates.c: Regenerate.
12356
3046d67a
PA
123572019-01-24 Pedro Alves <palves@redhat.com>
12358
12359 * common/forward-scope-exit.h
12360 (forward_scope_exit::forward_scope_exit): Pass arguments to
12361 m_bind_function directly, instead of creating a std::bind and
12362 copying that.
12363
353229bf
AH
123642019-01-24 Alan Hayward <alan.hayward@arm.com>
12365
12366 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12367 for static members.
12368 (pass_in_v_vfp_candidate): Likewise.
12369
311dc83a
TT
123702019-01-23 Tom Tromey <tom@tromey.com>
12371 Pedro Alves <palves@redhat.com>
12372
12373 * regcache.c (class regcache_invalidator): Remove.
12374 (regcache::raw_write): Use make_scope_exit.
12375
296bd123
TT
123762019-01-23 Tom Tromey <tom@tromey.com>
12377
12378 * ui-out.h (class ui_out_emit_type): Update comment.
12379
979a0d13
TT
123802019-01-23 Tom Tromey <tom@tromey.com>
12381
12382 * infrun.c (fetch_inferior_event): Update comment.
12383
d238133d
TT
123842019-01-23 Tom Tromey <tom@tromey.com>
12385 Pedro Alves <palves@redhat.com>
12386
12387 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12388 parameter.
12389 (fetch_inferior_event): Use SCOPE_EXIT.
12390
12391
9885e6bb
TT
123922019-01-23 Tom Tromey <tom@tromey.com>
12393 Pedro Alves <palves@redhat.com>
12394
12395 * infrun.c (disable_thread_events): Delete.
12396 (stop_all_threads): Use SCOPE_EXIT.
12397
286526c1
TT
123982019-01-23 Tom Tromey <tom@tromey.com>
12399 Pedro Alves <palves@redhat.com>
12400
12401 * symfile.c: Include forward-scope-exit.h.
12402 (clear_symtab_users_cleanup): Replace forward declaration with
12403 a FORWARD_SCOPE_EXIT.
12404 (syms_from_objfile_1): Use the forward_scope_exit and
12405 gdb::optional instead of cleanup_function.
12406 (reread_symbols): Use the forward_scope_exit instead of
12407 cleanup_function.
12408 (clear_symtab_users_cleanup): Remove function.
12409
1db93f14
TT
124102019-01-23 Tom Tromey <tom@tromey.com>
12411 Pedro Alves <palves@redhat.com>
12412
12413 * linux-nat.c: Include scope-exit.h.
12414 (cleanup_target_stop): Remove.
12415 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12416 SCOPE_EXIT.
12417
2cc83d1e
TT
124182019-01-23 Tom Tromey <tom@tromey.com>
12419 Pedro Alves <palves@redhat.com>
12420
12421 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12422 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12423
694c6bf5
TT
124242019-01-23 Tom Tromey <tom@tromey.com>
12425 Andrew Burgess <andrew.burgess@embecosm.com>
12426 Pedro Alves <palves@redhat.com>
12427
12428 * infrun.c (fetch_inferior_event): Use scope_exit.
12429 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12430 * top.c (execute_command): Use scope_exit.
12431 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12432 * utils.c (do_bpstat_clear_actions_cleanup)
12433 (make_bpstat_clear_actions_cleanup): Remove.
12434
4c41382a
TT
124352019-01-23 Tom Tromey <tom@tromey.com>
12436 Pedro Alves <palves@redhat.com>
12437
12438 * infrun.c: Include "common/scope-exit.h"
12439 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12440 (wait_for_inferior): Use SCOPE_EXIT.
12441 (fetch_inferior_event): Use scope_exit.
12442
89f8fb50
TT
124432019-01-23 Tom Tromey <tom@tromey.com>
12444 Pedro Alves <palves@redhat.com>
12445
12446 * breakpoint.c (create_breakpoint): Remove cleanup.
12447
5419bdae
TT
124482019-01-23 Tom Tromey <tom@tromey.com>
12449 Andrew Burgess <andrew.burgess@embecosm.com>
12450 Pedro Alves <palves@redhat.com>
12451
e587ef42
PA
124522019-01-23 Pedro Alves <palves@redhat.com>
12453
12454 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12455
77f0e74c
PA
124562019-01-23 Pedro Alves <palves@redhat.com>
12457 Andrew Burgess <andrew.burgess@embecosm.com>
12458
12459 * gdbthread.h: Include "common/forward-scope-exit.h".
12460 (scoped_finish_thread_state): Redefine custom class in terms of
12461 forward_scope_exit.
12462
5b9b3e53
PA
124632019-01-23 Pedro Alves <palves@redhat.com>
12464 Andrew Burgess <andrew.burgess@embecosm.com>
12465
12466 * common/forward-scope-exit.h: New file.
12467
54b65c9b
PA
124682019-01-23 Pedro Alves <palves@redhat.com>
12469 Andrew Burgess <andrew.burgess@embecosm.com>
12470 Tom Tromey <tom@tromey.com>
12471
12472 * common/scope-exit.h: New file.
12473
cf08fb29
PA
124742019-01-23 Pedro Alves <palves@redhat.com>
12475
12476 * common/preprocessor.h (ESC): Rename to ...
12477 (ESC_PARENS): ... this.
12478 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12479 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12480
ae73e2e2
TT
124812019-01-23 Tom Tromey <tom@tromey.com>
12482
12483 * language.h (class scoped_switch_to_sym_language_if_auto):
12484 Initialize m_lang in both cases.
12485
6594e122
AH
124862019-01-23 Alan Hayward <alan.hayward@arm.com>
12487
12488 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12489 with XCNEW.
12490
a7c9855d
TT
124912019-01-22 Tom Tromey <tom@tromey.com>
12492
12493 * corelow.c: Do not include sys/file.h.
12494
93cc1d53
TT
124952019-01-22 Tom Tromey <tom@tromey.com>
12496
12497 * tui/tui-wingeneral.h: Include gdb_curses.h.
12498
38561778
TT
124992019-01-22 Tom Tromey <tom@tromey.com>
12500
12501 * source-cache.h (class source_cache) <get_source_lines,
12502 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12503
37b3ab5b
TT
125042019-01-22 Tom Tromey <tom@tromey.com>
12505
12506 * remote-fileio.h (struct remote_target): Declare.
12507
3fabc016
TT
125082019-01-22 Tom Tromey <tom@tromey.com>
12509
12510 * python/py-arch.c: Do not include py-ref.h.
12511 * python/py-bpevent.c: Do not include py-ref.h.
12512 * python/py-cmd.c: Do not include py-ref.h.
12513 * python/py-continueevent.c: Do not include py-ref.h.
12514 * python/py-event.h: Do not include py-ref.h.
12515 * python/py-evtregistry.c: Do not include py-ref.h.
12516 * python/py-finishbreakpoint.c: Do not include py-ref.h.
12517 * python/py-frame.c: Do not include py-ref.h.
12518 * python/py-framefilter.c: Do not include py-ref.h.
12519 * python/py-function.c: Do not include py-ref.h.
12520 * python/py-infevents.c: Do not include py-ref.h.
12521 * python/py-linetable.c: Do not include py-ref.h.
12522 * python/py-objfile.c: Do not include py-ref.h.
12523 * python/py-param.c: Do not include py-ref.h.
12524 * python/py-prettyprint.c: Do not include py-ref.h.
12525 * python/py-progspace.c: Do not include py-ref.h.
12526 * python/py-symbol.c: Do not include py-ref.h.
12527 * python/py-symtab.c: Do not include py-ref.h.
12528 * python/py-type.c: Do not include py-ref.h.
12529 * python/py-unwind.c: Do not include py-ref.h.
12530 * python/py-utils.c: Do not include py-ref.h.
12531 * python/py-value.c: Do not include py-ref.h.
12532 * python/py-varobj.c: Do not include py-ref.h.
12533 * python/py-xmethods.c: Do not include py-ref.h.
12534 * python/python.c: Do not include py-ref.h.
12535 * varobj.c: Do not include py-ref.h.
12536
6b4d7774
TT
125372019-01-22 Tom Tromey <tom@tromey.com>
12538
12539 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12540 keyword for bcache.
12541
7af7e9b5
TT
125422019-01-22 Tom Tromey <tom@tromey.com>
12543
12544 * compile/compile-cplus-types.c: Remove a comment by #include.
12545
951d1049
TT
125462019-01-22 Tom Tromey <tom@tromey.com>
12547
12548 * compile/gcc-c-plugin.h: Include compile-internal.h.
12549
d65d5705
TT
125502019-01-22 Tom Tromey <tom@tromey.com>
12551
12552 * stabsread.c (EXTERN): Do not define.
12553 (symnum, next_symbol_text_func, processing_gcc_compilation)
12554 (within_function, global_sym_chain, global_stabs)
12555 (previous_stab_code, this_object_header_files)
12556 (n_this_object_header_files)
12557 (n_allocated_this_object_header_files): Define.
12558 * stabsread.h (EXTERN): Never define. Use "extern".
12559
b6fb1ee5
PW
125602019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12561
12562 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12563 history_value.
12564
be6d4f74
TT
125652019-01-21 Tom Tromey <tom@tromey.com>
12566
12567 * ui-out.c: Fix includes.
12568 * tui/tui-source.c: Fix includes.
12569 * target.c: Fix includes.
12570 * remote.c: Fix includes.
12571 * regcache.c: Fix includes.
12572 * python/py-block.c: Fix includes.
12573 * printcmd.c: Fix includes.
12574 * or1k-tdep.c: Fix includes.
12575 * mi/mi-main.c: Fix includes.
12576 * m32r-tdep.c: Fix includes.
12577 * csky-tdep.c: Fix includes.
12578 * compile/compile-cplus-types.c: Fix includes.
12579 * cli/cli-interp.c: Fix includes.
12580
73021deb
AH
125812019-01-21 Alan Hayward <alan.hayward@arm.com>
12582
12583 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12584 for padding.
12585
7932255d
TT
125862019-01-16 Tom Tromey <tom@tromey.com>
12587
12588 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
12589 earlier.
12590 (struct objfile) <msymbols_range>: Move from top level.
12591 <msymbols>: New method.
12592 (class objfile_msymbols): Remove.
12593 * symtab.c (default_collect_symbol_completion_matches_break_on):
12594 Update.
12595 * symmisc.c (dump_msymbols): Update.
12596 * stabsread.c (scan_file_globals): Update.
12597 * objc-lang.c (info_selectors_command, info_classes_command)
12598 (find_methods): Update.
12599 * minsyms.c (find_solib_trampoline_target): Update.
12600 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12601 * coffread.c (coff_symfile_read): Update.
12602 * ada-lang.c (ada_lookup_simple_minsym)
12603 (ada_collect_symbol_completion_matches): Update.
12604
604b1bfb
TT
126052019-01-16 Tom Tromey <tom@tromey.com>
12606
12607 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12608 type. Remove no-argument constructor.
12609 <iterator::operator++>: Simplify.
12610 <begin>: Update.
12611 <end>: Use minimal_symbol_count.
12612
f252c6d5
TT
126132019-01-16 Tom Tromey <tom@tromey.com>
12614
12615 * objfiles.h (struct objfile) <psymtabs>: New method.
12616 (class objfile_psymtabs): Remove.
12617 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12618 typedef.
12619 <range>: New method.
12620 (require_partial_symbols): Change return type.
12621 * psymtab.c (require_partial_symbols)
12622 (psym_expand_symtabs_matching): Update.
12623 * mdebugread.c (parse_partial_symbols): Update.
12624 * dbxread.c (dbx_end_psymtab): Update.
12625
b669c953
TT
126262019-01-15 Tom Tromey <tom@tromey.com>
12627
12628 * symtab.c (lookup_objfile_from_block)
12629 (lookup_symbol_in_objfile_symtabs)
12630 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12631 (find_line_symtab, info_sources_command)
12632 (default_collect_symbol_completion_matches_break_on)
12633 (make_source_files_completion_list): Update.
12634 * symmisc.c (print_objfile_statistics, dump_objfile)
12635 (maintenance_print_symbols, maintenance_info_symtabs)
12636 (maintenance_check_symtabs, maintenance_info_line_tables):
12637 Update.
12638 * source.c (select_source_symtab)
12639 (forget_cached_source_info_for_objfile): Update.
12640 * objfiles.h (class objfile_compunits): Remove.
12641 (struct objfile) <compunits_range>: New typedef.
12642 (compunits): New method.
12643 * objfiles.c (objfile_relocate1): Update.
12644 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12645 * maint.c (count_symtabs_and_blocks): Update.
12646 * linespec.c (iterate_over_all_matching_symtabs): Update.
12647 * cp-support.c (add_symbol_overload_list_qualified): Update.
12648 * coffread.c (coff_symtab_read): Update.
12649 * ada-lang.c (add_nonlocal_symbols)
12650 (ada_collect_symbol_completion_matches)
12651 (ada_add_global_exceptions): Update.
12652
7e955d83
TT
126532019-01-15 Tom Tromey <tom@tromey.com>
12654
12655 * progspace.h (program_space) <objfiles_safe_range>: New
12656 typedef.
12657 <objfiles_safe>: New method.
12658 * objfiles.h (class all_objfiles_safe): Remove.
12659 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12660 * jit.c (jit_inferior_exit_hook): Update.
12661
2030c079
TT
126622019-01-17 Tom Tromey <tom@tromey.com>
12663
12664 * progspace.h (program_space) <objfiles_range>: New typedef.
12665 <objfiles>: New method.
12666 <objfiles_head>: Rename from objfiles.
12667 (object_files): Update.
12668 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12669 * guile/scm-pretty-print.c
12670 (ppscm_find_pretty_printer_from_objfiles): Update.
12671 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12672 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12673 Update.
12674 * python/py-progspace.c (pspy_get_objfiles): Update.
12675 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12676 Update.
12677 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12678 (objfpy_lookup_objfile_by_build_id): Update.
12679 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12680 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12681 Update.
12682 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12683 (expand_symtab_containing_pc, lookup_objfile_from_block)
12684 (lookup_static_symbol, basic_lookup_transparent_type)
12685 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12686 (find_line_symtab, info_sources_command)
12687 (default_collect_symbol_completion_matches_break_on)
12688 (make_source_files_completion_list, find_main_name): Update.
12689 * symmisc.c (print_symbol_bcache_statistics)
12690 (print_objfile_statistics, maintenance_print_symbols)
12691 (maintenance_print_msymbols, maintenance_print_objfiles)
12692 (maintenance_info_symtabs, maintenance_check_symtabs)
12693 (maintenance_expand_symtabs, maintenance_info_line_tables):
12694 Update.
12695 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12696 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12697 (map_overlay_command, unmap_overlay_command)
12698 (simple_overlay_update, expand_symtabs_matching)
12699 (map_symbol_filenames): Update.
12700 * symfile-debug.c (set_debug_symfile): Update.
12701 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12702 Update.
12703 * source.c (select_source_symtab, forget_cached_source_info):
12704 Update.
12705 * solib.c (solib_read_symbols): Update.
12706 * solib-spu.c (append_ocl_sos): Update.
12707 * psymtab.c (maintenance_print_psymbols)
12708 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12709 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12710 * printcmd.c (info_symbol_command): Update.
12711 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12712 Update.
12713 * objfiles.h (class all_objfiles): Remove.
12714 * objfiles.c (have_partial_symbols, have_full_symbols)
12715 (have_minimal_symbols, qsort_cmp, update_section_map)
12716 (shared_objfile_contains_address_p)
12717 (default_iterate_over_objfiles_in_search_order): Update.
12718 * objc-lang.c (info_selectors_command, info_classes_command)
12719 (find_methods): Update.
12720 * minsyms.c (find_solib_trampoline_target): Update.
12721 * maint.c (maintenance_info_sections)
12722 (maintenance_translate_address, count_symtabs_and_blocks):
12723 Update.
12724 * main.c (captured_main_1): Update.
12725 * linux-thread-db.c (try_thread_db_load_from_pdir)
12726 (has_libpthread): Update.
12727 * linespec.c (iterate_over_all_matching_symtabs)
12728 (search_minsyms_for_name): Update.
12729 * jit.c (jit_find_objf_with_entry_addr): Update.
12730 * hppa-tdep.c (find_unwind_entry)
12731 (hppa_lookup_stub_minimal_symbol): Update.
12732 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12733 Update.
12734 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12735 (elf_gnu_ifunc_resolve_by_got): Update.
12736 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12737 * dwarf-index-write.c (save_gdb_index_command): Update.
12738 * cp-support.c (add_symbol_overload_list_qualified): Update.
12739 * breakpoint.c (create_overlay_event_breakpoint)
12740 (create_longjmp_master_breakpoint)
12741 (create_std_terminate_master_breakpoint)
12742 (create_exception_master_breakpoint): Update.
12743 * blockframe.c (find_pc_partial_function): Update.
12744 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12745 (ada_collect_symbol_completion_matches)
12746 (ada_add_global_exceptions): Update.
12747
776489e0
TT
127482019-01-17 Tom Tromey <tom@tromey.com>
12749
12750 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12751 declare VEC.
12752 (solib_target_parse_libraries): Change return type.
12753 (library_list_start_segment, library_list_start_section)
12754 (library_list_end_library, library_list_start_library); Update.
12755 (solib_target_free_library_list): Remove.
12756 (solib_target_parse_libraries): Remove cleanup. Change return
12757 type.
12758 (solib_target_current_sos): Update.
12759
6471e7d2
TT
127602019-01-17 Tom Tromey <tromey@bapiya>
12761
12762 * valprint.c: Replace "the the" with "the".
12763 * symtab.c: Replace "the the" with "the".
12764 * solib.c: Replace "the the" with "the".
12765 * solib-dsbt.c: Replace "the the" with "the".
12766 * linespec.c: Replace "the the" with "the".
12767 * dwarf2loc.h: Replace "the the" with "the".
12768 * amd64-windows-tdep.c: Replace "the the" with "the".
12769 * aarch64-tdep.c: Replace "the the" with "the".
12770
c24bdb02
KS
127712019-01-16 Keith Seitz <keiths@redhat.com>
12772
12773 PR gdb/23773
12774 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12775 <builder>: Rename to ..
12776 <m_builder>: ... this and make private.
12777 (dwarf2_cu::get_builder): New method. Change all users of
12778 `builder' to use this method.
12779 (dwarf2_start_symtab): Move to ...
12780 (dwarf2_cu::start_symtab): ... here. Update all callers
12781 (setup_type_unit_groups): Move to ...
12782 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12783 callers.
12784 (dwarf2_cu::reset_builder): New method.
12785 (process_full_compunit, process_full_type_unit): Use
12786 dwarf2_cu::reset_builder.
12787 (follow_die_offset): Record the ancestor CU if it is different
12788 from the followed DIE's CU.
12789 (follow_die_sig_1): Likewise.
12790
8d64371b
TT
127912019-01-15 Tom Tromey <tom@tromey.com>
12792
12793 * remote.c (class remote_state) <buf>: Now a char_vector.
12794 <buf_size>: Remove.
12795 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12796 parameter.
12797 (remote_target::getpkt_or_notif_sane_1)
12798 (remote_target::getpkt_sane)
12799 (remote_target::getpkt_or_notif_sane): Likewise.
12800 (class remote_target) <putpkt>: New overload.
12801 (remote_target::read_frame): Change type of "buf_p". Remove
12802 sizeof_p parameter.
12803 (packet_ok): New overload.
12804 (packet_check_result): New overload.
12805 Update all uses.
12806
bb277751
TT
128072019-01-14 Tom Tromey <tom@tromey.com>
12808
12809 * remote-notif.c (handle_notification, remote_notif_ack)
12810 (remote_notif_parse): Make "buf" const.
12811 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12812 const.
12813 (remote_notif_parse, remote_notif_ack, handle_notification):
12814 Likewise.
12815 * remote.c (remote_notif_stop_parse): Make "buf" const.
12816 (remote_target::remote_parse_stop_reply): Make "buf" const.
12817 (remote_notif_stop_ack): Make "buf" const.
12818
05be00a8
TT
128192019-01-14 Tom Tromey <tom@tromey.com>
12820
12821 * remote.c (remote_console_output): Make parameter const.
12822
491adeca
TT
128232019-01-14 Tom Tromey <tom@tromey.com>
12824
12825 * target-debug.h (target_debug_print_signals): Constify.
12826 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12827 * procfs.c (procfs_target::pass_signals): Update.
12828 * linux-nat.c (linux_nat_target::pass_signals): Update.
12829 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12830 * target-delegates.c: Rebuild.
12831 * remote.c (remote_target::program_signals): Update.
12832 (remote_target::pass_signals): Update.
12833 * target.c (target_pass_signals): Constify argument.
12834 (target_program_signals): Likewise.
12835 * target.h (struct target_ops) <pass_signals, program_signals>:
12836 Constify argument.
12837 (target_pass_signals, target_program_signals): Constify argument.
12838
bbd94648
TT
128392019-01-14 Tom Tromey <tom@tromey.com>
12840
12841 PR tui/28819:
12842 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12843
6f072a10
PFC
128442019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12845
12846 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12847 field.
12848 * rs6000-tdep.c: Include reggroups.h.
12849 (IS_V_ALIAS_PSEUDOREG): Define.
12850 (rs6000_register_name): Return names for the "vX" aliases.
12851 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12852 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12853 aliases. Call default_register_reggroup_p for all other
12854 pseudo-registers.
12855 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12856 New functions.
12857 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12858 Handle "vX" aliases.
12859 (v_alias_pseudo_register_collect): New function.
12860 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12861 (rs6000_gdbarch_init): Initialize "vX" aliases as
12862 pseudo-registers. Restore registration of
12863 rs6000_pseudo_register_reggroup_p with
12864 set_tdesc_pseudo_register_reggroup_p.
12865
1a782351
MF
128662019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12867
12868 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12869 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12870 set_gdbarch_num_pseudo_regs.
12871
d73cff18
PW
128722019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12873
12874 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12875 Remove arg prefixname, add do_set and do_show.
12876 Add member functions set_list and show_list.
12877 * cli/cli-style.c (class cli_style_option): Update accordingly.
12878 (style_set_list): Move to file scope.
12879 (style_show_list): Likewise.
12880 (set_style): Call help_list.
12881 (show_style): Call cmd_show_list.
12882 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12883 Update to use the new macro.
12884
60a90376
JB
128852019-10-12 Joel Brobecker <brobecker@adacore.com>
12886
12887 * ada-lang.c (_initialize_ada_language): Expand the help text
12888 for the "catch exception" command.
12889
9d7c67bf
PW
128902019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12891
12892 * symtab.c (matching_obj_sections): Initialize obj,
12893 declare it closer to its usage.
12894
7cf47dc4
TT
128952019-01-10 Tom Tromey <tom@tromey.com>
12896
12897 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12898 (basic_inf_threads_range): Remove.
12899 (inf_threads_range, inf_non_exited_threads_range)
12900 (safe_inf_threads_range): Use next_adapter.
12901
d3cb6808
KS
129022019-01-10 Keith Seitz <keiths@redhat.com>
12903
12904 PR gdb/23712
12905 PR symtab/23010
12906 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12907 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12908
63a20375
KS
129092019-01-10 Keith Seitz <keiths@redhat.com>
12910
12911 PR gdb/23712
12912 PR symtab/23010
12913 * dictionary.c (pending_to_vector): Remove.
12914 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12915 Remove _1 suffix, replacing functions of the same name. Update
12916 all callers.
12917 (dict_create_hashed, dict_create_hashed_expandable)
12918 (dict_create_linear, dict_create_linear_expandable, dict_free)
12919 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12920 Make functions static.
12921
b026f593
KS
129222019-01-10 Keith Seitz <keiths@redhat.com>
12923
12924 PR gdb/23712
12925 PR symtab/23010
12926 * dictionary.h (struct dictionary): Replace declaration with
12927 multidictionary.
12928 (dict_create_hashed, dict_create_hashed_expandable)
12929 (dict_create_linear, dict_create_linear_expandable)
12930 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12931 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12932 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12933 taking multidictionary argument.
12934 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12935 * block.h (struct block) <dict>: Change to multidictionary
12936 and rename `multidict'.
12937 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12938 symmisc.c: Update all dictionary references to multidictionary.
12939
c7748ee9
KS
129402019-01-10 Keith Seitz <keiths@redhat.com>
12941
12942 PR gdb/23712
12943 PR symtab/23010
12944 * dictionary.c: Include unordered_map.
12945 (pending_to_vector): New function.
12946 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12947 Rewrite the non-"_1" functions to take vector instead
12948 of linked list.
12949 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12950 "new" _1 versions of the same name.
12951 (multidictionary): Define.
12952 (std::hash<enum language): New definition.
12953 (collate_pending_symbols_by_language, mdict_create_hashed)
12954 (mdict_create_hashed_expandable, mdict_create_linear)
12955 (mdict_create_linear_expandable, mdict_free)
12956 (find_language_dictionary, create_new_language_dictionary)
12957 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12958 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12959 (mdict_size, mdict_empty): New functions.
12960 * dictionary.h (mdict_iterator): Define.
12961
67aa1f3c
PA
129622019-01-10 Pedro Alves <palves@redhat.com>
12963
12964 * breakpoint.c (read_uploaded_action)
12965 (create_tracepoint_from_upload): Adjust to use
12966 gdb::unique_xmalloc_ptr.
12967 * ctf.c (ctf_write_uploaded_tp):
12968 (SET_ARRAY_FIELD): Use emplace_back.
12969 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12970 * tracefile-tfile.c (tfile_write_uploaded_tp):
12971 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12972 gdb::unique_xmalloc_ptr.
12973 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12974 at_string, cond_string, cmd_strings>: Replace char pointers
12975 with gdb::unique_xmalloc_ptr.
12976
2f667667
PA
129772019-01-10 Pedro Alves <palves@redhat.com>
12978
12979 * solib-target.c (library_list_start_library): Don't xstrdup name.
12980
36cb7237
PA
129812019-01-10 Pedro Alves <palves@redhat.com>
12982
12983 * mdebugread.c (parse_partial_symbols): Use
12984 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12985
da584958
AB
129862019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12987
12988 * linux-fork.c (scoped_switch_fork_info)
12989 <~scoped_switch_fork_info>: Fix incorrect variable name.
12990
1ef8573c
AB
129912019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12992
12993 * linux-fork.c (scoped_switch_fork_info)
12994 <scoped_switch_fork_info>: Make explicit.
12995 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12996
8d7bcccb
TT
129972019-01-10 Tom Tromey <tom@tromey.com>
12998
12999 * objfiles.h (objfile::reset_psymtabs): Update.
13000 * objfiles.c (objfile::objfile): Update.
13001 * psymtab.h (psymtab_storage::obstack): Update.
13002 (psymtab_storage::m_obstack): Use gdb::optional.
13003 (class psymtab_storage): Update comment. Remove objfile
13004 parameter.
13005 * psymtab.c (psymtab_storage::psymtab_storage): Update.
13006
b596a3c7
TT
130072019-01-10 Tom Tromey <tom@tromey.com>
13008
13009 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13010 <free_psymtabs>: Now private.
13011 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13012 (allocate_psymtab): Use new method.
13013
a9342b62
TT
130142019-01-10 Tom Tromey <tom@tromey.com>
13015
13016 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13017 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13018 * mdebugread.c (parse_partial_symbols): Use
13019 allocate_dependencies.
13020 * dwarf2read.c (dwarf2_create_include_psymtab): Use
13021 allocate_dependencies.
13022 (process_psymtab_comp_unit_reader)
13023 (build_type_psymtab_dependencies): Likewise.
13024 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13025
5af70966
TT
130262019-01-10 Tom Tromey <tom@tromey.com>
13027
13028 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13029 PSYMBOL_SET_LANGUAGE.
13030 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13031
5923a04c
TT
130322019-01-10 Tom Tromey <tom@tromey.com>
13033
13034 * psymtab.h (psymtab_storage::obstack): New method.
13035 <m_obstack>: Rename from obstack; now private.
13036 * psymtab.c (psymtab_storage): Update.
13037 * dwarf2read.c (create_addrmap_from_index)
13038 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13039 Update.
13040
6d6a12bf
TT
130412019-01-10 Tom Tromey <tom@tromey.com>
13042
13043 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13044 * objfiles.h (objfile::reset_psymtabs): New method.
13045
d320c2b5
TT
130462019-01-10 Tom Tromey <tom@tromey.com>
13047
13048 * symmisc.c (print_symbol_bcache_statistics): Update.
13049 (print_objfile_statistics): Update.
13050 * symfile.c (reread_symbols): Update.
13051 * psymtab.h (class psymtab_storage): New.
13052 * psymtab.c (psymtab_storage): New constructor.
13053 (~psymtab_storage): New destructor.
13054 (require_partial_symbols): Update.
13055 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13056 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13057 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13058 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13059 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13060 (start_psymtab_common, end_psymtab_common)
13061 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13062 (allocate_psymtab): Update.
13063 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13064 Update.
13065 (dump_psymtab_addrmap, maintenance_print_psymbols)
13066 (maintenance_check_psymtabs): Update.
13067 (class objfile_psymtabs): Move to objfiles.h.
13068 * psympriv.h (discard_psymtab): Now inline.
13069 (psymtab_discarder::psymtab_discarder): Update.
13070 (psymtab_discarder::~psymtab_discarder): Update.
13071 (ALL_OBJFILE_PSYMTABS): Rewrite.
13072 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13073 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13074 Remove fields.
13075 <partial_symtabs>: New field.
13076 (class objfile_psymtabs): Move from psymtab.h. Update.
13077 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13078 psymbol_cache.
13079 (objfile::~objfile): Don't destroy psymbol_cache.
13080 * mdebugread.c (parse_partial_symbols): Update.
13081 * dwarf2read.c (create_addrmap_from_index)
13082 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13083 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13084 (add_partial_subprogram, dwarf2_ranges_read): Update.
13085 * dwarf-index-write.c (write_address_map)
13086 (write_one_signatured_type, recursively_write_psymbols)
13087 (class debug_names, class debug_names, write_psymtabs_to_index):
13088 Update.
13089
1d94a5a3
TT
130902019-01-10 Tom Tromey <tom@tromey.com>
13091
13092 * symtab.h (SYMBOL_SET_NAMES): Update.
13093 (symbol_set_names): Update.
13094 (MSYMBOL_SET_NAMES): Update.
13095 * symtab.c (symbol_set_names): Change argument to be an
13096 objfile_per_bfd_storage.
13097 * psymtab.c (add_psymbol_to_bcache): Update.
13098 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13099
0f14768a
TT
131002019-01-10 Tom Tromey <tom@tromey.com>
13101
13102 * symtab.c (create_demangled_names_hash): Change argument to be an
13103 objfile_per_bfd_storage.
13104 (symbol_set_names): Update.
13105
6eee24ce
TT
131062019-01-10 Tom Tromey <tom@tromey.com>
13107
13108 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13109 init_psymbol_list.
13110 * psymtab.c (init_psymbol_list): Do nothing if already called.
13111 * psympriv.h (init_psymbol_list): Add comment.
13112 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13113 init_psymbol_list.
13114 * dbxread.c (dbx_symfile_read): Unconditionally call
13115 init_psymbol_list.
13116
75aedd27
TT
131172019-01-10 Tom Tromey <tom@tromey.com>
13118
13119 * xcoffread.c (scan_xcoff_symtab): Update.
13120 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13121 "where".
13122 * mdebugread.c (parse_partial_symbols)
13123 (handle_psymbol_enumerators): Update.
13124 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13125 * dbxread.c (read_dbx_symtab): Update.
13126 * psympriv.h (psymbol_placement): New enum.
13127 (add_psymbol_to_list): Update.
13128
939652a5
TT
131292019-01-10 Tom Tromey <tom@tromey.com>
13130
13131 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13132 static_psymbols parameters.
13133 (scan_xcoff_symtab): Update.
13134 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13135 static_psymbols parameters.
13136 * psympriv.h (start_psymtab_common): Update.
13137 * mdebugread.c (parse_partial_symbols): Update.
13138 * dwarf2read.c (create_partial_symtab): Update.
13139 * dbxread.c (read_dbx_symtab): Update.
13140 (start_psymtab): Remove global_psymbols and static_psymbols
13141 parameters.
13142
baa62830
TT
131432019-01-10 Tom Tromey <tom@tromey.com>
13144
13145 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13146 * psymtab.c (allocate_psymtab): Add comment.
13147 * psympriv.h (allocate_psymtab): Add comment.
13148 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13149 initializations.
13150 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13151
0e8f53ba
TT
131522019-01-10 Tom Tromey <tom@tromey.com>
13153
13154 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13155 Don't declare.
13156 * mipsread.c: Include mdebugread.h.
13157 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13158 Declare.
13159 * elfread.c: Include mdebugread.h.
13160
b22a7c6a
TT
131612019-01-09 Tom Tromey <tom@tromey.com>
13162
13163 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13164 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13165 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13166 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13167 (psym_lookup_symbol, psym_find_last_source_symtab)
13168 (psym_forget_cached_source_info, psym_print_stats)
13169 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13170 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13171 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13172 (psym_find_compunit_symtab_by_address)
13173 (maintenance_print_psymbols, maintenance_info_psymtabs)
13174 (maintenance_check_psymtabs): Use ranged for.
13175 * psymtab.h (class objfile_psymtabs): New.
13176 (require_partial_symbols): Return objfile_psymtabs.
13177 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13178
3b9d3ac2
TT
131792019-01-09 Tom Tromey <tom@tromey.com>
13180
13181 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13182 (find_pc_mapped_section, list_overlays_command)
13183 (map_overlay_command, unmap_overlay_command)
13184 (simple_overlay_update): Use all_objfiles.
13185 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13186 * printcmd.c (info_symbol_command): Use all_objfiles.
13187 * objfiles.h (ALL_OBJSECTIONS): Remove.
13188 * maint.c (maintenance_translate_address): Use all_objfiles.
13189 * gcore.c (gcore_create_callback): Use all_objfiles.
13190 (objfile_find_memory_regions): Likewise.
13191
8b31193a
TT
131922019-01-09 Tom Tromey <tom@tromey.com>
13193
13194 * symtab.c (find_line_symtab, info_sources_command)
13195 (make_source_files_completion_list): Use objfile_compunits.
13196 * source.c (select_source_symtab): Use objfile_compunits.
13197 * objfiles.h (struct objfile): Update comment.
13198 (ALL_OBJFILES): Remove.
13199 (ALL_FILETABS): Remove.
13200 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13201 objfile_compunits.
13202
d5da8b3c
TT
132032019-01-09 Tom Tromey <tom@tromey.com>
13204
13205 * symmisc.c (print_objfile_statistics, dump_objfile)
13206 (maintenance_print_symbols): Use compunit_filetabs.
13207 * source.c (forget_cached_source_info_for_objfile): Use
13208 compunit_filetabs.
13209 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13210 (ALL_FILETABS): Use compunit_filetabs.
13211 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13212 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13213
5accd1a0
TT
132142019-01-09 Tom Tromey <tom@tromey.com>
13215
13216 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13217 (compunit_filetabs): New.
13218 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13219 compunit_filetabs.
13220 (info_sources_command, make_source_files_completion_list): Remove
13221 declaration.
13222 * symmisc.c (print_objfile_statistics, dump_objfile)
13223 (maintenance_print_symbols): Remove declaration.
13224 (maintenance_info_symtabs): Use compunit_filetabs.
13225 (maintenance_info_line_tables): Likewise.
13226 * source.c (select_source_symtab): Change local variable name.
13227 (forget_cached_source_info_for_objfile): Remove declaration.
13228 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13229 * objfiles.c (objfile_relocate1): Remove declaration.
13230 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13231 declaration.
13232 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13233 * coffread.c (coff_symtab_read): Remove declaration.
13234 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13235 compunit_filetabs.
13236
d8aeb77f
TT
132372019-01-09 Tom Tromey <tom@tromey.com>
13238
13239 * symtab.c (lookup_objfile_from_block)
13240 (find_pc_sect_compunit_symtab, search_symbols)
13241 (default_collect_symbol_completion_matches_break_on): Use
13242 objfile_compunits.
13243 * objfiles.h (ALL_COMPUNITS): Remove.
13244 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13245 * cp-support.c (add_symbol_overload_list_qualified): Use
13246 objfile_compunits.
13247 * ada-lang.c (ada_collect_symbol_completion_matches)
13248 (ada_add_global_exceptions): Use objfile_compunits.
13249
592553c4
TT
132502019-01-09 Tom Tromey <tom@tromey.com>
13251
13252 * source.c (select_source_symtab)
13253 (forget_cached_source_info_for_objfile): Remove declaration.
13254 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13255 declaration.
13256 * maint.c (count_symtabs_and_blocks): Remove declaration.
13257 * cp-support.c (add_symbol_overload_list_qualified): Remove
13258 declaration.
13259 * coffread.c (coff_symtab_read): Remove declaration.
13260 * symtab.c (lookup_symbol_in_objfile_symtabs)
13261 (basic_lookup_transparent_type_1): Use objfile_compunits.
13262 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13263 (info_sources_command, search_symbols)
13264 (default_collect_symbol_completion_matches_break_on)
13265 (make_source_files_completion_list): Remove declaration.
13266 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13267 (ada_collect_symbol_completion_matches)
13268 (ada_add_global_exceptions): Remove declaration.
13269 * linespec.c (iterate_over_all_matching_symtabs): Use
13270 objfile_compunits.
13271 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13272 (class objfile_compunits): New.
13273 (ALL_COMPUNITS): Use objfile_compunits.
13274 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13275 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13276 objfile_compunits.
13277 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13278
5325b9bf
TT
132792019-01-09 Tom Tromey <tom@tromey.com>
13280
13281 * symtab.c (search_symbols)
13282 (default_collect_symbol_completion_matches_break_on): Use
13283 objfile_msymbols.
13284 * ada-lang.c (ada_lookup_simple_minsym)
13285 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13286 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13287 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13288 objfile_msymbols.
13289 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13290 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13291 * objc-lang.c (find_methods): Use objfile_msymbols.
13292 (info_selectors_command, info_classes_command): Likewise.
13293 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13294 * objfiles.h (class objfile_msymbols): New.
13295 (ALL_OBJFILE_MSYMBOLS): Remove.
13296 (ALL_MSYMBOLS): Remove.
13297
cac85af2
TT
132982019-01-09 Tom Tromey <tom@tromey.com>
13299
13300 * common/next-iterator.h (next_adapter): Add Iterator template
13301 parameter.
13302 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13303 (class all_objfiles_safe): New.
13304 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13305 * objfiles.c (put_objfile_before): Update comment.
13306 (add_separate_debug_objfile): Likewise.
13307 (free_all_objfiles): Use all_objfiles_safe.
13308 (objfile_purge_solibs): Likewise.
13309
aed57c53
TT
133102019-01-09 Tom Tromey <tom@tromey.com>
13311
13312 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13313 (expand_symtab_containing_pc, lookup_static_symbol)
13314 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13315 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13316 all_objfiles.
13317 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13318 * breakpoint.c (create_overlay_event_breakpoint)
13319 (create_longjmp_master_breakpoint)
13320 (create_std_terminate_master_breakpoint)
13321 (create_exception_master_breakpoint): Use all_objfiles.
13322 * linux-thread-db.c (try_thread_db_load_from_pdir)
13323 (has_libpthread): Use all_objfiles.
13324 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13325 * linespec.c (iterate_over_all_matching_symtabs)
13326 (search_minsyms_for_name): Use all_objfiles.
13327 * maint.c (maintenance_info_sections): Use all_objfiles.
13328 * main.c (captured_main_1): Use all_objfiles.
13329 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13330 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13331 * guile/scm-pretty-print.c
13332 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13333 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13334 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13335 (maintenance_print_msymbols): Use all_objfiles.
13336 * source.c (select_source_symtab): Use all_objfiles.
13337 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13338 * symfile.c (remove_symbol_file_command)
13339 (expand_symtabs_matching, map_symbol_filenames): Use
13340 all_objfiles.
13341 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13342 all_objfiles.
13343 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13344 * objc-lang.c (find_methods): Use all_objfiles.
13345 * objfiles.c (have_partial_symbols, have_full_symbols)
13346 (have_minimal_symbols, qsort_cmp)
13347 (default_iterate_over_objfiles_in_search_order): Use
13348 all_objfiles.
13349 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13350 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13351 (maintenance_check_psymtabs): Use all_objfiles.
13352 (ALL_PSYMTABS): Remove.
13353 * compile/compile-object-run.c (do_module_cleanup): Use
13354 all_objfiles.
13355 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13356 * cp-support.c (add_symbol_overload_list_qualified): Use
13357 all_objfiles.
13358 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13359 Use all_objfiles.
13360 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13361 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13362 all_objfiles.
13363 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13364 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13365 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13366 Uses all_objfiles.
13367 * solib.c (solib_read_symbols): Use all_objfiles
13368
99d89cde
TT
133692019-01-09 Tom Tromey <tom@tromey.com>
13370
13371 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13372 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13373 all_objfiles.
13374 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13375 * symmisc.c (print_symbol_bcache_statistics)
13376 (print_objfile_statistics, maintenance_print_objfiles)
13377 (maintenance_info_symtabs, maintenance_check_symtabs)
13378 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13379 all_objfiles.
13380 * source.c (forget_cached_source_info): Use all_objfiles.
13381 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13382 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13383 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13384 * objfiles.c (update_section_map): Use all_objfiles.
13385 (shared_objfile_contains_address_p): Likewise.
13386 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13387 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13388
21708325
TT
133892019-01-09 Tom Tromey <tom@tromey.com>
13390
13391 * common/next-iterator.h: New file.
13392 * objfiles.h (class all_objfiles): New.
13393 (struct objfile_iterator): New.
13394
669e09f6
PW
133952019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13396
13397 * NEWS: Move the description of the changed "frame", "select-frame",
13398 and "info frame" commands to the Changed commands section.
13399
041be526
SM
134002019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13401
13402 * gdbtypes.c (check_stub_method_group): Remove handling of old
13403 mangling schemes.
13404 * linespec.c (find_methods): Likewise.
13405 * stabsread.c (read_member_functions): Likewise.
13406 * valops.c (search_struct_method): Likewise.
13407 (value_struct_elt_for_reference): Likewise.
13408 * NEWS: Mention this change.
13409
0e2a2133
AB
134102019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13411
13412 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13413 print_source_lines.
13414 * source.c (print_source_lines_base): Update line number check.
13415 (print_source_lines): New function.
13416 (source_lines_range::source_lines_range): New function.
13417 * source.h (class source_lines_range): New class.
13418 (print_source_lines): New declaration.
13419
1055a3b4
PW
134202019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13421
13422 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13423
cfeadda5
TT
134242019-01-08 Tom Tromey <tom@tromey.com>
13425 Simon Marchi <simon.marchi@ericsson.com>
13426
13427 PR gdb/24060
13428 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13429 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13430 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13431 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13432 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13433 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13434
583068ca
AB
134352019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13436
13437 * source.c (select_source_symtab): Move header comment to
13438 declaration in source.h.
13439 (forget_cached_source_info_for_objfile): Likewise.
13440 (forget_cached_source_info): Likewise.
13441 (identify_source_line): Likewise.
13442 * source.h (identify_source_line): Move declaration from symtab.h
13443 and add comment from source.c
13444 (print_source_lines): Likewise.
13445 (forget_cached_source_info_for_objfile): Likewise.
13446 (forget_cached_source_info): Likewise.
13447 (select_source_symtab): Likewise.
13448 (enum print_source_lines_flag): Move definition from symtab.h.
13449 * symtab.h (identify_source_line): Move declaration to source.h.
13450 (print_source_lines): Likewise.
13451 (forget_cached_source_info_for_objfile): Likewise.
13452 (forget_cached_source_info): Likewise.
13453 (select_source_symtab): Likewise.
13454 (enum print_source_lines_flag): Move definition to source.h.
13455 * tui/tui-hooks.c: Add 'source.h' include.
13456
ec98a4ad
AB
134572019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13458
13459 * source.c (print_source_lines_base): Handle requests to print
13460 reverse line number sequences, and guard against empty lines
13461 string.
13462
62ea19c1
AB
134632019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13464
13465 * source.c (print_source_lines_base): Fix skip of '\r' if next
13466 character is '\n'.
13467
9d30e1fd
TT
134682019-01-06 Tom Tromey <tom@tromey.com>
13469
13470 * c-exp.y (struct c_parse_state) <macro_original_text,
13471 expansion_obstack>: New member.
13472 (macro_original_text, expansion_obstack): Remove globals.
13473 (scan_macro_expansion, scanning_macro_expansion)
13474 (finished_macro_expansion): Update.
13475 (scan_macro_cleanup): Remove.
13476 (yylex, c_parse): Update.
13477
c65bac38
TT
134782019-01-06 Tom Tromey <tom@tromey.com>
13479
13480 * c-exp.y (struct c_parse_state) <strings>: New member.
13481 (operator_stoken): Update.
13482
02e12e38
TT
134832019-01-06 Tom Tromey <tom@tromey.com>
13484
13485 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13486 (union type_stack_elt) <typelist_val>: Now a pointer to
13487 std::vector.
13488 (type_stack_cleanup): Don't declare.
13489 (push_typelist): Update.
13490 * parse.c (pop_typelist): Return a std::vector.
13491 (push_typelist): Take a std::vector.
13492 (follow_types): Update. Do not free args.
13493 (type_stack_cleanup): Remove.
13494 * c-exp.y (struct c_parse_state): New.
13495 (cpstate): New global.
13496 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13497 (nonempty_typelist): Update.
13498 (func_mod): Create a new vector.
13499 (c_parse): Create a c_parse_state.
13500 (check_parameter_typelist): Do not delete params.
13501 (function_method): Update. Do not delete type_list.
13502
f097f5ad
TT
135032019-01-06 Tom Tromey <tom@tromey.com>
13504
13505 PR gdb/28155:
13506 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13507 check_typedef.
13508 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13509 (print_return_value): Likewise.
13510
d2adf9f1
TT
135112019-01-05 Tom Tromey <tom@tromey.com>
13512
13513 * contrib/cleanup_check.py: Remove.
13514 * contrib/gcc-with-excheck: Remove.
13515 * contrib/exsummary.py: Remove.
13516 * contrib/excheck.py: Remove.
13517
2eab46b1
JB
135182019-01-05 Joel Brobecker <brobecker@adacore.com>
13519
13520 * thread.c (delete_thread_1): Add gdb_assert that THR is not
13521 NULL. Initialize tpprev to NULL instead of assigning it
13522 to NULL on the next statement.
13523 * windows-nat.c (windows_delete_thread): Remove check for
13524 main_thread_id before printing thread exit notifications.
13525 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13526 Remove thread ID check against main_thread_id.
13527 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13528 windows_delete_thread.
13529 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13530
48c5e7e2
TT
135312019-01-04 Tom Tromey <tom@tromey.com>
13532
13533 * compile/compile.c (_initialize_compile): Use upper case for
13534 metasyntactic variables.
13535 * symmisc.c (_initialize_symmisc): Use upper case for
13536 metasyntactic variables.
13537 * psymtab.c (_initialize_psymtab): Use upper case for
13538 metasyntactic variables.
13539 * demangle.c (demangle_command): Use upper case for metasyntactic
13540 variables.
13541 (_initialize_demangler): Likewise.
13542 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13543 variables.
13544
986041cd
TT
135452019-01-03 Tom Tromey <tom@tromey.com>
13546
13547 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13548
7c711119
TT
135492019-01-03 Tom Tromey <tom@tromey.com>
13550
13551 * python/py-symtab.c (salpy_str): Update.
13552 (struct salpy_sal_object) <symtab>: Now a PyObject.
13553 (salpy_dealloc): Update.
13554 (del_objfile_sal): Use gdbpy_ref.
13555
1b20edf0
TT
135562019-01-03 Tom Tromey <tom@tromey.com>
13557
13558 * python/py-type.c (convert_field): Use new_reference. Return
13559 gdbpy_ref.
13560 (make_fielditem): Return gdbpy_ref.
13561 (typy_fields): Update.
13562 (typy_getitem): Update.
13563 (field_name): Return gdbpy_ref. Use new_reference.
13564 (typy_iterator_iternext): Update.
13565
ea41325b
TT
135662019-01-03 Tom Tromey <tom@tromey.com>
13567
13568 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13569
2a3c71d6
TT
135702019-01-03 Tom Tromey <tom@tromey.com>
13571
13572 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13573 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13574 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13575 (pspy_set_frame_filters, pspy_set_frame_unwinders)
13576 (pspy_set_type_printers): Likewise.
13577 * python/py-function.c (fnpy_init): Use gdbpy_ref.
13578 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13579 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13580 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13581 (objfpy_set_type_printers): Likewise.
13582
5c329e6a
TT
135832019-01-03 Tom Tromey <tom@tromey.com>
13584
13585 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13586 (gdbpy_print_stack): Use gdbpy_err_fetch.
13587 * python/python-internal.h (class gdbpy_err_fetch): New class.
13588 (class gdbpy_enter) <m_error_type, m_error_value,
13589 m_error_traceback>: Remove.
13590 <m_error>: New member.
13591 (gdbpy_exception_to_string): Don't declare.
13592 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13593 * python/py-value.c (convert_value_from_python): Use
13594 gdbpy_err_fetch.
13595 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13596 gdbpy_exception_to_string.
13597 (gdbpy_handle_exception): Use gdbpy_err_fetch.
13598 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13599 gdbpy_err_fetch.
13600
169bb27b
AB
136012019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13602
13603 * linux-nat.c (delete_lwp_cleanup): Delete.
13604 (struct lwp_deleter): New struct.
13605 (lwp_info_up): New typedef.
13606 (linux_nat_target::follow_fork): Delete cleanup, and make use of
13607 lwp_info_up.
13608
a07c8880
AB
136092019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13610
13611 * linux-fork.c (class scoped_switch_fork_info): New class.
13612 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13613
26089c49
AB
136142019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13615
13616 * valops.c (find_overload_match): Remove use of null_cleanup, and
13617 calls to do_cleanups.
13618
06d3e5b0
AB
136192019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13620
13621 * compile/compile-cplus-types.c
13622 (compile_cplus_instance::decl_name): Handle changes to
13623 cp_func_name.
13624 * cp-support.c (cp_func_name): Update header comment, update
13625 return type.
13626 * cp-support.h (cp_func_name): Update return type in declaration.
13627 * valops.c (find_overload_match): Move temp_func local to top
13628 level of function and change its type. Use temp_func to hold and
13629 delete temporary string obtained from cp_func_name.
13630
66644cd3
AB
136312019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13632
13633 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13634 gdb::char_vector, remove cleanup, and update uses of `msg`.
13635
592d8c0a
JW
136362019-01-03 Jim Wilson <jimw@sifive.com>
13637
13638 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13639
c55d06ec
TT
136402019-01-02 Tom Tromey <tom@tromey.com>
13641
13642 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13643 (tdesc_parse_xml): Remove cleanups.
13644 * target-descriptions.h (make_cleanup_free_target_description):
13645 Don't declare.
13646 (target_desc_deleter): New struct.
13647 (target_desc_up): New typedef.
13648 * target-descriptions.c (target_desc_deleter::operator()): Rename
13649 from free_target_description.
13650 (make_cleanup_free_target_description): Remove.
13651
3a6ae42d
TT
136522019-01-02 Tom Tromey <tom@tromey.com>
13653
13654 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
13655 constructor, destructor.
13656 (linespec_parser): Remove typedef.
13657 (~linespec_parser): Rename from linespec_parser_delete.
13658 (linespec_lex_to_end, linespec_complete_label)
13659 (linespec_complete): Update.
13660 (decode_line_full): Remove cleanups.
13661 (decode_line_1): Update.
13662
61fd3e73
TT
136632019-01-02 Tom Tromey <tom@tromey.com>
13664
13665 * python/python-internal.h (inferior_to_inferior_object): Change
13666 return type.
13667 * python/py-exitedevent.c (create_exited_event_object): Update.
13668 * python/py-inferior.c (inferior_to_inferior_object): Return
13669 gdbpy_ref.
13670 (python_new_inferior, python_inferior_deleted)
13671 (thread_to_thread_object, delete_thread_object)
13672 (build_inferior_list, gdbpy_selected_inferior): Update.
13673 * python/py-infthread.c (create_thread_object): Update. Also fail
13674 if inferior_to_inferior_object fails.
13675
d20172fc
SM
136762019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13677
13678 * inferior.h (class inferior) <displaced_step_state>: New field.
13679 * infrun.h (struct displaced_step_state): Move here from
13680 infrun.c. Initialize fields, add constructor.
13681 <inf>: Remove field.
13682 <reset>: New method.
13683 * infrun.c (struct displaced_step_inferior_state): Move to
13684 infrun.h.
13685 (displaced_step_inferior_states): Remove.
13686 (get_displaced_stepping_state): Adust.
13687 (displaced_step_in_progress_any_inferior): Adjust.
13688 (displaced_step_in_progress_thread): Adjust.
13689 (displaced_step_in_progress): Adjust.
13690 (add_displaced_stepping_state): Remove.
13691 (get_displaced_step_closure_by_addr): Adjust.
13692 (remove_displaced_stepping_state): Remove.
13693 (infrun_inferior_exit): Call displaced_step_state.reset.
13694 (use_displaced_stepping): Don't check for NULL.
13695 (displaced_step_prepare_throw): Call
13696 get_displaced_stepping_state.
13697 (displaced_step_fixup): Don't check for NULL.
13698 (prepare_for_detach): Don't check for NULL.
13699
e3319240
PW
137002019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13701
13702 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13703 in case of call that did not complete.
13704
5d36dfb9
AU
137052019-01-02 Andrey Utkin <autkin@undo.io>
13706
13707 * symfile.c (find_separate_debug_file): Fix search of debug files for
13708 remote debuggee.
13709
8833fbf0
TT
137102019-01-02 Tom Tromey <tom@tromey.com>
13711
13712 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13713 indentation.
13714 * python/py-frame.c (frapy_older): Remove cast.
13715 (frapy_newer): Likewise.
13716 * python/py-breakpoint.c (local_setattro): Remove cast.
13717 * python/py-arch.c (archpy_name): Remove local variable.
13718 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13719
4ada3dfd
JB
137202019-01-02 Joel Brobecker <brobecker@adacore.com>
13721
13722 * unittests/basic_string_view/element_access/char/empty.cc:
13723 Fix year range in copyright header.
13724
113b7b81
AB
137252019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13726
13727 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13728 Delete.
13729 <operator==>: Update with for removed field.
13730 <hash>: Likewise.
13731 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13732 <isa_features>: ...this.
13733 <abi_features>: New field.
13734 (riscv_isa_flen): Update comment.
13735 (riscv_abi_xlen): New declaration.
13736 (riscv_abi_flen): New declaration.
13737 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13738 isa_features.
13739 (riscv_abi_xlen): New function.
13740 (riscv_isa_flen): Update to get answer from isa_features.
13741 (riscv_abi_flen): New function.
13742 (riscv_has_fp_abi): Update to get answer from abi_features.
13743 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13744 xlen and flen.
13745 (riscv_call_info) <xlen, flen>: Update comment.
13746 (riscv_call_arg_struct): Remove invalid assertions
13747 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13748 is removed.
13749 (riscv_gdbarch_init): Gather isa features and abi features
13750 separately, ensure both match on the gdbarch when reusing an old
13751 gdbarch. Relax an error check to allow 32-bit abi float to run on
13752 a target with 64-bit float hardware.
13753
b18ca514
PW
137542019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13755
13756 * source.c (search_command_helper): Stop reverse search
13757 when line 1 has been searched.
13758
ec70d8db
PW
137592019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13760
13761 * record-full.c (record_full_base_target::close): Rewrite
13762 record_full_core_buf_list free logic.
13763
5b38f9c1
PW
137642019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13765
13766 * break-catch-syscall.c (print_one_catch_syscall): xfree
13767 the last text.
13768
66d91b39
JB
137692019-01-01 Joel Brobecker <brobecker@adacore.com>
13770
13771 * top.c (print_gdb_version): Update Copyright year in version
13772 message.
13773
42a4f53d
JB
137742019-01-01 Joel Brobecker <brobecker@adacore.com>
13775
13776 Update copyright year range in all GDB files.
13777
7e955d83 137782019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 13779
5bbd631d 13780 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 13781
5bbd631d 13782For older changes see ChangeLog-2018.
c906108c
SS
13783\f
13784Local Variables:
13785mode: change-log
13786left-margin: 8
13787fill-column: 74
13788version-control: never
57da7796 13789coding: utf-8
c906108c 13790End:
5bbd631d 13791
This page took 2.942369 seconds and 4 git commands to generate.